transportUmbrella
ActivePublic

Recent Activity

Mar 9 2018

sbruno closed D14540: Several LRO fixes.
Mar 9 2018, 12:08 AM · transport

Mar 8 2018

gallatin accepted D14540: Several LRO fixes.
Mar 8 2018, 7:11 PM · transport
sbruno accepted D14540: Several LRO fixes.

I'll grab this and shovel it in after builds are done.

Mar 8 2018, 6:25 PM · transport
jason_eggnet.com added inline comments to D14540: Several LRO fixes.
Mar 8 2018, 5:36 PM · transport
rstone added inline comments to D14540: Several LRO fixes.
Mar 8 2018, 4:28 PM · transport
rstone accepted D14540: Several LRO fixes.
Mar 8 2018, 2:34 PM · transport
kbowling updated the diff for D14540: Several LRO fixes.

Fix comment per rstone and jegg

Mar 8 2018, 7:56 AM · transport

Mar 7 2018

jason_eggnet.com added inline comments to D14540: Several LRO fixes.
Mar 7 2018, 11:13 PM · transport
rstone accepted D14540: Several LRO fixes.

I've written some unit tests that covering these cases here:

Mar 7 2018, 10:32 PM · transport
kbowling created D14540: Several LRO fixes.
Mar 7 2018, 4:42 PM · transport

Dec 17 2017

tuexen added a member for transport: tuexen.
Dec 17 2017, 7:24 PM

Aug 29 2017

kmacy abandoned D4490: inpcb rtentry/l2 prepend caching.
Aug 29 2017, 12:25 AM · transport

Aug 25 2017

sbruno closed D12003: Use counter(9) for PLPMTUD counters by committing rS322900: Use counter(9) for PLPMTUD counters..
Aug 25 2017, 7:42 PM · transport

Aug 15 2017

mjoras added a member for transport: mjoras.
Aug 15 2017, 4:52 PM

Aug 14 2017

kbowling added a comment to D12003: Use counter(9) for PLPMTUD counters.

Noob question, should freebsdversion bump since this alters the ABI?

Aug 14 2017, 8:45 PM · transport
kbowling updated the diff for D12003: Use counter(9) for PLPMTUD counters.

Use the libxo plurals and fix the pmtud-failed label

Aug 14 2017, 6:54 PM · transport
jtl accepted D12003: Use counter(9) for PLPMTUD counters.

Looks good (with one minor nit inline).

Aug 14 2017, 1:08 PM · transport
kbowling updated the diff for D12003: Use counter(9) for PLPMTUD counters.
Aug 14 2017, 6:17 AM · transport

Aug 12 2017

kbowling created D12003: Use counter(9) for PLPMTUD counters.
Aug 12 2017, 5:32 AM · transport

Oct 14 2016

pkelsey added a member for transport: pkelsey.
Oct 14 2016, 2:04 AM

Oct 4 2016

hiren updated subscribers of D4366: convert tcp timestamps to scaled sbintime.
Oct 4 2016, 12:46 AM · transport
hiren added a reviewer for D4366: convert tcp timestamps to scaled sbintime: rrs.
Oct 4 2016, 12:45 AM · transport

Jul 26 2016

jonlooney_gmail.com removed a member for transport: jonlooney_gmail.com.
Jul 26 2016, 2:41 PM

Jun 27 2016

novice_techie.com added a watcher for transport: novice_techie.com.
Jun 27 2016, 12:46 PM

Jun 3 2016

ae added a member for transport: ae.
Jun 3 2016, 8:23 AM

May 11 2016

rrs added a comment to D4294: modernize TCP constants.

Is TCPTV_DELACK (hz/25) 40 ms, or is it 40 ms only when HZ is 1000?

May 11 2016, 9:03 AM · transport

May 5 2016

gnn added reviewers for D4294: modernize TCP constants: gnn, transport.
May 5 2016, 4:26 PM · transport

Apr 18 2016

kmacy added a comment to D4295: Add driver backpressure.

Does ixgbe compile with the first parenthesis missing?

Apr 18 2016, 5:58 PM · transport
cramerj_intel.com added a comment to D4295: Add driver backpressure.

Does ixgbe compile with the first parenthesis missing?

Apr 18 2016, 5:53 PM · transport

Apr 5 2016

eadler removed a member for transport: eadler.
Apr 5 2016, 3:00 AM

Mar 24 2016

gnn closed D4306: Re-add route caching for TCP by committing rS297225: FreeBSD previously provided route caching for TCP (and UDP). Re-add.
Mar 24 2016, 7:55 AM · transport
gnn accepted D4306: Re-add route caching for TCP.
Mar 24 2016, 7:51 AM · transport
gnn added a comment to D4306: Re-add route caching for TCP.

Having applied this to HEAD I find that with the following test:

Mar 24 2016, 7:51 AM · transport
gnn added a comment to D4306: Re-add route caching for TCP.

I'll give this a benchmark in the Sentex lab.

Mar 24 2016, 6:24 AM · transport
olivier added a comment to D4306: Re-add route caching for TCP.
In D4306#121368, @mike-karels.net wrote:

This change does not affect forwarding, just TCP and UDP termination. It makes the most difference when TSO is not enabled.

Mar 24 2016, 6:19 AM · transport

Mar 19 2016

karels added a comment to D4306: Re-add route caching for TCP.

This change does not affect forwarding, just TCP and UDP termination. It makes the most difference when TSO is not enabled.

Mar 19 2016, 1:14 PM · transport
olivier added a comment to D4306: Re-add route caching for TCP.

In my standard forwarding scenario (2 static routes), I didn't see improvement neither regression with this patch (about -1% with pf or ipfw):

Mar 19 2016, 11:17 AM · transport

Mar 18 2016

karels updated the diff for D4306: Re-add route caching for TCP.

Fix user-level include of in_pcb.h
rt_gen_t was in an ifdef _KERNEL

Mar 18 2016, 1:24 AM · transport
karels added a comment to D4306: Re-add route caching for TCP.

Argh, I see what I did. I ended up with the wrong version of route.h in /usr/include.

Mar 18 2016, 1:17 AM · transport

Mar 16 2016

olivier added a comment to D4306: Re-add route caching for TCP.

I've sync my -head source to 296935, then applyed this patch without problem, but buildworld failed:

Mar 16 2016, 2:32 PM · transport
gnn added a reviewer for D4306: Re-add route caching for TCP: olivier.
Mar 16 2016, 8:02 AM · transport
gnn added a comment to D4306: Re-add route caching for TCP.

I've added Olivier as a reviewer because I'm hoping he'll test this patch and give us some updated performance numbers.

Mar 16 2016, 8:02 AM · transport
gnn updated subscribers of D4306: Re-add route caching for TCP.
Mar 16 2016, 8:01 AM · transport

Mar 14 2016

karels updated the diff for D4306: Re-add route caching for TCP.

Update to match head, fix UDP/IPv4 locking
Move definitions to match movement in header files.

Mar 14 2016, 3:02 AM · transport

Mar 9 2016

gnn accepted D4306: Re-add route caching for TCP.

4102 has already gone in. It's time to push this in as well.

Mar 9 2016, 1:49 AM · transport

Feb 15 2016

karels added a comment to D4490: inpcb rtentry/l2 prepend caching.

OK, I missed the malloc/copy in if_ethersubr.c. So there isn't a problem with pointers to freed memory, but the L2 code still has the issue as the routing code with copying the pointers to/from the route structure.

Feb 15 2016, 4:58 PM · transport

Feb 9 2016

kmacy added a comment to D4490: inpcb rtentry/l2 prepend caching.
In D4490#111292, @mike-karels.net wrote:
I'll respond to other parts soon.  But I want to correct this:

> About L2 caching: this approach is very wrong. Caching a pointer and length to the L2 header allows no way to validate or invalidate the cache. What happens when the L2 entry times out and is deleted?

I invalidate all cached context. See if_llatbl.c.

This is not effective. Consider the following:

Thread A checks the routing generation number in ip_output. Thread B then increments the generation count of all the routing tables (the bigger hammer approach!)

Feb 9 2016, 5:32 AM · transport
karels added a comment to D4490: inpcb rtentry/l2 prepend caching.
I'll respond to other parts soon.  But I want to correct this:
Feb 9 2016, 2:42 AM · transport

Feb 7 2016

kmacy added a comment to D4490: inpcb rtentry/l2 prepend caching.
In D4490#111105, @mike-karels.net wrote:

About L3 caching:

I think my approach, including a "struct route" in the in_pcb, is both simpler and more correct.

I dislike building a "struct route" on the stack and then moving fields to and from that structure from the pcb. I think it is wrong to compare the route using the in_pcb destination address, as that may have changed (e.g. in the UDP case). The struct route contains the previously-looked-up destination, which is necessary.

Feb 7 2016, 9:37 PM · transport
karels added a comment to D4490: inpcb rtentry/l2 prepend caching.

About L3 caching:

Feb 7 2016, 8:16 PM · transport