- User Since
- Oct 29 2015, 5:25 PM (158 w, 6 d)
Fri, Nov 9
Yeah, I saw this shortly before seeing this review. I agree we should fix it.
Thu, Nov 8
If alignment is important, we can (theoretically) do something more intelligent to maintain it. However, I think this is both safe and good enough for an emergency fix.
Fri, Nov 2
Thu, Oct 18
Tue, Oct 16
Fix stupid syntax error.
Oct 16 2018
Oct 13 2018
Please make the two changes suggested by bz@ and then feel free to commit this. I think its OK to ask re@ to commit this during the freeze. (I also won't be upset if they say "no".)
Oct 12 2018
Oct 11 2018
Oct 10 2018
The other half of the original diff is now in D17503.
Split the commit into two parts. In this part, just fix the early epoch calls.
Oct 9 2018
Oct 6 2018
Oct 5 2018
FYI, it looks like there was a typo in the description:
Oct 4 2018
Looks good. Please commit with "Approved: jtl (mentor)".
Sep 8 2018
Hi. I know I'm late to the party, but I have three comments:
a) I could be wrong, but I don't think there is any guarantee this won't be called simultaneously for two different groups at the same time. (The groups could be in different VNETs, for example.) In that case, two different invocations could be working on the function's static variables at the same time. That may produce unexpected results. (Granted, it would take an unusual series of events. But, I think we've all seen highly unusual events occur.)
b) I don't think the const variable also needs to be static.
c) It seems like the rate limiter should really be per-group, so I would suggest adding the lastprint variable to the inpcblbgroup struct.
Aug 23 2018
FYI, something didn't look right doing my tests. So, I'm going to delay committing this until I can satisfy myself that it behaves correctly. That will almost certainly mean I miss the code freeze. C'est la vie!
- Limit the ipq structure to the kernel to eliminate a buildworld failure. (And, why should we make userspace code import the sys/queue.h header for a structure they don't need anyway?)
- Address @jhb's nit.
Aug 22 2018
Aug 21 2018
Aug 18 2018
LGTM (with minor change noted in-line).
Aug 14 2018
Aug 6 2018
Jul 28 2018
Jul 27 2018
Jul 25 2018
Jul 24 2018
Never mind. It looks like this is a display issue, and you really are deleting them.
It looks like you're keeping the code by moving it to the modules directory? At this point, I think it just makes sense to delete it.
Jun 18 2018
Jun 15 2018
I've spent some time thinking about this a bit, and I have the following comments. (Some may seem contradictory, but please bear with me. :-) )
Jun 14 2018
Jun 13 2018
Address @markj's feedback by always defining the vmd_kernel_rwx_arena member of the vm_domain struct.
Jun 12 2018
Update the zone(9) manpage.
Jun 11 2018
Okay, really without the cruft this time. (Hopefully...)