- User Since
- Oct 29 2015, 5:25 PM (300 w, 4 d)
Jun 17 2021
May 20 2021
Apr 12 2021
Apr 1 2021
Thanks for doing this! It looks like a very positive change, and I'm sure there was a lot of effort put into finding the right way to clean up the code.
Thanks for doing this so quickly!
Mar 31 2021
FWIW, I disagree with this change. I think we should instead use atomic operations here.
Mar 12 2021
This is the change I am planning to commit once the regression tests finish running.
Mar 11 2021
Jan 14 2021
Dec 4 2020
This does not fix the regression I am experiencing in my test setup. I am testing with a machine which uses a LAGG interface to communicate with the outside world. Shutting this interface down still makes my SSH sessions hang.
Dec 3 2020
I just saw the discussion on the committers mailing list. First, it shows that @cy already has a proposed fix. Secondly, it shows that this is a larger issue (for example, netboot), which probably needs a different solution.
Nov 20 2020
Nov 17 2020
Updating the diff to include context.
While here, update the code in ctf_add_generic() to encode empty type names with index 0. This fixes the analogous case for type names.
Nov 16 2020
Nov 14 2020
Nov 13 2020
Nov 11 2020
Nov 10 2020
Nov 6 2020
Nov 5 2020
In general, this looks good. I have a small nit in that it seems like it would be worth considering whether it would be better to add the flag to the socket itself somehow so it could be synchronized by the socket lock. On the offchance someone did a socket operation which caused a wakeup while the TCP code was running, it seems possible that this might avoid a spurious wakeup. However, given the code in the src tree, I find it hard to reason through how this could occur.
Nov 4 2020
Apr 23 2020
Apr 20 2020
With the change I made to keep the current behavior for everything except swap (which is fairly well tested), are there additional concerns?
Apr 18 2020
Apr 17 2020
I was able to replicate it locally using llvm's c++ 9.0.1 and defining _WANT_SOCKET prior to including the header file:
Can you provide some more information on the exact error you saw? I'm 99.9% sure we successfully compiled these sources with LLVM 9.
Apr 16 2020
Apr 14 2020
Apr 13 2020
Address comments by @jhb:
- Delete the code to declare the GELI threads as kernel FPU threads. (I'll open a separate review for that.)
- Switch the default to blocking mallocs for everything except swap requests.
Rebase onto D24272.
Correct typo in the man page. (Thanks @bcr!)
Make the overflow rate-limit be controlled by a sysctl.
I'm going to do a tinderbox build of this + D24316 (mostly, to make sure I didn't mess up the various INET/INET6 combinations) and then commit them.
Apr 9 2020
Thanks for providing the extra context on the transport call today. Overall, this change looks good. I left a few nits in in-line comments.
As discussed on the transport call today, please change both the in order and out of order data path so we call sorwakeup_locked() (when necessary) after the SACK blocks are updated.
Apr 6 2020
Switch to using sbuf(9) for string creation. Also, use a constant string for "local:".
Apr 3 2020
FWIW, these are examples of the messages this produces:
Apr 3 19:58:34 c006 kernel: sonewconn: pcb 0xfffff805a566a200 (127.0.0.1:65432 (proto 6)): Listen queue overflow: 4 already in queue awaiting acceptance (1 occurrences) Apr 3 19:59:44 c006 kernel: sonewconn: pcb 0xfffff80611de4000 ([::1]:65432 (proto 6)): Listen queue overflow: 4 already in queue awaiting acceptance (2 occurrences) Apr 3 20:16:12 c006 kernel: sonewconn: pcb 0xfffff80170cde100 (local:/tmp/testsock): Listen queue overflow: 4 already in queue awaiting acceptance (1 occurrences)
Mar 12 2020
Mar 9 2020
Feb 27 2020
Feb 10 2020
Feb 7 2020
Feb 6 2020
Feb 5 2020
Oct 24 2019
@bz will commit.
Basically commited by @bz .