tcp: fix cleanup when in_pcbconnect() fails in syncache_socket()
ClosedPublic
Actions

Authored by tuexen on Jun 26 2024, 7:16 PM.

Details

Reviewers

jtl
rrs
glebius
rscheff
peter.lei_ieee.org
lstewart

Group Reviewers

transport

Commits

rG5632dd45cc10: tcp: improve error handling in syncache_socket()
rG3703e1a73e0e: tcp: improve error handling in syncache_socket()

Summary

If syncache_socket() fails after calling tcp_newtcpcb(), the resources allocated during
tcp_newtcpcb() needs to be freed. Just call tcp_discardcb() to do this.

Thanks to jtl for making me aware of the issue and proposing a fix.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Jun 26 2024, 7:16 PM

Herald added a reviewer: transport. · View Herald TranscriptJun 26 2024, 7:16 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Jun 26 2024, 7:16 PM

tuexen added a reviewer: peter.lei_ieee.org.Jun 26 2024, 7:20 PM

jtl accepted this revision.Jun 26 2024, 7:24 PM

This revision is now accepted and ready to land.Jun 26 2024, 7:24 PM

tuexen added a reviewer: lstewart.Jun 26 2024, 8:23 PM

rscheff accepted this revision.Jun 27 2024, 3:13 PM

glebius accepted this revision.Jun 27 2024, 3:18 PM

Closed by commit rG3703e1a73e0e: tcp: improve error handling in syncache_socket() (authored by tuexen). · Explain WhyJun 27 2024, 4:25 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rG3703e1a73e0e: tcp: improve error handling in syncache_socket().

tuexen added a commit: rG5632dd45cc10: tcp: improve error handling in syncache_socket().Aug 3 2024, 10:50 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_syncache.c

1 line

Diff 140309

View Options

sys/netinet/tcp_syncache.c

tcp: fix cleanup when in_pcbconnect() fails in syncache_socket()ClosedPublicActions