Page MenuHomeFreeBSD
Differential D45749

tcp: fix cleanup when in_pcbconnect() fails in syncache_socket()
ClosedPublic
Actions

Authored by tuexen on Jun 26 2024, 7:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 18, 6:52 AM
Unknown Object (File)
Sun, Nov 16, 11:54 AM
Unknown Object (File)
Sat, Nov 15, 6:26 AM
Unknown Object (File)
Thu, Nov 6, 6:50 AM
Unknown Object (File)
Wed, Nov 5, 6:53 AM
Unknown Object (File)
Tue, Nov 4, 8:10 AM
Unknown Object (File)
Tue, Nov 4, 7:17 AM
Unknown Object (File)
Tue, Nov 4, 5:19 AM
View All Files
Subscribers
imp
melifaro

Details

Reviewers
jtl
rrs
glebius
rscheff
peter.lei_ieee.org
lstewart
Group Reviewers
transport
Commits
rG5632dd45cc10: tcp: improve error handling in syncache_socket()
rG3703e1a73e0e: tcp: improve error handling in syncache_socket()
Summary

If syncache_socket() fails after calling tcp_newtcpcb(), the resources allocated during
tcp_newtcpcb() needs to be freed. Just call tcp_discardcb() to do this.

Thanks to jtl for making me aware of the issue and proposing a fix.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
netinet/
1 line

Diff 140309

View Options

sys/netinet/tcp_syncache.c

Loading...