Page MenuHomeFreeBSD

rscheff (Richard Scheffenegger)
User

Projects

User Details

User Since
Oct 18 2018, 9:44 PM (186 w, 3 d)

Recent Activity

Apr 13 2022

rscheff committed R10:033718abc859: tcp: Whitespace cleanup in brr and rack (authored by rscheff).
tcp: Whitespace cleanup in brr and rack
Apr 13 2022, 1:31 PM
rscheff closed D30043: tcp: Whitespace cleanup in brr and rack.
Apr 13 2022, 1:31 PM

Apr 7 2022

rscheff accepted D34672: siftr: expose t_flags2 in siftr output.
Apr 7 2022, 7:15 AM

Feb 26 2022

rscheff updated the diff for D30043: tcp: Whitespace cleanup in brr and rack.
  • cleaning up forward declarations
Feb 26 2022, 3:00 PM
rscheff updated the diff for D30043: tcp: Whitespace cleanup in brr and rack.
  • update whitespace fixes
Feb 26 2022, 2:57 PM

Feb 25 2022

rscheff committed R10:407c34e735b5: iscsi: retrieve global login timeout from sysctlbyname() as integer (authored by rscheff).
iscsi: retrieve global login timeout from sysctlbyname() as integer
Feb 25 2022, 8:00 PM
rscheff closed D34380: iscsi: retrieve global login timeout from sysctlbyname() as integer.
Feb 25 2022, 8:00 PM
rscheff requested review of D34380: iscsi: retrieve global login timeout from sysctlbyname() as integer.
Feb 25 2022, 7:56 PM
rscheff committed R10:2ff07d9220a0: tcp: Restore correct ECT marking behavior on SACK retransmissions (authored by rscheff).
tcp: Restore correct ECT marking behavior on SACK retransmissions
Feb 25 2022, 7:08 PM
rscheff closed D34376: tcp: Restore correct ECT marking behavior on SACK retransmissions.
Feb 25 2022, 7:08 PM
rscheff added inline comments to D23230: Implement ECN++ (draft-generalized-ecn).
Feb 25 2022, 5:13 PM
rscheff requested review of D34376: tcp: Restore correct ECT marking behavior on SACK retransmissions.
Feb 25 2022, 3:51 PM
rscheff updated the diff for D23230: Implement ECN++ (draft-generalized-ecn).
  • rebase
  • simplify the fastpath check if ECT should be set.
  • streamline fastpath check
  • update man date
  • have to explicitly check for ECN SYN
  • add TF2_ECN_PLUSPLUS flag to reduce cacheline churn in fastpath when checking V_ecn_generalized
  • bump tcp.4 datestamp
  • fix man page typos
  • fix typo in man page
  • update to use the common tcp_ecn.c sourcefile
  • fix types
Feb 25 2022, 1:08 PM
rscheff updated the diff for D34230: iscsi: send only 3 iscsi_pings in the timeout interval.
  • use the correct timeout value in log output
Feb 25 2022, 11:10 AM
rscheff committed R10:bd6bb4939714: iscsi: per-session timeouts and rapid teardown of session on reconnect (authored by rscheff).
iscsi: per-session timeouts and rapid teardown of session on reconnect
Feb 25 2022, 10:03 AM
rscheff closed D34198: iSCSI: per-session timeouts and rapid teardown of session on reconnect.
Feb 25 2022, 10:03 AM
rscheff added inline comments to D34198: iSCSI: per-session timeouts and rapid teardown of session on reconnect.
Feb 25 2022, 9:33 AM

Feb 22 2022

rscheff accepted D34332: tcp: Push bit failure to set in fastpath.

Possibly - probably missed this over my iterations. Thanks!

Feb 22 2022, 10:20 PM

Feb 21 2022

rscheff requested changes to D34332: tcp: Push bit failure to set in fastpath.

Sorry for the oversight.

Feb 21 2022, 6:02 PM

Feb 15 2022

rscheff updated the diff for D34198: iSCSI: per-session timeouts and rapid teardown of session on reconnect.
  • fix panic with NULL socket
  • update man timestamp
  • don't forget on is_login_timeout
Feb 15 2022, 7:09 PM
rscheff added a comment to D34230: iscsi: send only 3 iscsi_pings in the timeout interval.

I didn't want to modify the iscsi_callout() function completely. I guess the current design was picked to keep the housekeeping overhead low. Splitting iscsi_callout into a iscsid timeout, login timeout and ping hello function is certainly possible.

Feb 15 2022, 5:59 PM
rscheff committed R10:972a7d95ebfa: iscsi: Use calloutng instead of ticks in iscsi initiator (authored by rscheff).
iscsi: Use calloutng instead of ticks in iscsi initiator
Feb 15 2022, 5:44 PM
rscheff closed D34222: iscsi: Use calloutng instead of ticks in iscsi initiator.
Feb 15 2022, 5:44 PM
rscheff added a comment to D34230: iscsi: send only 3 iscsi_pings in the timeout interval.
In D34230#775828, @jhb wrote:

(I think this diff contains the prior change as well?) I would also suggest mstosbt() here as well.

Feb 15 2022, 8:52 AM
rscheff updated the diff for D34230: iscsi: send only 3 iscsi_pings in the timeout interval.
  • use mstosbt()
Feb 15 2022, 8:49 AM
rscheff committed R10:0c2832ee4f2d: tcp: Restore 6 tcps padding entries in HEAD (authored by rscheff).
tcp: Restore 6 tcps padding entries in HEAD
Feb 15 2022, 8:49 AM
rscheff closed D34269: tcp: Restore 6 tcps padding entries in HEAD.
Feb 15 2022, 8:48 AM
rscheff added inline comments to D34222: iscsi: Use calloutng instead of ticks in iscsi initiator.
Feb 15 2022, 8:40 AM
rscheff updated the diff for D34222: iscsi: Use calloutng instead of ticks in iscsi initiator.
  • make use of mstosbt()
Feb 15 2022, 8:39 AM

Feb 14 2022

rscheff requested review of D34269: tcp: Restore 6 tcps padding entries in HEAD.
Feb 14 2022, 9:25 PM

Feb 13 2022

rscheff closed D34223: iscsi: address unused-but-set-variable warning.
Feb 13 2022, 8:27 AM
rscheff committed R10:70e9f880d88e: iscsi: address unused-but-set-variable warning (authored by rscheff).
iscsi: address unused-but-set-variable warning
Feb 13 2022, 8:27 AM

Feb 12 2022

rscheff added reviewers for D34223: iscsi: address unused-but-set-variable warning: kbowling, hselasky, imp.

Any objections to getting rid of this recent compiler warning?

Feb 12 2022, 12:46 AM

Feb 11 2022

rscheff updated the diff for D21011: Functional implementation of Accurate ECN in FreeBSD.
  • rename variables to match convention
Feb 11 2022, 12:16 PM
rscheff updated the summary of D21011: Functional implementation of Accurate ECN in FreeBSD.
Feb 11 2022, 11:34 AM

Feb 10 2022

rscheff updated the diff for D21011: Functional implementation of Accurate ECN in FreeBSD.
  • manual rebase to main
Feb 10 2022, 8:33 PM
rscheff accepted D34242: tcp: Avoid conditionally defined fields in union lro_address.

lgtm

Feb 10 2022, 6:50 PM
rscheff closed D34161: Add/update AccECN related statistics and numbers.
Feb 10 2022, 4:35 PM
rscheff committed R10:3f169c54ab8e: tcp: Add/update AccECN related statistics and numbers (authored by rscheff).
tcp: Add/update AccECN related statistics and numbers
Feb 10 2022, 4:35 PM
rscheff updated the diff for D34161: Add/update AccECN related statistics and numbers.
  • rebase to main
Feb 10 2022, 2:26 PM

Feb 9 2022

rscheff added inline comments to D34198: iSCSI: per-session timeouts and rapid teardown of session on reconnect.
Feb 9 2022, 7:45 PM
rscheff accepted D34139: tcpsso, a tool to set socket options for TCP endpoints via the command line.
Feb 9 2022, 2:20 PM
rscheff requested review of D34230: iscsi: send only 3 iscsi_pings in the timeout interval.
Feb 9 2022, 11:55 AM
rscheff requested review of D34223: iscsi: address unused-but-set-variable warning.
Feb 9 2022, 11:03 AM
rscheff updated the diff for D34222: iscsi: Use calloutng instead of ticks in iscsi initiator.
  • make the call centered around the 1 sec mark
Feb 9 2022, 10:53 AM
rscheff requested review of D34222: iscsi: Use calloutng instead of ticks in iscsi initiator.
Feb 9 2022, 10:46 AM
rscheff accepted D34217: TCP syncache: enhance some KASSERT output.
Feb 9 2022, 7:10 AM

Feb 8 2022

rscheff added a comment to D34205: cleanup of rack variables.

the cleanup of the debug/troubleshooting/dev variable looks largely fine to me.

Feb 8 2022, 4:15 PM
rscheff added inline comments to D34198: iSCSI: per-session timeouts and rapid teardown of session on reconnect.
Feb 8 2022, 1:42 PM
rscheff updated the diff for D34198: iSCSI: per-session timeouts and rapid teardown of session on reconnect.
  • fix panic with NULL socket
  • directly access isc_ struct instead of handoff
  • update manual entry to reference sysctls
  • nicify outputs to match .conf token
Feb 8 2022, 1:40 PM
rscheff requested review of D34198: iSCSI: per-session timeouts and rapid teardown of session on reconnect.
Feb 8 2022, 8:41 AM
rscheff added inline comments to D21011: Functional implementation of Accurate ECN in FreeBSD.
Feb 8 2022, 7:32 AM
rscheff updated the diff for D21011: Functional implementation of Accurate ECN in FreeBSD.
  • improve man wording
Feb 8 2022, 7:32 AM

Feb 7 2022

rscheff closed D34180: update tcp flags after ECN processing in rack_fast_output.
Feb 7 2022, 1:34 PM
rscheff committed R10:ab001fcdf22d: tcp: Apply tcp flags after ECN processing in rack_fast_output() (authored by rscheff).
tcp: Apply tcp flags after ECN processing in rack_fast_output()
Feb 7 2022, 1:33 PM
rscheff updated the diff for D21011: Functional implementation of Accurate ECN in FreeBSD.
  • cleaning up a set of KMOD_ macros, and nicifying source code
Feb 7 2022, 8:20 AM

Feb 6 2022

rscheff updated the diff for D21011: Functional implementation of Accurate ECN in FreeBSD.
  • manual rebase to main
Feb 6 2022, 2:46 PM
rscheff updated the diff for D34161: Add/update AccECN related statistics and numbers.
  • rebase to main, set flags in rsm_fast_output after ecn changes
Feb 6 2022, 8:50 AM

Feb 5 2022

rscheff committed R10:1790549d801f: tcp: use TCPSTAT_INC in kernel ecn functions (authored by rscheff).
tcp: use TCPSTAT_INC in kernel ecn functions
Feb 5 2022, 3:56 PM
rscheff closed D34181: change KMOD_TCPSTAT_INC to TCPSTAT_INC in kernel ecn functions.
Feb 5 2022, 3:55 PM
rscheff requested review of D34181: change KMOD_TCPSTAT_INC to TCPSTAT_INC in kernel ecn functions.
Feb 5 2022, 3:36 PM
rscheff requested review of D34180: update tcp flags after ECN processing in rack_fast_output.
Feb 5 2022, 3:31 PM
rscheff closed D34162: All ECN handling code in a common source file.
Feb 5 2022, 3:13 PM
rscheff accepted D34162: All ECN handling code in a common source file.
Feb 5 2022, 3:13 PM
rscheff closed D34178: fix oversight in commit 0c424c90eaa6602e07bca7836b1d178b91f2a88a.
Feb 5 2022, 3:12 PM
rscheff accepted D34178: fix oversight in commit 0c424c90eaa6602e07bca7836b1d178b91f2a88a.
Feb 5 2022, 3:12 PM
rscheff added a comment to D34178: fix oversight in commit 0c424c90eaa6602e07bca7836b1d178b91f2a88a.

fixed with 2nd commit of D34162

Feb 5 2022, 3:10 PM
rscheff committed R10:f7220c486c1b: tcp: move ECN handling code to a common file (authored by rscheff).
tcp: move ECN handling code to a common file
Feb 5 2022, 2:06 PM
rscheff updated the diff for D34162: All ECN handling code in a common source file.
  • move tcp_set_flag aft the added setting of the ECN flags
  • remove #include from tcp_ecn.h
  • shuffle #include around, so that tcp_ecn.h doesn't need any
  • restore #include in tcp_ecn.h
Feb 5 2022, 1:57 PM
rscheff added inline comments to D34162: All ECN handling code in a common source file.
Feb 5 2022, 10:41 AM
rscheff updated the diff for D34162: All ECN handling code in a common source file.
  • restore diff after revert in main
  • fix type of flag variable in rack.c
Feb 5 2022, 10:37 AM
rscheff added a reverting change for R10:0c424c90eaa6: tcp: move ECN handling code to a common file: R10:7994ef3c394d: Revert "tcp: move ECN handling code to a common file".
Feb 5 2022, 2:29 AM
rscheff committed R10:7994ef3c394d: Revert "tcp: move ECN handling code to a common file" (authored by rscheff).
Revert "tcp: move ECN handling code to a common file"
Feb 5 2022, 2:29 AM
rscheff added a reverting change for D34162: All ECN handling code in a common source file: R10:7994ef3c394d: Revert "tcp: move ECN handling code to a common file".
Feb 5 2022, 2:29 AM
rscheff requested review of D34178: fix oversight in commit 0c424c90eaa6602e07bca7836b1d178b91f2a88a.
Feb 5 2022, 1:51 AM
rscheff updated the diff for D34161: Add/update AccECN related statistics and numbers.
  • rebase to main
  • set flags in rack_fsm_fast_output after ecn changes
Feb 5 2022, 1:38 AM
rscheff committed R10:0c424c90eaa6: tcp: move ECN handling code to a common file (authored by rscheff).
tcp: move ECN handling code to a common file
Feb 5 2022, 12:16 AM

Feb 4 2022

rscheff added a comment to D32540: iSCSI: Fast and per-session timeouts.
In D32540#773132, @imp wrote:

deciseconds are too weird. We should really specify them in terms of ms, even if internally we round that to 100ms increments.I'd hate to see that get established as the user interface and not be able to change it later.

Feb 4 2022, 11:30 PM
rscheff added a comment to D32540: iSCSI: Fast and per-session timeouts.
In D32540#773132, @imp wrote:

deciseconds are too weird. We should really specify them in terms of ms, even if internally we round that to 100ms increments.I'd hate to see that get established as the user interface and not be able to change it later.

Feb 4 2022, 11:25 PM
rscheff added a comment to D32540: iSCSI: Fast and per-session timeouts.

In short: I would like to commit this first go with decidec granularity, mostly unchanged external (script) interfaces (.conf, sysctl - well, changes from INT to STR, but the sysctl would not care in a script context). Unless there are strong objections against this current approach.

Feb 4 2022, 11:00 PM
rscheff added a comment to D32540: iSCSI: Fast and per-session timeouts.

I believe I have addressed all the concerns - but keeping the old log format, such that any tools currently interpreting log files do not get confused.

Feb 4 2022, 8:36 PM
rscheff updated the diff for D32540: iSCSI: Fast and per-session timeouts.
  • manual rebase to main
Feb 4 2022, 8:33 PM
rscheff added a reviewer for D32540: iSCSI: Fast and per-session timeouts: jhb.

@jhb - any thoughts on making the timeout of iscsi sessions configurable in deci-seconds? This is to facilitate more rapid tcp reconnections during network disruptions.

Feb 4 2022, 6:09 PM
rscheff added inline comments to D34162: All ECN handling code in a common source file.
Feb 4 2022, 3:06 PM
rscheff updated the diff for D34162: All ECN handling code in a common source file.
  • add ECN handling in the 3rd output path.
Feb 4 2022, 2:55 PM

Feb 3 2022

rscheff added a comment to D34138: sysctl interface to set socket options for TCP endpoints.

I see that you can set socket options wildcard style across all currently existing sockets.

tcpsso can perform such a loop, but not the code in the kernel.

Feb 3 2022, 11:14 PM
rscheff accepted D34164: Make tcp_ctloutput_set() non-static.

mostly mechanical changes, look good to me...

Feb 3 2022, 11:10 PM
rscheff updated the diff for D34162: All ECN handling code in a common source file.
  • clean commit against main, for ease of review
Feb 3 2022, 9:40 PM
rscheff requested review of D34162: All ECN handling code in a common source file.
Feb 3 2022, 9:32 PM
rscheff requested review of D34161: Add/update AccECN related statistics and numbers.
Feb 3 2022, 8:56 PM
rscheff closed D34160: tcp: fix typo in commit f026275e26d0071ac3dee98526e8b9bcad58f0fa.
Feb 3 2022, 8:32 PM
rscheff committed R10:fd723975ec72: tcp: fix typo in commit f026275e26d0071ac3dee98526e8b9bcad58f0fa (authored by rscheff).
tcp: fix typo in commit f026275e26d0071ac3dee98526e8b9bcad58f0fa
Feb 3 2022, 8:07 PM
rscheff requested review of D34160: tcp: fix typo in commit f026275e26d0071ac3dee98526e8b9bcad58f0fa.
Feb 3 2022, 7:55 PM
rscheff closed D34154: Disallow setting of ECN bits with setsockopt().
Feb 3 2022, 7:12 PM
rscheff committed R10:3b0ee680507a: tcp: Prevent setting of ECN bits with setsockopt() (authored by rscheff).
tcp: Prevent setting of ECN bits with setsockopt()
Feb 3 2022, 7:12 PM
rscheff added inline comments to D34154: Disallow setting of ECN bits with setsockopt().
Feb 3 2022, 4:53 PM
rscheff updated the diff for D34154: Disallow setting of ECN bits with setsockopt().
  • restore "tos" variable name
Feb 3 2022, 4:43 PM
rscheff updated the diff for D34154: Disallow setting of ECN bits with setsockopt().
  • update the ip.4 man page, to discourage the use of a tos field,
Feb 3 2022, 4:12 PM
rscheff updated the diff for D34154: Disallow setting of ECN bits with setsockopt().
  • only mask out ECN codepoint for TCP, leave other protos unperturbed
  • no need to parse the optval again
Feb 3 2022, 4:01 PM
rscheff closed D34130: Access TCP Header Flags via accessor MACRO.
Feb 3 2022, 3:57 PM