User Details
- User Since
- Oct 18 2018, 9:44 PM (320 w, 4 d)
Sun, Dec 8
Fri, Nov 29
Thu, Nov 28
@kp can you please review the PF-related changes in this Diff?
@kbowling, can you have a look at the intel driver changes and if they seem ok, remove that blocker?
Discussed in todays transport call, since this is not in the hot path of every packet, and the retention of the internal bit might confuse someone later, it was decided to abandon this change.
Tue, Nov 19
Thu, Nov 14
Well, I had the same thought - the full MSS (including options) is less frequently used, that the mss without options...
Wed, Nov 13
- update comment to reflect current checks in the code
- address peter's feedback for rack and bbr
Mon, Nov 11
Seems you inadvertedly removed all reviewers; I added a bunch who probably want to chime in from the transport/ip side. I myself welcome this change - and maybe we should be backporting this to stable/14 and the upcoming release even.... I suspect most public deployments have that tunable toggled already?
Nov 7 2024
Nov 5 2024
Nov 2 2024
Wouldn't it be possible to #define tcp_lro_log in a #else of the first block, such that this scattering of #ifdef's throughout the file could be avoided?
Nov 1 2024
- use accessor in various drivers
Oct 29 2024
Oct 18 2024
Oct 17 2024
- remove unneccesary style and line wrap changes
Oct 16 2024
- implement suggested improvements
Oct 15 2024
- remove unnecessary changes
While I agree that "goto" statements are not nice, and hard to follow - there is something to be said about the overhead of a function preamble, stack use and cleanup. I would suggest to make this an "__inline" function.
Thanks for the thorough review!
- fix typo, remove redundant all-flags definitions
- log TCP flags properly in ppp
- prepare more ipf tools for AccECN
- decode ACE in libipf too
- expand ipf for AccECN compatibility
Oct 14 2024
- missed function definition
- missed function definition
- clean up type and remove superfluous parenthesis
- revert adding support for TH_AE in ppp and pf
Oct 13 2024
- extend the use of accessor function in userspace and pfil
- add TH_AE decoding (identical to tcpdump as "e") as suggested by kp
- moving updating the th_flags further down past the last adjustment
Oct 11 2024
- use userspace accessor function
thanks!
- fix typo after rebase
- rebase main
Oct 9 2024
Oct 7 2024
Oct 3 2024
Oct 1 2024
Sep 30 2024
Sep 29 2024
Sep 28 2024
Sep 22 2024
Sep 19 2024
Sep 18 2024
- rebase to main
Sep 10 2024
Sep 6 2024
Looks good, the intended change is clear to follow and in line with the spirit of RFC9438.
lgtm;
Sep 5 2024
Jul 25 2024
Jul 11 2024
Jun 27 2024
May 16 2024
- remove unused variable
- rebase to main