Page MenuHomeFreeBSD

rscheff (Richard Scheffenegger)
User

Projects

User Details

User Since
Oct 18 2018, 9:44 PM (144 w, 3 d)

Recent Activity

Thu, Jul 22

rscheff added a comment to D31272: Small patch to optionally remove the TCP reassembly max queue length.

Can you explain a bit more about the rationale?

Thu, Jul 22, 11:27 AM

Jun 19 2021

rscheff committed R10:74d7fc8753a7: tcp: Add PRR cwnd reduction for non-SACK loss (authored by rscheff).
tcp: Add PRR cwnd reduction for non-SACK loss
Jun 19 2021, 5:42 PM
rscheff closed D29441: tcp: Add PRR cwnd reduction for non-SACK loss.
Jun 19 2021, 5:42 PM

Jun 16 2021

rscheff abandoned D28574: Add repository callsign to arcanist in docs.

Abandoning, as this doesn't seem to get any traction with maintainers of docs

Jun 16 2021, 9:30 AM
rscheff abandoned D29565: Send FIN bit by itself.
Jun 16 2021, 9:29 AM
rscheff closed D29690: [tcp] Keep socket buffer locked until upcall.

manual close, as commit didn't auto.close

Jun 16 2021, 9:28 AM
rscheff abandoned D30043: tcp: Whitespace cleanup in brr and rack.
Jun 16 2021, 9:26 AM

Jun 11 2021

rscheff accepted D30740: net.inet.tcp.tolerate_missing_ts=1.
Jun 11 2021, 6:32 PM
rscheff added a comment to D30727: tcp: Missing mfree in rack and bbr..

Is this the primary suspect for the mbuf leak issue around the socket upcall() handling?

Jun 11 2021, 5:19 PM
rscheff added inline comments to D30721: New Reno fixes.
Jun 11 2021, 10:33 AM
rscheff added inline comments to D30721: New Reno fixes.
Jun 11 2021, 9:05 AM

Jun 9 2021

rscheff accepted D30704: tcp: Mbuf leak while holding a socket buffer lock .

forget my last comment, I was looking on the wrong side of the screen or whatever. looks good.

Jun 9 2021, 6:58 PM
rscheff added a comment to D30704: tcp: Mbuf leak while holding a socket buffer lock .
Jun 9 2021, 6:56 PM
rscheff committed R10:71b88ee39fc6: tcp: fix a RACK socket buffer lock issue (authored by tuexen).
tcp: fix a RACK socket buffer lock issue
Jun 9 2021, 11:15 AM
rscheff committed R10:55cc0a478506: [tcp] Keep socket buffer locked until upcall (authored by rscheff).
[tcp] Keep socket buffer locked until upcall
Jun 9 2021, 11:14 AM
rscheff committed R10:0230e6cf56eb: rack: honor prior socket buffer lock when doing the upcall (authored by rscheff).
rack: honor prior socket buffer lock when doing the upcall
Jun 9 2021, 11:14 AM

Jun 8 2021

rscheff updated the diff for D29441: tcp: Add PRR cwnd reduction for non-SACK loss.
  • restricting t_dupacks calculations to not overflow
  • restrict further to a static comparison rather a dynamic
Jun 8 2021, 1:02 PM

May 31 2021

rscheff committed R10:11417329c930: tcp: Use local CC data only in the correct context (authored by rscheff).
tcp: Use local CC data only in the correct context
May 31 2021, 8:57 AM
rscheff committed R10:9eed9e5c2dd1: tcp: Use local CC data only in the correct context (authored by rscheff).
tcp: Use local CC data only in the correct context
May 31 2021, 8:57 AM

May 27 2021

rscheff accepted D30497: tcp: When we have an out-of-order FIN we do want to strip off the FIN bit..

lgtm

May 27 2021, 1:51 PM

May 26 2021

rscheff closed D30470: tcp: Use local CC data only in correct context.
May 26 2021, 6:17 PM
rscheff committed R10:c358f1857f0c: tcp: Use local CC data only in the correct context (authored by rscheff).
tcp: Use local CC data only in the correct context
May 26 2021, 6:17 PM
rscheff updated the diff for D30470: tcp: Use local CC data only in correct context.
  • add relevant comment
May 26 2021, 2:45 PM
rscheff requested review of D30470: tcp: Use local CC data only in correct context.
May 26 2021, 2:42 PM

May 25 2021

rscheff accepted D30451: Bugs and problems even in the base stack..

Always this pesky FIN bit in the sequence space... :)

May 25 2021, 12:10 PM

May 21 2021

rscheff closed D30390: rack: honor prior socket buffer lock when doing the upcall.
May 21 2021, 10:17 PM
rscheff committed R10:39756885633f: rack: honor prior socket buffer lock when doing the upcall (authored by rscheff).
rack: honor prior socket buffer lock when doing the upcall
May 21 2021, 10:16 PM
rscheff requested review of D30390: rack: honor prior socket buffer lock when doing the upcall.
May 21 2021, 9:31 PM
rscheff committed R10:032bf749fd44: [tcp] Keep socket buffer locked until upcall (authored by rscheff).
[tcp] Keep socket buffer locked until upcall
May 21 2021, 9:09 AM

May 20 2021

rscheff accepted D30358: Fix sending of TCP segments when IP level options are specified.

discussed in transport call.

May 20 2021, 2:18 PM
rscheff added a comment to D30358: Fix sending of TCP segments when IP level options are specified.

Where are the ip options accounted for, then? Is the mbuf already adjusted to no longer contain ipoptions by that time (not familiar with IP level processing).

May 20 2021, 10:59 AM
rscheff updated the diff for D29690: [tcp] Keep socket buffer locked until upcall.
  • rebase to main
  • remove WAKESOW after major RACK update again
May 20 2021, 10:32 AM

May 10 2021

rscheff committed R10:c55b340f824d: netstat: fix typo from 0471a8c73402 (authored by rscheff).
netstat: fix typo from 0471a8c73402
May 10 2021, 6:50 PM
rscheff committed R10:0471a8c73402: tcp: SACK Lost Retransmission Detection (LRD) (authored by rscheff).
tcp: SACK Lost Retransmission Detection (LRD)
May 10 2021, 5:12 PM
rscheff closed D28931: Basic Lost Retransmission Detection (LRD).
May 10 2021, 5:11 PM
rscheff added a comment to D30183: tzcode: Implement timezone change detection.

On a related note: do the makefiles fetch the current tzinfo files automatically, when building world/universe? (official repository now at https://www.iana.org/time-zones )

May 10 2021, 2:55 PM
rscheff updated the diff for D23230: Implement ECN++ (draft-generalized-ecn).
  • rebase
May 10 2021, 1:39 PM
rscheff updated the diff for D28931: Basic Lost Retransmission Detection (LRD).
  • add statisticts to see when lrd triggered
  • add sockopt TCP_LRD for a/B testing
May 10 2021, 1:25 PM
rscheff updated the diff for D28822: Add PRR 6937bis heuristic and remove prr_conservative sysctl.
  • rebase without D29441
  • make magic values human-readable
May 10 2021, 12:08 PM

May 6 2021

rscheff added a comment to D28822: Add PRR 6937bis heuristic and remove prr_conservative sysctl.

no magic numbers in sack-changed.

May 6 2021, 2:47 PM

May 4 2021

rscheff added inline comments to D30036: Update Rack and BBR to the latest from NF fixing LRO issues along the way..
May 4 2021, 7:16 AM

May 3 2021

rscheff updated subscribers of D30036: Update Rack and BBR to the latest from NF fixing LRO issues along the way..
May 3 2021, 6:06 PM

May 1 2021

rscheff committed R10:bb9dcbf1a243: tcp: stop spurious rescue retransmissions and potential asserts (authored by rscheff).
tcp: stop spurious rescue retransmissions and potential asserts
May 1 2021, 9:04 AM
rscheff added inline comments to D30036: Update Rack and BBR to the latest from NF fixing LRO issues along the way..
May 1 2021, 8:23 AM

Apr 30 2021

rscheff added a comment to D30043: tcp: Whitespace cleanup in brr and rack.

Certainly. While fixing the socket buffer upcall / SACK interaction (29290) the large swath of missing tabs got on me :)

Apr 30 2021, 6:28 PM
rscheff requested review of D30043: tcp: Whitespace cleanup in brr and rack.
Apr 30 2021, 10:12 AM
rscheff updated the diff for D29690: [tcp] Keep socket buffer locked until upcall.
  • remove unlock from tcp_reass() and more logging
Apr 30 2021, 9:10 AM

Apr 28 2021

rscheff committed R10:48be5b976e34: tcp: stop spurious rescue retransmissions and potential asserts (authored by rscheff).
tcp: stop spurious rescue retransmissions and potential asserts
Apr 28 2021, 1:08 PM
rscheff closed D29970: tcp: stop spurious rescue retransmissions.
Apr 28 2021, 1:08 PM

Apr 26 2021

rscheff added a comment to D29992: camcontrol(8): add "smart" command.
In D29992#672920, @mav wrote:

I am not sure how useful it is to report only SMART status. I barely remember any cases when SMART reported actual error. Much more often we start replacing drives preventivelywhen they start reallocating and loose performance.

Apr 26 2021, 3:15 PM

Apr 25 2021

rscheff requested review of D29970: tcp: stop spurious rescue retransmissions.
Apr 25 2021, 11:03 AM

Apr 24 2021

rscheff accepted D29963: tcp: fix man page.
Apr 24 2021, 5:41 PM

Apr 23 2021

rscheff updated the diff for D29690: [tcp] Keep socket buffer locked until upcall.
  • do not bail out of upcall for disconnected socket
  • track each lingering wakeup call
Apr 23 2021, 11:55 AM
rscheff committed R10:ab9104cbe4d5: tcp: Deal with DSACKs, and adjust rescue hole on success. (authored by rscheff).
tcp: Deal with DSACKs, and adjust rescue hole on success.
Apr 23 2021, 7:30 AM
rscheff committed R10:d76eb0da7283: tcp: keep SACK scoreboard sorted when doing rescue retransmission (authored by rscheff).
tcp: keep SACK scoreboard sorted when doing rescue retransmission
Apr 23 2021, 7:30 AM

Apr 22 2021

rscheff committed R10:eb65f2a3b1c8: rack: Fix ECN on finalizing session. (authored by rscheff).
rack: Fix ECN on finalizing session.
Apr 22 2021, 6:38 PM
rscheff committed R10:af5916594bcb: tcp: Prepare PRR to work with NewReno LossRecovery (authored by rscheff).
tcp: Prepare PRR to work with NewReno LossRecovery
Apr 22 2021, 6:32 PM
rscheff committed R10:f69b9760c202: tcp: Use PRR for ECN congestion recovery (authored by rscheff).
tcp: Use PRR for ECN congestion recovery
Apr 22 2021, 6:32 PM
rscheff committed R10:21e596f343c0: tcp: Refactor PRR code (authored by rscheff).
tcp: Refactor PRR code
Apr 22 2021, 6:32 PM
rscheff updated the diff for D28931: Basic Lost Retransmission Detection (LRD).
  • add man page for net.inet.tcp.do_lrd
Apr 22 2021, 6:07 PM
rscheff added a comment to D28931: Basic Lost Retransmission Detection (LRD).

transport call: fence this new functionality behind a sysctl until stability has been demonstrated

Apr 22 2021, 4:47 PM
rscheff added a comment to D29690: [tcp] Keep socket buffer locked until upcall.

Thank you. Ideally, you should obviouly no longer expirience any hungs, but also the dmesg should be void of any entries like "WAKESOR left over" or "handling WAKESOR finally".

Apr 22 2021, 2:03 PM
rscheff added a comment to D29690: [tcp] Keep socket buffer locked until upcall.

This diff is currently WIP - with extra logging scattered, and not all remnants, where tcp_handle_wakeup() is called, removed. The reason is that I lack an environemnt in which the Problem around NFS server becoming unresponsive, or entering a RST fight, can be replicated.

Apr 22 2021, 1:49 PM
rscheff updated the diff for D29690: [tcp] Keep socket buffer locked until upcall.
  • reduce so_rcv lock time as much as possible
Apr 22 2021, 1:25 PM

Apr 20 2021

rscheff committed R10:a649f1f6fd7a: tcp: Deal with DSACKs, and adjust rescue hole on success. (authored by rscheff).
tcp: Deal with DSACKs, and adjust rescue hole on success.
Apr 20 2021, 12:57 PM
rscheff closed D29835: tcp: Deal with DSACKs, and adjust rescue hole on success..
Apr 20 2021, 12:56 PM

Apr 19 2021

rscheff updated the diff for D29835: tcp: Deal with DSACKs, and adjust rescue hole on success..
  • relax criteria when to move left the rescue hole
Apr 19 2021, 10:20 PM
rscheff added a comment to D29835: tcp: Deal with DSACKs, and adjust rescue hole on success..

in stable-13, this is all gated with net.inet.tcp.rfc6675_pipe, defaulted to disabled.

Apr 19 2021, 6:55 PM
rscheff requested review of D29835: tcp: Deal with DSACKs, and adjust rescue hole on success..
Apr 19 2021, 2:29 PM

Apr 18 2021

rscheff closed D29825: tcp: keep SACK scoreboard sorted when doing rescue retransmission.
Apr 18 2021, 9:13 PM
rscheff committed R10:b87cf2bc841b: tcp: keep SACK scoreboard sorted when doing rescue retransmission (authored by rscheff).
tcp: keep SACK scoreboard sorted when doing rescue retransmission
Apr 18 2021, 9:13 PM
rscheff added a comment to D29690: [tcp] Keep socket buffer locked until upcall.

I did observe these leftovers locally also, but in both instances when there is a tcp state transition to closing / fin_wait. Do you see any odd timing now - e.g the server or client taking longer for a reconnect when the L2 and client interface are severed and restored?

Apr 18 2021, 8:12 PM
rscheff requested review of D29825: tcp: keep SACK scoreboard sorted when doing rescue retransmission.
Apr 18 2021, 6:48 PM
rscheff updated the diff for D29690: [tcp] Keep socket buffer locked until upcall.
  • remove unlock from tcp_reass() and more logging
  • address lock order reversal by doing the upcall before tcp_output() calls
Apr 18 2021, 12:22 PM

Apr 17 2021

rscheff closed D29658: rack: Fix ECN on finalizing session..
Apr 17 2021, 7:23 PM
rscheff committed R10:2e97826052d1: rack: Fix ECN on finalizing session. (authored by rscheff).
rack: Fix ECN on finalizing session.
Apr 17 2021, 7:22 PM
rscheff updated the diff for D23230: Implement ECN++ (draft-generalized-ecn).
  • add TF2_ECN_PLUSPLUS flag to reduce cacheline churn in fastpath when checking V_ecn_generalized
Apr 17 2021, 2:44 PM
rscheff closed D28702: Rename rfc6675_pipe to sack.revised, and enable by default.
Apr 17 2021, 1:51 PM
rscheff committed R10:d1de2b05a001: tcp: Rename rfc6675_pipe to sack.revised, and enable by default (authored by rscheff).
tcp: Rename rfc6675_pipe to sack.revised, and enable by default
Apr 17 2021, 1:51 PM
rscheff updated the diff for D28702: Rename rfc6675_pipe to sack.revised, and enable by default.
  • remove sysctlproc with hint, only mention change in man page
Apr 17 2021, 12:40 PM
rscheff updated the diff for D29690: [tcp] Keep socket buffer locked until upcall.
  • also do this for rack and bbr
Apr 17 2021, 12:19 AM
rscheff added inline comments to D29729: SMR for TCP hostcache..
Apr 17 2021, 12:07 AM

Apr 16 2021

rscheff added a comment to D29690: [tcp] Keep socket buffer locked until upcall.

I get a panic "_mtx_lock_sleep: recursed on non-recursive mutex"
when socantrcvmore() does SOCKBUF_LOCK() with this patch.

It was only on-screen, but here's the stack trace:
mtx_lock_sleep
mtx_lock_flags
socantrcvmore
tcp_do_seqment

Apr 16 2021, 11:52 PM
rscheff updated the diff for D29690: [tcp] Keep socket buffer locked until upcall.
  • deal with pending upcall on FIN correctly
Apr 16 2021, 11:43 PM
rscheff committed R10:4d8601e916cd: tcp: Use sbuf_drain unconditionally (authored by rscheff).
tcp: Use sbuf_drain unconditionally
Apr 16 2021, 10:13 PM
rscheff committed R10:c449b8a71bce: tcp: reduce memory footprint when listing tcp hostcache (authored by rscheff).
tcp: reduce memory footprint when listing tcp hostcache
Apr 16 2021, 10:13 PM
rscheff committed R10:cca0fba78e5f: tcp: Shouldn't drain empty sbuf (authored by rscheff).
tcp: Shouldn't drain empty sbuf
Apr 16 2021, 10:13 PM
rscheff committed R10:254b56ac2a9e: tcp: For hostcache performance, use atomics instead of counters (authored by rscheff).
tcp: For hostcache performance, use atomics instead of counters
Apr 16 2021, 10:12 PM
rscheff committed R10:d20563819b92: tcp: Make hostcache.cache_count MPSAFE by using a counter_u64_t (authored by rscheff).
tcp: Make hostcache.cache_count MPSAFE by using a counter_u64_t
Apr 16 2021, 10:12 PM
rscheff committed R10:a85003abdad4: tcp: drain tcp_hostcache_list in between per-bucket locks (authored by rscheff).
tcp: drain tcp_hostcache_list in between per-bucket locks
Apr 16 2021, 10:12 PM
rscheff committed R10:5934587a3130: tcp: Use sbuf_drain unconditionally (authored by rscheff).
tcp: Use sbuf_drain unconditionally
Apr 16 2021, 9:35 PM
rscheff committed R10:2a9ce2734f8b: tcp: Shouldn't drain empty sbuf (authored by rscheff).
tcp: Shouldn't drain empty sbuf
Apr 16 2021, 9:34 PM
rscheff committed R10:e9ca38abc79b: tcp: For hostcache performance, use atomics instead of counters (authored by rscheff).
tcp: For hostcache performance, use atomics instead of counters
Apr 16 2021, 9:34 PM
rscheff committed R10:c0f8ed6ff812: tcp: Make hostcache.cache_count MPSAFE by using a counter_u64_t (authored by rscheff).
tcp: Make hostcache.cache_count MPSAFE by using a counter_u64_t
Apr 16 2021, 9:34 PM
rscheff committed R10:12ce9e4868d1: tcp: drain tcp_hostcache_list in between per-bucket locks (authored by rscheff).
tcp: drain tcp_hostcache_list in between per-bucket locks
Apr 16 2021, 9:33 PM
rscheff committed R10:54beb1ef2c83: tcp: reduce memory footprint when listing tcp hostcache (authored by rscheff).
tcp: reduce memory footprint when listing tcp hostcache
Apr 16 2021, 9:33 PM
rscheff committed R10:139576030ff3: tcp: Use jenkins_hash32() in hostcache (authored by rscheff).
tcp: Use jenkins_hash32() in hostcache
Apr 16 2021, 8:47 PM
rscheff committed R10:e5bbb777cbfa: tcp: Use sbuf_drain unconditionally (authored by rscheff).
tcp: Use sbuf_drain unconditionally
Apr 16 2021, 8:47 PM
rscheff committed R10:9f3835013032: tcp: Shouldn't drain empty sbuf (authored by rscheff).
tcp: Shouldn't drain empty sbuf
Apr 16 2021, 8:47 PM
rscheff committed R10:38088b12fe64: tcp: Add hash histogram output and validate bucket length accounting (authored by rscheff).
tcp: Add hash histogram output and validate bucket length accounting
Apr 16 2021, 8:47 PM