Page MenuHomeFreeBSD

rscheff (Richard Scheffenegger)
User

Projects

User Details

User Since
Oct 18 2018, 9:44 PM (320 w, 4 d)

Recent Activity

Sun, Dec 8

rscheff closed D47063: extend the use of the th_flags accessor function.
Sun, Dec 8, 4:20 AM

Fri, Nov 29

rscheff committed rG347dd0539f3a: tcp: add TH_AE capabilities to ppp and pf (authored by rscheff).
tcp: add TH_AE capabilities to ppp and pf
Fri, Nov 29, 9:51 AM
rscheff committed rG0fc7bdc97836: tcp: extend the use of the th_flags accessor function (authored by rscheff).
tcp: extend the use of the th_flags accessor function
Fri, Nov 29, 9:51 AM
rscheff closed D47106: add TH_AE capabilities to ppp and pf.
Fri, Nov 29, 9:51 AM
rscheff added inline comments to D47063: extend the use of the th_flags accessor function.
Fri, Nov 29, 8:42 AM

Thu, Nov 28

rscheff added a comment to D47106: add TH_AE capabilities to ppp and pf.

@kp can you please review the PF-related changes in this Diff?

Thu, Nov 28, 3:17 PM
rscheff updated subscribers of D47063: extend the use of the th_flags accessor function.

@kbowling, can you have a look at the intel driver changes and if they seem ok, remove that blocker?

Thu, Nov 28, 3:16 PM
rscheff abandoned D43297: tcp: remove superfluous checks for ECN session.

Discussed in todays transport call, since this is not in the hot path of every packet, and the retention of the internal bit might confuse someone later, it was decided to abandon this change.

Thu, Nov 28, 3:12 PM

Tue, Nov 19

rscheff accepted D44258: ixgbe: Make masks for TCP flag handling during TSO sysctl'able.
Tue, Nov 19, 8:51 AM
rscheff added a comment to D44258: ixgbe: Make masks for TCP flag handling during TSO sysctl'able.
In D44258#1067037, @erj wrote:

Your description definitely helps; thanks for asking the question @kbowling. @tuexen have you checked these masks on the other devices that use ixl/ice, or is this what you've observed so far?

I haven't heard anything internally about needing the TSO masks to be changed, but I'm certainly fine with adding sysctls to configure these values since it seems to fix a valid issue.

Tue, Nov 19, 8:49 AM

Thu, Nov 14

rscheff committed rG22dcc8129385: tcp: Use segment size excluding tcp options for all cwnd calculations (authored by rscheff).
tcp: Use segment size excluding tcp options for all cwnd calculations
Thu, Nov 14, 6:38 PM
rscheff closed D47474: tcp: Use segment size excluding any options for all cwnd calculations.
Thu, Nov 14, 6:38 PM
rscheff closed D47056: tcp: allow TSO even while RX path is unordered.
Thu, Nov 14, 6:03 PM
rscheff closed D47541: tcp: fix cwnd recalculation during limited transmit.
Thu, Nov 14, 6:00 PM
rscheff committed rG8f5a2e216f4c: tcp: fix cwnd recalculation during limited transmit (authored by rscheff).
tcp: fix cwnd recalculation during limited transmit
Thu, Nov 14, 6:00 PM
rscheff committed rGc9047eb7b30d: tcp: allow TSO even while RX path is unordered (authored by rscheff).
tcp: allow TSO even while RX path is unordered
Thu, Nov 14, 5:15 PM
rscheff added a comment to D47474: tcp: Use segment size excluding any options for all cwnd calculations.

Well, I had the same thought - the full MSS (including options) is less frequently used, that the mss without options...

Thu, Nov 14, 4:25 PM
rscheff committed rGdded4e9e524c: tcp: change SOCKBUF_* macros to SOCK_[RECV|SEND]BUF_* macros (authored by rscheff).
tcp: change SOCKBUF_* macros to SOCK_[RECV|SEND]BUF_* macros
Thu, Nov 14, 10:08 AM
rscheff closed D47567: tcp: chance SOCKBUF_LOCK calls to SOCK_[RECV|SEND]BUF_LOCK.
Thu, Nov 14, 10:08 AM
rscheff accepted D47542: Change the SOCKBUF_LOCK calls to use the more refined SOCK_XXXBUF_LOCK/UNLOCK..
Thu, Nov 14, 8:31 AM
rscheff requested review of D47567: tcp: chance SOCKBUF_LOCK calls to SOCK_[RECV|SEND]BUF_LOCK.
Thu, Nov 14, 8:21 AM

Wed, Nov 13

rscheff requested review of D47541: tcp: fix cwnd recalculation during limited transmit.
Wed, Nov 13, 6:59 PM
rscheff updated the diff for D47056: tcp: allow TSO even while RX path is unordered.
  • update comment to reflect current checks in the code
Wed, Nov 13, 2:43 PM
rscheff updated the diff for D47056: tcp: allow TSO even while RX path is unordered.
  • address peter's feedback for rack and bbr
Wed, Nov 13, 2:35 PM

Mon, Nov 11

rscheff accepted D47512: ipv4: allow use of 240/4 by default.

Seems you inadvertedly removed all reviewers; I added a bunch who probably want to chime in from the transport/ip side. I myself welcome this change - and maybe we should be backporting this to stable/14 and the upcoming release even.... I suspect most public deployments have that tunable toggled already?

Mon, Nov 11, 6:11 PM
rscheff edited reviewers for D47512: ipv4: allow use of 240/4 by default, added: transport, glebius, melifaro, tuexen, rscheff, cc, rgrimes; removed: emaste.
Mon, Nov 11, 6:07 PM

Nov 7 2024

rscheff requested review of D47474: tcp: Use segment size excluding any options for all cwnd calculations.
Nov 7 2024, 2:41 PM

Nov 5 2024

rscheff accepted D47439: tcp: consistently set CWND to MSS in case of SYN/SYN ACK retransmissions.
Nov 5 2024, 8:26 AM

Nov 2 2024

rscheff added a comment to D47401: tcp: don't define and use BBLog function when TCP_BLACKBOX is not defined.

Wouldn't it be possible to #define tcp_lro_log in a #else of the first block, such that this scattering of #ifdef's throughout the file could be avoided?

Nov 2 2024, 5:17 PM

Nov 1 2024

rscheff updated the diff for D47063: extend the use of the th_flags accessor function.
  • use accessor in various drivers
Nov 1 2024, 10:14 AM

Oct 29 2024

rscheff committed rG7dc78150c730: tcp: refactor cwnd during SACK transmissions to allow TSO (authored by rscheff).
tcp: refactor cwnd during SACK transmissions to allow TSO
Oct 29 2024, 7:32 PM
rscheff closed D43470: tcp: refactor cwnd during SACK transmissions and enable TSO.
Oct 29 2024, 7:31 PM

Oct 18 2024

rscheff committed rG6b2977c5978b: tcp: fix duplicate retransmissions when RTO happens during SACK loss recovery (authored by rscheff).
tcp: fix duplicate retransmissions when RTO happens during SACK loss recovery
Oct 18 2024, 7:55 AM

Oct 17 2024

rscheff updated the diff for D43470: tcp: refactor cwnd during SACK transmissions and enable TSO.
  • remove unneccesary style and line wrap changes
Oct 17 2024, 4:31 PM
rscheff requested changes to D47130: tcp: remove the `goto drop` label by reusing equivalences in tcp_do_segment()..
Oct 17 2024, 3:57 PM
rscheff accepted D47130: tcp: remove the `goto drop` label by reusing equivalences in tcp_do_segment()..
Oct 17 2024, 3:16 PM

Oct 16 2024

rscheff updated the diff for D43470: tcp: refactor cwnd during SACK transmissions and enable TSO.
  • implement suggested improvements
Oct 16 2024, 8:57 PM

Oct 15 2024

rscheff added inline comments to D43470: tcp: refactor cwnd during SACK transmissions and enable TSO.
Oct 15 2024, 9:03 PM
rscheff updated the diff for D43470: tcp: refactor cwnd during SACK transmissions and enable TSO.
  • remove unnecessary changes
Oct 15 2024, 8:53 PM
rscheff requested changes to D47130: tcp: remove the `goto drop` label by reusing equivalences in tcp_do_segment()..

While I agree that "goto" statements are not nice, and hard to follow - there is something to be said about the overhead of a function preamble, stack use and cleanup. I would suggest to make this an "__inline" function.

Oct 15 2024, 8:39 PM
rscheff added a comment to D47106: add TH_AE capabilities to ppp and pf.

Thanks for the thorough review!

Oct 15 2024, 1:57 PM
rscheff updated the diff for D47106: add TH_AE capabilities to ppp and pf.
  • fix typo, remove redundant all-flags definitions
Oct 15 2024, 1:53 PM
rscheff added a comment to D47106: add TH_AE capabilities to ppp and pf.
In D47106#1073744, @kp wrote:

pf bits look good.

Oct 15 2024, 11:11 AM
rscheff updated the diff for D47106: add TH_AE capabilities to ppp and pf.
  • log TCP flags properly in ppp
Oct 15 2024, 11:07 AM
rscheff updated the diff for D47106: add TH_AE capabilities to ppp and pf.
  • prepare more ipf tools for AccECN
Oct 15 2024, 9:49 AM
rscheff updated the diff for D47106: add TH_AE capabilities to ppp and pf.
  • decode ACE in libipf too
  • expand ipf for AccECN compatibility
Oct 15 2024, 8:46 AM

Oct 14 2024

rscheff updated the diff for D47106: add TH_AE capabilities to ppp and pf.
  • missed function definition
Oct 14 2024, 2:14 PM
rscheff updated the diff for D47063: extend the use of the th_flags accessor function.
  • missed function definition
Oct 14 2024, 2:13 PM
rscheff requested review of D47106: add TH_AE capabilities to ppp and pf.
Oct 14 2024, 2:00 PM
rscheff updated the diff for D47063: extend the use of the th_flags accessor function.
  • clean up type and remove superfluous parenthesis
  • revert adding support for TH_AE in ppp and pf
Oct 14 2024, 1:58 PM

Oct 13 2024

rscheff updated the diff for D47063: extend the use of the th_flags accessor function.
  • extend the use of accessor function in userspace and pfil
Oct 13 2024, 7:56 PM
rscheff added a comment to D47063: extend the use of the th_flags accessor function.
In D47063#1073100, @kp wrote:

I'm happy with the pf bits.
It mostly doesn't matter because we tend to only look for th_flags flags and not th_x2, but it's probably better to use the accessor anyway.

We should probably do this too
...

Oct 13 2024, 10:48 AM
rscheff updated the diff for D47063: extend the use of the th_flags accessor function.
  • add TH_AE decoding (identical to tcpdump as "e") as suggested by kp
  • moving updating the th_flags further down past the last adjustment
Oct 13 2024, 10:43 AM

Oct 11 2024

rscheff updated the diff for D47063: extend the use of the th_flags accessor function.
  • use userspace accessor function
Oct 11 2024, 8:31 PM
rscheff retitled D47056: tcp: allow TSO even while RX path is unordered from tcp: allow LRO even while RX path is unordered to tcp: allow TSO even while RX path is unordered.
Oct 11 2024, 4:23 PM
rscheff requested review of D47063: extend the use of the th_flags accessor function.
Oct 11 2024, 4:14 PM
rscheff added a comment to D43470: tcp: refactor cwnd during SACK transmissions and enable TSO.

thanks!

Oct 11 2024, 3:17 PM
rscheff updated the diff for D43470: tcp: refactor cwnd during SACK transmissions and enable TSO.
  • fix typo after rebase
Oct 11 2024, 3:17 PM
rscheff added a comment to D43470: tcp: refactor cwnd during SACK transmissions and enable TSO.
In D43470#1072656, @cc wrote:

Because of commit 440f4ba18e3a, please re-base.

Oct 11 2024, 1:32 PM
rscheff requested review of D47056: tcp: allow TSO even while RX path is unordered.
Oct 11 2024, 1:12 PM
rscheff updated the diff for D43470: tcp: refactor cwnd during SACK transmissions and enable TSO.
  • rebase main
Oct 11 2024, 12:41 PM
rscheff committed rG440f4ba18e3a: tcp: fix duplicate retransmissions when RTO happens during SACK loss recovery (authored by rscheff).
tcp: fix duplicate retransmissions when RTO happens during SACK loss recovery
Oct 11 2024, 11:57 AM
rscheff closed D43355: tcp: fix erroneous transmission selection after RTO w/ SACK incoming.
Oct 11 2024, 11:57 AM

Oct 9 2024

rscheff updated the test plan for D43355: tcp: fix erroneous transmission selection after RTO w/ SACK incoming.
Oct 9 2024, 12:24 PM

Oct 7 2024

rscheff updated the test plan for D43355: tcp: fix erroneous transmission selection after RTO w/ SACK incoming.
Oct 7 2024, 1:57 PM
rscheff updated the test plan for D43355: tcp: fix erroneous transmission selection after RTO w/ SACK incoming.
Oct 7 2024, 12:58 PM

Oct 3 2024

rscheff accepted D46881: getsockopt: improve locking for SOL_SOCKET level socket options.
Oct 3 2024, 3:46 PM
rscheff added inline comments to D46425: Add TCP round counting logic for default stack..
Oct 3 2024, 3:19 PM

Oct 1 2024

rscheff accepted D46850: tcp: small cleanup.
Oct 1 2024, 7:51 AM
rscheff accepted D46824: tcp_output: Clear FIN if tcp_m_copym truncates output length.

lgtm

Oct 1 2024, 7:49 AM

Sep 30 2024

rscheff accepted D46839: tcp: improve mbuf handling when processing SYN.
Sep 30 2024, 10:34 AM

Sep 29 2024

rscheff accepted D46824: tcp_output: Clear FIN if tcp_m_copym truncates output length.

Good find! While there is probably zero difference as the compiler optimizes this, keeping "old_len" instead would only require the clearing of TH_FIN, and not another assignment though, which seems more alike to similar other checks... @tuexen @cc and @rrs may want to have a look too...

Sep 29 2024, 12:51 PM

Sep 28 2024

rscheff accepted D46793: tcp: improve ref count handling when processing SYN.
Sep 28 2024, 10:44 AM

Sep 22 2024

rscheff committed rG8fee873d78eb: tcp: keep syncache flags when updating ECN info (authored by rscheff).
tcp: keep syncache flags when updating ECN info
Sep 22 2024, 4:25 PM

Sep 19 2024

rscheff accepted D46701: mac: improve consistency.
Sep 19 2024, 3:17 PM
rscheff accepted D46623: tcp: remove unused socket option names.
Sep 19 2024, 3:14 PM

Sep 18 2024

rscheff committed rG0a05ea1f56e6: tcp: keep syncache flags when updating ECN info (authored by rscheff).
tcp: keep syncache flags when updating ECN info
Sep 18 2024, 9:50 AM
rscheff closed D46694: Keep syncache flags when updating ECN info.
Sep 18 2024, 9:50 AM
rscheff requested review of D46694: Keep syncache flags when updating ECN info.
Sep 18 2024, 9:12 AM
rscheff updated the test plan for D43355: tcp: fix erroneous transmission selection after RTO w/ SACK incoming.
Sep 18 2024, 8:31 AM
rscheff updated the diff for D43355: tcp: fix erroneous transmission selection after RTO w/ SACK incoming.
  • rebase to main
Sep 18 2024, 8:08 AM

Sep 10 2024

rscheff accepted D46618: tcp: improve whitespace consistency for socket option names.
Sep 10 2024, 6:50 AM

Sep 6 2024

rscheff accepted D46546: cc_cubic: use newreno to emulate AIMD in TCP-friendly region.

Looks good, the intended change is clear to follow and in line with the spirit of RFC9438.

Sep 6 2024, 7:24 AM
rscheff accepted D46046: tcp cc: re-organize newreno functions into parts that can be re-used.

lgtm;

Sep 6 2024, 7:23 AM

Sep 5 2024

rscheff accepted D46435: tcp: make tcp_lro_flush() static.
Sep 5 2024, 3:26 PM
rscheff accepted D46434: al_eth: improve TCP LRO.
Sep 5 2024, 3:25 PM
rscheff accepted D46433: neta: improve TCP LRO.
Sep 5 2024, 3:25 PM

Jul 25 2024

rscheff accepted D46066: tcp: implement throttling of challenge ACKs.
Jul 25 2024, 3:36 PM

Jul 11 2024

rscheff accepted D45894: tcp: improve SEG.ACK validation.
Jul 11 2024, 3:38 PM

Jun 27 2024

rscheff accepted D45753: tcp: improve failure handling in tcp_newtcpcb().
Jun 27 2024, 3:18 PM
rscheff accepted D45749: tcp: fix cleanup when in_pcbconnect() fails in syncache_socket().
Jun 27 2024, 3:13 PM

May 16 2024

rscheff updated the diff for D41715: tcp: Align cubic cc with rfc9438.
  • remove unused variable
May 16 2024, 9:25 PM
rscheff updated the diff for D41715: tcp: Align cubic cc with rfc9438.
  • rebase to main
May 16 2024, 8:48 PM

May 8 2024

rscheff committed rG2a9aae9e5f7a: tcp: add counter to track when SACK loss recovery uses TSO (authored by rscheff).
tcp: add counter to track when SACK loss recovery uses TSO
May 8 2024, 12:58 PM
rscheff closed D45070: tcp: add counter to track when SACK loss recovery uses TSO.
May 8 2024, 12:57 PM
rscheff committed rGdcdfe44901ec: tcp: add sysctl to allow/disallow TSO during SACK loss recovery (authored by rscheff).
tcp: add sysctl to allow/disallow TSO during SACK loss recovery
May 8 2024, 12:57 PM
rscheff closed D45068: tcp: add sysctl to allow/disallow TSO during SACK loss recovery.
May 8 2024, 12:57 PM
rscheff committed rGcbf3575aa3c2: tcp: filter small SACK blocks (authored by rscheff).
tcp: filter small SACK blocks
May 8 2024, 12:31 PM
rscheff closed D45075: tcp: filter small SACK blocks.
May 8 2024, 12:31 PM

May 7 2024

rscheff committed rG59884aea8b98: tcp: clean up macro useage in tcp_fixed_maxseg() (authored by rscheff).
tcp: clean up macro useage in tcp_fixed_maxseg()
May 7 2024, 8:14 PM