Page MenuHomeFreeBSD

rscheff (Richard Scheffenegger)
User

Projects

User Details

User Since
Oct 18 2018, 9:44 PM (287 w, 17 h)

Recent Activity

Yesterday

rscheff accepted D44746: tcp: drop data received after a FIN has been processed.

Base stack change looks good.

Thu, Apr 18, 3:12 PM
rscheff accepted D44648: tcp rack: improve BBR_LOG_CWND event.
Thu, Apr 18, 3:06 PM

Mon, Apr 15

rscheff accepted D44800: tcp bbr: improve code consistency.
Mon, Apr 15, 8:12 PM

Sun, Apr 7

rscheff accepted D44669: tcp: add some debug output.
Sun, Apr 7, 8:13 PM

Fri, Apr 5

rscheff accepted D44647: tcp rack: fix memory corruption.
Fri, Apr 5, 9:20 PM
rscheff accepted D44645: tcp: improve consistency.
Fri, Apr 5, 9:17 PM

Thu, Apr 4

rscheff accepted D44616: tcp bblog: cleanup.
Thu, Apr 4, 3:17 PM
rscheff accepted D44584: tcp hpts: initialize variable.
Thu, Apr 4, 3:14 PM

Wed, Apr 3

rscheff accepted D44610: tcp rack: fix sending .
Wed, Apr 3, 4:49 PM
rscheff accepted D44612: tcp: fix conversion of rttvar.
Wed, Apr 3, 1:30 PM
rscheff accepted D44611: tcp: fix comment.
Wed, Apr 3, 1:28 PM
rscheff added a comment to D44610: tcp rack: fix sending .

if idle is used as a boolean, why not be consequent about it and declare it as such also? To prevent future misuses with numeric calculations...

Wed, Apr 3, 12:38 PM

Tue, Mar 26

rscheff accepted D44510: tcp bblog: use correct length.
Tue, Mar 26, 12:29 PM

Fri, Mar 22

rscheff closed D44092: build: add Wswitch to clang for more consistency with gcc.
Fri, Mar 22, 10:41 AM
rscheff committed rG56b40c285b59: build: add -Wswitch to clang for more consistency with gcc (authored by rscheff).
build: add -Wswitch to clang for more consistency with gcc
Fri, Mar 22, 10:41 AM

Thu, Mar 21

rscheff added a comment to D44092: build: add Wswitch to clang for more consistency with gcc.
In D44092#1013944, @dim wrote:

KMSAN is @markj I believe? Though it looks like you're getting a clang assertion there. So what is the clang version being used?

Thu, Mar 21, 4:22 PM
rscheff added a reviewer for D44092: build: add Wswitch to clang for more consistency with gcc: dim.
Thu, Mar 21, 3:46 PM
rscheff accepted D44384: tcp: no data on SYN unless doing TFO.
Thu, Mar 21, 3:13 PM

Mar 18 2024

rscheff committed rGb5a9299bb8b9: ktls: catch invalid parameters earlier (authored by rscheff).
ktls: catch invalid parameters earlier
Mar 18 2024, 5:09 PM
rscheff closed D44364: ktls: catch invalid parameters earlier.
Mar 18 2024, 5:09 PM

Mar 14 2024

rscheff updated the diff for D44364: ktls: catch invalid parameters earlier.
  • some compiler trickery to the correct struct member size
Mar 14 2024, 10:30 PM
rscheff requested review of D44364: ktls: catch invalid parameters earlier.
Mar 14 2024, 9:49 PM
rscheff added a comment to D44362: tcp: remove IS_FASTOPEN() macro.
In D44362#1011765, @kib wrote:

I do not understand the change. You re-wrote the code as if the TCP_RFC7413 option is always set. This is not true, at least from the fast grepping of the sources.

Mar 14 2024, 8:52 PM
rscheff accepted D44362: tcp: remove IS_FASTOPEN() macro.

thx

Mar 14 2024, 8:50 PM
rscheff accepted D44362: tcp: remove IS_FASTOPEN() macro.

only minor whitespace nits. i'm ok with removing this macro mechanistically.

Mar 14 2024, 8:16 PM

Mar 13 2024

rscheff accepted D44349: netinet/tcp_var.h: always define IS_FASTOPEN() for kernel compilation env.
Mar 13 2024, 9:13 PM
rscheff committed rG85df11a1dec6: ktls: deep copy tls_enable struct for in-kernel tcp consumers (authored by rscheff).
ktls: deep copy tls_enable struct for in-kernel tcp consumers
Mar 13 2024, 9:08 PM
rscheff closed D44250: Deep copy tls_enable struct in copyin_tls_enable.
Mar 13 2024, 9:08 PM · NetApp
rscheff accepted D44340: tcp: move struct tcp_ifcap declaration under _KERNEL.
Mar 13 2024, 4:33 PM

Mar 12 2024

rscheff accepted D44219: ipsec_accel: kernel infrastructure.

i've read through the TCP related changes, which look good to me. But that's only a minute part of this change. Others should comment on the remaining aspects of this major diff.

Mar 12 2024, 7:18 AM

Mar 8 2024

rscheff updated the summary of D44250: Deep copy tls_enable struct in copyin_tls_enable.
Mar 8 2024, 9:23 PM · NetApp
rscheff added a comment to D44250: Deep copy tls_enable struct in copyin_tls_enable.

addressed all comments.

Mar 8 2024, 7:58 AM · NetApp
rscheff updated the diff for D44250: Deep copy tls_enable struct in copyin_tls_enable.
  • sort prototype definitions alphabetically
Mar 8 2024, 7:55 AM · NetApp

Mar 7 2024

rscheff updated the diff for D44250: Deep copy tls_enable struct in copyin_tls_enable.
  • clean key material in the error path too.
Mar 7 2024, 9:15 PM · NetApp
rscheff abandoned D44165: ktls: enumify tcp_tls_mode magic numbers.

Discussed transport

Mar 7 2024, 4:03 PM

Mar 6 2024

rscheff updated subscribers of D44259: e1000: Make masks for TCP flag handling during TSO sysctl'able.

Can I ping @kib like this?

Mar 6 2024, 10:29 PM
rscheff added a comment to D44258: ixgbe: Make masks for TCP flag handling during TSO sysctl'able.

As at least two, maybe three different NIC vendors have similar capabilities, wouldn't it make sense to have global, driver independent sysctls?

Mar 6 2024, 10:28 PM
rscheff updated the diff for D44250: Deep copy tls_enable struct in copyin_tls_enable.
  • clean before free all crypto material
Mar 6 2024, 7:02 PM · NetApp
rscheff commandeered D44250: Deep copy tls_enable struct in copyin_tls_enable from cmiller_netapp.com.
Mar 6 2024, 7:02 PM · NetApp
rscheff requested changes to D44250: Deep copy tls_enable struct in copyin_tls_enable.
Mar 6 2024, 6:34 PM · NetApp
rscheff added reviewers for D44250: Deep copy tls_enable struct in copyin_tls_enable: tuexen, jhb.
Mar 6 2024, 10:56 AM · NetApp

Mar 1 2024

rscheff added reviewers for D44165: ktls: enumify tcp_tls_mode magic numbers: cc, jhb, emaste, tuexen.
Mar 1 2024, 8:58 PM
rscheff added inline comments to D44165: ktls: enumify tcp_tls_mode magic numbers.
Mar 1 2024, 5:44 PM
rscheff updated the diff for D44165: ktls: enumify tcp_tls_mode magic numbers.

whitespace fix 2

Mar 1 2024, 2:12 PM
rscheff updated the diff for D44165: ktls: enumify tcp_tls_mode magic numbers.

whitespace fix

Mar 1 2024, 2:08 PM
rscheff requested review of D44165: ktls: enumify tcp_tls_mode magic numbers.
Mar 1 2024, 1:45 PM
rscheff updated subscribers of D44092: build: add Wswitch to clang for more consistency with gcc.

Makes sense to me. Have you tested make tinderbox?

Mar 1 2024, 8:23 AM

Feb 28 2024

rscheff added a comment to D44092: build: add Wswitch to clang for more consistency with gcc.

MAIN e0dfecadf5946b6a8ad423be4eb1c14017b3a8a7 errors on make tinderbox with the same error:

Feb 28 2024, 6:15 PM
rscheff added a comment to D44092: build: add Wswitch to clang for more consistency with gcc.

Makes sense to me. Have you tested make tinderbox?

Feb 28 2024, 6:10 PM
rscheff committed rGe6e28a73fc21: tcp: cubic - restart epoch after RTO (authored by rscheff).
tcp: cubic - restart epoch after RTO
Feb 28 2024, 12:27 AM
rscheff committed rG6e298c3612da: tcp: prevent div by zero in cc_htcp (authored by rscheff).
tcp: prevent div by zero in cc_htcp
Feb 28 2024, 12:27 AM

Feb 27 2024

rscheff committed rGf3f559705a05: tcp: cubic - restart epoch after RTO (authored by rscheff).
tcp: cubic - restart epoch after RTO
Feb 27 2024, 11:03 AM
rscheff committed rG419848219b40: tcp: prevent div by zero in cc_htcp (authored by rscheff).
tcp: prevent div by zero in cc_htcp
Feb 27 2024, 11:03 AM

Feb 26 2024

rscheff added a comment to D44092: build: add Wswitch to clang for more consistency with gcc.

Does -Wswitch require a default if all values of an enum are explicitly included? I don't know if that is common though.

Feb 26 2024, 9:39 PM
rscheff added a comment to D44092: build: add Wswitch to clang for more consistency with gcc.

Unfortunately, my box here is too small to build serveral universes.

Feb 26 2024, 9:31 PM
rscheff requested review of D44092: build: add Wswitch to clang for more consistency with gcc.
Feb 26 2024, 8:50 PM

Feb 25 2024

rscheff committed rG8917131e00b0: tcp: need default in switch statement for enum. (authored by rscheff).
tcp: need default in switch statement for enum.
Feb 25 2024, 7:09 PM
rscheff closed D44081: tcp: need default in switch statement for enum..
Feb 25 2024, 7:09 PM
rscheff added a comment to D44081: tcp: need default in switch statement for enum..

Apparently I've only checked clang or gccc12 but ont gcc13 - where there are subtle differences in what these compilers consider acceptable;

Feb 25 2024, 7:06 PM
rscheff requested review of D44081: tcp: need default in switch statement for enum..
Feb 25 2024, 6:39 PM
rscheff committed rGc9b6241e250a: tcp: address enum-int-mismatch (authored by rscheff).
tcp: address enum-int-mismatch
Feb 25 2024, 11:49 AM

Feb 24 2024

rscheff committed rG5e248c23d995: tcp: retain some CC signals outside of kernel scope (authored by rscheff).
tcp: retain some CC signals outside of kernel scope
Feb 24 2024, 8:03 PM
rscheff closed D44066: tcp: retain some CC signals outside of kernel scope.
Feb 24 2024, 8:02 PM
rscheff requested review of D44066: tcp: retain some CC signals outside of kernel scope.
Feb 24 2024, 8:01 PM
rscheff closed D44023: tcp: cubic - restart epoch after RTO.
Feb 24 2024, 4:17 PM
rscheff committed rG038699a8f18a: tcp: cubic - restart epoch after RTO (authored by rscheff).
tcp: cubic - restart epoch after RTO
Feb 24 2024, 4:17 PM
rscheff closed D43957: tcp: provide correct snd_fack on post_recovery.
Feb 24 2024, 4:17 PM
rscheff committed rG40fdc6d25f01: tcp: provide correct snd_fack on post_recovery (authored by rscheff).
tcp: provide correct snd_fack on post_recovery
Feb 24 2024, 4:17 PM
rscheff closed D43838: tcp: use enum for all congestion control signals.
Feb 24 2024, 4:16 PM
rscheff committed rGf74352fbcf15: tcp: use enum for all congestion control signals (authored by rscheff).
tcp: use enum for all congestion control signals
Feb 24 2024, 4:16 PM
rscheff closed D43797: tcp: prevent div by zero in cc_htcp.
Feb 24 2024, 4:16 PM
rscheff committed rG38983d40c18e: tcp: prevent div by zero in cc_htcp (authored by rscheff).
tcp: prevent div by zero in cc_htcp
Feb 24 2024, 4:16 PM

Feb 22 2024

rscheff added a comment to D44023: tcp: cubic - restart epoch after RTO.

I suspect this is not the final patch, but suffices for now to stop excessive inflation of cwnd on the first ACK when transistioning from slow-start to congestion avoidance.
The guidance given was that t_epoch should be reset at the time cc transitions from slow-start to cong-avoidance.
However, I would like to revisit this anew, once the major overhaul in D41715 is in...

Feb 22 2024, 8:33 PM
rscheff updated the diff for D43797: tcp: prevent div by zero in cc_htcp.
  • do max(1, div) instead max(maxseg, cwnd)/div
Feb 22 2024, 4:42 PM
rscheff requested review of D44023: tcp: cubic - restart epoch after RTO.
Feb 22 2024, 4:35 PM
rscheff added a comment to D43797: tcp: prevent div by zero in cc_htcp.

max(div, 1) prior of outer division.

Feb 22 2024, 3:20 PM

Feb 21 2024

rscheff accepted D44000: tcp: Add a new kernel-only TCP_USE_DDP socket option.
Feb 21 2024, 10:04 AM

Feb 18 2024

rscheff requested review of D43957: tcp: provide correct snd_fack on post_recovery.
Feb 18 2024, 11:12 AM
rscheff updated the diff for D41715: tcp: Align cubic cc with rfc9438.
  • rebase main
Feb 18 2024, 11:09 AM
rscheff updated the diff for D23230: Implement ECN++ (draft-generalized-ecn).
  • rebase main
Feb 18 2024, 10:29 AM
rscheff updated the diff for D36303: Implement AccECN option (w/ early assigned option number).
  • rebase main
Feb 18 2024, 10:27 AM
rscheff updated the diff for D42563: tcp: implement ACE-change ACKs.
  • rebase main
Feb 18 2024, 9:16 AM
rscheff updated the diff for D43470: tcp: refactor cwnd during SACK transmissions and enable TSO.
  • delta to D43355_sack_after_rto
Feb 18 2024, 9:14 AM
rscheff updated the diff for D43355: tcp: fix erroneous transmission selection after RTO w/ SACK incoming.
  • rebase to main
Feb 18 2024, 9:11 AM
rscheff updated the diff for D43838: tcp: use enum for all congestion control signals.
  • rebase main
Feb 18 2024, 9:10 AM

Feb 14 2024

rscheff committed rGfcea1cc9711a: tcp: fix RTO ssthresh for non-6675 pipe calculation (authored by rscheff).
tcp: fix RTO ssthresh for non-6675 pipe calculation
Feb 14 2024, 1:58 PM
rscheff closed D43876: tcp: fix RTO ssthresh for non-6675 pipe calculation.
Feb 14 2024, 1:58 PM
rscheff requested review of D43876: tcp: fix RTO ssthresh for non-6675 pipe calculation.
Feb 14 2024, 12:40 PM

Feb 12 2024

rscheff closed D43855: tcp: partially undo D43792.
Feb 12 2024, 9:41 PM
rscheff added a reverting change for rG62d47d73b7eb: tcp: stop timers and clean scoreboard in tcp_close(): rG57e27ff07aff: tcp: partially undo D43792.
Feb 12 2024, 9:41 PM
rscheff committed rG57e27ff07aff: tcp: partially undo D43792 (authored by rscheff).
tcp: partially undo D43792
Feb 12 2024, 9:41 PM
rscheff added a reverting change for D43792: tcp: stop timers and clean scoreboard in tcp_close(): rG57e27ff07aff: tcp: partially undo D43792.
Feb 12 2024, 9:41 PM
rscheff updated the summary of D43855: tcp: partially undo D43792.
Feb 12 2024, 8:18 PM
rscheff abandoned D43825: tcp: stop all timers in tcp_usr_detach().

Better revert to the prior state (with tcp_timer_stop() in tcp_discardcb()) - D43855

Feb 12 2024, 8:17 PM
rscheff requested review of D43855: tcp: partially undo D43792.
Feb 12 2024, 8:10 PM
rscheff added a reverting change for D43792: tcp: stop timers and clean scoreboard in tcp_close(): D43855: tcp: partially undo D43792.
Feb 12 2024, 8:09 PM
rscheff added a reverting change for rG62d47d73b7eb: tcp: stop timers and clean scoreboard in tcp_close(): D43855: tcp: partially undo D43792.
Feb 12 2024, 8:09 PM
rscheff added inline comments to D43838: tcp: use enum for all congestion control signals.
Feb 12 2024, 6:02 PM
rscheff added inline comments to D43838: tcp: use enum for all congestion control signals.
Feb 12 2024, 5:18 PM

Feb 11 2024

rscheff requested review of D43838: tcp: use enum for all congestion control signals.
Feb 11 2024, 6:09 PM