Page MenuHomeFreeBSD

cmiller_netapp.com (Chris Miller)
User

Projects

User Details

User Since
May 12 2021, 2:43 PM (201 w, 1 d)

Recent Activity

Thu, Feb 27

cmiller_netapp.com added a comment to D48896: Make VLAN hash table fixed width.

It probably can be implemented correctly, but I think it would require locking while the hash grows or shrinks. This change tries to strike a balance between the speed of VLAN_ARRAY and the memory savings of using the hash table, while avoiding the complexity associated with growing and shrinking the hash table. Growing and shrinking a hash table that can have a max 4096 entries just seems like overkill.

Thu, Feb 27, 2:28 PM

Wed, Feb 26

cmiller_netapp.com added a comment to D48896: Make VLAN hash table fixed width.

What is needed to continue moving this forward?

Wed, Feb 26, 5:19 PM

Feb 12 2025

cmiller_netapp.com added inline comments to D48896: Make VLAN hash table fixed width.
Feb 12 2025, 3:36 PM

Feb 11 2025

cmiller_netapp.com added inline comments to D48896: Make VLAN hash table fixed width.
Feb 11 2025, 7:25 PM
cmiller_netapp.com added a comment to D48896: Make VLAN hash table fixed width.
In D48896#1115745, @kp wrote:

I know there are users out there who run a very large number of vlans (>> 256) who might be affected by this. On the other hand, they ought to be using VLAN_ARRAY.

I'm tempted to suggest we should just make VLAN_ARRAY default, because it's not that much memory in the grand scheme of things, and it removes even more complexity.

Feb 11 2025, 7:22 PM
cmiller_netapp.com added a comment to D48896: Make VLAN hash table fixed width.

Haven't yet looked in detail, but have a quick question. Did you try VLAN_ARRAY option? Many years ago we left it in assumption that in some cases a user may want a full array of VLANs. I wonder if it is still functioning, since it was never compiled by default or advertised.

Feb 11 2025, 7:07 PM

Feb 7 2025

cmiller_netapp.com requested review of D48896: Make VLAN hash table fixed width.
Feb 7 2025, 10:20 PM

Oct 10 2024

cmiller_netapp.com added a watcher for network: cmiller_netapp.com.
Oct 10 2024, 8:43 PM

Mar 5 2024

cmiller_netapp.com added a project to D44250: Deep copy tls_enable struct in copyin_tls_enable: NetApp.
Mar 5 2024, 11:55 PM · NetApp
cmiller_netapp.com requested review of D44250: Deep copy tls_enable struct in copyin_tls_enable.
Mar 5 2024, 11:07 PM · NetApp