tcp: improve failure handling in tcp_newtcpcb()
ClosedPublic
Actions

Authored by tuexen on Jun 26 2024, 8:13 PM.

Details

Reviewers

jtl
rrs
glebius
rscheff
peter.lei_ieee.org
lstewart

Group Reviewers

transport

Commits

rGd02a9ef1f03a: tcp: improve failure handling in tcp_newtcpcb()
rG14fee5324a9b: tcp: improve failure handling in tcp_newtcpcb()

Summary

In case of a failure, where NULL is returned,

call CC_ALGO(tp)->cb_destroy, after CC_ALGO(tp)->cb_init was called.
call khelp_destroy_osd(), after khelp_init_osd() was called.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Jun 26 2024, 8:13 PM

Herald added a reviewer: transport. · View Herald TranscriptJun 26 2024, 8:13 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Jun 26 2024, 8:13 PM

tuexen added a reviewer: lstewart.Jun 26 2024, 8:24 PM

glebius accepted this revision.Jun 27 2024, 3:17 PM

rscheff accepted this revision.Jun 27 2024, 3:18 PM

This revision is now accepted and ready to land.Jun 27 2024, 3:18 PM

peter.lei_ieee.org accepted this revision.Jun 27 2024, 5:37 PM

Closed by commit rG14fee5324a9b: tcp: improve failure handling in tcp_newtcpcb() (authored by tuexen). · Explain WhyJun 27 2024, 5:56 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rG14fee5324a9b: tcp: improve failure handling in tcp_newtcpcb().

tuexen added a commit: rGd02a9ef1f03a: tcp: improve failure handling in tcp_newtcpcb().Aug 3 2024, 10:51 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_subr.c

11 lines

Diff 140310

View Options

tcp: improve failure handling in tcp_newtcpcb()ClosedPublicActions