- User Since
- Jan 22 2015, 5:22 AM (410 w, 1 d)
Tue, Nov 22
Thu, Nov 3
Oct 24 2022
Oct 21 2022
Oct 4 2022
Oct 3 2022
Sep 27 2022
Add the man page entry that Michael requested :)
This updates and gets some of the bits I missed previously.
Sep 26 2022
This will need a few more changes yet.. so its not yet complete.
Sep 21 2022
Sep 20 2022
Sep 19 2022
Take out the commented out old code.
Address Hans ULL comment for clock freq
Sep 9 2022
Addresses comments by jhb & np
Thinking about your "bintime" comment, I think this is probably a good idea, but
I suspect it needs to be applied even broader than in here. You have very similar
code in the Mlx driver since this was my original model. I have a review out on
that side as well making the more highly precision timer fix there.
Sep 8 2022
Aug 30 2022
Aug 25 2022
Fix a comment spelling error as well as reduce out a / and %.
Fix the spelling pointed out by kib. And take Hans suggestion to cut out a / and *.
Aug 24 2022
one more extra line
Address Drew's nits and also get rid of the debugging dump out printing fun.
Take out my debug stuff that I forgot to remove .. opps.. this will now
compile properly and no longer has the calibration query or the float up
of the actual hw_timestamp (had to expand the mbuf to have that and
thats not a good idea in general except for debugging).
Aug 23 2022
Aug 22 2022
Address the rest of Hans comment less one
Fix a nit from review of Peter Lei
After a bit of work and digging I have found on top of the timestamp
issue where LRO is reordering packets. Some in response to the
compressed ack and mbuf queuing. Others in just the normal
old flush paths. In any event this is not desirable for TCP, we need
to see the packets arrive in order. The most horrible one (for TCP)
is where the peer sends a RST followed quickly by a new SYN. This
will get reordered into SYN first then RST.
Aug 11 2022
Aug 8 2022
So if you are not doing soisconnected() here where does it happen at now?
These look ok but I also think it worth having Michael have a look in
case I am missing something ... :)
Aug 4 2022
Just found an interesting bug when SACKs are mixing in with compressed acks. We can
push the acks in the wrong order by remembering the last compressed ack we were filling.
We should NULL the cmp field when it turns out we have to add a packet that is
Drew suggested we use the mbufqueue flag as an indication that
we have stacks that are interested in the M_TSTMP_LRO so we only
do it if thats true.
Aug 1 2022
Jul 18 2022
Jun 30 2022
Jun 27 2022
Ok I have finished testing this and the pkt drills scripts show it works (one change on line 59 though had
to add the push bit.. which is correct).
Jun 2 2022
You need to update files also so that you can compile this
as an option as well i.e.
May 10 2022
Apr 26 2022
Apr 18 2022
Please fix what you broke in the LRO sort code above.
Apr 14 2022
Apr 13 2022
Apr 4 2022
Apr 1 2022
Mar 21 2022
update the comment Michael pointed out.
Mar 16 2022
Thanks for finding the debugging printf I missed in my cleanup. Lets also
take out the "no cc" printf too while we are at it. Only INVARIANT type
printfs as well as kld load failures should be in rack.