Page MenuHomeFreeBSD

rrs (Randall Stewart)
User

Projects

User Details

User Since
Jan 22 2015, 5:22 AM (238 w, 4 d)

Recent Activity

Thu, Aug 15

rrs added a comment to D21127: Final prep patch for BBR.

One more update, mainly comments but we also fix a couple of things

  1. The timestamp provided via the ctf common functions should be the real time not something from the mbuf, we let the transports look at those flags (which both BBR and the latest Rack do).
  2. We also for LRO add a gating of the number of acks (currently set to infinity) that can also cause a wakeup.
Thu, Aug 15, 1:40 PM

Tue, Aug 13

rrs added a comment to D21127: Final prep patch for BBR.

The LRO patch was missing data and length limits for input processing via
MBUF_QUEUE methods. This update adds that and an elaborate set of
comments to the rack_bbr_common.c module describing in detail what
a transport designer using MBUF_QUEUEING needs to contemplate.

Tue, Aug 13, 12:48 PM
rrs committed rS350973: Place back in the dependency on HPTS via module depends versus.
Place back in the dependency on HPTS via module depends versus
Tue, Aug 13, 12:41 PM

Fri, Aug 2

rrs committed rS350537: Fix one more atomic for i86.
Fix one more atomic for i86
Fri, Aug 2, 11:17 AM

Thu, Aug 1

rrs committed rS350521: Opps use fetchadd_u64 not long to keep old 32 bit platforms.
Opps use fetchadd_u64 not long to keep old 32 bit platforms
Thu, Aug 1, 8:26 PM
rrs added reviewers for D21127: Final prep patch for BBR: gallatin, tuexen, transport.
Thu, Aug 1, 2:34 PM
rrs created D21127: Final prep patch for BBR.
Thu, Aug 1, 2:33 PM
Herald added 1 blocking reviewer(s) for D20953: Third patchset in the set of patches to bring BBRv1 into the FreeBSD tree: transport.
Thu, Aug 1, 2:17 PM
rrs committed rS350501: This adds the third step in getting BBR into the tree. BBR and.
This adds the third step in getting BBR into the tree. BBR and
Thu, Aug 1, 2:17 PM
rrs added inline comments to D20953: Third patchset in the set of patches to bring BBRv1 into the FreeBSD tree.
Thu, Aug 1, 12:24 PM
rrs added inline comments to D20953: Third patchset in the set of patches to bring BBRv1 into the FreeBSD tree.
Thu, Aug 1, 12:15 PM

Mon, Jul 29

rrs added inline comments to D18811: nuke sack_newdata.
Mon, Jul 29, 6:16 PM
D21038: DSACK patch to conform fully with RFC2883 now requires changes to proceed.

Please validate the rack_bbr_common.c has (or does not have) the extra bit you added in the early part.

Mon, Jul 29, 6:13 PM
rrs added a comment to D20953: Third patchset in the set of patches to bring BBRv1 into the FreeBSD tree.

I plan on commiting this August 1st unless I hear screams.. its been pending since July 15th....

Mon, Jul 29, 6:07 PM

Sun, Jul 21

rrs added a comment to D20953: Third patchset in the set of patches to bring BBRv1 into the FreeBSD tree.

Update to address Michael's comments about copyright (missing new magic declarations at the top) and
also address an issue where if we have an interface that marks it to "not supporting" we properly
disable the rate limiting for that interface and do not allow the user to enable it (since it does
not support it).

Sun, Jul 21, 4:13 PM

Jul 18 2019

D20980: Add sysctl to use per end point pair TCP timestamp offsets instead of per connection based offsets is now accepted and ready to land.
Jul 18 2019, 11:26 AM

Jul 16 2019

D20971: Fix compilation on platforms using gcc is now accepted and ready to land.
Jul 16 2019, 4:38 PM

Jul 15 2019

rrs added a reviewer for D20953: Third patchset in the set of patches to bring BBRv1 into the FreeBSD tree: hselasky.
Jul 15 2019, 12:09 PM
rrs created D20953: Third patchset in the set of patches to bring BBRv1 into the FreeBSD tree.
Jul 15 2019, 12:08 PM

Jul 14 2019

rrs committed rS349987: This is the second in a number of patches needed to.
This is the second in a number of patches needed to
Jul 14 2019, 4:06 PM
rrs closed D20908: Fixing the DSACK code to properly clean up after sending a DSACK..
Jul 14 2019, 4:06 PM

Jul 12 2019

rrs committed rS349942: add back the comment around the pending DSACK fixes..
add back the comment around the pending DSACK fixes.
Jul 12 2019, 11:45 AM

Jul 11 2019

rrs committed rS349908: Update to jhb's other suggestion, use #error when.
Update to jhb's other suggestion, use #error when
Jul 11 2019, 4:41 AM
rrs committed rS349907: Update copyright per JBH's suggestions.. thanks..
Update copyright per JBH's suggestions.. thanks.
Jul 11 2019, 4:38 AM

Jul 10 2019

rrs created D20908: Fixing the DSACK code to properly clean up after sending a DSACK..
Jul 10 2019, 9:13 PM
rrs abandoned D19878: Updated Rack Stack.
Jul 10 2019, 8:41 PM
rrs committed rS349893: This commit updates rack to what is basically being used at NF as.
This commit updates rack to what is basically being used at NF as
Jul 10 2019, 8:41 PM
rrs closed D20834: First step in bring hpts and infrastructure up for bbr v1 update part1.
Jul 10 2019, 8:41 PM
rrs added a comment to D20834: First step in bring hpts and infrastructure up for bbr v1 update part1.

Add in the hopeless exit to tcp_hpts and also get the corrected (with DSACK patch) rack_18q22p2

Jul 10 2019, 3:20 PM
rrs added a comment to D20834: First step in bring hpts and infrastructure up for bbr v1 update part1.

Update to include some fixes Michael and I have been working on in a slow slow machine as well
as bring the Rack stack up to the latest production (with some small changes to make it compile).

Jul 10 2019, 11:00 AM

Jul 3 2019

rrs added a comment to D20834: First step in bring hpts and infrastructure up for bbr v1 update part1.

And we can't loose the commented out opt_kern_tls until the kern tls hits the tree

Jul 3 2019, 8:12 PM
rrs added a comment to D20834: First step in bring hpts and infrastructure up for bbr v1 update part1.

It helps if one remembers to bring the changes of the .h file too ... opps

Jul 3 2019, 8:09 PM
rrs added a comment to D20834: First step in bring hpts and infrastructure up for bbr v1 update part1.

Address phabricator nits

Jul 3 2019, 1:08 PM
D20834: First step in bring hpts and infrastructure up for bbr v1 update part1 now requires review to proceed.

In my detailed testing of hpts I found we are *not* doing the right thing as to calculating
the time for sleep. The code was starting at where the prev_slot was and moving
through counting the slots until it found a non-empty slot.

Jul 3 2019, 12:59 PM

Jul 2 2019

rrs added a comment to D20834: First step in bring hpts and infrastructure up for bbr v1 update part1.

So interestingly those includes are not needed.. not even sure the tls one is need (hwtls should be in the tree soon).. however more
interesting is why my freebsd head build works.. not sure why since it does not have hwtls in the mix.. need to go check whats going
on in my conf.

Jul 2 2019, 1:01 PM
rrs updated the diff for D20834: First step in bring hpts and infrastructure up for bbr v1 update part1.
Jul 2 2019, 1:00 PM
rrs updated the diff for D20834: First step in bring hpts and infrastructure up for bbr v1 update part1.
Jul 2 2019, 12:50 PM
rrs created D20834: First step in bring hpts and infrastructure up for bbr v1 update part1.
Jul 2 2019, 10:32 AM

Jun 28 2019

D20616: Add a new external mbuf type that holds multiple unmapped pages. is now accepted and ready to land.
Jun 28 2019, 3:43 PM

Jun 5 2019

rrs added a comment to D20110: Fix infinite loop on older hardware.

sorry wrong revision.. the trouble is in the DSACK commit which is r347382... thats what we are backing out of our sync... (off by
one error.. must be a programmer :-) )

Jun 5 2019, 6:51 PM
rrs added a comment to D20110: Fix infinite loop on older hardware.

There are for more problems then this. And its not explicitly with HPTS but it becomes the canary in the coal mine.
The basic problem is in r347381. This cause a huge slow down to the system at least with INVARIANTs. Hpts in
the form you are dealing with does handle wheel wrap well. We are backing out that change in our upstream
merge. And there will be changes I will be committing to fix wheel_wrap in hpts.

Jun 5 2019, 6:47 PM
rrs accepted D20372: Fix TCP RACK after adding DSACK support.
Jun 5 2019, 9:58 AM

May 9 2019

rrs accepted D20134: Bind TCP HPTS (pacer) threads to NUMA domains.
May 9 2019, 4:50 PM

Apr 10 2019

rrs created D19878: Updated Rack Stack.
Apr 10 2019, 7:48 PM
rrs committed rS346094: Fix a small bug in the tcp_log_id where the bucket.
Fix a small bug in the tcp_log_id where the bucket
Apr 10 2019, 6:58 PM

Apr 3 2019

rrs committed rS345851: Undo my previous erroneous commit changing the tcp_output kassert..
Undo my previous erroneous commit changing the tcp_output kassert.
Apr 3 2019, 7:35 PM

Mar 27 2019

rrs accepted D19334: Receiver Side DSACK (RFC2883) implementation.
Mar 27 2019, 4:09 PM

Mar 26 2019

rrs committed rS345527: Fix a small bug in the tcp_log_id where the bucket.
Fix a small bug in the tcp_log_id where the bucket
Mar 26 2019, 10:41 AM

Mar 23 2019

rrs accepted D19687: Fix KASSERT in tcp_output().
Mar 23 2019, 9:52 AM

Mar 19 2019

rrs abandoned D19611: Incorrect KASSERT.
Mar 19 2019, 5:36 PM

Mar 18 2019

rrs accepted D19355: Make RTO.Initial for TCP controllable via sysctl.
Mar 18 2019, 1:01 PM

Mar 17 2019

rrs updated the diff for D19611: Incorrect KASSERT.
Mar 17 2019, 1:22 PM
rrs created D19611: Incorrect KASSERT.
Mar 17 2019, 1:15 PM

Feb 21 2019

rrs accepted D18960: Patch to MFC TCP reassembly rewrite to stable/11.
Feb 21 2019, 12:21 PM

Feb 20 2019

rrs accepted D19254: Avoid dereferencing a NULL pointer when TCP_REASS_LOGGING is enabled.
Feb 20 2019, 8:31 PM
rrs accepted D18974: Use exponential backoff also for SYN segments.
Feb 20 2019, 12:08 PM

Feb 19 2019

rrs accepted D19152: Various cleanups to the management of multiple TCP stacks..
Feb 19 2019, 11:22 AM

Feb 13 2019

rrs created D19179: Crashing in a race with SOCK_DGRAM and unix domain sockets.
Feb 13 2019, 3:04 PM
rrs committed rS344099: This commit adds the missing release mechanism for the.
This commit adds the missing release mechanism for the
Feb 13 2019, 2:58 PM
rrs closed D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.
Feb 13 2019, 2:58 PM

Feb 11 2019

rrs updated the diff for D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.

get the update in and fix the pesky extra line.

Feb 11 2019, 12:37 PM

Feb 4 2019

rrs accepted D19071: Get TCP CDG CC working if net.inet.tcp.cc.cdg.smoothing_factor = 0 .
Feb 4 2019, 4:25 PM
rrs added inline comments to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.
Feb 4 2019, 12:11 PM

Feb 1 2019

rrs added inline comments to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.
Feb 1 2019, 4:05 PM
rrs updated the diff for D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.

Update to hopefully get a better view and not have the stray line in the diff

Feb 1 2019, 4:04 PM
rrs added a comment to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.

Interesting my svn copy does not have that extra chunk.. let me re-update the diff and use -x -up

Feb 1 2019, 4:03 PM
rrs added inline comments to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.
Feb 1 2019, 4:01 PM
rrs updated the diff for D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.

This updates the diff to Fix Hann's point on vlans, both the
vlan and lagg are now balanced.

Feb 1 2019, 12:31 PM
rrs added a comment to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.

Ahh good catch I did not know vlan had an allocator.. I will add it to the patch-set

Feb 1 2019, 12:18 PM
rrs accepted D19033: Initialise snd_wnd on the server side always before processing the ack.
Feb 1 2019, 11:26 AM

Jan 31 2019

rrs added a comment to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.

I don't follow your suggestion. Why would I add a if_snd_tag_free() in if_attach_internal() .
The driver below has to do that just like it has to add the if_snd_tag_alloc(). The
internal function has no way of knowing what is the right thing to do in
freeing a tag that the driver allocates. Having it be NULL as the default in
the internal just the same as if_snd_tag_alloc() is the right thing, only
if a driver sets these should they get used (when RATELIMIT is configured of course)

Jan 31 2019, 8:07 PM

Jan 30 2019

rrs added a comment to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.

Hi,
This patch does not look correct. You will need to pass the flowid in order to correctly handle this inside lagg?
Why are you not using the tag->ifp->if_sndtag_free(tag) in the first place?
--HPS

Hann's

Jan 30 2019, 4:31 PM
rrs created D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.
Jan 30 2019, 1:43 PM

Dec 17 2018

rrs accepted D18580: Accept always TCP segment with SEG.SEQ==RCV.NXT.
Dec 17 2018, 9:43 PM
rrs added inline comments to D18580: Accept always TCP segment with SEG.SEQ==RCV.NXT.
Dec 17 2018, 4:59 PM
rrs requested changes to D18580: Accept always TCP segment with SEG.SEQ==RCV.NXT.
Dec 17 2018, 4:55 PM

Nov 29 2018

rrs accepted D18366: Limit option_len for the TCP_CCALGOOPT option.
Nov 29 2018, 5:19 PM
rrs accepted D18375: Improve receive window autoscaling for TCP.
Nov 29 2018, 5:19 PM

Nov 21 2018

rrs accepted D18021: Improve KASSERTs in rack.c.

Good catch Michael!!!

Nov 21 2018, 12:30 PM

Nov 20 2018

rrs accepted D18033: TCP RACK stack should honor net.inet.tcp.drop_synfin sysctl variable.

Looks good to me :)

Nov 20 2018, 11:01 PM
rrs accepted D18032: Support RTT measurement even if switching from the rack stack to the base stack.
Nov 20 2018, 9:36 PM
rrs accepted D18034: The TCP RACK stack need to verify SEG.ACK first when in SYS-SENT state.
Nov 20 2018, 1:07 PM
rrs added inline comments to D18032: Support RTT measurement even if switching from the rack stack to the base stack.
Nov 20 2018, 12:59 PM
rrs accepted D18021: Improve KASSERTs in rack.c.
Nov 20 2018, 12:57 PM
rrs accepted D17949: Advertise a zero window when sending TCP RST segments via tcp_output().

This looks fine Michael :)

Nov 20 2018, 12:53 PM

Oct 18 2018

rrs accepted D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.
Oct 18 2018, 6:04 PM

Oct 16 2018

rrs accepted D17588: Fix TCP module unloading code to work with epoch(9) changes.
Oct 16 2018, 6:10 PM

Aug 28 2018

rrs accepted D16912: Fix TCP Fast Open for TCP RACK.
Aug 28 2018, 5:00 AM

Aug 27 2018

rrs added inline comments to D16912: Fix TCP Fast Open for TCP RACK.
Aug 27 2018, 3:07 PM
rrs accepted D16891: Make tcp_hpts compile with option RSS.

Because in order to conserve space the fid in the in_pcb (IIRR) is a uint16_t.. I was thinking
64k cpu's is probably enough for now :)

Aug 27 2018, 2:55 PM

Aug 21 2018

rrs accepted D16791: Add support for SO_DOMAIN in getsockopt().
Aug 21 2018, 1:23 PM
rrs accepted D16792: Fix inheritance of IPv6 options.
Aug 21 2018, 1:22 PM
rrs accepted D16796: Fix IPV6_USE_MIN_MTU socket option for TCP sockets.
Aug 21 2018, 1:22 PM

Aug 20 2018

rrs committed rS338102: This change represents a substantial restructure of the way we.
This change represents a substantial restructure of the way we
Aug 20 2018, 12:43 PM
rrs closed D16626: Rewrite of TCP Reassembly code.
Aug 20 2018, 12:43 PM

Aug 18 2018

rrs added inline comments to D16626: Rewrite of TCP Reassembly code.
Aug 18 2018, 7:17 PM
rrs updated the diff for D16626: Rewrite of TCP Reassembly code.

Fix the silly cut and paste bug.

Aug 18 2018, 7:15 PM
rrs updated the diff for D16626: Rewrite of TCP Reassembly code.

This version incorporates all of Jonathans comments and suggested improvements. Thanks
Jonathan!!!

Aug 18 2018, 7:01 AM

Aug 10 2018

rrs updated the diff for D16626: Rewrite of TCP Reassembly code.

This version updates from the last to include all of Lawrence Stewarts comments
as well as those from Peter Lei. A significant change is altering the calculate
overhead function to also glean the mlast so that a second walk of the mbuf
chain is no longer needed.

Aug 10 2018, 11:59 AM

Aug 9 2018

rrs accepted D16636: Improve TCP timestamps.
Aug 9 2018, 10:11 AM