Page MenuHomeFreeBSD

rrs (Randall Stewart)
User

Projects

User Details

User Since
Jan 22 2015, 5:22 AM (264 w, 6 d)

Recent Activity

Yesterday

rrs accepted D23647: TCP Ratelimit code update.
Tue, Feb 18, 12:07 PM
rrs updated the diff for D23647: TCP Ratelimit code update.

Update comments and name of the mss function per the comments in the review.

Tue, Feb 18, 12:07 PM
rrs added inline comments to D23647: TCP Ratelimit code update.
Tue, Feb 18, 11:44 AM

Wed, Feb 12

rrs added inline comments to D23647: TCP Ratelimit code update.
Wed, Feb 12, 3:39 PM
rrs updated the diff for D23647: TCP Ratelimit code update.

Address Hans comments, also fix the issue I had
when I back things out (the net epoch macro should have
been in the source).. also add just a few more comments and
fix a spelling error in one.

Wed, Feb 12, 3:38 PM
rrs committed rS357823: Lets get the real correct version.. gessh. I need.
Lets get the real correct version.. gessh. I need
Wed, Feb 12, 3:27 PM
rrs created D23647: TCP Ratelimit code update.
Wed, Feb 12, 2:14 PM
rrs committed rS357819: Opps committed the wrong ratelimit version in the.
Opps committed the wrong ratelimit version in the
Wed, Feb 12, 1:37 PM
rrs committed rS357818: White space cleanup -- remove trailing tab's or spaces.
White space cleanup -- remove trailing tab's or spaces
Wed, Feb 12, 1:31 PM
rrs committed rS357817: Whitespace, remove from three files trailing white.
Whitespace, remove from three files trailing white
Wed, Feb 12, 1:07 PM
rrs closed D23645: ECN incorrectly set.
Wed, Feb 12, 1:04 PM
rrs committed rS357816: This small fix makes it so we properly follow.
This small fix makes it so we properly follow
Wed, Feb 12, 1:04 PM
rrs added reviewers for D23645: ECN incorrectly set: tuexen, transport.
Wed, Feb 12, 12:45 PM
rrs created D23645: ECN incorrectly set.
Wed, Feb 12, 12:44 PM
rrs committed rS357815: Remove all trailing white space from the BBR/Rack fold. Bits.
Remove all trailing white space from the BBR/Rack fold. Bits
Wed, Feb 12, 12:40 PM
rrs committed rS357814: Now that all of the stats framework is.
Now that all of the stats framework is
Wed, Feb 12, 12:37 PM
rrs closed D23088: Remove the tied stats restriction to NETFLIX_STATS.
Wed, Feb 12, 12:37 PM
rrs accepted D23088: Remove the tied stats restriction to NETFLIX_STATS.
Wed, Feb 12, 12:01 PM

Fri, Jan 24

rrs accepted D23212: Fix server side TCP fast open.
Fri, Jan 24, 12:44 PM

Jan 8 2020

rrs created D23088: Remove the tied stats restriction to NETFLIX_STATS.
Jan 8 2020, 5:05 PM

Jan 6 2020

rrs accepted D22971: Fix race when accepting TCP connections.
Jan 6 2020, 3:38 PM
rrs committed rS356417: This catches rack up in the recent changes to ECN and.
This catches rack up in the recent changes to ECN and
Jan 6 2020, 3:29 PM
rrs closed D23052: Apply the same ECN updates that were in the default stack..
Jan 6 2020, 3:29 PM
rrs created D23052: Apply the same ECN updates that were in the default stack..
Jan 6 2020, 1:19 PM
rrs closed D22479: Fix up several sysctl that now should apply to both BBR and Rack as well as prepare for BBR to get experimental SaD.

Commited

Jan 6 2020, 1:03 PM
rrs closed D22866: Update tcp_logging to have two new features.
Jan 6 2020, 12:48 PM
rrs committed rS356414: This change adds a small feature to the tcp logging code. Basically.
This change adds a small feature to the tcp logging code. Basically
Jan 6 2020, 12:48 PM
rrs accepted D22866: Update tcp_logging to have two new features.
Jan 6 2020, 12:26 PM

Dec 18 2019

rrs created D22866: Update tcp_logging to have two new features.
Dec 18 2019, 12:59 PM

Dec 17 2019

rrs committed rS355859: This commit is a bit of a re-arrange of deck chairs. It.
This commit is a bit of a re-arrange of deck chairs. It
Dec 17 2019, 4:08 PM
rrs accepted D22704: Remove superfluous trailing whitespaces in TCP source files.

I am happy with one commit that cleans it all up :)

Dec 17 2019, 3:43 PM

Dec 4 2019

rrs accepted D22669: Add support for rate limited TLS send tags.
Dec 4 2019, 12:17 PM
rrs accepted D22479: Fix up several sysctl that now should apply to both BBR and Rack as well as prepare for BBR to get experimental SaD.
Dec 4 2019, 12:15 PM

Nov 22 2019

rrs accepted D21798: Restrict cwnd growth on app-limited flows.
Nov 22 2019, 11:29 AM
rrs accepted D22497: Moving all ECN related flags to flags2.
Nov 22 2019, 11:29 AM

Nov 21 2019

rrs accepted D22428: Editorial change to enhance readability of the TF_* bit constants.
Nov 21 2019, 9:25 PM
rrs accepted D22426: Add access to TOS(ECN bits) byte in TCP RACK.
Nov 21 2019, 9:19 PM
rrs accepted D22436: Add access to TOS(ECN bits) to the TCP syncache.
Nov 21 2019, 8:25 PM
rrs requested changes to D21798: Restrict cwnd growth on app-limited flows.

You cannot use tcp_compute_pipe() with rack. It does not use
the same variables as the default stack. Instead you must use the
ctf_flight_size() function to get whats in flight.

Nov 21 2019, 8:14 PM
rrs accepted D22267: Make sure the 'struct tcp_info' is stable.
Nov 21 2019, 8:09 PM
rrs updated the diff for D22479: Fix up several sysctl that now should apply to both BBR and Rack as well as prepare for BBR to get experimental SaD.
Nov 21 2019, 3:31 PM
rrs retitled D22479: Fix up several sysctl that now should apply to both BBR and Rack as well as prepare for BBR to get experimental SaD from Fix up several sysctl to Fix up several sysctl that now should apply to both BBR and Rack as well as prepare for BBR to get experimental SaD.
Nov 21 2019, 3:27 PM
rrs created D22479: Fix up several sysctl that now should apply to both BBR and Rack as well as prepare for BBR to get experimental SaD.
Nov 21 2019, 3:23 PM

Nov 2 2019

rrs closed D21582: Ok after several years here is BBR..
Nov 2 2019, 6:10 PM

Oct 24 2019

rrs committed rS354013: Fix a small bug in bbr when running under a VM. Basically what.
Fix a small bug in bbr when running under a VM. Basically what
Oct 24 2019, 5:54 AM

Oct 14 2019

rrs committed rS353490: if_hw_tsomaxsegsize needs to be initialized to zero, just.
if_hw_tsomaxsegsize needs to be initialized to zero, just
Oct 14 2019, 1:10 PM

Oct 6 2019

rrs committed rS353156: Brad Davis identified a problem with the new LRO code, VLAN's.
Brad Davis identified a problem with the new LRO code, VLAN's
Oct 6 2019, 10:29 PM

Sep 28 2019

rrs added a comment to D21669: mtod macro: Drop the type argument.

Well I am going to voice a different view. I do *not* see this as a nice cleanup. I see it
has a lessening of information.

Sep 28 2019, 9:27 AM
rrs accepted D21825: Fix locking for some RACK specific socket options.
Sep 28 2019, 9:21 AM

Sep 24 2019

rrs committed rS352661: lets put (void) in a couple of functions to keep older platforms that.
lets put (void) in a couple of functions to keep older platforms that
Sep 24 2019, 8:36 PM
rrs committed rS352660: don't call in_ratelmit detach when RATELIMIT is not.
don't call in_ratelmit detach when RATELIMIT is not
Sep 24 2019, 8:12 PM
rrs committed rS352659: Fix the ifdefs in tcp_ratelimit.h. They were reversed so.
Fix the ifdefs in tcp_ratelimit.h. They were reversed so
Sep 24 2019, 8:04 PM
rrs committed rS352657: This commit adds BBR (Bottleneck Bandwidth and RTT) congestion control. This.
This commit adds BBR (Bottleneck Bandwidth and RTT) congestion control. This
Sep 24 2019, 6:18 PM

Sep 23 2019

rrs accepted D21582: Ok after several years here is BBR..
Sep 23 2019, 8:41 PM

Sep 20 2019

rrs accepted D21644: During SYN floods, fallback exclusively to SYN cookies for a small period.
Sep 20 2019, 1:15 PM

Sep 17 2019

rrs updated the diff for D21582: Ok after several years here is BBR..

This updates the patch set, the ktls.h information was incorrect. I also add the fixes
that Michael is doing on the Rack side to BBR as well (check for invalid length in non-tso case).

Sep 17 2019, 2:47 PM
rrs accepted D21527: Add SIOCGIFDOWNREASON.
Sep 17 2019, 12:59 PM
rrs accepted D21644: During SYN floods, fallback exclusively to SYN cookies for a small period.
Sep 17 2019, 12:55 PM
rrs accepted D21666: Let the RACK stack take IP options into account when computing the space for user data in TCP segments.
Sep 17 2019, 12:48 PM

Sep 11 2019

rrs committed rS352215: With the recent commit of ktls, we no longer have a.
With the recent commit of ktls, we no longer have a
Sep 11 2019, 3:41 PM

Sep 10 2019

rrs accepted D21591: avoid unneeded call to arc4random() in syncache_add().
Sep 10 2019, 7:48 PM
rrs created D21582: Ok after several years here is BBR..
Sep 10 2019, 11:41 AM

Sep 9 2019

rrs accepted D21567: Improve DSACK computation.
Sep 9 2019, 3:16 PM
rrs requested changes to D21567: Improve DSACK computation.

I would like to see the Rack version of the code be identical to the tcp_input version.. i.e. it should check

Sep 9 2019, 9:44 AM

Sep 6 2019

rrs closed D21127: Final prep patch for BBR.
Sep 6 2019, 6:30 PM
rrs committed rS351951: This adds in the missing counter initialization which.
This adds in the missing counter initialization which
Sep 6 2019, 6:29 PM
rrs committed rS351934: This adds the final tweaks to LRO that will now allow me.
This adds the final tweaks to LRO that will now allow me
Sep 6 2019, 2:25 PM
rrs closed D21127: Final prep patch for BBR.
Sep 6 2019, 2:25 PM

Sep 3 2019

rrs accepted D21513: Fix TCP SACK block generation in the base stack.
Sep 3 2019, 9:35 PM
rrs accepted D21512: Fix two TCP Rack issues.
Sep 3 2019, 7:07 PM
rrs updated the diff for D21127: Final prep patch for BBR.

First version was missing a (void) in the registration function.. opps

Sep 3 2019, 12:06 PM
rrs updated the diff for D21127: Final prep patch for BBR.

This adds a simple registration mechanism that stacks can use as they successfully register/deregister to
make the LRO code aware if any stack wants to use mbuf-queueing per Drew's suggestion.

Sep 3 2019, 11:55 AM
rrs added inline comments to D21127: Final prep patch for BBR.
Sep 3 2019, 11:38 AM

Aug 26 2019

D21416: Improve locking in tcp_ratelimit.c is now accepted and ready to land.
Aug 26 2019, 2:45 PM

Aug 21 2019

D21277: Add kernel-side support for in-kernel TLS. is now accepted and ready to land.
Aug 21 2019, 10:56 AM
rrs committed rS351328: Fix an issue when TSO and Rack play together. Basically.
Fix an issue when TSO and Rack play together. Basically
Aug 21 2019, 10:45 AM

Aug 15 2019

rrs added a comment to D21127: Final prep patch for BBR.

One more update, mainly comments but we also fix a couple of things

  1. The timestamp provided via the ctf common functions should be the real time not something from the mbuf, we let the transports look at those flags (which both BBR and the latest Rack do).
  2. We also for LRO add a gating of the number of acks (currently set to infinity) that can also cause a wakeup.
Aug 15 2019, 1:40 PM

Aug 13 2019

rrs added a comment to D21127: Final prep patch for BBR.

The LRO patch was missing data and length limits for input processing via
MBUF_QUEUE methods. This update adds that and an elaborate set of
comments to the rack_bbr_common.c module describing in detail what
a transport designer using MBUF_QUEUEING needs to contemplate.

Aug 13 2019, 12:48 PM
rrs committed rS350973: Place back in the dependency on HPTS via module depends versus.
Place back in the dependency on HPTS via module depends versus
Aug 13 2019, 12:41 PM

Aug 2 2019

rrs committed rS350537: Fix one more atomic for i86.
Fix one more atomic for i86
Aug 2 2019, 11:17 AM

Aug 1 2019

rrs committed rS350521: Opps use fetchadd_u64 not long to keep old 32 bit platforms.
Opps use fetchadd_u64 not long to keep old 32 bit platforms
Aug 1 2019, 8:26 PM
rrs added reviewers for D21127: Final prep patch for BBR: gallatin, tuexen, transport.
Aug 1 2019, 2:34 PM
rrs created D21127: Final prep patch for BBR.
Aug 1 2019, 2:33 PM
Herald added 1 blocking reviewer(s) for D20953: Third patchset in the set of patches to bring BBRv1 into the FreeBSD tree: transport.
Aug 1 2019, 2:17 PM
rrs committed rS350501: This adds the third step in getting BBR into the tree. BBR and.
This adds the third step in getting BBR into the tree. BBR and
Aug 1 2019, 2:17 PM
rrs added inline comments to D20953: Third patchset in the set of patches to bring BBRv1 into the FreeBSD tree.
Aug 1 2019, 12:24 PM
rrs added inline comments to D20953: Third patchset in the set of patches to bring BBRv1 into the FreeBSD tree.
Aug 1 2019, 12:15 PM

Jul 29 2019

rrs added inline comments to D18811: nuke sack_newdata.
Jul 29 2019, 6:16 PM
D21038: DSACK patch to conform fully with RFC2883 now requires changes to proceed.

Please validate the rack_bbr_common.c has (or does not have) the extra bit you added in the early part.

Jul 29 2019, 6:13 PM
rrs added a comment to D20953: Third patchset in the set of patches to bring BBRv1 into the FreeBSD tree.

I plan on commiting this August 1st unless I hear screams.. its been pending since July 15th....

Jul 29 2019, 6:07 PM

Jul 21 2019

rrs added a comment to D20953: Third patchset in the set of patches to bring BBRv1 into the FreeBSD tree.

Update to address Michael's comments about copyright (missing new magic declarations at the top) and
also address an issue where if we have an interface that marks it to "not supporting" we properly
disable the rate limiting for that interface and do not allow the user to enable it (since it does
not support it).

Jul 21 2019, 4:13 PM

Jul 18 2019

D20980: Add sysctl to use per end point pair TCP timestamp offsets instead of per connection based offsets is now accepted and ready to land.
Jul 18 2019, 11:26 AM

Jul 16 2019

D20971: Fix compilation on platforms using gcc is now accepted and ready to land.
Jul 16 2019, 4:38 PM

Jul 15 2019

rrs added a reviewer for D20953: Third patchset in the set of patches to bring BBRv1 into the FreeBSD tree: hselasky.
Jul 15 2019, 12:09 PM
rrs created D20953: Third patchset in the set of patches to bring BBRv1 into the FreeBSD tree.
Jul 15 2019, 12:08 PM

Jul 14 2019

rrs committed rS349987: This is the second in a number of patches needed to.
This is the second in a number of patches needed to
Jul 14 2019, 4:06 PM
rrs closed D20908: Fixing the DSACK code to properly clean up after sending a DSACK..
Jul 14 2019, 4:06 PM

Jul 12 2019

rrs committed rS349942: add back the comment around the pending DSACK fixes..
add back the comment around the pending DSACK fixes.
Jul 12 2019, 11:45 AM

Jul 11 2019

rrs committed rS349908: Update to jhb's other suggestion, use #error when.
Update to jhb's other suggestion, use #error when
Jul 11 2019, 4:41 AM
rrs committed rS349907: Update copyright per JBH's suggestions.. thanks..
Update copyright per JBH's suggestions.. thanks.
Jul 11 2019, 4:38 AM