Page MenuHomeFreeBSD

rrs (Randall Stewart)
User

Projects

User Details

User Since
Jan 22 2015, 5:22 AM (461 w, 5 d)

Recent Activity

Yesterday

rrs committed rG6a79e48076bc: Fix two latent bugs in hpts. One where a static is put on (authored by rrs).
Fix two latent bugs in hpts. One where a static is put on
Mon, Nov 27, 7:40 PM

Thu, Nov 16

rrs accepted D28822: Add PRR 6937bis heuristic and remove prr_conservative sysctl.
Thu, Nov 16, 3:31 PM
rrs accepted D41672: tcp: add cubic_compute_pipe.
Thu, Nov 16, 3:16 PM

Oct 5 2023

rrs accepted D42031: Improve sending UDP messages using IPv6 mapped addresses.
Oct 5 2023, 3:24 PM
rrs accepted D39299: tcp: include RFC6675 IsLost() in pipe calculation.
Oct 5 2023, 3:10 PM

Oct 4 2023

rrs committed rG8818f0f1124e: TCP: Fix a rack bug that skyzall found which results in a crash. (authored by rrs).
TCP: Fix a rack bug that skyzall found which results in a crash.
Oct 4 2023, 7:20 PM

Sep 7 2023

rrs accepted D41715: tcp: Align cubic cc with rfc9438.
Sep 7 2023, 3:35 PM

Jul 13 2023

rrs accepted D41010: Fix building of TCP CC modules depending on TCP_HHOOK.
Jul 13 2023, 3:19 PM

Jun 28 2023

rrs committed rG96eb0d90cd75: tcp: With the right options in the kernel cc_cubic stays in slowstart always. (authored by rrs).
tcp: With the right options in the kernel cc_cubic stays in slowstart always.
Jun 28 2023, 3:21 PM
rrs closed D40761: tcp: With the right options in the kernel cc_cubic stays in slowstart always..
Jun 28 2023, 3:20 PM

Jun 27 2023

rrs updated the diff for D40761: tcp: With the right options in the kernel cc_cubic stays in slowstart always..

After looking at this and thinking on it changing the structure is the *wrong* approach since it leaves a landmine in place
that can get someone if they don't include opt_inet.h. The better choice is to make all things that ifdef in the tcppcb to
be in opt_global.h so that the entire kernel always knows what tcpcb looks like.

Jun 27 2023, 11:13 AM

Jun 26 2023

rrs requested review of D40761: tcp: With the right options in the kernel cc_cubic stays in slowstart always..
Jun 26 2023, 9:56 PM

Jun 9 2023

rrs closed D40391: tcp: Rack fixes and misc updates.
Jun 9 2023, 2:27 PM
rrs committed rGe022f2b0131a: tcp: Rack fixes and misc updates (authored by rrs).
tcp: Rack fixes and misc updates
Jun 9 2023, 2:27 PM

Jun 2 2023

rrs requested review of D40391: tcp: Rack fixes and misc updates.
Jun 2 2023, 1:51 PM

May 24 2023

rrs closed D40229: tcp: request tracking is not http specific..
May 24 2023, 2:35 PM
rrs committed rG57a3a161a92f: tcp: request tracking is not http specific. (authored by rrs).
tcp: request tracking is not http specific.
May 24 2023, 1:30 PM

May 23 2023

rrs requested review of D40229: tcp: request tracking is not http specific..
May 23 2023, 1:58 PM

May 19 2023

rrs committed rG72ae93825244: Add a comment to the new tcp_get_srtt method to clarify that ticks (authored by rrs).
Add a comment to the new tcp_get_srtt method to clarify that ticks
May 19 2023, 7:55 PM
rrs committed rGec6d620b197e: There are congestion control algorithms will that pull in srtt, and this can… (authored by rrs).
There are congestion control algorithms will that pull in srtt, and this can…
May 19 2023, 3:18 PM
rrs closed D40146: There are congestion control algorithms will that pull in srtt, and this can cause issues with rack..
May 19 2023, 3:18 PM

May 18 2023

rrs requested review of D40146: There are congestion control algorithms will that pull in srtt, and this can cause issues with rack..
May 18 2023, 5:31 PM
rrs accepted D40061: Under RSS, assign a TCP flow's inp_flowid anyway..
May 18 2023, 3:10 PM

Apr 21 2023

rrs committed rG01216268f89e: tcp: hpts needs to still call output even after input. (authored by rrs).
tcp: hpts needs to still call output even after input.
Apr 21 2023, 11:13 AM
rrs closed D39738: tcp: hpts needs to still call output even after input..
Apr 21 2023, 11:12 AM

Apr 20 2023

rrs requested review of D39738: tcp: hpts needs to still call output even after input..
Apr 20 2023, 7:45 PM
rrs accepted D39736: netstat: fix printing of TCP pcbs with -A.
Apr 20 2023, 7:38 PM
rrs accepted D39688: netstat: cleanup.
Apr 20 2023, 3:07 PM
rrs accepted D39698: tcp: move HPTS/LRO flags out of inpcb to tcpcb.

Why if 0x10000 is not used would it matter?

Apr 20 2023, 1:06 PM
rrs accepted D39697: tcp_hpts: move HPTS related fields from inpcb to tcpcb.
Apr 20 2023, 1:03 PM
rrs accepted D39696: tcp: purge the input queue from tcp_discardcb().
Apr 20 2023, 1:02 PM

Apr 19 2023

rrs closed D39699: tcp: rack the request level logging is a bit too noisy when doing point logging..
Apr 19 2023, 6:02 PM
rrs committed rG4e8a20a7642a: tcp: rack the request level logging is a bit too noisy when doing point logging. (authored by rrs).
tcp: rack the request level logging is a bit too noisy when doing point logging.
Apr 19 2023, 6:02 PM
rrs requested review of D39699: tcp: rack the request level logging is a bit too noisy when doing point logging..
Apr 19 2023, 5:53 PM
rrs committed rG7a842346c3cd: tcp: Rack can crash with the new non-TSO fix.. (authored by rrs).
tcp: Rack can crash with the new non-TSO fix..
Apr 19 2023, 5:17 PM
rrs closed D39690: tcp: Rack can crash with the new non-TSO fix...
Apr 19 2023, 5:17 PM
rrs committed rG303246dcdf44: We have a TCP_LOG_CONNEND log that should come out at the very last log of… (authored by rrs).
We have a TCP_LOG_CONNEND log that should come out at the very last log of…
Apr 19 2023, 4:54 PM
rrs closed D39693: tcp: Ending BB logs not always coming out.
Apr 19 2023, 4:54 PM
rrs updated the diff for D39693: tcp: Ending BB logs not always coming out.

Ensure it compiles when we don't have TCP_ACCOUNTING on

Apr 19 2023, 3:47 PM
rrs updated the diff for D39693: tcp: Ending BB logs not always coming out.

fix stray space

Apr 19 2023, 3:30 PM
rrs requested review of D39693: tcp: Ending BB logs not always coming out.
Apr 19 2023, 3:27 PM
rrs requested review of D39690: tcp: Rack can crash with the new non-TSO fix...
Apr 19 2023, 1:03 PM
rrs accepted D39436: trpt: fix logging.
Apr 19 2023, 11:15 AM
rrs accepted D39591: tcp: improve logging for PRUs .
Apr 19 2023, 11:13 AM
rrs committed rG960985a209f2: tcp: bbr.c is non-capable of doing ECN and sets an INP flag to fend off ECN… (authored by rrs).
tcp: bbr.c is non-capable of doing ECN and sets an INP flag to fend off ECN…
Apr 19 2023, 11:10 AM
rrs closed D39672: tcp: bbr.c is non-capable of doing ECN and sets an INP flag to fend off ECN however our syncache is not aware of that flag..
Apr 19 2023, 11:10 AM

Apr 18 2023

rrs requested review of D39672: tcp: bbr.c is non-capable of doing ECN and sets an INP flag to fend off ECN however our syncache is not aware of that flag..
Apr 18 2023, 8:18 PM
rrs closed D39653: tcp: Inconsistent use of hpts_calling flag.
Apr 18 2023, 4:02 PM
rrs committed rG2ad584c5551d: tcp: Inconsistent use of hpts_calling flag (authored by rrs).
tcp: Inconsistent use of hpts_calling flag
Apr 18 2023, 3:58 PM
rrs updated the diff for D39653: tcp: Inconsistent use of hpts_calling flag.

Almost forgot, when going through the compressed ack path we will need to possibly nuke the flag too if
output did not occur...

Apr 18 2023, 2:13 PM
rrs requested review of D39653: tcp: Inconsistent use of hpts_calling flag.
Apr 18 2023, 1:08 PM
rrs committed rG37229fed38c6: tcp: Blackbox logging and tcp accounting together can cause a crash. (authored by rrs).
tcp: Blackbox logging and tcp accounting together can cause a crash.
Apr 18 2023, 12:40 PM
rrs closed D39622: tcp: Blackbox logging and tcp accounting together can cause a crash..
Apr 18 2023, 12:40 PM

Apr 17 2023

rrs updated the diff for D39622: tcp: Blackbox logging and tcp accounting together can cause a crash..

Opps lets get the sets of the log union in the right place.

Apr 17 2023, 7:11 PM
rrs requested review of D39622: tcp: Blackbox logging and tcp accounting together can cause a crash..
Apr 17 2023, 7:06 PM

Apr 14 2023

rrs closed D39576: tcp: stack unloading crash in rack and bbr.
Apr 14 2023, 7:52 PM
rrs committed rG3cc7b6673280: tcp: stack unloading crash in rack and bbr (authored by rrs).
tcp: stack unloading crash in rack and bbr
Apr 14 2023, 7:44 PM
rrs requested review of D39576: tcp: stack unloading crash in rack and bbr.
Apr 14 2023, 6:55 PM
rrs accepted D39574: tcp_hpts: use queue(9) STAILQ for the input queue.
Apr 14 2023, 6:03 PM
rrs closed D39565: tcp: rack pacing has some caveats that need to be obeyed when LRO is missing..
Apr 14 2023, 1:34 PM
rrs committed rG9903bf34f01f: tcp: rack pacing has some caveats that need to be obeyed when LRO is missing (authored by rrs).
tcp: rack pacing has some caveats that need to be obeyed when LRO is missing
Apr 14 2023, 1:34 PM

Apr 13 2023

rrs requested review of D39565: tcp: rack pacing has some caveats that need to be obeyed when LRO is missing..
Apr 13 2023, 8:17 PM
rrs closed D39501: TCP: Misc cleanups of tcp_subr.c.
Apr 13 2023, 1:30 PM
rrs committed rG25685b753752: TCP: Misc cleanups of tcp_subr.c (authored by rrs).
TCP: Misc cleanups of tcp_subr.c
Apr 13 2023, 1:30 PM

Apr 12 2023

rrs added a comment to D39501: TCP: Misc cleanups of tcp_subr.c.

Would be nice to know what the problem is you are experiencing with the DSCP for IPv6.

Apr 12 2023, 9:00 PM
rrs added inline comments to D39501: TCP: Misc cleanups of tcp_subr.c.
Apr 12 2023, 5:42 PM
rrs updated the diff for D39501: TCP: Misc cleanups of tcp_subr.c.

Address Richard and Michaels comments by letting sleeping dogs lie :)

Apr 12 2023, 5:41 PM
rrs added inline comments to D39501: TCP: Misc cleanups of tcp_subr.c.
Apr 12 2023, 5:26 PM
rrs added inline comments to D39501: TCP: Misc cleanups of tcp_subr.c.
Apr 12 2023, 3:43 PM
rrs committed rG1073f416576b: tcp_lro: When processing compressed acks lets support the new early wake… (authored by rrs).
tcp_lro: When processing compressed acks lets support the new early wake…
Apr 12 2023, 3:35 PM
rrs closed D39502: tcp_lro: When processing compressed acks lets support the new early wake feature for rack..
Apr 12 2023, 3:35 PM
rrs accepted D39516: tcp: make net.inet.tcp.functions_default vnet specific.
Apr 12 2023, 3:16 PM

Apr 11 2023

rrs requested review of D39502: tcp_lro: When processing compressed acks lets support the new early wake feature for rack..
Apr 11 2023, 2:35 PM
rrs added reviewers for D39501: TCP: Misc cleanups of tcp_subr.c: glebius, gallatin.
Apr 11 2023, 1:32 PM
rrs requested review of D39501: TCP: Misc cleanups of tcp_subr.c.
Apr 11 2023, 1:32 PM

Apr 10 2023

rrs committed rGa2b33c9a7a95: tcp: Rack - in the absence of LRO fixed rate pacing (loopback or interfaces… (authored by rrs).
tcp: Rack - in the absence of LRO fixed rate pacing (loopback or interfaces…
Apr 10 2023, 8:34 PM
rrs closed D39494: tcp: Rack - in the absence of LRO fixed rate pacing (loopback or interfaces with no LRO) does not work correctly..
Apr 10 2023, 8:34 PM
rrs added a reviewer for D39494: tcp: Rack - in the absence of LRO fixed rate pacing (loopback or interfaces with no LRO) does not work correctly.: tuexen.
Apr 10 2023, 8:11 PM
rrs requested review of D39494: tcp: Rack - in the absence of LRO fixed rate pacing (loopback or interfaces with no LRO) does not work correctly..
Apr 10 2023, 8:11 PM

Apr 7 2023

rrs accepted D39435: tcp: pass tcpcb in the tfb_tcp_ctloutput() method instead of inpcb.
Apr 7 2023, 7:05 PM
rrs accepted D39434: tcp: reduce argument list to functions that pass a segment.
Apr 7 2023, 7:03 PM
rrs accepted D39433: tcp: retire tfb_tcp_hpts_do_segment().
Apr 7 2023, 7:02 PM
rrs closed D39427: tcp: misc cleanup of options for rack as well as socket option logging..
Apr 7 2023, 2:22 PM
rrs committed rG945f9a7cc9dc: tcp: misc cleanup of options for rack as well as socket option logging. (authored by rrs).
tcp: misc cleanup of options for rack as well as socket option logging.
Apr 7 2023, 2:16 PM
rrs accepted D39427: tcp: misc cleanup of options for rack as well as socket option logging..
Apr 7 2023, 12:53 PM

Apr 6 2023

rrs updated the diff for D39427: tcp: misc cleanup of options for rack as well as socket option logging..

Update comments and spacing per cc's request. I do not update padding since the set of rack
changes is *not* intended to ever be MFC'd.

Apr 6 2023, 12:17 PM
rrs added inline comments to D39427: tcp: misc cleanup of options for rack as well as socket option logging..
Apr 6 2023, 12:16 PM

Apr 5 2023

rrs accepted D39427: tcp: misc cleanup of options for rack as well as socket option logging..
Apr 5 2023, 3:28 PM
rrs updated the diff for D39427: tcp: misc cleanup of options for rack as well as socket option logging..

One missed peak_rate removal ...

Apr 5 2023, 3:28 PM
rrs requested review of D39427: tcp: misc cleanup of options for rack as well as socket option logging..
Apr 5 2023, 2:32 PM
rrs closed D39402: Update rack to the latest code used at NF..
Apr 5 2023, 2:29 PM
rrs accepted D39402: Update rack to the latest code used at NF..
Apr 5 2023, 2:29 PM

Apr 4 2023

rrs committed rG030434acaf46: Update rack to the latest code used at NF. (authored by rrs).
Update rack to the latest code used at NF.
Apr 4 2023, 8:06 PM
rrs updated the diff for D39402: Update rack to the latest code used at NF..

Fix another niggle from Gleb, after we seen *ptr == NULL we don't need to set
*ptr to NULL.

Apr 4 2023, 7:51 PM
rrs updated the diff for D39402: Update rack to the latest code used at NF..

Fix rack_init() bug Gleb found, We need to look at *ptr not ptr in our null check

Apr 4 2023, 7:42 PM
rrs updated the diff for D39402: Update rack to the latest code used at NF..

Opps missed one sysctl change that has to be in.

Apr 4 2023, 1:39 PM
rrs closed D39210: Fixes in the tcp infrastructure with respect to stack changes as well as other infrastructure updates for incoming rack features..

Its in Freebsd now..

Apr 4 2023, 1:07 PM
rrs requested review of D39402: Update rack to the latest code used at NF..
Apr 4 2023, 1:04 PM
rrs committed rG73ee5756dee6: Fixes in the tcp infrastructure with respect to stack changes as well as other… (authored by rrs).
Fixes in the tcp infrastructure with respect to stack changes as well as other…
Apr 4 2023, 12:32 PM

Mar 24 2023

rrs accepted D39235: LRO: improve IPv4/IPv6 packet header checks.
Mar 24 2023, 10:44 AM