Page MenuHomeFreeBSD

rrs (Randall Stewart)
User

Projects

User Details

User Since
Jan 22 2015, 5:22 AM (229 w, 5 d)

Recent Activity

Wed, Jun 5

rrs added a comment to D20110: Fix infinite loop on older hardware.

sorry wrong revision.. the trouble is in the DSACK commit which is r347382... thats what we are backing out of our sync... (off by
one error.. must be a programmer :-) )

Wed, Jun 5, 6:51 PM
rrs added a comment to D20110: Fix infinite loop on older hardware.

There are for more problems then this. And its not explicitly with HPTS but it becomes the canary in the coal mine.
The basic problem is in r347381. This cause a huge slow down to the system at least with INVARIANTs. Hpts in
the form you are dealing with does handle wheel wrap well. We are backing out that change in our upstream
merge. And there will be changes I will be committing to fix wheel_wrap in hpts.

Wed, Jun 5, 6:47 PM
rrs accepted D20372: Fix TCP RACK after adding DSACK support.
Wed, Jun 5, 9:58 AM

May 9 2019

rrs accepted D20134: Bind TCP HPTS (pacer) threads to NUMA domains.
May 9 2019, 4:50 PM

Apr 10 2019

rrs created D19878: Updated Rack Stack.
Apr 10 2019, 7:48 PM
rrs committed rS346094: Fix a small bug in the tcp_log_id where the bucket.
Fix a small bug in the tcp_log_id where the bucket
Apr 10 2019, 6:58 PM

Apr 3 2019

rrs committed rS345851: Undo my previous erroneous commit changing the tcp_output kassert..
Undo my previous erroneous commit changing the tcp_output kassert.
Apr 3 2019, 7:35 PM

Mar 27 2019

rrs accepted D19334: Receiver Side DSACK (RFC2883) implementation.
Mar 27 2019, 4:09 PM

Mar 26 2019

rrs committed rS345527: Fix a small bug in the tcp_log_id where the bucket.
Fix a small bug in the tcp_log_id where the bucket
Mar 26 2019, 10:41 AM

Mar 23 2019

rrs accepted D19687: Fix KASSERT in tcp_output().
Mar 23 2019, 9:52 AM

Mar 19 2019

rrs abandoned D19611: Incorrect KASSERT.
Mar 19 2019, 5:36 PM

Mar 18 2019

rrs accepted D19355: Make RTO.Initial for TCP controllable via sysctl.
Mar 18 2019, 1:01 PM

Mar 17 2019

rrs updated the diff for D19611: Incorrect KASSERT.
Mar 17 2019, 1:22 PM
rrs created D19611: Incorrect KASSERT.
Mar 17 2019, 1:15 PM

Feb 21 2019

rrs accepted D18960: Patch to MFC TCP reassembly rewrite to stable/11.
Feb 21 2019, 12:21 PM

Feb 20 2019

rrs accepted D19254: Avoid dereferencing a NULL pointer when TCP_REASS_LOGGING is enabled.
Feb 20 2019, 8:31 PM
rrs accepted D18974: Use exponential backoff also for SYN segments.
Feb 20 2019, 12:08 PM

Feb 19 2019

rrs accepted D19152: Various cleanups to the management of multiple TCP stacks..
Feb 19 2019, 11:22 AM

Feb 13 2019

rrs created D19179: Crashing in a race with SOCK_DGRAM and unix domain sockets.
Feb 13 2019, 3:04 PM
rrs committed rS344099: This commit adds the missing release mechanism for the.
This commit adds the missing release mechanism for the
Feb 13 2019, 2:58 PM
rrs closed D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.
Feb 13 2019, 2:58 PM

Feb 11 2019

rrs updated the diff for D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.

get the update in and fix the pesky extra line.

Feb 11 2019, 12:37 PM

Feb 4 2019

rrs accepted D19071: Get TCP CDG CC working if net.inet.tcp.cc.cdg.smoothing_factor = 0 .
Feb 4 2019, 4:25 PM
rrs added inline comments to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.
Feb 4 2019, 12:11 PM

Feb 1 2019

rrs added inline comments to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.
Feb 1 2019, 4:05 PM
rrs updated the diff for D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.

Update to hopefully get a better view and not have the stray line in the diff

Feb 1 2019, 4:04 PM
rrs added a comment to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.

Interesting my svn copy does not have that extra chunk.. let me re-update the diff and use -x -up

Feb 1 2019, 4:03 PM
rrs added inline comments to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.
Feb 1 2019, 4:01 PM
rrs updated the diff for D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.

This updates the diff to Fix Hann's point on vlans, both the
vlan and lagg are now balanced.

Feb 1 2019, 12:31 PM
rrs added a comment to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.

Ahh good catch I did not know vlan had an allocator.. I will add it to the patch-set

Feb 1 2019, 12:18 PM
rrs accepted D19033: Initialise snd_wnd on the server side always before processing the ack.
Feb 1 2019, 11:26 AM

Jan 31 2019

rrs added a comment to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.

I don't follow your suggestion. Why would I add a if_snd_tag_free() in if_attach_internal() .
The driver below has to do that just like it has to add the if_snd_tag_alloc(). The
internal function has no way of knowing what is the right thing to do in
freeing a tag that the driver allocates. Having it be NULL as the default in
the internal just the same as if_snd_tag_alloc() is the right thing, only
if a driver sets these should they get used (when RATELIMIT is configured of course)

Jan 31 2019, 8:07 PM

Jan 30 2019

rrs added a comment to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.

Hi,
This patch does not look correct. You will need to pass the flowid in order to correctly handle this inside lagg?
Why are you not using the tag->ifp->if_sndtag_free(tag) in the first place?
--HPS

Hann's

Jan 30 2019, 4:31 PM
rrs created D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.
Jan 30 2019, 1:43 PM

Dec 17 2018

rrs accepted D18580: Accept always TCP segment with SEG.SEQ==RCV.NXT.
Dec 17 2018, 9:43 PM
rrs added inline comments to D18580: Accept always TCP segment with SEG.SEQ==RCV.NXT.
Dec 17 2018, 4:59 PM
rrs requested changes to D18580: Accept always TCP segment with SEG.SEQ==RCV.NXT.
Dec 17 2018, 4:55 PM

Nov 29 2018

rrs accepted D18366: Limit option_len for the TCP_CCALGOOPT option.
Nov 29 2018, 5:19 PM
rrs accepted D18375: Improve receive window autoscaling for TCP.
Nov 29 2018, 5:19 PM

Nov 21 2018

rrs accepted D18021: Improve KASSERTs in rack.c.

Good catch Michael!!!

Nov 21 2018, 12:30 PM

Nov 20 2018

rrs accepted D18033: TCP RACK stack should honor net.inet.tcp.drop_synfin sysctl variable.

Looks good to me :)

Nov 20 2018, 11:01 PM
rrs accepted D18032: Support RTT measurement even if switching from the rack stack to the base stack.
Nov 20 2018, 9:36 PM
rrs accepted D18034: The TCP RACK stack need to verify SEG.ACK first when in SYS-SENT state.
Nov 20 2018, 1:07 PM
rrs added inline comments to D18032: Support RTT measurement even if switching from the rack stack to the base stack.
Nov 20 2018, 12:59 PM
rrs accepted D18021: Improve KASSERTs in rack.c.
Nov 20 2018, 12:57 PM
rrs accepted D17949: Advertise a zero window when sending TCP RST segments via tcp_output().

This looks fine Michael :)

Nov 20 2018, 12:53 PM

Oct 18 2018

rrs accepted D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.
Oct 18 2018, 6:04 PM

Oct 16 2018

rrs accepted D17588: Fix TCP module unloading code to work with epoch(9) changes.
Oct 16 2018, 6:10 PM

Aug 28 2018

rrs accepted D16912: Fix TCP Fast Open for TCP RACK.
Aug 28 2018, 5:00 AM

Aug 27 2018

rrs added inline comments to D16912: Fix TCP Fast Open for TCP RACK.
Aug 27 2018, 3:07 PM
rrs accepted D16891: Make tcp_hpts compile with option RSS.

Because in order to conserve space the fid in the in_pcb (IIRR) is a uint16_t.. I was thinking
64k cpu's is probably enough for now :)

Aug 27 2018, 2:55 PM

Aug 21 2018

rrs accepted D16791: Add support for SO_DOMAIN in getsockopt().
Aug 21 2018, 1:23 PM
rrs accepted D16792: Fix inheritance of IPv6 options.
Aug 21 2018, 1:22 PM
rrs accepted D16796: Fix IPV6_USE_MIN_MTU socket option for TCP sockets.
Aug 21 2018, 1:22 PM

Aug 20 2018

rrs committed rS338102: This change represents a substantial restructure of the way we.
This change represents a substantial restructure of the way we
Aug 20 2018, 12:43 PM
rrs closed D16626: Rewrite of TCP Reassembly code.
Aug 20 2018, 12:43 PM

Aug 18 2018

rrs added inline comments to D16626: Rewrite of TCP Reassembly code.
Aug 18 2018, 7:17 PM
rrs updated the diff for D16626: Rewrite of TCP Reassembly code.

Fix the silly cut and paste bug.

Aug 18 2018, 7:15 PM
rrs updated the diff for D16626: Rewrite of TCP Reassembly code.

This version incorporates all of Jonathans comments and suggested improvements. Thanks
Jonathan!!!

Aug 18 2018, 7:01 AM

Aug 10 2018

rrs updated the diff for D16626: Rewrite of TCP Reassembly code.

This version updates from the last to include all of Lawrence Stewarts comments
as well as those from Peter Lei. A significant change is altering the calculate
overhead function to also glean the mlast so that a second walk of the mbuf
chain is no longer needed.

Aug 10 2018, 11:59 AM

Aug 9 2018

rrs accepted D16636: Improve TCP timestamps.
Aug 9 2018, 10:11 AM
rrs accepted D16637: Remove ipsec includes from tcp_hpts.
Aug 9 2018, 10:10 AM
rrs updated the diff for D16626: Rewrite of TCP Reassembly code.

Fixes an accounting problem shown by testing

Aug 9 2018, 10:07 AM

Aug 8 2018

rrs updated the diff for D16626: Rewrite of TCP Reassembly code.

Testing with INVAR found a problem with my late morning last optimization. If the
seq is behind us but overlaps we can't do the optimization.

Aug 8 2018, 8:59 PM
rrs created D16626: Rewrite of TCP Reassembly code.
Aug 8 2018, 2:25 PM
rrs closed D16604: Rack sends extra FIN.
Aug 8 2018, 1:37 PM
rrs committed rS337455: Fix a small bug in rack where it will.
Fix a small bug in rack where it will
Aug 8 2018, 1:37 PM

Aug 6 2018

rrs created D16604: Rack sends extra FIN.
Aug 6 2018, 9:32 AM
rrs closed D16579: Rack delayed ack issue.
Aug 6 2018, 9:22 AM
rrs committed rS337375: This fixes a bug in Rack where we were.
This fixes a bug in Rack where we were
Aug 6 2018, 9:22 AM

Aug 5 2018

rrs updated the diff for D16579: Rack delayed ack issue.

Update my typo :)

Aug 5 2018, 11:47 AM
rrs added inline comments to D16579: Rack delayed ack issue.
Aug 5 2018, 11:45 AM

Aug 3 2018

rrs created D16579: Rack delayed ack issue.
Aug 3 2018, 11:48 AM

Jul 31 2018

rrs accepted D16377: Add dtrace network provider for UDP-Lite.
Jul 31 2018, 7:01 PM

Jul 30 2018

rrs accepted D16369: Add missing dtrace receive and send probes for TCP.
Jul 30 2018, 12:00 PM
rrs closed D16453: When data after close is on, you can mess up the reassm queue.
Jul 30 2018, 10:24 AM
rrs committed rS336893: This fixes a hole where rack could end up.
This fixes a hole where rack could end up
Jul 30 2018, 10:23 AM
rrs accepted D16503: Send consistent SEG.WIN when sending from the timewait code path.
Jul 30 2018, 10:19 AM
rrs accepted D16458: Allow implicit connection setup for TCP/IPv6.
Jul 30 2018, 10:17 AM
rrs accepted D16485: Fix some TCP fast open issues.
Jul 30 2018, 10:13 AM

Jul 26 2018

rrs created D16453: When data after close is on, you can mess up the reassm queue.
Jul 26 2018, 11:00 AM

Jul 24 2018

rrs committed rS336672: Delete the example tcp stack "fastpath" which.
Delete the example tcp stack "fastpath" which
Jul 24 2018, 2:56 PM
rrs closed D16420: Fastpath was a temp holder to give as an example and now needs to disappear.
Jul 24 2018, 2:56 PM
rrs updated the diff for D16420: Fastpath was a temp holder to give as an example and now needs to disappear.
Jul 24 2018, 1:27 PM
rrs created D16420: Fastpath was a temp holder to give as an example and now needs to disappear.
Jul 24 2018, 1:22 PM

Jul 19 2018

rrs accepted D16046: Add UDP receive probes.
Jul 19 2018, 3:36 PM

Jul 18 2018

rrs committed rS336465: Bump the ICMP echo limits to match the RFC.
Bump the ICMP echo limits to match the RFC
Jul 18 2018, 10:50 PM
rrs closed D16333: The ICMP echo is too small.
Jul 18 2018, 10:50 PM
rrs created D16333: The ICMP echo is too small.
Jul 18 2018, 10:46 PM

Jul 12 2018

rrs accepted D16201: acquire inp lock around ip6_pcbopt to fix IPV6_TCLASS panic.
Jul 12 2018, 4:26 PM

Jun 21 2018

rrs committed rS335502: This adds in an optimization so that we only walk one.
This adds in an optimization so that we only walk one
Jun 21 2018, 9:04 PM
rrs closed D15937: Optimize the TSO and copy paths to use the new tcp_m_copy routine.
Jun 21 2018, 9:04 PM

Jun 20 2018

rrs created D15937: Optimize the TSO and copy paths to use the new tcp_m_copy routine.
Jun 20 2018, 8:29 PM

Jun 19 2018

rrs committed rS335364: Make sure that the t_peakrate_thr is not compiled in.
Make sure that the t_peakrate_thr is not compiled in
Jun 19 2018, 11:20 AM
rrs committed rS335361: Move the tp set back to where it was before.
Move the tp set back to where it was before
Jun 19 2018, 5:28 AM

Jun 18 2018

rrs committed rS335317: Move to using the inp->vnet pointer has suggested by lstewart..
Move to using the inp->vnet pointer has suggested by lstewart.
Jun 18 2018, 2:10 PM

Jun 14 2018

rrs committed rS335106: This fixes several bugs that Larry Rosenman helped me find in.
This fixes several bugs that Larry Rosenman helped me find in
Jun 14 2018, 3:27 AM
rrs closed D15758: Rack crash that Larry Rosenman found...
Jun 14 2018, 3:27 AM

Jun 12 2018

rrs closed D15757: HPTS Is missing some support for Vnets.
Jun 12 2018, 11:54 PM
rrs committed rS335022: This fixes missing VNET sets in the hpts system. Basically.
This fixes missing VNET sets in the hpts system. Basically
Jun 12 2018, 11:54 PM