Page MenuHomeFreeBSD

rrs (Randall Stewart)
User

Projects

User Details

User Since
Jan 22 2015, 5:22 AM (279 w, 6 d)

Recent Activity

Today

rrs accepted D25115: Restrict enabling TCP-FASTOPEN to end-points in CLOSED or LISTEN state.

It would not be EAGAIN/EBUSY since you can't do it again and expect it to succeed. I think
EINVAL is ok here.

Wed, Jun 3, 11:21 AM

Fri, May 29

rrs updated the diff for D25000: Skyzaller crash found by Michael Tuexen.

Ok turns out skyzaller has found yet another crash having to do with TFO for all three stacks. Lets update
the patch to fix that too.

Fri, May 29, 1:36 PM

Mon, May 25

rrs requested review of D25000: Skyzaller crash found by Michael Tuexen.
Mon, May 25, 1:44 PM
rrs added a comment to D24902: Time to First byte in and out.

Has discussed on the transport call, I will be updating these to have a uint64_t and a nano-second basis for the values (including t_starttime I think since this
is what you compare these against) :)

Mon, May 25, 11:39 AM

Thu, May 21

rrs added inline comments to D24237: Fix erroneous "DSACK" during loss recovery.
Thu, May 21, 3:37 PM
rrs accepted D24817: DCTCP: update alpha only once after loss recovery..
Thu, May 21, 2:20 PM
rrs accepted D23364: Send CWR only on new data, as per sec. 6.1.2 of RFC3168.
Thu, May 21, 2:16 PM

Wed, May 20

rrs added a comment to D24902: Time to First byte in and out.

I don't think that holding just the delta is what you really want. You want to be able
to tell when the first byte came in and the first byte went out. The delta only gives
one a partial view of what happened. And we are not living in 1984 where 64k of
memory is a lot. Four bytes to get more detailed information is I think worth it.

Wed, May 20, 11:22 AM

Tue, May 19

rrs updated the diff for D24852: Invalid addresses in sending or connecting.

Note that we don't want to commit these for a while since skyzaller uses these addresses but it
is something we should do.

Tue, May 19, 12:01 PM
rrs added inline comments to D24852: Invalid addresses in sending or connecting.
Tue, May 19, 11:55 AM
rrs updated the diff for D24852: Invalid addresses in sending or connecting.

Hmm I somehow got the wrong patch here.

Tue, May 19, 11:54 AM

Mon, May 18

rrs requested review of D24902: Time to First byte in and out.
Mon, May 18, 8:00 PM
rrs accepted D24781: Allow TCP to reuse local port with different destinations.

Yeah the spelling error check is rather dumb :)

Mon, May 18, 6:29 AM

Fri, May 15

rrs closed D24852: Invalid addresses in sending or connecting.
Fri, May 15, 2:00 PM
rrs committed rS361080: This fixes several skyzaller issues found with the.
This fixes several skyzaller issues found with the
Fri, May 15, 2:00 PM
rrs accepted D24831: Allow only IPv4 addresses in sendto() for TCP on AF_INET sockets.
Fri, May 15, 1:57 PM
rrs requested review of D24852: Invalid addresses in sending or connecting.
Fri, May 15, 12:41 PM
rrs updated the diff for D24826: Hung sessions.

We should not ever do GP measurements until we are established

Fri, May 15, 12:39 PM
rrs updated the diff for D24826: Hung sessions.

One little other niggle that I noticed, we should not do a goto again if the SYN bit is set ...

Fri, May 15, 12:01 PM
rrs updated the diff for D24826: Hung sessions.

And even yet another issue thanks to skyzaller in bbr.. the rc_lost when doing TCP-FO was incorrect in rxt timers.

Fri, May 15, 11:13 AM
rrs requested review of D24826: Hung sessions.
Fri, May 15, 5:24 AM
rrs updated the diff for D24826: Hung sessions.

Let's also fix the accounting panic that skyzaller is finding here too. When we are in a front
state and have a SYN outstanding that should count in the ctf_outstanding size. Also if
we have sent a FIN same thing.

Fri, May 15, 4:49 AM

Thu, May 14

rrs added inline comments to D24830: sendfile_test: Finish to implement linear probing to find a free port .
Thu, May 14, 11:17 AM

Tue, May 12

rrs accepted D24821: IPv6: Fix a panic in the nd6 code with unmapped mbufs..
Tue, May 12, 1:51 PM
rrs accepted D24822: IPv6: sync IP_NO_SND_TAG_RL support from IPv4.
Tue, May 12, 1:49 PM

Thu, May 7

rrs closed D24747: Responding properly to SYN-ACK.
Thu, May 7, 8:30 PM
rrs committed rS360798: When in the SYN-SENT state bbr and rack will not properly send an ACK but….
When in the SYN-SENT state bbr and rack will not properly send an ACK but…
Thu, May 7, 8:30 PM
rrs added inline comments to D23371: Retain only mutually supported TCP options after simultaneous SYN.
Thu, May 7, 3:01 PM
rrs added reviewers for D24747: Responding properly to SYN-ACK: transport, tuexen.
Thu, May 7, 10:50 AM
rrs requested review of D24747: Responding properly to SYN-ACK.
Thu, May 7, 10:49 AM
rrs committed rS360776: NF has an internal option that changes the tcp_mcopy_m routine slightly (has.
NF has an internal option that changes the tcp_mcopy_m routine slightly (has
Thu, May 7, 10:46 AM

Mon, May 4

rrs closed D24576: Update Rack and BBR to the latest from NF.
Mon, May 4, 11:19 PM
rrs committed rS360644: This fixes two issues found by ankitraheja09@gmail.com.
This fixes two issues found by ankitraheja09@gmail.com
Mon, May 4, 11:03 PM
rrs closed D24693: Fix an issue with retransmitted SYN's as well as sending RST's.
Mon, May 4, 11:03 PM
rrs accepted D24694: Readadd net epoch in TCP RACK.
Mon, May 4, 10:59 PM
rrs updated the summary of D24693: Fix an issue with retransmitted SYN's as well as sending RST's.
Mon, May 4, 10:55 PM
rrs updated the diff for D24693: Fix an issue with retransmitted SYN's as well as sending RST's.

gets rid of some emacs trailing ws

Mon, May 4, 10:54 PM
rrs added reviewers for D24693: Fix an issue with retransmitted SYN's as well as sending RST's: tuexen, transport.
Mon, May 4, 10:00 PM
rrs requested review of D24693: Fix an issue with retransmitted SYN's as well as sending RST's.
Mon, May 4, 9:59 PM
rrs accepted D24690: Enter epoch before sending ACK in BBR.
Mon, May 4, 9:56 PM
rrs committed rS360639: This commit brings things into sync with the advancements that.
This commit brings things into sync with the advancements that
Mon, May 4, 8:29 PM
rrs closed D24574: TCP OOB data handling.
Mon, May 4, 8:20 PM
rrs committed rS360638: Adjust the fb to have a way to ask the underlying stack.
Adjust the fb to have a way to ask the underlying stack
Mon, May 4, 8:20 PM

Apr 28 2020

rrs added inline comments to D24576: Update Rack and BBR to the latest from NF.
Apr 28 2020, 5:06 PM
rrs updated the diff for D24576: Update Rack and BBR to the latest from NF.

Follow Michaels suggestion and go 2016 - 2020 in the copyright instead of 2016 - 20

Apr 28 2020, 5:04 PM
rrs updated the diff for D24576: Update Rack and BBR to the latest from NF.

Even though there are no plans to add ECN to BBRv1, lets go ahead
and add back the uint8_t iptos value since you never know we might
circle back and do this plus we also want to remain somewhat consistent
between BBR and Rack

Apr 28 2020, 5:00 PM
rrs added a comment to D24576: Update Rack and BBR to the latest from NF.

I would suggest leaving the iptos changes in. It does not
harm in BBR and someday we will be doing BBRv2 and in
that we will do ECN.. so best to leave it in place I think.

Apr 28 2020, 4:50 PM
rrs updated the diff for D24576: Update Rack and BBR to the latest from NF.

Lets go ahead and add the new function to return that we don't do PRUS_OOB as long as we are in fixing things.

Apr 28 2020, 4:49 PM
rrs updated the diff for D24574: TCP OOB data handling.

Update to fix inadvertent overwrite of error and the name of the option function change per Michael's comment

Apr 28 2020, 12:43 PM
rrs added inline comments to D24574: TCP OOB data handling.
Apr 28 2020, 12:40 PM

Apr 27 2020

rrs updated the diff for D24574: TCP OOB data handling.

Now that D24575 is in lets take it a step further and provide the hooks so
we can ask a transport (optionally) if they support various PRU_XXX flags.
If they don't provide a function then they "support all" PRU_XXX flags.

Apr 27 2020, 4:46 PM
rrs committed rS360385: This change does a small prepratory step in getting the.
This change does a small prepratory step in getting the
Apr 27 2020, 4:30 PM
rrs closed D24575: Preparation for BBR and Rack update..
Apr 27 2020, 4:30 PM
rrs updated the diff for D24574: TCP OOB data handling.

Now that I know MSG_OOB is out of the picture make the appropriate update.

Apr 27 2020, 4:26 PM
rrs added inline comments to D24574: TCP OOB data handling.
Apr 27 2020, 4:23 PM
rrs updated the diff for D24576: Update Rack and BBR to the latest from NF.

Address all of Michael's first set of comments.

Apr 27 2020, 12:29 PM
rrs added inline comments to D24576: Update Rack and BBR to the latest from NF.
Apr 27 2020, 12:26 PM
rrs updated the diff for D24575: Preparation for BBR and Rack update..

Address all of Michael's comments

Apr 27 2020, 11:31 AM
rrs added inline comments to D24575: Preparation for BBR and Rack update..
Apr 27 2020, 11:29 AM
rrs added inline comments to D24574: TCP OOB data handling.
Apr 27 2020, 11:24 AM

Apr 26 2020

rrs added reviewers for D24576: Update Rack and BBR to the latest from NF: tuexen, transport.
Apr 26 2020, 3:16 PM
rrs requested review of D24576: Update Rack and BBR to the latest from NF.
Apr 26 2020, 3:15 PM
rrs requested review of D24575: Preparation for BBR and Rack update..
Apr 26 2020, 3:11 PM
rrs requested review of D24574: TCP OOB data handling.
Apr 26 2020, 3:05 PM

Apr 10 2020

rrs accepted D24213: Re-work unmapped mbufs to carry ext_pgs in the mbuf itself..
Apr 10 2020, 1:37 PM

Mar 12 2020

rrs accepted D23904: Use tcpstats accessor functions for kernel modules in case of RACK and BBR.
Mar 12 2020, 2:46 PM

Mar 9 2020

rrs accepted D23811: make lacp's use_numa hashing aware of send tags.
Mar 9 2020, 1:36 PM

Mar 8 2020

rrs accepted D23998: Don't deref an mbuf ext_pgs pointer in tcp_m_copym() unless we need to.
Mar 8 2020, 4:14 PM

Feb 27 2020

rrs added inline comments to D23726: Make RSS kernels compile again.
Feb 27 2020, 6:25 PM

Feb 26 2020

rrs committed rS358332: This commit expands tcp_ratelimit to be able to handle cards.
This commit expands tcp_ratelimit to be able to handle cards
Feb 26 2020, 1:48 PM
rrs closed D23647: TCP Ratelimit code update.
Feb 26 2020, 1:48 PM

Feb 18 2020

rrs accepted D23647: TCP Ratelimit code update.
Feb 18 2020, 12:07 PM
rrs updated the diff for D23647: TCP Ratelimit code update.

Update comments and name of the mss function per the comments in the review.

Feb 18 2020, 12:07 PM
rrs added inline comments to D23647: TCP Ratelimit code update.
Feb 18 2020, 11:44 AM

Feb 12 2020

rrs added inline comments to D23647: TCP Ratelimit code update.
Feb 12 2020, 3:39 PM
rrs updated the diff for D23647: TCP Ratelimit code update.

Address Hans comments, also fix the issue I had
when I back things out (the net epoch macro should have
been in the source).. also add just a few more comments and
fix a spelling error in one.

Feb 12 2020, 3:38 PM
rrs committed rS357823: Lets get the real correct version.. gessh. I need.
Lets get the real correct version.. gessh. I need
Feb 12 2020, 3:27 PM
rrs created D23647: TCP Ratelimit code update.
Feb 12 2020, 2:14 PM
rrs committed rS357819: Opps committed the wrong ratelimit version in the.
Opps committed the wrong ratelimit version in the
Feb 12 2020, 1:37 PM
rrs committed rS357818: White space cleanup -- remove trailing tab's or spaces.
White space cleanup -- remove trailing tab's or spaces
Feb 12 2020, 1:31 PM
rrs committed rS357817: Whitespace, remove from three files trailing white.
Whitespace, remove from three files trailing white
Feb 12 2020, 1:07 PM
rrs closed D23645: ECN incorrectly set.
Feb 12 2020, 1:04 PM
rrs committed rS357816: This small fix makes it so we properly follow.
This small fix makes it so we properly follow
Feb 12 2020, 1:04 PM
rrs added reviewers for D23645: ECN incorrectly set: tuexen, transport.
Feb 12 2020, 12:45 PM
rrs created D23645: ECN incorrectly set.
Feb 12 2020, 12:44 PM
rrs committed rS357815: Remove all trailing white space from the BBR/Rack fold. Bits.
Remove all trailing white space from the BBR/Rack fold. Bits
Feb 12 2020, 12:40 PM
rrs committed rS357814: Now that all of the stats framework is.
Now that all of the stats framework is
Feb 12 2020, 12:37 PM
rrs closed D23088: Remove the tied stats restriction to NETFLIX_STATS.
Feb 12 2020, 12:37 PM
rrs accepted D23088: Remove the tied stats restriction to NETFLIX_STATS.
Feb 12 2020, 12:01 PM

Jan 24 2020

rrs accepted D23212: Fix server side TCP fast open.
Jan 24 2020, 12:44 PM

Jan 8 2020

rrs created D23088: Remove the tied stats restriction to NETFLIX_STATS.
Jan 8 2020, 5:05 PM

Jan 6 2020

rrs accepted D22971: Fix race when accepting TCP connections.
Jan 6 2020, 3:38 PM
rrs committed rS356417: This catches rack up in the recent changes to ECN and.
This catches rack up in the recent changes to ECN and
Jan 6 2020, 3:29 PM
rrs closed D23052: Apply the same ECN updates that were in the default stack..
Jan 6 2020, 3:29 PM
rrs created D23052: Apply the same ECN updates that were in the default stack..
Jan 6 2020, 1:19 PM
rrs closed D22479: Fix up several sysctl that now should apply to both BBR and Rack as well as prepare for BBR to get experimental SaD.

Commited

Jan 6 2020, 1:03 PM
rrs closed D22866: Update tcp_logging to have two new features.
Jan 6 2020, 12:48 PM
rrs committed rS356414: This change adds a small feature to the tcp logging code. Basically.
This change adds a small feature to the tcp logging code. Basically
Jan 6 2020, 12:48 PM
rrs accepted D22866: Update tcp_logging to have two new features.
Jan 6 2020, 12:26 PM

Dec 18 2019

rrs created D22866: Update tcp_logging to have two new features.
Dec 18 2019, 12:59 PM