tcp: make sack_rxmit in tcp_output() a bool
ClosedPublic
Actions

Authored by glebius on Dec 29 2024, 12:26 AM.

Tags

None

Referenced Files

	F151012522: D48235.id149197.diff
	Sun, Apr 5, 11:12 AM

	Unknown Object (File)
	Sun, Mar 22, 12:33 PM

	Unknown Object (File)
	Sun, Mar 22, 12:54 AM

	Unknown Object (File)
	Sat, Mar 7, 2:19 AM

	Unknown Object (File)
	Mar 2 2026, 9:11 AM

	Unknown Object (File)
	Feb 23 2026, 9:55 PM

	Unknown Object (File)
	Feb 20 2026, 5:50 PM

	Unknown Object (File)
	Feb 17 2026, 11:59 AM

View All 68 Files

Subscribers

imp

melifaro

Details

Reviewers

rscheff
rrs
tuexen

Group Reviewers

transport

Commits

rG72c11c40ab5b: tcp: make sack_rxmit in tcp_output() a bool

Summary

Also make this variable initialization, as well as accompanying sackhole
pointer, slightly more readable. NFC.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Dec 29 2024, 12:26 AM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptDec 29 2024, 12:26 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Dec 29 2024, 12:26 AM

Harbormaster completed remote builds in B61375: Diff 148500.Dec 29 2024, 12:26 AM

glebius added a child revision: D48236: tcp: properly reset sackhint values when SACK recovery is done.Dec 29 2024, 12:26 AM

rrs accepted this revision.Dec 30 2024, 1:10 PM

This revision is now accepted and ready to land.Dec 30 2024, 1:10 PM

tuexen accepted this revision.Dec 30 2024, 2:38 PM

rscheff accepted this revision.Jan 13 2025, 10:18 AM

Closed by commit rG72c11c40ab5b: tcp: make sack_rxmit in tcp_output() a bool (authored by glebius). · Explain WhyJan 13 2025, 6:15 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG72c11c40ab5b: tcp: make sack_rxmit in tcp_output() a bool.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_output.c

25 lines

Diff 149197

View Options

tcp: make sack_rxmit in tcp_output() a boolClosedPublicActions