Differential D48236

tcp: properly reset sackhint values when SACK recovery is done
ClosedPublic
Actions

Authored by glebius on Dec 29 2024, 12:26 AM.

Tags

None

Referenced Files

	F151941021: D48236.id.diff
	Sat, Apr 11, 4:02 PM

	Unknown Object (File)
	Tue, Apr 7, 8:23 AM

	Unknown Object (File)
	Sun, Apr 5, 1:08 AM

	Unknown Object (File)
	Thu, Apr 2, 6:31 PM

	Unknown Object (File)
	Tue, Mar 31, 1:19 PM

	Unknown Object (File)
	Mar 12 2026, 12:47 PM

	Unknown Object (File)
	Mar 12 2026, 6:26 AM

	Unknown Object (File)
	Mar 10 2026, 6:26 AM

View All 73 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGb84f41b4e82d: tcp: properly reset sackhint values when SACK recovery is done

Summary

When the SACK scoreboard collapses, properly clear all the counters.
The counters are used in tcp_compute_pipe(), which can be called
anytime later after the SACK recovery. The returned result can be
totally bogus, including both too large and too small values.

PR: 283649

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Dec 29 2024, 12:26 AM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptDec 29 2024, 12:26 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Dec 29 2024, 12:26 AM

Harbormaster completed remote builds in B61376: Diff 148501.Dec 29 2024, 12:26 AM

glebius added a parent revision: D48235: tcp: make sack_rxmit in tcp_output() a bool.Dec 29 2024, 12:26 AM

glebius added a child revision: D48237: tcp: don't send beyond receivers advertised window.

emaste added a subscriber: emaste.Jan 13 2025, 1:04 AM

rscheff accepted this revision.Jan 13 2025, 10:20 AM

This revision is now accepted and ready to land.Jan 13 2025, 10:20 AM

Closed by commit rGb84f41b4e82d: tcp: properly reset sackhint values when SACK recovery is done (authored by glebius). · Explain WhyJan 13 2025, 6:15 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGb84f41b4e82d: tcp: properly reset sackhint values when SACK recovery is done.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

27 lines

Diff 149198

sys/netinet/tcp_sack.c

Loading...