Page MenuHomeFreeBSD

tcp: improve initializing the fields in tcp_log_buffer
ClosedPublic

Authored by tuexen on Apr 2 2025, 8:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 12:39 PM
Unknown Object (File)
Tue, Oct 14, 2:38 AM
Unknown Object (File)
Thu, Sep 18, 8:15 AM
Unknown Object (File)
Sep 4 2025, 12:28 AM
Unknown Object (File)
Aug 26 2025, 6:05 AM
Unknown Object (File)
Aug 12 2025, 5:13 AM
Unknown Object (File)
Aug 11 2025, 11:41 PM
Unknown Object (File)
Aug 4 2025, 11:30 PM

Details

Summary

Initialize the fields in the tcp_log_buffer in the sequence they appear in the structure and add the initialization of tlb_flex1, tlb_flex2, and _pad[].

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen requested review of this revision.Apr 2 2025, 8:56 PM

IMHO, these macros are more obfuscation than a helper. I would write one big sparse initializer here and let compiler optimize wrt padding zeroing.

This revision is now accepted and ready to land.Apr 3 2025, 10:51 AM

Note I do agree with Gleb here, these macros are just nasty and not very clear. However I think that making such a change should be a separate commit from this one!