Page MenuHomeFreeBSD

tcp: improve initializing the fields in tcp_log_buffer
ClosedPublic

Authored by tuexen on Apr 2 2025, 8:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 18, 11:52 AM
Unknown Object (File)
Sun, Jun 14, 6:31 AM
Unknown Object (File)
Thu, Jun 4, 4:28 AM
Unknown Object (File)
Thu, May 21, 12:17 PM
Unknown Object (File)
May 15 2026, 1:32 PM
Unknown Object (File)
May 15 2026, 6:20 AM
Unknown Object (File)
May 14 2026, 9:02 PM
Unknown Object (File)
May 12 2026, 3:32 AM

Details

Summary

Initialize the fields in the tcp_log_buffer in the sequence they appear in the structure and add the initialization of tlb_flex1, tlb_flex2, and _pad[].

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen requested review of this revision.Apr 2 2025, 8:56 PM

IMHO, these macros are more obfuscation than a helper. I would write one big sparse initializer here and let compiler optimize wrt padding zeroing.

This revision is now accepted and ready to land.Apr 3 2025, 10:51 AM

Note I do agree with Gleb here, these macros are just nasty and not very clear. However I think that making such a change should be a separate commit from this one!