Page MenuHomeFreeBSD

TCP RACK: don't log an uninitialized value
ClosedPublic

Authored by tuexen on Jan 6 2025, 9:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 7, 5:54 AM
Unknown Object (File)
Tue, Sep 23, 1:33 AM
Unknown Object (File)
Sep 7 2025, 5:23 PM
Unknown Object (File)
Sep 5 2025, 6:42 PM
Unknown Object (File)
Sep 5 2025, 6:03 PM
Unknown Object (File)
Sep 4 2025, 2:31 AM
Unknown Object (File)
Sep 3 2025, 1:19 AM
Unknown Object (File)
Aug 27 2025, 8:04 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen requested review of this revision.Jan 6 2025, 9:24 PM
tuexen retitled this revision from TCP RACK: don't lock an uninitialized value to TCP RACK: don't log an uninitialized value.Jan 7 2025, 8:07 AM
tuexen added a reviewer: glebius.
This revision is now accepted and ready to land.Jan 8 2025, 4:07 PM

Why not move the old_method: label above the stack variables' declaration? I think it may be cleaner to read.
Like this:

	old_method:
		uint64_t cwnd, tr_perms = 0;
		int32_t reduce = 0;
This revision was automatically updated to reflect the committed changes.
In D48346#1103376, @cc wrote:

Why not move the old_method: label above the stack variables' declaration? I think it may be cleaner to read.
Like this:

	old_method:
		uint64_t cwnd, tr_perms = 0;
		int32_t reduce = 0;

I prefer declarations before code in a block and label inside the code block. Maybe this is just a personal preference. But I also had to look up the specification if Coverity is correct in stating that the variable might be unused...