gnn (George Neville-Neil)
User

Projects (6)

User Details

User Since
May 18 2014, 4:14 AM (183 w, 4 d)

Recent Activity

Mon, Nov 13

gnn accepted D12474: Add destructive dtrace to bsdinstall hardening menu.
Mon, Nov 13, 1:33 AM
gnn accepted D13017: Add IPSec tests in tunnel mode.
Mon, Nov 13, 1:29 AM

Fri, Nov 3

gnn accepted D12747: loopback route needs RTF_PINNED flag.
Fri, Nov 3, 5:33 PM

Oct 19 2017

gnn added a reviewer for D12586: improve inp locking in getsockopt, setsockopt, and related functions: rwatson.
Oct 19 2017, 4:06 PM

Oct 9 2017

gnn accepted D12583: check so_error earlier in sosend_generic.
Oct 9 2017, 11:02 PM
gnn committed rS324435: Add the firmware for the Intel 8265 WiFi device..
Add the firmware for the Intel 8265 WiFi device.
Oct 9 2017, 3:55 PM
gnn committed rS324434: Add support for Intel 8265 WiFi.
Add support for Intel 8265 WiFi
Oct 9 2017, 3:49 PM

Oct 3 2017

gnn accepted D12569: Updates to Tiers..
Oct 3 2017, 4:55 AM

Sep 20 2017

gnn committed rS323814: MFC: 323253, 323499.
MFC: 323253, 323499
Sep 20 2017, 4:31 PM

Sep 12 2017

gnn accepted D12334: Fix DTrace test tst_inet_ntop_d: remove definitions which are already in libdtrace.

LGMT too. Thanks!

Sep 12 2017, 2:13 PM

Sep 9 2017

gnn accepted D12298: libc: remove gets.
Sep 9 2017, 8:44 PM

Sep 7 2017

gnn committed rS323253: Add D definitions for the named values in socket.h.
Add D definitions for the named values in socket.h
Sep 7 2017, 3:05 AM
gnn closed D12241: Add a set of D defines based on the contents of socket.h.
Sep 7 2017, 3:05 AM
gnn added a comment to D12241: Add a set of D defines based on the contents of socket.h.

It bugs me to have new, BSD licensed, code in the cddl directory but I'm OK with this being there for now. And, yes, we need an automagic way to generate these.

Sep 7 2017, 2:35 AM

Sep 6 2017

gnn accepted D11518: Add support for generic backpressure indicator for ratelimited transmit queues aswell as non-ratelimited ones.
Sep 6 2017, 12:47 PM
gnn updated the summary of D12241: Add a set of D defines based on the contents of socket.h.
Sep 6 2017, 2:32 AM
gnn updated the diff for D12241: Add a set of D defines based on the contents of socket.h.
Sep 6 2017, 2:31 AM
gnn created D12241: Add a set of D defines based on the contents of socket.h.
Sep 6 2017, 2:28 AM
gnn abandoned D12240: Add a set of D defines based on the contents of socket.h.
Sep 6 2017, 2:19 AM
gnn created D12240: Add a set of D defines based on the contents of socket.h.
Sep 6 2017, 2:12 AM
gnn accepted D12227: Fixup compilation and enable dtrace support for mips64.

LGTM

Sep 6 2017, 12:17 AM

Aug 28 2017

gnn committed rP448871: Update Meinberg Tools package to 1.0.0.
Update Meinberg Tools package to 1.0.0
Aug 28 2017, 3:16 PM

Aug 9 2017

gnn accepted D11806: Enable IPSEC_SUPPORT..

Sure.

Aug 9 2017, 8:51 PM

Jul 28 2017

gnn accepted D11768: Add support to devel/libhyve-remote. (VNC Server).
Jul 28 2017, 8:38 AM

Jul 26 2017

gnn closed D6448: Allow bigger number of packets to generate.

This has already been committed upstream and is present in HEAD.

Jul 26 2017, 12:19 PM
gnn accepted D11731: Fix DTrace test timeout: common.dtraceUtil.t_dtrace_contrib.tst_ZeroFunctionProbes_d_ksh.
Jul 26 2017, 12:04 PM

Jul 25 2017

gnn accepted D11668: Fix common.probes.t_dtrace_contrib.tst_probestar_d timeout issue.
Jul 25 2017, 10:26 AM
gnn accepted D11671: Fix test timeout: common.speculation.t_dtrace_contrib.tst_NoSpecBuffer_d.
Jul 25 2017, 10:25 AM
gnn accepted D11673: Fix test timeout: common.dtraceUtil.t_dtrace_contrib.tst_DestructWithFunction_d_ksh.
Jul 25 2017, 10:25 AM
gnn accepted D11674: Fix test timeout: common.funcs.t_dtrace_contrib.tst_cleanpath_d.
Jul 25 2017, 10:25 AM
gnn accepted D11676: Fix test timeout: common.funcs.t_dtrace_contrib.tst_basename_d.
Jul 25 2017, 10:25 AM
gnn accepted D11707: common/funcs/tst.basename.d*: make it compatible with basename(1).
Jul 25 2017, 10:25 AM
gnn accepted D11713: Fix DTrace test case: common.misc.t_dtrace_contrib.tst_macroglob_ksh.
Jul 25 2017, 10:24 AM
gnn accepted D11716: DTtrace test suite driver: execute the verifying script generated by test case.
Jul 25 2017, 10:24 AM

Jul 13 2017

gnn added a reviewer for D11003: Load balance sockets with new SO_REUSEPORT_LB option: glebius.
Jul 13 2017, 4:08 PM

Jul 6 2017

gnn committed rS320752: MFC 319803.
MFC 319803
Jul 6 2017, 6:33 PM

Jun 21 2017

gnn accepted D11085: TCP Blackbox Recorder.
Jun 21 2017, 8:29 PM

Jun 20 2017

gnn accepted D11016: Add a sysctl to toggle the use of the sockets LOWAT when calculating auto window growth.
Jun 20 2017, 11:30 PM

Jun 10 2017

gnn committed rS319805: Update the variables as well..
Update the variables as well.
Jun 10 2017, 8:51 PM
gnn committed rS319804: Update Makefile to contain the new DTrace lockstat manual page..
Update Makefile to contain the new DTrace lockstat manual page.
Jun 10 2017, 8:47 PM
gnn committed rS319803: Manual page for the DTrace lockstat provider.
Manual page for the DTrace lockstat provider
Jun 10 2017, 8:42 PM
gnn closed D11128: New manual page for the DTrace lockstat provider by committing rS319803: Manual page for the DTrace lockstat provider.
Jun 10 2017, 8:42 PM
gnn updated the diff for D11128: New manual page for the DTrace lockstat provider.

Address markj's comments.

Jun 10 2017, 8:39 PM
gnn added inline comments to D11128: New manual page for the DTrace lockstat provider.
Jun 10 2017, 8:36 PM
gnn added a reviewer for D11128: New manual page for the DTrace lockstat provider: DTrace.
Jun 10 2017, 5:27 PM
gnn updated the diff for D11128: New manual page for the DTrace lockstat provider.
Jun 10 2017, 5:27 PM
gnn created D11128: New manual page for the DTrace lockstat provider.
Jun 10 2017, 3:04 PM

Jun 8 2017

gnn accepted D11086: Enable the ability to load multiple versions of the same TCP stack.
Jun 8 2017, 12:25 AM

Jun 5 2017

gnn added reviewers for D11003: Load balance sockets with new SO_REUSEPORT_LB option: transport, rrs, jtl, tuexen.
Jun 5 2017, 1:58 PM

May 12 2017

gnn added a reviewer for D10686: Improve layout of struct inpcb: bz.
May 12 2017, 12:48 PM

May 6 2017

gnn accepted D10592: pf: Fix vnet initialisation.
May 6 2017, 8:00 PM

May 3 2017

gnn added inline comments to D9988: Add support for a copyoutmbuf() subroutine for DTrace..
May 3 2017, 11:07 AM

Apr 22 2017

gnn accepted D10432: Flush the LRO ctrl as soon as lro_mbufs fills up..
Apr 22 2017, 4:30 PM
gnn accepted D10430: Frames that are not considered for LRO should not be counted in LRO stats..
Apr 22 2017, 4:30 PM
gnn accepted D10424: Ignore TCP SYN-ACK segments with non-matching SEG.ACK in SYN-SENT state.
Apr 22 2017, 2:47 PM

Apr 20 2017

gnn accepted D10272: Improve handling of syncookies.

The Transport group discussed this during a conference call and decided that this is good to go in.

Apr 20 2017, 4:09 PM

Apr 14 2017

gnn accepted D10384: Make crypto(9) multi thread.

Other than the two minor nits above this looks OK to me.

Apr 14 2017, 1:34 PM

Apr 13 2017

gnn accepted D10375: Add large replay widow support to setkey(8) and improve setkey's debugging.
Apr 13 2017, 1:57 PM

Apr 11 2017

gnn accepted D9894: Honor net.inet.tcp.drop_synfin in other states than LISTEN.
Apr 11 2017, 2:00 PM
gnn accepted D10356: Inherit IPv6 checksum offloading flags to vlan interfaces.
Apr 11 2017, 1:40 PM
gnn accepted D10358: Make sysctl identifiers for direct netisr queue to be unique.
Apr 11 2017, 1:33 PM

Apr 9 2017

gnn accepted D9668: Support estimated RTT for receive buffer auto resizing.
Apr 9 2017, 10:45 PM

Apr 8 2017

gnn accepted D10313: rendevous -> rendezvous.
Apr 8 2017, 12:02 PM

Apr 7 2017

gnn accepted D9668: Support estimated RTT for receive buffer auto resizing.

I like the use of DTrace as well. Please add the script as another commit.

Apr 7 2017, 6:00 PM

Apr 4 2017

gnn added a comment to D10272: Improve handling of syncookies.

Note that this has failed to build according to the build bot (see Harbormaster). Thoughts on that?

Apr 4 2017, 9:56 PM

Mar 30 2017

gnn committed rS316210: MFC: 313176, 313177, 313359.
MFC: 313176, 313177, 313359
Mar 30 2017, 2:52 AM
gnn committed rS316208: MFC: 311225, 311243, 313045.
MFC: 311225, 311243, 313045
Mar 30 2017, 2:44 AM
gnn requested changes to D9894: Honor net.inet.tcp.drop_synfin in other states than LISTEN.

Other than the need for some clarifying parentheses I think this is OK.

Mar 30 2017, 1:12 AM

Mar 29 2017

gnn accepted D10149: DTrace Audit Provider Prototype.
Mar 29 2017, 6:01 PM

Mar 28 2017

gnn requested changes to D10158: [mbufq] add mbufq_concat_all().

Looks like Jenkins didn't like this little change either. You should look into the build failure. I also agree with the removal of _all() from the function name.

Mar 28 2017, 11:50 PM
gnn accepted D10149: DTrace Audit Provider Prototype.
Mar 28 2017, 11:36 PM

Mar 27 2017

gnn accepted D10135: Enable route and LLE (ndp) caching in TCP/IPv6.
Mar 27 2017, 12:25 AM

Mar 25 2017

gnn committed rS315951: Free Mike Karels from mentorship..
Free Mike Karels from mentorship.
Mar 25 2017, 2:12 PM
gnn accepted D10059: Fix reference count leak with L2 caching..
Mar 25 2017, 2:07 PM

Mar 21 2017

gnn accepted D9571: bridgestp: update path cost on media changes.
Mar 21 2017, 5:44 AM
gnn added inline comments to D9658: Remove the arbitrary limit on DTrace buffers.
Mar 21 2017, 4:55 AM

Mar 18 2017

gnn accepted D10018: Summary:.
Mar 18 2017, 12:33 AM

Mar 17 2017

gnn added inline comments to D10018: Summary:.
Mar 17 2017, 6:14 AM
gnn accepted D10018: Summary:.

Other than the nits I pointed out already this looks like a good change.

Mar 17 2017, 5:08 AM

Mar 16 2017

gnn updated the diff for D10013: Add support for syscall::*fork:return probes in both parent and child..

Remove filtering based on system call type (suggested by rwatson)

Mar 16 2017, 8:58 AM

Mar 15 2017

gnn updated the summary of D10013: Add support for syscall::*fork:return probes in both parent and child..
Mar 15 2017, 1:22 PM
gnn created D10013: Add support for syscall::*fork:return probes in both parent and child..
Mar 15 2017, 1:21 PM
gnn added a comment to D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.

New, BSD license, code does not need to be in cddl. Most of the new D scripts and programs go into either share/dtrace or the DTrace Toolkit port. Since this is a script I'd put it into share/dtrace if you want it in the src tree.

Mar 15 2017, 1:56 AM

Mar 14 2017

gnn added a comment to D9987: Add support for syscall::*fork:return tracing in DTrace.

Actually it was in kern_fork() that I first looked, but, we do not have access to the syscall args structure at that point. I'll dig a bit more to see if I missed a pointer that would lead me there, or figure out if there is a reasonable way to synthesize one.

Mar 14 2017, 4:18 AM

Mar 13 2017

gnn added a reviewer for D9988: Add support for a copyoutmbuf() subroutine for DTrace.: DTrace.
Mar 13 2017, 9:45 AM
gnn added a reviewer for D9987: Add support for syscall::*fork:return tracing in DTrace: graeme.jenkinson_cl.cam.ac.uk.
Mar 13 2017, 9:44 AM
gnn created D9988: Add support for a copyoutmbuf() subroutine for DTrace..
Mar 13 2017, 9:43 AM
gnn added reviewers for D9987: Add support for syscall::*fork:return tracing in DTrace: markj, DTrace.
Mar 13 2017, 9:39 AM
gnn created D9987: Add support for syscall::*fork:return tracing in DTrace.
Mar 13 2017, 9:38 AM

Mar 4 2017

gnn added a comment to D9721: Add netisr queue for deferred IPsec processing to reduce kernel stack requirements.

If you can wait a day or so I'd love to have Olivier, now added to the review, run one of his perf tests on this.

Mar 4 2017, 12:23 AM
gnn added a reviewer for D9721: Add netisr queue for deferred IPsec processing to reduce kernel stack requirements: olivier.
Mar 4 2017, 12:22 AM

Mar 2 2017

gnn added inline comments to D9805: Add the ability to filter the listing of security policies by policy scope.
Mar 2 2017, 4:40 PM
gnn accepted D9847: Try to extract the RFC1048 data from PXE.
Mar 2 2017, 4:38 PM
gnn accepted D9854: Add cxgbetool(8) to the base system..
Mar 2 2017, 7:02 AM

Feb 23 2017

gnn accepted D9701: Errors caused by DTrace are not correctly handled by ARMv6 abort_handler().
Feb 23 2017, 6:08 PM · ARM, DTrace
gnn added inline comments to D9721: Add netisr queue for deferred IPsec processing to reduce kernel stack requirements.
Feb 23 2017, 12:45 PM

Feb 17 2017

gnn updated the diff for D9658: Remove the arbitrary limit on DTrace buffers.

Address two of markj's suggestions.

Feb 17 2017, 11:22 PM
gnn added a comment to D9658: Remove the arbitrary limit on DTrace buffers.

Updated

Feb 17 2017, 11:21 PM
gnn added inline comments to D9658: Remove the arbitrary limit on DTrace buffers.
Feb 17 2017, 11:19 PM
gnn added inline comments to D9658: Remove the arbitrary limit on DTrace buffers.
Feb 17 2017, 11:00 PM