Page MenuHomeFreeBSD

gnn (George Neville-Neil)
User

Projects (7)

User Details

User Since
May 18 2014, 4:14 AM (341 w, 2 d)

Recent Activity

Wed, Nov 25

gnn updated the diff for D27354: Address issue pointed out in CVE-2020-25705.

Clean up various bits for hopeful commit.

Wed, Nov 25, 9:30 PM
gnn updated the diff for D27354: Address issue pointed out in CVE-2020-25705.

Updates based on conversations with cperciva and emaste

Wed, Nov 25, 6:16 PM
gnn updated the diff for D27354: Address issue pointed out in CVE-2020-25705.

Address issues pointed out by philip@

Wed, Nov 25, 3:54 PM

Tue, Nov 24

gnn requested review of D27354: Address issue pointed out in CVE-2020-25705.
Tue, Nov 24, 6:35 PM

Tue, Nov 17

gnn committed rS367740: MFC: 367628, 367635, 367645.
MFC: 367628, 367635, 367645
Tue, Nov 17, 1:02 AM

Fri, Nov 13

gnn committed rS367635: Followup pointed out by ae@.
Followup pointed out by ae@
Fri, Nov 13, 1:07 PM

Thu, Nov 12

gnn closed D27166: Add redirects to the fast forwarding path.

Committed revision 367628.

Thu, Nov 12, 9:59 PM
gnn committed rS367628: An earlier commit effectively turned out the fast forwading path.
An earlier commit effectively turned out the fast forwading path
Thu, Nov 12, 9:59 PM
gnn updated the diff for D27166: Add redirects to the fast forwarding path.

Address melifaro@ request to move code into a function.

Thu, Nov 12, 4:49 PM
gnn added inline comments to D27166: Add redirects to the fast forwarding path.
Thu, Nov 12, 4:14 PM

Wed, Nov 11

gnn added inline comments to D27166: Add redirects to the fast forwarding path.
Wed, Nov 11, 10:18 PM
gnn updated the diff for D27166: Add redirects to the fast forwarding path.

Address the comment about the comment.

Wed, Nov 11, 10:16 PM

Tue, Nov 10

gnn requested review of D27166: Add redirects to the fast forwarding path.
Tue, Nov 10, 9:59 PM

Mon, Nov 9

gnn accepted D27148: Improve RFC 7323 Compliance.

Thanks for doing this and bringing the code up to date.

Mon, Nov 9, 2:48 PM

Oct 21 2020

gnn accepted D26879: Add ipfw SDT probe..

Thanks for the update, please proceed.

Oct 21 2020, 2:49 PM

Oct 20 2020

gnn requested changes to D26879: Add ipfw SDT probe..

I like the idea of this change but I believe that a new file should be created in netpfil/ipfw to contain the code that's been put into in_kdtrace.[ch] in this review.

Oct 20 2020, 2:46 PM

Oct 19 2020

gnn accepted D26875: Save the current TCP pacing rate in t_pacing_rate..
Oct 19 2020, 11:24 PM
gnn accepted D26821: Add a kernel crypto driver using assembly routines from OpenSSL..

LGTM

Oct 19 2020, 10:53 PM

Oct 13 2020

gnn accepted D26757: Fix to join AllHost mcast group again when adding an existing IP address.
Oct 13 2020, 2:44 PM

Oct 9 2020

gnn accepted D25993: bpf(4): Update the manual page to reflect reality.
Oct 9 2020, 2:51 PM

Oct 6 2020

gnn accepted D22369: Add support for IPSec ESN and pass relevant information to crypto layer.

LGTM, thanks!

Oct 6 2020, 11:24 PM

Oct 4 2020

gnn added a comment to D26652: Implement SO_RERROR.

While I applaud this idea for route(4)ing sockets I think that applying it broadly to other socket types has issues that need to be considered. Has this patch been brought to arch@ as yet? I think either a narrower application (just to route(4)) and then a discussion on arch(4) is appropriate for this change.

Oct 4 2020, 1:29 PM
gnn added a comment to D22369: Add support for IPSec ESN and pass relevant information to crypto layer.

This patch contains many magic numbers 4, 8 and 32 that should either be removed by the proper use of sizeof() or turned into #defines that are named.

Oct 4 2020, 1:25 PM

Oct 2 2020

gnn accepted D26636: Implement SIOCGIFALIAS.

LGTM

Oct 2 2020, 3:25 AM

Aug 20 2020

gnn accepted D26088: net80211: set_vht_extchan() reverse order to always return best.
Aug 20 2020, 11:14 PM
gnn accepted D26089: net80211: improve media information for VHT5GHZ.
Aug 20 2020, 11:13 PM
gnn accepted D26091: net80211: enhance getflags*() and ieee80211_add_channel*().
Aug 20 2020, 11:13 PM

Aug 18 2020

gnn requested changes to D26091: net80211: enhance getflags*() and ieee80211_add_channel*().
Aug 18 2020, 9:17 PM
gnn requested changes to D26089: net80211: improve media information for VHT5GHZ.

Remove dead code or give it a real name please.

Aug 18 2020, 9:15 PM
gnn requested changes to D26088: net80211: set_vht_extchan() reverse order to always return best.

Can you #define the magic number?

Aug 18 2020, 9:14 PM

Aug 15 2020

gnn accepted D26002: 80211: consistently order 160 and 80+80.

LGTM

Aug 15 2020, 10:44 PM
gnn accepted D26001: 80211: consistently spell 80P80.

LGTM

Aug 15 2020, 10:38 PM
gnn added a comment to D26000: net80211 / ifconfig: cleanup the use of IEEE80211_FVHT_USEVHT*.

I'm happy with this change although I'd remove the code in #if 0 instead of leaving it there.

Aug 15 2020, 10:37 PM

Aug 14 2020

gnn accepted D26071: Corret the mask byte order to check for reservered bits..

Approved.

Aug 14 2020, 10:21 PM

Aug 12 2020

gnn committed rS364175: Restore Qing Li's commit bit.
Restore Qing Li's commit bit
Aug 12 2020, 6:35 PM

Aug 11 2020

gnn committed rD54422: Update my key since the previous one expired..
Update my key since the previous one expired.
Aug 11 2020, 7:34 PM

Jul 12 2020

gnn accepted D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

Second guessing the compiler is a fool's errand and I rather doubt you'd ever see a 50% "win" with this kind of change. That being said it makes the code more readable to my eyes and is acceptable.

Jul 12 2020, 8:41 PM · network
gnn accepted D25619: Don't print VNET pointer when starting up.
Jul 12 2020, 1:29 PM

Jul 1 2020

gnn accepted D25312: Relax the rule against declaring variables in nested scopes..
Jul 1 2020, 9:33 PM
gnn accepted D25417: Add a driver for the SafeXcel EIP-97..
Jul 1 2020, 3:57 PM
gnn added a comment to D25417: Add a driver for the SafeXcel EIP-97..

Some minor nits. I'm happy to see this go in.

Jul 1 2020, 1:15 PM

Jun 23 2020

gnn accepted D24246: Add a timeline for completion of mentorship..

I'm ok with "may" so LGTM.

Jun 23 2020, 7:43 PM
gnn accepted D25312: Relax the rule against declaring variables in nested scopes..
Jun 23 2020, 7:42 PM

May 14 2020

gnn added a comment to D21669: mtod macro: Drop the type argument.

Coming back to this after a discussion with cem@ and emaste@ I think this idea still deserves some merit. It makes the resulting code easier to read, at least to my eyes and removes a somewhat confusing and error prone macro from the code base. It would be easy enough to propose the same change to the other BSDs as well.

May 14 2020, 9:16 PM

Apr 21 2020

gnn accepted D24342: Remove support for IPsec algorithms deprecated in r348205 and r360202..
Apr 21 2020, 1:35 AM

Apr 16 2020

gnn accepted D24342: Remove support for IPsec algorithms deprecated in r348205 and r360202..

A couple of brief comments above, but overall the patch is good and should be integrated.

Apr 16 2020, 9:13 PM

Feb 5 2020

gnn accepted D22403: [PowerPC] ELFv2 libdtrace support (userland side).

LGTM

Feb 5 2020, 7:26 PM · DTrace, PowerPC

Feb 4 2020

gnn committed rS357488: MFC 356913.
MFC 356913
Feb 4 2020, 3:31 AM

Jan 20 2020

gnn committed rS356913: Add support for latest Intel I219 device, supported in Lenovo Carbon X1 v7.
Add support for latest Intel I219 device, supported in Lenovo Carbon X1 v7
Jan 20 2020, 12:53 PM

Aug 11 2019

gnn committed rS350865: MFC: 350557.
MFC: 350557
Aug 11 2019, 8:34 PM
gnn committed rS350864: MFC: 350557.
MFC: 350557
Aug 11 2019, 8:34 PM

Aug 3 2019

gnn committed rS350557: Properly validte arguments for route deletion.
Properly validte arguments for route deletion
Aug 3 2019, 2:42 PM

Jun 4 2019

gnn committed rP503460: Add -fPIC reqiured to link this library against other libraries.
Add -fPIC reqiured to link this library against other libraries
Jun 4 2019, 9:17 AM

May 26 2019

gnn committed rP502707: Add missing include file to the list of things to install..
Add missing include file to the list of things to install.
May 26 2019, 10:04 AM

May 21 2019

gnn accepted D20340: Add deprecation warnings for IPsec algorithms deprecated in RFC 8221..

Thanks.

May 21 2019, 11:54 PM

May 8 2019

gnn accepted D20163: Remove IPSEC from GENERIC due to performance issues.
May 8 2019, 8:40 AM

May 7 2019

gnn accepted D20096: Enable build/install DTrace tests on amd64.
May 7 2019, 3:32 PM

Apr 13 2019

gnn accepted D19848: ext2fs: Dtrace support..

OK, I'm happy to work out this "trace" thing later.

Apr 13 2019, 11:46 PM

Apr 11 2019

gnn added a comment to D19848: ext2fs: Dtrace support..

Some general comments.

Apr 11 2019, 2:27 PM

Mar 21 2019

gnn accepted D19668: Remove -n flag, fix setting date / time.

Thanks for fixing this.

Mar 21 2019, 6:37 AM

Jan 11 2019

gnn closed D18505: Remove the timed daemon..
Jan 11 2019, 8:46 PM
gnn committed rS342139: Remove, the now very outdated, timed..
Remove, the now very outdated, timed.
Jan 11 2019, 8:46 PM

Jan 9 2019

gnn accepted D18765: Add EINTEGRITY as new error number.

errno.d looks good to me.

Jan 9 2019, 2:24 AM

Jan 8 2019

gnn added inline comments to D18765: Add EINTEGRITY as new error number.
Jan 8 2019, 8:57 AM

Jan 2 2019

gnn committed rP489084: Update to release 2018-12-R1.
Update to release 2018-12-R1
Jan 2 2019, 2:17 PM
gnn committed rP489083: Update to 2018-12-R1 release.
Update to 2018-12-R1 release
Jan 2 2019, 2:16 PM

Dec 15 2018

gnn added a comment to D18505: Remove the timed daemon..

Address issues with the latest diff.

Dec 15 2018, 8:13 PM
gnn updated the diff for D18505: Remove the timed daemon..

Address Obsolete vs. OptionalObsolete issues.

Dec 15 2018, 8:12 PM
gnn updated the diff for D18505: Remove the timed daemon..

Regenerate src.conf

Dec 15 2018, 10:00 AM

Dec 14 2018

gnn updated the diff for D18505: Remove the timed daemon..

Address recent comments by bz@, but not src.conf

Dec 14 2018, 8:44 PM
gnn updated the diff for D18505: Remove the timed daemon..

Address leftover space.

Dec 14 2018, 7:05 PM
gnn added a comment to D18505: Remove the timed daemon..

Fixed

Dec 14 2018, 7:04 PM
gnn updated the diff for D18505: Remove the timed daemon..

Address comments from sbruno. Leave the obsolete files but remove the MK_TIMED.

Dec 14 2018, 2:08 PM
gnn updated the diff for D18505: Remove the timed daemon..

Address comments from bcr@ and bz@

Dec 14 2018, 1:54 PM

Dec 11 2018

gnn added a reviewer for D18505: Remove the timed daemon.: bz.
Dec 11 2018, 8:26 PM

Dec 10 2018

gnn created D18505: Remove the timed daemon..
Dec 10 2018, 11:56 PM

Dec 3 2018

gnn committed rS341428: Free Vincenzo Maffione from mentorship.
Free Vincenzo Maffione from mentorship
Dec 3 2018, 3:25 PM

Nov 28 2018

gnn accepted D17987: netmap: set IFCAP_NETMAP in if_capabilities.

I approve the plan laid out in the comments with np@

Nov 28 2018, 1:15 PM

Nov 16 2018

gnn accepted D17988: ifnet(9): Add description of IFCAP_NETMAP.

Approved by: gnn@

Nov 16 2018, 10:17 AM

Nov 10 2018

gnn accepted D17916: vtnet: fix netmap support.

Thanks. Please commit with the standard Approved by: line.

Nov 10 2018, 3:55 PM
gnn accepted D17698: netmap: pkt-gen: several updates from upstream.

LGTM this can be committed with Approved by: gnn (mentor)

Nov 10 2018, 7:57 AM
gnn requested changes to D17916: vtnet: fix netmap support.

Please update the onoff variable to match how we normally express this in FreeBSD. Other than that small nit this looks fine.

Nov 10 2018, 7:49 AM

Oct 31 2018

gnn accepted D17762: PR211618: remove reference to dtruss from dtrace(1).

Do it.

Oct 31 2018, 3:25 PM
gnn accepted D17735: netmap: add load balancer program.

Approved by mentor

Oct 31 2018, 2:36 PM

Oct 24 2018

gnn accepted D17683: netmap: add man page for the vale-ctl program.

Please commit with Approved by: gnn

Oct 24 2018, 3:33 PM

Oct 23 2018

gnn accepted D17664: netmap: add man page for the bridge program.

LGTM. Please add the Approved by: gnn@ line to your commit.

Oct 23 2018, 3:08 PM
gnn accepted D17364: netmap: align codebase to the current upstream (commit id 8374e1a7e6941).

Smoke tested in the Sentex cluster on cxl (Chelsio) hardware.

Oct 23 2018, 8:09 AM

Oct 8 2018

gnn added a reviewer for D17364: netmap: align codebase to the current upstream (commit id 8374e1a7e6941): np.
Oct 8 2018, 11:31 PM

Oct 5 2018

gnn accepted D17411: man: fix vale(4) port naming.

LGTM. Approved by mentor.

Oct 5 2018, 9:22 PM
gnn committed rS339196: Add myself as co-mentor with hrs@ for Vincenzo Maffione.
Add myself as co-mentor with hrs@ for Vincenzo Maffione
Oct 5 2018, 3:03 PM

Oct 1 2018

gnn accepted D17348: Allow DTrace audit provider probes to fire even if auditd(8) isn't running..

LGTM

Oct 1 2018, 2:41 PM

Sep 30 2018

gnn accepted D17348: Allow DTrace audit provider probes to fire even if auditd(8) isn't running..

LGTM

Sep 30 2018, 3:38 PM

Sep 29 2018

gnn committed rS339017: Free Daichi Goto from mentorship.
Free Daichi Goto from mentorship
Sep 29 2018, 4:38 PM

Sep 4 2018

gnn committed rP478962: Fix typo.
Fix typo
Sep 4 2018, 2:12 PM
gnn committed rP478956: Update the license allow post GPLv2.
Update the license allow post GPLv2
Sep 4 2018, 1:14 PM
gnn committed rP478954: Remove an unused dependency, update to properly grab version of Python.
Remove an unused dependency, update to properly grab version of Python
Sep 4 2018, 1:12 PM

Sep 3 2018

gnn committed rP478916: Update build dependencies to track a library rather than an executable.
Update build dependencies to track a library rather than an executable
Sep 3 2018, 7:43 PM
gnn committed rP478915: Update dependencies to properly follow Python and libraries.
Update dependencies to properly follow Python and libraries
Sep 3 2018, 7:41 PM
gnn committed rP478914: Switch to the more idiomatic inclusion of Python.
Switch to the more idiomatic inclusion of Python
Sep 3 2018, 7:33 PM
gnn committed rP478894: Attach libbtbb and ubertooth to the build.
Attach libbtbb and ubertooth to the build
Sep 3 2018, 6:47 PM