Page MenuHomeFreeBSD

gnn (George Neville-Neil)
User

Projects (7)

User Details

User Since
May 18 2014, 4:14 AM (383 w, 3 d)

Recent Activity

Sun, Sep 5

gnn committed R10:c850ca3a1716: Retore the vnet before returning an error. (authored by gnn).
Retore the vnet before returning an error.
Sun, Sep 5, 10:34 PM

Thu, Aug 26

gnn accepted D31700: tcp: Remove unused v6 state definitions.

Pretty much anything marked as KAME compatibility can be removed as KAME ended long ago.

Thu, Aug 26, 9:15 PM

Jun 21 2021

gnn committed R10:c6b2d024d7ee: Retore the vnet before returning an error. (authored by gnn).
Retore the vnet before returning an error.
Jun 21 2021, 2:50 PM
gnn closed D30741: Restore VNET before returning in error paths in vlan_setmulti..
Jun 21 2021, 2:50 PM

Jun 17 2021

gnn accepted D30804: NOTES: Update the HZ entry with latest advice..

LGTM

Jun 17 2021, 5:00 PM
gnn accepted D30802: man9: add hz(9) and hardclock(9).

LGTM

Jun 17 2021, 5:00 PM

May 28 2021

gnn accepted D30531: libpmc: always generate libpmc_events.c.
May 28 2021, 7:10 PM
gnn accepted D30530: libpmc: remove pe->alias.
May 28 2021, 7:10 PM
gnn accepted D30529: remove unused 'isfixed' variable.
May 28 2021, 7:09 PM
gnn accepted D30528: libpmc: eliminate pmc_pmu_stat_mode().
May 28 2021, 7:09 PM
gnn accepted D30527: libpmc: fix Intel "instructions" alias.
May 28 2021, 7:09 PM
gnn accepted D30526: pmccontrol: improve -L with pmu-events.
May 28 2021, 7:08 PM

Apr 21 2021

gnn accepted D29887: pmcstat: set initial counter value to zero.
Apr 21 2021, 4:48 PM
gnn accepted D29885: pmc_allocate(3): document the count argument.
Apr 21 2021, 4:48 PM

Apr 20 2021

gnn accepted D28434: Add FIB_ALGO to GENERIC on amd64/arm64..
Apr 20 2021, 11:39 PM

Apr 16 2021

gnn accepted D29787: man: document ether_gen_addr(9).

LGTM

Apr 16 2021, 1:44 AM

Apr 9 2021

gnn committed R9:a0fbda3eef0f: Rough draft on collaboration using github (authored by gnn).
Rough draft on collaboration using github
Apr 9 2021, 8:18 PM
gnn committed R9:63584c7bba7b: Address points brought up by bsdimp (authored by gnn).
Address points brought up by bsdimp
Apr 9 2021, 8:18 PM
gnn committed R9:6982d9119d29: Add langauge and other simple updates from uqs (authored by gnn).
Add langauge and other simple updates from uqs
Apr 9 2021, 8:18 PM
gnn committed R9:e47e964a9d36: Rough draft on collaboration using github (authored by gnn).
Rough draft on collaboration using github
Apr 9 2021, 8:18 PM

Apr 7 2021

gnn accepted D26447: add deprecation notice to ftpd.

Now that this review has devolved to the point of discussing democracy, rather than the deprecation of a piece of long surviving, but, inherently insecure code in our base system, it's time for people to step back from their keyboards and realize that removing this from base does not make it impossible to install or use, it simply reduces the default attack surface of our system. So, let's let emaste put this deprecation in for 14, and move on.

Apr 7 2021, 1:23 PM
gnn accepted D29600: arm64: Fix finding the pmc event ID.
Apr 7 2021, 1:05 PM

Apr 2 2021

gnn accepted D29555: pf: Add static DTrace probe points.

LGTM

Apr 2 2021, 5:10 PM
gnn added inline comments to D29543: license: Create a license guideline document.
Apr 2 2021, 5:07 PM
gnn added inline comments to D29543: license: Create a license guideline document.
Apr 2 2021, 5:03 PM

Mar 18 2021

gnn accepted D29268: armv8crypto: add some missing copyright statements.

LGTM

Mar 18 2021, 9:11 PM

Mar 11 2021

gnn accepted D29226: SPDX: Add canonical licenses for indirect SPDX references in the tree.

LGTM

Mar 11 2021, 11:23 PM

Mar 10 2021

gnn accepted D29201: net/tcptestsuite: Fix pkg-plist.

LGTM. Thanks.

Mar 10 2021, 8:30 PM
gnn committed rP568015: Take maintainership of the port and add updated files..
Take maintainership of the port and add updated files.
Mar 10 2021, 4:30 PM

Feb 19 2021

gnn accepted D28804: Fix `arp -d` / `ndp -d`..

Couple of nits but otherwise LGTM.

Feb 19 2021, 8:59 PM

Feb 12 2021

gnn added reviewers for D28622: handbook/config: Add section on configuring IPv6: bz, hrs.
Feb 12 2021, 6:35 PM
gnn accepted D28622: handbook/config: Add section on configuring IPv6.
Feb 12 2021, 6:35 PM

Feb 8 2021

gnn accepted D22712: Add Router and Prefix table limits..

LGTM

Feb 8 2021, 5:49 PM

Jan 22 2021

gnn accepted D22003: Add lle_event handler to ARP.
Jan 22 2021, 3:20 PM

Jan 19 2021

gnn added a comment to D28232: Fix possible panic in udp6_input() due to lack of locking..

Yup, I understand that we do not currently have that function. I think you ought to add that as part of this fix.

Jan 19 2021, 4:25 PM
gnn requested changes to D28232: Fix possible panic in udp6_input() due to lack of locking..

I believe the use of this boolean is the wrong approach. If you want to check and then lock you'll need to an an INP_RLOCKED similar to INP_WLOCKED which can be found in in_pcb.h.

Jan 19 2021, 1:07 PM

Jan 13 2021

gnn accepted D28132: Handle functions that use a nop in the arm64 fbt.
Jan 13 2021, 6:00 PM

Jan 5 2021

gnn accepted D27884: Install dtrace.h and depedencies.
Jan 5 2021, 4:05 PM
gnn accepted D27973: Move the PMC overflow count to make it per-CPU.

LGTM

Jan 5 2021, 4:04 PM

Dec 13 2020

gnn committed R9:a978c10d524c: Approved by: rwatson (mentor) (authored by gnn).
Approved by: rwatson (mentor)
Dec 13 2020, 6:39 PM
gnn committed R9:bfec4a38693a: Approved by: rwatson (mentor) (authored by gnn).
Approved by: rwatson (mentor)
Dec 13 2020, 6:39 PM
gnn committed R9:055c82f2f0e4: Add a new project (Dingo) to the list of projects that are being (authored by gnn).
Add a new project (Dingo) to the list of projects that are being
Dec 13 2020, 6:37 PM
gnn committed R9:b8d403de6f83: Add new worker (Andrea Campi) who is working on a port of Howl. (authored by gnn).
Add new worker (Andrea Campi) who is working on a port of Howl.
Dec 13 2020, 6:36 PM
gnn committed R9:998fc7dad297: Update information on new system (cheetah) put into the lab. (authored by gnn).
Update information on new system (cheetah) put into the lab.
Dec 13 2020, 6:28 PM
gnn committed R9:c0cd4daf476d: A few word changes from obrien. (authored by gnn).
A few word changes from obrien.
Dec 13 2020, 6:28 PM
gnn committed R9:d2a917e97ed3: Submitted by: Johnny Cho popeye at yahoo-inc.com (authored by gnn).
Submitted by: Johnny Cho popeye at yahoo-inc.com
Dec 13 2020, 6:21 PM
gnn committed R9:6cdad1c50d33: Update key to contain a freebsd.org address as well as my own normal email (authored by gnn).
Update key to contain a freebsd.org address as well as my own normal email
Dec 13 2020, 6:17 PM

Dec 7 2020

gnn updated the diff for D27354: Address issue pointed out in CVE-2020-25705.

Update with suggestions from emaste

Dec 7 2020, 3:43 PM

Nov 25 2020

gnn updated the diff for D27354: Address issue pointed out in CVE-2020-25705.

Clean up various bits for hopeful commit.

Nov 25 2020, 9:30 PM
gnn updated the diff for D27354: Address issue pointed out in CVE-2020-25705.

Updates based on conversations with cperciva and emaste

Nov 25 2020, 6:16 PM
gnn updated the diff for D27354: Address issue pointed out in CVE-2020-25705.

Address issues pointed out by philip@

Nov 25 2020, 3:54 PM

Nov 24 2020

gnn requested review of D27354: Address issue pointed out in CVE-2020-25705.
Nov 24 2020, 6:35 PM

Nov 17 2020

gnn committed rS367740: MFC: 367628, 367635, 367645.
MFC: 367628, 367635, 367645
Nov 17 2020, 1:02 AM

Nov 13 2020

gnn committed rS367635: Followup pointed out by ae@.
Followup pointed out by ae@
Nov 13 2020, 1:07 PM

Nov 12 2020

gnn closed D27166: Add redirects to the fast forwarding path.

Committed revision 367628.

Nov 12 2020, 9:59 PM
gnn committed rS367628: An earlier commit effectively turned out the fast forwading path.
An earlier commit effectively turned out the fast forwading path
Nov 12 2020, 9:59 PM
gnn updated the diff for D27166: Add redirects to the fast forwarding path.

Address melifaro@ request to move code into a function.

Nov 12 2020, 4:49 PM
gnn added inline comments to D27166: Add redirects to the fast forwarding path.
Nov 12 2020, 4:14 PM

Nov 11 2020

gnn added inline comments to D27166: Add redirects to the fast forwarding path.
Nov 11 2020, 10:18 PM
gnn updated the diff for D27166: Add redirects to the fast forwarding path.

Address the comment about the comment.

Nov 11 2020, 10:16 PM

Nov 10 2020

gnn requested review of D27166: Add redirects to the fast forwarding path.
Nov 10 2020, 9:59 PM

Nov 9 2020

gnn accepted D27148: Improve RFC 7323 Compliance.

Thanks for doing this and bringing the code up to date.

Nov 9 2020, 2:48 PM

Oct 21 2020

gnn accepted D26879: Add ipfw SDT probe..

Thanks for the update, please proceed.

Oct 21 2020, 2:49 PM

Oct 20 2020

gnn requested changes to D26879: Add ipfw SDT probe..

I like the idea of this change but I believe that a new file should be created in netpfil/ipfw to contain the code that's been put into in_kdtrace.[ch] in this review.

Oct 20 2020, 2:46 PM

Oct 19 2020

gnn accepted D26875: Save the current TCP pacing rate in t_pacing_rate..
Oct 19 2020, 11:24 PM
gnn accepted D26821: Add a kernel crypto driver using assembly routines from OpenSSL..

LGTM

Oct 19 2020, 10:53 PM

Oct 13 2020

gnn accepted D26757: Fix to join AllHost mcast group again when adding an existing IP address.
Oct 13 2020, 2:44 PM

Oct 9 2020

gnn accepted D25993: bpf(4): Update the manual page to reflect reality.
Oct 9 2020, 2:51 PM

Oct 6 2020

gnn accepted D22369: Add support for IPSec ESN and pass relevant information to crypto layer.

LGTM, thanks!

Oct 6 2020, 11:24 PM

Oct 4 2020

gnn added a comment to D26652: Implement SO_RERROR.

While I applaud this idea for route(4)ing sockets I think that applying it broadly to other socket types has issues that need to be considered. Has this patch been brought to arch@ as yet? I think either a narrower application (just to route(4)) and then a discussion on arch(4) is appropriate for this change.

Oct 4 2020, 1:29 PM
gnn added a comment to D22369: Add support for IPSec ESN and pass relevant information to crypto layer.

This patch contains many magic numbers 4, 8 and 32 that should either be removed by the proper use of sizeof() or turned into #defines that are named.

Oct 4 2020, 1:25 PM

Oct 2 2020

gnn accepted D26636: Implement SIOCGIFALIAS.

LGTM

Oct 2 2020, 3:25 AM

Aug 20 2020

gnn accepted D26088: net80211: set_vht_extchan() reverse order to always return best.
Aug 20 2020, 11:14 PM
gnn accepted D26089: net80211: improve media information for VHT5GHZ.
Aug 20 2020, 11:13 PM
gnn accepted D26091: net80211: enhance getflags*() and ieee80211_add_channel*().
Aug 20 2020, 11:13 PM

Aug 18 2020

gnn requested changes to D26091: net80211: enhance getflags*() and ieee80211_add_channel*().
Aug 18 2020, 9:17 PM
gnn requested changes to D26089: net80211: improve media information for VHT5GHZ.

Remove dead code or give it a real name please.

Aug 18 2020, 9:15 PM
gnn requested changes to D26088: net80211: set_vht_extchan() reverse order to always return best.

Can you #define the magic number?

Aug 18 2020, 9:14 PM

Aug 15 2020

gnn accepted D26002: 80211: consistently order 160 and 80+80.

LGTM

Aug 15 2020, 10:44 PM
gnn accepted D26001: 80211: consistently spell 80P80.

LGTM

Aug 15 2020, 10:38 PM
gnn added a comment to D26000: net80211 / ifconfig: cleanup the use of IEEE80211_FVHT_USEVHT*.

I'm happy with this change although I'd remove the code in #if 0 instead of leaving it there.

Aug 15 2020, 10:37 PM

Aug 14 2020

gnn accepted D26071: Corret the mask byte order to check for reservered bits..

Approved.

Aug 14 2020, 10:21 PM

Aug 12 2020

gnn committed rS364175: Restore Qing Li's commit bit.
Restore Qing Li's commit bit
Aug 12 2020, 6:35 PM

Aug 11 2020

gnn committed rD54422: Update my key since the previous one expired..
Update my key since the previous one expired.
Aug 11 2020, 7:34 PM

Jul 12 2020

gnn accepted D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

Second guessing the compiler is a fool's errand and I rather doubt you'd ever see a 50% "win" with this kind of change. That being said it makes the code more readable to my eyes and is acceptable.

Jul 12 2020, 8:41 PM · network
gnn accepted D25619: Don't print VNET pointer when starting up.
Jul 12 2020, 1:29 PM

Jul 1 2020

gnn accepted D25312: Relax the rule against declaring variables in nested scopes..
Jul 1 2020, 9:33 PM
gnn accepted D25417: Add a driver for the SafeXcel EIP-97..
Jul 1 2020, 3:57 PM
gnn added a comment to D25417: Add a driver for the SafeXcel EIP-97..

Some minor nits. I'm happy to see this go in.

Jul 1 2020, 1:15 PM

Jun 23 2020

gnn accepted D24246: Add a timeline for completion of mentorship..

I'm ok with "may" so LGTM.

Jun 23 2020, 7:43 PM
gnn accepted D25312: Relax the rule against declaring variables in nested scopes..
Jun 23 2020, 7:42 PM

May 14 2020

gnn added a comment to D21669: mtod macro: Drop the type argument.

Coming back to this after a discussion with cem@ and emaste@ I think this idea still deserves some merit. It makes the resulting code easier to read, at least to my eyes and removes a somewhat confusing and error prone macro from the code base. It would be easy enough to propose the same change to the other BSDs as well.

May 14 2020, 9:16 PM

Apr 21 2020

gnn accepted D24342: Remove support for IPsec algorithms deprecated in r348205 and r360202..
Apr 21 2020, 1:35 AM

Apr 16 2020

gnn accepted D24342: Remove support for IPsec algorithms deprecated in r348205 and r360202..

A couple of brief comments above, but overall the patch is good and should be integrated.

Apr 16 2020, 9:13 PM

Feb 5 2020

gnn accepted D22403: [PowerPC] ELFv2 libdtrace support (userland side).

LGTM

Feb 5 2020, 7:26 PM · DTrace, PowerPC

Feb 4 2020

gnn committed rS357488: MFC 356913.
MFC 356913
Feb 4 2020, 3:31 AM

Jan 20 2020

gnn committed rS356913: Add support for latest Intel I219 device, supported in Lenovo Carbon X1 v7.
Add support for latest Intel I219 device, supported in Lenovo Carbon X1 v7
Jan 20 2020, 12:53 PM

Aug 11 2019

gnn committed rS350865: MFC: 350557.
MFC: 350557
Aug 11 2019, 8:34 PM
gnn committed rS350864: MFC: 350557.
MFC: 350557
Aug 11 2019, 8:34 PM

Aug 3 2019

gnn committed rS350557: Properly validte arguments for route deletion.
Properly validte arguments for route deletion
Aug 3 2019, 2:42 PM