Page MenuHomeFreeBSD

gnn (George Neville-Neil)
User

Projects (7)

User Details

User Since
May 18 2014, 4:14 AM (320 w, 4 d)

Recent Activity

Wed, Jul 1

gnn accepted D25312: Relax the rule against declaring variables in nested scopes..
Wed, Jul 1, 9:33 PM
gnn accepted D25417: Add a driver for the SafeXcel EIP-97..
Wed, Jul 1, 3:57 PM
gnn added a comment to D25417: Add a driver for the SafeXcel EIP-97..

Some minor nits. I'm happy to see this go in.

Wed, Jul 1, 1:15 PM

Tue, Jun 23

gnn accepted D24246: Add a timeline for completion of mentorship..

I'm ok with "may" so LGTM.

Tue, Jun 23, 7:43 PM
gnn accepted D25312: Relax the rule against declaring variables in nested scopes..
Tue, Jun 23, 7:42 PM

May 14 2020

gnn added a comment to D21669: mtod macro: Drop the type argument.

Coming back to this after a discussion with cem@ and emaste@ I think this idea still deserves some merit. It makes the resulting code easier to read, at least to my eyes and removes a somewhat confusing and error prone macro from the code base. It would be easy enough to propose the same change to the other BSDs as well.

May 14 2020, 9:16 PM

Apr 21 2020

gnn accepted D24342: Remove support for IPsec algorithms deprecated in r348205 and r360202..
Apr 21 2020, 1:35 AM

Apr 16 2020

gnn accepted D24342: Remove support for IPsec algorithms deprecated in r348205 and r360202..

A couple of brief comments above, but overall the patch is good and should be integrated.

Apr 16 2020, 9:13 PM

Feb 5 2020

gnn accepted D22403: [PowerPC] ELFv2 libdtrace support (userland side).

LGTM

Feb 5 2020, 7:26 PM · DTrace, PowerPC

Feb 4 2020

gnn committed rS357488: MFC 356913.
MFC 356913
Feb 4 2020, 3:31 AM

Jan 20 2020

gnn committed rS356913: Add support for latest Intel I219 device, supported in Lenovo Carbon X1 v7.
Add support for latest Intel I219 device, supported in Lenovo Carbon X1 v7
Jan 20 2020, 12:53 PM

Aug 11 2019

gnn committed rS350865: MFC: 350557.
MFC: 350557
Aug 11 2019, 8:34 PM
gnn committed rS350864: MFC: 350557.
MFC: 350557
Aug 11 2019, 8:34 PM

Aug 3 2019

gnn committed rS350557: Properly validte arguments for route deletion.
Properly validte arguments for route deletion
Aug 3 2019, 2:42 PM

Jun 4 2019

gnn committed rP503460: Add -fPIC reqiured to link this library against other libraries.
Add -fPIC reqiured to link this library against other libraries
Jun 4 2019, 9:17 AM

May 26 2019

gnn committed rP502707: Add missing include file to the list of things to install..
Add missing include file to the list of things to install.
May 26 2019, 10:04 AM

May 21 2019

gnn accepted D20340: Add deprecation warnings for IPsec algorithms deprecated in RFC 8221..

Thanks.

May 21 2019, 11:54 PM

May 8 2019

gnn accepted D20163: Remove IPSEC from GENERIC due to performance issues.
May 8 2019, 8:40 AM

May 7 2019

gnn accepted D20096: Enable build/install DTrace tests on amd64.
May 7 2019, 3:32 PM

Apr 13 2019

gnn accepted D19848: ext2fs: Dtrace support..

OK, I'm happy to work out this "trace" thing later.

Apr 13 2019, 11:46 PM

Apr 11 2019

gnn added a comment to D19848: ext2fs: Dtrace support..

Some general comments.

Apr 11 2019, 2:27 PM

Mar 21 2019

gnn accepted D19668: Remove -n flag, fix setting date / time.

Thanks for fixing this.

Mar 21 2019, 6:37 AM

Jan 11 2019

gnn closed D18505: Remove the timed daemon..
Jan 11 2019, 8:46 PM
gnn committed rS342139: Remove, the now very outdated, timed..
Remove, the now very outdated, timed.
Jan 11 2019, 8:46 PM

Jan 9 2019

gnn accepted D18765: Add EINTEGRITY as new error number.

errno.d looks good to me.

Jan 9 2019, 2:24 AM

Jan 8 2019

gnn added inline comments to D18765: Add EINTEGRITY as new error number.
Jan 8 2019, 8:57 AM

Jan 2 2019

gnn committed rP489084: Update to release 2018-12-R1.
Update to release 2018-12-R1
Jan 2 2019, 2:17 PM
gnn committed rP489083: Update to 2018-12-R1 release.
Update to 2018-12-R1 release
Jan 2 2019, 2:16 PM

Dec 15 2018

gnn added a comment to D18505: Remove the timed daemon..

Address issues with the latest diff.

Dec 15 2018, 8:13 PM
gnn updated the diff for D18505: Remove the timed daemon..

Address Obsolete vs. OptionalObsolete issues.

Dec 15 2018, 8:12 PM
gnn updated the diff for D18505: Remove the timed daemon..

Regenerate src.conf

Dec 15 2018, 10:00 AM

Dec 14 2018

gnn updated the diff for D18505: Remove the timed daemon..

Address recent comments by bz@, but not src.conf

Dec 14 2018, 8:44 PM
gnn updated the diff for D18505: Remove the timed daemon..

Address leftover space.

Dec 14 2018, 7:05 PM
gnn added a comment to D18505: Remove the timed daemon..

Fixed

Dec 14 2018, 7:04 PM
gnn updated the diff for D18505: Remove the timed daemon..

Address comments from sbruno. Leave the obsolete files but remove the MK_TIMED.

Dec 14 2018, 2:08 PM
gnn updated the diff for D18505: Remove the timed daemon..

Address comments from bcr@ and bz@

Dec 14 2018, 1:54 PM

Dec 11 2018

gnn added a reviewer for D18505: Remove the timed daemon.: bz.
Dec 11 2018, 8:26 PM

Dec 10 2018

gnn created D18505: Remove the timed daemon..
Dec 10 2018, 11:56 PM

Dec 3 2018

gnn committed rS341428: Free Vincenzo Maffione from mentorship.
Free Vincenzo Maffione from mentorship
Dec 3 2018, 3:25 PM

Nov 28 2018

gnn accepted D17987: netmap: set IFCAP_NETMAP in if_capabilities.

I approve the plan laid out in the comments with np@

Nov 28 2018, 1:15 PM

Nov 16 2018

gnn accepted D17988: ifnet(9): Add description of IFCAP_NETMAP.

Approved by: gnn@

Nov 16 2018, 10:17 AM

Nov 10 2018

gnn accepted D17916: vtnet: fix netmap support.

Thanks. Please commit with the standard Approved by: line.

Nov 10 2018, 3:55 PM
gnn accepted D17698: netmap: pkt-gen: several updates from upstream.

LGTM this can be committed with Approved by: gnn (mentor)

Nov 10 2018, 7:57 AM
gnn requested changes to D17916: vtnet: fix netmap support.

Please update the onoff variable to match how we normally express this in FreeBSD. Other than that small nit this looks fine.

Nov 10 2018, 7:49 AM

Oct 31 2018

gnn accepted D17762: PR211618: remove reference to dtruss from dtrace(1).

Do it.

Oct 31 2018, 3:25 PM
gnn accepted D17735: netmap: add load balancer program.

Approved by mentor

Oct 31 2018, 2:36 PM

Oct 24 2018

gnn accepted D17683: netmap: add man page for the vale-ctl program.

Please commit with Approved by: gnn

Oct 24 2018, 3:33 PM

Oct 23 2018

gnn accepted D17664: netmap: add man page for the bridge program.

LGTM. Please add the Approved by: gnn@ line to your commit.

Oct 23 2018, 3:08 PM
gnn accepted D17364: netmap: align codebase to the current upstream (commit id 8374e1a7e6941).

Smoke tested in the Sentex cluster on cxl (Chelsio) hardware.

Oct 23 2018, 8:09 AM

Oct 8 2018

gnn added a reviewer for D17364: netmap: align codebase to the current upstream (commit id 8374e1a7e6941): np.
Oct 8 2018, 11:31 PM

Oct 5 2018

gnn accepted D17411: man: fix vale(4) port naming.

LGTM. Approved by mentor.

Oct 5 2018, 9:22 PM
gnn committed rS339196: Add myself as co-mentor with hrs@ for Vincenzo Maffione.
Add myself as co-mentor with hrs@ for Vincenzo Maffione
Oct 5 2018, 3:03 PM

Oct 1 2018

gnn accepted D17348: Allow DTrace audit provider probes to fire even if auditd(8) isn't running..

LGTM

Oct 1 2018, 2:41 PM

Sep 30 2018

gnn accepted D17348: Allow DTrace audit provider probes to fire even if auditd(8) isn't running..

LGTM

Sep 30 2018, 3:38 PM

Sep 29 2018

gnn committed rS339017: Free Daichi Goto from mentorship.
Free Daichi Goto from mentorship
Sep 29 2018, 4:38 PM

Sep 4 2018

gnn committed rP478962: Fix typo.
Fix typo
Sep 4 2018, 2:12 PM
gnn committed rP478956: Update the license allow post GPLv2.
Update the license allow post GPLv2
Sep 4 2018, 1:14 PM
gnn committed rP478954: Remove an unused dependency, update to properly grab version of Python.
Remove an unused dependency, update to properly grab version of Python
Sep 4 2018, 1:12 PM

Sep 3 2018

gnn committed rP478916: Update build dependencies to track a library rather than an executable.
Update build dependencies to track a library rather than an executable
Sep 3 2018, 7:43 PM
gnn committed rP478915: Update dependencies to properly follow Python and libraries.
Update dependencies to properly follow Python and libraries
Sep 3 2018, 7:41 PM
gnn committed rP478914: Switch to the more idiomatic inclusion of Python.
Switch to the more idiomatic inclusion of Python
Sep 3 2018, 7:33 PM
gnn committed rP478894: Attach libbtbb and ubertooth to the build.
Attach libbtbb and ubertooth to the build
Sep 3 2018, 6:47 PM
gnn committed rP478892: Make this port depend on its library.
Make this port depend on its library
Sep 3 2018, 6:43 PM
gnn committed rP478890: Ubertooth Tools for use with Ubertooth One a Bluetooth and BLE sniffer.
Ubertooth Tools for use with Ubertooth One a Bluetooth and BLE sniffer
Sep 3 2018, 6:36 PM
gnn committed rP478889: Bluetooth Baseband Library for use by Ubertooth and others.
Bluetooth Baseband Library for use by Ubertooth and others
Sep 3 2018, 6:35 PM

Aug 20 2018

gnn accepted D16204: top(1): support multibyte characters in command names (ARGV array) depending on locale.

LGTM

Aug 20 2018, 9:30 AM
gnn added inline comments to D16763: top(1) - fixed an output problem at dumb terminal.
Aug 20 2018, 9:28 AM

Aug 6 2018

gnn accepted D16589: Allow anonymous DTrace audit-provider tracing by preloading audit event file..

LGTM

Aug 6 2018, 8:42 PM

Jul 26 2018

gnn accepted D16455: top(1): fixed the empty output problem in non-interactive mode (-n, -b) regressed in r336028.
Jul 26 2018, 12:42 PM
gnn accepted D16452: top(1): forgot in r336160.
Jul 26 2018, 12:41 PM

Jul 15 2018

gnn accepted D16268: Fix the UDP tests.
Jul 15 2018, 7:22 PM
gnn accepted D16276: Don't rely on a local sshd being running for a local test..
Jul 15 2018, 7:20 PM

Jul 10 2018

gnn requested changes to D16095: add a new port: textproc/tttcmds.

Please find a ports person (I don''t commit enough ports) to review this as well please.

Jul 10 2018, 3:00 AM

Jul 9 2018

gnn accepted D16174: top(1): Fix the prompt bug and core dump problem in o / p mode that occurred by r336028.
Jul 9 2018, 4:00 PM

Jul 8 2018

gnn requested changes to D16174: top(1): Fix the prompt bug and core dump problem in o / p mode that occurred by r336028.
Jul 8 2018, 4:21 PM

Jul 5 2018

gnn accepted D16083: Changed to eliminate the upper limit of command length displayed by "-a" and expand to match terminal width.

Approved by mentor.

Jul 5 2018, 9:57 PM

Jul 2 2018

gnn added inline comments to D16083: Changed to eliminate the upper limit of command length displayed by "-a" and expand to match terminal width.
Jul 2 2018, 1:34 AM

Jun 30 2018

gnn accepted D16058: top(1) - support UTF-8 display.

LGTM

Jun 30 2018, 3:09 PM
gnn requested changes to D16058: top(1) - support UTF-8 display.
Jun 30 2018, 7:12 AM

Jun 26 2018

gnn accepted D16006: top(1): increased the maximum length of command shown by "-a".

Approved.

Jun 26 2018, 8:02 AM

Jun 18 2018

gnn accepted D15855: Fix dtrace output of IP addresses as strings.

LGTM. Thanks.

Jun 18 2018, 9:08 AM

May 11 2018

gnn accepted D15363: Add deprecation notice for vxge(4).

LGTM.

May 11 2018, 4:14 AM

Apr 11 2018

gnn committed rS332410: Temporarily suspend Bruce Simpson's commit bit..
Temporarily suspend Bruce Simpson's commit bit.
Apr 11 2018, 5:19 PM

Feb 28 2018

gnn updated the diff for D9988: Add support for a copyoutmbuf() subroutine for DTrace..

Updates from bcr and markj

Feb 28 2018, 4:52 AM
gnn planned changes to D9988: Add support for a copyoutmbuf() subroutine for DTrace..
Feb 28 2018, 4:49 AM

Feb 26 2018

gnn accepted D11600: net/packetdrill: update to latest version.
Feb 26 2018, 6:34 PM

Feb 19 2018

gnn accepted D10006: Add dwatch(8) for watching processes as they trigger dtrace probe.
Feb 19 2018, 1:59 AM

Feb 4 2018

gnn accepted D14141: fix underflow for cubic_cwnd().
Feb 4 2018, 7:26 AM

Jan 30 2018

gnn accepted D14122: makesyscalls: permit a range of syscall numbers for UNIMPL.
Jan 30 2018, 1:20 AM

Jan 11 2018

gnn accepted D13670: Make dtraceall loadable again on arm64.
Jan 11 2018, 5:50 PM

Dec 3 2017

gnn committed rS326503: Add support for RealTek 8812 over USB.
Add support for RealTek 8812 over USB
Dec 3 2017, 10:02 PM

Nov 13 2017

gnn accepted D12474: Add destructive dtrace to bsdinstall hardening menu.
Nov 13 2017, 1:33 AM
gnn accepted D13017: Add IPSec tests in tunnel mode.
Nov 13 2017, 1:29 AM

Nov 3 2017

gnn accepted D12747: loopback route needs RTF_PINNED flag.
Nov 3 2017, 5:33 PM

Oct 19 2017

gnn added a reviewer for D12586: improve inp locking in getsockopt, setsockopt, and related functions: rwatson.
Oct 19 2017, 4:06 PM

Oct 9 2017

gnn accepted D12583: check so_error earlier in sosend_generic.
Oct 9 2017, 11:02 PM
gnn committed rS324435: Add the firmware for the Intel 8265 WiFi device..
Add the firmware for the Intel 8265 WiFi device.
Oct 9 2017, 3:55 PM
gnn committed rS324434: Add support for Intel 8265 WiFi.
Add support for Intel 8265 WiFi
Oct 9 2017, 3:49 PM

Oct 3 2017

gnn accepted D12569: Updates to Tiers..
Oct 3 2017, 4:55 AM

Sep 20 2017

gnn committed rS323814: MFC: 323253, 323499.
MFC: 323253, 323499
Sep 20 2017, 4:31 PM