Paths

Table of Contentst

Differential D30530

libpmc: remove pe->alias
ClosedPublic
Actions

Authored by mhorne on May 28 2021, 6:11 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 15, 7:39 AM

	Unknown Object (File)
	Fri, Nov 15, 5:53 AM

	Unknown Object (File)
	Oct 20 2024, 3:21 AM

	Unknown Object (File)
	Oct 2 2024, 7:50 AM

	Unknown Object (File)
	Sep 28 2024, 8:03 AM

	Unknown Object (File)
	Sep 27 2024, 9:33 AM

	Unknown Object (File)
	Sep 26 2024, 7:47 PM

	Unknown Object (File)
	Sep 26 2024, 11:39 AM

View All 67 Files

Subscribers

Details

Reviewers

emaste
ray
gnn

Group Reviewers

Commits

rG3a9b3a847026: libpmc: remove pe->alias
rG0c915023dbb7: libpmc: remove pe->alias

Summary

It has never been a part of upstream's struct pmu_event. The jevents
utility will not fill this field, so remove it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.May 28 2021, 6:11 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 28 2021, 6:11 PM

mhorne requested review of this revision.May 28 2021, 6:11 PM

Harbormaster completed remote builds in B39545: Diff 90068.May 28 2021, 6:12 PM

Linux (now?) has const char *compat; in this slot, is that equivalent?

In D30530#685644, @emaste wrote:

Linux (now?) has const char *compat; in this slot, is that equivalent?

They seem to be different. The intent of the alias field was to allow events to have multiple names (I guess). The purpose of the compat field is to allow for mapping events to specific SoCs, rather than CPUs. How this is achieved is not obvious from the commit message, but the compat feature was added much more recently (2020).

gnn accepted this revision.May 28 2021, 7:10 PM

This revision is now accepted and ready to land.May 28 2021, 7:10 PM

Closed by commit rG0c915023dbb7: libpmc: remove pe->alias (authored by mhorne). · Explain WhyMay 31 2021, 8:41 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG0c915023dbb7: libpmc: remove pe->alias.

mhorne added a commit: rG3a9b3a847026: libpmc: remove pe->alias.Jul 29 2021, 3:27 PM

Revision Contents
Changeset List

Path

Size

lib/

libpmc/

libpmc_pmu_util.c

4 lines

pmu-events/

1 line

Diff 90213

lib/libpmc/libpmc_pmu_util.c

Loading...

lib/libpmc/pmu-events/pmu-events.h

Loading...