Page MenuHomeFreeBSD

libpmc: remove pe->alias
ClosedPublic

Authored by mhorne on May 28 2021, 6:11 PM.

Details

Summary

It has never been a part of upstream's struct pmu_event. The jevents
utility will not fill this field, so remove it.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Linux (now?) has const char *compat; in this slot, is that equivalent?

Linux (now?) has const char *compat; in this slot, is that equivalent?

They seem to be different. The intent of the alias field was to allow events to have multiple names (I guess). The purpose of the compat field is to allow for mapping events to specific SoCs, rather than CPUs. How this is achieved is not obvious from the commit message, but the compat feature was added much more recently (2020).

This revision is now accepted and ready to land.May 28 2021, 7:10 PM
This revision was automatically updated to reflect the committed changes.