Page MenuHomeFreeBSD
Differential D30530

libpmc: remove pe->alias
ClosedPublic
Actions

Authored by mhorne on May 28 2021, 6:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 2, 10:43 AM
Unknown Object (File)
Mar 8 2024, 12:01 AM
Unknown Object (File)
Feb 1 2024, 3:22 PM
Unknown Object (File)
Jan 10 2024, 9:19 AM
Unknown Object (File)
Dec 22 2023, 1:46 AM
Unknown Object (File)
Dec 20 2023, 2:09 AM
Unknown Object (File)
Dec 14 2023, 10:31 PM
Unknown Object (File)
Nov 24 2023, 1:47 AM
View All 30 Files
Subscribers
imp

Details

Reviewers
emaste
ray
gnn
Group Reviewers
pmc
Commits
rG3a9b3a847026: libpmc: remove pe->alias
rG0c915023dbb7: libpmc: remove pe->alias
Summary

It has never been a part of upstream's struct pmu_event. The jevents
utility will not fill this field, so remove it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.May 28 2021, 6:11 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 28 2021, 6:11 PM
mhorne requested review of this revision.May 28 2021, 6:11 PM
Harbormaster completed remote builds in B39545: Diff 90068.May 28 2021, 6:12 PM
emaste added a comment.May 28 2021, 6:19 PM

Linux (now?) has const char *compat; in this slot, is that equivalent?

mhorne added a comment.May 28 2021, 6:38 PM
In D30530#685644, @emaste wrote:

Linux (now?) has const char *compat; in this slot, is that equivalent?

They seem to be different. The intent of the alias field was to allow events to have multiple names (I guess). The purpose of the compat field is to allow for mapping events to specific SoCs, rather than CPUs. How this is achieved is not obvious from the commit message, but the compat feature was added much more recently (2020).

gnn accepted this revision.May 28 2021, 7:10 PM
This revision is now accepted and ready to land.May 28 2021, 7:10 PM
Closed by commit rG0c915023dbb7: libpmc: remove pe->alias (authored by mhorne). · Explain WhyMay 31 2021, 8:41 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG0c915023dbb7: libpmc: remove pe->alias.
mhorne added a commit: rG3a9b3a847026: libpmc: remove pe->alias.Jul 29 2021, 3:27 PM

Revision Contents
Changeset List

PathSize
lib/
libpmc/
4 lines
pmu-events/
1 line

Diff 90213

View Options

lib/libpmc/libpmc_pmu_util.c

Loading...
View Options

lib/libpmc/pmu-events/pmu-events.h

Loading...