Page MenuHomeFreeBSD
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Sat, Apr 20

gnn accepted D44483: sdt: Prototype implementation of SDT probes using hot-patching.

LGTM

Sat, Apr 20, 4:28 PM

Mar 21 2024

gnn added a comment to D43504: netinet: add a probe point for IP stats counters.

LGTM. Do it!

Mar 21 2024, 3:49 AM

Nov 14 2023

gnn closed D42096: A skeleton kernel module suitable for creating new such modules..

commit 029848334f85e03895234db8b89f5544ffb6e720 (HEAD -> main, freebsd/main, fr>
Author: George V. Neville-Neil <gnn@FreeBSD.org>
Date: Tue Nov 14 16:09:18 2023 -0500

Nov 14 2023, 9:13 PM
gnn committed rGb2e41172bdc0: A skeleton kernel module suitable for creating new such modules. (authored by gnn).
A skeleton kernel module suitable for creating new such modules.
Nov 14 2023, 9:12 PM
gnn committed rG029848334f85: Address review feedback on a typo. (authored by gnn).
Address review feedback on a typo.
Nov 14 2023, 9:12 PM
gnn added a comment to D42096: A skeleton kernel module suitable for creating new such modules..

@jhb Just sent a private email asking for more of these and I'll organize and commit, thanks!

Nov 14 2023, 6:45 PM

Nov 12 2023

gnn added a comment to D42096: A skeleton kernel module suitable for creating new such modules..

I have to say I prefer the version with the module_data, even though it is admittedly longer, because it shows the reader how to explicitly add module data. A much simpler verison with SYSINIT and SYSUNINIT doesn't easily show someone how to not only make a module but how to create their private module data. I could create a version with both using a #define #if setup, so we can show both styles. Let me know is that would be preferred or if what we have here is acceptable.

Nov 12 2023, 1:17 AM
gnn updated the diff for D42096: A skeleton kernel module suitable for creating new such modules..
  • Update the minor issues found by jhb@, other discussion continues.
Nov 12 2023, 1:12 AM

Oct 5 2023

gnn requested review of D42096: A skeleton kernel module suitable for creating new such modules..
Oct 5 2023, 8:08 PM

Sep 7 2023

gnn accepted D41745: dtrace: Add the 'oformat' libdtrace option..

Please address the comments from markj@ but otherwise this looks good, and more extensive than what we came up with on CADETS.

Sep 7 2023, 1:10 PM ยท DTrace

Sep 5 2023

gnn committed R9:df296dae57f2: Update my key as the older one is now revoked. (authored by gnn).
Update my key as the older one is now revoked.
Sep 5 2023, 4:35 PM

May 5 2023

gnn accepted D39933: man9: Add a manual page for kstack_contains(9)..

Approved

May 5 2023, 8:04 AM

Apr 10 2023

gnn accepted D39488: procfs: Sync a documentation comment with the code..

Approved

Apr 10 2023, 5:40 PM
gnn accepted D39484: procfs: Document the content of /proc/$PID/map..

Approved

Apr 10 2023, 3:20 PM

Apr 5 2023

gnn accepted D39439: pmc: Keep a list sorted..

Approved

Apr 5 2023, 6:41 PM

Mar 28 2023

gnn accepted D39298: pmc: Add a reminder to maintain documentation..

Approved

Mar 28 2023, 11:10 PM

Mar 25 2023

gnn accepted D39264: procfs: Add manual page cross references..

Approved

Mar 25 2023, 2:36 PM

Mar 24 2023

gnn added a comment to D39249: pmcstat: Warn about text output format stability..

Approved.

Mar 24 2023, 1:12 PM

Feb 24 2023

gnn accepted D38673: Add gnn@ as my mentor..
Feb 24 2023, 9:35 PM

Feb 18 2023

gnn accepted D38658: Sort a list of mentor/mentee relationships..
Feb 18 2023, 7:26 PM
gnn accepted D38657: pgpkeys: Add a stronger public key to 'jkoshy.key'..
Feb 18 2023, 7:08 PM

Feb 13 2023

gnn accepted D38544: Move myself to the list of active developers..

LGTM

Feb 13 2023, 1:26 PM

Dec 21 2022

gnn accepted D37773: Fix loading the hwpmc module when ACPI is enabled.

LGTM

Dec 21 2022, 3:11 PM

Dec 14 2022

gnn accepted D37694: tcp: retire TCPDEBUG.

LGTM

Dec 14 2022, 2:30 PM

May 31 2022

gnn accepted D35339: mbuf(9): Implement a leaf network interface field in the mbuf packet header..

LGTM

May 31 2022, 1:41 PM

Mar 28 2022

gnn removed a member for secteam: gnn.
Mar 28 2022, 10:01 PM

Mar 21 2022

gnn committed rGbb53dd56c30c: kern_tc.c/cputick2usec() (which is used to calculate cputime from (authored by firk_cantconnect.ru).
kern_tc.c/cputick2usec() (which is used to calculate cputime from
Mar 21 2022, 1:35 PM
gnn closed D34558: Fix imprecisions and timestep in cputime counters.
Mar 21 2022, 1:34 PM

Mar 20 2022

gnn abandoned D5330: Fix tryforward so that it can return ICMP errors to the correct origin, even in the face of IPFW and NAT..
Mar 20 2022, 8:06 PM
gnn abandoned D9658: Remove the arbitrary limit on DTrace buffers.
Mar 20 2022, 8:06 PM
gnn abandoned D9987: Add support for syscall::*fork:return tracing in DTrace.
Mar 20 2022, 8:05 PM
gnn abandoned D9988: Add support for a copyoutmbuf() subroutine for DTrace..
Mar 20 2022, 8:05 PM
gnn abandoned D10013: Add support for syscall::*fork:return probes in both parent and child..
Mar 20 2022, 8:04 PM

Mar 17 2022

gnn added a comment to D34558: Fix imprecisions and timestep in cputime counters.

For some reason phk@ can't currently log in, so he emailed me his comments. I paste them here, verbatim:

Mar 17 2022, 2:08 AM

Mar 16 2022

gnn added a comment to D34558: Fix imprecisions and timestep in cputime counters.

Is it possible to find out how this was tested?

Mar 16 2022, 9:53 PM
gnn added reviewers for D34558: Fix imprecisions and timestep in cputime counters: phk, imp.
Mar 16 2022, 9:51 PM

Jan 27 2022

gnn removed a member for transport: gnn.
Jan 27 2022, 3:56 PM
gnn removed a member for pmc: gnn.
Jan 27 2022, 3:55 PM
gnn removed a member for DTrace: gnn.
Jan 27 2022, 3:55 PM
gnn removed a member for network: gnn.
Jan 27 2022, 3:55 PM

Jan 22 2022

gnn accepted D34003: ports-mgmt/pkg-graph: New port to visualize package dependencies.

LGTM and Thanks!

Jan 22 2022, 5:13 PM

Nov 16 2021

gnn committed rG06a8ffd4cd54: Fix two more nits from 0mp (authored by gnn).
Fix two more nits from 0mp
Nov 16 2021, 2:01 PM
gnn committed rG406feaa862d7: Initial clean up the language in the manual pages. (authored by gnn).
Initial clean up the language in the manual pages.
Nov 16 2021, 2:01 PM
gnn committed rG409d1bf7d6de: Address review comments from 0mp, debdrup and oshogbo (authored by gnn).
Address review comments from 0mp, debdrup and oshogbo
Nov 16 2021, 2:01 PM
gnn closed D32976: Initial clean up the language in the manual pages..
Nov 16 2021, 2:01 PM
gnn updated the diff for D32976: Initial clean up the language in the manual pages..
  • Fix two more nits from 0mp
Nov 16 2021, 1:43 PM

Nov 15 2021

gnn updated the diff for D32976: Initial clean up the language in the manual pages..
  • Address review comments from 0mp, debdrup and oshogbo
Nov 15 2021, 5:37 PM

Nov 12 2021

gnn requested review of D32976: Initial clean up the language in the manual pages..
Nov 12 2021, 9:13 PM

Sep 5 2021

gnn committed rGc850ca3a1716: Retore the vnet before returning an error. (authored by gnn).
Retore the vnet before returning an error.
Sep 5 2021, 10:34 PM

Aug 26 2021

gnn accepted D31700: tcp: Remove unused v6 state definitions.

Pretty much anything marked as KAME compatibility can be removed as KAME ended long ago.

Aug 26 2021, 9:15 PM

Jun 21 2021

gnn committed rGc6b2d024d7ee: Retore the vnet before returning an error. (authored by gnn).
Retore the vnet before returning an error.
Jun 21 2021, 2:50 PM
gnn closed D30741: Restore VNET before returning in error paths in vlan_setmulti..
Jun 21 2021, 2:50 PM

Jun 17 2021

gnn accepted D30804: NOTES: Update the HZ entry with latest advice..

LGTM

Jun 17 2021, 5:00 PM
gnn accepted D30802: man9: add hz(9) and hardclock(9).

LGTM

Jun 17 2021, 5:00 PM

May 28 2021

gnn accepted D30531: libpmc: always generate libpmc_events.c.
May 28 2021, 7:10 PM
gnn accepted D30530: libpmc: remove pe->alias.
May 28 2021, 7:10 PM
gnn accepted D30529: remove unused 'isfixed' variable.
May 28 2021, 7:09 PM
gnn accepted D30528: libpmc: eliminate pmc_pmu_stat_mode().
May 28 2021, 7:09 PM
gnn accepted D30527: libpmc: fix Intel "instructions" alias.
May 28 2021, 7:09 PM
gnn accepted D30526: pmccontrol: improve -L with pmu-events.
May 28 2021, 7:08 PM

Apr 21 2021

gnn accepted D29887: pmcstat: set initial counter value to zero.
Apr 21 2021, 4:48 PM
gnn accepted D29885: pmc_allocate(3): document the count argument.
Apr 21 2021, 4:48 PM

Apr 20 2021

gnn accepted D28434: Add FIB_ALGO to GENERIC on amd64/arm64..
Apr 20 2021, 11:39 PM

Apr 16 2021

gnn accepted D29787: man: document ether_gen_addr(9).

LGTM

Apr 16 2021, 1:44 AM

Apr 9 2021

gnn committed R9:a0fbda3eef0f: Rough draft on collaboration using github (authored by gnn).
Rough draft on collaboration using github
Apr 9 2021, 8:18 PM
gnn committed R9:63584c7bba7b: Address points brought up by bsdimp (authored by gnn).
Address points brought up by bsdimp
Apr 9 2021, 8:18 PM
gnn committed R9:6982d9119d29: Add langauge and other simple updates from uqs (authored by gnn).
Add langauge and other simple updates from uqs
Apr 9 2021, 8:18 PM
gnn committed R9:e47e964a9d36: Rough draft on collaboration using github (authored by gnn).
Rough draft on collaboration using github
Apr 9 2021, 8:18 PM

Apr 7 2021

gnn accepted D26447: add deprecation notice to ftpd.

Now that this review has devolved to the point of discussing democracy, rather than the deprecation of a piece of long surviving, but, inherently insecure code in our base system, it's time for people to step back from their keyboards and realize that removing this from base does not make it impossible to install or use, it simply reduces the default attack surface of our system. So, let's let emaste put this deprecation in for 14, and move on.

Apr 7 2021, 1:23 PM
gnn accepted D29600: arm64: Fix finding the pmc event ID.
Apr 7 2021, 1:05 PM

Apr 2 2021

gnn accepted D29555: pf: Add static DTrace probe points.

LGTM

Apr 2 2021, 5:10 PM
gnn added inline comments to D29543: license: Create a license guideline document.
Apr 2 2021, 5:07 PM
gnn added inline comments to D29543: license: Create a license guideline document.
Apr 2 2021, 5:03 PM

Mar 18 2021

gnn accepted D29268: armv8crypto: add some missing copyright statements.

LGTM

Mar 18 2021, 9:11 PM

Mar 11 2021

gnn accepted D29226: SPDX: Add canonical licenses for indirect SPDX references in the tree.

LGTM

Mar 11 2021, 11:23 PM

Mar 10 2021

gnn accepted D29201: net/tcptestsuite: Fix pkg-plist.

LGTM. Thanks.

Mar 10 2021, 8:30 PM
gnn committed rP568015: Take maintainership of the port and add updated files..
Take maintainership of the port and add updated files.
Mar 10 2021, 4:30 PM

Feb 19 2021

gnn accepted D28804: Fix `arp -d` / `ndp -d`..

Couple of nits but otherwise LGTM.

Feb 19 2021, 8:59 PM

Feb 12 2021

gnn added reviewers for D28622: handbook/config: Add section on configuring IPv6: bz, hrs.
Feb 12 2021, 6:35 PM
gnn accepted D28622: handbook/config: Add section on configuring IPv6.
Feb 12 2021, 6:35 PM

Feb 8 2021

gnn accepted D22712: Add Router and Prefix table limits..

LGTM

Feb 8 2021, 5:49 PM

Jan 22 2021

gnn accepted D22003: Add lle_event handler to ARP.
Jan 22 2021, 3:20 PM

Jan 19 2021

gnn added a comment to D28232: Fix possible panic in udp6_input() due to lack of locking..

Yup, I understand that we do not currently have that function. I think you ought to add that as part of this fix.

Jan 19 2021, 4:25 PM
gnn requested changes to D28232: Fix possible panic in udp6_input() due to lack of locking..

I believe the use of this boolean is the wrong approach. If you want to check and then lock you'll need to an an INP_RLOCKED similar to INP_WLOCKED which can be found in in_pcb.h.

Jan 19 2021, 1:07 PM

Jan 13 2021

gnn accepted D28132: Handle functions that use a nop in the arm64 fbt.
Jan 13 2021, 6:00 PM

Jan 5 2021

gnn accepted D27884: Install dtrace.h and depedencies.
Jan 5 2021, 4:05 PM
gnn accepted D27973: Move the PMC overflow count to make it per-CPU.

LGTM

Jan 5 2021, 4:04 PM

Dec 13 2020

gnn committed R9:a978c10d524c: Approved by: rwatson (mentor) (authored by gnn).
Approved by: rwatson (mentor)
Dec 13 2020, 6:39 PM
gnn committed R9:bfec4a38693a: Approved by: rwatson (mentor) (authored by gnn).
Approved by: rwatson (mentor)
Dec 13 2020, 6:39 PM
gnn committed R9:055c82f2f0e4: Add a new project (Dingo) to the list of projects that are being (authored by gnn).
Add a new project (Dingo) to the list of projects that are being
Dec 13 2020, 6:37 PM
gnn committed R9:b8d403de6f83: Add new worker (Andrea Campi) who is working on a port of Howl. (authored by gnn).
Add new worker (Andrea Campi) who is working on a port of Howl.
Dec 13 2020, 6:36 PM
gnn committed R9:998fc7dad297: Update information on new system (cheetah) put into the lab. (authored by gnn).
Update information on new system (cheetah) put into the lab.
Dec 13 2020, 6:28 PM
gnn committed R9:c0cd4daf476d: A few word changes from obrien. (authored by gnn).
A few word changes from obrien.
Dec 13 2020, 6:28 PM
gnn committed R9:d2a917e97ed3: Submitted by: Johnny Cho popeye at yahoo-inc.com (authored by gnn).
Submitted by: Johnny Cho popeye at yahoo-inc.com
Dec 13 2020, 6:21 PM
gnn committed R9:6cdad1c50d33: Update key to contain a freebsd.org address as well as my own normal email (authored by gnn).
Update key to contain a freebsd.org address as well as my own normal email
Dec 13 2020, 6:17 PM

Dec 7 2020

gnn updated the diff for D27354: Address issue pointed out in CVE-2020-25705.

Update with suggestions from emaste

Dec 7 2020, 3:43 PM

Nov 25 2020

gnn updated the diff for D27354: Address issue pointed out in CVE-2020-25705.

Clean up various bits for hopeful commit.

Nov 25 2020, 9:30 PM
gnn updated the diff for D27354: Address issue pointed out in CVE-2020-25705.

Updates based on conversations with cperciva and emaste

Nov 25 2020, 6:16 PM
gnn updated the diff for D27354: Address issue pointed out in CVE-2020-25705.

Address issues pointed out by philip@

Nov 25 2020, 3:54 PM

Nov 24 2020

gnn requested review of D27354: Address issue pointed out in CVE-2020-25705.
Nov 24 2020, 6:35 PM
Next