Page MenuHomeFreeBSD

pmccontrol: improve -L with pmu-events
ClosedPublic

Authored by mhorne on May 28 2021, 6:08 PM.

Details

Summary

Check if the action is supported rather than carrying a
machine-dependent #ifdef.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

usr.sbin/pmccontrol/pmccontrol.c
294

This (pmc_pmu_print_counters) is an empty fn on non-x86?

usr.sbin/pmccontrol/pmccontrol.c
294

For now, yes, but soon it won't be. However, pmc_pmu_enabled() will return false on those platforms.

This revision is now accepted and ready to land.May 28 2021, 6:35 PM
This revision was automatically updated to reflect the committed changes.