Page MenuHomeFreeBSD
Differential D30526

pmccontrol: improve -L with pmu-events
ClosedPublic
Actions

Authored by mhorne on May 28 2021, 6:08 PM.
Tags
None
Referenced Files
F81955667: D30526.id90210.diff
Tue, Apr 23, 5:32 PM
Unknown Object (File)
Tue, Apr 23, 5:33 AM
Unknown Object (File)
Tue, Apr 23, 1:03 AM
Unknown Object (File)
Tue, Apr 23, 1:03 AM
Unknown Object (File)
Tue, Apr 23, 12:59 AM
Unknown Object (File)
Tue, Apr 23, 12:46 AM
Unknown Object (File)
Sun, Apr 21, 9:06 PM
Unknown Object (File)
Sat, Apr 20, 4:07 AM
View All 54 Files
Subscribers
imp

Details

Reviewers
emaste
ray
gnn
Group Reviewers
pmc
Commits
rG6b2ccad29745: pmccontrol: improve -L with pmu-events
rG167cdaa7e300: pmccontrol: improve -L with pmu-events
Summary

Check if the action is supported rather than carrying a
machine-dependent #ifdef.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.May 28 2021, 6:08 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 28 2021, 6:08 PM
mhorne requested review of this revision.May 28 2021, 6:08 PM
Harbormaster completed remote builds in B39541: Diff 90064.May 28 2021, 6:08 PM
emaste added inline comments.May 28 2021, 6:15 PM
usr.sbin/pmccontrol/pmccontrol.c
295

This (pmc_pmu_print_counters) is an empty fn on non-x86?

mhorne added inline comments.May 28 2021, 6:20 PM
usr.sbin/pmccontrol/pmccontrol.c
295

For now, yes, but soon it won't be. However, pmc_pmu_enabled() will return false on those platforms.

emaste accepted this revision.May 28 2021, 6:35 PM
This revision is now accepted and ready to land.May 28 2021, 6:35 PM
gnn accepted this revision.May 28 2021, 7:08 PM
ray accepted this revision.May 28 2021, 10:32 PM
Closed by commit rG167cdaa7e300: pmccontrol: improve -L with pmu-events (authored by mhorne). · Explain WhyMay 31 2021, 8:40 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG167cdaa7e300: pmccontrol: improve -L with pmu-events.
mhorne added a commit: rG6b2ccad29745: pmccontrol: improve -L with pmu-events.Jul 29 2021, 3:27 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
pmccontrol/
16 lines

Diff 90210

View Options

usr.sbin/pmccontrol/pmccontrol.c

Loading...