Paths

Table of Contentst

pmcstat: set initial counter value to zero
ClosedPublic
Actions

Authored by mhorne on Apr 21 2021, 4:43 PM.

Tags

None

Referenced Files

	F153468045: D29887.id87877.diff
	Tue, Apr 21, 8:23 AM

	F153467959: D29887.id87877.diff
	Tue, Apr 21, 8:23 AM

	Unknown Object (File)
	Sun, Apr 19, 5:42 PM

	Unknown Object (File)
	Wed, Apr 15, 2:44 PM

	Unknown Object (File)
	Wed, Apr 15, 3:19 AM

	Unknown Object (File)
	Tue, Apr 7, 4:34 PM

	Unknown Object (File)
	Mon, Apr 6, 4:19 AM

	Unknown Object (File)
	Thu, Apr 2, 9:00 AM

View All Files

Subscribers

imp

pmc

Details

Reviewers

jkoshy_users.sourceforge.net
ray
emaste
mmacy
gnn

Commits

rG112e30301846: pmcstat: set initial counter value to zero
rGedcf9e59c356: pmcstat: set initial counter value to zero

Summary

For an infrequent event, pmcstat may report (u_long)-1 for CPUs where
the counter was never incremented. Just set this to zero, instead.

ev->ev_count is passed as the count argument to pmc_allocate(3), but
this wasn't always the case.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Apr 21 2021, 4:43 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 21 2021, 4:43 PM

mhorne requested review of this revision.Apr 21 2021, 4:43 PM

Harbormaster completed remote builds in B38756: Diff 87877.Apr 21 2021, 4:43 PM

gnn accepted this revision.Apr 21 2021, 4:48 PM

This revision is now accepted and ready to land.Apr 21 2021, 4:48 PM

Closed by commit rGedcf9e59c356: pmcstat: set initial counter value to zero (authored by mhorne). · Explain WhyApr 21 2021, 8:35 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rGedcf9e59c356: pmcstat: set initial counter value to zero.

mhorne added a commit: rG112e30301846: pmcstat: set initial counter value to zero.Apr 29 2021, 1:39 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

pmcstat/

pmcstat.c

2 lines

Diff 87897

View Options

usr.sbin/pmcstat/pmcstat.c

pmcstat: set initial counter value to zeroClosedPublicActions