Paths

Table of Contentst

Differential D29887

pmcstat: set initial counter value to zero
ClosedPublic
Actions

Authored by mhorne on Apr 21 2021, 4:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jun 16, 6:17 AM

	Unknown Object (File)
	Mon, Jun 2, 12:19 AM

	Unknown Object (File)
	Sun, Jun 1, 1:11 PM

	Unknown Object (File)
	Sat, May 31, 2:21 AM

	Unknown Object (File)
	Apr 21 2025, 9:21 PM

	Unknown Object (File)
	Apr 21 2025, 9:09 PM

	Unknown Object (File)
	Apr 21 2025, 8:55 PM

	Unknown Object (File)
	Apr 21 2025, 8:32 PM

Subscribers

Details

Reviewers

jkoshy_users.sourceforge.net
ray
emaste
mmacy
gnn

Commits

rG112e30301846: pmcstat: set initial counter value to zero
rGedcf9e59c356: pmcstat: set initial counter value to zero

Summary

For an infrequent event, pmcstat may report (u_long)-1 for CPUs where
the counter was never incremented. Just set this to zero, instead.

ev->ev_count is passed as the count argument to pmc_allocate(3), but
this wasn't always the case.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Apr 21 2021, 4:43 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 21 2021, 4:43 PM

mhorne requested review of this revision.Apr 21 2021, 4:43 PM

Harbormaster completed remote builds in B38756: Diff 87877.Apr 21 2021, 4:43 PM

gnn accepted this revision.Apr 21 2021, 4:48 PM

This revision is now accepted and ready to land.Apr 21 2021, 4:48 PM

Closed by commit rGedcf9e59c356: pmcstat: set initial counter value to zero (authored by mhorne). · Explain WhyApr 21 2021, 8:35 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rGedcf9e59c356: pmcstat: set initial counter value to zero.

mhorne added a commit: rG112e30301846: pmcstat: set initial counter value to zero.Apr 29 2021, 1:39 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

pmcstat/

2 lines

Diff 87897

usr.sbin/pmcstat/pmcstat.c

Loading...