User Details
- User Since
- Jul 18 2014, 8:51 PM (463 w, 6 d)
Thu, May 18
Minimal changes, otherwise LGTM.
Apr 2 2023
Mar 12 2023
Mar 11 2023
LGTM, and pretty clever to take a boolean to panic.
Feb 25 2023
Thanks!
The printf vs dtrace call choice is not easy but yes as long as the filesystem is still in usable condition I think we should prefer the dtrace call.
You may want to send a diff to @mckusick syncing the UFS change. FWIW, I think UFS should also embrace DTrace ;).
Feb 18 2023
Feb 11 2023
I think this is the first time I have seen a char string return value. Can we keep the same coding style as in ext2_check_direntry() ?
That is .. assigning error_msg within the function instead of returning it.
While I agree with the sentiment that panicing is a rather extreme measure, it is better to keep consistency between UFS and ext2.
Hmm.. we should keep consistency with UFS .. and that means panic in ext2_dirbad(). My guess is that for this case you shouldn' t call ext2_dirbad().
Feb 2 2023
Dec 17 2022
Dec 3 2022
Oct 26 2022
Oct 13 2022
Jul 11 2022
May 12 2022
- LGTM
Apr 4 2022
LGTM
Mar 5 2022
Feb 28 2022
Feb 21 2022
Feb 20 2022
Feb 2 2022
Jan 1 2022
LGTM, especially since we were not handling the case.
We should probably use PR ## instead of URLs in comments but there is no project policy on that.
LGTM, except for the minor comment issue.
Dec 15 2021
I appreciate this effort going on. Getting good implementations of these functions is tough.,
Dec 11 2021
Dec 6 2021
Nov 29 2021
Nov 28 2021
I will admit I don't like this. Does linux do the same?
Oct 22 2021
Oct 6 2021
Sep 25 2021
Interesting ... I don't see the old protocol described upstream
Aug 24 2021
Aug 2 2021
Please also take a look at NetBSD's change 1.23, "Avoid undefined behavior in fread(3)".
Jul 22 2021
Jun 25 2021
Jun 19 2021
Jun 16 2021
Jun 15 2021
Jun 1 2021
May 31 2021
Remove deprecated unlocking, pointed out by kib
May 30 2021
Duh ! I see now.
May 29 2021
Apr 25 2021
Apr 24 2021
We don't have the naming conflict here, but befs is OK.
FWIW, there is a fuse version which would be useful before considering a kernel version.
Apr 23 2021
While the ext_time_t approach is valid and it also consistent with UFS2, it is usually faster to use 32bit values so you *could* use casts. Either way is valid so I won't object.
LGTM, but ultimately cem@ is the local expert.
Apr 22 2021
Using all uppercase messages is bad, unless there is a panic.
Otherwise, LGTM.
Do not touch inode.h.
FWIW, I'd like to see OpenBFS (haiku OS) supported some day on FreeBSD, so this support is welcome.
Apr 3 2021
FWIW ....
I read gcov, but sys/gnu/gcov survived. Perhaps it was meant to be gprof?
LGTM, but gad is the expert.
Mar 17 2021
FWIW, I got the BSD-1-Clause License approved by OSI, Approval is not terribly important as we only use it for a couple of files in the tree.
OTOH the very simplistic license would be useful to adopt for source header files (*.h).
Feb 20 2021
Jan 1 2021
Dec 24 2020
Dec 22 2020
Dec 21 2020
Dec 20 2020
Wow, I should have dropped it by accident: it was surely my intention to keep couchdb in services.