pfg (Pedro Giffuni)
User

Projects

User Details

User Since
Jul 18 2014, 8:51 PM (182 w, 5 d)

Recent Activity

Yesterday

pfg committed rS328093: ufs: use mallocarray(9)..
ufs: use mallocarray(9).
Wed, Jan 17, 6:18 PM

Tue, Jan 16

pfg committed rS328070: SPDX: finish tagging sys/cam..
SPDX: finish tagging sys/cam.
Tue, Jan 16, 11:20 PM
pfg committed rS328067: scsi_ch.c: Small cleanups to the comments..
scsi_ch.c: Small cleanups to the comments.
Tue, Jan 16, 11:08 PM
pfg committed rS328056: ext2fs: use mallocarray(9)..
ext2fs: use mallocarray(9).
Tue, Jan 16, 7:29 PM
pfg committed rS328041: Fix build after r328020..
Fix build after r328020.
Tue, Jan 16, 6:05 AM

Mon, Jan 15

pfg added a comment to D13837: Wider adoption of mallocarray(9)..

For the record: the changes were committed by parts in a series of commits from r328016 to r328026.

Mon, Jan 15, 10:44 PM
pfg committed rS328026: misc geom and gnu: make some use of mallocarray(9)..
misc geom and gnu: make some use of mallocarray(9).
Mon, Jan 15, 9:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Mon, Jan 15, 9:23 PM
pfg committed rS328025: net*: make some use of mallocarray(9)..
net*: make some use of mallocarray(9).
Mon, Jan 15, 9:22 PM
pfg committed rS328024: netgraph: make some use of mallocarray(9)..
netgraph: make some use of mallocarray(9).
Mon, Jan 15, 9:19 PM
pfg committed rS328023: kern: make some use of mallocarray(9)..
kern: make some use of mallocarray(9).
Mon, Jan 15, 9:18 PM
pfg committed rS328022: cam: make some use of mallocarray(9)..
cam: make some use of mallocarray(9).
Mon, Jan 15, 9:15 PM
pfg committed rS328021: nfsclient: make some use of mallocarray(9)..
nfsclient: make some use of mallocarray(9).
Mon, Jan 15, 9:15 PM
pfg committed rS328020: mips: make some use of mallocarray(9)..
mips: make some use of mallocarray(9).
Mon, Jan 15, 9:13 PM
pfg committed rS328019: ndis: make some use of mallocarray(9)..
ndis: make some use of mallocarray(9).
Mon, Jan 15, 9:11 PM
pfg committed rS328018: powerpc: make some use of mallocarray(9)..
powerpc: make some use of mallocarray(9).
Mon, Jan 15, 9:11 PM
pfg committed rS328017: arm: make some use of mallocarray(9)..
arm: make some use of mallocarray(9).
Mon, Jan 15, 9:10 PM
pfg committed rS328016: x86: make some use of mallocarray(9)..
x86: make some use of mallocarray(9).
Mon, Jan 15, 9:08 PM

Sun, Jan 14

pfg committed rS327978: Free Fedor Uporov from mentorship..
Free Fedor Uporov from mentorship.
Sun, Jan 14, 9:21 PM
pfg committed rS327953: Fix build after r327949..
Fix build after r327949.
Sun, Jan 14, 12:31 AM

Sat, Jan 13

pfg updated the diff for D13837: Wider adoption of mallocarray(9)..

I committed sys/dev in rr327949 so drop those from the Revision.

Sat, Jan 13, 10:36 PM
pfg committed rS327949: dev: make some use of mallocarray(9)..
dev: make some use of mallocarray(9).
Sat, Jan 13, 10:30 PM
pfg committed rS327940: zstd: Use mallocarray(9) for calloc macro..
zstd: Use mallocarray(9) for calloc macro.
Sat, Jan 13, 7:03 PM
pfg committed rS327937: Revert r327934 to fix the log message..
Revert r327934 to fix the log message.
Sat, Jan 13, 6:56 PM
pfg committed rS327935: Add SPDX identifier for the example license..
Add SPDX identifier for the example license.
Sat, Jan 13, 6:28 PM
pfg committed rS327934: zstd: Use memalloc(9) for calloc macro..
zstd: Use memalloc(9) for calloc macro.
Sat, Jan 13, 6:09 PM

Fri, Jan 12

pfg committed rS327898: libalias: small memory allocation cleanups..
libalias: small memory allocation cleanups.
Fri, Jan 12, 11:12 PM
pfg committed rS327883: MFC r327697, r327699:.
MFC r327697, r327699:
Fri, Jan 12, 5:36 PM
pfg updated the diff for D13835: Make use of mallocarray(9) in drm drivers..

This should be a minimal and more straightforward replacement.

Fri, Jan 12, 4:44 PM

Thu, Jan 11

pfg removed reviewers for D13837: Wider adoption of mallocarray(9).: O3: Kernel Random Numbers Generator, jmg, slm, shurd.
Thu, Jan 11, 7:23 PM
pfg updated the diff for D13837: Wider adoption of mallocarray(9)..

Drop the arc4random change for now as to unblock this change.

Thu, Jan 11, 3:52 PM
pfg committed rS327831: dev/bhnd: Make use of mallocarray(9)..
dev/bhnd: Make use of mallocarray(9).
Thu, Jan 11, 3:44 PM
pfg committed rS327829: netpfil/ipfw: Make some use of mallocarray(9)..
netpfil/ipfw: Make some use of mallocarray(9).
Thu, Jan 11, 3:29 PM
pfg closed D13834: Make use of mallocarray in sys/netpfil/ipfw.
Thu, Jan 11, 3:29 PM
pfg committed rS327828: dev/(e1000,ixl): Make some use of mallocarray(9)..
dev/(e1000,ixl): Make some use of mallocarray(9).
Thu, Jan 11, 3:25 PM
pfg closed D13833: Make use of the newly introduce mallocarray(9)..
Thu, Jan 11, 3:25 PM
pfg accepted D13738: patch(1): Don't check for NUL bytes in Plan A.
Thu, Jan 11, 2:28 PM
pfg added a comment to D13837: Wider adoption of mallocarray(9)..
In D13837#290289, @cem wrote:
In D13837#290288, @pfg wrote:

It is now the case that it panics right

Right.

(OpenBSD panics also, I think)?

No idea.

Can we have it return NULL for M_NOWAIT and panic for M_WAITOK?

No, I don't think that makes any sense.

Thu, Jan 11, 12:25 AM
pfg added a comment to D13837: Wider adoption of mallocarray(9)..

When I started this changes, mallocarray(9) would return NULL on overflow, and for the M_WAITOK case the code was not prepared to handle that, so I avoided M_WAITOK changes for this revision (I was not going to do it at all).

Thu, Jan 11, 12:22 AM

Wed, Jan 10

pfg added a comment to D13837: Wider adoption of mallocarray(9)..
In D13837#290278, @cem wrote:

Was this mechanical (with e.g. coccinelle)?

Nope ... I checked it on opengrok and then by hand.

Wed, Jan 10, 11:56 PM
pfg added a comment to D13835: Make use of mallocarray(9) in drm drivers..

Hi!

What is the benefit of using mallocarray() here?

Wed, Jan 10, 11:52 PM
pfg added a reviewer for D13837: Wider adoption of mallocarray(9).: cem.
Wed, Jan 10, 11:44 PM
pfg committed rS327793: MFC r327289:.
MFC r327289:
Wed, Jan 10, 9:24 PM
pfg committed rS327791: MFC r327289:.
MFC r327289:
Wed, Jan 10, 9:17 PM
pfg created D13837: Wider adoption of mallocarray(9)..
Wed, Jan 10, 8:56 PM
pfg committed rS327788: linuxkpi: Simplify kmalloc_array..
linuxkpi: Simplify kmalloc_array.
Wed, Jan 10, 8:50 PM
pfg accepted D13834: Make use of mallocarray in sys/netpfil/ipfw.
Wed, Jan 10, 8:48 PM
pfg retitled D13834: Make use of mallocarray in sys/netpfil/ipfw from Make use of mallocarray in sys/netpfil/ipfs to Make use of mallocarray in sys/netpfil/ipfw.
Wed, Jan 10, 8:47 PM
pfg created D13835: Make use of mallocarray(9) in drm drivers..
Wed, Jan 10, 8:40 PM
pfg updated the summary of D13834: Make use of mallocarray in sys/netpfil/ipfw.
Wed, Jan 10, 8:31 PM
pfg created D13834: Make use of mallocarray in sys/netpfil/ipfw.
Wed, Jan 10, 8:30 PM
pfg created D13833: Make use of the newly introduce mallocarray(9)..
Wed, Jan 10, 8:15 PM
pfg committed rS327782: dev/bxe: make use of mallocarray(9)..
dev/bxe: make use of mallocarray(9).
Wed, Jan 10, 8:05 PM
pfg committed rS327781: Use mallocarray(9) in dirhash..
Use mallocarray(9) in dirhash.
Wed, Jan 10, 7:45 PM
pfg added a comment to D13810: Add metadata_csum feature support..
In D13810#289917, @fsu wrote:
In D13810#289909, @pfg wrote:
In D13810#289828, @fsu wrote:
In D13810#289543, @pfg wrote:

A thought : would it be possible to checksum only what we are going to write to disk?
Data will not, generally, corrupt in memory and the kernel has no use for the checksums at runtime so we only need to write stuff when it's going to be converted to the on-disk format in ext2_inode_cnv.c.

All fields, which are mentioned in SUMMERY, should be written to disk. If it will not be updated, we will have errors reported by e2fsck, or bunch of error messages from driver on linux side.

I am not complaining at all about what is being checksummed: I understand you want to checksum everything that is needed. The main doubt is when to checksum.

There are two possibilities: you either checksum everything as soon as you get it or you checksum at the last moment before writing to disk. Both options have their advantages It seems like the checksumming is happening all over the filesystem so you are doing the former, I was only wondering if we could do all the checksums in a single place, right when we are converting to the ext2fs format for writing.

I am not sure if such thing is poosible though, and your change is not incorrect so I'll let you think about it but I'll approve the patch.

I use second approach, checksum every field before bwrite() call.

OK, I see ...

Wed, Jan 10, 6:30 PM
pfg accepted D13810: Add metadata_csum feature support..
In D13810#289828, @fsu wrote:
In D13810#289543, @pfg wrote:

A thought : would it be possible to checksum only what we are going to write to disk?
Data will not, generally, corrupt in memory and the kernel has no use for the checksums at runtime so we only need to write stuff when it's going to be converted to the on-disk format in ext2_inode_cnv.c.

All fields, which are mentioned in SUMMERY, should be written to disk. If it will not be updated, we will have errors reported by e2fsck, or bunch of error messages from driver on linux side.

Wed, Jan 10, 3:44 PM

Tue, Jan 9

pfg committed rS327751: Use the __result_use_check attribute also for reallocf(3)..
Use the __result_use_check attribute also for reallocf(3).
Tue, Jan 9, 10:48 PM
pfg added a comment to D13810: Add metadata_csum feature support..

A thought : would it be possible to checksum only what we are going to write to disk?
Data will not, generally, corrupt in memory and the kernel has no use for the checksums at runtime so we only need to write stuff when it's going to be converted to the on-disk format in ext2_inode_cnv.c.

Tue, Jan 9, 8:36 PM

Mon, Jan 8

pfg committed rS327699: Revert r327697:.
Revert r327697:
Mon, Jan 8, 3:54 PM
pfg committed rS327697: malloc(9): drop the __result_use_check attribute for the kernel allocator..
malloc(9): drop the __result_use_check attribute for the kernel allocator.
Mon, Jan 8, 3:41 PM

Sat, Jan 6

pfg accepted D13737: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_* (cosmetic only)..
Sat, Jan 6, 4:17 PM
pfg accepted D13766: Introduce mallocarray() in the kernel.

OK, thanks.

Sat, Jan 6, 4:11 PM
pfg added inline comments to D13766: Introduce mallocarray() in the kernel.
Sat, Jan 6, 1:55 PM
pfg added inline comments to D13766: Introduce mallocarray() in the kernel.
Sat, Jan 6, 3:46 AM
pfg requested changes to D13766: Introduce mallocarray() in the kernel.

For the record: I never liked adding this to stdlib but in the case of the kernel I think it is a good thing.

Sat, Jan 6, 3:34 AM

Fri, Jan 5

pfg committed rS327590: MFC r327329:.
MFC r327329:
Fri, Jan 5, 5:23 PM
pfg committed rS327589: MFC r327329:.
MFC r327329:
Fri, Jan 5, 5:21 PM

Thu, Jan 4

pfg committed rS327550: MFC r327295:.
MFC r327295:
Thu, Jan 4, 3:58 PM
pfg committed rS327549: MFC r327295:.
MFC r327295:
Thu, Jan 4, 3:55 PM

Wed, Jan 3

pfg accepted D11530: ext2fs: Add 64bit feature support.

Approved: however since this depend on the 64 bit inode changes, my guess is that it cannot be merged to stable as-is.

Wed, Jan 3, 3:02 PM

Tue, Jan 2

pfg added inline comments to D11530: ext2fs: Add 64bit feature support.
Tue, Jan 2, 3:57 PM

Sun, Dec 31

pfg created D13706: sysv_ipc.c: merge copyright assignment to the NetBSD Foundation.
Sun, Dec 31, 4:09 AM
pfg committed rS327408: sysv_{ipc|shm}: update the NetBSD VCS tags to match nearer our files..
sysv_{ipc|shm}: update the NetBSD VCS tags to match nearer our files.
Sun, Dec 31, 3:34 AM

Sat, Dec 30

pfg committed rS327383: elink.[ch]: Move historic VCS tags after the license..
elink.[ch]: Move historic VCS tags after the license.
Sat, Dec 30, 3:13 PM
pfg committed rS327373: geom_ccd.c: Fix the licenses properly.
geom_ccd.c: Fix the licenses properly
Sat, Dec 30, 2:07 AM
pfg committed rS327372: geom_ccd.c: Update the license with changes from upstream..
geom_ccd.c: Update the license with changes from upstream.
Sat, Dec 30, 1:37 AM
pfg committed rS327370: ccdconfig: Move VCS tags to be more consistent with our style..
ccdconfig: Move VCS tags to be more consistent with our style.
Sat, Dec 30, 12:26 AM
pfg committed rS327368: ccdconfig: Update licensing terms to match NetBSD..
ccdconfig: Update licensing terms to match NetBSD.
Sat, Dec 30, 12:23 AM

Fri, Dec 29

pfg committed rS327331: if_txpreg.h: drop clauses 3 and 4..
if_txpreg.h: drop clauses 3 and 4.
Fri, Dec 29, 1:00 AM
pfg committed rS327329: dev/txp: Update if_txpreg.h to match OpenBSD's version..
dev/txp: Update if_txpreg.h to match OpenBSD's version.
Fri, Dec 29, 12:27 AM

Thu, Dec 28

pfg committed rS327297: Fix some typos..
Fix some typos.
Thu, Dec 28, 8:41 PM
pfg committed rS327296: netinet6/ip6_id.c: niels kindly dropped clause 3/4 from the license..
netinet6/ip6_id.c: niels kindly dropped clause 3/4 from the license.
Thu, Dec 28, 8:35 PM
pfg committed rS327295: Start syncing changes from OpenBSD's ip6_id.c instead of ip_id.c..
Start syncing changes from OpenBSD's ip6_id.c instead of ip_id.c.
Thu, Dec 28, 8:27 PM
pfg committed rS327294: Revert r327293.
Revert r327293
Thu, Dec 28, 8:10 PM
pfg committed rS327293: netinet6/ip6_id.c: niels kindly dropped clause 3/4 from the license..
netinet6/ip6_id.c: niels kindly dropped clause 3/4 from the license.
Thu, Dec 28, 7:43 PM
pfg committed rS327290: rpc.sprayd: Remove 3rd and 4th clauses in christos' license..
rpc.sprayd: Remove 3rd and 4th clauses in christos' license.
Thu, Dec 28, 5:52 PM
pfg committed rS327289: rpc.sprayd: Bring some changes from NetBSD..
rpc.sprayd: Bring some changes from NetBSD.
Thu, Dec 28, 5:44 PM
pfg committed rS327288: sys/sys/chio.h: add NetBSD RCS ID..
sys/sys/chio.h: add NetBSD RCS ID.
Thu, Dec 28, 2:26 PM
pfg committed rS327287: sys/i386/isa/elink*: sync with (older) NetBSD..
sys/i386/isa/elink*: sync with (older) NetBSD.
Thu, Dec 28, 2:14 PM
pfg committed rS327261: SPDX: fix wrong license ID tag in dev/cesa..
SPDX: fix wrong license ID tag in dev/cesa.
Thu, Dec 28, 3:11 AM
pfg committed rS327260: SPDX: fix wrong license ID tag in dev/spibus..
SPDX: fix wrong license ID tag in dev/spibus.
Thu, Dec 28, 3:05 AM
pfg committed rS327257: SPDX: fix wrong license ID tag in libkern..
SPDX: fix wrong license ID tag in libkern.
Thu, Dec 28, 1:20 AM
pfg committed rS327256: arm/ixp425: Drop 3rd and 4th clauses from Ichiro FUKUHARA's license..
arm/ixp425: Drop 3rd and 4th clauses from Ichiro FUKUHARA's license.
Thu, Dec 28, 1:12 AM

Wed, Dec 27

pfg committed rS327255: SPDX: fix license ID tags for arm/xscale..
SPDX: fix license ID tags for arm/xscale.
Wed, Dec 27, 10:48 PM
pfg committed rS327252: sparc64: Update idprom.h..
sparc64: Update idprom.h.
Wed, Dec 27, 10:01 PM
pfg committed rS327249: SPDX: Small for a license ID tags..
SPDX: Small for a license ID tags.
Wed, Dec 27, 9:36 PM
pfg committed rS327248: SPDX: Fix some License ID tags for libc..
SPDX: Fix some License ID tags for libc.
Wed, Dec 27, 9:21 PM
pfg committed rS327245: ccdconfig: Update licensing terms..
ccdconfig: Update licensing terms.
Wed, Dec 27, 8:10 PM
pfg committed rS327243: SPDX: Complete License ID tags for UFS..
SPDX: Complete License ID tags for UFS.
Wed, Dec 27, 7:14 PM

Fri, Dec 22

pfg added a comment to D11530: ext2fs: Add 64bit feature support.
In D11530#284219, @fsu wrote:

What I find confusing is that there is "force_64bit_alloc", labelled for testing/debugging only and a couple of TODO things that give the impresion that the implementation is still not ready.

Yep, seems like I should ask the suggestion here...
Let me explain. This is hack to allow to allocate blocks outside of UINT_MAX range, which was used for testing purposes..
I mean, it is too difficult to test 16TB volume in case of ENOSPC without it.
So, I want to store it in svn history, to explain, how it was tested.
My plan was to commit main patch and then remove this hack. Or it is too dirty behavior to store stuff like this in the history?

Fri, Dec 22, 5:52 PM