Page MenuHomeFreeBSD

pfg (Pedro Giffuni)
User

Projects

User Details

User Since
Jul 18 2014, 8:51 PM (292 w, 3 d)

Recent Activity

Sun, Feb 23

pfg committed rS358259: MFC r357414, r357415, r357417, r357423, r357424, r357587, r357655:.
MFC r357414, r357415, r357417, r357423, r357424, r357587, r357655:
Sun, Feb 23, 3:18 PM

Sat, Feb 22

pfg added a reviewer for D23793: kernel: provide panicky version of __unreachable: theraven.

Ugh.. I think this was discussed when __unreachable() was introduced (D2536 perhaps), and back then it was not considered a good idea.

Sat, Feb 22, 7:10 PM

Fri, Feb 21

pfg committed rS358209: MFC r357414, r357415, r357417, r357423, r357424, r357587, r357655:.
MFC r357414, r357415, r357417, r357423, r357424, r357587, r357655:
Fri, Feb 21, 4:48 AM

Thu, Feb 20

pfg committed rS358170: Revert r358153: it is causing unexpected issues with the build system..
Revert r358153: it is causing unexpected issues with the build system.
Thu, Feb 20, 3:52 PM
pfg committed rS358153: /etc/services: attempt bring the database to this century..
/etc/services: attempt bring the database to this century.
Thu, Feb 20, 3:54 AM
pfg closed D23621: Update /etc/services: attempt to bring it to the new century.
Thu, Feb 20, 3:54 AM

Sun, Feb 16

pfg added a comment to D17115: Generate /etc/services from the IANA registry (plus local mods).

IANA has indeed removed some services: I think people can de-register services they don't use/develop anymore. We should remove at least Kerberos IV and netatalk, both are not in the IANA. Also IANA lists first tcp, udp and lastly sctp so perhaps its better to jeep things consistent.

Sun, Feb 16, 11:10 PM
pfg added a reviewer for D23621: Update /etc/services: attempt to bring it to the new century: vangyzen.
Sun, Feb 16, 11:00 PM

Thu, Feb 13

pfg updated the diff for D23621: Update /etc/services: attempt to bring it to the new century.

Sync with latest updates.

Thu, Feb 13, 3:54 PM
pfg committed rS357860: Revert r357343:.
Revert r357343:
Thu, Feb 13, 3:42 PM
pfg updated the diff for D23621: Update /etc/services: attempt to bring it to the new century.

Update Take2:
It is important to consider the differences between System Ports and User
ports. This changes keeps the system ports closely in sync with IANA.

Thu, Feb 13, 3:33 PM

Tue, Feb 11

pfg added a comment to D23621: Update /etc/services: attempt to bring it to the new century.
In D23621#518545, @cy wrote:

The fact that Kerberos IV is EOL doesn'[t mitigate the fact that the entries are still registered with IANA and that some KRB4 app may expect the entries to exist. Suggest we use https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml as a reference.

Tue, Feb 11, 9:00 PM
pfg added a comment to D23621: Update /etc/services: attempt to bring it to the new century.
In D23621#518528, @mjg wrote:

If you want an example of what happens when a random parameter gets whacked out of proportion compared to Linux, here it is:
https://www.postgresql.org/message-id/CAEepm%3D3VF%3DPUp2f8gU8fgZB22yPE_KBS0%2Be1AHAtQ%3D09schTHg%40mail.gmail.com
Parameter set to 65536 because "why not" while it is 4096 on Linux resulted in a 256KB buffer in postgres when it should have been a fraction of that size. And so on. If there is no reason to deviate, don't.

Tue, Feb 11, 8:53 PM
pfg added a comment to D23621: Update /etc/services: attempt to bring it to the new century.

Hello;

In D23621#518513, @mjg wrote:

Removing very stale entries or adding something may be fine, but the list as suggested is a non-starter. One has to expect there is plenty of custom userspace code parsing it which will choke on the new size.

Tue, Feb 11, 7:33 PM
pfg created D23621: Update /etc/services: attempt to bring it to the new century.
Tue, Feb 11, 4:46 PM

Mon, Feb 10

pfg accepted D23605: Add a EXT2FS-specific implementation for lseek(SEEK_DATA)..

Good, indeed r252956, which was the predecesor of this, was built on an UFS patch.
Well done, thanks!

Mon, Feb 10, 6:37 PM

Fri, Feb 7

pfg committed rS357655: typo: stray spaces..
typo: stray spaces.
Fri, Feb 7, 3:16 PM
pfg committed rS357654: typo: s/impelmentation/implementation/..
typo: s/impelmentation/implementation/.
Fri, Feb 7, 3:14 PM

Thu, Feb 6

pfg committed rS357631: fstyp: sync HAMMER1/2 detection support with DragonFly BSD..
fstyp: sync HAMMER1/2 detection support with DragonFly BSD.
Thu, Feb 6, 6:04 PM

Wed, Feb 5

pfg committed rS357587: ethernet: Add a couple more Ethertypes..
ethernet: Add a couple more Ethertypes.
Wed, Feb 5, 7:11 PM

Mon, Feb 3

pfg committed rS357424: typo: Registration..
typo: Registration.
Mon, Feb 3, 2:02 AM
pfg committed rS357423: ethernet: Minor cleanup..
ethernet: Minor cleanup.
Mon, Feb 3, 1:08 AM

Sun, Feb 2

pfg committed rS357417: style(9): Fix spaces after #define..
style(9): Fix spaces after #define.
Sun, Feb 2, 7:02 PM
pfg committed rS357415: ethernet: add some more Ethertypes..
ethernet: add some more Ethertypes.
Sun, Feb 2, 6:33 PM
pfg committed rS357414: ethernet: add some more Ethertypes..
ethernet: add some more Ethertypes.
Sun, Feb 2, 6:27 PM

Fri, Jan 31

pfg committed rS357343: services: Add PROFInet and EtherCAT..
services: Add PROFInet and EtherCAT.
Fri, Jan 31, 6:55 PM

Thu, Jan 30

pfg committed rP524656: java/jakarta-regexp: deprecate..
java/jakarta-regexp: deprecate.
Thu, Jan 30, 7:01 PM

Wed, Jan 29

pfg committed rP524611: java/jakarta-commons-discovery: move to java/apache-commons-discovery.
java/jakarta-commons-discovery: move to java/apache-commons-discovery
Wed, Jan 29, 11:00 PM

Jan 25 2020

pfg committed rP524044: textproc/apache-poi: update to version 4.1.1.
textproc/apache-poi: update to version 4.1.1
Jan 25 2020, 3:50 PM

Jan 24 2020

pfg committed rP523979: math/apache-commons-math: sort math/Makefile.
math/apache-commons-math: sort math/Makefile
Jan 24 2020, 7:06 PM
pfg committed rP523978: math/jakarta-commons-math3 update and rename to apache-commons-math.
math/jakarta-commons-math3 update and rename to apache-commons-math
Jan 24 2020, 7:02 PM
pfg committed rP523970: math/superlu_mt: Resurrect..
math/superlu_mt: Resurrect.
Jan 24 2020, 3:27 PM

Jan 23 2020

pfg committed rP523937: devel/webstorm: Update to version 2019.3.2.
devel/webstorm: Update to version 2019.3.2
Jan 23 2020, 4:50 PM
pfg committed rP523936: devel/phpstorm: Update to version 2019.3.2.
devel/phpstorm: Update to version 2019.3.2
Jan 23 2020, 4:48 PM

Jan 22 2020

pfg committed rP523847: cad/calculix : update to version 2.16.1.
cad/calculix : update to version 2.16.1
Jan 22 2020, 9:19 PM

Jan 21 2020

pfg committed rP523750: math/metis4: Deprecate.
math/metis4: Deprecate
Jan 21 2020, 10:43 PM
pfg committed rP523737: java/apache-bcel: update description..
java/apache-bcel: update description.
Jan 21 2020, 7:57 PM

Jan 19 2020

pfg updated the diff for D23259: ext2fs: initial support for byteswapping..

Small fix .. and still very far from over.

Jan 19 2020, 9:16 PM
pfg updated the diff for D23259: ext2fs: initial support for byteswapping..

Update.
I started modifying htree and lookup as well, but it's coming quickly
off-hand.

Jan 19 2020, 8:02 PM
pfg added a comment to D23259: ext2fs: initial support for byteswapping..
In D23259#510030, @fsu wrote:

I am not sure that dinode and superblock conversion will be enough, as I checked on linux side, the group descriptors should be converted too, possible same for bitmaps.
From https://ext4.wiki.kernel.org/index.php/Ext4_Disk_Layout
"All fields in ext4 are written to disk in little-endian order"

Argh .. a look into the NetBSD code indicades the directory entries (atr least e2d_reclen and e2d_namlen) need special treatment as well. Not sure yet about names wichh are character strings.

Jan 19 2020, 4:03 PM
pfg added a comment to D23259: ext2fs: initial support for byteswapping..
In D23259#510030, @fsu wrote:

I am not sure that dinode and superblock conversion will be enough, as I checked on linux side, the group descriptors should be converted too, possible same for bitmaps.
From https://ext4.wiki.kernel.org/index.php/Ext4_Disk_Layout
"All fields in ext4 are written to disk in little-endian order"

Yes, everything is in LE. The question is where does the transfer happen? The eraliest we do that, the better. Otherwise we should probably move the group descriptors to the dinode header, to have everything that must be translated in the same place.

Jan 19 2020, 2:13 PM
pfg created D23259: ext2fs: initial support for byteswapping..
Jan 19 2020, 4:03 AM

Jan 16 2020

pfg committed rP523262: devel/R-cran-vcd: update to version 1.4-5.
devel/R-cran-vcd: update to version 1.4-5
Jan 16 2020, 9:58 PM

Jan 13 2020

pfg accepted D23159: fstyp: fix Coverity issues in hammer support.

LGTM. I forwarded the revision link to Tomohiro Kusumi from DragonFly as well.

Jan 13 2020, 9:52 PM

Jan 11 2020

pfg committed rS356624: Update ELFOSABI_* constants with OpenVOS..
Update ELFOSABI_* constants with OpenVOS.
Jan 11 2020, 1:45 AM

Jan 4 2020

pfg abandoned D15687: libssp is part of GCC, not an independent library..

Overcome by D22943 and SVN r356356.

Jan 4 2020, 10:09 PM
pfg committed rP522060: cad/calculix-ccx: Enable multithreading with spooles..
cad/calculix-ccx: Enable multithreading with spooles.
Jan 4 2020, 8:36 PM
pfg committed rP522059: cad/calculix-ccx: Enable multithreading with spooles..
cad/calculix-ccx: Enable multithreading with spooles.
Jan 4 2020, 8:34 PM
pfg accepted D22943: Provide libssp based on libc.

Cool.
FWIW, it may make sense to MFC this code: it is under strong copyleft and getting linked with everything.

Jan 4 2020, 3:04 PM

Dec 30 2019

pfg abandoned D22925: netpfil/ipfw: use arc4random() instead of random().

I am abandoning this line of changes: it doesnt bring any advantage.

Dec 30 2019, 2:55 PM
pfg abandoned D22924: netinet/cc: make use of arc4random().

Abandon: it was not exactly right.

Dec 30 2019, 2:48 PM
pfg committed rP521492: cad/calculix : update to version 2.16.
cad/calculix : update to version 2.16
Dec 30 2019, 2:36 PM

Dec 29 2019

pfg added a reviewer for D22943: Provide libssp based on libc: oliver.pntr-gmail.com.

Let me add Oliver as he was my student for GSoC 2015.

Dec 29 2019, 4:59 AM
pfg accepted D22943: Provide libssp based on libc.

I am fine with this approach: while we do have an implementation of these functions (GSoC 2015), I don't think FORTIFY_SOURCE solves anything that we don't already do with the strong stack protector. Stubbing the functions out is a quick and practical solution.
We should still consider removing the stubs in a near future: I haven't looked at how linux does it but I think this stuff is not carried by glibc but in GCC libs instead.

Dec 29 2019, 4:02 AM

Dec 28 2019

pfg committed rS356142: SPDX: update some tags with two licenses..
SPDX: update some tags with two licenses.
Dec 28 2019, 2:59 AM
pfg committed rS356141: arm/ffs.S: remove stale comment..
arm/ffs.S: remove stale comment.
Dec 28 2019, 2:11 AM

Dec 27 2019

pfg committed rS356106: msun: drop clause 3 from the Berkeley license..
msun: drop clause 3 from the Berkeley license.
Dec 27 2019, 1:11 AM
pfg closed D22928: Drop clause 3 of Berkeley license..
Dec 27 2019, 1:11 AM

Dec 26 2019

pfg added a comment to D22924: netinet/cc: make use of arc4random().

Unpredictability is not important here, it is more the distribution. Any reason why the change has to happen?

Dec 26 2019, 9:11 PM
pfg added reviewers for D22925: netpfil/ipfw: use arc4random() instead of random(): melifaro, ae.

Add some developers that are more likely to know the code better.

Dec 26 2019, 6:54 PM
pfg added reviewers for D22924: netinet/cc: make use of arc4random(): lstewart, tuexen.

Add developers that are more likely to know better the code than me.

Dec 26 2019, 6:46 PM
pfg created D22928: Drop clause 3 of Berkeley license..
Dec 26 2019, 4:18 PM

Dec 25 2019

pfg added a comment to D6442: Make more use of arc4random() in the kernel..
In D6442#502200, @pfg wrote:

Hmm ...
When arc4random was introduced in OpenBSD the idea was to have one unique random algorithm to replace them all. This patch is old and reflects that idea. I am now thinking , that that is not the real objective for us.

Well, the idea is not purely unifying the generators, but to use the same CSPRNG in as much as possible places in kernel to make it harder to predicate the next output, by using these arc4random() calls as another form of randomness introduced to the entropy source (as such, to effectively use the feature the calls has to obtain small quantities of outputs from arc4random()).
That's said, I believe we still want to use arc4random() for, at least, the code paths that are not performance critical and do performance analysis and decide carefully if they should be used in the critical ones.

Dec 25 2019, 9:08 PM
pfg abandoned D6442: Make more use of arc4random() in the kernel..

Drop revision: none of this is security critical and replacing good old random for the sake of removing it is not an objective.

Dec 25 2019, 8:39 PM
pfg updated the diff for D6442: Make more use of arc4random() in the kernel..

Drop stuff that was moved to other differentials.

Dec 25 2019, 8:36 PM
pfg added a comment to D6442: Make more use of arc4random() in the kernel..

Hmm ...
When arc4random was introduced in OpenBSD the idea was to have one unique random algorithm to replace them all. This patch is old and reflects that idea. I am now thinking , that that is not the real objective for us.

Dec 25 2019, 8:16 PM
pfg added a reviewer for D22924: netinet/cc: make use of arc4random(): network.
Dec 25 2019, 7:10 PM
pfg added reviewers for D22925: netpfil/ipfw: use arc4random() instead of random(): cem, network.
Dec 25 2019, 7:09 PM
pfg created D22925: netpfil/ipfw: use arc4random() instead of random().
Dec 25 2019, 7:06 PM
pfg created D22924: netinet/cc: make use of arc4random().
Dec 25 2019, 6:59 PM
pfg added a comment to D6442: Make more use of arc4random() in the kernel..
In D6442#502158, @cem wrote:

I think it would be more straightforward to divide this into reviews by subject code area. Feel free to cc me in all of those if you do so. I’m happier to see more use of arc4random when it’s a good fit.

Dec 25 2019, 6:28 PM
pfg updated the diff for D6442: Make more use of arc4random() in the kernel..

Drop one more case where the return type matters.

Dec 25 2019, 6:07 PM
pfg updated the diff for D6442: Make more use of arc4random() in the kernel..

Drop some replacements wehre the different retrn value type is important.

Dec 25 2019, 5:28 PM
pfg added a reviewer for D6442: Make more use of arc4random() in the kernel.: cem.

Add cem@.

Dec 25 2019, 4:29 PM
pfg updated the diff for D6442: Make more use of arc4random() in the kernel..

Update: some code has already been replaced.

Dec 25 2019, 4:28 PM

Dec 24 2019

pfg closed D13369: Add hammer support for fstyp(8)..
Dec 24 2019, 7:00 PM
pfg committed rS356060: sbin/fstyp: recgonize Dragonfly's hammer and hammer2..
sbin/fstyp: recgonize Dragonfly's hammer and hammer2.
Dec 24 2019, 7:00 PM
pfg updated the diff for D13369: Add hammer support for fstyp(8)..

rebase the patches to match modern FreeBSD.

Dec 24 2019, 3:39 AM
pfg committed rP520767: devel/jetbrains-webstorm: Update to 2019.3.1.
devel/jetbrains-webstorm: Update to 2019.3.1
Dec 24 2019, 1:00 AM
pfg committed rP520766: devel/jetbrains-phpstorm: Update to 2019.3.1.
devel/jetbrains-phpstorm: Update to 2019.3.1
Dec 24 2019, 1:00 AM
pfg committed rP520763: java/jakarta-bcel move to apache- and update to version 6.4.1.
java/jakarta-bcel move to apache- and update to version 6.4.1
Dec 24 2019, 12:36 AM
pfg committed rD53708: Document doubling the size of ARG_MAX on LP64 platforms..
Document doubling the size of ARG_MAX on LP64 platforms.
Dec 24 2019, 12:22 AM

Dec 23 2019

pfg added a reviewer for D13369: Add hammer support for fstyp(8).: cem.

cem@ has been adding some interesting support to fstyp so perhaps he may want to review or even take over.

Dec 23 2019, 6:25 PM

Dec 21 2019

pfg committed rP520578: science/tfel: update to version 3.3.
science/tfel: update to version 3.3
Dec 21 2019, 7:53 PM
pfg committed rD53702: Double the size of ARG_MAX on LP64 platforms..
Double the size of ARG_MAX on LP64 platforms.
Dec 21 2019, 3:01 AM
pfg committed rS355968: MFC r355828:.
MFC r355828:
Dec 21 2019, 2:40 AM

Dec 16 2019

pfg committed rS355828: Double the size of ARG_MAX on LP64 platforms..
Double the size of ARG_MAX on LP64 platforms.
Dec 16 2019, 11:55 PM

Dec 15 2019

pfg committed rP520187: science/tfel: update to version 3.2.2.
science/tfel: update to version 3.2.2
Dec 15 2019, 5:21 PM
pfg committed rS355762: cdefs: use more accurate GCC version for the deprecated attribute..
cdefs: use more accurate GCC version for the deprecated attribute.
Dec 15 2019, 1:57 AM

Dec 14 2019

pfg committed rS355745: MFC 354924:.
MFC 354924:
Dec 14 2019, 3:15 AM

Dec 11 2019

pfg accepted D22187: Add sigsetop extensions commonly found in musl libc and glibc.
Dec 11 2019, 7:02 PM
pfg added a comment to D22187: Add sigsetop extensions commonly found in musl libc and glibc.

LGTM, I like sensible extensions.

Dec 11 2019, 2:32 PM

Dec 10 2019

pfg accepted D22750: sed: process \r, \n, and \t.
Dec 10 2019, 4:56 PM

Dec 9 2019

pfg added a comment to D17174: Put guards around timespec_get() decleration..

FWIW,
It looks like we should update
contrib/libc++/include/__config around line 348.

Dec 9 2019, 2:24 AM

Dec 3 2019

pfg committed rP518970: devel/jetbrains-webstorm: Update to 2019.3.
devel/jetbrains-webstorm: Update to 2019.3
Dec 3 2019, 10:36 PM
pfg committed rP518969: devel/jetbrains-phpstorm: update to version 2019.3..
devel/jetbrains-phpstorm: update to version 2019.3.
Dec 3 2019, 10:31 PM

Dec 1 2019

pfg committed rP518783: science/tfel: completely disable the PYTHON option..
science/tfel: completely disable the PYTHON option.
Dec 1 2019, 3:56 PM

Nov 28 2019

pfg committed rP518576: science/tfel: fix pkg-fallout.
science/tfel: fix pkg-fallout
Nov 28 2019, 12:33 PM

Nov 27 2019

pfg committed rP518485: science/tfel: Update to version 3.2.1.
science/tfel: Update to version 3.2.1
Nov 27 2019, 12:54 AM

Nov 20 2019

pfg committed rS354924: MFV 354917, 354918, 354919.
MFV 354917, 354918, 354919
Nov 20 2019, 11:56 PM