Page MenuHomeFreeBSD

pfg (Pedro Giffuni)
User

Projects

User Details

User Since
Jul 18 2014, 8:51 PM (248 w, 1 d)

Recent Activity

Fri, Apr 19

pfg committed rP499388: math/taucs: change metis4 dependency to metis..
math/taucs: change metis4 dependency to metis.
Fri, Apr 19, 8:18 PM
pfg committed rP499378: cad/calculix: Update to 2.15..
cad/calculix: Update to 2.15.
Fri, Apr 19, 5:16 PM

Thu, Apr 18

pfg committed rP499275: cad/calculix-ccx: Update to version 2.15..
cad/calculix-ccx: Update to version 2.15.
Thu, Apr 18, 3:33 PM

Wed, Apr 17

pfg committed rD52935: Note enhanced commit privileges..
Note enhanced commit privileges.
Wed, Apr 17, 2:49 PM
pfg committed rS346311: Add orphan mentee..
Add orphan mentee.
Wed, Apr 17, 2:21 PM
pfg committed rS346310: Add myself to ports committers..
Add myself to ports committers.
Wed, Apr 17, 2:12 PM

Sat, Apr 13

pfg committed rS346189: MFC r344755 (by fsu@).
MFC r344755 (by fsu@)
Sat, Apr 13, 8:49 PM

Wed, Apr 10

pfg accepted D19848: ext2fs: Dtrace support..

I still hope to hear from the DTrace experts, but I like this very much. Thanks!

Wed, Apr 10, 4:06 PM

Mon, Apr 8

pfg added inline comments to D19848: ext2fs: Dtrace support..
Mon, Apr 8, 7:27 PM
pfg added reviewers for D19848: ext2fs: Dtrace support.: gnn, markj, mckusick.

Very cool (but I am biased since I suggested the fusefs-dtrace changes as a starting point)!

Mon, Apr 8, 7:21 PM

Fri, Apr 5

pfg accepted D19824: Implement checking of `.' and `..' entries of subdirectory..
Fri, Apr 5, 1:03 AM

Mar 1 2019

pfg added a comment to D19325: Do not panic if inode bitmap is corrupted..

I recently added the new error EINTEGRITY which is intended for use when a cylinder group or other filesystem structure has an integrity error.

Mar 1 2019, 4:12 AM

Feb 27 2019

pfg accepted D19325: Do not panic if inode bitmap is corrupted..

Upon further thought: the situation is very different for ext2fs than to a filesystem in which the all the system depends as in UFS.

Feb 27 2019, 8:20 PM
pfg accepted D19327: Do not read the on-disk inode in case of vnode allocation..
In D19327#414960, @fsu wrote:
In D19327#413791, @pfg wrote:

Note why we specifically set ip->i_flags = 0 since r294652:

The ip->i_flags will be zero in all cases inside this function because we does not read new inode from disk at all for now and inode is allocated thru malloc with M_ZERO flag.

OK, you are rught, we were not allocating (with M_ZERO) this before.

Feb 27 2019, 4:51 PM
pfg added a reviewer for D19325: Do not panic if inode bitmap is corrupted.: mckusick.

Hi Kirk;
We have this as a panic in UFS, as well.

Feb 27 2019, 4:40 PM
pfg added a comment to D19325: Do not panic if inode bitmap is corrupted..

We should probably keep this panic for consistency with UFS, which also panics on this case.

Feb 27 2019, 2:52 PM
pfg accepted D19324: Validate block bitmaps..
Feb 27 2019, 2:46 PM
pfg accepted D19323: Add additional on-disk inode checks..
Feb 27 2019, 2:45 PM
pfg accepted D19322: Make superblock reading logic more strict..
Feb 27 2019, 2:43 PM
pfg accepted D19385: Fix double free in case of mount error..
Feb 27 2019, 2:34 PM

Feb 25 2019

pfg added a comment to D19327: Do not read the on-disk inode in case of vnode allocation..

Note why we specifically set ip->i_flags = 0 since r294652:

Feb 25 2019, 12:02 AM

Feb 24 2019

pfg accepted D19326: Fix integer overflow possibility..
Feb 24 2019, 11:53 PM

Feb 22 2019

pfg accepted D19235: Fix binutils compilation error with Clang 8.

LGTM.
FWIW, the GPLv3 version does an ugly calloc() dance with pointers which looks a lot more confusing.

Feb 22 2019, 7:17 PM
pfg added a comment to D19236: Fix clang error builtin-requires-header on pthread_create.

I am unsure if it is a style rule but we generally place such pragmas before and after all declarations so that they don't get in the way of easier reading.

Feb 22 2019, 3:16 AM

Feb 20 2019

pfg committed rS344363: MFC r344042:.
MFC r344042:
Feb 20 2019, 2:12 PM
pfg committed rS344362: MFC r344042:.
MFC r344042:
Feb 20 2019, 2:10 PM

Feb 19 2019

pfg added a comment to D13706: sysv_ipc.c: merge copyright assignment to the NetBSD Foundation.

pfg I think you miss understood, and upon looking I was not clear, it is not you that I am unhappy with about "playing with copyrights and licenses", it is NetBSD and possibly Charles Hannum who as Robert points out modified a license without ALL authors approval. I would be very upset if someone disturbed my disclaimer in this manner.

Feb 19 2019, 7:18 PM
pfg abandoned D13706: sysv_ipc.c: merge copyright assignment to the NetBSD Foundation.

Upon closer examination of this there are some issues, it alters a license post fact of copyrights asserted by some, and changes the clause in the license from Author to NetBSD, which effects the since of the copyright. I really wish the playing with Copyrights and Licenses would stop, this is a good example, of a well meant change, causing an ugly problem. For examle, the disclaimer is now in the name NetBSD, so what happened to the disclaim asserted by nCircle Network, and Robert Watson?

Feb 19 2019, 4:50 PM
pfg accepted D19240: Remove redundant code in acl_strip.

(trasz is the expert here)

Feb 19 2019, 3:34 PM

Feb 15 2019

pfg abandoned D19203: Replace two-operand instruction aliases that clang does not understand with the three-operand instructions..

If it's not needed then just lets not spend time on it.

Feb 15 2019, 8:41 PM
pfg added a comment to D19203: Replace two-operand instruction aliases that clang does not understand with the three-operand instructions..

Note that I have no idea of MIPS asm, just noticed the commit on OpenBSD MIPS64 .. feel free to commit if it works for you.

Feb 15 2019, 4:18 AM
pfg created D19203: Replace two-operand instruction aliases that clang does not understand with the three-operand instructions..
Feb 15 2019, 4:14 AM

Feb 12 2019

pfg committed rS344042: UMA: unsign some variables related to allocation in hash_alloc()..
UMA: unsign some variables related to allocation in hash_alloc().
Feb 12 2019, 4:33 AM
pfg closed D19148: UMA: unsign some variables related to allocation in hash_alloc()..
Feb 12 2019, 4:33 AM
pfg updated the diff for D19148: UMA: unsign some variables related to allocation in hash_alloc()..

Unsign uh_hashmask
(Don't expect any failure but will test anyways)

Feb 12 2019, 12:33 AM

Feb 11 2019

pfg added a comment to D19148: UMA: unsign some variables related to allocation in hash_alloc()..
In D19148#409628, @mav wrote:
In D19148#409623, @pfg wrote:

I thought of that but I saw a -1 when calculating it:

hash->uh_hashmask = hash->uh_hashsize - 1;

.A hashsize of zero makes little sense but it is still a valid value (?).

hashsize of zero makes no sense to me. I haven't checked how exactly it is initialized and whether it is used for some implementation reasons, but smallest possible size of hash is 1 with mask of 0. For size of 0 there is just no meaningful mask. Plus few places where uh_hashmask is used, do not care whether it is negative or overflown unsigned.

Feb 11 2019, 10:59 PM
pfg updated the diff for D19148: UMA: unsign some variables related to allocation in hash_alloc()..

Missing hval unsigning (pointed out by mav).

Feb 11 2019, 4:20 PM
pfg added a comment to D19148: UMA: unsign some variables related to allocation in hash_alloc()..
In D19148#409622, @mav wrote:

Generally I agree with it. I spotted it too when worked on my change. It just needs 8 times more RAM then what we have now to overflow, so I preferred my patch to be minimal. Just going that way, why not make uh_hashmask also unsigned?

Feb 11 2019, 4:15 PM
pfg added a reviewer for D19148: UMA: unsign some variables related to allocation in hash_alloc().: markj.
Feb 11 2019, 3:09 PM
pfg created D19148: UMA: unsign some variables related to allocation in hash_alloc()..
Feb 11 2019, 3:07 PM

Feb 10 2019

pfg committed rS343989: MFC r342910:.
MFC r342910:
Feb 10 2019, 11:47 PM
pfg committed rS343988: MFC r342910:.
MFC r342910:
Feb 10 2019, 11:45 PM

Jan 28 2019

pfg committed rS343519: MFC r342379, r342383:.
MFC r342379, r342383:
Jan 28 2019, 2:26 AM
pfg committed rS343517: MFC r343459: (parcial).
MFC r343459: (parcial)
Jan 28 2019, 2:13 AM
pfg committed rS343512: MFC r343459:.
MFC r343459:
Jan 28 2019, 1:37 AM

Jan 25 2019

pfg committed rS343459: ext2fs: Add some extra consistency checks for the superblock..
ext2fs: Add some extra consistency checks for the superblock.
Jan 25 2019, 10:22 PM

Jan 21 2019

pfg committed rS343258: MFC r343023:.
MFC r343023:
Jan 21 2019, 2:55 PM
pfg committed rS343257: MFC r343023:.
MFC r343023:
Jan 21 2019, 2:54 PM
pfg committed rS343256: MFC r343023:.
MFC r343023:
Jan 21 2019, 2:53 PM

Jan 14 2019

pfg committed rS343023: msun: reduce diff between src/e_j0.c and src/e_j0f.c.
msun: reduce diff between src/e_j0.c and src/e_j0f.c
Jan 14 2019, 3:49 PM
pfg committed rS343010: MFC r342632:.
MFC r342632:
Jan 14 2019, 3:19 AM

Jan 11 2019

pfg committed rP489987: New port devel/phpstorm: ligthning-smart PHP IDE..
New port devel/phpstorm: ligthning-smart PHP IDE.
Jan 11 2019, 6:27 PM
pfg closed D18477: [NEW PORT]devel/jetbrains-phpstorm: JetBrains PhpStorm IDE.
Jan 11 2019, 6:27 PM · Ports Committers
pfg added a comment to D18477: [NEW PORT]devel/jetbrains-phpstorm: JetBrains PhpStorm IDE.

FWIW, this is currently my favorite IDE on FreeBSD: netbeans has problems refreshing.
VSCode is not yet ported :(.

Jan 11 2019, 4:45 AM · Ports Committers

Jan 10 2019

pfg committed rS342910: grep(1) outputs NOT-matched lines with multi-byte characters.
grep(1) outputs NOT-matched lines with multi-byte characters
Jan 10 2019, 2:59 AM

Jan 7 2019

pfg committed rS342851: pow(3): Workaround possible signed shift Undefined Behavior..
pow(3): Workaround possible signed shift Undefined Behavior.
Jan 7 2019, 5:35 PM

Jan 1 2019

pfg added a comment to D18531: PR208117: regex(3): implement equivalence classes.

FWIW, I have a patch from the late ache@ to finish the removal of __collate_range_cmp() started in r302512.
It is practically impossible to remove a symbol as that would in theory break the ABI, so I understand we may be wary of adding new ones.

Jan 1 2019, 3:39 PM

Dec 31 2018

pfg committed rS342651: msun: Fix some old typos..
msun: Fix some old typos.
Dec 31 2018, 3:43 PM

Dec 30 2018

pfg closed D18445: Update ext2fs(5) man page.
Dec 30 2018, 7:45 PM
pfg committed rS342632: ext2fs.5: Update the manpage..
ext2fs.5: Update the manpage.
Dec 30 2018, 7:45 PM

Dec 27 2018

pfg updated the diff for D18477: [NEW PORT]devel/jetbrains-phpstorm: JetBrains PhpStorm IDE.

Fix issues pointed out by mat@

Dec 27 2018, 7:47 PM · Ports Committers
pfg added inline comments to D18477: [NEW PORT]devel/jetbrains-phpstorm: JetBrains PhpStorm IDE.
Dec 27 2018, 7:03 PM · Ports Committers
pfg retitled D18477: [NEW PORT]devel/jetbrains-phpstorm: JetBrains PhpStorm IDE from [NEW PORT] java/jetbrains-phpstorm: JetBrains PhpStorm IDE to [NEW PORT]devel/jetbrains-phpstorm: JetBrains PhpStorm IDE.
Dec 27 2018, 5:10 PM · Ports Committers
pfg updated the diff for D18477: [NEW PORT]devel/jetbrains-phpstorm: JetBrains PhpStorm IDE.
  • Update to 2018.3.2
  • Move to devel as we don't really depend on the intellij infrastructure.
  • Use native file watching support as in the latest intellij port.
Dec 27 2018, 5:10 PM · Ports Committers

Dec 23 2018

pfg updated the diff for D18445: Update ext2fs(5) man page.

Minore updates

Dec 23 2018, 9:12 PM
pfg committed rS342383: Fix mismatch from r342379..
Fix mismatch from r342379.
Dec 23 2018, 8:51 PM
pfg closed D18630: gai_strerror() - Update string error messages according to RFC 3493.
Dec 23 2018, 6:22 PM
pfg accepted D18630: gai_strerror() - Update string error messages according to RFC 3493.

Commtted as r342379

Dec 23 2018, 6:21 PM
pfg committed rS342379: gai_strerror() - Update string error messages according to RFC 3493..
gai_strerror() - Update string error messages according to RFC 3493.
Dec 23 2018, 6:16 PM
pfg added a comment to D18630: gai_strerror() - Update string error messages according to RFC 3493.

Thanks for the suggestions.

Dec 23 2018, 5:50 PM
pfg updated the diff for D18630: gai_strerror() - Update string error messages according to RFC 3493.
Dec 23 2018, 5:49 PM
pfg updated the diff for D18630: gai_strerror() - Update string error messages according to RFC 3493.

Keep the documentation consitent in the headers and manpage as well.
(Yes, I still have to update the manpage date before committing).

Dec 23 2018, 12:49 AM

Dec 21 2018

pfg created D18630: gai_strerror() - Update string error messages according to RFC 3493.
Dec 21 2018, 4:37 PM
pfg resigned from D17083: Alter the prototype of qsort_r(3) to match glibc..
Dec 21 2018, 4:20 PM

Dec 19 2018

pfg added a comment to D18611: PR234066: jemalloc assertion failure in less.

For the record: while it is good practice to request reviews before committing, IMHO they dont make much sense, and are not required at all, for reverts. After all they stand for things all the initial reviewers missed in the first place ;).

Dec 19 2018, 10:52 PM
pfg accepted D18611: PR234066: jemalloc assertion failure in less.
Dec 19 2018, 10:34 PM

Dec 16 2018

pfg added a comment to D18579: Remove amd(8) from base.
In D18579#396127, @cy wrote:

I haven't figured out how to diff deleted files in git yet. I'll upload it soon.

If people decide not to make a decision now this revision can be abandoned and I can save it for later. git stash is my friend.

Dec 16 2018, 7:20 PM
pfg added a reviewer for D18579: Remove amd(8) from base: bapt.

Age should not be a criteria for removal. BSD is old, very old, shall we remove it simply cause it is old? IMHO you all are getting way ahead of the process, having reviews to remove code before the cost/benefit and open discussions happens is backwards.

Dec 16 2018, 6:20 PM

Dec 12 2018

pfg accepted D18531: PR208117: regex(3): implement equivalence classes.
Dec 12 2018, 4:56 PM

Dec 8 2018

pfg updated the diff for D18445: Update ext2fs(5) man page.

Fix mamdoc issues.

Dec 8 2018, 6:27 PM
pfg added inline comments to D18477: [NEW PORT]devel/jetbrains-phpstorm: JetBrains PhpStorm IDE.
Dec 8 2018, 3:45 PM · Ports Committers
pfg updated the diff for D18477: [NEW PORT]devel/jetbrains-phpstorm: JetBrains PhpStorm IDE.

Use WRKSRC instead of WRKDIST.
Still passes portlint and check-plist

Dec 8 2018, 3:44 PM · Ports Committers
pfg accepted D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.
Dec 8 2018, 3:27 PM

Dec 7 2018

pfg created D18477: [NEW PORT]devel/jetbrains-phpstorm: JetBrains PhpStorm IDE.
Dec 7 2018, 7:22 PM · Ports Committers
pfg committed rS341676: MFC r341505:.
MFC r341505:
Dec 7 2018, 3:45 AM

Dec 6 2018

pfg updated the diff for D18445: Update ext2fs(5) man page.

Really add the symlink

Dec 6 2018, 2:02 AM
pfg updated the test plan for D18445: Update ext2fs(5) man page.
Dec 6 2018, 2:01 AM
pfg added a comment to D18445: Update ext2fs(5) man page.

Please create links for ext3fs.5 and ext4fs.5; in share/man/man5/Makefile, add these to the list:

MLINKS+= ext2fs.5 ext3fs.5
MLINKS+= ext2fs.5 ext4fs.5

I agree the ext4fs link is useful. the ext3fs is probably not

Dec 6 2018, 1:59 AM
pfg updated the diff for D18445: Update ext2fs(5) man page.

Add a soflink for ext4fs. I am not currently adding a link to ext3 since
linux doesn't seem to carry it anymore and we don't support the main
feature it brought: journalling.

Dec 6 2018, 1:55 AM
pfg created D18445: Update ext2fs(5) man page.
Dec 6 2018, 1:10 AM

Dec 4 2018

pfg committed rS341505: ext2fs.4: basic updates..
ext2fs.4: basic updates.
Dec 4 2018, 10:51 PM

Nov 23 2018

pfg accepted D17903: [libedit] enhance multibyte support.

LGTM

Nov 23 2018, 6:30 PM
pfg accepted D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.

Nice!

Nov 23 2018, 2:29 PM
pfg accepted D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.

Looks good to me, but it would be nice to have input from kevans as well.

Nov 23 2018, 2:17 AM
pfg accepted D18297: PR153502: [libc] regex(3) bug with UTF-8 locale.

Aha .. so nice to find a bug , thanks !

Nov 23 2018, 2:11 AM

Nov 22 2018

pfg added a comment to D18297: PR153502: [libc] regex(3) bug with UTF-8 locale.

I am not an expert on the area but I see where the comment comes from:

Nov 22 2018, 3:10 PM

Nov 16 2018

pfg accepted D17903: [libedit] enhance multibyte support.
Nov 16 2018, 2:33 AM

Nov 9 2018

pfg accepted D17917: d_off support for multiple filesystems.
Nov 9 2018, 10:02 PM
pfg added a comment to D17917: d_off support for multiple filesystems.
In D17917#382778, @pfg wrote:

Maybe a sweep with opengrok is a good idea to see where we should be using this.

I don't know about opengrok, but this is a new feature only affecting a small part of the ABI so it seems pretty well contained.

Nov 9 2018, 3:29 PM
pfg added a comment to D17903: [libedit] enhance multibyte support.
In D17903#382777, @bapt wrote:
In D17903#382776, @pfg wrote:

For the record ...

We really do need to update libedit (from NetBSD).
These changes are welcome but I fear the approach of trying to preserve our changes is not sustainable anymore

Someone brave, and with time, has to take the step of just bringing the NetBSD version ...

I did it once, it is not that hard, and our version right now is not that far from there version is it? for the record, I have also contacted christos@ by email so he can wait on this review.

Nov 9 2018, 3:14 PM