Page MenuHomeFreeBSD

pfg (Pedro Giffuni)
User

Projects

User Details

User Since
Jul 18 2014, 8:51 PM (316 w, 1 h)

Recent Activity

Thu, Jul 30

pfg committed rP543812: lang/bsh: Use JDK 8 to build..
lang/bsh: Use JDK 8 to build.
Thu, Jul 30, 5:28 PM
pfg committed rP543805: cad/NASTRAN-95: mark broken.
cad/NASTRAN-95: mark broken
Thu, Jul 30, 5:05 PM

Mon, Jul 13

pfg added a comment to D25640: sed "y" command bracket balancing check.
In D25640#567601, @pfg wrote:

LGTM however, I would recommend an exp-run. Many times before have sed changes caused trouble in the ports tree to be later reverted.

Yep, I was looking at the svn log of usr.bin/sed/ and noticed quite a few backouts. I agree that exp-run should be done, but even if some ports break those would need to be fixed instead of rejecting this change as it's obvious bug (and yes, gsed agrees).

Mon, Jul 13, 11:09 PM
pfg added a comment to D25640: sed "y" command bracket balancing check.

LGTM however, I would recommend an exp-run. Many times before have sed changes caused trouble in the ports tree to be later reverted.

Mon, Jul 13, 5:15 PM

Jul 2 2020

pfg accepted D25312: Relax the rule against declaring variables in nested scopes..
Jul 2 2020, 6:45 PM

Jun 18 2020

pfg committed rS362345: services: Add SSDP to service database.
services: Add SSDP to service database
Jun 18 2020, 10:10 PM
pfg accepted D25312: Relax the rule against declaring variables in nested scopes..
Jun 18 2020, 9:18 AM

Jun 7 2020

pfg committed rS361898: services: Add SSDP to service database.
services: Add SSDP to service database
Jun 7 2020, 7:56 PM
pfg accepted D24079: Read commands from stdin when -f - is passed to sed(1).
Jun 7 2020, 2:52 PM
pfg reopened D23621: Update /etc/services: attempt to bring it to the new century.

I plan to re-commit this as soon as FreeBSD 12.2 is released, to avoid a limitation of the build system.

Jun 7 2020, 5:40 AM

May 11 2020

pfg committed rP534959: devel/jetbrains-phpstorm: major update to version 2020.1.1.
devel/jetbrains-phpstorm: major update to version 2020.1.1
May 11 2020, 9:12 PM

May 8 2020

pfg committed rP534319: math/R-cran-BsMD: update to 2020.4.30..
math/R-cran-BsMD: update to 2020.4.30.
May 8 2020, 3:30 AM

May 4 2020

pfg added a comment to D23259: ext2fs: initial support for byteswapping..
In D23259#543516, @fsu wrote:
In D23259#543509, @pfg wrote:

Sorry I meant to approve this:
https://reviews.freebsd.org/D24685

(fsu should have comandeered this one instead of opening a new one)

I did not managed with new diff uploading, diff did not want to attach to this revision.
Seems like, I can attach diffs only to revisions, which were opened by me.
Please correct me if I am wrong or lose something in the Phabricator UI.

May 4 2020, 4:31 PM
pfg abandoned D23259: ext2fs: initial support for byteswapping..

Sorry I meant to approve this:
https://reviews.freebsd.org/D24685

May 4 2020, 4:12 PM
pfg accepted D24685: ext2fs: initial support for byteswapping (was https://reviews.freebsd.org/D23259).
May 4 2020, 4:12 PM · PowerPC
pfg accepted D23259: ext2fs: initial support for byteswapping..
May 4 2020, 4:06 PM

Apr 21 2020

pfg committed rP532249: math/reduce-psl update to version 20200301.
math/reduce-psl update to version 20200301
Apr 21 2020, 3:27 AM

Apr 18 2020

pfg committed rP532039: devel/jetbrains-phpstorm: major update to version 2020.1.
devel/jetbrains-phpstorm: major update to version 2020.1
Apr 18 2020, 6:02 PM

Apr 14 2020

pfg added a comment to D13209: linuxulator: Add user xattrs support for i386 and amd64 platforms..

Ping? What's the status of this?

Apr 14 2020, 7:26 PM

Mar 25 2020

pfg accepted D23926: Swap words order instead of bits order on BIG ENDIAN.
Mar 25 2020, 3:20 PM

Mar 24 2020

pfg abandoned D21638: Add kqueue support for ZFS..

Can we close this review now?

Mar 24 2020, 3:19 PM

Mar 22 2020

pfg committed rS359202: MFC r353909, r355192, r355218, r355218, r358506, r359005:.
MFC r353909, r355192, r355218, r355218, r358506, r359005:
Mar 22 2020, 1:40 AM
pfg committed rS359199: MFC r353909, r355192, r355218, r355218, r358506, r359005:.
MFC r353909, r355192, r355218, r355218, r358506, r359005:
Mar 22 2020, 1:23 AM

Mar 19 2020

pfg committed rP528728: devel/jetbrains-phpstorm: Update to version 2019.3.4.
devel/jetbrains-phpstorm: Update to version 2019.3.4
Mar 19 2020, 3:25 PM

Mar 17 2020

pfg added a comment to D24079: Read commands from stdin when -f - is passed to sed(1).

LGTM, but I have no time to test.
Note that this type of changes should be checked with an exxp-run

Mar 17 2020, 4:15 PM

Mar 15 2020

pfg committed rS359005: calendar(1): Updates and corrections for some calendar files..
calendar(1): Updates and corrections for some calendar files.
Mar 15 2020, 12:49 AM
pfg closed D23581: calendar(1): Updates and corrections for calendar files.
Mar 15 2020, 12:49 AM

Mar 14 2020

pfg updated the diff for D23621: Update /etc/services: attempt to bring it to the new century.

Update User Ports, attempting to bring balance with what can actually appear in a UNIX system.

Mar 14 2020, 3:28 PM

Mar 12 2020

pfg committed rS358904: style(9): Fix space after #define..
style(9): Fix space after #define.
Mar 12 2020, 3:57 AM
pfg committed rS358903: MFC r358154 (by delphij).
MFC r358154 (by delphij)
Mar 12 2020, 3:04 AM

Mar 11 2020

pfg committed rS358870: MFC r358154 (by delphij).
MFC r358154 (by delphij)
Mar 11 2020, 5:45 AM
pfg committed rS358869: Remove GNU patch..
Remove GNU patch.
Mar 11 2020, 4:55 AM
pfg committed rS358868: Delete OpenBSD's variant of RCS..
Delete OpenBSD's variant of RCS.
Mar 11 2020, 4:45 AM

Mar 10 2020

pfg accepted D23581: calendar(1): Updates and corrections for calendar files.

I thought cem would want to do the commit.
I've been a bit sick, but I'll commit it this week if no one else does.

Mar 10 2020, 3:08 AM

Mar 4 2020

pfg accepted D23581: calendar(1): Updates and corrections for calendar files.
Mar 4 2020, 9:20 PM

Mar 3 2020

pfg added inline comments to D23926: Swap words order instead of bits order on BIG ENDIAN.
Mar 3 2020, 3:57 PM
pfg accepted D23926: Swap words order instead of bits order on BIG ENDIAN.

LGTM

Mar 3 2020, 2:48 PM
pfg requested changes to D23926: Swap words order instead of bits order on BIG ENDIAN.

The code is rather tricky, it would be convenient to checksum the object code on Little Endian to make sure nothing changes.

Mar 3 2020, 3:25 AM

Mar 2 2020

pfg accepted D23926: Swap words order instead of bits order on BIG ENDIAN.

Approved BTW, the code obviously doesn't change anything for LE.

Mar 2 2020, 9:30 PM
pfg added a reviewer for D23926: Swap words order instead of bits order on BIG ENDIAN: numerics.

Hmm... if the tests pass I guess it is good, but does the comment need updating as well?
The else case in the old code was going backwards but this one doesn't.

Mar 2 2020, 9:20 PM

Feb 29 2020

pfg added a comment to D23817: Fix build of x11-drivers/xf86-video-ati-legacy.

It did compile but no joy sadly :(.
I left the complete log here:
https://people.freebsd.org/~pfg/docs/Xorg.0.log

Feb 29 2020, 3:51 AM

Feb 28 2020

pfg committed rS358448: /etc/services: attempt to bring the database to this century 1/2..
/etc/services: attempt to bring the database to this century 1/2.
Feb 28 2020, 8:43 PM

Feb 26 2020

pfg committed rP527152: devel/jetbrains-phpstorm: Update to version 2019.3.3.
devel/jetbrains-phpstorm: Update to version 2019.3.3
Feb 26 2020, 5:55 AM
pfg committed rP527151: textproc/apache-poi: Update to 4.1.2..
textproc/apache-poi: Update to 4.1.2.
Feb 26 2020, 5:05 AM
pfg committed rP527150: devel/apache-rat: Update to version 0.13.
devel/apache-rat: Update to version 0.13
Feb 26 2020, 4:58 AM

Feb 23 2020

pfg committed rS358259: MFC r357414, r357415, r357417, r357423, r357424, r357587, r357655:.
MFC r357414, r357415, r357417, r357423, r357424, r357587, r357655:
Feb 23 2020, 3:18 PM

Feb 22 2020

pfg added a reviewer for D23793: kernel: provide panicky version of __unreachable: theraven.

Ugh.. I think this was discussed when __unreachable() was introduced (D2536 perhaps), and back then it was not considered a good idea.

Feb 22 2020, 7:10 PM

Feb 21 2020

pfg committed rS358209: MFC r357414, r357415, r357417, r357423, r357424, r357587, r357655:.
MFC r357414, r357415, r357417, r357423, r357424, r357587, r357655:
Feb 21 2020, 4:48 AM

Feb 20 2020

pfg committed rS358170: Revert r358153: it is causing unexpected issues with the build system..
Revert r358153: it is causing unexpected issues with the build system.
Feb 20 2020, 3:52 PM
pfg committed rS358153: /etc/services: attempt bring the database to this century..
/etc/services: attempt bring the database to this century.
Feb 20 2020, 3:54 AM
pfg closed D23621: Update /etc/services: attempt to bring it to the new century.
Feb 20 2020, 3:54 AM

Feb 16 2020

pfg added a comment to D17115: Generate /etc/services from the IANA registry (plus local mods).

IANA has indeed removed some services: I think people can de-register services they don't use/develop anymore. We should remove at least Kerberos IV and netatalk, both are not in the IANA. Also IANA lists first tcp, udp and lastly sctp so perhaps its better to jeep things consistent.

Feb 16 2020, 11:10 PM
pfg added a reviewer for D23621: Update /etc/services: attempt to bring it to the new century: vangyzen.
Feb 16 2020, 11:00 PM

Feb 13 2020

pfg updated the diff for D23621: Update /etc/services: attempt to bring it to the new century.

Sync with latest updates.

Feb 13 2020, 3:54 PM
pfg committed rS357860: Revert r357343:.
Revert r357343:
Feb 13 2020, 3:42 PM
pfg updated the diff for D23621: Update /etc/services: attempt to bring it to the new century.

Update Take2:
It is important to consider the differences between System Ports and User
ports. This changes keeps the system ports closely in sync with IANA.

Feb 13 2020, 3:33 PM

Feb 11 2020

pfg added a comment to D23621: Update /etc/services: attempt to bring it to the new century.
In D23621#518545, @cy wrote:

The fact that Kerberos IV is EOL doesn'[t mitigate the fact that the entries are still registered with IANA and that some KRB4 app may expect the entries to exist. Suggest we use https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml as a reference.

Feb 11 2020, 9:00 PM
pfg added a comment to D23621: Update /etc/services: attempt to bring it to the new century.
In D23621#518528, @mjg wrote:

If you want an example of what happens when a random parameter gets whacked out of proportion compared to Linux, here it is:

https://www.postgresql.org/message-id/CAEepm%3D3VF%3DPUp2f8gU8fgZB22yPE_KBS0%2Be1AHAtQ%3D09schTHg%40mail.gmail.com

Parameter set to 65536 because "why not" while it is 4096 on Linux resulted in a 256KB buffer in postgres when it should have been a fraction of that size. And so on. If there is no reason to deviate, don't.

Feb 11 2020, 8:53 PM
pfg added a comment to D23621: Update /etc/services: attempt to bring it to the new century.

Hello;

In D23621#518513, @mjg wrote:

Removing very stale entries or adding something may be fine, but the list as suggested is a non-starter. One has to expect there is plenty of custom userspace code parsing it which will choke on the new size.

Feb 11 2020, 7:33 PM
pfg created D23621: Update /etc/services: attempt to bring it to the new century.
Feb 11 2020, 4:46 PM

Feb 10 2020

pfg accepted D23605: Add a EXT2FS-specific implementation for lseek(SEEK_DATA)..

Good, indeed r252956, which was the predecesor of this, was built on an UFS patch.
Well done, thanks!

Feb 10 2020, 6:37 PM

Feb 7 2020

pfg committed rS357655: typo: stray spaces..
typo: stray spaces.
Feb 7 2020, 3:16 PM
pfg committed rS357654: typo: s/impelmentation/implementation/..
typo: s/impelmentation/implementation/.
Feb 7 2020, 3:14 PM

Feb 6 2020

pfg committed rS357631: fstyp: sync HAMMER1/2 detection support with DragonFly BSD..
fstyp: sync HAMMER1/2 detection support with DragonFly BSD.
Feb 6 2020, 6:04 PM

Feb 5 2020

pfg committed rS357587: ethernet: Add a couple more Ethertypes..
ethernet: Add a couple more Ethertypes.
Feb 5 2020, 7:11 PM

Feb 3 2020

pfg committed rS357424: typo: Registration..
typo: Registration.
Feb 3 2020, 2:02 AM
pfg committed rS357423: ethernet: Minor cleanup..
ethernet: Minor cleanup.
Feb 3 2020, 1:08 AM

Feb 2 2020

pfg committed rS357417: style(9): Fix spaces after #define..
style(9): Fix spaces after #define.
Feb 2 2020, 7:02 PM
pfg committed rS357415: ethernet: add some more Ethertypes..
ethernet: add some more Ethertypes.
Feb 2 2020, 6:33 PM
pfg committed rS357414: ethernet: add some more Ethertypes..
ethernet: add some more Ethertypes.
Feb 2 2020, 6:27 PM

Jan 31 2020

pfg committed rS357343: services: Add PROFInet and EtherCAT..
services: Add PROFInet and EtherCAT.
Jan 31 2020, 6:55 PM

Jan 30 2020

pfg committed rP524656: java/jakarta-regexp: deprecate..
java/jakarta-regexp: deprecate.
Jan 30 2020, 7:01 PM

Jan 29 2020

pfg committed rP524611: java/jakarta-commons-discovery: move to java/apache-commons-discovery.
java/jakarta-commons-discovery: move to java/apache-commons-discovery
Jan 29 2020, 11:00 PM

Jan 25 2020

pfg committed rP524044: textproc/apache-poi: update to version 4.1.1.
textproc/apache-poi: update to version 4.1.1
Jan 25 2020, 3:50 PM

Jan 24 2020

pfg committed rP523979: math/apache-commons-math: sort math/Makefile.
math/apache-commons-math: sort math/Makefile
Jan 24 2020, 7:06 PM
pfg committed rP523978: math/jakarta-commons-math3 update and rename to apache-commons-math.
math/jakarta-commons-math3 update and rename to apache-commons-math
Jan 24 2020, 7:02 PM
pfg committed rP523970: math/superlu_mt: Resurrect..
math/superlu_mt: Resurrect.
Jan 24 2020, 3:27 PM

Jan 23 2020

pfg committed rP523937: devel/webstorm: Update to version 2019.3.2.
devel/webstorm: Update to version 2019.3.2
Jan 23 2020, 4:50 PM
pfg committed rP523936: devel/phpstorm: Update to version 2019.3.2.
devel/phpstorm: Update to version 2019.3.2
Jan 23 2020, 4:48 PM

Jan 22 2020

pfg committed rP523847: cad/calculix : update to version 2.16.1.
cad/calculix : update to version 2.16.1
Jan 22 2020, 9:19 PM

Jan 21 2020

pfg committed rP523750: math/metis4: Deprecate.
math/metis4: Deprecate
Jan 21 2020, 10:43 PM
pfg committed rP523737: java/apache-bcel: update description..
java/apache-bcel: update description.
Jan 21 2020, 7:57 PM

Jan 19 2020

pfg updated the diff for D23259: ext2fs: initial support for byteswapping..

Small fix .. and still very far from over.

Jan 19 2020, 9:16 PM
pfg updated the diff for D23259: ext2fs: initial support for byteswapping..

Update.
I started modifying htree and lookup as well, but it's coming quickly
off-hand.

Jan 19 2020, 8:02 PM
pfg added a comment to D23259: ext2fs: initial support for byteswapping..
In D23259#510030, @fsu wrote:

I am not sure that dinode and superblock conversion will be enough, as I checked on linux side, the group descriptors should be converted too, possible same for bitmaps.
From https://ext4.wiki.kernel.org/index.php/Ext4_Disk_Layout
"All fields in ext4 are written to disk in little-endian order"

Argh .. a look into the NetBSD code indicades the directory entries (atr least e2d_reclen and e2d_namlen) need special treatment as well. Not sure yet about names wichh are character strings.

Jan 19 2020, 4:03 PM
pfg added a comment to D23259: ext2fs: initial support for byteswapping..
In D23259#510030, @fsu wrote:

I am not sure that dinode and superblock conversion will be enough, as I checked on linux side, the group descriptors should be converted too, possible same for bitmaps.
From https://ext4.wiki.kernel.org/index.php/Ext4_Disk_Layout
"All fields in ext4 are written to disk in little-endian order"

Yes, everything is in LE. The question is where does the transfer happen? The eraliest we do that, the better. Otherwise we should probably move the group descriptors to the dinode header, to have everything that must be translated in the same place.

Jan 19 2020, 2:13 PM
pfg created D23259: ext2fs: initial support for byteswapping..
Jan 19 2020, 4:03 AM

Jan 16 2020

pfg committed rP523262: devel/R-cran-vcd: update to version 1.4-5.
devel/R-cran-vcd: update to version 1.4-5
Jan 16 2020, 9:58 PM

Jan 13 2020

pfg accepted D23159: fstyp: fix Coverity issues in hammer support.

LGTM. I forwarded the revision link to Tomohiro Kusumi from DragonFly as well.

Jan 13 2020, 9:52 PM

Jan 11 2020

pfg committed rS356624: Update ELFOSABI_* constants with OpenVOS..
Update ELFOSABI_* constants with OpenVOS.
Jan 11 2020, 1:45 AM

Jan 4 2020

pfg abandoned D15687: libssp is part of GCC, not an independent library..

Overcome by D22943 and SVN r356356.

Jan 4 2020, 10:09 PM
pfg committed rP522060: cad/calculix-ccx: Enable multithreading with spooles..
cad/calculix-ccx: Enable multithreading with spooles.
Jan 4 2020, 8:36 PM
pfg committed rP522059: cad/calculix-ccx: Enable multithreading with spooles..
cad/calculix-ccx: Enable multithreading with spooles.
Jan 4 2020, 8:34 PM
pfg accepted D22943: Provide libssp based on libc.

Cool.
FWIW, it may make sense to MFC this code: it is under strong copyleft and getting linked with everything.

Jan 4 2020, 3:04 PM

Dec 30 2019

pfg abandoned D22925: netpfil/ipfw: use arc4random() instead of random().

I am abandoning this line of changes: it doesnt bring any advantage.

Dec 30 2019, 2:55 PM
pfg abandoned D22924: netinet/cc: make use of arc4random().

Abandon: it was not exactly right.

Dec 30 2019, 2:48 PM
pfg committed rP521492: cad/calculix : update to version 2.16.
cad/calculix : update to version 2.16
Dec 30 2019, 2:36 PM

Dec 29 2019

pfg added a reviewer for D22943: Provide libssp based on libc: oliver.pntr-gmail.com.

Let me add Oliver as he was my student for GSoC 2015.

Dec 29 2019, 4:59 AM
pfg accepted D22943: Provide libssp based on libc.

I am fine with this approach: while we do have an implementation of these functions (GSoC 2015), I don't think FORTIFY_SOURCE solves anything that we don't already do with the strong stack protector. Stubbing the functions out is a quick and practical solution.
We should still consider removing the stubs in a near future: I haven't looked at how linux does it but I think this stuff is not carried by glibc but in GCC libs instead.

Dec 29 2019, 4:02 AM

Dec 28 2019

pfg committed rS356142: SPDX: update some tags with two licenses..
SPDX: update some tags with two licenses.
Dec 28 2019, 2:59 AM