- User Since
- Jul 18 2014, 8:51 PM (256 w, 2 d)
Sun, Jun 9
Adding fsu@ in case he wants to mention something else :).
Yes, we do fully support ext4 read and write in FreeBSD 12+. We also support Extended Attributes, ACLs, and most features with the exception of journalling and encryption. As mentioned in BSDNow, 12.1 will have a DTrace provider.
Sat, Jun 8
Thanks for working on this. For the record,
Wed, May 29
Sat, May 25
The changes seem correct.
I don't think a simple phabricator acceptance from a committer is suficient approval for a non src committer though, so I hereby explicitly approve it.
May 12 2019
May 8 2019
May 1 2019
Apr 27 2019
This has rusted since the last revision: fts had some changes (mostly just updated prototypes) and glob has been rewritten.
It needs some fresh eyes into it (cc'ing brooks in case he wants to take over).
Most of these don't make sense as they cant overflow, and those that do were committed.
This was committed as r337456.
Is this still a valid review? I recall something related was committed.
Apr 24 2019
Apr 19 2019
Apr 18 2019
Apr 17 2019
Apr 13 2019
Apr 10 2019
I still hope to hear from the DTrace experts, but I like this very much. Thanks!
Apr 8 2019
Very cool (but I am biased since I suggested the fusefs-dtrace changes as a starting point)!
Apr 5 2019
Mar 1 2019
Feb 27 2019
Upon further thought: the situation is very different for ext2fs than to a filesystem in which the all the system depends as in UFS.
OK, you are rught, we were not allocating (with M_ZERO) this before.
We have this as a panic in UFS, as well.
We should probably keep this panic for consistency with UFS, which also panics on this case.
Feb 25 2019
Note why we specifically set ip->i_flags = 0 since r294652:
Feb 24 2019
Feb 22 2019
FWIW, the GPLv3 version does an ugly calloc() dance with pointers which looks a lot more confusing.
I am unsure if it is a style rule but we generally place such pragmas before and after all declarations so that they don't get in the way of easier reading.
Feb 20 2019
Feb 19 2019
(trasz is the expert here)
Feb 15 2019
If it's not needed then just lets not spend time on it.
Note that I have no idea of MIPS asm, just noticed the commit on OpenBSD MIPS64 .. feel free to commit if it works for you.
Feb 12 2019
(Don't expect any failure but will test anyways)
Feb 11 2019
Missing hval unsigning (pointed out by mav).
Feb 10 2019
Jan 28 2019
Jan 25 2019
Jan 21 2019
Jan 14 2019
Jan 11 2019
FWIW, this is currently my favorite IDE on FreeBSD: netbeans has problems refreshing.
VSCode is not yet ported :(.
Jan 10 2019
Jan 7 2019
Jan 1 2019
FWIW, I have a patch from the late ache@ to finish the removal of __collate_range_cmp() started in r302512.
It is practically impossible to remove a symbol as that would in theory break the ABI, so I understand we may be wary of adding new ones.
Dec 31 2018
Dec 30 2018
Dec 27 2018
Fix issues pointed out by mat@
- Update to 2018.3.2
- Move to devel as we don't really depend on the intellij infrastructure.
- Use native file watching support as in the latest intellij port.
Dec 23 2018
Commtted as r342379
Thanks for the suggestions.
Keep the documentation consitent in the headers and manpage as well.
(Yes, I still have to update the manpage date before committing).
Dec 21 2018
Dec 19 2018
For the record: while it is good practice to request reviews before committing, IMHO they dont make much sense, and are not required at all, for reverts. After all they stand for things all the initial reviewers missed in the first place ;).
Dec 16 2018
Dec 12 2018
Dec 8 2018
Use WRKSRC instead of WRKDIST.
Still passes portlint and check-plist