Page MenuHomeFreeBSD

pfg (Pedro Giffuni)
User

Projects

User Details

User Since
Jul 18 2014, 8:51 PM (281 w, 1 d)

Recent Activity

Tue, Dec 3

pfg committed rP518970: devel/jetbrains-webstorm: Update to 2019.3.
devel/jetbrains-webstorm: Update to 2019.3
Tue, Dec 3, 10:36 PM
pfg committed rP518969: devel/jetbrains-phpstorm: update to version 2019.3..
devel/jetbrains-phpstorm: update to version 2019.3.
Tue, Dec 3, 10:31 PM

Sun, Dec 1

pfg committed rP518783: science/tfel: completely disable the PYTHON option..
science/tfel: completely disable the PYTHON option.
Sun, Dec 1, 3:56 PM

Thu, Nov 28

pfg committed rP518576: science/tfel: fix pkg-fallout.
science/tfel: fix pkg-fallout
Thu, Nov 28, 12:33 PM

Wed, Nov 27

pfg committed rP518485: science/tfel: Update to version 3.2.1.
science/tfel: Update to version 3.2.1
Wed, Nov 27, 12:54 AM

Wed, Nov 20

pfg committed rS354924: MFV 354917, 354918, 354919.
MFV 354917, 354918, 354919
Wed, Nov 20, 11:56 PM
pfg committed rS354920: Tag openresolv 3.9.2..
Tag openresolv 3.9.2.
Wed, Nov 20, 10:26 PM
pfg committed rS354919: Import openresolv 3.9.2.
Import openresolv 3.9.2
Wed, Nov 20, 10:24 PM
pfg committed rS354918: Undo r354917 to correct the log: it was actually version 3.9.2.
Undo r354917 to correct the log: it was actually version 3.9.2
Wed, Nov 20, 10:20 PM
pfg committed rS354917: Import openresolv 3.9.0.
Import openresolv 3.9.0
Wed, Nov 20, 10:13 PM
pfg committed rP518057: devel/jetbrains-phpstorm: update to version 2019.2.5..
devel/jetbrains-phpstorm: update to version 2019.2.5.
Wed, Nov 20, 10:00 PM

Sun, Nov 10

pfg committed rP517235: devel/jetbrains-webstorm: Update to 2019.2.4.
devel/jetbrains-webstorm: Update to 2019.2.4
Sun, Nov 10, 10:03 PM
pfg committed rP517232: devel/jetbrains-phpstorm: Update to 2019.2.4.
devel/jetbrains-phpstorm: Update to 2019.2.4
Sun, Nov 10, 10:00 PM

Nov 1 2019

pfg committed rP516263: devel/dmake: update to version 4.12.3.
devel/dmake: update to version 4.12.3
Nov 1 2019, 7:05 PM

Oct 17 2019

pfg created D21902: Replace most obsolete references of jakarta to apache.
Oct 17 2019, 5:05 PM
pfg closed D21902: Replace most obsolete references of jakarta to apache.
Oct 17 2019, 5:03 PM

Oct 7 2019

pfg committed rP513971: textproc/apache-commons-digester: Update URL..
textproc/apache-commons-digester: Update URL.
Oct 7 2019, 4:49 PM
pfg committed rP513970: Old jakarta ports: add license..
Old jakarta ports: add license.
Oct 7 2019, 4:46 PM
pfg committed rP513938: editors/openoffice-4: bump revision..
editors/openoffice-4: bump revision.
Oct 7 2019, 11:10 AM
pfg committed rP513937: Fix dependencies after r513899.
Fix dependencies after r513899
Oct 7 2019, 11:00 AM

Oct 6 2019

pfg committed rP513899: rename most cases of jakarta- to apache-.
rename most cases of jakarta- to apache-
Oct 6 2019, 7:08 PM

Sep 29 2019

pfg committed rP513268: devel/jetbrains-phpstorm: Update to version 2019.2.3.
devel/jetbrains-phpstorm: Update to version 2019.2.3
Sep 29 2019, 8:09 PM
pfg committed rP513188: devel/jetbrains-webstorm: Update to 2019.2.3.
devel/jetbrains-webstorm: Update to 2019.2.3
Sep 29 2019, 1:10 AM

Sep 25 2019

pfg committed rP512819: devel/jetbrains-phpstorm: Update to version 2019.2.2.
devel/jetbrains-phpstorm: Update to version 2019.2.2
Sep 25 2019, 8:40 PM

Sep 17 2019

pfg added reviewers for D21638: Add kqueue support for ZFS.: jmg, asomers.

I am starting to concur that this call may be obsoleted.
Let me add the kqueue maintainer and the fuse maintainer (Alan added kqueue support to fuse) as they may shed some more light on this

Sep 17 2019, 3:30 AM
pfg closed D21139: Add deprecation notice to snd_maestro(4).
Sep 17 2019, 3:25 AM
pfg accepted D21139: Add deprecation notice to snd_maestro(4).

Committed as r350970.

Sep 17 2019, 3:25 AM
pfg closed D21138: Add deprecation notice to snd_ds1(4).

Committed as r350969.

Sep 17 2019, 3:24 AM

Sep 13 2019

pfg added inline comments to D21638: Add kqueue support for ZFS..
Sep 13 2019, 7:12 PM
pfg updated the diff for D21638: Add kqueue support for ZFS..

Fix typo

Sep 13 2019, 7:01 PM
pfg added inline comments to D21638: Add kqueue support for ZFS..
Sep 13 2019, 6:56 PM
pfg added a reviewer for D21638: Add kqueue support for ZFS.: ZFS.
Sep 13 2019, 5:24 PM
pfg created D21638: Add kqueue support for ZFS..
Sep 13 2019, 5:22 PM
pfg added a comment to D21584: Update libedit to 2019-09-10.

I was busy in the hospital (visiting not as patient) and didn't get the chance to approve it ... Huge thanks for doing this!

Sep 13 2019, 4:47 PM

Sep 9 2019

pfg committed rS352054: ral(4): Use unsigned to avoid undefined behavior..
ral(4): Use unsigned to avoid undefined behavior.
Sep 9 2019, 3:31 AM

Aug 29 2019

pfg committed rP510187: devel/jetbrains-webstorm: Update to 2019.2.1.
devel/jetbrains-webstorm: Update to 2019.2.1
Aug 29 2019, 9:01 PM
pfg committed rP510186: devel/jetbrains-phpstorm: Update to 2019.2.1.
devel/jetbrains-phpstorm: Update to 2019.2.1
Aug 29 2019, 8:59 PM

Aug 27 2019

pfg committed rP509983: math/mumps4: modernize the port..
math/mumps4: modernize the port.
Aug 27 2019, 3:27 AM

Aug 23 2019

pfg accepted D21378: Turn off -Werror for gcc 4.2.1.
Aug 23 2019, 4:00 PM

Aug 16 2019

pfg committed rS351112: MFC r350970:.
MFC r350970:
Aug 16 2019, 4:54 AM
pfg committed rS351111: MFC r350969:.
MFC r350969:
Aug 16 2019, 4:53 AM
pfg committed rS351110: MFC r350970:.
MFC r350970:
Aug 16 2019, 4:53 AM
pfg committed rS351109: MFC r350969:.
MFC r350969:
Aug 16 2019, 4:51 AM

Aug 13 2019

pfg committed rS350970: Add deprecation notice to snd_maestro(4)..
Add deprecation notice to snd_maestro(4).
Aug 13 2019, 1:25 AM
pfg committed rS350969: Add deprecation notice to snd_ds1(4)..
Add deprecation notice to snd_ds1(4).
Aug 13 2019, 1:24 AM
D21139: Add deprecation notice to snd_maestro(4) now requires review to proceed.

This passes "mandoc -Tlint".

Aug 13 2019, 1:22 AM
pfg added a comment to D21138: Add deprecation notice to snd_ds1(4).

This passes "mandoc -Tlint".

Aug 13 2019, 1:21 AM

Aug 11 2019

pfg added a comment to D21138: Add deprecation notice to snd_ds1(4).

Fixes.

Aug 11 2019, 3:57 AM

Aug 8 2019

pfg committed rP508362: graphics/dataplot: replace numberingn to preserve the time/version continuum.
graphics/dataplot: replace numberingn to preserve the time/version continuum
Aug 8 2019, 5:46 AM

Aug 6 2019

pfg committed rP508261: math/superlu_mt: update URLs..
math/superlu_mt: update URLs.
Aug 6 2019, 4:17 PM
pfg committed rP508260: graphics/dataplot: update to version g20190426.
graphics/dataplot: update to version g20190426
Aug 6 2019, 4:16 PM

Aug 4 2019

pfg committed rP508133: devel/jetbrains-webstorm: Update to version 2019.2.
devel/jetbrains-webstorm: Update to version 2019.2
Aug 4 2019, 11:28 PM
pfg committed rP508132: devel/jetbrains-phpstorm: Update to version 2019.2.
devel/jetbrains-phpstorm: Update to version 2019.2
Aug 4 2019, 11:27 PM

Aug 3 2019

pfg added a comment to D15687: libssp is part of GCC, not an independent library..

Did you verify that the problem on i386 described in r251668 no longer occurs?

Aug 3 2019, 10:25 PM
pfg added a comment to D15687: libssp is part of GCC, not an independent library..

I think the problem in libssp_nonshared.a is brought in bogusly by the
libc.ldscript.

Aug 3 2019, 8:07 PM

Aug 2 2019

pfg created D21139: Add deprecation notice to snd_maestro(4).
Aug 2 2019, 7:26 PM
pfg created D21138: Add deprecation notice to snd_ds1(4).
Aug 2 2019, 7:11 PM

Jul 31 2019

pfg committed rP507738: devel/jetbrains-webstorm Update to version 2019.1.4.
devel/jetbrains-webstorm Update to version 2019.1.4
Jul 31 2019, 9:08 PM

Jul 26 2019

pfg committed rS350366: MFC r349802 (from fsu@):.
MFC r349802 (from fsu@):
Jul 26 2019, 9:08 PM

Jul 22 2019

pfg committed rP507176: Update java/intellij-rubymine to version 2019.1.2.
Update java/intellij-rubymine to version 2019.1.2
Jul 22 2019, 9:53 PM

Jul 15 2019

pfg committed rP506709: New port: JetBrains WebStorm..
New port: JetBrains WebStorm.
Jul 15 2019, 8:15 PM

Jul 6 2019

pfg added a comment to V9: Which fusefs(5) features would you like to see?.

Its an ext4 feature, linux calls it crtime (creation time), just to be different ;).

Jul 6 2019, 4:12 PM
pfg added a comment to V9: Which fusefs(5) features would you like to see?.

In general I prefer we support a lower number of the protocol but that we support it well.

Jul 6 2019, 2:47 PM

Jun 30 2019

pfg added a comment to D20598: powerpc: Transition to Secure-PLT, like most other OSs.

Is there anything to be done for modern versions of GCC (GCC 8 or later)?

Jun 30 2019, 3:56 PM

Jun 24 2019

pfg updated subscribers of D20598: powerpc: Transition to Secure-PLT, like most other OSs.

I think andreast@ and gerald@ may want to be kept in the loop for the GCC update then :).

Jun 24 2019, 9:48 PM
pfg added a comment to D20598: powerpc: Transition to Secure-PLT, like most other OSs.

Very exciting ... will upstream GCC require changes as well?

Jun 24 2019, 8:10 PM

Jun 9 2019

pfg added a reviewer for D20571: Add a sentence about full ext4 read/write support the filesystems chapter in the handbook: fsu.

Adding fsu@ in case he wants to mention something else :).

Jun 9 2019, 11:28 PM
pfg accepted D20571: Add a sentence about full ext4 read/write support the filesystems chapter in the handbook.

Yes, we do fully support ext4 read and write in FreeBSD 12+. We also support Extended Attributes, ACLs, and most features with the exception of journalling and encryption. As mentioned in BSDNow, 12.1 will have a DTrace provider.

Jun 9 2019, 11:25 PM

Jun 8 2019

pfg added a comment to D20533: Add a basic clang-format configuration file.

Thanks for working on this. For the record,

Jun 8 2019, 2:30 AM

May 29 2019

pfg committed rS348349: typo: suppported..
typo: suppported.
May 29 2019, 2:08 AM

May 25 2019

pfg accepted D20396: Missing "else" in cascaded condition (if).

The changes seem correct.
I don't think a simple phabricator acceptance from a committer is suficient approval for a non src committer though, so I hereby explicitly approve it.

May 25 2019, 3:22 AM

May 12 2019

pfg committed rP501504: devel/jetbrains-phpstorm update to 2019.1.2.
devel/jetbrains-phpstorm update to 2019.1.2
May 12 2019, 8:33 PM

May 8 2019

pfg committed rP501049: math/R-cran-DoE.base update to 1.1-3.
math/R-cran-DoE.base update to 1.1-3
May 8 2019, 8:08 PM

May 1 2019

pfg committed rP500596: math/reduce* : Update to 20190413 snapshot.
math/reduce* : Update to 20190413 snapshot
May 1 2019, 3:49 PM

Apr 27 2019

pfg abandoned D2877: More Apple-block function support.

This has rusted since the last revision: fts had some changes (mostly just updated prototypes) and glob has been rewritten.
It needs some fresh eyes into it (cc'ing brooks in case he wants to take over).

Apr 27 2019, 3:42 PM
pfg abandoned D9915: Use of reallocarray(3) in userland..

Most of these don't make sense as they cant overflow, and those that do were committed.

Apr 27 2019, 2:41 PM
pfg closed D16615: msdosfs: fixes for Undefined Behavior..

This was committed as r337456.

Apr 27 2019, 2:34 PM
pfg resigned from D10009: Fix a memory leak in bhyve.
Apr 27 2019, 2:30 PM
pfg added a reviewer for D13487: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_*.: asomers.

Is this still a valid review? I recall something related was committed.

Apr 27 2019, 2:27 PM

Apr 24 2019

pfg committed rP499913: devel/jetbrains-phpstorm: minor update to version 2019.1.1..
devel/jetbrains-phpstorm: minor update to version 2019.1.1.
Apr 24 2019, 8:56 PM

Apr 19 2019

pfg committed rP499388: math/taucs: change metis4 dependency to metis..
math/taucs: change metis4 dependency to metis.
Apr 19 2019, 8:18 PM
pfg committed rP499378: cad/calculix: Update to 2.15..
cad/calculix: Update to 2.15.
Apr 19 2019, 5:16 PM

Apr 18 2019

pfg committed rP499275: cad/calculix-ccx: Update to version 2.15..
cad/calculix-ccx: Update to version 2.15.
Apr 18 2019, 3:33 PM

Apr 17 2019

pfg committed rD52935: Note enhanced commit privileges..
Note enhanced commit privileges.
Apr 17 2019, 2:49 PM
pfg committed rS346311: Add orphan mentee..
Add orphan mentee.
Apr 17 2019, 2:21 PM
pfg committed rS346310: Add myself to ports committers..
Add myself to ports committers.
Apr 17 2019, 2:12 PM

Apr 13 2019

pfg committed rS346189: MFC r344755 (by fsu@).
MFC r344755 (by fsu@)
Apr 13 2019, 8:49 PM

Apr 10 2019

pfg accepted D19848: ext2fs: Dtrace support..

I still hope to hear from the DTrace experts, but I like this very much. Thanks!

Apr 10 2019, 4:06 PM

Apr 8 2019

pfg added inline comments to D19848: ext2fs: Dtrace support..
Apr 8 2019, 7:27 PM
pfg added reviewers for D19848: ext2fs: Dtrace support.: gnn, markj, mckusick.

Very cool (but I am biased since I suggested the fusefs-dtrace changes as a starting point)!

Apr 8 2019, 7:21 PM

Apr 5 2019

pfg accepted D19824: Implement checking of `.' and `..' entries of subdirectory..
Apr 5 2019, 1:03 AM

Mar 1 2019

pfg added a comment to D19325: Do not panic if inode bitmap is corrupted..

I recently added the new error EINTEGRITY which is intended for use when a cylinder group or other filesystem structure has an integrity error.

Mar 1 2019, 4:12 AM

Feb 27 2019

pfg accepted D19325: Do not panic if inode bitmap is corrupted..

Upon further thought: the situation is very different for ext2fs than to a filesystem in which the all the system depends as in UFS.

Feb 27 2019, 8:20 PM
pfg accepted D19327: Do not read the on-disk inode in case of vnode allocation..
In D19327#414960, @fsu wrote:
In D19327#413791, @pfg wrote:

Note why we specifically set ip->i_flags = 0 since r294652:

The ip->i_flags will be zero in all cases inside this function because we does not read new inode from disk at all for now and inode is allocated thru malloc with M_ZERO flag.

OK, you are rught, we were not allocating (with M_ZERO) this before.

Feb 27 2019, 4:51 PM
pfg added a reviewer for D19325: Do not panic if inode bitmap is corrupted.: mckusick.

Hi Kirk;
We have this as a panic in UFS, as well.

Feb 27 2019, 4:40 PM
pfg added a comment to D19325: Do not panic if inode bitmap is corrupted..

We should probably keep this panic for consistency with UFS, which also panics on this case.

Feb 27 2019, 2:52 PM
pfg accepted D19324: Validate block bitmaps..
Feb 27 2019, 2:46 PM
pfg accepted D19323: Add additional on-disk inode checks..
Feb 27 2019, 2:45 PM
pfg accepted D19322: Make superblock reading logic more strict..
Feb 27 2019, 2:43 PM
pfg accepted D19385: Fix double free in case of mount error..
Feb 27 2019, 2:34 PM