pfg (Pedro Giffuni)
User

Projects

User Details

User Since
Jul 18 2014, 8:51 PM (204 w, 6 d)

Recent Activity

Wed, Jun 13

pfg added a reviewer for D15687: libssp is part of GCC, not an independent library.: jhb.
Wed, Jun 13, 2:27 AM
pfg added a comment to D15768: Cosmetic style(9) fixes space vs tab..

As a sidenote: one file in bhyve has no license. This is a problem.

Wed, Jun 13, 2:22 AM
pfg requested changes to D15768: Cosmetic style(9) fixes space vs tab..

I agree with other reviewers: The SPDX changes should be split.

Wed, Jun 13, 2:20 AM

Mon, Jun 11

pfg committed rS334950: style(9): Fix tabs after #define..
style(9): Fix tabs after #define.
Mon, Jun 11, 2:45 PM

Thu, Jun 7

pfg created D15687: libssp is part of GCC, not an independent library..
Thu, Jun 7, 5:36 AM

Wed, Jun 6

pfg committed rS334742: MFC r333311:.
MFC r333311:
Wed, Jun 6, 10:29 PM

May 14 2018

pfg committed rS333611: MFC r333239:.
MFC r333239:
May 14 2018, 7:22 PM
pfg committed rS333610: MFC r333239:.
MFC r333239:
May 14 2018, 7:20 PM

May 12 2018

pfg accepted D15396: Fix directory blocks checksumming..
May 12 2018, 3:01 AM
pfg accepted D15395: Fix on-disk inode checksum calculation logic..

Looks good to me

May 12 2018, 2:54 AM
pfg accepted D15394: Fix EXT2FS_DEBUG definition usage..
May 12 2018, 2:50 AM

May 6 2018

pfg committed rS333311: msdosfs: use vfs_timestamp() to generate timestamps instead of getnanotime()..
msdosfs: use vfs_timestamp() to generate timestamps instead of getnanotime().
May 6 2018, 9:29 PM
pfg closed D15297: msdosfs: use vfs_timestamp() to generate timestamps instead of getnanotime().
May 6 2018, 9:29 PM · Src Committers
pfg removed a reviewer for D15297: msdosfs: use vfs_timestamp() to generate timestamps instead of getnanotime(): emaste.

For the record, his patch first appeared in PR 217560, it's unrelated to the Bug, so I asked for an independent CR.
I will take care of it.

May 6 2018, 9:22 PM · Src Committers

May 4 2018

pfg accepted D15297: msdosfs: use vfs_timestamp() to generate timestamps instead of getnanotime().

Approved.
Hoping someone else can do the honors though .. I did somethig dumb with my partition table.

May 4 2018, 6:08 PM · Src Committers
pfg committed rS333239: msdosfs: long names of files are created incorrectly..
msdosfs: long names of files are created incorrectly.
May 4 2018, 3:44 AM

Apr 28 2018

pfg committed rS333082: MFC r332986:.
MFC r332986:
Apr 28 2018, 2:32 AM

Apr 25 2018

pfg committed rS332986: makefs: Use ENODATA instead of ENOMSG as a translation for missing ENOATTR..
makefs: Use ENODATA instead of ENOMSG as a translation for missing ENOATTR.
Apr 25 2018, 2:44 AM

Apr 19 2018

pfg committed rS332750: MFC r328957:.
MFC r328957:
Apr 19 2018, 2:50 AM
pfg committed rS332749: MFC r328957:.
MFC r328957:
Apr 19 2018, 2:47 AM

Apr 8 2018

pfg committed rS332308: MFC r331969, r332035:.
MFC r331969, r332035:
Apr 8 2018, 9:56 PM

Apr 4 2018

pfg committed rS332035: pthread.h: minor indentation cleanups..
pthread.h: minor indentation cleanups.
Apr 4 2018, 3:16 PM
pfg committed rS331969: pthread.h: drop nullability attributes..
pthread.h: drop nullability attributes.
Apr 4 2018, 2:00 AM

Mar 20 2018

pfg abandoned D10035: Use of nullability attributes in string functions..

There is little interest on this.

Mar 20 2018, 2:41 AM

Mar 6 2018

pfg committed rP463737: math/R-cran-truncnorm: Update to 1.0-8.
math/R-cran-truncnorm: Update to 1.0-8
Mar 6 2018, 6:22 PM

Feb 28 2018

pfg committed rS330097: MFC r329848:.
MFC r329848:
Feb 28 2018, 2:50 AM
pfg committed rS330096: MFC r329848:.
MFC r329848:
Feb 28 2018, 2:49 AM
pfg committed rS330095: MFC r329846:.
MFC r329846:
Feb 28 2018, 2:39 AM
pfg committed rS330094: MFC r329846:.
MFC r329846:
Feb 28 2018, 2:38 AM

Feb 23 2018

pfg committed rP462703: math/reduce: update to latest snapshot and cleanup..
math/reduce: update to latest snapshot and cleanup.
Feb 23 2018, 3:21 PM
pfg committed rP462702: math/reduce: update to latest snapshot and cleanup..
math/reduce: update to latest snapshot and cleanup.
Feb 23 2018, 3:12 PM
pfg committed rS329848: __printf_render_int(): small type change to match use..
__printf_render_int(): small type change to match use.
Feb 23 2018, 1:12 AM
pfg committed rS329846: getpeereid(3): Fix behavior on failure to match documentation..
getpeereid(3): Fix behavior on failure to match documentation.
Feb 23 2018, 12:28 AM

Feb 10 2018

pfg committed rS329102: libcompat: Use %hu for unsigned shorts..
libcompat: Use %hu for unsigned shorts.
Feb 10 2018, 2:45 PM

Feb 8 2018

pfg committed rS329018: su_data: correct macro expansion..
su_data: correct macro expansion.
Feb 8 2018, 2:54 PM
pfg committed rP461242: math/coinmp: Fix description for FORTRAN option..
math/coinmp: Fix description for FORTRAN option.
Feb 8 2018, 2:41 PM
pfg committed rP461195: math/coinmp: Add an option for Fortran..
math/coinmp: Add an option for Fortran.
Feb 8 2018, 1:13 AM

Feb 6 2018

pfg committed rS328957: {ext2|ufs}_readdir: Avoid setting negative ncookies..
{ext2|ufs}_readdir: Avoid setting negative ncookies.
Feb 6 2018, 10:38 PM

Feb 5 2018

pfg committed rS328885: ext2fs: remove EXT4F_RO_INCOMPAT_SUPP.
ext2fs: remove EXT4F_RO_INCOMPAT_SUPP
Feb 5 2018, 3:14 PM
pfg committed rS328884: MFC r328567:.
MFC r328567:
Feb 5 2018, 3:03 PM
pfg committed rS328882: ext2fs: Cleanup variable assignments for extents..
ext2fs: Cleanup variable assignments for extents.
Feb 5 2018, 2:30 PM
pfg closed D14193: ext2fs: Tidy ups for variable assignment..
Feb 5 2018, 2:30 PM
pfg added a comment to D14193: ext2fs: Tidy ups for variable assignment..
In D14193#297843, @fsu wrote:

I am more prefer to initialize stack variables immediately after declaration, but, seems like it is not so perfect practice.
Ok.

Feb 5 2018, 2:22 PM

Feb 4 2018

pfg updated the diff for D14193: ext2fs: Tidy ups for variable assignment..

Fix compilation.

Feb 4 2018, 3:25 PM
pfg created D14193: ext2fs: Tidy ups for variable assignment..
Feb 4 2018, 3:19 PM

Feb 2 2018

pfg added a comment to D10035: Use of nullability attributes in string functions..

At a glance this seems fine. Is it stalled for review or abandoned?

Feb 2 2018, 11:43 PM

Feb 1 2018

pfg committed rS328649: MFC r328497:.
MFC r328497:
Feb 1 2018, 2:00 AM
pfg committed rS328648: MFC r328497:.
MFC r328497:
Feb 1 2018, 1:59 AM

Jan 29 2018

pfg committed rS328567: libedit: sort the Makefile in line with NetBSD's version..
libedit: sort the Makefile in line with NetBSD's version.
Jan 29 2018, 10:38 PM
pfg committed rS328551: pppctl88) Avoid strcpy() copies on overlapping string..
pppctl88) Avoid strcpy() copies on overlapping string.
Jan 29 2018, 2:24 PM
pfg committed rS328525: ftp(1): Use closefrom() instead of individual close()s..
ftp(1): Use closefrom() instead of individual close()s.
Jan 29 2018, 1:06 AM

Jan 28 2018

pfg committed rS328517: Avoid implicit gcc nonnull attribute in vwarnx()..
Avoid implicit gcc nonnull attribute in vwarnx().
Jan 28 2018, 7:37 PM
pfg committed rS328506: Revert r328492:.
Revert r328492:
Jan 28 2018, 3:17 AM

Jan 27 2018

pfg committed rS328497: pfctl(8): Fix two wrong conditions..
pfctl(8): Fix two wrong conditions.
Jan 27 2018, 10:57 PM
pfg closed D14083: pfctl(8): Fix two wrong conditions..
Jan 27 2018, 10:57 PM
pfg created D14083: pfctl(8): Fix two wrong conditions..
Jan 27 2018, 10:34 PM
pfg committed rS328493: libthr: Fix missing break in switch..
libthr: Fix missing break in switch.
Jan 27 2018, 10:28 PM
pfg committed rS328492: Fix gcc80 -Wsizeof-pointer-memaccess warning..
Fix gcc80 -Wsizeof-pointer-memaccess warning.
Jan 27 2018, 10:16 PM
pfg committed rS328487: pax(1): Honour the restrict in sigaction()..
pax(1): Honour the restrict in sigaction().
Jan 27 2018, 6:24 PM
pfg committed rS328486: fortune(6): Fix gcc80 -Wbool-operation warnings..
fortune(6): Fix gcc80 -Wbool-operation warnings.
Jan 27 2018, 5:43 PM
pfg committed rS328480: Revert r328479:.
Revert r328479:
Jan 27 2018, 4:34 PM
pfg committed rS328479: {ext2|ufs}_readdir: Set limit on valid ncookies values..
{ext2|ufs}_readdir: Set limit on valid ncookies values.
Jan 27 2018, 3:34 PM

Jan 25 2018

pfg committed rS328406: Minor style issue introduced in r328346..
Minor style issue introduced in r328346.
Jan 25 2018, 6:01 PM
pfg accepted D14051: Remove K&R stuff: never use it in new code..
Jan 25 2018, 5:07 PM

Jan 24 2018

pfg committed rS328346: ext2fs|ufs:Unsign some values related to allocation..
ext2fs|ufs:Unsign some values related to allocation.
Jan 24 2018, 5:59 PM
pfg committed rS328340: Revert r327781, r328093, r328056:.
Revert r327781, r328093, r328056:
Jan 24 2018, 4:45 PM
pfg committed rS328308: MFC r328221:.
MFC r328221:
Jan 24 2018, 12:12 AM

Jan 23 2018

pfg committed rS328280: extfs: Remove unused variables..
extfs: Remove unused variables.
Jan 23 2018, 2:17 PM
pfg closed D14017: Remove some apparently unused variables..
Jan 23 2018, 2:17 PM

Jan 22 2018

pfg created D14017: Remove some apparently unused variables..
Jan 22 2018, 5:43 PM
pfg closed D13835: Make use of mallocarray(9) in drm drivers..
Jan 22 2018, 3:56 PM
pfg committed rS328261: drm2: Basic use of mallocarray(9)..
drm2: Basic use of mallocarray(9).
Jan 22 2018, 3:56 PM
pfg accepted D13835: Make use of mallocarray(9) in drm drivers..

This is small enough that shouldn't affect upstream merging (also the code is very FreeBSD-specific).
It also respects the general objective of the code.

Jan 22 2018, 2:35 AM
pfg committed rS328239: Forgot to sort here in r328238..
Forgot to sort here in r328238.
Jan 22 2018, 2:26 AM
pfg committed rS328238: Unsign some values related to allocation..
Unsign some values related to allocation.
Jan 22 2018, 2:08 AM
pfg committed rS328237: Use the __alloc_size2 attribute where relevant..
Use the __alloc_size2 attribute where relevant.
Jan 22 2018, 1:50 AM

Jan 21 2018

pfg committed rS328221: Define a new __alloc_size2 attribute to complement the exiting support..
Define a new __alloc_size2 attribute to complement the exiting support.
Jan 21 2018, 8:28 PM
pfg committed rS328218: Revert r327828, r327949, r327953, r328016-r328026, r328041:.
Revert r327828, r327949, r327953, r328016-r328026, r328041:
Jan 21 2018, 3:42 PM

Jan 19 2018

pfg added a comment to D13964: Add flex_bg/meta_bg features RW support. .
In D13964#293442, @fsu wrote:
In D13964#293380, @pfg wrote:
In D13964#293266, @fsu wrote:
In D13964#293256, @pfg wrote:

Hmm.. it seems like we are getting to a rather complete ext4 implementation, which is positive. On the downside the code is diverging from UFS. We just can't have both I guess.

There are another features like RO_COMPAT_QUOTA, INCOMPAT_INLINE_DATA, etc, but from my current point of view, it is not so, important, if it will be required to implement it. I think it a not a problem.
The only feature, which will be difficult to implement is RO_COMPAT_BIGALLOC, but I hope it will be not widely used by linux.

I haven't looked at ext4 for a while but most of those features seem to require some obscure collaboration from the kernel, that is out of the scope of the driver. There's also the issue that most of the interesting enhancements in linux assume there is journalling.

I am not sure, that journal feature is required for non-native file system, also it will be difficult to test it.

Jan 19 2018, 7:26 PM
pfg added a comment to D13964: Add flex_bg/meta_bg features RW support. .
In D13964#293266, @fsu wrote:
In D13964#293256, @pfg wrote:

Hmm.. it seems like we are getting to a rather complete ext4 implementation, which is positive. On the downside the code is diverging from UFS. We just can't have both I guess.

There are another features like RO_COMPAT_QUOTA, INCOMPAT_INLINE_DATA, etc, but from my current point of view, it is not so, important, if it will be required to implement it. I think it a not a problem.
The only feature, which will be difficult to implement is RO_COMPAT_BIGALLOC, but I hope it will be not widely used by linux.

Jan 19 2018, 3:46 PM
pfg committed rS328164: libnv: Use mallocarray(9) for the nv_calloc..
libnv: Use mallocarray(9) for the nv_calloc.
Jan 19 2018, 2:50 PM
pfg added a comment to D13964: Add flex_bg/meta_bg features RW support. .

A sidenote: I just noticed META_BG is supported on ext3 too.

Jan 19 2018, 3:56 AM
pfg accepted D13964: Add flex_bg/meta_bg features RW support. .

Hmm.. it seems like we are getting to a rather complete ext4 implementation, which is positive. On the downside the code is diverging from UFS. We just can't have both I guess.
In any case , let me mention that EXT4F_RO_INCOMPAT_SUPP was created as a dirty hack: to workaround for features that we were not planning to support at all but that we needed to fake in order to read the partition.
We should remove EXT4F_RO_INCOMPAT_SUPP as it has fulfilled its purpose.

Jan 19 2018, 3:41 AM

Jan 17 2018

pfg committed rS328093: ufs: use mallocarray(9)..
ufs: use mallocarray(9).
Jan 17 2018, 6:18 PM

Jan 16 2018

pfg committed rS328070: SPDX: finish tagging sys/cam..
SPDX: finish tagging sys/cam.
Jan 16 2018, 11:20 PM
pfg committed rS328067: scsi_ch.c: Small cleanups to the comments..
scsi_ch.c: Small cleanups to the comments.
Jan 16 2018, 11:08 PM
pfg committed rS328056: ext2fs: use mallocarray(9)..
ext2fs: use mallocarray(9).
Jan 16 2018, 7:29 PM
pfg committed rS328041: Fix build after r328020..
Fix build after r328020.
Jan 16 2018, 6:05 AM

Jan 15 2018

pfg added a comment to D13837: Wider adoption of mallocarray(9)..

For the record: the changes were committed by parts in a series of commits from r328016 to r328026.

Jan 15 2018, 10:44 PM
pfg committed rS328026: misc geom and gnu: make some use of mallocarray(9)..
misc geom and gnu: make some use of mallocarray(9).
Jan 15 2018, 9:23 PM
pfg closed D13837: Wider adoption of mallocarray(9)..
Jan 15 2018, 9:23 PM
pfg committed rS328025: net*: make some use of mallocarray(9)..
net*: make some use of mallocarray(9).
Jan 15 2018, 9:22 PM
pfg committed rS328024: netgraph: make some use of mallocarray(9)..
netgraph: make some use of mallocarray(9).
Jan 15 2018, 9:19 PM
pfg committed rS328023: kern: make some use of mallocarray(9)..
kern: make some use of mallocarray(9).
Jan 15 2018, 9:18 PM
pfg committed rS328022: cam: make some use of mallocarray(9)..
cam: make some use of mallocarray(9).
Jan 15 2018, 9:15 PM
pfg committed rS328021: nfsclient: make some use of mallocarray(9)..
nfsclient: make some use of mallocarray(9).
Jan 15 2018, 9:15 PM
pfg committed rS328020: mips: make some use of mallocarray(9)..
mips: make some use of mallocarray(9).
Jan 15 2018, 9:13 PM
pfg committed rS328019: ndis: make some use of mallocarray(9)..
ndis: make some use of mallocarray(9).
Jan 15 2018, 9:11 PM
pfg committed rS328018: powerpc: make some use of mallocarray(9)..
powerpc: make some use of mallocarray(9).
Jan 15 2018, 9:11 PM
pfg committed rS328017: arm: make some use of mallocarray(9)..
arm: make some use of mallocarray(9).
Jan 15 2018, 9:10 PM