Page MenuHomeFreeBSD

pfg (Pedro Giffuni)
User

Projects

User Details

User Since
Jul 18 2014, 8:51 PM (218 w, 5 h)

Recent Activity

Mon, Sep 17

pfg committed rS338707: MFC r337992, r338125:.
MFC r337992, r338125:
Mon, Sep 17, 2:51 AM

Sun, Sep 9

pfg added a comment to D17083: Alter the prototype of qsort_r(3) to match glibc..
In D17083#364265, @pfg wrote:

This is likely to cause huge havoc in the ports tree: we created the API and Apple adopted it. Later glibc and NetBSD adopted their own variant.

Sun, Sep 9, 1:15 AM

Sat, Sep 8

pfg added a comment to D17083: Alter the prototype of qsort_r(3) to match glibc..

This is likely to cause huge havoc in the ports tree: we created the API and Apple adopted it. Later glibc and NetBSD adopted their own variant.

Sat, Sep 8, 10:36 PM

Aug 22 2018

pfg committed rS338181: MFC r337728: (committed by jilles).
MFC r337728: (committed by jilles)
Aug 22 2018, 4:27 AM
pfg committed rS338180: MFC r337456:.
MFC r337456:
Aug 22 2018, 4:21 AM
pfg committed rS338179: MFC r337456:.
MFC r337456:
Aug 22 2018, 4:20 AM

Aug 21 2018

pfg committed rS338125: libthr: minor spacing cleanup..
libthr: minor spacing cleanup.
Aug 21 2018, 1:33 AM
pfg committed rS338124: MFC r337422:.
MFC r337422:
Aug 21 2018, 1:17 AM

Aug 18 2018

pfg added a comment to D16722: POSIX compliance improvements in the pthread(3) functions..
In D16722#356962, @kib wrote:
In D16722#356907, @pfg wrote:
Aug 18 2018, 10:18 PM
pfg committed rS337992: POSIX compliance improvements in the pthread(3) functions..
POSIX compliance improvements in the pthread(3) functions.
Aug 18 2018, 1:05 AM
pfg closed D16722: POSIX compliance improvements in the pthread(3) functions..
Aug 18 2018, 1:05 AM
pfg updated the test plan for D16722: POSIX compliance improvements in the pthread(3) functions..
Aug 18 2018, 12:47 AM
pfg added a comment to D16722: POSIX compliance improvements in the pthread(3) functions..
In D16722#356897, @kib wrote:

I do not think that functions definitions need to use __restrict. libthr is compiled only with C99 compiler, never C89 nor C++, so direct use of the restrict keyword is fine.

Aug 18 2018, 12:44 AM

Aug 17 2018

pfg added a comment to D16722: POSIX compliance improvements in the pthread(3) functions..
In D16722#356695, @kib wrote:
In D16722#356631, @pfg wrote:
Aug 17 2018, 10:44 PM
pfg updated the diff for D16722: POSIX compliance improvements in the pthread(3) functions..

Checked for compliance against POSIX/SUSv4-2018.
Document the changes in the man pages.

Aug 17 2018, 10:20 PM
pfg added a comment to D16722: POSIX compliance improvements in the pthread(3) functions..
In D16722#356491, @kib wrote:
In D16722#356448, @pfg wrote:
In D16722#356440, @kib wrote:

Did you verified include/pthread.h against POSIX/SUSv4-2018 ?

No, I only checked individual functions against the public v2-1997, which came up first in my search.

It does not matter much which version of POSIX you used. I am concerned with the header change to match at least some standard.

Aug 17 2018, 2:38 PM
pfg updated the diff for D16722: POSIX compliance improvements in the pthread(3) functions..

Avoid const poisoning the private functions by using __DECONST early.

Aug 17 2018, 2:22 PM
pfg updated the summary of D16722: POSIX compliance improvements in the pthread(3) functions..
Aug 17 2018, 2:26 AM
pfg added a comment to D16722: POSIX compliance improvements in the pthread(3) functions..
In D16722#356440, @kib wrote:

Did you verified include/pthread.h against POSIX/SUSv4-2018 ?

Aug 17 2018, 2:22 AM

Aug 16 2018

pfg committed rS337920: Revert r337419..
Revert r337419.
Aug 16 2018, 6:35 PM

Aug 15 2018

pfg updated the diff for D16722: POSIX compliance improvements in the pthread(3) functions..

Drop the bogus umtx change: instead adopt a couple of __DECONST() in
libthr to workaround the warnings.

Aug 15 2018, 10:10 PM
pfg added inline comments to D16722: POSIX compliance improvements in the pthread(3) functions..
Aug 15 2018, 9:44 PM
pfg created D16722: POSIX compliance improvements in the pthread(3) functions..
Aug 15 2018, 2:26 PM
pfg added a comment to D16707: [GSoC 2018] Porting of .NET Core Runtime, SDK, and PowerShell.

May I suggest you add "test" targets to the ports?

Aug 15 2018, 1:19 AM

Aug 14 2018

pfg committed rS337823: MFC r337458, r337618:.
MFC r337458, r337618:
Aug 14 2018, 10:57 PM

Aug 9 2018

pfg accepted D13528: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_* (logic only)..

(I thought this had been committed already :-/ )

Aug 9 2018, 2:11 AM

Aug 8 2018

pfg committed rS337458: Fix printf(1) ignores width and precision in %b format..
Fix printf(1) ignores width and precision in %b format.
Aug 8 2018, 3:25 PM
pfg committed rS337457: Revert r337440: the log message is wrong..
Revert r337440: the log message is wrong.
Aug 8 2018, 3:12 PM
pfg committed rS337456: msdosfs: fixes for Undefined Behavior..
msdosfs: fixes for Undefined Behavior.
Aug 8 2018, 3:08 PM
pfg added a reviewer for D16615: msdosfs: fixes for Undefined Behavior.: delphij.
Aug 8 2018, 4:27 AM

Aug 7 2018

pfg committed rS337440: Fix printf(1) ignores width and precision in %b format..
Fix printf(1) ignores width and precision in %b format.
Aug 7 2018, 11:04 PM
pfg created D16615: msdosfs: fixes for Undefined Behavior..
Aug 7 2018, 3:48 PM
pfg committed rS337422: libc: fix cases of undefined behavior..
libc: fix cases of undefined behavior.
Aug 7 2018, 3:24 PM
pfg committed rS337419: sed(1): partial fix for the case of the regex delimited with '['..
sed(1): partial fix for the case of the regex delimited with '['.
Aug 7 2018, 2:47 PM

Aug 6 2018

pfg committed rS337367: MFC r336926:.
MFC r336926:
Aug 6 2018, 2:11 AM
pfg committed rS337366: MFC r336926:.
MFC r336926:
Aug 6 2018, 2:09 AM

Jul 30 2018

pfg committed rS336929: sed: compile with the default WARNS level..
sed: compile with the default WARNS level.
Jul 30 2018, 7:42 PM
pfg committed rS336926: sed: unsign some indexes to fix sign-compare warnings..
sed: unsign some indexes to fix sign-compare warnings.
Jul 30 2018, 6:29 PM

Jul 29 2018

pfg added a comment to D16484: Add new port textproc/scancode-toolkit.

I think you still have to fix the shebang on "configure".

Jul 29 2018, 12:55 AM · Contributor Reviewers (ports)
pfg added a comment to D16484: Add new port textproc/scancode-toolkit.

Cool thanks! Please try to upstream the changes when you can.

Jul 29 2018, 12:46 AM · Contributor Reviewers (ports)

Jul 18 2018

pfg accepted D16316: Consistently use explicit_bzero() for _Final methods..
Jul 18 2018, 3:16 PM
pfg accepted D16314: Get rid of unused variables..

Good catch!

Jul 18 2018, 3:51 AM

Jul 17 2018

pfg committed rD52014: Document FreeBSD version 1200074..
Document FreeBSD version 1200074.
Jul 17 2018, 2:44 AM
pfg committed rS336360: FreeBSD_version bump as per r336351,.
FreeBSD_version bump as per r336351,
Jul 17 2018, 2:21 AM

Jul 16 2018

pfg committed rS336351: Update libstdc++ configuration..
Update libstdc++ configuration.
Jul 16 2018, 6:53 PM
pfg closed D16289: Update libstdc++ configuration..
Jul 16 2018, 6:53 PM
pfg created D16289: Update libstdc++ configuration..
Jul 16 2018, 2:47 PM
pfg committed rS336324: MFC r336115;.
MFC r336115;
Jul 16 2018, 12:28 AM
pfg committed rS336323: MFC r336113:.
MFC r336113:
Jul 16 2018, 12:23 AM
pfg committed rS336322: MFC r336115;.
MFC r336115;
Jul 16 2018, 12:20 AM

Jul 9 2018

pfg committed rS336145: localedef(1): remove duplicated includes..
localedef(1): remove duplicated includes.
Jul 9 2018, 8:39 PM
pfg committed rS336143: sed(1): Suppress implicit-fallthrough..
sed(1): Suppress implicit-fallthrough.
Jul 9 2018, 8:27 PM
pfg accepted D16192: Utilize le32dec()..

Thanks! feel free to MFC my previous change.

Jul 9 2018, 12:14 PM

Jul 8 2018

pfg committed rS336115: libiconv: correct undefined behavior..
libiconv: correct undefined behavior.
Jul 8 2018, 11:22 PM
pfg committed rS336113: gzip: fix for undefined behavior..
gzip: fix for undefined behavior.
Jul 8 2018, 10:39 PM

Jul 3 2018

pfg abandoned D15687: libssp is part of GCC, not an independent library..

Abandon: it does seem like we can just remove libssp but I don't have time to dig deeper.

Jul 3 2018, 9:52 PM

Jun 30 2018

pfg added a comment to D15687: libssp is part of GCC, not an independent library..
In D15687#340722, @kib wrote:
In D15687#340721, @pfg wrote:
In D15687#340720, @kib wrote:
In D15687#340719, @pfg wrote:
In D15687#340718, @kib wrote:

I fail to understand this. What is built instead of libssp when MK_GCC is NO ? If the answer is nothing, then you get non-functional system.

The answer is indeed nothing. Why is the system non-functional? Why do we need libssp and is there documentation to replace it?

Because you need to satisfy the ssp symbols to get working binaries.

So what is the point of this patch ?

The point is that libssp is part of GCC so we need to know what we need to replace it with (without looking insidie since its GPLd).

I am even more confused now. Why did not you answered this question for yourself before even proposing to remove libssp by the switch ?

Well, that was the question I was asking myself. I moved libssp along with the other libgcc libs (where it came from) and buildworld still works, I get no missing symbols anywhere.
I theorized that we appear to have added the FORTIFY_SOURCE functions but we are not using them anywhere.

Ports are working still on my machine (11-stable), after building without libssp:

file /usr/lib/libssp_nonshared.a:
/usr/lib/libssp_nonshared.a:: cannot open `/usr/lib/libssp_nonshared.a:' (No such file or directory)

Goal is to have the functional system, and to have it GPL-free is somewhere in the second line.

Yes, I am just trying to identify why current is non-functional without the GPL'd piece.

If you do not provide libssp(_nonshared.a), then you should disable -f option for ssp, which is probably enabled by default in the spec for gcc, and somewhere in c++ for clang.

Thanks, that is a good hint.

Jun 30 2018, 10:21 PM
pfg added a comment to D15687: libssp is part of GCC, not an independent library..
In D15687#340720, @kib wrote:
In D15687#340719, @pfg wrote:
In D15687#340718, @kib wrote:

I fail to understand this. What is built instead of libssp when MK_GCC is NO ? If the answer is nothing, then you get non-functional system.

The answer is indeed nothing. Why is the system non-functional? Why do we need libssp and is there documentation to replace it?

Because you need to satisfy the ssp symbols to get working binaries.

So what is the point of this patch ?

The point is that libssp is part of GCC so we need to know what we need to replace it with (without looking insidie since its GPLd).

I am even more confused now. Why did not you answered this question for yourself before even proposing to remove libssp by the switch ?

Jun 30 2018, 9:30 PM
pfg added a comment to D15687: libssp is part of GCC, not an independent library..
In D15687#340718, @kib wrote:

I fail to understand this. What is built instead of libssp when MK_GCC is NO ? If the answer is nothing, then you get non-functional system.

Jun 30 2018, 9:05 PM
pfg added a reviewer for D15687: libssp is part of GCC, not an independent library.: kib.

All ports fail to build with this patch

Jun 30 2018, 8:14 PM

Jun 26 2018

pfg added a comment to D15687: libssp is part of GCC, not an independent library..

For reference, BSDL __stack_chk_fail in Android https://android.googlesource.com/platform/bionic/+/ics-mr1-release/libc/bionic/ssp.c and NetBSD http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libc/misc/stack_protector.c?annotate=1.9&only_with_tag=MAIN.

The libssp subdir should be added only if both MK_SSP and MK_GCC are true; someone who sets WITHOUT_SSP but WITH_GCC should not get it. Also, it seems there are other MK_SSP conditionals that need to be investigated in other Makefiles and share/mk.

Jun 26 2018, 3:22 PM
pfg added a comment to D15687: libssp is part of GCC, not an independent library..

In terms of exposed symbols (see objdump -T), libssp definitely is a FORTIFY_SOURCE implementation. I've not looked at the code to avoid contamination in case we need a cleanroom one.

Jun 26 2018, 2:58 PM
pfg added a reviewer for D15687: libssp is part of GCC, not an independent library.: brooks.

For the record: the compiler libssp is not the same as libssp as in NetBSD and bionic's libc, which implements the libc support for FORTIFY_SOURCE.

Jun 26 2018, 1:13 AM

Jun 13 2018

pfg added a reviewer for D15687: libssp is part of GCC, not an independent library.: jhb.
Jun 13 2018, 2:27 AM
pfg added a comment to D15768: Cosmetic style(9) fixes space vs tab..

As a sidenote: one file in bhyve has no license. This is a problem.

Jun 13 2018, 2:22 AM
pfg requested changes to D15768: Cosmetic style(9) fixes space vs tab..

I agree with other reviewers: The SPDX changes should be split.

Jun 13 2018, 2:20 AM

Jun 11 2018

pfg committed rS334950: style(9): Fix tabs after #define..
style(9): Fix tabs after #define.
Jun 11 2018, 2:45 PM

Jun 7 2018

pfg created D15687: libssp is part of GCC, not an independent library..
Jun 7 2018, 5:36 AM

Jun 6 2018

pfg committed rS334742: MFC r333311:.
MFC r333311:
Jun 6 2018, 10:29 PM

May 14 2018

pfg committed rS333611: MFC r333239:.
MFC r333239:
May 14 2018, 7:22 PM
pfg committed rS333610: MFC r333239:.
MFC r333239:
May 14 2018, 7:20 PM

May 12 2018

pfg accepted D15396: Fix directory blocks checksumming..
May 12 2018, 3:01 AM
pfg accepted D15395: Fix on-disk inode checksum calculation logic..

Looks good to me

May 12 2018, 2:54 AM
pfg accepted D15394: Fix EXT2FS_DEBUG definition usage..
May 12 2018, 2:50 AM

May 6 2018

pfg committed rS333311: msdosfs: use vfs_timestamp() to generate timestamps instead of getnanotime()..
msdosfs: use vfs_timestamp() to generate timestamps instead of getnanotime().
May 6 2018, 9:29 PM
pfg closed D15297: msdosfs: use vfs_timestamp() to generate timestamps instead of getnanotime().
May 6 2018, 9:29 PM · Src Committers
pfg removed a reviewer for D15297: msdosfs: use vfs_timestamp() to generate timestamps instead of getnanotime(): emaste.

For the record, his patch first appeared in PR 217560, it's unrelated to the Bug, so I asked for an independent CR.
I will take care of it.

May 6 2018, 9:22 PM · Src Committers

May 4 2018

pfg accepted D15297: msdosfs: use vfs_timestamp() to generate timestamps instead of getnanotime().

Approved.
Hoping someone else can do the honors though .. I did somethig dumb with my partition table.

May 4 2018, 6:08 PM · Src Committers
pfg committed rS333239: msdosfs: long names of files are created incorrectly..
msdosfs: long names of files are created incorrectly.
May 4 2018, 3:44 AM

Apr 28 2018

pfg committed rS333082: MFC r332986:.
MFC r332986:
Apr 28 2018, 2:32 AM

Apr 25 2018

pfg committed rS332986: makefs: Use ENODATA instead of ENOMSG as a translation for missing ENOATTR..
makefs: Use ENODATA instead of ENOMSG as a translation for missing ENOATTR.
Apr 25 2018, 2:44 AM

Apr 19 2018

pfg committed rS332750: MFC r328957:.
MFC r328957:
Apr 19 2018, 2:50 AM
pfg committed rS332749: MFC r328957:.
MFC r328957:
Apr 19 2018, 2:47 AM

Apr 8 2018

pfg committed rS332308: MFC r331969, r332035:.
MFC r331969, r332035:
Apr 8 2018, 9:56 PM

Apr 4 2018

pfg committed rS332035: pthread.h: minor indentation cleanups..
pthread.h: minor indentation cleanups.
Apr 4 2018, 3:16 PM
pfg committed rS331969: pthread.h: drop nullability attributes..
pthread.h: drop nullability attributes.
Apr 4 2018, 2:00 AM

Mar 20 2018

pfg abandoned D10035: Use of nullability attributes in string functions..

There is little interest on this.

Mar 20 2018, 2:41 AM

Mar 6 2018

pfg committed rP463737: math/R-cran-truncnorm: Update to 1.0-8.
math/R-cran-truncnorm: Update to 1.0-8
Mar 6 2018, 6:22 PM

Feb 28 2018

pfg committed rS330097: MFC r329848:.
MFC r329848:
Feb 28 2018, 2:50 AM
pfg committed rS330096: MFC r329848:.
MFC r329848:
Feb 28 2018, 2:49 AM
pfg committed rS330095: MFC r329846:.
MFC r329846:
Feb 28 2018, 2:39 AM
pfg committed rS330094: MFC r329846:.
MFC r329846:
Feb 28 2018, 2:38 AM

Feb 23 2018

pfg committed rP462703: math/reduce: update to latest snapshot and cleanup..
math/reduce: update to latest snapshot and cleanup.
Feb 23 2018, 3:21 PM
pfg committed rP462702: math/reduce: update to latest snapshot and cleanup..
math/reduce: update to latest snapshot and cleanup.
Feb 23 2018, 3:12 PM
pfg committed rS329848: __printf_render_int(): small type change to match use..
__printf_render_int(): small type change to match use.
Feb 23 2018, 1:12 AM
pfg committed rS329846: getpeereid(3): Fix behavior on failure to match documentation..
getpeereid(3): Fix behavior on failure to match documentation.
Feb 23 2018, 12:28 AM

Feb 10 2018

pfg committed rS329102: libcompat: Use %hu for unsigned shorts..
libcompat: Use %hu for unsigned shorts.
Feb 10 2018, 2:45 PM

Feb 8 2018

pfg committed rS329018: su_data: correct macro expansion..
su_data: correct macro expansion.
Feb 8 2018, 2:54 PM
pfg committed rP461242: math/coinmp: Fix description for FORTRAN option..
math/coinmp: Fix description for FORTRAN option.
Feb 8 2018, 2:41 PM
pfg committed rP461195: math/coinmp: Add an option for Fortran..
math/coinmp: Add an option for Fortran.
Feb 8 2018, 1:13 AM