fusefs: correctly set lock owner during FUSE_SETLK
ClosedPublic
Actions

Authored by asomers on Jun 2 2021, 9:44 PM.

Details

Reviewers

emaste
pfg

Commits

rGc7fe00ae403f: fusefs: correctly set lock owner during FUSE_SETLK
rG7d9771228715: fusefs: correctly set lock owner during FUSE_SETLK
rG18b19f8c6e04: fusefs: correctly set lock owner during FUSE_SETLK

Summary

During FUSE_SETLK, the owner field should uniquely identify the calling
process. The fusefs module now sets it to the process's pid.
Previously, it expected the calling process to set it directly, which
was wrong.

libfuse also apparently expects the owner field to be set during
FUSE_GETLK, though I'm not sure why.

PR: 256005
Reported by: Agata <chogata@moosefs.pro>
MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Jun 2 2021, 9:44 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 2 2021, 9:44 PM

asomers requested review of this revision.Jun 2 2021, 9:44 PM

Harbormaster completed remote builds in B39675: Diff 90344.Jun 2 2021, 9:44 PM

pfg, would you mind reviewing this change?

piotr.konopelko_moosefs.com added a subscriber: piotr.konopelko_moosefs.com.Jun 22 2021, 8:43 PM

Hrm, it seems I had an inline comment that was never submitted.

tests/sys/fs/fusefs/locks.cc
281	Can you explain this part of the change (i.e., 0 instead of pid which was fake)

asomers added inline comments.Jun 22 2021, 9:05 PM

tests/sys/fs/fusefs/locks.cc
281	When I first wrote the test I thought that the caller of fcntl was supposed to set pid. But that was wrong. The kernel is supposed to set it, and we verify it on return.