Page MenuHomeFreeBSD
Differential D35771

Rewrite function definitions with identifier lists
ClosedPublic
Actions

Authored by yikong_google.com on Jul 11 2022, 10:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 10, 9:41 AM
Unknown Object (File)
Sun, Aug 9, 11:57 AM
Unknown Object (File)
Sun, Aug 9, 9:52 AM
Unknown Object (File)
Sun, Aug 9, 9:48 AM
Unknown Object (File)
Sat, Aug 1, 11:53 PM
Unknown Object (File)
Sat, Aug 1, 5:41 AM
Unknown Object (File)
Mon, Jul 27, 5:28 AM
Unknown Object (File)
Sun, Jul 26, 3:47 PM
View All Files
Subscribers
imp
lwhsu

Details

Reviewers
pfg
jhb
Commits
rGeaf38b5ff9d9: msun: Rewrite function definitions with identifier lists
rG7f753c0c3377: msun: Rewrite function definitions with identifier lists
rG7e06f4708cbe: msun: Rewrite function definitions with identifier lists
Summary

This syntax is removed in C2x proposal N2432.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yikong_google.com requested review of this revision.Jul 11 2022, 10:34 AM
yikong_google.com created this revision.
yikong_google.com added reviewers: pfg, jhb.Jul 11 2022, 10:36 AM
pfg accepted this revision.Jul 11 2022, 7:13 PM
This revision is now accepted and ready to land.Jul 11 2022, 7:13 PM
yikong_google.com added a comment.Jul 11 2022, 7:23 PM

Can you please commit this for me? Thanks.

pfg added a comment.Jul 11 2022, 7:43 PM
In D35771#811866, @yikong_google.com wrote:

Can you please commit this for me? Thanks.

Sorry, I don't have access to my FreeBSD box at this time.

lwhsu added a subscriber: lwhsu.Jul 12 2022, 1:08 AM
In D35771#811866, @yikong_google.com wrote:

Can you please commit this for me? Thanks.

I can help with this, and there are some things I want to check:

  • Is Yi Kong <yikong@google.com>the preferred author line in git log?
  • Do we need to add Sponsored by: Google (or similar) line to the commit message?
  • Is this cherry-picked from Android code? If so, do we need to add Obtained from: line to the commit message?
yikong_google.com added a comment.Jul 12 2022, 5:07 AM

Thanks for help committing this.

In D35771#811944, @lwhsu wrote:
In D35771#811866, @yikong_google.com wrote:

Can you please commit this for me? Thanks.

I can help with this, and there are some things I want to check:

  • Is Yi Kong <yikong@google.com>the preferred author line in git log?

Yes.

  • Do we need to add Sponsored by: Google (or similar) line to the commit message?

That won't be necessary.

  • Is this cherry-picked from Android code? If so, do we need to add Obtained from: line to the commit message?

No.

Closed by commit rG7e06f4708cbe: msun: Rewrite function definitions with identifier lists (authored by yikong_google.com, committed by lwhsu). · Explain WhyJul 12 2022, 5:21 AM
This revision was automatically updated to reflect the committed changes.
lwhsu added a commit: rG7e06f4708cbe: msun: Rewrite function definitions with identifier lists.
Herald added a subscriber: imp. · View Herald TranscriptJul 12 2022, 5:21 AM
lwhsu added a commit: rG7f753c0c3377: msun: Rewrite function definitions with identifier lists.Jul 15 2022, 2:03 PM
lwhsu added a commit: rGeaf38b5ff9d9: msun: Rewrite function definitions with identifier lists.

Revision Contents
Changeset List

PathSize
lib/
msun/
src/
3 lines
3 lines

Diff 108047

View Options

lib/msun/src/w_cabsf.c

Loading...
View Options

lib/msun/src/w_drem.c

Loading...