Page MenuHomeFreeBSD

mckusick (Marshall Kirk McKusick)
User

Projects

User Details

User Since
Oct 24 2014, 7:17 PM (251 w, 1 d)

Recent Activity

Yesterday

mckusick committed rS351164: MFC of 351002.
MFC of 351002
Sat, Aug 17, 6:07 AM

Thu, Aug 15

mckusick committed rS351098: Add missing comma in calendar.freebsd.
Add missing comma in calendar.freebsd
Thu, Aug 15, 6:46 PM

Wed, Aug 14

mckusick added a comment to D2844: Bail out of corrupt directory entries during boot.

Any progress on getting this done?

Wed, Aug 14, 6:05 AM

Tue, Aug 13

mckusick committed rS351002: Clarify comment that describes how the FS_METACKHASH is managed..
Clarify comment that describes how the FS_METACKHASH is managed.
Tue, Aug 13, 8:56 PM

Sat, Aug 10

mckusick committed rS350852: MFC of 350682.
MFC of 350682
Sat, Aug 10, 11:08 PM
mckusick committed rS350851: MFC of 350682.
MFC of 350682
Sat, Aug 10, 11:07 PM
mckusick committed rS350850: MFC of 350490.
MFC of 350490
Sat, Aug 10, 11:03 PM

Wed, Aug 7

mckusick committed rS350682: Correct the location of the first backup superblock in fsck_ffs.8..
Correct the location of the first backup superblock in fsck_ffs.8.
Wed, Aug 7, 4:56 PM

Tue, Aug 6

mckusick committed rS350653: Ignore UFS/FFS superblock check hash failures so as to allow a higher.
Ignore UFS/FFS superblock check hash failures so as to allow a higher
Tue, Aug 6, 6:29 PM
mckusick committed rS350651: A race condition existed between the time a UFS/FFS superblock check.
A race condition existed between the time a UFS/FFS superblock check
Tue, Aug 6, 6:10 PM

Wed, Jul 31

mckusick committed rS350490: When updating the user or group disk quotas for the return of inodes or.
When updating the user or group disk quotas for the return of inodes or
Wed, Jul 31, 10:45 PM
mckusick committed rS350460: MFC of 349589, 350070, 350071, 350096, and 350187.
MFC of 349589, 350070, 350071, 350096, and 350187
Wed, Jul 31, 12:16 AM

Tue, Jul 30

mckusick committed rS350459: MFC of 349032.
MFC of 349032
Tue, Jul 30, 11:50 PM

Fri, Jul 26

mckusick added a comment to D21039: Enable witness blessings..

This is long overdue. I would love to have these known LORs ignored.

Fri, Jul 26, 12:44 AM

Sat, Jul 20

mckusick committed rS350187: Treat any inode with bad content as unknown (i.e., ask if it should.
Treat any inode with bad content as unknown (i.e., ask if it should
Sat, Jul 20, 9:39 PM
mckusick committed rS350186: When running with journaled soft updates, some updated inodes were not.
When running with journaled soft updates, some updated inodes were not
Sat, Jul 20, 9:20 PM

Jul 18 2019

mckusick added a comment to D2844: Bail out of corrupt directory entries during boot.

I concur that taking evasive action is preferable to looping forever. However, we can do better than just bailing out. The kernel code checks for a bad d_reclen and if found skips up to the beginning of the next block within the directory using this code:

Jul 18 2019, 6:24 PM

Jul 17 2019

mckusick committed rS350096: The error reported in FS-14-UFS-3 can only happen on UFS/FFS.
The error reported in FS-14-UFS-3 can only happen on UFS/FFS
Jul 17 2019, 10:07 PM

Jul 16 2019

mckusick committed rS350071: Style..
Style.
Jul 16 2019, 11:39 PM
mckusick committed rS350070: When a process attempts to allocate space on a full filesystem, a.
When a process attempts to allocate space on a full filesystem, a
Jul 16 2019, 11:12 PM

Jul 3 2019

D18586: mount(8) does not handle "update" option in the fstab(5) correctly is now accepted and ready to land.

Looks good.

Jul 3 2019, 4:15 AM

Jul 1 2019

mckusick committed rS349589: Add a new "untrusted" option to the mount command. Its purpose.
Add a new "untrusted" option to the mount command. Its purpose
Jul 1 2019, 11:23 PM
Herald added a reviewer for D20786: Add option "untrusted" to mount(8): manpages.
Jul 1 2019, 11:23 PM

Jun 29 2019

D20695: Fix VOP_PUTPAGES(9) in regards to the use of VM_PAGER_CLUSTER_OK is now accepted and ready to land.

Looks good to go.

Jun 29 2019, 2:49 AM

Jun 28 2019

mckusick added a comment to D20786: Add option "untrusted" to mount(8).

Some of the checks that I am contemplating are expensive in that they may require extra I/O operations. Another possible thing is that I may spawn a process to run a full filesystem check before proceeding with the mount. These are not things that should or need to be done in the case of a trusted filesystem. I believe that the name "untrusted" well and succinctly describes this option.

Jun 28 2019, 5:52 PM

Jun 27 2019

mckusick created D20786: Add option "untrusted" to mount(8).
Jun 27 2019, 10:40 PM
D20695: Fix VOP_PUTPAGES(9) in regards to the use of VM_PAGER_CLUSTER_OK now requires changes to proceed.

Doing asynchronous writes prevents clustering. The correct fix is to say:

Jun 27 2019, 9:09 PM

Jun 24 2019

D20741: Remove references to splbio(). is now accepted and ready to land.

Simply deleting the comments about splbio is fine. It might be helpful to change the comment to say `Called with the soft update lock held.' In many places the lock ownership is asserted which may be sufficient, or perhaps the assertion should be added where it is not already there.

Jun 24 2019, 11:42 PM

Jun 20 2019

D20705: Add FIOBMAP2 ioctl is now accepted and ready to land.

Changing ufs_bamparray() to return errors rather than panicing is a helpful move forward.

Jun 20 2019, 6:08 AM
D20704: Add a VOP_BMAP(9) man page is now accepted and ready to land.

Looks good to me.

Jun 20 2019, 6:00 AM

Jun 17 2019

mckusick committed rS349155: MFC of 349032.
MFC of 349032
Jun 17 2019, 9:31 PM

Jun 14 2019

mckusick committed rS349032: Clarify that the -r and -R options can be used only to create level 0 dumps..
Clarify that the -r and -R options can be used only to create level 0 dumps.
Jun 14 2019, 6:10 AM

Jun 12 2019

mckusick added a comment to D18351: Add BIO_SPEEDUP.

Has this been resolved / committed?

Jun 12 2019, 8:48 PM
mckusick added a comment to D18586: mount(8) does not handle "update" option in the fstab(5) correctly.

Has this been resolved / committed?

Jun 12 2019, 8:47 PM

Jun 7 2019

mckusick committed rS348792: MFC of 348259.
MFC of 348259
Jun 7 2019, 10:25 PM

Jun 4 2019

mckusick accepted D20518: Add myself to committers-src.dot and calendar.freebsd.
Jun 4 2019, 7:49 PM

May 28 2019

mckusick committed rS348330: Add a missing bresle() in seldom-used error return..
Add a missing bresle() in seldom-used error return.
May 28 2019, 5:31 PM
mckusick committed rS348329: Convert use of UFS-specific #ifdef DEBUG to DIAGNOSTIC or INVARIANTS.
Convert use of UFS-specific #ifdef DEBUG to DIAGNOSTIC or INVARIANTS
May 28 2019, 4:32 PM

May 27 2019

mckusick committed rS348300: Add function name and line number debugging information to softupdates.
Add function name and line number debugging information to softupdates
May 27 2019, 6:23 AM

May 25 2019

mckusick committed rS348260: MFC of 348074.
MFC of 348074
May 25 2019, 12:22 AM
mckusick committed rS348259: When using the destroy option to shut down a nop GEOM module, I/O.
When using the destroy option to shut down a nop GEOM module, I/O
May 25 2019, 12:08 AM

May 24 2019

mckusick committed rS348256: MFC of 348074.
MFC of 348074
May 24 2019, 11:07 PM

May 21 2019

mckusick committed rS348074: This revision began as a simple change to eliminate an uninitialized warning.
This revision began as a simple change to eliminate an uninitialized warning
May 21 2019, 10:25 PM

May 20 2019

mckusick accepted D20304: NDFREE(): Fix unlocking for LOCKPARENT|LOCKLEAF and ndp->ni_dvp == ndp->ni_vp.

This change looks correct to me.

May 20 2019, 9:44 PM

May 10 2019

mckusick committed rS347475: MFC of 347064, 347066, and 347130.
MFC of 347064, 347066, and 347130
May 10 2019, 11:46 PM
mckusick committed rS347474: MFC of 347064, 347066, and 347130.
MFC of 347064, 347066, and 347130
May 10 2019, 11:45 PM

May 6 2019

mckusick committed rS347200: MFC of 346185.
MFC of 346185
May 6 2019, 7:16 PM
mckusick committed rS347199: MFC of 345758.
MFC of 345758
May 6 2019, 7:13 PM

May 4 2019

mckusick committed rS347130: Zero out the file directory entry metadata to reduce disk.
Zero out the file directory entry metadata to reduce disk
May 4 2019, 6:01 PM

May 3 2019

mckusick committed rS347066: This update eliminates a kernel stack disclosure bug in UFS/FFS.
This update eliminates a kernel stack disclosure bug in UFS/FFS
May 3 2019, 9:54 PM
mckusick committed rS347064: Simplify calculation of DIRECTSIZ. No functional change intended..
Simplify calculation of DIRECTSIZ. No functional change intended.
May 3 2019, 9:46 PM

Apr 27 2019

mckusick accepted D20066: Stop checking for TD_IDLETHREAD() in the buffer cache..

A useful cleanup.

Apr 27 2019, 12:49 PM

Apr 15 2019

mckusick committed rS346222: MFC of 345758.
MFC of 345758
Apr 15 2019, 12:10 PM
mckusick committed rS346221: MFC of 345758.
MFC of 345758
Apr 15 2019, 12:08 PM

Apr 13 2019

mckusick committed rS346185: Followup to -r344552 in which fsck_ffs checks for a size past the.
Followup to -r344552 in which fsck_ffs checks for a size past the
Apr 13 2019, 1:31 PM

Apr 9 2019

mckusick added a comment to D19599: Add a UFS-specific implementation for lseek(SEEK_DATA)..

Should this now be closed since it was resolved in D19811?

Apr 9 2019, 7:12 PM

Mar 31 2019

mckusick committed rS345758: When using the force option to shut down a memory-disk device,.
When using the force option to shut down a memory-disk device,
Mar 31 2019, 9:35 PM

Mar 29 2019

mckusick committed rS345667: MFC of 343536, 345077, and 345352.
MFC of 343536, 345077, and 345352
Mar 29 2019, 1:17 AM
mckusick committed rS345666: MFC of 343536, 345077, and 345352.
MFC of 343536, 345077, and 345352
Mar 29 2019, 1:15 AM

Mar 20 2019

mckusick committed rS345352: This is an additional and hopefully final fix for bug report 230962..
This is an additional and hopefully final fix for bug report 230962.
Mar 20 2019, 11:11 PM

Mar 17 2019

mckusick accepted D19599: Add a UFS-specific implementation for lseek(SEEK_DATA)..

This seems like a very useful improvement.

Mar 17 2019, 12:32 AM

Mar 16 2019

mckusick added a comment to D19598: Remove incorrect comments..

I would preface the actual condition "The nbp parameter is non-NULL when the mapping is for a block that contains data, one of an external data block, a direct block, or the final block in a chain of indirect blocks." before the correct clarification "If mapping an extended attribute block, nbp must point to a buffer for that block."

Mar 16 2019, 11:49 PM

Mar 12 2019

mckusick committed rS345077: This is an additional fix for bug report 230962. When using.
This is an additional fix for bug report 230962. When using
Mar 12 2019, 7:09 PM
mckusick committed rS345044: Add KASSERT to the softdep_disk_write_complete() function in the.
Add KASSERT to the softdep_disk_write_complete() function in the
Mar 12 2019, 12:10 AM

Mar 11 2019

mckusick committed rS345043: Give more complete information in INVARIANTS panic messages at end of.
Give more complete information in INVARIANTS panic messages at end of
Mar 11 2019, 11:54 PM
mckusick committed rS345037: Update the main loop in the flushbuflist() routine to properly select.
Update the main loop in the flushbuflist() routine to properly select
Mar 11 2019, 10:42 PM
mckusick committed rS345032: Augment the UFS filesystem specific print function (called by the.
Augment the UFS filesystem specific print function (called by the
Mar 11 2019, 10:05 PM
mckusick committed rS345029: Augment DDB "show buffer" command to print the buffer's referenced.
Augment DDB "show buffer" command to print the buffer's referenced
Mar 11 2019, 9:49 PM

Mar 7 2019

mckusick accepted D19437: explain fsck -f more in detail.

Looks good, thanks for clarifying -f.

Mar 7 2019, 12:15 AM
mckusick committed rS344864: MFC of 344731.
MFC of 344731
Mar 7 2019, 12:04 AM
mckusick committed rS344863: MFC of 344731.
MFC of 344731
Mar 7 2019, 12:02 AM
mckusick committed rS344861: MFC of 344552 and 344732.
MFC of 344552 and 344732
Mar 7 2019, 12:00 AM

Mar 6 2019

mckusick committed rS344860: MFC of 344552 and 344732.
MFC of 344552 and 344732
Mar 6 2019, 11:55 PM

Mar 3 2019

mckusick added a comment to D19437: explain fsck -f more in detail.

Your change looks good. I'll approve once you update the suggested mandoc refinement.

Mar 3 2019, 9:28 PM

Mar 2 2019

mckusick committed rS344732: Properly calculate the last used logical block of a file when checking.
Properly calculate the last used logical block of a file when checking
Mar 2 2019, 9:30 PM
mckusick committed rS344731: The size of the UFS soft-updates journal must be a multiple of the.
The size of the UFS soft-updates journal must be a multiple of the
Mar 2 2019, 9:23 PM

Mar 1 2019

mckusick added a comment to D19325: Do not panic if inode bitmap is corrupted..

I recently added the new error EINTEGRITY which is intended for use when a cylinder group or other filesystem structure has an integrity error. My initial plan is to use it for check-hash failures, but this is another good place to use it. It means that the callers of the functions that return this error need to be prepared to handle it. Specifically when allocating blocks or files trying to allocate from a different cylinder group. When deleting blocks or files, not immediately giving up, but trying to release all the remaining blocks of the file. A similar analysis would need to be used for this error (notably trying to allocate from a different cylinder group).

Mar 1 2019, 1:15 AM
mckusick added a comment to D18586: mount(8) does not handle "update" option in the fstab(5) correctly.

The addition to fstab.5 is helpful, but slightly incomplete in that it is not clear in what context the update keyword would be used.I would add text at the end of your new block that says something like:
The
.Dq update
option is typically used in conjuction with two
.Nm
files.
The first
.Nm
file is used to set up the initial set of file systems.
The second
.Nm
file is then run to update the initial set of file systems and
to add additional file systems.

Mar 1 2019, 12:54 AM

Feb 25 2019

mckusick committed rS344552: After a crash, a file that extends into indirect blocks may end up.
After a crash, a file that extends into indirect blocks may end up
Feb 25 2019, 9:58 PM

Feb 19 2019

mckusick committed rS344302: Ensure that inode updates are properly flushed out during the first.
Ensure that inode updates are properly flushed out during the first
Feb 19 2019, 8:12 PM

Jan 28 2019

mckusick added a comment to D18991: Add dash as a valid characterl to UFS label name.

Note that update of manual page date fell out on corrective update.

Jan 28 2019, 10:00 PM
mckusick accepted D18991: Add dash as a valid characterl to UFS label name.

Looks good.

Jan 28 2019, 9:56 PM
mckusick committed rS343538: MFC of 343449 and 343483.
MFC of 343449 and 343483
Jan 28 2019, 9:48 PM
mckusick committed rS343537: MFC of 343449 and 343483.
MFC of 343449 and 343483
Jan 28 2019, 9:46 PM
mckusick committed rS343536: This bug was introduced with the change to use softdep_bp_to_mp() in.
This bug was introduced with the change to use softdep_bp_to_mp() in
Jan 28 2019, 9:37 PM

Jan 27 2019

mckusick requested changes to D18991: Add dash as a valid characterl to UFS label name.

As noted, date at top of manual pages needs to be updated (which I will admit, I failed to do when I added underscores).

Jan 27 2019, 9:03 PM

Jan 26 2019

mckusick committed rS343483: Update tunefs and newfs error messages for the -L (volume label) option.
Update tunefs and newfs error messages for the -L (volume label) option
Jan 26 2019, 10:27 PM
mckusick committed rS343462: Expand DDB's set of printable soft dependency data structures. The.
Expand DDB's set of printable soft dependency data structures. The
Jan 26 2019, 5:35 AM

Jan 25 2019

mckusick committed rS343457: Add printing of b_ioflags to DDB `show buffer' command..
Add printing of b_ioflags to DDB `show buffer' command.
Jan 25 2019, 9:24 PM
mckusick committed rS343449: Allow tunefs to include '_' as a legal character in label names.
Allow tunefs to include '_' as a legal character in label names
Jan 25 2019, 8:07 PM

Jan 17 2019

mckusick committed rS343115: Truely fix #if defined broken in -r343111.
Truely fix #if defined broken in -r343111
Jan 17 2019, 4:27 PM
mckusick committed rS343114: Proper definition of elast3..
Proper definition of elast3.
Jan 17 2019, 3:42 PM
mckusick committed rS343113: Fix #if defined broken in -r343111.
Fix #if defined broken in -r343111
Jan 17 2019, 3:35 PM
mckusick committed rS343111: Create new EINTEGRITY error with message "Integrity check failed"..
Create new EINTEGRITY error with message "Integrity check failed".
Jan 17 2019, 6:36 AM
mckusick closed D18765: Add EINTEGRITY as new error number.
Jan 17 2019, 6:36 AM

Jan 11 2019

mckusick updated the diff for D18765: Add EINTEGRITY as new error number.

Update the intro(2) manual page to better reflect the meaning as suggested by imp, cem, etal.

Jan 11 2019, 11:11 PM

Jan 10 2019

mckusick added a comment to D18765: Add EINTEGRITY as new error number.
In D18765#401317, @imp wrote:

At a minimum EINTEGRITY is useful for mount since it allows the mount command to notify the user that the mount failed because of an integrity error which very likely can be fixed with a run of fsck versus an I/O error which probably cannot.

We should make mount return a different exit value for this perhaps... We could use that to automate a running of fsck in some cases.
EINTEGRITY means the end-to-end notion of what should be there isn't. This is similar to EIO (can't read the sector). The integrity error, though, means that some can't fail sanity check failed, which is a larger class of errors.

Jan 10 2019, 4:57 AM
mckusick added a comment to D18765: Add EINTEGRITY as new error number.

At a minimum EINTEGRITY is useful for mount since it allows the mount command to notify the user that the mount failed because of an integrity error which very likely can be fixed with a run of fsck versus an I/O error which probably cannot.

Jan 10 2019, 12:21 AM
mckusick updated the diff for D18765: Add EINTEGRITY as new error number.

Based on feedback from Ed Maste and Ed Schouten do not add EINTEGRITY to CloudABI. Rather map it to EINVAL as is done in Linux compatibility.

Jan 10 2019, 12:13 AM

Jan 9 2019

mckusick added a comment to D18765: Add EINTEGRITY as new error number.

It is useful to the application or user to distinguish EINTEGRITY from EIO. With EIO they know that the underlying media has failed and there is really nothing they can do. With EINTEGRITY the individual file has become corrupted, but if they still have its contents, they can remove it and rewrite it as the filesystem media itself is still working. Alternatively they can request the system administrator to run a check of the filesystem to attempt to clean up the file.

Jan 9 2019, 11:48 PM