Page MenuHomeFreeBSD

mckusick (Marshall Kirk McKusick)
User

Projects

User Details

User Since
Oct 24 2014, 7:17 PM (277 w, 4 d)

Recent Activity

Yesterday

mckusick committed rS358085: Additional KASSERTs to ensure the consistency of the soft updates.
Additional KASSERTs to ensure the consistency of the soft updates
Tue, Feb 18, 11:56 PM

Tue, Jan 28

mckusick added a comment to D23239: [uma-multipage 3/3] uma: grow slabs to enforce minimum memory efficiency.

The logic is easier for me to follow.

Tue, Jan 28, 7:38 PM

Thu, Jan 23

mckusick committed rS357034: MFC of 356714.
MFC of 356714
Thu, Jan 23, 6:24 AM
mckusick committed rS357033: MFC of 356714.
MFC of 356714
Thu, Jan 23, 6:21 AM
mckusick committed rS357032: MFC of 356763.
MFC of 356763
Thu, Jan 23, 6:18 AM
mckusick committed rS357031: MFC of 356763.
MFC of 356763
Thu, Jan 23, 6:11 AM
mckusick committed rS357030: MFC of 356739.
MFC of 356739
Thu, Jan 23, 6:06 AM
mckusick committed rS357029: MFC of 356739.
MFC of 356739
Thu, Jan 23, 6:03 AM

Wed, Jan 22

mckusick committed rS356965: MFC of 356627.
MFC of 356627
Wed, Jan 22, 1:31 AM
mckusick committed rS356964: MFC of 356627.
MFC of 356627
Wed, Jan 22, 1:29 AM

Jan 20 2020

mckusick added a comment to D23239: [uma-multipage 3/3] uma: grow slabs to enforce minimum memory efficiency.

I am really happy to see these changes as it will be especially helpful for vnodes that waste many Megabytes of space.
I concur with Jeff that the new code is difficult to follow, though do not have any suggestions on how to simplify it.

Jan 20 2020, 3:06 AM

Jan 17 2020

mckusick added a comment to D22973: Map ECKSUM and EFRAGS from ZFS onto real errnos.

After consulting with kib@ I have concluded that it is acceptable to MFC -r343111 to stable/12. You should MFC your change separately (i.e., in a second checkin).

Jan 17 2020, 9:41 PM

Jan 15 2020

mckusick committed rS356763: Peter Holm reports that his test that does an umount(8) on an active.
Peter Holm reports that his test that does an umount(8) on an active
Jan 15 2020, 6:53 PM

Jan 14 2020

mckusick committed rS356739: When sync'ing a mount point, the mount point's vnodes were scanned.
When sync'ing a mount point, the mount point's vnodes were scanned
Jan 14 2020, 10:28 PM

Jan 13 2020

mckusick accepted D23067: vfs: reimplement vlrureclaim to actually use LRU.

This change seems like an improvement over what we have now.

Jan 13 2020, 5:04 AM
mckusick accepted D23117: Use buf to send speedup.

I have never been a fan of short-circuiting the layers, so am fine with keeping them intact.

Jan 13 2020, 4:47 AM
mckusick accepted D22973: Map ECKSUM and EFRAGS from ZFS onto real errnos.

Looks good to go.

Jan 13 2020, 12:52 AM

Jan 11 2020

mckusick committed rS356627: When a read error occurs while fetching a directory block to delete.
When a read error occurs while fetching a directory block to delete
Jan 11 2020, 3:19 AM

Jan 10 2020

mckusick accepted D23050: Use humanize_number to format available and bad space sizes..

OK, looks good to go.

Jan 10 2020, 12:37 AM
mckusick added a comment to D22973: Map ECKSUM and EFRAGS from ZFS onto real errnos.

I agree with mac@ that it looks like EFRAGS is only in an unused code path. But it does not hurt to map it to a FreeBSD error in the event that the code path gets brought back to life.

Jan 10 2020, 12:35 AM

Jan 7 2020

mckusick added a comment to D22996: 5/7 ufs: use lazy list instead of active list for syncer.

I noted I don't know what guaratees are needed for quota files, thus I for safety I regressed the quota-induced scan to go over all vnodes in the mount point. Getting rid of the extra loop is a laudable goal of course, but I don't know how it should look like on a kernel with my patch. If the current places which put the vnode on the dirty list are sufficient that's great, but chances are excellent quota code needs extra calls

Jan 7 2020, 5:44 PM
mckusick added a comment to D23050: Use humanize_number to format available and bad space sizes..

My confusion is what "clusters" represent. Apparently a cluster is a 32KB block. Based on your clarification, I now agree with your calculation and printing of free space, but suggest that you clarify that clusters are 32KB blocks (either by replacing the word "clusters" with "32KB blocks", or if clusters is meaningful to administrators change it to "32KB clusters").

Jan 7 2020, 5:29 PM
mckusick added a comment to D22995: 4/7 vfs: add per-mount vnode lazy list and use it for deferred inactive + msync.

Overall I like these changes. I have one specific comment here and also a suggested change to qsync/qsyncvp to mitigate the increased cost of qsync().

Jan 7 2020, 12:27 AM
mckusick added a comment to D22994: 3/7 ufs: add a setter for inode i_flag field.

What is the reason for adding this macro to set i_flags?

Jan 7 2020, 12:18 AM
mckusick added a comment to D22996: 5/7 ufs: use lazy list instead of active list for syncer.

The heavy use of qsync() is in ffs_sync_lazy() and ffs_sync(). These should be using qsyncvp() in their loops rather than separately calling qsync() as show in my attached diff.


This change is independent of your changes, so I should just check it in as a separate change.

Jan 7 2020, 12:15 AM

Jan 6 2020

mckusick requested changes to D23050: Use humanize_number to format available and bad space sizes..

The current output is number of free blocks and number of bad blocks. You are changing it to number of free bytes and number of bad bytes.
Since fsck for all other filesystems reports blocks this is a non-standard semantic change, so I recommend that you restore the / 1024 to output block counts.
If you think that it is useful to have byte counts then should make it clear you are reporting bytes and not blocks (e.g., %sB free bytes).

Jan 6 2020, 10:23 PM
mckusick added a comment to D23049: fsck_msdosfs.8: document -M.

Might we remove it in the future? I.e., should we add a note that users should not rely on it remaining?

Jan 6 2020, 9:46 PM
mckusick accepted D23049: fsck_msdosfs.8: document -M.

This looks good.

Jan 6 2020, 9:45 PM
mckusick committed rS356428: MFC of 356063.
MFC of 356063
Jan 6 2020, 9:23 PM
mckusick committed rS356427: MFC of 356063.
MFC of 356063
Jan 6 2020, 9:14 PM
mckusick requested changes to D22973: Map ECKSUM and EFRAGS from ZFS onto real errnos.

Adding a new error number requires changes to a lot more files than just lib/libc/gen/errlst.c. See for example -r343111 when I added EINTEGRITY which touched 16 different files in the system. And that is just to add the base error. It then has to be added to every system call manual page for which it can be returned.

Jan 6 2020, 9:01 PM

Dec 25 2019

mckusick committed rS356067: MFC of 355995.
MFC of 355995
Dec 25 2019, 5:01 AM

Dec 24 2019

mckusick committed rS356063: When running fsck_ffs manually, do not ask:.
When running fsck_ffs manually, do not ask:
Dec 24 2019, 11:03 PM

Dec 22 2019

mckusick committed rS355995: Fix typo in hastd.8 manual page..
Fix typo in hastd.8 manual page.
Dec 22 2019, 1:23 AM

Dec 13 2019

mckusick added a comment to D18351: Add BIO_SPEEDUP.

A couple of minor nits noted inline.

Dec 13 2019, 1:18 AM

Dec 3 2019

mckusick committed rS355371: Currently the breadn_flags() and getblkx() interfaces are passed.
Currently the breadn_flags() and getblkx() interfaces are passed
Dec 3 2019, 11:07 PM

Nov 20 2019

mckusick committed rS354873: White space cleanup. No functional change..
White space cleanup. No functional change.
Nov 20 2019, 1:14 AM
mckusick committed rS354872: Add some KASSERTs. Reacquire a mutex after a kernel printf rather.
Add some KASSERTs. Reacquire a mutex after a kernel printf rather
Nov 20 2019, 1:10 AM

Oct 27 2019

mckusick committed rS354125: MFC of 354050.
MFC of 354050
Oct 27 2019, 4:11 AM
mckusick committed rS354124: MFC of 354050.
MFC of 354050
Oct 27 2019, 4:09 AM
mckusick committed rS354123: MFC of 353903.
MFC of 353903
Oct 27 2019, 3:47 AM
mckusick committed rS354122: MFC of 353903.
MFC of 353903
Oct 27 2019, 3:46 AM

Oct 24 2019

mckusick committed rS354050: After the unlink() of one name of a file with multiple links, a.
After the unlink() of one name of a file with multiple links, a
Oct 24 2019, 9:28 PM
mckusick committed rS354036: Soft updates needs to keep an on-disk linked list of inodes that.
Soft updates needs to keep an on-disk linked list of inodes that
Oct 24 2019, 7:47 PM

Oct 22 2019

mckusick committed rS353903: Replace an uninitialized variable with the correct element from the.
Replace an uninitialized variable with the correct element from the
Oct 22 2019, 10:24 PM

Oct 17 2019

mckusick accepted D22042: Abbreviate softdep lock names..

This request is entirely reasonable.

Oct 17 2019, 11:31 PM

Oct 11 2019

mckusick accepted D21897: mountroot: Run statfs after mounting devfs.

I concur that VFS_STATFS should be done here.

Oct 11 2019, 4:30 AM

Oct 4 2019

mckusick committed rS353099: Update ffs_getcg() function to accept a flags parameter to be passed.
Update ffs_getcg() function to accept a flags parameter to be passed
Oct 4 2019, 5:28 AM

Oct 1 2019

mckusick committed rS352947: MFC of 352453.
MFC of 352453
Oct 1 2019, 11:28 PM
mckusick committed rS352946: MFC of 352453.
MFC of 352453
Oct 1 2019, 11:27 PM

Sep 17 2019

mckusick committed rS352453: The VFS-level clustering code collects together sequential blocks.
The VFS-level clustering code collects together sequential blocks
Sep 17 2019, 5:45 PM

Sep 12 2019

mckusick accepted D21593: Add an option to gnop to allow rejecting I/O after allowing some through..

With the minor changes requested, looks good to me.

Sep 12 2019, 9:57 PM

Sep 9 2019

mckusick added a comment to D21560: Collection of fixes for exec/v_writecount handling..

What scenario would ever have v_writecount be less than zero?

Sep 9 2019, 4:12 AM

Aug 28 2019

D21412: Rework v_object lifecycle for vnodes. is now accepted and ready to land.

Removing the function is right approach. All looks good.

Aug 28 2019, 8:00 PM

Aug 27 2019

mckusick added inline comments to D21412: Rework v_object lifecycle for vnodes..
Aug 27 2019, 6:49 PM
mckusick added a comment to D21412: Rework v_object lifecycle for vnodes..

My inline comment seems to have been lost. I requested that ufs_prepare_reclaim() be made static.

Aug 27 2019, 6:47 PM
D21412: Rework v_object lifecycle for vnodes. now requires changes to proceed.

This change looks good to me modulo minor inline comment.

Aug 27 2019, 6:45 PM

Aug 17 2019

mckusick committed rS351164: MFC of 351002.
MFC of 351002
Aug 17 2019, 6:07 AM

Aug 15 2019

mckusick committed rS351098: Add missing comma in calendar.freebsd.
Add missing comma in calendar.freebsd
Aug 15 2019, 6:46 PM

Aug 14 2019

mckusick added a comment to D2844: Bail out of corrupt directory entries during boot.

Any progress on getting this done?

Aug 14 2019, 6:05 AM

Aug 13 2019

mckusick committed rS351002: Clarify comment that describes how the FS_METACKHASH is managed..
Clarify comment that describes how the FS_METACKHASH is managed.
Aug 13 2019, 8:56 PM

Aug 10 2019

mckusick committed rS350852: MFC of 350682.
MFC of 350682
Aug 10 2019, 11:08 PM
mckusick committed rS350851: MFC of 350682.
MFC of 350682
Aug 10 2019, 11:07 PM
mckusick committed rS350850: MFC of 350490.
MFC of 350490
Aug 10 2019, 11:03 PM

Aug 7 2019

mckusick committed rS350682: Correct the location of the first backup superblock in fsck_ffs.8..
Correct the location of the first backup superblock in fsck_ffs.8.
Aug 7 2019, 4:56 PM

Aug 6 2019

mckusick committed rS350653: Ignore UFS/FFS superblock check hash failures so as to allow a higher.
Ignore UFS/FFS superblock check hash failures so as to allow a higher
Aug 6 2019, 6:29 PM
mckusick committed rS350651: A race condition existed between the time a UFS/FFS superblock check.
A race condition existed between the time a UFS/FFS superblock check
Aug 6 2019, 6:10 PM

Jul 31 2019

mckusick committed rS350490: When updating the user or group disk quotas for the return of inodes or.
When updating the user or group disk quotas for the return of inodes or
Jul 31 2019, 10:45 PM
mckusick committed rS350460: MFC of 349589, 350070, 350071, 350096, and 350187.
MFC of 349589, 350070, 350071, 350096, and 350187
Jul 31 2019, 12:16 AM

Jul 30 2019

mckusick committed rS350459: MFC of 349032.
MFC of 349032
Jul 30 2019, 11:50 PM

Jul 26 2019

mckusick added a comment to D21039: Enable witness blessings..

This is long overdue. I would love to have these known LORs ignored.

Jul 26 2019, 12:44 AM

Jul 20 2019

mckusick committed rS350187: Treat any inode with bad content as unknown (i.e., ask if it should.
Treat any inode with bad content as unknown (i.e., ask if it should
Jul 20 2019, 9:39 PM
mckusick committed rS350186: When running with journaled soft updates, some updated inodes were not.
When running with journaled soft updates, some updated inodes were not
Jul 20 2019, 9:20 PM

Jul 18 2019

mckusick added a comment to D2844: Bail out of corrupt directory entries during boot.

I concur that taking evasive action is preferable to looping forever. However, we can do better than just bailing out. The kernel code checks for a bad d_reclen and if found skips up to the beginning of the next block within the directory using this code:

Jul 18 2019, 6:24 PM

Jul 17 2019

mckusick committed rS350096: The error reported in FS-14-UFS-3 can only happen on UFS/FFS.
The error reported in FS-14-UFS-3 can only happen on UFS/FFS
Jul 17 2019, 10:07 PM

Jul 16 2019

mckusick committed rS350071: Style..
Style.
Jul 16 2019, 11:39 PM
mckusick committed rS350070: When a process attempts to allocate space on a full filesystem, a.
When a process attempts to allocate space on a full filesystem, a
Jul 16 2019, 11:12 PM

Jul 3 2019

D18586: mount(8) does not handle "update" option in the fstab(5) correctly is now accepted and ready to land.

Looks good.

Jul 3 2019, 4:15 AM

Jul 1 2019

mckusick committed rS349589: Add a new "untrusted" option to the mount command. Its purpose.
Add a new "untrusted" option to the mount command. Its purpose
Jul 1 2019, 11:23 PM
Herald added a reviewer for D20786: Add option "untrusted" to mount(8): manpages.
Jul 1 2019, 11:23 PM

Jun 29 2019

D20695: Fix VOP_PUTPAGES(9) in regards to the use of VM_PAGER_CLUSTER_OK is now accepted and ready to land.

Looks good to go.

Jun 29 2019, 2:49 AM

Jun 28 2019

mckusick added a comment to D20786: Add option "untrusted" to mount(8).

Some of the checks that I am contemplating are expensive in that they may require extra I/O operations. Another possible thing is that I may spawn a process to run a full filesystem check before proceeding with the mount. These are not things that should or need to be done in the case of a trusted filesystem. I believe that the name "untrusted" well and succinctly describes this option.

Jun 28 2019, 5:52 PM

Jun 27 2019

mckusick created D20786: Add option "untrusted" to mount(8).
Jun 27 2019, 10:40 PM
D20695: Fix VOP_PUTPAGES(9) in regards to the use of VM_PAGER_CLUSTER_OK now requires changes to proceed.

Doing asynchronous writes prevents clustering. The correct fix is to say:

Jun 27 2019, 9:09 PM

Jun 24 2019

D20741: Remove references to splbio(). is now accepted and ready to land.

Simply deleting the comments about splbio is fine. It might be helpful to change the comment to say `Called with the soft update lock held.' In many places the lock ownership is asserted which may be sufficient, or perhaps the assertion should be added where it is not already there.

Jun 24 2019, 11:42 PM

Jun 20 2019

D20705: Add FIOBMAP2 ioctl is now accepted and ready to land.

Changing ufs_bamparray() to return errors rather than panicing is a helpful move forward.

Jun 20 2019, 6:08 AM
D20704: Add a VOP_BMAP(9) man page is now accepted and ready to land.

Looks good to me.

Jun 20 2019, 6:00 AM

Jun 17 2019

mckusick committed rS349155: MFC of 349032.
MFC of 349032
Jun 17 2019, 9:31 PM

Jun 14 2019

mckusick committed rS349032: Clarify that the -r and -R options can be used only to create level 0 dumps..
Clarify that the -r and -R options can be used only to create level 0 dumps.
Jun 14 2019, 6:10 AM

Jun 12 2019

mckusick added a comment to D18351: Add BIO_SPEEDUP.

Has this been resolved / committed?

Jun 12 2019, 8:48 PM
mckusick added a comment to D18586: mount(8) does not handle "update" option in the fstab(5) correctly.

Has this been resolved / committed?

Jun 12 2019, 8:47 PM

Jun 7 2019

mckusick committed rS348792: MFC of 348259.
MFC of 348259
Jun 7 2019, 10:25 PM

Jun 4 2019

mckusick accepted D20518: Add myself to committers-src.dot and calendar.freebsd.
Jun 4 2019, 7:49 PM

May 28 2019

mckusick committed rS348330: Add a missing bresle() in seldom-used error return..
Add a missing bresle() in seldom-used error return.
May 28 2019, 5:31 PM
mckusick committed rS348329: Convert use of UFS-specific #ifdef DEBUG to DIAGNOSTIC or INVARIANTS.
Convert use of UFS-specific #ifdef DEBUG to DIAGNOSTIC or INVARIANTS
May 28 2019, 4:32 PM

May 27 2019

mckusick committed rS348300: Add function name and line number debugging information to softupdates.
Add function name and line number debugging information to softupdates
May 27 2019, 6:23 AM

May 25 2019

mckusick committed rS348260: MFC of 348074.
MFC of 348074
May 25 2019, 12:22 AM
mckusick committed rS348259: When using the destroy option to shut down a nop GEOM module, I/O.
When using the destroy option to shut down a nop GEOM module, I/O
May 25 2019, 12:08 AM

May 24 2019

mckusick committed rS348256: MFC of 348074.
MFC of 348074
May 24 2019, 11:07 PM

May 21 2019

mckusick committed rS348074: This revision began as a simple change to eliminate an uninitialized warning.
This revision began as a simple change to eliminate an uninitialized warning
May 21 2019, 10:25 PM