Page MenuHomeFreeBSD

mckusick (Marshall Kirk McKusick)
User

Projects

User Details

User Since
Oct 24 2014, 7:17 PM (313 w, 6 d)

Recent Activity

Tue, Oct 27

mckusick added a comment to D26964: ufs softdep: end-of-life truncate should depend on dirent write.

You note that ``If we then crashed before the dirent write, we would recover with a state where the file was still linked, but had been truncated to zero. The resulting state could be considered corruption.'' The filesystem is not corrupted in the sense that it needs fsck to be run to clean it up. We simply end up with an unexpected result.

Tue, Oct 27, 12:55 AM

Sun, Oct 25

mckusick committed rS367045: Use proper type (ino_t) for inode numbers to avoid improper sign extention.
Use proper type (ino_t) for inode numbers to avoid improper sign extention
Sun, Oct 25, 9:04 PM
mckusick committed rS367035: Filesystem utilities that modify the filesystem (growfs(8), tunefs(8),.
Filesystem utilities that modify the filesystem (growfs(8), tunefs(8),
Sun, Oct 25, 1:36 AM
mckusick committed rS367034: Various new check-hash checks have been added to the UFS filesystem.
Various new check-hash checks have been added to the UFS filesystem
Sun, Oct 25, 12:44 AM

Fri, Oct 23

mckusick added a comment to D26912: RFC: Disk I/O priority support.

It would be trivial to request high priority for synchronous writes in bwrite() and if desired synchronous reads in bread(). That would have effects for several filesystems.

Fri, Oct 23, 6:16 AM · cam

Sun, Oct 18

mckusick added a comment to D26136: Handle LoR in flush_pagedep_deps()..

Added a couple of inline comments.

Sun, Oct 18, 10:46 PM

Sat, Oct 3

mckusick accepted D26596: ufs: restore uniqueness of st_dev.
Sat, Oct 3, 8:27 PM

Sep 26 2020

mckusick committed rS366187: MFS of 366163 from stable/12 which is MFC of 365992 from head..
MFS of 366163 from stable/12 which is MFC of 365992 from head.
Sep 26 2020, 9:46 PM

Sep 25 2020

mckusick added a comment to D26511: Do not leak B_BARRIER..
In D26511#591360, @kib wrote:

The block being written with the barrier is a newly allocated block of inodes. The write is done asynchronously and the cylinder group is then updated to reflect that the additional inodes are available. The reason for the barrier is so that the cylinder group buffer with the newly expanded inode map cannot be written before the newly allocated set of inodes.

Since the incore cylinder group includes the newly created inodes, some other thread can come along and try to use one of those newly allocated inodes. but, it will block on the inode buffer until its write has completed.

The bug in this instance is that there is an assumption that the write cannot fail. Clearly this is a bad assumption. So, the correct fix is to not depend on the barrier write, but rather to create a callback that updates the cylinder group once the write of the new inodes has completed successfully.

In the specific case of kostik1316, doing that would deadlock the machine. Problem is that CoW write returned ENOSPC, which means that there is no way to correctly free space on the volume. I am not sure what do to there. Most likely any other write would also return ENOSPC, so in fact consistency of the volume is not too badly broken if we just fail there. If we start tracking the write as a dependency for cg write, then all that buffers add to the dirty space which eventually hang buffer subsystem.

I believe (based on Peter testing) that just erroring write allows us to unmount.

What we are trying to do where the barrier write is being used in UFS is expand the number of available inodes. It is OK to abandon the write of the zero'ed out inode block as the expansion can be put off to later. But, we must not update the cylinder group to say that these new inodes are available if we have not been able to zero them out. As it is currently written, the cylinder group is updated but the on-disk inodes are not zero'ed out. If the unmount succeeds in writing out the dirty buffers we will end up with a corrupted filesystem because fsck_ffs will try to check the non-zero'ed out inodes and raise numerous errors trying to correct the inconsistencies that arise from the random data in the uninitialzed inode block.

Sep 25 2020, 6:36 PM
mckusick committed rS366163: MFC of 365992.
MFC of 365992
Sep 25 2020, 5:14 PM
mckusick added a comment to D26511: Do not leak B_BARRIER..
In D26511#590951, @kib wrote:
In D26511#590229, @kib wrote:

As long as the buffer remains locked until it is successfully written, this should be fine.

Sorry, I do not fully understand you note. Do you mean that it is fine to have B_BARRIER set as far as buffer is not unlocked ? If not, could you please clarify.

We are depending on this being written before it can be used. If it were unlocked, then some other thread could get it and make use of it. See comment above use of babarrierwrite in sys/ufs/ffs/ffs_alloc.c.

I still do not understand what do you mean by 'use'. In the kostik1316 dump, most probable scenario was that babarrierwrite() for the inode block failed with ENOSPC, and then bufdone() does brelse() on the buffer. So it is unlocked, but this is somewhat unrelated to the issue of leaking B_BARRIER.

Sep 25 2020, 1:03 AM

Sep 23 2020

mckusick added a comment to D26511: Do not leak B_BARRIER..
In D26511#590229, @kib wrote:

As long as the buffer remains locked until it is successfully written, this should be fine.

Sorry, I do not fully understand you note. Do you mean that it is fine to have B_BARRIER set as far as buffer is not unlocked ? If not, could you please clarify.

We are depending on this being written before it can be used. If it were unlocked, then some other thread could get it and make use of it. See comment above use of babarrierwrite in sys/ufs/ffs/ffs_alloc.c.

Sep 23 2020, 10:25 PM

Sep 22 2020

mckusick committed rS365992: Add missing cylinder group check-hash updates when doing large expansions.
Add missing cylinder group check-hash updates when doing large expansions
Sep 22 2020, 3:57 AM

Sep 21 2020

mckusick accepted D26511: Do not leak B_BARRIER..

As long as the buffer remains locked until it is successfully written, this should be fine.

Sep 21 2020, 10:38 PM
mckusick committed rS365971: MFC of 365700.
MFC of 365700
Sep 21 2020, 7:26 PM

Sep 19 2020

mckusick committed rS365919: Update the libufs cgget() and cgput() interfaces to have a similar.
Update the libufs cgget() and cgput() interfaces to have a similar
Sep 19 2020, 10:49 PM
mckusick committed rS365912: The fsdb(8) utility uses the fsck_ffs(8) disk I/O interfaces, so.
The fsdb(8) utility uses the fsck_ffs(8) disk I/O interfaces, so
Sep 19 2020, 8:06 PM

Sep 13 2020

mckusick committed rS365700: In the newfs(8) utility, use the more appropriate sbwrite() and cgwrite().
In the newfs(8) utility, use the more appropriate sbwrite() and cgwrite()
Sep 13 2020, 10:58 PM

Sep 12 2020

mckusick accepted D26375: Move td_softdep_cleanup() from userret() to ast().

This change looks reasonable to me as at least for amd64 every path out of the kernel appears to check TDF_ASTPENDING and calls ast() if set.

Sep 12 2020, 6:14 AM

Sep 1 2020

mckusick accepted D26289: Remove risky compatability with old kernels..

It was a horrible hack at the time and should have been tossed decades ago.

Sep 1 2020, 11:17 PM

Aug 31 2020

mckusick committed rS364983: MFC of 364895.
MFC of 364895
Aug 31 2020, 5:25 AM

Aug 29 2020

mckusick added a comment to D25969: Events for mount, remount and umount in devdAdd remount vfs event, publish mount, remount and unmount events..

A new review? If so, I suggest that you close this one and give a pointer to the new one.

Aug 29 2020, 10:02 PM

Aug 27 2020

mckusick committed rS364895: Add a comment to clarify when and why cached names are deleted.
Add a comment to clarify when and why cached names are deleted
Aug 27 2020, 10:15 PM
mckusick added a comment to D25969: Events for mount, remount and umount in devdAdd remount vfs event, publish mount, remount and unmount events..

What is the status with this change?

Aug 27 2020, 10:01 PM

Aug 26 2020

mckusick added a comment to D26136: Handle LoR in flush_pagedep_deps()..

The get_parent_vp() function seems to be handling two different problems.
In its first instance it is dealing with locking its parent. Here we already have the function vn_vget_ino() which presumably could be used to handle this situation.
In its second and third instances it is avoiding a LOR of acquiring an inode lock while holding a buffer lock. Here we need a function like the proposed get_parent_vp(). However, we will no longer need the first (vp) argument as we are acquiring a child inode so do not have to release the already held parent inode before acquiring the child inode.

Aug 26 2020, 12:07 AM

Aug 15 2020

mckusick committed rS364262: Use the sbput() function to write alternate superblocks so that.
Use the sbput() function to write alternate superblocks so that
Aug 15 2020, 9:40 PM

Aug 8 2020

mckusick accepted D25969: Events for mount, remount and umount in devdAdd remount vfs event, publish mount, remount and unmount events..

This change will provide the interface that we will need to notify daemon processes for our forcible unmount and forcible downgrade to read-only as well as re-establishment of read-write after a successful background fsck.

Aug 8 2020, 4:19 AM

Jul 22 2020

mckusick accepted D25759: Avoid reading one byte before the path buffer..

I concur with the proposed change and also agree that cem's suggestion is a good one.

Jul 22 2020, 4:32 AM

Jul 21 2020

mckusick committed rS363405: MFC of 362369 (by Lorenzo Salvadore) and 363192.
MFC of 362369 (by Lorenzo Salvadore) and 363192
Jul 21 2020, 11:23 PM

Jul 14 2020

mckusick closed D25660: Update to D25266 bin/ps: Make the rtprio option actually show realtime priorities.
Jul 14 2020, 6:57 PM
mckusick committed rS363192: Update to D25266, bin/ps: Make the rtprio option actually show.
Update to D25266, bin/ps: Make the rtprio option actually show
Jul 14 2020, 6:57 PM
mckusick requested review of D25660: Update to D25266 bin/ps: Make the rtprio option actually show realtime priorities.
Jul 14 2020, 7:31 AM

Jul 13 2020

mckusick requested changes to D25599: vfs_syscalls: Call VFS_SYNC with MNT_WAIT argument..

This should not be done as written as it can cause a denial of service (infinite loop) as described in my previous comment.

Jul 13 2020, 11:10 PM
mckusick closed D2068: add mahrens as committer.

Done.

Jul 13 2020, 11:08 PM

Jul 10 2020

mckusick added a comment to D25599: vfs_syscalls: Call VFS_SYNC with MNT_WAIT argument..

If data is being written to the filesystem faster than the disk can write it then a sync with MNT_WAIT will never finish. The only safe way to use sync with MNT_WAIT is to first suspend the filesystem to create a finite number of write operations that need to be done.

Jul 10 2020, 9:15 PM

Jul 9 2020

mckusick committed rS363056: MFC of 362560.
MFC of 362560
Jul 9 2020, 7:12 PM

Jul 6 2020

mckusick added a comment to D25579: (lookup 4) ufs: add support for lockless lookup.

I cannot speak to the correctness of the whole patch, but looking over D25577, D25578, and this one, D25579, I see nothing that looks incorrect.

Jul 6 2020, 11:03 PM

Jun 30 2020

mckusick requested changes to D25073: Define M_UFSMNT in ffs_subr.c.

Per the above commentary, this change should be withdrawn.

Jun 30 2020, 6:25 PM

Jun 24 2020

mckusick added a comment to D25073: Define M_UFSMNT in ffs_subr.c.

Having read Chuck's argument, I agree with it. I was thinking that the g_label_ufs.c routines passed in M_UFSMNT as their malloc type. But they do not. They use M_GEOM malloc type. So there is no need for them to have an definition for M_UFSMNT.

Jun 24 2020, 9:36 PM
mckusick added a comment to D25403: Fix fallout from the emancipation of dump(8) workers.

Thanks for this cleanup. I found the previous transformation grating for the reasons that you listed.

Jun 24 2020, 4:34 PM
mckusick accepted D25073: Define M_UFSMNT in ffs_subr.c.

This looks like a reasonable change to me.

Jun 24 2020, 6:22 AM
mckusick added a comment to D25404: ufs: a fix for sync write.

I believe that the existing test already has this covered. The test (resid > uio->uio_resid) is checking that any data has been written. In the typical case this is at the end of the file and the size will have increased. But if the write was in the middle of a file filling in a hole then this test will catch that and cause the inode to be written.

Jun 24 2020, 6:02 AM

Jun 23 2020

mckusick committed rS362561: Optimize g_journal's superblock update by noting that the summary.
Optimize g_journal's superblock update by noting that the summary
Jun 23 2020, 9:44 PM
mckusick committed rS362560: Correctly describe the return values for the libufs library sbget().
Correctly describe the return values for the libufs library sbget()
Jun 23 2020, 9:37 PM
mckusick committed rS362559: The libufs library needs to track and free the new fs_si structure.
The libufs library needs to track and free the new fs_si structure
Jun 23 2020, 9:28 PM
mckusick committed rS362558: Align comments in struct uufsd structure. No semantic change..
Align comments in struct uufsd structure. No semantic change.
Jun 23 2020, 9:17 PM

Jun 19 2020

mckusick committed rS362418: Allocate an fs_summary_info structure when creating a UFS filesystem.
Allocate an fs_summary_info structure when creating a UFS filesystem
Jun 19 2020, 11:33 PM
mckusick added a comment to D25266: bin/ps: Make the rtprio option actually show realtime priorities.

Interesting that I never added myself to the committers-src.dot file.
For reference, the file that actually controls access to doing src commits is /usr/src/svnadmin/conf/access.
For interesting statistics on the history of commits, fetch these files:

fetch https://people.freebsd.org/~rodrigo/commits-base.txt
fetch https://people.freebsd.org/~rodrigo/commits-doc.txt
fetch https://people.freebsd.org/~rodrigo/commits-ports.txt

I agree that there should be documentation of MFC guidelines somewhere.
For a change of this sort an MFC delay in the range of 1-2 weeks is reasonable.

Jun 19 2020, 3:56 AM
mckusick committed rS362359: The binary representation of the superblock (the fs structure) is written.
The binary representation of the superblock (the fs structure) is written
Jun 19 2020, 1:04 AM
mckusick committed rS362358: Move the pointers stored in the superblock into a separate.
Move the pointers stored in the superblock into a separate
Jun 19 2020, 1:03 AM

Jun 18 2020

mckusick accepted D25266: bin/ps: Make the rtprio option actually show realtime priorities.

Your argument has pursuaded me. Looks good to go.

Jun 18 2020, 10:04 PM
mckusick added a comment to D25266: bin/ps: Make the rtprio option actually show realtime priorities.

One other suggestion is to change "normal" to "timeshare" or perhaps "timeshr" as that name is more descriptive of what is being reported.

Jun 18 2020, 9:19 AM
mckusick added a comment to D25285: fix kernel linking without FFS.

On further though, I agree with you that ffs_subr.c should only be shared functions.

Jun 18 2020, 9:19 AM

Jun 16 2020

mckusick added a comment to D25266: bin/ps: Make the rtprio option actually show realtime priorities.

This looks like a big improvement. My one suggestion is that you add the priority value for normal (as level - PRI_MIN_TIMESHARE).

Jun 16 2020, 10:31 PM
mckusick added a comment to D25285: fix kernel linking without FFS.

Rather than moving all these functions from a file in which they logically belong to one in which they do not, how about we just put #ifdef FFS around the _KERNEL part. This produces minimal changes, leaves things where they logically belong, and reduces the size of the extra copy of ffs_subr.o.

Jun 16 2020, 10:21 PM

Jun 6 2020

mckusick committed rS361875: Clear the IN_SIZEMOD and IN_IBLKDATA flags only when doing a.
Clear the IN_SIZEMOD and IN_IBLKDATA flags only when doing a
Jun 6 2020, 8:18 PM

Jun 5 2020

mckusick committed rS361814: Further evaluation of the POSIX spec for fdatasync() shows that it.
Further evaluation of the POSIX spec for fdatasync() shows that it
Jun 5 2020, 1:01 AM

Jun 4 2020

mckusick committed rS361801: Two additional places that need to identify IN_IBLKDATA..
Two additional places that need to identify IN_IBLKDATA.
Jun 4 2020, 6:35 PM
mckusick accepted D25072: UFS: write inode block for fdatasync(2) if pointers in inode where allocated.

This looks good to go.

Jun 4 2020, 4:01 AM

Jun 3 2020

mckusick added a comment to D25072: UFS: write inode block for fdatasync(2) if pointers in inode where allocated.

Overall this looks like a correct change. As noted in my inline comment, I do not think that you should change the semantics of waitfor.

Jun 3 2020, 11:41 PM

May 19 2020

mckusick accepted D24088: handle disk I/O errors in FFS with softdep enabled..

Finally, this looks good to go.

May 19 2020, 5:41 AM

May 15 2020

mckusick accepted D24596: vfs: add restrictions to read(2) of a directory.

I believe that this change is correct as it stands.

May 15 2020, 10:42 PM
mckusick added a comment to D24088: handle disk I/O errors in FFS with softdep enabled..

Peter,
Can you run one more test run over this code just to be sure that it patches cleanly and that none of our final changes broke anything?

May 15 2020, 8:16 PM

May 13 2020

mckusick accepted D24596: vfs: add restrictions to read(2) of a directory.

This looks good to me. I am fine with not supporting the old behavior.

May 13 2020, 10:17 PM

May 9 2020

mckusick committed rS360835: MFC of 356666.
MFC of 356666
May 9 2020, 5:04 AM

May 3 2020

mckusick added a comment to D24652: Non-transparent superpages support..

This rather long block is a summary of the discussion that Kostik
and I had in email. Dropping it in here so that it is part of the
public record. Regular font are my comments; italics font are
Kostik's response to my comments.

May 3 2020, 6:11 AM
mckusick added a comment to D24596: vfs: add restrictions to read(2) of a directory.

As imp has noted, we have had readdir(3) and the getdirents(2) for nearly 40 years and many filesystems do not support directly reading directories. While I personally still use od(1) to inspect UFS directories, that is a pretty lame reason for keeping the functionality. And returning EISDIR will make us more compatible with Linux and remain in compliance with POSIX. So, all told I am in favor of this change. Adding a sysctl to revert to the old behavior seems reasonable so long as it defaults to the new (EISDIR) behavior.

May 3 2020, 12:28 AM

Apr 20 2020

mckusick accepted D24484: Retire two unused background fsck sysctls..

I concur with this change.
It should be MFC'ed to stable/12 and stable/11.

Apr 20 2020, 8:00 PM

Apr 15 2020

mckusick committed rS359946: MFC of 359627.
MFC of 359627
Apr 15 2020, 12:18 AM

Apr 10 2020

mckusick committed rS359790: Inode check-hash errors were being reported after system crashes..
Inode check-hash errors were being reported after system crashes.
Apr 10 2020, 11:58 PM
mckusick committed rS359789: Add an inode check-hash verification when running the journalled.
Add an inode check-hash verification when running the journalled
Apr 10 2020, 11:49 PM

Apr 9 2020

mckusick committed rS359760: Fixing the soft update macros in -r359612 triggered a previously.
Fixing the soft update macros in -r359612 triggered a previously
Apr 9 2020, 11:51 PM
mckusick committed rS359759: When running with a kernel compiled with DEBUG_LOCKS, before.
When running with a kernel compiled with DEBUG_LOCKS, before
Apr 9 2020, 11:42 PM
mckusick committed rS359738: Revert MFC of 359612 due to reported problems..
Revert MFC of 359612 due to reported problems.
Apr 9 2020, 6:36 AM
mckusick committed rS359737: Revert MFC of 359612 due to reported problems..
Revert MFC of 359612 due to reported problems.
Apr 9 2020, 6:33 AM

Apr 6 2020

mckusick committed rS359670: MFC of 359612.
MFC of 359612
Apr 6 2020, 10:15 PM
mckusick committed rS359669: MFC of 359612.
MFC of 359612
Apr 6 2020, 10:12 PM
mckusick committed rS359668: Revert -r359612 as it can cause other panics..
Revert -r359612 as it can cause other panics.
Apr 6 2020, 8:23 PM

Apr 4 2020

mckusick committed rS359627: Clean up global variable declarations in the dump and restore.
Clean up global variable declarations in the dump and restore
Apr 4 2020, 12:57 AM
mckusick closed D24210: dump/restore: define variables in exactly one compilation unit.
Apr 4 2020, 12:57 AM

Apr 3 2020

mckusick abandoned D24209: dumprestore: extern the instance of union u_spcl.

Changes moved to D24210.

Apr 3 2020, 11:51 PM
mckusick commandeered D24209: dumprestore: extern the instance of union u_spcl.

These changes will be done as part of D24210 so that all the updates to make the dump and restore utilities compile with -fno-common are in one place.

Apr 3 2020, 11:50 PM
mckusick updated the diff for D24210: dump/restore: define variables in exactly one compilation unit.

Rather than using EXTERN, place each global declaration into the file in which it is primarily used.

Apr 3 2020, 11:48 PM
mckusick commandeered D24210: dump/restore: define variables in exactly one compilation unit.

Taking over with Kyle Evans blessing.

Apr 3 2020, 10:20 PM
mckusick committed rS359613: When shrinking the size of a directory it is sometimes necessary to.
When shrinking the size of a directory it is sometimes necessary to
Apr 3 2020, 8:44 PM
mckusick committed rS359612: Convert DOINGSOFTDEP, MOUNTEDSOFTDEP, DOINGSUJ, and MOUNTEDSUJ to being.
Convert DOINGSOFTDEP, MOUNTEDSOFTDEP, DOINGSUJ, and MOUNTEDSUJ to being
Apr 3 2020, 8:31 PM

Mar 31 2020

mckusick accepted D24209: dumprestore: extern the instance of union u_spcl.

Now looks good.

Mar 31 2020, 9:32 PM
mckusick added a comment to D24210: dump/restore: define variables in exactly one compilation unit.

Rather than doing EXTERN, move the explicit declarations into file as this:
mapsize - main.c
usedinomap - main.c
dumpdirmap - main.c
dumpinomap - main.c
disk - main.c
tape - main.c
popenout - main.c
dumpdates - itime.c
temp - unused, remove from dump.h, main.c, and definition of _PATH_DTMP from pathnames.h
lastlevel - itime.c
level - main.c
uflag - main.c
diskfd - main.c
tapefd - tape.c
pipeout - main.c
curino - tape.c
newtape - tape.c
density - already declared in main.c
tapesize - main.c
tsize - main.c
asize - tape.c
etapes - main.c
nonodump - main.c
unlimited - main.c
cachesize - already declared in main.c
rsync_friendly - main.c
notify - already declared in main.c
blockswritten - already declared in main.c
tapeno - already declared in main.c
tstart_writing - main.c
tend_writing - main.c
passno - main.c
sblock - main.c
dev_bsize - already declared in main.c
dev_bshift - main.c
tp_bshift - main.c
dumpdates - leave in itime.c
nddates - leave in itime.c
If you would like me to take over this project, I am willing to do so.

Mar 31 2020, 9:31 PM

Mar 30 2020

mckusick accepted D24210: dump/restore: define variables in exactly one compilation unit.

I prefer just using extern and then declaring the actual variables in the function in which they are most prominent, but using EXTERN as you have done does work fine.

Mar 30 2020, 10:42 PM
mckusick requested changes to D24209: dumprestore: extern the instance of union u_spcl.

While u_spcl is used only in dump/tape.c, it is used in four different files in restore and is not meant to be a separate instance in each one. So, you will have to make it an extern in the header file and then declare it in dump/tape.c and restore/dump.c. I prefer that you do it that way as opposed to the much uglier EXTERN approach.

Mar 30 2020, 10:40 PM
mckusick accepted D24168: Document EINTEGRITY errors for many system calls..

This looks complete. I had missed the VOP_* manual pages, good catch.
I am happy to have you clean up the duplicate EIOs.
Thanks for doing this.

Mar 30 2020, 12:29 AM

Mar 24 2020

mckusick requested changes to D24168: Document EINTEGRITY errors for many system calls..

While read(2) and write(2) are the most likely system calls to return EINTEGRITY, really any system call that accesses a filesystem can potentially return EINTEGRITY. Using the metric that if it can return EIO, then it can now return EINTEGRITY leads to this list of system calls needing EINTEGRITY added: access.2, acct.2, bind.2, chdir.2, chflags.2, chmod.2, chown.2, chroot.2, copy_file_range.2, execve.2, fhlink.2, fhreadlink.2, fsync.2, getdirentries.2, getfh.2, getfsstat.2, intro.2, ktrace.2, link.2, lio_listio.2, mkdir.2, mkfifo.2, mknod.2, mount.2, msync.2, open.2, pathconf.2, posix_fallocate.2, quotactl.2, readlink.2, rename.2, rmdir.2, sendfile.2, stat.2, statfs.2, swapon.2, symlink.2, truncate.2, undelete.2, unlink.2, utimensat.2, and utimes.2.

Mar 24 2020, 12:19 AM

Mar 20 2020

mckusick accepted D24131: Use the newer EINTEGRITY error when authentication fails..

This is a good example of a place that where EINTEGRITY is intended to be used.
At the moment mount(2) is the only system call that lists EINTEGRITY as a possible error. If your change is going to cause EINTEGRITY to be returned to other system calls (like read(2) or wirite(2)) then you should add it to their list of possible error returns.

Mar 20 2020, 11:18 PM

Mar 17 2020

mckusick accepted D24087: Add fsck_flags config option.

Looks good to me.

Mar 17 2020, 11:33 PM
mckusick requested changes to D24087: Add fsck_flags config option.

With the above suggested changes, I agree with this proposal.

Mar 17 2020, 4:45 AM

Mar 11 2020

mckusick committed rS358899: When mounting a UFS filesystem, return EINTEGRITY rather than EIO.
When mounting a UFS filesystem, return EINTEGRITY rather than EIO
Mar 11 2020, 9:00 PM

Feb 27 2020

mckusick accepted D23787: add "mntfs" private vnodes for file systems to access their storage safely.

I am happy with this revision.

Feb 27 2020, 6:07 AM

Feb 18 2020

mckusick committed rS358085: Additional KASSERTs to ensure the consistency of the soft updates.
Additional KASSERTs to ensure the consistency of the soft updates
Feb 18 2020, 11:56 PM

Jan 28 2020

mckusick added a comment to D23239: [uma-multipage 3/3] uma: grow slabs to enforce minimum memory efficiency.

The logic is easier for me to follow.

Jan 28 2020, 7:38 PM

Jan 23 2020

mckusick committed rS357034: MFC of 356714.
MFC of 356714
Jan 23 2020, 6:24 AM