Page MenuHomeFreeBSD
Feed Advanced Search

Sun, Nov 20

mckusick committed rGbca262f0f351: Fix for tunefs(8) unable to add a UFS/FFS soft update journal. (authored by mckusick).
Fix for tunefs(8) unable to add a UFS/FFS soft update journal.
Sun, Nov 20, 5:15 PM

Fri, Nov 18

mckusick added a comment to D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.

@ota_j.email.ne.jp:
Is this ready to be committed?

Fri, Nov 18, 10:28 PM
mckusick committed rGc2a74ca2c3d9: Fix to b999366aab4e for compilation on i386. (authored by mckusick).
Fix to b999366aab4e for compilation on i386.
Fri, Nov 18, 5:07 AM
mckusick committed rG37ddf393f85b: stand: Compile out the extensive superblock diagnostic messages for BIOS loader (authored by imp).
stand: Compile out the extensive superblock diagnostic messages for BIOS loader
Fri, Nov 18, 1:23 AM
mckusick committed rGb999366aab4e: Do comprehensive UFS/FFS superblock integrity checks when reading a superblock. (authored by mckusick).
Do comprehensive UFS/FFS superblock integrity checks when reading a superblock.
Fri, Nov 18, 1:22 AM

Thu, Nov 17

mckusick committed rG8435a9b20684: Updates to UFS/FFS superblock integrity checks when reading a superblock. (authored by mckusick).
Updates to UFS/FFS superblock integrity checks when reading a superblock.
Thu, Nov 17, 10:52 PM

Sun, Nov 13

mckusick committed rG78f412987605: Enable taking snapshots on UFS/FFS filesystems using journaled soft updates. (authored by mckusick).
Enable taking snapshots on UFS/FFS filesystems using journaled soft updates.
Sun, Nov 13, 7:03 AM

Sat, Nov 12

mckusick added a comment to D37354: Port HAMMER2 from DragonFly (read-only support).

I generally agree with the comments by markj. As someone who helps to maintain VFS infrastructure, the addition of a new filesystem means one more place that changes need to be propagated. I do not see a lot of use cases for a read-only HAMMER filesystem. I would be much more willing to see it added if it has write ability added as FreeBSD users could then use it without need of having a Dragonfly system running. Another alternative would be to make this code available as a port which could be tried out by those wishing to use it. More importantly it would push off tracking changes to the VFS infrastructure to the port maintainer.

Sat, Nov 12, 11:58 PM
mckusick committed rG5c7ba6bdf83f: Fix for tunefs(8) unable to add a UFS/FFS soft update journal. (authored by mckusick).
Fix for tunefs(8) unable to add a UFS/FFS soft update journal.
Sat, Nov 12, 11:38 PM

Thu, Nov 10

mckusick committed rG5f7acd185831: Fix printfs for fsck_ffs(8) i386 build. (authored by mckusick).
Fix printfs for fsck_ffs(8) i386 build.
Thu, Nov 10, 6:00 AM
mckusick committed rG689a9368eb60: Fix types for fsck_ffs(8) i386 build. (authored by mckusick).
Fix types for fsck_ffs(8) i386 build.
Thu, Nov 10, 2:32 AM

Wed, Nov 9

mckusick committed rG460ed6106cf0: Add support for managing UFS/FFS snapshots to fsck_ffs(8). (authored by mckusick).
Add support for managing UFS/FFS snapshots to fsck_ffs(8).
Wed, Nov 9, 6:47 PM
mckusick closed D36491: Add support for managing UFS/FFS snapshots to fsck_ffs(8).
Wed, Nov 9, 6:47 PM

Mon, Nov 7

mckusick updated the diff for D36491: Add support for managing UFS/FFS snapshots to fsck_ffs(8).

Fixes for bugs found by Peter Holm.

Mon, Nov 7, 11:59 PM
mckusick committed rGf515a279f720: Clean up error output for extended attributes in fsck_ffs(8). (authored by mckusick).
Clean up error output for extended attributes in fsck_ffs(8).
Mon, Nov 7, 10:33 PM
mckusick added a comment to D36491: Add support for managing UFS/FFS snapshots to fsck_ffs(8).

Well, ... I just got this looping problem with a new test scenario and the patched fsck_ffs + this disk image: https://people.freebsd.org/~pho/diskimage.20221013.xz

Mon, Nov 7, 1:25 AM

Nov 1 2022

mckusick committed rG0f58c5454c66: Add a description of soft updates journaling to newfs(8). (authored by mckusick).
Add a description of soft updates journaling to newfs(8).
Nov 1 2022, 12:15 AM
mckusick committed rGaff7cd295fdb: Update date in tunefs(8) manual page. (authored by mckusick).
Update date in tunefs(8) manual page.
Nov 1 2022, 12:15 AM
mckusick committed rGa1017358b35e: Add a description of soft updates journaling to tunefs(8). (authored by mckusick).
Add a description of soft updates journaling to tunefs(8).
Nov 1 2022, 12:15 AM

Oct 31 2022

mckusick committed rGb06a5f6f5e39: Add a description of soft updates journaling to newfs(8). (authored by mckusick).
Add a description of soft updates journaling to newfs(8).
Oct 31 2022, 3:55 AM
mckusick committed rG1639fa2cd548: Update date in tunefs(8) manual page. (authored by mckusick).
Update date in tunefs(8) manual page.
Oct 31 2022, 3:52 AM
mckusick committed rGde1f80e4c138: Add a description of soft updates journaling to tunefs(8). (authored by mckusick).
Add a description of soft updates journaling to tunefs(8).
Oct 31 2022, 3:52 AM
mckusick committed rG759ee8654012: Add a description of soft updates journaling to newfs(8). (authored by mckusick).
Add a description of soft updates journaling to newfs(8).
Oct 31 2022, 3:47 AM
mckusick committed rG25431fd62146: Update date in tunefs(8) manual page. (authored by mckusick).
Update date in tunefs(8) manual page.
Oct 31 2022, 3:42 AM
mckusick committed rG9f004375ae01: Add a description of soft updates journaling to tunefs(8). (authored by mckusick).
Add a description of soft updates journaling to tunefs(8).
Oct 31 2022, 3:42 AM

Oct 30 2022

mckusick committed rG595746df6fe9: Additional diagnostic output when running fsck_ffs with debugging flag (-d) (authored by mckusick).
Additional diagnostic output when running fsck_ffs with debugging flag (-d)
Oct 30 2022, 10:01 PM

Oct 21 2022

mckusick committed rG243a0eda9ace: Increase the maximum size of the journaled soft-updates journal. (authored by mckusick).
Increase the maximum size of the journaled soft-updates journal.
Oct 21 2022, 6:01 PM
mckusick committed rG0929a153fc5c: Add a description of soft updates journaling to newfs(8). (authored by mckusick).
Add a description of soft updates journaling to newfs(8).
Oct 21 2022, 5:58 PM

Oct 19 2022

mckusick added a comment to D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.
In D34012#841017, @bcr wrote:

Who's going to commit this?

Oct 19 2022, 9:41 PM

Oct 16 2022

mckusick accepted D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.

This all looks good to me. Addition of tests is helpful and appreciated.

Oct 16 2022, 2:15 PM

Oct 13 2022

mckusick committed rG565337126942: Fix an incorrectly placed parenthesis. (authored by mckusick).
Fix an incorrectly placed parenthesis.
Oct 13 2022, 3:47 PM
mckusick committed rG0ae91878cc45: When taking a snapshot on a UFS/FFS filesystem, it must be mounted. (authored by mckusick).
When taking a snapshot on a UFS/FFS filesystem, it must be mounted.
Oct 13 2022, 3:44 PM

Oct 9 2022

mckusick added a comment to D36491: Add support for managing UFS/FFS snapshots to fsck_ffs(8).

Document checksnapinfo().

Oct 9 2022, 3:37 AM
mckusick updated the diff for D36491: Add support for managing UFS/FFS snapshots to fsck_ffs(8).

Add comments to checksnapinfo() and its macro CHKBLKINLIST().

Oct 9 2022, 3:36 AM

Oct 3 2022

mckusick committed rGdcdba3460dd7: Updates to UFS/FFS superblock integrity checks when reading a superblock. (authored by mckusick).
Updates to UFS/FFS superblock integrity checks when reading a superblock.
Oct 3 2022, 12:54 PM

Oct 2 2022

mckusick added a comment to D36491: Add support for managing UFS/FFS snapshots to fsck_ffs(8).

Thanks for your continued feedback.

Oct 2 2022, 12:38 PM
mckusick updated the diff for D36491: Add support for managing UFS/FFS snapshots to fsck_ffs(8).

Add verification of snapshot having made copies of its superblock and cylinder groups (new code near the end of setup.c). Checking the correctness of the existing list is less disruptive than changing the on-disk format to allow the addition of a check-hash.

Oct 2 2022, 12:15 PM

Sep 29 2022

mckusick committed rG221da3e9212d: Fix an incorrectly placed parenthesis. (authored by mckusick).
Fix an incorrectly placed parenthesis.
Sep 29 2022, 8:47 AM

Sep 28 2022

mckusick added inline comments to D36491: Add support for managing UFS/FFS snapshots to fsck_ffs(8).
Sep 28 2022, 2:27 PM

Sep 27 2022

mckusick committed rG3c67983babbb: Handle NULL return from localtime(3) in ls(1) and find(1) (authored by mckusick).
Handle NULL return from localtime(3) in ls(1) and find(1)
Sep 27 2022, 4:21 PM
mckusick committed rG27d673fbbb79: When taking a snapshot on a UFS/FFS filesystem, it must be mounted. (authored by mckusick).
When taking a snapshot on a UFS/FFS filesystem, it must be mounted.
Sep 27 2022, 3:59 PM
mckusick added inline comments to D36491: Add support for managing UFS/FFS snapshots to fsck_ffs(8).
Sep 27 2022, 1:09 PM

Sep 16 2022

mckusick added a comment to D36515: ctime.3: Add a note about a possible return value to the description of localtime(3).

It took us a long time to figure out one sentence, but I am happy with the result. Thanks Gordon for your patience.

Sep 16 2022, 7:41 PM

Sep 14 2022

mckusick added a comment to D36515: ctime.3: Add a note about a possible return value to the description of localtime(3).

Proposed new wording.

Sep 14 2022, 4:00 PM
mckusick accepted D36522: ufs: try to elide the interlock in ufs_itimes.

With updates, looks good.

Sep 14 2022, 3:53 PM

Sep 12 2022

mckusick updated the diff for D36491: Add support for managing UFS/FFS snapshots to fsck_ffs(8).

Add context to diffs

Sep 12 2022, 11:36 PM

Sep 10 2022

mckusick accepted D36521: vfs: retire V_MNTREF.

Looks like a useful cleanup to me.

Sep 10 2022, 10:36 PM
mckusick added a comment to D36515: ctime.3: Add a note about a possible return value to the description of localtime(3).

I think that it would be better to just add a sentence in the description of localtime that notes that it may return NULL since that is where it is most likely to be seen by readers of the manual page.

diff --git a/contrib/tzcode/stdtime/ctime.3 b/contrib/tzcode/stdtime/ctime.3
index 771027fa62ec..c577073a9a2a 100644
--- a/contrib/tzcode/stdtime/ctime.3
+++ b/contrib/tzcode/stdtime/ctime.3
@@ -94,6 +94,10 @@ and returns a pointer to a
 (described below) which contains
 the broken-out time information for the value after adjusting for the current
 time zone (and any other factors such as Daylight Saving Time).
+When the passed in time translates to a year that will not fit
+in an integer type,
+.Fn localtime
+returns NULL.
 Time zone adjustments are performed as specified by the
 .Ev TZ
 environment variable (see

Otherwise add it as a standard section as noted in my inline comment.

Sep 10 2022, 4:12 PM

Sep 9 2022

mckusick added a comment to D36474: Handle out-of-bounds file timestamps in ls(1) and find(1).
In D36474#828714, @kib wrote:

The strlen() call in ls_strftime() is no useful: it's result is dropped immediately. Please note my suggestion about voiding return type for ls_strftime().

Sep 9 2022, 9:33 PM
mckusick closed D36474: Handle out-of-bounds file timestamps in ls(1) and find(1).
Sep 9 2022, 9:31 PM
mckusick committed rG927f8d8bbbed: Handle NULL return from localtime(3) in ls(1) and find(1) (authored by mckusick).
Handle NULL return from localtime(3) in ls(1) and find(1)
Sep 9 2022, 9:31 PM

Sep 8 2022

mckusick requested review of D36491: Add support for managing UFS/FFS snapshots to fsck_ffs(8).
Sep 8 2022, 12:54 AM

Sep 7 2022

mckusick added a comment to D36474: Handle out-of-bounds file timestamps in ls(1) and find(1).

Update strncpy(3) to strlcpy(3).

Sep 7 2022, 11:50 PM
mckusick updated the diff for D36474: Handle out-of-bounds file timestamps in ls(1) and find(1).

Follow Kostik's suggestion to use strlcpy(3) rather than strncpy(3).

Sep 7 2022, 11:49 PM
mckusick added a comment to D36474: Handle out-of-bounds file timestamps in ls(1) and find(1).

Further investigation shows that there are over 100 utilities and libraries that use localtime(3) and none of the ones I have looked at are prepared for a NULL return. They all need to be fixed along the lines of ls(1) and find(1) or there has to be some defined `bad date' value that is returned in the tm structure. Here is a list of places that call localtime(3):

Sep 7 2022, 11:40 PM
mckusick requested review of D36474: Handle out-of-bounds file timestamps in ls(1) and find(1).
Sep 7 2022, 1:00 AM

Sep 6 2022

mckusick committed rG2567b60f6253: Fix for f4fc389. (authored by mckusick).
Fix for f4fc389.
Sep 6 2022, 11:23 PM
mckusick committed rG2ddf8cdbe085: Clarify error messages about bad inodes. (authored by mckusick).
Clarify error messages about bad inodes.
Sep 6 2022, 11:18 PM

Sep 5 2022

mckusick committed rG4b4cc78a762c: Formatting cleanups and debugging fix. (authored by mckusick).
Formatting cleanups and debugging fix.
Sep 5 2022, 7:08 PM

Sep 3 2022

mckusick committed rG2aa6ed881d22: Fix printf formating. (authored by mckusick).
Fix printf formating.
Sep 3 2022, 10:41 PM
mckusick accepted D36227: pkgbase: Put ufs related tools and lib in their own package.
In D36227#826485, @imp wrote:

Is dump/restore UFS-specific?

They are. Technically restore can restore files from a ufs dump to any filesystem, but it's so coupled to dump that I'd have to say both are as UFS specific as clri or tunefs

Sep 3 2022, 10:02 PM
mckusick committed rGf4fc3895243b: Properly handle the replacement of a partially allocated root directory. (authored by mckusick).
Properly handle the replacement of a partially allocated root directory.
Sep 3 2022, 9:49 PM
mckusick committed rGcf17c2ff11a9: Flush and close getnextino cache when done using it in Pass 1b. (authored by mckusick).
Flush and close getnextino cache when done using it in Pass 1b.
Sep 3 2022, 9:17 PM
mckusick committed rG82ee4e1c42d7: Updates to UFS/FFS superblock integrity checks when reading a superblock. (authored by mckusick).
Updates to UFS/FFS superblock integrity checks when reading a superblock.
Sep 3 2022, 9:12 PM

Aug 29 2022

mckusick committed rG827622937efa: Correct calculation of inode location in getnextino cache. (authored by mckusick).
Correct calculation of inode location in getnextino cache.
Aug 29 2022, 6:48 AM
mckusick committed rG9dee5da7450e: Updates to UFS/FFS superblock integrity checks when reading a superblock. (authored by mckusick).
Updates to UFS/FFS superblock integrity checks when reading a superblock.
Aug 29 2022, 6:16 AM
mckusick committed rG2e4da012d57e: Correct calculation of inode location in getnextino cache. (authored by mckusick).
Correct calculation of inode location in getnextino cache.
Aug 29 2022, 6:10 AM

Aug 26 2022

mckusick committed rG27c6009e7237: Correct diagnostic messages for bad cylinder groups. (authored by mckusick).
Correct diagnostic messages for bad cylinder groups.
Aug 26 2022, 7:33 AM
mckusick committed rGf0be378a66a7: Updates to UFS/FFS superblock integrity checks when reading a superblock. (authored by mckusick).
Updates to UFS/FFS superblock integrity checks when reading a superblock.
Aug 26 2022, 7:11 AM
mckusick committed rG495b1baac327: Provide better diagnostic messages for bad cylinder groups. (authored by mckusick).
Provide better diagnostic messages for bad cylinder groups.
Aug 26 2022, 6:59 AM

Aug 24 2022

mckusick committed rG345bfec10905: Provide cache coherency between getnextinode() and ginode() (authored by mckusick).
Provide cache coherency between getnextinode() and ginode()
Aug 24 2022, 6:50 AM
mckusick committed rGbe639cc8eef0: Update standard superblock when successful using an alternate superblock. (authored by mckusick).
Update standard superblock when successful using an alternate superblock.
Aug 24 2022, 6:30 AM

Aug 18 2022

mckusick accepted D36253: stand: Search less agressively for UFS super block.

This gets us back to close to what we had previously. You might want to reduce output further by adding the UFS_NOMSG flag, but generally non-UFS systems will not have a valid magic number which will prevent any further messages, so you should only get messages if you have something that is likely to be a UFS filesystem.

Aug 18 2022, 6:07 AM

Aug 17 2022

mckusick committed rGcf1a6ffceec4: Allow forced r/w mount of UFS/FFS filesystem with a bad check hash. (authored by mckusick).
Allow forced r/w mount of UFS/FFS filesystem with a bad check hash.
Aug 17 2022, 10:50 PM
mckusick committed rG6bae6625e0e0: Improve handling of missing '.' and '..' in UFS directories. (authored by mckusick).
Improve handling of missing '.' and '..' in UFS directories.
Aug 17 2022, 9:22 PM
mckusick committed rG4f9606c9a615: When reading backup UFS superblocks, report reason if they cannot be used. (authored by mckusick).
When reading backup UFS superblocks, report reason if they cannot be used.
Aug 17 2022, 8:55 PM

Aug 16 2022

mckusick committed rG128b0398a1d4: Update date in tunefs(8) manual page. (authored by mckusick).
Update date in tunefs(8) manual page.
Aug 16 2022, 11:48 PM

Aug 15 2022

mckusick committed rG82493ff7007a: Add a description of soft updates journaling to tunefs(8). (authored by mckusick).
Add a description of soft updates journaling to tunefs(8).
Aug 15 2022, 8:46 PM

Aug 13 2022

mckusick committed rG6b9d4fbb7fe5: Explicitly initialize rather than reading newly allocated UFS inodes. (authored by mckusick).
Explicitly initialize rather than reading newly allocated UFS inodes.
Aug 13 2022, 8:52 PM
mckusick committed rG6e821c35d68d: Correctness cleanups in fsck_ffs(8). (authored by mckusick).
Correctness cleanups in fsck_ffs(8).
Aug 13 2022, 8:29 PM
mckusick committed rGe68866164212: Move the ability to search for alternate UFS superblocks from fsck_ffs(8) (authored by mckusick).
Move the ability to search for alternate UFS superblocks from fsck_ffs(8)
Aug 13 2022, 7:46 PM
mckusick closed D36053: Move the ability to search for alternate UFS superblocks from fsck_ffs(8) into ffs_search() to allow use by other parts of the system..
Aug 13 2022, 7:45 PM

Aug 12 2022

mckusick accepted D36175: stand: Compile out the extensive superblock diagnostic messages for BIOS loader.

This looks like an excellent solution to the problem. It also lets unconstrained loader continue to give useful diagnostic output when unable to use a filesystem.

Aug 12 2022, 10:09 PM

Aug 7 2022

mckusick added a comment to D36053: Move the ability to search for alternate UFS superblocks from fsck_ffs(8) into ffs_search() to allow use by other parts of the system..

Thanks Warner. You zero'ed in on the part that I was concerned about which is whether the expanded code would fit.
If you do find that the fit is a problem, it would be trivial to #ifdef to get the old behavior and smaller code where needed.

Aug 7 2022, 6:59 AM

Aug 6 2022

mckusick added a comment to D36053: Move the ability to search for alternate UFS superblocks from fsck_ffs(8) into ffs_search() to allow use by other parts of the system..

The English in the manual page change LGTM. I can't attest to consistency with the rest.

Aug 6 2022, 6:32 PM
mckusick added a comment to D36053: Move the ability to search for alternate UFS superblocks from fsck_ffs(8) into ffs_search() to allow use by other parts of the system..
In D36053#818684, @gbe wrote:

LGTM for the man page parts.

Aug 6 2022, 6:32 PM
mckusick added a comment to D36053: Move the ability to search for alternate UFS superblocks from fsck_ffs(8) into ffs_search() to allow use by other parts of the system..
In D36053#818705, @kib wrote:

I am not sure about positioning of fstype(8) there. On one hand, it is better to report that the volume is suspicious to have something resembling UFS on it. On the other hand, it might be that the alternative superblock is a ghost and now the different kind of the on-disk structure is present.

Aug 6 2022, 6:31 PM
mckusick requested review of D36053: Move the ability to search for alternate UFS superblocks from fsck_ffs(8) into ffs_search() to allow use by other parts of the system..
Aug 6 2022, 1:04 AM

Aug 4 2022

mckusick committed rG23c8b19c1d13: Drop checks with last alternate superblock in fsck_ffs(8). (authored by mckusick).
Drop checks with last alternate superblock in fsck_ffs(8).
Aug 4 2022, 11:09 PM

Aug 1 2022

mckusick committed rGd22531d57282: Identify each UFS/FFS superblock integrity check as a warning or fatal error. (authored by mckusick).
Identify each UFS/FFS superblock integrity check as a warning or fatal error.
Aug 1 2022, 5:13 AM
mckusick committed rG184e3118c105: Updates to UFS/FFS superblock integrity checks when reading a superblock. (authored by mckusick).
Updates to UFS/FFS superblock integrity checks when reading a superblock.
Aug 1 2022, 3:29 AM

Jul 31 2022

mckusick committed rG3e40d2cc61a0: Fix for 548045b a too aggressive UFS superblock integrity check. (authored by mckusick).
Fix for 548045b a too aggressive UFS superblock integrity check.
Jul 31 2022, 2:50 PM
mckusick committed rGb21582ee03ec: Add a flags parameter to the ffs_sbget() function that reads UFS superblocks. (authored by mckusick).
Add a flags parameter to the ffs_sbget() function that reads UFS superblocks.
Jul 31 2022, 5:52 AM
mckusick committed rG548045bf57c4: Updates to UFS/FFS superblock integrity checks when reading a superblock. (authored by mckusick).
Updates to UFS/FFS superblock integrity checks when reading a superblock.
Jul 31 2022, 5:36 AM

Jul 29 2022

mckusick committed rG58cb3626762d: Fix for 90e2971 that caused some geli commands to return the wrong exit status. (authored by mckusick).
Fix for 90e2971 that caused some geli commands to return the wrong exit status.
Jul 29 2022, 6:12 PM

Jul 25 2022

mckusick committed rGbf24d17fda75: Have dumpfs(8) ignore superblock check-hash failures. (authored by mckusick).
Have dumpfs(8) ignore superblock check-hash failures.
Jul 25 2022, 1:14 AM
mckusick committed rG1297a704d991: Output fs_csaddr rather than fs_old_csaddr for UFS1 filesystems. (authored by mckusick).
Output fs_csaddr rather than fs_old_csaddr for UFS1 filesystems.
Jul 25 2022, 1:14 AM
mckusick committed rG82e72f1d12fa: Add d_sblockloc to libufs(3) disk structure to allow options to be added. (authored by mckusick).
Add d_sblockloc to libufs(3) disk structure to allow options to be added.
Jul 25 2022, 1:14 AM

Jul 21 2022

mckusick committed rGf030f1102c62: Delete UFS2 backup superblock recovery info when building a UFS1 filesystem. (authored by mckusick).
Delete UFS2 backup superblock recovery info when building a UFS1 filesystem.
Jul 21 2022, 5:53 AM
mckusick committed rG36e08b0127f9: Bug fix to UFS/FFS superblock integrity checks when reading a superblock. (authored by mckusick).
Bug fix to UFS/FFS superblock integrity checks when reading a superblock.
Jul 21 2022, 5:53 AM