Page MenuHomeFreeBSD

UFS: panic rather than forcibly unmount the root fs
ClosedPublic

Authored by chs on Aug 8 2023, 7:18 PM.
Tags
None
Referenced Files
F83343291: D41387.diff
Thu, May 9, 3:56 AM
F83329026: D41387.diff
Wed, May 8, 11:52 PM
Unknown Object (File)
Thu, May 2, 10:20 AM
Unknown Object (File)
Thu, May 2, 10:20 AM
Unknown Object (File)
Sat, Apr 27, 6:27 AM
Unknown Object (File)
Fri, Apr 26, 6:26 AM
Unknown Object (File)
Fri, Apr 26, 1:24 AM
Unknown Object (File)
Apr 8 2024, 5:49 AM
Subscribers

Details

Summary

If the root fs is forcibly unmounted then basically every process
will die with a SEGV as soon as it tries to run again because libc.so
is gone, which leaves the system basically hung. It seems better
to just panic instead, so let's do that.

Requested-by: karels
Sponsored-by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chs requested review of this revision.Aug 8 2023, 7:18 PM

Is there always leading context, like a failure messages? OtherwiseLGTM, but I'll let Kirk weigh in.

There should always be context, but I'm hunting a 'weird' case in the disk error/timeout recovery code that might cause this w/o a message.
Usually there are very verbose error messages, though, that indicate why this was the case.

This revision is now accepted and ready to land.Aug 8 2023, 8:41 PM

This looks like the correct solution to me. We are at the point where we decide we need to do a forcible unmount and realize that we are about to do it on the root filesystem.