Add more accurate directory entries check
ClosedPublic
Actions

Authored by fsu on Dec 10 2021, 5:22 PM.

Tags

None

Referenced Files

	F160258700: D33374.id100746.diff
	Mon, Jun 22, 3:44 PM

	F160254885: D33374.id.diff
	Mon, Jun 22, 2:47 PM

	Unknown Object (File)
	Fri, Jun 19, 1:43 PM

	Unknown Object (File)
	Thu, Jun 18, 4:01 PM

	Unknown Object (File)
	May 8 2026, 10:12 PM

	Unknown Object (File)
	May 8 2026, 6:49 PM

	Unknown Object (File)
	May 8 2026, 5:10 PM

	Unknown Object (File)
	May 8 2026, 4:38 PM

View All Files

Subscribers

imp

Details

Reviewers

pfg
nc

Commits

rGbb9f1ba4b55c: Add more accurate directory entries check

Summary

Rename ext2_dirbadentry() to ext2_check_direntry(). Add directory entry inode value check, and call ext2_check_direntry() in all cases. The dirchk sysctl is removed.

This PR should close next BZ issues:
259024 (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259024)
259041 (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259041)

Test Plan

Tested using next testing scripts:
https://github.com/thedrgreenthumb/Jenkins/tree/pjenkins/Target/ext2fs_test_all

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fsu created this revision.Dec 10 2021, 5:22 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 10 2021, 5:22 PM

fsu requested review of this revision.Dec 10 2021, 5:22 PM

LGTM

This revision is now accepted and ready to land.Dec 11 2021, 12:03 AM

Closed by commit rGbb9f1ba4b55c: Add more accurate directory entries check (authored by fsu). · Explain WhyDec 30 2021, 6:15 AM

This revision was automatically updated to reflect the committed changes.

fsu added a commit: rGbb9f1ba4b55c: Add more accurate directory entries check.

Revision Contents
Changeset List

Path

Size

sys/

fs/

ext2fs/

ext2_lookup.c

39 lines

Diff 100746

View Options

sys/fs/ext2fs/ext2_lookup.c

Add more accurate directory entries checkClosedPublicActions