fsu (Fedor Uporov)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 27 2017, 5:46 PM (42 w, 2 d)

Recent Activity

Sun, Jan 14

fsu committed rS327977: Add metadata_csum feature support..
Add metadata_csum feature support.
Sun, Jan 14, 8:46 PM
fsu closed D13810: Add metadata_csum feature support..
Sun, Jan 14, 8:46 PM

Wed, Jan 10

fsu added a comment to D13810: Add metadata_csum feature support..
In D13810#289909, @pfg wrote:
In D13810#289828, @fsu wrote:
In D13810#289543, @pfg wrote:

A thought : would it be possible to checksum only what we are going to write to disk?
Data will not, generally, corrupt in memory and the kernel has no use for the checksums at runtime so we only need to write stuff when it's going to be converted to the on-disk format in ext2_inode_cnv.c.

All fields, which are mentioned in SUMMERY, should be written to disk. If it will not be updated, we will have errors reported by e2fsck, or bunch of error messages from driver on linux side.

I am not complaining at all about what is being checksummed: I understand you want to checksum everything that is needed. The main doubt is when to checksum.

There are two possibilities: you either checksum everything as soon as you get it or you checksum at the last moment before writing to disk. Both options have their advantages It seems like the checksumming is happening all over the filesystem so you are doing the former, I was only wondering if we could do all the checksums in a single place, right when we are converting to the ext2fs format for writing.

I am not sure if such thing is poosible though, and your change is not incorrect so I'll let you think about it but I'll approve the patch.

Wed, Jan 10, 4:16 PM
fsu added a comment to D13810: Add metadata_csum feature support..
In D13810#289543, @pfg wrote:

A thought : would it be possible to checksum only what we are going to write to disk?
Data will not, generally, corrupt in memory and the kernel has no use for the checksums at runtime so we only need to write stuff when it's going to be converted to the on-disk format in ext2_inode_cnv.c.

Wed, Jan 10, 7:53 AM

Tue, Jan 9

fsu created D13810: Add metadata_csum feature support..
Tue, Jan 9, 10:25 AM
fsu added inline comments to D13528: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_* (logic only)..
Tue, Jan 9, 6:50 AM
fsu updated the diff for D13528: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_* (logic only)..
  • Declare struct fuse_listxattr_* to not use fuse_getxattr_* in case of list().
  • Remove ENOSYS error check in case of second fdisp_wait_answ() call under list().
Tue, Jan 9, 6:37 AM

Mon, Jan 8

fsu added inline comments to D13528: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_* (logic only)..
Mon, Jan 8, 9:15 AM
fsu updated the diff for D13528: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_* (logic only)..

More deep reinitialization of struct fuse_dispatcher fdi before second call to fdisp_wait_answ() under fuse_vnop_listextattr().

Mon, Jan 8, 8:57 AM

Fri, Jan 5

fsu committed rS327585: MFC r326807:.
MFC r326807:
Fri, Jan 5, 10:04 AM
fsu closed D11530: ext2fs: Add 64bit feature support.
Fri, Jan 5, 10:04 AM
fsu committed rS327584: Add 64bit feature support..
Add 64bit feature support.
Fri, Jan 5, 10:04 AM

Wed, Jan 3

fsu updated the diff for D13267: Export extattr_*vp() functions to allow to use it in the linuxulator in future .

Ok, let's try to proceed...
Here is very initial version of vfs_extattr.c, where the io faults are handled.
It even somehow does not works with ufs, but works with ext2fs, I did not dig in this problem for now, because it is needed to figure out the direction and next steps for extattrs topic, the testing procedure will include all available filesystems with extattrs support and will be developed later.
So, @kib, could you please review it and provide the comments.

Wed, Jan 3, 12:06 PM
fsu added inline comments to D11530: ext2fs: Add 64bit feature support.
Wed, Jan 3, 7:44 AM

Tue, Jan 2

fsu updated the diff for D11530: ext2fs: Add 64bit feature support.

Diff changes:

  • Restore FLEX_BG check.
  • Remove 64k block size/extents mount check.
  • Remove 64bit feature testing hack.
  • Revert newline in the ext2_alloc.c
Tue, Jan 2, 9:02 AM
fsu added a comment to D13487: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_*..

Also, cosmetic changes are extracted in https://reviews.freebsd.org/D13737.

Tue, Jan 2, 8:26 AM
fsu created D13737: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_* (cosmetic only)..
Tue, Jan 2, 8:25 AM

Fri, Dec 22

fsu added a comment to D11530: ext2fs: Add 64bit feature support.

What I find confusing is that there is "force_64bit_alloc", labelled for testing/debugging only and a couple of TODO things that give the impresion that the implementation is still not ready.

Fri, Dec 22, 5:33 PM
fsu committed rS327087: MFC r326808, r326824:.
MFC r326808, r326824:
Fri, Dec 22, 5:19 PM
fsu added a comment to D11530: ext2fs: Add 64bit feature support.

I can confirm that it is ready to commit to head with long MFC for additional testing.
I made normal tests using fsx/fstorture + tests for modes when blocks are allocated out of UINT_MAX range.
More detailed information could be found in second test scripts attachment.
The reason why it was done in two phases (I mean a bunch of time between first and second review revisions),
because this feature heavily related with extents.
There were two ways to integrate extents and 64bit:

  • RO extents, then RO 64bit, then RW extents, then RW 64bit.
  • RO extents, then RW extetns, then RW 64bit.
Fri, Dec 22, 7:37 AM

Wed, Dec 20

fsu updated the diff for D11530: ext2fs: Add 64bit feature support.

Updated version of 64bit feature.
It was required to implement extents feature before add it.

Wed, Dec 20, 9:37 AM

Tue, Dec 19

fsu updated the diff for D13528: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_* (logic only)..

Add linux_list stack variable to make listxattr() function more readable.

Tue, Dec 19, 7:32 AM

Dec 18 2017

fsu added a comment to D13487: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_*..

Ok), logic fixes are extracted in https://reviews.freebsd.org/D13528.

Dec 18 2017, 8:09 AM
fsu created D13528: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_* (logic only)..
Dec 18 2017, 8:08 AM

Dec 15 2017

fsu added a comment to D13267: Export extattr_*vp() functions to allow to use it in the linuxulator in future .

It is too difficult to me to implement it now, so, seems like, I have a questions to @kib.
As I currently understand, what we want to achive to is, not allow page faults to happen during extattr operations, is insert some sort of logic, like happen between vn_io_fault() and vn_read/vn_write or VOP_READ/VOP_WRITE.
It should be inserted in the extattr_*vp() between uio initialization and VOP_*EXTATTR call.

Dec 15 2017, 8:27 AM
fsu added a comment to D13487: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_*..

Seems like, it is not clearly understandable what was fixed. Ok, let me explain:

  • The was a bug in list() function when uio was not passed, the size of linux list (not converted to bsd was returned).
  • Case when neither uio nor size were not passed to list() and get(), this logic could be used to check does extattr with some key exist or not.
Dec 15 2017, 7:43 AM

Dec 14 2017

fsu created D13487: fuse extattrs: fix issue when neither uio nor size were not passed to VOP_*..
Dec 14 2017, 7:45 AM

Dec 13 2017

fsu committed rS326824: Fix kernel build if MAC is not defined..
Fix kernel build if MAC is not defined.
Dec 13 2017, 4:15 PM

Dec 12 2017

fsu committed rS326810: MFC r326282, r326317:.
MFC r326282, r326317:
Dec 12 2017, 8:29 PM
fsu committed rS326808: Move buffer size checks outside of the vnode locks..
Move buffer size checks outside of the vnode locks.
Dec 12 2017, 8:16 PM
fsu closed D13405: Move buffer size checks outside of the vnode locks..
Dec 12 2017, 8:16 PM
fsu closed D13359: ext2fs: Fix extattr getters in case of neither uio nor buffer was not passed to VOP_*..
Dec 12 2017, 8:03 PM
fsu committed rS326807: Fix extattr getters in case of neither uio nor buffer was not passed to VOP_*..
Fix extattr getters in case of neither uio nor buffer was not passed to VOP_*.
Dec 12 2017, 8:03 PM

Dec 7 2017

fsu updated the diff for D13267: Export extattr_*vp() functions to allow to use it in the linuxulator in future .

It is difficult to find a value to restrict extattr value size. Because, as I know, in case of ntfs and hfs, the extattr sizes are "infinity".
So I decided to use the same check for uio size, so we will have two checks one on extattr_*vp() layer and one on upper layer on system call pass.
My opinio is that, the check in the extattr_*vp() layer is needed because this function will be exported as part of kernel interface.

Dec 7 2017, 8:20 AM
fsu added a comment to D13267: Export extattr_*vp() functions to allow to use it in the linuxulator in future .

Ok, here the buffer size checks in the extattr_*_vp() are moved out from vnode locks:
https://reviews.freebsd.org/D13405

Dec 7 2017, 7:57 AM
fsu created D13405: Move buffer size checks outside of the vnode locks..
Dec 7 2017, 7:56 AM

Dec 6 2017

fsu added inline comments to D13267: Export extattr_*vp() functions to allow to use it in the linuxulator in future .
Dec 6 2017, 10:43 AM
fsu updated the diff for D13267: Export extattr_*vp() functions to allow to use it in the linuxulator in future .

Switch extattr_*_vp() to use input buffers from kernelspace.

Dec 6 2017, 10:42 AM

Dec 5 2017

fsu added a comment to D13209: linuxulator: Add user xattrs support for i386 and amd64 platforms..

Ok, if I understood correctly, the idea is to use vp_extattr_*() to use in case of calls from filesystem, and extattr_*_vp() - in case of system calls.
Let's get back to:
https://reviews.freebsd.org/D13267
I want to solve the interface questions before getting back to linuxulator xattrs implementation.
Robert, you are already invited to the review above.

Dec 5 2017, 12:56 PM
fsu updated the diff for D13267: Export extattr_*vp() functions to allow to use it in the linuxulator in future .

Updated after discussion with @rwatson in the:
https://reviews.freebsd.org/D13209

Dec 5 2017, 12:47 PM

Dec 4 2017

fsu created D13359: ext2fs: Fix extattr getters in case of neither uio nor buffer was not passed to VOP_*..
Dec 4 2017, 10:14 AM
fsu added a comment to D13209: linuxulator: Add user xattrs support for i386 and amd64 platforms..

Ok, I was wrong with with MAC and user extattrs, the MAC checking functions should be restored.
Also, the general question, just to be sure, does MAC check is responsibility of VFS or the filesystem?

Dec 4 2017, 8:53 AM

Dec 1 2017

fsu added a comment to D13209: linuxulator: Add user xattrs support for i386 and amd64 platforms..

Ok, thanks for suggest.
My choice was closer to (1), because it was not required to modify kernel code, so it was faster in case of debugging, because it is not needed to rebuild kernel every time. But (2) is more clear.
So, I will not commit https://reviews.freebsd.org/D13267 for now, but I will update it little bit later together with current review.

Dec 1 2017, 9:49 AM

Nov 28 2017

fsu added a comment to D13209: linuxulator: Add user xattrs support for i386 and amd64 platforms..

As could be seen from https://reviews.freebsd.org/D13267,
all extattr_*_vp() functions were exported, but, the only extattr_delete_vp() is used by current review iteration.
To use all the extattr_*_vp() functions I need to pull up the vnode locking logic out of this functions,
because I need one vnode lock per one system call, as I understand.
So, I should decide, where is the better way:

  1. Use the current way, where from linux_*_common() I will call VOP_*'s.
  2. Try to make extattr_*_vp() from vfs_extattr.c more generic. I mean remove vnode locking logic and add additional checks.
Nov 28 2017, 8:33 AM
fsu added a comment to D13209: linuxulator: Add user xattrs support for i386 and amd64 platforms..
In D13209#276930, @cem wrote:
In D13209#276929, @pfg wrote:

In one of the early comments Fedor attached a shell script with the tests extracted from the Linux Test Project.
Alternatively you can check all the test suite here:

https://linux-test-project.github.io/

There are several at testcases/kernel/syscalls

So I need a Linux system to compile them, right? Do they compile statically or do I need some Linux shared libraries as well? Thanks!

Nov 28 2017, 7:56 AM

Nov 27 2017

fsu updated the diff for D13209: linuxulator: Add user xattrs support for i386 and amd64 platforms..

Fix different marks from pfg and cem + split the patch additionaly (see comment above).

Nov 27 2017, 11:56 AM
fsu added a comment to D13209: linuxulator: Add user xattrs support for i386 and amd64 platforms..

Make additional commit split:
https://reviews.freebsd.org/D13267

Nov 27 2017, 11:46 AM
fsu created D13267: Export extattr_*vp() functions to allow to use it in the linuxulator in future .
Nov 27 2017, 11:45 AM

Nov 24 2017

fsu added a comment to D13209: linuxulator: Add user xattrs support for i386 and amd64 platforms..

In case of linux acls worked thru xattr syscalls, but with different namespace:
% strace setfacl -m m::rx ./FILE0
...
getrlimit(RLIMIT_NOFILE, {rlim_cur=1024, rlim_max=64*1024}) = 0
lstat("./FILE0", {st_mode=S_IFREG|0654, st_size=5, ...}) = 0
getxattr("./FILE0", "system.posix_acl_access", "\2\0\0\0\1\0\6\0\377\377\377\377\4\0\6\0\377\377\377\377\20\0\5\0\377\377\377\377 \0\4\0\377\377\377\377", 132) = 36
exit_group(0)

Nov 24 2017, 8:30 AM
fsu created D13221: Remap freebsd ENOATTR(87) errno from linux EOPNOTSUPP(95) to ENODATA(61) for i386/amd64 architectures..
Nov 24 2017, 8:28 AM

Nov 23 2017

fsu added a comment to D13209: linuxulator: Add user xattrs support for i386 and amd64 platforms..

Test helper script for LTP running.

Nov 23 2017, 8:34 AM
fsu created D13209: linuxulator: Add user xattrs support for i386 and amd64 platforms..
Nov 23 2017, 8:33 AM

Oct 12 2017

fsu added a comment to D12485: fuse.ko: Add extattrs support..

Everything noticed above will be fixed before commit.
Conrad, I should say you thanks for your review and time, which you spent.
Also, it would be great if you can, not review, but just look to ext2fs extents diff, where you was invited.

Oct 12 2017, 10:34 AM

Oct 10 2017

fsu updated the diff for D12485: fuse.ko: Add extattrs support..
  • Add name length check.
  • Add comments to function arguments.
  • Some refactoring.
Oct 10 2017, 7:45 AM

Oct 9 2017

fsu added inline comments to D12485: fuse.ko: Add extattrs support..
Oct 9 2017, 8:01 AM
fsu updated the diff for D12485: fuse.ko: Add extattrs support..
  • Swap inplace names conversion to malloced.
  • Reorder names conversion function arguments.
  • Fix style.
Oct 9 2017, 7:55 AM

Sep 29 2017

fsu added inline comments to D12485: fuse.ko: Add extattrs support..
Sep 29 2017, 7:56 AM
fsu updated the diff for D12485: fuse.ko: Add extattrs support..
  • remove extattr namespaces sysctl.
  • revet err check according style(9)
  • swap printf() to debug_printf()
Sep 29 2017, 7:54 AM

Sep 28 2017

fsu added a comment to D12087: ext2fs: extents, initial RW support.
In D12087#259854, @pfg wrote:

Add cem@, he may want to review it before it lands.

Sep 28 2017, 4:06 PM
fsu added a comment to D12485: fuse.ko: Add extattrs support..

The diff updated.
Also, it would be great to decide something with this new namespaces sysctl, leave it or remove.
May be somebody know some experienced persons, who worked with fuse fs, and can add them to this review, to clarify this question.

Sep 28 2017, 12:37 PM
fsu updated the diff for D12485: fuse.ko: Add extattrs support..

Here are some fixes according @cem's suggestions.

Sep 28 2017, 12:37 PM

Sep 25 2017

fsu updated the diff for D12485: fuse.ko: Add extattrs support..

Update diff to have full context.

Sep 25 2017, 6:48 AM
fsu updated the diff for D12485: fuse.ko: Add extattrs support..

Update diff to have full context.

Sep 25 2017, 6:43 AM

Sep 24 2017

fsu created D12485: fuse.ko: Add extattrs support..
Sep 24 2017, 3:31 PM

Aug 26 2017

fsu added a comment to D12087: ext2fs: extents, initial RW support.

Move huge_file discussions here:
https://reviews.freebsd.org/D12131

Aug 26 2017, 7:05 PM
fsu created D12131: ext2fs:Fix huge_file feature.
Aug 26 2017, 7:04 PM

Aug 25 2017

fsu added a comment to D12087: ext2fs: extents, initial RW support.

Ok, I am not sure that it is possible to overflow this variable.
We have 16 bit from e2di_nblock_high and 32 bit from e2di_nblock.
So:
pow(2, 48) * 512 / pow(1024,4) = 131072
Where result is in TBs.
The we can see from https://ext4.wiki.kernel.org/index.php/Ext4_Disk_Layout (File System Maximums table)
That for 64k blocks in both 32bit and 64bit cases we have maximum file size 256TB.

Aug 25 2017, 6:57 AM

Aug 24 2017

fsu added a comment to D12087: ext2fs: extents, initial RW support.
In D12087#251372, @pfg wrote:

I might have missed it, but have you considered the case that requires writing EXT4_HUGE_FILEs?

Yep, you can see it from attached test script, the mkfs option -O huge_file was added in all cases.

Of course, I am waiting for kevlo@ to chime in as he has more experience with this than me.

Me too:)

Aug 24 2017, 10:05 AM

Aug 23 2017

fsu updated the diff for D12087: ext2fs: extents, initial RW support.

Remove forgotten unneeded stuff.

Aug 23 2017, 6:27 AM

Aug 21 2017

fsu updated the diff for D12087: ext2fs: extents, initial RW support.

Fix small knits.

Aug 21 2017, 11:22 AM

Aug 20 2017

fsu created D12087: ext2fs: extents, initial RW support.
Aug 20 2017, 4:28 PM

Aug 2 2017

fsu added a comment to D11530: ext2fs: Add 64bit feature support.

Sorry for long delay from my side, but, seems like, this review revision should be frozen. It contain some "fundamental" problems, which can not be resolved directly. I found it, when started to play with large zvols. So, I need some time, and I can not estimate it for now.

Aug 2 2017, 8:57 PM

Jul 9 2017

fsu added a comment to D11530: ext2fs: Add 64bit feature support.

Ha...! The zfs with compressed zvol is good idea.

Jul 9 2017, 6:17 PM
fsu added inline comments to D11530: ext2fs: Add 64bit feature support.
Jul 9 2017, 5:35 PM
fsu added inline comments to D11530: ext2fs: Add 64bit feature support.
Jul 9 2017, 5:33 PM
fsu added a comment to D11530: ext2fs: Add 64bit feature support.
In D11530#238803, @pfg wrote:

You can use the existing ext4gd fields but for the others we need to have extra care.

I think/suspect the 64BIT flag needs a 64 bit system and basically breaks the on-disk compatibility: I recall it was causing issues with some bootloaders.

Jul 9 2017, 5:27 PM

Jul 8 2017

fsu created D11530: ext2fs: Add 64bit feature support.
Jul 8 2017, 5:02 PM

Jun 27 2017

fsu added a comment to D11208: ext2fs: Add unsupported ext2fs features dmesg report.

I should add, that it is not critical change, because it does not have influence to functionality. So, we can really skip it.
From other side, user will know from dmesg. why his volume does not mounted, or mounted in ro instead of rw, so he can try to use debugfs in some cases, or in more rare case try to add new functionality by himself;)

Jun 27 2017, 6:17 AM
fsu accepted D11354: ext2fs: add support for e2di_uid_high and e2di_gid_high..
Jun 27 2017, 6:08 AM

Jun 26 2017

fsu added a comment to D11354: ext2fs: add support for e2di_uid_high and e2di_gid_high..

As, I learned linux sources you can use uid/gid high without E2DI_HAS_XTIME(ip) check, because it depends only from mount option on linux side, not from inode size.
So, seems like

ip->i_uid |= (uint32_t)ei->e2di_uid_high << 16;
ip->i_gid |= (uint32_t)ei->e2di_gid_high << 16;
Jun 26 2017, 6:57 AM

Jun 19 2017

fsu added inline comments to D11211: ext2fs: Add uninit_bg feature support..
Jun 19 2017, 9:42 AM
fsu updated the diff for D11211: ext2fs: Add uninit_bg feature support..

Comments fixes.

Jun 19 2017, 9:41 AM
fsu updated the diff for D11210: ext2fs: Add dir_nlink feature support.

Fix ext2_max_nlink() function.

Jun 19 2017, 8:53 AM
fsu added a comment to D11210: ext2fs: Add dir_nlink feature support.
In D11210#233013, @pfg wrote:

For the case where EXT2F_ROCOMPAT_DIR_NLINK is defined, should be able to handle more that 65000 links.
This code doesn't support that case so we are not really supporting the feature.

I suspect the feature is not really usable on ext2.

Jun 19 2017, 8:52 AM

Jun 18 2017

fsu added a comment to D11209: ext2fs: Add huge_file feature RW support.
In D11209#233019, @pfg wrote:
In D11209#232927, @thisisadrgreenthumb_gmail.com wrote:
In D11209#232380, @pfg wrote:

I think the flag is unnecessary in this case due to the way the feature flags work:

  • ROCOMPAT means that even if not supported we can mount the file system (which we do).
  • defining the feature would mean we support it fully, which would imply write support.

Unfortunately, we can mount it only in READ ONLY mode, but we need RW, because, this feature is usefull on relatively old linux distros.

You mean ext2/3 with enabled EXT2F_ROCOMPAT_HUGE_FILE? The case makes little sense but last time the feature flags work in such a way that we can still mount the filesystem RW: we will just not write huge files.

Jun 18 2017, 8:28 PM
fsu added a comment to D11211: ext2fs: Add uninit_bg feature support..

Learned this man pages, but it is more about bit-sequences finding. Here I should only fill first parts of bitmaps. So, can not find how it is possible to apply it here.

Jun 18 2017, 3:17 PM
fsu updated the diff for D11210: ext2fs: Add dir_nlink feature support.

Use _NLINK_MAX limit depending of extfs version.

Jun 18 2017, 3:17 PM
fsu added a comment to D11209: ext2fs: Add huge_file feature RW support.
In D11209#232380, @pfg wrote:

I think the flag is unnecessary in this case due to the way the feature flags work:

  • ROCOMPAT means that even if not supported we can mount the file system (which we do).
  • defining the feature would mean we support it fully, which would imply write support.
Jun 18 2017, 3:16 PM

Jun 16 2017

fsu added a comment to D11211: ext2fs: Add uninit_bg feature support..

BTW, I think we might have code for CRCs in the kernel already. Not sure but ext2_crc16() may be redundant,

Jun 16 2017, 7:47 AM
fsu updated the diff for D11211: ext2fs: Add uninit_bg feature support..

Move csum logic to own file.

Jun 16 2017, 7:46 AM
fsu updated the diff for D11210: ext2fs: Add dir_nlink feature support.

Restrict LINK_MAX to 32k

Jun 16 2017, 7:45 AM
fsu updated the diff for D11209: ext2fs: Add huge_file feature RW support.

Just add only feature to RO_COMPAT.

Jun 16 2017, 7:44 AM
fsu updated the diff for D11208: ext2fs: Add unsupported ext2fs features dmesg report.

Swap features defines to enums.

Jun 16 2017, 7:43 AM

Jun 15 2017

fsu added a comment to D11209: ext2fs: Add huge_file feature RW support.

I am not sure, that bigalloc could be implemented in nearest feature, because it is one of most complex ext4 features. Ok, I will update diff, where I will remove the if() expression ext2_i2ei(), but will leave EXT2F_ROCOMPAT_HUGE_FILE under EXT2F_ROCOMPAT_SUPP

Jun 15 2017, 5:42 PM
fsu added a comment to D11211: ext2fs: Add uninit_bg feature support..

Ok, you are right, I will try to add file like ext2_csum.c

Jun 15 2017, 3:55 PM
fsu added a comment to D11209: ext2fs: Add huge_file feature RW support.

The code from ext2_inode_cnv.c could be removed until bigalloc will not be added. But in all cases EXT2F_ROCOMPAT_HUGE_FILE should be placed in correct place, because it is useful feature and we can not mount drives to RW mode.

Jun 15 2017, 3:54 PM
fsu added a comment to D11208: ext2fs: Add unsupported ext2fs features dmesg report.

Ok, I will try locally implement it as enum, if it will be suitable, I will update review

Jun 15 2017, 3:48 PM
fsu added a comment to D11210: ext2fs: Add dir_nlink feature support.

But we able to set 65000. I tested it on x86_64, but I can see the same for 32 bit platforms _types.h:
typedef uint64_t nlink_t; /* link count */

Jun 15 2017, 3:46 PM
fsu added a comment to D11208: ext2fs: Add unsupported ext2fs features dmesg report.

Fix for() loops.

Jun 15 2017, 3:13 PM
fsu updated the diff for D11208: ext2fs: Add unsupported ext2fs features dmesg report.

Sorry, but I did not get your idea, what use instead of struct in this case?

Jun 15 2017, 3:12 PM