Improve extents verification logic
ClosedPublic
Actions

Authored by fsu on Dec 10 2021, 5:23 PM.

Tags

None

Referenced Files

	F135944588: D33375.id99825.diff
	Fri, Nov 14, 10:20 AM

	Unknown Object (File)
	Tue, Nov 4, 7:36 PM

	Unknown Object (File)
	Mon, Nov 3, 12:35 AM

	Unknown Object (File)
	Sun, Oct 26, 9:48 PM

	Unknown Object (File)
	Sun, Oct 26, 4:28 PM

	Unknown Object (File)
	Sun, Oct 26, 12:17 PM

	Unknown Object (File)
	Sun, Oct 26, 12:35 AM

	Unknown Object (File)
	Oct 14 2025, 4:31 AM

View All Files

Subscribers

imp

Details

Reviewers

pfg
nc

Commits

rGf1d5e2c862ef: Improve extents verification logic

Summary

Add functionality for extents validation inside the filesystem extents block.
The main logic is implemented under ext4_validate_extent_entries() function, which verifies extents or extents indexes depending of extent depth value.

This PR is more robust fix for issue introduced in:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259112

Test Plan

Tested using next testing scripts:
https://github.com/thedrgreenthumb/Jenkins/tree/pjenkins/Target/ext2fs_test_all

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fsu created this revision.Dec 10 2021, 5:23 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 10 2021, 5:23 PM

fsu requested review of this revision.Dec 10 2021, 5:23 PM

pfg accepted this revision.Dec 11 2021, 12:37 AM

This revision is now accepted and ready to land.Dec 11 2021, 12:37 AM

Closed by commit rGf1d5e2c862ef: Improve extents verification logic (authored by fsu). · Explain WhyDec 30 2021, 6:15 AM

This revision was automatically updated to reflect the committed changes.

fsu added a commit: rGf1d5e2c862ef: Improve extents verification logic.

Revision Contents
Changeset List

Path

Size

sys/

fs/

ext2fs/

ext2_extents.c

291 lines

ext2_inode_cnv.c

8 lines

Diff 100747

View Options

sys/fs/ext2fs/ext2_extents.c