- User Since
- Aug 2 2014, 12:45 PM (251 w, 1 d)
Sat, May 25
This is a bit hacky, even for my standards, so I've come up with this as an alternative: https://reviews.freebsd.org/D20411.
Thu, May 23
Also call stuff for i386.
Tue, May 21
Move stuff around.
Mon, May 20
Drop unneeded line
Sun, May 19
Thu, May 16
Even more better ifdefs.
Okay, there's still something wrong. While "kldload linux64" works, the "kldload linux" doesn't due to "link_elf_obj: symbol linux_ptrace_status undefined" error.
Wed, May 15
One more ifdef, per dchagin's suggestion.
Tue, May 14
Ifdef out the thing.
Mon, May 13
Fri, May 10
Wed, May 8
That was copy/paste from OpenBSD's commit message, but okay. How about now?
Tue, May 7
Not sure what do you mean. I think I've marked all __inline functions there?
The title and description don't match the patch, but apart from that - looks good!
Okay. So... last chance for folks who want to be on the 'Reviewed by' list to mark it as Approved? Thanks :-)
Have you considered splitting it into two: one for getting rid of DEBUG, and one for preventing out of tree builds? The former looks fine, but I don’t understand the build system well enough wrt the latter.
Sun, May 5
Fri, May 3
Thu, May 2
So, given the dispute above is more about guidelines for Linux packages and less about this port in particular, is there anything left to do before this can be committed?
Wed, May 1
The kyua(1) man page does reference atf... in a way - it just .Xrs to it, without mentioning it in the text itself. And yeah, the Wiki does include some more detail, but I always view it as kind of additional source - I know I went for the man page first, and simply pointing me in the right direction would spare me some work. Basically - 'man tests' is the first place I'd look for information on tests. And as it is now, it mentions how to run them, but not how to write them.