Page MenuHomeFreeBSD

trasz (Edward Tomasz Napierała)
User

Projects

User Details

User Since
Aug 2 2014, 12:45 PM (337 w, 1 d)

Recent Activity

Yesterday

trasz updated the diff for D28212: linux: implement PTRACE_GET_SYSCALL_INFO.

Remove debugging printf.

Sun, Jan 17, 6:21 PM
trasz added reviewers for D28212: linux: implement PTRACE_GET_SYSCALL_INFO: Linux Emulation, jhb.
Sun, Jan 17, 6:18 PM
trasz requested review of D28212: linux: implement PTRACE_GET_SYSCALL_INFO.
Sun, Jan 17, 6:17 PM

Sat, Jan 16

trasz added a reviewer for D28192: linux: make fstatat(2) handle AT_EMPTY_PATH: Linux Emulation.
Sat, Jan 16, 4:30 PM
trasz requested review of D28192: linux: make fstatat(2) handle AT_EMPTY_PATH.
Sat, Jan 16, 4:29 PM

Fri, Jan 15

trasz added reviewers for D28178: linux: fix PTRACE_POKEDATA and PTRACE_POKETEXT.: Linux Emulation, jhb.
Fri, Jan 15, 10:46 PM
trasz requested review of D28178: linux: fix PTRACE_POKEDATA and PTRACE_POKETEXT..
Fri, Jan 15, 4:58 PM

Thu, Jan 14

trasz updated the diff for D28164: linux: add support for SO_PEERSEC getsockopt.

Refactor.

Thu, Jan 14, 7:11 PM
trasz added a reviewer for D28165: linux: add support for SO_PEERGROUPS: Linux Emulation.
Thu, Jan 14, 7:02 PM
trasz requested review of D28165: linux: add support for SO_PEERGROUPS.
Thu, Jan 14, 7:01 PM
trasz added a comment to D28164: linux: add support for SO_PEERSEC getsockopt.

For reference: http://kernsec.org/pipermail/linux-security-module-archive/2020-September/023250.html

Thu, Jan 14, 6:10 PM
trasz added a reviewer for D28164: linux: add support for SO_PEERSEC getsockopt: Linux Emulation.
Thu, Jan 14, 6:03 PM
trasz requested review of D28164: linux: add support for SO_PEERSEC getsockopt.
Thu, Jan 14, 6:02 PM
trasz committed rP561563: sysutils/debootstrap: install mremap(2) apt(8) workaround.
sysutils/debootstrap: install mremap(2) apt(8) workaround
Thu, Jan 14, 2:38 PM
trasz added a comment to D14835: Enhance support for Linux mremap system call.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=59912 could be useful perhaps?

Thu, Jan 14, 1:02 PM
trasz committed R10:feb96ee9c804: linux: mute "unsupported socket(AF_NETLINK, 3, NETLINK_AUDIT)" warnings (authored by trasz).
linux: mute "unsupported socket(AF_NETLINK, 3, NETLINK_AUDIT)" warnings
Thu, Jan 14, 9:48 AM

Wed, Jan 13

trasz added a comment to D28058: Build VirtIO modules on all architectures.

It might be useful to also install virtio man pages on all architectures (in share/man/man4/Makefile) then?

Wed, Jan 13, 5:14 PM
trasz accepted D28122: [mips] revert r366664 - flip mips back from -O2 to -O.
Wed, Jan 13, 5:07 PM
trasz committed R10:ec2700e01532: linux: mute the "unsupported prctl option 23" warnings (authored by trasz).
linux: mute the "unsupported prctl option 23" warnings
Wed, Jan 13, 10:32 AM
trasz added a comment to D28105: linux: bump the default version from 3.10.0 to 3.17.0.

Yup. We're still missing statx(2), but the ones above will do for now.

Wed, Jan 13, 10:03 AM
trasz committed R10:a339b4223a4f: linux: bump the default version from 3.10.0 to 3.17.0 (authored by trasz).
linux: bump the default version from 3.10.0 to 3.17.0
Wed, Jan 13, 10:03 AM
trasz closed D28105: linux: bump the default version from 3.10.0 to 3.17.0.
Wed, Jan 13, 10:02 AM
trasz committed rP561450: sysutils/debootstrap: add workarounds necessary for bootstrapping.
sysutils/debootstrap: add workarounds necessary for bootstrapping
Wed, Jan 13, 9:57 AM

Mon, Jan 11

trasz added a reviewer for D28105: linux: bump the default version from 3.10.0 to 3.17.0: Linux Emulation.
Mon, Jan 11, 10:59 PM
trasz requested review of D28105: linux: bump the default version from 3.10.0 to 3.17.0.
Mon, Jan 11, 10:58 PM

Mon, Jan 4

trasz added a comment to D27801: automount(8): try umount(8) before unmount(3).

The current diff seems a bit incomplete - previous one seemed ok, something between Phab and Git, perhaps?

Mon, Jan 4, 7:40 PM
trasz accepted D27807: Use compat.linux.emul_path instead of hardcoded path in /etc/rc.d/linux.

Looks good, thank you!

Mon, Jan 4, 4:33 PM · Linux Emulation

Tue, Dec 29

trasz added a comment to D27336: Make bsnmpclient(3) thread-safe.

... And reverted in f53120073b3 - mostly because, as Jessica pointed out, it would break existing applications which properly share the context between threads, eg by using explicit locking.

Tue, Dec 29, 8:06 PM
trasz added a reverting change for R10:89e3d5671ba1: bsnmpclient(3): make it thread-safe: R10:f53120073b32: Revert "bsnmpclient(3): make it thread-safe".
Tue, Dec 29, 8:00 PM
trasz added a reverting change for D27336: Make bsnmpclient(3) thread-safe: R10:f53120073b32: Revert "bsnmpclient(3): make it thread-safe".
Tue, Dec 29, 8:00 PM
trasz committed R10:f53120073b32: Revert "bsnmpclient(3): make it thread-safe" (authored by trasz).
Revert "bsnmpclient(3): make it thread-safe"
Tue, Dec 29, 7:59 PM
trasz updated the diff for D27812: camcontrol(8): remove unnecessary CCB zeroing.

Squash.

Tue, Dec 29, 5:31 PM
trasz updated the diff for D27813: camcontrol: stop pretending cam_cmd is a bitmask.

Drop unneeded changes.

Tue, Dec 29, 5:26 PM
trasz requested review of D27813: camcontrol: stop pretending cam_cmd is a bitmask.
Tue, Dec 29, 5:19 PM
trasz requested review of D27812: camcontrol(8): remove unnecessary CCB zeroing.
Tue, Dec 29, 5:19 PM
trasz added a comment to D26743: Factor out code from fstyp into libfstyp.

I'm not a huge fan of this, to be honest. Not the implementation, but rather the idea.

Tue, Dec 29, 4:21 PM
trasz added a comment to D26836: linsysfs: add drm render node.

Ping?

Tue, Dec 29, 3:32 PM
trasz added a comment to D27792: Ensure that d_off is initialized.

I don't remember much about how directory entries work, but I don't see anything wrong with the patch. I have a question, though: how did it work before? Is that field actually used?

Tue, Dec 29, 3:30 PM
trasz committed R10:89e3d5671ba1: bsnmpclient(3): make it thread-safe (authored by trasz).
bsnmpclient(3): make it thread-safe
Tue, Dec 29, 3:01 PM
trasz closed D27336: Make bsnmpclient(3) thread-safe.
Tue, Dec 29, 3:01 PM
trasz closed D27328: Fix memory leak by freein the 'addr'.
Tue, Dec 29, 2:55 PM
trasz committed R10:a7972b49044f: iscsid(8): fix memory leak by freeing the 'addr' (authored by trasz).
iscsid(8): fix memory leak by freeing the 'addr'
Tue, Dec 29, 2:55 PM
trasz closed D27329: Free data allocated by getaddrinfo(3).
Tue, Dec 29, 2:53 PM
trasz committed R10:7db3d97e0ffd: iscsid(8): free data allocated by getaddrinfo(3) (authored by trasz).
iscsid(8): free data allocated by getaddrinfo(3)
Tue, Dec 29, 2:53 PM
trasz closed D27330: In g_newprovider_event() return if G_P_WITHER is set.
Tue, Dec 29, 2:37 PM
trasz committed R10:123019739c90: geom(4): make g_newprovider_event() return if G_P_WITHER is set (authored by trasz).
geom(4): make g_newprovider_event() return if G_P_WITHER is set
Tue, Dec 29, 2:36 PM
trasz closed D27333: Make cam_getccb(3) zero the whole ccb, not just the header.
Tue, Dec 29, 2:29 PM
trasz committed R10:3e404b8c53db: libcam(3): make cam_getccb(3) zero the whole ccb, not just the header (authored by trasz).
libcam(3): make cam_getccb(3) zero the whole ccb, not just the header
Tue, Dec 29, 2:29 PM
trasz committed R10:4ddb3cc5973b: devfs(4): defer freeing until we drop devmtx ("cdev") (authored by trasz).
devfs(4): defer freeing until we drop devmtx ("cdev")
Tue, Dec 29, 2:07 PM
trasz closed D27334: Defer freeing until we drop devmtx.
Tue, Dec 29, 2:07 PM

Mon, Dec 28

trasz added a comment to D27337: Fix use after free in msdosfs_rename().

Which unlock? The gotos at 1048, 1057, 1062, 1076, 1080, 1085, and 1089 all get here without the lock held.

Mon, Dec 28, 6:21 PM

Sun, Dec 27

trasz updated the diff for D27784: nsdispatch(3): drop useless atexit hook.

Also remove now useless variable.

Sun, Dec 27, 5:02 PM
trasz requested review of D27784: nsdispatch(3): drop useless atexit hook.
Sun, Dec 27, 4:54 PM
trasz updated the diff for D26785: Get rid of useless stat(2) call.

Slightly improve.

Sun, Dec 27, 4:46 PM

Thu, Dec 24

trasz accepted D27699: Fix the types in some Linux syscall definitions.
Thu, Dec 24, 10:32 AM

Wed, Dec 23

trasz accepted D27740: linux64: Don't pass unnecessary -S and -g to objcopy.
Wed, Dec 23, 5:11 PM
trasz accepted D27647: Rename i386's Linux ELF to Linux ELF32.
Wed, Dec 23, 5:09 PM

Dec 13 2020

trasz committed R9:ad7ec3bbab13: Add myself. (authored by trasz).
Add myself.
Dec 13 2020, 6:02 PM
trasz committed R9:a579ede87d6b: Add my PGP keys. (authored by trasz).
Add my PGP keys.
Dec 13 2020, 6:02 PM
trasz committed R9:f35d8fbe19a4: Move myself from additional contributors to commiters. (authored by trasz).
Move myself from additional contributors to commiters.
Dec 13 2020, 6:02 PM
trasz committed R9:bffd0faf3b52: Add myself. (authored by trasz).
Add myself.
Dec 13 2020, 6:02 PM
trasz committed R9:b93716908b91: Add myself. (authored by trasz).
Add myself.
Dec 13 2020, 6:02 PM
trasz committed R9:85482a67a8c1: I'm a src commiter now. Wow. I mean... wow. ;-) (authored by trasz).
I'm a src commiter now. Wow. I mean... wow. ;-)
Dec 13 2020, 5:46 PM
trasz committed R9:aa7bafaaec1a: Document removal of VSVTX, VSGID and VSUID flags. (authored by trasz).
Document removal of VSVTX, VSGID and VSUID flags.
Dec 13 2020, 5:46 PM
trasz committed R9:a3ed6f0ef270: Bump __FreeBSD_version after introduction of accmode_t. (authored by trasz).
Bump __FreeBSD_version after introduction of accmode_t.
Dec 13 2020, 5:45 PM

Dec 12 2020

trasz planned changes to D27573: WIP: also handle sigfastblock.
Dec 12 2020, 9:29 PM

Dec 11 2020

trasz updated the diff for D27573: WIP: also handle sigfastblock.

Fix thinko.

Dec 11 2020, 3:57 PM
trasz planned changes to D27573: WIP: also handle sigfastblock.
Dec 11 2020, 3:51 PM
trasz requested review of D27573: WIP: also handle sigfastblock.
Dec 11 2020, 3:51 PM
trasz requested review of D27572: Add a mechanism to enable/disable syscall slow path.
Dec 11 2020, 3:28 PM
trasz updated the diff for D27332: Fix buffer overrun in getrpcport(3).

Make sure to request IPv4 address.

Dec 11 2020, 1:32 PM
trasz added a comment to D27337: Fix use after free in msdosfs_rename().

Ah, right. What do you think about the new patch? I've tried avoiding the relocking, but the code flow there is somewhat complicated and I'd probably introduce more bugs.

Dec 11 2020, 1:09 PM
trasz updated the diff for D27337: Fix use after free in msdosfs_rename().

Make sure the ip is valid.

Dec 11 2020, 1:08 PM
trasz updated the diff for D27569: Do not prompt for password if it's set to empty password.

Fix thinko.

Dec 11 2020, 12:04 PM
trasz added a reviewer for D27569: Do not prompt for password if it's set to empty password: des.
Dec 11 2020, 11:36 AM
trasz requested review of D27569: Do not prompt for password if it's set to empty password.
Dec 11 2020, 11:35 AM
trasz abandoned D27419: Make databases/sqlite3 use pread(2)/pwrite(2) syscalls..

Ah, never mind, there's https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241385 which is much better.

Dec 11 2020, 11:23 AM
trasz requested review of D27567: Make the private libsqlite3 lib use pread/pwrite.
Dec 11 2020, 11:03 AM

Dec 10 2020

trasz committed rS368510: Make "diskinfo -i" also test 1MB reads..
Make "diskinfo -i" also test 1MB reads.
Dec 10 2020, 10:23 AM

Dec 7 2020

trasz added a comment to D27337: Fix use after free in msdosfs_rename().
In D27337#613495, @kib wrote:
In D27337#610604, @kib wrote:

This is not a proper fix. ip is invalid the very moment fvp is unlocked.

"ip" as the pointer (later used to compare it with "xp"), or vnode data it points to?

Well, is a pointer to freed memory valid ? This is somewhat scholastic question, and I believe that our kernel depends on pointer value itself not becoming a poisoned value after free.
But the data it points to is invalid, and your patch still accesses the potentially freed or reused memory.

Dec 7 2020, 11:34 AM

Nov 30 2020

trasz updated the diff for D27419: Make databases/sqlite3 use pread(2)/pwrite(2) syscalls..

Bump PORTREVISION.

Nov 30 2020, 10:14 AM
trasz requested review of D27419: Make databases/sqlite3 use pread(2)/pwrite(2) syscalls..
Nov 30 2020, 10:13 AM

Nov 26 2020

trasz added a comment to D27334: Defer freeing until we drop devmtx.

(Tinderboxed.)

Nov 26 2020, 11:55 AM
trasz added a comment to D27328: Fix memory leak by freein the 'addr'.

(Tinderboxed.)

Nov 26 2020, 11:54 AM
trasz added a comment to D27329: Free data allocated by getaddrinfo(3).

(Tinderboxed.)

Nov 26 2020, 11:54 AM

Nov 25 2020

trasz added a comment to D27338: Fix vnode leak with msdosfs_rename().
In D27338#610605, @kib wrote:

Do you have repro ? Did you sent it to pho ?

Nov 25 2020, 2:16 PM
trasz added a comment to D27338: Fix vnode leak with msdosfs_rename().

(Tinderboxed.)

Nov 25 2020, 2:15 PM
trasz added a comment to D27330: In g_newprovider_event() return if G_P_WITHER is set.

(Tinderboxed.)

Nov 25 2020, 2:14 PM
trasz added a comment to D27333: Make cam_getccb(3) zero the whole ccb, not just the header.

(Tinderboxed.)

Nov 25 2020, 2:14 PM

Nov 24 2020

trasz added inline comments to D27332: Fix buffer overrun in getrpcport(3).
Nov 24 2020, 11:18 AM
trasz added a comment to D27132: Clear TDB_USERWR in ast().
In D27132#610070, @kib wrote:

Until you set ast flag for other threads, they can run arbitrary amount of code, including syscalls.

Nov 24 2020, 11:04 AM
trasz added inline comments to D27339: Fix double unlock if the source file disappears.
Nov 24 2020, 10:59 AM
trasz added a comment to D27337: Fix use after free in msdosfs_rename().
In D27337#610604, @kib wrote:

This is not a proper fix. ip is invalid the very moment fvp is unlocked.

Nov 24 2020, 10:56 AM
trasz updated the summary of D27334: Defer freeing until we drop devmtx.
Nov 24 2020, 10:46 AM
trasz updated the diff for D27334: Defer freeing until we drop devmtx.

Prettify.

Nov 24 2020, 10:45 AM
trasz added a comment to D27336: Make bsnmpclient(3) thread-safe.

(Tinderboxed.)

Nov 24 2020, 10:41 AM

Nov 23 2020

trasz closed D27249: Replace paths in ctladm(8) examples with something sensible.
Nov 23 2020, 2:30 PM
trasz committed rS367956: Replace paths in ctladm(8) examples with something sensible..
Replace paths in ctladm(8) examples with something sensible.
Nov 23 2020, 2:30 PM
trasz closed D27248: Assorted tweaks to hier(7).
Nov 23 2020, 2:27 PM
trasz committed rS367954: Assorted tweaks to hier(7): punctuation, some .Xr's, clarify wording..
Assorted tweaks to hier(7): punctuation, some .Xr's, clarify wording.
Nov 23 2020, 2:27 PM