trasz (Edward Tomasz Napierała)
User

Projects

User Details

User Since
Aug 2 2014, 12:45 PM (185 w, 6 d)

Recent Activity

Wed, Feb 21

trasz committed rS329724: Build getty(8) with WARNS=6..
Build getty(8) with WARNS=6.
Wed, Feb 21, 3:57 PM
trasz closed D14197: Build getty(8) with WARNS=6.
Wed, Feb 21, 3:57 PM
trasz committed rS329708: Use proper buffer length (the announce_buf char pointer used to be anarray),.
Use proper buffer length (the announce_buf char pointer used to be anarray),
Wed, Feb 21, 2:05 PM
trasz closed D14369: Fix "cd0: Attempt".
Wed, Feb 21, 2:05 PM

Wed, Feb 14

trasz added a comment to D14369: Fix "cd0: Attempt".

Fixes https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222103.

Wed, Feb 14, 2:14 PM
trasz added reviewers for D14369: Fix "cd0: Attempt": scottl, imp.
Wed, Feb 14, 2:14 PM
trasz retitled D14369: Fix "cd0: Attempt" from Fix "cd0: Attempt" Use proper buffer length (the announce_buf char pointer used to be an array), broken in r317143. to Fix "cd0: Attempt".
Wed, Feb 14, 2:14 PM
trasz created D14369: Fix "cd0: Attempt".
Wed, Feb 14, 2:13 PM

Sun, Feb 11

trasz added a comment to D14197: Build getty(8) with WARNS=6.

(Note to self: tinderboxed.)

Sun, Feb 11, 2:02 PM
trasz committed rS329123: Make lock(1) use PAM. This makes the -p option work again. (Well, kind of,.
Make lock(1) use PAM. This makes the -p option work again. (Well, kind of,
Sun, Feb 11, 1:35 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Sun, Feb 11, 1:35 PM

Sat, Feb 10

trasz added a reviewer for D14307: Improve missing tty handling in init(8): imp.
Sat, Feb 10, 8:25 PM
trasz updated the summary of D14307: Improve missing tty handling in init(8).
Sat, Feb 10, 8:25 PM
trasz created D14307: Improve missing tty handling in init(8).
Sat, Feb 10, 8:24 PM
trasz added a comment to D14198: Prevent getty(8) from looping if the device node doesn't exist..

I tried digging a little, and unfortunately the loop comes from before our repo history starts - r1593, which is some RCS repo surgery by rgrimes@.

Sat, Feb 10, 7:35 PM
trasz updated the diff for D4981: Add PAM support for lock(1). This makes "lock -p" actually useful..

Make tinderbox happy.

Sat, Feb 10, 7:12 PM
trasz added a comment to D14197: Build getty(8) with WARNS=6.

So, does it look reasonable enough to get accepted? Thanks!

Sat, Feb 10, 4:35 PM

Mon, Feb 5

trasz updated the diff for D14197: Build getty(8) with WARNS=6.

Some of the improvements suggested by imp@.

Mon, Feb 5, 10:46 AM
trasz added inline comments to D14197: Build getty(8) with WARNS=6.
Mon, Feb 5, 10:45 AM

Sun, Feb 4

trasz added a comment to D14198: Prevent getty(8) from looping if the device node doesn't exist..

Well, if it was specified in ttys as "on", that's what would happen. But it's supposed to be used with "onifexists", or perhaps "onifconsole".

Sun, Feb 4, 9:24 PM
trasz added a reviewer for D14198: Prevent getty(8) from looping if the device node doesn't exist.: imp.
Sun, Feb 4, 8:17 PM
trasz updated the summary of D14198: Prevent getty(8) from looping if the device node doesn't exist..
Sun, Feb 4, 8:17 PM
trasz created D14198: Prevent getty(8) from looping if the device node doesn't exist..
Sun, Feb 4, 8:15 PM
trasz added a reviewer for D14197: Build getty(8) with WARNS=6: imp.
Sun, Feb 4, 8:07 PM
trasz created D14197: Build getty(8) with WARNS=6.
Sun, Feb 4, 8:06 PM
trasz committed rS328858: Sprinkle static; avoid nested externs..
Sprinkle static; avoid nested externs.
Sun, Feb 4, 7:05 PM
trasz committed rS328857: Add missing initializer..
Add missing initializer.
Sun, Feb 4, 6:40 PM
trasz committed rS328856: Rename getty's getline() to get_line(), to avoid clash with getline(3)..
Rename getty's getline() to get_line(), to avoid clash with getline(3).
Sun, Feb 4, 6:40 PM
trasz committed rS328855: Don't cast away the const, it's not been needed since r92925..
Don't cast away the const, it's not been needed since r92925.
Sun, Feb 4, 6:36 PM
trasz committed rS328846: Initialize all the fields. This is one of the steps required to bump WARNS..
Initialize all the fields. This is one of the steps required to bump WARNS.
Sun, Feb 4, 1:58 PM
trasz committed rS328843: Reduce code duplication; no functional changes..
Reduce code duplication; no functional changes.
Sun, Feb 4, 1:55 PM
trasz committed rS328841: Remove unused variable..
Remove unused variable.
Sun, Feb 4, 1:54 PM

Tue, Jan 30

trasz committed rS328590: Document the new hw.usb.template behaviour..
Document the new hw.usb.template behaviour.
Tue, Jan 30, 10:10 AM
trasz committed rS328589: Make the handler routine for the hw.usb.template sysctl trigger the USB.
Make the handler routine for the hw.usb.template sysctl trigger the USB
Tue, Jan 30, 10:08 AM

Sat, Jan 27

trasz committed rS328456: Remove mention of sys/boot/ from hier(7), it doesn't exist anymore..
Remove mention of sys/boot/ from hier(7), it doesn't exist anymore.
Sat, Jan 27, 12:10 AM

Fri, Jan 26

trasz accepted D13746: Don't truncate name of label, just report that is invalid..
Fri, Jan 26, 6:54 PM

Wed, Jan 24

trasz committed rS328342: Add SPDX identifiers to linux_ptrace.c and cfumass.c..
Add SPDX identifiers to linux_ptrace.c and cfumass.c.
Wed, Jan 24, 5:04 PM
trasz committed rS328341: Add SPDX tags to iscsi(4)..
Add SPDX tags to iscsi(4).
Wed, Jan 24, 4:58 PM
trasz committed rS328339: Add SPDX tags to autofs(5)..
Add SPDX tags to autofs(5).
Wed, Jan 24, 4:40 PM
trasz committed rS328338: Add SPDX tags for automount(8) et al..
Add SPDX tags for automount(8) et al.
Wed, Jan 24, 4:39 PM
trasz committed rS328337: Add missing SPDX tags for ctld(8)..
Add missing SPDX tags for ctld(8).
Wed, Jan 24, 4:37 PM
trasz committed rS328336: Add missing SPDX identifier in iscsid(8)..
Add missing SPDX identifier in iscsid(8).
Wed, Jan 24, 4:34 PM
trasz committed rS328335: Add SPDX identifiers for uefisign(8) sources..
Add SPDX identifiers for uefisign(8) sources.
Wed, Jan 24, 4:33 PM

Jan 21 2018

trasz committed rS328219: Add missing manufacturer/serial number string descriptors..
Add missing manufacturer/serial number string descriptors.
Jan 21 2018, 5:31 PM

Jan 20 2018

trasz committed rS328197: Remove unused index..
Remove unused index.
Jan 20 2018, 2:06 PM
trasz committed rS328196: Add missing SPDX tags; the rest of the license text is the same as in other.
Add missing SPDX tags; the rest of the license text is the same as in other
Jan 20 2018, 2:04 PM
trasz committed rS328195: Add usb_template(4) to RPI-B kernel config. This is to support the USB OTG.
Add usb_template(4) to RPI-B kernel config. This is to support the USB OTG
Jan 20 2018, 2:00 PM
trasz closed D13924: Add usb_template to RPI-B.
Jan 20 2018, 2:00 PM
trasz committed rS328194: Add sysctls to control device side USB identifiers. This makes it.
Add sysctls to control device side USB identifiers. This makes it
Jan 20 2018, 1:58 PM
trasz closed D13920: Add sysctls to control device side USB identifiers..
Jan 20 2018, 1:58 PM

Jan 16 2018

trasz added inline comments to D13920: Add sysctls to control device side USB identifiers..
Jan 16 2018, 3:44 PM
trasz updated the diff for D13920: Add sysctls to control device side USB identifiers..

... and add back the man page.

Jan 16 2018, 3:43 PM
trasz updated the diff for D13920: Add sysctls to control device side USB identifiers..

Fixes from hselasky@, plus comment out the sysctl nodes for interface strings.

Jan 16 2018, 3:42 PM
trasz added a comment to D13920: Add sysctls to control device side USB identifiers..

Ah, before you ask - the "deduplication". I hadn't done that for two reasons. First, most of the settings for each template need to be separate anyway, since you'll want different product IDs and strings. Pretty much the only common thing would be the vendor, and complicating things just for that seems a bit... superfluous. Also, in some cases you might actually want a separate vendor/manufacturer anyway - if, for example, you wanted a template that closely mimics the FTDI.

Jan 16 2018, 11:22 AM

Jan 15 2018

trasz added a reviewer for D13924: Add usb_template to RPI-B: hselasky.
Jan 15 2018, 8:32 PM
trasz created D13924: Add usb_template to RPI-B.
Jan 15 2018, 8:32 PM
trasz added a comment to D13920: Add sysctls to control device side USB identifiers..

Note there are some other minor changes I'd like to do - such as adding missing "manufacturer" identifiers for some of the templates, or unifying that field's contents for all templates. I'd prefer to do this in a subsequent commit - this one here closely preserves the existing behaviour.

Jan 15 2018, 5:37 PM
trasz updated the summary of D13920: Add sysctls to control device side USB identifiers..
Jan 15 2018, 5:35 PM
trasz created D13920: Add sysctls to control device side USB identifiers..
Jan 15 2018, 5:33 PM

Jan 10 2018

trasz committed rS327777: Make nullfs properly report MNT_AUTOMOUNTED set on the nullfs mount itself,.
Make nullfs properly report MNT_AUTOMOUNTED set on the nullfs mount itself,
Jan 10 2018, 5:51 PM

Jan 3 2018

trasz committed rS327522: Fix warnings from "mandoc -Tlint -Wwarning"..
Fix warnings from "mandoc -Tlint -Wwarning".
Jan 3 2018, 5:28 PM

Dec 30 2017

trasz committed rS327382: Improve usbconfig(8) manual page by adding descriptions for subcommands..
Improve usbconfig(8) manual page by adding descriptions for subcommands.
Dec 30 2017, 12:57 PM
trasz closed D13445: Improve usbconfig(8) manual page.
Dec 30 2017, 12:57 PM

Dec 28 2017

trasz added a comment to D13445: Improve usbconfig(8) manual page.

So, how does it look now?

Dec 28 2017, 3:56 PM
trasz updated the diff for D13445: Improve usbconfig(8) manual page.

Fix capitalization and .Dd.

Dec 28 2017, 3:56 PM
trasz updated the diff for D13445: Improve usbconfig(8) manual page.

More changes.

Dec 28 2017, 3:53 PM

Dec 13 2017

trasz committed rS326820: Tone down the description for the growfs "-y" flag..
Tone down the description for the growfs "-y" flag.
Dec 13 2017, 2:09 PM

Dec 12 2017

trasz updated the diff for D13445: Improve usbconfig(8) manual page.

Various fixes.

Dec 12 2017, 12:17 PM
trasz added inline comments to D13445: Improve usbconfig(8) manual page.
Dec 12 2017, 12:15 PM

Dec 11 2017

trasz added a reviewer for D13445: Improve usbconfig(8) manual page: hselasky.
Dec 11 2017, 1:18 PM
trasz created D13445: Improve usbconfig(8) manual page.
Dec 11 2017, 1:18 PM

Dec 9 2017

trasz committed rS326730: Move the DIAGNOSTIC check for lost iSCSI PDUs from icl_conn_close().
Move the DIAGNOSTIC check for lost iSCSI PDUs from icl_conn_close()
Dec 9 2017, 3:35 PM

Dec 2 2017

trasz committed rS326471: Document autofs(6) sysctl variables..
Document autofs(6) sysctl variables.
Dec 2 2017, 1:12 PM

Dec 1 2017

trasz committed rS326430: Add "vmaddr" ps(1) keyword..
Add "vmaddr" ps(1) keyword.
Dec 1 2017, 11:32 AM

Nov 30 2017

trasz committed rS326393: Make the ddb(4) "set" command list variables when called without parameters..
Make the ddb(4) "set" command list variables when called without parameters.
Nov 30 2017, 12:22 PM

Nov 28 2017

trasz committed rS326314: Make kdb_reenter() silent when explicitly called from db_error()..
Make kdb_reenter() silent when explicitly called from db_error().
Nov 28 2017, 12:54 PM
trasz closed D13212: Unclutter ddb(4) error handling.
Nov 28 2017, 12:54 PM

Nov 27 2017

trasz committed rS326252: Add /etc/autofs/include_nis, a non-rewriting NIS map..
Add /etc/autofs/include_nis, a non-rewriting NIS map.
Nov 27 2017, 12:50 PM
trasz committed rS326251: Rename /etc/autofs/include_nis to /etc/autofs/include_nis_nullfs, to indicate.
Rename /etc/autofs/include_nis to /etc/autofs/include_nis_nullfs, to indicate
Nov 27 2017, 12:46 PM
trasz committed rS326250: Change formatting; no functional changes..
Change formatting; no functional changes.
Nov 27 2017, 12:44 PM
trasz committed rS326249: Update intro(6) - remove hint that doesn't work, add explicit list.
Update intro(6) - remove hint that doesn't work, add explicit list
Nov 27 2017, 12:39 PM
trasz closed D13196: Update intro(6).
Nov 27 2017, 12:39 PM
trasz committed rS326248: .Xr pmcstat(8) from kgmon(8) and gprof(1)..
.Xr pmcstat(8) from kgmon(8) and gprof(1).
Nov 27 2017, 12:37 PM
trasz committed rS326247: Revert r326125..
Revert r326125.
Nov 27 2017, 12:34 PM

Nov 25 2017

trasz added a comment to D13212: Unclutter ddb(4) error handling.

Thanks. Not sure why I went with the additional variable, tbh. Also, there are a few other calls to kdb_enter(), so I think adding a separate kdb_enter_silent() is nicer, especially regarding that it's a pretty small function and doesn't really need a wrapper.

Nov 25 2017, 3:21 PM
trasz updated the diff for D13212: Unclutter ddb(4) error handling.

Use kdb_reenter_silent() instead of an additional variable.

Nov 25 2017, 3:20 PM

Nov 23 2017

trasz planned changes to D13211: Make the 'q' in ddb(4) pager actually abort the output.
Nov 23 2017, 3:39 PM
trasz added a reviewer for D13212: Unclutter ddb(4) error handling: jhb.
Nov 23 2017, 12:53 PM
trasz created D13212: Unclutter ddb(4) error handling.
Nov 23 2017, 12:53 PM
trasz added a reviewer for D13211: Make the 'q' in ddb(4) pager actually abort the output: jhb.
Nov 23 2017, 12:48 PM
trasz created D13211: Make the 'q' in ddb(4) pager actually abort the output.
Nov 23 2017, 12:47 PM
trasz closed D12574: Mark kgmon(8) as obsolete.
Nov 23 2017, 12:41 PM
trasz committed rS326125: Mark kgmon(8) obsolete, redirecting users to pmcstat(8)..
Mark kgmon(8) obsolete, redirecting users to pmcstat(8).
Nov 23 2017, 12:41 PM

Nov 22 2017

trasz created D13196: Update intro(6).
Nov 22 2017, 9:08 PM
trasz added a comment to D13193: iscsisctl language fixes.

Oh wow. It's hard to believe I managed to overlook _that_. Approved :-)

Nov 22 2017, 6:13 PM

Nov 19 2017

trasz added a comment to D12574: Mark kgmon(8) as obsolete.

No idea if it works. Few months ago I've tried to build the kernel with kgmon support, and it didn't build. Either way, the correct way to phasing it out is to declare it obsoleted in the man page, and I think that's something that can be done without checking if it actually works.

Nov 19 2017, 12:42 PM

Nov 18 2017

trasz added a comment to D13143: Make rtld use read(2) instead of mmap(2) for ELF headers.

Why twice?

Nov 18 2017, 3:16 PM
trasz closed D12834: Bump initial rtld memory pool size.
Nov 18 2017, 1:21 PM
trasz committed rS325965: Increase rtld initial memory pool size from 32kB to 128kB..
Increase rtld initial memory pool size from 32kB to 128kB.
Nov 18 2017, 1:21 PM
trasz added a comment to D12834: Bump initial rtld memory pool size.

I've tested it on i386, and yes, 32k is not enough there as well.

Nov 18 2017, 12:49 PM