Page MenuHomeFreeBSD

trasz (Edward Tomasz Napierała)
User

Projects

User Details

User Since
Aug 2 2014, 12:45 PM (258 w, 4 d)

Recent Activity

Yesterday

trasz added inline comments to D20655: Make use of stats(3) in the TCP stack.
Wed, Jul 17, 8:06 PM
trasz added a comment to D20477: Introduce stats(3).

One more fix from Allan.

Wed, Jul 17, 7:43 PM

Mon, Jul 15

trasz updated the summary of D20477: Introduce stats(3).
Mon, Jul 15, 7:42 PM
trasz updated the summary of D20477: Introduce stats(3).
Mon, Jul 15, 7:38 PM
trasz updated the summary of D20655: Make use of stats(3) in the TCP stack.
Mon, Jul 15, 6:43 PM
trasz added a comment to D20324: Introduce the ARB tree(3) macros.
In D20324#450030, @cem wrote:

But I've added the justification (explanation of what's the point of ARB, from the consumer point of view) to the man page already. What else is needed?

Are you referring to the single sentence, "[ARB trees] are useful, e.g., when the tree needs to be [transferred] between userspace and kernel", or am I missing the justification? If I am missing the complete justification, please point me at the part of the text that justifies the design. I am looking for considerably better justification than that single sentence.

Mon, Jul 15, 6:37 PM
trasz updated the summary of D20324: Introduce the ARB tree(3) macros.
Mon, Jul 15, 5:17 PM
trasz updated the summary of D20324: Introduce the ARB tree(3) macros.
Mon, Jul 15, 5:16 PM
trasz updated the summary of D20116: Introduce <sys/qmath.h>.
Mon, Jul 15, 5:01 PM
trasz updated the summary of D20655: Make use of stats(3) in the TCP stack.
Mon, Jul 15, 4:30 PM

Sun, Jul 14

trasz updated the summary of D20324: Introduce the ARB tree(3) macros.
Sun, Jul 14, 9:25 PM
trasz updated the summary of D20656: Add new port: net/tcprtt: reliably measure the TCP handshake round trip time using stats(9).
Sun, Jul 14, 7:06 PM

Sat, Jul 13

trasz added inline comments to D20116: Introduce <sys/qmath.h>.
Sat, Jul 13, 7:22 PM
trasz updated the summary of D20116: Introduce <sys/qmath.h>.

Update the example.

Sat, Jul 13, 7:21 PM

Wed, Jul 10

trasz updated the summary of D20720: Make linuxulator handle ELFOSABI_NONE ELF executables.
Wed, Jul 10, 2:08 PM
trasz updated the summary of D20720: Make linuxulator handle ELFOSABI_NONE ELF executables.
Wed, Jul 10, 2:07 PM
trasz added a comment to D20720: Make linuxulator handle ELFOSABI_NONE ELF executables.

Remove some cruft.

Wed, Jul 10, 2:04 PM
trasz added a comment to D20720: Make linuxulator handle ELFOSABI_NONE ELF executables.
In D20720#452395, @kib wrote:
In D20720#452276, @kib wrote:

Well, yes, that’s precisely what it’s intended to do.

It would be even fine if we knew the side effects in advance. I can only repeat, such change should be accompanied by the analysis of effects on other ABIs.

Okay, but what do you mean by that? Apart from what I've done, which is looking at various binaries in FreeBSD, both base and some packages, to verify they are all properly branded?

What you did is just a way to start examine the change and see that it does not break things big outright.
What is needed is understanding how does the change affects selection of the ABI for binary, i.e. explanation which binaries suddenly start being classified for different brand.
That said, we already have sysctl kern.elf{32,64}.fallback_brand and brandelf(8).

Wed, Jul 10, 1:43 PM
trasz updated the summary of D20116: Introduce <sys/qmath.h>.
Wed, Jul 10, 12:37 PM

Tue, Jul 9

trasz retitled D20656: Add new port: net/tcprtt: reliably measure the TCP handshake round trip time using stats(9) from Add new port: net/tcprtt: reliably measure the TCP handshake round trip time using stats(9) to Add new port: net/tcprtt: reliably measure the TCP handshake round trip time using stats(9).

Move sources to GitHub, add __FreeBSD_version check.

Tue, Jul 9, 7:51 PM

Sun, Jul 7

trasz added a comment to D20477: Introduce stats(3).

Update to the new Q_INI(3) syntax; no functional changes.

Sun, Jul 7, 7:56 PM
trasz added a comment to D20116: Introduce <sys/qmath.h>.
In D20116#449151, @cem wrote:
In D20116#448878, @cem wrote:

I think there are open questions around rounding behavior and making the extensive macros into functions.

The problem with functions is that in many places it uses Q_TC() (which boils down to __typeof()), or macros that expand to Q_TC(). I guess I could try to rework the ones which don't, but that would look inconsistent.

Is it really useful to have any of these operate on anything smaller than a machine word? I think you could basically do all the math on unsigned long (and perhaps uint64_t for 32-bit arch) in functions and just use macros for thin shims that convert word-sized results to the magical smaller width types. Functions are really a lot better than macros to debug and analyze so even if there is a little pain over the current macro approach, I think it is sometimes worth it.

Sun, Jul 7, 7:49 PM
trasz added a comment to D20116: Introduce <sys/qmath.h>.

Merge upstream change from lstewart@:

Sun, Jul 7, 7:45 PM
trasz added a comment to D20720: Make linuxulator handle ELFOSABI_NONE ELF executables.
In D20720#452276, @kib wrote:

Well, yes, that’s precisely what it’s intended to do.

It would be even fine if we knew the side effects in advance. I can only repeat, such change should be accompanied by the analysis of effects on other ABIs.

Sun, Jul 7, 5:07 PM
trasz added a comment to D20864: Let linuxulator mprotect mask unsupported bits before calling kern_mprotect.

(And if you're feeling adventurous, the linux-ltp port contains mprotect tests; you might want to check those as well.)

Sun, Jul 7, 5:00 PM
D20864: Let linuxulator mprotect mask unsupported bits before calling kern_mprotect is now accepted and ready to land.

Looks good. One thing you might want to check, if you have time, is that whether we should just ignore unknown flags? I seem to remember (although I might well be completely confused here) that Linux mmap used to ignore unknown bits; does linux mremap perhaps do the same?

Sun, Jul 7, 4:55 PM
trasz added a comment to D20720: Make linuxulator handle ELFOSABI_NONE ELF executables.

Well, yes, that’s precisely what it’s intended to do.

Sun, Jul 7, 11:05 AM

Sat, Jul 6

trasz added a comment to D20720: Make linuxulator handle ELFOSABI_NONE ELF executables.

Which other ABIs?

Sat, Jul 6, 6:47 AM

Thu, Jul 4

trasz added a comment to D20116: Introduce <sys/qmath.h>.

Merge upstream change from lstewart@:

Thu, Jul 4, 8:21 PM
trasz closed D20690: Silently ignore FS_IOC_FIEMAP.
Thu, Jul 4, 8:16 PM
trasz committed rS349750: Return ENOTSUP for Linux FS_IOC_FIEMAP ioctl..
Return ENOTSUP for Linux FS_IOC_FIEMAP ioctl.
Thu, Jul 4, 8:16 PM
trasz added a comment to D20685: Relax compat.linux.osrelease checks.

Anyone?

Thu, Jul 4, 7:49 PM
trasz committed rS349748: Add support for PTRACE_O_TRACEEXIT to linuxulator ptrace(2)..
Add support for PTRACE_O_TRACEEXIT to linuxulator ptrace(2).
Thu, Jul 4, 7:47 PM
trasz closed D20689: Add support for PTRACE_O_TRACEEXIT to linuxulator ptrace(2).
Thu, Jul 4, 7:47 PM
trasz closed D20691: Implement PTRACE_GETSIGINFO.
Thu, Jul 4, 7:44 PM
trasz committed rS349747: Implement PTRACE_GETSIGINFO. This makes Linux strace(1) quieter.
Implement PTRACE_GETSIGINFO. This makes Linux strace(1) quieter
Thu, Jul 4, 7:44 PM
trasz closed D20692: Fix prlimit64(2) with pid == 0.
Thu, Jul 4, 7:40 PM
trasz committed rS349746: Fix linuxulator prlimit64(2) with pid == 0. This makes 'ulimit -a'.
Fix linuxulator prlimit64(2) with pid == 0. This makes 'ulimit -a'
Thu, Jul 4, 7:40 PM
trasz abandoned D19458: Drop unused 'p' argument to nfsvno_link();.
Thu, Jul 4, 7:19 PM
trasz abandoned D19457: Drop unused 'p' argument to nfsvno_rmdirsub();.
Thu, Jul 4, 7:19 PM
trasz abandoned D19456: Drop unused 'p' argument to nfsvno_readlink();.
Thu, Jul 4, 7:19 PM
trasz abandoned D19454: Drop unused 'p' argument to nfsvno_getfh()..
Thu, Jul 4, 7:19 PM
trasz abandoned D19453: Drop unused 'p' argument to nfsrv_findlayout()..
Thu, Jul 4, 7:19 PM
trasz abandoned D19452: Drop unused 'p' argument to nfsrv_checksequence()..
Thu, Jul 4, 7:18 PM
trasz abandoned D19451: Drop unused 'p' argument to nfsvno_symlink()..
Thu, Jul 4, 7:18 PM
trasz abandoned D19450: Drop unused 'p' argument to nfsvno_mkdir()..
Thu, Jul 4, 7:18 PM
trasz abandoned D19449: Drop unused 'p' argument to nfsvno_mknod()..
Thu, Jul 4, 7:18 PM
trasz abandoned D19448: Don't pass td to nfsvno_fillattr()..
Thu, Jul 4, 7:18 PM
trasz abandoned D19447: Don't pass td to nfsrv_checkgetattr()..
Thu, Jul 4, 7:18 PM
trasz abandoned D19445: Don't pass td to nfsrvd_mkdirsub() and nfsrvd_symlinksub()..
Thu, Jul 4, 7:18 PM
trasz abandoned D19444: Don't pass td to nfsrv_opencheck()..
Thu, Jul 4, 7:18 PM
trasz abandoned D19443: Don't pass td to nfsrv_pnfscreate()..
Thu, Jul 4, 7:17 PM
trasz abandoned D19442: Push td down nfsvno_accchk()..
Thu, Jul 4, 7:17 PM
trasz abandoned D19423: Push td down into nfssvc_srvcall()..
Thu, Jul 4, 7:17 PM
trasz abandoned D19415: Assert that cnp->cn_thread is always curthread.
Thu, Jul 4, 7:17 PM
trasz abandoned D17789: Fix msg_controllen example.
Thu, Jul 4, 7:17 PM
trasz added a comment to D20757: Bump Linux version to 3.2.0.

And, FWIW, glibc doesn't seem to have any kind of fanotify fallback.

Thu, Jul 4, 6:47 PM
trasz added a comment to D20720: Make linuxulator handle ELFOSABI_NONE ELF executables.

Ping? Does the patch look ok?

Thu, Jul 4, 6:40 PM
trasz added a comment to D20757: Bump Linux version to 3.2.0.

I see the following after 2.6.32 and up to and including 3.2, with uninteresting ports (e.g. m68k) excluded:

recvmmsg(2)                2.6.33
prlimit64(2)               2.6.36
Thu, Jul 4, 6:38 PM
trasz added inline comments to D20116: Introduce <sys/qmath.h>.
Thu, Jul 4, 5:26 PM
trasz added a comment to D20116: Introduce <sys/qmath.h>.

Fixes from sef@ and allanjude@.

Thu, Jul 4, 5:26 PM

Fri, Jun 28

trasz added inline comments to D20655: Make use of stats(3) in the TCP stack.
Fri, Jun 28, 8:53 PM
trasz added a comment to D20324: Introduce the ARB tree(3) macros.

Fix typo.

Fri, Jun 28, 8:49 PM
trasz added a comment to D20116: Introduce <sys/qmath.h>.

Fix use of pointers as booleans, use ptrdiff_t, and add brief explanation
of rounding (or lack thereof).

Fri, Jun 28, 8:45 PM
trasz added a comment to D20324: Introduce the ARB tree(3) macros.
In D20324#449149, @cem wrote:

So... is there anything else left to do here?

A design justification is still missing. Pointing to another proposed patch with fundamentally the same unanswered design questions as a potential consumer isn't in itself a good justification to take this.

Fri, Jun 28, 12:18 PM

Tue, Jun 25

trasz added a comment to D20324: Introduce the ARB tree(3) macros.

So... is there anything else left to do here?

Tue, Jun 25, 6:17 PM
trasz added a comment to D20324: Introduce the ARB tree(3) macros.

Add ARB_ALLOCSIZE().

Tue, Jun 25, 6:16 PM
trasz added a comment to D20757: Bump Linux version to 3.2.0.

Do we have a list of syscalls/interfaces by kernel version anywhere?

Tue, Jun 25, 5:36 PM
trasz added a comment to D20687: Fix execution of linux binaries with glibc>=2.24.

Also is it the case that /bin/echo 1 1 1 1 1... consistently fails with some number of 1s and runs successfully with other cases? Like 1 1 1 works, 1 1 1 1 fails, 1 1 1 1 1 works?

Tue, Jun 25, 5:33 PM
trasz added a comment to D20687: Fix execution of linux binaries with glibc>=2.24.

Do you have more details about working/non-working versions? I.e., what glibc version works?

Tue, Jun 25, 5:32 PM
trasz added a comment to D20116: Introduce <sys/qmath.h>.
In D20116#448878, @cem wrote:

So... is there anything else left for me to do here before this can get committed?

I think there are open questions around rounding behavior and making the extensive macros into functions.

Tue, Jun 25, 5:30 PM
trasz updated the summary of D20757: Bump Linux version to 3.2.0.
Tue, Jun 25, 2:52 PM
trasz added reviewers for D20757: Bump Linux version to 3.2.0: dchagin, Linux Emulation.
Tue, Jun 25, 2:43 PM
trasz created D20757: Bump Linux version to 3.2.0.
Tue, Jun 25, 2:43 PM
trasz added a comment to D20116: Introduce <sys/qmath.h>.

So... is there anything else left for me to do here before this can get committed?

Tue, Jun 25, 1:16 PM

Mon, Jun 24

trasz added a comment to D20720: Make linuxulator handle ELFOSABI_NONE ELF executables.

Many many many Linux binaries are ELFOSABI_NONE.
The Elf64_Brandinfo definitions directly above the added lines allow executables with ELFOSABI_NONE to run when interp_path matches. You can see one was added for musl libc, before that one was added, Alpine Linux did not work.
But that's for normal executables.

But the musl entry still says ELFOSABI_LINUX, doesn't it?

Yes, that doesn't mean it won't match with NONE.
https://github.com/freebsd/freebsd/blob/fc870a6df90c3876ec348720e21e74beb8b70d92/sys/kern/imgact_elf.c#L378-L395 "Lacking a known brand, search for a recognized interpreter"

Mon, Jun 24, 8:59 PM
trasz added a comment to D20693: Fix bogomips calculation.

It was compared under VMWare Fusion - with the change the value matches what the actual CentOS reports.

Mon, Jun 24, 8:56 AM
trasz added a comment to D20720: Make linuxulator handle ELFOSABI_NONE ELF executables.

Many many many Linux binaries are ELFOSABI_NONE.
The Elf64_Brandinfo definitions directly above the added lines allow executables with ELFOSABI_NONE to run when interp_path matches. You can see one was added for musl libc, before that one was added, Alpine Linux did not work.
But that's for normal executables.

Mon, Jun 24, 8:54 AM
trasz added a comment to D20720: Make linuxulator handle ELFOSABI_NONE ELF executables.
In D20720#448098, @kib wrote:

Without this commit, Linux ldd is broken - it errors out due to not being able to exec rtld. No idea why rtld is like this, but, well, it is - both in Centos and Ubuntu.
It probably also fixed Android binaries; I hadn’t tested it this time.

So the issue is that shared objects do not specify ABI ? Does it mean that with the change, direct execution mode for our rtld (and then our ldd) is either broken or only works by chance ?

Mon, Jun 24, 8:42 AM

Sat, Jun 22

trasz added a comment to D20720: Make linuxulator handle ELFOSABI_NONE ELF executables.

Without this commit, Linux ldd is broken - it errors out due to not being able to exec rtld. No idea why rtld is like this, but, well, it is - both in Centos and Ubuntu.

Sat, Jun 22, 6:19 PM

Fri, Jun 21

trasz added reviewers for D20720: Make linuxulator handle ELFOSABI_NONE ELF executables: Linux Emulation, dchagin, kib.
Fri, Jun 21, 7:09 PM
trasz created D20720: Make linuxulator handle ELFOSABI_NONE ELF executables.
Fri, Jun 21, 7:09 PM

Wed, Jun 19

trasz added a comment to D20684: Don't do linuxulator path translation when chrooted.

Hm, true. Add a sysctl perhaps, to turn it on and off?

Wed, Jun 19, 1:29 PM
trasz added a comment to D20693: Fix bogomips calculation.

Meh.

Wed, Jun 19, 1:01 AM
trasz added reviewers for D20693: Fix bogomips calculation: dchagin, Linux Emulation.
Wed, Jun 19, 12:51 AM
trasz created D20693: Fix bogomips calculation.
Wed, Jun 19, 12:50 AM
trasz added a comment to D14835: Enhance support for Linux mremap system call.

FWIW, trying to run apt-get autoremove results in:

Wed, Jun 19, 12:01 AM

Tue, Jun 18

trasz added a comment to D14835: Enhance support for Linux mremap system call.

Ping?

Tue, Jun 18, 11:53 PM
trasz added reviewers for D20692: Fix prlimit64(2) with pid == 0: dchagin, Linux Emulation.
Tue, Jun 18, 11:12 PM
trasz created D20692: Fix prlimit64(2) with pid == 0.
Tue, Jun 18, 11:11 PM
trasz added reviewers for D20691: Implement PTRACE_GETSIGINFO: dchagin, Linux Emulation.
Tue, Jun 18, 10:06 PM
trasz created D20691: Implement PTRACE_GETSIGINFO.
Tue, Jun 18, 10:05 PM
trasz added reviewers for D20690: Silently ignore FS_IOC_FIEMAP: dchagin, Linux Emulation.
Tue, Jun 18, 9:19 PM
trasz created D20690: Silently ignore FS_IOC_FIEMAP.
Tue, Jun 18, 9:19 PM
trasz added reviewers for D20689: Add support for PTRACE_O_TRACEEXIT to linuxulator ptrace(2): dchagin, emaste.
Tue, Jun 18, 8:32 PM
trasz created D20689: Add support for PTRACE_O_TRACEEXIT to linuxulator ptrace(2).
Tue, Jun 18, 8:31 PM
trasz added inline comments to D20687: Fix execution of linux binaries with glibc>=2.24.
Tue, Jun 18, 8:06 PM
trasz updated the summary of D20687: Fix execution of linux binaries with glibc>=2.24.
Tue, Jun 18, 8:00 PM
trasz added reviewers for D20687: Fix execution of linux binaries with glibc>=2.24: dchagin, Linux Emulation.
Tue, Jun 18, 7:57 PM
trasz created D20687: Fix execution of linux binaries with glibc>=2.24.
Tue, Jun 18, 7:56 PM