Page MenuHomeFreeBSD

trasz (Edward Tomasz Napierała)
User

Projects

User Details

User Since
Aug 2 2014, 12:45 PM (320 w, 5 d)

Recent Activity

Yesterday

trasz updated the diff for D26528: Optimize riscv's cpu_fetch_syscall_args().

Fix tinderbox.

Thu, Sep 24, 9:37 AM

Wed, Sep 23

trasz updated the diff for D26530: Make makesyscalls.lua initialize 'struct sysent' entries using c99 designated identifiers.

Drop some fields that were always 0 or NULL.

Wed, Sep 23, 9:29 PM
trasz updated the summary of D26508: Shrink sysent from 48 to 32 bytes.
Wed, Sep 23, 2:05 PM
trasz retitled D26508: Shrink sysent from 48 to 32 bytes from Shrink sysent from 48 to 40 bytes to Shrink sysent from 48 to 32 bytes.
Wed, Sep 23, 2:03 PM
trasz updated the diff for D26508: Shrink sysent from 48 to 32 bytes.

Down to 32 bytes.

Wed, Sep 23, 2:02 PM
trasz updated the test plan for D26530: Make makesyscalls.lua initialize 'struct sysent' entries using c99 designated identifiers.
Wed, Sep 23, 2:01 PM
trasz requested review of D26530: Make makesyscalls.lua initialize 'struct sysent' entries using c99 designated identifiers.
Wed, Sep 23, 1:50 PM
trasz requested review of D26528: Optimize riscv's cpu_fetch_syscall_args().
Wed, Sep 23, 11:31 AM

Mon, Sep 21

trasz added a comment to D26471: Build debug kernels with -O2..

(Also tinderboxed.)

Mon, Sep 21, 10:24 PM
trasz updated the diff for D26471: Build debug kernels with -O2..

Apply suggestion from Jess (if I understood it correctly).

Mon, Sep 21, 10:23 PM
trasz added a comment to D26458: Get rid of sa->narg.

To explain my view a bit better:

Mon, Sep 21, 8:14 PM
trasz abandoned D26248: Use strlcpy(3) instead of strncpy(3)..

There's a consensus that this change doesn't improve the state of things; drop it for now.

Mon, Sep 21, 4:21 PM
trasz added inline comments to D26406: Stop calling set_syscall_retval() from linux_set_syscall_retval().
Mon, Sep 21, 3:58 PM
trasz updated the diff for D26406: Stop calling set_syscall_retval() from linux_set_syscall_retval().

Fix multiple issues.

Mon, Sep 21, 3:58 PM
trasz added inline comments to D26458: Get rid of sa->narg.
Mon, Sep 21, 3:57 PM
trasz abandoned D26393: Simplify linux_exec_setregs.

Yeah, you're right, this would be step in the wrong direction.

Mon, Sep 21, 12:59 PM
trasz added a comment to D26404: Move KTRUSERRET() from userret() to ast().

Ping?

Mon, Sep 21, 12:54 PM
trasz requested review of D26508: Shrink sysent from 48 to 32 bytes.
Mon, Sep 21, 12:53 PM
trasz added inline comments to D26458: Get rid of sa->narg.
Mon, Sep 21, 9:43 AM
trasz updated the diff for D26458: Get rid of sa->narg.

Drop the 'narg' structure field; tinderboxed.

Mon, Sep 21, 9:30 AM

Sun, Sep 20

trasz updated the diff for D26458: Get rid of sa->narg.

More fixes from Konstantin; passes tinderbox. Removing the field still TBD.

Sun, Sep 20, 12:58 PM

Fri, Sep 18

trasz added a comment to D26471: Build debug kernels with -O2..
In D26471#588937, @imp wrote:

Will this screw up the tracebacks? One of the reason that I've compiled at lower O levels is to not have @#^#$Y up DEBUG kernels...

Fri, Sep 18, 3:11 PM
trasz added a comment to D26471: Build debug kernels with -O2..

(Tinderboxed.)

Fri, Sep 18, 3:08 PM

Thu, Sep 17

trasz updated the diff for D26471: Build debug kernels with -O2..

Tweak.

Thu, Sep 17, 9:12 PM
trasz updated the summary of D26471: Build debug kernels with -O2..
Thu, Sep 17, 8:49 PM
trasz added inline comments to D26458: Get rid of sa->narg.
Thu, Sep 17, 8:48 PM
trasz requested review of D26471: Build debug kernels with -O2..
Thu, Sep 17, 8:45 PM
trasz updated the diff for D26458: Get rid of sa->narg.

Fixes.

Thu, Sep 17, 8:39 PM
trasz committed rS365834: Reduce code duplication by introducing linux_copyout_sockaddr().
Reduce code duplication by introducing linux_copyout_sockaddr()
Thu, Sep 17, 12:14 PM
trasz closed D25804: Reduce code duplication by introducing linux_copyout_sockaddr().
Thu, Sep 17, 12:14 PM
trasz updated the summary of D26458: Get rid of sa->narg.
Thu, Sep 17, 11:50 AM
trasz committed rS365833: Add support for SOUND_MIXER_WRITE_MONITOR ioctl. Fixes alsamixer(1).
Add support for SOUND_MIXER_WRITE_MONITOR ioctl. Fixes alsamixer(1)
Thu, Sep 17, 11:45 AM
trasz closed D25806: Add support for SOUND_MIXER_WRITE_MONITOR ioctl.
Thu, Sep 17, 11:45 AM
trasz committed rS365832: Get rid of sv_errtbl and SV_ABI_ERRNO()..
Get rid of sv_errtbl and SV_ABI_ERRNO().
Thu, Sep 17, 11:40 AM
trasz closed D26388: Get rid of sv_errtbl and SV_ABI_ERRNO().
Thu, Sep 17, 11:40 AM
trasz updated the diff for D26458: Get rid of sa->narg.

Fix build on arm64.

Thu, Sep 17, 11:16 AM

Wed, Sep 16

trasz requested review of D26458: Get rid of sa->narg.
Wed, Sep 16, 7:30 PM
trasz added a comment to D26388: Get rid of sv_errtbl and SV_ABI_ERRNO().

(Tinderboxed.)

Wed, Sep 16, 8:59 AM

Tue, Sep 15

trasz added inline comments to D26204: fix integer underflow in getgrnam_r and getpwnam_r.
Tue, Sep 15, 8:32 PM
trasz added inline comments to D26406: Stop calling set_syscall_retval() from linux_set_syscall_retval().
Tue, Sep 15, 6:43 PM
trasz updated the diff for D26388: Get rid of sv_errtbl and SV_ABI_ERRNO().

Be more strict on allowed values and don't return -1 (which would be ERESTART).

Tue, Sep 15, 6:37 PM
trasz added reviewers for D26406: Stop calling set_syscall_retval() from linux_set_syscall_retval(): kib, Linux Emulation.
Tue, Sep 15, 5:04 PM
trasz added a reviewer for D26393: Simplify linux_exec_setregs: kib.
Tue, Sep 15, 4:58 PM
trasz requested review of D26440: Rework ptrace flags checking in syscallenter, WIP.
Tue, Sep 15, 4:51 PM
trasz updated the diff for D26388: Get rid of sv_errtbl and SV_ABI_ERRNO().

Regen.

Tue, Sep 15, 4:46 PM
trasz committed rS365755: Move SV_ABI_ERRNO translation into linux-specific code, to simplify.
Move SV_ABI_ERRNO translation into linux-specific code, to simplify
Tue, Sep 15, 4:41 PM
trasz closed D26378: Move SV_ABI_ERRNO translation to linux-specific code.
Tue, Sep 15, 4:41 PM
trasz updated the diff for D26378: Move SV_ABI_ERRNO translation to linux-specific code.

Fixed tinderbox even more.

Tue, Sep 15, 5:31 AM

Mon, Sep 14

trasz added a comment to D26393: Simplify linux_exec_setregs.

I'm not sure if the call to setup_lcall_gate() is safe for Linux binaries?

Mon, Sep 14, 12:19 PM
trasz committed rS365713: Skip armv7 bectl tests on CI; they deadlock (""KSTACK_PAGES is 2")..
Skip armv7 bectl tests on CI; they deadlock (""KSTACK_PAGES is 2").
Mon, Sep 14, 10:35 AM
trasz updated the diff for D26378: Move SV_ABI_ERRNO translation to linux-specific code.

Fix tinderbox.

Mon, Sep 14, 10:27 AM
trasz added a comment to D26404: Move KTRUSERRET() from userret() to ast().

Done.

Mon, Sep 14, 10:20 AM
trasz committed rS365712: Move td_softdep_cleanup() from userret() to ast(); it's infrequent.
Move td_softdep_cleanup() from userret() to ast(); it's infrequent
Mon, Sep 14, 10:17 AM
trasz closed D26375: Move td_softdep_cleanup() from userret() to ast().
Mon, Sep 14, 10:17 AM
trasz committed rS365711: Move TDP_GEOM check from userret() to ast(); this code path is quite.
Move TDP_GEOM check from userret() to ast(); this code path is quite
Mon, Sep 14, 10:14 AM
trasz closed D26374: Move TDP_GEOM check to ast().
Mon, Sep 14, 10:14 AM
trasz committed rS365710: Move racct/rctl throttling from userret() to ast(). There's no reason.
Move racct/rctl throttling from userret() to ast(). There's no reason
Mon, Sep 14, 9:44 AM
trasz closed D26368: Move racct/rctl throttling from userret() to ast(). There's no reason for it to sit in the syscall fast path..
Mon, Sep 14, 9:44 AM

Sun, Sep 13

trasz added a comment to D26374: Move TDP_GEOM check to ast().

(Tinderboxed, Tested by: pho)

Sun, Sep 13, 3:57 PM

Sat, Sep 12

trasz added a comment to D26368: Move racct/rctl throttling from userret() to ast(). There's no reason for it to sit in the syscall fast path..

(Tinderboxed.)

Sat, Sep 12, 2:51 PM

Fri, Sep 11

trasz added a reviewer for D26388: Get rid of sv_errtbl and SV_ABI_ERRNO(): kib.
Fri, Sep 11, 6:26 PM
trasz added inline comments to D26378: Move SV_ABI_ERRNO translation to linux-specific code.
Fri, Sep 11, 6:25 PM
trasz requested review of D26406: Stop calling set_syscall_retval() from linux_set_syscall_retval().
Fri, Sep 11, 6:24 PM
trasz requested review of D26404: Move KTRUSERRET() from userret() to ast().
Fri, Sep 11, 10:40 AM
trasz updated the summary of D26378: Move SV_ABI_ERRNO translation to linux-specific code.
Fri, Sep 11, 10:34 AM
trasz added reviewers for D26378: Move SV_ABI_ERRNO translation to linux-specific code: Linux Emulation, kib, emaste.
Fri, Sep 11, 10:33 AM

Thu, Sep 10

trasz added inline comments to D26375: Move td_softdep_cleanup() from userret() to ast().
Thu, Sep 10, 8:29 PM
trasz added a reviewer for D26393: Simplify linux_exec_setregs: Linux Emulation.
Thu, Sep 10, 8:19 PM
trasz requested review of D26393: Simplify linux_exec_setregs.
Thu, Sep 10, 4:31 PM
trasz requested review of D26388: Get rid of sv_errtbl and SV_ABI_ERRNO().
Thu, Sep 10, 10:36 AM

Wed, Sep 9

trasz requested review of D26378: Move SV_ABI_ERRNO translation to linux-specific code.
Wed, Sep 9, 4:42 PM
trasz added inline comments to D26375: Move td_softdep_cleanup() from userret() to ast().
Wed, Sep 9, 4:36 PM
trasz added reviewers for D26375: Move td_softdep_cleanup() from userret() to ast(): kib, mckusick.
Wed, Sep 9, 3:25 PM
trasz requested review of D26375: Move td_softdep_cleanup() from userret() to ast().
Wed, Sep 9, 3:24 PM
trasz added reviewers for D26374: Move TDP_GEOM check to ast(): kib, mav.
Wed, Sep 9, 3:10 PM
trasz requested review of D26374: Move TDP_GEOM check to ast().
Wed, Sep 9, 3:09 PM
trasz requested review of D26368: Move racct/rctl throttling from userret() to ast(). There's no reason for it to sit in the syscall fast path..
Wed, Sep 9, 9:21 AM

Tue, Sep 1

trasz committed rS365042: Make sure not to pass NULL to strtoul(3). The values come.
Make sure not to pass NULL to strtoul(3). The values come
Tue, Sep 1, 2:59 PM
trasz closed D26246: Make sure not to pass NULL to strtoul(3).
Tue, Sep 1, 2:59 PM
trasz closed D26247: Fix string overflow.
Tue, Sep 1, 2:52 PM
trasz committed rS365040: Fix string overflow that could occur during redirection due to passing.
Fix string overflow that could occur during redirection due to passing
Tue, Sep 1, 2:52 PM
trasz committed rS365035: MFC r363305:.
MFC r363305:
Tue, Sep 1, 12:12 PM
trasz committed rS365034: MFC r363304:.
MFC r363304:
Tue, Sep 1, 12:09 PM

Mon, Aug 31

trasz added a reviewer for D26248: Use strlcpy(3) instead of strncpy(3).: mav.
Mon, Aug 31, 4:10 PM
trasz added a comment to D26248: Use strlcpy(3) instead of strncpy(3)..

Interesting. There are two different serial_num fields: one in cbe_lun, and one in params; same with device_id. The cbe_lun->serial_num is indeed documented this way, but params->device_id (ctl_ioctl.h:struct ctl_lun_create_params) is definitely a string; that's how both ctladm(8) and ctld(8) use it.

Mon, Aug 31, 4:10 PM
trasz updated the summary of D26247: Fix string overflow.
Mon, Aug 31, 2:23 PM
trasz updated the summary of D26246: Make sure not to pass NULL to strtoul(3).
Mon, Aug 31, 2:23 PM
trasz updated the summary of D26248: Use strlcpy(3) instead of strncpy(3)..
Mon, Aug 31, 2:22 PM
trasz added a reviewer for D26246: Make sure not to pass NULL to strtoul(3): mav.
Mon, Aug 31, 2:09 PM
trasz added a reviewer for D26247: Fix string overflow: mav.
Mon, Aug 31, 2:09 PM
trasz requested review of D26248: Use strlcpy(3) instead of strncpy(3)..
Mon, Aug 31, 2:08 PM
trasz requested review of D26247: Fix string overflow.
Mon, Aug 31, 1:54 PM
trasz requested review of D26246: Make sure not to pass NULL to strtoul(3).
Mon, Aug 31, 1:48 PM
trasz committed rP547170: Fix build ("ld: error: duplicate symbol: RAM")..
Fix build ("ld: error: duplicate symbol: RAM").
Mon, Aug 31, 12:22 PM
trasz closed D26217: missing "nocover" mount option on 12-STABLE makes rc.d/linux error out.
Mon, Aug 31, 12:14 PM
trasz committed rS364985: In 13-CURRENT, the linux rc script uses "nocover" mount option to avoid.
In 13-CURRENT, the linux rc script uses "nocover" mount option to avoid
Mon, Aug 31, 12:14 PM
trasz accepted D26217: missing "nocover" mount option on 12-STABLE makes rc.d/linux error out.

Looks perfect, thank you!

Mon, Aug 31, 12:07 PM
trasz added inline comments to D26240: Allow rc.d/linux to create mount points for Linux-specific filestsystems.
Mon, Aug 31, 12:01 PM
trasz added inline comments to D26240: Allow rc.d/linux to create mount points for Linux-specific filestsystems.
Mon, Aug 31, 12:00 PM

Sat, Aug 29

trasz committed rS364955: Drop the "nocover" option from the linux rc script; the option.
Drop the "nocover" option from the linux rc script; the option
Sat, Aug 29, 12:54 PM