trasz (Edward Tomasz Napierała)
User

Projects

User Details

User Since
Aug 2 2014, 12:45 PM (175 w, 4 d)

Recent Activity

Today

trasz committed rS326820: Tone down the description for the growfs "-y" flag..
Tone down the description for the growfs "-y" flag.
Wed, Dec 13, 2:09 PM

Yesterday

trasz updated the diff for D13445: Improve usbconfig(8) manual page.

Various fixes.

Tue, Dec 12, 12:17 PM
trasz added inline comments to D13445: Improve usbconfig(8) manual page.
Tue, Dec 12, 12:15 PM

Mon, Dec 11

trasz added a reviewer for D13445: Improve usbconfig(8) manual page: hselasky.
Mon, Dec 11, 1:18 PM
trasz created D13445: Improve usbconfig(8) manual page.
Mon, Dec 11, 1:18 PM

Sat, Dec 9

trasz committed rS326730: Move the DIAGNOSTIC check for lost iSCSI PDUs from icl_conn_close().
Move the DIAGNOSTIC check for lost iSCSI PDUs from icl_conn_close()
Sat, Dec 9, 3:35 PM

Sat, Dec 2

trasz committed rS326471: Document autofs(6) sysctl variables..
Document autofs(6) sysctl variables.
Sat, Dec 2, 1:12 PM

Fri, Dec 1

trasz committed rS326430: Add "vmaddr" ps(1) keyword..
Add "vmaddr" ps(1) keyword.
Fri, Dec 1, 11:32 AM

Thu, Nov 30

trasz committed rS326393: Make the ddb(4) "set" command list variables when called without parameters..
Make the ddb(4) "set" command list variables when called without parameters.
Thu, Nov 30, 12:22 PM

Tue, Nov 28

trasz committed rS326314: Make kdb_reenter() silent when explicitly called from db_error()..
Make kdb_reenter() silent when explicitly called from db_error().
Tue, Nov 28, 12:54 PM
trasz closed D13212: Unclutter ddb(4) error handling.
Tue, Nov 28, 12:54 PM

Mon, Nov 27

trasz committed rS326252: Add /etc/autofs/include_nis, a non-rewriting NIS map..
Add /etc/autofs/include_nis, a non-rewriting NIS map.
Mon, Nov 27, 12:50 PM
trasz committed rS326251: Rename /etc/autofs/include_nis to /etc/autofs/include_nis_nullfs, to indicate.
Rename /etc/autofs/include_nis to /etc/autofs/include_nis_nullfs, to indicate
Mon, Nov 27, 12:46 PM
trasz committed rS326250: Change formatting; no functional changes..
Change formatting; no functional changes.
Mon, Nov 27, 12:44 PM
trasz committed rS326249: Update intro(6) - remove hint that doesn't work, add explicit list.
Update intro(6) - remove hint that doesn't work, add explicit list
Mon, Nov 27, 12:39 PM
trasz closed D13196: Update intro(6).
Mon, Nov 27, 12:39 PM
trasz committed rS326248: .Xr pmcstat(8) from kgmon(8) and gprof(1)..
.Xr pmcstat(8) from kgmon(8) and gprof(1).
Mon, Nov 27, 12:37 PM
trasz committed rS326247: Revert r326125..
Revert r326125.
Mon, Nov 27, 12:34 PM

Sat, Nov 25

trasz added a comment to D13212: Unclutter ddb(4) error handling.

Thanks. Not sure why I went with the additional variable, tbh. Also, there are a few other calls to kdb_enter(), so I think adding a separate kdb_enter_silent() is nicer, especially regarding that it's a pretty small function and doesn't really need a wrapper.

Sat, Nov 25, 3:21 PM
trasz updated the diff for D13212: Unclutter ddb(4) error handling.

Use kdb_reenter_silent() instead of an additional variable.

Sat, Nov 25, 3:20 PM

Thu, Nov 23

trasz planned changes to D13211: Make the 'q' in ddb(4) pager actually abort the output.
Thu, Nov 23, 3:39 PM
trasz added a reviewer for D13212: Unclutter ddb(4) error handling: jhb.
Thu, Nov 23, 12:53 PM
trasz created D13212: Unclutter ddb(4) error handling.
Thu, Nov 23, 12:53 PM
trasz added a reviewer for D13211: Make the 'q' in ddb(4) pager actually abort the output: jhb.
Thu, Nov 23, 12:48 PM
trasz created D13211: Make the 'q' in ddb(4) pager actually abort the output.
Thu, Nov 23, 12:47 PM
trasz closed D12574: Mark kgmon(8) as obsolete.
Thu, Nov 23, 12:41 PM
trasz committed rS326125: Mark kgmon(8) obsolete, redirecting users to pmcstat(8)..
Mark kgmon(8) obsolete, redirecting users to pmcstat(8).
Thu, Nov 23, 12:41 PM

Wed, Nov 22

trasz created D13196: Update intro(6).
Wed, Nov 22, 9:08 PM
trasz added a comment to D13193: iscsisctl language fixes.

Oh wow. It's hard to believe I managed to overlook _that_. Approved :-)

Wed, Nov 22, 6:13 PM

Sun, Nov 19

trasz added a comment to D12574: Mark kgmon(8) as obsolete.

No idea if it works. Few months ago I've tried to build the kernel with kgmon support, and it didn't build. Either way, the correct way to phasing it out is to declare it obsoleted in the man page, and I think that's something that can be done without checking if it actually works.

Sun, Nov 19, 12:42 PM

Sat, Nov 18

trasz added a comment to D13143: Make rtld use read(2) instead of mmap(2) for ELF headers.

Why twice?

Sat, Nov 18, 3:16 PM
trasz closed D12834: Bump initial rtld memory pool size.
Sat, Nov 18, 1:21 PM
trasz committed rS325965: Increase rtld initial memory pool size from 32kB to 128kB..
Increase rtld initial memory pool size from 32kB to 128kB.
Sat, Nov 18, 1:21 PM
trasz added a comment to D12834: Bump initial rtld memory pool size.

I've tested it on i386, and yes, 32k is not enough there as well.

Sat, Nov 18, 12:49 PM
trasz added a reviewer for D13143: Make rtld use read(2) instead of mmap(2) for ELF headers: kib.
Sat, Nov 18, 10:02 AM
trasz created D13143: Make rtld use read(2) instead of mmap(2) for ELF headers.
Sat, Nov 18, 10:00 AM

Fri, Nov 17

trasz abandoned D12908: Don't munmap(2) ELF headers in map_object().
Fri, Nov 17, 9:24 PM

Tue, Nov 14

trasz committed rS325824: MFC r325009:.
MFC r325009:
Tue, Nov 14, 6:17 PM
trasz committed rS325823: MFC r213931:.
MFC r213931:
Tue, Nov 14, 6:13 PM
trasz committed rS325822: MFC r324857:.
MFC r324857:
Tue, Nov 14, 6:08 PM
trasz committed rS325821: MFC r324427:.
MFC r324427:
Tue, Nov 14, 6:02 PM
trasz committed rS325820: MFC r324367:.
MFC r324367:
Tue, Nov 14, 5:58 PM
trasz committed rS325819: MFC r324276:.
MFC r324276:
Tue, Nov 14, 5:56 PM
trasz committed rS325818: MFC r324199:.
MFC r324199:
Tue, Nov 14, 5:54 PM
trasz committed rS325815: MFC r320672:.
MFC r320672:
Tue, Nov 14, 5:06 PM
trasz committed rS325814: MFC r320672:.
MFC r320672:
Tue, Nov 14, 5:04 PM
trasz committed rS325809: MFC r324261:.
MFC r324261:
Tue, Nov 14, 4:00 PM

Nov 8 2017

trasz added inline comments to D12985: bhyve: don't try to capsicumise after failed open.
Nov 8 2017, 1:59 PM · bhyve

Nov 7 2017

trasz accepted D12836: ctl: Make max_luns and max_ports tunable variables instead of hardcoded defines..
Nov 7 2017, 3:51 PM

Nov 4 2017

trasz committed rS325403: Add missing MLINKS for disk_add_alias(9)..
Add missing MLINKS for disk_add_alias(9).
Nov 4 2017, 4:24 PM
trasz added a comment to D12945: Introduce phys2disk..

Why this way, instead of adding handling all that inside disk(9) instead? That would "just work" for all the periph drivers, without changing them.

Nov 4 2017, 4:21 PM
trasz committed rS325400: Make autofs(5) rc scripts run earlier, matching those for amd(8)..
Make autofs(5) rc scripts run earlier, matching those for amd(8).
Nov 4 2017, 3:52 PM
trasz committed rS325392: Add NIS automounter map, which supports rewriting of self-hosted locations.
Add NIS automounter map, which supports rewriting of self-hosted locations
Nov 4 2017, 2:38 PM
trasz committed rS325390: Use proper naming in a debug message..
Use proper naming in a debug message.
Nov 4 2017, 2:14 PM

Nov 3 2017

trasz added inline comments to D12836: ctl: Make max_luns and max_ports tunable variables instead of hardcoded defines..
Nov 3 2017, 12:47 PM

Nov 2 2017

trasz added a reviewer for D12908: Don't munmap(2) ELF headers in map_object(): kib.
Nov 2 2017, 1:18 PM
trasz created D12908: Don't munmap(2) ELF headers in map_object().
Nov 2 2017, 1:17 PM
trasz committed rS325319: Remove artificial limit for -i..
Remove artificial limit for -i.
Nov 2 2017, 12:17 PM
trasz committed rS325318: Add benchmark for access(2)..
Add benchmark for access(2).
Nov 2 2017, 12:16 PM
trasz committed rS325317: Add bad_open benchmark, which measures failed opens by calling.
Add bad_open benchmark, which measures failed opens by calling
Nov 2 2017, 12:16 PM
trasz committed rS325316: Add benchmark for getresuid(2) - three pointers, although only "output" ones,.
Add benchmark for getresuid(2) - three pointers, although only "output" ones,
Nov 2 2017, 12:15 PM
trasz committed rS325315: Add select(2) benchmark. It takes four pointers; unfortunately it's.
Add select(2) benchmark. It takes four pointers; unfortunately it's
Nov 2 2017, 12:13 PM
trasz committed rS325314: Add getpriority(2) benchmark; it's a lightweight syscall which does pretty.
Add getpriority(2) benchmark; it's a lightweight syscall which does pretty
Nov 2 2017, 12:12 PM
trasz committed rS325313: Make syscall_timing(1) default to a temporary file when run without -p..
Make syscall_timing(1) default to a temporary file when run without -p.
Nov 2 2017, 12:11 PM
trasz committed rS325312: Add fetchbench, a trivial HTTP benchmark based on fetch(1)..
Add fetchbench, a trivial HTTP benchmark based on fetch(1).
Nov 2 2017, 12:09 PM

Oct 30 2017

trasz added a comment to D12834: Bump initial rtld memory pool size.

No idea if it eats the same amount on 32 bit archs. Why is this important? Even if we wasted this 128kB of virtual address space, it doesn't hurt in any way, right?

Oct 30 2017, 12:43 PM
trasz added a comment to D12834: Bump initial rtld memory pool size.

It is still being allocated dynamically, it's just the current preallocation size is not enough even for true(1). See the munmap/mmap pair below:

Oct 30 2017, 11:37 AM
trasz added a comment to D12773: Manage thread signal mask using a shared word, instead of syscall..

I've got mixed feelings. On one hand it's nice to get rid of those sigprocmasks, and the patch itself looks fine. On the other hand, this adds the fetch to syscallenter(2), which is already quite bloated...

Oct 30 2017, 9:23 AM
trasz added a reviewer for D12834: Bump initial rtld memory pool size: kib.
Oct 30 2017, 9:06 AM
trasz created D12834: Bump initial rtld memory pool size.
Oct 30 2017, 9:06 AM
trasz committed rS325134: Use MAP_PRIVATE instead of obsolete MAP_COPY. No functional changes..
Use MAP_PRIVATE instead of obsolete MAP_COPY. No functional changes.
Oct 30 2017, 8:56 AM

Oct 29 2017

trasz committed rS325102: Plug memory leak on error case..
Plug memory leak on error case.
Oct 29 2017, 12:07 PM
trasz committed rS325101: Add back missing MTX_DEF, it still needs to be there..
Add back missing MTX_DEF, it still needs to be there.
Oct 29 2017, 12:03 PM

Oct 26 2017

trasz committed rS325009: Make gmountver(8) use direct dispatch..
Make gmountver(8) use direct dispatch.
Oct 26 2017, 10:18 AM
trasz committed rS325007: Make gmountver(8) use G_PF_ACCEPT_UNMAPPED..
Make gmountver(8) use G_PF_ACCEPT_UNMAPPED.
Oct 26 2017, 9:29 AM
trasz added a comment to D12773: Manage thread signal mask using a shared word, instead of syscall..

There is nothing there that seems related to libc (setsigmask(2)), why?

Oct 26 2017, 6:04 AM

Oct 24 2017

trasz committed rS324953: Remove unneeded calls to access(2) from rtld(1); just call open(2) instead..
Remove unneeded calls to access(2) from rtld(1); just call open(2) instead.
Oct 24 2017, 12:56 PM
trasz closed D12766: Remove unneeded calls to access(2) from rtld(1).
Oct 24 2017, 12:56 PM
trasz committed rS324952: Replace lseek(2)/read(2) pair with pread(2), removing yet another syscall.
Replace lseek(2)/read(2) pair with pread(2), removing yet another syscall
Oct 24 2017, 12:04 PM
trasz updated the diff for D12766: Remove unneeded calls to access(2) from rtld(1).

Rebase after commiting the style fixes.

Oct 24 2017, 11:33 AM
trasz committed rS324951: Make find_library() conform to style(9). No functional changes..
Make find_library() conform to style(9). No functional changes.
Oct 24 2017, 11:25 AM
trasz committed rS324950: Reword the conditional; it was ugly, and adding another parameter,.
Reword the conditional; it was ugly, and adding another parameter,
Oct 24 2017, 11:17 AM
trasz committed rS324949: Use xmalloc and read(2) instead of mmap(2) to read in libmap.conf(5)..
Use xmalloc and read(2) instead of mmap(2) to read in libmap.conf(5).
Oct 24 2017, 10:48 AM
trasz closed D12767: Use xmalloc+read instead of mmap(2) to read in libmap.conf(5).
Oct 24 2017, 10:48 AM

Oct 23 2017

trasz added a comment to D12766: Remove unneeded calls to access(2) from rtld(1).

I only see one libc.so.7 - from /lib. There's an attempt to load it from /usr/local/lib, but that fails with ENOENT.

Oct 23 2017, 8:11 PM
trasz added a comment to D12767: Use xmalloc+read instead of mmap(2) to read in libmap.conf(5).

I've just did a totally unscientific benchmark (for n in jot 10`; do /usr/bin/time sh -c 'for f in jot 10000; do /usr/bin/true; done'; done 2>&1`), curated the results with sed 's/,/./g', and... huh.

Oct 23 2017, 7:59 PM
trasz added a comment to D12767: Use xmalloc+read instead of mmap(2) to read in libmap.conf(5).

The allocated memory probably indeed seems to be allocated with mmap(2), but that's done anyway, ie we're not adding another mmap call to the binary startup. The read(2) might indeed be a bit faster due to not messing with memory mappings, but as you say, I don't expect this to be measurable. The additional copy won't hurt either - we're touching all that data just afterwards.

Oct 23 2017, 4:54 PM
trasz added a comment to D12767: Use xmalloc+read instead of mmap(2) to read in libmap.conf(5).

One fewer syscall during binary startup. Besides, reading in a small text file using mmap seems just weird; we use the usual read(2) for ld-elf.so.hints.

Oct 23 2017, 3:33 PM
trasz added a reviewer for D12767: Use xmalloc+read instead of mmap(2) to read in libmap.conf(5): kib.
Oct 23 2017, 12:52 PM
trasz created D12767: Use xmalloc+read instead of mmap(2) to read in libmap.conf(5).
Oct 23 2017, 12:52 PM
trasz added a reviewer for D12766: Remove unneeded calls to access(2) from rtld(1): kib.
Oct 23 2017, 11:59 AM
trasz retitled D12766: Remove unneeded calls to access(2) from rtld(1) from Remove unneeded calls to access(2) from rtld(1). to Remove unneeded calls to access(2) from rtld(1).
Oct 23 2017, 11:59 AM
trasz created D12766: Remove unneeded calls to access(2) from rtld(1).
Oct 23 2017, 11:58 AM

Oct 22 2017

trasz committed rS324857: Add OID for the vm.overcommit sysctl. This makes it possible to remove.
Add OID for the vm.overcommit sysctl. This makes it possible to remove
Oct 22 2017, 10:35 AM
trasz closed D12745: Add OID for vm.overcommit..
Oct 22 2017, 10:35 AM
trasz committed rS324856: Don't call realpath(3) from libmap rtld code. This gets rid of a few calls.
Don't call realpath(3) from libmap rtld code. This gets rid of a few calls
Oct 22 2017, 10:33 AM
trasz closed D12741: Don't call realpath(3) from libmap rtld code..
Oct 22 2017, 10:33 AM

Oct 20 2017

trasz added a reviewer for D12745: Add OID for vm.overcommit.: kib.
Oct 20 2017, 6:28 PM
trasz created D12745: Add OID for vm.overcommit..
Oct 20 2017, 6:28 PM
trasz added inline comments to D12741: Don't call realpath(3) from libmap rtld code..
Oct 20 2017, 4:30 PM