trasz (Edward Tomasz Napierała)
User

Projects

User Details

User Since
Aug 2 2014, 12:45 PM (138 w, 3 d)

Recent Activity

Yesterday

trasz accepted D10153: remove usfs from arm kernel configs.
Mon, Mar 27, 10:39 PM
trasz committed rS316057: Document EVENTHANDLER_DEFINE(9)..
Document EVENTHANDLER_DEFINE(9).
Mon, Mar 27, 8:32 PM
trasz committed rS316056: The cn_consume was removed in r296716..
The cn_consume was removed in r296716.
Mon, Mar 27, 8:29 PM

Thu, Mar 23

trasz added a comment to D10099: Split iscsi ctl frontend off of ctl(4) as cfiscsi(4).

Thanks. Generally speaking I like the change. Two things still bother me. First, as mav@ mentioned, ctld(8) will automatically load ctl(4) kernel module; it would be nice if things kept working for people depending on it. Second - that's a minor one, but the iSCSI frontend was introduced in 10.0, not 12.0.

Thu, Mar 23, 5:08 PM
trasz added a comment to D10099: Split iscsi ctl frontend off of ctl(4) as cfiscsi(4).

The AUTHORS section for cfiscsi.4 seems completely wrong. Can you just copy it from iscsi.4?

Thu, Mar 23, 9:54 AM

Sun, Mar 19

trasz committed rS315564: Improve formatting..
Improve formatting.
Sun, Mar 19, 4:17 PM
trasz committed rS315561: Bring back the "i". The point is to make it easy to find via "apropos.
Bring back the "i". The point is to make it easy to find via "apropos
Sun, Mar 19, 3:53 PM
trasz committed rS315560: Document how to use reroot with NFS..
Document how to use reroot with NFS.
Sun, Mar 19, 3:50 PM
trasz committed rS315556: MFC r313947:.
MFC r313947:
Sun, Mar 19, 3:32 PM
trasz committed rS315555: MFC r313281:.
MFC r313281:
Sun, Mar 19, 3:15 PM
trasz committed rS315554: MFC r313015:.
MFC r313015:
Sun, Mar 19, 3:07 PM
trasz committed rS315553: MFC r313018:.
MFC r313018:
Sun, Mar 19, 2:46 PM
trasz committed rS315551: MFC r313016:.
MFC r313016:
Sun, Mar 19, 2:40 PM
trasz committed rS315550: MFC r312987:.
MFC r312987:
Sun, Mar 19, 2:36 PM
trasz committed rS315549: MFC r312988:.
MFC r312988:
Sun, Mar 19, 2:25 PM
trasz committed rS315548: MFC r312986:.
MFC r312986:
Sun, Mar 19, 2:13 PM
trasz committed rS315547: MFC r313946:.
MFC r313946:
Sun, Mar 19, 2:09 PM
trasz committed rS315546: MFC r313915:.
MFC r313915:
Sun, Mar 19, 2:06 PM
trasz committed rS315544: MFC r313993:.
MFC r313993:
Sun, Mar 19, 10:42 AM
trasz committed rS315543: MFC r314282:.
MFC r314282:
Sun, Mar 19, 10:40 AM
trasz committed rS315542: MFC r313995:.
MFC r313995:
Sun, Mar 19, 10:38 AM
trasz committed rS315541: MFC r313804:.
MFC r313804:
Sun, Mar 19, 10:37 AM
trasz committed rS315540: MFC r313351:.
MFC r313351:
Sun, Mar 19, 10:36 AM
trasz committed rS315539: MFC r313350:.
MFC r313350:
Sun, Mar 19, 10:34 AM
trasz committed rS315538: MFC r313283:.
MFC r313283:
Sun, Mar 19, 10:32 AM
trasz committed rS315537: MFC r313017:.
MFC r313017:
Sun, Mar 19, 10:29 AM
trasz committed rS315535: MFC r312539 (by mav@):.
MFC r312539 (by mav@):
Sun, Mar 19, 10:26 AM
trasz committed rS315521: MFC r312622:.
MFC r312622:
Sun, Mar 19, 12:00 AM

Sat, Mar 18

trasz committed rS315520: MFC r311283:.
MFC r311283:
Sat, Mar 18, 11:58 PM
trasz committed rS315519: MFC r311284:.
MFC r311284:
Sat, Mar 18, 11:56 PM
trasz committed rS315517: MFC r308339:.
MFC r308339:
Sat, Mar 18, 11:25 PM
trasz committed rS315495: MFC r306161:.
MFC r306161:
Sat, Mar 18, 6:06 PM
trasz committed rS315494: MFC r306160:.
MFC r306160:
Sat, Mar 18, 6:01 PM
trasz committed rS315493: MFC r306129:.
MFC r306129:
Sat, Mar 18, 5:59 PM
trasz committed rS315492: MFC r306096:.
MFC r306096:
Sat, Mar 18, 5:58 PM
trasz committed rS315491: MFC r306094:.
MFC r306094:
Sat, Mar 18, 5:58 PM
trasz committed rD50067: Update my gnupg key. The previous one got lost ages ago..
Update my gnupg key. The previous one got lost ages ago.
Sat, Mar 18, 5:20 PM

Tue, Feb 28

trasz closed D8788: Document USB Mass Storage CTL frontend..

Committed by wblock@ as r50019.

Tue, Feb 28, 11:27 PM
trasz updated the diff for D8788: Document USB Mass Storage CTL frontend..

Reroot part moved to https://reviews.freebsd.org/D9834.

Tue, Feb 28, 10:09 AM
trasz planned changes to D9834: Document reroot..

Note that parts of this functionality are not yet implemented.

Tue, Feb 28, 10:07 AM
trasz retitled D9834: Document reroot. from to Document reroot..
Tue, Feb 28, 10:06 AM

Mon, Feb 27

trasz added a comment to D8788: Document USB Mass Storage CTL frontend..

Hm, something is wrong:

Mon, Feb 27, 9:21 PM
trasz commandeered D8788: Document USB Mass Storage CTL frontend..
Mon, Feb 27, 8:30 PM
trasz added inline comments to D8788: Document USB Mass Storage CTL frontend..
Mon, Feb 27, 8:29 PM

Sun, Feb 26

trasz accepted D9746: Update devd.conf for ports change 421360.
Sun, Feb 26, 7:55 PM

Feb 25 2017

trasz closed D9692: Fix linux_fstatfs(). by committing rS314282: Fix linux_fstatfs() to return proper value for f_frsize. Without it,.
Feb 25 2017, 8:32 PM
trasz committed rS314282: Fix linux_fstatfs() to return proper value for f_frsize. Without it,.
Fix linux_fstatfs() to return proper value for f_frsize. Without it,
Feb 25 2017, 8:32 PM
trasz added a comment to D9299: Rework CTL frontend & backend options to use nv(3), allow creating multiple ioctl frontend ports.

It looks like it's still missing the update to usage() in ctladm.c, and the ctladm.8 manual page. The rest looks nice, thanks for working on this :-)

Feb 25 2017, 11:15 AM
trasz added a comment to D8788: Document USB Mass Storage CTL frontend..

So, hm, is it good to go? Warren?

Feb 25 2017, 11:03 AM

Feb 22 2017

trasz added reviewers for D8788: Document USB Mass Storage CTL frontend.: wblock, emaste.
Feb 22 2017, 3:18 PM
trasz added a comment to D8788: Document USB Mass Storage CTL frontend..

Thanks. One thing I'm not sure about is the "USB OTG" stuff. "OTG" is not an acronym it itself, I think; "USB OTG" is. As in, the whole stuff.

Feb 22 2017, 3:17 PM
trasz updated the diff for D8788: Document USB Mass Storage CTL frontend..

Incorporate fixes from wblock@.

Feb 22 2017, 3:16 PM

Feb 21 2017

trasz committed rS314046: Get rid of foo_sys() in linuxulator code. It was commented out, and it.
Get rid of foo_sys() in linuxulator code. It was commented out, and it
Feb 21 2017, 3:57 PM

Feb 20 2017

trasz updated the diff for D9674: Handle ENXIO bufs..

Bring back the correct diff.

Feb 20 2017, 8:04 PM
trasz updated the diff for D9692: Fix linux_fstatfs()..

Handle 32 bits as well. Note that this is completely untested.

Feb 20 2017, 8:03 PM
trasz added a comment to D9674: Handle ENXIO bufs..

Erm, wait.

Feb 20 2017, 8:01 PM
trasz updated the diff for D9674: Handle ENXIO bufs..

Handle 32 bits as well. Note that the 32 bit part is untested.

Feb 20 2017, 8:00 PM
trasz committed rS313995: Add /proc/self/mounts to linprocfs; some linux binaries need it..
Add /proc/self/mounts to linprocfs; some linux binaries need it.
Feb 20 2017, 5:33 PM
trasz added a reviewer for D9692: Fix linux_fstatfs().: dchagin.
Feb 20 2017, 5:30 PM
trasz retitled D9692: Fix linux_fstatfs(). from to Fix linux_fstatfs()..
Feb 20 2017, 5:30 PM
trasz added a comment to D9674: Handle ENXIO bufs..

Perhaps we could just add an additional check to not do this in case of softdep, ie if the buf has dependencies? Or rather, just add a conditional a bit lower to not call buf_deallocate() of them?

Feb 20 2017, 4:56 PM
trasz committed rS313994: Simplify devfs_fsync() by removing it. This might also be a minor.
Simplify devfs_fsync() by removing it. This might also be a minor
Feb 20 2017, 4:18 PM
trasz closed D9628: Simplify devfs_fsync(). by committing rS313994: Simplify devfs_fsync() by removing it. This might also be a minor.
Feb 20 2017, 4:18 PM
trasz committed rS313993: Reimplement linux_arch_prctl() as a wrapper around sysarch(2)..
Reimplement linux_arch_prctl() as a wrapper around sysarch(2).
Feb 20 2017, 4:13 PM
trasz closed D9372: Reimplement linux_arch_prctl() as a wrapper around sysarch(). by committing rS313993: Reimplement linux_arch_prctl() as a wrapper around sysarch(2)..
Feb 20 2017, 4:13 PM
trasz accepted D9677: Make the code match the comments. If we have ANY buf's that failed then return EAGAIN. The current code just returns that if the LAST buf failed..

My worry here is that with this patch, we won't retry fsync if it failed with EIO, while with the previous code, due to the logic error, we would (at least if the failed buf was not the last one). I'm not sure if anything depends on it, though.

Feb 20 2017, 11:30 AM
trasz added a comment to D9674: Handle ENXIO bufs..

That's true, softdeps code has an explicit workaround for ENXIO. That said, I don't think we need to worry about softdep at all at this time - if it panics, it panics; it's not a regression, because it always panicked. It would be nice if UFS without softdep, or msdosfs, didn't panic, and for that, we need to handle those bufs somewhere.

Feb 20 2017, 11:26 AM

Feb 19 2017

trasz committed rS313959: Add USB Mass Storage CTL frontend. This makes it possible.
Add USB Mass Storage CTL frontend. This makes it possible
Feb 19 2017, 5:48 PM
trasz closed D8787: Add USB Mass Storage CTL frontend. by committing rS313959: Add USB Mass Storage CTL frontend. This makes it possible.
Feb 19 2017, 5:48 PM
trasz updated D9628: Simplify devfs_fsync()..
Feb 19 2017, 5:32 PM
trasz updated D9628: Simplify devfs_fsync()..
Feb 19 2017, 5:31 PM
trasz added a reviewer for D9628: Simplify devfs_fsync().: imp.
Feb 19 2017, 5:31 PM
trasz committed rS313947: There are some Linux binaries that expect the system to obey the "addr".
There are some Linux binaries that expect the system to obey the "addr"
Feb 19 2017, 5:17 PM
trasz closed D9373: Tweak linux mmap address hint handling. by committing rS313947: There are some Linux binaries that expect the system to obey the "addr".
Feb 19 2017, 5:17 PM
trasz added reviewers for D9674: Handle ENXIO bufs.: imp, kib.
Feb 19 2017, 5:10 PM
trasz retitled D9674: Handle ENXIO bufs. from to Handle ENXIO bufs..
Feb 19 2017, 5:09 PM
trasz committed rS313946: Make savecore(8) output nicer by specifying the maximum field width.
Make savecore(8) output nicer by specifying the maximum field width
Feb 19 2017, 4:59 PM
trasz committed rS313943: Make mdconfig(8) not segfault when the kernel returns garbage data..
Make mdconfig(8) not segfault when the kernel returns garbage data.
Feb 19 2017, 4:09 PM

Feb 18 2017

trasz added a reviewer for D9662: Better flag handling in linux_mmap().: dchagin.
Feb 18 2017, 1:26 PM
trasz retitled D9662: Better flag handling in linux_mmap(). from to Better flag handling in linux_mmap()..
Feb 18 2017, 1:23 PM
trasz updated the diff for D9628: Simplify devfs_fsync()..

Remove the pointless wrapper.

Feb 18 2017, 11:53 AM
trasz added a comment to D9628: Simplify devfs_fsync()..

The panic was changed into printf already, as it triggered every time, even when UFS or msdosfs could survive just fine. The warning - I kind of agree, it could be useful, but I don't think it's worth complicating the code just for that.

Feb 18 2017, 11:46 AM
trasz committed rS313915: Make fsck(8) default to "ufs", like eg mount(8) does..
Make fsck(8) default to "ufs", like eg mount(8) does.
Feb 18 2017, 11:43 AM
trasz closed D9621: Make fsck(8) default to "ufs". by committing rS313915: Make fsck(8) default to "ufs", like eg mount(8) does..
Feb 18 2017, 11:43 AM

Feb 17 2017

trasz added inline comments to D8787: Add USB Mass Storage CTL frontend..
Feb 17 2017, 10:02 PM
trasz added a comment to D9621: Make fsck(8) default to "ufs"..

Konstantin - _all_ the utilities. Namely newfs and mount. They all default to ufs. It's logical for fsck to do the same. Especially that other systems people are used to don't require one to specify the filesystem by hand either.

Feb 17 2017, 8:00 PM
trasz added a reviewer for D9628: Simplify devfs_fsync().: kib.
Feb 17 2017, 5:15 PM
trasz added a comment to D9628: Simplify devfs_fsync()..

Tested by: pho

Feb 17 2017, 5:14 PM

Feb 16 2017

trasz added a comment to D9621: Make fsck(8) default to "ufs"..

Wouldn't that defeat the purpose of having the default? Other utilities don't issue warnings in this case, they just silently go with default.

Feb 16 2017, 1:36 PM
trasz committed rS313809: Implement linux version of ptrace(2). It's nowhere near complete,.
Implement linux version of ptrace(2). It's nowhere near complete,
Feb 16 2017, 1:32 PM
trasz closed D9406: Implement linux64 version of ptrace. by committing rS313809: Implement linux version of ptrace(2). It's nowhere near complete,.
Feb 16 2017, 1:32 PM
trasz updated the diff for D9406: Implement linux64 version of ptrace..

Rebase.

Feb 16 2017, 12:48 PM
trasz retitled D9628: Simplify devfs_fsync(). from to Simplify devfs_fsync()..
Feb 16 2017, 11:03 AM
trasz committed rS313804: Improve debugging output..
Improve debugging output.
Feb 16 2017, 10:36 AM

Feb 15 2017

trasz added a reviewer for D9621: Make fsck(8) default to "ufs".: kib.
Feb 15 2017, 4:56 PM
trasz retitled D9621: Make fsck(8) default to "ufs". from to Make fsck(8) default to "ufs"..
Feb 15 2017, 4:55 PM
trasz committed rS313775: Change the "devfs_fsync: vop_stdfsync failed" from panic to a printf..
Change the "devfs_fsync: vop_stdfsync failed" from panic to a printf.
Feb 15 2017, 4:52 PM
trasz committed rS313770: Regen after r313769..
Regen after r313769.
Feb 15 2017, 2:26 PM
trasz committed rS313769: Fix definition of linux64 ptrace syscall..
Fix definition of linux64 ptrace syscall.
Feb 15 2017, 2:12 PM
trasz updated the diff for D9406: Implement linux64 version of ptrace..

Fix diff.

Feb 15 2017, 10:37 AM