Page MenuHomeFreeBSD

trasz (Edward Tomasz Napierała)
User

Projects

User Details

User Since
Aug 2 2014, 12:45 PM (276 w, 6 d)

Recent Activity

Today

trasz added a reviewer for D22465: Implement Linux syslog(2) syscall; just enough to make the dmesg(8) utility work.: Linux Emulation.
Fri, Nov 22, 8:17 AM
trasz accepted D22466: add deprecation warning to amd.
Fri, Nov 22, 7:56 AM

Wed, Nov 20

trasz created D22465: Implement Linux syslog(2) syscall; just enough to make the dmesg(8) utility work..
Wed, Nov 20, 7:22 PM

Mon, Nov 18

trasz added inline comments to D20655: Make use of stats(3) in the TCP stack.
Mon, Nov 18, 10:59 PM
trasz updated the diff for D20655: Make use of stats(3) in the TCP stack.

Fixes from lstewart@.

Mon, Nov 18, 10:58 PM
trasz committed rS354805: Make linux(4) open(2)/openat(2) return ELOOP instead of EMLINK,.
Make linux(4) open(2)/openat(2) return ELOOP instead of EMLINK,
Mon, Nov 18, 10:19 AM
trasz closed D22384: linux(4): return ELOOP instead of EMLINK.
Mon, Nov 18, 10:19 AM
trasz accepted D22339: Update the ses(4) man page.
Mon, Nov 18, 10:15 AM

Fri, Nov 15

trasz added a comment to D22371: Add sync_file_range(2) to linux(4)..

(Tinderboxed.)

Fri, Nov 15, 6:11 PM
trasz updated the summary of D22384: linux(4): return ELOOP instead of EMLINK.
Fri, Nov 15, 6:07 PM
trasz added a comment to D22384: linux(4): return ELOOP instead of EMLINK.

Sure, it's openat02:5. I'll add it to the commit.

Fri, Nov 15, 6:07 PM
trasz retitled D22384: linux(4): return ELOOP instead of EMLINK from linux(4): return ELOOP instead of EMLINKS to linux(4): return ELOOP instead of EMLINK.
Fri, Nov 15, 4:32 PM
trasz added reviewers for D22384: linux(4): return ELOOP instead of EMLINK: Linux Emulation, emaste.
Fri, Nov 15, 4:32 PM
trasz created D22384: linux(4): return ELOOP instead of EMLINK.
Fri, Nov 15, 4:31 PM
trasz committed rS354732: Support O_CLOEXEC in linux(4) open(2) and openat(2)..
Support O_CLOEXEC in linux(4) open(2) and openat(2).
Fri, Nov 15, 4:21 PM
trasz closed D21966: linux(4): support O_CLOEXEC.
Fri, Nov 15, 4:21 PM
trasz added inline comments to D22371: Add sync_file_range(2) to linux(4)..
Fri, Nov 15, 8:43 AM

Thu, Nov 14

trasz updated the diff for D22371: Add sync_file_range(2) to linux(4)..

Fix most of the problems.

Thu, Nov 14, 10:03 PM
trasz added inline comments to D22371: Add sync_file_range(2) to linux(4)..
Thu, Nov 14, 9:55 PM
trasz committed rP517601: Upgrade devel/linux-ltp to 20190930..
Upgrade devel/linux-ltp to 20190930.
Thu, Nov 14, 4:55 PM
trasz updated the summary of D22371: Add sync_file_range(2) to linux(4)..
Thu, Nov 14, 2:02 PM
trasz created D22371: Add sync_file_range(2) to linux(4)..
Thu, Nov 14, 2:00 PM

Wed, Nov 13

trasz committed rP517387: Unbreak; I've uploaded distfiles into the usual place and now it seems.
Unbreak; I've uploaded distfiles into the usual place and now it seems
Wed, Nov 13, 9:36 PM
trasz added inline comments to D22277: Improve Linuxulator man pages.
Wed, Nov 13, 8:32 PM
trasz committed rS354691: Improve Linuxulator man pages to better reflect the current state,.
Improve Linuxulator man pages to better reflect the current state,
Wed, Nov 13, 8:32 PM
trasz closed D22277: Improve Linuxulator man pages.
Wed, Nov 13, 8:32 PM
trasz committed rS354690: Add 'linux_mounts_enable' rc.conf(5) variable, to make it possible.
Add 'linux_mounts_enable' rc.conf(5) variable, to make it possible
Wed, Nov 13, 8:27 PM
trasz closed D22320: Add linux_skip_mounts.
Wed, Nov 13, 8:27 PM
trasz added inline comments to D22277: Improve Linuxulator man pages.
Wed, Nov 13, 1:06 PM

Tue, Nov 12

trasz updated the diff for D22277: Improve Linuxulator man pages.

Document linux_mounts_enable.

Tue, Nov 12, 3:06 PM
trasz updated the diff for D22320: Add linux_skip_mounts.

Rename to 'linux_mounts_enable' and flip the meaning.

Tue, Nov 12, 3:03 PM
trasz removed a reviewer for D22323: 2019Q3 Quarterly status report: lidl.
Tue, Nov 12, 1:58 PM
trasz added reviewers for D22323: 2019Q3 Quarterly status report: allanjude, bcr, lidl.
Tue, Nov 12, 1:54 PM
trasz added a comment to D22193: Add kern.geom.part.separator..

FWIW, grepping for that pattern only brings up the one hit Warner has already mentioned, and it's already under #ifdef illumos:

% grep -r '%ss%d' *
cddl/contrib/opensolaris/cmd/zpool/zpool_vdev.c:                (void) snprintf(buf, sizeof (buf), "%ss%d", path, slice);
Tue, Nov 12, 10:25 AM

Mon, Nov 11

trasz added reviewers for D22320: Add linux_skip_mounts: Linux Emulation, netchild, ian.
Mon, Nov 11, 10:07 PM
trasz created D22320: Add linux_skip_mounts.
Mon, Nov 11, 10:06 PM
trasz added a comment to D22277: Improve Linuxulator man pages.

Fixed, thanks!

Mon, Nov 11, 4:05 PM
trasz updated the diff for D22277: Improve Linuxulator man pages.

Feedback from brueffer@.

Mon, Nov 11, 4:05 PM
trasz updated the diff for D22277: Improve Linuxulator man pages.

Apply feedback from emaste@ and tijl@.

Mon, Nov 11, 3:07 PM
trasz added reviewers for D22277: Improve Linuxulator man pages: tijl, emaste.
Mon, Nov 11, 11:38 AM

Sat, Nov 9

trasz committed rS354571: Add GEOM attribute to report physical device name, and report it.
Add GEOM attribute to report physical device name, and report it
Sat, Nov 9, 5:30 PM
trasz closed D22249: Show HBA path in 'diskinfo -v'..
Sat, Nov 9, 5:30 PM

Fri, Nov 8

trasz accepted D22271: Create /etc/os-release file..
Fri, Nov 8, 8:00 PM
trasz added inline comments to D22271: Create /etc/os-release file..
Fri, Nov 8, 7:41 PM
trasz updated the diff for D22193: Add kern.geom.part.separator..

Feedback from brueffer@ and allanjude@.

Fri, Nov 8, 7:33 PM
trasz updated the summary of D22249: Show HBA path in 'diskinfo -v'..
Fri, Nov 8, 4:07 PM
trasz updated the diff for D22249: Show HBA path in 'diskinfo -v'..

Rename to "attachment", merge into a single GEOM attribute.

Fri, Nov 8, 4:05 PM
trasz added a comment to D22277: Improve Linuxulator man pages.

That's true; I've added a BUGS section.

Fri, Nov 8, 11:14 AM
trasz updated the diff for D22277: Improve Linuxulator man pages.

Add BUGS.

Fri, Nov 8, 11:14 AM
trasz committed rS354533: Humanize more columns in the vmstat(8) output and adjust widths..
Humanize more columns in the vmstat(8) output and adjust widths.
Fri, Nov 8, 11:10 AM
trasz closed D22185: Fix vmstat(8) output.
Fri, Nov 8, 11:10 AM
trasz added a comment to D22275: Document procfs(5) as obsolete.

So... Is procfs actually obsolete then?

Fri, Nov 8, 11:04 AM

Thu, Nov 7

trasz added a comment to D22249: Show HBA path in 'diskinfo -v'..

"Attachment" sounds perfect, thanks!

Thu, Nov 7, 7:00 PM
trasz added a comment to D22267: Make sure the 'struct tcp_info' is stable.

(Tinderboxed.)

Thu, Nov 7, 6:21 PM
trasz added a reviewer for D22277: Improve Linuxulator man pages: Linux Emulation.
Thu, Nov 7, 6:18 PM
trasz created D22277: Improve Linuxulator man pages.
Thu, Nov 7, 6:18 PM
trasz committed rS354459: The cdceem(4) driver debuted in 12.1..
The cdceem(4) driver debuted in 12.1.
Thu, Nov 7, 6:16 PM
trasz committed rS354458: Extend the linux rc script to mount the neccessary file systems,.
Extend the linux rc script to mount the neccessary file systems,
Thu, Nov 7, 6:15 PM
trasz closed D21874: Extend the linux rc script.
Thu, Nov 7, 6:15 PM
trasz created D22275: Document procfs(5) as obsolete.
Thu, Nov 7, 2:33 PM
trasz added a comment to D22249: Show HBA path in 'diskinfo -v'..

Overall, the changes look good to me, but I am having a twinge over "HBA". HBA completely makes sense for SCSI but doesn't at all for NVMe. SATA falls in the middle depending on whether this is a proprietary thing or AHCI.

Thu, Nov 7, 1:42 PM

Wed, Nov 6

trasz added inline comments to D20655: Make use of stats(3) in the TCP stack.
Wed, Nov 6, 8:57 PM
trasz created D22267: Make sure the 'struct tcp_info' is stable.
Wed, Nov 6, 8:55 PM
trasz closed D20333: Make linux(4) create /dev/shm..
Wed, Nov 6, 8:53 PM
trasz committed rS354413: Make linux(4) create /dev/shm. Linux applications often expect.
Make linux(4) create /dev/shm. Linux applications often expect
Wed, Nov 6, 8:53 PM

Tue, Nov 5

trasz created D22249: Show HBA path in 'diskinfo -v'..
Tue, Nov 5, 8:18 PM

Mon, Nov 4

trasz added a comment to D22194: Colored output for err(3).
In D22194#485930, @imp wrote:

teemo. Coding the ansi escape sequences is really a bad idea.

Mon, Nov 4, 4:27 PM
trasz added inline comments to D22194: Colored output for err(3).
Mon, Nov 4, 12:44 PM
trasz accepted D22188: libstats: Fix ABI assertion..
Mon, Nov 4, 12:42 PM

Fri, Nov 1

trasz added a comment to D22193: Add kern.geom.part.separator..
In D22193#485070, @imp wrote:
/*
  * Fill in the devid, now that we've labeled the disk.
  */
 (void) snprintf(buf, sizeof (buf), "%ss%d", path, slice);
 if ((fd = open(buf, O_RDONLY)) < 0) {
         (void) fprintf(stderr,
             gettext("cannot open '%s': %s\n"),
             buf, strerror(errno));
         return (-1);
 }

is one example, this one is from cddl/contrib/opensolaris/cmd/zpool/zpool_vdev.c

We should try to find these cases and clean them up. I wouldn't expect there to be too many, since everything should be using GEOM to create partitions etc.

Fri, Nov 1, 11:36 PM
trasz added inline comments to D22185: Fix vmstat(8) output.
Fri, Nov 1, 11:35 PM
trasz updated the diff for D20655: Make use of stats(3) in the TCP stack.

Fix tinderbox on i386.

Fri, Nov 1, 10:03 PM
trasz added a comment to D22185: Fix vmstat(8) output.

(Tinderboxed.)

Fri, Nov 1, 9:32 AM

Thu, Oct 31

trasz added a comment to D22193: Add kern.geom.part.separator..
In D22193#485070, @imp wrote:
/*
  * Fill in the devid, now that we've labeled the disk.
  */
 (void) snprintf(buf, sizeof (buf), "%ss%d", path, slice);
 if ((fd = open(buf, O_RDONLY)) < 0) {
         (void) fprintf(stderr,
             gettext("cannot open '%s': %s\n"),
             buf, strerror(errno));
         return (-1);
 }

is one example, this one is from cddl/contrib/opensolaris/cmd/zpool/zpool_vdev.c

Thu, Oct 31, 5:58 PM
trasz updated the diff for D22193: Add kern.geom.part.separator..

Update the man page.

Thu, Oct 31, 11:05 AM

Wed, Oct 30

trasz added a comment to D20333: Make linux(4) create /dev/shm..
In D20333#484720, @kib wrote:

Well, they don't print an error. I'm not quite sure why, but I've tested both scenarios - kldloading linux.ko and then linux64.ko, and the other way around; same with kldunloading.

Then there must be a bug either in the testing methodology or in the code, right ? Ensure that the make_dev line is executed in both cases.

Wed, Oct 30, 9:39 PM
trasz added a comment to D22193: Add kern.geom.part.separator..
In D22193#485062, @imp wrote:

There are lots of places in the system that will break when this is not '' . What are your plans on fixing those?

Wed, Oct 30, 6:37 PM
trasz added a comment to D22193: Add kern.geom.part.separator..

Is the 'd' or 'c' in the description a typo? Should it be ada0d/s1? or ada0/s1

Wed, Oct 30, 6:35 PM
trasz updated the summary of D22193: Add kern.geom.part.separator..
Wed, Oct 30, 6:34 PM
trasz created D22194: Colored output for err(3).
Wed, Oct 30, 3:16 PM
trasz created D22193: Add kern.geom.part.separator..
Wed, Oct 30, 3:14 PM
trasz added a reviewer for D22185: Fix vmstat(8) output: allanjude.
Wed, Oct 30, 2:06 PM
trasz updated the summary of D22185: Fix vmstat(8) output.
Wed, Oct 30, 2:06 PM
trasz updated the diff for D22185: Fix vmstat(8) output.

Fix layout for one disk setups.

Wed, Oct 30, 12:36 PM
trasz committed rS354172: There's nothing architecture specific in "options STATS"; move it from.
There's nothing architecture specific in "options STATS"; move it from
Wed, Oct 30, 10:16 AM

Tue, Oct 29

trasz created D22185: Fix vmstat(8) output.
Tue, Oct 29, 10:49 PM
trasz committed rS354154: Fix column title alignment..
Fix column title alignment.
Tue, Oct 29, 8:28 PM
trasz added a comment to D20333: Make linux(4) create /dev/shm..

Well, they don't print an error. I'm not quite sure why, but I've tested both scenarios - kldloading linux.ko and then linux64.ko, and the other way around; same with kldunloading.

Tue, Oct 29, 10:29 AM
trasz added inline comments to D21324: Add stats(3) support to nc(1).
Tue, Oct 29, 10:23 AM

Mon, Oct 28

trasz committed rS354139: Document the fact that Linux binaries depend on pty(4)..
Document the fact that Linux binaries depend on pty(4).
Mon, Oct 28, 9:22 PM
trasz closed D21492: Make linux_common depend on pty..
Mon, Oct 28, 9:22 PM
trasz updated the diff for D20333: Make linux(4) create /dev/shm..

Apply comments from kib@ and emaste@.

Mon, Oct 28, 9:16 PM

Thu, Oct 24

trasz updated the diff for D21324: Add stats(3) support to nc(1).

Attempt to fix problems with -N reported by thj@; also build fix
for rescue(8).

Thu, Oct 24, 3:57 PM
trasz abandoned D20411: Add devfs(5) support for VOP_MKDIR(9) and VOP_RMDIR(9).
Thu, Oct 24, 2:01 PM
trasz added a comment to D21874: Extend the linux rc script.

Also see the discussion under https://reviews.freebsd.org/D20322.

Thu, Oct 24, 1:53 PM
trasz abandoned D20322: Make linux_enable="YES" result in mounting linprocfs, linsysfs, and handling /dev/shm/.

Superseded by https://reviews.freebsd.org/D21874.

Thu, Oct 24, 1:52 PM

Wed, Oct 23

trasz added a comment to D20655: Make use of stats(3) in the TCP stack.

(Tinderboxed.)

Wed, Oct 23, 8:39 PM
trasz updated the diff for D20655: Make use of stats(3) in the TCP stack.

Drop local change to GENERIC.

Wed, Oct 23, 8:39 PM
trasz updated the diff for D21324: Add stats(3) support to nc(1).

Add WITH_STATS conditional.

Wed, Oct 23, 8:18 PM
trasz updated the diff for D21324: Add stats(3) support to nc(1).

Make -M also work with -l; reported by thj@.

Wed, Oct 23, 8:08 PM