trasz (Edward Tomasz Napierała)
User

Projects

Badges

User does not have any badges.
User Since
Aug 2 2014, 12:45 PM (133 w, 2 d)

Recent Activity

Today

trasz accepted D9677: Make the code match the comments. If we have ANY buf's that failed then return EAGAIN. The current code just returns that if the LAST buf failed..

My worry here is that with this patch, we won't retry fsync if it failed with EIO, while with the previous code, due to the logic error, we would (at least if the failed buf was not the last one). I'm not sure if anything depends on it, though.

Mon, Feb 20, 11:30 AM
trasz added a comment to D9674: Handle ENXIO bufs..

That's true, softdeps code has an explicit workaround for ENXIO. That said, I don't think we need to worry about softdep at all at this time - if it panics, it panics; it's not a regression, because it always panicked. It would be nice if UFS without softdep, or msdosfs, didn't panic, and for that, we need to handle those bufs somewhere.

Mon, Feb 20, 11:26 AM

Yesterday

trasz committed rS313959: Add USB Mass Storage CTL frontend. This makes it possible.
Add USB Mass Storage CTL frontend. This makes it possible
Sun, Feb 19, 5:48 PM
trasz closed D8787: Add USB Mass Storage CTL frontend. by committing rS313959: Add USB Mass Storage CTL frontend. This makes it possible.
Sun, Feb 19, 5:48 PM
trasz updated the summary for D9628: Simplify devfs_fsync()..
Sun, Feb 19, 5:32 PM
trasz updated the summary for D9628: Simplify devfs_fsync()..
Sun, Feb 19, 5:31 PM
trasz added a reviewer for D9628: Simplify devfs_fsync().: imp.
Sun, Feb 19, 5:31 PM
trasz committed rS313947: There are some Linux binaries that expect the system to obey the "addr".
There are some Linux binaries that expect the system to obey the "addr"
Sun, Feb 19, 5:17 PM
trasz closed D9373: Tweak linux mmap address hint handling. by committing rS313947: There are some Linux binaries that expect the system to obey the "addr".
Sun, Feb 19, 5:17 PM
trasz added reviewers for D9674: Handle ENXIO bufs.: imp, kib.
Sun, Feb 19, 5:10 PM
trasz created D9674: Handle ENXIO bufs..
Sun, Feb 19, 5:09 PM
trasz committed rS313946: Make savecore(8) output nicer by specifying the maximum field width.
Make savecore(8) output nicer by specifying the maximum field width
Sun, Feb 19, 4:59 PM
trasz committed rS313943: Make mdconfig(8) not segfault when the kernel returns garbage data..
Make mdconfig(8) not segfault when the kernel returns garbage data.
Sun, Feb 19, 4:09 PM

Sat, Feb 18

trasz added a reviewer for D9662: Better flag handling in linux_mmap().: dchagin.
Sat, Feb 18, 1:26 PM
trasz created D9662: Better flag handling in linux_mmap()..
Sat, Feb 18, 1:23 PM
trasz updated the diff for D9628: Simplify devfs_fsync()..

Remove the pointless wrapper.

Sat, Feb 18, 11:53 AM
trasz added a comment to D9628: Simplify devfs_fsync()..

The panic was changed into printf already, as it triggered every time, even when UFS or msdosfs could survive just fine. The warning - I kind of agree, it could be useful, but I don't think it's worth complicating the code just for that.

Sat, Feb 18, 11:46 AM
trasz committed rS313915: Make fsck(8) default to "ufs", like eg mount(8) does..
Make fsck(8) default to "ufs", like eg mount(8) does.
Sat, Feb 18, 11:43 AM
trasz closed D9621: Make fsck(8) default to "ufs". by committing rS313915: Make fsck(8) default to "ufs", like eg mount(8) does..
Sat, Feb 18, 11:43 AM

Fri, Feb 17

trasz added inline comments to D8787: Add USB Mass Storage CTL frontend..
Fri, Feb 17, 10:02 PM
trasz added a comment to D9621: Make fsck(8) default to "ufs"..

Konstantin - _all_ the utilities. Namely newfs and mount. They all default to ufs. It's logical for fsck to do the same. Especially that other systems people are used to don't require one to specify the filesystem by hand either.

Fri, Feb 17, 8:00 PM
trasz added a reviewer for D9628: Simplify devfs_fsync().: kib.
Fri, Feb 17, 5:15 PM
trasz added a comment to D9628: Simplify devfs_fsync()..

Tested by: pho

Fri, Feb 17, 5:14 PM

Thu, Feb 16

trasz added a comment to D9621: Make fsck(8) default to "ufs"..

Wouldn't that defeat the purpose of having the default? Other utilities don't issue warnings in this case, they just silently go with default.

Thu, Feb 16, 1:36 PM
trasz committed rS313809: Implement linux version of ptrace(2). It's nowhere near complete,.
Implement linux version of ptrace(2). It's nowhere near complete,
Thu, Feb 16, 1:32 PM
trasz closed D9406: Implement linux64 version of ptrace. by committing rS313809: Implement linux version of ptrace(2). It's nowhere near complete,.
Thu, Feb 16, 1:32 PM
trasz updated the diff for D9406: Implement linux64 version of ptrace..

Rebase.

Thu, Feb 16, 12:48 PM
trasz created D9628: Simplify devfs_fsync()..
Thu, Feb 16, 11:03 AM
trasz committed rS313804: Improve debugging output..
Improve debugging output.
Thu, Feb 16, 10:36 AM

Wed, Feb 15

trasz added a reviewer for D9621: Make fsck(8) default to "ufs".: kib.
Wed, Feb 15, 4:56 PM
trasz created D9621: Make fsck(8) default to "ufs"..
Wed, Feb 15, 4:55 PM
trasz committed rS313775: Change the "devfs_fsync: vop_stdfsync failed" from panic to a printf..
Change the "devfs_fsync: vop_stdfsync failed" from panic to a printf.
Wed, Feb 15, 4:52 PM
trasz committed rS313770: Regen after r313769..
Regen after r313769.
Wed, Feb 15, 2:26 PM
trasz committed rS313769: Fix definition of linux64 ptrace syscall..
Fix definition of linux64 ptrace syscall.
Wed, Feb 15, 2:12 PM
trasz updated the diff for D9406: Implement linux64 version of ptrace..

Fix diff.

Wed, Feb 15, 10:37 AM
trasz updated the diff for D9406: Implement linux64 version of ptrace..

Cosmetic fixes.

Wed, Feb 15, 10:34 AM

Tue, Feb 14

trasz added a comment to D8787: Add USB Mass Storage CTL frontend..

Note to self: tinderboxed.

Tue, Feb 14, 6:15 PM
trasz accepted D2210: Linux getdents/getdents64 rewrite..

Looks good. :-)

Tue, Feb 14, 3:45 PM
trasz updated the diff for D8787: Add USB Mass Storage CTL frontend..

Fix build on sparc64.

Tue, Feb 14, 1:35 PM

Mon, Feb 13

trasz updated the diff for D9373: Tweak linux mmap address hint handling..

Regen.

Mon, Feb 13, 12:32 PM
trasz added inline comments to D2210: Linux getdents/getdents64 rewrite..
Mon, Feb 13, 12:04 PM

Sat, Feb 11

trasz abandoned D6313: Remove NULL checks after M_WAITOK allocations from ath(4)..
Sat, Feb 11, 3:27 PM
trasz added a comment to D9372: Reimplement linux_arch_prctl() as a wrapper around sysarch()..

I should, but it's called from entirely different codepaths, and I'd prefer to not mix things at this point, since it makes debugging regressions harder.

Sat, Feb 11, 3:25 PM
trasz added a comment to D9373: Tweak linux mmap address hint handling..

I'm not sure if I want to clutter other parts of the system just for this. This is specific to Linux, and not even Linux in general - it's a workaround for arguably buggy behaviour of some linux apps (ART in this case). In other words it's a bug compatibility. We already have lots of those in linuxulator.

Sat, Feb 11, 3:14 PM
trasz accepted D9464: try to fix RACCT_RSS accounting.
Sat, Feb 11, 3:11 PM
trasz added inline comments to D8787: Add USB Mass Storage CTL frontend..
Sat, Feb 11, 12:42 PM
trasz updated the diff for D8787: Add USB Mass Storage CTL frontend..

Updated version with numerous small improvements here and there.
I've incorporated the man page updated with wblocked@, but did some
more changes; please tell me what you think.

Sat, Feb 11, 12:38 PM

Mon, Feb 6

trasz committed rS313352: Add kern_vm_mmap2(), kern_vm_mprotect(), kern_vm_msync(), kern_vm_munlock(),.
Add kern_vm_mmap2(), kern_vm_mprotect(), kern_vm_msync(), kern_vm_munlock(),
Mon, Feb 6, 8:57 PM
trasz closed D9378: Add vm_mmap2(), vm_mprotect(), vm_msync(), vm_munlock(), vm_munmap(), and vm_madvise(). by committing rS313352: Add kern_vm_mmap2(), kern_vm_mprotect(), kern_vm_msync(), kern_vm_munlock(),.
Mon, Feb 6, 8:57 PM
trasz committed rS313351: Make root_mount_hold() work after boot. This is important for two.
Make root_mount_hold() work after boot. This is important for two
Mon, Feb 6, 8:45 PM
trasz closed D9388: Make root_mount_hold() work after boot. by committing rS313351: Make root_mount_hold() work after boot. This is important for two.
Mon, Feb 6, 8:45 PM
trasz committed rS313350: In r290196 the root mount hold mechanism was changed to make it not wait.
In r290196 the root mount hold mechanism was changed to make it not wait
Mon, Feb 6, 8:37 PM
trasz closed D9387: Add vfs.root_mount_always_wait. by committing rS313350: In r290196 the root mount hold mechanism was changed to make it not wait.
Mon, Feb 6, 8:37 PM

Sun, Feb 5

trasz added a comment to D9387: Add vfs.root_mount_always_wait..

Note to self: tinderboxed.

Sun, Feb 5, 9:03 PM
trasz added a comment to D9388: Make root_mount_hold() work after boot..

Note to self: tinderboxed.

Sun, Feb 5, 9:03 PM
trasz committed rS313283: Fix linux_pipe() and linux_pipe2() to close file descriptors on copyout.
Fix linux_pipe() and linux_pipe2() to close file descriptors on copyout
Sun, Feb 5, 2:03 PM
trasz closed D9425: Fix error handling in linux_pipe(). by committing rS313283: Fix linux_pipe() and linux_pipe2() to close file descriptors on copyout.
Sun, Feb 5, 2:03 PM
trasz committed rS313281: Add kern_cpuset_getaffinity() and kern_cpuset_getaffinity(),.
Add kern_cpuset_getaffinity() and kern_cpuset_getaffinity(),
Sun, Feb 5, 1:25 PM
trasz closed D9383: Add kern_cpuset_getaffinity() and kern_cpuset_getaffinity(). by committing rS313281: Add kern_cpuset_getaffinity() and kern_cpuset_getaffinity(),.
Sun, Feb 5, 1:25 PM
trasz updated the diff for D9388: Make root_mount_hold() work after boot..

Don't allow NULL pointer in root_mount_rel().

Sun, Feb 5, 12:09 PM
trasz added a comment to D9425: Fix error handling in linux_pipe()..

Note to self: tinderboxed.

Sun, Feb 5, 11:49 AM

Fri, Feb 3

trasz added a reviewer for D9425: Fix error handling in linux_pipe().: dchagin.
Fri, Feb 3, 2:00 PM
trasz created D9425: Fix error handling in linux_pipe()..
Fri, Feb 3, 2:00 PM
trasz added a reviewer for D2210: Linux getdents/getdents64 rewrite.: dchagin.
Fri, Feb 3, 12:46 PM
trasz added a comment to D2210: Linux getdents/getdents64 rewrite..

Dmitry, do I understand it right that the current code - the one we have in CURRENT and 11 - panics on LTP tests? Could you run it with the patch applied and see if it works correctly? Thanks!

Fri, Feb 3, 12:46 PM
trasz updated the diff for D2210: Linux getdents/getdents64 rewrite..

Rebase.

Fri, Feb 3, 12:42 PM

Thu, Feb 2

trasz committed rS313099: Ifdef out the unused vm_rr_selectdomain()..
Ifdef out the unused vm_rr_selectdomain().
Thu, Feb 2, 5:45 PM
trasz added a comment to D9378: Add vm_mmap2(), vm_mprotect(), vm_msync(), vm_munlock(), vm_munmap(), and vm_madvise()..

Note to self: tinderboxed.

Thu, Feb 2, 11:21 AM
trasz added a comment to D9406: Implement linux64 version of ptrace..

Thanks; the bsd_to_linux_errno[] thing was just a leftover.

Thu, Feb 2, 12:13 AM
trasz updated the diff for D9406: Implement linux64 version of ptrace..

... and readd the linux_ptrace.c, d'oh!

Thu, Feb 2, 12:11 AM
trasz updated the diff for D9406: Implement linux64 version of ptrace..

Fix printf, remove leftover.

Thu, Feb 2, 12:10 AM

Wed, Feb 1

trasz added a comment to D9388: Make root_mount_hold() work after boot..

Good point with root_mount_rel(), I'll fix that.

Wed, Feb 1, 11:38 PM
trasz added a comment to D9378: Add vm_mmap2(), vm_mprotect(), vm_msync(), vm_munlock(), vm_munmap(), and vm_madvise()..

Dmitry, could you test it? Thanks!

Wed, Feb 1, 11:29 PM
trasz updated the diff for D9378: Add vm_mmap2(), vm_mprotect(), vm_msync(), vm_munlock(), vm_munmap(), and vm_madvise()..

Fix build.

Wed, Feb 1, 11:27 PM
trasz added a reviewer for D9406: Implement linux64 version of ptrace.: dchagin.
Wed, Feb 1, 3:27 PM
trasz created D9406: Implement linux64 version of ptrace..
Wed, Feb 1, 3:26 PM
trasz added a comment to D9383: Add kern_cpuset_getaffinity() and kern_cpuset_getaffinity()..

Note to self: tinderboxed.

Wed, Feb 1, 12:58 PM

Tue, Jan 31

trasz added a reviewer for D9388: Make root_mount_hold() work after boot.: marcel.

Marcel, "svn ann" suggests it was there when you wrote it. What do you think about the change? Thanks!

Tue, Jan 31, 5:00 PM
trasz added inline comments to D9378: Add vm_mmap2(), vm_mprotect(), vm_msync(), vm_munlock(), vm_munmap(), and vm_madvise()..
Tue, Jan 31, 4:50 PM
trasz committed rS313018: Add kern_pread() and kern_pwrite(), and use it in compats instead.
Add kern_pread() and kern_pwrite(), and use it in compats instead
Tue, Jan 31, 3:35 PM
trasz closed D9379: Add kern_pread() and kern_pwrite(). by committing rS313018: Add kern_pread() and kern_pwrite(), and use it in compats instead.
Tue, Jan 31, 3:35 PM
trasz committed rS313017: Fix linux_getppid() to debug the actual parent, even it was reparented.
Fix linux_getppid() to debug the actual parent, even it was reparented
Tue, Jan 31, 3:23 PM
trasz closed D9361: Fix linux_getppid() by committing rS313017: Fix linux_getppid() to debug the actual parent, even it was reparented.
Tue, Jan 31, 3:23 PM
trasz committed rS313016: Replace calls to sys_truncate() with kern_truncate()..
Replace calls to sys_truncate() with kern_truncate().
Tue, Jan 31, 3:20 PM
trasz closed D9371: Add kern_truncate(). by committing rS313016: Replace calls to sys_truncate() with kern_truncate()..
Tue, Jan 31, 3:20 PM
trasz committed rS313015: Add kern_cpuset_getid() and kern_cpuset_setid(), and use them.
Add kern_cpuset_getid() and kern_cpuset_setid(), and use them
Tue, Jan 31, 3:11 PM
trasz closed D9382: Add kern_cpuset_setid() and kern_cpuset_setid(). by committing rS313015: Add kern_cpuset_getid() and kern_cpuset_setid(), and use them.
Tue, Jan 31, 3:11 PM
trasz added a comment to D9382: Add kern_cpuset_setid() and kern_cpuset_setid()..

Note to self: tinderboxed.

Tue, Jan 31, 3:02 PM

Mon, Jan 30

trasz added a comment to D9361: Fix linux_getppid().

Note to self: tinderboxed.

Mon, Jan 30, 8:47 PM
trasz added a comment to D9371: Add kern_truncate()..

(Note to self: tinderboxed.)

Mon, Jan 30, 8:46 PM
trasz added a comment to D9379: Add kern_pread() and kern_pwrite()..

Note to self: tinderboxed.

Mon, Jan 30, 8:46 PM
trasz updated the diff for D9387: Add vfs.root_mount_always_wait..

Make the sysctl RDTUN.

Mon, Jan 30, 7:06 PM
trasz added a reviewer for D9387: Add vfs.root_mount_always_wait.: kib.
Mon, Jan 30, 6:34 PM
trasz added a reviewer for D9388: Make root_mount_hold() work after boot.: kib.
Mon, Jan 30, 6:34 PM
trasz created D9388: Make root_mount_hold() work after boot..
Mon, Jan 30, 6:33 PM
trasz created D9387: Add vfs.root_mount_always_wait..
Mon, Jan 30, 6:23 PM
trasz added reviewers for D9383: Add kern_cpuset_getaffinity() and kern_cpuset_getaffinity().: kib, dchagin.

Dmitry, could you test it? I have no software that calls it.

Mon, Jan 30, 3:25 PM
trasz created D9383: Add kern_cpuset_getaffinity() and kern_cpuset_getaffinity()..
Mon, Jan 30, 3:25 PM
trasz added a reviewer for D9382: Add kern_cpuset_setid() and kern_cpuset_setid().: kib.
Mon, Jan 30, 2:57 PM
trasz created D9382: Add kern_cpuset_setid() and kern_cpuset_setid()..
Mon, Jan 30, 2:57 PM