Page MenuHomeFreeBSD

mountroot: On failure return ENOENT, not ENODEV
AbandonedPublic

Authored by trasz on May 18 2022, 1:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 7:05 AM
Unknown Object (File)
Mon, Apr 22, 2:29 AM
Unknown Object (File)
Fri, Apr 19, 11:03 AM
Unknown Object (File)
Wed, Apr 17, 3:42 AM
Unknown Object (File)
Tue, Apr 16, 5:20 AM
Unknown Object (File)
Feb 13 2024, 11:44 AM
Unknown Object (File)
Dec 20 2023, 6:39 AM
Unknown Object (File)
Dec 16 2023, 1:54 AM
Subscribers

Details

Reviewers
kib
Summary

As it is now, if we wait for a device node to appear
and it never happens, we return ENODEV ("failed with error 19").
Use ENOENT instead; ENODEV might be quite misleading.

Sponsored By: EPSRC

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45619
Build 42507: arc lint + arc unit

Event Timeline

trasz requested review of this revision.May 18 2022, 1:19 PM

I do not object, mostly because I cannot make an opinion. You mentioned that 'ENODEV might be quite misleading'. Can you provide more info, and explain what this change gives us?

My first thought about ENODEV was something about GEOM. ENOENT, on the other hand, would make it obvious what's going on: the root device node is simply not there.

As I said, I do not see a point, but I do not object.

This revision is now accepted and ready to land.May 19 2022, 1:55 PM