IMHO this is superseded by https://reviews.freebsd.org/D40188

IMHO this is superseded by https://reviews.freebsd.org/D40188

It doesn't look like the patch in it's current state handles this circular includes.

In D40188#915660, @dvl wrote:

In D40188#915159, @otis wrote:

Haven't looked closely yet, but: are circular includes handled correctly?

This is what I came here to ask.

I like this approach.
It blurs the line between UCL and jail format (IMHO making future transition to UCL smoother), and makes include more explicit (and less magical comparing to D40188)

@jamie please re-generate the diff with -U9999 and re-upload it. This is necessary to have context available. (Annoying Phab limitation when diffs are uploaded manually)

Testing is finished

un-approving

40008 fails:

> sh ./tools/tools/git/git-arc.sh patch -c D40008
 INFO  Base commit is not in local repository; trying to fetch.
Checking patch stand/efi/libefi/eficom.c...
error: stand/efi/libefi/eficom.c: does not exist in index

Test 2 also passed successfully:

Test no.2 passed

Not sure if this is something that you want to address in this change: long lines are not wrapped when I do git-arc patch -c D40016

un-requesting changes

Looks like arc_call_conduit is a typo. Fixing it manually on my end made everything work.

Long lines don't seem to be wrapped.

> git log -n1
commit 80108b46712dc2aad86f6c8618be9e1fb4d406e6 (HEAD -> git-arc-test)
Author: Ihor Antonov <ihor@antonovs.family>
Date:   Mon May 8 18:01:54 2023 -0700

Test no.1 Passed successfully:

Updated the diff for more fun.

It seems that this diff does not apply cleanly on top of main:
Here is why:
patch assumes: _commits=$(git rev-list $_commits | (tail -r 2>/dev/null || tac))
while in reality: _commits=$(git rev-list $_commits | tail -r)

@meka_tilda.center please re-upload the diff with context (i.e. generate it with git diff -U9999) such that reviewers can see more unchanged lines

This change conflicts with https://reviews.freebsd.org/D39011
@antranigv_freebsd.am and @meka_tilda.center need to hash this out

add __builtin_unreachable(); for --help case
remove unnecessary usage() prototype

minor fix

Address @allanjude and @imp comments

Add --help as per @freebsd_igalic.co request

@kevans: fixed all comments, added diff with -U9999999

minor fix

missing closing brace

address comments by @kevans

ready for review

I am just a humble FreeBSD user, but I think this absolutely must be done.
Reducing code footprint, attack surface and cognitive overhead for those who maintain the code.
+1