Page MenuHomeFreeBSD

ihor_antonovs.family (Ihor Antonov)
Jack of all Trades

Projects

User Details

User Since
Dec 31 2019, 6:28 PM (232 w, 2 d)

Recent Activity

Jun 5 2023

ihor_antonovs.family added a project to D40371: automatic service jails: some setup for full functionality of the services in automatic service jails: Jails.
Jun 5 2023, 2:55 PM · rc, Jails
ihor_antonovs.family added a project to D40370: Infrastructure for automatic jailing of rc.d-services: Jails.
Jun 5 2023, 2:55 PM · rc, Jails
ihor_antonovs.family added a project to D40369: Extend /usr/bin/service with the possibility to set ENV vars: Jails.
Jun 5 2023, 2:54 PM · Jails

Jun 4 2023

ihor_antonovs.family added a project to D40262: Allow setting a per-Jail fallback ABI brand.: Jails.
Jun 4 2023, 2:00 PM · Jails
ihor_antonovs.family added a project to D40377: Teach route(8) to run in jails: Jails.
Jun 4 2023, 1:59 PM · Jails
ihor_antonovs.family resigned from D39011: Enable jail(8) to parse all config files.

IMHO this is superseded by https://reviews.freebsd.org/D40188

Jun 4 2023, 12:34 AM
ihor_antonovs.family resigned from D38826: Fix multiple rc.d/jail and jail.conf.d issues.

IMHO this is superseded by https://reviews.freebsd.org/D40188

Jun 4 2023, 12:34 AM · Jails

May 30 2023

ihor_antonovs.family added a comment to D40299: Tie kern.fallback_elf_brand to the fallback elf brand of the current prison.
May 30 2023, 2:52 PM

May 23 2023

ihor_antonovs.family added a comment to D40188: Add ".include" directive to jail.conf.

It doesn't look like the patch in it's current state handles this circular includes.

May 23 2023, 1:04 AM · Jails
ihor_antonovs.family added a comment to D40188: Add ".include" directive to jail.conf.
In D40188#915660, @dvl wrote:
In D40188#915159, @otis wrote:

Haven't looked closely yet, but: are circular includes handled correctly?

This is what I came here to ask.

May 23 2023, 1:00 AM · Jails

May 21 2023

ihor_antonovs.family added a comment to D40188: Add ".include" directive to jail.conf.

I like this approach.
It blurs the line between UCL and jail format (IMHO making future transition to UCL smoother), and makes include more explicit (and less magical comparing to D40188)

May 21 2023, 1:01 AM · Jails
ihor_antonovs.family added a comment to D40188: Add ".include" directive to jail.conf.

@jamie please re-generate the diff with -U9999 and re-upload it. This is necessary to have context available. (Annoying Phab limitation when diffs are uploaded manually)

May 21 2023, 12:38 AM · Jails

May 9 2023

ihor_antonovs.family abandoned D40016: Test git-arc.

Testing is finished

May 9 2023, 6:13 PM
ihor_antonovs.family resigned from D39992: git-arc: Add -c flag to patch to commit the change.

un-approving

May 9 2023, 3:39 PM
ihor_antonovs.family added a comment to D39992: git-arc: Add -c flag to patch to commit the change.

40008 fails:

> sh ./tools/tools/git/git-arc.sh patch -c D40008
 INFO  Base commit is not in local repository; trying to fetch.
Checking patch stand/efi/libefi/eficom.c...
error: stand/efi/libefi/eficom.c: does not exist in index
May 9 2023, 2:32 AM
ihor_antonovs.family added a comment to D39992: git-arc: Add -c flag to patch to commit the change.

Test 2 also passed successfully:

May 9 2023, 2:21 AM
ihor_antonovs.family added a comment to D40016: Test git-arc.

Test no.2 passed

May 9 2023, 2:20 AM
ihor_antonovs.family added a comment to D39992: git-arc: Add -c flag to patch to commit the change.

Not sure if this is something that you want to address in this change: long lines are not wrapped when I do git-arc patch -c D40016

May 9 2023, 2:12 AM
ihor_antonovs.family accepted D39992: git-arc: Add -c flag to patch to commit the change.

un-requesting changes

May 9 2023, 2:09 AM
ihor_antonovs.family requested changes to D39992: git-arc: Add -c flag to patch to commit the change.

Looks like arc_call_conduit is a typo. Fixing it manually on my end made everything work.

May 9 2023, 1:13 AM
ihor_antonovs.family added a comment to D40016: Test git-arc.

Long lines don't seem to be wrapped.

> git log -n1
commit 80108b46712dc2aad86f6c8618be9e1fb4d406e6 (HEAD -> git-arc-test)
Author: Ihor Antonov <ihor@antonovs.family>
Date:   Mon May 8 18:01:54 2023 -0700
May 9 2023, 1:06 AM
ihor_antonovs.family added a comment to D40016: Test git-arc.

Test no.1 Passed successfully:

May 9 2023, 1:03 AM
ihor_antonovs.family updated the summary of D40016: Test git-arc.
May 9 2023, 1:03 AM
ihor_antonovs.family updated the diff for D40016: Test git-arc.

Updated the diff for more fun.

May 9 2023, 1:00 AM
ihor_antonovs.family requested review of D40016: Test git-arc.
May 9 2023, 12:45 AM

May 7 2023

ihor_antonovs.family requested changes to D39975: tools/git: ensure git-arc is more platform indepdendent.

It seems that this diff does not apply cleanly on top of main:
Here is why:
patch assumes: _commits=$(git rev-list $_commits | (tail -r 2>/dev/null || tac))
while in reality: _commits=$(git rev-list $_commits | tail -r)

May 7 2023, 1:15 AM

Apr 14 2023

ihor_antonovs.family updated ihor_antonovs.family.
Apr 14 2023, 2:10 AM

Mar 25 2023

ihor_antonovs.family added a member for Jails: ihor_antonovs.family.
Mar 25 2023, 12:14 AM

Mar 21 2023

ihor_antonovs.family accepted D39011: Enable jail(8) to parse all config files.
Mar 21 2023, 10:51 PM
ihor_antonovs.family added inline comments to D39011: Enable jail(8) to parse all config files.
Mar 21 2023, 3:31 AM
ihor_antonovs.family requested changes to D39011: Enable jail(8) to parse all config files.
Mar 21 2023, 3:21 AM
ihor_antonovs.family added inline comments to D39011: Enable jail(8) to parse all config files.
Mar 21 2023, 3:21 AM
ihor_antonovs.family added a comment to D39011: Enable jail(8) to parse all config files.

@meka_tilda.center please re-upload the diff with context (i.e. generate it with git diff -U9999) such that reviewers can see more unchanged lines

Mar 21 2023, 2:08 AM

Mar 18 2023

ihor_antonovs.family awarded D7474: Add rc.conf support for foo_daemon="-r". a Like token.
Mar 18 2023, 9:32 PM · rc

Mar 11 2023

ihor_antonovs.family added a comment to D38826: Fix multiple rc.d/jail and jail.conf.d issues.

This change conflicts with https://reviews.freebsd.org/D39011
@antranigv_freebsd.am and @meka_tilda.center need to hash this out

Mar 11 2023, 6:09 PM · Jails
ihor_antonovs.family added inline comments to D39011: Enable jail(8) to parse all config files.
Mar 11 2023, 6:08 PM

Feb 28 2023

ihor_antonovs.family foisted D38826: Fix multiple rc.d/jail and jail.conf.d issues upon antranigv_freebsd.am.
Feb 28 2023, 6:11 PM · Jails
ihor_antonovs.family requested review of D38826: Fix multiple rc.d/jail and jail.conf.d issues.
Feb 28 2023, 6:07 PM · Jails

Feb 6 2023

ihor_antonovs.family requested review of D38244: daemon: add long_opts.
Feb 6 2023, 8:15 PM

Feb 5 2023

ihor_antonovs.family updated the diff for D38244: daemon: add long_opts.

add __builtin_unreachable(); for --help case
remove unnecessary usage() prototype

Feb 5 2023, 5:53 PM

Feb 4 2023

ihor_antonovs.family updated the diff for D38244: daemon: add long_opts.

minor fix

Feb 4 2023, 7:26 PM
ihor_antonovs.family updated the diff for D38244: daemon: add long_opts.

Address @allanjude and @imp comments

Feb 4 2023, 7:22 PM
ihor_antonovs.family added inline comments to D38244: daemon: add long_opts.
Feb 4 2023, 6:39 PM
ihor_antonovs.family added a reviewer for D38244: daemon: add long_opts: emaste.
Feb 4 2023, 4:40 PM

Feb 3 2023

ihor_antonovs.family added inline comments to D38244: daemon: add long_opts.
Feb 3 2023, 9:31 PM
ihor_antonovs.family updated the diff for D38244: daemon: add long_opts.

Add --help as per @freebsd_igalic.co request

Feb 3 2023, 8:57 PM
ihor_antonovs.family added inline comments to D38244: daemon: add long_opts.
Feb 3 2023, 8:47 PM

Feb 2 2023

ihor_antonovs.family added a comment to D38244: daemon: add long_opts.

@kevans: fixed all comments, added diff with -U9999999

Feb 2 2023, 6:38 AM
ihor_antonovs.family updated the diff for D38244: daemon: add long_opts.

minor fix

Feb 2 2023, 6:35 AM
ihor_antonovs.family updated the diff for D38244: daemon: add long_opts.

missing closing brace

Feb 2 2023, 6:33 AM
ihor_antonovs.family updated the diff for D38244: daemon: add long_opts.

address comments by @kevans

Feb 2 2023, 6:31 AM

Jan 30 2023

ihor_antonovs.family added inline comments to D38244: daemon: add long_opts.
Jan 30 2023, 2:13 AM

Jan 28 2023

ihor_antonovs.family added a reviewer for D38244: daemon: add long_opts: manpages.
Jan 28 2023, 10:45 PM
ihor_antonovs.family updated the diff for D38244: daemon: add long_opts.
Jan 28 2023, 7:55 PM
ihor_antonovs.family retitled D38244: daemon: add long_opts from [WIP] daemon: add long_opts to daemon: add long_opts.
Jan 28 2023, 7:54 PM
ihor_antonovs.family updated the diff for D38244: daemon: add long_opts.

ready for review

Jan 28 2023, 7:54 PM
ihor_antonovs.family updated the diff for D38244: daemon: add long_opts.
Jan 28 2023, 5:36 PM
ihor_antonovs.family updated the diff for D38244: daemon: add long_opts.
Jan 28 2023, 5:26 PM
ihor_antonovs.family added reviewers for D38244: daemon: add long_opts: kevans, cperciva.
Jan 28 2023, 5:20 PM
ihor_antonovs.family requested review of D38244: daemon: add long_opts.
Jan 28 2023, 5:20 PM

Mar 22 2020

ihor_antonovs.family awarded D18578: OpenRC for FreeBSD a Like token.
Mar 22 2020, 4:33 AM

Jan 28 2020

ihor_antonovs.family added a comment to D23389: Add deprecation notice to vpo.4 / Remove vpo.4.

I am just a humble FreeBSD user, but I think this absolutely must be done.
Reducing code footprint, attack surface and cognitive overhead for those who maintain the code.
+1

Jan 28 2020, 4:57 AM