Should you remove netdate.c entirely? and remove the prototype from date/extern.h ?

In D18494#394133, @avg wrote:

Unfortunately, I disagree with this change. I think that it is backwards.
illumos has already translated their zfs.1m and zpool.1m to mdoc format, so I assume that that's the direction they are moving in.
I'd rather help them with that in this case as well.
IMO, that would be a better way to overcome the divergence.

Confirmed that this fixes my mlx4en(4) not attaching

Agreed

This is much better.

I think the EFI size should be 200MB or 256MB, rather than 35MB

Yeah, it was just an oversight that we didn't remove this along with bdes back in February 2017.

I am back at home now, so I'll get this refreshed

I am glad to see this progressing again.

Approved By: allanjude

Future note: please upload patches with full context, either using the 'arcanist' tool, or just generate the diff with -U99999 (svn diff -x -U99999)

Approved By: allanjude

Approved By: allanjude

This missing code was identified during the ZFS call earlier today.

I agree with @dvl and @bapt, including only *.conf is common across other parts of FreeBSD and the wider conf.d directory idiom elsewhere. There are too many changes for a rouge file to break your configuration otherwise.

The check for zp->z_unlocked was dropped in rS303763, although possibly only because of the changes to the locking. Maybe @avg can shed more light on it.

Fix makefile

In D17389#370970, @imp wrote:

I'd strongly advise adding DESTDIR support for certctl...

Add missing manpage

Address feedback from delphij

Approved By: allanjude

Approved By: allanjude

Approved By: allanjude

Finish renaming things

Be extra strict when downloading the source-of-truth root certificate chain

Rename trustctl to certctl

Thanks for catching this

Fixes zfs @ mountroot

Last change requested by dteske

Updated with extensive feedback from dteske@

Thanks for all of the feedback

Address the last of dteske's feedback

Fix comment style

Fix a minor error

Update with latest feedback

Address the rest of the feedback from emaste and dteske

Updated to use loader.efi and create a startup.nsh

Approved By: allanjude

+1 this patch, has caught me out a number of times.

In D16684#355335, @mandree wrote:

Thanks. This is looking almost good, just the error handling for the close() and we should be done. I haven't been able to do run-time testing yet.

Again, the downloaded diff does not apply - what's wrong here?

--------------------------
|Index: security/ca_root_nss/files/MAca-bundle.pl.in
|===================================================================
|--- security/ca_root_nss/files/MAca-bundle.pl.in
|+++ security/ca_root_nss/files/MAca-bundle.pl.in
--------------------------
Patching file files/MAca-bundle.pl.in using Plan A...
Hunk #1 succeeded at 1.
Hunk #2 failed at 36.
Hunk #3 succeeded at 92.
Hunk #4 succeeded at 121.
Hunk #5 succeeded at 188.
1 out of 5 hunks failed while patching files/MAca-bundle.pl.in
done