Reviewed By: allanjude

Reviewed By: allanjude

Reviewed By: allanjude

Man page changes approved

Address feedback from Chuck

Reviewed By: allanjude

Reviewed By: allanjude

I don't think the paths will be a problem for reproducibility. You can use temp mounts (mount -t zfs pool/dataset /mnt/whatever) or altroot (create or import the pool with an altroot=/mnt or some other path, and it will prefix all mountpoints with that path).

Fix typo

Reviewed by: allanjude

Reviewed by: allanjude

In D30848#693919, @jhb wrote:

FWIW, the original use case was floppies and that you had to have the bcache_free so that when you swapped floppies (for use with splitfs or kernel and mfsroot on separate floppies), the loader would always read data from the new floppy. However, that use case is no longer relevant.

Reviewed By: allanjude

Reviewed by: allanjude

LGTM

Reviewed By: allanjude

With mjg@'s suggested changes

Reviewed By: allanjude

If there are other characters that need to be blocked, it might make sense to use strcspn. Although I think in this case, what you have here is fine.

Reviewed By: allanjude

@dch feel free to commandeer this. I've updated it to our repo, and resolved the issues building on 12.2

Reviewed By: allanjude

My understanding was this was meant to catch when you switch which timezone you are in, less so detecting when the timezone definition is updated.

I found this while testing, and after digging through the code, discovered that it should be '*' not '+'.

Address review feedback

Reviewed By: allanjude