Page MenuHomeFreeBSD

allanjude (Allan Jude)
UserAdministrator

Projects (11)

User Details

User Since
May 19 2014, 3:05 PM (582 w, 2 d)
Roles
Administrator

Recent Activity

Thu, Jul 3

allanjude accepted D51149: tftpd: explicitly set egid after dropping supplemental groups.
Thu, Jul 3, 3:58 PM

Tue, Jul 1

allanjude accepted D51109: press: added recent Foundation articles.
Tue, Jul 1, 3:44 PM
allanjude added inline comments to D50603: Use ada device names in ZFS handbook chapter instead of legacy da or ad .
Tue, Jul 1, 3:41 PM
allanjude created P662 search git for largest changes.
Tue, Jul 1, 1:36 PM

Fri, Jun 27

allanjude committed rGeae830109571: Fix 2 bugs in non-raw send with encryption (authored by g_amanakis_yahoo.com).
Fix 2 bugs in non-raw send with encryption
Fri, Jun 27, 8:09 PM

Wed, Jun 25

allanjude added a comment to D40816: bsdinstall: protect disk label and zfsboot on Auto ZFS+MBR.
In D40816#1164504, @jhb wrote:

I am not sure how the import of OpenZFS would have changed any of this, but, for MBR we hide the 256kb /boot/zfsboot file in the slack space between the end of the ZFS uberblocks, and the start of the data area (4 MiB offset from the start of the partition).

The first 1kb, is installed in the slack at the start of the partition.

So basically:

  1. mbr reads first 1kb of partition
  2. first 512b of zfsboot knows where to find the rest of zfsboot
  3. the rest of zfsboot is installed at an offset of 1024x512b where the first part of zfsboot knows where to find it.
  1. mbr actually reads the first 512b of the partition

However, this change seems to not trust ZFS to do what you claim above. Rather than letting ZFS start at the start of the MBR slice, it is creating an explicit gap so that s1a doesn't start at the the start of a slice but leaves a 2048 sector (1MB) "hole" (between the start of the MBR slice, and the first BSD label partition ("s1a"). It then places the rest of the zfsboot payload at an offset (1024 sectors in) to the rest of that "hole" before the actual ZFS partition starts. So, clearly it seems like OpenZFS is not preserving the same layout for some reason and this change is trying to avoid interacting with ZFS entirely. If we really want ZFS + MBR to work this way, we should just change zfsboot to stop assuming the 1024 offset so we can write zfsboot contiguously to the start of the MBR slice. Then we could at least leave a smaller "hole" prior to "s1a". I'm also not sure how wise it is to leave unallocated space in the BSD label at the start of the slice. If you happen to fat finger a gpart command in the future, you could end up adding a new partition in the "hole" and end up overwriting the zfsboot contents. :(

Given all that, I wonder if we shouldn't just punt and say that ZFS + MBR isn't supported anymore. It hasn't worked in years and is pretty fragile.

Wed, Jun 25, 5:08 PM
allanjude committed rG32f9c9699a5a: Reset kvo_laundry to prevent it being cumulative (authored by allanjude).
Reset kvo_laundry to prevent it being cumulative
Wed, Jun 25, 1:40 PM
allanjude closed D50907: Reset kvo_laundry to prevent it being cumulative.
Wed, Jun 25, 1:39 PM

Tue, Jun 24

allanjude accepted D50941: bsdinstall: Report error from installing firmware.

I wonder if the -q ends up hiding too much useful context for the error, but better to avoid the console spam in the happy case.

Tue, Jun 24, 6:27 PM
allanjude accepted D51014: lockf: add a -p mode to write the child's pid.

Very useful functionality

Tue, Jun 24, 3:51 PM
allanjude accepted D51009: pkill: better document ancestor-hiding.
Tue, Jun 24, 1:36 PM

Sun, Jun 22

allanjude added a comment to D49993: bridge(4): allow member interface vlan to be configured.

The description says 'patched' (if an tagged incoming frame does not patch the port's pvid) where I think you meant 'matched'

Sun, Jun 22, 5:41 PM

Fri, Jun 20

allanjude accepted D50949: scandir: Fix behavior when no entries match..
Fri, Jun 20, 4:11 PM

Thu, Jun 19

allanjude accepted D50925: shar: remove from the tree well in advance of the 15.0 release.
Thu, Jun 19, 12:58 AM

Tue, Jun 17

allanjude requested review of D50907: Reset kvo_laundry to prevent it being cumulative.
Tue, Jun 17, 1:53 PM

Jun 15 2025

allanjude accepted D50647: INDEX.keymaps: Fix "Mulitlingual" typo.
Jun 15 2025, 8:46 PM

Jun 9 2025

allanjude accepted D50714: cp: Improve -p flag tests..
Jun 9 2025, 1:08 PM

May 31 2025

allanjude accepted D50348: netcat: Allow service names to be used..
May 31 2025, 2:49 PM
allanjude accepted D50628: cp: Improve to_root test case..
May 31 2025, 2:45 PM

May 30 2025

allanjude accepted D40816: bsdinstall: protect disk label and zfsboot on Auto ZFS+MBR.

I am not sure how the import of OpenZFS would have changed any of this, but, for MBR we hide the 256kb /boot/zfsboot file in the slack space between the end of the ZFS uberblocks, and the start of the data area (4 MiB offset from the start of the partition).

May 30 2025, 9:13 PM
allanjude accepted D50604: cp: Fix copying to root directory..
May 30 2025, 2:08 PM

May 11 2025

allanjude accepted D50297: bsdinstall: Use a login shell for final configuration..

I didn't realize we had added -l to /bin/sh.

May 11 2025, 3:55 PM
allanjude added inline comments to D50297: bsdinstall: Use a login shell for final configuration..
May 11 2025, 3:22 PM
allanjude requested changes to D50297: bsdinstall: Use a login shell for final configuration..
May 11 2025, 3:21 PM
allanjude accepted D50297: bsdinstall: Use a login shell for final configuration..
May 11 2025, 3:19 PM

May 9 2025

allanjude accepted D50257: cp: Fix dead link case..
May 9 2025, 12:55 PM
allanjude accepted D50256: cp: Address style issues from external review..
May 9 2025, 12:51 PM

May 7 2025

allanjude created P659 Rogers traceroute to NYI.
May 7 2025, 9:53 PM

Apr 15 2025

allanjude accepted D49842: ln: Tweak append logic..
Apr 15 2025, 5:50 PM
allanjude accepted D49841: cp: Improve error messages..
Apr 15 2025, 5:48 PM

Apr 1 2025

allanjude accepted D49624: fts: Stop abusing the comma operator..
Apr 1 2025, 1:53 PM

Feb 28 2025

allanjude accepted D49165: Makefile.inc1: Make package timestamps reproducible.

Looks good

Feb 28 2025, 3:12 PM

Feb 26 2025

allanjude accepted D48464: libbe: avoid copying encryption-related props.

Otherwise looks good to me.

Feb 26 2025, 4:55 PM

Feb 18 2025

allanjude added a comment to D46235: devel/py-ordered-set: convert to USE_PYTHON=pep517.

This seems fine, is there a reason it is not moving forward?

Feb 18 2025, 2:24 PM
allanjude accepted D49044: net/samba4{19,20}: "samba-tool domain backup offline" hangs.

silly GNU getopt

Feb 18 2025, 2:21 PM

Feb 10 2025

allanjude added a comment to D48874: swapon: parse md.eli device for encrypted swapfile from fstab.
In D48874#1114805, @dsl wrote:

Could you add a short test plan to follow?

I hope the test plan is as expected. Otherwise please let me know.

Feb 10 2025, 5:32 PM
allanjude added inline comments to D48874: swapon: parse md.eli device for encrypted swapfile from fstab.
Feb 10 2025, 5:31 PM

Feb 7 2025

allanjude accepted D48883: [NEW-PORT] sysutils/data-prepper: Opensearch Data Prepper.
Feb 7 2025, 2:43 PM
allanjude accepted D48882: [NEW-PORT] net/akhq: Web GUI for Apache Kafka.
Feb 7 2025, 2:05 PM

Jan 30 2025

allanjude added a comment to D10320: usr.bin/netstat: -n should not print symbolic names.
Jan 30 2025, 9:00 PM
allanjude accepted D48729: netstat: restore printing the "default" keyword, provide -nn option.

This seems like the best approach to avoid surprising users and breaking scripts.

Jan 30 2025, 8:54 PM
allanjude added a member for Klara: becker.greg_att.net.
Jan 30 2025, 5:29 PM
allanjude added a member for Klara: bnovkov.
Jan 30 2025, 5:29 PM

Jan 9 2025

allanjude committed R9:be306ce3f5a5: 11.4 release notes: man page links to freebsd-update(8) were incorrect (authored by allanjude).
11.4 release notes: man page links to freebsd-update(8) were incorrect
Jan 9 2025, 12:29 AM
allanjude committed R9:f4ef77ce87f5: Fix references to the 'previous version' in the 11.4 release notes (authored by allanjude).
Fix references to the 'previous version' in the 11.4 release notes
Jan 9 2025, 12:27 AM

Dec 23 2024

allanjude accepted D48181: diff: Fix device case..

Reviewed by: allanjude

Dec 23 2024, 5:11 PM

Dec 18 2024

allanjude accepted D48130: shar: add a deprecation notice.
Dec 18 2024, 2:39 AM

Dec 12 2024

allanjude added a reviewer for D38047: Multiple fixes to the NSS caching system: Klara.
Dec 12 2024, 1:44 PM · Src Committers

Dec 7 2024

allanjude accepted D47977: strptime: Fix day-of-week calculation..
Dec 7 2024, 1:59 PM

Dec 3 2024

allanjude accepted D47875: stress2: Use tests as the default test user..
Dec 3 2024, 1:43 PM

Nov 26 2024

allanjude committed rG9206c7996198: usr.bin/netstat: -n should not print symbolic names (authored by allanjude).
usr.bin/netstat: -n should not print symbolic names
Nov 26 2024, 2:57 PM
allanjude closed D10320: usr.bin/netstat: -n should not print symbolic names.
Nov 26 2024, 2:57 PM

Nov 13 2024

allanjude accepted D47537: mv: Type and style nits..
Nov 13 2024, 1:45 PM

Oct 8 2024

allanjude accepted D41784: cat: report copy_file_range() errors with the read filename.
Oct 8 2024, 12:29 PM

Oct 7 2024

allanjude created firewall.
Oct 7 2024, 3:10 PM

Sep 20 2024

allanjude added a comment to D46717: diff: support -qq to output absolutely nothing.

still a WIP

Sep 20 2024, 3:31 PM
allanjude requested review of D46717: diff: support -qq to output absolutely nothing.
Sep 20 2024, 3:31 PM
allanjude requested review of D46716: periodic 100.chksetuid: supress output if diff is purely whitespace.
Sep 20 2024, 3:19 PM

Sep 6 2024

allanjude added a comment to D45056: support for DIRECT access via ggated and ggatec.

How should I submit this to you for the path; I have never used git format-patch before; I tried doing git format-patch main and it generated 21 files (since I have 21 commits). Manpage suggests I email this to you? But it seems rude to just blast you with 21 patches; and I don't know your email.

Sep 6 2024, 12:42 PM · Src Committers

Aug 27 2024

allanjude accepted D46454: netinet: Explicitly disallow connections to the unspecified address.
Aug 27 2024, 4:02 PM

Aug 2 2024

allanjude accepted D46216: shutdown: add a flag to suppress warning messages.
Aug 2 2024, 10:32 PM

Aug 1 2024

allanjude added a reviewer for D39768: sockets: avoid layering violation in handling SO_SETFIB: markj.
Aug 1 2024, 3:31 PM

Jul 30 2024

allanjude accepted D46174: ifnet(9): Remove mention of defunct ifaddr_byindex(9)..
Jul 30 2024, 1:40 PM

Jul 27 2024

allanjude accepted D46169: diff: Fix integer overflow..
Jul 27 2024, 6:00 PM

Jul 25 2024

allanjude accepted D46136: netinet6 tests: Add a regression test for default router handling.
Jul 25 2024, 5:56 PM

Jul 23 2024

allanjude accepted D32615: route: avoid overlapping strcpy.
Jul 23 2024, 12:22 PM
allanjude added a comment to D46069: route: avoid overlapping strcpy(3).
In D46069#1050289, @fuz wrote:

Wouldn't it be much simpler to just keep a pointer to the domain part around rather than moving it to the beginning of the domain array?

Jul 23 2024, 12:21 PM

Jul 9 2024

allanjude accepted D44488: pf: if a new RDR state connect be created, modulate src port.
Jul 9 2024, 1:16 PM
allanjude accepted D45672: pf: Make pf_get_translation() more expressive.
Jul 9 2024, 1:12 PM

Jun 29 2024

allanjude accepted D45779: diff: Document the --no-dereference option..

I kind of feel that '--no-follow' is the more common name, but not that fussed.

Jun 29 2024, 8:14 PM

Jun 21 2024

allanjude accepted D45676: Prepare some build fixes in advance of more _FORTIFY_SOURCE.

ZFS bits look good to me

Jun 21 2024, 5:04 PM

Jun 16 2024

allanjude added a reviewer for D45602: Allow setting socket error: markj.
Jun 16 2024, 11:02 PM

Jun 14 2024

allanjude accepted D45585: ifconfig: turn interface address without mask into an error.

The warning has been there long enough, and an error is better than doing the wrong thing, it has far fewer side effects.

Jun 14 2024, 2:02 PM

Jun 13 2024

allanjude accepted D45576: tzsetup: add detail to -s option.
Jun 13 2024, 3:28 PM
allanjude accepted D45575: tzsetup: ask local/UTC question only on x86.
Jun 13 2024, 3:27 PM
allanjude added a comment to D45537: netcat: Update to OpenBSD 7.5.

The most important change was to add support of TLS, which is #ifdef'ed out and the rest of change is not quite worth the effort IMHO.

It would be nice to have something that implements libtls APi, e.g. libretls first.

Jun 13 2024, 12:57 AM
allanjude accepted D45572: adjkerntz(8): Prefer "Real-Time Clock (RTC)" terminology.
Jun 13 2024, 12:23 AM
allanjude accepted D45573: tzsetup: Correct UTC description.
Jun 13 2024, 12:19 AM

Jun 11 2024

allanjude added inline comments to D34498: libmd: stop exporting _block symbols.
Jun 11 2024, 4:15 PM
allanjude added a reviewer for D45537: netcat: Update to OpenBSD 7.5: des.
Jun 11 2024, 4:03 PM

Jun 9 2024

allanjude updated the diff for D45537: netcat: Update to OpenBSD 7.5.

Fix usage() alignment

Jun 9 2024, 12:15 AM
allanjude requested review of D45537: netcat: Update to OpenBSD 7.5.
Jun 9 2024, 12:07 AM

Jun 8 2024

allanjude committed rG1849781381dd: Import netcat from OpenBSD 7.5. (authored by allanjude).
Import netcat from OpenBSD 7.5.
Jun 8 2024, 10:51 PM

Jun 6 2024

allanjude committed rG4472fd66d006: lam: fail on I/O errors (authored by ccecchi_apple.com).
lam: fail on I/O errors
Jun 6 2024, 5:27 PM
allanjude closed D45437: lam: fail on I/O errors.
Jun 6 2024, 5:26 PM
allanjude committed rG7dd39ef4e0d5: comm: close a race condition when comm is fed from stdin (authored by ccecchi_apple.com).
comm: close a race condition when comm is fed from stdin
Jun 6 2024, 5:07 PM
allanjude committed rG63f5c101a1fd: comm: flush stdout for error checking prior to exiting (authored by ccecchi_apple.com).
comm: flush stdout for error checking prior to exiting
Jun 6 2024, 5:07 PM
allanjude closed D45440: comm: close a race condition when comm is fed from stdin.
Jun 6 2024, 5:07 PM
allanjude closed D45439: comm: flush stdout for error checking prior to exiting.
Jun 6 2024, 5:07 PM
allanjude accepted D45092: ifconfig(8): wordsmith -G and -g descriptions.

Looks good, just the SPDX and the date need fixing.

Jun 6 2024, 4:04 PM

Jun 5 2024

allanjude accepted D45493: pci(4): unbreak the build.
Jun 5 2024, 1:23 PM

Jun 4 2024

allanjude accepted D45437: lam: fail on I/O errors.
Jun 4 2024, 11:19 PM
allanjude accepted D45439: comm: flush stdout for error checking prior to exiting.
Jun 4 2024, 11:13 PM
allanjude accepted D45440: comm: close a race condition when comm is fed from stdin.
Jun 4 2024, 11:13 PM
allanjude accepted D45488: radlib: fix a memory leak.
Jun 4 2024, 8:12 PM
allanjude added a comment to D45444: lib/libmd: rework and accelerate SHA1 implementation.

Are you sure it is safe to drop the __weak_reference() bits at the bottom? They relate to the fact that there are conflicts between libmd and libcrypt (not to be confused with libcrypto)

Jun 4 2024, 12:16 AM

May 31 2024

allanjude awarded Dev Summit Attendee to recipient: ccecchi_apple.com.
May 31 2024, 7:33 PM

May 24 2024

allanjude abandoned D22444: Add UDP encapsulation of ESP in IPv6.

That was committed as https://reviews.freebsd.org/D42526 / 80044c785cb040a2cf73779d23f9e1e81a00c6c3

May 24 2024, 6:09 PM
allanjude commandeered D22444: Add UDP encapsulation of ESP in IPv6.
May 24 2024, 6:08 PM
allanjude accepted D45343: net-mgmt/net-snmp: Print a warning if config files aren't readable.
May 24 2024, 3:17 PM