Page MenuHomeFreeBSD

allanjude (Allan Jude)
UserAdministrator

Projects (9)

User Details

User Since
May 19 2014, 3:05 PM (471 w, 5 d)
Roles
Administrator

Recent Activity

Mon, May 22

allanjude accepted D40200: ctags: Error out if writing to stdout failed..

Reviewed-by: allanjude

Mon, May 22, 1:02 PM

Thu, May 18

allanjude requested review of D40142: Remove the "hardening" menu frm bsdinstall.
Thu, May 18, 2:00 PM

Wed, May 10

allanjude accepted D40032: md5: Add missing references to sha384..

Reviewed by: allanjude

Wed, May 10, 1:08 PM

Apr 11 2023

allanjude committed R9:037bedfaf948: 13.2 Relnotes: Link to the freebsd-update instructions in the handbook (authored by allanjude).
13.2 Relnotes: Link to the freebsd-update instructions in the handbook
Apr 11 2023, 10:57 PM
allanjude committed R9:b8788e696dfd: Update freebsd-update section to reference upgrading 13.1 to 13.2 (authored by allanjude).
Update freebsd-update section to reference upgrading 13.1 to 13.2
Apr 11 2023, 10:40 PM

Apr 10 2023

allanjude committed rG461ccb55d50c: dhclient: add ability to ignore options in offers (authored by rob.norris_klarasystems.com).
dhclient: add ability to ignore options in offers
Apr 10 2023, 11:14 PM

Apr 4 2023

allanjude accepted D39400: efi: Add zfs bootonce support to boot1.efi.

Reviewed by: allanjude

Apr 4 2023, 1:31 AM

Mar 25 2023

allanjude accepted D39266: pwd_mkdb: Sort options and update usage message..

Reviewed by: allanjude

Mar 25 2023, 2:09 PM

Mar 17 2023

allanjude added a member for Klara: rob.norris_klarasystems.com.
Mar 17 2023, 1:04 AM

Mar 14 2023

allanjude closed D38600: loader: Add support for booting from a ZFS snapshot.
Mar 14 2023, 2:20 PM
allanjude committed rGa849842f510a: loader: Add support for booting from a ZFS snapshot (authored by allanjude).
loader: Add support for booting from a ZFS snapshot
Mar 14 2023, 2:20 PM

Mar 1 2023

allanjude committed rG71af885af9c8: u3g(4): Add device ID for the Quectel EM160R (authored by allanjude).
u3g(4): Add device ID for the Quectel EM160R
Mar 1 2023, 2:08 PM

Feb 28 2023

allanjude accepted D38663: pkill: use an ARG_MAX size buffer for argument matching.

Reviewed by: allanjude

Feb 28 2023, 2:52 AM

Feb 22 2023

allanjude accepted D38734: stand: fix buffer overflow in getrootmount().

Reviewed by: allanjude

Feb 22 2023, 11:26 PM
allanjude committed rGb772fe0d6626: Fix per-jail zfs.mount_snapshot setting (authored by allanjude).
Fix per-jail zfs.mount_snapshot setting
Feb 22 2023, 1:49 PM

Feb 21 2023

allanjude committed rG426ed0052540: Fix per-jail zfs.mount_snapshot setting (authored by allanjude).
Fix per-jail zfs.mount_snapshot setting
Feb 21 2023, 10:47 PM
allanjude committed rG8b04c1cbfc1c: Fix per-jail zfs.mount_snapshot setting (authored by allanjude).
Fix per-jail zfs.mount_snapshot setting
Feb 21 2023, 10:44 PM
allanjude closed D38662: Fix per-jail zfs.mount_snapshot setting.
Feb 21 2023, 10:43 PM
allanjude added a comment to D38600: loader: Add support for booting from a ZFS snapshot.
In D38600#881030, @imp wrote:

btw, this looks really cool...

One other thing... where is the 'read only' flag set. I may be missing it, but I don't see it here.

Feb 21 2023, 10:38 PM
allanjude added a comment to D38600: loader: Add support for booting from a ZFS snapshot.
In D38600#881029, @imp wrote:

so can we use zfs:<snapshot> in all the places where we can use zfs:<dataset> now with these changes?

Feb 21 2023, 10:37 PM
allanjude requested review of D38600: loader: Add support for booting from a ZFS snapshot.
Feb 21 2023, 9:44 PM

Feb 19 2023

allanjude requested review of D38662: Fix per-jail zfs.mount_snapshot setting.
Feb 19 2023, 1:03 AM

Feb 18 2023

allanjude committed rGdf91d8167d97: mutex(9): correct man page, mtx_trylock_spin returns int not void (authored by allanjude).
mutex(9): correct man page, mtx_trylock_spin returns int not void
Feb 18 2023, 2:32 AM
allanjude closed D35283: mutex(9): correct man page, mtx_trylock_spin returns int not void.
Feb 18 2023, 2:31 AM

Feb 15 2023

allanjude added inline comments to D38618: nproc: denote an incompatiblity with Linux.
Feb 15 2023, 8:51 PM

Feb 9 2023

allanjude added inline comments to D38463: tarfs: Fix issues revealed by static analysis and testing..
Feb 9 2023, 3:40 PM

Feb 8 2023

allanjude added inline comments to D38413: ahci: increase timout.
Feb 8 2023, 1:23 PM

Feb 6 2023

allanjude accepted D38373: libmd / md5: Add SHA-512/224..

Reviewed by: allanjude

Feb 6 2023, 4:07 PM

Feb 5 2023

allanjude accepted D38244: daemon: add long_opts.
Feb 5 2023, 5:57 PM
allanjude accepted D38244: daemon: add long_opts.
Feb 5 2023, 5:55 PM
allanjude accepted D38244: daemon: add long_opts.

Reviewed by: allanjude

Feb 5 2023, 5:39 PM

Feb 4 2023

allanjude accepted D38382: contributing: Start pointing people at github.

Reviewed by: allanjude

Feb 4 2023, 7:47 PM
allanjude added inline comments to D38244: daemon: add long_opts.
Feb 4 2023, 6:34 PM
allanjude requested changes to D38244: daemon: add long_opts.
Feb 4 2023, 5:48 PM

Feb 3 2023

allanjude accepted D38369: cp: Minor code cleanup..

Reviewed by: allanjude

Feb 3 2023, 1:49 PM

Feb 2 2023

allanjude accepted D38344: timeout: Move from /usr/bin to /bin.

Reviewed by: allanjude

Feb 2 2023, 5:10 PM

Feb 1 2023

allanjude accepted D38286: libc: Add tests for strchrnul(3)..

Reviewed by: allanjude

Feb 1 2023, 1:47 PM

Jan 31 2023

allanjude accepted D38287: Improve the style in one of the examples..

approved by: allanjude

Jan 31 2023, 2:20 AM
allanjude accepted D38288: Remove single-use variable..

Approved by: allanjude

Jan 31 2023, 2:19 AM

Jan 27 2023

allanjude committed rG5ff13fbc199b: MFV: zstd 1.5.2 (authored by allanjude).
MFV: zstd 1.5.2
Jan 27 2023, 5:31 PM

Jan 25 2023

allanjude accepted D38141: tzcode: Document zic's -D option..
Jan 25 2023, 4:12 PM
allanjude accepted D38142: zoneinfo: On amd64, include 32-bit data..

Reviewed by: allanjude

Jan 25 2023, 1:13 PM
allanjude accepted D38141: tzcode: Document zic's -D option..

Reviewed by: allanjude

Jan 25 2023, 1:11 PM
allanjude committed rGb3392d84da5b: Import zstd 1.5.2 (authored by allanjude).
Import zstd 1.5.2
Jan 25 2023, 1:25 AM

Jan 18 2023

allanjude added a comment to D37767: Add CPU Ident for Qualcomm Kryo 400 (used in MS Dev Kit).

I pulled the neoverse bits out, but didn't stage it properly, and the commit went in with the bits that were supposed to be excluded

Jan 18 2023, 9:10 PM
allanjude committed rGfd5e9210598c: Add CPU Ident for Qualcomm Kryo 400 (used in MS Dev Kit) (authored by allanjude).
Add CPU Ident for Qualcomm Kryo 400 (used in MS Dev Kit)
Jan 18 2023, 9:06 PM
allanjude closed D37767: Add CPU Ident for Qualcomm Kryo 400 (used in MS Dev Kit).
Jan 18 2023, 9:05 PM

Jan 14 2023

allanjude accepted D25368: Allow comma in login.conf capabilities.

Reviewed-by: allanjude

Jan 14 2023, 4:18 PM
allanjude added a reviewer for D25368: Allow comma in login.conf capabilities: Klara.
Jan 14 2023, 2:07 PM
allanjude added inline comments to D25368: Allow comma in login.conf capabilities.
Jan 14 2023, 1:59 PM

Jan 13 2023

allanjude added a reviewer for D27318: freebsd-version(1): present -v option, to print verbose output: Klara.
Jan 13 2023, 9:45 PM

Dec 22 2022

allanjude added a reviewer for D35531: Propigate v_free_target updates to pid controllers in each domain: khng.
Dec 22 2022, 7:29 PM

Dec 6 2022

allanjude committed R9:36e46ab1949c: Correct the release date of FreeBSD 12.4 to not be in the past (authored by allanjude).
Correct the release date of FreeBSD 12.4 to not be in the past
Dec 6 2022, 12:33 AM

Dec 2 2022

allanjude committed rGc6ec1b441ad3: Add support for adding default routes for other FIBs (authored by andrew.fengler_scaleengine.com).
Add support for adding default routes for other FIBs
Dec 2 2022, 9:29 PM

Nov 17 2022

allanjude accepted D37076: Fix blksize selection in vn_generic_copy_file_range() for ZFS.

Reviewed By: allanjude

Nov 17 2022, 12:59 AM

Nov 14 2022

allanjude added a reviewer for D37383: service(8): add -s for showing status: 0mp.
Nov 14 2022, 1:11 AM · rc
allanjude accepted D37383: service(8): add -s for showing status.

Reviewed-by: allanjude

Nov 14 2022, 1:11 AM · rc

Nov 4 2022

allanjude accepted D37265: getty: Avoid NULL deref if stdin is not a tty..

Reviewed by: allanjude

Nov 4 2022, 3:31 PM
allanjude added inline comments to D37265: getty: Avoid NULL deref if stdin is not a tty..
Nov 4 2022, 2:46 PM
allanjude accepted D37263: getty: code cleanup, part 1.

Reviewed by: allanjude

Nov 4 2022, 2:01 PM
allanjude accepted D37236: gzip: Add support for decompressing zstd files..

Reviewed by: allanjude

Nov 4 2022, 12:48 PM

Oct 27 2022

allanjude accepted D37138: script: Correct -F in man page and usage string. Sponsored by: Klara, Inc. MFC after: 1 week script: Add usage string for playback mode. Sponsored by: Klara, Inc..
Oct 27 2022, 2:32 PM

Oct 20 2022

allanjude added a comment to D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..

The reason we stopped doing this originally, is that if ZFS imports the pool using disk names like /dev/ada0p3, then the GPT label version like /dev/gpt/swap went away, and then you ended up with no swap mounted.
I don't know if things have changed somewhat since when I ran into these problems around 2015. I know there was some work to try to mitigate the issue.

Oct 20 2022, 2:39 AM

Oct 7 2022

allanjude accepted D36906: Tolerate missing /usr/bin/timeout in zfskeys.

Reviewed by: allanjude

Oct 7 2022, 6:24 PM · rc
allanjude added inline comments to D36906: Tolerate missing /usr/bin/timeout in zfskeys.
Oct 7 2022, 5:53 PM · rc
allanjude added a reviewer for D36906: Tolerate missing /usr/bin/timeout in zfskeys: Klara.
Oct 7 2022, 5:31 PM · rc
allanjude committed rG50315501340c: Bump MAC_VERSION to 5 (authored by allanjude).
Bump MAC_VERSION to 5
Oct 7 2022, 3:26 PM

Sep 30 2022

allanjude accepted D36459: bsdinstall: add hooks to allow for easier customizing the install.

Approved by: allanjude

Sep 30 2022, 3:17 PM

Sep 27 2022

allanjude added members for Klara: markj, des.
Sep 27 2022, 7:51 PM

Sep 20 2022

allanjude added inline comments to D36241: freebsd-update(8): add new command to 'check' for available updates only.
Sep 20 2022, 5:30 PM
allanjude accepted D36635: release: Use standard mount points for arm MBR boot images.

LGTM

Sep 20 2022, 3:17 PM

Sep 13 2022

allanjude added a comment to D36459: bsdinstall: add hooks to allow for easier customizing the install.

If you use . instead of sh thse local scripts would have more access to the environment variables.

Sep 13 2022, 12:15 AM
allanjude accepted D36235: bsdinstall: fix a couple stragglers in whitelabeling the scripts.

Reviewed by: allanjude

Sep 13 2022, 12:10 AM

Sep 12 2022

allanjude accepted D36539: siftr: spell PFIL_PASS correctly..

Reviewed by: allanjude

Sep 12 2022, 5:15 PM

Sep 10 2022

allanjude committed rGb20ec58669e2: vfs.typenumhash: fix sysctl description (authored by allanjude).
vfs.typenumhash: fix sysctl description
Sep 10 2022, 10:49 PM

Aug 23 2022

allanjude committed R9:495ce84e20ac: 13.2 release schedue: fix asciidoc syntax error (authored by allanjude).
13.2 release schedue: fix asciidoc syntax error
Aug 23 2022, 8:01 PM

Aug 20 2022

allanjude added a reviewer for D36081: zfskeys: if location is prompt then prompt during boot: 0mp.
Aug 20 2022, 2:20 AM

Aug 16 2022

allanjude added a comment to D36194: copy_file_range: If _PC_MIN_HOLE_SIZE is small, use mnt_stat.f_iosize.

As far as fusefs goes, we don't know the true blocksize. The FUSE protocol gives us no way of knowing. So using f_iosize is probably the best that we can do, and that's what this patch will do.

Bu I have another question: why does ZFS always return 512B for _PC_MIN_HOLE_SIZE ? pathconf(2) operates on individual paths, so it could return VTOZ(vp)->z_blksz . But I'm not sure what that will show for an empty file; we must test it.

Aug 16 2022, 3:06 PM
allanjude added a comment to D36194: copy_file_range: If _PC_MIN_HOLE_SIZE is small, use mnt_stat.f_iosize.
In D36194#821894, @mav wrote:

Looks good to me, but as was told it would be good for ZFS to report more realistic minimal hole, if possible, rather than absolute minimum. I'd also like this to be able to copy multiple blocks at a time, that may be very helpful for small blocks and sync=always.

Aug 16 2022, 3:04 PM

Aug 14 2022

allanjude added a comment to D36194: copy_file_range: If _PC_MIN_HOLE_SIZE is small, use mnt_stat.f_iosize.

This version looks fine to me.

I do have a couple more comments....
Would allowing a greater than maxphys size for the canseek
case make sense (ie. up to 16Mbytes for ZFS instead of 1Mbyte)?

Aug 14 2022, 4:58 PM
allanjude added a reviewer for D36194: copy_file_range: If _PC_MIN_HOLE_SIZE is small, use mnt_stat.f_iosize: asomers.
Aug 14 2022, 4:57 PM
allanjude added a comment to D36194: copy_file_range: If _PC_MIN_HOLE_SIZE is small, use mnt_stat.f_iosize.

I've also updated the commit message to reflect the changes, can you give it a look over and make sure you agree with it. Thank you.

Aug 14 2022, 2:28 PM
allanjude updated the diff for D36194: copy_file_range: If _PC_MIN_HOLE_SIZE is small, use mnt_stat.f_iosize.

Add comment as recommended by rmacklem

Aug 14 2022, 2:28 PM
allanjude retitled D36194: copy_file_range: If _PC_MIN_HOLE_SIZE is small, use mnt_stat.f_iosize from copy_file_range: copy maxphys sized chunks unless hole detection fails to copy_file_range: If _PC_MIN_HOLE_SIZE is small, use mnt_stat.f_iosize.
Aug 14 2022, 2:27 PM
allanjude updated the diff for D36194: copy_file_range: If _PC_MIN_HOLE_SIZE is small, use mnt_stat.f_iosize.

Update based on feedback from rmacklem

Aug 14 2022, 2:22 PM
allanjude added inline comments to D36194: copy_file_range: If _PC_MIN_HOLE_SIZE is small, use mnt_stat.f_iosize.
Aug 14 2022, 4:54 AM
allanjude added a comment to D36194: copy_file_range: If _PC_MIN_HOLE_SIZE is small, use mnt_stat.f_iosize.

This basically looks ok to me. However, I have been recently playing with
sparse files on ZFS and I don't seem to be able to create an imbedded
hole (one not to EOF) which is less than 128K and I seem to be able to
create a hole of just about any size at EOF (truncate grows file size).

Aug 14 2022, 2:26 AM

Aug 13 2022

allanjude updated the diff for D36194: copy_file_range: If _PC_MIN_HOLE_SIZE is small, use mnt_stat.f_iosize.

With the previous change, we don't need the condition when resetting xfer at the end of the loop

Aug 13 2022, 10:26 PM
allanjude updated the diff for D36194: copy_file_range: If _PC_MIN_HOLE_SIZE is small, use mnt_stat.f_iosize.

Set blksize to match xfer in the maxphys case, because vn_write_outvp() copies in blksize chunks

Aug 13 2022, 8:57 PM
allanjude updated the diff for D36194: copy_file_range: If _PC_MIN_HOLE_SIZE is small, use mnt_stat.f_iosize.

Fix missing ;

Aug 13 2022, 8:24 PM
allanjude added reviewers for D36194: copy_file_range: If _PC_MIN_HOLE_SIZE is small, use mnt_stat.f_iosize: rmacklem, jrtc27, imp, kevans, mav.
Aug 13 2022, 8:22 PM
allanjude requested review of D36194: copy_file_range: If _PC_MIN_HOLE_SIZE is small, use mnt_stat.f_iosize.
Aug 13 2022, 8:21 PM

Aug 5 2022

allanjude abandoned D17513: Add missing performance optimization of AVL tree comparator functions.

overcome by events

Aug 5 2022, 3:27 PM
allanjude accepted D35357: bsdinstall: add variables to allow skipping over some phases of the install.

Reviewed by: allanjude

Aug 5 2022, 3:24 PM

Jul 21 2022

allanjude added a reverting change for rG3810b3790322: mac_ddb: Make db_show_vnet_valid() handle !VIMAGE: rGe89841f89318: Revert "mac_ddb: Make db_show_vnet_valid() handle !VIMAGE".
Jul 21 2022, 2:28 PM
allanjude committed rGe89841f89318: Revert "mac_ddb: Make db_show_vnet_valid() handle !VIMAGE" (authored by allanjude).
Revert "mac_ddb: Make db_show_vnet_valid() handle !VIMAGE"
Jul 21 2022, 2:28 PM
allanjude committed rG3810b3790322: mac_ddb: Make db_show_vnet_valid() handle !VIMAGE (authored by allanjude).
mac_ddb: Make db_show_vnet_valid() handle !VIMAGE
Jul 21 2022, 2:01 PM

Jul 18 2022

allanjude committed rG4e2121c10afc: mac_ddb: add some validation functions (authored by mhorne).
mac_ddb: add some validation functions
Jul 18 2022, 10:09 PM
allanjude committed rG2449b9e5fe56: mac: kdb/ddb framework hooks (authored by mhorne).
mac: kdb/ddb framework hooks
Jul 18 2022, 10:09 PM
allanjude committed rG287d467c5db5: mac: add new mac_ddb(4) policy (authored by mhorne).
mac: add new mac_ddb(4) policy
Jul 18 2022, 10:09 PM