Page MenuHomeFreeBSD

allanjude (Allan Jude)
UserAdministrator

Projects (6)

User Details

User Since
May 19 2014, 3:05 PM (353 w, 2 d)
Roles
Administrator

Recent Activity

Today

allanjude retitled D28740: smbios: Use loader provided address for SMBIOS entry point from smbios: Use loader provided adddress for SMBIOS entry point to smbios: Use loader provided address for SMBIOS entry point.
Wed, Feb 24, 2:51 PM
allanjude updated the diff for D28743: ipmi_smbios: Deduplicate smbios entry point discovery logic.

After rebase

Wed, Feb 24, 2:51 PM

Yesterday

allanjude added a reverting change for R10:ba6e37e47f41: ipmi_smbios: Deduplicate smbios entry point discovery logic: R10:6d67af5f8e66: Revert "ipmi_smbios: Deduplicate smbios entry point discovery logic".
Tue, Feb 23, 10:51 PM
allanjude committed R10:6d67af5f8e66: Revert "ipmi_smbios: Deduplicate smbios entry point discovery logic" (authored by allanjude).
Revert "ipmi_smbios: Deduplicate smbios entry point discovery logic"
Tue, Feb 23, 10:51 PM
allanjude added a reverting change for R10:d2589dc3d56c: ipmi_smbios: remove unused smbios_cksum function: R10:4a5dfded17ef: Revert "ipmi_smbios: remove unused smbios_cksum function".
Tue, Feb 23, 10:51 PM
allanjude added a reverting change for D28743: ipmi_smbios: Deduplicate smbios entry point discovery logic: R10:6d67af5f8e66: Revert "ipmi_smbios: Deduplicate smbios entry point discovery logic".
Tue, Feb 23, 10:51 PM
allanjude added a reverting change for D28751: ipmi_smbios: remove unused smbios_cksum function: R10:4a5dfded17ef: Revert "ipmi_smbios: remove unused smbios_cksum function".
Tue, Feb 23, 10:50 PM
allanjude committed R10:4a5dfded17ef: Revert "ipmi_smbios: remove unused smbios_cksum function" (authored by allanjude).
Revert "ipmi_smbios: remove unused smbios_cksum function"
Tue, Feb 23, 10:50 PM
allanjude reopened D28743: ipmi_smbios: Deduplicate smbios entry point discovery logic.

I had to revert this, as it depends on https://reviews.freebsd.org/D28739 which isn't ready to land yet

Tue, Feb 23, 10:50 PM
allanjude updated the diff for D28737: stand: Support (and prefer) the SMBIOS 64-bit Entry Point Structure.

Fix a typo

Tue, Feb 23, 10:24 PM
allanjude updated the diff for D28737: stand: Support (and prefer) the SMBIOS 64-bit Entry Point Structure.

Switch to Scott's newer suggested code that is much cleaner

Tue, Feb 23, 9:57 PM
allanjude updated the diff for D28745: ipmi: Add smbus and pci ipmi types to aarch64 builds.

Add the new code to sys/conf/files.arm64 as well, so IPMI works when built into the kernel

Tue, Feb 23, 9:38 PM
allanjude retitled D28745: ipmi: Add smbus and pci ipmi types to aarch64 builds from ipmi: Add smbus and pci ipmi types to aarch64 build to ipmi: Add smbus and pci ipmi types to aarch64 builds.
Tue, Feb 23, 9:38 PM
allanjude added reviewers for D28739: smbios: Support (and prefer) the SMBIOS 64-bit Entry Point Structure: imp, manu, scottph.
Tue, Feb 23, 9:30 PM
allanjude committed R10:d2589dc3d56c: ipmi_smbios: remove unused smbios_cksum function (authored by allanjude).
ipmi_smbios: remove unused smbios_cksum function
Tue, Feb 23, 9:25 PM
allanjude closed D28751: ipmi_smbios: remove unused smbios_cksum function.
Tue, Feb 23, 9:25 PM
allanjude committed R10:ba6e37e47f41: ipmi_smbios: Deduplicate smbios entry point discovery logic (authored by allanjude).
ipmi_smbios: Deduplicate smbios entry point discovery logic
Tue, Feb 23, 9:20 PM
allanjude committed R10:d0673fe160b0: smbios: Move smbios driver out from x86 machdep code (authored by allanjude).
smbios: Move smbios driver out from x86 machdep code
Tue, Feb 23, 9:20 PM
allanjude closed D28743: ipmi_smbios: Deduplicate smbios entry point discovery logic.
Tue, Feb 23, 9:20 PM
allanjude closed D28738: smbios: Move smbios driver out from x86 machdep code.
Tue, Feb 23, 9:20 PM
allanjude closed D28742: iicsmb: Request the bus recursively in bread().
Tue, Feb 23, 8:08 PM
allanjude committed R10:11ba8488b863: iicsmb: Request the bus recursively in bread() (authored by allanjude).
iicsmb: Request the bus recursively in bread()
Tue, Feb 23, 8:08 PM

Sat, Feb 20

allanjude added a comment to D24423: arm/pmu: add ACPI attachment, more FDT names.

I tested this recently on an ARM64 ACPI box, and ran into a panic at boot:

pmu0: <Performance Monitoring Unit> on acpi0
pmu0: MADT: cpu 0 (mpidr 1179648) irq 23 level-triggered
pmu0: MADT: cpu 1 (mpidr 1703936) irq 23 level-triggered
pmu0: MADT: cpu 2 (mpidr 1310720) irq 23 level-triggered
pmu0: MADT: cpu 3 (mpidr 1835008) irq 23 level-triggered
pmu0: MADT: cpu 4 (mpidr 1048576) irq 23 level-triggered
pmu0: MADT: cpu 5 (mpidr 1572864) irq 23 level-triggered
pmu0: MADT: cpu 6 (mpidr 1441792) irq 23 level-triggered
pmu0: MADT: cpu 7 (mpidr 1966080) irq 23 level-triggered
pmu0: MADT: cpu 8 (mpidr 655360) irq 23 level-triggered
pmu0: MADT: cpu 9 (mpidr 2228224) irq 23 level-triggered
pmu0: MADT: cpu 10 (mpidr 786432) irq 23 level-triggered
pmu0: MADT: cpu 11 (mpidr 2359296) irq 23 level-triggered
pmu0: MADT: cpu 12 (mpidr 524288) irq 23 level-triggered
pmu0: MADT: cpu 13 (mpidr 2097152) irq 23 level-triggered
Fatal data abort:
  x0:                0
  x1: ffffa0001d8103a8
  x2:                0
  x3:                a
  x4: ffff000000721fc0
  x5:               10
  x6:                f
  x7:              254
  x8: ffffa0001d80fe00
  x9: ffff000000aad928
 x10:                1
 x11:                0
 x12:                0
 x13:                4
 x14:               80
 x15:                1
 x16:              700
 x17:                3
 x18: ffff000000f277e0
 x19: ffff000000f27870
 x20: ffff0002023fd43c
 x21:                d
 x22: ffffa0001d80fe00
 x23: ffffa0001d80bc00
 x24:               17
 x25: ffff000000823cd6
 x26: ffffa0001d80bb00
 x27: ffffa0001d805af0
 x28:                1
 x29: ffff000000f277f0
  sp: ffff000000f277e0
  lr: ffff000000720860
 elr: ffff000000720888
spsr:         604001c5
 far:                0
 esr:         96000004
panic: vm_fault failed: ffff000000720888
cpuid = 0
time = 1
KDB: stack backtrace:
db_trace_self() at db_trace_self
db_trace_self_wrapper() at db_trace_self_wrapper+0x30
vpanic() at vpanic+0x184
panic() at panic+0x44
data_abort() at data_abort+0x1d8
handle_el1h_sync() at handle_el1h_sync+0x74
--- exception, esr 0x96000004
madt_handler() at madt_handler+0xe8
acpi_walk_subtables() at acpi_walk_subtables+0x3c
pmu_acpi_attach() at pmu_acpi_attach+0x64
device_attach() at device_attach+0x400
bus_generic_new_pass() at bus_generic_new_pass+0x11c
bus_generic_new_pass() at bus_generic_new_pass+0xac
bus_generic_new_pass() at bus_generic_new_pass+0xac
root_bus_configure() at root_bus_configure+0x40
mi_startup() at mi_startup+0x22c
virtdone() at virtdone+0x6c
KDB: enter: panic
[ thread pid 0 tid 100000 ]
Stopped at      kdb_enter+0x40: undefined       d4200000
Sat, Feb 20, 4:22 AM · arm64

Fri, Feb 19

allanjude created P484 update ESP.
Fri, Feb 19, 10:26 PM
allanjude committed R10:57d2eb8896c2: Use iflib_if_init_locked() during media change instead of iflib_init_locked(). (authored by allanjude).
Use iflib_if_init_locked() during media change instead of iflib_init_locked().
Fri, Feb 19, 9:07 PM
allanjude committed R10:18f552e647f5: Use iflib_if_init_locked() during media change instead of iflib_init_locked(). (authored by allanjude).
Use iflib_if_init_locked() during media change instead of iflib_init_locked().
Fri, Feb 19, 8:44 PM

Thu, Feb 18

allanjude added a reviewer for D28748: ig4(4): Use calculated value when sda_hold is zero in ACPI: scottph.
Thu, Feb 18, 3:53 PM
allanjude closed D28749: ipmi_ssif: Fix inverted for the end of multi-part reads.
Thu, Feb 18, 3:51 PM
allanjude committed R10:8c280db0b4d2: ipmi_ssif: Fix inverted for the end of multi-part reads (authored by allanjude).
ipmi_ssif: Fix inverted for the end of multi-part reads
Thu, Feb 18, 3:51 PM
allanjude closed D28747: ig4(4): Increase timeout to about 1 second.
Thu, Feb 18, 3:51 PM
allanjude committed R10:37ef8d4cd6b5: ig4(4): Increase timeout to about 1 second (authored by allanjude).
ig4(4): Increase timeout to about 1 second
Thu, Feb 18, 3:51 PM
allanjude added a comment to D28738: smbios: Move smbios driver out from x86 machdep code.

If the intention is to support smbios(4) on non-x86, shouldn't it be added to a non-x86 KERNCONF file?

Thu, Feb 18, 3:41 PM
allanjude added a comment to D28749: ipmi_ssif: Fix inverted for the end of multi-part reads.

Do we want to put this link and section reference in the commit message?

Thu, Feb 18, 1:47 AM

Wed, Feb 17

allanjude added a comment to D28749: ipmi_ssif: Fix inverted for the end of multi-part reads.
In D28749#643720, @manu wrote:

Any docs on what this should contain ?

Wed, Feb 17, 11:01 PM
allanjude added a reviewer for D28749: ipmi_ssif: Fix inverted for the end of multi-part reads: scottph.
Wed, Feb 17, 11:01 PM
allanjude added a comment to D28707: Fix attachment of IPMI driver on ARM64.
In D28707#643461, @imp wrote:

We also have a machine here that won't boot with the patches applied. Please don't commit until that gets worked out....

Wed, Feb 17, 10:01 PM
allanjude added a comment to D28738: smbios: Move smbios driver out from x86 machdep code.

Should https://reviews.freebsd.org/D28745 be squashed into this review?

Wed, Feb 17, 9:47 PM
allanjude added a comment to D28745: ipmi: Add smbus and pci ipmi types to aarch64 builds.

It likely makes sense to squash this with https://reviews.freebsd.org/D28738

Wed, Feb 17, 9:47 PM
allanjude added reviewers for D28747: ig4(4): Increase timeout to about 1 second: manu, scottph, andrew.
Wed, Feb 17, 9:45 PM
allanjude added reviewers for D28746: ig4(4): Add an EMAG device type: scottph, imp.
Wed, Feb 17, 9:45 PM
allanjude added inline comments to D28746: ig4(4): Add an EMAG device type.
Wed, Feb 17, 9:45 PM
allanjude added inline comments to D28741: acpi: Add workaround for Altra I2C memory resource.
Wed, Feb 17, 9:44 PM
allanjude added reviewers for D28741: acpi: Add workaround for Altra I2C memory resource: scottph, imp.
Wed, Feb 17, 9:43 PM
allanjude added reviewers for D28738: smbios: Move smbios driver out from x86 machdep code: emaste, scottph, mhorne.
Wed, Feb 17, 9:41 PM
allanjude added inline comments to D28737: stand: Support (and prefer) the SMBIOS 64-bit Entry Point Structure.
Wed, Feb 17, 9:41 PM
allanjude added reviewers for D28737: stand: Support (and prefer) the SMBIOS 64-bit Entry Point Structure: tsoome, manu, andrew, scottph.
Wed, Feb 17, 9:39 PM
allanjude added a comment to D28707: Fix attachment of IPMI driver on ARM64.

Ok, I think I've gotten a handle on the git-arc tool.

Wed, Feb 17, 9:38 PM
allanjude requested review of D28751: ipmi_smbios: remove unused smbios_cksum function.
Wed, Feb 17, 9:36 PM
allanjude requested review of D28750: ipmi: on aarch64, load dependancies to increase chance of finding ipmi device.
Wed, Feb 17, 9:35 PM
allanjude requested review of D28749: ipmi_ssif: Fix inverted for the end of multi-part reads.
Wed, Feb 17, 9:35 PM
allanjude requested review of D28748: ig4(4): Use calculated value when sda_hold is zero in ACPI.
Wed, Feb 17, 9:35 PM
allanjude requested review of D28747: ig4(4): Increase timeout to about 1 second.
Wed, Feb 17, 9:35 PM
allanjude requested review of D28746: ig4(4): Add an EMAG device type.
Wed, Feb 17, 9:35 PM
allanjude requested review of D28745: ipmi: Add smbus and pci ipmi types to aarch64 builds.
Wed, Feb 17, 9:35 PM
allanjude requested review of D28744: Enable smbios in ARM64 GENERIC.
Wed, Feb 17, 9:35 PM
allanjude added a comment to D28707: Fix attachment of IPMI driver on ARM64.

No, having only one loop that set both kenv is what we need.

Wed, Feb 17, 9:35 PM
allanjude requested review of D28743: ipmi_smbios: Deduplicate smbios entry point discovery logic.
Wed, Feb 17, 9:35 PM
allanjude requested review of D28742: iicsmb: Request the bus recursively in bread().
Wed, Feb 17, 9:35 PM
allanjude requested review of D28741: acpi: Add workaround for Altra I2C memory resource.
Wed, Feb 17, 9:35 PM
allanjude requested review of D28739: smbios: Support (and prefer) the SMBIOS 64-bit Entry Point Structure.
Wed, Feb 17, 9:35 PM
allanjude requested review of D28740: smbios: Use loader provided address for SMBIOS entry point.
Wed, Feb 17, 9:35 PM
allanjude requested review of D28738: smbios: Move smbios driver out from x86 machdep code.
Wed, Feb 17, 9:35 PM
allanjude requested review of D28737: stand: Support (and prefer) the SMBIOS 64-bit Entry Point Structure.
Wed, Feb 17, 9:35 PM
allanjude added a comment to D28707: Fix attachment of IPMI driver on ARM64.

@allanjude these originated as a number of commits, right? Does it make sense to start committing earlier patches that have been reviewed (e.g. stand bits) and rebase this review?

Wed, Feb 17, 9:00 PM
allanjude added a comment to D28707: Fix attachment of IPMI driver on ARM64.
In D28707#643382, @manu wrote:
In D28707#643373, @manu wrote:

stand patches can't go in without the kernel ones.
If we find a smbios v3 table we don't set the kenv of the v2.1 one so kernel won't work.

Ou, but that would be major pain - it would be bad day for anyone trying to boot older kernel... so we should provide both to let older kernel to work?

Yeah I think so, I think we should just export every smbios table in loader and let kernel choose.

Wed, Feb 17, 8:59 PM

Tue, Feb 16

allanjude updated the diff for D28707: Fix attachment of IPMI driver on ARM64.

Repost

Tue, Feb 16, 10:36 PM
allanjude added inline comments to D28707: Fix attachment of IPMI driver on ARM64.
Tue, Feb 16, 10:35 PM
allanjude updated the diff for D28707: Fix attachment of IPMI driver on ARM64.
  • stand: Support (and prefer) the SMBIOS 64-bit Entry Point Structure
  • smbios: Move smbios driver out from x86 machdep code
  • smbios: Support (and prefer) the SMBIOS 64-bit Entry Point Structure
  • smbios: Use loader provided adddress for SMBIOS entry point
  • acpi: Add workaround for Altra I2C memory resource
  • iicsmb: Request the bus recursively in bread()
  • ipmi_smbios: Deduplicate smbios entry point discovery logic
  • Enable smbios in ARM64 GENERIC
  • ipmi: Add smbus and pci ipmi types to aarch64 build
  • ig4(4): Add an EMAG device type
  • ig4(4): Increase timeout to about 1 second
  • ig4(4): Use calculated value when sda_hold is zero in ACPI
  • ipmi_ssif: Fix inverted for the end of multi-part reads
  • smbios: update makefile for new location of smbios.c
  • ipmi: on aarch64, load dependancies to increase chance of finding ipmi device
  • ipmi_smbios: remove unused smbios_cksum function
  • [squashme] Address feedback from manu and andrew
Tue, Feb 16, 10:33 PM
allanjude closed D28667: Use iflib_if_init_locked() during media change instead of iflib_init_locked()..
Tue, Feb 16, 7:03 PM
allanjude committed R10:922cf8ac43ad: Use iflib_if_init_locked() during media change instead of iflib_init_locked(). (authored by allanjude).
Use iflib_if_init_locked() during media change instead of iflib_init_locked().
Tue, Feb 16, 7:02 PM
allanjude added inline comments to D28707: Fix attachment of IPMI driver on ARM64.
Tue, Feb 16, 6:33 PM
allanjude added a reviewer for D28707: Fix attachment of IPMI driver on ARM64: gallatin.
Tue, Feb 16, 5:07 PM
allanjude requested review of D28707: Fix attachment of IPMI driver on ARM64.
Tue, Feb 16, 5:06 PM
allanjude updated subscribers of D27813: camcontrol: stop pretending cam_cmd is a bitmask.
Tue, Feb 16, 4:12 PM

Sun, Feb 14

allanjude committed R9:873687264f6c: The RSS feed for news was missing the # in the URL, resulting in 404s (authored by allanjude).
The RSS feed for news was missing the # in the URL, resulting in 404s
Sun, Feb 14, 7:00 PM
allanjude updated the summary of D28667: Use iflib_if_init_locked() during media change instead of iflib_init_locked()..
Sun, Feb 14, 6:50 PM
allanjude requested review of D28667: Use iflib_if_init_locked() during media change instead of iflib_init_locked()..
Sun, Feb 14, 6:47 PM

Tue, Feb 2

allanjude committed R9:9374bec4869a: bsdinstall: Fix corrupted table (authored by allanjude).
bsdinstall: Fix corrupted table
Tue, Feb 2, 6:01 AM

Mon, Feb 1

allanjude committed R9:a4b277251661: Fix broken link to the BSD family tree in the FAQ (authored by allanjude).
Fix broken link to the BSD family tree in the FAQ
Mon, Feb 1, 1:20 AM
allanjude closed D28440: Improve the documentation front page with book/article names.
Mon, Feb 1, 1:10 AM
allanjude committed R9:bc185da8de51: Improve the documentation front page with full book/article names (authored by allanjude).
Improve the documentation front page with full book/article names
Mon, Feb 1, 1:10 AM

Sun, Jan 31

allanjude requested review of D28440: Improve the documentation front page with book/article names.
Sun, Jan 31, 7:44 PM

Fri, Jan 29

allanjude committed R9:e20bb4a200ea: Remove the sort-by-date on the advisories/errata pages (authored by allanjude).
Remove the sort-by-date on the advisories/errata pages
Fri, Jan 29, 8:15 PM

Thu, Jan 28

allanjude committed R10:e6b7809cdfc4: Flip the default for OPENSSL_KTLS to arm64 (authored by allanjude).
Flip the default for OPENSSL_KTLS to arm64
Thu, Jan 28, 9:36 PM
allanjude committed R10:b1f1917de48b: Regenerate src.conf.5 after enabling MK_OPENSSL_KTLS for arm64 (authored by allanjude).
Regenerate src.conf.5 after enabling MK_OPENSSL_KTLS for arm64
Thu, Jan 28, 9:36 PM
allanjude closed D28405: Flip the default for OPENSSL_KTLS to arm64.
Thu, Jan 28, 9:36 PM
allanjude requested review of D28405: Flip the default for OPENSSL_KTLS to arm64.
Thu, Jan 28, 9:19 PM
allanjude committed R10:f9322ff6efa5: Enable KERN_TLS by default in ARM64 GENERIC (authored by allanjude).
Enable KERN_TLS by default in ARM64 GENERIC
Thu, Jan 28, 8:51 PM

Tue, Jan 26

allanjude requested review of D28358: Improve the column widths of various pages in the FDP.
Tue, Jan 26, 6:05 PM
allanjude raised a concern with R9:42b64a1521a3: Fix links in the main page..
Tue, Jan 26, 3:08 PM
allanjude requested review of D28344: Use Hugo's relLangURL filter to fix relative URLs in list shortdocs.
Tue, Jan 26, 4:10 AM
allanjude committed R9:ca50c35a68ea: Add a missing space to unbreak rendering of chapters-order sub-heading (authored by allanjude).
Add a missing space to unbreak rendering of chapters-order sub-heading
Tue, Jan 26, 3:42 AM

Jan 21 2021

allanjude added a comment to D28247: Introduce SIOCGIFDNAME to get the interface device name.
In D28247#632482, @kp wrote:

I don't think it's a string length issue.

Jan 21 2021, 8:41 PM
allanjude added a comment to D28247: Introduce SIOCGIFDNAME to get the interface device name.
In D28247#632482, @kp wrote:

I don't think it's a string length issue. It's an issue of incorrect assumptions. This patch assumes that the original name of the interface is always the driver name ('if_dname') plus unit number. That's not the case for epair interfaces, and I wouldn't be surprised that this also fails for vlan interfaces (where the numeric suffix is not the unit number).

Jan 21 2021, 8:39 PM
allanjude committed R10:e6d795d15469: Fix manpage markup in 2c8bb126de56ce49637ad752e78957d9ebafba02 (authored by allanjude).
Fix manpage markup in 2c8bb126de56ce49637ad752e78957d9ebafba02
Jan 21 2021, 8:33 PM
allanjude closed D28272: bhyve: Add missing man page section on the nodelete block-device-option.
Jan 21 2021, 8:31 PM
allanjude committed R10:2c8bb126de56: bhyve: Add missing man page section on the nodelete block-device-option (authored by allanjude).
bhyve: Add missing man page section on the nodelete block-device-option
Jan 21 2021, 8:31 PM
allanjude closed D28245: ifconfig: add vlanproto "qiniq" as an alias for "802.1ad".

Committed as R10:b84d0aaa4e64

Jan 21 2021, 5:58 PM
allanjude requested review of D28272: bhyve: Add missing man page section on the nodelete block-device-option.
Jan 21 2021, 5:19 PM
allanjude added a comment to D28247: Introduce SIOCGIFDNAME to get the interface device name.
In D28247#632273, @kp wrote:

It turns out there's an edge case we didn't consider:

epair0a: flags=8842<BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        initname: epair0
        options=8<VLAN_MTU>
        ether 02:a5:17:a0:1e:0a
        groups: epair
        media: Ethernet 10Gbase-T (10Gbase-T <full-duplex>)
        status: active
        nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>

Also, this wants a test case or two.

Jan 21 2021, 3:39 PM