Page MenuHomeFreeBSD

allanjude (Allan Jude)
UserAdministrator

Projects (6)

User Details

User Since
May 19 2014, 3:05 PM (315 w, 1 d)
Roles
Administrator

Recent Activity

Today

allanjude added a comment to D25103: zfsbootcfg: use vfs.root.mountfrom and update nextboot on every vdev.

As we progress here, we will want a switch to maintain the legacy behaviour, at least for a while. We might even decide not to change the default right away.

Tue, Jun 2, 6:31 PM
allanjude added inline comments to D25103: zfsbootcfg: use vfs.root.mountfrom and update nextboot on every vdev.
Tue, Jun 2, 6:23 PM

Wed, May 27

allanjude reopened D12127: handbook: fix various formatting issues in ZFS chapter.
Wed, May 27, 2:45 AM

Thu, May 21

allanjude accepted D24920: zfs: add to bootloader option to rewind the ZFS checkpoint..

Reviewed By: allanjude

Thu, May 21, 1:45 AM

Wed, May 20

allanjude accepted D23641: Fix indentation in bsdinstall-created wpa_supplicant.conf.

Reviewed By: allanjude

Wed, May 20, 9:06 PM
allanjude added reviewers for D24920: zfs: add to bootloader option to rewind the ZFS checkpoint.: tsoome, kevans.
Wed, May 20, 5:51 PM

Fri, May 15

allanjude added a comment to D24790: libalias: retire cuseeme support.

Yeah, in general the FTP one might still be in use, but pretty much every FTP server supports passive mode now, so I don't know how often the FTP module is useful.

Fri, May 15, 3:13 PM

Thu, May 14

allanjude accepted D24805: liblzma: Make liblzma use libmd implementation of SHA256..

Thanks for cleaning this up, as noted in rS292782 the libmd version was optimized by cperciva@

Thu, May 14, 9:13 PM
allanjude accepted D24790: libalias: retire cuseeme support.

Removing any surface area we can seems like a good idea

Thu, May 14, 8:50 PM

Sun, May 10

allanjude accepted D24799: Retire idle commit bits for dexuan and leitao.

Approved

Sun, May 10, 5:40 PM

Tue, May 5

allanjude accepted D24692: Add my pgp key, sort keys alphabetically, and tend to igory issues..

Approved By: allanjude

Tue, May 5, 5:07 PM

May 2 2020

allanjude committed rP533692: Fix distinfo for www/varnish-libvmod-digest.
Fix distinfo for www/varnish-libvmod-digest
May 2 2020, 3:34 PM

May 1 2020

allanjude closed D24643: Bring libvmod-maxminddb back from the dead.

Committed as rP533560 not sure why it did not close properly.

May 1 2020, 4:58 PM
allanjude committed rP533560: Restore www/varnish-libvmod-maxminddb.
Restore www/varnish-libvmod-maxminddb
May 1 2020, 4:48 PM
allanjude updated the diff for D24643: Bring libvmod-maxminddb back from the dead.

Update version
Apply tricks learned from last nights review

May 1 2020, 2:18 PM
allanjude committed rP533490: Update www/varnish-libvmod-digest to 1.0.2.
Update www/varnish-libvmod-digest to 1.0.2
May 1 2020, 4:04 AM
allanjude closed D24642: Update libvmod-digest to 1.0.2 + unreleased patches.
May 1 2020, 4:04 AM
allanjude updated the diff for D24642: Update libvmod-digest to 1.0.2 + unreleased patches.

Sync with jrm's suggestions

May 1 2020, 4:03 AM
allanjude updated the diff for D24642: Update libvmod-digest to 1.0.2 + unreleased patches.

Force use of varnish6

May 1 2020, 2:39 AM
allanjude updated the diff for D24642: Update libvmod-digest to 1.0.2 + unreleased patches.

Apply suggested changes from jrm

May 1 2020, 2:25 AM
allanjude added inline comments to D24642: Update libvmod-digest to 1.0.2 + unreleased patches.
May 1 2020, 2:05 AM

Apr 30 2020

allanjude requested review of D24643: Bring libvmod-maxminddb back from the dead.
Apr 30 2020, 10:04 PM
allanjude requested review of D24642: Update libvmod-digest to 1.0.2 + unreleased patches.
Apr 30 2020, 10:00 PM
allanjude added reviewers for D23572: Update OpenBSM constants with recent additions by Apple: kevans, csjp.
Apr 30 2020, 9:49 PM
allanjude accepted D24640: bsdinstall: do a `certctl rehash` upon installation of configuration.

This looks good to me. Although I wonder if we might not want a solution that also covers people who don't run the installer. So that things like the VM Images that are generated by the release have the certs setup

Apr 30 2020, 6:22 PM

Apr 28 2020

allanjude accepted D24246: Add a timeline for unmentoring..
Apr 28 2020, 6:16 PM
allanjude added inline comments to D24321: Style revisions, accessibility enhancements, and ports statistics updates.
Apr 28 2020, 2:33 AM
allanjude committed rD54079: Update FAQ entries 10.21 and 10.22.
Update FAQ entries 10.21 and 10.22
Apr 28 2020, 2:29 AM
allanjude closed D24486: Update FAQs 10.21 and 10.22.
Apr 28 2020, 2:29 AM
allanjude accepted D24486: Update FAQs 10.21 and 10.22.
Apr 28 2020, 2:26 AM

Apr 27 2020

allanjude committed rS360389: Update for 2020.
Update for 2020
Apr 27 2020, 6:08 PM
allanjude accepted D24590: WWW: fix search.

I think having them all is fine

Apr 27 2020, 4:43 PM

Apr 24 2020

allanjude accepted D21805: freebsd-update: rehash certs.

With DESTDIR support in certctl now, this looks good to me

Apr 24 2020, 5:27 PM

Apr 23 2020

allanjude committed rS360230: trim(8): candelete() returns wrong results because fd is opened O_WRONLY.
trim(8): candelete() returns wrong results because fd is opened O_WRONLY
Apr 23 2020, 8:15 PM
allanjude closed D24371: trim(8): candelete() returns wrong results because fd is opened O_WRONLY.
Apr 23 2020, 8:15 PM
allanjude committed rS360229: Add VIRTIO_BLK_T_DISCARD (TRIM) support to the bhyve virtio-blk backend.
Add VIRTIO_BLK_T_DISCARD (TRIM) support to the bhyve virtio-blk backend
Apr 23 2020, 7:21 PM
allanjude closed D21707: Add VIRTIO_BLK_T_DISCARD (TRIM) support to the bhyve virtio-blk backend.
Apr 23 2020, 7:21 PM
allanjude updated the diff for D21707: Add VIRTIO_BLK_T_DISCARD (TRIM) support to the bhyve virtio-blk backend.

Move copyright message to the correct place

Apr 23 2020, 5:00 PM

Apr 14 2020

allanjude added a comment to D24417: stats(7): Add a man-page with list of stat utilities..

Not sure if ministat belongs on the list. It is more for doing statistical analysis, it doesn't actually give you any stats/status about your system

Apr 14 2020, 3:42 PM

Apr 13 2020

allanjude updated the summary of D24402: Write packages directory to ${PKGREPOSITORY} rather than ${WRKDIR}/pkg.
Apr 13 2020, 8:16 PM
allanjude created D24402: Write packages directory to ${PKGREPOSITORY} rather than ${WRKDIR}/pkg.
Apr 13 2020, 8:16 PM

Apr 12 2020

allanjude committed rD54053: Fix typo.
Fix typo
Apr 12 2020, 11:08 PM
allanjude updated the diff for D21708: Add VIRTIO_BLK_T_DISCARD support to the virtio-blk driver.

Fix typo

Apr 12 2020, 5:32 AM
allanjude added inline comments to D21708: Add VIRTIO_BLK_T_DISCARD support to the virtio-blk driver.
Apr 12 2020, 5:30 AM
allanjude updated the diff for D21708: Add VIRTIO_BLK_T_DISCARD support to the virtio-blk driver.

Address most of cem's feedback

Apr 12 2020, 5:30 AM
allanjude added a comment to D24371: trim(8): candelete() returns wrong results because fd is opened O_WRONLY.

I'm not sure I understand the problem.

The candelete() function does properly detect if the disk supports TRIM

Does or does not? Anyway, it works for me just fine using stable/11 system:

mdconfig -at malloc -s 1m

md0

  1. diskinfo -v md0 | grep TRIM Yes # TRIM/UNMAP support
  2. trim -f /dev/md0; echo $?

trim /dev/md0 offset 0 length 1048576
0

The function candelete() was copied from diskinfo(8) code as noted in the commit message. The diskinfo utility opens the device with O_RDONLY, too. It all was tested before committing.

Apr 12 2020, 3:32 AM
allanjude added a comment to D24371: trim(8): candelete() returns wrong results because fd is opened O_WRONLY.

The change LGTM, but double check your commit message. Is there a missing "not"?

Apr 12 2020, 3:30 AM
allanjude updated the summary of D24371: trim(8): candelete() returns wrong results because fd is opened O_WRONLY.
Apr 12 2020, 3:30 AM

Apr 11 2020

allanjude updated the diff for D21708: Add VIRTIO_BLK_T_DISCARD support to the virtio-blk driver.

Update to fix some issues and catch up with HEAD

Apr 11 2020, 9:26 PM
allanjude created D24371: trim(8): candelete() returns wrong results because fd is opened O_WRONLY.
Apr 11 2020, 3:19 PM

Apr 10 2020

allanjude updated the diff for D21707: Add VIRTIO_BLK_T_DISCARD (TRIM) support to the bhyve virtio-blk backend.

Add VIRTIO_BLK_T_DISCARD (TRIM) support to the bhyve virtio-blk backend

Apr 10 2020, 7:31 PM

Apr 3 2020

allanjude committed rD54032: Add the second FreeBSD Office Hours.
Add the second FreeBSD Office Hours
Apr 3 2020, 3:51 AM

Mar 31 2020

allanjude accepted D24246: Add a timeline for unmentoring..
Mar 31 2020, 11:35 PM
allanjude committed rD54025: Add Wednesday's "FreeBSD Office Hours" event to the front page.
Add Wednesday's "FreeBSD Office Hours" event to the front page
Mar 31 2020, 1:15 AM

Mar 30 2020

allanjude accepted D24225: Save 7k of text space by using simpler crc32 for standalone case..

This seems like a good way to cut down the size

Mar 30 2020, 5:36 PM

Mar 16 2020

allanjude accepted D24068: loader: remove libsa/crc32.c and use version from zlib.

Reviewed By: allanjude

Mar 16 2020, 8:28 PM

Mar 12 2020

allanjude added a reviewer for D23911: sshd: Warn about missing ssh-keygen only when necessary: emaste.
Mar 12 2020, 8:24 PM

Mar 11 2020

allanjude added a comment to D21892: freebsd-update: create a ZFS boot environment on install if the system supports it.

ping: Is there anything left for Dave to do here, or can we commit this?

Mar 11 2020, 8:25 PM
allanjude added a comment to D21805: freebsd-update: rehash certs.

Is this stalled?

Mar 11 2020, 8:24 PM

Mar 8 2020

allanjude renamed harrison-astrodog.net from harrison.grundy-astrodoggroup.com to harrison-astrodog.net.
Mar 8 2020, 4:32 PM

Feb 22 2020

allanjude accepted D23792: Add 'ctld -t'..

Reviewed By: allanjude

Feb 22 2020, 7:50 PM

Jan 31 2020

allanjude added a reviewer for D18908: Added SOCKS5 support to libfetch: trasz.
Jan 31 2020, 11:08 PM

Jan 28 2020

allanjude added reviewers for D23387: geli taste: allow GELIBOOT tagged providers as well: pjd, oshogbo.
Jan 28 2020, 1:00 AM

Jan 15 2020

allanjude committed rD53783: Add a link to the FreeBSD Papers site from the /docs page.
Add a link to the FreeBSD Papers site from the /docs page
Jan 15 2020, 11:18 PM

Jan 14 2020

allanjude accepted D22306: zfs: add option for forcible unmounting dataset while receiving snapshot..

Reviewed by: allanjude

Jan 14 2020, 5:59 PM

Jan 13 2020

allanjude accepted D22706: Add per-FIB gateway support to rc.d/routing.
Jan 13 2020, 11:52 PM

Dec 12 2019

allanjude accepted D22567: Add 'sesutil show'.

Reviewed By: allanjude

Dec 12 2019, 1:36 PM

Dec 9 2019

allanjude accepted D22733: pfctl: Warn users when they run into kernel limits.

Reviewed By: allanjude

Dec 9 2019, 6:08 AM

Dec 4 2019

allanjude accepted D21324: Add stats(3) support to nc(1).
Dec 4 2019, 3:05 PM

Nov 29 2019

allanjude added inline comments to D21324: Add stats(3) support to nc(1).
Nov 29 2019, 12:11 AM

Nov 28 2019

allanjude added inline comments to D22567: Add 'sesutil show'.
Nov 28 2019, 3:34 AM
allanjude added inline comments to D22567: Add 'sesutil show'.
Nov 28 2019, 3:20 AM
allanjude added a comment to D22567: Add 'sesutil show'.

I wonder if it would make sense to try to stripe the trailing whitespace from the serial # etc. The json output looks a little silly:

Nov 28 2019, 3:11 AM
allanjude accepted D22585: Limit openfiles-cur to 1024.

Reviewed by: allanjude

Nov 28 2019, 3:09 AM

Nov 27 2019

allanjude added reviewers for D22567: Add 'sesutil show': mav, bapt.
Nov 27 2019, 5:32 PM

Nov 25 2019

allanjude accepted D22323: 2019Q3 Quarterly status report.

Reviewed By: allanjude

Nov 25 2019, 7:12 PM

Nov 22 2019

allanjude added a comment to D22193: Add kern.geom.part.separator..

FWIW, grepping for that pattern only brings up the one hit Warner has already mentioned, and it's already under #ifdef illumos:

% grep -r '%ss%d' *
cddl/contrib/opensolaris/cmd/zpool/zpool_vdev.c:                (void) snprintf(buf, sizeof (buf), "%ss%d", path, slice);
Nov 22 2019, 1:59 PM

Nov 19 2019

allanjude added inline comments to D22306: zfs: add option for forcible unmounting dataset while receiving snapshot..
Nov 19 2019, 4:00 PM

Nov 15 2019

allanjude added inline comments to D22323: 2019Q3 Quarterly status report.
Nov 15 2019, 9:14 PM
allanjude added inline comments to D22323: 2019Q3 Quarterly status report.
Nov 15 2019, 8:36 PM

Nov 13 2019

allanjude accepted D22322: Conduct/reporting split.

I am fine with moving the text, just make sure you svn commit the correct files

Nov 13 2019, 10:24 PM

Nov 12 2019

allanjude added a comment to D22304: gnop: add the option for adding a suffix to the name of the device.

Why don't we just have a "name" parameter that determines the entire gnop provider name?

Nov 12 2019, 5:28 AM
allanjude added a comment to D22322: Conduct/reporting split.

it looks like you added conduct-reporting.html (the build artifact) not .xml (the source), and that it was not marked as a text file.

Nov 12 2019, 5:24 AM

Nov 8 2019

allanjude accepted D22249: Show HBA path in 'diskinfo -v'..

Maybe give Warner a chance to provide any more feedback before we commit this.

Nov 8 2019, 7:38 PM
allanjude added inline comments to D22193: Add kern.geom.part.separator..
Nov 8 2019, 7:06 PM

Nov 7 2019

allanjude accepted D22249: Show HBA path in 'diskinfo -v'..

Attachment does seem to fit the bill best

Nov 7 2019, 5:04 PM
allanjude added a reviewer for D20655: Make use of stats(3) in the TCP stack: pkelsey.
Nov 7 2019, 4:53 PM
allanjude accepted D22185: Fix vmstat(8) output.

Reviewed By: allanjude

Nov 7 2019, 4:53 PM

Nov 1 2019

allanjude added a comment to D22193: Add kern.geom.part.separator..
In D22193#485070, @imp wrote:
/*
  * Fill in the devid, now that we've labeled the disk.
  */
 (void) snprintf(buf, sizeof (buf), "%ss%d", path, slice);
 if ((fd = open(buf, O_RDONLY)) < 0) {
         (void) fprintf(stderr,
             gettext("cannot open '%s': %s\n"),
             buf, strerror(errno));
         return (-1);
 }

is one example, this one is from cddl/contrib/opensolaris/cmd/zpool/zpool_vdev.c

Nov 1 2019, 10:20 PM
allanjude added inline comments to D22185: Fix vmstat(8) output.
Nov 1 2019, 10:17 PM

Oct 30 2019

allanjude added a comment to D22193: Add kern.geom.part.separator..

Is the 'd' or 'c' in the description a typo? Should it be ada0d/s1? or ada0/s1

Oct 30 2019, 4:58 PM

Oct 23 2019

allanjude added inline comments to D20656: Add new port: net/tcprtt: reliably measure the TCP handshake round trip time using stats(9).
Oct 23 2019, 9:19 PM

Oct 11 2019

allanjude accepted D21895: MFZol: Fix performance of "zfs recv" with many deletions.

Reviewed By: allanjude

Oct 11 2019, 2:54 PM
allanjude added a reviewer for D21895: MFZol: Fix performance of "zfs recv" with many deletions: ZFS.
Oct 11 2019, 2:52 PM

Oct 3 2019

allanjude added inline comments to D21892: freebsd-update: create a ZFS boot environment on install if the system supports it.
Oct 3 2019, 11:05 PM

Oct 2 2019

allanjude added inline comments to D20655: Make use of stats(3) in the TCP stack.
Oct 2 2019, 4:14 PM

Sep 19 2019

allanjude closed D21361: sys/vm/vm_glue.c: Incorrect function name in panic string..

Committed as rS352504

Sep 19 2019, 7:29 AM
allanjude committed rS352504: sys/vm/vm_glue.c: Incorrect function name in panic string.
sys/vm/vm_glue.c: Incorrect function name in panic string
Sep 19 2019, 7:28 AM

Sep 18 2019

allanjude created D21708: Add VIRTIO_BLK_T_DISCARD support to the virtio-blk driver.
Sep 18 2019, 7:24 PM
allanjude created D21707: Add VIRTIO_BLK_T_DISCARD (TRIM) support to the bhyve virtio-blk backend.
Sep 18 2019, 7:19 PM