I might reverse the order of these, since loading the module is the recommended action, and compiling it into your kernel is for people who want to do custom kernels.

In D20477#443980, @cem wrote:

So like, what's the motivation of this change? What are the goals? How was this design chosen? There's 6000 lines of diff present as a fait accompli without any kind of socialization on arch@ or anywhere else. Code is great, but the high level stuff is missing.
Comment density is "low" and copy-paste density is "high." Did you consider templating this, either with awk or C++?
"stats(3)" is a bit misleading; 3900 LoC are a new kernel file. What is the expected consumer? What is the general API surface? Where is the design doc?
Where is the stats(9) manual page? What do stats(3) consumers look like? Will there ever be any in tree? Can this live in ports?

Approved By: allanjude (mentor)

@rgrimes If you want to commandeer this review and put an updated diff, that would be great.

This is a nice cleanup, thank you.

Send it

Approved

Remove the duplicated event (Pedro Giffuni commit bit enhanced)

The description does not seem to match what the code does now.

Need to add opt_tmpfs.h to the tmpfs kernel module Makefile

In D19686#421604, @delphij wrote:

Why is the partition index changed from 1 to 2? (The change looks otherwise fine to me).

Sorry to arrive so late to this review.

I'd also like to see someone else's opinion on making whitespace changes.

Seems like a good fix, and even an optimization.

Focus on non-developers

Thanks for doing the cleanup and adding the ascii-art diagram, that is very helpful.

There should be a better way to get a list of the disks from the pool with the zpool command, but there currently isn't

Thank you.

As a general comment, since IPFW can be loaded as a kernel module now, I'd make that the recommended configuration at the start of the file, and include the 'how to compile a kernel with ipfw in it' at the bottom of the chapter, so as not to send new users off into more complicated configurations for no reason.

Thank you for working on this

Should you remove netdate.c entirely? and remove the prototype from date/extern.h ?

In D18494#394133, @avg wrote:

Unfortunately, I disagree with this change. I think that it is backwards.
illumos has already translated their zfs.1m and zpool.1m to mdoc format, so I assume that that's the direction they are moving in.
I'd rather help them with that in this case as well.
IMO, that would be a better way to overcome the divergence.

Confirmed that this fixes my mlx4en(4) not attaching

Agreed

This is much better.

I think the EFI size should be 200MB or 256MB, rather than 35MB

Yeah, it was just an oversight that we didn't remove this along with bdes back in February 2017.

I am back at home now, so I'll get this refreshed

I am glad to see this progressing again.

Approved By: allanjude

Future note: please upload patches with full context, either using the 'arcanist' tool, or just generate the diff with -U99999 (svn diff -x -U99999)

Approved By: allanjude

Approved By: allanjude