I think something else is going on. Can you try the with and without with 'truss -c' instead of 'time'

I am confused by your results:

In D12339#255993, @cem wrote:

Er, why is rename / renameat with AT_FDCWD not allowed in capability mode?

Resync

Looks good.

Thanks for keeping on top of this

In the future we should do away with the uuencode, and maybe switch to xz (doesn't save any space over bzip, but is one of the only remaining uses of bzip in buildworld)

Hopefully Colin can get a chance to look at this too, but looks good to me now.

If it is going to be on by default, it should be enabled even in the absence of -h when you do geli init. And we need a -H flag for init/label to be able to disable it.

I think it makes more sense to treat it like $NOTTYOK etc, and just make it 0 or 1

We'll need to make sure to note the change in the release notes and the UPDATING file then.

Approved

Fix

I have not had a chance to test this code yet, but reading it over it looks good to me.

Approved

Thank you.

Committed as rS295080

Update with feedback from emaste

In D11471#237195, @emaste wrote:

Do we want to be explicit about being removed from future versions of the FreeBSD base system?

@emaste: Do you want to subsume D9680 into this?

Rebase to -current

Reduce diff against zstd

Lots of cleanup

With this minor fix: https://github.com/allanjude/freebsd/commit/bc4280b8702e3f982cc8624d052125c5b5a3face.diff

If you can address the feedback that is here, and remove the whitespace changes, I think this is ready to land.

Switch from uuencoded bzip to raw xz

I am going to do the uuencode change as well.

ping

Looks good, thank you.

Approved

This has been on my TODO list for a long time, thank you.

This is what I should have done, but I was trying to avoid merge conflicts with stable/11

In D11100#232684, @sbruno wrote:

In D11100#231454, @allanjude wrote:

I think this should go upstream (https://github.com/openzfs/openzfs) but they are happy to have it come from FreeBSD or just be directly to their github.

Huh ... openzfs has their github issue tracker turned off. There doesn't seem to be a bug tracker or direct way of saying "take this code".

You should also change the value for the ZFS Auto mode, which applies to amd64 and arm64:

I think this should go upstream (https://github.com/openzfs/openzfs) but they are happy to have it come from FreeBSD or just be directly to their github.

Looks good to me. What needs to be done for the GELI bits?