Page MenuHomeFreeBSD

allanjude (Allan Jude)
UserAdministrator

Projects (10)

User Details

User Since
May 19 2014, 3:05 PM (522 w, 4 d)
Roles
Administrator

Recent Activity

Today

allanjude abandoned D22444: Add UDP encapsulation of ESP in IPv6.

That was committed as https://reviews.freebsd.org/D42526 / 80044c785cb040a2cf73779d23f9e1e81a00c6c3

Fri, May 24, 6:09 PM
allanjude commandeered D22444: Add UDP encapsulation of ESP in IPv6.
Fri, May 24, 6:08 PM
allanjude accepted D45343: net-mgmt/net-snmp: Print a warning if config files aren't readable.
Fri, May 24, 3:17 PM
allanjude added a reviewer for D45343: net-mgmt/net-snmp: Print a warning if config files aren't readable: 0mp.
Fri, May 24, 3:17 PM
allanjude added a comment to D45317: net-mgmt/net-snmp: Update ownership of snmpd.log.
In D45317#1034152, @dvl wrote:

After reading that, I did some testing:

  • root:wheel yes, it stops logging after HUP.
  • snmpd:snmpd logging contines after HUP.
Fri, May 24, 12:56 AM

Yesterday

allanjude accepted D45329: cross: Move Solaris API64 defines to common.
Thu, May 23, 11:00 PM
allanjude accepted D45317: net-mgmt/net-snmp: Update ownership of snmpd.log.
Thu, May 23, 5:11 PM

Wed, May 22

allanjude accepted D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..

approved by: allanjude (mentor)

Wed, May 22, 11:46 PM
allanjude committed rG207e8cef0b36: ftpd: stop using -g flag for /bin/ls (authored by allanjude).
ftpd: stop using -g flag for /bin/ls
Wed, May 22, 5:19 PM
allanjude committed rGe5fadc41b480: ftpd: stop using -g flag for /bin/ls (authored by allanjude).
ftpd: stop using -g flag for /bin/ls
Wed, May 22, 3:59 PM

Tue, May 21

allanjude committed rGe20971500194: ftpd: stop using -g flag for /bin/ls (authored by allanjude).
ftpd: stop using -g flag for /bin/ls
Tue, May 21, 10:53 PM
allanjude closed D45291: ftpd: stop using -g flag for /bin/ls.
Tue, May 21, 10:53 PM
allanjude updated the summary of D45291: ftpd: stop using -g flag for /bin/ls.
Tue, May 21, 10:52 PM
allanjude updated the diff for D45291: ftpd: stop using -g flag for /bin/ls.

Update commit message as suggested by jrtc27

Tue, May 21, 10:51 PM
allanjude requested review of D45291: ftpd: stop using -g flag for /bin/ls.
Tue, May 21, 10:45 PM

Thu, May 16

allanjude accepted D45219: diff: Warn if the atomizer detected truncation..
Thu, May 16, 1:41 PM
allanjude accepted D45218: libdiff: Add a test for the truncation issue..
Thu, May 16, 1:40 PM
allanjude added a reviewer for D45217: libdiff: Detect and recover from file truncation.: kevans.
Thu, May 16, 1:38 PM

Wed, May 15

allanjude added a comment to D44488: pf: if a new RDR state connect be created, modulate src port.

I've spent some time looking into the underlying problem, and I'm not sure that this approach (quietly rewriting the src port) is correct. The pf.conf manual page says:

In addition to modifying the address, some translation rules may modify
source or destination ports for tcp(4) or udp(4) connections; implicitly
in the case of nat rules and explicitly in the case of rdr rules.  Port
numbers are never translated with a binat rule.

but with this change we are implicitly rewriting the source port. What explicit mechanism is the man page alluding to here?

Wed, May 15, 2:04 PM
allanjude accepted D45209: ifconfig: Markup nits..
Wed, May 15, 12:51 PM

Fri, May 10

allanjude added a member for Klara: oshogbo.
Fri, May 10, 3:14 PM
allanjude removed a member for Klara: thj.
Fri, May 10, 3:14 PM

Wed, May 8

allanjude accepted D45127: bsdinstall: Stop loading cryptodev for ZFS installations.
Wed, May 8, 3:16 PM

Mon, May 6

allanjude accepted D45098: adduser: Fix confusion between `uclass` and `_class`..
Mon, May 6, 1:11 PM
allanjude accepted D45097: pw: Don't silently ignore unparsed command line arguments..
Mon, May 6, 1:06 PM
allanjude accepted D45096: pw: Rename some enums..

I agree with karels@'s suggestion re: commit message

Mon, May 6, 1:05 PM

Fri, May 3

allanjude accepted D45080: libdiff: More type issues..
Fri, May 3, 4:31 PM
allanjude accepted D45077: libdiff: Fix type issues..
Fri, May 3, 1:26 PM

Apr 19 2024

allanjude accepted D44863: adduser: Overhaul..

About time the FreeBSD 4.x perl compat bits went away, especially since they were not actually providing compatibility.

Apr 19 2024, 1:29 PM

Apr 16 2024

allanjude accepted D44805: cp: Clarify an obscure comment..
Apr 16 2024, 12:47 PM
allanjude accepted D44806: cp: Additional sanity check..
Apr 16 2024, 12:47 PM

Apr 13 2024

allanjude accepted D44773: nullfs: Show correct exported flag..
Apr 13 2024, 1:37 PM

Apr 11 2024

allanjude accepted D44747: cloudware: allow disk format to be a list.
Apr 11 2024, 1:55 PM

Apr 4 2024

allanjude accepted D44635: ln: Improve link(1) variant of ln(1)..
Apr 4 2024, 2:08 PM

Mar 29 2024

allanjude accepted D44558: usr.bin: Make lorder conditional on MK_TOOLCHAIN..
Mar 29 2024, 6:10 PM

Mar 28 2024

allanjude added a comment to D44488: pf: if a new RDR state connect be created, modulate src port.

What real-life situation is this fix for? If this is for connections coming from behind a 3rd party SNAT, where SNAT reuses source ports faster than pf expires states, then maybe tuning pf timeouts would be enough. Or we could allow pf states to transition from TCPS_FIN_WAIT_2 back to TCPS_SYN_SENT, basically implementing SO_REUSEPORT for pf.

Mar 28 2024, 1:58 PM

Mar 26 2024

allanjude accepted D44514: install: Prefer strsnvis() to strsvis()..
Mar 26 2024, 4:58 PM
allanjude accepted D44512: ln: Clean up and simplify tests..

reviewed-by: allanjude

Mar 26 2024, 4:43 PM
allanjude accepted D44513: ln: Add a test case for ln -sfF..

reviewed-by: allanjude

Mar 26 2024, 4:35 PM
allanjude accepted D44511: ln: Use stdbool, style nits..

reviewed-by: allanjude

Mar 26 2024, 4:29 PM
allanjude accepted D44504: touch: Allow setting the timestamp to -1..

reviewed-by: allanjude

Mar 26 2024, 3:26 PM

Mar 24 2024

allanjude updated the diff for D44488: pf: if a new RDR state connect be created, modulate src port.

Address feedback

Mar 24 2024, 7:34 AM
allanjude added inline comments to D44488: pf: if a new RDR state connect be created, modulate src port.
Mar 24 2024, 7:34 AM
allanjude updated the diff for D44488: pf: if a new RDR state connect be created, modulate src port.

Add test case

Mar 24 2024, 6:57 AM
allanjude updated the test plan for D44488: pf: if a new RDR state connect be created, modulate src port.
Mar 24 2024, 6:55 AM
allanjude requested review of D44488: pf: if a new RDR state connect be created, modulate src port.
Mar 24 2024, 3:58 AM

Mar 12 2024

allanjude accepted D44304: ping: Fix protocol selection with NOINET6 kernel..

Reviewed-by: allanjude

Mar 12 2024, 4:23 PM

Mar 6 2024

allanjude accepted D44166: tarfs: Improve validation of numeric fields..
Mar 6 2024, 1:41 PM

Mar 5 2024

allanjude accepted D44227: tarfs: Factor out common test code..
Mar 5 2024, 1:48 PM
allanjude added inline comments to D44166: tarfs: Improve validation of numeric fields..
Mar 5 2024, 1:47 PM

Mar 4 2024

allanjude accepted D44022: Add missing "be"..
Mar 4 2024, 2:31 PM
allanjude accepted D44203: tarfs: Remove unnecessary hack and obsolete comment..
Mar 4 2024, 1:52 PM

Mar 1 2024

allanjude retitled D44167: script: handle terminal resize on SIGSWINCH from Handle terminal resize on SIGSWINCH in /usr/bin/script Added '-w' to enable forwarding of these events follows. to Handle terminal resize on SIGSWINCH in /usr/bin/scriptAdded '-w' to enable forwarding of these events follows..
Mar 1 2024, 3:49 PM

Feb 29 2024

allanjude accepted D44154: lorder: Tweak invalid file test..

The world is nothing if not consistency inconsistent.

Feb 29 2024, 1:45 PM
allanjude accepted D44155: lorder: Don't rely on legacy syntax..

good catch

Feb 29 2024, 1:45 PM

Feb 28 2024

allanjude accepted D44135: lorder: Undeprecate..

reviewed-by: allanjude

Feb 28 2024, 2:09 PM
allanjude accepted D44134: lorder: Add unit tests..

reviewed-by: allanjude

Feb 28 2024, 2:09 PM
allanjude accepted D44133: lorder: Clean up and improve robustness..

reviewed-by: allanjude

Feb 28 2024, 2:07 PM

Feb 27 2024

allanjude accepted D44043: zfsd: Use vdev prop values for fault/degrade thresholds.

reviewed-by: allanjude

Feb 27 2024, 7:57 PM · ZFS

Feb 23 2024

allanjude added inline comments to D44043: zfsd: Use vdev prop values for fault/degrade thresholds.
Feb 23 2024, 4:40 PM · ZFS

Feb 20 2024

allanjude accepted D43991: md5: Untabify declarations..
Feb 20 2024, 7:32 PM
allanjude accepted D43990: md5: Fix GNU check mode..
Feb 20 2024, 7:32 PM
allanjude accepted D43989: md5: Fix Perl mode long options..
Feb 20 2024, 7:30 PM
allanjude accepted D43988: md5: Add test case for GNU input modes..

reviewed-by: allanjude

Feb 20 2024, 7:30 PM

Feb 14 2024

allanjude accepted D43871: md5: Ignore files in string and passthrough mode..

Good change to avoid unexpected behaviour

Feb 14 2024, 1:59 PM
allanjude accepted D43870: md5: Accept "-" as alias for stdin..

I could have sworn it did this already.

Feb 14 2024, 1:58 PM

Feb 12 2024

allanjude accepted D43850: patch: Support long context lines..

Reviewed-by: allanjude

Feb 12 2024, 6:20 PM

Jan 31 2024

allanjude accepted D43559: bintrans: Remove unused variable..

Reviewed-by: allanjude

Jan 31 2024, 2:40 PM
allanjude accepted D43532: bintrans: Error out if writing to the output failed..

Reviewed-by: allanjude

Jan 31 2024, 2:40 PM

Jan 25 2024

allanjude committed R9:e296c9ae4b9b: ChiBUG has shutdown (authored by allanjude).
ChiBUG has shutdown
Jan 25 2024, 11:16 PM

Jan 18 2024

allanjude added reviewers for D43505: mpr: endianess fix for set/get dpm page0: oshogbo, ken, jhibbits.
Jan 18 2024, 8:18 PM

Jan 16 2024

allanjude committed rGdc02374f5445: Fix KASSERT in 80044c78 causing build failures (authored by allanjude).
Fix KASSERT in 80044c78 causing build failures
Jan 16 2024, 11:15 PM
allanjude closed D42526: Add UDP encapsulation of ESP in IPv6.

Committed as 80044c785cb040a2cf73779d23f9e1e81a00c6c3

Jan 16 2024, 8:49 PM
allanjude committed rG80044c785cb0: Add UDP encapsulation of ESP in IPv6 (authored by xavier.beaudouin_klarasystems.com).
Add UDP encapsulation of ESP in IPv6
Jan 16 2024, 8:48 PM

Jan 12 2024

allanjude accepted D43423: login: Missed an instance of getpwnam()..

Reviewed-by: allanjude

Jan 12 2024, 4:37 PM

Jan 9 2024

allanjude accepted D43376: login: Use getpwnam_r() instead of getpwnam()..

Reviewed-by: allanjude

Jan 9 2024, 7:16 PM

Jan 4 2024

allanjude added inline comments to D43158: arm64: Disable kernel superpage promotion when KMSAN is configured.
Jan 4 2024, 3:08 PM

Jan 2 2024

allanjude accepted D43286: bhyveload: enter capability mode after we setup the vcpu.

reviewed-by: allanjude

Jan 2 2024, 11:32 PM
allanjude accepted D43285: bhyveload: hold /boot and do relative lookups for the loader.

reviewed-by: allanjude

Jan 2 2024, 11:32 PM
allanjude accepted D43284: bhyveload: use a dirfd to support -h.

reviewed-by: allanjude

Jan 2 2024, 11:29 PM

Dec 14 2023

allanjude accepted D43067: cp: Move the -N flag in the manual page..

reviewed-by: allanjude

Dec 14 2023, 7:56 PM

Dec 13 2023

allanjude accepted D43055: cp: Refactor the core logic..

reviewed-by: allanjude

Dec 13 2023, 11:30 PM
allanjude accepted D43054: cp: Add tests for symbolic link case..

reviewed-by: allanjude

Dec 13 2023, 11:25 PM

Dec 11 2023

allanjude abandoned D41759: arm: Allow in-kernel VFP instructions handling..
Dec 11 2023, 4:19 PM · ARM
allanjude commandeered D41759: arm: Allow in-kernel VFP instructions handling..
Dec 11 2023, 4:19 PM · ARM

Dec 9 2023

allanjude committed R9:c781a3ebdbe0: Add HamBUG.ca to the usergroup list (authored by allanjude).
Add HamBUG.ca to the usergroup list
Dec 9 2023, 5:13 PM

Nov 29 2023

allanjude accepted D42839: tail: Fix heap overflow in -F case..

reviewed-by: allanjude

Nov 29 2023, 9:02 PM

Nov 22 2023

allanjude accepted D42713: lockf: don't hold stdin/stdout/stderr open.

reviewed-by: allanjude

Nov 22 2023, 1:59 PM
allanjude accepted D42718: lockf: allow locking file descriptors.

reviewed-by: allanjude

Nov 22 2023, 1:59 PM
allanjude accepted D42714: lockf: add some tests.

reviewed-by: allanjude

Nov 22 2023, 1:50 PM
allanjude accepted D42712: lockf: correct omission in the usage statement.

reviewed-by: allanjude

Nov 22 2023, 1:39 PM
allanjude accepted D42711: lockf: hide unavailable error with -n -s.

reviewed-by: allanjude

Nov 22 2023, 1:39 PM

Nov 9 2023

allanjude updated the summary of D42526: Add UDP encapsulation of ESP in IPv6.
Nov 9 2023, 3:55 PM
allanjude added reviewers for D42526: Add UDP encapsulation of ESP in IPv6: markj, ae.
Nov 9 2023, 3:55 PM

Nov 7 2023

allanjude accepted D42490: certctl: Convert line endings before inspecting files..

reviewed-by: allanjude

Nov 7 2023, 7:28 PM

Oct 19 2023

allanjude accepted D42276: certctl: Fix recent regressions..

Reviewed-by: allanjude

Oct 19 2023, 4:02 PM

Oct 14 2023

allanjude added a member for ZFS: allanjude.
Oct 14 2023, 2:28 PM
allanjude accepted D42211: ZFS: Set spa_ccw_fail_time=0 when expanding vdev..

If we are happy with this fix, we should open a pull request for it upstream as well, I think it is reasonable to reset the retry especially since this is either a user initiated action, or proved by an device change event from the system

Oct 14 2023, 2:28 PM

Oct 9 2023

allanjude accepted D42137: ping: Simplify protocol selection..

reviewed-by: allanjude

Oct 9 2023, 8:58 PM

Oct 6 2023

allanjude accepted D42111: daemon: Disable stdio buffering..

Reviewed-by: allanjude

Oct 6 2023, 4:14 PM