allanjude (Allan Jude)Administrator
User

Projects

User Details

User Since
May 19 2014, 3:05 PM (196 w, 6 d)
Roles
Administrator

Recent Activity

Yesterday

allanjude updated the diff for D14502: Improve the disk growing instructions.

Fix tense error pointed out by bcr

Sun, Feb 25, 6:43 PM
allanjude created D14502: Improve the disk growing instructions.
Sun, Feb 25, 6:05 AM

Thu, Feb 22

allanjude added reviewers for D14465: Create sysctl hw.model on ARM: andrew, manu, imp.
Thu, Feb 22, 12:52 AM · ARM
allanjude accepted D14408: Sandbox wc(1) with fileargs..
Thu, Feb 22, 12:46 AM

Sat, Feb 17

allanjude accepted D14408: Sandbox wc(1) with fileargs..

This looks pretty clean, I like it.

Sat, Feb 17, 5:13 PM

Tue, Feb 13

allanjude accepted D14352: Move zstd malloc()/free()/calloc() macros to stdlib.h..
Tue, Feb 13, 4:33 PM

Sat, Feb 10

allanjude added a comment to D14286: firewall_type is ignored if not set in rc.conf or rc.conf.local.

For this to work right, shouldn't we load /etc/rc.conf.d/pf and maybe ipf as well?

Sat, Feb 10, 5:22 AM

Tue, Feb 6

allanjude accepted D13778: rc.d/cleanvar: purgedir function has shell expansion vulnerability.

This seems like a much safer approach

Tue, Feb 6, 8:25 PM

Sun, Feb 4

allanjude committed rS328839: Add the ThinkPad X1 (sandybridge) to the bsdinstall blacklist.
Add the ThinkPad X1 (sandybridge) to the bsdinstall blacklist
Sun, Feb 4, 12:17 PM

Fri, Feb 2

allanjude accepted D12690: Add GELI partition types.
Fri, Feb 2, 10:44 AM

Wed, Jan 31

allanjude accepted D12302: Move EFI FAT creation to here to obviate need for the boot1.efifat file.
Wed, Jan 31, 12:55 AM

Mon, Jan 29

allanjude accepted D14120: Remove duplicate entries from various conf/files*.
Mon, Jan 29, 5:27 PM
allanjude updated the diff for D11124: WIP: ZSTD in ZFS.

Solve issues with L2ARC if compressed_arc_enabled=0

Mon, Jan 29, 5:33 AM

Sun, Jan 28

allanjude added a comment to D14064: Change the installer default to not install ports.

Maybe as a separate change, but is it time to stop shipping lib32 by default as well?

Sun, Jan 28, 12:16 AM
allanjude accepted D14064: Change the installer default to not install ports.
Sun, Jan 28, 12:16 AM

Sat, Jan 27

allanjude updated the diff for D7655: Capsicumize uudecode/b64decode.

Update to latest -current for @bkidney_briankidney.ca

Sat, Jan 27, 11:01 PM
allanjude closed D10239: Create a machine/metadata.h for RISC-V.
Sat, Jan 27, 10:47 PM
allanjude abandoned D12295: Kill gets().
Sat, Jan 27, 10:30 PM
allanjude abandoned D12624: sys/boot: always use freshly build libstand.
Sat, Jan 27, 10:29 PM

Jan 22 2018

allanjude added a comment to D12396: Default ABD chunk size.

avg@ added the loader tunable to make this adjustable in https://svnweb.freebsd.org/base?view=revision&revision=323797 however I have every reason to believe (and measurements from production) that 4K is a going to result in more waste than a 1K default. A 1K default may result in fragmentation with 4K slabs but there is less waste for everyone with 1K than 4K.

@mahrens , do you think OpenZFS will go back to a 1K default?

Jan 22 2018, 3:40 AM · ZFS

Jan 14 2018

allanjude accepted D11970: cddl/sbin/zfs build warning fix.
Jan 14 2018, 5:06 PM

Jan 4 2018

allanjude added inline comments to D13757: morse: implement support for decoding morse code.
Jan 4 2018, 4:54 AM

Dec 7 2017

allanjude added a member for committers: chuck.
Dec 7 2017, 4:09 PM

Dec 5 2017

allanjude updated the diff for D11124: WIP: ZSTD in ZFS.

Newer version of ZSTD (1.3.2)

Dec 5 2017, 4:41 AM

Dec 4 2017

allanjude updated the diff for D10407: Modify zstd so it can be built into the kernel as well.

Switch from symlink to include files

Dec 4 2017, 4:51 AM
allanjude committed rS326507: increase maximum size of zfsboot.
increase maximum size of zfsboot
Dec 4 2017, 2:42 AM
allanjude updated the diff for D10407: Modify zstd so it can be built into the kernel as well.

Switch to Warner's fake-files concept

Dec 4 2017, 2:21 AM
allanjude added inline comments to D10407: Modify zstd so it can be built into the kernel as well.
Dec 4 2017, 1:47 AM
allanjude committed rS326506: Use __has_builtin() to ensure clz and clzll builtins are available.
Use __has_builtin() to ensure clz and clzll builtins are available
Dec 4 2017, 1:16 AM

Dec 3 2017

allanjude updated the diff for D10407: Modify zstd so it can be built into the kernel as well.

Update to latest -current and lots of cleanup suggested by imp

Dec 3 2017, 5:15 AM

Nov 30 2017

allanjude accepted D13301: Fix various warnings related to geli support..

Thanks for cleaning up my mess

Nov 30 2017, 4:59 PM

Nov 23 2017

allanjude added inline comments to D12577: Some more basic flavors work..
Nov 23 2017, 5:16 PM

Nov 22 2017

allanjude accepted D13190: Fix indentation in bsdinstall-created wpa_supplicant.conf.

goatforit

Nov 22 2017, 3:39 AM

Nov 21 2017

allanjude added a comment to D13088: zpool: cannot anymore import cache device which doesn't contain a previos ZFS vdev label.

The best fix would have been to check the errno value inside zpool_read_label() just after the libc calls, like all errno checks should be done. But it necessitates to add one more return value to zpool_read_label():

  • 0 == vdev label was read (continue the normal execution)
  • -1 == ENOMEM, do the no_memory() call and fail.
  • -2 == vdev label not found (don't enter the if block and continue the normal execution)
Nov 21 2017, 1:26 AM

Nov 19 2017

allanjude added a comment to D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.

I'll try to get some time allocated to that - right now the machine that
I use for this effort is busy doing other things but I may be able to
free up some time on it in the next week or two.

Is there any intent to backport/MFC those changes into 11-STABLE?  That
I can probably test and adapt the code to more-quickly.

The needfree change is a good one, it's just that having it confined to
-HEAD causes problems for me right now due to "free computer of
appropriate configuration" constraints.

Thanks in advance.

Nov 19 2017, 6:49 PM · ZFS
allanjude added a comment to D7538: Correct adaptation ZFS ARC memory pressure to FreeBSD.

Well that's a bitch.

It's easily fixed but I'm not going to be doing much with -HEAD until it
stabilizes and gets closer to being -RELEASE.

Nov 19 2017, 4:53 PM · ZFS

Nov 18 2017

allanjude accepted D13149: bsdinstall: Add ntpdate option.

Note: the modern installer has an entire UI dedicated to you setting the date correctly during the install.

Nov 18 2017, 10:08 PM

Nov 17 2017

allanjude added a comment to D13088: zpool: cannot anymore import cache device which doesn't contain a previos ZFS vdev label.

Thanks for your comments Allan and Andriy.
Concerning the errno set to 12 (ENOMEM), it's effectively set by the ioctl ZFS_IOC_POOL_STATS which is first called with a too small nvlist.
I'm attaching the conditional watchpoint where it happens.

Watchpoint 1 hit:
old value: 0
new value: 12
Process 11604 stopped
* thread #1, name = 'zpool', stop reason = watchpoint 1
    frame #0: 0x0000000800e951e9 libzfs.so.2`zcmd_ioctl(fd=3, request=5, zc=0x00007fffffffc640) at libzfs_compat.c:117
   114 	
   115 		if (ret == 0 && oldsize < zc->zc_nvlist_dst_size) {
   116 			ret = -1;
-> 117 			errno = ENOMEM;
   118 		}
   119 	
   120 		return (ret);
(lldb) bt
* thread #1, name = 'zpool', stop reason = watchpoint 1
  * frame #0: 0x0000000800e951e9 libzfs.so.2`zcmd_ioctl(fd=3, request=5, zc=0x00007fffffffc640) at libzfs_compat.c:117
    frame #1: 0x0000000800e87099 libzfs.so.2`zpool_refresh_stats(zhp=0x0000000802c30000, missing=0x00007fffffffd844) at libzfs_config.c:282
    frame #2: 0x0000000800e800e5 libzfs.so.2`zpool_open_canfail(hdl=0x0000000802c20000, pool="bld311") at libzfs_pool.c:995
    frame #3: 0x0000000800e802ef libzfs.so.2`zpool_open(hdl=0x0000000802c20000, pool=<unavailable>) at libzfs_pool.c:1051
    frame #4: 0x000000000040820c zpool`zpool_do_add(argc=3, argv=0x00007fffffffeb70) at zpool_main.c:540
    frame #5: 0x000000000040766f zpool`main(argc=<unavailable>, argv=0x00007fffffffeb60) at zpool_main.c:5642
    frame #6: 0x00000000004043ff zpool`_start + 399

Concerning your suggestion on how to fix it, I would rather suggest that to modify zpool_read_label() to return -1 in the case of a libc with errno == ENOMEM and return -2 in the case of other internal and logical ZFS "failure" ( no vdev label for exemple ).
In my opinion our real bug here is to check the value of errno after a call to an internal ZFS function and not after the libc call. Currently we are reading errno too late and we cannot easily differentiate a libc failure from a normal ZFS failure.

for example:

if (zpool_read_label(fd, &config) != 0 && errno == ENOMEM) {
        (void) no_memory(hdl);
        return (-1);
}

would be:

if (zpool_read_label(fd, &config) == -1) {
        (void) no_memory(hdl);
        return (-1);
}
Nov 17 2017, 5:35 PM

Nov 15 2017

allanjude added a comment to D13088: zpool: cannot anymore import cache device which doesn't contain a previos ZFS vdev label.

I think since we are returning -1 (a failure), it makes more sense to set errno to 0 at the top of the function, so that we only zero it if it is from before this function was run.

Nov 15 2017, 5:03 PM

Nov 13 2017

allanjude closed D11471: Add deprecation notices for all rcmd tools.
Nov 13 2017, 2:18 AM
allanjude removed a reviewer for D11471: Add deprecation notices for all rcmd tools: jlh.
Nov 13 2017, 2:18 AM
allanjude accepted D11471: Add deprecation notices for all rcmd tools.
Nov 13 2017, 2:18 AM

Nov 12 2017

allanjude added a comment to D10407: Modify zstd so it can be built into the kernel as well.

Thanks for the feedback Warner. I'll work on that stuff later today or tomorrow.

Nov 12 2017, 12:08 AM

Nov 11 2017

allanjude updated the diff for D10407: Modify zstd so it can be built into the kernel as well.

Rebase to zstd 1.3.2

Nov 11 2017, 3:15 PM
allanjude closed D12395: vmstat: Fix duplicate key in libxo output.
Nov 11 2017, 2:02 PM
allanjude committed rS325715: vmstat: fix duplicate key in libxo output.
vmstat: fix duplicate key in libxo output
Nov 11 2017, 2:02 PM

Nov 1 2017

allanjude added a comment to D11124: WIP: ZSTD in ZFS.

@yann.collet.73_gmail.com : Is there any tuning we can do to get the size of the compression context down, since we know the maximum size if the input will be 16MB?

Nov 1 2017, 3:05 AM

Oct 31 2017

allanjude added a comment to D12847: loader ptblread() is broken with >512B sectors.

I will test this on my macbookpro NVMe where FreeBSD currently cannot read the partition table.

Oct 31 2017, 11:51 AM
allanjude added a comment to D12848: Remove 'adding_user.7'.

Did you check for other man pages that .Xr this manpage?

Oct 31 2017, 11:50 AM
allanjude added a comment to D9649: Enable VNET operations for ifconfig and route.

I think an interface like mjg described is the best approach.

Oct 31 2017, 11:21 AM · network
allanjude requested changes to D9649: Enable VNET operations for ifconfig and route.

jail_attach() is not the correct approach, because it makes the actions of the administrator on the host visible within the jail.

Oct 31 2017, 11:08 AM · network

Oct 30 2017

allanjude accepted D12831: bluetooth: Default to discoverable off.

bluetooth should not be unconditional.

Oct 30 2017, 4:35 AM

Oct 29 2017

allanjude accepted D12827: New ports, sysutils/smart: Output disk SMART values.

Thank you very much

Oct 29 2017, 9:37 PM
allanjude accepted D12820: Move up the correct to compile the kernel.

Approved

Oct 29 2017, 12:57 AM
allanjude added a reviewer for D12820: Move up the correct to compile the kernel: allanjude.
Oct 29 2017, 12:52 AM
allanjude added a comment to D12820: Move up the correct to compile the kernel.

It might be useful to mention -DNO_CLEAN as a more supported shortcut

Oct 29 2017, 12:51 AM

Oct 17 2017

allanjude accepted D12678: Improve svn copy documentation.

Approved

Oct 17 2017, 5:22 PM

Oct 16 2017

allanjude added a reviewer for D11124: WIP: ZSTD in ZFS: tsoome.
Oct 16 2017, 4:47 PM
allanjude accepted D12679: Document missing libgeom functions.

Approved By: allanjude

Oct 16 2017, 3:33 PM

Oct 14 2017

allanjude accepted D11793: security/openssh-portable: Remove groff dependency.
Oct 14 2017, 2:28 AM

Oct 12 2017

allanjude accepted D12640: libc: allow posix_fallocate in capability mode.
Oct 12 2017, 2:04 AM

Oct 10 2017

allanjude added inline comments to D11124: WIP: ZSTD in ZFS.
Oct 10 2017, 4:56 AM
allanjude added a dependency for D11124: WIP: ZSTD in ZFS: D10407: Modify zstd so it can be built into the kernel as well.
Oct 10 2017, 3:01 AM
allanjude added a dependent revision for D10407: Modify zstd so it can be built into the kernel as well: D11124: WIP: ZSTD in ZFS.
Oct 10 2017, 3:01 AM
allanjude updated the summary of D11124: WIP: ZSTD in ZFS.
Oct 10 2017, 3:01 AM
allanjude updated the diff for D10407: Modify zstd so it can be built into the kernel as well.

Cleanup debugging cruft

Oct 10 2017, 2:58 AM
allanjude updated the diff for D10407: Modify zstd so it can be built into the kernel as well.

Sparc fixes

Oct 10 2017, 2:55 AM
allanjude updated the diff for D11124: WIP: ZSTD in ZFS.

Update to support ZSTD 1.3.x

Oct 10 2017, 2:53 AM

Oct 8 2017

allanjude added a comment to D12624: sys/boot: always use freshly build libstand.

@imp I know you are working on a sys/boot cleanup, so I figured you might want to integrate this

Oct 8 2017, 7:58 PM
allanjude created D12624: sys/boot: always use freshly build libstand.
Oct 8 2017, 7:58 PM

Oct 7 2017

allanjude updated the diff for D10407: Modify zstd so it can be built into the kernel as well.

Address Conrad's feedback re: M_NOWAIT

Oct 7 2017, 3:18 AM
allanjude updated the summary of D10407: Modify zstd so it can be built into the kernel as well.
Oct 7 2017, 3:18 AM

Oct 6 2017

allanjude added a comment to D10447: Unify boot1 with loader.

This now cleanly applies with 'arc patch' for me

Oct 6 2017, 3:37 PM
allanjude updated the diff for D10407: Modify zstd so it can be built into the kernel as well.

Updated for newer version of zstd

Oct 6 2017, 4:57 AM
allanjude accepted D12298: libc: remove gets.
Oct 6 2017, 3:57 AM

Oct 3 2017

allanjude accepted D12578: Display TRIM/UNMAP support in "diskinfo -v".

Thank you

Oct 3 2017, 8:59 PM
allanjude accepted D12578: Display TRIM/UNMAP support in "diskinfo -v".

I agree with @mav about adding any other useful bits from GEOM that are available.

Oct 3 2017, 7:57 PM

Oct 2 2017

allanjude accepted D12567: Update the process of creating new Wiki accounts.

Approved

Oct 2 2017, 6:10 PM
allanjude committed rS324206: bsdinstall(8) hardening menu: Utilize new kern.randompid=1 behaviour.
bsdinstall(8) hardening menu: Utilize new kern.randompid=1 behaviour
Oct 2 2017, 2:19 PM
allanjude closed D12433: bsdinstall(8) hardening menu: Utilize new kern.randompid=1 behaviour.
Oct 2 2017, 2:19 PM
allanjude accepted D11869: sys/boot/geli build warning fixes.
Oct 2 2017, 4:32 AM
allanjude added inline comments to D12474: Add destructive dtrace to bsdinstall hardening menu.
Oct 2 2017, 4:32 AM
allanjude accepted D12556: Add back zh_CN entry on the homepage.
Oct 2 2017, 4:31 AM

Sep 29 2017

allanjude accepted D12476: Fix variable name typo in bsdinstall ttys hardening.
Sep 29 2017, 3:18 PM

Sep 27 2017

allanjude accepted D12433: bsdinstall(8) hardening menu: Utilize new kern.randompid=1 behaviour.
Sep 27 2017, 4:24 PM

Sep 22 2017

allanjude added a comment to D12406: increase libmd buffer size to 1m.

I think something else is going on. Can you try the with and without with 'truss -c' instead of 'time'

Sep 22 2017, 8:20 AM

Sep 21 2017

allanjude added a comment to D12406: increase libmd buffer size to 1m.

I am confused by your results:

Sep 21 2017, 10:11 PM

Sep 16 2017

allanjude committed rS323645: kern.osreldate is an integer, not a string.
kern.osreldate is an integer, not a string
Sep 16 2017, 4:23 PM
allanjude created D12395: vmstat: Fix duplicate key in libxo output.
Sep 16 2017, 4:17 PM

Sep 15 2017

allanjude accepted D12339: rename(2): document capability mode errors.
Sep 15 2017, 2:18 PM
allanjude added a comment to D12339: rename(2): document capability mode errors.
In D12339#255993, @cem wrote:

Er, why is rename / renameat with AT_FDCWD not allowed in capability mode?

Sep 15 2017, 2:18 PM

Sep 14 2017

allanjude accepted D12370: loader: biosmem.c cstyle cleanup.
Sep 14 2017, 3:51 PM

Sep 13 2017

allanjude committed rS323554: Increase EFI boot file size frok 128k to 384k.
Increase EFI boot file size frok 128k to 384k
Sep 13 2017, 5:00 PM
allanjude closed D9680: Increase EFI MSDOSFS image size to 512Kib.
Sep 13 2017, 5:00 PM
allanjude updated the diff for D9680: Increase EFI MSDOSFS image size to 512Kib.

Resync

Sep 13 2017, 4:25 AM

Sep 12 2017

allanjude accepted D12346: Don't complain about missing mountpoints for scripted installations..
Sep 12 2017, 9:59 PM
allanjude accepted D12317: Deorbit catman. It's useless on modern hardware..
Sep 12 2017, 9:48 PM
allanjude accepted D12340: libefi: efipart_open should check the status from disk_open.

Looks good.

Sep 12 2017, 2:15 PM

Sep 11 2017

allanjude accepted D12288: loader should support large_dnode.

Thanks for keeping on top of this

Sep 11 2017, 4:08 PM
allanjude requested changes to D12302: Move EFI FAT creation to here to obviate need for the boot1.efifat file.
Sep 11 2017, 12:32 AM