As we progress here, we will want a switch to maintain the legacy behaviour, at least for a while. We might even decide not to change the default right away.

Reviewed By: allanjude

Reviewed By: allanjude

Yeah, in general the FTP one might still be in use, but pretty much every FTP server supports passive mode now, so I don't know how often the FTP module is useful.

Thanks for cleaning this up, as noted in rS292782 the libmd version was optimized by cperciva@

Removing any surface area we can seems like a good idea

Approved

Approved By: allanjude

Committed as rP533560 not sure why it did not close properly.

Update version
Apply tricks learned from last nights review

Sync with jrm's suggestions

Force use of varnish6

Apply suggested changes from jrm

This looks good to me. Although I wonder if we might not want a solution that also covers people who don't run the installer. So that things like the VM Images that are generated by the release have the certs setup

I think having them all is fine

With DESTDIR support in certctl now, this looks good to me

Move copyright message to the correct place

Not sure if ministat belongs on the list. It is more for doing statistical analysis, it doesn't actually give you any stats/status about your system

Fix typo

Address most of cem's feedback

In D24371#536111, @eugen_grosbein.net wrote:

I'm not sure I understand the problem.

The candelete() function does properly detect if the disk supports TRIM

Does or does not? Anyway, it works for me just fine using stable/11 system:

mdconfig -at malloc -s 1m

md0

1. diskinfo -v md0 | grep TRIM Yes # TRIM/UNMAP support
2. trim -f /dev/md0; echo $?

trim /dev/md0 offset 0 length 1048576
0

The function candelete() was copied from diskinfo(8) code as noted in the commit message. The diskinfo utility opens the device with O_RDONLY, too. It all was tested before committing.

In D24371#536107, @asomers wrote:

The change LGTM, but double check your commit message. Is there a missing "not"?

Update to fix some issues and catch up with HEAD

Add VIRTIO_BLK_T_DISCARD (TRIM) support to the bhyve virtio-blk backend

This seems like a good way to cut down the size

Reviewed By: allanjude

ping: Is there anything left for Dave to do here, or can we commit this?

Is this stalled?

Reviewed By: allanjude

Reviewed by: allanjude

Reviewed By: allanjude

Reviewed By: allanjude

I wonder if it would make sense to try to stripe the trailing whitespace from the serial # etc. The json output looks a little silly:

Reviewed by: allanjude

Reviewed By: allanjude

In D22193#488245, @trasz wrote:

FWIW, grepping for that pattern only brings up the one hit Warner has already mentioned, and it's already under #ifdef illumos:

% grep -r '%ss%d' *
cddl/contrib/opensolaris/cmd/zpool/zpool_vdev.c:                (void) snprintf(buf, sizeof (buf), "%ss%d", path, slice);

I am fine with moving the text, just make sure you svn commit the correct files

In D22304#487863, @markj wrote:

Why don't we just have a "name" parameter that determines the entire gnop provider name?

it looks like you added conduct-reporting.html (the build artifact) not .xml (the source), and that it was not marked as a text file.

Maybe give Warner a chance to provide any more feedback before we commit this.

Attachment does seem to fit the bill best

Reviewed By: allanjude

In D22193#485070, @imp wrote:

/*
  * Fill in the devid, now that we've labeled the disk.
  */
 (void) snprintf(buf, sizeof (buf), "%ss%d", path, slice);
 if ((fd = open(buf, O_RDONLY)) < 0) {
         (void) fprintf(stderr,
             gettext("cannot open '%s': %s\n"),
             buf, strerror(errno));
         return (-1);
 }

is one example, this one is from cddl/contrib/opensolaris/cmd/zpool/zpool_vdev.c

Is the 'd' or 'c' in the description a typo? Should it be ada0d/s1? or ada0/s1

Reviewed By: allanjude

Committed as rS352504