Page MenuHomeFreeBSD

allanjude (Allan Jude)
UserAdministrator

Projects (9)

User Details

User Since
May 19 2014, 3:05 PM (417 w, 4 d)
Roles
Administrator

Recent Activity

Wed, May 18

allanjude added inline comments to D35248: makefs: Add ZFS support.
Wed, May 18, 11:10 PM
allanjude added a comment to D35248: makefs: Add ZFS support.
In D35248#798943, @imp wrote:

Shouldn't you reach over into the boot loader to get the shared files?
If there's some reason you can't do this, it should be documented and/or discussed.

Yes, there's no real reason not to. I just did copied them because I had to modify some of the shared files and wanted to keep things self-contained.

I also wonder if there's precedent for sharing code with the loader like that. Should it perhaps be moved to some common area, or should I just set .PATH=stand/libsa/zfs and not worry about it?

Wed, May 18, 10:34 PM

Fri, May 6

allanjude added inline comments to D35139: dmesg: Document kern.msgbuf_show_timestamp.
Fri, May 6, 4:47 PM

Apr 14 2022

allanjude accepted D34879: bsdinstall: Filter out devices that cannot be opened.

reviewed by: allanjude

Apr 14 2022, 5:55 PM
allanjude accepted D34878: bsdinstall: allow whitelabeling the installer.

Reviewed by: allanjude

Apr 14 2022, 5:54 PM

Mar 25 2022

allanjude added a reviewer for D34637: Allow realtime and precise accounting of cpu utilization for threads and racct-objects.: trasz.
Mar 25 2022, 1:18 PM · Jails

Mar 18 2022

allanjude accepted D34601: zfskeys: Support autoloading of keys stored on ZFS.

reviewed by: allanjude

Mar 18 2022, 1:05 PM · rc

Mar 17 2022

allanjude updated subscribers of D34465: bhyve: use bhyve_config for SMBIOS strings.
Mar 17 2022, 5:37 PM · bhyve
allanjude removed a reviewer for D31578: bhyve: add support for QEMU's fwcfg: tsoome.
Mar 17 2022, 5:37 PM · bhyve
allanjude added a reviewer for D31578: bhyve: add support for QEMU's fwcfg: tsoome.
Mar 17 2022, 5:36 PM · bhyve

Mar 9 2022

allanjude accepted D34511: script add -T fmt to print time-stamps.
Mar 9 2022, 8:51 PM
allanjude accepted D34497: libmd, kern, stand: consolidate md5 implementations (NFC).

Reviewed by: allanjude

Mar 9 2022, 6:42 PM

Mar 7 2022

allanjude accepted D34167: bsdinstall: Do not show disks that are already in use when creating a zpool.

My only concern here is a user not understanding why the disks they know exist are not present in the list.
dialog doesn't really provide a way to present the 'disabled' disks, so I don't know there is much we can do about this.
Since it is likely the commands will fail for the disk that is in use, I think this is fine.

Mar 7 2022, 3:16 PM

Mar 4 2022

allanjude accepted D34428: RELNOTES: Note addition of zfskeys.
Mar 4 2022, 9:47 PM

Mar 3 2022

allanjude accepted D34427: rc.conf: Document zfskeys.
Mar 3 2022, 7:07 PM

Feb 10 2022

allanjude updated subscribers of D32670: The Arm CoreLink DMC-620 Dynamic Memory Controller PMU driver.
Feb 10 2022, 4:40 PM
allanjude updated subscribers of D32321: Add support of ARM CMN-600 controller, PMU access functions only. Add support of PMU counters of ARM CMN-600 controller..
Feb 10 2022, 4:40 PM

Jan 28 2022

allanjude added a member for Klara: rew.
Jan 28 2022, 5:37 PM
allanjude created Klara.
Jan 28 2022, 2:13 PM
allanjude accepted D34075: Fix wording in comments.

Reviewed by: allanjude

Jan 28 2022, 2:12 PM

Jan 26 2022

allanjude added a comment to D21939: Enter chroot before looking up user or group to change to.

This change may cause breakage in setups where the chroot does not have /etc/pwd.db and related files. Given that chroot(8) has worked like this since 2003, why change it now?

The text that used to be in the manual page may be a bit misleading but it is still correct, since chroot(2) requires root privileges and therefore the actual privilege change occurs after it. The lookup of UIDs and GIDs is not explicitly mentioned.

Swapping the order can be done with the existing tools by executing su(1) or another chroot(8) in the chroot. The former has the advantage of also setting various other items such as the login class.

Jan 26 2022, 6:19 PM
allanjude accepted D34046: Fix test output when gzip is run with -tlv.

Reviewed By: allanjude

Jan 26 2022, 4:00 PM

Jan 20 2022

allanjude accepted D33575: bhyve nvme: Fix LBA out-of-range calculation.

Reviewed by: allanjude

Jan 20 2022, 5:12 PM

Jan 17 2022

allanjude accepted D33918: bsdinstall: Add quotes around error message argument.

yeah, --msgbox complains "Expected no more than 3 tokens for --msgbox, have 9." or however many words there were in your error message, plus the "0 0" parameters.

Jan 17 2022, 5:03 PM

Jan 8 2022

allanjude added inline comments to D33795: tail: add test for tail -F against newsyslog rotation.
Jan 8 2022, 7:33 PM
allanjude updated the diff for D33795: tail: add test for tail -F against newsyslog rotation.

Don't sleep longer than required

Jan 8 2022, 7:33 PM
allanjude added a reviewer for D33795: tail: add test for tail -F against newsyslog rotation: nsultana_seas.upenn.edu.
Jan 8 2022, 6:15 PM
allanjude updated the summary of D33795: tail: add test for tail -F against newsyslog rotation.
Jan 8 2022, 5:59 PM
allanjude updated the diff for D33795: tail: add test for tail -F against newsyslog rotation.

Fix commit message, broken tail -F is on 13.0 not 12.2

Jan 8 2022, 5:59 PM
allanjude requested review of D33795: tail: add test for tail -F against newsyslog rotation.
Jan 8 2022, 5:54 PM

Jan 6 2022

allanjude accepted D30186: init_main.c: sort includes.

Reviewed By: allanjude

Jan 6 2022, 5:15 PM

Dec 23 2021

allanjude accepted D33568: bhyve nvme: Implement Log Page Offset.

Reviewed By: allanjude

Dec 23 2021, 5:24 PM
allanjude accepted D33574: bhyve nvme: Add Select support to Get Features.

Reviewed By: allanjude

Dec 23 2021, 5:22 PM
allanjude added inline comments to D33577: bhyve nvme: Fix Set Features, AEN.
Dec 23 2021, 5:22 PM
allanjude accepted D33567: bhyve nvme: Implement LBA Range Type feature.

Reviewed By: allanjude

Dec 23 2021, 5:21 PM
allanjude accepted D33566: bhyve nvme: Fix Namespace Specific Set Features.

Reviewed By: allanjude

Dec 23 2021, 5:20 PM
allanjude accepted D33578: bhyve nvme: Fix Identify Namespace, NSID=ffffffff.

Reviewed By: allanjude

Dec 23 2021, 5:20 PM
allanjude accepted D33565: bhyve nvme: Fix NVM Format completion status.

Reviewed By: allanjude

Dec 23 2021, 5:20 PM
allanjude accepted D33576: bhyve nvme: Fix reported VWC value.

Reviewed By: allanjude

Dec 23 2021, 5:17 PM
allanjude accepted D33569: bhyve nvme: Add missing Admin opcodes.

Reviewed By: allanjude

Dec 23 2021, 5:17 PM
allanjude accepted D33570: bhyve nvme: Remove redundant AER Limit checks.

Reviewed By: allanjude

Dec 23 2021, 5:17 PM
allanjude accepted D33573: bhyve nvme: Update v1.4 Identify Controller data.

Reviewed By: allanjude

Dec 23 2021, 5:16 PM
allanjude accepted D33575: bhyve nvme: Fix LBA out-of-range calculation.

Reviewed By: allanjude

Dec 23 2021, 5:15 PM
allanjude accepted D33403: bhyve: get mediasize for character devices when resizing virtio-blk.

Reviewed by: allanjude

Dec 23 2021, 5:12 PM
allanjude added inline comments to D33572: bhyve nvme: Add Temperature Threshold support.
Dec 23 2021, 5:07 PM
allanjude accepted D33564: bhyve nvme: Advertise v1.4 support.

Reviewed By: allanjude

Dec 23 2021, 5:04 PM

Dec 14 2021

allanjude added a comment to D15607: Improve error handling for KERN_PROC_{CWD,FILEDESC}..

This came up again via: https://blog.guillaume-gomez.fr/articles/2021-12-14+sysinfo%3A+version+0.22+and+FreeBSD+support

Dec 14 2021, 6:45 PM

Dec 10 2021

allanjude added inline comments to D33381: rc.subr: Do not apply limits unless requested.
Dec 10 2021, 11:30 PM · rc

Dec 8 2021

allanjude added reviewers for D33227: syncache: accept packets with no SA when TCP_MD5SIG is set: ae, melifaro.
Dec 8 2021, 8:33 PM

Dec 3 2021

allanjude committed R10:5f034a005435: fstab.5: spell encryption correctly (authored by fk_fabiankeil.de).
fstab.5: spell encryption correctly
Dec 3 2021, 4:30 PM
allanjude added a reviewer for D33248: Optionally deliver SIGCAP on capsicum violations.: oshogbo.
Dec 3 2021, 3:20 PM
allanjude accepted D33238: OptionalObsoleteFiles.inc: Add rc.d/zfskeys.

Approved By: allanjude

Dec 3 2021, 12:50 AM

Dec 2 2021

allanjude accepted D33230: rc: Hook zfskeys to the build.

Make sure to MFC this to stable/13 as well.

Dec 2 2021, 6:04 PM
allanjude added a comment to D33224: config(8): Add support for implications and specifying multiple files per option..

I think indenting the line continuations would help with the readability.

Dec 2 2021, 2:35 PM

Nov 30 2021

allanjude accepted D33203: bhyve blockif: fix blockif_candelete with Capsicum.

Reviewed By: allanjude

Nov 30 2021, 8:46 PM

Nov 25 2021

allanjude accepted D33110: arch.7: move discontinued CPU archs to own table.

Nice improvement

Nov 25 2021, 5:47 PM

Nov 22 2021

allanjude committed R10:8ffcfb399b20: openssl: Fix detection of ARMv7 and ARM64 CPU features (authored by allanjude).
openssl: Fix detection of ARMv7 and ARM64 CPU features
Nov 22 2021, 7:00 PM
allanjude committed R10:0ed191d116f5: openssl: Fix detection of ARMv7 and ARM64 CPU features (authored by allanjude).
openssl: Fix detection of ARMv7 and ARM64 CPU features
Nov 22 2021, 6:23 PM
allanjude committed R10:32a2fed6e71f: openssl: Fix detection of ARMv7 and ARM64 CPU features (authored by allanjude).
openssl: Fix detection of ARMv7 and ARM64 CPU features
Nov 22 2021, 6:15 PM
allanjude committed R10:d9bb798725cf: openssl: Fix detection of ARMv7 and ARM64 CPU features (authored by allanjude).
openssl: Fix detection of ARMv7 and ARM64 CPU features
Nov 22 2021, 6:12 PM
allanjude closed D33060: openssl: Fix detection of ARMv7 and ARM64 CPU features.
Nov 22 2021, 6:11 PM
allanjude committed R10:5bbfa333cfc4: ipresend(1): Make the build slightly less broken. (authored by allanjude).
ipresend(1): Make the build slightly less broken.
Nov 22 2021, 6:04 PM
allanjude closed D27335: Make ipresend(1) build slightly less broken.
Nov 22 2021, 6:03 PM

Nov 21 2021

allanjude updated the diff for D33071: arm64: Enable SHA256 instruction in the kernel.

Update to fix build error

Nov 21 2021, 5:38 PM
allanjude requested review of D33071: arm64: Enable SHA256 instruction in the kernel.
Nov 21 2021, 4:46 PM

Nov 20 2021

allanjude added a comment to D33061: security/openssl: Fix detection of ARMv7/ARM64 CPU features.

Awaiting comments from upstream before committing. I'm assuming this will be incorporated in next releases too.

Committing version 1.1.1l_1,1 is too beautiful a chance to let is pass me by!

Nov 20 2021, 2:29 PM

Nov 19 2021

allanjude updated the diff for D33060: openssl: Fix detection of ARMv7 and ARM64 CPU features.

Update to the cleaner style patch

Nov 19 2021, 6:43 PM
allanjude requested review of D33062: security/openssl-devel: Fix detection of ARM CPU features.
Nov 19 2021, 6:38 PM
allanjude updated the diff for D33061: security/openssl: Fix detection of ARMv7/ARM64 CPU features.

Update with cleaner patch and add configure scripts to enable armcap.c

Nov 19 2021, 6:36 PM
allanjude retitled D33061: security/openssl: Fix detection of ARMv7/ARM64 CPU features from openssl: Fix detection of ARMv7 and ARM64 CPU features to security/openssl: Fix detection of ARMv7/ARM64 CPU features.
Nov 19 2021, 6:35 PM
allanjude requested review of D33061: security/openssl: Fix detection of ARMv7/ARM64 CPU features.
Nov 19 2021, 3:25 PM
allanjude requested review of D33060: openssl: Fix detection of ARMv7 and ARM64 CPU features.
Nov 19 2021, 3:18 PM

Nov 17 2021

allanjude committed R10:2e946f870558: Fix ZFS module build (authored by allanjude).
Fix ZFS module build
Nov 17 2021, 3:10 PM

Nov 13 2021

allanjude added inline comments to D32979: ps(1): let J flag list all jailed processes.
Nov 13 2021, 12:53 AM

Nov 12 2021

allanjude added inline comments to D32956: rtsol/rtsold: Add option to skip random delay.
Nov 12 2021, 2:15 PM

Nov 9 2021

allanjude added a comment to D28737: stand: Support (and prefer) the SMBIOS 64-bit Entry Point Structure.

Ping - is there any work left to do here or can this be merged and closed?

Nov 9 2021, 2:01 PM

Nov 4 2021

allanjude closed D32775: Allow kern.ipc.maxsockets to be set to current value without error.
Nov 4 2021, 12:57 PM
allanjude committed R10:c441592a0e15: Allow kern.ipc.maxsockets to be set to current value without error (authored by allanjude).
Allow kern.ipc.maxsockets to be set to current value without error
Nov 4 2021, 12:57 PM
allanjude updated the diff for D32775: Allow kern.ipc.maxsockets to be set to current value without error.

Address review feedback from markj

Nov 4 2021, 12:39 AM
allanjude closed D32698: SIFTR: Fix compilation with -DSIFTR_IPV6.
Nov 4 2021, 12:34 AM
allanjude committed R10:34d8fffff313: SIFTR: Fix compilation with -DSIFTR_IPV6 (authored by allanjude).
SIFTR: Fix compilation with -DSIFTR_IPV6
Nov 4 2021, 12:34 AM

Nov 1 2021

allanjude added reviewers for D32775: Allow kern.ipc.maxsockets to be set to current value without error: kevans, markj, rew.
Nov 1 2021, 1:42 PM
allanjude requested review of D32775: Allow kern.ipc.maxsockets to be set to current value without error.
Nov 1 2021, 1:41 PM

Oct 28 2021

allanjude added a reviewer for D32698: SIFTR: Fix compilation with -DSIFTR_IPV6: glebius.
Oct 28 2021, 6:29 PM
allanjude accepted D32707: smbfs: add deprecation notice.

Reviewed by: allanjude

Oct 28 2021, 2:54 PM

Oct 27 2021

allanjude updated the diff for D32698: SIFTR: Fix compilation with -DSIFTR_IPV6.

Update to return PFIL_PASS instead of 0

Oct 27 2021, 9:57 PM
allanjude updated subscribers of D32698: SIFTR: Fix compilation with -DSIFTR_IPV6.
Oct 27 2021, 9:00 PM
allanjude requested review of D32698: SIFTR: Fix compilation with -DSIFTR_IPV6.
Oct 27 2021, 9:00 PM

Oct 26 2021

allanjude updated the summary of D32316: Support of optional PMC classes..
Oct 26 2021, 4:28 PM · pmc

Oct 20 2021

allanjude updated the summary of D32319: System wide and NUMA domain wide counters support. PMC classes for ARM DMC-620 and CMN-600..
Oct 20 2021, 11:40 PM
allanjude updated the summary of D32321: Add support of ARM CMN-600 controller, PMU access functions only. Add support of PMU counters of ARM CMN-600 controller..
Oct 20 2021, 11:39 PM
allanjude updated the summary of D32320: Allocate event for DMC-620 and CMN-600 controllers PMU. Add events supported by DMC-620 and CMN-600 controllers PMU..
Oct 20 2021, 11:39 PM
allanjude updated the summary of D32335: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man page..
Oct 20 2021, 11:39 PM

Sep 28 2021

allanjude accepted D32163: loader: Set twiddle globaldiv to 16 by default.

Reviewed by: allanjude

Sep 28 2021, 6:30 PM

Sep 27 2021

allanjude added a comment to D32163: loader: Set twiddle globaldiv to 16 by default.

2nd the documentation updates required, but I agree this change is a good one.

Sep 27 2021, 11:09 PM

Sep 25 2021

allanjude added a comment to D32130: [WIP] Add more interactive mode to gstat.

Thank you for doing this, it is very helpful.

Sep 25 2021, 12:55 AM

Sep 23 2021

allanjude accepted D32063: man: reset OPTIND after parsing args.
Sep 23 2021, 1:04 PM

Sep 21 2021

allanjude committed R10:ae5a522cae7e: nvmecontrol: Display Metadata and Sanitize capabilities of the device (authored by allanjude).
nvmecontrol: Display Metadata and Sanitize capabilities of the device
Sep 21 2021, 9:16 PM
allanjude closed D31067: nvmecontrol: Display Metadata and Sanitize capabilities of the device.
Sep 21 2021, 9:16 PM

Sep 16 2021

allanjude accepted D31983: bhyve: Support setting the disk serial number for VirtIO block devices..

Reviewed By: allanjude

Sep 16 2021, 6:58 PM