Page MenuHomeFreeBSD

allanjude (Allan Jude)
UserAdministrator

Projects (6)

User Details

User Since
May 19 2014, 3:05 PM (360 w, 2 d)
Roles
Administrator

Recent Activity

Thu, Apr 8

allanjude committed R9:fe42947944f0: Add Klara to the consultants list (authored by allanjude).
Add Klara to the consultants list
Thu, Apr 8, 2:32 PM
allanjude closed D29436: Prune consultants list.
Thu, Apr 8, 2:32 PM
allanjude committed R9:6e0e32a3e5d8: Prune consultants list of inactive entities (authored by allanjude).
Prune consultants list of inactive entities
Thu, Apr 8, 2:32 PM
allanjude added a comment to D29436: Prune consultants list.

am I ok to proceed with this cleanup?

Thu, Apr 8, 1:51 PM

Wed, Apr 7

allanjude committed R10:066a576c5f1b: ipfw: update man page example for nat show log (authored by novel).
ipfw: update man page example for nat show log
Wed, Apr 7, 3:41 PM

Thu, Apr 1

allanjude added inline comments to D29541: DTrace: document the "nolibs" option.
Thu, Apr 1, 8:56 PM · DTrace
allanjude added a comment to D29046: uma: Fall back to other domains even for FIRSTTOUCH.

The case I am thinking of, there are 4 NUMA domains, but memory access is equal cost to all four, so there may be better performance to be had by having the default policy be INTERLEAVE instead of FIRST_TOUCH (use the bandwidth of all 4 memory controllers). So I wasn't thinking to override those that request FIRST_TOUCH, but just set the default policy for zones that don't request a specific policy.

Thu, Apr 1, 8:11 PM
allanjude added a comment to D25601: rc.d/kld: Set sysctls after loading modules..

For modules that have tunables, you need to set them via kenv (or have them set at boot via loader.conf) BEFORE you load the module.

Thu, Apr 1, 7:37 PM
allanjude added a comment to D29046: uma: Fall back to other domains even for FIRSTTOUCH.

Would it make sense to have a tunable to control the default policy for UMA? If I wanted to have zones that don't declare themselves UMA_ZONE_FIRSTTOUCH, but interleaved, or something to that effect?

Thu, Apr 1, 7:29 PM
allanjude added inline comments to D29104: domainset: Define additional global policies.
Thu, Apr 1, 7:26 PM

Mon, Mar 29

allanjude added inline comments to D29436: Prune consultants list.
Mon, Mar 29, 2:06 PM

Fri, Mar 26

allanjude requested review of D29436: Prune consultants list.
Fri, Mar 26, 9:05 PM
allanjude accepted D29101: wait for device mounts in zpool and dumpon.

Reviewed By: allanjude
Approved By: allanjude

Fri, Mar 26, 12:03 AM
allanjude added a reviewer for D29101: wait for device mounts in zpool and dumpon: avg.
Fri, Mar 26, 12:01 AM

Mar 15 2021

allanjude added a comment to P484 update ESP.
In P484#2311, @imp wrote:

cp /boot/boot1.efi /mnt/efi/boot/bootx64.efi

is easier :)

Mar 15 2021, 6:09 PM

Mar 14 2021

allanjude created P488 lockf_linux.c.
Mar 14 2021, 1:54 PM

Mar 11 2021

allanjude updated subscribers of D29212: sh: add the -S flag, to call setsid() when forking subshells.
Mar 11 2021, 12:56 AM
allanjude added a reviewer for D29212: sh: add the -S flag, to call setsid() when forking subshells: dteske.
Mar 11 2021, 12:56 AM
allanjude requested review of D29212: sh: add the -S flag, to call setsid() when forking subshells.
Mar 11 2021, 12:56 AM

Mar 10 2021

allanjude committed R9:734c9f27575b: Make the example URL not a link, since it requires substitutions (authored by allanjude).
Make the example URL not a link, since it requires substitutions
Mar 10 2021, 9:57 PM

Mar 4 2021

allanjude added inline comments to D28834: Wire up OpenZFS with VOP_DEALLOCATE(9).
Mar 4 2021, 4:22 PM

Mar 2 2021

allanjude reopened D27336: Make bsnmpclient(3) thread-safe.
Mar 2 2021, 11:08 PM

Feb 25 2021

allanjude committed R10:1eb60112b22e: Use iflib_if_init_locked() during media change instead of iflib_init_locked(). (authored by allanjude).
Use iflib_if_init_locked() during media change instead of iflib_init_locked().
Feb 25 2021, 8:42 PM
allanjude committed R9:01f6f5280502: Add missing digit to the year of release date for 11.3 (authored by allanjude).
Add missing digit to the year of release date for 11.3
Feb 25 2021, 4:42 PM
allanjude committed R9:a683b52cfb54: Add 12.1 to the EoL list (authored by allanjude).
Add 12.1 to the EoL list
Feb 25 2021, 12:30 AM

Feb 24 2021

allanjude retitled D28740: smbios: Use loader provided address for SMBIOS entry point from smbios: Use loader provided adddress for SMBIOS entry point to smbios: Use loader provided address for SMBIOS entry point.
Feb 24 2021, 2:51 PM
allanjude updated the diff for D28743: ipmi_smbios: Deduplicate smbios entry point discovery logic.

After rebase

Feb 24 2021, 2:51 PM

Feb 23 2021

allanjude added a reverting change for R10:ba6e37e47f41: ipmi_smbios: Deduplicate smbios entry point discovery logic: R10:6d67af5f8e66: Revert "ipmi_smbios: Deduplicate smbios entry point discovery logic".
Feb 23 2021, 10:51 PM
allanjude committed R10:6d67af5f8e66: Revert "ipmi_smbios: Deduplicate smbios entry point discovery logic" (authored by allanjude).
Revert "ipmi_smbios: Deduplicate smbios entry point discovery logic"
Feb 23 2021, 10:51 PM
allanjude added a reverting change for R10:d2589dc3d56c: ipmi_smbios: remove unused smbios_cksum function: R10:4a5dfded17ef: Revert "ipmi_smbios: remove unused smbios_cksum function".
Feb 23 2021, 10:51 PM
allanjude added a reverting change for D28743: ipmi_smbios: Deduplicate smbios entry point discovery logic: R10:6d67af5f8e66: Revert "ipmi_smbios: Deduplicate smbios entry point discovery logic".
Feb 23 2021, 10:51 PM
allanjude added a reverting change for D28751: ipmi_smbios: remove unused smbios_cksum function: R10:4a5dfded17ef: Revert "ipmi_smbios: remove unused smbios_cksum function".
Feb 23 2021, 10:50 PM
allanjude committed R10:4a5dfded17ef: Revert "ipmi_smbios: remove unused smbios_cksum function" (authored by allanjude).
Revert "ipmi_smbios: remove unused smbios_cksum function"
Feb 23 2021, 10:50 PM
allanjude reopened D28743: ipmi_smbios: Deduplicate smbios entry point discovery logic.

I had to revert this, as it depends on https://reviews.freebsd.org/D28739 which isn't ready to land yet

Feb 23 2021, 10:50 PM
allanjude updated the diff for D28737: stand: Support (and prefer) the SMBIOS 64-bit Entry Point Structure.

Fix a typo

Feb 23 2021, 10:24 PM
allanjude updated the diff for D28737: stand: Support (and prefer) the SMBIOS 64-bit Entry Point Structure.

Switch to Scott's newer suggested code that is much cleaner

Feb 23 2021, 9:57 PM
allanjude updated the diff for D28745: ipmi: Add smbus and pci ipmi types to aarch64 builds.

Add the new code to sys/conf/files.arm64 as well, so IPMI works when built into the kernel

Feb 23 2021, 9:38 PM
allanjude retitled D28745: ipmi: Add smbus and pci ipmi types to aarch64 builds from ipmi: Add smbus and pci ipmi types to aarch64 build to ipmi: Add smbus and pci ipmi types to aarch64 builds.
Feb 23 2021, 9:38 PM
allanjude added reviewers for D28739: smbios: Support (and prefer) the SMBIOS 64-bit Entry Point Structure: imp, manu, scottph.
Feb 23 2021, 9:30 PM
allanjude committed R10:d2589dc3d56c: ipmi_smbios: remove unused smbios_cksum function (authored by allanjude).
ipmi_smbios: remove unused smbios_cksum function
Feb 23 2021, 9:25 PM
allanjude closed D28751: ipmi_smbios: remove unused smbios_cksum function.
Feb 23 2021, 9:25 PM
allanjude committed R10:ba6e37e47f41: ipmi_smbios: Deduplicate smbios entry point discovery logic (authored by allanjude).
ipmi_smbios: Deduplicate smbios entry point discovery logic
Feb 23 2021, 9:20 PM
allanjude committed R10:d0673fe160b0: smbios: Move smbios driver out from x86 machdep code (authored by allanjude).
smbios: Move smbios driver out from x86 machdep code
Feb 23 2021, 9:20 PM
allanjude closed D28743: ipmi_smbios: Deduplicate smbios entry point discovery logic.
Feb 23 2021, 9:20 PM
allanjude closed D28738: smbios: Move smbios driver out from x86 machdep code.
Feb 23 2021, 9:20 PM
allanjude closed D28742: iicsmb: Request the bus recursively in bread().
Feb 23 2021, 8:08 PM
allanjude committed R10:11ba8488b863: iicsmb: Request the bus recursively in bread() (authored by allanjude).
iicsmb: Request the bus recursively in bread()
Feb 23 2021, 8:08 PM

Feb 20 2021

allanjude added a comment to D24423: arm/pmu: add ACPI attachment, more FDT names.

I tested this recently on an ARM64 ACPI box, and ran into a panic at boot:

pmu0: <Performance Monitoring Unit> on acpi0
pmu0: MADT: cpu 0 (mpidr 1179648) irq 23 level-triggered
pmu0: MADT: cpu 1 (mpidr 1703936) irq 23 level-triggered
pmu0: MADT: cpu 2 (mpidr 1310720) irq 23 level-triggered
pmu0: MADT: cpu 3 (mpidr 1835008) irq 23 level-triggered
pmu0: MADT: cpu 4 (mpidr 1048576) irq 23 level-triggered
pmu0: MADT: cpu 5 (mpidr 1572864) irq 23 level-triggered
pmu0: MADT: cpu 6 (mpidr 1441792) irq 23 level-triggered
pmu0: MADT: cpu 7 (mpidr 1966080) irq 23 level-triggered
pmu0: MADT: cpu 8 (mpidr 655360) irq 23 level-triggered
pmu0: MADT: cpu 9 (mpidr 2228224) irq 23 level-triggered
pmu0: MADT: cpu 10 (mpidr 786432) irq 23 level-triggered
pmu0: MADT: cpu 11 (mpidr 2359296) irq 23 level-triggered
pmu0: MADT: cpu 12 (mpidr 524288) irq 23 level-triggered
pmu0: MADT: cpu 13 (mpidr 2097152) irq 23 level-triggered
Fatal data abort:
  x0:                0
  x1: ffffa0001d8103a8
  x2:                0
  x3:                a
  x4: ffff000000721fc0
  x5:               10
  x6:                f
  x7:              254
  x8: ffffa0001d80fe00
  x9: ffff000000aad928
 x10:                1
 x11:                0
 x12:                0
 x13:                4
 x14:               80
 x15:                1
 x16:              700
 x17:                3
 x18: ffff000000f277e0
 x19: ffff000000f27870
 x20: ffff0002023fd43c
 x21:                d
 x22: ffffa0001d80fe00
 x23: ffffa0001d80bc00
 x24:               17
 x25: ffff000000823cd6
 x26: ffffa0001d80bb00
 x27: ffffa0001d805af0
 x28:                1
 x29: ffff000000f277f0
  sp: ffff000000f277e0
  lr: ffff000000720860
 elr: ffff000000720888
spsr:         604001c5
 far:                0
 esr:         96000004
panic: vm_fault failed: ffff000000720888
cpuid = 0
time = 1
KDB: stack backtrace:
db_trace_self() at db_trace_self
db_trace_self_wrapper() at db_trace_self_wrapper+0x30
vpanic() at vpanic+0x184
panic() at panic+0x44
data_abort() at data_abort+0x1d8
handle_el1h_sync() at handle_el1h_sync+0x74
--- exception, esr 0x96000004
madt_handler() at madt_handler+0xe8
acpi_walk_subtables() at acpi_walk_subtables+0x3c
pmu_acpi_attach() at pmu_acpi_attach+0x64
device_attach() at device_attach+0x400
bus_generic_new_pass() at bus_generic_new_pass+0x11c
bus_generic_new_pass() at bus_generic_new_pass+0xac
bus_generic_new_pass() at bus_generic_new_pass+0xac
root_bus_configure() at root_bus_configure+0x40
mi_startup() at mi_startup+0x22c
virtdone() at virtdone+0x6c
KDB: enter: panic
[ thread pid 0 tid 100000 ]
Stopped at      kdb_enter+0x40: undefined       d4200000
Feb 20 2021, 4:22 AM · arm64

Feb 19 2021

allanjude created P484 update ESP.
Feb 19 2021, 10:26 PM
allanjude committed R10:57d2eb8896c2: Use iflib_if_init_locked() during media change instead of iflib_init_locked(). (authored by allanjude).
Use iflib_if_init_locked() during media change instead of iflib_init_locked().
Feb 19 2021, 9:07 PM
allanjude committed R10:18f552e647f5: Use iflib_if_init_locked() during media change instead of iflib_init_locked(). (authored by allanjude).
Use iflib_if_init_locked() during media change instead of iflib_init_locked().
Feb 19 2021, 8:44 PM

Feb 18 2021

allanjude added a reviewer for D28748: ig4(4): Use calculated value when sda_hold is zero in ACPI: scottph.
Feb 18 2021, 3:53 PM
allanjude closed D28749: ipmi_ssif: Fix inverted for the end of multi-part reads.
Feb 18 2021, 3:51 PM
allanjude committed R10:8c280db0b4d2: ipmi_ssif: Fix inverted for the end of multi-part reads (authored by allanjude).
ipmi_ssif: Fix inverted for the end of multi-part reads
Feb 18 2021, 3:51 PM
allanjude closed D28747: ig4(4): Increase timeout to about 1 second.
Feb 18 2021, 3:51 PM
allanjude committed R10:37ef8d4cd6b5: ig4(4): Increase timeout to about 1 second (authored by allanjude).
ig4(4): Increase timeout to about 1 second
Feb 18 2021, 3:51 PM
allanjude added a comment to D28738: smbios: Move smbios driver out from x86 machdep code.

If the intention is to support smbios(4) on non-x86, shouldn't it be added to a non-x86 KERNCONF file?

Feb 18 2021, 3:41 PM
allanjude added a comment to D28749: ipmi_ssif: Fix inverted for the end of multi-part reads.

Do we want to put this link and section reference in the commit message?

Feb 18 2021, 1:47 AM

Feb 17 2021

allanjude added a comment to D28749: ipmi_ssif: Fix inverted for the end of multi-part reads.
In D28749#643720, @manu wrote:

Any docs on what this should contain ?

Feb 17 2021, 11:01 PM
allanjude added a reviewer for D28749: ipmi_ssif: Fix inverted for the end of multi-part reads: scottph.
Feb 17 2021, 11:01 PM
allanjude added a comment to D28707: Fix attachment of IPMI driver on ARM64.
In D28707#643461, @imp wrote:

We also have a machine here that won't boot with the patches applied. Please don't commit until that gets worked out....

Feb 17 2021, 10:01 PM
allanjude added a comment to D28738: smbios: Move smbios driver out from x86 machdep code.

Should https://reviews.freebsd.org/D28745 be squashed into this review?

Feb 17 2021, 9:47 PM
allanjude added a comment to D28745: ipmi: Add smbus and pci ipmi types to aarch64 builds.

It likely makes sense to squash this with https://reviews.freebsd.org/D28738

Feb 17 2021, 9:47 PM
allanjude added reviewers for D28747: ig4(4): Increase timeout to about 1 second: manu, scottph, andrew.
Feb 17 2021, 9:45 PM
allanjude added reviewers for D28746: ig4(4): Add an EMAG device type: scottph, imp.
Feb 17 2021, 9:45 PM
allanjude added inline comments to D28746: ig4(4): Add an EMAG device type.
Feb 17 2021, 9:45 PM
allanjude added inline comments to D28741: acpi: Add workaround for Altra I2C memory resource.
Feb 17 2021, 9:44 PM
allanjude added reviewers for D28741: acpi: Add workaround for Altra I2C memory resource: scottph, imp.
Feb 17 2021, 9:43 PM
allanjude added reviewers for D28738: smbios: Move smbios driver out from x86 machdep code: emaste, scottph, mhorne.
Feb 17 2021, 9:41 PM
allanjude added inline comments to D28737: stand: Support (and prefer) the SMBIOS 64-bit Entry Point Structure.
Feb 17 2021, 9:41 PM
allanjude added reviewers for D28737: stand: Support (and prefer) the SMBIOS 64-bit Entry Point Structure: tsoome, manu, andrew, scottph.
Feb 17 2021, 9:39 PM
allanjude added a comment to D28707: Fix attachment of IPMI driver on ARM64.

Ok, I think I've gotten a handle on the git-arc tool.

Feb 17 2021, 9:38 PM
allanjude requested review of D28751: ipmi_smbios: remove unused smbios_cksum function.
Feb 17 2021, 9:36 PM
allanjude requested review of D28750: ipmi: on aarch64, load dependancies to increase chance of finding ipmi device.
Feb 17 2021, 9:35 PM
allanjude requested review of D28749: ipmi_ssif: Fix inverted for the end of multi-part reads.
Feb 17 2021, 9:35 PM
allanjude requested review of D28748: ig4(4): Use calculated value when sda_hold is zero in ACPI.
Feb 17 2021, 9:35 PM
allanjude requested review of D28747: ig4(4): Increase timeout to about 1 second.
Feb 17 2021, 9:35 PM
allanjude requested review of D28746: ig4(4): Add an EMAG device type.
Feb 17 2021, 9:35 PM
allanjude requested review of D28745: ipmi: Add smbus and pci ipmi types to aarch64 builds.
Feb 17 2021, 9:35 PM
allanjude requested review of D28744: Enable smbios in ARM64 GENERIC.
Feb 17 2021, 9:35 PM
allanjude added a comment to D28707: Fix attachment of IPMI driver on ARM64.

No, having only one loop that set both kenv is what we need.

Feb 17 2021, 9:35 PM
allanjude requested review of D28743: ipmi_smbios: Deduplicate smbios entry point discovery logic.
Feb 17 2021, 9:35 PM
allanjude requested review of D28742: iicsmb: Request the bus recursively in bread().
Feb 17 2021, 9:35 PM
allanjude requested review of D28741: acpi: Add workaround for Altra I2C memory resource.
Feb 17 2021, 9:35 PM
allanjude requested review of D28739: smbios: Support (and prefer) the SMBIOS 64-bit Entry Point Structure.
Feb 17 2021, 9:35 PM
allanjude requested review of D28740: smbios: Use loader provided address for SMBIOS entry point.
Feb 17 2021, 9:35 PM
allanjude requested review of D28738: smbios: Move smbios driver out from x86 machdep code.
Feb 17 2021, 9:35 PM
allanjude requested review of D28737: stand: Support (and prefer) the SMBIOS 64-bit Entry Point Structure.
Feb 17 2021, 9:35 PM
allanjude added a comment to D28707: Fix attachment of IPMI driver on ARM64.

@allanjude these originated as a number of commits, right? Does it make sense to start committing earlier patches that have been reviewed (e.g. stand bits) and rebase this review?

Feb 17 2021, 9:00 PM
allanjude added a comment to D28707: Fix attachment of IPMI driver on ARM64.
In D28707#643382, @manu wrote:
In D28707#643373, @manu wrote:

stand patches can't go in without the kernel ones.
If we find a smbios v3 table we don't set the kenv of the v2.1 one so kernel won't work.

Ou, but that would be major pain - it would be bad day for anyone trying to boot older kernel... so we should provide both to let older kernel to work?

Yeah I think so, I think we should just export every smbios table in loader and let kernel choose.

Feb 17 2021, 8:59 PM

Feb 16 2021

allanjude updated the diff for D28707: Fix attachment of IPMI driver on ARM64.

Repost

Feb 16 2021, 10:36 PM
allanjude added inline comments to D28707: Fix attachment of IPMI driver on ARM64.
Feb 16 2021, 10:35 PM
allanjude updated the diff for D28707: Fix attachment of IPMI driver on ARM64.
  • stand: Support (and prefer) the SMBIOS 64-bit Entry Point Structure
  • smbios: Move smbios driver out from x86 machdep code
  • smbios: Support (and prefer) the SMBIOS 64-bit Entry Point Structure
  • smbios: Use loader provided adddress for SMBIOS entry point
  • acpi: Add workaround for Altra I2C memory resource
  • iicsmb: Request the bus recursively in bread()
  • ipmi_smbios: Deduplicate smbios entry point discovery logic
  • Enable smbios in ARM64 GENERIC
  • ipmi: Add smbus and pci ipmi types to aarch64 build
  • ig4(4): Add an EMAG device type
  • ig4(4): Increase timeout to about 1 second
  • ig4(4): Use calculated value when sda_hold is zero in ACPI
  • ipmi_ssif: Fix inverted for the end of multi-part reads
  • smbios: update makefile for new location of smbios.c
  • ipmi: on aarch64, load dependancies to increase chance of finding ipmi device
  • ipmi_smbios: remove unused smbios_cksum function
  • [squashme] Address feedback from manu and andrew
Feb 16 2021, 10:33 PM
allanjude closed D28667: Use iflib_if_init_locked() during media change instead of iflib_init_locked()..
Feb 16 2021, 7:03 PM
allanjude committed R10:922cf8ac43ad: Use iflib_if_init_locked() during media change instead of iflib_init_locked(). (authored by allanjude).
Use iflib_if_init_locked() during media change instead of iflib_init_locked().
Feb 16 2021, 7:02 PM
allanjude added inline comments to D28707: Fix attachment of IPMI driver on ARM64.
Feb 16 2021, 6:33 PM
allanjude added a reviewer for D28707: Fix attachment of IPMI driver on ARM64: gallatin.
Feb 16 2021, 5:07 PM
allanjude requested review of D28707: Fix attachment of IPMI driver on ARM64.
Feb 16 2021, 5:06 PM
allanjude updated subscribers of D27813: camcontrol: stop pretending cam_cmd is a bitmask.
Feb 16 2021, 4:12 PM

Feb 14 2021

allanjude committed R9:873687264f6c: The RSS feed for news was missing the # in the URL, resulting in 404s (authored by allanjude).
The RSS feed for news was missing the # in the URL, resulting in 404s
Feb 14 2021, 7:00 PM