User Details
- User Since
- Jan 8 2018, 10:05 PM (370 w, 4 d)
Oct 23 2024
Oct 18 2024
Update diff with -U99999
Implemented all PR changes
Implemented all changes save for pulling thread safety into step4
implemented all PR changes
All changes minus L771 one
Oct 17 2024
We shouldn't need it. The only consumer of this function is __ns_mp_cache_read in nscache.clli.
Line 296 we loop until res != -2 (which is an internal state). so when we leave that loop we know we're in some kind of terminal protocol state.
Oct 16 2024
rebasing with minor additional changes before I begin the work to split this up
Oct 13 2024
Interim PR changes while I work on splitting this up to different sub PRs. Don't want my work lost
Sep 21 2024
Possible to get some eyes on this and see if we can get this across?
With many apologies for the delay, this is now sent.
Sep 8 2024
Aug 24 2024
How should I submit this to you for the path; I have never used git format-patch before; I tried doing git format-patch main and it generated 21 files (since I have 21 commits). Manpage suggests I email this to you? But it seems rude to just blast you with 21 patches; and I don't know your email.
Updated with last PR fixes
Aug 16 2024
Is there anything I can do here?
Aug 15 2024
Rebase and remove unnecessary () in an if check (per review comment)
Aug 14 2024
Updated to remove the extra newline
Aug 13 2024
Should note I just got done testing this with a clean 14.1 src tree that I applied the git diff to with no other changes; tested sha256 password and sha512 password, additionally un-commented both test vector suites and all passed.
Updated the diff per requested copyright changes.
Aug 12 2024
Synced with latest freebsd/main for diff generation, no other changes
As promised, updated, including modifications to export sha512 from C, updated lua crypt implementation to use exported C routines, removed the now unneeded pure lua implementation, I ran all validation suites on my computer and this is passing.
Aug 11 2024
Aug 9 2024
Aug 6 2024
I can work on that and validate it; checking quickly it looks like the version exported is compatible (the big issue with other implementations was being given the binary form of the hash to work with, your export seems to do that).
Jul 13 2024
Previous version did have one compile error (missing ;) in the file I warned I had not tested; also updated usage to match man pages
May 10 2024
updated diff -U 99999
Updated diff -U99999
May 9 2024
Updated with PR comments
May 2 2024
Updated for -U99999 as requested.
Could this be imported as is, and then when the hash modules are in and exported it could be switched over?
I believe I have addressed all of reviews; it would be great to get this in for 14.1 so I don't keep having to patch my local copies
Apr 18 2024
Updated with all PR comments, save 1.
Aug 26 2023
- Updated documentation
- refactored tests to make them easier to add to.
Updated diff with all comments addressed, specifically:
- hashes.lua removed and moved into crypt.lua with no reexport
- tests refactored
- tests for NIST vectors for SHA256/512 added (and verified)
- added "crypt:" prefix on password
Aug 23 2023
Thinking about this, I can make a couple of changes that could make this more palatable:
Aug 20 2023
These have existed for decades and pretty much every boot loader and every link in the booting process has optional passwords in place as a check against random people interfering with the boot process. BIOS has it, openboot has it, grub has it.
Uncomfortable how? This is a very straightforward implementation of SHA256/SHA512 modeled after existing LUA SHA2 libraries. I only reimplemented because:
- existing ones were based on lua <5.4 and relied on the bit32 library which is not in LUA54
- were vastly overcomplicated and not BSD licensed (ones that worked on every version of LUA and included multiple different sub-implementations optimized for a vast number of possible LUA configurations.)
- were incapable of being used in this context (they would return hex encoded values, where the crypt(3) algorithms require the raw binary to feed into subsequent stages
Aug 19 2023
Aug 4 2023
Cleaned up erroneous patches due to my tree being out of date with target.
Ran entire kyua test suite as follows:
Updates from code review