Page MenuHomeFreeBSD

dsl (Dmitry Salychev)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 1 2020, 1:24 PM (181 w, 1 d)

Recent Activity

Mar 17 2024

dsl committed rG65eb09f9d550: Add myself (dsl) to the calendar.freebsd (authored by dsl).
Add myself (dsl) to the calendar.freebsd
Mar 17 2024, 10:12 AM

Feb 22 2024

dsl accepted D43937: dpaa2: Use bus_generic_rman_*.

Compiled, booted and tested under load for several hours out of curiosity. Looks good to me.

Feb 22 2024, 9:28 PM
dsl added a reviewer for D43937: dpaa2: Use bus_generic_rman_*: dsl.
Feb 22 2024, 9:26 PM

Nov 17 2023

dsl accepted D42644: dpaa2: fdt improve detection.
Nov 17 2023, 9:37 AM
dsl accepted D42643: dpaa2: defer link_state updates until we are up.
Nov 17 2023, 8:28 AM
dsl accepted D42645: dpaa2: make VLANs usable on dpni.
Nov 17 2023, 8:12 AM

Sep 19 2023

dsl added a comment to D41563: sff: Improve names and error messages.

@jrtc27 @bz Any comments?

Sep 19 2023, 10:40 AM

Sep 9 2023

dsl added a comment to D41563: sff: Improve names and error messages.

re-based and updated according to the comment

Sep 9 2023, 2:14 PM
dsl updated the diff for D41563: sff: Improve names and error messages.
Sep 9 2023, 2:13 PM

Aug 25 2023

dsl updated the diff for D41563: sff: Improve names and error messages.

Added a comment about "mod_abs"

Aug 25 2023, 10:28 PM

Aug 24 2023

dsl added a comment to D41563: sff: Improve names and error messages.

@jrtc27 Could you comment or accept it if everything's according to your expectation?

Aug 24 2023, 7:59 AM

Aug 23 2023

dsl requested review of D41563: sff: Improve names and error messages.
Aug 23 2023, 12:29 PM

Aug 20 2023

dsl committed rG58983e4b0253: dpaa2: Clean up channels in separate tasks (authored by dsl).
dpaa2: Clean up channels in separate tasks
Aug 20 2023, 8:18 AM
dsl closed D41296: dpaa2: Clean up channels in separate tasks.
Aug 20 2023, 8:18 AM

Aug 18 2023

dsl updated the diff for D41296: dpaa2: Clean up channels in separate tasks.

Re-based on the latest main.

Aug 18 2023, 2:53 PM
dsl added a comment to D41296: dpaa2: Clean up channels in separate tasks.

@bz I'm not exactly sure why phabricator shows diffs this way, but I don't see those lines changed between main and dpaa2 branches: https://github.com/freebsd/freebsd-src/compare/main...mcusim:freebsd-src:dpaa2

Aug 18 2023, 11:08 AM
dsl closed D41440: sff: Add SFP driver (fdt-based draft).
Aug 18 2023, 10:41 AM
dsl committed rG2a9021898c4e: sff: Add SFP driver (fdt-based draft) (authored by dsl).
sff: Add SFP driver (fdt-based draft)
Aug 18 2023, 10:41 AM

Aug 17 2023

dsl added a comment to D41296: dpaa2: Clean up channels in separate tasks.

Commit message has been updated and $FreeBSD$ removed from new files only.

Aug 17 2023, 8:46 PM
dsl updated the diff for D41296: dpaa2: Clean up channels in separate tasks.
Aug 17 2023, 8:45 PM

Aug 16 2023

dsl updated the diff for D41440: sff: Add SFP driver (fdt-based draft).

$FreeBSD$ removed

Aug 16 2023, 9:08 PM
dsl added inline comments to D41296: dpaa2: Clean up channels in separate tasks.
Aug 16 2023, 9:27 AM

Aug 15 2023

dsl updated the diff for D41440: sff: Add SFP driver (fdt-based draft).
Aug 15 2023, 12:07 PM

Aug 14 2023

dsl added a comment to D41440: sff: Add SFP driver (fdt-based draft).

I somehow missed this interface sorry ...

Aug 14 2023, 12:44 PM
dsl added a comment to D41440: sff: Add SFP driver (fdt-based draft).

@manu, I'll need the only method in sff_if.m for now to implement SIOCGI2C in dpaa2_ni.c. I haven't ever worked with SFF/SFP modules and not sure what registers in their EEPROM or GPIO pins have to be tinkered with in order to let them start properly. This is the reason for such a draft instead of a fully fledged driver.

Aug 14 2023, 11:36 AM
dsl updated the diff for D41440: sff: Add SFP driver (fdt-based draft).
Aug 14 2023, 11:31 AM

Aug 13 2023

dsl requested review of D41440: sff: Add SFP driver (fdt-based draft).
Aug 13 2023, 10:46 AM

Aug 12 2023

dsl added a comment to D41296: dpaa2: Clean up channels in separate tasks.

Commit message's updated.

Aug 12 2023, 10:24 AM
dsl updated the diff for D41296: dpaa2: Clean up channels in separate tasks.
Aug 12 2023, 10:07 AM

Aug 10 2023

dsl added inline comments to D41296: dpaa2: Clean up channels in separate tasks.
Aug 10 2023, 10:20 AM
dsl added inline comments to D41296: dpaa2: Clean up channels in separate tasks.
Aug 10 2023, 9:23 AM
dsl updated the diff for D41296: dpaa2: Clean up channels in separate tasks.
Aug 10 2023, 9:21 AM

Aug 7 2023

dsl added inline comments to D41296: dpaa2: Clean up channels in separate tasks.
Aug 7 2023, 10:15 AM
dsl added a comment to D41296: dpaa2: Clean up channels in separate tasks.

In theory this should be broken up into multiple commits: first move the code as is into extra files (no functional changes), then reduce code duplication etc, then rename variables etc without other functional changes, ... a dedicated cleanup change, ... I know this is hard and a lot of extra work. Please try to get to that in the future. It helps a lot with review, keeping functional changes smaller, also when going back in history and looking at a change again or when bisecting for other reasons.

Aug 7 2023, 9:39 AM

Aug 3 2023

dsl requested review of D41296: dpaa2: Clean up channels in separate tasks.
Aug 3 2023, 1:55 PM

May 11 2023

dsl committed rG718bdb6a71ba: dpaa2: Simplify addresses translation with PHYS_TO_DMAP (authored by dsl).
dpaa2: Simplify addresses translation with PHYS_TO_DMAP
May 11 2023, 3:47 PM
dsl closed D39946: dpaa2: Simplify addresses translation with PHYS_TO_DMAP.
May 11 2023, 3:46 PM
dsl added a comment to D39946: dpaa2: Simplify addresses translation with PHYS_TO_DMAP.

@bz, Can I commit?

May 11 2023, 9:33 AM

May 9 2023

dsl updated the diff for D39946: dpaa2: Simplify addresses translation with PHYS_TO_DMAP.

I've replaced anonymous enum with macro definitions for sizes.

May 9 2023, 10:32 AM
dsl added inline comments to D39946: dpaa2: Simplify addresses translation with PHYS_TO_DMAP.
May 9 2023, 8:37 AM

May 8 2023

dsl updated the diff for D39946: dpaa2: Simplify addresses translation with PHYS_TO_DMAP.

I've added CTASSERT checks to all of the types which sizes are fixed or shouldn't exceed limits enforced by DPAA2 firmware.

May 8 2023, 11:28 AM
dsl added inline comments to D39946: dpaa2: Simplify addresses translation with PHYS_TO_DMAP.
May 8 2023, 11:14 AM

May 3 2023

dsl updated the diff for D39946: dpaa2: Simplify addresses translation with PHYS_TO_DMAP.

I've removed a [DMAP_MIN_PHYSADDR,DMAP_MAX_PHYSADDR] range limit for DMA tags as @mhorne explained. Initially, I thought that it's a requirement to calculate KVA by PHYS_TO_DMAP properly.

May 3 2023, 10:32 AM
dsl requested review of D39946: dpaa2: Simplify addresses translation with PHYS_TO_DMAP.
May 3 2023, 10:25 AM

Apr 20 2023

dsl added a comment to D38592: dpaa2: add console support for FDT based systems.

No further comments. I didn't realize I can accept it :)

Apr 20 2023, 3:37 PM
dsl accepted D38592: dpaa2: add console support for FDT based systems.
Apr 20 2023, 3:37 PM

Apr 19 2023

dsl closed D39509: dpaa2: Avoid dpaa2_cmd race conditions.
Apr 19 2023, 3:51 PM
dsl committed rG4cd966142822: dpaa2: Avoid dpaa2_cmd race conditions (authored by dsl).
dpaa2: Avoid dpaa2_cmd race conditions
Apr 19 2023, 3:51 PM

Apr 13 2023

dsl updated the diff for D39509: dpaa2: Avoid dpaa2_cmd race conditions.
Apr 13 2023, 4:15 PM
dsl updated the diff for D39509: dpaa2: Avoid dpaa2_cmd race conditions.

diff has been updated to provide full context.

Apr 13 2023, 4:13 PM

Apr 12 2023

dsl added a comment to D38592: dpaa2: add console support for FDT based systems.

May we have it committed?

Apr 12 2023, 12:09 PM

Apr 11 2023

dsl requested review of D39509: dpaa2: Avoid dpaa2_cmd race conditions.
Apr 11 2023, 5:30 PM

Feb 20 2023

dsl added a comment to D38594: dpaa2: fiken token for open commands and wait for our command.

How often do you OPEN objects?

You're taking current implementation into account only when I re-used dpaa2_cmd extensively without proper locking though. I'm working on a patch to allocate dpaa2_cmd on stack and initialize them ad-hoc. We won't need to lock them, but DPAA2 objects themselves will be opened/closed more frequently.

Feb 20 2023, 7:14 PM

Feb 15 2023

dsl added a comment to D38592: dpaa2: add console support for FDT based systems.

Overall changes look good to me.

Feb 15 2023, 10:20 PM
dsl added a comment to D38594: dpaa2: fiken token for open commands and wait for our command.

My understanding is that re-setting the command token to zero explicitly isn't what MC expects in most operations (except xxx_CREATE ones when token = 0 means that a newly created object will be assigned to the resource container that hosts the MC command portal currently executing the command), i.e. when you're going to open an object (DPNI, DPMAC, etc.) within a resource container, you must supply an authentication token obtained previously when the resource container was opened.

Feb 15 2023, 10:12 PM
dsl added inline comments to D38592: dpaa2: add console support for FDT based systems.
Feb 15 2023, 2:29 PM

Feb 14 2023

dsl added inline comments to D38592: dpaa2: add console support for FDT based systems.
Feb 14 2023, 8:12 PM

Jan 22 2023

dsl committed rGd5a64a935bc9: Add initial DPAA2 support (authored by dsl).
Add initial DPAA2 support
Jan 22 2023, 2:09 PM

Oct 14 2022

dsl closed D36638: Initial DPAA2 support.
Oct 14 2022, 8:53 PM · arm64
dsl committed rGba7319e9091b: Add initial DPAA2 support (authored by dsl).
Add initial DPAA2 support
Oct 14 2022, 8:53 PM

Oct 13 2022

dsl updated the diff for D36638: Initial DPAA2 support.
  • dpaa2_mc.c patched to fix LINT-FDT build (discovered and fixed by @bz, thanks!);
  • copyrights of dpaa2_ni_dpkg.h and dpaa2_swc.c updated to include copyright notices from the original files together with the updated SPDX license identifiers.
Oct 13 2022, 7:32 PM · arm64

Oct 11 2022

dsl updated the diff for D36638: Initial DPAA2 support.

Whitespace changes in sys/arm64/conf/std.nxp removed

Oct 11 2022, 9:00 AM · arm64

Oct 10 2022

dsl updated the diff for D36638: Initial DPAA2 support.
  • DPAA2 files were placed between dev/cpufreq and dev/dwc in sys/conf/files.arm64;
  • Copyrights were added to sys/dev/dpaa2/dpaa2_ni_dpkg.h (drivers/net/ethernet/freescale/dpaa2/dpkg.h) and sys/dev/dpaa2/dpaa2_swp.c (drivers/soc/fsl/dpio/qbman-portal.c) as their significant parts were copy-pasted from the Linux drivers.
Oct 10 2022, 8:37 AM · arm64
dsl added inline comments to D36638: Initial DPAA2 support.
Oct 10 2022, 7:08 AM · arm64

Oct 6 2022

dsl updated the diff for D36638: Initial DPAA2 support.

SOC_NXP_LS to lower case

Oct 6 2022, 4:06 PM · arm64
dsl abandoned D36677: Add an ability to read PACKAGE and LOCAL_REFERENCE properties.

Closed in favor of https://reviews.freebsd.org/D36793

Oct 6 2022, 7:02 AM

Oct 5 2022

dsl updated the diff for D36638: Initial DPAA2 support.

Obtain DEVICE_PROP_HANDLE properties using new API (as @bz suggested in https://reviews.freebsd.org/D36793#837246)

Oct 5 2022, 7:48 PM · arm64

Oct 4 2022

dsl added a comment to D36793: device_get_property: add a HANDLE case.

@mw, this diff is supposed to substitute some pieces from sys/dev/dpaa2/dpaa2_mc_fdt.c and sys/dev/dpaa2/dpaa2_mc_acpi.c (https://reviews.freebsd.org/D36638):

Oct 4 2022, 6:52 AM

Sep 30 2022

dsl added inline comments to D36638: Initial DPAA2 support.
Sep 30 2022, 6:43 AM · arm64
dsl updated the diff for D36638: Initial DPAA2 support.
  • memac bits are re-worked by @bz to separate FDT/ACPI parts into the different drivers (thanks!);
  • frame queues aren't blocked anymore on Rx now (not necessary due to the QBMan's processing of the Volatile Dequeue commands where frames are pulled from the only frame queue in response to the command; it fixes LOR reported by @bz as well)
Sep 30 2022, 6:41 AM · arm64

Sep 25 2022

dsl added a comment to D36677: Add an ability to read PACKAGE and LOCAL_REFERENCE properties.

OK, I'll make a note for myself. Thanks for a suggestion!

Sep 25 2022, 4:15 PM

Sep 23 2022

dsl updated the test plan for D36638: Initial DPAA2 support.
Sep 23 2022, 7:58 AM · arm64
dsl updated the test plan for D36638: Initial DPAA2 support.
Sep 23 2022, 7:56 AM · arm64
dsl added a comment to D36638: Initial DPAA2 support.

Review for ACPI changes: https://reviews.freebsd.org/D36677

Sep 23 2022, 7:45 AM · arm64
dsl requested review of D36677: Add an ability to read PACKAGE and LOCAL_REFERENCE properties.
Sep 23 2022, 7:44 AM

Sep 22 2022

dsl added inline comments to D36638: Initial DPAA2 support.
Sep 22 2022, 7:35 AM · arm64

Sep 21 2022

dsl updated the diff for D36638: Initial DPAA2 support.

_STANDALONE test removed

Sep 21 2022, 4:53 PM · arm64
dsl added inline comments to D36638: Initial DPAA2 support.
Sep 21 2022, 4:44 PM · arm64
dsl updated the diff for D36638: Initial DPAA2 support.

cosmetic changes, alphabetical re-ordering and ACPI changes removed (to be reviewed separately)

Sep 21 2022, 4:19 PM · arm64

Sep 20 2022

dsl added a comment to D36638: Initial DPAA2 support.
In D36638#831758, @manu wrote:

I'm using it for a few months now on my Honeycomb and it works great, never had any issue.
Reviewing all that is a bit too big for me but you can at least add me as a Tested by: entry :)

Thanks a lot for working on this.

Sep 20 2022, 3:52 PM · arm64
dsl updated the summary of D36638: Initial DPAA2 support.
Sep 20 2022, 3:30 PM · arm64
dsl requested review of D36638: Initial DPAA2 support.
Sep 20 2022, 3:29 PM · arm64

Aug 22 2022

dsl committed rGa070c11afe59: Add dsl to the src committers and bz as my mentor (authored by dsl).
Add dsl to the src committers and bz as my mentor
Aug 22 2022, 2:00 PM
dsl closed D36276: Add dsl to the src committers and bz as my mentor.
Aug 22 2022, 2:00 PM

Aug 21 2022

dsl updated the diff for D36276: Add dsl to the src committers and bz as my mentor.

I've provided an actual diff revision URL and removed [PATCH] prefix from the commit message.

Aug 21 2022, 6:06 PM
dsl requested review of D36276: Add dsl to the src committers and bz as my mentor.
Aug 21 2022, 6:00 PM

Aug 9 2022

dsl added a watcher for linuxkpi: dsl.
Aug 9 2022, 7:49 PM

Jul 23 2022

bofh renamed dsl from dsl_mcusim.org to dsl.
Jul 23 2022, 2:41 AM

Jul 22 2022

dsl closed D35850: New committer (src): Dmitry Salychev (steps 1-4).
Jul 22 2022, 6:31 PM
dsl committed R9:79736c49a490: Add records about new src committer (dsl) (authored by dsl).
Add records about new src committer (dsl)
Jul 22 2022, 6:31 PM

Jul 19 2022

dsl requested review of D35850: New committer (src): Dmitry Salychev (steps 1-4).
Jul 19 2022, 3:54 PM

Dec 26 2021

dsl added a comment to D33417: Do not call iommu_map_msi when ctx is NULL.

I've just got a kernel panic at the same place with IOMMU enabled and DPAA2 driver WIP on Honeycomb board.

Dec 26 2021, 9:48 PM

Aug 1 2021

dsl updated the diff for D31267: Parse named nodes from IORT ACPI on arm64.

outid will be written in case of a non-null output node found only. This is how iort_pci_rc_map() used to work and I don't want my patch to change this behavior.

Aug 1 2021, 5:27 PM
dsl updated the diff for D31267: Parse named nodes from IORT ACPI on arm64.

Shared parts of the iort_pci_rc_map() and iort_named_comp_map() were extracted into a separate iort_smmu_trymap() function.

Aug 1 2021, 4:43 PM

Jul 27 2021

dsl added a comment to D31267: Parse named nodes from IORT ACPI on arm64.

@andrew It definitely won't be, but I wanted to have a separate function for named components from IORT table similar to one for PCI RC nodes. I'll probably extract the same parts of the both functions into a separate one.

Jul 27 2021, 9:07 AM
dsl added a comment to D31267: Parse named nodes from IORT ACPI on arm64.

You won't see "MSI allocated" in dmesg if you clone the repository or pull the latest changes now. Please, ping me and I'll explain how to test this patch.

Jul 27 2021, 8:29 AM

Jul 22 2021

dsl requested review of D31267: Parse named nodes from IORT ACPI on arm64.
Jul 22 2021, 9:05 AM

Dec 2 2020

dsl added a comment to D27422: Add support of UART_DEV_DBGPORT to uart_bus_fdt.c.

@mhorne, @andrew, thanks for help here :)

Dec 2 2020, 4:59 PM
dsl added a comment to D27422: Add support of UART_DEV_DBGPORT to uart_bus_fdt.c.

@mhorne Should I update a patch attached to the PR also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251053 ?

Dec 2 2020, 4:45 PM
dsl updated the diff for D27422: Add support of UART_DEV_DBGPORT to uart_bus_fdt.c.

Unnecessary tests of the devtype argument have been removed from uart_cpu_getdev() in sys/dev/uart/uart_cpu_arm64.c and sys/dev/uart/uart_cpu_fdt.c. uart_cpu_fdt_probe() checks for console types it supports.

Dec 2 2020, 11:04 AM