User Details
- User Since
- Nov 1 2020, 1:24 PM (213 w, 4 d)
Tue, Nov 19
Mon, Nov 18
Nov 2 2024
Nov 1 2024
Oct 14 2024
LGTM, but why "half-working"? Is there BFP_MTAP on Rx somewhere?
Oct 12 2024
LGTM, thanks @bz
Jun 3 2024
May 22 2024
@jhb yes, of course.
May 21 2024
Mar 17 2024
Feb 22 2024
Compiled, booted and tested under load for several hours out of curiosity. Looks good to me.
Nov 17 2023
Sep 19 2023
Sep 9 2023
re-based and updated according to the comment
Aug 25 2023
Added a comment about "mod_abs"
Aug 24 2023
@jrtc27 Could you comment or accept it if everything's according to your expectation?
Aug 23 2023
Aug 20 2023
Aug 18 2023
Re-based on the latest main.
@bz I'm not exactly sure why phabricator shows diffs this way, but I don't see those lines changed between main and dpaa2 branches: https://github.com/freebsd/freebsd-src/compare/main...mcusim:freebsd-src:dpaa2
Aug 17 2023
Commit message has been updated and $FreeBSD$ removed from new files only.
Aug 16 2023
$FreeBSD$ removed
Aug 15 2023
Aug 14 2023
I somehow missed this interface sorry ...
@manu, I'll need the only method in sff_if.m for now to implement SIOCGI2C in dpaa2_ni.c. I haven't ever worked with SFF/SFP modules and not sure what registers in their EEPROM or GPIO pins have to be tinkered with in order to let them start properly. This is the reason for such a draft instead of a fully fledged driver.
Aug 13 2023
Aug 12 2023
Commit message's updated.
Aug 10 2023
Aug 7 2023
In theory this should be broken up into multiple commits: first move the code as is into extra files (no functional changes), then reduce code duplication etc, then rename variables etc without other functional changes, ... a dedicated cleanup change, ... I know this is hard and a lot of extra work. Please try to get to that in the future. It helps a lot with review, keeping functional changes smaller, also when going back in history and looking at a change again or when bisecting for other reasons.
Aug 3 2023
May 11 2023
@bz, Can I commit?
May 9 2023
I've replaced anonymous enum with macro definitions for sizes.
May 8 2023
I've added CTASSERT checks to all of the types which sizes are fixed or shouldn't exceed limits enforced by DPAA2 firmware.
May 3 2023
I've removed a [DMAP_MIN_PHYSADDR,DMAP_MAX_PHYSADDR] range limit for DMA tags as @mhorne explained. Initially, I thought that it's a requirement to calculate KVA by PHYS_TO_DMAP properly.
Apr 20 2023
No further comments. I didn't realize I can accept it :)
Apr 19 2023
Apr 13 2023
diff has been updated to provide full context.
Apr 12 2023
May we have it committed?
Apr 11 2023
Feb 20 2023
How often do you OPEN objects?
You're taking current implementation into account only when I re-used dpaa2_cmd extensively without proper locking though. I'm working on a patch to allocate dpaa2_cmd on stack and initialize them ad-hoc. We won't need to lock them, but DPAA2 objects themselves will be opened/closed more frequently.
Feb 15 2023
Overall changes look good to me.
My understanding is that re-setting the command token to zero explicitly isn't what MC expects in most operations (except xxx_CREATE ones when token = 0 means that a newly created object will be assigned to the resource container that hosts the MC command portal currently executing the command), i.e. when you're going to open an object (DPNI, DPMAC, etc.) within a resource container, you must supply an authentication token obtained previously when the resource container was opened.
Feb 14 2023
Jan 22 2023
Oct 14 2022
Oct 13 2022
- dpaa2_mc.c patched to fix LINT-FDT build (discovered and fixed by @bz, thanks!);
- copyrights of dpaa2_ni_dpkg.h and dpaa2_swc.c updated to include copyright notices from the original files together with the updated SPDX license identifiers.
Oct 11 2022
Whitespace changes in sys/arm64/conf/std.nxp removed
Oct 10 2022
- DPAA2 files were placed between dev/cpufreq and dev/dwc in sys/conf/files.arm64;
- Copyrights were added to sys/dev/dpaa2/dpaa2_ni_dpkg.h (drivers/net/ethernet/freescale/dpaa2/dpkg.h) and sys/dev/dpaa2/dpaa2_swp.c (drivers/soc/fsl/dpio/qbman-portal.c) as their significant parts were copy-pasted from the Linux drivers.
Oct 6 2022
SOC_NXP_LS to lower case
Closed in favor of https://reviews.freebsd.org/D36793
Oct 5 2022
Obtain DEVICE_PROP_HANDLE properties using new API (as @bz suggested in https://reviews.freebsd.org/D36793#837246)
Oct 4 2022
@mw, this diff is supposed to substitute some pieces from sys/dev/dpaa2/dpaa2_mc_fdt.c and sys/dev/dpaa2/dpaa2_mc_acpi.c (https://reviews.freebsd.org/D36638):
Sep 30 2022
- memac bits are re-worked by @bz to separate FDT/ACPI parts into the different drivers (thanks!);
- frame queues aren't blocked anymore on Rx now (not necessary due to the QBMan's processing of the Volatile Dequeue commands where frames are pulled from the only frame queue in response to the command; it fixes LOR reported by @bz as well)
Sep 25 2022
OK, I'll make a note for myself. Thanks for a suggestion!
Sep 23 2022
Review for ACPI changes: https://reviews.freebsd.org/D36677
Sep 22 2022
Sep 21 2022
_STANDALONE test removed
cosmetic changes, alphabetical re-ordering and ACPI changes removed (to be reviewed separately)
Sep 20 2022
Aug 22 2022
Aug 21 2022
I've provided an actual diff revision URL and removed [PATCH] prefix from the commit message.