Page MenuHomeFreeBSD

Add an ability to read PACKAGE and LOCAL_REFERENCE properties
AbandonedPublic

Authored by dsl on Sep 23 2022, 7:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 3, 5:26 PM
Unknown Object (File)
Fri, May 31, 1:17 PM
Unknown Object (File)
May 7 2024, 10:40 PM
Unknown Object (File)
May 7 2024, 10:40 PM
Unknown Object (File)
Apr 22 2024, 6:31 PM
Unknown Object (File)
Apr 20 2024, 8:33 AM
Unknown Object (File)
Dec 31 2023, 12:07 AM
Unknown Object (File)
Dec 23 2023, 1:07 AM
Subscribers

Details

Reviewers
bz
andrew
jhb
jkim
Summary

(ACPI changes from https://reviews.freebsd.org/D36638 were extracted to be reviewed separately)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dsl requested review of this revision.Sep 23 2022, 7:44 AM

Adding mw and kd as well given they have done the abstractions earlier this year and may have an interest.

sys/dev/acpica/acpi.c
147

Unneeded whitespace change probably being my fault from earlier edits. Can you re-adjust that please so it's out of the diff?

1976

I still don't know how really; I'd be open to suggestions but otherwise it works for now.

Hi @dsl,

On the occasion, it would be great to extend device_get_property or add a new routine (e.g. device_get_reference) for obtaining phandles in a unified way. That would allow minimizing the code related to HW description in https://reviews.freebsd.org/D36638 (and some future code I'm working on :) ).

In D36677#833135, @mw wrote:

Hi @dsl,

On the occasion, it would be great to extend device_get_property or add a new routine (e.g. device_get_reference) for obtaining phandles in a unified way. That would allow minimizing the code related to HW description in https://reviews.freebsd.org/D36638 (and some future code I'm working on :) ).

@mw, while opened by@dsl the code in question was done by me. Extending the device interface independent on FDT or ACPI sounds good to me. I shall go an have a look together with @dsl. For reference we are tlaking about an extension to the original works like 206dc82bc3fc5e1d90200e189ce5f2240dfec874 and b344de4d0d163cbd8bf88cb5d226c18fe96f488f .

Hi @mw,

OK, I'll make a note for myself. Thanks for a suggestion!

In D36677#833135, @mw wrote:

Hi @dsl,

On the occasion, it would be great to extend device_get_property or add a new routine (e.g. device_get_reference) for obtaining phandles in a unified way. That would allow minimizing the code related to HW description in https://reviews.freebsd.org/D36638 (and some future code I'm working on :) ).

@mw were you thinking of something like this or more sophisticated? https://people.freebsd.org/~bz/tmp/20220928-02-device-phandle.diff Given the concepts in both worlds are quite different it is kind-of hard to fully unify this case.. (phandle_t node == uint32_t, ACPI_HANDLE == sizeof(void *))

In D36677#834931, @bz wrote:
In D36677#833135, @mw wrote:

Hi @dsl,

On the occasion, it would be great to extend device_get_property or add a new routine (e.g. device_get_reference) for obtaining phandles in a unified way. That would allow minimizing the code related to HW description in https://reviews.freebsd.org/D36638 (and some future code I'm working on :) ).

@mw were you thinking of something like this or more sophisticated? https://people.freebsd.org/~bz/tmp/20220928-02-device-phandle.diff Given the concepts in both worlds are quite different it is kind-of hard to fully unify this case.. (phandle_t node == uint32_t, ACPI_HANDLE == sizeof(void *))

I put an updated version up at https://reviews.freebsd.org/D36793 as that is probably easier to comment on.