(ACPI changes from https://reviews.freebsd.org/D36638 were extracted to be reviewed separately)
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Adding mw and kd as well given they have done the abstractions earlier this year and may have an interest.
sys/dev/acpica/acpi.c | ||
---|---|---|
147 | Unneeded whitespace change probably being my fault from earlier edits. Can you re-adjust that please so it's out of the diff? | |
1976 | I still don't know how really; I'd be open to suggestions but otherwise it works for now. |
Hi @dsl,
On the occasion, it would be great to extend device_get_property or add a new routine (e.g. device_get_reference) for obtaining phandles in a unified way. That would allow minimizing the code related to HW description in https://reviews.freebsd.org/D36638 (and some future code I'm working on :) ).
@mw, while opened by@dsl the code in question was done by me. Extending the device interface independent on FDT or ACPI sounds good to me. I shall go an have a look together with @dsl. For reference we are tlaking about an extension to the original works like 206dc82bc3fc5e1d90200e189ce5f2240dfec874 and b344de4d0d163cbd8bf88cb5d226c18fe96f488f .
@mw were you thinking of something like this or more sophisticated? https://people.freebsd.org/~bz/tmp/20220928-02-device-phandle.diff Given the concepts in both worlds are quite different it is kind-of hard to fully unify this case.. (phandle_t node == uint32_t, ACPI_HANDLE == sizeof(void *))
I put an updated version up at https://reviews.freebsd.org/D36793 as that is probably easier to comment on.