LGTM

LGTM. Thanks!

BTW, I found there is PR236371.

The user gave me access to his box to test the latest driver from the website. Good news is it works very well. Unfortunately, kldload hpt37xx panics kernel. I see it panics in hpt_match() but I cannot trace it any further because the problem is somewhere in the binary blob. When it is compiled in kernel or loaded from loader(8), everything looks normal. What should we do now?

In D29679#669969, @arichardson wrote:

Sorry about that! I only saw the last comment and somehow missed that one. I can revert and re-land separately if you prefer?

I guess you missed this comment. :-(

I'll commit this when Clang 12 is merged to head.

LGTM

In D29679#669649, @arichardson wrote:

I can commit the regeneration of inittokenizer.c separately, so that this commit only includes the __dead2 change?

D28596 is committed. Please rebase.

In D29679#669618, @arichardson wrote:

In D29679#669604, @jkim wrote:

Sorry, I was going to take a look at this today. BTW, there is D28596.

Ah thanks, I didn't see that review. I can rebase on top of that one if you would like?

Sorry, I was going to take a look at this today. BTW, there is D28596.

In D15307#666805, @imp wrote:

In D15307#664721, @jkim wrote:

In D15307#664358, @imp wrote:

But I'd like reports of it working after the commit to feel happiest.

I'll make sure about that. Thanks!

Great! Thanks. There's a hptiop that's billed as supporting all 3xxx/4xxx hpt cards, but the man page doesn't list 37xx cards. Do you know if the cards this driver supports are also supported by that one?

In D15307#664358, @imp wrote:

But I'd like reports of it working after the commit to feel happiest.

One user asked me why this driver never hit src tree. Were there any serious issues with the driver?

@jhb Are you MFC'ing this to stable/13 and/or releng/13.0?

This broke build on amd64:

/usr/src/sys/dev/smbios/smbios.c:212:14: error: no member named 'eps_64bit' in 'struct smbios_softc'
        if (smbios->eps_64bit) {
            ~~~~~~  ^
/usr/src/sys/dev/smbios/smbios.c:213:20: error: no member named 'eps3' in 'struct smbios_softc'; did you mean 'eps'?
                *table = smbios->eps3->structure_table_address;
                                 ^~~~
                                 eps
/usr/src/sys/dev/smbios/smbios.c:66:22: note: 'eps' declared here
        struct smbios_eps *     eps;
                                ^
/usr/src/sys/dev/smbios/smbios.c:214:19: error: no member named 'eps3' in 'struct smbios_softc'; did you mean 'eps'?
                *size = smbios->eps3->structure_table_max_size;
                                ^~~~
                                eps
/usr/src/sys/dev/smbios/smbios.c:66:22: note: 'eps' declared here
        struct smbios_eps *     eps;
                                ^
/usr/src/sys/dev/smbios/smbios.c:214:25: error: no member named 'structure_table_max_size' in 'struct smbios_eps'; did you mean 'structure_table_address'?
                *size = smbios->eps3->structure_table_max_size;
                                      ^~~~~~~~~~~~~~~~~~~~~~~~
                                      structure_table_address
/usr/src/sys/dev/smbios/smbios.h:58:11: note: 'structure_table_address' declared here
        uint32_t        structure_table_address;
                        ^
4 errors generated.

Please regen initskel.c because flex.skl was updated in 6b7e592c215fb76ea027f25030ddc9a697184fbe. Note it was also MFC'ed to stable/13 and releng/13.0.

LGTM