Page MenuHomeFreeBSD
Differential D36870

Add mbuf_tstmp2timeval()
ClosedPublic
Actions

Authored by kib on Oct 3 2022, 10:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 13, 7:51 PM
Unknown Object (File)
Wed, May 6, 1:02 AM
Unknown Object (File)
Sun, May 3, 12:15 PM
Unknown Object (File)
Sun, May 3, 7:00 AM
Unknown Object (File)
Sun, May 3, 12:56 AM
Unknown Object (File)
Thu, Apr 30, 4:52 PM
Unknown Object (File)
Wed, Apr 29, 11:26 AM
Unknown Object (File)
Tue, Apr 28, 4:19 AM
View All Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
rrs
• hselasky
gallatin
jkim
rscheff
Group Reviewers
transport
Commits
rG2220b66fe0d5: Add mbuf_tstmp2timeval()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Oct 3 2022, 10:53 PM
Herald added a reviewer: transport. · View Herald TranscriptOct 3 2022, 10:53 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript
kib requested review of this revision.Oct 3 2022, 10:53 PM
jkim accepted this revision.Oct 3 2022, 10:59 PM

LGTM

• hselasky added inline comments.Oct 4 2022, 8:34 AM
sys/sys/mbuf.h
1692

Should the value you divide by be unsigned?

1000000000U ? 1000U ?

kib added inline comments.Oct 4 2022, 8:38 AM
sys/sys/mbuf.h
1692

Why would it matter? What do you expect to change in the result?

• hselasky accepted this revision.Oct 4 2022, 10:38 AM
• hselasky added inline comments.
sys/sys/mbuf.h
1692

It's OK, plase ignore.

rcv_tstmp is unsigned, so the compiler always produce an unsigned value.

rscheff accepted this revision.Oct 4 2022, 5:42 PM
This revision is now accepted and ready to land.Oct 4 2022, 5:42 PM
Closed by commit rG2220b66fe0d5: Add mbuf_tstmp2timeval() (authored by kib). · Explain WhyNov 7 2022, 10:33 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG2220b66fe0d5: Add mbuf_tstmp2timeval().

Revision Contents
Changeset List

PathSize
sys/
netinet/
tcp_stacks/
6 lines
3 lines
sys/
14 lines

Diff 112748

View Options

sys/netinet/tcp_stacks/bbr.c

Loading...
View Options

sys/netinet/tcp_stacks/rack.c

Loading...
View Options

sys/sys/mbuf.h

Loading...