Add mbuf_tstmp2timeval()
ClosedPublic
Actions

Authored by kib on Oct 3 2022, 10:53 PM.

Details

Reviewers

rrs
• hselasky
gallatin
jkim
rscheff

Group Reviewers

transport

Commits

rG2220b66fe0d5: Add mbuf_tstmp2timeval()

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Oct 3 2022, 10:53 PM

Herald added a reviewer: transport. · View Herald TranscriptOct 3 2022, 10:53 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

kib requested review of this revision.Oct 3 2022, 10:53 PM

LGTM

• hselasky added inline comments.Oct 4 2022, 8:34 AM

sys/sys/mbuf.h
1692	Should the value you divide by be unsigned? 1000000000U ? 1000U ?

kib added inline comments.Oct 4 2022, 8:38 AM

sys/sys/mbuf.h
1692	Why would it matter? What do you expect to change in the result?

• hselasky accepted this revision.Oct 4 2022, 10:38 AM

• hselasky added inline comments.

sys/sys/mbuf.h
1692	It's OK, plase ignore. rcv_tstmp is unsigned, so the compiler always produce an unsigned value.

rscheff accepted this revision.Oct 4 2022, 5:42 PM

This revision is now accepted and ready to land.Oct 4 2022, 5:42 PM

Closed by commit rG2220b66fe0d5: Add mbuf_tstmp2timeval() (authored by kib). · Explain WhyNov 7 2022, 10:33 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG2220b66fe0d5: Add mbuf_tstmp2timeval().

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

bbr.c

6 lines

rack.c

3 lines

sys/

mbuf.h

14 lines

Diff 112748

View Options

sys/netinet/tcp_stacks/bbr.c

View Options

sys/netinet/tcp_stacks/rack.c

View Options

Add mbuf_tstmp2timeval()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 112748

sys/netinet/tcp_stacks/bbr.c

sys/netinet/tcp_stacks/rack.c

sys/sys/mbuf.h

Add mbuf_tstmp2timeval()
ClosedPublic
Actions

Revision Contents
Changeset List