Page MenuHomeFreeBSD

hselasky (Hans Petter Selasky)
User

Projects

User Details

User Since
Nov 28 2014, 6:55 PM (389 w, 2 d)

Recent Activity

Today

hselasky added a comment to D35146: USB Hub Overcurrent (usb_hub.c.diff).

Hans, can you further explain this "overcurrent not set"? I'm reading the USB 2.0 specifications here http://sdpha2.ucsd.edu/Lab_Equip_Manuals/usb_20.pdf on the last paragraph on page 339 with continuation on page 340.

Mon, May 16, 12:28 PM
hselasky added a comment to D35146: USB Hub Overcurrent (usb_hub.c.diff).

I wonder why there is an overcurrent event happening in the first place ....

Mon, May 16, 12:21 PM
hselasky added a comment to D35146: USB Hub Overcurrent (usb_hub.c.diff).

I see.

Mon, May 16, 12:20 PM

Yesterday

hselasky added a comment to D35146: USB Hub Overcurrent (usb_hub.c.diff).

I'll get back to you tomorrow. Not working today :-)

Sun, May 15, 1:24 PM

Thu, May 12

hselasky accepted D35170: Make MSG_TLSAPPDATA only apply to Alert records.

Maybe you can add a __predict_false() there aswell.

Thu, May 12, 3:00 PM
hselasky committed R11:190f279934bd: audio/hpsjam: Update to 1.0.24 (authored by hselasky).
audio/hpsjam: Update to 1.0.24
Thu, May 12, 2:52 PM
hselasky committed R10:f9e90c24737f: LinuxKPI: Implement linux/hashtable.h for FreeBSD. (authored by hselasky).
LinuxKPI: Implement linux/hashtable.h for FreeBSD.
Thu, May 12, 2:38 PM
hselasky closed D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..
Thu, May 12, 2:38 PM
hselasky accepted D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..
Thu, May 12, 2:37 PM
hselasky updated the diff for D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..

Address come long lines and improve some type asserts.

Thu, May 12, 2:35 PM
hselasky added inline comments to D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..
Thu, May 12, 2:28 PM

Wed, May 11

hselasky added a comment to D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..
In D35162#797274, @bz wrote:

I'd probably say "Dragonfly via drm-kmod" as you obtained it from drm-kmod?

Wed, May 11, 12:03 PM
hselasky updated the summary of D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..
Wed, May 11, 12:01 PM
hselasky updated the summary of D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..
Wed, May 11, 11:42 AM
hselasky added a comment to D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..

@manu: Where was "include/linux/hash.h" obtained from?

Wed, May 11, 11:34 AM
hselasky updated the diff for D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..

Implement suggestions from bz@ and markj@ .

Wed, May 11, 11:30 AM
hselasky added inline comments to D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..
Wed, May 11, 11:30 AM

Tue, May 10

hselasky added inline comments to D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..
Tue, May 10, 2:54 PM
hselasky added inline comments to D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..
Tue, May 10, 12:59 PM
hselasky added a comment to D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..

manu@ : Could you do a quick test with graphics drivers ?

Tue, May 10, 12:57 PM
hselasky requested review of D35162: LinuxKPI: Implement linux/hashtable.h for FreeBSD..
Tue, May 10, 12:56 PM
hselasky committed R10:c42b04d3af7e: xhci(4): Tweak USB port speed checks to allow newer super speed generations. (authored by hselasky).
xhci(4): Tweak USB port speed checks to allow newer super speed generations.
Tue, May 10, 8:09 AM
hselasky committed R10:7aedfebd77d1: xhci(4): Properly define all basic USB port speeds. (authored by hselasky).
xhci(4): Properly define all basic USB port speeds.
Tue, May 10, 8:09 AM
hselasky committed R10:75a5bdd45302: xhci(4): Tweak USB port speed checks to allow newer super speed generations. (authored by hselasky).
xhci(4): Tweak USB port speed checks to allow newer super speed generations.
Tue, May 10, 8:08 AM
hselasky committed R10:a11ac66f1c0e: xhci(4): Properly define all basic USB port speeds. (authored by hselasky).
xhci(4): Properly define all basic USB port speeds.
Tue, May 10, 8:07 AM
hselasky committed R10:51a9a42f0c0b: mlx5en(4): Use hard-coded 4K page size for RQ/SQ/CQ. (authored by hselasky).
mlx5en(4): Use hard-coded 4K page size for RQ/SQ/CQ.
Tue, May 10, 8:07 AM

Mon, May 9

hselasky added a comment to D35146: USB Hub Overcurrent (usb_hub.c.diff).

I suggest you add a counter which resets on overcurrent not set, and counts to 3 before giving up power on.

Mon, May 9, 11:21 AM
hselasky added inline comments to D35146: USB Hub Overcurrent (usb_hub.c.diff).
Mon, May 9, 11:14 AM
hselasky added a comment to D35146: USB Hub Overcurrent (usb_hub.c.diff).

Please update your patch! There is an "update diff" selection in the "menu".

Mon, May 9, 10:43 AM

Fri, May 6

hselasky added inline comments to D32356: Add support for TLS RX via IFNET.
Fri, May 6, 1:28 PM · network
hselasky updated the diff for D32356: Add support for TLS RX via IFNET.
  • Implement crypto state as enum (as suggested by Gleb)
  • Remove an unused variable
  • Rebased patch.
Fri, May 6, 1:23 PM · network

Thu, May 5

hselasky committed R10:9f580526e45a: ibcore: Remove set, but not used variable. (authored by hselasky).
ibcore: Remove set, but not used variable.
Thu, May 5, 10:34 AM

Wed, May 4

hselasky committed R10:465c5bd88e64: xhci(4): Always add and evaluate the slot context. (authored by hselasky).
xhci(4): Always add and evaluate the slot context.
Wed, May 4, 12:28 PM
hselasky committed R10:340ed8ccb576: xhci(4): Only drop BULK and INTERRUPT endpoints to reset data toggle. (authored by hselasky).
xhci(4): Only drop BULK and INTERRUPT endpoints to reset data toggle.
Wed, May 4, 12:28 PM
hselasky committed R10:cacb5f3ea5d3: xhci(4): Always add and evaluate the slot context. (authored by hselasky).
xhci(4): Always add and evaluate the slot context.
Wed, May 4, 7:31 AM
hselasky committed R10:a1ec8baee5dd: xhci(4): Only drop BULK and INTERRUPT endpoints to reset data toggle. (authored by hselasky).
xhci(4): Only drop BULK and INTERRUPT endpoints to reset data toggle.
Wed, May 4, 7:31 AM
hselasky committed R10:11a732b28031: xhci(4): Always add and evaluate the slot context. (authored by hselasky).
xhci(4): Always add and evaluate the slot context.
Wed, May 4, 7:30 AM
hselasky committed R10:473c925e4359: xhci(4): Only drop BULK and INTERRUPT endpoints to reset data toggle. (authored by hselasky).
xhci(4): Only drop BULK and INTERRUPT endpoints to reset data toggle.
Wed, May 4, 7:29 AM
hselasky committed R10:a1c0442b418b: xhci(4): Tweak USB port speed checks to allow newer super speed generations. (authored by hselasky).
xhci(4): Tweak USB port speed checks to allow newer super speed generations.
Wed, May 4, 7:27 AM
hselasky committed R10:d730333c80fe: xhci(4): Properly define all basic USB port speeds. (authored by hselasky).
xhci(4): Properly define all basic USB port speeds.
Wed, May 4, 7:27 AM

Tue, May 3

hselasky committed R10:6d8c6b24ee0a: xhci(4): Always add and evaluate the slot context. (authored by hselasky).
xhci(4): Always add and evaluate the slot context.
Tue, May 3, 7:47 PM
hselasky committed R10:610528736f3f: xhci(4): Only drop BULK and INTERRUPT endpoints to reset data toggle. (authored by hselasky).
xhci(4): Only drop BULK and INTERRUPT endpoints to reset data toggle.
Tue, May 3, 7:46 PM
hselasky committed R10:09dd1adfa4c9: xhci(4): Always add and evaluate the slot context. (authored by hselasky).
xhci(4): Always add and evaluate the slot context.
Tue, May 3, 4:16 PM
hselasky committed R10:e276d2815031: xhci(4): Only drop BULK and INTERRUPT endpoints to reset data toggle. (authored by hselasky).
xhci(4): Only drop BULK and INTERRUPT endpoints to reset data toggle.
Tue, May 3, 4:15 PM
hselasky committed R10:d735d604f063: mlx5en(4): Use hard-coded 4K page size for RQ/SQ/CQ. (authored by hselasky).
mlx5en(4): Use hard-coded 4K page size for RQ/SQ/CQ.
Tue, May 3, 11:50 AM
hselasky accepted D35116: mac_curtain infrastructure: everything.

LinuxKPI bits are OK.

Tue, May 3, 9:05 AM

Mon, May 2

hselasky committed R11:66be6b83209a: sysutils/rshim-user-space: Update to version 2.0.6-10 (authored by hselasky).
sysutils/rshim-user-space: Update to version 2.0.6-10
Mon, May 2, 2:17 PM
hselasky committed R10:6244b53e1658: ibcore: Allow passing NULL-pointers to ib_umem_release() (authored by hselasky).
ibcore: Allow passing NULL-pointers to ib_umem_release()
Mon, May 2, 11:13 AM

Sun, May 1

hselasky committed R11:eb5fce936ef1: emulators/wine-devel: Fix packaging with ALSA on (authored by hselasky).
emulators/wine-devel: Fix packaging with ALSA on
Sun, May 1, 2:46 PM

Sat, Apr 30

hselasky accepted D35101: mixer: remove volume backwards compat, add % interpretation.
Sat, Apr 30, 6:56 PM
hselasky added a comment to D35101: mixer: remove volume backwards compat, add % interpretation.

There are some rc.d / devd scripts in base which needs fixing. Just
grep -ri mixer /usr/src

Sat, Apr 30, 9:26 AM
hselasky committed R10:6eb6aeef7e67: uath(4): Fix incorrect byte-swapping and a buffer length check. (authored by hselasky).
uath(4): Fix incorrect byte-swapping and a buffer length check.
Sat, Apr 30, 9:24 AM
hselasky added a comment to D35101: mixer: remove volume backwards compat, add % interpretation.

I have no objections for this patch, specifying percentage with "%" else it is relative to 1.0.

Sat, Apr 30, 8:56 AM

Wed, Apr 27

hselasky committed R10:245d5a65f580: xhci(4): Ensure the so-called data toggle gets properly reset. (authored by hselasky).
xhci(4): Ensure the so-called data toggle gets properly reset.
Wed, Apr 27, 7:35 PM
hselasky committed R10:683c36ae04ab: xhci(4): Ensure the so-called data toggle gets properly reset. (authored by hselasky).
xhci(4): Ensure the so-called data toggle gets properly reset.
Wed, Apr 27, 7:19 PM
hselasky committed R10:b199e55ce6d9: No need to stop XHCI endpoints in disabled state. (authored by hselasky).
No need to stop XHCI endpoints in disabled state.
Wed, Apr 27, 7:18 PM
hselasky committed R10:8a047df9946c: xhci(4): Ensure the so-called data toggle gets properly reset. (authored by hselasky).
xhci(4): Ensure the so-called data toggle gets properly reset.
Wed, Apr 27, 7:12 PM
hselasky committed R10:3644b9209993: xhci(4): Ensure the so-called data toggle gets properly reset. (authored by hselasky).
xhci(4): Ensure the so-called data toggle gets properly reset.
Wed, Apr 27, 7:08 PM
hselasky accepted D35076: Add USB ID and quirks for Huawei E3372.
Wed, Apr 27, 1:04 PM
hselasky accepted D35075: usb: Respect NO_INQUIRY quirk during device enumeration.
Wed, Apr 27, 1:02 PM

Tue, Apr 26

hselasky accepted D35051: LinuxKPI: Implement kthread_worker related functions.

Looks good!

Tue, Apr 26, 6:44 AM

Mon, Apr 25

hselasky added inline comments to D35051: LinuxKPI: Implement kthread_worker related functions.
Mon, Apr 25, 6:59 AM
hselasky accepted D35050: LinuxKPI: Implement sched_set_fifo(_low) functions.

Maybe split the header file inclusions and the addition of new functions before committing.

Mon, Apr 25, 6:47 AM
hselasky accepted D35049: LinuxKPI: Add cpu_latency_qos_request_active stub to linux/pm_qos.h.
Mon, Apr 25, 6:46 AM
hselasky accepted D35048: LinuxKPI: Fix typo in cond_resched_lock.
Mon, Apr 25, 6:46 AM
hselasky accepted D35047: LinuxKPI: Convert lkpi-shrinker lock to sx..
Mon, Apr 25, 6:44 AM
hselasky accepted D35046: LinuxKPI: Allow lkpi_iic driver to be a child of drm device..
Mon, Apr 25, 6:43 AM

Sat, Apr 23

hselasky updated the diff for D32356: Add support for TLS RX via IFNET.

Rebase patch after @jhb latest crypto additions.

Sat, Apr 23, 8:32 AM · network

Fri, Apr 22

hselasky accepted D35027: KTLS: Construct IV directly in crp.crp_iv for TLS 1.3 AEAD encryption..
Fri, Apr 22, 6:39 AM
hselasky accepted D35012: KTLS: Add a new recrypt operation to the software backend..
Fri, Apr 22, 6:39 AM
hselasky accepted D35011: KTLS: Move OCF function pointers out of ktls_session..
Fri, Apr 22, 6:38 AM

Thu, Apr 21

hselasky added a comment to D35021: linuxkpi: Mitigate a seqlock livelock.

@emaste: I've seen something similar with amdgpu . Testing on 13-stable right now :-)

Thu, Apr 21, 6:36 PM
hselasky accepted D35021: linuxkpi: Mitigate a seqlock livelock.
Thu, Apr 21, 4:31 PM
hselasky accepted D35021: linuxkpi: Mitigate a seqlock livelock.

Sounds good to me. Then only fast IRQ's can interrupt, but those are not used by the LKPI at all, so this should be fine.

Thu, Apr 21, 4:03 PM
hselasky committed R11:0e68090e02a0: sysutils/rshim-user-space: Update to version 2.0.6-8 (authored by hselasky).
sysutils/rshim-user-space: Update to version 2.0.6-8
Thu, Apr 21, 3:56 PM
hselasky committed R10:cda31e734925: xhci(4): Ensure the so-called data toggle gets properly reset. (authored by hselasky).
xhci(4): Ensure the so-called data toggle gets properly reset.
Thu, Apr 21, 3:03 PM
hselasky accepted D35013: KTLS: Free the MAC session when destroying AES-CBC software sessions..
Thu, Apr 21, 6:04 AM
hselasky added inline comments to D35012: KTLS: Add a new recrypt operation to the software backend..
Thu, Apr 21, 6:03 AM
hselasky accepted D35011: KTLS: Move OCF function pointers out of ktls_session..

Maybe use "const". Else looks good!

Thu, Apr 21, 6:00 AM

Wed, Apr 20

hselasky added a comment to D33693: Run softclock threads at a hardware ithread priority..

@mav: It is user-space I'm most interested in. I have a program that sleeps excatly 1ms and then wakes up to send a UDP packet. It is is very difficult to get it running correctly, because of scheduling taking time (this is my suspect) and I believe HZ=2000 helps.

Wed, Apr 20, 2:38 PM
hselasky added a comment to D33693: Run softclock threads at a hardware ithread priority..

@mav : This is not about sbt vs HZ.

Wed, Apr 20, 2:24 PM
hselasky added a comment to D33693: Run softclock threads at a hardware ithread priority..

BTW: Another thing we should do is to bump default hz to 2000, because many applications operate on millisecond granularity and task switching every ms, is the sometimes too slow!

Wed, Apr 20, 7:12 AM

Apr 16 2022

hselasky accepted D32551: if(9): Implement support for nvlist-based set- and get- network interface capabilities..
Apr 16 2022, 7:08 AM

Apr 15 2022

hselasky added inline comments to D32551: if(9): Implement support for nvlist-based set- and get- network interface capabilities..
Apr 15 2022, 5:43 PM
hselasky added inline comments to D32551: if(9): Implement support for nvlist-based set- and get- network interface capabilities..
Apr 15 2022, 5:34 PM
hselasky added inline comments to D34252: LinuxKPI: add proper support for charp module parameters.
Apr 15 2022, 5:26 PM · linuxkpi
hselasky committed R11:ba5d067f191c: sysutils/rshim-user-space: Update to version 2.0.6-7 (authored by hselasky).
sysutils/rshim-user-space: Update to version 2.0.6-7
Apr 15 2022, 1:03 PM

Apr 8 2022

hselasky added a comment to D34825: mlx4: Comment out a variable only used in commented-out code..

I was just thinking about removing this line:

Apr 8 2022, 8:19 PM
hselasky accepted D34844: LinuxKPI: add ALIGN_DOWN().

This will do too:

Apr 8 2022, 4:08 PM
hselasky added a comment to D34840: uhid_snes: Remove USB_ST_TRANSFERRED handling for the status request..

I suspect you can just remove the new_status . I think it is some leftover.

Apr 8 2022, 9:44 AM
hselasky added a reviewer for D34840: uhid_snes: Remove USB_ST_TRANSFERRED handling for the status request.: wulf.
Apr 8 2022, 9:40 AM
hselasky accepted D34839: Correct calendar date entry for myself.
Apr 8 2022, 9:40 AM
hselasky accepted D34827: mlx5: Remove unused variables..
Apr 8 2022, 9:38 AM
hselasky accepted D34826: mlx4: Remove unused variables..
Apr 8 2022, 9:35 AM
hselasky accepted D34825: mlx4: Comment out a variable only used in commented-out code..

Just delete those lines. No need to comment out.

Apr 8 2022, 9:35 AM

Apr 7 2022

hselasky added a comment to D34812: mlx5: Pass the correct data pointer to the add_dst_cb instead of NULL..

Your initial commit message was fine. Ignore my comment about mlx5 -> mlx5en.

Apr 7 2022, 9:55 AM
hselasky accepted D34812: mlx5: Pass the correct data pointer to the add_dst_cb instead of NULL..

FYI: This piece of code is unused.

Apr 7 2022, 9:41 AM

Apr 6 2022

hselasky committed R11:71730fe51add: sysutils/rshim-user-space: Update to version 2.0.6-6 (authored by hselasky).
sysutils/rshim-user-space: Update to version 2.0.6-6
Apr 6 2022, 7:28 PM
hselasky added a comment to D22154: Delayed context for SIOCADDMULTI.

If you look at:

Apr 6 2022, 2:47 PM
hselasky added a comment to D22154: Delayed context for SIOCADDMULTI.

I think a delmultitask would be appropriate to avoid races on the if_ioctl handler, adding and removing multicast addresses.

Apr 6 2022, 2:41 PM