Page MenuHomeFreeBSD

hselasky (Hans Petter Selasky)
User

Projects

User Details

User Since
Nov 28 2014, 6:55 PM (262 w, 12 h)

Recent Activity

Yesterday

hselasky committed rS355447: Fix compilation issue with mlx5core and sparc64 (gcc48):.
Fix compilation issue with mlx5core and sparc64 (gcc48):
Fri, Dec 6, 4:20 PM
hselasky committed rS355446: Implement hardware TLS via send tags for mlx5en(4), which is supported by.
Implement hardware TLS via send tags for mlx5en(4), which is supported by
Fri, Dec 6, 3:36 PM

Thu, Dec 5

hselasky added a comment to D22669: Add support for rate limited TLS send tags.
In D22669#496485, @jhb wrote:

As I have told you multiple times, it is _not_ the same for Chelsio as TLS send tags on Chelsio always support rate limiting. However, it doesn't seem like this is blocking upstreaming since you've just committed the non-ratelimit TLS code today?

Thu, Dec 5, 6:38 PM
hselasky committed rS355421: Add basic support for TCP/IP based hardware TLS offload to mlx5core..
Add basic support for TCP/IP based hardware TLS offload to mlx5core.
Thu, Dec 5, 3:16 PM
hselasky committed rS355419: MFC r355108 and r355170:.
MFC r355108 and r355170:
Thu, Dec 5, 2:54 PM
hselasky committed rS355418: MFC r355108 and r355170:.
MFC r355108 and r355170:
Thu, Dec 5, 2:52 PM
hselasky committed rS355417: MFC r355108 and r355170:.
MFC r355108 and r355170:
Thu, Dec 5, 2:50 PM
hselasky added inline comments to D22669: Add support for rate limited TLS send tags.
Thu, Dec 5, 1:21 PM
hselasky added a comment to D22669: Add support for rate limited TLS send tags.
In D22669#495980, @jhb wrote:

How does changing the rate work? Right now you'd have to have all the places that change the rate figure out what type the tag is to send a different structure down for modifying the rate. That is sub-optimal. This also doesn't address the issue of how to make the socket option adjust the rate of an existing tag. Just adding a new tag type is the easy part of the problem, but not a full solution on its own.

Thu, Dec 5, 1:19 PM

Wed, Dec 4

hselasky added inline comments to D22669: Add support for rate limited TLS send tags.
Wed, Dec 4, 2:22 PM
hselasky added a reviewer for D22669: Add support for rate limited TLS send tags: kib.
Wed, Dec 4, 10:08 AM
hselasky created D22669: Add support for rate limited TLS send tags.
Wed, Dec 4, 10:07 AM

Tue, Dec 3

hselasky committed rS355322: Use refcount from "in_joingroup_locked()" when joining multicast.
Use refcount from "in_joingroup_locked()" when joining multicast
Tue, Dec 3, 8:47 AM
hselasky closed D22595: Align refcounting in multicast code between IPv4 and IPv6.
Tue, Dec 3, 8:47 AM
hselasky updated the diff for D22595: Align refcounting in multicast code between IPv4 and IPv6.

Implement suggestion from @rgrimes .

Tue, Dec 3, 8:17 AM
hselasky added inline comments to D22595: Align refcounting in multicast code between IPv4 and IPv6.
Tue, Dec 3, 8:12 AM
hselasky added inline comments to D22595: Align refcounting in multicast code between IPv4 and IPv6.
Tue, Dec 3, 8:04 AM

Sun, Dec 1

hselasky accepted D22586: Implement safe memory reclamation in UMA..

Looks good with regards to EPOCH and wrapping counters.

Sun, Dec 1, 7:09 AM

Sat, Nov 30

hselasky added a reviewer for D22595: Align refcounting in multicast code between IPv4 and IPv6: network.
Sat, Nov 30, 4:48 AM

Fri, Nov 29

hselasky added inline comments to D22586: Implement safe memory reclamation in UMA..
Fri, Nov 29, 10:49 AM

Thu, Nov 28

hselasky created D22595: Align refcounting in multicast code between IPv4 and IPv6.
Thu, Nov 28, 6:29 PM
hselasky added inline comments to D22586: Implement safe memory reclamation in UMA..
Thu, Nov 28, 8:52 AM
hselasky committed rS355170: Factor out check for mounted root file system..
Factor out check for mounted root file system.
Thu, Nov 28, 8:47 AM
hselasky closed D22571: Factor out checks for mounted root file system.
Thu, Nov 28, 8:47 AM

Wed, Nov 27

hselasky updated the diff for D22571: Factor out checks for mounted root file system.

Handle comments from @kib

Wed, Nov 27, 4:21 PM
hselasky updated the diff for D22571: Factor out checks for mounted root file system.

Keep the rootvnode check in case the root file system gets unmounted.
Update comment.

Wed, Nov 27, 4:11 PM
hselasky updated the diff for D22571: Factor out checks for mounted root file system.
Wed, Nov 27, 4:00 PM
hselasky commandeered D22571: Factor out checks for mounted root file system.
Wed, Nov 27, 3:56 PM
hselasky added a comment to D22571: Factor out checks for mounted root file system.
Index: sys/kern/kern_linker.c
===================================================================
--- sys/kern/kern_linker.c	(revision 355108)
+++ sys/kern/kern_linker.c	(working copy)
@@ -2067,6 +2067,7 @@
     struct linker_file *parent, const struct mod_depend *verinfo,
     struct linker_file **lfpp)
 {
+	struct proc *cp = curproc;
 	linker_file_t lfdep;
 	const char *filename;
 	char *pathname;
@@ -2079,13 +2080,13 @@
  		 */
 		KASSERT(verinfo == NULL, ("linker_load_module: verinfo"
 		    " is not NULL"));
-		if (rootvnode == NULL)
+		if (rootvnode == NULL || cp->p_fd == NULL || cp->p_fd->fd_rdir == NULL)
 			return (ENXIO);
 		pathname = linker_search_kld(kldname);
 	} else {
 		if (modlist_lookup2(modname, verinfo) != NULL)
 			return (EEXIST);
-		if (rootvnode == NULL)
+		if (rootvnode == NULL || cp->p_fd == NULL || cp->p_fd->fd_rdir == NULL)
 			return (ENXIO);
 		if (kldname != NULL)
 			pathname = strdup(kldname, M_LINKER);
Wed, Nov 27, 3:41 PM
hselasky added a comment to D22571: Factor out checks for mounted root file system.

I wonder if this check should be factored out? It is not only the LinuxKPI which access these code paths too early, but USB drivers loading firmware .ko's can also do the same??

Wed, Nov 27, 3:33 PM
hselasky added inline comments to D22571: Factor out checks for mounted root file system.
Wed, Nov 27, 3:29 PM

Tue, Nov 26

hselasky committed rS355108: Fix panic when loading kernel modules before root file system is mounted..
Fix panic when loading kernel modules before root file system is mounted.
Tue, Nov 26, 12:20 PM
hselasky closed D22545: Fix panic when loading kernel modules before root file system is mounted.
Tue, Nov 26, 12:20 PM

Mon, Nov 25

hselasky accepted D20740: in_mcast.c: need if_addr_lock around inm_release_deferred.
Mon, Nov 25, 9:49 PM
hselasky retitled D22545: Fix panic when loading kernel modules before root file system is mounted from Fix panic when loading kernel modules before root file system is loaded to Fix panic when loading kernel modules before root file system is mounted.
Mon, Nov 25, 2:40 PM
hselasky updated the diff for D22545: Fix panic when loading kernel modules before root file system is mounted.

Include full context.

Mon, Nov 25, 2:39 PM
hselasky created D22545: Fix panic when loading kernel modules before root file system is mounted.
Mon, Nov 25, 2:38 PM

Fri, Nov 22

hselasky committed rS354996: MFC r354728:.
MFC r354728:
Fri, Nov 22, 2:24 PM
hselasky committed rS354995: MFC r354728:.
MFC r354728:
Fri, Nov 22, 2:23 PM
hselasky committed rS354994: MFC r354727:.
MFC r354727:
Fri, Nov 22, 2:22 PM
hselasky committed rS354993: MFC r354727:.
MFC r354727:
Fri, Nov 22, 2:18 PM

Thu, Nov 21

hselasky committed rS354969: Add USB ID for Diamond Multimedia BVU195 Display Link device..
Add USB ID for Diamond Multimedia BVU195 Display Link device.
Thu, Nov 21, 4:42 PM

Tue, Nov 19

hselasky accepted D22443: Reduce the vnet_set module size of ip_mroute to allow loading as a module..

Looks good to me.

Tue, Nov 19, 2:24 PM
hselasky added inline comments to D22315: Port the NetBSD KCSAN runtime to FreeBSD.
Tue, Nov 19, 9:13 AM

Fri, Nov 15

hselasky committed rS354728: Prevent potential underflow in ibcore..
Prevent potential underflow in ibcore.
Fri, Nov 15, 11:47 AM
hselasky committed rS354727: Correct MR length field to be 64-bit in ibcore..
Correct MR length field to be 64-bit in ibcore.
Fri, Nov 15, 11:45 AM

Mon, Nov 11

hselasky added inline comments to D22315: Port the NetBSD KCSAN runtime to FreeBSD.
Mon, Nov 11, 7:31 PM
hselasky added inline comments to D22315: Port the NetBSD KCSAN runtime to FreeBSD.
Mon, Nov 11, 3:46 PM
hselasky committed rS354616: MFC r354335:.
MFC r354335:
Mon, Nov 11, 3:28 PM
hselasky committed rS354615: MFC r351937:.
MFC r351937:
Mon, Nov 11, 3:26 PM
hselasky committed rS354614: MFC r351701:.
MFC r351701:
Mon, Nov 11, 3:24 PM
hselasky committed rS354613: MFC r354335:.
MFC r354335:
Mon, Nov 11, 2:56 PM
hselasky committed rS354612: MFC r353273:.
MFC r353273:
Mon, Nov 11, 2:52 PM
hselasky committed rS354611: MFC r353273:.
MFC r353273:
Mon, Nov 11, 2:51 PM
hselasky committed rS354610: MFC r353275:.
MFC r353275:
Mon, Nov 11, 2:49 PM
hselasky committed rS354609: MFC r353275:.
MFC r353275:
Mon, Nov 11, 2:41 PM

Thu, Nov 7

hselasky committed rS354440: Check CSUM_SND_TAG flag before classifying packet has having a send.
Check CSUM_SND_TAG flag before classifying packet has having a send
Thu, Nov 7, 1:12 PM
hselasky committed rS354439: Revert accidential chunk added to GENERIC from previous commit..
Revert accidential chunk added to GENERIC from previous commit.
Thu, Nov 7, 1:01 PM
hselasky committed rS354438: Partial MFC of CSUM_SND_TAG flag from r348254..
Partial MFC of CSUM_SND_TAG flag from r348254.
Thu, Nov 7, 12:58 PM

Nov 4 2019

hselasky committed rS354335: Enable device class group attributes in the LinuxKPI..
Enable device class group attributes in the LinuxKPI.
Nov 4 2019, 2:19 PM
hselasky closed D21564: LinuxKPI: enable class dev_groups attributes.
Nov 4 2019, 2:19 PM
hselasky added a comment to D21564: LinuxKPI: enable class dev_groups attributes.

I'll handle it.

Nov 4 2019, 1:44 PM
hselasky accepted D21564: LinuxKPI: enable class dev_groups attributes.

Who will submit this patch?

Nov 4 2019, 7:22 AM

Oct 25 2019

hselasky accepted D22154: Delayed context for SIOCADDMULTI.

Looks good to me.

Oct 25 2019, 9:59 PM
hselasky added inline comments to D22154: Delayed context for SIOCADDMULTI.
Oct 25 2019, 8:31 PM
hselasky added inline comments to D22154: Delayed context for SIOCADDMULTI.
Oct 25 2019, 8:28 PM
hselasky added inline comments to D22154: Delayed context for SIOCADDMULTI.
Oct 25 2019, 8:26 PM
hselasky added a comment to D22154: Delayed context for SIOCADDMULTI.

Please add code to drain this new task.

Oct 25 2019, 5:16 PM
hselasky accepted D22153: Properly set VNET when nuking recvif from fragment queues.
Oct 25 2019, 5:06 PM

Oct 16 2019

hselasky added a comment to D22054: frag6: fix vnet teardown leak.

MFC after: XXX

Oct 16 2019, 10:07 AM
hselasky accepted D22054: frag6: fix vnet teardown leak.

Looks good.

Oct 16 2019, 10:05 AM
hselasky closed D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.
Oct 16 2019, 9:12 AM
hselasky committed rS353635: Fix panic in network stack due to use after free when receiving.
Fix panic in network stack due to use after free when receiving
Oct 16 2019, 9:12 AM
hselasky committed rS353633: VLAN_TRUNKDEV() requires epochification in ibcore after r353292..
VLAN_TRUNKDEV() requires epochification in ibcore after r353292.
Oct 16 2019, 8:56 AM
hselasky committed rS353632: Replace rdma_is_upper_dev_rcu() with rdma_vlan_dev_real_dev() in ibcore..
Replace rdma_is_upper_dev_rcu() with rdma_vlan_dev_real_dev() in ibcore.
Oct 16 2019, 8:55 AM
hselasky committed rS353631: VLAN_DEVAT() requires epochification in ipoib after r353292..
VLAN_DEVAT() requires epochification in ipoib after r353292.
Oct 16 2019, 8:41 AM

Oct 15 2019

hselasky added inline comments to D22017: Add NOEPOCHASSERT()..
Oct 15 2019, 5:26 PM
hselasky added inline comments to D22017: Add NOEPOCHASSERT()..
Oct 15 2019, 3:59 PM
hselasky committed rS353550: The two functions ifnet_byindex() and ifnet_byindex_locked() are exactly the.
The two functions ifnet_byindex() and ifnet_byindex_locked() are exactly the
Oct 15 2019, 12:08 PM
hselasky committed rS353549: Exclude the network link eventhandler from epochification after r353292..
Exclude the network link eventhandler from epochification after r353292.
Oct 15 2019, 11:20 AM
hselasky committed rS353548: Fix missing epochification of the LinuxKPI after r353292..
Fix missing epochification of the LinuxKPI after r353292.
Oct 15 2019, 11:14 AM
hselasky committed rS353547: Fix missing epochification of the ibcore code after r353292..
Fix missing epochification of the ibcore code after r353292.
Oct 15 2019, 11:12 AM
hselasky committed rS353546: Fix missing epochification of the ipoib code after r353292..
Fix missing epochification of the ipoib code after r353292.
Oct 15 2019, 11:11 AM

Oct 14 2019

hselasky accepted D22017: Add NOEPOCHASSERT()..

Looks good.

Oct 14 2019, 10:03 AM

Oct 10 2019

hselasky committed rS353407: MFS r353405:.
MFS r353405:
Oct 10 2019, 4:05 PM
hselasky committed rS353406: MFC r353321:.
MFC r353321:
Oct 10 2019, 3:38 PM
hselasky committed rS353405: MFC r353321:.
MFC r353321:
Oct 10 2019, 3:37 PM

Oct 9 2019

hselasky committed rP514184: Update port to v1.0-alpha.2.
Update port to v1.0-alpha.2
Oct 9 2019, 7:00 PM
hselasky committed rP514183: Remove whitespace at end of line..
Remove whitespace at end of line.
Oct 9 2019, 6:59 PM
hselasky added a comment to D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

I've added prints in the new code paths and verified that:

Oct 9 2019, 6:51 PM
hselasky committed rS353359: Factor out TCP rateset destruction code..
Factor out TCP rateset destruction code.
Oct 9 2019, 5:08 PM
hselasky committed rS353353: Fix locking order reversal in the TCP ratelimit code by moving.
Fix locking order reversal in the TCP ratelimit code by moving
Oct 9 2019, 4:49 PM
hselasky updated the diff for D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

No need to check shutdown flag in IPv6 fragment cleanup code yet (@bz fill add this later)

Oct 9 2019, 4:13 PM
hselasky updated the diff for D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

Fix check for shutdown in IPv4 reassembly cleanup.

Oct 9 2019, 4:11 PM
hselasky added a comment to D20293: ucom(4): synchronously execute param changes.

Yes, that's the simplest.

Oct 9 2019, 2:10 PM
hselasky committed rP514124: Update port Makefile as suggested by mat@ ..
Update port Makefile as suggested by mat@ .
Oct 9 2019, 7:46 AM
hselasky added a comment to D20293: ucom(4): synchronously execute param changes.

Ultimately, why does this stuff need to be done asynchronously in a different process? I would understand if bits outside of dev/usb/serial/* were submitting commands to this process as well, but that's simply not the case as far as I can tell -- it looks like it was mostly done like this to match the structure of usb_ethernet, which is not a solid reason.

Oct 9 2019, 7:24 AM

Oct 8 2019

hselasky added a comment to D20051: Define and use functions to test specific VNET states during shutdown.

@bz: The old checks don't respect if we are bringing up or destroying a VNET. For example this one in if_detach:

Oct 8 2019, 9:00 PM
hselasky added a comment to D21943: Correct and final KPI to traverse through interface address lists for drivers.Removal of not stack allocated epoch_tracker..

sys/ofed, sys/dev/mlx4, sys/dev/mlx5 and sys/dev/usb changes look OK.

Oct 8 2019, 8:50 PM
hselasky updated the diff for D20051: Define and use functions to test specific VNET states during shutdown.

Update patch.

Oct 8 2019, 8:27 PM