- User Since
- Nov 28 2014, 6:55 PM (272 w, 4 d)
From what I can see "pf_overload_task()" does not send or receive and IP packets, and does not need to run under EPOCH(9).
Mon, Feb 17
Sun, Feb 16
Can you upload patch context?
Fri, Feb 14
Thu, Feb 13
Looks very good. See my two comments.
Looks good to me.
SYSCTL_ADD_NODE() and SYSCTL_NODE() are always MPSAFE.
Wed, Feb 12
The Mellanox drivers currently manage this internally:
The LinuxKPI does not depend on Giant. All instances of SYSCTL's in the LinuxKPI can be made MPSAFE.
Tue, Feb 11
All sysctls in USB drivers are MPSAFE including uaudio.c .
Rebase patch after r357772.
Mon, Feb 10
@glebius: Looks better now?
I'm good with this change.
Fri, Feb 7
Patch looks good.
Do you have a reference for the new PCI ID values?
@jeff: Can you accept this change?
Thu, Feb 6
Can the people subscribed to this patch which think the current version is OK accept it again?
Use atomic_load_int() instead of "volatile" as suggested by kib@ .
Exactly what you said, so that the hflags should be constant after MSI(-X) interrupt is set up. So again, I am not sure how did you see leaked epoch entry for mlx5en interrupt thread.
Wed, Feb 5
Tue, Feb 4
mjg@, mav@, gallatin@: How does the latest patch version look?
Mark ie_hflags volatile to simplify use of atomic.
Make sure ie_hflags is not cleared before update.
Can you comment on this change?
jhb@ can you comment if it is safe to access the structure pointed to by "ie" like done in the patch above?
Use atomic_load_int() where appropriate like suggested by mjg@ .
Mon, Feb 3
@mjg: Thank you. I'll have a look at this again tomorrow.