Page MenuHomeFreeBSD

hselasky (Hans Petter Selasky)
User

Projects

User Details

User Since
Nov 28 2014, 6:55 PM (309 w, 7 h)

Recent Activity

Yesterday

hselasky accepted D27020: Remove IF_SND_TAG_TYPE_TLS_RATE_LIMIT conditionals..
Fri, Oct 30, 3:50 PM
hselasky committed rS367158: MFC r366961:.
MFC r366961:
Fri, Oct 30, 8:07 AM
hselasky committed rS367157: MFC r366961:.
MFC r366961:
Fri, Oct 30, 8:06 AM

Thu, Oct 29

hselasky added inline comments to D26691: Support hardware rate limiting (pacing) with TLS offload..
Thu, Oct 29, 8:41 AM
hselasky accepted D27000: Add m_snd_tag_alloc() as a wrapper around if_snd_tag_alloc()..
Thu, Oct 29, 8:39 AM
hselasky added inline comments to D26996: Use public interfaces to manage the nested rate limit send tag..
Thu, Oct 29, 8:38 AM
hselasky accepted D26996: Use public interfaces to manage the nested rate limit send tag..

Looks good!

Thu, Oct 29, 8:36 AM
hselasky accepted D26995: Call m_snd_tag_rele() to free send tags..

Looks good!

Thu, Oct 29, 8:31 AM

Wed, Oct 28

hselasky added a comment to D26884: Add sndstat IOCTLs draft.

I think the bit-perfect parameters should be used, if possible.

Wed, Oct 28, 9:23 AM
hselasky added a comment to D26884: Add sndstat IOCTLs draft.

What about providing the default sample bit depth used?

Wed, Oct 28, 8:55 AM
hselasky committed rS367096: Add new USB IDs..
Add new USB IDs.
Wed, Oct 28, 8:23 AM

Sat, Oct 24

hselasky committed rS366996: Implement xa_init() in the LinuxKPI as a wrapper for xa_init_flags()..
Implement xa_init() in the LinuxKPI as a wrapper for xa_init_flags().
Sat, Oct 24, 1:16 PM
hselasky committed rS366995: More style fixes (partial revert of r366994)..
More style fixes (partial revert of r366994).
Sat, Oct 24, 1:07 PM
hselasky committed rS366994: Fix order of header files:.
Fix order of header files:
Sat, Oct 24, 10:52 AM
hselasky committed rS366993: Run code through "clang-format -style=file" with some additional fixes..
Run code through "clang-format -style=file" with some additional fixes.
Sat, Oct 24, 10:24 AM

Fri, Oct 23

hselasky committed rS366961: Fix for loading cuse.ko via rc.d . Make sure we declare the cuse(3).
Fix for loading cuse.ko via rc.d . Make sure we declare the cuse(3)
Fri, Oct 23, 8:45 AM
hselasky accepted D26913: xhci: Handle the case when MSI-X BAR is same as IO BAR..

Looks good.

Fri, Oct 23, 7:32 AM

Thu, Oct 22

hselasky added a comment to D26884: Add sndstat IOCTLs draft.
Thu, Oct 22, 6:17 PM
hselasky committed rS366936: Compile fix for MIPS, MIPS64, POWERPC and POWERPC64..
Compile fix for MIPS, MIPS64, POWERPC and POWERPC64.
Thu, Oct 22, 12:22 PM
hselasky committed rS366935: Fix for colliding change (r366917)..
Fix for colliding change (r366917).
Thu, Oct 22, 10:37 AM
hselasky committed rS366934: Fix for monotolithic kernel builds using device lagg(4)..
Fix for monotolithic kernel builds using device lagg(4).
Thu, Oct 22, 10:29 AM
hselasky committed rS366933: Add support for IP over infiniband, IPoIB, to lagg(4). Currently only.
Add support for IP over infiniband, IPoIB, to lagg(4). Currently only
Thu, Oct 22, 9:47 AM
hselasky committed rS366931: Implement mbuf hashing routines for IP over infiniband, IPoIB..
Implement mbuf hashing routines for IP over infiniband, IPoIB.
Thu, Oct 22, 9:18 AM
hselasky closed D26254: Add support for IPoIB lagg devices in FreeBSD.
Thu, Oct 22, 9:10 AM
hselasky committed rS366930: Factor out generic IP over infiniband, IPoIB, definitions and code.
Factor out generic IP over infiniband, IPoIB, definitions and code
Thu, Oct 22, 9:10 AM
hselasky updated the diff for D26254: Add support for IPoIB lagg devices in FreeBSD.

Allow if_infiniband to be unloaded.

Thu, Oct 22, 8:19 AM
hselasky updated the diff for D26254: Add support for IPoIB lagg devices in FreeBSD.

Implement suggestions from @melifaro .

Thu, Oct 22, 8:13 AM

Wed, Oct 21

hselasky added a reviewer for D26254: Add support for IPoIB lagg devices in FreeBSD: melifaro.
Wed, Oct 21, 11:48 AM
hselasky added inline comments to D26254: Add support for IPoIB lagg devices in FreeBSD.
Wed, Oct 21, 11:47 AM
hselasky added a comment to D26254: Add support for IPoIB lagg devices in FreeBSD.

Test OK.

Wed, Oct 21, 11:43 AM
hselasky updated the diff for D26254: Add support for IPoIB lagg devices in FreeBSD.

Implement suggestion from @melfario .

Wed, Oct 21, 11:12 AM
hselasky added a comment to D26254: Add support for IPoIB lagg devices in FreeBSD.

@melfario

require lagg creation to specify laggtype in the creation params, assuming ethernet by default. ifconfig(8) needs to be updated (changes similar to vxlan_create() in sbin/ifconfig/ifvxlan.c).

Wed, Oct 21, 8:38 AM

Tue, Oct 20

hselasky added inline comments to D26254: Add support for IPoIB lagg devices in FreeBSD.
Tue, Oct 20, 8:40 PM
hselasky added a comment to D26254: Add support for IPoIB lagg devices in FreeBSD.

The only real question/concern I have is the name. I'm a bit afraid that we're saying that "bond" is an IB port-channel and "lagg" is an ethernet port-channel. It's a bit confusing, given one cannot distinguish which is which by name and the fact that Linux folks are used to "bond" as the ethernet port-channel. If we really want to have the different names (to keep some applications happy?), would it be possible to have a name other than "bond"?

I agree with @melifaro ; Link Aggregation Group covers Ethernet (failover, lacp, loadbalance, roundrobin); why can't it also cover InfiniBand failover as part of the same?

Tue, Oct 20, 8:36 PM
hselasky added inline comments to D26254: Add support for IPoIB lagg devices in FreeBSD.
Tue, Oct 20, 9:15 AM
hselasky updated the diff for D26254: Add support for IPoIB lagg devices in FreeBSD.

Add comment for LAGG's mutex, as suggested by @ae.

Tue, Oct 20, 9:12 AM
hselasky updated the diff for D26254: Add support for IPoIB lagg devices in FreeBSD.

Factor hashing functions as suggested by @ae .

Tue, Oct 20, 9:07 AM
hselasky committed rS366889: MFC r349277 and r366669:.
MFC r349277 and r366669:
Tue, Oct 20, 8:40 AM
hselasky committed rS366888: MFC r366669:.
MFC r366669:
Tue, Oct 20, 8:35 AM
hselasky committed rS366887: MFC r366536:.
MFC r366536:
Tue, Oct 20, 8:34 AM
hselasky committed rS366886: MFC r366536:.
MFC r366536:
Tue, Oct 20, 8:33 AM
hselasky committed rS366885: MFC r366535:.
MFC r366535:
Tue, Oct 20, 8:32 AM
hselasky committed rS366884: MFC r366535:.
MFC r366535:
Tue, Oct 20, 8:31 AM
hselasky committed rS366883: MFC r366533:.
MFC r366533:
Tue, Oct 20, 8:30 AM
hselasky committed rS366882: MFC r366533:.
MFC r366533:
Tue, Oct 20, 8:29 AM
hselasky committed rS366881: MFC r366518:.
MFC r366518:
Tue, Oct 20, 8:25 AM
hselasky committed rS366880: MFC r366518:.
MFC r366518:
Tue, Oct 20, 8:25 AM
hselasky committed rS366879: MFC r347596 and r366432:.
MFC r347596 and r366432:
Tue, Oct 20, 8:23 AM
hselasky committed rS366878: MFC r366432:.
MFC r366432:
Tue, Oct 20, 8:18 AM
hselasky committed rS366877: MFC r366431:.
MFC r366431:
Tue, Oct 20, 8:15 AM
hselasky committed rS366876: MFC r366431:.
MFC r366431:
Tue, Oct 20, 8:14 AM
hselasky committed rS366875: MFC r365966:.
MFC r365966:
Tue, Oct 20, 8:13 AM
hselasky committed rS366874: MFC r365966:.
MFC r365966:
Tue, Oct 20, 8:12 AM
hselasky committed rS366873: MFC r365958:.
MFC r365958:
Tue, Oct 20, 8:11 AM
hselasky committed rS366872: MFC r365236:.
MFC r365236:
Tue, Oct 20, 8:08 AM
hselasky accepted D26691: Support hardware rate limiting (pacing) with TLS offload..
Tue, Oct 20, 7:58 AM

Mon, Oct 19

hselasky updated the test plan for D26254: Add support for IPoIB lagg devices in FreeBSD.
Mon, Oct 19, 11:00 AM

Sun, Oct 18

hselasky committed rS366806: Add new USB quirk..
Add new USB quirk.
Sun, Oct 18, 8:58 AM

Fri, Oct 16

hselasky committed rS366751: Remove ifdefs around IS_ALIGNED() definition in the LinuxKPI..
Remove ifdefs around IS_ALIGNED() definition in the LinuxKPI.
Fri, Oct 16, 11:01 AM

Tue, Oct 13

hselasky committed rS366669: Implement more RCU list functions in the LinuxKPI..
Implement more RCU list functions in the LinuxKPI.
Tue, Oct 13, 4:19 PM
hselasky accepted D26733: Allow IPoIB to work with multiple FIBs.

If you MFC it too it is fine. I'll rebase my patch.

Tue, Oct 13, 7:24 AM

Sun, Oct 11

hselasky added a comment to D26733: Allow IPoIB to work with multiple FIBs.

This piece of code is about to change with D26254 . I've added the patch there instead.

Sun, Oct 11, 7:26 AM
hselasky updated the diff for D26254: Add support for IPoIB lagg devices in FreeBSD.

D26733: Allow IPoIB to work with mutiple FIBs

Sun, Oct 11, 7:25 AM

Sat, Oct 10

hselasky updated the test plan for D26254: Add support for IPoIB lagg devices in FreeBSD.
Sat, Oct 10, 4:59 PM
hselasky updated the diff for D26254: Add support for IPoIB lagg devices in FreeBSD.

ifp -> ifp->if_vnet

Sat, Oct 10, 4:50 PM
hselasky updated the diff for D26254: Add support for IPoIB lagg devices in FreeBSD.

Need to set VNET before the lladdr event.

Sat, Oct 10, 4:48 PM
hselasky updated the diff for D26254: Add support for IPoIB lagg devices in FreeBSD.

Fix for double free of mbuf.

Sat, Oct 10, 4:33 PM
hselasky updated the diff for D26254: Add support for IPoIB lagg devices in FreeBSD.

Generate proper lladdr change event.

Sat, Oct 10, 11:16 AM
hselasky updated the diff for D26254: Add support for IPoIB lagg devices in FreeBSD.

Implement full support for failover.

Sat, Oct 10, 9:59 AM

Thu, Oct 8

hselasky accepted D26691: Support hardware rate limiting (pacing) with TLS offload..

Looks good from mlx5_en_main.c's point of view.
@gallatin: Did you test this with mlx5en?

Thu, Oct 8, 10:25 PM
hselasky updated the diff for D26254: Add support for IPoIB lagg devices in FreeBSD.

Rebase patch mostly.

Thu, Oct 8, 11:36 AM
hselasky committed rS366536: Try a bit harder to get the USB device descriptor in case the initial read….
Try a bit harder to get the USB device descriptor in case the initial read…
Thu, Oct 8, 11:30 AM
hselasky committed rS366535: The ethernet header structure is read-only. Add const keyword..
The ethernet header structure is read-only. Add const keyword.
Thu, Oct 8, 11:25 AM
hselasky committed rS366533: Allow evdev's rcpt_mask and sysmouse_t_axis parameters to be specified in.
Allow evdev's rcpt_mask and sysmouse_t_axis parameters to be specified in
Thu, Oct 8, 11:00 AM

Wed, Oct 7

hselasky accepted D26708: LinuxKPI: A bitfield.h implementation..
Wed, Oct 7, 8:49 PM
hselasky added inline comments to D26708: LinuxKPI: A bitfield.h implementation..
Wed, Oct 7, 6:12 PM
hselasky committed rS366518: Properly cleanup driver during remove_one() in mlx5core..
Properly cleanup driver during remove_one() in mlx5core.
Wed, Oct 7, 5:47 PM
hselasky committed rP551619: Fix rc.d status command for virtual_oss..
Fix rc.d status command for virtual_oss.
Wed, Oct 7, 7:11 AM

Tue, Oct 6

hselasky committed rP551596: Fix path for virtual_oss when checking pidfile in rc.d file..
Fix path for virtual_oss when checking pidfile in rc.d file.
Tue, Oct 6, 8:58 PM
hselasky accepted D26689: Store the send tag type in the common send tag header..

Looks good - approved!

Tue, Oct 6, 7:41 AM

Sun, Oct 4

hselasky closed D26657: linuxkpi: populate the acquire context field of a ww_mutex.
Sun, Oct 4, 5:24 PM · linuxkpi
hselasky committed rS366432: Populate the acquire context field of a ww_mutex in the LinuxKPI..
Populate the acquire context field of a ww_mutex in the LinuxKPI.
Sun, Oct 4, 5:24 PM
hselasky closed D21863: ugensa: add support for Google Cr50 (GSC) Closed Case Debugging UART interfaces.
Sun, Oct 4, 5:17 PM
hselasky committed rS366431: Add support for Google Cr50 (GSC) Closed Case Debugging UART interfaces to.
Add support for Google Cr50 (GSC) Closed Case Debugging UART interfaces to
Sun, Oct 4, 5:17 PM
hselasky accepted D21863: ugensa: add support for Google Cr50 (GSC) Closed Case Debugging UART interfaces.
Sun, Oct 4, 5:14 PM
hselasky added inline comments to D21863: ugensa: add support for Google Cr50 (GSC) Closed Case Debugging UART interfaces.
Sun, Oct 4, 5:12 PM
hselasky accepted D26651: linuxkpi: MODULE_DEVICE_TABLE to MODULE_PNP_INFO.
Sun, Oct 4, 3:01 PM
hselasky accepted D26657: linuxkpi: populate the acquire context field of a ww_mutex.

Looks good. You need someone to commit this?

Sun, Oct 4, 2:21 PM · linuxkpi

Sat, Oct 3

hselasky committed rP551339: Add missing LD_PRELOAD= environment variable to the virtual_oss rc.d ..
Add missing LD_PRELOAD= environment variable to the virtual_oss rc.d .
Sat, Oct 3, 7:23 PM
hselasky added a comment to D26651: linuxkpi: MODULE_DEVICE_TABLE to MODULE_PNP_INFO.

Format should use "J" instead, I guess, because it allows -1 as ignore value.

Sat, Oct 3, 6:40 PM
hselasky added a comment to D26651: linuxkpi: MODULE_DEVICE_TABLE to MODULE_PNP_INFO.

Also sadly add subvendor, etc. fields as comments at the end

to the descriptor_string seem to prevent autoloading and that

Sat, Oct 3, 6:35 PM
hselasky added inline comments to D26651: linuxkpi: MODULE_DEVICE_TABLE to MODULE_PNP_INFO.
Sat, Oct 3, 6:34 PM

Fri, Oct 2

hselasky added inline comments to D26598: linuxkpi: upstream drm-kmod conflicting changes.
Fri, Oct 2, 2:42 PM

Thu, Oct 1

hselasky added inline comments to D21863: ugensa: add support for Google Cr50 (GSC) Closed Case Debugging UART interfaces.
Thu, Oct 1, 4:34 PM
hselasky added inline comments to D21863: ugensa: add support for Google Cr50 (GSC) Closed Case Debugging UART interfaces.
Thu, Oct 1, 4:13 PM
hselasky added inline comments to D26598: linuxkpi: upstream drm-kmod conflicting changes.
Thu, Oct 1, 1:50 PM
hselasky accepted D26603: LinuxKPI: Implement ACPI bits required by drm-kmod in base system..

Make sure this code compiles for all platforms we have before committing. Not only amd64 and aarch64.

Thu, Oct 1, 7:16 AM

Sep 30 2020

hselasky added inline comments to D26603: LinuxKPI: Implement ACPI bits required by drm-kmod in base system..
Sep 30 2020, 10:54 AM
hselasky added a reviewer for D26603: LinuxKPI: Implement ACPI bits required by drm-kmod in base system.: kib.
Sep 30 2020, 10:53 AM
hselasky added a comment to D26598: linuxkpi: upstream drm-kmod conflicting changes.

This change looks good. Just address @kib's comments.

Sep 30 2020, 7:11 AM