- User Since
- Nov 28 2014, 6:55 PM (147 w, 1 d)
Fri, Sep 22
Wed, Sep 20
Tue, Sep 19
Yes, server and client can use same object, and that is what happens with the current patch when the "mem" handle is the same.
@kib : How can two different processes share a piece of memory if not using the same VM object?
There is one more requirement. If I create a swap object I need to be able to offset inside the swap object. Is that supported?
What callbacks ? If you unref the allocated vm objects on cuse.ko unload, VM will correctly free both objects and objects page queues when the last process unmaps it. For OBJT_SWAP you do not need to do anything else except releasing _your_ references.
If the shared communication memory is still mapped when cuse.ko is unloaded, what should happen ? I do not think that it is really possible to track such situations and prevent cuse.ko unload without huge and really unneeded efforts. Leaving the deallocation of the objects to normal VM lifecycle rules avoids unnecessary troubles, IMO.
Can you explain why did you claimed, in the conversation with Mark, that the swap object does not work for you ?
Mon, Sep 18
Set correct size of allocated VM object in case there is an offset within the object requested by the mmap().
Fix some bugs found during testing.
Looks good to me.
Rework patch based on input.
Sat, Sep 16
Wed, Sep 13
Mon, Sep 11
Thank you. Currently reviewing this patch in Mellanox.
Sat, Sep 9
Thu, Sep 7
Wed, Sep 6
Can everyone have a look at this patch again and press accept ? I want to push this patch unless there are any major blockers.
Instead of using tags have you considered a modified if_transmit that returns the current occupancy-level of the tx queue (as a percentage or some normalized representation)? That would make it fully stateless and we wouldn't have to involve any inp in any of this. Any feature hooked up to inp will work only for IP connections that terminate on that node and not, say, packet forwarding use cases.
Tue, Aug 29
Mon, Aug 28
Aug 24 2017
Aug 23 2017
Can you add a port option to set DEBUG_FLAGS="-g" ??
Aug 21 2017
Aug 20 2017
Aug 17 2017
The LinuxKPI bits look good to me. Please address John Baldwins comments before committing.
Aug 16 2017
This patch looks good to me. @gallatin do you want to test it aswell before it reaches -head? I'll give it a spin tomorrow.
Aug 15 2017
Aug 14 2017
Aug 13 2017
I'll have a closer look at this tomorrow. Thank you!
Aug 11 2017
Aug 10 2017
Looks good. Try to make the commit message a bit clearer: