Page MenuHomeFreeBSD

hselasky (Hans Petter Selasky)
User

Projects

User Details

User Since
Nov 28 2014, 6:55 PM (203 w, 1 d)

Recent Activity

Today

hselasky added a comment to D17616: Add missing function attributes and assert for refcount_acquire_if_not_zero() and refcount_acquire_if_not_last().

@kib : Only refcount_release() can be called w/o checking the returned result, so I didn't add an attribute for that function. The others should be fine from what I can see.

Sun, Oct 21, 8:54 AM
hselasky updated the diff for D17616: Add missing function attributes and assert for refcount_acquire_if_not_zero() and refcount_acquire_if_not_last().

Update assert message, suggested by @kib .

Sun, Oct 21, 8:52 AM

Yesterday

hselasky updated the diff for D17616: Add missing function attributes and assert for refcount_acquire_if_not_zero() and refcount_acquire_if_not_last().

Minor refactor.

Sat, Oct 20, 7:47 AM
hselasky retitled D17616: Add missing function attributes and assert for refcount_acquire_if_not_zero() and refcount_acquire_if_not_last() from Add missing function attributes and assert for refcount_acquire_if_not_zero() to Add missing function attributes and assert for refcount_acquire_if_not_zero() and refcount_acquire_if_not_last().
Sat, Oct 20, 7:44 AM
hselasky updated the diff for D17616: Add missing function attributes and assert for refcount_acquire_if_not_zero() and refcount_acquire_if_not_last().

I think the return value of refcount_release() should also be checked, but I see many users in the kernel which don't check it.

Sat, Oct 20, 7:44 AM

Fri, Oct 19

hselasky added a parent revision for D17617: Fix for use-after-free in if_vlan.c: D17599: Fix for deadlock and race deleting entries for epoch managed lists.
Fri, Oct 19, 5:56 PM
hselasky added a child revision for D17599: Fix for deadlock and race deleting entries for epoch managed lists: D17617: Fix for use-after-free in if_vlan.c.
Fri, Oct 19, 5:56 PM
hselasky created D17617: Fix for use-after-free in if_vlan.c.
Fri, Oct 19, 5:55 PM
hselasky updated the diff for D17599: Fix for deadlock and race deleting entries for epoch managed lists.

Use already existing refcount_acquire_if_not_zero(). Suggested by @mjg .

Fri, Oct 19, 5:46 PM
hselasky edited reviewers for D17616: Add missing function attributes and assert for refcount_acquire_if_not_zero() and refcount_acquire_if_not_last(), added: mjg; removed: mmacy.
Fri, Oct 19, 5:43 PM
hselasky updated the diff for D17616: Add missing function attributes and assert for refcount_acquire_if_not_zero() and refcount_acquire_if_not_last().

Update as per @mjg 's suggestion

Fri, Oct 19, 5:43 PM
hselasky added a comment to D16660: devmatch ugly hack.

Ping is this patch still relevant?

Fri, Oct 19, 5:33 PM
hselasky updated the diff for D17599: Fix for deadlock and race deleting entries for epoch managed lists.

Make sure the return value of ifa_ref() is checked.

Fri, Oct 19, 5:07 PM
hselasky updated the diff for D17616: Add missing function attributes and assert for refcount_acquire_if_not_zero() and refcount_acquire_if_not_last().

Make sure return value is checked.

Fri, Oct 19, 5:02 PM
hselasky updated the diff for D17599: Fix for deadlock and race deleting entries for epoch managed lists.

Updated patch with full context.

Fri, Oct 19, 1:56 PM
hselasky updated the summary of D17616: Add missing function attributes and assert for refcount_acquire_if_not_zero() and refcount_acquire_if_not_last().
Fri, Oct 19, 1:36 PM
hselasky created D17616: Add missing function attributes and assert for refcount_acquire_if_not_zero() and refcount_acquire_if_not_last().
Fri, Oct 19, 1:35 PM
hselasky added a comment to D17598: Properly handle case when system is out of network interface numbers.

@bz: Try modifying the script to create 65536 /dev/tun devices.

Fri, Oct 19, 8:42 AM
hselasky added inline comments to D17598: Properly handle case when system is out of network interface numbers.
Fri, Oct 19, 8:42 AM
hselasky committed rS339443: MFC r339388:.
MFC r339388:
Fri, Oct 19, 8:40 AM
hselasky committed rS339442: MFC r339388:.
MFC r339388:
Fri, Oct 19, 8:38 AM
hselasky added a comment to D17598: Properly handle case when system is out of network interface numbers.

Silly question; can you explain that test case? How do 255 multicast addresses assigned to 255 interfaces make you run out of ifindex space?

Fri, Oct 19, 8:34 AM
hselasky updated the test plan for D17598: Properly handle case when system is out of network interface numbers.
Fri, Oct 19, 8:30 AM

Thu, Oct 18

hselasky added inline comments to D17598: Properly handle case when system is out of network interface numbers.
Thu, Oct 18, 7:40 PM
hselasky updated the diff for D17598: Properly handle case when system is out of network interface numbers.

Found more issues related - fix while at it.

Thu, Oct 18, 2:05 PM
hselasky updated the diff for D17598: Properly handle case when system is out of network interface numbers.

Update as per kib's suggestion.

Thu, Oct 18, 11:51 AM
hselasky updated the diff for D17598: Properly handle case when system is out of network interface numbers.

Patch with full context.

Thu, Oct 18, 10:36 AM

Wed, Oct 17

hselasky added a reviewer for D17598: Properly handle case when system is out of network interface numbers: slavash.
Wed, Oct 17, 5:35 PM
hselasky created D17599: Fix for deadlock and race deleting entries for epoch managed lists.
Wed, Oct 17, 5:33 PM
hselasky updated the summary of D17598: Properly handle case when system is out of network interface numbers.
Wed, Oct 17, 4:51 PM
hselasky created D17598: Properly handle case when system is out of network interface numbers.
Wed, Oct 17, 4:50 PM

Tue, Oct 16

hselasky committed rS339388: Fix for reception of large full speed isochronous frames via the transaction.
Fix for reception of large full speed isochronous frames via the transaction
Tue, Oct 16, 6:47 PM

Mon, Oct 15

hselasky closed D17496: Fix deadlock when destroying VLANs.
Mon, Oct 15, 10:29 AM
hselasky committed rS339358: Fix deadlock when destroying VLANs..
Fix deadlock when destroying VLANs.
Mon, Oct 15, 10:29 AM

Thu, Oct 11

hselasky accepted D17516: libusb(3): Update the link to the libusb homepage..
Thu, Oct 11, 1:14 PM
hselasky committed rS339302: MFC r339235:.
MFC r339235:
Thu, Oct 11, 7:35 AM

Wed, Oct 10

hselasky updated the summary of D17496: Fix deadlock when destroying VLANs.
Wed, Oct 10, 7:57 AM
hselasky updated the summary of D17496: Fix deadlock when destroying VLANs.
Wed, Oct 10, 7:56 AM
hselasky created D17496: Fix deadlock when destroying VLANs.
Wed, Oct 10, 7:54 AM

Mon, Oct 8

hselasky committed rS339235: Add missing steering rules for virtual function, VF, in mlx4en(4) driver..
Add missing steering rules for virtual function, VF, in mlx4en(4) driver.
Mon, Oct 8, 2:52 PM

Fri, Oct 5

hselasky committed rS339191: MFC r338993:.
MFC r338993:
Fri, Oct 5, 7:52 AM
hselasky committed rS339190: MFC r338993:.
MFC r338993:
Fri, Oct 5, 7:51 AM
hselasky committed rS339189: MFC r338993:.
MFC r338993:
Fri, Oct 5, 7:49 AM

Tue, Oct 2

hselasky committed rS339086: Selectivly backport fix for firmware command hang when switching from.
Selectivly backport fix for firmware command hang when switching from
Tue, Oct 2, 4:01 PM

Fri, Sep 28

hselasky committed rS338993: When multiple threads are involved receiving completion events in LibUSB.
When multiple threads are involved receiving completion events in LibUSB
Fri, Sep 28, 10:28 AM

Sep 19 2018

hselasky committed rS338793: MFC r338679:.
MFC r338679:
Sep 19 2018, 8:14 AM
hselasky committed rS338792: MFC r338679:.
MFC r338679:
Sep 19 2018, 8:13 AM
hselasky committed rS338791: MFC r338679:.
MFC r338679:
Sep 19 2018, 8:11 AM
hselasky committed rS338790: MFC r338616:.
MFC r338616:
Sep 19 2018, 8:10 AM
hselasky committed rS338789: MFC r338616:.
MFC r338616:
Sep 19 2018, 7:57 AM
hselasky committed rS338788: MFC r338616:.
MFC r338616:
Sep 19 2018, 7:56 AM

Sep 17 2018

hselasky committed rS338709: MFC r338613:.
MFC r338613:
Sep 17 2018, 11:24 AM

Sep 14 2018

hselasky committed rS338679: Improve LibUSB debugging by simultaneously allowing both function.
Improve LibUSB debugging by simultaneously allowing both function
Sep 14 2018, 1:41 PM

Sep 12 2018

hselasky committed rS338616: Fix issues about cancelling USB transfers in LibUSB when the USB device has.
Fix issues about cancelling USB transfers in LibUSB when the USB device has
Sep 12 2018, 3:06 PM
hselasky committed rS338615: Fix incorrect display of the sys.class.infiniband.xxx.ports.1.rate sysctl.
Fix incorrect display of the sys.class.infiniband.xxx.ports.1.rate sysctl
Sep 12 2018, 10:53 AM
hselasky committed rS338613: Fix for backends which doesn't support capsicum..
Fix for backends which doesn't support capsicum.
Sep 12 2018, 10:10 AM
hselasky committed rS338612: MFC r338491:.
MFC r338491:
Sep 12 2018, 8:56 AM

Sep 11 2018

hselasky committed rS338588: Fix compile warning about missing prototype when WANT_FUNCTIONS is defined..
Fix compile warning about missing prototype when WANT_FUNCTIONS is defined.
Sep 11 2018, 3:56 PM

Sep 10 2018

hselasky committed rS338557: MFC r338541:.
MFC r338541:
Sep 10 2018, 8:19 AM
hselasky committed rS338556: MFC r338526:.
MFC r338526:
Sep 10 2018, 8:17 AM
hselasky committed rS338555: MFC r338495:.
MFC r338495:
Sep 10 2018, 8:15 AM
hselasky committed rS338554: MFC r338493:.
MFC r338493:
Sep 10 2018, 8:13 AM
hselasky committed rS338553: MFC r338492:.
MFC r338492:
Sep 10 2018, 8:11 AM
hselasky committed rS338552: MFC r338492:.
MFC r338492:
Sep 10 2018, 8:09 AM
hselasky committed rS338551: MFC r338490:.
MFC r338490:
Sep 10 2018, 8:06 AM
hselasky committed rS338550: MFC r338490:.
MFC r338490:
Sep 10 2018, 8:05 AM
hselasky committed rS338549: MFC r338489:.
MFC r338489:
Sep 10 2018, 8:04 AM
hselasky committed rS338548: MFC r338489:.
MFC r338489:
Sep 10 2018, 8:02 AM

Sep 9 2018

hselasky committed rS338541: Introduce and use sgid_index in CM requests in ibcore..
Introduce and use sgid_index in CM requests in ibcore.
Sep 9 2018, 7:20 AM

Sep 7 2018

hselasky committed rS338526: Implement get network interface by params function in ipoib..
Implement get network interface by params function in ipoib.
Sep 7 2018, 6:05 PM

Sep 6 2018

hselasky committed rS338495: Add proper support for VIMAGE to krping..
Add proper support for VIMAGE to krping.
Sep 6 2018, 2:03 PM
hselasky committed rS338493: Make the MSIX module parameter limit per device, in mlx5en(4)..
Make the MSIX module parameter limit per device, in mlx5en(4).
Sep 6 2018, 12:41 PM
hselasky committed rS338492: Add support for receive side scaling stride, RSSS, in mlx5en(4)..
Add support for receive side scaling stride, RSSS, in mlx5en(4).
Sep 6 2018, 12:28 PM
hselasky committed rS338489: Maximum number of mbuf frags is off-by-one for worst case scenario in mlx5en(4)..
Maximum number of mbuf frags is off-by-one for worst case scenario in mlx5en(4).
Sep 6 2018, 12:26 PM
hselasky committed rS338490: Don't stall transmit queue on drops in mlx5en(4)..
Don't stall transmit queue on drops in mlx5en(4).
Sep 6 2018, 12:26 PM

Aug 31 2018

hselasky accepted D16974: Add u3g ppp.conf entry..
Aug 31 2018, 3:58 PM

Aug 24 2018

hselasky added a comment to D15259: Add netdump hooks for mlxen(4)..

We have this patched queued internally for testing and review. You'd like to have it in before 12 is out?

Aug 24 2018, 7:03 AM

Aug 22 2018

hselasky accepted D16731: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types.
Aug 22 2018, 7:35 AM
hselasky added a comment to D16731: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types.

I think "GBase" was the common before this change aswell.

Aug 22 2018, 7:25 AM

Aug 21 2018

hselasky added inline comments to D16731: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types.
Aug 21 2018, 5:48 PM
hselasky accepted D16731: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types.
Aug 21 2018, 5:47 PM

Aug 20 2018

hselasky added a comment to D16772: Fixing a broken touchscreen controller.

Roberto, can you plug the failing device w/o your patch, setting:

Aug 20 2018, 12:30 PM
hselasky commandeered D16772: Fixing a broken touchscreen controller.
Aug 20 2018, 12:26 PM
hselasky edited reviewers for D16772: Fixing a broken touchscreen controller, added: wulf; removed: bapt, bdrewery, jhb, dim, gleb, glebius, garga, jhibbits.
Aug 20 2018, 12:25 PM
hselasky requested changes to D16772: Fixing a broken touchscreen controller.

I think your patch is wrong.

Aug 20 2018, 12:24 PM
hselasky updated subscribers of D16731: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types.
Aug 20 2018, 9:24 AM
hselasky added a comment to D16731: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types.

I see IFM_40G_ER4 is missing from the table. There is only IFM_40G_LR4 currently.

Aug 20 2018, 9:10 AM
hselasky accepted D16799: Eliminate the unused arena parameter from kmem_alloc_contig().
Aug 20 2018, 7:54 AM
hselasky added inline comments to D16799: Eliminate the unused arena parameter from kmem_alloc_contig().
Aug 20 2018, 7:54 AM

Aug 19 2018

hselasky added inline comments to D16799: Eliminate the unused arena parameter from kmem_alloc_contig().
Aug 19 2018, 6:46 PM
hselasky added a comment to D16721: Touchscreen support for Touchscreens on amd64 and i386 platforms.

I think the reason HID picks up the device first will be solved by:
https://reviews.freebsd.org/D16735

Aug 19 2018, 6:33 PM

Aug 18 2018

hselasky added inline comments to D16735: Create devctl freeze/thaw..
Aug 18 2018, 9:33 AM

Aug 17 2018

hselasky accepted D16772: Fixing a broken touchscreen controller.

Can you explain the change with a few words?

Aug 17 2018, 4:21 PM

Aug 16 2018

hselasky added a comment to D16721: Touchscreen support for Touchscreens on amd64 and i386 platforms.

I'm just wondering if the name TOUCHSCREEN is too generic.

Aug 16 2018, 9:33 AM
hselasky committed rS337898: MFC r337527:.
MFC r337527:
Aug 16 2018, 8:12 AM
hselasky committed rS337897: MFC r337376:.
MFC r337376:
Aug 16 2018, 8:11 AM
hselasky committed rS337896: MFC r337374:.
MFC r337374:
Aug 16 2018, 8:10 AM
hselasky committed rS337895: MFC r337373:.
MFC r337373:
Aug 16 2018, 8:09 AM
hselasky committed rS337894: MFC r337232:.
MFC r337232:
Aug 16 2018, 8:08 AM
hselasky committed rS337893: MFC r337529:.
MFC r337529:
Aug 16 2018, 8:05 AM