Page MenuHomeFreeBSD

hselasky (Hans Petter Selasky)
User

Projects

User Details

User Since
Nov 28 2014, 6:55 PM (220 w, 2 d)

Recent Activity

Fri, Feb 15

hselasky committed rS344147: MFC r343905:.
MFC r343905:
Fri, Feb 15, 9:26 AM
hselasky committed rS344146: MFC r343905:.
MFC r343905:
Fri, Feb 15, 9:22 AM
hselasky committed rS344145: MFC r343905:.
MFC r343905:
Fri, Feb 15, 9:21 AM
hselasky committed rS344144: MFC r343905:.
MFC r343905:
Fri, Feb 15, 9:20 AM

Mon, Feb 11

hselasky accepted D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.
Mon, Feb 11, 1:05 PM

Fri, Feb 8

hselasky committed rS343905: Improve Bluetooth device discovery support for Android and Microsoft devices..
Improve Bluetooth device discovery support for Android and Microsoft devices.
Fri, Feb 8, 1:11 PM
hselasky committed rS343903: MFC r343572:.
MFC r343572:
Fri, Feb 8, 10:32 AM
hselasky committed rS343902: MFC r343572:.
MFC r343572:
Fri, Feb 8, 10:28 AM
hselasky committed rS343901: MFC r343572:.
MFC r343572:
Fri, Feb 8, 10:27 AM
hselasky committed rS343900: MFC r343572:.
MFC r343572:
Fri, Feb 8, 10:25 AM

Wed, Feb 6

hselasky committed rS343840: MFC r343584:.
MFC r343584:
Wed, Feb 6, 6:03 PM

Mon, Feb 4

hselasky added a reviewer for D19063: mlx5en: add pfil ethernet hook: kib.
Mon, Feb 4, 8:39 AM

Sat, Feb 2

hselasky added a reviewer for D19063: mlx5en: add pfil ethernet hook: slavash.
Sat, Feb 2, 3:31 PM

Fri, Feb 1

hselasky added inline comments to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.
Fri, Feb 1, 4:36 PM
hselasky added inline comments to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.
Fri, Feb 1, 2:27 PM
hselasky committed rS343658: MFC r343453:.
MFC r343453:
Fri, Feb 1, 10:10 AM
hselasky committed rS343657: MFC r343453:.
MFC r343453:
Fri, Feb 1, 10:09 AM
hselasky committed rS343656: MFC r343453:.
MFC r343453:
Fri, Feb 1, 10:08 AM
hselasky committed rS343655: MFC r343451:.
MFC r343451:
Fri, Feb 1, 10:06 AM
hselasky committed rS343654: MFC r343451:.
MFC r343451:
Fri, Feb 1, 10:06 AM
hselasky committed rS343651: Build fix for missing NET_EPOCH_XXX() dependencies after r343650..
Build fix for missing NET_EPOCH_XXX() dependencies after r343650.
Fri, Feb 1, 9:19 AM
hselasky committed rS343650: MFC r343395:.
MFC r343395:
Fri, Feb 1, 9:08 AM
hselasky committed rS343649: MFC r343394:.
MFC r343394:
Fri, Feb 1, 9:07 AM
hselasky committed rS343648: MFC r343393:.
MFC r343393:
Fri, Feb 1, 9:07 AM
hselasky committed rS343647: MFC r343392:.
MFC r343392:
Fri, Feb 1, 9:05 AM

Thu, Jan 31

hselasky added a comment to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.
In D19032#407220, @rrs wrote:

I don't follow your suggestion. Why would I add a if_snd_tag_free() in if_attach_internal() .
The driver below has to do that just like it has to add the if_snd_tag_alloc(). The
internal function has no way of knowing what is the right thing to do in
freeing a tag that the driver allocates. Having it be NULL as the default in
the internal just the same as if_snd_tag_alloc() is the right thing, only
if a driver sets these should they get used (when RATELIMIT is configured of course)

Thu, Jan 31, 9:25 PM

Wed, Jan 30

hselasky accepted D19040: Don't set IFCAP_TXRTLMT during lagg_clone_create()..

Looks good.

Wed, Jan 30, 9:39 PM
hselasky committed rS343584: Export vendor specific USB MIDI device list to PnP info..
Export vendor specific USB MIDI device list to PnP info.
Wed, Jan 30, 5:11 PM
hselasky added a comment to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.
In D19032#406795, @rrs wrote:

Hi,

Wed, Jan 30, 5:01 PM
hselasky added a comment to D19032: Balance the if_snd_tag_alloc with an appropriate if_snd_tag_free.

This patch does not look correct. You will need to pass the flowid in order to correctly handle this inside lagg?

Wed, Jan 30, 2:07 PM
hselasky committed rS343572: Add support for Audio Sink and Audio Source profiles to sdpd(8)..
Add support for Audio Sink and Audio Source profiles to sdpd(8).
Wed, Jan 30, 9:45 AM

Fri, Jan 25

hselasky accepted D18904: Make arp return errors.
Fri, Jan 25, 8:26 PM
hselasky committed rS343453: Add new USB quirk..
Add new USB quirk.
Fri, Jan 25, 8:20 PM
hselasky closed D18917: Add another quirk for the CORSAIR STRAFE keyboard.
Fri, Jan 25, 8:20 PM
hselasky accepted D18917: Add another quirk for the CORSAIR STRAFE keyboard.
Fri, Jan 25, 8:18 PM
hselasky committed rS343451: Add full support for PCI_ANY_ID when matching PCI IDs in the LinuxKPI..
Add full support for PCI_ANY_ID when matching PCI IDs in the LinuxKPI.
Fri, Jan 25, 8:13 PM

Thu, Jan 24

hselasky committed rP491085: Fix build with GCC-based architectures..
Fix build with GCC-based architectures.
Thu, Jan 24, 9:33 AM
hselasky committed rS343395: Fix refcounting leaks in IPv6 MLD code leading to loss of IPv6.
Fix refcounting leaks in IPv6 MLD code leading to loss of IPv6
Thu, Jan 24, 8:34 AM
hselasky committed rS343394: When detaching a network interface drain the workqueue freeing the inm's.
When detaching a network interface drain the workqueue freeing the inm's
Thu, Jan 24, 8:25 AM
hselasky committed rS343393: Add debugging sysctl to disable incoming MLD v2 messages similar to the.
Add debugging sysctl to disable incoming MLD v2 messages similar to the
Thu, Jan 24, 8:18 AM
hselasky closed D18887: Fix refcounting leaks in IPv6 MLD code leading to loss of IPv6 connectivity.
Thu, Jan 24, 8:16 AM
hselasky committed rS343392: Fix duplicate acquiring of refcount when joining IPv6 multicast groups..
Fix duplicate acquiring of refcount when joining IPv6 multicast groups.
Thu, Jan 24, 8:16 AM

Wed, Jan 23

hselasky updated the diff for D18887: Fix refcounting leaks in IPv6 MLD code leading to loss of IPv6 connectivity.

Address comments from @bz . Fix a CTR statement which was accessing an uninitialized variable.

Wed, Jan 23, 7:14 PM
hselasky added inline comments to D18887: Fix refcounting leaks in IPv6 MLD code leading to loss of IPv6 connectivity.
Wed, Jan 23, 7:00 PM
hselasky committed rS343352: Add USB quirk..
Add USB quirk.
Wed, Jan 23, 6:53 PM

Jan 18 2019

hselasky added a comment to D18887: Fix refcounting leaks in IPv6 MLD code leading to loss of IPv6 connectivity.
In D18887#403208, @bz wrote:

(a) there's one or two lines of whitespace changes in there; can we get them sorted separately?

Jan 18 2019, 1:35 PM
hselasky updated the diff for D18887: Fix refcounting leaks in IPv6 MLD code leading to loss of IPv6 connectivity.

Whitespace diff reduction.

Jan 18 2019, 1:31 PM
hselasky added a comment to D18887: Fix refcounting leaks in IPv6 MLD code leading to loss of IPv6 connectivity.
In D18887#403202, @kib wrote:

Can you add an explanation which of this changes fixes loss of ipv6 connectivity, and why the problem occurred in the first place.

Jan 18 2019, 12:18 PM
hselasky updated the summary of D18887: Fix refcounting leaks in IPv6 MLD code leading to loss of IPv6 connectivity.
Jan 18 2019, 12:18 PM
hselasky updated the diff for D18887: Fix refcounting leaks in IPv6 MLD code leading to loss of IPv6 connectivity.

Fixed a whitespaces vs tabs issue.

Jan 18 2019, 11:48 AM
hselasky created D18887: Fix refcounting leaks in IPv6 MLD code leading to loss of IPv6 connectivity.
Jan 18 2019, 11:43 AM
hselasky committed rS343139: MFC r342884:.
MFC r342884:
Jan 18 2019, 8:59 AM
hselasky committed rS343138: MFC r342884:.
MFC r342884:
Jan 18 2019, 8:57 AM
hselasky committed rS343137: MFC r342884:.
MFC r342884:
Jan 18 2019, 8:55 AM
hselasky committed rS343136: MFC r342778:.
MFC r342778:
Jan 18 2019, 8:49 AM
hselasky committed rS343135: MFC r342778:.
MFC r342778:
Jan 18 2019, 8:48 AM
hselasky committed rS343134: MFC r342778:.
MFC r342778:
Jan 18 2019, 8:48 AM
hselasky committed rS343133: MFC r342730:.
MFC r342730:
Jan 18 2019, 8:46 AM
hselasky committed rS343132: MFC r342730:.
MFC r342730:
Jan 18 2019, 8:45 AM
hselasky committed rS343131: MFC r342730:.
MFC r342730:
Jan 18 2019, 8:44 AM

Jan 12 2019

hselasky committed rS342961: snd_uaudio: Add quirks for Edirol UA-25EX in advanced driver mode..
snd_uaudio: Add quirks for Edirol UA-25EX in advanced driver mode.
Jan 12 2019, 11:15 AM

Jan 9 2019

hselasky accepted D18791: devel/libevdev, devel/libmtdev: advertise evdev-proto as API dependency.

I don't see any issues here. And I'm not a ports expert :-)

Jan 9 2019, 2:37 PM
hselasky closed D18769: Fix broken IPv6 scope ID checks in outgoing direction.
Jan 9 2019, 2:28 PM
hselasky committed rS342884: Fix loopback traffic when using non-lo0 link local IPv6 addresses..
Fix loopback traffic when using non-lo0 link local IPv6 addresses.
Jan 9 2019, 2:28 PM
hselasky added a comment to D18769: Fix broken IPv6 scope ID checks in outgoing direction.
In D18769#400969, @ae wrote:

So, why you think that this is wrong and shouldn't happen?

Because then TCP loopback on non-lo0 link-local addresses won't work.

Can you show an example? I just tested and it works:

% nc -6 -l fe80::e6a7:a0ff:fe8e:16bf%lagg0 1234
TEST
% nc -6 fe80::e6a7:a0ff:fe8e:16bf%lagg0 1234
TEST
Jan 9 2019, 11:16 AM
hselasky added a comment to D18769: Fix broken IPv6 scope ID checks in outgoing direction.

Would it be possible to include firewalls in the test plan?
For example, ensure that ipfw still accepts the packet using something like 'allow ip6 from any to any via lo0' rule.

Jan 9 2019, 10:45 AM
hselasky added a comment to D18769: Fix broken IPv6 scope ID checks in outgoing direction.
In D18769#400616, @ae wrote:

The current code would drop packets which are designated for loopback which use a link-local scope ID in the destination address or source address, because they won't match the lo0's scope ID.

So, why you think that this is wrong and shouldn't happen?

Jan 9 2019, 10:43 AM

Jan 7 2019

hselasky updated the diff for D18769: Fix broken IPv6 scope ID checks in outgoing direction.

Address comments by bz@ .

Jan 7 2019, 2:34 PM
hselasky added inline comments to D18769: Fix broken IPv6 scope ID checks in outgoing direction.
Jan 7 2019, 2:26 PM
hselasky added a reviewer for D18769: Fix broken IPv6 scope ID checks in outgoing direction: bz.
Jan 7 2019, 2:07 PM
hselasky created D18769: Fix broken IPv6 scope ID checks in outgoing direction.
Jan 7 2019, 12:33 PM

Jan 4 2019

hselasky committed rS342778: Reduce timeout for reading the USB HUB port status to 1000ms and try to filter.
Reduce timeout for reading the USB HUB port status to 1000ms and try to filter
Jan 4 2019, 9:09 PM

Jan 3 2019

hselasky committed rS342730: Improve USB generic debug messages. Print process ID and name when opening.
Improve USB generic debug messages. Print process ID and name when opening
Jan 3 2019, 2:28 PM
hselasky committed rS342729: MFC r342549:.
MFC r342549:
Jan 3 2019, 9:30 AM
hselasky committed rS342728: MFC r342456:.
MFC r342456:
Jan 3 2019, 9:29 AM
hselasky committed rS342727: MFC r342549:.
MFC r342549:
Jan 3 2019, 9:28 AM
hselasky committed rS342726: MFC r342549:.
MFC r342549:
Jan 3 2019, 9:27 AM
hselasky committed rS342725: MFC r342549:.
MFC r342549:
Jan 3 2019, 9:27 AM
hselasky committed rS342724: MFC r342456:.
MFC r342456:
Jan 3 2019, 9:25 AM
hselasky committed rS342723: MFC r342456:.
MFC r342456:
Jan 3 2019, 9:24 AM
hselasky committed rS342722: MFC r342456:.
MFC r342456:
Jan 3 2019, 9:23 AM

Dec 30 2018

hselasky added a comment to D18606: Fix linux_destroy_dev() behaviour when there are still files open from the destroying cdev..

What happend to the diffs in this differential revision?

Dec 30 2018, 3:38 PM

Dec 27 2018

hselasky committed rS342549: Add USB quirk for SPL Crimson Rev 1..
Add USB quirk for SPL Crimson Rev 1.
Dec 27 2018, 8:29 AM

Dec 25 2018

hselasky committed rS342456: Fix reading of USB sample rate descriptor for SPL Crimson Rev 1..
Fix reading of USB sample rate descriptor for SPL Crimson Rev 1.
Dec 25 2018, 10:16 AM

Dec 19 2018

hselasky added a comment to D18606: Fix linux_destroy_dev() behaviour when there are still files open from the destroying cdev..

@johalun0_gmail.com : Can you test this patch with DRM code?

Dec 19 2018, 2:13 PM
hselasky added a reviewer for D18606: Fix linux_destroy_dev() behaviour when there are still files open from the destroying cdev.: johalun0_gmail.com.
Dec 19 2018, 2:12 PM
hselasky added a comment to D18606: Fix linux_destroy_dev() behaviour when there are still files open from the destroying cdev..
In D18606#396732, @kib wrote:

Does this code handle forking of file descriptors?

What do you mean by forking ? Duping happens at descriptors layer, not file.

Dec 19 2018, 12:21 PM
hselasky added inline comments to D18606: Fix linux_destroy_dev() behaviour when there are still files open from the destroying cdev..
Dec 19 2018, 12:20 PM
hselasky added a comment to D18606: Fix linux_destroy_dev() behaviour when there are still files open from the destroying cdev..

Does this code handle forking of file descriptors?

Dec 19 2018, 10:50 AM
hselasky committed rS342216: MFC r341844:.
MFC r341844:
Dec 19 2018, 8:50 AM
hselasky committed rS342215: MFC r341844:.
MFC r341844:
Dec 19 2018, 8:49 AM

Dec 14 2018

hselasky committed rP487418: Fix devd rule for Logitech gamepad..
Fix devd rule for Logitech gamepad.
Dec 14 2018, 9:40 AM

Dec 13 2018

hselasky committed rP487369: Add devd rule for a Logitech gamepad..
Add devd rule for a Logitech gamepad.
Dec 13 2018, 2:52 PM
hselasky committed rP487368: Update webcamd to version 4.20.0.1.
Update webcamd to version 4.20.0.1
Dec 13 2018, 2:24 PM
hselasky committed rS342037: MFC r334648:.
MFC r334648:
Dec 13 2018, 10:34 AM
hselasky committed rS342036: MFC r334648:.
MFC r334648:
Dec 13 2018, 10:34 AM

Dec 12 2018

hselasky committed rS341987: MFC r341587:.
MFC r341587:
Dec 12 2018, 1:20 PM
hselasky committed rS341986: MFC r341587:.
MFC r341587:
Dec 12 2018, 1:20 PM
hselasky committed rS341985: MFC r341586:.
MFC r341586:
Dec 12 2018, 1:16 PM
hselasky committed rS341984: MFC r341585:.
MFC r341585:
Dec 12 2018, 1:16 PM