hselasky (Hans Petter Selasky)
User

Projects

User Details

User Since
Nov 28 2014, 6:55 PM (164 w, 1 d)

Recent Activity

Fri, Jan 19

hselasky added a comment to D13975: Add info about c99 designationed initializers..

Instead of referring C99 initializers, you can also say: initialization by record is preferred.

Fri, Jan 19, 5:02 PM
hselasky committed rS328163: Add new USB ID to U3G driver..
Add new USB ID to U3G driver.
Fri, Jan 19, 1:06 PM
hselasky committed rS328162: Improve support for USB based 3G/4G/5G dongles from Huawei..
Improve support for USB based 3G/4G/5G dongles from Huawei.
Fri, Jan 19, 12:59 PM
hselasky accepted D13975: Add info about c99 designationed initializers..
Fri, Jan 19, 7:35 AM

Tue, Jan 16

hselasky accepted D13920: Add sysctls to control device side USB identifiers..

Looks good!

Tue, Jan 16, 4:02 PM
hselasky added inline comments to D13920: Add sysctls to control device side USB identifiers..
Tue, Jan 16, 11:38 AM
hselasky added inline comments to D13920: Add sysctls to control device side USB identifiers..
Tue, Jan 16, 11:34 AM

Mon, Jan 15

hselasky accepted D13924: Add usb_template to RPI-B.
Mon, Jan 15, 10:06 PM
hselasky added a comment to D13920: Add sysctls to control device side USB identifiers..

I'll have a look at this tomorrow. Getting late now.

Mon, Jan 15, 10:04 PM
hselasky committed rP459122: Enable STDIO backend by default..
Enable STDIO backend by default.
Mon, Jan 15, 9:59 PM
hselasky updated the diff for D4605: Properly stop timer before freeing link level entries for IPv4 and IPv6.

Update patch for 12-current

Mon, Jan 15, 2:30 PM

Thu, Dec 28

hselasky accepted D13445: Improve usbconfig(8) manual page.

Thank you. This looks good!

Thu, Dec 28, 4:05 PM

Dec 20 2017

hselasky added a comment to D13530: Properly define static mutex in mlx4 core.

Try to look at the generated assembly code from the compiler. The section attributes should be clearly marked in the output.

Dec 20 2017, 10:03 AM

Dec 18 2017

hselasky created D13530: Properly define static mutex in mlx4 core.
Dec 18 2017, 3:13 PM

Dec 12 2017

hselasky added inline comments to D13445: Improve usbconfig(8) manual page.
Dec 12 2017, 12:30 PM
hselasky added inline comments to D13445: Improve usbconfig(8) manual page.
Dec 12 2017, 12:28 PM

Dec 11 2017

hselasky added a comment to D13445: Improve usbconfig(8) manual page.

Check my comments and update. Thanks!

Dec 11 2017, 1:38 PM

Dec 8 2017

hselasky committed rS326716: Correctly define the unordered_map namespace in ofed/libibnetdisc ..
Correctly define the unordered_map namespace in ofed/libibnetdisc .
Dec 8 2017, 9:01 PM
hselasky committed rS326704: Add support for IPv6 based addresses as part of the TCP unify portspace feature.
Add support for IPv6 based addresses as part of the TCP unify portspace feature
Dec 8 2017, 7:21 PM
hselasky committed rS326703: Add support for IPv6 based addresses as part of the TCP unify portspace feature.
Add support for IPv6 based addresses as part of the TCP unify portspace feature
Dec 8 2017, 7:20 PM
hselasky committed rS326694: MFC r326362:.
MFC r326362:
Dec 8 2017, 3:37 PM
hselasky committed rS326693: MFC r326362:.
MFC r326362:
Dec 8 2017, 3:31 PM
hselasky committed rS326692: MFC r326362:.
MFC r326362:
Dec 8 2017, 3:27 PM
hselasky committed rS326691: MFC r326362:.
MFC r326362:
Dec 8 2017, 3:23 PM

Dec 7 2017

hselasky accepted D13401: mlx4: Remove redundant declarations to fix GCC build.

Just make sure it builds with the default clang and I'll pull this into Mellanox later on. Looks good.

Dec 7 2017, 6:14 PM
hselasky added a comment to D13407: Add missing network interface address event for adding default IPv6 link-local addresses.

@kib: Other places where "EVENTHANDLER_INVOKE(ifaddr_event, ifp)" is used there are no locks involved from what I can see. Correct me if I'm wrong.

Dec 7 2017, 4:11 PM
hselasky created D13407: Add missing network interface address event for adding default IPv6 link-local addresses.
Dec 7 2017, 2:44 PM

Dec 6 2017

hselasky committed rP455641: Update ZynAddSubFx to v3.0.3..
Update ZynAddSubFx to v3.0.3.
Dec 6 2017, 9:57 AM

Dec 5 2017

hselasky committed rS326563: Correctly prefix the infiniband include directory for buildworld. This fixes.
Correctly prefix the infiniband include directory for buildworld. This fixes
Dec 5 2017, 8:25 AM

Dec 4 2017

hselasky added a comment to D13329: Fix make universe with WITH_OFED=yes..

I found it. This change should be the correct one:

Dec 4 2017, 2:11 PM
hselasky added a comment to D13329: Fix make universe with WITH_OFED=yes..

Yes, it looks like you're right. My test-builds picked up /usr/include/xxx instead of /usr/obj/xxx . In the Makefiles for OFED I've added these CFLAGS, but INCLUDEDIR is still pointing to /usr/include instead of /usr/obj/xxx :-(

Dec 4 2017, 1:45 PM
hselasky added a comment to D13329: Fix make universe with WITH_OFED=yes..

Can you check inside your MAKEOBJDIRPEFIX if there is "include/infiniband" and what its contents might be?

Dec 4 2017, 1:02 PM
hselasky added inline comments to D13329: Fix make universe with WITH_OFED=yes..
Dec 4 2017, 12:28 PM
hselasky added inline comments to D13329: Fix make universe with WITH_OFED=yes..
Dec 4 2017, 12:17 PM
hselasky added inline comments to D13329: Fix make universe with WITH_OFED=yes..
Dec 4 2017, 12:15 PM
hselasky committed rS326521: MFC r325897:.
MFC r325897:
Dec 4 2017, 9:54 AM
hselasky committed rS326520: MFC r325897:.
MFC r325897:
Dec 4 2017, 9:53 AM
hselasky committed rS326519: MFC r326058:.
MFC r326058:
Dec 4 2017, 9:51 AM
hselasky committed rS326517: MFC r326161:.
MFC r326161:
Dec 4 2017, 9:48 AM
hselasky committed rS326515: MFC r326161:.
MFC r326161:
Dec 4 2017, 9:46 AM
hselasky committed rS326514: MFC r326161:.
MFC r326161:
Dec 4 2017, 9:42 AM
hselasky committed rS326513: MFC r326392:.
MFC r326392:
Dec 4 2017, 9:37 AM
hselasky committed rS326512: MFC r326392:.
MFC r326392:
Dec 4 2017, 9:27 AM
hselasky committed rS326511: MFC r326392:.
MFC r326392:
Dec 4 2017, 9:26 AM

Dec 2 2017

hselasky added inline comments to D13329: Fix make universe with WITH_OFED=yes..
Dec 2 2017, 10:34 PM

Nov 30 2017

hselasky committed rS326392: Properly define the VLAN_XXX() function macros to avoid miscompilation when.
Properly define the VLAN_XXX() function macros to avoid miscompilation when
Nov 30 2017, 11:35 AM

Nov 29 2017

hselasky closed D13298: Fix regression issue after r326218.
Nov 29 2017, 11:28 PM
hselasky committed rS326376: The sched_add() function is not only used when the thread is initially.
The sched_add() function is not only used when the thread is initially
Nov 29 2017, 11:28 PM
hselasky added a comment to D13298: Fix regression issue after r326218.

@kib : got it. I'll fix the commit message before pushing the change. Thank you!

Nov 29 2017, 11:04 PM
hselasky updated the summary of D13298: Fix regression issue after r326218.
Nov 29 2017, 10:58 PM
hselasky updated the diff for D13298: Fix regression issue after r326218.

Update as per suggestions from @kib and @jhb .

Nov 29 2017, 10:56 PM
hselasky added a reviewer for D13298: Fix regression issue after r326218: nwhitehorn.
Nov 29 2017, 10:14 PM
hselasky created D13298: Fix regression issue after r326218.
Nov 29 2017, 10:09 PM
hselasky committed rS326362: Disallow TUN and TAP character device IOCTLs to modify the network device.
Disallow TUN and TAP character device IOCTLs to modify the network device
Nov 29 2017, 9:40 AM

Nov 24 2017

hselasky committed rS326170: Remove myself..
Remove myself.
Nov 24 2017, 2:52 PM
hselasky committed rS326169: RoCE/infiniband upgrade to Linux v4.9 for kernel and userspace..
RoCE/infiniband upgrade to Linux v4.9 for kernel and userspace.
Nov 24 2017, 2:51 PM
hselasky committed rS326168: Fix for multi-threaded lib32 compat build on amd64..
Fix for multi-threaded lib32 compat build on amd64.
Nov 24 2017, 2:29 PM
hselasky committed rS326164: Add myself to merge projects/bsd_rdma_4_9 to head..
Add myself to merge projects/bsd_rdma_4_9 to head.
Nov 24 2017, 12:28 PM
hselasky committed rS326162: Merge ^/head r326132 through r326161..
Merge ^/head r326132 through r326161.
Nov 24 2017, 12:13 PM
hselasky committed rS326161: Implement atomic_fetchadd_64() for i386. This function is needed by the.
Implement atomic_fetchadd_64() for i386. This function is needed by the
Nov 24 2017, 12:10 PM
hselasky committed rS326160: Compile fixes for 32-bit architectures..
Compile fixes for 32-bit architectures.
Nov 24 2017, 12:09 PM
hselasky committed rS326159: Compile fix for LINT-NOIP kernel target..
Compile fix for LINT-NOIP kernel target.
Nov 24 2017, 12:06 PM
hselasky committed rS326149: Make sure all tasks are cancelled synchronously in ipoib to avoid.
Make sure all tasks are cancelled synchronously in ipoib to avoid
Nov 24 2017, 9:55 AM
hselasky committed rS326148: Build fix for ipoib when CONFIG_INFINIBAND_IPOIB_CM is defined..
Build fix for ipoib when CONFIG_INFINIBAND_IPOIB_CM is defined.
Nov 24 2017, 9:53 AM
hselasky committed rS326147: Build fix for kernel LINT target..
Build fix for kernel LINT target.
Nov 24 2017, 9:12 AM
hselasky committed rS326146: Simplify the build dependencies when building the OFED libraries..
Simplify the build dependencies when building the OFED libraries.
Nov 24 2017, 9:01 AM

Nov 23 2017

hselasky committed rS326133: Merge ^/head r325999 through r326131..
Merge ^/head r325999 through r326131.
Nov 23 2017, 2:29 PM
hselasky committed rS326127: Make sure the iSCSI I/O limits are set properly so that the ISCSIDSEND IOCTL.
Make sure the iSCSI I/O limits are set properly so that the ISCSIDSEND IOCTL
Nov 23 2017, 1:57 PM
hselasky committed rS326124: The __internal_mr is freed as part of the protection domain, pd..
The __internal_mr is freed as part of the protection domain, pd.
Nov 23 2017, 12:25 PM

Nov 21 2017

hselasky committed rS326058: Make sure all initialized mutexes are destroyed in the iser module,.
Make sure all initialized mutexes are destroyed in the iser module,
Nov 21 2017, 1:56 PM
hselasky committed rS326054: MFC r299674 and r299931:.
MFC r299674 and r299931:
Nov 21 2017, 10:19 AM
hselasky committed rS326053: Compile fix for the mlx4 module..
Compile fix for the mlx4 module.
Nov 21 2017, 9:08 AM

Nov 19 2017

hselasky committed rS325999: Merge ^/head r325842 through r325998..
Merge ^/head r325842 through r325998.
Nov 19 2017, 12:37 PM
hselasky committed rS325998: There is no need to depend on libthr..
There is no need to depend on libthr.
Nov 19 2017, 12:30 PM

Nov 18 2017

hselasky committed rS325976: Remove duplicate static function prototype to fix compilation of.
Remove duplicate static function prototype to fix compilation of
Nov 18 2017, 8:32 PM

Nov 17 2017

hselasky committed rS325945: MFC r325616:.
MFC r325616:
Nov 17 2017, 3:49 PM
hselasky committed rS325944: MFC r325616:.
MFC r325616:
Nov 17 2017, 3:48 PM
hselasky committed rS325943: MFC r325615:.
MFC r325615:
Nov 17 2017, 3:47 PM
hselasky committed rS325941: MFC r325615:.
MFC r325615:
Nov 17 2017, 3:45 PM
hselasky committed rS325940: MFC r325614:.
MFC r325614:
Nov 17 2017, 3:43 PM
hselasky committed rS325939: MFC r325614:.
MFC r325614:
Nov 17 2017, 3:37 PM
hselasky committed rS325938: MFC r325533:.
MFC r325533:
Nov 17 2017, 3:32 PM
hselasky committed rS325937: MFC r325533:.
MFC r325533:
Nov 17 2017, 3:30 PM
hselasky committed rS325936: MFC r325533:.
MFC r325533:
Nov 17 2017, 3:28 PM
hselasky committed rS325935: Fix compilation of libibnetdisc using in-base GCC v4.2.1..
Fix compilation of libibnetdisc using in-base GCC v4.2.1.
Nov 17 2017, 3:24 PM

Nov 16 2017

hselasky committed rS325897: Improve the library dependencies helper script in src/tools..
Improve the library dependencies helper script in src/tools.
Nov 16 2017, 3:26 PM
hselasky committed rS325896: Fix compilation for libsysdecode..
Fix compilation for libsysdecode.
Nov 16 2017, 3:18 PM
hselasky committed rS325895: Remove conflicting uint definition..
Remove conflicting uint definition.
Nov 16 2017, 3:17 PM
hselasky committed rS325894: Update list of hardcoded OFED build order dependencies for.
Update list of hardcoded OFED build order dependencies for
Nov 16 2017, 3:13 PM
hselasky committed rS325891: Update iser backend code to use new ibcore APIs..
Update iser backend code to use new ibcore APIs.
Nov 16 2017, 1:28 PM

Nov 15 2017

hselasky committed rS325843: Add full support for specifying IPv6 addresses to krping..
Add full support for specifying IPv6 addresses to krping.
Nov 15 2017, 11:35 AM
hselasky committed rS325842: Merge ^/head r325663 through r325841..
Merge ^/head r325663 through r325841.
Nov 15 2017, 11:29 AM
hselasky committed rS325841: Update the mlx4 core and mlx4en(4) modules towards Linux v4.9..
Update the mlx4 core and mlx4en(4) modules towards Linux v4.9.
Nov 15 2017, 11:15 AM

Nov 14 2017

hselasky committed rS325807: Make sure the ib_wr_opcode enum is signed by adding a negative dummy element..
Make sure the ib_wr_opcode enum is signed by adding a negative dummy element.
Nov 14 2017, 2:51 PM
hselasky committed rS325806: Make sure a valid VNET is set before trying to access the V_ip6_v6only.
Make sure a valid VNET is set before trying to access the V_ip6_v6only
Nov 14 2017, 2:43 PM
hselasky committed rS325805: Set the default VNET in krping before calling ifunit_ref(). Else using IPv6.
Set the default VNET in krping before calling ifunit_ref(). Else using IPv6
Nov 14 2017, 2:40 PM

Nov 13 2017

hselasky committed rS325767: Properly handle the case where the linux_cdev_handle_insert() function.
Properly handle the case where the linux_cdev_handle_insert() function
Nov 13 2017, 6:16 PM
hselasky committed rS325763: Fix OFED library dependencies..
Fix OFED library dependencies.
Nov 13 2017, 12:36 PM
hselasky committed rS325762: Remove no longer needed TESTBUILD defines from OFED Makefiles..
Remove no longer needed TESTBUILD defines from OFED Makefiles.
Nov 13 2017, 11:36 AM
hselasky committed rS325761: Remove no longer supported mthca driver..
Remove no longer supported mthca driver.
Nov 13 2017, 11:00 AM