Page MenuHomeFreeBSD

hselasky (Hans Petter Selasky)
User

Projects

User Details

User Since
Nov 28 2014, 6:55 PM (326 w, 2 d)

Recent Activity

Thu, Feb 25

hselasky added a comment to D28032: add interface set 0/alter when start/stop play/record audio.

I'll try to get some work done here once 13 is out. This will be a new feature :-)

Thu, Feb 25, 3:30 PM
hselasky committed rP566525: Update qaudiosonar to v1.7.3.
Update qaudiosonar to v1.7.3
Thu, Feb 25, 10:42 AM

Mon, Feb 22

hselasky committed R10:9febbc454190: Fix for natd(8) sending wrong sequence number after TCP retransmission, (authored by hselasky).
Fix for natd(8) sending wrong sequence number after TCP retransmission,
Mon, Feb 22, 4:16 PM

Sun, Feb 21

hselasky committed rP566228: Fix unintended activation of automatic process already running checks.
Fix unintended activation of automatic process already running checks
Sun, Feb 21, 3:35 PM

Thu, Feb 18

hselasky accepted D28773: mbuf: add a way to mark flowid as calculated from the internal headers.

Looks good.

Thu, Feb 18, 3:06 PM
hselasky added inline comments to D28773: mbuf: add a way to mark flowid as calculated from the internal headers.
Thu, Feb 18, 2:13 PM
hselasky committed R10:0abf8ecb11ca: MFC 12148d4300db: (authored by hselasky).
MFC 12148d4300db:
Thu, Feb 18, 9:20 AM
hselasky committed R10:e710703067b1: MFC 12148d4300db: (authored by hselasky).
MFC 12148d4300db:
Thu, Feb 18, 8:47 AM
hselasky committed R10:3ea88413d607: MFC 12148d4300db: (authored by hselasky).
MFC 12148d4300db:
Thu, Feb 18, 8:45 AM
hselasky committed R10:c558999977fb: MFC 12148d4300db: (authored by hselasky).
MFC 12148d4300db:
Thu, Feb 18, 8:43 AM
hselasky accepted D28762: ofed: quiet gcc -Wint-in-bool-context.

Looks good. Don't forget to MFC.

Thu, Feb 18, 8:36 AM

Wed, Feb 17

hselasky committed R10:d23b583dfdd5: Bump the FreeBSD kernel version in kernel boot shim. (authored by hselasky).
Bump the FreeBSD kernel version in kernel boot shim.
Wed, Feb 17, 3:48 PM

Sun, Feb 14

hselasky committed R10:12148d4300db: Fix for locking order reversal in USB audio driver, when using mmap(). (authored by hselasky).
Fix for locking order reversal in USB audio driver, when using mmap().
Sun, Feb 14, 7:34 PM
hselasky committed rP565207: Update qaudiosonar to v1.7.2.
Update qaudiosonar to v1.7.2
Sun, Feb 14, 7:56 AM

Fri, Feb 12

hselasky committed rP565019: Update hpsjam to 1.0.10:.
Update hpsjam to 1.0.10:
Fri, Feb 12, 2:28 PM

Wed, Feb 10

hselasky added a comment to D28032: add interface set 0/alter when start/stop play/record audio.

I might have some time later this month to help prepare a patch the way I think is more correct to implement this.

Wed, Feb 10, 8:44 PM
hselasky accepted D28576: Silence warnings about no-op alignment operations.

Looks good.

Wed, Feb 10, 8:33 PM
hselasky requested changes to D28032: add interface set 0/alter when start/stop play/record audio.

Like said:
Channel prepare must use the configure message callback API, else this control request might end up out of order!

Wed, Feb 10, 4:05 AM

Mon, Feb 8

hselasky committed R10:8cb8d8d99879: MFC 093e72319089: (authored by hselasky).
MFC 093e72319089:
Mon, Feb 8, 3:32 PM
hselasky committed R10:20204c4681cb: MFC 85d8d30f9f70: (authored by hselasky).
MFC 85d8d30f9f70:
Mon, Feb 8, 3:32 PM
hselasky committed rP564683: Update webcamd to 5.10.6.1.
Update webcamd to 5.10.6.1
Mon, Feb 8, 9:07 AM
hselasky committed R10:6a97a237a258: MFC 85d8d30f9f70: (authored by hselasky).
MFC 85d8d30f9f70:
Mon, Feb 8, 8:44 AM
hselasky committed R10:e326cb03bcd8: MFC 093e72319089: (authored by hselasky).
MFC 093e72319089:
Mon, Feb 8, 8:38 AM
hselasky committed R10:ac86c042fbce: MFC 85d8d30f9f70: (authored by hselasky).
MFC 85d8d30f9f70:
Mon, Feb 8, 8:37 AM

Sun, Feb 7

hselasky added a comment to D28521: dev/usb/input/wsp: Add sysctl tunable for Z-Axis inversion.

wulf@ Can you please have a look?

Sun, Feb 7, 3:41 PM · Contributor Reviews (base)
hselasky added a reviewer for D28521: dev/usb/input/wsp: Add sysctl tunable for Z-Axis inversion: wulf.
Sun, Feb 7, 3:41 PM · Contributor Reviews (base)
hselasky added a comment to D28508: mlx5: Pad sq locks to minimize false sharing.

Drew, can you look at this patch.

Sun, Feb 7, 10:13 AM
hselasky added a reviewer for D28508: mlx5: Pad sq locks to minimize false sharing: gallatin.
Sun, Feb 7, 10:13 AM
hselasky added a comment to D28508: mlx5: Pad sq locks to minimize false sharing.

Only if RSS is enabled it binds interrupts. Let's add Drew for comments.

Sun, Feb 7, 10:12 AM

Fri, Feb 5

hselasky added a comment to D28508: mlx5: Pad sq locks to minimize false sharing.

Both locks are typically locked from the same CPU. Can you show some benefits of this, or is it just theoretical?

Fri, Feb 5, 8:20 PM

Thu, Feb 4

hselasky committed rP564033: Add webpage link for virtual_oss..
Add webpage link for virtual_oss.
Thu, Feb 4, 2:36 PM
hselasky committed rP564030: Update to 1.2.7:.
Update to 1.2.7:
Thu, Feb 4, 2:25 PM
hselasky accepted D28469: amd64 GENERIC: compile in mlx5en(4).
Thu, Feb 4, 8:18 AM

Wed, Feb 3

hselasky updated the diff for D28136: Fix for use after free when detaching network interface.

Added examples of new API usage - requested by kib@ .

Wed, Feb 3, 1:27 PM
hselasky added a comment to D28469: amd64 GENERIC: compile in mlx5en(4).

Probably should do the same for aarch64 .

Wed, Feb 3, 12:26 PM
hselasky added a comment to D28136: Fix for use after free when detaching network interface.

@kib: Let me start from scratch:

Wed, Feb 3, 12:13 PM
hselasky added a comment to D28136: Fix for use after free when detaching network interface.

man blockcount
No manual entry for blockcount

Wed, Feb 3, 11:37 AM
hselasky added inline comments to D28136: Fix for use after free when detaching network interface.
Wed, Feb 3, 9:23 AM
hselasky added inline comments to D28136: Fix for use after free when detaching network interface.
Wed, Feb 3, 8:36 AM

Tue, Feb 2

hselasky updated the diff for D28136: Fix for use after free when detaching network interface.

Address comments from @kp

Tue, Feb 2, 10:02 PM
hselasky added inline comments to D28136: Fix for use after free when detaching network interface.
Tue, Feb 2, 8:04 PM
hselasky accepted D28420: Fix race condition in linuxkpi workqueue.

Looks good. Don't forget to MFC to 11,12,13.

Tue, Feb 2, 2:38 PM
hselasky accepted D28460: WITH_OFED build option: fix.
Tue, Feb 2, 2:37 PM

Mon, Feb 1

hselasky added a reviewer for D28421: Fix mismerge in OFED update: kib.
Mon, Feb 1, 2:19 PM
hselasky accepted D28421: Fix mismerge in OFED update.

Looks good.

Mon, Feb 1, 2:18 PM
hselasky added a reviewer for D28420: Fix race condition in linuxkpi workqueue: hselasky.
Mon, Feb 1, 2:00 PM
hselasky added inline comments to D28420: Fix race condition in linuxkpi workqueue.
Mon, Feb 1, 2:00 PM
hselasky committed R10:db46c0d0cb3d: Fix LINT kernel builds after 1a714ff20419 . (authored by hselasky).
Fix LINT kernel builds after 1a714ff20419 .
Mon, Feb 1, 1:25 PM
hselasky closed D28357: Update the tcp_ratelimit code to finally work right :).
Mon, Feb 1, 1:25 PM
hselasky committed R10:671c393854a5: MFC ea0efc370416: (authored by hselasky).
MFC ea0efc370416:
Mon, Feb 1, 9:33 AM
hselasky committed R10:8340ed8900e4: MFC 064009e79462: (authored by hselasky).
MFC 064009e79462:
Mon, Feb 1, 9:29 AM
hselasky committed R10:918b98a06129: MFC 064009e79462: (authored by hselasky).
MFC 064009e79462:
Mon, Feb 1, 9:28 AM
hselasky committed R10:6bc1f8425560: MFC 064009e79462: (authored by hselasky).
MFC 064009e79462:
Mon, Feb 1, 9:27 AM
hselasky committed R10:22aca6726891: MFC b8051298b0a3: (authored by hselasky).
MFC b8051298b0a3:
Mon, Feb 1, 9:25 AM

Sun, Jan 31

hselasky added a comment to D28421: Fix mismerge in OFED update.

Targetting a review for Monday.

Sun, Jan 31, 9:27 AM
hselasky added a comment to D28420: Fix race condition in linuxkpi workqueue.

I will test and review this patch on Monday.

Sun, Jan 31, 9:26 AM

Jan 29 2021

hselasky added a comment to D28421: Fix mismerge in OFED update.

I'll have a look at this tomorrow.

Jan 29 2021, 9:38 PM
hselasky committed rP563181: Update port to v2.0.5-9.
Update port to v2.0.5-9
Jan 29 2021, 9:19 AM

Jan 28 2021

hselasky committed R10:b8051298b0a3: Fix missing value in uar_page field for ratelimit in mlx5en(4). (authored by hselasky).
Fix missing value in uar_page field for ratelimit in mlx5en(4).
Jan 28 2021, 2:41 PM
hselasky accepted D28357: Update the tcp_ratelimit code to finally work right :).
Jan 28 2021, 1:19 PM
hselasky added a comment to D28357: Update the tcp_ratelimit code to finally work right :).

@rrs: I'm fine with your proposal to commit everything except the mlx5en(4) parts, which we would like split out in an own commit.

Jan 28 2021, 1:18 PM
hselasky added inline comments to D27505: Fix subinterface vlan creation..
Jan 28 2021, 11:50 AM
hselasky accepted D27505: Fix subinterface vlan creation..

Test OK!

Jan 28 2021, 11:48 AM

Jan 27 2021

hselasky added a comment to D27505: Fix subinterface vlan creation..

Let me test your latest patch tomorrow. Thank you!

Jan 27 2021, 8:19 PM
hselasky added a comment to D28357: Update the tcp_ratelimit code to finally work right :).

Can if_next_snd_tag() be committed first?

Jan 27 2021, 7:27 PM
hselasky added a comment to D27505: Fix subinterface vlan creation..

The following additional diff make things work. Can you integrate and test?

Jan 27 2021, 12:38 PM
hselasky added inline comments to D27505: Fix subinterface vlan creation..
Jan 27 2021, 12:15 PM
hselasky added a comment to D27505: Fix subinterface vlan creation..

It is still not working. Trying to investigate why.

Jan 27 2021, 11:45 AM
hselasky added inline comments to D27505: Fix subinterface vlan creation..
Jan 27 2021, 11:29 AM
hselasky added inline comments to D27505: Fix subinterface vlan creation..
Jan 27 2021, 11:27 AM

Jan 26 2021

hselasky added a comment to D28357: Update the tcp_ratelimit code to finally work right :).

It looks like the Mellanox bits can be committed separately and before the other patches.

Jan 26 2021, 5:41 PM
hselasky committed R10:093e72319089: Add missing decrement of active ratelimit connections. (authored by hselasky).
Add missing decrement of active ratelimit connections.
Jan 26 2021, 5:03 PM
hselasky committed R10:85d8d30f9f70: Don't allow allocating a new send tag on an INP which is being torn down. (authored by hselasky).
Don't allow allocating a new send tag on an INP which is being torn down.
Jan 26 2021, 5:03 PM
hselasky added a comment to D27505: Fix subinterface vlan creation..

Still doesn't work like it should:

Jan 26 2021, 4:54 PM
hselasky added a comment to D26598: linuxkpi: upstream drm-kmod conflicting changes.

No more comments from me.

Jan 26 2021, 4:18 PM
hselasky added inline comments to D26598: linuxkpi: upstream drm-kmod conflicting changes.
Jan 26 2021, 1:01 PM
hselasky added inline comments to D27505: Fix subinterface vlan creation..
Jan 26 2021, 12:35 PM

Jan 25 2021

hselasky added inline comments to D27505: Fix subinterface vlan creation..
Jan 25 2021, 11:26 AM
hselasky added a comment to D27505: Fix subinterface vlan creation..

Can you please test the patch? I get bogus results:

Jan 25 2021, 11:20 AM
hselasky committed R10:064009e79462: Add support for enabling and disabling IFCAP_VLAN_HWTSO via (authored by hselasky).
Add support for enabling and disabling IFCAP_VLAN_HWTSO via
Jan 25 2021, 10:29 AM

Jan 22 2021

hselasky added a comment to D28136: Fix for use after free when detaching network interface.

Run ifconfig ue0 in a loop on a USB interface which has got a mii interface attached to it.

Jan 22 2021, 10:19 PM
hselasky added a comment to D26598: linuxkpi: upstream drm-kmod conflicting changes.

Just one minor comment and I will accept.

Jan 22 2021, 2:10 PM
hselasky committed R10:2695791408f5: MFC r367612: (authored by kib).
MFC r367612:
Jan 22 2021, 12:50 PM
hselasky committed R10:2cd3c13be316: MFC r367611: (authored by kib).
MFC r367611:
Jan 22 2021, 12:50 PM
hselasky committed R10:65dd92f6043d: MFC r367610: (authored by kib).
MFC r367610:
Jan 22 2021, 12:50 PM
hselasky committed R10:c408d03b378a: MFC r367609: (authored by kib).
MFC r367609:
Jan 22 2021, 12:50 PM
hselasky committed R10:e87e3e82f3a0: MFC 9a47ae044b48: (authored by hselasky).
MFC 9a47ae044b48:
Jan 22 2021, 12:50 PM
hselasky committed R10:f301a7de8b76: MFC daa150aaa30f: (authored by hselasky).
MFC daa150aaa30f:
Jan 22 2021, 12:49 PM
hselasky committed R10:1f1f6b4cb5ee: MFC r353632: (authored by hselasky).
MFC r353632:
Jan 22 2021, 12:49 PM
hselasky committed R10:43bf82ace68d: MFC a00718e1dfcd: (authored by hselasky).
MFC a00718e1dfcd:
Jan 22 2021, 12:49 PM
hselasky committed R10:198471ed6b15: MFC 89c0b4fa1172: (authored by hselasky).
MFC 89c0b4fa1172:
Jan 22 2021, 12:49 PM
hselasky committed R10:71c34db5ba79: MFC 87b3c8cc99f9: (authored by hselasky).
MFC 87b3c8cc99f9:
Jan 22 2021, 12:49 PM
hselasky committed R10:4ffbeb0414ed: MFC 82c7abe7785b: (authored by hselasky).
MFC 82c7abe7785b:
Jan 22 2021, 12:49 PM
hselasky committed R10:6187db1d915d: MFC 50a9f8bbc1dd: (authored by hselasky).
MFC 50a9f8bbc1dd:
Jan 22 2021, 12:49 PM
hselasky committed R10:8302e83a1c4e: MFC 376e130b4707: (authored by hselasky).
MFC 376e130b4707:
Jan 22 2021, 12:49 PM
hselasky committed R10:a7c9b12baf7d: MFC 480570dbb309: (authored by hselasky).
MFC 480570dbb309:
Jan 22 2021, 12:49 PM
hselasky committed R10:026b14030bdf: MFC 376479200760: (authored by hselasky).
MFC 376479200760:
Jan 22 2021, 12:49 PM
hselasky committed R10:e1e64a0921c7: MFC 9a47ae044b48: (authored by hselasky).
MFC 9a47ae044b48:
Jan 22 2021, 12:31 PM
hselasky committed R10:125cdcc13b70: MFC r353632: (authored by hselasky).
MFC r353632:
Jan 22 2021, 12:31 PM
hselasky committed R10:bad1f0930326: MFC daa150aaa30f: (authored by hselasky).
MFC daa150aaa30f:
Jan 22 2021, 12:31 PM