Page MenuHomeFreeBSD

hselasky (Hans Petter Selasky)
User

Projects

User Details

User Since
Nov 28 2014, 6:55 PM (246 w, 2 d)

Recent Activity

Sat, Aug 17

hselasky added a comment to D21298: OFED: Unbreak SDP support in ibcore.

If all compilers support \#pragma once I'm fine with that, but else we should follow the style in FreeBSD.

Sat, Aug 17, 10:03 AM
hselasky committed rS351167: Include item position in report descriptor dump in usbhidctl(1)..
Include item position in report descriptor dump in usbhidctl(1).
Sat, Aug 17, 8:29 AM
D21298: OFED: Unbreak SDP support in ibcore is now accepted and ready to land.

Looks good. See my one comment.

Sat, Aug 17, 8:15 AM

Fri, Aug 16

hselasky committed rS351146: Implement detach_kernel_driver command in usbconfig(8)..
Implement detach_kernel_driver command in usbconfig(8).
Fri, Aug 16, 9:18 PM
hselasky added inline comments to D21277: Add kernel-side support for in-kernel TLS..
Fri, Aug 16, 11:15 AM
hselasky added inline comments to D21277: Add kernel-side support for in-kernel TLS..
Fri, Aug 16, 11:15 AM
hselasky added inline comments to D21277: Add kernel-side support for in-kernel TLS..
Fri, Aug 16, 11:07 AM

Thu, Aug 15

D21071: Firmware loader for Intel Wireless 8260 based Bluetooth USB devices is now accepted and ready to land.

Looks very good!

Thu, Aug 15, 8:36 PM

Wed, Aug 14

hselasky committed rS351019: MFC r350675:.
MFC r350675:
Wed, Aug 14, 9:44 AM
hselasky committed rS351018: MFC r350675:.
MFC r350675:
Wed, Aug 14, 9:43 AM
hselasky committed rS351017: MFC r350396:.
MFC r350396:
Wed, Aug 14, 9:42 AM
hselasky committed rS351015: MFC r350396:.
MFC r350396:
Wed, Aug 14, 9:41 AM
hselasky committed rS351013: MFC r350396:.
MFC r350396:
Wed, Aug 14, 9:40 AM
hselasky committed rS351009: Implement pci_enable_msi() and pci_disable_msi() in the LinuxKPI..
Implement pci_enable_msi() and pci_disable_msi() in the LinuxKPI.
Wed, Aug 14, 9:36 AM
hselasky closed D21008: Implement pci_enable_msi() and pci_disable_msi() in the LinuxKPI..
Wed, Aug 14, 9:36 AM · arm64

Tue, Aug 13

D20992: Fix build with DRM and INVARIANTS enabled. is now accepted and ready to land.

Looks good!

Tue, Aug 13, 5:40 PM

Thu, Aug 8

hselasky added a comment to D20992: Fix build with DRM and INVARIANTS enabled..

@jhb : OK, if you can move lockdep_is_held() under #ifdef INVARIANTS and otherwise define lockdep_is_held() as 1, I think we are in-line.

Thu, Aug 8, 5:12 PM
hselasky added a comment to D20992: Fix build with DRM and INVARIANTS enabled..

Ok, can you tell me what the semantic in Linux is for lockdep_is_held() after on a lock locked via read_lock()?

Thu, Aug 8, 7:44 AM
hselasky added a comment to D20992: Fix build with DRM and INVARIANTS enabled..

If we look at Linux all the LOCKDEP stuff is under ifdef:

Thu, Aug 8, 7:41 AM

Wed, Aug 7

hselasky added a comment to D20992: Fix build with DRM and INVARIANTS enabled..

Are we certain that lockep() is not used with read_lock()? Also I don't like that cast to lock_object. It would be better to do this clean by referring to the lock object field in the lock, assuming they are named then same. Or use WITNESS for selected locks, which is much better. The reason WITNESS is currently disabled for LinuxKPI spinlocks is that spinlocks are not destroyed under Linux, so the WITNESS object never goes away.

Wed, Aug 7, 4:38 PM
hselasky committed rS350675: Correct PCI device ID for XHCI USB controller..
Correct PCI device ID for XHCI USB controller.
Wed, Aug 7, 1:35 PM
hselasky added a comment to D20992: Fix build with DRM and INVARIANTS enabled..

@hselasky Do you have any thoughts on the LOCK_CLASS-based approach? Is this something you can test? I've only tested it with drm.

Wed, Aug 7, 8:06 AM
hselasky added inline comments to D20992: Fix build with DRM and INVARIANTS enabled..
Wed, Aug 7, 8:02 AM

Tue, Aug 6

hselasky added a comment to D21008: Implement pci_enable_msi() and pci_disable_msi() in the LinuxKPI..

Please test!

Tue, Aug 6, 1:50 PM · arm64
hselasky added a comment to D21008: Implement pci_enable_msi() and pci_disable_msi() in the LinuxKPI..

Can you try this patch and report back?

Tue, Aug 6, 1:44 PM · arm64
hselasky added a comment to D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

Rebase patch after latest changes upstream.

Tue, Aug 6, 9:15 AM
hselasky added a comment to D21008: Implement pci_enable_msi() and pci_disable_msi() in the LinuxKPI..

Please test.

Tue, Aug 6, 9:04 AM · arm64
hselasky added a comment to D21008: Implement pci_enable_msi() and pci_disable_msi() in the LinuxKPI..

Can you test this patch?

Tue, Aug 6, 9:00 AM · arm64
hselasky retitled D21008: Implement pci_enable_msi() and pci_disable_msi() in the LinuxKPI. from linuxkpi: implement pci_enable_msi / pci_disable_msi to Implement pci_enable_msi() and pci_disable_msi() in the LinuxKPI..

Can you test this updated patch?

Tue, Aug 6, 8:40 AM · arm64
hselasky edited reviewers for D21008: Implement pci_enable_msi() and pci_disable_msi() in the LinuxKPI., added: greg_unrelenting.technology; removed: hselasky.
Tue, Aug 6, 8:40 AM · arm64
hselasky added inline comments to D21008: Implement pci_enable_msi() and pci_disable_msi() in the LinuxKPI..
Tue, Aug 6, 8:12 AM · arm64

Mon, Aug 5

hselasky added a comment to D11560: Remove use of 9k clusters from mlx4_en rx path.

Adding Slava to this review aswell.

Mon, Aug 5, 8:17 AM
hselasky updated subscribers of D11560: Remove use of 9k clusters from mlx4_en rx path.
Mon, Aug 5, 8:16 AM

Sun, Aug 4

D21096: Add necessary bits for Linux KPI to work correctly on powerpc is now accepted and ready to land.

Looks good. Maybe you should also bump the __FreeBSD_version when you commit this.

Sun, Aug 4, 1:26 PM

Fri, Aug 2

D20865: Expose USB port physical information in ACPI by sysctl. is now accepted and ready to land.
Fri, Aug 2, 7:43 AM

Thu, Aug 1

hselasky added a comment to D21037: linuxpki: correct is_{zero,broadcast}_ether_addr.

There is no regular (operating on the integer regiter file) instructions on amd64 that could add e.g. three registers once. There is a LEA instruction which allows you to add to registers and a constant, but thats all.

Thu, Aug 1, 4:13 PM
hselasky added a comment to D21037: linuxpki: correct is_{zero,broadcast}_ether_addr.

I don't understand this comment. Can you elaborate? IMO, we want to differentiate from Linux when and only when it is possible to do better than Linux does; not gratuitously.

Thu, Aug 1, 4:12 PM
hselasky added a comment to D21037: linuxpki: correct is_{zero,broadcast}_ether_addr.

Maybe the following is unclear:

Thu, Aug 1, 3:00 PM
D21037: linuxpki: correct is_{zero,broadcast}_ether_addr now requires changes to proceed.

If the functions are not broken there is no reason to fix them from my POV.

Thu, Aug 1, 1:49 PM

Wed, Jul 31

hselasky added inline comments to D20865: Expose USB port physical information in ACPI by sysctl..
Wed, Jul 31, 2:53 PM
hselasky added a comment to D21008: Implement pci_enable_msi() and pci_disable_msi() in the LinuxKPI..

OK, I'll try to have a look at your patch.

Wed, Jul 31, 9:36 AM · arm64
hselasky added a comment to D9594: Port utouch driver from TrueOS.

Can you abandon this differential revision if no longer active?

Wed, Jul 31, 9:36 AM
hselasky added a comment to D11560: Remove use of 9k clusters from mlx4_en rx path.

Ping - is this patch still relevant?

Wed, Jul 31, 9:35 AM
hselasky added a comment to D20865: Expose USB port physical information in ACPI by sysctl..

Was patch updated?

Wed, Jul 31, 9:34 AM
hselasky added a comment to D20804: support for xbox one controller as uhid.

Can this device be used via /usr/ports/multimedia/webcamd ?

Wed, Jul 31, 9:33 AM
hselasky added inline comments to D18921: Prevent buffer overrun in tzsetup (for -C with overly large parameter).
Wed, Jul 31, 9:30 AM
D18921: Prevent buffer overrun in tzsetup (for -C with overly large parameter) is now accepted and ready to land.
Wed, Jul 31, 9:25 AM
hselasky added a comment to D19886: Fix numerous refcount bugs in multicast ....

Ping: Can this change be abandoned now?

Wed, Jul 31, 9:20 AM
D20953: Third patchset in the set of patches to bring BBRv1 into the FreeBSD tree is now accepted and ready to land.

Changes look good to me.

Wed, Jul 31, 9:19 AM
hselasky added a comment to D21096: Add necessary bits for Linux KPI to work correctly on powerpc.

@jhibbits : Can you update the patch with the agreed upon changes?

Wed, Jul 31, 9:09 AM
hselasky added a comment to D20992: Fix build with DRM and INVARIANTS enabled..

Just remove lockdep_is_held(m) .

Wed, Jul 31, 9:08 AM
hselasky added a comment to D20992: Fix build with DRM and INVARIANTS enabled..

@zeising : Do you use CONFIG_LOCKDEP in drm-next ?

Wed, Jul 31, 9:08 AM

Mon, Jul 29

hselasky added inline comments to D21096: Add necessary bits for Linux KPI to work correctly on powerpc.
Mon, Jul 29, 10:23 PM
hselasky added inline comments to D21096: Add necessary bits for Linux KPI to work correctly on powerpc.
Mon, Jul 29, 2:43 PM
hselasky added a comment to D21008: Implement pci_enable_msi() and pci_disable_msi() in the LinuxKPI..

Assume that the driver knows not to enable both MSIX and MSI.

Mon, Jul 29, 2:29 PM · arm64
hselasky added inline comments to D21008: Implement pci_enable_msi() and pci_disable_msi() in the LinuxKPI..
Mon, Jul 29, 2:28 PM · arm64

Sun, Jul 28

hselasky committed rS350396: Add support for tethering with Nokia 7 plus and the alike..
Add support for tethering with Nokia 7 plus and the alike.
Sun, Jul 28, 9:47 PM
hselasky added a comment to D21096: Add necessary bits for Linux KPI to work correctly on powerpc.

I'll have a closer look tomorrow. Most of this looks good.

Sun, Jul 28, 9:33 PM

Fri, Jul 26

D21071: Firmware loader for Intel Wireless 8260 based Bluetooth USB devices is now accepted and ready to land.

Looks good!

Fri, Jul 26, 7:02 AM

Wed, Jul 24

hselasky added reviewers for D21041: net: Update SFF-8024 definitions and strings with values from rev 4.6: slavash, gallatin.
Wed, Jul 24, 4:28 PM · network

Sun, Jul 21

hselasky added a comment to D21008: Implement pci_enable_msi() and pci_disable_msi() in the LinuxKPI..

I'll have a closer look at you patch(es) when I'm back in office. Please stay tuned.

Sun, Jul 21, 8:24 AM · arm64

Jul 19 2019

hselasky added a comment to D20992: Fix build with DRM and INVARIANTS enabled..

What about lockedep_is_held() ??

Jul 19 2019, 1:55 PM

Jul 18 2019

hselasky committed rP506869: Move pkg-plist to Makefile..
Move pkg-plist to Makefile.
Jul 18 2019, 6:12 PM
hselasky committed rP506867: Add new port qaudiosonar v1.6.0..
Add new port qaudiosonar v1.6.0.
Jul 18 2019, 5:53 PM
hselasky committed rP506864: Update midipp to 2.0.2.
Update midipp to 2.0.2
Jul 18 2019, 5:47 PM
hselasky committed rP506863: Fix spelling..
Fix spelling.
Jul 18 2019, 5:46 PM

Jul 16 2019

hselasky committed rS350032: MFC r349645:.
MFC r349645:
Jul 16 2019, 3:07 PM

Jul 15 2019

hselasky added a reviewer for D20953: Third patchset in the set of patches to bring BBRv1 into the FreeBSD tree: slavash.
Jul 15 2019, 1:01 PM

Jul 12 2019

hselasky added a comment to D20789: Use DEVICE memory instead of UNCACHEABLE on aarch64 in LinuxKPI ioremap.

Please stay tuned!

Jul 12 2019, 3:29 PM · arm64

Jul 9 2019

hselasky added inline comments to D20865: Expose USB port physical information in ACPI by sysctl..
Jul 9 2019, 4:40 PM

Jul 8 2019

hselasky committed rS349852: Restore binary compatibility for epoch(9) API..
Restore binary compatibility for epoch(9) API.
Jul 8 2019, 9:33 PM
hselasky committed rS349851: Put USB ACPI code into own module, uacpi.ko..
Put USB ACPI code into own module, uacpi.ko.
Jul 8 2019, 8:53 PM
hselasky added a comment to D20865: Expose USB port physical information in ACPI by sysctl..

Please re-base this patch on top of the latest 13-current.

Jul 8 2019, 7:34 PM
hselasky committed rS349844: Minor code cleanup of USB ACPI code after r349161..
Minor code cleanup of USB ACPI code after r349161.
Jul 8 2019, 7:26 PM

Jul 6 2019

D20865: Expose USB port physical information in ACPI by sysctl. is now accepted and ready to land.

Looks good. Some minor nits. Please fix before commit.

Jul 6 2019, 6:39 PM

Jul 5 2019

hselasky committed rS349765: MFC r349507:.
MFC r349507:
Jul 5 2019, 12:36 PM
hselasky committed rS349764: MFC r349506:.
MFC r349506:
Jul 5 2019, 12:33 PM
hselasky committed rS349763: MFC r340404, r340415, r340417, r340419 and r340420:.
MFC r340404, r340415, r340417, r340419 and r340420:
Jul 5 2019, 12:26 PM
hselasky committed rS349762: MFC r349369:.
MFC r349369:
Jul 5 2019, 10:31 AM
hselasky committed rP505892: Update virtual_oss to 1.2.4.
Update virtual_oss to 1.2.4
Jul 5 2019, 9:34 AM

Jul 4 2019

hselasky committed rP505845: Update virtual_oss to 1.2.3.
Update virtual_oss to 1.2.3
Jul 4 2019, 5:08 PM
hselasky committed rP505839: Fix issues with ALSA OSS backend for firefox and chrome..
Fix issues with ALSA OSS backend for firefox and chrome.
Jul 4 2019, 3:46 PM

Jul 3 2019

hselasky committed rS349670: MFC r349522:.
MFC r349522:
Jul 3 2019, 6:29 PM
hselasky committed rS349669: MFC r349409 and r349410:.
MFC r349409 and r349410:
Jul 3 2019, 6:26 PM
hselasky committed rS349668: MFC r349409 and r349410:.
MFC r349409 and r349410:
Jul 3 2019, 6:25 PM
hselasky committed rS349667: MFC r349409 and r349410:.
MFC r349409 and r349410:
Jul 3 2019, 6:23 PM
hselasky committed rS349666: MFC r349370:.
MFC r349370:
Jul 3 2019, 6:19 PM
hselasky committed rS349665: MFC r349370:.
MFC r349370:
Jul 3 2019, 6:18 PM
hselasky committed rS349664: MFC r349370:.
MFC r349370:
Jul 3 2019, 6:18 PM
hselasky committed rS349663: MFC r349368:.
MFC r349368:
Jul 3 2019, 6:17 PM
hselasky committed rS349662: MFC r349368:.
MFC r349368:
Jul 3 2019, 6:16 PM
hselasky committed rS349661: MFC r349367:.
MFC r349367:
Jul 3 2019, 6:15 PM
hselasky committed rS349660: MFC r349367:.
MFC r349367:
Jul 3 2019, 6:14 PM
hselasky committed rS349645: Remove dead code added after r348743 in the LinuxKPI. The.
Remove dead code added after r348743 in the LinuxKPI. The
Jul 3 2019, 9:48 AM

Jul 2 2019

hselasky added a comment to D20740: in_mcast.c: need if_addr_lock around inm_release_deferred.

Patch looks good to me. Did you run with this patch?

Jul 2 2019, 2:16 PM
hselasky added a comment to D20739: in6_joingroup_locked: need if_addr_lock around in6m_disconnect_locked.

Patch looks good to me. Did you run this patch, I.E. force the error case somehow?

Jul 2 2019, 2:15 PM

Jun 29 2019

hselasky added a comment to D20804: support for xbox one controller as uhid.

Can you upload full context for the diff?

Jun 29 2019, 12:42 PM

Jun 28 2019

hselasky committed rS349522: Need to apply the PCIM_BAR_MEM_BASE mask to the physical memory.
Need to apply the PCIM_BAR_MEM_BASE mask to the physical memory
Jun 28 2019, 10:29 PM
D20789: Use DEVICE memory instead of UNCACHEABLE on aarch64 in LinuxKPI ioremap is now accepted and ready to land.

Spell lkpi -> LinuxKPI in the commit message.

Jun 28 2019, 1:56 PM · arm64
hselasky accepted D20616: Add a new external mbuf type that holds multiple unmapped pages..
Jun 28 2019, 1:09 PM