hselasky (Hans Petter Selasky)
User

Projects

User Details

User Since
Nov 28 2014, 6:55 PM (147 w, 1 d)

Recent Activity

Fri, Sep 22

hselasky committed rS323916: Extend sysctl description for hw.usb.disable_enumeration ..
Extend sysctl description for hw.usb.disable_enumeration .
Fri, Sep 22, 8:21 AM
hselasky committed rS323910: Add support for 32-bit compatibility IOCTLs in the LinuxKPI..
Add support for 32-bit compatibility IOCTLs in the LinuxKPI.
Fri, Sep 22, 8:12 AM

Wed, Sep 20

hselasky committed rS323811: Regenerate usb.conf ..
Regenerate usb.conf .
Wed, Sep 20, 3:00 PM
hselasky committed rS323810: MFC r322530 and r323220:.
MFC r322530 and r323220:
Wed, Sep 20, 2:46 PM
hselasky committed rS323809: MFC r322530 and r323220:.
MFC r322530 and r323220:
Wed, Sep 20, 2:44 PM
hselasky committed rS323808: MFC r322530 and r323220:.
MFC r322530 and r323220:
Wed, Sep 20, 2:43 PM
hselasky committed rP450201: Enable OSS audio backend by default..
Enable OSS audio backend by default.
Wed, Sep 20, 1:30 PM

Tue, Sep 19

hselasky added a comment to D11392: Allow CUSE to free memory mapped memory by using d_mmap_single instead of d_mmap.

Yes, server and client can use same object, and that is what happens with the current patch when the "mem" handle is the same.

Tue, Sep 19, 4:37 PM
hselasky added a comment to D11392: Allow CUSE to free memory mapped memory by using d_mmap_single instead of d_mmap.

@kib : How can two different processes share a piece of memory if not using the same VM object?

Tue, Sep 19, 4:00 PM
hselasky added a comment to D11392: Allow CUSE to free memory mapped memory by using d_mmap_single instead of d_mmap.
In D11392#257497, @kib wrote:

@kib

There is one more requirement. If I create a swap object I need to be able to offset inside the swap object. Is that supported?

Does the vm_ooffset_t *offset argument in the d_mmap_single() signature does what you need (I am not sure what and why you need) ?

Tue, Sep 19, 2:57 PM
hselasky added a comment to D11392: Allow CUSE to free memory mapped memory by using d_mmap_single instead of d_mmap.

There is one more requirement. If I create a swap object I need to be able to offset inside the swap object. Is that supported?

Tue, Sep 19, 12:10 PM
hselasky added a comment to D11392: Allow CUSE to free memory mapped memory by using d_mmap_single instead of d_mmap.

What callbacks ? If you unref the allocated vm objects on cuse.ko unload, VM will correctly free both objects and objects page queues when the last process unmaps it. For OBJT_SWAP you do not need to do anything else except releasing _your_ references.

Tue, Sep 19, 11:01 AM
hselasky added a comment to D11392: Allow CUSE to free memory mapped memory by using d_mmap_single instead of d_mmap.

If the shared communication memory is still mapped when cuse.ko is unloaded, what should happen ? I do not think that it is really possible to track such situations and prevent cuse.ko unload without huge and really unneeded efforts. Leaving the deallocation of the objects to normal VM lifecycle rules avoids unnecessary troubles, IMO.

Tue, Sep 19, 10:26 AM
hselasky added a comment to D11392: Allow CUSE to free memory mapped memory by using d_mmap_single instead of d_mmap.
Can you explain why did you claimed, in the conversation with Mark, that the swap object does not work for you ?
Tue, Sep 19, 9:15 AM

Mon, Sep 18

hselasky accepted D11392: Allow CUSE to free memory mapped memory by using d_mmap_single instead of d_mmap.
Mon, Sep 18, 7:13 PM
hselasky updated the diff for D11392: Allow CUSE to free memory mapped memory by using d_mmap_single instead of d_mmap.

Set correct size of allocated VM object in case there is an offset within the object requested by the mmap().

Mon, Sep 18, 6:36 PM
hselasky updated the diff for D11392: Allow CUSE to free memory mapped memory by using d_mmap_single instead of d_mmap.

Fix some bugs found during testing.

Mon, Sep 18, 6:18 PM
hselasky accepted D12407: linsysfs(5): Fix two unrelated issues.

Looks good to me.

Mon, Sep 18, 5:11 PM
hselasky added inline comments to D12407: linsysfs(5): Fix two unrelated issues.
Mon, Sep 18, 5:05 PM
hselasky updated the diff for D11392: Allow CUSE to free memory mapped memory by using d_mmap_single instead of d_mmap.

Rework patch based on input.

Mon, Sep 18, 4:55 PM
hselasky committed rS323706: Bump the __FreeBSD_version after recent LinuxKPI changes..
Bump the __FreeBSD_version after recent LinuxKPI changes.
Mon, Sep 18, 1:40 PM
hselasky committed rS323705: The LinuxKPI atomics do not have acquire nor release semantics unless.
The LinuxKPI atomics do not have acquire nor release semantics unless
Mon, Sep 18, 1:37 PM
hselasky committed rS323704: Only wire pages in the LinuxKPI instead of holding and wiring them..
Only wire pages in the LinuxKPI instead of holding and wiring them.
Mon, Sep 18, 1:24 PM
hselasky committed rS323703: Add support for shared memory functions to the LinuxKPI..
Add support for shared memory functions to the LinuxKPI.
Mon, Sep 18, 1:17 PM

Sat, Sep 16

hselasky committed rS323652: Temporary fix to avoid hitting kernel assert..
Temporary fix to avoid hitting kernel assert.
Sat, Sep 16, 4:32 PM
hselasky committed rS323651: Remove no longer needed linux_poll_wakeup() calls. This is now handled by.
Remove no longer needed linux_poll_wakeup() calls. This is now handled by
Sat, Sep 16, 4:31 PM
hselasky committed rS323650: Embedding the scope ID is no longer needed for IPv6..
Embedding the scope ID is no longer needed for IPv6.
Sat, Sep 16, 4:29 PM
hselasky committed rS323649: Set length field of socket address..
Set length field of socket address.
Sat, Sep 16, 4:28 PM
hselasky committed rS323648: Fix for refcount leak..
Fix for refcount leak.
Sat, Sep 16, 4:27 PM
hselasky committed rS323647: Make sure the socket address length field gets set..
Make sure the socket address length field gets set.
Sat, Sep 16, 4:27 PM
hselasky committed rS323646: Improve ibcore address resolving:.
Improve ibcore address resolving:
Sat, Sep 16, 4:24 PM
hselasky committed rS323644: Fix in-kernel build of ibcore module..
Fix in-kernel build of ibcore module.
Sat, Sep 16, 4:17 PM
hselasky committed rS323643: Adapt the existing SDP ULP code to the new ibcore APIs..
Adapt the existing SDP ULP code to the new ibcore APIs.
Sat, Sep 16, 4:16 PM

Wed, Sep 13

hselasky accepted D12354: Silently handle freeaddrinfo(NULL) for compatibility with code which works on other OSes..
Wed, Sep 13, 10:39 AM

Mon, Sep 11

hselasky added a comment to D12176: mlx4_en: Implement SIOCGIFRSS{KEY,HASH}.

Thank you. Currently reviewing this patch in Mellanox.

Mon, Sep 11, 7:23 AM

Sat, Sep 9

hselasky committed rS323364: Only search the scope ID in ip6_find_dev() for IPv6 addresses which.
Only search the scope ID in ip6_find_dev() for IPv6 addresses which
Sat, Sep 9, 12:50 PM
hselasky committed rS323351: Resolve IPv6 scope ID issues when using ip6_find_dev() in the LinuxKPI..
Resolve IPv6 scope ID issues when using ip6_find_dev() in the LinuxKPI.
Sat, Sep 9, 7:21 AM
hselasky committed rS323350: Remove unsafe access to the LinuxKPI file structure from ibcore..
Remove unsafe access to the LinuxKPI file structure from ibcore.
Sat, Sep 9, 6:34 AM
hselasky committed rS323349: Properly implement poll_wait() in the LinuxKPI. This prevents direct.
Properly implement poll_wait() in the LinuxKPI. This prevents direct
Sat, Sep 9, 6:29 AM
hselasky committed rS323347: Add more sanity checks to linux_fget() in the LinuxKPI. This prevents.
Add more sanity checks to linux_fget() in the LinuxKPI. This prevents
Sat, Sep 9, 6:04 AM

Thu, Sep 7

hselasky accepted D12267: Fix an infinite loop in tcp_tw_2msl_scan() when an INP_TIMEWAIT inp has been destroyed before its tcptw with INVARIANTS undefined..
Thu, Sep 7, 4:44 PM

Wed, Sep 6

hselasky committed rS323223: MFC r322810 and r322830:.
MFC r322810 and r322830:
Wed, Sep 6, 3:33 PM
hselasky added inline comments to D12176: mlx4_en: Implement SIOCGIFRSS{KEY,HASH}.
Wed, Sep 6, 2:13 PM
hselasky committed rS323220: Add new USB quirk..
Add new USB quirk.
Wed, Sep 6, 2:00 PM
hselasky committed rS323219: Add support for generic backpressure indicator for ratelimited.
Add support for generic backpressure indicator for ratelimited
Wed, Sep 6, 1:56 PM
hselasky closed D11518: Add support for generic backpressure indicator for ratelimited transmit queues aswell as non-ratelimited ones.
Wed, Sep 6, 1:56 PM
hselasky committed rS323218: MFC r322810 and r322830:.
MFC r322810 and r322830:
Wed, Sep 6, 1:10 PM
hselasky added inline comments to D11518: Add support for generic backpressure indicator for ratelimited transmit queues aswell as non-ratelimited ones.
Wed, Sep 6, 7:01 AM
hselasky added a comment to D11518: Add support for generic backpressure indicator for ratelimited transmit queues aswell as non-ratelimited ones.

Can everyone have a look at this patch again and press accept ? I want to push this patch unless there are any major blockers.

Wed, Sep 6, 7:00 AM
hselasky updated the diff for D11518: Add support for generic backpressure indicator for ratelimited transmit queues aswell as non-ratelimited ones.
Wed, Sep 6, 6:59 AM
hselasky added inline comments to D11518: Add support for generic backpressure indicator for ratelimited transmit queues aswell as non-ratelimited ones.
Wed, Sep 6, 6:44 AM
hselasky added a comment to D11518: Add support for generic backpressure indicator for ratelimited transmit queues aswell as non-ratelimited ones.

Instead of using tags have you considered a modified if_transmit that returns the current occupancy-level of the tx queue (as a percentage or some normalized representation)? That would make it fully stateless and we wouldn't have to involve any inp in any of this. Any feature hooked up to inp will work only for IP connections that terminate on that node and not, say, packet forwarding use cases.

Wed, Sep 6, 6:42 AM

Tue, Aug 29

hselasky accepted D10021: KMS DRM port.
Tue, Aug 29, 8:23 AM

Mon, Aug 28

hselasky accepted D10021: KMS DRM port.
Mon, Aug 28, 8:53 AM

Aug 24 2017

hselasky committed rS322830: Compile fixes for LINT on 32-bit platforms..
Compile fixes for LINT on 32-bit platforms.
Aug 24 2017, 8:09 AM

Aug 23 2017

hselasky committed rS322810: Add new mlx5ib(4) driver to the kernel source tree which supports.
Add new mlx5ib(4) driver to the kernel source tree which supports
Aug 23 2017, 12:09 PM
hselasky accepted D10021: KMS DRM port.

Can you add a port option to set DEBUG_FLAGS="-g" ??

Aug 23 2017, 7:19 AM

Aug 21 2017

hselasky committed rS322747: Merge ^/head r322398 through r322746..
Merge ^/head r322398 through r322746.
Aug 21 2017, 11:58 AM
hselasky committed rS322746: Fix for deadlock situation in the LinuxKPI's RCU synchronize API..
Fix for deadlock situation in the LinuxKPI's RCU synchronize API.
Aug 21 2017, 11:51 AM

Aug 20 2017

hselasky accepted D11786: uath: fix varible types, add checks for descriptor / command header structure fields..

Looks good.

Aug 20 2017, 7:09 PM

Aug 17 2017

hselasky accepted D12054: Move some other SI_SUB_INIT_IF initializations to SI_SUB_TASKQ.

The LinuxKPI bits look good to me. Please address John Baldwins comments before committing.

Aug 17 2017, 6:08 AM

Aug 16 2017

hselasky added a comment to D12050: Fix mlx5en(4) to properly call m_defrag..

This patch looks good to me. @gallatin do you want to test it aswell before it reaches -head? I'll give it a spin tomorrow.

Aug 16 2017, 7:42 PM
hselasky added inline comments to D12050: Fix mlx5en(4) to properly call m_defrag..
Aug 16 2017, 7:35 PM

Aug 15 2017

hselasky committed rS322540: MFC r322250:.
MFC r322250:
Aug 15 2017, 1:37 PM
hselasky committed rS322539: MFC r322250:.
MFC r322250:
Aug 15 2017, 12:57 PM
hselasky committed rS322538: MFC r322251:.
MFC r322251:
Aug 15 2017, 12:54 PM
hselasky committed rS322537: MFC r322251:.
MFC r322251:
Aug 15 2017, 12:30 PM
hselasky committed rS322536: MFC r322248:.
MFC r322248:
Aug 15 2017, 12:28 PM
hselasky committed rS322531: MFC r322248:.
MFC r322248:
Aug 15 2017, 9:21 AM
hselasky committed rS322530: Add new USB quirk..
Add new USB quirk.
Aug 15 2017, 8:44 AM
hselasky committed rS322529: MFC r322248:.
MFC r322248:
Aug 15 2017, 8:29 AM
hselasky accepted D12017: wmt: Driver for generic MS Windows 7/8/10 - compatible USB HID multi-touch devices.
Aug 15 2017, 7:50 AM

Aug 14 2017

hselasky committed rS322507: MFC r322306:.
MFC r322306:
Aug 14 2017, 1:43 PM
hselasky committed rS322506: MFC r322306:.
MFC r322306:
Aug 14 2017, 1:37 PM
hselasky committed rS322505: MFC r322306:.
MFC r322306:
Aug 14 2017, 1:32 PM
hselasky committed rS322504: MFC r322304:.
MFC r322304:
Aug 14 2017, 1:29 PM
hselasky committed rS322503: MFC r322304:.
MFC r322304:
Aug 14 2017, 1:27 PM
hselasky committed rS322502: MFC r289577:.
MFC r289577:
Aug 14 2017, 1:25 PM
hselasky committed rS322501: MFC r292537 and r314878:.
MFC r292537 and r314878:
Aug 14 2017, 1:15 PM
hselasky committed rS322500: MFC r314878:.
MFC r314878:
Aug 14 2017, 12:59 PM
hselasky committed rS322499: MFC r322304:.
MFC r322304:
Aug 14 2017, 12:47 PM
hselasky committed rS322498: MFC r314878:.
MFC r314878:
Aug 14 2017, 12:46 PM
hselasky committed rS322497: MFC r322305:.
MFC r322305:
Aug 14 2017, 12:37 PM
hselasky added inline comments to D11786: uath: fix varible types, add checks for descriptor / command header structure fields..
Aug 14 2017, 12:29 PM
hselasky accepted D12017: wmt: Driver for generic MS Windows 7/8/10 - compatible USB HID multi-touch devices.
Aug 14 2017, 12:14 PM

Aug 13 2017

hselasky added a comment to D11786: uath: fix varible types, add checks for descriptor / command header structure fields..

I'll have a closer look at this tomorrow. Thank you!

Aug 13 2017, 8:07 PM

Aug 11 2017

hselasky committed rS322398: Merge ^/head r321383 through r322397..
Merge ^/head r321383 through r322397.
Aug 11 2017, 11:02 AM
hselasky committed rS322397: Make sure the "vm_flags" and "vm_page_prot" fields get set correctly.
Make sure the "vm_flags" and "vm_page_prot" fields get set correctly
Aug 11 2017, 10:45 AM

Aug 10 2017

hselasky updated subscribers of D1777: Associated fix for arp/nd6 timer usage..

@oleg : Beware of the callout return value differences between FreeBSD 9-10-11 and 12 !
@glebius

Aug 10 2017, 1:08 PM
hselasky committed rS322357: Use integer type to pass around jiffies and/or ticks values in the.
Use integer type to pass around jiffies and/or ticks values in the
Aug 10 2017, 1:05 PM
hselasky committed rS322355: Fixes for wait event in the LinuxKPI. These are regression issues.
Fixes for wait event in the LinuxKPI. These are regression issues
Aug 10 2017, 1:00 PM
hselasky committed rS322354: Make sure the linux_wait_event_common() function in the LinuxKPI properly.
Make sure the linux_wait_event_common() function in the LinuxKPI properly
Aug 10 2017, 12:51 PM
hselasky accepted D11932: Add LinuxKPI support for attaching DRM drivers.

Looks good. Try to make the commit message a bit clearer:

Aug 10 2017, 6:40 AM
hselasky added inline comments to D11932: Add LinuxKPI support for attaching DRM drivers.
Aug 10 2017, 5:46 AM

Aug 9 2017

hselasky committed rS322306: Print maximum MTU when trying to set invalid MTU in the mlx4en(4) driver..
Print maximum MTU when trying to set invalid MTU in the mlx4en(4) driver.
Aug 9 2017, 10:33 AM
hselasky committed rS322305: Increment queue drops in the network statistics when transmitted packets.
Increment queue drops in the network statistics when transmitted packets
Aug 9 2017, 10:31 AM
hselasky committed rS322304: Add support for RX and TX statistics when the mlx4en(4) PCI device.
Add support for RX and TX statistics when the mlx4en(4) PCI device
Aug 9 2017, 10:27 AM
hselasky added inline comments to D11932: Add LinuxKPI support for attaching DRM drivers.
Aug 9 2017, 6:46 AM

Aug 8 2017

hselasky committed rS322251: Make sure the received IP header gets 32-bit aligned for short packets.
Make sure the received IP header gets 32-bit aligned for short packets
Aug 8 2017, 11:49 AM
hselasky committed rS322250: Count drop events due to lack of PCI bandwidth as queue drops and not as.
Count drop events due to lack of PCI bandwidth as queue drops and not as
Aug 8 2017, 11:37 AM