Page MenuHomeFreeBSD

hselasky (Hans Petter Selasky)
User

Projects

User Details

User Since
Nov 28 2014, 6:55 PM (229 w, 1 d)

Recent Activity

Yesterday

hselasky added a comment to D19983: Enable Mellanox drivers on AArch64.

Can you verify that the LINT kernel passes with this change on aarch64?

Sat, Apr 20, 3:03 PM · arm64, Contributor Reviews (base)
hselasky accepted D19987: Enable ioremap for aarch64 in the LinuxKPI.

Commit message should be something like this:
Enable ioremap for aarch64 in the LinuxKPI.

Sat, Apr 20, 2:57 PM · arm64, Contributor Reviews (base)
hselasky added a comment to D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

@glebius: I believe all the alternatives for solving this issue has been enumerated and discussed.

Sat, Apr 20, 1:16 PM
hselasky added a comment to D19983: Enable Mellanox drivers on AArch64.

Can you split this patch?

Sat, Apr 20, 1:08 PM · arm64, Contributor Reviews (base)

Thu, Apr 18

hselasky added a comment to D19845: to be compatible with an IOMMU LinuxKPI should use bus_dma(9).

@johalun: can you try again with the dma_lock changes?

Thu, Apr 18, 8:44 PM
hselasky committed rS346356: Implement flag for telling cuse(3) clients if the peer is running in 32-bit.
Implement flag for telling cuse(3) clients if the peer is running in 32-bit
Thu, Apr 18, 7:04 PM

Wed, Apr 17

hselasky added a comment to D19886: Fix refcount issue in in_getmulti.

Can you test ifconfig adding / removing and setting same ipv4 multicast address and ensure you don't leak by printing the refs involved?
Also can you do the same for starting and stopping rpcbind?

Wed, Apr 17, 11:21 AM
hselasky added inline comments to D19845: to be compatible with an IOMMU LinuxKPI should use bus_dma(9).
Wed, Apr 17, 9:23 AM
hselasky added inline comments to D19845: to be compatible with an IOMMU LinuxKPI should use bus_dma(9).
Wed, Apr 17, 9:19 AM
hselasky added a comment to D19845: to be compatible with an IOMMU LinuxKPI should use bus_dma(9).

When committing and MFC-ing this patch you'll need to bump the __FreeBSD_version in sys/sys/param.h, because you are changing fundamental structures and external kernel modules needs to be rebuilt.

Wed, Apr 17, 9:17 AM
hselasky added a reviewer for D19930: Track device's NUMA domain in ifnet & allocate ifnet from NUMA local memory: slavash.
Wed, Apr 17, 7:38 AM

Mon, Apr 15

hselasky added a comment to D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

Do I get an accept from transport aswell?

Mon, Apr 15, 5:34 PM
hselasky committed rS346248: Remove superfluous USB keyword..
Remove superfluous USB keyword.
Mon, Apr 15, 5:32 PM
hselasky committed rS346229: Fix spelling..
Fix spelling.
Mon, Apr 15, 2:32 PM
hselasky accepted D19063: mlx5en: add pfil ethernet hook.

Looks good.

Mon, Apr 15, 2:12 PM

Fri, Apr 12

hselasky added a comment to D19886: Fix refcount issue in in_getmulti.

The latter in6m_acquire(in6m) should also be removed from carp driver. I think this is a bug. Can you test?

Fri, Apr 12, 12:54 PM
hselasky added inline comments to D19886: Fix refcount issue in in_getmulti.
Fri, Apr 12, 11:52 AM
hselasky added a comment to D19886: Fix refcount issue in in_getmulti.

Are you trying to mimic the solution I did for IPv6 MLD?

Fri, Apr 12, 11:48 AM
hselasky added a comment to D19886: Fix refcount issue in in_getmulti.

Is it possible to fix PF and CARP instead? Allocating an INM with an initial refcount of 2 seems a bit odd!

Fri, Apr 12, 11:03 AM
hselasky added inline comments to D19886: Fix refcount issue in in_getmulti.
Fri, Apr 12, 10:33 AM
hselasky added a comment to D19886: Fix refcount issue in in_getmulti.

What kind of tests have been done in order to check for leaks?

Fri, Apr 12, 8:24 AM

Thu, Apr 11

hselasky added a comment to D19845: to be compatible with an IOMMU LinuxKPI should use bus_dma(9).

@johalun : I'd like to have you test these patches with drm-next before going upstream. Can you do that?

Thu, Apr 11, 1:27 PM
hselasky committed rS346119: Remove unused raw_value field..
Remove unused raw_value field.
Thu, Apr 11, 8:07 AM

Wed, Apr 10

hselasky committed rS346093: Define the callout return value like a two-bit state in a structure..
Define the callout return value like a two-bit state in a structure.
Wed, Apr 10, 6:17 PM
hselasky committed rS346091: Callout drain does not have to be followed by a callout stop call..
Callout drain does not have to be followed by a callout stop call.
Wed, Apr 10, 6:12 PM
hselasky committed rS346083: Create new projects branch for working on the kernel callout subsystem..
Create new projects branch for working on the kernel callout subsystem.
Wed, Apr 10, 4:09 PM
hselasky committed rS346084: Delete old projects branch..
Delete old projects branch.
Wed, Apr 10, 3:55 PM

Mon, Apr 8

hselasky added inline comments to D19845: to be compatible with an IOMMU LinuxKPI should use bus_dma(9).
Mon, Apr 8, 4:04 PM
hselasky added a reviewer for D19845: to be compatible with an IOMMU LinuxKPI should use bus_dma(9): johalun.
Mon, Apr 8, 3:55 PM
hselasky added reviewers for D19845: to be compatible with an IOMMU LinuxKPI should use bus_dma(9): slavash, kib.
Mon, Apr 8, 3:47 PM

Fri, Apr 5

hselasky committed rS345946: MFC r345633:.
MFC r345633:
Fri, Apr 5, 11:39 AM
hselasky committed rS345945: MFC r345633:.
MFC r345633:
Fri, Apr 5, 11:38 AM
hselasky committed rS345944: MFC r345499:.
MFC r345499:
Fri, Apr 5, 11:37 AM
hselasky committed rS345943: MFC r345499:.
MFC r345499:
Fri, Apr 5, 11:36 AM
hselasky committed rS345942: MFC r345499:.
MFC r345499:
Fri, Apr 5, 11:35 AM
hselasky committed rS345941: MFC r345499:.
MFC r345499:
Fri, Apr 5, 11:34 AM
hselasky committed rS345940: MFC r345109:.
MFC r345109:
Fri, Apr 5, 11:33 AM
hselasky committed rS345939: MFC r345109:.
MFC r345109:
Fri, Apr 5, 11:33 AM
hselasky committed rS345938: MFC r345108:.
MFC r345108:
Fri, Apr 5, 11:32 AM
hselasky committed rS345937: MFC r345108:.
MFC r345108:
Fri, Apr 5, 11:31 AM
hselasky committed rS345936: MFC r345107:.
MFC r345107:
Fri, Apr 5, 11:30 AM
hselasky committed rS345935: MFC r345107:.
MFC r345107:
Fri, Apr 5, 11:30 AM
hselasky committed rS345934: MFC r345106:.
MFC r345106:
Fri, Apr 5, 11:29 AM
hselasky committed rS345933: MFC r345106:.
MFC r345106:
Fri, Apr 5, 11:29 AM
hselasky committed rS345932: MFC r345105:.
MFC r345105:
Fri, Apr 5, 11:28 AM
hselasky committed rS345931: MFC r345105:.
MFC r345105:
Fri, Apr 5, 11:27 AM
hselasky committed rS345930: MFC r345104:.
MFC r345104:
Fri, Apr 5, 11:26 AM
hselasky committed rS345929: MFC r345104:.
MFC r345104:
Fri, Apr 5, 11:26 AM
hselasky committed rS345928: MFC r345101:.
MFC r345101:
Fri, Apr 5, 11:24 AM
hselasky committed rS345927: MFC r345101:.
MFC r345101:
Fri, Apr 5, 11:24 AM
hselasky committed rS345926: MFC r345099:.
MFC r345099:
Fri, Apr 5, 11:21 AM
hselasky committed rS345925: MFC r345099:.
MFC r345099:
Fri, Apr 5, 11:20 AM
hselasky committed rS345924: MFC r345098:.
MFC r345098:
Fri, Apr 5, 11:19 AM
hselasky committed rS345923: MFC r345098:.
MFC r345098:
Fri, Apr 5, 11:19 AM
hselasky committed rS345922: MFC r345097:.
MFC r345097:
Fri, Apr 5, 11:17 AM
hselasky committed rS345921: MFC r345097:.
MFC r345097:
Fri, Apr 5, 11:17 AM
hselasky committed rS345920: MFC r345096:.
MFC r345096:
Fri, Apr 5, 11:16 AM
hselasky committed rS345919: MFC r345096:.
MFC r345096:
Fri, Apr 5, 11:16 AM
hselasky committed rS345918: MFC r345095 and r345110:.
MFC r345095 and r345110:
Fri, Apr 5, 11:14 AM
hselasky committed rS345917: MFC r345095 and r345110:.
MFC r345095 and r345110:
Fri, Apr 5, 11:14 AM
hselasky committed rS345916: MFC r345094:.
MFC r345094:
Fri, Apr 5, 11:11 AM
hselasky committed rS345915: MFC r345094:.
MFC r345094:
Fri, Apr 5, 11:11 AM
hselasky committed rS345914: MFC r345093:.
MFC r345093:
Fri, Apr 5, 11:10 AM
hselasky committed rS345913: MFC r345093:.
MFC r345093:
Fri, Apr 5, 11:10 AM
hselasky committed rS345912: MFC r345092:.
MFC r345092:
Fri, Apr 5, 11:09 AM
hselasky committed rS345911: MFC r345092:.
MFC r345092:
Fri, Apr 5, 11:08 AM
hselasky committed rS345910: MFC r345091:.
MFC r345091:
Fri, Apr 5, 11:07 AM
hselasky committed rS345909: MFC r345091:.
MFC r345091:
Fri, Apr 5, 11:07 AM
hselasky committed rS345908: MFC r345090:.
MFC r345090:
Fri, Apr 5, 11:06 AM
hselasky committed rS345907: MFC r345090:.
MFC r345090:
Fri, Apr 5, 11:06 AM
hselasky committed rS345906: MFC r336832:.
MFC r336832:
Fri, Apr 5, 10:01 AM

Wed, Apr 3

hselasky updated the diff for D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

Fix eventhandler function arguments. Apparently there was no compiletime check for the prototype.

Wed, Apr 3, 10:16 AM
hselasky updated the diff for D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

I've had another go at this and it appears only IPv4 and IPv6 fragments cause use-after free and panic.
I've narrowed down my patch to be more specific.

Wed, Apr 3, 9:33 AM

Sat, Mar 30

hselasky committed rP497368: Update virtual_oss to 1.2.2.
Update virtual_oss to 1.2.2
Sat, Mar 30, 11:00 PM
hselasky accepted D19764: Fix if_(m)addr_rlock() on stable/12..

The patch technically looks good to me. Is this change for MFC only?

Sat, Mar 30, 6:57 PM

Fri, Mar 29

hselasky added a comment to D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

@glebius and @hselasky rather than changing pr_drain I wondered about an eventhandler or something as that way dealing with non-protocol places such as firewalls, netisr, .. would also be possible? I think not queuing is not an option, arp queue is just another one of these places... there's more and more the longer I think about it... We'll need something to get them all (and getting the locking right).

Fri, Mar 29, 1:39 PM
hselasky committed rP497114: Restore virtual_oss_ctl to version 1.2.0..
Restore virtual_oss_ctl to version 1.2.0.
Fri, Mar 29, 12:49 PM
hselasky committed rP497113: Update virtual_oss to 1.2.1.
Update virtual_oss to 1.2.1
Fri, Mar 29, 12:47 PM

Thu, Mar 28

hselasky committed rS345633: Add new USB PCI ID..
Add new USB PCI ID.
Thu, Mar 28, 9:01 AM

Tue, Mar 26

hselasky committed rS345546: MFC r342961:.
MFC r342961:
Tue, Mar 26, 1:53 PM
hselasky committed rS345545: MFC r342961:.
MFC r342961:
Tue, Mar 26, 1:53 PM
hselasky committed rS345544: MFC r342961:.
MFC r342961:
Tue, Mar 26, 1:52 PM
hselasky committed rS345543: MFC r343352:.
MFC r343352:
Tue, Mar 26, 1:49 PM
hselasky committed rS345542: MFC r343352:.
MFC r343352:
Tue, Mar 26, 1:49 PM
hselasky committed rS345541: MFC r344795:.
MFC r344795:
Tue, Mar 26, 1:46 PM
hselasky committed rS345540: MFC r344795:.
MFC r344795:
Tue, Mar 26, 1:46 PM
hselasky committed rS345539: MFC r344795:.
MFC r344795:
Tue, Mar 26, 1:45 PM
hselasky committed rS345538: MFC r345011:.
MFC r345011:
Tue, Mar 26, 1:43 PM
hselasky committed rS345537: MFC r345011:.
MFC r345011:
Tue, Mar 26, 1:42 PM
hselasky committed rS345536: MFC r345010:.
MFC r345010:
Tue, Mar 26, 1:41 PM
hselasky committed rS345535: MFC r345010:.
MFC r345010:
Tue, Mar 26, 1:40 PM
hselasky committed rS345534: MFC r344920:.
MFC r344920:
Tue, Mar 26, 1:39 PM
hselasky committed rS345533: MFC r344920:.
MFC r344920:
Tue, Mar 26, 1:38 PM
hselasky committed rS345532: MFC r344919:.
MFC r344919:
Tue, Mar 26, 1:35 PM
hselasky committed rS345531: MFC r344919:.
MFC r344919:
Tue, Mar 26, 1:33 PM

Mon, Mar 25

hselasky committed rS345499: Change all kernel C-type macros into static inline functions..
Change all kernel C-type macros into static inline functions.
Mon, Mar 25, 1:50 PM
hselasky closed D19694: Change all kernel C-type macros into static inline functions.
Mon, Mar 25, 1:50 PM

Sun, Mar 24

hselasky updated the diff for D19694: Change all kernel C-type macros into static inline functions.
Sun, Mar 24, 8:00 PM
hselasky added a reviewer for D19694: Change all kernel C-type macros into static inline functions: imp.
Sun, Mar 24, 3:30 PM
hselasky created D19694: Change all kernel C-type macros into static inline functions.
Sun, Mar 24, 3:29 PM