Page MenuHomeFreeBSD
People hselasky

hselasky (Hans Petter Selasky)
User

Projects

User Details

User Since
Nov 28 2014, 6:55 PM (347 w, 5 d)

Recent Activity
View All

Yesterday

hselasky accepted D30980: LinuxKPI: add read_poll_timeout().
Wed, Jul 28, 3:35 PM
hselasky added a comment to D31320: sound(4): implement playback/recording mode sysctl.

Yes, MIDI devices are also PCM devices, but there is no /dev/dspX device.

Wed, Jul 28, 3:31 PM
hselasky added a comment to D31320: sound(4): implement playback/recording mode sysctl.

PCM_MODE_NONE usually means MIDI. Could you investigate that a bit?

Wed, Jul 28, 3:04 PM
hselasky accepted D30980: LinuxKPI: add read_poll_timeout().
Wed, Jul 28, 2:26 PM
hselasky added a comment to D31320: sound(4): implement playback/recording mode sysctl.

What is the motivation for changing this?

Wed, Jul 28, 2:25 PM
hselasky added inline comments to D30980: LinuxKPI: add read_poll_timeout().
Wed, Jul 28, 1:14 PM
hselasky accepted D31322: LinuxKPI: add fsleep().
Wed, Jul 28, 1:12 PM
hselasky committed R10:d2cbfbc57b20: mlx5/mlx4: Bump driver version to 3.7 (authored by hselasky).
mlx5/mlx4: Bump driver version to 3.7
Wed, Jul 28, 11:48 AM
hselasky closed D29100: mlx5: Print driver version only when creating an interface.
Wed, Jul 28, 11:48 AM
hselasky accepted D29100: mlx5: Print driver version only when creating an interface.
Wed, Jul 28, 11:37 AM
hselasky committed R10:b633e08c705f: ibcore: Kernel space update based on Linux 5.7-rc1. (authored by hselasky).
ibcore: Kernel space update based on Linux 5.7-rc1.
Wed, Jul 28, 11:35 AM
hselasky accepted D31320: sound(4): implement playback/recording mode sysctl.
Wed, Jul 28, 11:15 AM
hselasky added a comment to D31320: sound(4): implement playback/recording mode sysctl.

OK! Can you update the patch to use "mode"?

Wed, Jul 28, 10:54 AM
hselasky added a comment to D31320: sound(4): implement playback/recording mode sysctl.

Does the word "mode" make sense to you?

Wed, Jul 28, 10:42 AM
hselasky accepted D31149: ibcore: Kernel space update based on Linux 5.7-rc1.
Wed, Jul 28, 10:07 AM

Tue, Jul 27

hselasky added inline comments to D31322: LinuxKPI: add fsleep().
Tue, Jul 27, 4:26 PM
hselasky accepted D31321: LinuxKPI: add nexthdr definitions for IPv6.
Tue, Jul 27, 1:53 PM
hselasky added a comment to D31320: sound(4): implement playback/recording mode sysctl.

Could you check an english dictionary with synonyms?

Tue, Jul 27, 1:12 PM
hselasky added a comment to D31320: sound(4): implement playback/recording mode sysctl.

Are there other options for naming.

Tue, Jul 27, 12:39 PM
hselasky added a comment to D31320: sound(4): implement playback/recording mode sysctl.

I think s/status/feature/ is a better word?

Tue, Jul 27, 12:24 PM

Mon, Jul 26

hselasky committed R11:751dac326be4: audio/hpsjam: Update to 1.0.16 (authored by hselasky).
audio/hpsjam: Update to 1.0.16
Mon, Jul 26, 4:41 PM
hselasky committed R10:9661887500f8: Fix mismerge in OFED update (authored by hselasky).
Fix mismerge in OFED update
Mon, Jul 26, 4:16 PM
hselasky committed R10:5f23486df92d: ipoib: Fix for accessing uninitialized pointers and freed memory during attach… (authored by hselasky).
ipoib: Fix for accessing uninitialized pointers and freed memory during attach…
Mon, Jul 26, 4:16 PM
hselasky committed R10:5b803f682001: mlx5: Numa domain improvements. (authored by hselasky).
mlx5: Numa domain improvements.
Mon, Jul 26, 4:16 PM
hselasky committed R10:2b4db9bbc23b: mlx5: Fix for uninitialized "uid" field. (authored by hselasky).
mlx5: Fix for uninitialized "uid" field.
Mon, Jul 26, 4:16 PM
hselasky committed R10:191a0e65a016: mlx4: Map core_clock page to user space only when allowed (authored by hselasky).
mlx4: Map core_clock page to user space only when allowed
Mon, Jul 26, 4:16 PM
hselasky committed R10:fdab56d1f605: mlx5en: Allow binding channels to CPUs when RSS is not enabled. (authored by hselasky).
mlx5en: Allow binding channels to CPUs when RSS is not enabled.
Mon, Jul 26, 4:16 PM
hselasky committed R10:9fe9a92ab68f: ibcore: Add some functions and definitions for selecting and querying retryable… (authored by hselasky).
ibcore: Add some functions and definitions for selecting and querying retryable…
Mon, Jul 26, 4:16 PM
hselasky committed R10:0ebff67cab8b: mlx5en: Wait for all TLS connections to terminate when unloading driver. (authored by hselasky).
mlx5en: Wait for all TLS connections to terminate when unloading driver.
Mon, Jul 26, 4:16 PM
hselasky committed R10:857966b357ee: mlx5en: Allocate per-channel doorbells. (authored by hselasky).
mlx5en: Allocate per-channel doorbells.
Mon, Jul 26, 4:16 PM
hselasky committed R10:1554e2673b3b: mlx5en: Configure relaxed PCI read and write ordering for ethernet. (authored by hselasky).
mlx5en: Configure relaxed PCI read and write ordering for ethernet.
Mon, Jul 26, 4:16 PM
hselasky committed R10:cd08d4c53775: mlx4ib and mlx5ib: Set slid to zero in Ethernet completion struct (authored by hselasky).
mlx4ib and mlx5ib: Set slid to zero in Ethernet completion struct
Mon, Jul 26, 4:16 PM
hselasky committed R10:c41403c5cae2: mlx5en: Check for pci_channel_offline() when draining sendqueue. (authored by hselasky).
mlx5en: Check for pci_channel_offline() when draining sendqueue.
Mon, Jul 26, 4:16 PM
hselasky committed R10:763d239db250: mlx5ib: Implement support for enabling and disabling RoCE ECN. (authored by hselasky).
mlx5ib: Implement support for enabling and disabling RoCE ECN.
Mon, Jul 26, 4:15 PM
hselasky committed R10:75b63f08d2e8: mlx5core: Don't query the PCI config space for offline during a firmware… (authored by hselasky).
mlx5core: Don't query the PCI config space for offline during a firmware…
Mon, Jul 26, 4:15 PM
hselasky committed R10:526c54f54b50: mlx5ib: Extend parameter macros so that more arguments may be added. (authored by hselasky).
mlx5ib: Extend parameter macros so that more arguments may be added.
Mon, Jul 26, 4:15 PM
hselasky committed R10:f52bc34a0635: Fix LINT kernel build issues after c3987b8ea793c11f61fecb14ef93195a23e3522c . (authored by hselasky).
Fix LINT kernel build issues after c3987b8ea793c11f61fecb14ef93195a23e3522c .
Mon, Jul 26, 4:15 PM
hselasky committed R10:47f7e8e4231f: ibcore: Declare ib_post_send() and ib_post_recv() arguments const (authored by hselasky).
ibcore: Declare ib_post_send() and ib_post_recv() arguments const
Mon, Jul 26, 4:15 PM
hselasky committed R10:ee9aeb312c4c: ibcore: Implement ib_uverbs_get_ucontext_file(). (authored by hselasky).
ibcore: Implement ib_uverbs_get_ucontext_file().
Mon, Jul 26, 4:15 PM
hselasky committed R10:b383248ef6dc: mlx5: Set default timestamp format for mlx5en(4) and mlx5ib. (authored by hselasky).
mlx5: Set default timestamp format for mlx5en(4) and mlx5ib.
Mon, Jul 26, 4:15 PM
hselasky committed R10:a7a80f17715c: mlx5: Add new timestamp mode bits. (authored by hselasky).
mlx5: Add new timestamp mode bits.
Mon, Jul 26, 4:15 PM
hselasky committed R10:11f42801533c: ibcore: Clean up INIT_UDATA() and INIT_UDATA_BUF_OR_NULL() macro usage. (authored by hselasky).
ibcore: Clean up INIT_UDATA() and INIT_UDATA_BUF_OR_NULL() macro usage.
Mon, Jul 26, 4:15 PM
hselasky committed R10:1c1c0acb3113: ibcore: Simplify ib_modify_qp_is_ok(). (authored by hselasky).
ibcore: Simplify ib_modify_qp_is_ok().
Mon, Jul 26, 4:15 PM
hselasky committed R10:4c033941d0b9: ibcore: Support rate limit for packet pacing (authored by hselasky).
ibcore: Support rate limit for packet pacing
Mon, Jul 26, 4:15 PM
hselasky committed R10:d76e6346afbc: ibcore: Add new IB rates. (authored by hselasky).
ibcore: Add new IB rates.
Mon, Jul 26, 4:15 PM
hselasky committed R10:a0d74ac3f370: ibcore: Fix a use-after-free in ucma_resolve_ip(). (authored by hselasky).
ibcore: Fix a use-after-free in ucma_resolve_ip().
Mon, Jul 26, 4:15 PM
hselasky committed R10:1753641a8b93: ibcore: Define option to set ack timeout. (authored by hselasky).
ibcore: Define option to set ack timeout.
Mon, Jul 26, 4:15 PM
hselasky committed R10:d857bf203733: ibcore: Don't allocate method table, if already present. (authored by hselasky).
ibcore: Don't allocate method table, if already present.
Mon, Jul 26, 4:15 PM
hselasky committed R10:fe866f58903b: ibcore: Remove debug prints after allocation failure. (authored by hselasky).
ibcore: Remove debug prints after allocation failure.
Mon, Jul 26, 4:15 PM
hselasky committed R10:7449dd9a127d: ibcore: Do not overreact to SM LID change event. (authored by hselasky).
ibcore: Do not overreact to SM LID change event.
Mon, Jul 26, 4:15 PM
hselasky committed R10:36f60545aac6: ibcore: Fix use-after-free in IB mad completion handling. (authored by hselasky).
ibcore: Fix use-after-free in IB mad completion handling.
Mon, Jul 26, 4:15 PM
hselasky committed R10:7da85a0db999: ibcore: Fail early if unsupported QP is provided. (authored by hselasky).
ibcore: Fail early if unsupported QP is provided.
Mon, Jul 26, 4:14 PM
hselasky committed R10:dd7241e04d90: ibcore: Use inline function to validate port (authored by hselasky).
ibcore: Use inline function to validate port
Mon, Jul 26, 4:14 PM
hselasky committed R10:a4b27295c71e: ibcore: Validate port number in query_pkey verb. (authored by hselasky).
ibcore: Validate port number in query_pkey verb.
Mon, Jul 26, 4:14 PM
hselasky committed R10:6ee862127d3d: ibcore: Protect against concurrent access to hardware stats. (authored by hselasky).
ibcore: Protect against concurrent access to hardware stats.
Mon, Jul 26, 4:14 PM
hselasky committed R10:f919e2521470: mlx5core: Make sure error code is propagated on error. (authored by hselasky).
mlx5core: Make sure error code is propagated on error.
Mon, Jul 26, 4:14 PM
hselasky committed R10:e898f1af80f6: ibcore: Do not expose unsupported counters. (authored by hselasky).
ibcore: Do not expose unsupported counters.
Mon, Jul 26, 4:14 PM
hselasky committed R10:2cbd28890432: ibcore: Introduce ib_port_phys_state enum. (authored by hselasky).
ibcore: Introduce ib_port_phys_state enum.
Mon, Jul 26, 4:14 PM
hselasky committed R10:645d0710fc48: ibcore: Fix unable to change lifespan entry for hw_counters. (authored by hselasky).
ibcore: Fix unable to change lifespan entry for hw_counters.
Mon, Jul 26, 4:14 PM
hselasky committed R10:c629928b25cc: ibcore: Fix memory leak in cm_req_handler error flows. (authored by hselasky).
ibcore: Fix memory leak in cm_req_handler error flows.
Mon, Jul 26, 4:14 PM
hselasky committed R10:06307dd6e0df: ibcore: Issue DREQ when receiving REQ/REP for stale QP. (authored by hselasky).
ibcore: Issue DREQ when receiving REQ/REP for stale QP.
Mon, Jul 26, 4:14 PM
hselasky committed R10:c254f79d9ae7: ibcore: Move debug counters to be under relevant IB device (authored by hselasky).
ibcore: Move debug counters to be under relevant IB device
Mon, Jul 26, 4:14 PM
hselasky committed R10:072eaae40ba7: ibcore: Fix memory leak in cm_add/remove_one. (authored by hselasky).
ibcore: Fix memory leak in cm_add/remove_one.
Mon, Jul 26, 4:14 PM
hselasky committed R10:a306f3d4485d: ibcore: Block processing of alternate path handling in RoCE RX CM messages. (authored by hselasky).
ibcore: Block processing of alternate path handling in RoCE RX CM messages.
Mon, Jul 26, 4:14 PM
hselasky committed R10:b3f8942c1a5d: ibcore: Store and restore ah_attr during LAP msg processing. (authored by hselasky).
ibcore: Store and restore ah_attr during LAP msg processing.
Mon, Jul 26, 4:14 PM
hselasky committed R10:bc73c139f027: ibcore: Add rdma_reject_msg() helper function. (authored by hselasky).
ibcore: Add rdma_reject_msg() helper function.
Mon, Jul 26, 4:14 PM
hselasky committed R10:349d037802fe: mlx5ib: Fix XRC QP support after introducing extended atomic. (authored by hselasky).
mlx5ib: Fix XRC QP support after introducing extended atomic.
Mon, Jul 26, 4:14 PM
hselasky committed R10:6c80d908d671: ibcore: Remove unused and erroneous msg sequence encoding. (authored by hselasky).
ibcore: Remove unused and erroneous msg sequence encoding.
Mon, Jul 26, 4:14 PM
hselasky committed R10:4e16399f4507: ipoib: Destroying a CQ should never fail. (authored by hselasky).
ipoib: Destroying a CQ should never fail.
Mon, Jul 26, 4:13 PM
hselasky committed R10:f1d4741b7600: mlx5ib: Limit mkey page size to 2GB (authored by hselasky).
mlx5ib: Limit mkey page size to 2GB
Mon, Jul 26, 4:13 PM
hselasky committed R10:6b49b46f2692: mlx5en: Add more error checks in the transmit path. (authored by hselasky).
mlx5en: Add more error checks in the transmit path.
Mon, Jul 26, 4:13 PM
hselasky committed R10:cae3be82c3cd: mlx5ib: Simplify mlx5_ib_cont_pages() (authored by hselasky).
mlx5ib: Simplify mlx5_ib_cont_pages()
Mon, Jul 26, 4:13 PM
hselasky committed R10:24cf63c77833: mlx5ib: Support RAW Ethernet when RoCE is disabled in mlx5ib(4) (authored by hselasky).
mlx5ib: Support RAW Ethernet when RoCE is disabled in mlx5ib(4)
Mon, Jul 26, 4:13 PM
hselasky committed R10:906117f77367: mlx5en: Add missing media types for 100GBit/s, 200Gbit/s and 400Gbit/s. (authored by hselasky).
mlx5en: Add missing media types for 100GBit/s, 200Gbit/s and 400Gbit/s.
Mon, Jul 26, 4:13 PM

Wed, Jul 21

hselasky committed R10:575945f10b9e: Update the mlx5en(4) manual page. (authored by hselasky).
Update the mlx5en(4) manual page.
Wed, Jul 21, 9:12 AM
hselasky committed R10:0f8dafb45859: Implement the SOUND_MIXER_WRITE_MUTE and SOUND_MIXER_READ_MUTE ioctl(9)s. (authored by hselasky).
Implement the SOUND_MIXER_WRITE_MUTE and SOUND_MIXER_READ_MUTE ioctl(9)s.
Wed, Jul 21, 9:12 AM
hselasky closed D31228: Update mlx5en(4).
Wed, Jul 21, 9:12 AM
hselasky closed D31130: sound(4): mixer: implement (un)muting.
Wed, Jul 21, 9:12 AM
hselasky updated the diff for D31228: Update mlx5en(4).

Address comments from kib@

Wed, Jul 21, 8:56 AM
hselasky added a comment to D30980: LinuxKPI: add read_poll_timeout().

Ping. See my comment.

Wed, Jul 21, 8:43 AM
hselasky accepted D31130: sound(4): mixer: implement (un)muting.
Wed, Jul 21, 8:38 AM

Tue, Jul 20

hselasky updated the diff for D31228: Update mlx5en(4).

Address comments from @kib

Tue, Jul 20, 3:57 PM
hselasky added inline comments to D31228: Update mlx5en(4).
Tue, Jul 20, 3:56 PM
hselasky requested review of D31228: Update mlx5en(4).
Tue, Jul 20, 9:59 AM
hselasky added a comment to D31149: ibcore: Kernel space update based on Linux 5.7-rc1.

@np: I've included your patches now. Do you have more? I know at least the mmap support needs a check.

Tue, Jul 20, 8:07 AM
hselasky updated the diff for D31149: ibcore: Kernel space update based on Linux 5.7-rc1.

Update patch.

Tue, Jul 20, 8:06 AM
hselasky added a comment to D31149: ibcore: Kernel space update based on Linux 5.7-rc1.

@np: Is is possible you could send the changes as an incremental diff to: hselasky@freebsd.org ?

Tue, Jul 20, 7:43 AM

Mon, Jul 19

hselasky added a comment to D31149: ibcore: Kernel space update based on Linux 5.7-rc1.

Hi Navdeep,

Mon, Jul 19, 3:59 PM

Sun, Jul 18

hselasky committed R11:9b61f489deb7: audio/midipp: Update to 2.0.9 (authored by hselasky).
audio/midipp: Update to 2.0.9
Sun, Jul 18, 11:08 AM
hselasky committed R11:2a254107cf3a: audio/hpsjam: Update to 1.0.15 (authored by hselasky).
audio/hpsjam: Update to 1.0.15
Sun, Jul 18, 11:08 AM

Thu, Jul 15

hselasky accepted D31195: tcp: Lro needs to validate that it does not go beyond the end of the mbuf as it parses..
Thu, Jul 15, 7:33 PM
hselasky added inline comments to D31195: tcp: Lro needs to validate that it does not go beyond the end of the mbuf as it parses..
Thu, Jul 15, 6:28 PM
hselasky added inline comments to D31195: tcp: Lro needs to validate that it does not go beyond the end of the mbuf as it parses..
Thu, Jul 15, 5:59 PM
hselasky added inline comments to D31195: tcp: Lro needs to validate that it does not go beyond the end of the mbuf as it parses..
Thu, Jul 15, 5:41 PM
hselasky added inline comments to D31195: tcp: Lro needs to validate that it does not go beyond the end of the mbuf as it parses..
Thu, Jul 15, 5:40 PM
hselasky added a comment to D31195: tcp: Lro needs to validate that it does not go beyond the end of the mbuf as it parses..

Hi Randall,

Thu, Jul 15, 5:36 PM
hselasky added a reviewer for D31195: tcp: Lro needs to validate that it does not go beyond the end of the mbuf as it parses.: gallatin.
Thu, Jul 15, 5:11 PM
hselasky added a comment to D31195: tcp: Lro needs to validate that it does not go beyond the end of the mbuf as it parses..

Hi Randall,

Thu, Jul 15, 5:10 PM
hselasky added inline comments to D31189: tcp: LRO epoch issue as well a potential pullup issue..
Thu, Jul 15, 3:15 PM
hselasky added inline comments to D31189: tcp: LRO epoch issue as well a potential pullup issue..
Thu, Jul 15, 2:34 PM