Page MenuHomeFreeBSD

arichardson (Alexander Richardson)
User

Projects

User Details

User Since
Jan 17 2017, 2:21 PM (221 w, 5 d)

Recent Activity

Thu, Apr 15

arichardson added inline comments to D29680: bsd.compiler.mk: detect Apple Clang for cross-builds.
Thu, Apr 15, 3:44 PM
arichardson committed R10:062293c2c471: Remove XFAIL from tests/lib/msun/lround_test:main (authored by arichardson).
Remove XFAIL from tests/lib/msun/lround_test:main
Thu, Apr 15, 3:29 PM
arichardson committed R10:3f01d8c2fe5d: Remove amd64 XFAIL from tests/lib/msun/fma_test:infinities (authored by arichardson).
Remove amd64 XFAIL from tests/lib/msun/fma_test:infinities
Thu, Apr 15, 3:29 PM
arichardson closed D29743: lib/msun: Exclude ignored-pragmas from -Werror.
Thu, Apr 15, 3:28 PM
arichardson committed R10:168234fa67c3: lib/msun: Exclude ignored-pragmas from -Werror (authored by arichardson).
lib/msun: Exclude ignored-pragmas from -Werror
Thu, Apr 15, 3:28 PM
arichardson added inline comments to D29536: libc/string/memset.c: Use unsigned long for stores.
Thu, Apr 15, 3:14 PM
arichardson added inline comments to D29680: bsd.compiler.mk: detect Apple Clang for cross-builds.
Thu, Apr 15, 2:54 PM
arichardson added a comment to D29680: bsd.compiler.mk: detect Apple Clang for cross-builds.

ping?

Thu, Apr 15, 10:37 AM
arichardson planned changes to D28536: libthr: Avoid interposable calls to memcpy/memset/memmove.
Thu, Apr 15, 10:36 AM
arichardson updated the summary of D29535: libc/string/bcopy.c: Use intptr_t as the copy type.
Thu, Apr 15, 10:36 AM
arichardson added a comment to D29536: libc/string/memset.c: Use unsigned long for stores.

ping?

Thu, Apr 15, 10:36 AM
arichardson updated the summary of D29536: libc/string/memset.c: Use unsigned long for stores.
Thu, Apr 15, 10:35 AM
arichardson added a comment to D29535: libc/string/bcopy.c: Use intptr_t as the copy type.

ping?

Thu, Apr 15, 10:35 AM
arichardson added a comment to D29159: linker_set: fix globl/weak symbol redefinitions to work on clang 12.

Will commit this version on Monday unless anyone has further comments.

Thu, Apr 15, 10:33 AM
arichardson accepted D29159: linker_set: fix globl/weak symbol redefinitions to work on clang 12.
Thu, Apr 15, 10:32 AM
arichardson added a comment to D29039: Allow lib/msun/logarithm_test to pass on ld128 platforms.

ping?

Thu, Apr 15, 10:30 AM
arichardson updated the diff for D28886: Update rtsock_l3 test after 2fe5a79425c79f7b828acd91da66d97230925fc8.

Rebase after D29528

Thu, Apr 15, 10:24 AM

Wed, Apr 14

arichardson added a comment to D29743: lib/msun: Exclude ignored-pragmas from -Werror.

Looks like the warning is not triggered for x86, only other architectures. That indicates that the pragmas might actually be implemented now.
Should I restrict the -Wno-error to non-x86?

Wed, Apr 14, 9:28 AM
arichardson added a reviewer for D29159: linker_set: fix globl/weak symbol redefinitions to work on clang 12: jrtc27.
Wed, Apr 14, 9:24 AM
arichardson updated the diff for D29159: linker_set: fix globl/weak symbol redefinitions to work on clang 12.
  • Use __XSTRING
Wed, Apr 14, 9:23 AM
arichardson commandeered D29159: linker_set: fix globl/weak symbol redefinitions to work on clang 12.
Wed, Apr 14, 9:21 AM

Tue, Apr 13

arichardson added a comment to D29743: lib/msun: Exclude ignored-pragmas from -Werror.

I saw this building CheriBSD, and I think it affected almost all architectures.

Tue, Apr 13, 1:41 PM
arichardson updated the summary of D29679: contrib/flex: Drop local __dead2 patch.
Tue, Apr 13, 12:26 PM
arichardson updated the diff for D29679: contrib/flex: Drop local __dead2 patch.

re-generate bootstrap files

Tue, Apr 13, 12:25 PM
arichardson added a comment to D27972: Revert "arcconfig: add callsign again".

I think arcanist might not like numeric-only callsigns? I can't figure out what the correct value should be.

Tue, Apr 13, 12:07 PM
arichardson requested review of D29743: lib/msun: Exclude ignored-pragmas from -Werror.
Tue, Apr 13, 11:59 AM
arichardson committed R10:73c14cc76b5f: Remove history.immutable from .arcconfig (authored by arichardson).
Remove history.immutable from .arcconfig
Tue, Apr 13, 11:39 AM
arichardson closed D27971: Remove history.immutable from .arcconfig.
Tue, Apr 13, 11:39 AM
arichardson updated the diff for D27971: Remove history.immutable from .arcconfig.

rebase

Tue, Apr 13, 11:36 AM

Sat, Apr 10

arichardson committed R10:7755e8ae322b: ifconfig: fix UBSan signed shift error (authored by arichardson).
ifconfig: fix UBSan signed shift error
Sat, Apr 10, 1:31 PM
arichardson committed R10:d612bd6d0d5d: libarchive: Make test_read_append_filter_wrong_program pass again (authored by arichardson).
libarchive: Make test_read_append_filter_wrong_program pass again
Sat, Apr 10, 1:31 PM
arichardson committed R10:676010ab86f5: tests/sys/net/routing: XFAIL the two failing tests (authored by arichardson).
tests/sys/net/routing: XFAIL the two failing tests
Sat, Apr 10, 1:31 PM
arichardson committed R10:c5cde5af4b82: resolv_test: Fix racy exit check, remove mutexes, and reduce output (authored by arichardson).
resolv_test: Fix racy exit check, remove mutexes, and reduce output
Sat, Apr 10, 1:31 PM
arichardson committed R10:30626f9ad5ef: sys/dev/md: Drop unncessary __GLOBL(mfs_root) (authored by arichardson).
sys/dev/md: Drop unncessary __GLOBL(mfs_root)
Sat, Apr 10, 1:31 PM
arichardson committed R10:52b6501bd7de: libsa: Remove conflicting .global/.weak directive (authored by arichardson).
libsa: Remove conflicting .global/.weak directive
Sat, Apr 10, 1:31 PM
arichardson committed R10:3496971e61dc: lib/libc/net/nsdispatch.c: Fix missing unlock and add locking annotations (authored by arichardson).
lib/libc/net/nsdispatch.c: Fix missing unlock and add locking annotations
Sat, Apr 10, 1:31 PM
arichardson committed R10:0eafcef4552c: RISC-V: Fix feenableexcept return value (authored by arichardson).
RISC-V: Fix feenableexcept return value
Sat, Apr 10, 1:31 PM
arichardson committed R10:57971fe46793: bsd.compiler.mk: Detect distribution-provided GCC when executed as cc (authored by jrtc27).
bsd.compiler.mk: Detect distribution-provided GCC when executed as cc
Sat, Apr 10, 1:31 PM
arichardson committed R10:54d6cf9ec82b: Allow using sanitizers for ssp tests with out-of-tree compiler (authored by arichardson).
Allow using sanitizers for ssp tests with out-of-tree compiler
Sat, Apr 10, 1:31 PM
arichardson committed R10:d435574abffd: ng_macfilter_test: Skip rather than fail if there is no network (authored by arichardson).
ng_macfilter_test: Skip rather than fail if there is no network
Sat, Apr 10, 1:31 PM
arichardson committed R10:2cb6b07ca506: Always build the sanitizer runtimes when compiling with clang (authored by arichardson).
Always build the sanitizer runtimes when compiling with clang
Sat, Apr 10, 1:31 PM
arichardson committed R10:4eaec3eb5f9e: tools/build/make.py: Avoid calling brew --prefix on macOS unnecessarily (authored by arichardson).
tools/build/make.py: Avoid calling brew --prefix on macOS unnecessarily
Sat, Apr 10, 1:31 PM
arichardson committed R10:0a0e327fad67: tools/build/make.py: Don't call brew --prefix if --cross-bindir is set (authored by arichardson).
tools/build/make.py: Don't call brew --prefix if --cross-bindir is set
Sat, Apr 10, 1:31 PM
arichardson committed R10:350123947584: tools/build/make.py: drop workaround for cc --version not being parsed (authored by arichardson).
tools/build/make.py: drop workaround for cc --version not being parsed
Sat, Apr 10, 1:30 PM
arichardson committed R10:502d647d75c8: tests/sys/netgraph: Further CI fixes (authored by arichardson).
tests/sys/netgraph: Further CI fixes
Sat, Apr 10, 1:30 PM
arichardson committed R10:7962978754d3: Unbreak MSG_CMSG_CLOEXEC (authored by arichardson).
Unbreak MSG_CMSG_CLOEXEC
Sat, Apr 10, 1:30 PM
arichardson committed R10:6462d714c766: Silence unused parameter warnings in the RISC-V fenv.h (authored by arichardson).
Silence unused parameter warnings in the RISC-V fenv.h
Sat, Apr 10, 1:30 PM
arichardson added a comment to D27971: Remove history.immutable from .arcconfig.

ping? Can we drop the immutable setting so that arc diff adds the Differential Revision: metadata to commit messages automatically?

Sat, Apr 10, 1:04 PM

Fri, Apr 9

arichardson accepted D29686: Avoid raising unexpected floating point exceptions in libm.

I had a similar patch locally using =strict, but it seems like maytrap should be sufficient.

Fri, Apr 9, 11:16 PM
arichardson updated the summary of D29680: bsd.compiler.mk: detect Apple Clang for cross-builds.
Fri, Apr 9, 5:26 PM
arichardson added a comment to D29680: bsd.compiler.mk: detect Apple Clang for cross-builds.

The new version uses COMPILER_FEATURES instead.

bmake[2]: "/Users/alex/cheri/cheribsd/share/mk/bsd.compiler.mk" line 253: COMPILER_FEATURES=apple-clang c++11 c++14 c++17 retpoline init-all
bmake[2]: "/Users/alex/cheri/cheribsd/share/mk/bsd.compiler.mk" line 254: COMPILER_TYPE=clang
bmake[2]: "/Users/alex/cheri/cheribsd/share/mk/bsd.compiler.mk" line 255: COMPILER_VERSION=120000
bmake[2]: "/Users/alex/cheri/cheribsd/share/mk/bsd.compiler.mk" line 256: X_COMPILER_FEATURES=c++11 c++14 c++17 retpoline init-all
bmake[2]: "/Users/alex/cheri/cheribsd/share/mk/bsd.compiler.mk" line 257: X_COMPILER_TYPE=clang
bmake[2]: "/Users/alex/cheri/cheribsd/share/mk/bsd.compiler.mk" line 258: X_COMPILER_VERSION=130000
Fri, Apr 9, 5:25 PM
arichardson updated the diff for D29680: bsd.compiler.mk: detect Apple Clang for cross-builds.

Use COMPILER_FEATURES instead

Fri, Apr 9, 5:25 PM
arichardson added inline comments to D29680: bsd.compiler.mk: detect Apple Clang for cross-builds.
Fri, Apr 9, 5:11 PM
arichardson added inline comments to D29680: bsd.compiler.mk: detect Apple Clang for cross-builds.
Fri, Apr 9, 5:03 PM
arichardson requested review of D29680: bsd.compiler.mk: detect Apple Clang for cross-builds.
Fri, Apr 9, 4:59 PM
arichardson updated the diff for D29679: contrib/flex: Drop local __dead2 patch.

Update some pre-generated files

Fri, Apr 9, 4:45 PM
arichardson requested review of D29679: contrib/flex: Drop local __dead2 patch.
Fri, Apr 9, 4:43 PM
arichardson added reviewers for D29159: linker_set: fix globl/weak symbol redefinitions to work on clang 12: brooks, dim.
Fri, Apr 9, 4:18 PM

Thu, Apr 8

arichardson added a comment to D29647: bmake: Also print -de error information when running multiple jobs.

@sjg Should I send this patch somewhere else to get it upstreamed, or is posting it here sufficient?

Thu, Apr 8, 2:42 PM
arichardson requested review of D29647: bmake: Also print -de error information when running multiple jobs.
Thu, Apr 8, 2:42 PM
arichardson added a comment to D29633: rtld: make dlerror() thread-local.

Seems reasonable to me (unless we want to support TLS inside RTLD but that seems like it would require more work).

Thu, Apr 8, 1:08 PM
arichardson added a comment to D29630: arm64: clear debug register state on fork.

Should they also be cleared in exec_setregs()? Or do we expect to keep them if they are changed after fork()?

Thu, Apr 8, 1:06 PM
arichardson abandoned D29495: sys/linker_set.h: Add SET_DECLARE_WEAK().

Abandoning in favour of D29159

Thu, Apr 8, 11:56 AM
arichardson added a comment to D29159: linker_set: fix globl/weak symbol redefinitions to work on clang 12.

Actually I think this solution is probably better than D29495. I just encountered some annoying errors where depending on ifdefs the set can be either empty or non-empty. Probably better to just always declare them weak.

Thu, Apr 8, 11:56 AM
arichardson planned changes to D29495: sys/linker_set.h: Add SET_DECLARE_WEAK().

Have to handle the kernel module case, so we do actually need the __GLOBL().

Thu, Apr 8, 10:51 AM
arichardson added a reviewer for D29495: sys/linker_set.h: Add SET_DECLARE_WEAK(): kib.
Thu, Apr 8, 10:42 AM
arichardson updated the summary of D29495: sys/linker_set.h: Add SET_DECLARE_WEAK().
Thu, Apr 8, 10:42 AM
arichardson updated the summary of D29495: sys/linker_set.h: Add SET_DECLARE_WEAK().
Thu, Apr 8, 10:39 AM
arichardson updated the diff for D29495: sys/linker_set.h: Add SET_DECLARE_WEAK().
  • tinderbox fixes
Thu, Apr 8, 10:37 AM

Wed, Apr 7

arichardson updated the summary of D29495: sys/linker_set.h: Add SET_DECLARE_WEAK().
Wed, Apr 7, 1:19 PM
arichardson updated the diff for D29495: sys/linker_set.h: Add SET_DECLARE_WEAK().

drop __GLOBL()

Wed, Apr 7, 1:19 PM
arichardson closed D29036: libarchive: Make test_read_append_filter_wrong_program pass again.
Wed, Apr 7, 10:37 AM
arichardson committed R10:2bca8aa7a79a: libarchive: Make test_read_append_filter_wrong_program pass again (authored by arichardson).
libarchive: Make test_read_append_filter_wrong_program pass again
Wed, Apr 7, 10:37 AM
arichardson closed D29528: tests/sys/net/routing: XFAIL the two failing tests.
Wed, Apr 7, 10:36 AM
arichardson committed R10:83532eb68cd0: tests/sys/net/routing: XFAIL the two failing tests (authored by arichardson).
tests/sys/net/routing: XFAIL the two failing tests
Wed, Apr 7, 10:36 AM

Mon, Apr 5

arichardson added a comment to D29323: Implement O_PATH.
acl_get_fd(fd): Invalid argument
futimens(fd): Invalid argument
extattr_set_fd(fd): Invalid argument

Okay. These now fail as expected. errno is EINVAL rather than EBADF. In case of futimens() Linux fails with EBADF.

Mon, Apr 5, 4:29 PM

Thu, Apr 1

arichardson added a comment to D28536: libthr: Avoid interposable calls to memcpy/memset/memmove.

Sorry, I probably didn't explain the problem correctly. I will do some more debugging next week to narrow down the exact cause of this problem.

Thu, Apr 1, 8:04 PM
arichardson abandoned D28531: libthr: Avoid TSan false-positives due to internal malloc.

Will try to silence the false-positives inside TSan instead.

Thu, Apr 1, 7:53 PM
arichardson added a comment to D28536: libthr: Avoid interposable calls to memcpy/memset/memmove.

The problem in TSan is that __interceptor_memcpy (dst=0x7fffdf9f97c0, src=0x7fffdf9f9c00, size=880) is called from a signal handler context, but TSan doesn't know about that and this corrupts the internal state. If I instead intercept __sys_sigaction to make TSan receive the signals and forward them to libthr, this causes even worse internal consistency issues in all sanitizer runtimes. Simply avoiding that one interposable call makes the TSan runtime happy again.

Thu, Apr 1, 5:14 PM
arichardson added a comment to D28536: libthr: Avoid interposable calls to memcpy/memset/memmove.
In D28536#662153, @kib wrote:

No, I object against this kind of ugliness. mem* functions are thread- and async-signal-safe. If something cannot intercept them without satisfying the requirements, that something is buggy.

Please just inline memcpy in single place (?) where it is needed. Or provide the local copy for it, again in the place where it is needed, perhaps naming it differently.

Thu, Apr 1, 5:11 PM
arichardson updated the summary of D28536: libthr: Avoid interposable calls to memcpy/memset/memmove.
Thu, Apr 1, 2:48 PM
arichardson retitled D28536: libthr: Avoid interposable calls to memcpy/memset/memmove from libthr: Avoid calling memcpy() while handling signals to libthr: Avoid interposable calls to memcpy/memset/memmove.
Thu, Apr 1, 2:48 PM
arichardson updated the diff for D28536: libthr: Avoid interposable calls to memcpy/memset/memmove.

Add a local implementation of memcpy/memset instead.

Thu, Apr 1, 2:47 PM
arichardson added inline comments to D29535: libc/string/bcopy.c: Use intptr_t as the copy type.
Thu, Apr 1, 2:43 PM
arichardson added a comment to D29535: libc/string/bcopy.c: Use intptr_t as the copy type.

intptr_t isn't sufficient for hybrid CHERI though, so we'd still need the diff to make it intcap_t downstream...

Thu, Apr 1, 2:42 PM
arichardson added a comment to D29536: libc/string/memset.c: Use unsigned long for stores.

Would (u)intptr_t make more sense so it's faster on CHERI? Doesn't make a difference upstream but does to us.

Thu, Apr 1, 2:41 PM
arichardson requested review of D29536: libc/string/memset.c: Use unsigned long for stores.
Thu, Apr 1, 2:38 PM
arichardson requested review of D29535: libc/string/bcopy.c: Use intptr_t as the copy type.
Thu, Apr 1, 2:37 PM
arichardson added a comment to D28467: Emit an error when we seen absolute paths to .o files.

With the latest version I get the following error :

bmake[5]: "/Users/alex/cheri/freebsd/share/mk/bsd.dep.mk" line 203: "$OBJS absolute path not allowed: /Users/alex/cheri/build/freebsd-amd64-build/Users/alex/cheri/freebsd/amd64.amd64/stand/i386/btx/lib/crt0.o.  If this is intended, add them to _ABSOLUTE_PATH_OBJS to silence this error or define _ALLOW_ABSOLUTE_OBJ_PATH to disable this diagnostic."
bmake[5]: stopped in /Users/alex/cheri/freebsd/stand/i386/loader_4th

To avoid this I changed loader/Makefile.

Thu, Apr 1, 10:01 AM
arichardson retitled D28467: Emit an error when we seen absolute paths to .o files from Print a warning when we seen absolute paths to .o files to Emit an error when we seen absolute paths to .o files.
Thu, Apr 1, 10:01 AM
arichardson updated the diff for D28467: Emit an error when we seen absolute paths to .o files.
  • Move to shared file
  • add opt-out mechanism
  • Use it to fix loader build
Thu, Apr 1, 10:01 AM
arichardson added a comment to D29528: tests/sys/net/routing: XFAIL the two failing tests.

Will commit this on Monday unless D28886 is committed first.

Thu, Apr 1, 9:00 AM
arichardson added a comment to D28886: Update rtsock_l3 test after 2fe5a79425c79f7b828acd91da66d97230925fc8.

I've posted D29528 to get CI green again and allow for more time for this patch to be reviewed.

Thu, Apr 1, 9:00 AM
arichardson requested review of D29528: tests/sys/net/routing: XFAIL the two failing tests.
Thu, Apr 1, 8:59 AM
arichardson updated the summary of D29036: libarchive: Make test_read_append_filter_wrong_program pass again.
Thu, Apr 1, 8:42 AM
arichardson updated the diff for D29036: libarchive: Make test_read_append_filter_wrong_program pass again.

Cherry-pick upstreamed commit instead

Thu, Apr 1, 8:40 AM

Wed, Mar 31

arichardson added a reviewer for D29495: sys/linker_set.h: Add SET_DECLARE_WEAK(): greg_unrelenting.technology.
Wed, Mar 31, 7:39 PM
arichardson added a comment to D29159: linker_set: fix globl/weak symbol redefinitions to work on clang 12.

Sorry didn't see this revision. I chose a slightly different approach in D29495

Wed, Mar 31, 7:16 PM

Tue, Mar 30

arichardson updated the diff for D29495: sys/linker_set.h: Add SET_DECLARE_WEAK().

add missed case

Tue, Mar 30, 3:50 PM
arichardson updated the diff for D29495: sys/linker_set.h: Add SET_DECLARE_WEAK().

switch order

Tue, Mar 30, 2:24 PM