- User Since
- Jan 17 2017, 2:21 PM (332 w, 3 h)
Wed, May 24
Thanks for adding this - I was recently trying to debug RISC-V issues using qemu tracing and the constant SBI calls meant that it made essentially zero progress since tracing slowed down qemu so much that the next timer interrupt fired once it returned from the sbi call.
Sat, May 20
Fri, May 19
Rebased on latest main.
@cperciva it would be great if you could test how much this helps your usecase.
Tue, May 16
Can this be committed, so this header is standalone even if you don't use a patched LLVM?
Sat, May 6
Tue, May 2
Mon, May 1
Apr 28 2023
Apr 23 2023
Apr 22 2023
Thanks for the update, looks like it's much closer to the build world flags now. Would be good to know if the __unused bits can be removed but otherwise looks good to me (well the parts that I understand).
Apr 21 2023
I'd prefer if the __enum_uint8(vtype) changes were only inside structs and not in the function signatures but I don't feel strongly about it.
Apr 10 2023
Mar 28 2023
Mar 16 2023
I think the second macro is unnecessary based on my experiments with godbolt. Otherwise LGTM once we've decided where to place it (and I'd suggest with the _KERNEL guard).
Mar 15 2023
Mar 13 2023
Not tested it but changes LGTM. Looking forward to dropping the workaround from cheribuild
Using the C23 underlying enum type extension is IMO better and safer. Support with clang (since version 8) and GCC 13+: https://godbolt.org/z/n4EshMY1j
Feb 28 2023
Feb 25 2023
I don't understand why this program is special and should default to using LTO. Shouldn't there be a global WITH_LTO switch instead that builds all base system programs with LTO?
Feb 4 2023
Slight preference for __has_include but this also LGTM.
Jan 24 2023
Could 32-bit arches just cast to an int32 pointer and ignore the remaining bits of the contention object?
Jan 20 2023
Jan 19 2023
@jfree One more thing, could you give me an email address for committing? I see some commits in tree with Jake Freeland <jfree@FreeBSD.org>, is that correct?
Also no need to upload a new patch, those are notes to myself for testing later :)
Jan 17 2023
Thanks! This seems fine to me, but please wait for @jrtc27 to approve as well.
Jan 9 2023
IMO we should add this automatically based on where certain utilities are. Is this for xz? If so make.py could use the result of shutil.which to find that directory.
Jan 5 2023
Jan 4 2023
Dec 26 2022
I'm surprised these are needed, ld.lld should automatically add the symbols. Also can the _hdr symbols be placed inside the section? It should be fine for them to be be non-zero if non-existent since end will be equal to start.
Dec 20 2022
Commit message looks a bit odd in phab. Sounds like this is just a nodejs update so if it still works LGTM.
Dec 19 2022
Dec 17 2022
Dec 1 2022
I am surprised that this is needed considering libc++ has pragma GCC system_header: https://github.com/llvm/llvm-project/blame/main/libcxx/include/string_view#L240
Nov 28 2022
Oct 28 2022
Oct 27 2022
This is fine as a workaround, but maybe we should just use command -v instead of which? I've seen build failures where docker images didn't include which
Oct 12 2022
drop unnecessary line
Oct 10 2022
I can confirm this fixes the issue I was seeing.
Oct 4 2022
Something like this: https://godbolt.org/z/xKxnheh5r
Would saving the pointer address in a local uinptr_t/size_t fix the warning?
Sep 28 2022
I just skimmed over this tests and it seems like the only one that modifies global state are renice_abs_user and renice_rel_user since all others only apply to the PID. I think it should be sufficient to split those two out into a separate test and set exclusive on that one? This would allow running the remaining tests in parallel and thereby increase throughput.
Are these tests fundamentally incompatible with parallel execution? If not I'd prefer if they could be fixed. Alternatively this could go in as a workaround as long as there is a PR to ensure this gets cleaned up eventually.
Aug 11 2022
LGTM. We could also go for inline functions that call the __builtin functions but this is simpler.
Abandoning since D36135 fixes the underlying issue.
Oh nice, didn't see these changes, I just went for the simple workaround in D36089
Aug 9 2022
Test plan: build with 'LOCAL_XTOOL_DIRS=lib/libnetbsd usr.sbin/makefs usr.bin/mkimg' on Linux.
Jul 26 2022
I think the -x flag is not required since that is the default for .s but I don't think it does any harm.
Jul 20 2022
Maybe the rules for .s files should be updated to compile them using CC instead?
Jun 24 2022
Seems fine to me. Alternatively we could add a "gnu-like-arguments" (or some better name) feature for bfd compatible syntax.
Jun 20 2022
May 24 2022
Adding downstream patches is not great but I think in this case it's reasonable. Although maybe upstream would be happy with this too, I'm not sure what the supported compilers for compiler-rt are.
May 22 2022
If there are no further comments/suggestions, I'll commit this next week (most likely Wednesday)
May 19 2022
Is there a per-process counter that that test could check instead of a global one? It seems rather racy even if we aren't running tests in parallel?
May 7 2022
Ping? Is this ok to commit?
Apr 19 2022
Apr 18 2022
Use FreeBSD HEAD instead of CheriBSD HEAD as the base
Apr 17 2022
Apr 12 2022
Mar 30 2022
Mar 13 2022
FYI as of LLVM 9, clang will optimize memcmp calls that only check for equality to bcmp.
Feb 14 2022
Feb 9 2022