User Details
- User Since
- Jan 17 2017, 2:21 PM (373 w, 6 d)
Wed, Mar 6
Sun, Feb 25
Fri, Feb 23
Have you tried running the lsan test suite with this change?
Feb 2 2024
For example the linux joystick.h defines a bunch of ioctls that I don't see implemented on FreeBSD, so we really shouldn't claim support for it? Maybe the header should only includes the constants?
Jan 30 2024
Commit message should probably be qualified with "for kernel compilation"?
This LGTM but the commit message should also include the minimum Clang+GCC versions
Jan 29 2024
ping?
Jan 18 2024
Jan 14 2024
Based on https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66425#c56 we can use [[nodiscard]] with GCC 11 and higher which has the expected semantics. But for now this change seems fine
Both of these features are required by POSIX, %% also seems to be required:
https://pubs.opengroup.org/onlinepubs/009604499/utilities/xcu_chap02.html#tag_02_06_02
Jan 12 2024
Jan 2 2024
Looking at the Clang change that added -std=c17 (https://github.com/llvm/llvm-project/commit/5b6c0f75e01571851b767dc63a3229c962f464f1), the only difference is the value of __STDC_VERSION__, so unless code uses this in preprocessor macros it's identical to -std=c11
I had a look on godbolt to see which compiler versions support c17: https://godbolt.org/z/EGd4TqP3j
Dec 31 2023
Overall I'd be very happy to see the standard bumped to c17 but I'm not sure what the current minimum compiler versions are. But then again maybe it's time to say you need a c17 compiler for current...
Dec 12 2023
Dec 11 2023
Nov 24 2023
Nov 21 2023
Nov 5 2023
I see you have a reduced test case, would it be possible to turn it into a regression test for in the ld-elf tests?
Oct 20 2023
Sep 26 2023
You could push to a GitHub fork, then it will run the bootstrap steps as part of the GitHub action
This will almost certainly break the cross build. The typedefs in the local _ctype.h are needed. Can you modify that file to include the new generated header?
Sep 18 2023
Is there a reason you didn't add __asm__ volatile(".cfi_undefined x30"); to the start of the C function? In my testing with CheriBSD this appears to work in the same way (libunwind tests fail before, succeed after).
Sep 13 2023
Thanks for working on this - I also tried to get it to work a few years ago but didn't get too far. It looks like this includes the fix to the uninitialized variable that I ran into (https://github.com/arichardson/cheribsd/commits/virtfs-cheribsd) so I think all of my fixes from back then are included.
Aug 23 2023
Jul 26 2023
Thanks for fixing this - I wonder if it's time to try turning on strict tmppath by default again upstream. I initially tried that but gave up after noticing that it broke various cases like etcupdate that I didn't have time to debug.
Jul 8 2023
This breaks the macos bootstrap jobs, could you add an ifdef around the new code?
Jul 7 2023
IIRC this is also built during bootstrap. Could you check that the GitHub actions CI is still happy before committing?
Jun 26 2023
I'm surprised this is needed, you'd hope the compiler could do this transformation. Maybe worth filling a LLVM bug report?
Jun 7 2023
This will sort by name not priority. Ld.lld will sort by priority automatically if you omit init_array from the linker script but for bfd you need SORT_BY_INIT_PRIORITY
May 24 2023
Thanks for adding this - I was recently trying to debug RISC-V issues using qemu tracing and the constant SBI calls meant that it made essentially zero progress since tracing slowed down qemu so much that the next timer interrupt fired once it returned from the sbi call.
May 20 2023
May 19 2023
fix tslog
Rebased on latest main.
@cperciva it would be great if you could test how much this helps your usecase.
May 16 2023
Can this be committed, so this header is standalone even if you don't use a patched LLVM?
May 6 2023
May 2 2023
May 1 2023
Apr 28 2023
Apr 23 2023
Apr 22 2023
Thanks for the update, looks like it's much closer to the build world flags now. Would be good to know if the __unused bits can be removed but otherwise looks good to me (well the parts that I understand).
Apr 21 2023
I'd prefer if the __enum_uint8(vtype) changes were only inside structs and not in the function signatures but I don't feel strongly about it.
Apr 10 2023
Mar 28 2023
Mar 16 2023
I think the second macro is unnecessary based on my experiments with godbolt. Otherwise LGTM once we've decided where to place it (and I'd suggest with the _KERNEL guard).
Mar 15 2023
Mar 13 2023
LGTM
Not tested it but changes LGTM. Looking forward to dropping the workaround from cheribuild
Using the C23 underlying enum type extension is IMO better and safer. Support with clang (since version 8) and GCC 13+: https://godbolt.org/z/n4EshMY1j
Feb 28 2023
Feb 25 2023
I don't understand why this program is special and should default to using LTO. Shouldn't there be a global WITH_LTO switch instead that builds all base system programs with LTO?
Feb 4 2023
Slight preference for __has_include but this also LGTM.
Jan 24 2023
Could 32-bit arches just cast to an int32 pointer and ignore the remaining bits of the contention object?
Jan 20 2023
Jan 19 2023
@jfree One more thing, could you give me an email address for committing? I see some commits in tree with Jake Freeland <jfree@FreeBSD.org>, is that correct?
Also no need to upload a new patch, those are notes to myself for testing later :)
Jan 17 2023
Thanks! This seems fine to me, but please wait for @jrtc27 to approve as well.
Jan 9 2023
IMO we should add this automatically based on where certain utilities are. Is this for xz? If so make.py could use the result of shutil.which to find that directory.
Jan 5 2023
Jan 4 2023
Dec 26 2022
I'm surprised these are needed, ld.lld should automatically add the symbols. Also can the _hdr symbols be placed inside the section? It should be fine for them to be be non-zero if non-existent since end will be equal to start.
Dec 20 2022
Commit message looks a bit odd in phab. Sounds like this is just a nodejs update so if it still works LGTM.
Dec 19 2022
Dec 17 2022
Dec 1 2022
I am surprised that this is needed considering libc++ has pragma GCC system_header: https://github.com/llvm/llvm-project/blame/main/libcxx/include/string_view#L240
Nov 28 2022
Oct 28 2022
Oct 27 2022
This is fine as a workaround, but maybe we should just use command -v instead of which? I've seen build failures where docker images didn't include which
Oct 12 2022
drop unnecessary line
Oct 10 2022
I can confirm this fixes the issue I was seeing.
Oct 4 2022
Something like this: https://godbolt.org/z/xKxnheh5r