Page MenuHomeFreeBSD

arichardson (Alexander Richardson)
User

Projects

User Details

User Since
Jan 17 2017, 2:21 PM (332 w, 3 h)

Recent Activity

Wed, May 24

arichardson added a comment to D40241: riscv timer: use stimecmp CSR when available.

Thanks for adding this - I was recently trying to debug RISC-V issues using qemu tracing and the constant SBI calls meant that it made essentially zero progress since tracing slowed down qemu so much that the next timer interrupt fired once it returned from the sbi call.

Wed, May 24, 2:10 PM

Sat, May 20

arichardson added a comment to D39916: mi_startup: sort sysinit array using qsort instead of bubble sort.
Sorting 1125 sysinit items
117378 instructions with qsort()
5509157 instructions with bubble

And if the list is already sorted and you use insertion sort there instead of bubble sort, what is the time then? Can you get that into the list too?

I guess it will be something like 500x instead of your 50x.

--HPS

Yes that would obviously be faster but I don't have time to work on that. If you are planning to work on this and it's going to be ready for review in the near future I'd be happy to drop this patch.

However, using a pre-existing sorting function to obtain a noticeable speedup seems like a valid approach to me. Just because it could be done in a more optimal way at some hypothetical point in the future shouldn't mean we can't make incremental improvements on the way to an ideal solution. Otherwise things would never improve...

Could we make a deal on that? I writeup a patch for the 500x case today, and you can test it and compare against the current results?

Sat, May 20, 5:31 PM
arichardson added inline comments to D39916: mi_startup: sort sysinit array using qsort instead of bubble sort.
Sat, May 20, 12:54 AM
arichardson added a comment to D39916: mi_startup: sort sysinit array using qsort instead of bubble sort.
Sorting 1125 sysinit items
117378 instructions with qsort()
5509157 instructions with bubble

And if the list is already sorted and you use insertion sort there instead of bubble sort, what is the time then? Can you get that into the list too?

I guess it will be something like 500x instead of your 50x.

--HPS

Sat, May 20, 12:47 AM

Fri, May 19

arichardson updated the summary of D39916: mi_startup: sort sysinit array using qsort instead of bubble sort.
Fri, May 19, 8:21 PM
arichardson updated the diff for D39916: mi_startup: sort sysinit array using qsort instead of bubble sort.

fix tslog

Fri, May 19, 8:03 PM
arichardson updated the diff for D39916: mi_startup: sort sysinit array using qsort instead of bubble sort.

Rebased on latest main.
@cperciva it would be great if you could test how much this helps your usecase.

Fri, May 19, 5:24 PM
arichardson added a comment to D39916: mi_startup: sort sysinit array using qsort instead of bubble sort.
In D39916#908757, @mjg wrote:

this is a massively dodgy change, one has to expect some of the real orderings work by accident. i think it would be better to take a look at trimming the list instead.

Trimming the list definitely makes sense but I went for the simpler change here. The list is currently somewhat arbitrarily sorted by the linker and I don't think this makes it any worse. We could add a stable sort to libkern but I don't think this should be needed.

Arbitrary ordering of the linker has bitten us in the past, sometimes it seems like it'd be nice to have the option to introduce some intentional chaos so that we can find potential issues by randomly reordering (within a {subsystem, order}, naturally), but you'd really want to be able to do that *and* find a way to make it reproducible (e.g., feed it this seed via tunable and it'll re-order in such a way that GENERIC dies in a horrible fire)

Fri, May 19, 5:22 PM
arichardson added inline comments to D39916: mi_startup: sort sysinit array using qsort instead of bubble sort.
Fri, May 19, 5:19 PM

Tue, May 16

arichardson added a comment to D22630: Include <sys/cdefs.h> in execinfo.h.

Can this be committed, so this header is standalone even if you don't use a patched LLVM?

Tue, May 16, 7:50 PM

Sat, May 6

arichardson added inline comments to D39909: hwpmc: use kstack_contains().
Sat, May 6, 11:53 PM

Tue, May 2

arichardson added a comment to D39916: mi_startup: sort sysinit array using qsort instead of bubble sort.
In D39916#908757, @mjg wrote:

this is a massively dodgy change, one has to expect some of the real orderings work by accident. i think it would be better to take a look at trimming the list instead.

Tue, May 2, 1:55 AM

Mon, May 1

arichardson added a comment to D39916: mi_startup: sort sysinit array using qsort instead of bubble sort.
In D39916#908603, @imp wrote:

does qsort's unstable sort actually change the order of anything?

Mon, May 1, 10:23 PM
arichardson requested review of D39916: mi_startup: sort sysinit array using qsort instead of bubble sort.
Mon, May 1, 8:34 PM

Apr 28 2023

arichardson committed rGb347c2284603: cross-build: Add common compatibility headers after OS-specific ones (authored by arichardson).
cross-build: Add common compatibility headers after OS-specific ones
Apr 28 2023, 11:15 PM

Apr 23 2023

arichardson added inline comments to D39766: Enable building tar for non-FreeBSD host.
Apr 23 2023, 12:21 AM

Apr 22 2023

arichardson accepted D39744: Simplify building host tools during DIRDEPS_BUILD.

Looks good to me now but please wait for @jrtc27 and/or @imp before committing.

Apr 22 2023, 5:58 PM
arichardson added a comment to D39744: Simplify building host tools during DIRDEPS_BUILD.

Thanks for the update, looks like it's much closer to the build world flags now. Would be good to know if the __unused bits can be removed but otherwise looks good to me (well the parts that I understand).

Apr 22 2023, 5:45 AM

Apr 21 2023

arichardson added inline comments to D39744: Simplify building host tools during DIRDEPS_BUILD.
Apr 21 2023, 11:43 PM
arichardson accepted D39747: llvm: fix some llvm-* tool links when WITH_LLVM_BINUTILS set.
Apr 21 2023, 2:11 PM
arichardson added inline comments to D39744: Simplify building host tools during DIRDEPS_BUILD.
Apr 21 2023, 1:50 PM
arichardson added inline comments to D39744: Simplify building host tools during DIRDEPS_BUILD.
Apr 21 2023, 1:42 PM
arichardson added a comment to D39031: Support byte-sized enums.

I'd prefer if the __enum_uint8(vtype) changes were only inside structs and not in the function signatures but I don't feel strongly about it.

Apr 21 2023, 12:31 AM

Apr 10 2023

arichardson accepted D39496: Remove the riscv64sf architecture..
Apr 10 2023, 11:55 PM

Mar 28 2023

arichardson accepted D39295: cross-build: Add secure_getenv() for MacOS cross builds.
Mar 28 2023, 2:09 PM

Mar 16 2023

arichardson added a comment to D39031: Support byte-sized enums.

I think the second macro is unnecessary based on my experiments with godbolt. Otherwise LGTM once we've decided where to place it (and I'd suggest with the _KERNEL guard).

Mar 16 2023, 7:45 AM

Mar 15 2023

arichardson abandoned D27088: Add .cfi_{start,end}proc annotations for MIPS assembly.
Mar 15 2023, 5:11 PM

Mar 13 2023

arichardson accepted D39073: .github: Test DISK_IMAGE_TOOLS_BOOTSTRAP in CI.

LGTM

Mar 13 2023, 11:32 PM
arichardson added inline comments to D39072: Add new DISK_IMAGE_TOOLS_BOOTSTRAP option.
Mar 13 2023, 11:31 PM
arichardson accepted D39072: Add new DISK_IMAGE_TOOLS_BOOTSTRAP option.

Not tested it but changes LGTM. Looking forward to dropping the workaround from cheribuild

Mar 13 2023, 11:29 PM
arichardson added a comment to D39031: Support byte-sized enums.

Using the C23 underlying enum type extension is IMO better and safer. Support with clang (since version 8) and GCC 13+: https://godbolt.org/z/n4EshMY1j

Mar 13 2023, 11:14 AM

Feb 28 2023

arichardson added a comment to D38755: gh-bc: don't disable LTO on powerpc64.
In D38755#883149, @se wrote:

I don't understand why this program is special and should default to using LTO. Shouldn't there be a global WITH_LTO switch instead that builds all base system programs with LTO?

I had suggested introduction of LTO macros in the base system several years ago, but got no positive feedback.

My suggestion was to allow base system components to be tagged for compilation with LTO, but the actual options being determined by the framework depending on the compiler and target architecture.

This particular program benefits a lot from LTO because of its structure: the author first developed an abstract library to manipulate vectors (originally in C++, then ported to C), then based the implementation of bc on this library. If these vector operations had been implemented as macros or as inline functions, they would automatically be reduced after expansion, since passed constant parameters would allow moving run-time tests into the compile phase, but these vector functions are in a stand-alone library that can be used and tested independently of the bc and dc programs. LTO allows the compiler to inline optimized trivial fractions of complex vector operations in many places (including inner loops), leading to a measured reduction of the run-time of complex operations of about 30%.

I'm all for the introduction of framework support for LTO, which probably should add the required options for LTO to CFLAGS, but also provide a macro that can be tested in the source code, e.g. in case LTO on some compiler/architecture causes issues with specific code sequences.

Given the advantages offered by "thin" LTO without the high impact on link times of "full" LTO, it might be possible to build most of the userland code on most platforms with -flto=thin by default, BTW. This program is small enough to be compiled with -flto=full without, though. Therefore, it might be useful to support both thin and full LTO in the framework (as hints to the build system, whether and which LTO method to use).

Feb 28 2023, 10:54 AM

Feb 25 2023

arichardson added a comment to D38755: gh-bc: don't disable LTO on powerpc64.

I don't understand why this program is special and should default to using LTO. Shouldn't there be a global WITH_LTO switch instead that builds all base system programs with LTO?

Feb 25 2023, 11:11 PM

Feb 4 2023

arichardson accepted D38378: usr.bin/find: Fix -acl, broken by D13306 (since FreeBSD 12.0).

Slight preference for __has_include but this also LGTM.

Feb 4 2023, 5:45 PM

Jan 24 2023

arichardson accepted D38178: libcxx: use __SIZEOF_LONG__ == 8 instead of __LP64__.
Jan 24 2023, 11:31 PM
arichardson added a comment to D38132: libcxx: Implement atomic::wait/wake using _umtx_op(2) ) for 64bit arches.

Could 32-bit arches just cast to an int32 pointer and ignore the remaining bits of the contention object?

Jan 24 2023, 8:57 AM
arichardson added a comment to D38132: libcxx: Implement atomic::wait/wake using _umtx_op(2) ) for 64bit arches.

Could 32-bit arches just cast to an int32 pointer and ignore the remaining bits of the contention object?

Jan 24 2023, 8:56 AM

Jan 20 2023

arichardson committed rG34ac629b40e6: Shell-escape assignments to PATH in the top-level makefiles (authored by arichardson).
Shell-escape assignments to PATH in the top-level makefiles
Jan 20 2023, 10:49 AM

Jan 19 2023

arichardson added a comment to D37991: Makefile: Avoid sanitizing PATH on non-FreeBSD systems.

@jfree One more thing, could you give me an email address for committing? I see some commits in tree with Jake Freeland <jfree@FreeBSD.org>, is that correct?

Jan 19 2023, 10:56 AM
arichardson added a comment to D37991: Makefile: Avoid sanitizing PATH on non-FreeBSD systems.

Also no need to upload a new patch, those are notes to myself for testing later :)

Jan 19 2023, 10:50 AM
arichardson added inline comments to D37991: Makefile: Avoid sanitizing PATH on non-FreeBSD systems.
Jan 19 2023, 10:47 AM
arichardson added a comment to D37991: Makefile: Avoid sanitizing PATH on non-FreeBSD systems.

I'd extend the commit message to the following, capturing the justification for the change:

Makefile: Avoid sanitizing PATH on non-FreeBSD systems

Allow the build process to find host binaries during the host-symlinks target when
cross-building on non-FreeBSD systems. Whilst most non-FreeBSD systems have all
the needed tools in /sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin (the final
path added by host-symlinks itself), Homebrew for macOS on Arm defaults to
/opt/homebrew/bin, other more niche systems may also deviate and users may
expect tools in a customised PATH to be picked up, unlike on FreeBSD where we
want to ensure everything comes from base. In particular, (un)xz are needed
from Homebrew on macOS, and thus cannot be found on Arm without this.

Note that non-FreeBSD builds enforce BUILD_WITH_STRICT_TMPPATH, and so the
actual main build steps will still use a sanitised PATH.

Thanks for writing this up. I should have added a description like this from the start.
I am not a FreeBSD committer yet, so I am not capable of committing this to src.
Would one of you be willing to do that? @jrtc27 @arichardson

Thanks :)

Jan 19 2023, 10:46 AM

Jan 17 2023

arichardson accepted D37991: Makefile: Avoid sanitizing PATH on non-FreeBSD systems.

Thanks! This seems fine to me, but please wait for @jrtc27 to approve as well.

Jan 17 2023, 3:04 PM

Jan 9 2023

arichardson added a reviewer for D37983: Add --symlink-bindir flag to make.py build tool: jrtc27.
Jan 9 2023, 7:47 AM
arichardson added a comment to D37983: Add --symlink-bindir flag to make.py build tool.

IMO we should add this automatically based on where certain utilities are. Is this for xz? If so make.py could use the result of shutil.which to find that directory.

Jan 9 2023, 7:46 AM

Jan 5 2023

arichardson added inline comments to D37952: stand: Add libbacktrace to toolbox of boot loader.
Jan 5 2023, 11:43 PM

Jan 4 2023

arichardson abandoned D28736: DO NOT MERGE: This seems to fix https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253589.
Jan 4 2023, 9:09 AM

Dec 26 2022

arichardson added a comment to D37864: stand: Add eh symbols to linker scripts.

I'm surprised these are needed, ld.lld should automatically add the symbols. Also can the _hdr symbols be placed inside the section? It should be fine for them to be be non-zero if non-existent since end will be equal to start.

Dec 26 2022, 1:29 PM

Dec 20 2022

arichardson accepted D37769: .github: Switch to v3 of actions/checkout..

Commit message looks a bit odd in phab. Sounds like this is just a nodejs update so if it still works LGTM.

Dec 20 2022, 11:39 PM

Dec 19 2022

arichardson added inline comments to D37722: Add new rc: machine_id to generate /etc/machine-id.
Dec 19 2022, 12:34 PM

Dec 17 2022

arichardson added inline comments to D37722: Add new rc: machine_id to generate /etc/machine-id.
Dec 17 2022, 9:49 AM

Dec 1 2022

arichardson added a comment to D37530: Silence GCC warnings when using libc++ headers..

I am surprised that this is needed considering libc++ has pragma GCC system_header: https://github.com/llvm/llvm-project/blame/main/libcxx/include/string_view#L240

Dec 1 2022, 12:14 AM

Nov 28 2022

arichardson added reviewers for D28557: Minor sed cleanups: imp, emaste.
Nov 28 2022, 10:28 PM

Oct 28 2022

arichardson added a comment to D36900: tools/build/make.py: fix cross build on Fedora Linux.

This is fine as a workaround, but maybe we should just use command -v instead of which? I've seen build failures where docker images didn't include which

Hi @arichardson, I verified command -v which on Fedora and it also returns just "which" when the bash function is set.

Can we assume bash is mandatory for make.py? I found that we can have a clean bash environment with "env -i bash --noprofile --norc". One option would be cleanup bash at beginning and copy PATH var over. Another could be change the code that uses which to something like `env -i bash --noprofile --norc -c 'command -v <target_binary>".

Oct 28 2022, 5:29 PM

Oct 27 2022

arichardson added a comment to D36900: tools/build/make.py: fix cross build on Fedora Linux.

This is fine as a workaround, but maybe we should just use command -v instead of which? I've seen build failures where docker images didn't include which

Oct 27 2022, 11:37 PM

Oct 12 2022

arichardson added a comment to D36953: usr.sbin/pmcstat: return non-zero if the launched command fails.

While it might make sense to propagate the exit code/signal via pmcstat, I believe returning EX_IOERR if the child process fails should be sufficient.

I think it probably does; it looks like that's what ktrace does, for instance. Do you know what Linux perf does?

I don't object if you think this is best; I think returning EX_IOERR is better than EX_OK if the child reports failure anyhow.

Oct 12 2022, 7:09 PM
arichardson updated the diff for D36953: usr.sbin/pmcstat: return non-zero if the launched command fails.

drop unnecessary line

Oct 12 2022, 4:55 PM
arichardson requested review of D36953: usr.sbin/pmcstat: return non-zero if the launched command fails.
Oct 12 2022, 4:54 PM

Oct 10 2022

arichardson accepted D36925: hwpmc: Move DMC-620 and CMN-600 events to allow for full Armv8.0 space.

I can confirm this fixes the issue I was seeing.

Oct 10 2022, 9:30 PM

Oct 4 2022

arichardson added a comment to D36819: libbegemot: Disable -Wuse-after-free..

Something like this: https://godbolt.org/z/xKxnheh5r

Oct 4 2022, 10:23 AM
arichardson added a comment to D36819: libbegemot: Disable -Wuse-after-free..

Would saving the pointer address in a local uinptr_t/size_t fix the warning?

Oct 4 2022, 10:21 AM

Sep 28 2022

arichardson updated subscribers of D36720: tests/usr.bin/renice: Prevent running them in parallel.

I just skimmed over this tests and it seems like the only one that modifies global state are renice_abs_user and renice_rel_user since all others only apply to the PID. I think it should be sufficient to split those two out into a separate test and set exclusive on that one? This would allow running the remaining tests in parallel and thereby increase throughput.

Sep 28 2022, 9:19 AM
arichardson added a comment to D36720: tests/usr.bin/renice: Prevent running them in parallel.

Are these tests fundamentally incompatible with parallel execution? If not I'd prefer if they could be fixed. Alternatively this could go in as a workaround as long as there is a PR to ensure this gets cleaned up eventually.

Sep 28 2022, 9:13 AM

Aug 11 2022

arichardson closed D34939: Install working pkgconfig .pc files for compat libraries.
Aug 11 2022, 10:47 PM
arichardson committed rGac175bd33a21: Install working pkgconfig .pc files for compat libraries (authored by arichardson).
Install working pkgconfig .pc files for compat libraries
Aug 11 2022, 10:47 PM
arichardson accepted D36134: tools/build: Provide fls* when cross-building on Linux.

LGTM. We could also go for inline functions that call the __builtin functions but this is simpler.

Aug 11 2022, 10:44 PM
arichardson added inline comments to D36132: sys: Extract __bitcount* from sys/types.h to new sys/bitcount.h.
Aug 11 2022, 10:42 PM
arichardson abandoned D36089: usr.sbin/makefs: Disable ZFS support when bootstrapping on non-FreeBSD.

Abandoning since D36135 fixes the underlying issue.

Aug 11 2022, 10:23 PM
arichardson added a comment to D36135: makefs: Fix issues building as a cross-tool on non-FreeBSD.

Oh nice, didn't see these changes, I just went for the simple workaround in D36089

Aug 11 2022, 10:23 PM

Aug 9 2022

arichardson added a comment to D36089: usr.sbin/makefs: Disable ZFS support when bootstrapping on non-FreeBSD.

Test plan: build with 'LOCAL_XTOOL_DIRS=lib/libnetbsd usr.sbin/makefs usr.bin/mkimg' on Linux.

Aug 9 2022, 8:39 AM
arichardson requested review of D36089: usr.sbin/makefs: Disable ZFS support when bootstrapping on non-FreeBSD.
Aug 9 2022, 8:37 AM

Jul 26 2022

arichardson accepted D35859: Use the compiler driver instead of ${AS}.

I think the -x flag is not required since that is the default for .s but I don't think it does any harm.

Jul 26 2022, 9:26 PM

Jul 20 2022

arichardson added a comment to D35859: Use the compiler driver instead of ${AS}.

Maybe the rules for .s files should be updated to compile them using CC instead?

Jul 20 2022, 11:13 PM

Jun 24 2022

arichardson added a comment to D35589: Add and check for relro linker feature.

Seems fine to me. Alternatively we could add a "gnu-like-arguments" (or some better name) feature for bfd compatible syntax.

Jun 24 2022, 11:49 PM

Jun 20 2022

arichardson added a comment to D35534: lib/csu: Ensure that ELF notes are retained with -Wl,--gc-sections.

This was considered but not done as it requires the linker to support SHF_RETAIN. The best option is to move the note to just crti and have a dummy crti for CHERI downstream rather than omit it

Jun 20 2022, 9:56 PM
arichardson requested review of D35534: lib/csu: Ensure that ELF notes are retained with -Wl,--gc-sections.
Jun 20 2022, 9:36 PM

May 24 2022

arichardson added a comment to D35311: compiler-rt: fix compiler rt with CROSS_TOOLCHAIN.

Adding downstream patches is not great but I think in this case it's reasonable. Although maybe upstream would be happy with this too, I'm not sure what the supported compilers for compiler-rt are.

May 24 2022, 9:56 PM

May 22 2022

arichardson added a comment to D34939: Install working pkgconfig .pc files for compat libraries.

If there are no further comments/suggestions, I'll commit this next week (most likely Wednesday)

May 22 2022, 2:54 PM

May 19 2022

arichardson added a comment to D35260: Prevent running unix_passfd_test in parallel.

Is there a per-process counter that that test could check instead of a global one? It seems rather racy even if we aren't running tests in parallel?

May 19 2022, 10:30 PM

May 7 2022

arichardson committed rG3c01fdcfc161: cross-build: fix some redeclaration warnings during bootstrap (authored by arichardson).
cross-build: fix some redeclaration warnings during bootstrap
May 7 2022, 3:59 PM
arichardson committed rG299d5e2b640b: Add missing const after 6c4f95161d6e (authored by arichardson).
Add missing const after 6c4f95161d6e
May 7 2022, 3:59 PM
arichardson committed rGb7a47939e250: virtio: make the write_config buffer argument const (authored by arichardson).
virtio: make the write_config buffer argument const
May 7 2022, 3:59 PM
arichardson committed rG95c6e44054ce: linuxkpi: implement ida_alloc() (authored by arichardson).
linuxkpi: implement ida_alloc()
May 7 2022, 3:58 PM
arichardson committed rG763198cc5086: linuxkpi: Allow BUILD_BUG_ON in if statements without braces (authored by arichardson).
linuxkpi: Allow BUILD_BUG_ON in if statements without braces
May 7 2022, 3:58 PM
arichardson committed rG82b4e784f3df: linuxkpi: Add sg_init_one (authored by arichardson).
linuxkpi: Add sg_init_one
May 7 2022, 3:58 PM
arichardson added a comment to D34939: Install working pkgconfig .pc files for compat libraries.

Ping? Is this ok to commit?

May 7 2022, 3:58 PM
arichardson committed rGcbbdacf4dc8f: Add missing dep patterns for .pieo (authored by arichardson).
Add missing dep patterns for .pieo
May 7 2022, 3:58 PM
arichardson committed rGb0188ea20071: Add a test for https://reviews.freebsd.org/D31858 (PR 258310) (authored by arichardson).
Add a test for https://reviews.freebsd.org/D31858 (PR 258310)
May 7 2022, 3:57 PM
arichardson committed rGafab9d5ffe63: Export _mmap and __sys_mmap from libc.so (authored by arichardson).
Export _mmap and __sys_mmap from libc.so
May 7 2022, 3:57 PM

Apr 19 2022

arichardson requested review of D34971: bsd.test.mk: Attempt to work around installation race.
Apr 19 2022, 9:19 PM

Apr 18 2022

arichardson added a comment to D34939: Install working pkgconfig .pc files for compat libraries.
In D34939#792003, @imp wrote:

A quick glance says "this looks good to me" if that's the feedback you're looking for :)

Apr 18 2022, 2:49 PM
arichardson updated the summary of D34939: Install working pkgconfig .pc files for compat libraries.
Apr 18 2022, 2:49 PM
arichardson updated the diff for D34939: Install working pkgconfig .pc files for compat libraries.

Use FreeBSD HEAD instead of CheriBSD HEAD as the base

Apr 18 2022, 2:48 PM

Apr 17 2022

arichardson requested review of D34939: Install working pkgconfig .pc files for compat libraries.
Apr 17 2022, 7:22 PM

Apr 12 2022

arichardson added inline comments to D34797: Remove checks for __GNUCLIKE_ASM assuming it is always true..
Apr 12 2022, 10:59 PM

Mar 30 2022

arichardson added inline comments to rGf90cd1ae30b5: Clear non-x86 compat stat syscall kernel stack memory disclosure.
Mar 30 2022, 6:46 PM

Mar 13 2022

arichardson added a comment to D28846: amd64: make bcmp in libc just call memcmp.

FYI as of LLVM 9, clang will optimize memcmp calls that only check for equality to bcmp.

Mar 13 2022, 6:36 AM

Feb 14 2022

arichardson added inline comments to D34267: riscv: Fix another race in pmap_pinit().
Feb 14 2022, 3:48 PM

Feb 9 2022

arichardson added a comment to D34215: crunchgen: remove -Wl,-dc.

LGTM

Feb 9 2022, 9:06 AM

Jan 28 2022

arichardson accepted D34081: sort: Fix message catalogue usage.
Jan 28 2022, 4:38 PM