Also add the manpages

Sounds good, happy to zero after realloc instead. Will update soon.

Well ubsan is complaining that it loaded a value of 190 so that memory clearly wasn't zeroed.

In D31927#720365, @dim wrote:

I did this slightly differently in https://github.com/DimitryAndric/freebsd-src/commit/73a8f96dc7c12ebf76f5a40a7f1208c11f75741f, and I put it in another if block. It would be nice to choose either my version or yours, and integrate it right away, so I don't get needless merge conflicts the next time I sync up the llvm-13-update branch with main.

This change was sufficient to build and test amd64 with LLVM HEAD as of today.

Seems reasonable to me. What is the motivating use case?

ping?

Correct comment and drop $FreeBSD$ tags

LGTM. Possibly we should bootstrap the mkdtemp(3) sources rather than the host (glibc) ones to ensure all bootstrapped binaries behave the same way as they do on FreeBSD.

I agree, it would be very nice to add the values from the commit message to a test in lib/msun/tests. There's isn't a pow test yet, but one of the others could be used as a copy-paste starting point.

I can confirm this reliably fixes the test original test case (converted to ATF in D31862).
Code looks good to me, but since I'm not familiar with that part of the kernel I'd wait for @markj to review too.

ping?

Fix SOBJS->OBJS and modifying the wrong meta.* file

rebase

In D31060#715946, @emaste wrote:

From @mhorne via 4d0dc60f14019eab08f6d9dc656c9f9f1ebdde02, llvm-strip does not parse --
Now worked around in the base system, but we ought to support it in llvm-strip.

ping @dim ?

I doubt this is needed for bootstrapping, so using the current ifdef looks good to me. It would be good to see if/which flags are used during the build that aren't universally supported, but for now this should be sufficient.

Looks good to me, but maybe wait a little bit before committing so @kevans can have a look.

In D31498#711595, @fbsd-phab_maskray.me wrote:

In D31498#711395, @arichardson wrote:

In D31498#710007, @fbsd-phab_maskray.me wrote:

(FreeBSD on non-FreeBSD isn't smooth. i cannot do a build test.)

@fbsd-phab_maskray.me Could you post the error message somewhere? In general, cross-builds from linux+macOS should work, and I try to fix them after any breaking change.

The new behavior matches Linux glibc/musl.

I don't have a error message. If you want to test a breaking case for the old behavior, perhaps use -z common-page=1024 and then set the system page size larger than common-page-size.
I believe mprotect will have an incorrect length.

Looks good to me, but maybe wait for @emaste or @markj to also have a look.

I believe not modifying the n field should also make it easier to support multiple prefixes. For example like this:

#include <stdbool.h>
#include <stddef.h>
#include <stdio.h>
#include <string.h>

Need to rebase on top of https://reviews.freebsd.org/D31545

I like this approach, but how about avoiding duplicated work by only iterating over env once. I've attached a minimal test program based on this revision that should avoid unnecessary work by looping over env once and if the prefix matches checking the array of variables.

#include <sys/param.h>
#include <stdbool.h>
#include <stddef.h>
#include <stdio.h>
#include <string.h>

One thought I had a while back when looking at the environment variable code in rtld was to do a single pass over environ that initializes all the variables (to avoid pulling in getenv.c from libc).
I.e. having an array of something like this

struct ld_env_var_desc {
	char n[64];
        char **dest;
	bool unsecure;
};

or possibly a slightly more complicated struct that can also handle conversion to int/bool:

enum ld_env_type { ENV_STR, ENV_INT, ENV_BOOL, };

In D31498#710007, @fbsd-phab_maskray.me wrote:

(FreeBSD on non-FreeBSD isn't smooth. i cannot do a build test.)

don't install the tools at all

ping?

In D31383#707328, @pfg wrote:

Good.

Please also take a look at NetBSD's change 1.23, "Avoid undefined behavior in fread(3)".

@dim does this look okay?