User Details
- User Since
- Jan 17 2017, 2:21 PM (279 w, 4 d)
Tue, May 24
Adding downstream patches is not great but I think in this case it's reasonable. Although maybe upstream would be happy with this too, I'm not sure what the supported compilers for compiler-rt are.
Sun, May 22
If there are no further comments/suggestions, I'll commit this next week (most likely Wednesday)
Thu, May 19
Is there a per-process counter that that test could check instead of a global one? It seems rather racy even if we aren't running tests in parallel?
Sat, May 7
Ping? Is this ok to commit?
Apr 19 2022
Apr 18 2022
Use FreeBSD HEAD instead of CheriBSD HEAD as the base
Apr 17 2022
Apr 12 2022
Mar 30 2022
Mar 13 2022
FYI as of LLVM 9, clang will optimize memcmp calls that only check for equality to bcmp.
Feb 14 2022
Feb 9 2022
Jan 28 2022
Code changes look reasonable to me, but I've never used the NLS APIs. Since there is already an ifdef, maybe it makes sense to disable it for BOOTSTRAPPING? Will the bootstrap tools be able to load the catalog?
Jan 20 2022
Jan 16 2022
Similar patch (D33903) has been committed.
Oct 26 2021
Oct 18 2021
Other than the minor issue I noted this seems reasonable to me. @emaste what do you think?
A lot of that makefile is a bit confusing since I tried to get things to work without understanding everything... But since this fixed the build LGTM.
Oct 17 2021
Oct 14 2021
Oct 12 2021
LGTM. roundup2 usage can be simplified but feel free to ignore that suggestion.
This looks good to me, but I'd wait for @jhb to have a look. Not sure if we should make the rtld path an output parameter for is_executable() like we do in CheriBSD.
I generally like this change, it brings us closer to what we do in CheriBSD. I originally used direct exec a few years ago to handle our multiple ABIs but never got around to upstreaming that change (https://github.com/CTSRD-CHERI/cheribsd/commit/75d09a5fff18dca99f822d4d2ba04a201a39e153 and https://github.com/CTSRD-CHERI/cheribsd/commit/3f2a7f26a2cfe41a0acc4a67deb941eb7cee500d).
Other than my minor comment this LGTM.
Oct 11 2021
Zero after realloc instead
Oct 10 2021
Oct 8 2021
fix comment
- fix missing linux_virtio_cread_bytes
- add to sys/conf/files
remove some unused lines
Oct 5 2021
Sep 22 2021
Sep 20 2021
Also add the manpages
Sep 14 2021
Sounds good, happy to zero after realloc instead. Will update soon.
Sep 13 2021
Well ubsan is complaining that it loaded a value of 190 so that memory clearly wasn't zeroed.
This change was sufficient to build and test amd64 with LLVM HEAD as of today.
Seems reasonable to me. What is the motivating use case?
Sep 9 2021
Sep 7 2021
Correct comment and drop $FreeBSD$ tags
Sep 6 2021
LGTM. Possibly we should bootstrap the mkdtemp(3) sources rather than the host (glibc) ones to ensure all bootstrapped binaries behave the same way as they do on FreeBSD.
I agree, it would be very nice to add the values from the commit message to a test in lib/msun/tests. There's isn't a pow test yet, but one of the others could be used as a copy-paste starting point.
ping?
Fix SOBJS->OBJS and modifying the wrong meta.* file