Adding downstream patches is not great but I think in this case it's reasonable. Although maybe upstream would be happy with this too, I'm not sure what the supported compilers for compiler-rt are.

If there are no further comments/suggestions, I'll commit this next week (most likely Wednesday)

Is there a per-process counter that that test could check instead of a global one? It seems rather racy even if we aren't running tests in parallel?

Ping? Is this ok to commit?

In D34939#792003, @imp wrote:

A quick glance says "this looks good to me" if that's the feedback you're looking for :)

Use FreeBSD HEAD instead of CheriBSD HEAD as the base

FYI as of LLVM 9, clang will optimize memcmp calls that only check for equality to bcmp.

LGTM

Code changes look reasonable to me, but I've never used the NLS APIs. Since there is already an ifdef, maybe it makes sense to disable it for BOOTSTRAPPING? Will the bootstrap tools be able to load the catalog?

Similar patch (D33903) has been committed.

Other than the minor issue I noted this seems reasonable to me. @emaste what do you think?

A lot of that makefile is a bit confusing since I tried to get things to work without understanding everything... But since this fixed the build LGTM.

LGTM. roundup2 usage can be simplified but feel free to ignore that suggestion.

This looks good to me, but I'd wait for @jhb to have a look. Not sure if we should make the rtld path an output parameter for is_executable() like we do in CheriBSD.

I generally like this change, it brings us closer to what we do in CheriBSD. I originally used direct exec a few years ago to handle our multiple ABIs but never got around to upstreaming that change (https://github.com/CTSRD-CHERI/cheribsd/commit/75d09a5fff18dca99f822d4d2ba04a201a39e153 and https://github.com/CTSRD-CHERI/cheribsd/commit/3f2a7f26a2cfe41a0acc4a67deb941eb7cee500d).

Other than my minor comment this LGTM.

Zero after realloc instead

fix comment

• fix missing linux_virtio_cread_bytes
• add to sys/conf/files

remove some unused lines

Also add the manpages

Sounds good, happy to zero after realloc instead. Will update soon.

Well ubsan is complaining that it loaded a value of 190 so that memory clearly wasn't zeroed.

In D31927#720365, @dim wrote:

I did this slightly differently in https://github.com/DimitryAndric/freebsd-src/commit/73a8f96dc7c12ebf76f5a40a7f1208c11f75741f, and I put it in another if block. It would be nice to choose either my version or yours, and integrate it right away, so I don't get needless merge conflicts the next time I sync up the llvm-13-update branch with main.

This change was sufficient to build and test amd64 with LLVM HEAD as of today.

Seems reasonable to me. What is the motivating use case?

ping?

Correct comment and drop $FreeBSD$ tags

LGTM. Possibly we should bootstrap the mkdtemp(3) sources rather than the host (glibc) ones to ensure all bootstrapped binaries behave the same way as they do on FreeBSD.

I agree, it would be very nice to add the values from the commit message to a test in lib/msun/tests. There's isn't a pow test yet, but one of the others could be used as a copy-paste starting point.

I can confirm this reliably fixes the test original test case (converted to ATF in D31862).
Code looks good to me, but since I'm not familiar with that part of the kernel I'd wait for @markj to review too.

ping?

Fix SOBJS->OBJS and modifying the wrong meta.* file