- User Since
- Jan 17 2017, 2:21 PM (166 w, 4 d)
Fri, Mar 27
Wed, Mar 25
Thanks for upstreaming this! I think there are still a few files that installsysroot installs that aren't really needed (NLS?) but I needs to check whether that's still the case.
Mon, Mar 23
Sun, Mar 22
Rebased on latest HEAD.
Fri, Mar 20
Wed, Mar 18
The package also creates a tests user. Not sure if that is still required.
Tue, Mar 17
Mon, Mar 16
Rebase after LLVM 10 import
Tue, Mar 10
I'm currently on holiday but will update this once I'm back on Monday.
Tue, Mar 3
I think they should be installed. It allows e.g. building binaries for a bare metal target. Fixing it in upstream llvm would be ideal but we could also change the FreeBSD headers to check for the llvm macros?
Sat, Feb 29
How does this compare to using the __atomic compiler builtins?
Feb 6 2020
Change looks fine to me.
Feb 4 2020
Feb 3 2020
Allow overriding the LMA as may be required for some targets (requested by @jrtc27)
Jan 31 2020
Jan 29 2020
I can commit this now if we are okay with octeon kernels being broken until llvm 10 lands?
Jan 27 2020
Jan 25 2020
Yes I agree, removing the LTO option is not necessary.
I think in https://github.com/CTSRD-CHERI/cheribsd/commit/8041a7e459d1d6e453d082ff57db2f3f94ca1a3c I just copied from the genassym.o line.
Jan 17 2020
I also tried building n32 but that fails when linking the syscall objects. My guess is that SYS.h is missing the PIC n32 case and always generates position dependent assembly.
mips64hf is currently broken because libc_nossp is built as soft-float (I think this is the lib32 version only since the error happens when building rtld-elf32):
Jan 16 2020
Looks fine to me but someone else should give the final approval.
I guess I could try to build and boot a n32 world, but I'm not sure which kernel I should be using to test it.
No longer accurate, I have changes to allow bootstrapping localedef and CDDL code.
I am not sure what the correct process is to merge upstream LLVM changes. Is it fine to just commit this diff or are any other steps required?
Jan 15 2020
Jan 10 2020
Ping? Can we merge this or do I have to convince upstream LLVM to add checks for the FreeBSD _FOO_DECLARED macros to their stddef.h/stdarg.h? I'm not sure how willing they would be to make that change though.
I agree that a small separate tool would be nicer. I don't really have time to write one right now though. I'll wait before committing this until it's the last blocker for cross-building. Maybe by then I'll find some time to add a write_locked (or whatever name we want to choose) bootstrap tool.
Jan 5 2020
Jan 2 2020
Looks good. Compiles for me with latest LLVM.
Dec 10 2019
Dec 2 2019
Nov 21 2019
Nov 20 2019
LGTM. Only concern might be that adding /usr/libexec to PATH adds too much stuff.
Nov 19 2019
Nov 17 2019
Nov 15 2019
This change is required to build with an unmodified upstream LLVM since the default upstream clang builtin headers are incompatible with the ones in /usr/bin/include (see my earlier comments in this review).
Disable all flags except -l/-u when bootstrapping