Page MenuHomeFreeBSD

arichardson (Alexander Richardson)
User

Projects

User Details

User Since
Jan 17 2017, 2:21 PM (245 w, 6 h)

Recent Activity

Wed, Sep 22

arichardson added inline comments to D32052: tests: Test endian.h, byteswap.h, sys/endian.h and both endian.h and byteswap.h together.
Wed, Sep 22, 1:21 PM
arichardson added inline comments to D32052: tests: Test endian.h, byteswap.h, sys/endian.h and both endian.h and byteswap.h together.
Wed, Sep 22, 7:53 AM

Mon, Sep 20

arichardson added inline comments to D32022: Update OptionalObsoleteFiles.inc after 021385aba562.
Mon, Sep 20, 1:46 PM
arichardson updated the diff for D32022: Update OptionalObsoleteFiles.inc after 021385aba562.

Also add the manpages

Mon, Sep 20, 11:38 AM
arichardson updated subscribers of D32022: Update OptionalObsoleteFiles.inc after 021385aba562.
Mon, Sep 20, 8:50 AM
arichardson requested review of D32022: Update OptionalObsoleteFiles.inc after 021385aba562.
Mon, Sep 20, 8:48 AM

Tue, Sep 14

arichardson planned changes to D31382: lib/libc: Fix uninitialized value in __setenv().

Sounds good, happy to zero after realloc instead. Will update soon.

Tue, Sep 14, 9:31 AM

Mon, Sep 13

arichardson added a comment to D31382: lib/libc: Fix uninitialized value in __setenv().

Well ubsan is complaining that it loaded a value of 190 so that memory clearly wasn't zeroed.

Mon, Sep 13, 9:06 PM
arichardson added a comment to D31927: Add -Wno-error=unused-but-set-variable when building with Clang 13+.
In D31927#720365, @dim wrote:

I did this slightly differently in https://github.com/DimitryAndric/freebsd-src/commit/73a8f96dc7c12ebf76f5a40a7f1208c11f75741f, and I put it in another if block. It would be nice to choose either my version or yours, and integrate it right away, so I don't get needless merge conflicts the next time I sync up the llvm-13-update branch with main.

Mon, Sep 13, 12:57 PM
arichardson added a comment to D31927: Add -Wno-error=unused-but-set-variable when building with Clang 13+.

This change was sufficient to build and test amd64 with LLVM HEAD as of today.

Mon, Sep 13, 12:30 PM
arichardson requested review of D31927: Add -Wno-error=unused-but-set-variable when building with Clang 13+.
Mon, Sep 13, 12:29 PM
arichardson closed D31040: Add missing dep patterns for .pieo.
Mon, Sep 13, 12:23 PM
arichardson committed R10:2d78130185b5: Add missing dep patterns for .pieo (authored by arichardson).
Add missing dep patterns for .pieo
Mon, Sep 13, 12:23 PM
arichardson committed R10:d7d962ead0b6: Add a test for https://reviews.freebsd.org/D31858 (PR 258310) (authored by arichardson).
Add a test for https://reviews.freebsd.org/D31858 (PR 258310)
Mon, Sep 13, 9:34 AM
arichardson closed D31862: Add a test for https://reviews.freebsd.org/D31858 (PR 258310).
Mon, Sep 13, 9:33 AM
arichardson added reviewers for D31382: lib/libc: Fix uninitialized value in __setenv(): emaste, kib.
Mon, Sep 13, 9:14 AM
arichardson accepted D31924: libprocstat: extend zfs_defs hack for .pieo.
Mon, Sep 13, 9:13 AM
arichardson accepted D31920: bsd.lib.mk: add conditions for building _pie.a archives.

Seems reasonable to me. What is the motivating use case?

Mon, Sep 13, 9:13 AM
arichardson added a comment to D31040: Add missing dep patterns for .pieo.

ping?

Mon, Sep 13, 9:12 AM

Thu, Sep 9

arichardson committed R10:395db99f32bc: Export _mmap and __sys_mmap from libc.so (authored by arichardson).
Export _mmap and __sys_mmap from libc.so
Thu, Sep 9, 10:48 AM

Tue, Sep 7

arichardson accepted D31874: cdefs.h: Remove redundant #ifdefs.
Tue, Sep 7, 3:50 PM
arichardson added inline comments to D27743: Add aio_writev and aio_readv.
Tue, Sep 7, 12:26 PM
arichardson committed R10:4a6bf977ac3e: Fix cross-builds after 4e5d32a445f90d37966cd6de571978551654e3f3 (authored by jlduran_gmail.com).
Fix cross-builds after 4e5d32a445f90d37966cd6de571978551654e3f3
Tue, Sep 7, 9:58 AM
arichardson committed R10:94d9439b6be6: Fix cross-builds after 4e5d32a445f90d37966cd6de571978551654e3f3 (authored by jlduran_gmail.com).
Fix cross-builds after 4e5d32a445f90d37966cd6de571978551654e3f3
Tue, Sep 7, 9:55 AM
arichardson updated the diff for D31862: Add a test for https://reviews.freebsd.org/D31858 (PR 258310).

Correct comment and drop $FreeBSD$ tags

Tue, Sep 7, 9:33 AM

Mon, Sep 6

arichardson accepted D31863: genoffset.sh: Use 10 X's instead of 5 for pick mkdtemp implementations.

LGTM. Possibly we should bootstrap the mkdtemp(3) sources rather than the host (glibc) ones to ensure all bootstrapped binaries behave the same way as they do on FreeBSD.

Mon, Sep 6, 7:52 PM
arichardson added a comment to D31865: Fix powf()..

I agree, it would be very nice to add the values from the commit message to a test in lib/msun/tests. There's isn't a pow test yet, but one of the others could be used as a copy-paste starting point.

Mon, Sep 6, 7:47 PM
arichardson accepted D31858: kqueue: drain kqueue taskqueue if syscall tickled it.

I can confirm this reliably fixes the test original test case (converted to ATF in D31862).
Code looks good to me, but since I'm not familiar with that part of the kernel I'd wait for @markj to review too.

Mon, Sep 6, 3:22 PM
arichardson requested review of D31862: Add a test for https://reviews.freebsd.org/D31858 (PR 258310).
Mon, Sep 6, 3:20 PM
arichardson added a comment to D31382: lib/libc: Fix uninitialized value in __setenv().

ping?

Mon, Sep 6, 12:05 PM
arichardson retitled D31040: Add missing dep patterns for .pieo from Add missing dep patterns for .pieo and .nosspico to Add missing dep patterns for .pieo.
Mon, Sep 6, 9:35 AM
arichardson updated the diff for D31040: Add missing dep patterns for .pieo.

Fix SOBJS->OBJS and modifying the wrong meta.* file

Mon, Sep 6, 9:35 AM
arichardson committed R10:24f586182ff4: Enable MK_LLVM_BINUTILS if MK_ASAN is requested (authored by arichardson).
Enable MK_LLVM_BINUTILS if MK_ASAN is requested
Mon, Sep 6, 9:26 AM
arichardson closed D31061: Enable MK_LLVM_BINUTILS if MK_ASAN is requested.
Mon, Sep 6, 9:26 AM
arichardson closed D31060: Add WITH_LLVM_BINUTILS to install LLVM binutils instead of Elftoolchain.
Mon, Sep 6, 9:25 AM
arichardson committed R10:021385aba562: Add WITH_LLVM_BINUTILS to install LLVM binutils instead of Elftoolchain (authored by arichardson).
Add WITH_LLVM_BINUTILS to install LLVM binutils instead of Elftoolchain
Mon, Sep 6, 9:25 AM
arichardson closed D31058: Don't build and install {llvm,clang,lldb}-tblgen for the target.
Mon, Sep 6, 9:25 AM
arichardson committed R10:8e1c989abbd1: Don't build and install {llvm,clang,lldb}-tblgen for the target (authored by arichardson).
Don't build and install {llvm,clang,lldb}-tblgen for the target
Mon, Sep 6, 9:25 AM
arichardson closed D31059: Don't default MK_LLVM_TARGET_ALL to yes unless MK_CLANG is requested.
Mon, Sep 6, 9:25 AM
arichardson committed R10:e7e22476d1d7: Don't default MK_LLVM_TARGET_ALL to yes unless MK_CLANG is requested (authored by arichardson).
Don't default MK_LLVM_TARGET_ALL to yes unless MK_CLANG is requested
Mon, Sep 6, 9:25 AM
arichardson updated the diff for D31060: Add WITH_LLVM_BINUTILS to install LLVM binutils instead of Elftoolchain.

rebase

Mon, Sep 6, 8:49 AM
arichardson added inline comments to D29870: clang-format: Minor tweaks.
Mon, Sep 6, 8:25 AM

Mon, Aug 30

arichardson added a comment to D31060: Add WITH_LLVM_BINUTILS to install LLVM binutils instead of Elftoolchain.

From @mhorne via 4d0dc60f14019eab08f6d9dc656c9f9f1ebdde02, llvm-strip does not parse --
Now worked around in the base system, but we ought to support it in llvm-strip.

Mon, Aug 30, 5:57 PM

Aug 26 2021

arichardson added inline comments to D31058: Don't build and install {llvm,clang,lldb}-tblgen for the target.
Aug 26 2021, 9:23 AM
arichardson added a comment to D31058: Don't build and install {llvm,clang,lldb}-tblgen for the target.

ping @dim ?

Aug 26 2021, 9:23 AM

Aug 23 2021

arichardson added a comment to D31619: truncate(1): Fix cross-build CI failure due to missing fspacectl.

I doubt this is needed for bootstrapping, so using the current ifdef looks good to me. It would be good to see if/which flags are used during the build that aren't universally supported, but for now this should be sufficient.

Aug 23 2021, 1:53 PM
arichardson accepted D26734: crunchgen: replace "cd p->srcdir && pwd -P" with realpath(p->srcdir).

Looks good to me, but maybe wait a little bit before committing so @kevans can have a look.

Aug 23 2021, 1:48 PM

Aug 19 2021

arichardson accepted D31610: crunchgen: fix remaining issues under WARNS=6.
Aug 19 2021, 7:52 AM
arichardson accepted D31609: crunchide: static'ify remaining non-exported functions.
Aug 19 2021, 7:52 AM
arichardson accepted D31608: crunchide: address complaints from WARNS=6.
Aug 19 2021, 7:51 AM
arichardson accepted D31607: crunchgen: sprinkle some const-poisoning around.
Aug 19 2021, 7:51 AM

Aug 18 2021

arichardson committed R10:64f6c8d616b9: Mark LLDB/CLANG_BOOTSTRAP/LLD_BOOTSTRAP as broken on non-FreeBSD for now (authored by arichardson).
Mark LLDB/CLANG_BOOTSTRAP/LLD_BOOTSTRAP as broken on non-FreeBSD for now
Aug 18 2021, 8:55 AM
arichardson committed R10:ba91a76793d9: Add missing lex/yacc dependency for mkesdb/mkcsmapper bootstrap (authored by arichardson).
Add missing lex/yacc dependency for mkesdb/mkcsmapper bootstrap
Aug 18 2021, 8:55 AM

Aug 17 2021

arichardson committed R10:d9f25575a29f: Mark LLDB/CLANG_BOOTSTRAP/LLD_BOOTSTRAP as broken on non-FreeBSD for now (authored by arichardson).
Mark LLDB/CLANG_BOOTSTRAP/LLD_BOOTSTRAP as broken on non-FreeBSD for now
Aug 17 2021, 4:45 PM

Aug 16 2021

arichardson added a comment to D31498: rtld: Round down relro_size.

(FreeBSD on non-FreeBSD isn't smooth. i cannot do a build test.)

@fbsd-phab_maskray.me Could you post the error message somewhere? In general, cross-builds from linux+macOS should work, and I try to fix them after any breaking change.

The new behavior matches Linux glibc/musl.

I don't have a error message. If you want to test a breaking case for the old behavior, perhaps use -z common-page=1024 and then set the system page size larger than common-page-size.
I believe mprotect will have an incorrect length.

Aug 16 2021, 7:13 PM
arichardson accepted D31545: rtld: rework how environment variables are named.

Looks good to me, but maybe wait for @emaste or @markj to also have a look.

Aug 16 2021, 4:45 PM
arichardson added a comment to D31545: rtld: rework how environment variables are named.

I believe not modifying the n field should also make it easier to support multiple prefixes. For example like this:

#include <stdbool.h>
#include <stddef.h>
#include <stdio.h>
#include <string.h>
Aug 16 2021, 3:08 PM
arichardson planned changes to D28220: rtld: Always check LD_64_/LD_32_ environment variables.

Need to rebase on top of https://reviews.freebsd.org/D31545

Aug 16 2021, 2:53 PM
arichardson added a comment to D31545: rtld: rework how environment variables are named.

I like this approach, but how about avoiding duplicated work by only iterating over env once. I've attached a minimal test program based on this revision that should avoid unnecessary work by looping over env once and if the prefix matches checking the array of variables.

#include <sys/param.h>
#include <stdbool.h>
#include <stddef.h>
#include <stdio.h>
#include <string.h>
Aug 16 2021, 2:52 PM
arichardson added a comment to D31545: rtld: rework how environment variables are named.

One thought I had a while back when looking at the environment variable code in rtld was to do a single pass over environ that initializes all the variables (to avoid pulling in getenv.c from libc).
I.e. having an array of something like this

struct ld_env_var_desc {
	char n[64];
        char **dest;
	bool unsecure;
};

or possibly a slightly more complicated struct that can also handle conversion to int/bool:

enum ld_env_type { ENV_STR, ENV_INT, ENV_BOOL, };
Aug 16 2021, 11:55 AM
arichardson added a comment to D31498: rtld: Round down relro_size.

(FreeBSD on non-FreeBSD isn't smooth. i cannot do a build test.)

Aug 16 2021, 11:39 AM
arichardson added inline comments to R10:cef65082ae12: bsd.compiler.mk: Fix cross-building from non-FreeBSD.
Aug 16 2021, 11:37 AM
arichardson committed R10:cc1345056b11: Add missing lex/yacc dependency for mkesdb/mkcsmapper bootstrap (authored by arichardson).
Add missing lex/yacc dependency for mkesdb/mkcsmapper bootstrap
Aug 16 2021, 9:37 AM
arichardson added inline comments to R10:cef65082ae12: bsd.compiler.mk: Fix cross-building from non-FreeBSD.
Aug 16 2021, 9:25 AM
arichardson added inline comments to R10:cef65082ae12: bsd.compiler.mk: Fix cross-building from non-FreeBSD.
Aug 16 2021, 8:41 AM
arichardson accepted D31529: Makefile.inc1: Make sure sub-makes see MK_CLANG_BOOTSTRAP=no when XCC is a path.
Aug 16 2021, 8:37 AM
arichardson retitled D31058: Don't build and install {llvm,clang,lldb}-tblgen for the target from Only build {llvm,clang,lldb}-tblgen for the target with MK_CLANG_EXTRAS to Don't build and install {llvm,clang,lldb}-tblgen for the target.
Aug 16 2021, 8:29 AM
arichardson updated the diff for D31058: Don't build and install {llvm,clang,lldb}-tblgen for the target.

don't install the tools at all

Aug 16 2021, 8:27 AM
arichardson added a comment to D31382: lib/libc: Fix uninitialized value in __setenv().

ping?

Aug 16 2021, 8:17 AM

Aug 5 2021

arichardson committed R10:7809becb4ea6: Add missing bsd.linker.mk include after 31ba4ce8898f9dfa5e7f054fdbc26e50a599a6e3 (authored by arichardson).
Add missing bsd.linker.mk include after 31ba4ce8898f9dfa5e7f054fdbc26e50a599a6e3
Aug 5 2021, 10:46 AM
arichardson committed R10:c65dab7dd245: Allow bootstrapping llvm-tblgen on macOS and Linux (authored by arichardson).
Allow bootstrapping llvm-tblgen on macOS and Linux
Aug 5 2021, 9:28 AM
arichardson committed R10:1d7c196d119d: Remove mkcsmapper_static and mkesdb_static from build-tools (authored by arichardson).
Remove mkcsmapper_static and mkesdb_static from build-tools
Aug 5 2021, 9:28 AM
arichardson committed R10:85c76b41178c: tools/build: Don't redefine open() for the linux bootstrap (authored by arichardson).
tools/build: Don't redefine open() for the linux bootstrap
Aug 5 2021, 9:28 AM
arichardson committed R10:e2e533bdcc7f: bsd.linker.mk: Detect LLD when built with PACKAGE_VENDOR (authored by arichardson).
bsd.linker.mk: Detect LLD when built with PACKAGE_VENDOR
Aug 5 2021, 9:28 AM
arichardson committed R10:b7440d235e5d: Don't build lldb-tablegen if MK_LLDB=no (authored by arichardson).
Don't build lldb-tablegen if MK_LLDB=no
Aug 5 2021, 9:28 AM
arichardson committed R10:e0174face9bb: Allow building usr.bin/vi with MK_ASAN (authored by arichardson).
Allow building usr.bin/vi with MK_ASAN
Aug 5 2021, 9:27 AM
arichardson committed R10:0869d85591db: bin/ps: Avoid function name conflict with libc uname() (authored by arichardson).
bin/ps: Avoid function name conflict with libc uname()
Aug 5 2021, 9:27 AM
arichardson committed R10:120f0a029e26: Fix building rescue/rescue when sanitizers are enabled (authored by arichardson).
Fix building rescue/rescue when sanitizers are enabled
Aug 5 2021, 9:27 AM
arichardson committed R10:7a7324d9cebe: usr.bin/diff: fix UBSan error in readhash (authored by arichardson).
usr.bin/diff: fix UBSan error in readhash
Aug 5 2021, 9:27 AM
arichardson committed R10:608cb9631239: usr.bin/login: send errors to console if syslog isn't running (authored by arichardson).
usr.bin/login: send errors to console if syslog isn't running
Aug 5 2021, 9:27 AM
arichardson committed R10:e4c2ffe93205: usr.bin/sort: Avoid UBSan errors (authored by arichardson).
usr.bin/sort: Avoid UBSan errors
Aug 5 2021, 9:27 AM
arichardson added a reverting change for R10:8ec4ba8a76aa: Remove lib/kyua from the build: R10:22548a3b8070: Simplify and speed up the kyua build.
Aug 5 2021, 9:26 AM
arichardson committed R10:22548a3b8070: Simplify and speed up the kyua build (authored by arichardson).
Simplify and speed up the kyua build
Aug 5 2021, 9:26 AM

Aug 3 2021

arichardson added reviewers for D31061: Enable MK_LLVM_BINUTILS if MK_ASAN is requested: emaste, markj, dim.
Aug 3 2021, 9:41 AM
arichardson committed R10:428a32edba4c: Use .sinclude for bsd.sanitizer.mk (authored by arichardson).
Use .sinclude for bsd.sanitizer.mk
Aug 3 2021, 9:40 AM

Aug 2 2021

arichardson committed R10:9f1db6c5557b: Add missing bsd.linker.mk include after 31ba4ce8898f9dfa5e7f054fdbc26e50a599a6e3 (authored by arichardson).
Add missing bsd.linker.mk include after 31ba4ce8898f9dfa5e7f054fdbc26e50a599a6e3
Aug 2 2021, 3:40 PM
arichardson added a comment to D31383: Fix undefined pointer arithmetic in fread().
In D31383#707328, @pfg wrote:

Good.

Please also take a look at NetBSD's change 1.23, "Avoid undefined behavior in fread(3)".

Aug 2 2021, 3:07 PM
arichardson committed R10:17d6371e4c85: Fix GCC and -DWITH_CLEAN build after 7bc797e3f3807660cf98e5b1bd63545cafe820f8 (authored by arichardson).
Fix GCC and -DWITH_CLEAN build after 7bc797e3f3807660cf98e5b1bd63545cafe820f8
Aug 2 2021, 3:04 PM
arichardson committed R10:5c9cb96a239c: Fix BUILD_WITH_STRICT_TMPPATH build after adding time to ITOOLS (authored by arichardson).
Fix BUILD_WITH_STRICT_TMPPATH build after adding time to ITOOLS
Aug 2 2021, 2:49 PM
arichardson requested review of D31383: Fix undefined pointer arithmetic in fread().
Aug 2 2021, 2:44 PM
arichardson requested review of D31382: lib/libc: Fix uninitialized value in __setenv().
Aug 2 2021, 2:43 PM
arichardson added a comment to D31058: Don't build and install {llvm,clang,lldb}-tblgen for the target.

@dim does this look okay?

Aug 2 2021, 1:40 PM
arichardson closed D31057: Allow bootstrapping llvm-tblgen on macOS and Linux.
Aug 2 2021, 1:38 PM
arichardson committed R10:31ba4ce8898f: Allow bootstrapping llvm-tblgen on macOS and Linux (authored by arichardson).
Allow bootstrapping llvm-tblgen on macOS and Linux
Aug 2 2021, 1:38 PM
arichardson added inline comments to D31057: Allow bootstrapping llvm-tblgen on macOS and Linux.
Aug 2 2021, 1:38 PM
arichardson committed R10:2de949cf85d0: Remove mkcsmapper_static and mkesdb_static from build-tools (authored by arichardson).
Remove mkcsmapper_static and mkesdb_static from build-tools
Aug 2 2021, 1:36 PM
arichardson committed R10:8185be330723: libc: Disable ASAN for certain string functions (authored by arichardson).
libc: Disable ASAN for certain string functions
Aug 2 2021, 1:36 PM
arichardson committed R10:f0712132b68b: Don't instrument the rdtsc ifunc when building with ASAN/UBSAN (authored by arichardson).
Don't instrument the rdtsc ifunc when building with ASAN/UBSAN
Aug 2 2021, 1:36 PM
arichardson committed R10:5e9226f063bc: Fix build of stand/ when building world with ASAN (authored by arichardson).
Fix build of stand/ when building world with ASAN
Aug 2 2021, 1:35 PM
arichardson committed R10:c826e08841fb: Fix MK_TESTS build with MK_ASAN/MK_UBSAN (authored by arichardson).
Fix MK_TESTS build with MK_ASAN/MK_UBSAN
Aug 2 2021, 1:35 PM