Page MenuHomeFreeBSD

arichardson (Alexander Richardson)
User

Projects

User Details

User Since
Jan 17 2017, 2:21 PM (279 w, 4 d)

Recent Activity

Tue, May 24

arichardson added a comment to D35311: compiler-rt: fix compiler rt with CROSS_TOOLCHAIN.

Adding downstream patches is not great but I think in this case it's reasonable. Although maybe upstream would be happy with this too, I'm not sure what the supported compilers for compiler-rt are.

Tue, May 24, 9:56 PM

Sun, May 22

arichardson added a comment to D34939: Install working pkgconfig .pc files for compat libraries.

If there are no further comments/suggestions, I'll commit this next week (most likely Wednesday)

Sun, May 22, 2:54 PM

Thu, May 19

arichardson added a comment to D35260: Prevent running unix_passfd_test in parallel.

Is there a per-process counter that that test could check instead of a global one? It seems rather racy even if we aren't running tests in parallel?

Thu, May 19, 10:30 PM

Sat, May 7

arichardson committed R10:3c01fdcfc161: cross-build: fix some redeclaration warnings during bootstrap (authored by arichardson).
cross-build: fix some redeclaration warnings during bootstrap
Sat, May 7, 3:59 PM
arichardson committed R10:299d5e2b640b: Add missing const after 6c4f95161d6e (authored by arichardson).
Add missing const after 6c4f95161d6e
Sat, May 7, 3:59 PM
arichardson committed R10:b7a47939e250: virtio: make the write_config buffer argument const (authored by arichardson).
virtio: make the write_config buffer argument const
Sat, May 7, 3:59 PM
arichardson committed R10:95c6e44054ce: linuxkpi: implement ida_alloc() (authored by arichardson).
linuxkpi: implement ida_alloc()
Sat, May 7, 3:58 PM
arichardson committed R10:763198cc5086: linuxkpi: Allow BUILD_BUG_ON in if statements without braces (authored by arichardson).
linuxkpi: Allow BUILD_BUG_ON in if statements without braces
Sat, May 7, 3:58 PM
arichardson committed R10:82b4e784f3df: linuxkpi: Add sg_init_one (authored by arichardson).
linuxkpi: Add sg_init_one
Sat, May 7, 3:58 PM
arichardson added a comment to D34939: Install working pkgconfig .pc files for compat libraries.

Ping? Is this ok to commit?

Sat, May 7, 3:58 PM
arichardson committed R10:cbbdacf4dc8f: Add missing dep patterns for .pieo (authored by arichardson).
Add missing dep patterns for .pieo
Sat, May 7, 3:58 PM
arichardson committed R10:b0188ea20071: Add a test for https://reviews.freebsd.org/D31858 (PR 258310) (authored by arichardson).
Add a test for https://reviews.freebsd.org/D31858 (PR 258310)
Sat, May 7, 3:57 PM
arichardson committed R10:afab9d5ffe63: Export _mmap and __sys_mmap from libc.so (authored by arichardson).
Export _mmap and __sys_mmap from libc.so
Sat, May 7, 3:57 PM

Apr 19 2022

arichardson requested review of D34971: bsd.test.mk: Attempt to work around installation race.
Apr 19 2022, 9:19 PM

Apr 18 2022

arichardson added a comment to D34939: Install working pkgconfig .pc files for compat libraries.
In D34939#792003, @imp wrote:

A quick glance says "this looks good to me" if that's the feedback you're looking for :)

Apr 18 2022, 2:49 PM
arichardson updated the summary of D34939: Install working pkgconfig .pc files for compat libraries.
Apr 18 2022, 2:49 PM
arichardson updated the diff for D34939: Install working pkgconfig .pc files for compat libraries.

Use FreeBSD HEAD instead of CheriBSD HEAD as the base

Apr 18 2022, 2:48 PM

Apr 17 2022

arichardson requested review of D34939: Install working pkgconfig .pc files for compat libraries.
Apr 17 2022, 7:22 PM

Apr 12 2022

arichardson added inline comments to D34797: Remove checks for __GNUCLIKE_ASM assuming it is always true..
Apr 12 2022, 10:59 PM

Mar 30 2022

arichardson added inline comments to R10:f90cd1ae30b5: Clear non-x86 compat stat syscall kernel stack memory disclosure.
Mar 30 2022, 6:46 PM

Mar 13 2022

arichardson added a comment to D28846: amd64: make bcmp in libc just call memcmp.

FYI as of LLVM 9, clang will optimize memcmp calls that only check for equality to bcmp.

Mar 13 2022, 6:36 AM

Feb 14 2022

arichardson added inline comments to D34267: riscv: Fix another race in pmap_pinit().
Feb 14 2022, 3:48 PM

Feb 9 2022

arichardson added a comment to D34215: crunchgen: remove -Wl,-dc.

LGTM

Feb 9 2022, 9:06 AM

Jan 28 2022

arichardson accepted D34081: sort: Fix message catalogue usage.
Jan 28 2022, 4:38 PM
arichardson added a comment to D34081: sort: Fix message catalogue usage.

Code changes look reasonable to me, but I've never used the NLS APIs. Since there is already an ifdef, maybe it makes sense to disable it for BOOTSTRAPPING? Will the bootstrap tools be able to load the catalog?

Jan 28 2022, 4:38 PM

Jan 20 2022

arichardson added inline comments to D33964: proc: Use more appropriate types for KERN_PROC_VM_LAYOUT.
Jan 20 2022, 9:44 PM

Jan 16 2022

arichardson abandoned D31383: Fix undefined pointer arithmetic in fread().

Similar patch (D33903) has been committed.

Jan 16 2022, 9:07 AM

Oct 26 2021

arichardson closed D32022: Update OptionalObsoleteFiles.inc after 021385aba562.
Oct 26 2021, 2:58 AM

Oct 18 2021

arichardson accepted D30080: lorder: add deprecation notice.
Oct 18 2021, 8:21 PM
arichardson added a comment to D32065: llvm-strings(1): Install as strings when WITH_LLVM_BINUTILS=YES.

Other than the minor issue I noted this seems reasonable to me. @emaste what do you think?

Oct 18 2021, 8:20 PM
arichardson added inline comments to D32514: rtld_malloc: more accurate handling of mmap(2) failure.
Oct 18 2021, 8:17 PM
arichardson accepted D32514: rtld_malloc: more accurate handling of mmap(2) failure.
Oct 18 2021, 8:17 PM
arichardson added inline comments to D32542: Fix cross-building on Linux/aarch64.
Oct 18 2021, 1:06 PM
arichardson accepted D32542: Fix cross-building on Linux/aarch64.

A lot of that makefile is a bit confusing since I tried to get things to work without understanding everything... But since this fixed the build LGTM.

Oct 18 2021, 1:05 PM

Oct 17 2021

arichardson added inline comments to D32524: rtld: Support DT_RELR relative relocation format.
Oct 17 2021, 6:48 AM

Oct 14 2021

arichardson committed R10:367ec75323e6: Fix a syntax error in 1b85b68da0b2 (authored by arichardson).
Fix a syntax error in 1b85b68da0b2
Oct 14 2021, 4:47 PM
arichardson committed R10:1b85b68da0b2: llvm-readobj: Attach to buildsystem (authored by me_cameronkatri.com).
llvm-readobj: Attach to buildsystem
Oct 14 2021, 4:20 PM
arichardson closed D32058: llvm-readobj: Attach to buildsystem.
Oct 14 2021, 4:20 PM

Oct 12 2021

arichardson accepted D32474: crt_malloc: Be more persistent when handling mmap() failure.

LGTM. roundup2 usage can be simplified but feel free to ignore that suggestion.

Oct 12 2021, 10:17 PM
arichardson added a comment to D32464: Fix ldd -f on shared objects.

This looks good to me, but I'd wait for @jhb to have a look. Not sure if we should make the rtld path an output parameter for is_executable() like we do in CheriBSD.

Oct 12 2021, 4:01 PM
arichardson added a reviewer for D32464: Fix ldd -f on shared objects: jhb.

I generally like this change, it brings us closer to what we do in CheriBSD. I originally used direct exec a few years ago to handle our multiple ABIs but never got around to upstreaming that change (https://github.com/CTSRD-CHERI/cheribsd/commit/75d09a5fff18dca99f822d4d2ba04a201a39e153 and https://github.com/CTSRD-CHERI/cheribsd/commit/3f2a7f26a2cfe41a0acc4a67deb941eb7cee500d).

Oct 12 2021, 3:01 PM
arichardson accepted D32058: llvm-readobj: Attach to buildsystem.

Other than my minor comment this LGTM.

Oct 12 2021, 7:23 AM

Oct 11 2021

arichardson committed R10:9017870541da: Add missing const after 6c4f95161d6e (authored by arichardson).
Add missing const after 6c4f95161d6e
Oct 11 2021, 12:21 PM
arichardson updated the diff for D31382: lib/libc: Fix uninitialized value in __setenv().

Zero after realloc instead

Oct 11 2021, 11:22 AM
arichardson committed R10:a89410ef9179: cross-build: fix some redeclaration warnings during bootstrap (authored by arichardson).
cross-build: fix some redeclaration warnings during bootstrap
Oct 11 2021, 11:20 AM
arichardson committed R10:6c4f95161d6e: virtio: make the write_config buffer argument const (authored by arichardson).
virtio: make the write_config buffer argument const
Oct 11 2021, 10:55 AM
arichardson committed R10:d98f2712c7f5: linuxkpi: implement ida_alloc() (authored by arichardson).
linuxkpi: implement ida_alloc()
Oct 11 2021, 10:55 AM
arichardson committed R10:6d15ccde4d95: linuxkpi: Allow BUILD_BUG_ON in if statements without braces (authored by arichardson).
linuxkpi: Allow BUILD_BUG_ON in if statements without braces
Oct 11 2021, 10:55 AM
arichardson committed R10:ff479cc6c9ee: linuxkpi: add PAGE_ALIGNED macro (authored by arichardson).
linuxkpi: add PAGE_ALIGNED macro
Oct 11 2021, 10:55 AM
arichardson closed D32370: virtio: make the write_config buffer argument const.
Oct 11 2021, 10:55 AM
arichardson closed D32366: A few linuxkpi additions for virtio-gpu.
Oct 11 2021, 10:54 AM
arichardson committed R10:2686b10db41c: linuxkpi: Add sg_init_one (authored by arichardson).
linuxkpi: Add sg_init_one
Oct 11 2021, 10:54 AM
arichardson committed R10:88c027338f18: Update OptionalObsoleteFiles.inc after 021385aba562 (authored by arichardson).
Update OptionalObsoleteFiles.inc after 021385aba562
Oct 11 2021, 10:54 AM

Oct 10 2021

arichardson accepted D32443: bootstrap: No need to disabled shared libraries.
Oct 10 2021, 5:49 PM

Oct 8 2021

arichardson updated the diff for D32372: Initial linuxkpi support for virtio.

fix comment

Oct 8 2021, 8:34 PM
arichardson updated the diff for D32372: Initial linuxkpi support for virtio.
  • fix missing linux_virtio_cread_bytes
  • add to sys/conf/files
Oct 8 2021, 8:32 PM
arichardson updated the diff for D32372: Initial linuxkpi support for virtio.

remove some unused lines

Oct 8 2021, 4:00 PM
arichardson requested review of D32372: Initial linuxkpi support for virtio.
Oct 8 2021, 3:58 PM
arichardson requested review of D32371: virtqueue: expose two helper functions.
Oct 8 2021, 3:57 PM
arichardson requested review of D32370: virtio: make the write_config buffer argument const.
Oct 8 2021, 3:55 PM
arichardson requested review of D32366: A few linuxkpi additions for virtio-gpu.
Oct 8 2021, 8:38 AM

Oct 5 2021

arichardson added inline comments to D13306: Allow compiling usr.bin/find on Linux and Mac.
Oct 5 2021, 12:24 PM
arichardson added inline comments to D13306: Allow compiling usr.bin/find on Linux and Mac.
Oct 5 2021, 12:03 PM
arichardson added inline comments to D13306: Allow compiling usr.bin/find on Linux and Mac.
Oct 5 2021, 12:01 PM
arichardson added inline comments to D32307: Prepare the system for _FORTIFY_SOURCE.
Oct 5 2021, 7:46 AM

Sep 22 2021

arichardson added inline comments to D32052: tests: Test endian.h, byteswap.h, sys/endian.h and both endian.h and byteswap.h together.
Sep 22 2021, 1:21 PM
arichardson added inline comments to D32052: tests: Test endian.h, byteswap.h, sys/endian.h and both endian.h and byteswap.h together.
Sep 22 2021, 7:53 AM

Sep 20 2021

arichardson added inline comments to D32022: Update OptionalObsoleteFiles.inc after 021385aba562.
Sep 20 2021, 1:46 PM
arichardson updated the diff for D32022: Update OptionalObsoleteFiles.inc after 021385aba562.

Also add the manpages

Sep 20 2021, 11:38 AM
arichardson updated subscribers of D32022: Update OptionalObsoleteFiles.inc after 021385aba562.
Sep 20 2021, 8:50 AM
arichardson requested review of D32022: Update OptionalObsoleteFiles.inc after 021385aba562.
Sep 20 2021, 8:48 AM

Sep 14 2021

arichardson planned changes to D31382: lib/libc: Fix uninitialized value in __setenv().

Sounds good, happy to zero after realloc instead. Will update soon.

Sep 14 2021, 9:31 AM

Sep 13 2021

arichardson added a comment to D31382: lib/libc: Fix uninitialized value in __setenv().

Well ubsan is complaining that it loaded a value of 190 so that memory clearly wasn't zeroed.

Sep 13 2021, 9:06 PM
arichardson added a comment to D31927: Add -Wno-error=unused-but-set-variable when building with Clang 13+.
In D31927#720365, @dim wrote:

I did this slightly differently in https://github.com/DimitryAndric/freebsd-src/commit/73a8f96dc7c12ebf76f5a40a7f1208c11f75741f, and I put it in another if block. It would be nice to choose either my version or yours, and integrate it right away, so I don't get needless merge conflicts the next time I sync up the llvm-13-update branch with main.

Sep 13 2021, 12:57 PM
arichardson added a comment to D31927: Add -Wno-error=unused-but-set-variable when building with Clang 13+.

This change was sufficient to build and test amd64 with LLVM HEAD as of today.

Sep 13 2021, 12:30 PM
arichardson requested review of D31927: Add -Wno-error=unused-but-set-variable when building with Clang 13+.
Sep 13 2021, 12:29 PM
arichardson closed D31040: Add missing dep patterns for .pieo.
Sep 13 2021, 12:23 PM
arichardson committed R10:2d78130185b5: Add missing dep patterns for .pieo (authored by arichardson).
Add missing dep patterns for .pieo
Sep 13 2021, 12:23 PM
arichardson committed R10:d7d962ead0b6: Add a test for https://reviews.freebsd.org/D31858 (PR 258310) (authored by arichardson).
Add a test for https://reviews.freebsd.org/D31858 (PR 258310)
Sep 13 2021, 9:34 AM
arichardson closed D31862: Add a test for https://reviews.freebsd.org/D31858 (PR 258310).
Sep 13 2021, 9:33 AM
arichardson added reviewers for D31382: lib/libc: Fix uninitialized value in __setenv(): emaste, kib.
Sep 13 2021, 9:14 AM
arichardson accepted D31924: libprocstat: extend zfs_defs hack for .pieo.
Sep 13 2021, 9:13 AM
arichardson accepted D31920: bsd.lib.mk: add conditions for building _pie.a archives.

Seems reasonable to me. What is the motivating use case?

Sep 13 2021, 9:13 AM
arichardson added a comment to D31040: Add missing dep patterns for .pieo.

ping?

Sep 13 2021, 9:12 AM

Sep 9 2021

arichardson committed R10:395db99f32bc: Export _mmap and __sys_mmap from libc.so (authored by arichardson).
Export _mmap and __sys_mmap from libc.so
Sep 9 2021, 10:48 AM

Sep 7 2021

arichardson accepted D31874: cdefs.h: Remove redundant #ifdefs.
Sep 7 2021, 3:50 PM
arichardson added inline comments to D27743: Add aio_writev and aio_readv.
Sep 7 2021, 12:26 PM
arichardson committed R10:4a6bf977ac3e: Fix cross-builds after 4e5d32a445f90d37966cd6de571978551654e3f3 (authored by jlduran_gmail.com).
Fix cross-builds after 4e5d32a445f90d37966cd6de571978551654e3f3
Sep 7 2021, 9:58 AM
arichardson committed R10:94d9439b6be6: Fix cross-builds after 4e5d32a445f90d37966cd6de571978551654e3f3 (authored by jlduran_gmail.com).
Fix cross-builds after 4e5d32a445f90d37966cd6de571978551654e3f3
Sep 7 2021, 9:55 AM
arichardson updated the diff for D31862: Add a test for https://reviews.freebsd.org/D31858 (PR 258310).

Correct comment and drop $FreeBSD$ tags

Sep 7 2021, 9:33 AM

Sep 6 2021

arichardson accepted D31863: genoffset.sh: Use 10 X's instead of 5 for pick mkdtemp implementations.

LGTM. Possibly we should bootstrap the mkdtemp(3) sources rather than the host (glibc) ones to ensure all bootstrapped binaries behave the same way as they do on FreeBSD.

Sep 6 2021, 7:52 PM
arichardson added a comment to D31865: Fix powf()..

I agree, it would be very nice to add the values from the commit message to a test in lib/msun/tests. There's isn't a pow test yet, but one of the others could be used as a copy-paste starting point.

Sep 6 2021, 7:47 PM
arichardson accepted D31858: kqueue: drain kqueue taskqueue if syscall tickled it.

I can confirm this reliably fixes the test original test case (converted to ATF in D31862).
Code looks good to me, but since I'm not familiar with that part of the kernel I'd wait for @markj to review too.

Sep 6 2021, 3:22 PM
arichardson requested review of D31862: Add a test for https://reviews.freebsd.org/D31858 (PR 258310).
Sep 6 2021, 3:20 PM
arichardson added a comment to D31382: lib/libc: Fix uninitialized value in __setenv().

ping?

Sep 6 2021, 12:05 PM
arichardson retitled D31040: Add missing dep patterns for .pieo from Add missing dep patterns for .pieo and .nosspico to Add missing dep patterns for .pieo.
Sep 6 2021, 9:35 AM
arichardson updated the diff for D31040: Add missing dep patterns for .pieo.

Fix SOBJS->OBJS and modifying the wrong meta.* file

Sep 6 2021, 9:35 AM
arichardson committed R10:24f586182ff4: Enable MK_LLVM_BINUTILS if MK_ASAN is requested (authored by arichardson).
Enable MK_LLVM_BINUTILS if MK_ASAN is requested
Sep 6 2021, 9:26 AM
arichardson closed D31061: Enable MK_LLVM_BINUTILS if MK_ASAN is requested.
Sep 6 2021, 9:26 AM
arichardson closed D31060: Add WITH_LLVM_BINUTILS to install LLVM binutils instead of Elftoolchain.
Sep 6 2021, 9:25 AM