Differential D43236

tcp_wrappers: Use default C standard version
ClosedPublic
Actions

Authored by mchoo on Dec 29 2023, 9:43 PM.

Tags

Referenced Files

	F166294769: D43236.diff
	Wed, Aug 12, 5:34 PM

	F166283282: D43236.id149006.diff
	Wed, Aug 12, 4:43 PM

	Unknown Object (File)
	Wed, Aug 12, 6:29 AM

	Unknown Object (File)
	Mon, Aug 10, 10:11 PM

	Unknown Object (File)
	Mon, Aug 3, 7:42 AM

	Unknown Object (File)
	Mon, Aug 3, 6:16 AM

	Unknown Object (File)
	Mon, Aug 3, 3:41 AM

	Unknown Object (File)
	Sun, Aug 2, 1:37 AM

Subscribers

Contributor Reviews (src)

Details

Reviewers

emaste
mchoo
arichardson

Group Reviewers

Contributor Reviews (src)

Commits

rG880f1dee7ea2: tcp_wrappers: Use default C standard version
rG2cadbe468a8e: tcp_wrappers: Use default C standard version

Test Plan

cd /libexec/tcpd
make

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mchoo created this revision.Dec 29 2023, 9:43 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 29 2023, 9:43 PM

mchoo requested review of this revision.Dec 29 2023, 9:43 PM

Harbormaster completed remote builds in B55154: Diff 131986.Dec 29 2023, 9:43 PM

mchoo edited the test plan for this revision. (Show Details)Dec 29 2023, 9:44 PM

mchoo added a reviewer: Contributor Reviews (src).

mchoo added a project: Contributor Reviews (src).

mchoo added a subscriber: Contributor Reviews (src).

mchoo added a parent revision: D43237: Use gnu17 for buildworld.Dec 29 2023, 9:57 PM

Do you happen to have these changes available in a Git repo somewhere that I can pull from?

This revision is now accepted and ready to land.Dec 29 2023, 10:17 PM

emaste added inline comments.Dec 29 2023, 10:19 PM

contrib/tcp_wrappers/tcpd.c
48	style(9) has the function name start in column 1, int main(...

Fix function header accordign to style(9)

This revision now requires review to proceed.Dec 29 2023, 11:16 PM

Harbormaster completed remote builds in B55157: Diff 131999.Dec 29 2023, 11:16 PM

mchoo marked an inline comment as done.Dec 29 2023, 11:17 PM

In D43236#985438, @emaste wrote:

Do you happen to have these changes available in a Git repo somewhere that I can pull from?

I pushed this change to my Github repo

mchoo removed a parent revision: D43237: Use gnu17 for buildworld.Dec 30 2023, 5:26 AM

mchoo added a child revision: D43237: Use gnu17 for buildworld.

mchoo retitled this revision from tcp_wrappers: Use default C standard version for buildworld to tcp_wrappers: Use default C standard version.Dec 31 2023, 3:20 AM

mchoo mentioned this in D43237: Use gnu17 for buildworld.Dec 31 2023, 6:49 AM

Accepted earlier by @emaste .

This revision is now accepted and ready to land.Dec 31 2023, 4:30 PM

arichardson accepted this revision.Jan 29 2024, 11:59 PM

mchoo mentioned this in D43239: Use gnu17 for buildkernel.Jan 4 2025, 6:20 PM

Closed by commit rG2cadbe468a8e: tcp_wrappers: Use default C standard version (authored by mchoo, committed by jhb). · Explain WhyJan 9 2025, 6:10 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG2cadbe468a8e: tcp_wrappers: Use default C standard version.

mchoo removed a child revision: D43237: Use gnu17 for buildworld.Jan 9 2025, 7:56 PM

emaste added a commit: rG880f1dee7ea2: tcp_wrappers: Use default C standard version.Jan 24 2025, 7:51 PM

Revision Contents
Changeset List

Path

Size

contrib/

tcp_wrappers/

1 line

libexec/

tcpd/

1 line

Diff 149006

contrib/tcp_wrappers/tcpd.c

Loading...

libexec/tcpd/Makefile

Loading...