There is also https://reviews.freebsd.org/D28781.

In D28593#643293, @gbe wrote:

There is still the Makefile change missing.

@yuripv do you have any open issues for the man page?

I would approve it, but you have spend more time in reviewing it.

I'd rather not modify the contrib source, skip installing these, and use MLINKS instead.

some style.mdoc.5 cleanup

• only special case .Va after .It macro
• document the requirements in style.mdoc.5

With few fixes, don't use .Cm for arguments, don't add <> around arguments, and use .Nm Cm for subcommands.

Looks like usage message needs to be updated as well.

In D26966#618727, @pfg wrote:

In D26966#618725, @yuripv wrote:

Looks like export is only ever used in export_pam_environment(), where its return value is ignored.

Yes, I see :-/
So the change is useless, as are the checks for the pre-conditions.

It was really nice to see FreeBSD mentioned in a software security course though.

Looks like export is only ever used in export_pam_environment(), where its return value is ignored.

In D27623#617271, @0mp wrote:

Hmm, maybe it's better to keep the example shorter as in the err(3) manual page?

In D27623#617254, @0mp wrote:

@yuripv, let me know if that's a nice addition to the manual page or not. :) I understand it's basic stuff, but I feel like it's nice to show common patterns in a manual for reference.

As I was going through MFCing locale changes, I noticed one little (BIG) problem with this review/commit -- it forgot to actually install the updated sources to share/ subdirectories, so we currently ship what was previous version in share/.

In D17737#478038, @bapt wrote:

did you forget that one?

Committed in rS368390, not sure why phabricator didn't grok it.

• rewrite (actually copy and modify utf8-rollup.pl) mkwidths in perl, making it 300x faster compared to sh version
• add to README
• use pkgconf to get utf8proc cflags/libs

context

Thank you.

In D25640#567601, @pfg wrote:

LGTM however, I would recommend an exp-run. Many times before have sed changes caused trouble in the ports tree to be later reverted.

In D25398#560911, @pstef wrote:

It's not immediately obvious to me why rS29310 would render this a no-op, but I know that the use of ki_estcpu instead of ki_pctcpu is bogus for anything but the 4BSD scheduler.

remove debugging cruft