- User Since
- Aug 19 2018, 12:11 AM (68 w, 1 d)
Oct 28 2019
Oct 26 2019
Oct 19 2019
Oct 18 2019
Oct 10 2019
Oct 8 2019
Sep 30 2019
Sep 25 2019
Sep 24 2019
Warner, does this make sense to you/won't interfere with other changes you might be working on?
Sep 22 2019
Sep 19 2019
actually split the synopsis into separate options that can't be used together
As noted by @imp, there are better ways to do this.
Sep 16 2019
Sep 11 2019
Correct the .Fo field (remove *). Ingo did agree that .Fo (f) shouldn't trigger the warning and it will be supressed in the future. For the moment, we'll just have a non-fatal warning.
Sep 10 2019
- use sbuf functions
- also handle am_pm
- mark all keywords not specified by POSIX (e.g. abmon_1 through abmon_12, am_str, pm_str, ...) as local additions as other systems (at least Linux and Solaris) do not handle them
- add tests
Sep 9 2019
Sep 3 2019
Sep 2 2019
Aug 30 2019
Aug 29 2019
@ian I'm not sure if I should put you in 'submitted by' or 'reviewed by' line, you did both :)
Aug 28 2019
Feb 6 2019
@eadler any comments on this as you requested pre-commit review for top?
Jan 12 2019
@kevans any thoughts here? I'm still hesitant to add the symbol, so are you ok with the change only being in libc and libregex using the old behavior (strict character comparison instead of equivalence class)?
@imp anything else I need to change here?
Jan 2 2019
Are we *guaranteed* to have the floppy drives coming only at the start of the list?
Address comments from @imp.
-N doesn't need the -b bootnum.
Jan 1 2019
Drop the xlocale_private.h change, it's not really needed.
Dec 27 2018
Dec 25 2018
Dec 23 2018
Dec 22 2018
Dec 19 2018
Looks good to me, I have even applied the patch and tested some corner cases I could think of :-)
Dec 12 2018
@kevans are you OK with the test case added to libc/regex instead and using sed? :)
Dec 8 2018
Oops, I didn't mean to add Ed back to this review :-)
Reading through the discussion, I do agree with @ed -- we should have just one version in UTF-8, and convert to current encoding on the fly, though I do agree with @AMDmi3 as well -- making sure we use only the characters that can be converted to the related single-byte locale shouldn't be that hard, we don't need to use the fancy unicode chars in messages.
Sorry for the delay. I have spent quite a bit more time on this, including testing. Summary and the change updated accordingly.