Page MenuHomeFreeBSD

yuripv (Yuri Pankov)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2018, 12:11 AM (35 w, 6 h)

Recent Activity

Feb 6 2019

yuripv added a comment to D18705: efibootmgr: make generic usage message more readable.
In D18705#401939, @imp wrote:

This is fine, but there's a chance we'll rework the arg parsing in this program in the near future... Better to get this in now though.

Feb 6 2019, 4:04 AM
yuripv added a comment to D18658: top: fix PID sorting after r340742; add process birth time sorting.

@eadler any comments on this as you requested pre-commit review for top?

Feb 6 2019, 4:02 AM
yuripv committed rS343826: pwm.8: fix markup in synopsis, add -f description.
pwm.8: fix markup in synopsis, add -f description
Feb 6 2019, 4:00 AM
yuripv closed D18829: pwm.8: fix markup in synopsis, add -f description.
Feb 6 2019, 4:00 AM
yuripv closed D18830: pwm.9: fix markup in interfaces description.
Feb 6 2019, 3:58 AM
yuripv committed rS343825: pwm.9: fix markup in interfaces description.
pwm.9: fix markup in interfaces description
Feb 6 2019, 3:58 AM

Jan 12 2019

yuripv added a comment to D18531: PR208117: regex(3): implement equivalence classes.

@kevans any thoughts here? I'm still hesitant to add the symbol, so are you ok with the change only being in libc and libregex using the old behavior (strict character comparison instead of equivalence class)?

Jan 12 2019, 4:14 PM
yuripv added a comment to D18408: PR209468: aacraid fixes to work with newer controller firmware.

Hi @yuripv, are there plans to commit this?

Jan 12 2019, 4:12 PM
yuripv added a comment to D18705: efibootmgr: make generic usage message more readable.

@imp anything else I need to change here?

Jan 12 2019, 4:11 PM
yuripv created D18830: pwm.9: fix markup in interfaces description.
Jan 12 2019, 4:09 PM
yuripv created D18829: pwm.8: fix markup in synopsis, add -f description.
Jan 12 2019, 4:08 PM

Jan 2 2019

yuripv added a comment to D18723: biosdisk needs to use std probe for floppy devices.

Are we *guaranteed* to have the floppy drives coming only at the start of the list?

Jan 2 2019, 10:44 PM
yuripv added inline comments to D18705: efibootmgr: make generic usage message more readable.
Jan 2 2019, 4:46 PM
yuripv updated the diff for D18705: efibootmgr: make generic usage message more readable.

Address comments from @imp.

Jan 2 2019, 4:45 PM
yuripv added a comment to D18705: efibootmgr: make generic usage message more readable.

-N (delete BootNext) doesn’t require -b since it doesn’t operate on a bootnum.

Jan 2 2019, 2:54 PM
yuripv updated the diff for D18705: efibootmgr: make generic usage message more readable.

-N doesn't need the -b bootnum.

Jan 2 2019, 2:54 PM
yuripv edited reviewers for D18705: efibootmgr: make generic usage message more readable, added: bcran; removed: db.
Jan 2 2019, 1:35 PM

Jan 1 2019

yuripv updated the diff for D18531: PR208117: regex(3): implement equivalence classes.

Drop the xlocale_private.h change, it's not really needed.

Jan 1 2019, 7:40 AM
yuripv created D18705: efibootmgr: make generic usage message more readable.
Jan 1 2019, 6:32 AM

Dec 27 2018

yuripv added inline comments to D18658: top: fix PID sorting after r340742; add process birth time sorting.
Dec 27 2018, 9:03 PM

Dec 25 2018

yuripv accepted D18656: Bump sys_errlist size to keep ABI backward-compatible for some time..
Dec 25 2018, 3:58 PM
yuripv created D18658: top: fix PID sorting after r340742; add process birth time sorting.
Dec 25 2018, 3:42 PM
yuripv added inline comments to D18656: Bump sys_errlist size to keep ABI backward-compatible for some time..
Dec 25 2018, 3:39 PM
yuripv added inline comments to D18656: Bump sys_errlist size to keep ABI backward-compatible for some time..
Dec 25 2018, 3:02 PM
yuripv accepted D18656: Bump sys_errlist size to keep ABI backward-compatible for some time..
Dec 25 2018, 2:57 PM

Dec 23 2018

yuripv created D18636: ssh: revert to previous IPQoS options if running under VMware hypervisor.
Dec 23 2018, 11:35 AM

Dec 22 2018

yuripv added inline comments to D18531: PR208117: regex(3): implement equivalence classes.
Dec 22 2018, 1:29 AM

Dec 19 2018

yuripv added a comment to D18611: PR234066: jemalloc assertion failure in less.
In D18611#396895, @pfg wrote:

For the record: while it is good practice to request reviews before committing, IMHO they dont make much sense, and are not required at all, for reverts. After all they stand for things all the initial reviewers missed in the first place ;).

Dec 19 2018, 11:31 PM
yuripv committed rS342265: regcomp: revert part of r341838 which turned out to be unrelated.
regcomp: revert part of r341838 which turned out to be unrelated
Dec 19 2018, 11:29 PM
yuripv closed D18611: PR234066: jemalloc assertion failure in less.
Dec 19 2018, 11:29 PM
yuripv created D18611: PR234066: jemalloc assertion failure in less.
Dec 19 2018, 10:23 PM
yuripv accepted D18605: Allow multi-byte thousands separators in strfmon(3).

Looks good to me, I have even applied the patch and tested some corner cases I could think of :-)

Dec 19 2018, 6:31 PM

Dec 12 2018

yuripv added inline comments to D18531: PR208117: regex(3): implement equivalence classes.
Dec 12 2018, 4:31 PM
yuripv created D18531: PR208117: regex(3): implement equivalence classes.
Dec 12 2018, 4:28 PM
yuripv committed rS341838: regcomp: reduce size of bitmap for multibyte locales.
regcomp: reduce size of bitmap for multibyte locales
Dec 12 2018, 4:24 AM
yuripv closed D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.
Dec 12 2018, 4:24 AM
yuripv added a comment to D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.

@kevans are you OK with the test case added to libc/regex instead and using sed? :)

Dec 12 2018, 2:58 AM

Dec 8 2018

yuripv added a comment to D2232: Implement NLS catalog encoding conversion.

Oops, I didn't mean to add Ed back to this review :-)

Dec 8 2018, 9:16 PM
yuripv updated subscribers of D2232: Implement NLS catalog encoding conversion.
Dec 8 2018, 9:16 PM
yuripv updated subscribers of D2232: Implement NLS catalog encoding conversion.

Reading through the discussion, I do agree with @ed -- we should have just one version in UTF-8, and convert to current encoding on the fly, though I do agree with @AMDmi3 as well -- making sure we use only the characters that can be converted to the related single-byte locale shouldn't be that hard, we don't need to use the fancy unicode chars in messages.

Dec 8 2018, 9:15 PM
yuripv added inline comments to D18452: Add device_delete_children(9) manual page.
Dec 8 2018, 9:04 PM
yuripv committed rS341745: MFC r340835:.
MFC r340835:
Dec 8 2018, 7:45 PM
yuripv added a reviewer for D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range: bapt.
Dec 8 2018, 4:44 AM
yuripv updated the diff for D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.

Sorry for the delay. I have spent quite a bit more time on this, including testing. Summary and the change updated accordingly.

Dec 8 2018, 4:08 AM

Dec 6 2018

yuripv committed rS341639: syslog(3): stdarg.h is needed only for vsyslog().
syslog(3): stdarg.h is needed only for vsyslog()
Dec 6 2018, 6:03 PM
yuripv closed D18334: syslog(3): stdarg.h is needed only for vsyslog().
Dec 6 2018, 6:03 PM
yuripv added a comment to D18334: syslog(3): stdarg.h is needed only for vsyslog().

LGTM. Do you you need someone to commit this for you?

Dec 6 2018, 5:55 PM
yuripv committed rS341634: termcap: add italics and tmux entries.
termcap: add italics and tmux entries
Dec 6 2018, 1:46 PM
yuripv closed D18363: termcap: add italics and tmux entries.
Dec 6 2018, 1:46 PM
yuripv committed rS341631: MFC r339827:.
MFC r339827:
Dec 6 2018, 11:52 AM
yuripv committed rS341630: MFC r339311, r339313:.
MFC r339311, r339313:
Dec 6 2018, 11:50 AM
yuripv committed rS341629: MFC r340491, r340492:.
MFC r340491, r340492:
Dec 6 2018, 10:53 AM
yuripv committed rS341628: MFC r340204:.
MFC r340204:
Dec 6 2018, 10:49 AM
yuripv committed rS341627: MFC r340144:.
MFC r340144:
Dec 6 2018, 10:41 AM
yuripv committed rS341626: MFC r340128:.
MFC r340128:
Dec 6 2018, 9:52 AM
yuripv committed rS341625: MFC r340104:.
MFC r340104:
Dec 6 2018, 9:47 AM

Dec 5 2018

yuripv added a comment to D18408: PR209468: aacraid fixes to work with newer controller firmware.

With the comment updated, should I go ahead and commit this? Or we should still wait for actual reviews from @scottl and @mav?

Dec 5 2018, 10:19 PM
yuripv committed rS341597: Actually mark r341596 as MFC..
Actually mark r341596 as MFC.
Dec 5 2018, 5:16 PM
yuripv committed rS341596: MFC r339827:.
MFC r339827:
Dec 5 2018, 5:12 PM

Dec 3 2018

yuripv committed rS341446: mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs..
mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs.
Dec 3 2018, 10:33 PM
yuripv closed D18414: mkisoimages.sh: don't use -p flag for cp.
Dec 3 2018, 10:33 PM
yuripv updated the diff for D18408: PR209468: aacraid fixes to work with newer controller firmware.

Add the comment for msi_tupelo (and cleanup whitespace issues introduced by the patch).

Dec 3 2018, 7:39 PM
yuripv updated the test plan for D18408: PR209468: aacraid fixes to work with newer controller firmware.
Dec 3 2018, 11:53 AM
yuripv updated the test plan for D18408: PR209468: aacraid fixes to work with newer controller firmware.
Dec 3 2018, 11:50 AM
yuripv created D18414: mkisoimages.sh: don't use -p flag for cp.
Dec 3 2018, 6:58 AM

Dec 2 2018

yuripv added inline comments to rS334805: - Once we have shifted arguments up to thrice, base-bits-dir is $1 rather.
Dec 2 2018, 7:43 PM
yuripv updated the diff for D18408: PR209468: aacraid fixes to work with newer controller firmware.

Now with full context...

Dec 2 2018, 4:06 PM
yuripv created D18408: PR209468: aacraid fixes to work with newer controller firmware.
Dec 2 2018, 4:06 PM
yuripv committed rS340491: Use UnicodeData.txt to create UTF-8 ctype map..
Use UnicodeData.txt to create UTF-8 ctype map.
Dec 2 2018, 1:16 PM
yuripv closed D17842: use ctype data from UnicodeData.txt.

Done in rS340491.

Dec 2 2018, 1:15 PM

Nov 29 2018

yuripv committed rS341235: MFC r340976:.
MFC r340976:
Nov 29 2018, 3:08 PM
yuripv committed rS341234: MFC r340976:.
MFC r340976:
Nov 29 2018, 3:08 PM
yuripv committed rS341175: MFS12 r341168:.
MFS12 r341168:
Nov 29 2018, 1:31 AM
yuripv committed rS341168: MFC r340974:.
MFC r340974:
Nov 29 2018, 12:37 AM

Nov 28 2018

yuripv updated the diff for D18363: termcap: add italics and tmux entries.

diff with full context

Nov 28 2018, 12:08 AM
yuripv created D18363: termcap: add italics and tmux entries.
Nov 28 2018, 12:08 AM

Nov 26 2018

yuripv committed rS340992: Add ga_IE.UTF-8 locale..
Add ga_IE.UTF-8 locale.
Nov 26 2018, 7:40 PM
yuripv closed D17997: PR228587: Add ga_IE.UTF-8 locale.
Nov 26 2018, 7:40 PM
yuripv added a comment to D17950: PR202290: vi: fix illegal utf-8 sequence detection.

Upstream PR: https://github.com/lichray/nvi2/pull/61

Nov 26 2018, 3:44 PM
yuripv closed D17950: PR202290: vi: fix illegal utf-8 sequence detection.
Nov 26 2018, 3:34 PM
yuripv committed rS340976: vi: fix UTF-8 detection..
vi: fix UTF-8 detection.
Nov 26 2018, 3:34 PM
yuripv committed rS340974: bectl: sync usage with man page, removing stray multibyte characters.
bectl: sync usage with man page, removing stray multibyte characters
Nov 26 2018, 3:13 PM
yuripv closed D18335: sync bectl usage with man page.
Nov 26 2018, 3:13 PM
yuripv added a comment to D17950: PR202290: vi: fix illegal utf-8 sequence detection.
In D17950#389310, @bapt wrote:

as this been upstreamed? (https://github.com/lichray/nvi2)

Nov 26 2018, 8:34 AM
yuripv created D18335: sync bectl usage with man page.
Nov 26 2018, 7:42 AM
yuripv created D18334: syslog(3): stdarg.h is needed only for vsyslog().
Nov 26 2018, 12:15 AM

Nov 23 2018

yuripv added inline comments to D18309: llvm-objdump: initial man page.
Nov 23 2018, 4:15 PM
yuripv committed rS340835: regexec: fix processing multibyte strings..
regexec: fix processing multibyte strings.
Nov 23 2018, 3:49 PM
yuripv closed D18297: PR153502: [libc] regex(3) bug with UTF-8 locale.
Nov 23 2018, 3:49 PM
yuripv updated the diff for D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.

drop unrelated changes

Nov 23 2018, 11:46 AM
yuripv updated the diff for D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.

After providing the quick fix, I have started wondering how GNU grep (or libgnuregex, more precisely) does the matching without providing any locale specific data; the answer is pretty simple, not sure why I didn't think about it from the start -- fold the case of *both* sides of comparison, and compare both-upper and/or both-lower.

Nov 23 2018, 11:39 AM
yuripv added a comment to D18303: Rewrite ithread(9) man page.

Please submit diffs with full context.

Nov 23 2018, 10:52 AM
yuripv retitled D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range from regcomp() recuses infinitely on a case-insensitive pattern with unidirectional case-mappings to regcomp() recurses infinitely on a case-insensitive pattern with unidirectional case-mappings.
Nov 23 2018, 1:48 AM
yuripv created D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.
Nov 23 2018, 1:48 AM

Nov 22 2018

yuripv updated the diff for D18297: PR153502: [libc] regex(3) bug with UTF-8 locale.
Nov 22 2018, 10:09 PM
yuripv updated the diff for D18297: PR153502: [libc] regex(3) bug with UTF-8 locale.

typos.

Nov 22 2018, 10:04 PM
yuripv added a comment to D18297: PR153502: [libc] regex(3) bug with UTF-8 locale.
In D18297#388056, @pfg wrote:

I am not an expert on the area but I see where the comment comes from:

RFC3629 states on page 2:

The byte-value lexicographic sorting order of UTF-8 strings is the
same as if ordered by character numbers.  Of course this is of
limited interest since a sort order based on character numbers is
almost never culturally valid.
 
The Boyer-Moore fast search algorithm can be used with UTF-8 data.
Nov 22 2018, 10:02 PM
yuripv updated the diff for D18297: PR153502: [libc] regex(3) bug with UTF-8 locale.

redo.

Nov 22 2018, 10:01 PM
yuripv created D18297: PR153502: [libc] regex(3) bug with UTF-8 locale.
Nov 22 2018, 1:46 PM
yuripv abandoned D17449: PR227408: apropos(1) doesn't sort.

There's a reply and action upstream, the patch integrated there is more complete (removing all "bits" stuff from mansearch), will use that one.

Nov 22 2018, 1:19 PM