Page MenuHomeFreeBSD

yuripv (Yuri Pankov)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2018, 12:11 AM (16 w, 6 d)

Recent Activity

Wed, Dec 12

yuripv added inline comments to D18531: PR208117: regex(3): implement equivalence classes.
Wed, Dec 12, 4:31 PM
yuripv created D18531: PR208117: regex(3): implement equivalence classes.
Wed, Dec 12, 4:28 PM
yuripv committed rS341838: regcomp: reduce size of bitmap for multibyte locales.
regcomp: reduce size of bitmap for multibyte locales
Wed, Dec 12, 4:24 AM
yuripv closed D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.
Wed, Dec 12, 4:24 AM
yuripv added a comment to D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.

@kevans are you OK with the test case added to libc/regex instead and using sed? :)

Wed, Dec 12, 2:58 AM

Sat, Dec 8

yuripv added a comment to D2232: Implement NLS catalog encoding conversion.

Oops, I didn't mean to add Ed back to this review :-)

Sat, Dec 8, 9:16 PM
yuripv updated subscribers of D2232: Implement NLS catalog encoding conversion.
Sat, Dec 8, 9:16 PM
yuripv updated subscribers of D2232: Implement NLS catalog encoding conversion.

Reading through the discussion, I do agree with @ed -- we should have just one version in UTF-8, and convert to current encoding on the fly, though I do agree with @AMDmi3 as well -- making sure we use only the characters that can be converted to the related single-byte locale shouldn't be that hard, we don't need to use the fancy unicode chars in messages.

Sat, Dec 8, 9:15 PM
yuripv added inline comments to D18452: Add device_delete_children(9) manual page.
Sat, Dec 8, 9:04 PM
yuripv committed rS341745: MFC r340835:.
MFC r340835:
Sat, Dec 8, 7:45 PM
yuripv added a reviewer for D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range: bapt.
Sat, Dec 8, 4:44 AM
yuripv updated the diff for D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.

Sorry for the delay. I have spent quite a bit more time on this, including testing. Summary and the change updated accordingly.

Sat, Dec 8, 4:08 AM

Thu, Dec 6

yuripv committed rS341639: syslog(3): stdarg.h is needed only for vsyslog().
syslog(3): stdarg.h is needed only for vsyslog()
Thu, Dec 6, 6:03 PM
yuripv closed D18334: syslog(3): stdarg.h is needed only for vsyslog().
Thu, Dec 6, 6:03 PM
yuripv added a comment to D18334: syslog(3): stdarg.h is needed only for vsyslog().

LGTM. Do you you need someone to commit this for you?

Thu, Dec 6, 5:55 PM
yuripv committed rS341634: termcap: add italics and tmux entries.
termcap: add italics and tmux entries
Thu, Dec 6, 1:46 PM
yuripv closed D18363: termcap: add italics and tmux entries.
Thu, Dec 6, 1:46 PM
yuripv committed rS341631: MFC r339827:.
MFC r339827:
Thu, Dec 6, 11:52 AM
yuripv committed rS341630: MFC r339311, r339313:.
MFC r339311, r339313:
Thu, Dec 6, 11:50 AM
yuripv committed rS341629: MFC r340491, r340492:.
MFC r340491, r340492:
Thu, Dec 6, 10:53 AM
yuripv committed rS341628: MFC r340204:.
MFC r340204:
Thu, Dec 6, 10:49 AM
yuripv committed rS341627: MFC r340144:.
MFC r340144:
Thu, Dec 6, 10:41 AM
yuripv committed rS341626: MFC r340128:.
MFC r340128:
Thu, Dec 6, 9:52 AM
yuripv committed rS341625: MFC r340104:.
MFC r340104:
Thu, Dec 6, 9:47 AM

Wed, Dec 5

yuripv added a comment to D18408: PR209468: aacraid fixes to work with newer controller firmware.

With the comment updated, should I go ahead and commit this? Or we should still wait for actual reviews from @scottl and @mav?

Wed, Dec 5, 10:19 PM
yuripv committed rS341597: Actually mark r341596 as MFC..
Actually mark r341596 as MFC.
Wed, Dec 5, 5:16 PM
yuripv committed rS341596: MFC r339827:.
MFC r339827:
Wed, Dec 5, 5:12 PM

Mon, Dec 3

yuripv committed rS341446: mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs..
mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs.
Mon, Dec 3, 10:33 PM
yuripv closed D18414: mkisoimages.sh: don't use -p flag for cp.
Mon, Dec 3, 10:33 PM
yuripv updated the diff for D18408: PR209468: aacraid fixes to work with newer controller firmware.

Add the comment for msi_tupelo (and cleanup whitespace issues introduced by the patch).

Mon, Dec 3, 7:39 PM
yuripv updated the test plan for D18408: PR209468: aacraid fixes to work with newer controller firmware.
Mon, Dec 3, 11:53 AM
yuripv updated the test plan for D18408: PR209468: aacraid fixes to work with newer controller firmware.
Mon, Dec 3, 11:50 AM
yuripv created D18414: mkisoimages.sh: don't use -p flag for cp.
Mon, Dec 3, 6:58 AM

Sun, Dec 2

yuripv added inline comments to rS334805: - Once we have shifted arguments up to thrice, base-bits-dir is $1 rather.
Sun, Dec 2, 7:43 PM
yuripv updated the diff for D18408: PR209468: aacraid fixes to work with newer controller firmware.

Now with full context...

Sun, Dec 2, 4:06 PM
yuripv created D18408: PR209468: aacraid fixes to work with newer controller firmware.
Sun, Dec 2, 4:06 PM
yuripv committed rS340491: Use UnicodeData.txt to create UTF-8 ctype map..
Use UnicodeData.txt to create UTF-8 ctype map.
Sun, Dec 2, 1:16 PM
yuripv closed D17842: use ctype data from UnicodeData.txt.

Done in rS340491.

Sun, Dec 2, 1:15 PM

Thu, Nov 29

yuripv committed rS341235: MFC r340976:.
MFC r340976:
Thu, Nov 29, 3:08 PM
yuripv committed rS341234: MFC r340976:.
MFC r340976:
Thu, Nov 29, 3:08 PM
yuripv committed rS341175: MFS12 r341168:.
MFS12 r341168:
Thu, Nov 29, 1:31 AM
yuripv committed rS341168: MFC r340974:.
MFC r340974:
Thu, Nov 29, 12:37 AM

Wed, Nov 28

yuripv updated the diff for D18363: termcap: add italics and tmux entries.

diff with full context

Wed, Nov 28, 12:08 AM
yuripv created D18363: termcap: add italics and tmux entries.
Wed, Nov 28, 12:08 AM

Mon, Nov 26

yuripv committed rS340992: Add ga_IE.UTF-8 locale..
Add ga_IE.UTF-8 locale.
Mon, Nov 26, 7:40 PM
yuripv closed D17997: PR228587: Add ga_IE.UTF-8 locale.
Mon, Nov 26, 7:40 PM
yuripv added a comment to D17950: PR202290: vi: fix illegal utf-8 sequence detection.

Upstream PR: https://github.com/lichray/nvi2/pull/61

Mon, Nov 26, 3:44 PM
yuripv closed D17950: PR202290: vi: fix illegal utf-8 sequence detection.
Mon, Nov 26, 3:34 PM
yuripv committed rS340976: vi: fix UTF-8 detection..
vi: fix UTF-8 detection.
Mon, Nov 26, 3:34 PM
yuripv committed rS340974: bectl: sync usage with man page, removing stray multibyte characters.
bectl: sync usage with man page, removing stray multibyte characters
Mon, Nov 26, 3:13 PM
yuripv closed D18335: sync bectl usage with man page.
Mon, Nov 26, 3:13 PM
yuripv added a comment to D17950: PR202290: vi: fix illegal utf-8 sequence detection.
In D17950#389310, @bapt wrote:

as this been upstreamed? (https://github.com/lichray/nvi2)

Mon, Nov 26, 8:34 AM
yuripv created D18335: sync bectl usage with man page.
Mon, Nov 26, 7:42 AM
yuripv created D18334: syslog(3): stdarg.h is needed only for vsyslog().
Mon, Nov 26, 12:15 AM

Fri, Nov 23

yuripv added inline comments to D18309: llvm-objdump: initial man page.
Fri, Nov 23, 4:15 PM
yuripv committed rS340835: regexec: fix processing multibyte strings..
regexec: fix processing multibyte strings.
Fri, Nov 23, 3:49 PM
yuripv closed D18297: PR153502: [libc] regex(3) bug with UTF-8 locale.
Fri, Nov 23, 3:49 PM
yuripv updated the diff for D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.

drop unrelated changes

Fri, Nov 23, 11:46 AM
yuripv updated the diff for D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.

After providing the quick fix, I have started wondering how GNU grep (or libgnuregex, more precisely) does the matching without providing any locale specific data; the answer is pretty simple, not sure why I didn't think about it from the start -- fold the case of *both* sides of comparison, and compare both-upper and/or both-lower.

Fri, Nov 23, 11:39 AM
yuripv added a comment to D18303: Rewrite ithread(9) man page.

Please submit diffs with full context.

Fri, Nov 23, 10:52 AM
yuripv retitled D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range from regcomp() recuses infinitely on a case-insensitive pattern with unidirectional case-mappings to regcomp() recurses infinitely on a case-insensitive pattern with unidirectional case-mappings.
Fri, Nov 23, 1:48 AM
yuripv created D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.
Fri, Nov 23, 1:48 AM

Thu, Nov 22

yuripv updated the diff for D18297: PR153502: [libc] regex(3) bug with UTF-8 locale.
Thu, Nov 22, 10:09 PM
yuripv updated the diff for D18297: PR153502: [libc] regex(3) bug with UTF-8 locale.

typos.

Thu, Nov 22, 10:04 PM
yuripv added a comment to D18297: PR153502: [libc] regex(3) bug with UTF-8 locale.
In D18297#388056, @pfg wrote:

I am not an expert on the area but I see where the comment comes from:

RFC3629 states on page 2:

The byte-value lexicographic sorting order of UTF-8 strings is the
same as if ordered by character numbers.  Of course this is of
limited interest since a sort order based on character numbers is
almost never culturally valid.
 
The Boyer-Moore fast search algorithm can be used with UTF-8 data.
Thu, Nov 22, 10:02 PM
yuripv updated the diff for D18297: PR153502: [libc] regex(3) bug with UTF-8 locale.

redo.

Thu, Nov 22, 10:01 PM
yuripv created D18297: PR153502: [libc] regex(3) bug with UTF-8 locale.
Thu, Nov 22, 1:46 PM
yuripv abandoned D17449: PR227408: apropos(1) doesn't sort.

There's a reply and action upstream, the patch integrated there is more complete (removing all "bits" stuff from mansearch), will use that one.

Thu, Nov 22, 1:19 PM

Wed, Nov 21

yuripv added inline comments to D18036: Fix style nits in strings.
Wed, Nov 21, 10:05 PM

Sat, Nov 17

yuripv committed rS340492: Make mbstowcs_basic test pass, now that we have more ctype definitions..
Make mbstowcs_basic test pass, now that we have more ctype definitions.
Sat, Nov 17, 1:00 PM

Thu, Nov 15

yuripv created D17997: PR228587: Add ga_IE.UTF-8 locale.
Thu, Nov 15, 4:43 PM

Nov 14 2018

yuripv added inline comments to D17973: Fix /etc/ntp mode.
Nov 14 2018, 4:31 PM
yuripv added a comment to D17842: use ctype data from UnicodeData.txt.

Baptiste, anything else you want to see done/answered for this to proceed?

Nov 14 2018, 1:46 PM
yuripv committed rS340429: Fix WITHOUT_ICONV build after r340276..
Fix WITHOUT_ICONV build after r340276.
Nov 14 2018, 9:06 AM

Nov 13 2018

yuripv added a comment to D17449: PR227408: apropos(1) doesn't sort.
In D17449#375264, @bapt wrote:

First we should ship the said manpage :)

I think this is debattable, but I think upstream is opened enought to accept such change, you should anyway talk to them to see if that will remain a freebsd only patch or not :)

OK, will do.

Nov 13 2018, 9:39 AM

Nov 11 2018

yuripv created D17950: PR202290: vi: fix illegal utf-8 sequence detection.
Nov 11 2018, 9:49 PM
yuripv committed rS340354: Use blank am_pm and t_fmt_ampm for de_AT and de_DE locales as apparently.
Use blank am_pm and t_fmt_ampm for de_AT and de_DE locales as apparently
Nov 11 2018, 1:41 PM
yuripv closed D17945: PR231771: remove am/pm from German locales.
Nov 11 2018, 1:41 PM
yuripv created D17945: PR231771: remove am/pm from German locales.
Nov 11 2018, 12:11 PM

Nov 9 2018

yuripv accepted D17903: [libedit] enhance multibyte support.
Nov 9 2018, 10:16 PM
yuripv added a comment to D17842: use ctype data from UnicodeData.txt.
In D17842#382775, @bapt wrote:

That look sane to me, the thing is I wonder how hard it would be to maintain

Nov 9 2018, 3:15 PM
yuripv added inline comments to D17903: [libedit] enhance multibyte support.
Nov 9 2018, 12:39 PM
yuripv added inline comments to D17903: [libedit] enhance multibyte support.
Nov 9 2018, 12:24 PM
yuripv committed rS340276: Reset persistent mbstates when rune locale encoding changes..
Reset persistent mbstates when rune locale encoding changes.
Nov 9 2018, 3:33 AM
yuripv closed D17796: locale: persistent mbstates should be reset when rune locale changes.
Nov 9 2018, 3:33 AM

Nov 8 2018

yuripv added a comment to D17903: [libedit] enhance multibyte support.

I think this makes perfect sense. You might want to update editline(3) as well so it doesn't say it only knows about UTF-8 and C locales.

Nov 8 2018, 11:00 PM
yuripv added reviewers for D17903: [libedit] enhance multibyte support: bapt, jilles.
Nov 8 2018, 10:59 PM

Nov 7 2018

yuripv updated the summary of D17842: use ctype data from UnicodeData.txt.
Nov 7 2018, 12:16 AM
yuripv updated the diff for D17842: use ctype data from UnicodeData.txt.

cleanup done separately; rebase

Nov 7 2018, 12:12 AM

Nov 6 2018

yuripv committed rS340204: Cleanup locale tools:.
Cleanup locale tools:
Nov 6 2018, 9:50 PM
yuripv closed D17858: cleanup locale tools.
Nov 6 2018, 9:50 PM
yuripv created D17859: undocument isideogram, isphonogram, isspecial, and friends.
Nov 6 2018, 4:56 AM
yuripv updated the diff for D17858: cleanup locale tools.
Nov 6 2018, 1:46 AM
yuripv created D17858: cleanup locale tools.
Nov 6 2018, 1:31 AM

Nov 5 2018

yuripv updated the summary of D17842: use ctype data from UnicodeData.txt.
Nov 5 2018, 9:41 AM
yuripv created D17842: use ctype data from UnicodeData.txt.
Nov 5 2018, 9:35 AM

Nov 4 2018

yuripv committed rS340144: Add hybrid C.UTF-8 locale being identical to default C locale except.
Add hybrid C.UTF-8 locale being identical to default C locale except
Nov 4 2018, 10:13 PM
yuripv closed D17833: introduce C.UTF-8 locale.
Nov 4 2018, 10:13 PM
yuripv added a comment to D17833: introduce C.UTF-8 locale.

Just for the note: perl bits here are only the helper tools for someone updating the locale sources in share/, and aren't run during the build, so even if something is broken there (and I tried not to as I used them), it's only bad until there's a need to update the data again where they will be fixed anyway :)

Nov 4 2018, 6:04 PM
yuripv committed rS340128: Teach man(1) about C.UTF-8..
Teach man(1) about C.UTF-8.
Nov 4 2018, 4:59 PM