- User Since
- Aug 19 2018, 12:11 AM (35 w, 6 h)
Feb 6 2019
@eadler any comments on this as you requested pre-commit review for top?
Jan 12 2019
@kevans any thoughts here? I'm still hesitant to add the symbol, so are you ok with the change only being in libc and libregex using the old behavior (strict character comparison instead of equivalence class)?
@imp anything else I need to change here?
Jan 2 2019
Are we *guaranteed* to have the floppy drives coming only at the start of the list?
Address comments from @imp.
-N doesn't need the -b bootnum.
Jan 1 2019
Drop the xlocale_private.h change, it's not really needed.
Dec 27 2018
Dec 25 2018
Dec 23 2018
Dec 22 2018
Dec 19 2018
Looks good to me, I have even applied the patch and tested some corner cases I could think of :-)
Dec 12 2018
@kevans are you OK with the test case added to libc/regex instead and using sed? :)
Dec 8 2018
Oops, I didn't mean to add Ed back to this review :-)
Reading through the discussion, I do agree with @ed -- we should have just one version in UTF-8, and convert to current encoding on the fly, though I do agree with @AMDmi3 as well -- making sure we use only the characters that can be converted to the related single-byte locale shouldn't be that hard, we don't need to use the fancy unicode chars in messages.
Sorry for the delay. I have spent quite a bit more time on this, including testing. Summary and the change updated accordingly.
Dec 6 2018
Dec 5 2018
Dec 3 2018
Add the comment for msi_tupelo (and cleanup whitespace issues introduced by the patch).
Dec 2 2018
Now with full context...
Nov 29 2018
Nov 28 2018
diff with full context
Nov 26 2018
Upstream PR: https://github.com/lichray/nvi2/pull/61
Nov 23 2018
drop unrelated changes
After providing the quick fix, I have started wondering how GNU grep (or libgnuregex, more precisely) does the matching without providing any locale specific data; the answer is pretty simple, not sure why I didn't think about it from the start -- fold the case of *both* sides of comparison, and compare both-upper and/or both-lower.
Please submit diffs with full context.
Nov 22 2018