Page MenuHomeFreeBSD

yuripv (Yuri Pankov)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2018, 12:11 AM (307 w, 5 d)

Recent Activity

Jan 20 2024

yuripv added inline comments to D43518: Implement kcmp(2).
Jan 20 2024, 4:42 AM

Dec 22 2023

yuripv committed rG8f7ed58a1555: regex: mixed sets are misidentified as singletons (authored by Bill Sommerfeld <sommerfeld@hamachi.org>).
regex: mixed sets are misidentified as singletons
Dec 22 2023, 5:22 AM
yuripv closed D43149: regex: mixed sets are misidentified as singletons.
Dec 22 2023, 5:21 AM

Dec 21 2023

yuripv updated the diff for D43149: regex: mixed sets are misidentified as singletons.

Rework test case

Dec 21 2023, 5:58 AM
yuripv added inline comments to D43149: regex: mixed sets are misidentified as singletons.
Dec 21 2023, 5:57 AM
yuripv requested review of D43149: regex: mixed sets are misidentified as singletons.
Dec 21 2023, 3:58 AM

Dec 20 2023

yuripv added a reverting change for rGa4a9d2a64a4d: locale: regenerate SJIS charmap from CLDR: rG7d413ee80522: Revert "locale: regenerate SJIS charmap from CLDR".
Dec 20 2023, 7:16 AM
yuripv committed rG7d413ee80522: Revert "locale: regenerate SJIS charmap from CLDR" (authored by yuripv).
Revert "locale: regenerate SJIS charmap from CLDR"
Dec 20 2023, 7:16 AM
yuripv added a reverting change for D42848: locale: regenerate SJIS charmap from CLDR: rG7d413ee80522: Revert "locale: regenerate SJIS charmap from CLDR".
Dec 20 2023, 7:15 AM
yuripv committed rGa4a9d2a64a4d: locale: regenerate SJIS charmap from CLDR (authored by yuripv).
locale: regenerate SJIS charmap from CLDR
Dec 20 2023, 6:28 AM
yuripv closed D42848: locale: regenerate SJIS charmap from CLDR.
Dec 20 2023, 6:28 AM

Nov 30 2023

yuripv requested review of D42848: locale: regenerate SJIS charmap from CLDR.
Nov 30 2023, 9:12 AM

Nov 28 2023

yuripv committed rG5b4b93e6074c: msgdef: fix NO and SI locales (authored by yuripv).
msgdef: fix NO and SI locales
Nov 28 2023, 8:06 AM

Sep 26 2023

yuripv added a comment to D41983: localedef: extract ctype defs from _ctype.h instead of including it.

You could push to a GitHub fork, then it will run the bootstrap steps as part of the GitHub action

Sep 26 2023, 5:54 PM
yuripv added a comment to D41927: locale: use per-thread-locale's __mb_sb_limit.
In D41927#956266, @kib wrote:
In D41927#956261, @kib wrote:

I do not know much about runes/locales either.

I'm not that worried about the fix itself, more about adding the public symbol to libc, and wanted to hear from you if this is acceptable.

If the symbol is needed, why not? The concern is that we must support it forever, with the same or compatible semantic. But then again, this is the question for the locale code maintenance.

Sep 26 2023, 4:12 PM
yuripv requested review of D41985: isctype: use per-thread-locale's __mb_sb_limit.
Sep 26 2023, 4:11 PM
yuripv added a comment to D41983: localedef: extract ctype defs from _ctype.h instead of including it.

This will almost certainly break the cross build. The typedefs in the local _ctype.h are needed. Can you modify that file to include the new generated header?

Yep, I am working on getting cross-build, but I don't see why it would break though, nothing in ctype.c uses those types and we are not including/using the is*() functions.

Sep 26 2023, 2:09 PM
yuripv added a comment to D41983: localedef: extract ctype defs from _ctype.h instead of including it.

This will almost certainly break the cross build. The typedefs in the local _ctype.h are needed. Can you modify that file to include the new generated header?

Sep 26 2023, 1:51 PM
yuripv requested review of D41983: localedef: extract ctype defs from _ctype.h instead of including it.
Sep 26 2023, 11:46 AM

Sep 25 2023

yuripv added inline comments to D41851: virtio: start simple, document virtio_endian(9).
Sep 25 2023, 11:57 PM · manpages
yuripv added inline comments to D41887: domain(9): better link functions to implement a protosw.
Sep 25 2023, 11:32 PM · manpages
yuripv added inline comments to D41949: mailmap: Add pstef and val.
Sep 25 2023, 11:28 PM
yuripv committed rG3fb80f1476c7: regcomp: use unsigned char when testing for escapes (authored by christos_netbsd.org).
regcomp: use unsigned char when testing for escapes
Sep 25 2023, 10:53 PM
yuripv closed D41947: regcomp: use unsigned char when testing for escapes.
Sep 25 2023, 10:52 PM
yuripv updated the diff for D41947: regcomp: use unsigned char when testing for escapes.

Apparently NetBSD has a bit more complete fix for this (thanks Kyle), use it instead.

Sep 25 2023, 10:18 PM

Sep 23 2023

yuripv added inline comments to D41947: regcomp: use unsigned char when testing for escapes.
Sep 23 2023, 8:43 PM
yuripv added a comment to D41927: locale: use per-thread-locale's __mb_sb_limit.
In D41927#956261, @kib wrote:

I do not know much about runes/locales either.

Sep 23 2023, 10:24 AM
yuripv updated the summary of D41947: regcomp: use unsigned char when testing for escapes.
Sep 23 2023, 10:04 AM
yuripv requested review of D41947: regcomp: use unsigned char when testing for escapes.
Sep 23 2023, 9:54 AM

Sep 22 2023

yuripv updated the diff for D41927: locale: use per-thread-locale's __mb_sb_limit.
  • Versions.def updated in separate commit
  • drop extern as suggested by Konstantin
Sep 22 2023, 9:36 AM
yuripv committed rG95a4709b2cca: Create namespace for the symbols added during 15-CURRENT cycle (authored by yuripv).
Create namespace for the symbols added during 15-CURRENT cycle
Sep 22 2023, 8:20 AM
yuripv closed D41935: Create namespace for the symbols added during 15-CURRENT cycle.
Sep 22 2023, 8:19 AM
yuripv requested review of D41935: Create namespace for the symbols added during 15-CURRENT cycle.
Sep 22 2023, 8:00 AM
yuripv retitled D41927: locale: use per-thread-locale's __mb_sb_limit from pr265950 draft to locale: use per-thread-locale's __mb_sb_limit.
Sep 22 2023, 12:15 AM
yuripv updated the summary of D41927: locale: use per-thread-locale's __mb_sb_limit.
Sep 22 2023, 12:15 AM
yuripv updated the diff for D41927: locale: use per-thread-locale's __mb_sb_limit.

complete change (except for linux cross build testing)

Sep 22 2023, 12:14 AM

Sep 21 2023

yuripv committed rG7431b9928946: .mailmap: normalize Mina's name in correct email case as well (authored by yuripv).
.mailmap: normalize Mina's name in correct email case as well
Sep 21 2023, 9:32 PM
yuripv added a comment to D41931: Add .mailmap to correct some author data.

As discussed with Mina on IRC, entries with correct email but missing accent in surname need to be normalized as well, i.e.

diff --git a/.mailmap b/.mailmap
index 3760aeece44..1f27f22efdb 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1,5 +1,6 @@
 <ehem+freebsd@m5p.com> <ehem_freebsd_m5p.com>
 <ehem+freebsd@m5p.com> <ehem_freebsd@m5p.com>
+Mina Galić <freebsd@igalic.co> <freebsd@igalic.co>
 Mina Galić <freebsd@igalic.co> <freebsd_igalic.co>
 Mina Galić <freebsd@igalic.co> <me_igalic.co>
 Mina Galić <freebsd@igalic.co> <me@igalic.co>
Sep 21 2023, 9:14 PM
yuripv committed rG159599c4a2bb: msgdef: fix NO and SI locales (authored by yuripv).
msgdef: fix NO and SI locales
Sep 21 2023, 10:55 AM
yuripv closed D41899: msgdef: fix NO and SI locales.
Sep 21 2023, 10:55 AM
yuripv requested review of D41927: locale: use per-thread-locale's __mb_sb_limit.
Sep 21 2023, 1:39 AM

Sep 20 2023

yuripv committed rGa4916232acd6: libc: use separate collate objects for C, POSIX, and C.UTF-8 (authored by yuripv).
libc: use separate collate objects for C, POSIX, and C.UTF-8
Sep 20 2023, 1:26 PM

Sep 18 2023

yuripv updated the diff for D41899: msgdef: fix NO and SI locales.

(re)generate nn_NO.ISO8859-15 from CLDR

Sep 18 2023, 9:46 AM
yuripv added a comment to D41899: msgdef: fix NO and SI locales.
In D41899#954906, @imp wrote:

Though nynorsk and bokmal aren't quite the same, this does fix the circular issue. And the two are close enough.

Sep 18 2023, 9:45 AM
yuripv requested review of D41899: msgdef: fix NO and SI locales.
Sep 18 2023, 12:30 AM

Sep 5 2023

yuripv accepted D41692: localedef: expand the default charmap.
Sep 5 2023, 5:02 AM

Sep 4 2023

yuripv added a comment to D41692: localedef: expand the default charmap.

Just wondering what triggered this change, i.e. does it fix any known issues?

Sep 4 2023, 7:12 AM

Sep 2 2023

yuripv accepted D41693: localedef: add newlines to error messages.
Sep 2 2023, 10:08 AM

Aug 5 2023

yuripv added a comment to D41329: cdefs.h: unbreak linker sets for gcc.
Aug 5 2023, 11:50 AM
yuripv added a comment to D41329: cdefs.h: unbreak linker sets for gcc.

Ok, I think I understand what's going on here. Does https://termbin.com/895q resolve the issue instead for you? That's what we're actually trying to do here, I think.

The following part from your patch is enough to unbreak gcc and is exactly what the patch here does:

--- a/sys/sys/linker_set.h
+++ b/sys/sys/linker_set.h
@@ -66,8 +66,8 @@
 #endif
 
 #define __MAKE_SET_QV(set, sym, qv)			\
-	__WEAK(__CONCAT(__start_set_,set));		\
-	__WEAK(__CONCAT(__stop_set_,set));		\
+	__GLOBL(__CONCAT(__start_set_,set));		\
+	__GLOBL(__CONCAT(__stop_set_,set));		\
 	static void const * qv				\
 	__NOASAN					\
 	__set_##set##_sym_##sym __section("set_" #set)	\

I know, but it's bogus to mix things like this. There's a lot of detail in all this that you're glossing over by just doing that. You need the rest to make it less fragile in corner cases, and of course to make it work for both LLVM's assembler and binutil's.

Aug 5 2023, 8:21 AM
yuripv added a comment to D41329: cdefs.h: unbreak linker sets for gcc.

Ok, I think I understand what's going on here. Does https://termbin.com/895q resolve the issue instead for you? That's what we're actually trying to do here, I think.

Aug 5 2023, 8:08 AM
yuripv added a comment to D41329: cdefs.h: unbreak linker sets for gcc.

Ok, I think I understand what's going on here. Does https://termbin.com/895q resolve the issue instead for you? That's what we're actually trying to do here, I think.

Aug 5 2023, 7:57 AM
yuripv requested review of D41329: cdefs.h: unbreak linker sets for gcc.
Aug 5 2023, 12:42 AM

Aug 4 2023

yuripv closed D41151: locale: update to CLDR 43 and Unicode 15.

Committed in rGb306c604df541dede4d0f3cc96188bbf5b6719fe.

Aug 4 2023, 10:43 AM
yuripv added a comment to D41151: locale: update to CLDR 43 and Unicode 15.

Hmm, this doesn't seem to be automatically closed on commit.

Aug 4 2023, 10:33 AM
yuripv committed rGdd3055a75f3f: OptionalObsoleteFiles: add missed keymaps for sycons (authored by yuripv).
OptionalObsoleteFiles: add missed keymaps for sycons
Aug 4 2023, 10:10 AM
yuripv committed rGb306c604df54: locale: update to CLDR 43 and Unicode 15 (authored by yuripv).
locale: update to CLDR 43 and Unicode 15
Aug 4 2023, 9:09 AM

Jul 26 2023

yuripv committed rGbb255cee9382: tzsetup: fix "misleading indentation" warning with -DVERBOSE (authored by yuripv).
tzsetup: fix "misleading indentation" warning with -DVERBOSE
Jul 26 2023, 10:36 AM

Jul 22 2023

yuripv requested review of D41151: locale: update to CLDR 43 and Unicode 15.
Jul 22 2023, 9:23 AM

Jul 19 2023

yuripv added inline comments to D41063: libsysdecode: add zfs iocs.
Jul 19 2023, 1:36 PM
yuripv added inline comments to D41063: libsysdecode: add zfs iocs.
Jul 19 2023, 7:40 AM

Jul 18 2023

yuripv updated the diff for D41063: libsysdecode: add zfs iocs.

add some \n's

Jul 18 2023, 3:03 PM
yuripv updated the test plan for D41063: libsysdecode: add zfs iocs.
Jul 18 2023, 12:55 PM
yuripv requested review of D41063: libsysdecode: add zfs iocs.
Jul 18 2023, 12:51 PM
yuripv committed rGb36f469a15ec: zfs: set autotrim default to 'off' (authored by yuripv).
zfs: set autotrim default to 'off'
Jul 18 2023, 9:22 AM
yuripv closed D41056: zfs: set autotrim default to 'off'.
Jul 18 2023, 9:21 AM

Jul 17 2023

yuripv added a comment to D41056: zfs: set autotrim default to 'off'.
In D41056#934733, @mav wrote:

I like removal of IN_FREEBSD_BASE. I would be happy if autotrim was enabled by default, but if it wasn't for some time, then I see no problem to clean this up. I just wonder how long it was broken. Respective part of the patch will need to be upstreamed to OpenZFS also, may be in parallel to make sure more people are in sync about it.

Jul 17 2023, 3:04 PM
yuripv added inline comments to D40874: kinst.4: update man page.
Jul 17 2023, 2:38 PM
yuripv updated the summary of D41056: zfs: set autotrim default to 'off'.
Jul 17 2023, 9:31 AM
yuripv requested review of D41056: zfs: set autotrim default to 'off'.
Jul 17 2023, 9:28 AM

Jun 29 2023

yuripv added a comment to D40075: openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h.

Sadly, I had to revert this, with all these defines being ambiguously named I missed the fact that IN_BASE is only used in FreeBSD-specific code to signify userland/kernel differences, while IN_FREEBSD_BASE really means FreeBSD-specific code inside the common code. Will need to think more about proper approach (and naming?) here.

Jun 29 2023, 9:09 PM
yuripv added a reverting change for D40075: openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h: rGaf2939f227db: Revert "openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h".
Jun 29 2023, 9:07 PM
yuripv added a reverting change for rGd2a45e9e817a: openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h: rGaf2939f227db: Revert "openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h".
Jun 29 2023, 9:07 PM
yuripv committed rGaf2939f227db: Revert "openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h" (authored by yuripv).
Revert "openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h"
Jun 29 2023, 9:07 PM
yuripv closed D40075: openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h.
Jun 29 2023, 8:18 PM
yuripv committed rGd2a45e9e817a: openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h (authored by yuripv).
openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h
Jun 29 2023, 8:18 PM
yuripv committed rG24ec316c13bd: Correctly spell illumos (all lowercase) in man pages (authored by yuripv).
Correctly spell illumos (all lowercase) in man pages
Jun 29 2023, 11:49 AM

Jun 28 2023

yuripv added inline comments to D40690: setclasspriority(): New value 'inherit'.
Jun 28 2023, 10:43 AM
yuripv added inline comments to D40691: login.conf(5): Document priority's special value 'inherit'.
Jun 28 2023, 10:39 AM

Jun 19 2023

yuripv accepted D40601: seq: fix check for rounding error/truncation.
Jun 19 2023, 11:10 AM

May 30 2023

yuripv added inline comments to D40236: Fix NULL deref in ip_output during route change.
May 30 2023, 7:09 PM

May 23 2023

yuripv added inline comments to D40206: bectl.8: update /home.
May 23 2023, 4:10 PM

May 13 2023

yuripv updated the diff for D40075: openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h.

modify spa.h instead as proposed by Warner

May 13 2023, 5:08 PM

May 12 2023

yuripv added a comment to D40075: openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h.

re: stand, I don't see a call to zpool_prop_init() in there anywhere, zpool_prop.c does not seem to be compiled as well; am I missing something obvious?

May 12 2023, 10:09 AM
yuripv added inline comments to D40074: vmm(4): document maxcpu tunable.
May 12 2023, 9:18 AM
yuripv added a comment to D40075: openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h.

I *guess* it was done this way as it's the only FreeBSD-specific part in the "common" code, and everything using IN_BASE is located under sys/contrib/openzfs/lib/libzfs/os/freebsd and sys/contrib/openzfs/include/os/freebsd proper.

May 12 2023, 9:10 AM
yuripv requested review of D40075: openzfs: use IN_BASE instead of IN_FREEBSD_BASE in spa.h.
May 12 2023, 12:09 AM

May 11 2023

yuripv requested review of D40074: vmm(4): document maxcpu tunable.
May 11 2023, 9:51 PM

May 10 2023

yuripv accepted D40051: md5: Add missing <errno.h>..
May 10 2023, 7:08 PM

May 9 2023

yuripv accepted D40018: md5: Include <osreldate.h> for __FreeBSD_version..
May 9 2023, 4:41 PM
yuripv added inline comments to D40018: md5: Include <osreldate.h> for __FreeBSD_version..
May 9 2023, 12:02 PM
yuripv abandoned D40015: md5: attempt fixing cross-builds in github ci.
May 9 2023, 12:01 PM
yuripv closed D39999: em(4): update sysctl list, mention iflib(4).
May 9 2023, 8:03 AM
yuripv committed rGb0cf48305f7f: em(4): update sysctl list, mention iflib(4) (authored by yuripv).
em(4): update sysctl list, mention iflib(4)
May 9 2023, 8:03 AM

May 8 2023

yuripv requested review of D40015: md5: attempt fixing cross-builds in github ci.
May 8 2023, 10:56 PM
yuripv committed rG7adea6dbed35: calendar: cleanup obsolete directories (authored by yuripv).
calendar: cleanup obsolete directories
May 8 2023, 10:50 PM
yuripv added inline comments to D39446: md5: Improve compatibility..
May 8 2023, 2:18 PM
yuripv committed rG1e37655ec389: vt(4): document enable_altgr (authored by yuripv).
vt(4): document enable_altgr
May 8 2023, 1:55 PM
yuripv closed D39997: vt(4): document enable_altgr.
May 8 2023, 1:55 PM
yuripv requested review of D39999: em(4): update sysctl list, mention iflib(4).
May 8 2023, 1:49 PM