Page MenuHomeFreeBSD

yuripv (Yuri Pankov)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2018, 12:11 AM (93 w, 2 d)

Recent Activity

Wed, May 27

yuripv added a comment to D25013: w: don't truncate argument list if --libxo was specified.
In D25013#550908, @phil wrote:

Just knowing that the "--libxo" was used is not sufficient, since there are options that should not affect output (e.g. color, no-humanize, warn).

Can you describe more exactly when you want to avoid truncation? I'm guessing you want this for the "encoding" output styles (XML, JSON) and not text, but do you want to truncate HTML output?

Maybe the test you are needing is just "if (xo_get_style(NULL) == XO_STYLE_TEXT)"?

Thanks,
Phil

Wed, May 27, 7:55 AM

Tue, May 26

yuripv requested review of D25013: w: don't truncate argument list if --libxo was specified.
Tue, May 26, 8:35 AM

Tue, May 19

yuripv added a comment to D24919: nvi: fallback to iso8859-1 if utf-8 check failed and fileencoding/locale encoding is utf-8.
In D24919#548529, @bapt wrote:

Have you contacted the upstream? https://github.com/lichray/nvi2

Will do, forgot about it! Thanks.

Tue, May 19, 5:20 PM
yuripv added a reviewer for D24919: nvi: fallback to iso8859-1 if utf-8 check failed and fileencoding/locale encoding is utf-8: lichray_gmail.com.
Tue, May 19, 5:19 PM
yuripv added a comment to D24919: nvi: fallback to iso8859-1 if utf-8 check failed and fileencoding/locale encoding is utf-8.
In D24919#548529, @bapt wrote:

Have you contacted the upstream? https://github.com/lichray/nvi2

Tue, May 19, 5:03 PM
yuripv requested review of D24919: nvi: fallback to iso8859-1 if utf-8 check failed and fileencoding/locale encoding is utf-8.
Tue, May 19, 5:00 PM
yuripv added inline comments to D24916: Add Caveats Section to fgetln(3).
Tue, May 19, 2:05 PM

Sat, May 16

yuripv added inline comments to D24862: Provide a MAC policy for granting PRIV_VFS_READ_DIR.
Sat, May 16, 6:55 PM

Feb 21 2020

yuripv added inline comments to D23724: acpi_lid: correct Lid state after boot and resume.
Feb 21 2020, 9:37 AM
yuripv updated the diff for D23724: acpi_lid: correct Lid state after boot and resume.

Correct sysctl description.

Feb 21 2020, 9:37 AM

Feb 17 2020

yuripv updated the summary of D23724: acpi_lid: correct Lid state after boot and resume.
Feb 17 2020, 4:38 AM
yuripv added inline comments to D23724: acpi_lid: correct Lid state after boot and resume.
Feb 17 2020, 3:04 AM
yuripv created D23724: acpi_lid: correct Lid state after boot and resume.
Feb 17 2020, 2:47 AM

Jan 21 2020

yuripv removed a member for manpages: yuripv.
Jan 21 2020, 12:01 AM

Jan 9 2020

yuripv accepted D23109: libc: Fix a few bugs in the xlocale collation code..
Jan 9 2020, 5:43 PM
yuripv added a comment to D23109: libc: Fix a few bugs in the xlocale collation code..

I wonder if we could instead check if we have the table already loaded and return without doing everything over and over again. Something like the following right at the start:

if (table->__collate_load_error == 0 && table->header != NULL && strcmp(table->header.locale, encoding) == 0)
    return (_LDP_LOADED);

Not completely sure about the table->header check here as we already checked that the table was loaded, but it's just an idea.

(P.S. I think encoding is really a wrong argument name here, as it's full locale name.)

Jan 9 2020, 5:43 PM
yuripv added a comment to D23109: libc: Fix a few bugs in the xlocale collation code..

I wonder if we could instead check if we have the table already loaded and return without doing everything over and over again. Something like the following right at the start:

Jan 9 2020, 5:39 PM

Oct 28 2019

yuripv added a reviewer for D22169: libsysdecode/truss: linux stat syscalls: jhb.
Oct 28 2019, 5:33 AM
yuripv added inline comments to D22169: libsysdecode/truss: linux stat syscalls.
Oct 28 2019, 5:32 AM
yuripv updated the test plan for D22169: libsysdecode/truss: linux stat syscalls.
Oct 28 2019, 5:29 AM
yuripv created D22169: libsysdecode/truss: linux stat syscalls.
Oct 28 2019, 5:29 AM

Oct 26 2019

yuripv created D22160: PR241491: bin/ps: use locale-based string specifiers.
Oct 26 2019, 4:22 PM

Oct 19 2019

yuripv added inline comments to D21880: fstat(1) -s option.
Oct 19 2019, 8:07 PM
yuripv closed D21794: PR235100: pre-generate Big5 charmap from CLDR data.
Oct 19 2019, 10:05 AM
yuripv closed D21850: PR240911: mark the "Private Use Area" characters as "graph".
Oct 19 2019, 10:05 AM

Oct 18 2019

yuripv created D22075: PR240990: linux: handle the CLOCK_{PROCESS,THREAD}_CPUTIME_ID specified directly.
Oct 18 2019, 9:42 AM
yuripv added a reviewer for D22073: PR240989: provide just one instance of futex_list: dchagin.
Oct 18 2019, 5:25 AM
yuripv created D22073: PR240989: provide just one instance of futex_list.
Oct 18 2019, 5:14 AM

Oct 10 2019

yuripv added inline comments to D21958: add manual pages for the superio driver and interface.
Oct 10 2019, 11:20 PM

Oct 8 2019

yuripv created D21930: fix ESP generation for ZFS boot.
Oct 8 2019, 6:10 AM

Sep 30 2019

yuripv created D21850: PR240911: mark the "Private Use Area" characters as "graph".
Sep 30 2019, 10:31 AM

Sep 25 2019

yuripv added a member for manpages: yuripv.
Sep 25 2019, 8:56 PM
yuripv created D21794: PR235100: pre-generate Big5 charmap from CLDR data.
Sep 25 2019, 8:08 PM

Sep 24 2019

yuripv added a comment to D21710: efibootmgr(8): fix markup and style issues.

Warner, does this make sense to you/won't interfere with other changes you might be working on?

Sep 24 2019, 12:16 PM
yuripv added a reviewer for D21710: efibootmgr(8): fix markup and style issues: imp.
Sep 24 2019, 12:15 PM

Sep 22 2019

yuripv created D21760: lib/libc/regex: fix build with REDEBUG defined.
Sep 22 2019, 8:30 PM

Sep 19 2019

yuripv updated the diff for D21710: efibootmgr(8): fix markup and style issues.

actually split the synopsis into separate options that can't be used together

Sep 19 2019, 9:05 AM
yuripv created D21710: efibootmgr(8): fix markup and style issues.
Sep 19 2019, 8:25 AM
yuripv abandoned D18705: efibootmgr: make generic usage message more readable.

As noted by @imp, there are better ways to do this.

Sep 19 2019, 8:22 AM

Sep 16 2019

yuripv added inline comments to D21672: Add dmgk as a new ports committer (mentor/mentee info).
Sep 16 2019, 8:49 PM

Sep 11 2019

yuripv added inline comments to D21607: getsockopt.2: clarify that SO_TIMESTAMP is not 100% reliable.
Sep 11 2019, 7:33 PM
yuripv updated the diff for D21569: sbuf(9): fix sbuf_drain_func typedef markup.

Correct the .Fo field (remove *). Ingo did agree that .Fo (f) shouldn't trigger the warning and it will be supressed in the future. For the moment, we'll just have a non-fatal warning.

Sep 11 2019, 7:23 PM

Sep 10 2019

yuripv created D21599: locale: more output fixes.
Sep 10 2019, 9:28 PM
yuripv updated the diff for D21490: locale: handle day, abday, mon, abmon, am_pm keywords.
  • use sbuf functions
  • also handle am_pm
  • mark all keywords not specified by POSIX (e.g. abmon_1 through abmon_12, am_str, pm_str, ...) as local additions as other systems (at least Linux and Solaris) do not handle them
  • add tests
Sep 10 2019, 10:45 AM

Sep 9 2019

yuripv added a comment to D21569: sbuf(9): fix sbuf_drain_func typedef markup.
In D21569#469935, @0mp wrote:

Seems fine to me.

Sep 9 2019, 9:35 AM
yuripv updated the summary of D21569: sbuf(9): fix sbuf_drain_func typedef markup.
Sep 9 2019, 8:19 AM
yuripv created D21569: sbuf(9): fix sbuf_drain_func typedef markup.
Sep 9 2019, 8:16 AM

Sep 3 2019

yuripv added inline comments to D21490: locale: handle day, abday, mon, abmon, am_pm keywords.
Sep 3 2019, 9:20 AM

Sep 2 2019

yuripv created D21490: locale: handle day, abday, mon, abmon, am_pm keywords.
Sep 2 2019, 3:13 PM

Aug 30 2019

yuripv added inline comments to D21473: freebsd-update: Add `updatesready` and `showconfig` commands..
Aug 30 2019, 2:37 AM

Aug 29 2019

yuripv added a comment to D21452: ichsmb: defer smbus attach until interrupts are available.

@ian I'm not sure if I should put you in 'submitted by' or 'reviewed by' line, you did both :)

Aug 29 2019, 12:47 AM

Aug 28 2019

yuripv added a comment to D21452: ichsmb: defer smbus attach until interrupts are available.
In D21452#466886, @ian wrote:

IMO, the much easier fix is to change the call to bus_generic_attach() at the end of the ichsmb_attach() routine to:

config_intrhook_oneshot((ich_func_t)bus_generic_attach, dev);
return (0);

We really need to do it to all i2c/smb controller drivers. I've done most of the arm ones already.

Aug 28 2019, 7:07 PM
yuripv retitled D21452: ichsmb: defer smbus attach until interrupts are available from ichsmb: poll for cmd completion status instead of sleeping if cold booted to ichsmb: defer smbus attach until interrupts are available.
Aug 28 2019, 7:07 PM
yuripv added a comment to D21452: ichsmb: defer smbus attach until interrupts are available.

If this driver doesn't need to started early have a look at this:

We could modify SI_SUB_DRIVERS in the macro below to load the driver at a later point in time!

#define EARLY_DRIVER_MODULE_ORDERED(name, busname, driver, devclass,    \
    evh, arg, order, pass)                                              \
                                                                        \
static struct driver_module_data name##_##busname##_driver_mod = {      \
        evh, arg,                                                       \
        #busname,                                                       \
        (kobj_class_t) &driver,                                         \
        &devclass,                                                      \
        pass                                                            \
};                                                                      \
                                                                        \
static moduledata_t name##_##busname##_mod = {                          \
        #busname "/" #name,                                             \
        driver_module_handler,                                          \
        &name##_##busname##_driver_mod                                  \
};                                                                      \
DECLARE_MODULE(name##_##busname, name##_##busname##_mod,                \
               SI_SUB_DRIVERS, order)

/sys/sys/bus.h:#define	DRIVER_MODULE_ORDERED(name, busname, driver, devclass, evh, arg,\
Aug 28 2019, 2:33 PM
yuripv added a comment to D21452: ichsmb: defer smbus attach until interrupts are available.

Can you upload full context?

Aug 28 2019, 1:52 PM
yuripv updated the diff for D21452: ichsmb: defer smbus attach until interrupts are available.
Aug 28 2019, 1:52 PM
yuripv created D21452: ichsmb: defer smbus attach until interrupts are available.
Aug 28 2019, 12:59 PM

Feb 6 2019

yuripv added a comment to D18705: efibootmgr: make generic usage message more readable.
In D18705#401939, @imp wrote:

This is fine, but there's a chance we'll rework the arg parsing in this program in the near future... Better to get this in now though.

Feb 6 2019, 4:04 AM
yuripv added a comment to D18658: top: fix PID sorting after r340742; add process birth time sorting.

@eadler any comments on this as you requested pre-commit review for top?

Feb 6 2019, 4:02 AM
yuripv committed rS343826: pwm.8: fix markup in synopsis, add -f description.
pwm.8: fix markup in synopsis, add -f description
Feb 6 2019, 4:00 AM
yuripv closed D18829: pwm.8: fix markup in synopsis, add -f description.
Feb 6 2019, 4:00 AM
yuripv closed D18830: pwm.9: fix markup in interfaces description.
Feb 6 2019, 3:58 AM
yuripv committed rS343825: pwm.9: fix markup in interfaces description.
pwm.9: fix markup in interfaces description
Feb 6 2019, 3:58 AM

Jan 12 2019

yuripv added a comment to D18531: PR208117: regex(3): implement equivalence classes.

@kevans any thoughts here? I'm still hesitant to add the symbol, so are you ok with the change only being in libc and libregex using the old behavior (strict character comparison instead of equivalence class)?

Jan 12 2019, 4:14 PM
yuripv added a comment to D18408: PR209468: aacraid fixes to work with newer controller firmware.

Hi @yuripv, are there plans to commit this?

Jan 12 2019, 4:12 PM
yuripv added a comment to D18705: efibootmgr: make generic usage message more readable.

@imp anything else I need to change here?

Jan 12 2019, 4:11 PM
yuripv created D18830: pwm.9: fix markup in interfaces description.
Jan 12 2019, 4:09 PM
yuripv created D18829: pwm.8: fix markup in synopsis, add -f description.
Jan 12 2019, 4:08 PM

Jan 2 2019

yuripv added a comment to D18723: biosdisk needs to use std probe for floppy devices.

Are we *guaranteed* to have the floppy drives coming only at the start of the list?

Jan 2 2019, 10:44 PM
yuripv added inline comments to D18705: efibootmgr: make generic usage message more readable.
Jan 2 2019, 4:46 PM
yuripv updated the diff for D18705: efibootmgr: make generic usage message more readable.

Address comments from @imp.

Jan 2 2019, 4:45 PM
yuripv added a comment to D18705: efibootmgr: make generic usage message more readable.

-N (delete BootNext) doesn’t require -b since it doesn’t operate on a bootnum.

Jan 2 2019, 2:54 PM
yuripv updated the diff for D18705: efibootmgr: make generic usage message more readable.

-N doesn't need the -b bootnum.

Jan 2 2019, 2:54 PM
yuripv edited reviewers for D18705: efibootmgr: make generic usage message more readable, added: bcran; removed: db.
Jan 2 2019, 1:35 PM

Jan 1 2019

yuripv updated the diff for D18531: PR208117: regex(3): implement equivalence classes.

Drop the xlocale_private.h change, it's not really needed.

Jan 1 2019, 7:40 AM
yuripv created D18705: efibootmgr: make generic usage message more readable.
Jan 1 2019, 6:32 AM

Dec 27 2018

yuripv added inline comments to D18658: top: fix PID sorting after r340742; add process birth time sorting.
Dec 27 2018, 9:03 PM

Dec 25 2018

yuripv accepted D18656: Bump sys_errlist size to keep ABI backward-compatible for some time..
Dec 25 2018, 3:58 PM
yuripv created D18658: top: fix PID sorting after r340742; add process birth time sorting.
Dec 25 2018, 3:42 PM
yuripv added inline comments to D18656: Bump sys_errlist size to keep ABI backward-compatible for some time..
Dec 25 2018, 3:39 PM
yuripv added inline comments to D18656: Bump sys_errlist size to keep ABI backward-compatible for some time..
Dec 25 2018, 3:02 PM
yuripv accepted D18656: Bump sys_errlist size to keep ABI backward-compatible for some time..
Dec 25 2018, 2:57 PM

Dec 23 2018

yuripv created D18636: ssh: revert to previous IPQoS options if running under VMware hypervisor.
Dec 23 2018, 11:35 AM

Dec 22 2018

yuripv added inline comments to D18531: PR208117: regex(3): implement equivalence classes.
Dec 22 2018, 1:29 AM

Dec 19 2018

yuripv added a comment to D18611: PR234066: jemalloc assertion failure in less.
In D18611#396895, @pfg wrote:

For the record: while it is good practice to request reviews before committing, IMHO they dont make much sense, and are not required at all, for reverts. After all they stand for things all the initial reviewers missed in the first place ;).

Dec 19 2018, 11:31 PM
yuripv committed rS342265: regcomp: revert part of r341838 which turned out to be unrelated.
regcomp: revert part of r341838 which turned out to be unrelated
Dec 19 2018, 11:29 PM
yuripv closed D18611: PR234066: jemalloc assertion failure in less.
Dec 19 2018, 11:29 PM
yuripv created D18611: PR234066: jemalloc assertion failure in less.
Dec 19 2018, 10:23 PM
yuripv accepted D18605: Allow multi-byte thousands separators in strfmon(3).

Looks good to me, I have even applied the patch and tested some corner cases I could think of :-)

Dec 19 2018, 6:31 PM

Dec 12 2018

yuripv added inline comments to D18531: PR208117: regex(3): implement equivalence classes.
Dec 12 2018, 4:31 PM
yuripv created D18531: PR208117: regex(3): implement equivalence classes.
Dec 12 2018, 4:28 PM
yuripv committed rS341838: regcomp: reduce size of bitmap for multibyte locales.
regcomp: reduce size of bitmap for multibyte locales
Dec 12 2018, 4:24 AM
yuripv closed D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.
Dec 12 2018, 4:24 AM
yuripv added a comment to D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range.

@kevans are you OK with the test case added to libc/regex instead and using sed? :)

Dec 12 2018, 2:58 AM

Dec 8 2018

yuripv added a comment to D2232: Implement NLS catalog encoding conversion.

Oops, I didn't mean to add Ed back to this review :-)

Dec 8 2018, 9:16 PM
yuripv updated subscribers of D2232: Implement NLS catalog encoding conversion.
Dec 8 2018, 9:16 PM
yuripv updated subscribers of D2232: Implement NLS catalog encoding conversion.

Reading through the discussion, I do agree with @ed -- we should have just one version in UTF-8, and convert to current encoding on the fly, though I do agree with @AMDmi3 as well -- making sure we use only the characters that can be converted to the related single-byte locale shouldn't be that hard, we don't need to use the fancy unicode chars in messages.

Dec 8 2018, 9:15 PM
yuripv added inline comments to D18452: Add device_delete_children(9) manual page.
Dec 8 2018, 9:04 PM
yuripv committed rS341745: MFC r340835:.
MFC r340835:
Dec 8 2018, 7:45 PM
yuripv added a reviewer for D18302: regcomp() recurses infinitely on a case-insensitive pattern containing wide characters in 128-255 range: bapt.
Dec 8 2018, 4:44 AM