Page MenuHomeFreeBSD

md5: Include <osreldate.h> for __FreeBSD_version.
ClosedPublic

Authored by des on May 9 2023, 10:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 1:44 AM
Unknown Object (File)
Fri, Apr 19, 4:56 PM
Unknown Object (File)
Tue, Apr 9, 9:35 AM
Unknown Object (File)
Thu, Apr 4, 1:53 PM
Unknown Object (File)
Tue, Apr 2, 9:06 AM
Unknown Object (File)
Sat, Mar 30, 8:00 AM
Unknown Object (File)
Jan 30 2024, 11:47 PM
Unknown Object (File)
Dec 20 2023, 5:05 AM
Subscribers

Details

Summary

It is usually provided by <sys/param.h>, but not when bootstrapping.

Fixes: 4849767cb16a
MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.May 9 2023, 10:00 AM
sbin/md5/md5.c
23

I wanted to propose the same, but looking at the history looks like param.h was added for the same reason of bootstrapping:

commit cab31e0e216c7defefd4aba14693ba2252ea7308
Author: Jessica Clarke <jrtc27@FreeBSD.org>
Date:   Fri Jun 25 22:00:11 2021 +0100

    md5: Fix cross-build after c2870e576bd2

    On macOS and Linux the current set of headers do not end up pulling in
    sys/param.h, causing MAXPATHLEN to not be defined and the build to fail.
des retitled this revision from md5: Use <osreldate.h> instead of <sys/param.h> to md5: Include <osreldate.h> for __FreeBSD_version..May 9 2023, 4:40 PM
des edited the summary of this revision. (Show Details)

We still need <sys/param.h>.

des marked an inline comment as done.May 9 2023, 4:40 PM
This revision is now accepted and ready to land.May 9 2023, 4:41 PM