- Overhaul the GNU compatibility mode to more closely emulate what the GNU tools do.
- Add a Perl compatibility mode which emulates the shasum tool that ships with Perl. This is currently not installed.
- Overhaul the tests.
Sponsored by: Klara, Inc.
Details
Details
- Reviewers
kevans - Group Reviewers
Klara tests - Commits
- rG4849767cb16a: md5: Improve compatibility.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sbin/md5/md5.c | ||
|---|---|---|
| 464 | Ideally all of these that have a corresponding short option should really just be using that for the struct option val, rather than having to handle both cases for each duplicated option (the first enum optval value would start at CHAR_MAX). We're already at 20 options, over half-way to the printable character range that could conceivably be used as flags and we're at the mercy of both GNU *sum and the Perl shasum for a chunk of our flags. If we can cleanly avoid having to maybe care about this in the future, I think we should. | |
| sbin/md5/md5.c | ||
|---|---|---|
| 464 | This is still really ugly, but I guess at least it's not a potential future conflict now. | |
Comment Actions
- In bits mode, check that the length is a multiple of 8.
- Remove unused test files.
- Don't install shasum for now.
- Improve the man page.
Comment Actions
I think this LGTM; one request that you can deal with pre-push.
| sbin/md5/Makefile | ||
|---|---|---|
| 30 | Since we're adding these commented out, please pair it with a brief comment explaining why so that someone doesn't come along and just think it's a dead idea. | |
| sbin/md5/md5.c | ||
|---|---|---|
| 1032 | Looks like referencing __FreeBSD_version broken cross-builds in github CI: https://github.com/freebsd/freebsd-src/actions/runs/4912938253/jobs/8772539897 Probably including <osreldate.h> should help here? | |