Page MenuHomeFreeBSD

localedef: add newlines to error messages
ClosedPublic

Authored by kevans on Sep 2 2023, 6:36 AM.
Tags
None
Referenced Files
F152988271: D41693.diff
Sat, Apr 18, 12:10 PM
Unknown Object (File)
Fri, Apr 10, 1:30 AM
Unknown Object (File)
Tue, Apr 7, 3:40 AM
Unknown Object (File)
Wed, Apr 1, 5:05 PM
Unknown Object (File)
Mar 14 2026, 3:02 PM
Unknown Object (File)
Feb 27 2026, 9:39 PM
Unknown Object (File)
Feb 7 2026, 11:33 PM
Unknown Object (File)
Feb 7 2026, 7:07 PM
Subscribers

Details

Summary

These won't be added elsewhere, so add a little bit of room to make
these messages a little easier to read. The existing set is a mixed
bag, there are somewhere in the ballpark of 45, 46 printfs to stderr and
19 of those had newlines.

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans requested review of this revision.Sep 2 2023, 6:36 AM
yuripv added inline comments.
usr.bin/localedef/localedef.h
177

this really should be something fatal like err() (same as in illumos).

This revision is now accepted and ready to land.Sep 2 2023, 10:08 AM
usr.bin/localedef/localedef.h
177

+1; I might be able to follow-up on this later.

This revision was automatically updated to reflect the committed changes.