Page MenuHomeFreeBSD

localedef: add newlines to error messages
ClosedPublic

Authored by kevans on Sep 2 2023, 6:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 11:26 PM
Unknown Object (File)
Thu, Oct 9, 2:52 PM
Unknown Object (File)
Thu, Oct 9, 4:35 AM
Unknown Object (File)
Tue, Sep 23, 3:15 AM
Unknown Object (File)
Sep 12 2025, 6:40 AM
Unknown Object (File)
Sep 9 2025, 8:02 AM
Unknown Object (File)
Sep 6 2025, 1:26 AM
Unknown Object (File)
Sep 5 2025, 5:10 PM
Subscribers

Details

Summary

These won't be added elsewhere, so add a little bit of room to make
these messages a little easier to read. The existing set is a mixed
bag, there are somewhere in the ballpark of 45, 46 printfs to stderr and
19 of those had newlines.

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans requested review of this revision.Sep 2 2023, 6:36 AM
yuripv added inline comments.
usr.bin/localedef/localedef.h
177

this really should be something fatal like err() (same as in illumos).

This revision is now accepted and ready to land.Sep 2 2023, 10:08 AM
usr.bin/localedef/localedef.h
177

+1; I might be able to follow-up on this later.

This revision was automatically updated to reflect the committed changes.