Page MenuHomeFreeBSD
Feed Advanced Search

Mon, Jul 27

yuripv accepted D25814: nologin.8: Improve wording.

Thank you.

Mon, Jul 27, 6:48 AM

Sun, Jul 26

yuripv committed rS363577: MFC r362146:.
MFC r362146:
Sun, Jul 26, 7:19 PM
yuripv added inline comments to D24196: Document the exit status and the message of nologin(8).
Sun, Jul 26, 10:12 AM
yuripv committed rS363543: sed: treat '[' as ordinary character in 'y' command.
sed: treat '[' as ordinary character in 'y' command
Sun, Jul 26, 9:15 AM
yuripv closed D25640: sed "y" command bracket balancing check.
Sun, Jul 26, 9:15 AM

Tue, Jul 14

yuripv committed rS363207: top: VIS_SAFE turned out to be unsafe.
top: VIS_SAFE turned out to be unsafe
Tue, Jul 14, 10:43 PM
yuripv accepted D25229: Allow bootstrapping localdef on non-FreeBSD systems.
Tue, Jul 14, 5:47 PM

Mon, Jul 13

yuripv added a comment to D25640: sed "y" command bracket balancing check.
In D25640#567601, @pfg wrote:

LGTM however, I would recommend an exp-run. Many times before have sed changes caused trouble in the ports tree to be later reverted.

Mon, Jul 13, 10:57 PM
yuripv added a comment to D25398: w: remove proc_compare().

It's not immediately obvious to me why rS29310 would render this a no-op, but I know that the use of ki_estcpu instead of ki_pctcpu is bogus for anything but the 4BSD scheduler.

Mon, Jul 13, 3:04 PM
yuripv requested review of D25649: setclassenvironment: trim leading spaces in variable names.
Mon, Jul 13, 1:24 PM
yuripv updated the test plan for D25640: sed "y" command bracket balancing check.
Mon, Jul 13, 11:06 AM
yuripv updated the diff for D25640: sed "y" command bracket balancing check.

remove debugging cruft

Mon, Jul 13, 3:21 AM
yuripv requested review of D25640: sed "y" command bracket balancing check.
Mon, Jul 13, 3:20 AM
yuripv committed rS363138: sed/multi_test: print comment for current test, not next one.
sed/multi_test: print comment for current test, not next one
Mon, Jul 13, 1:33 AM

Sat, Jul 11

yuripv added inline comments to D25622: ping(8): Improve validation of -g, -G and -h parameters..
Sat, Jul 11, 6:23 PM

Jun 23 2020

yuripv closed D25174: w: use locale-based format specifiers.
Jun 23 2020, 3:22 AM
yuripv requested review of D25174: w: use locale-based format specifiers.
Jun 23 2020, 3:21 AM
yuripv requested review of D24744: hwpstate_intel: don't unconditionally print the error message.
Jun 23 2020, 3:16 AM

Jun 22 2020

yuripv committed rS362515: Revert r362148..
Revert r362148.
Jun 22 2020, 10:59 PM
yuripv requested review of D25398: w: remove proc_compare().
Jun 22 2020, 7:15 AM

Jun 21 2020

yuripv committed rS362464: w: use locale-based string format specifiers.
w: use locale-based string format specifiers
Jun 21 2020, 11:42 AM

Jun 18 2020

yuripv accepted D25229: Allow bootstrapping localdef on non-FreeBSD systems.

I think this looks good.

Jun 18 2020, 4:04 PM

Jun 15 2020

yuripv committed rS362200: MFC r353127:.
MFC r353127:
Jun 15 2020, 4:00 PM

Jun 13 2020

yuripv committed rS362148: nvi: fallback to ISO8859-1 as last resort.
nvi: fallback to ISO8859-1 as last resort
Jun 13 2020, 2:11 PM
yuripv closed D24919: nvi: fallback to iso8859-1 if utf-8 check failed and fileencoding/locale encoding is utf-8.
Jun 13 2020, 2:11 PM
yuripv committed rS362147: awk(1): use -version instead of -V.
awk(1): use -version instead of -V
Jun 13 2020, 9:16 AM
yuripv closed D25164: awk.1: use -version instead of -V.
Jun 13 2020, 9:16 AM
yuripv committed rS362146: locale: exit 1 if unknown keyword was specified.
locale: exit 1 if unknown keyword was specified
Jun 13 2020, 8:37 AM

Jun 11 2020

yuripv added inline comments to D24916: Add Caveats Section to fgetln(3).
Jun 11 2020, 9:41 PM

Jun 9 2020

yuripv added a comment to D22160: PR241491: bin/ps: use locale-based string specifiers.
In D22160#555029, @phil wrote:

The "%hs" bits look good, but why do you add the call to xo_no_setlocale()?

Thanks,
Phil

Jun 9 2020, 7:08 AM
yuripv committed rS361962: ps: remove xo_no_setlocale() call.
ps: remove xo_no_setlocale() call
Jun 9 2020, 7:07 AM

Jun 8 2020

yuripv added a comment to D22160: PR241491: bin/ps: use locale-based string specifiers.
In D22160#555029, @phil wrote:

The "%hs" bits look good, but why do you add the call to xo_no_setlocale()?

Thanks,
Phil

Jun 8 2020, 3:43 PM

Jun 7 2020

yuripv added a comment to D25165: taskqueue(9): reference callout(9) instead of timeout(9).

And yeah, I think it’s a good idea to fix all of them. Still, this is fine too.

Jun 7 2020, 9:21 AM
yuripv committed rS361888: taskqueue(9): reference callout(9) instead of timeout(9).
taskqueue(9): reference callout(9) instead of timeout(9)
Jun 7 2020, 9:18 AM
yuripv closed D25165: taskqueue(9): reference callout(9) instead of timeout(9).
Jun 7 2020, 9:18 AM
yuripv closed D22160: PR241491: bin/ps: use locale-based string specifiers.
Jun 7 2020, 8:21 AM
yuripv committed rS361887: ps: use %hs instead of %s format specifiers.
ps: use %hs instead of %s format specifiers
Jun 7 2020, 8:21 AM
yuripv added inline comments to D25165: taskqueue(9): reference callout(9) instead of timeout(9).
Jun 7 2020, 6:34 AM

Jun 6 2020

yuripv added inline comments to D24919: nvi: fallback to iso8859-1 if utf-8 check failed and fileencoding/locale encoding is utf-8.
Jun 6 2020, 7:54 PM
yuripv closed D25166: stats.7: fix nonexistent references, various lint issues.
Jun 6 2020, 5:49 PM
yuripv committed rS361871: stats(7): fix bad Xr references and lint noise.
stats(7): fix bad Xr references and lint noise
Jun 6 2020, 5:49 PM
yuripv added a comment to D25166: stats.7: fix nonexistent references, various lint issues.
In D25166#554560, @bjk wrote:

I expect I should be the one committing this?
But I will hold off for a bit in case someone wants to respond to the 'kldstat' remark.

Jun 6 2020, 5:31 PM
yuripv requested review of D25166: stats.7: fix nonexistent references, various lint issues.
Jun 6 2020, 11:09 AM
yuripv added a comment to D25165: taskqueue(9): reference callout(9) instead of timeout(9).

Actually, there are more timeout(9) references, wonder if it would make sense to gather all of those in one review?

Jun 6 2020, 10:44 AM
yuripv requested review of D25165: taskqueue(9): reference callout(9) instead of timeout(9).
Jun 6 2020, 10:40 AM
yuripv requested review of D25164: awk.1: use -version instead of -V.
Jun 6 2020, 9:06 AM
yuripv added inline comments to D24919: nvi: fallback to iso8859-1 if utf-8 check failed and fileencoding/locale encoding is utf-8.
Jun 6 2020, 8:05 AM

Jun 5 2020

yuripv added inline comments to D25103: zfsbootcfg: use vfs.root.mountfrom and update nextboot on every vdev.
Jun 5 2020, 6:25 PM

Jun 4 2020

yuripv added inline comments to D25117: Add pthread_getname_np() and pthread_setname_np() aliases for pthread_get_name_np() and pthread_set_name_np()..
Jun 4 2020, 5:11 PM

May 27 2020

yuripv added a comment to D25013: w: don't truncate argument list if --libxo was specified.
In D25013#550908, @phil wrote:

Just knowing that the "--libxo" was used is not sufficient, since there are options that should not affect output (e.g. color, no-humanize, warn).

Can you describe more exactly when you want to avoid truncation? I'm guessing you want this for the "encoding" output styles (XML, JSON) and not text, but do you want to truncate HTML output?

Maybe the test you are needing is just "if (xo_get_style(NULL) == XO_STYLE_TEXT)"?

Thanks,
Phil

May 27 2020, 7:55 AM

May 26 2020

yuripv requested review of D25013: w: don't truncate argument list if --libxo was specified.
May 26 2020, 8:35 AM

May 19 2020

yuripv added a comment to D24919: nvi: fallback to iso8859-1 if utf-8 check failed and fileencoding/locale encoding is utf-8.
In D24919#548529, @bapt wrote:

Have you contacted the upstream? https://github.com/lichray/nvi2

Will do, forgot about it! Thanks.

May 19 2020, 5:20 PM
yuripv added a reviewer for D24919: nvi: fallback to iso8859-1 if utf-8 check failed and fileencoding/locale encoding is utf-8: lichray_gmail.com.
May 19 2020, 5:19 PM
yuripv added a comment to D24919: nvi: fallback to iso8859-1 if utf-8 check failed and fileencoding/locale encoding is utf-8.
In D24919#548529, @bapt wrote:

Have you contacted the upstream? https://github.com/lichray/nvi2

May 19 2020, 5:03 PM
yuripv requested review of D24919: nvi: fallback to iso8859-1 if utf-8 check failed and fileencoding/locale encoding is utf-8.
May 19 2020, 5:00 PM
yuripv added inline comments to D24916: Add Caveats Section to fgetln(3).
May 19 2020, 2:05 PM

May 16 2020

yuripv added inline comments to D24862: Provide a MAC policy for granting PRIV_VFS_READ_DIR.
May 16 2020, 6:55 PM

Feb 21 2020

yuripv added inline comments to D23724: acpi_lid: correct Lid state after boot and resume.
Feb 21 2020, 9:37 AM
yuripv updated the diff for D23724: acpi_lid: correct Lid state after boot and resume.

Correct sysctl description.

Feb 21 2020, 9:37 AM

Feb 17 2020

yuripv updated the summary of D23724: acpi_lid: correct Lid state after boot and resume.
Feb 17 2020, 4:38 AM
yuripv added inline comments to D23724: acpi_lid: correct Lid state after boot and resume.
Feb 17 2020, 3:04 AM
yuripv created D23724: acpi_lid: correct Lid state after boot and resume.
Feb 17 2020, 2:47 AM

Jan 21 2020

yuripv removed a member for manpages: yuripv.
Jan 21 2020, 12:01 AM

Jan 9 2020

yuripv accepted D23109: libc: Fix a few bugs in the xlocale collation code..
Jan 9 2020, 5:43 PM
yuripv added a comment to D23109: libc: Fix a few bugs in the xlocale collation code..

I wonder if we could instead check if we have the table already loaded and return without doing everything over and over again. Something like the following right at the start:

if (table->__collate_load_error == 0 && table->header != NULL && strcmp(table->header.locale, encoding) == 0)
    return (_LDP_LOADED);

Not completely sure about the table->header check here as we already checked that the table was loaded, but it's just an idea.

(P.S. I think encoding is really a wrong argument name here, as it's full locale name.)

Jan 9 2020, 5:43 PM
yuripv added a comment to D23109: libc: Fix a few bugs in the xlocale collation code..

I wonder if we could instead check if we have the table already loaded and return without doing everything over and over again. Something like the following right at the start:

Jan 9 2020, 5:39 PM

Oct 28 2019

yuripv added a reviewer for D22169: libsysdecode/truss: linux stat syscalls: jhb.
Oct 28 2019, 5:33 AM
yuripv added inline comments to D22169: libsysdecode/truss: linux stat syscalls.
Oct 28 2019, 5:32 AM
yuripv updated the test plan for D22169: libsysdecode/truss: linux stat syscalls.
Oct 28 2019, 5:29 AM
yuripv created D22169: libsysdecode/truss: linux stat syscalls.
Oct 28 2019, 5:29 AM

Oct 26 2019

yuripv created D22160: PR241491: bin/ps: use locale-based string specifiers.
Oct 26 2019, 4:22 PM

Oct 19 2019

yuripv added inline comments to D21880: fstat(1) -s option.
Oct 19 2019, 8:07 PM
yuripv closed D21794: PR235100: pre-generate Big5 charmap from CLDR data.
Oct 19 2019, 10:05 AM
yuripv closed D21850: PR240911: mark the "Private Use Area" characters as "graph".
Oct 19 2019, 10:05 AM

Oct 18 2019

yuripv created D22075: PR240990: linux: handle the CLOCK_{PROCESS,THREAD}_CPUTIME_ID specified directly.
Oct 18 2019, 9:42 AM
yuripv added a reviewer for D22073: PR240989: provide just one instance of futex_list: dchagin.
Oct 18 2019, 5:25 AM
yuripv created D22073: PR240989: provide just one instance of futex_list.
Oct 18 2019, 5:14 AM

Oct 10 2019

yuripv added inline comments to D21958: add manual pages for the superio driver and interface.
Oct 10 2019, 11:20 PM

Oct 8 2019

yuripv created D21930: fix ESP generation for ZFS boot.
Oct 8 2019, 6:10 AM

Sep 30 2019

yuripv created D21850: PR240911: mark the "Private Use Area" characters as "graph".
Sep 30 2019, 10:31 AM

Sep 25 2019

yuripv added a member for manpages: yuripv.
Sep 25 2019, 8:56 PM
yuripv created D21794: PR235100: pre-generate Big5 charmap from CLDR data.
Sep 25 2019, 8:08 PM

Sep 24 2019

yuripv added a comment to D21710: efibootmgr(8): fix markup and style issues.

Warner, does this make sense to you/won't interfere with other changes you might be working on?

Sep 24 2019, 12:16 PM
yuripv added a reviewer for D21710: efibootmgr(8): fix markup and style issues: imp.
Sep 24 2019, 12:15 PM

Sep 22 2019

yuripv created D21760: lib/libc/regex: fix build with REDEBUG defined.
Sep 22 2019, 8:30 PM

Sep 19 2019

yuripv updated the diff for D21710: efibootmgr(8): fix markup and style issues.

actually split the synopsis into separate options that can't be used together

Sep 19 2019, 9:05 AM
yuripv created D21710: efibootmgr(8): fix markup and style issues.
Sep 19 2019, 8:25 AM
yuripv abandoned D18705: efibootmgr: make generic usage message more readable.

As noted by @imp, there are better ways to do this.

Sep 19 2019, 8:22 AM

Sep 16 2019

yuripv added inline comments to D21672: Add dmgk as a new ports committer (mentor/mentee info).
Sep 16 2019, 8:49 PM

Sep 11 2019

yuripv added inline comments to D21607: getsockopt.2: clarify that SO_TIMESTAMP is not 100% reliable.
Sep 11 2019, 7:33 PM
yuripv updated the diff for D21569: sbuf(9): fix sbuf_drain_func typedef markup.

Correct the .Fo field (remove *). Ingo did agree that .Fo (f) shouldn't trigger the warning and it will be supressed in the future. For the moment, we'll just have a non-fatal warning.

Sep 11 2019, 7:23 PM

Sep 10 2019

yuripv created D21599: locale: more output fixes.
Sep 10 2019, 9:28 PM
yuripv updated the diff for D21490: locale: handle day, abday, mon, abmon, am_pm keywords.
  • use sbuf functions
  • also handle am_pm
  • mark all keywords not specified by POSIX (e.g. abmon_1 through abmon_12, am_str, pm_str, ...) as local additions as other systems (at least Linux and Solaris) do not handle them
  • add tests
Sep 10 2019, 10:45 AM

Sep 9 2019

yuripv added a comment to D21569: sbuf(9): fix sbuf_drain_func typedef markup.
In D21569#469935, @0mp wrote:

Seems fine to me.

Sep 9 2019, 9:35 AM
yuripv updated the summary of D21569: sbuf(9): fix sbuf_drain_func typedef markup.
Sep 9 2019, 8:19 AM
yuripv created D21569: sbuf(9): fix sbuf_drain_func typedef markup.
Sep 9 2019, 8:16 AM

Sep 3 2019

yuripv added inline comments to D21490: locale: handle day, abday, mon, abmon, am_pm keywords.
Sep 3 2019, 9:20 AM

Sep 2 2019

yuripv created D21490: locale: handle day, abday, mon, abmon, am_pm keywords.
Sep 2 2019, 3:13 PM

Aug 30 2019

yuripv added inline comments to D21473: freebsd-update: Add `updatesready` and `showconfig` commands..
Aug 30 2019, 2:37 AM

Aug 29 2019

yuripv added a comment to D21452: ichsmb: defer smbus attach until interrupts are available.

@ian I'm not sure if I should put you in 'submitted by' or 'reviewed by' line, you did both :)

Aug 29 2019, 12:47 AM