vmm(4): document maxcpu tunable
Needs RevisionPublic
Actions

Authored by yuripv on May 11 2023, 9:51 PM.

Details

Reviewers

corvink
grahamperrin

Group Reviewers

manpages
bhyve

Summary

Document hw.vmm.maxcpu and update related part in bhyve(8).

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

yuripv requested review of this revision.May 11 2023, 9:51 PM

corvink added a subscriber: corvink.

corvink added inline comments.

share/man/man4/vmm.4
27

This revision is now accepted and ready to land.May 12 2023, 5:34 AM

grahamperrin requested changes to this revision.May 12 2023, 6:46 AM

grahamperrin added inline comments.

This revision now requires changes to proceed.May 12 2023, 6:46 AM

yuripv marked 2 inline comments as done.May 12 2023, 9:18 AM

yuripv added inline comments.

share/man/man4/vmm.4
87	I'm not a grammar expert for sure, but should we then fix all other ones? :) $ grep -FIr 'before booting the kernel or stored' share/man \| wc -l 36 $ grep -FIr 'before booting the kernel, or stored' share/man \| wc -l 5
92	Saying "physical" sounds wrong to me somehow -- we are talking about the result of sockets/cores/threads here, and "physical" makes me think about just "sockets".
usr.sbin/bhyve/bhyve.8
150–152	"can be changed with vmm(4)" sounds like broken sentence to me

Thanks for catching this.

share/man/man4/vmm.4
87	I think you don't need the comma. It's not a conjunction between two sentences, but a compound predicate (subject is "Tunables" predicate is "set ... or stored ...").
91	Maybe "Maximum number of virtual CPUs for each virtual machine." The limit is per-VM, not global across all VMs.
92	The goal is to communicate real CPUs on the host, and physical is the normal antonym for virtual. In the commit adding this tunable I did use this sentence: The default is now the number of physical CPUs in the system rather than 16. I think you can drop "active" from the suggestion.
usr.sbin/bhyve/bhyve.8
150–152	Yes, I would drop the ", and can be changed with" and use the original "See" for the last part here. I would keep most of the suggestion from Graham though, but perhaps drop "active" as I suggested for the same phrase above.