Document hw.vmm.maxcpu and update related part in bhyve(8).
I'm not a grammar expert for sure, but should we then fix all other ones? :)
$ grep -FIr 'before booting the kernel or stored' share/man | wc -l 36 $ grep -FIr 'before booting the kernel, or stored' share/man | wc -l 5
Saying "physical" sounds wrong to me somehow -- we are talking about the result of sockets/cores/threads here, and "physical" makes me think about just "sockets".
"can be changed with vmm(4)" sounds like broken sentence to me
Thanks for catching this.
I think you don't need the comma. It's not a conjunction between two sentences, but a compound predicate (subject is "Tunables" predicate is "set ... or stored ...").
Maybe "Maximum number of virtual CPUs for each virtual machine."
The limit is per-VM, not global across all VMs.
The goal is to communicate real CPUs on the host, and physical is the normal antonym for virtual. In the commit adding this tunable I did use this sentence:
The default is now the number of physical CPUs in the system rather than 16.
I think you can drop "active" from the suggestion.
Yes, I would drop the ", and can be changed with" and use the original "See" for the last part here. I would keep most of the suggestion from Graham though, but perhaps drop "active" as I suggested for the same phrase above.