Page MenuHomeFreeBSD

rgrimes
User

Projects

User Details

User Since
Dec 19 2016, 4:11 AM (259 w, 2 d)

Recent Activity

Mon, Dec 6

rgrimes accepted D33274: IPv4: fix redirect sending conditions.

Pi, thank you for spotting this, and bz thanks for the quick fix. This explains some issues I had when I tried to migrate to 13 on a router, but had no time to investigate what was going wrong.

Mon, Dec 6, 5:57 PM

Sep 24 2021

rgrimes requested changes to D32078: Make {t,}csh sessions more xterm friendly.

I strongly disagree with adding "site and user specific" tweaks to the dot.cshrc files. Further I note that a huge down side of systems that do this xterm tittle setting create very miss leading situations when the terminal disconnects for any reason (ie your xterm is now local, not remote). Some systems do infact try to clean that up in the logout scripts, but that doesnt work if your disconnected for any other reason. There is already a very clear default prompt setting that shows you the hostname of the system you are logged into.

Sep 24 2021, 4:12 PM

Sep 18 2021

rgrimes added a comment to D28200: Set MAC to broadcast when pinging 255.255.255.255 as noted in RFC919.
In D28200#722356, @kp wrote:

So, I've been looking at committing this, and I'm still convinced that the previous behaviour is indeed incorrect, but I'm no longer sure this is the correct fix.
We should probably call in_broadcast() to run this check, rather than duplicate the logic here.

Sep 18 2021, 5:00 PM

Sep 12 2021

rgrimes accepted D31861: Change lowest address on subnet (host 0) not to broadcast by default..
Sep 12 2021, 4:03 PM

Sep 6 2021

rgrimes added a comment to D31861: Change lowest address on subnet (host 0) not to broadcast by default..

Add some reviewers, and pull in most of the subscribers fro D19316

Sep 6 2021, 9:01 PM
rgrimes added reviewers for D31861: Change lowest address on subnet (host 0) not to broadcast by default.: melifaro, cem, rscheff.
Sep 6 2021, 9:00 PM
rgrimes accepted D31861: Change lowest address on subnet (host 0) not to broadcast by default..

Looks ok to me, just a comment on keeping code speed the same in almost all cases.

Sep 6 2021, 4:16 PM

Jul 27 2021

rgrimes added inline comments to D31315: lagg.4: note laggtype arg and reorder wireless example.
Jul 27 2021, 7:45 PM

Jul 9 2021

rgrimes accepted D31114: awk: revert to upstream behavior for ranges for gawk compatibility.
Jul 9 2021, 1:20 PM

Jul 8 2021

rgrimes added inline comments to D31077: if_epair: rework.
Jul 8 2021, 5:57 PM

Jun 19 2021

rgrimes accepted D30740: net.inet.tcp.tolerate_missing_ts=1.
Jun 19 2021, 12:38 PM

Jun 11 2021

rgrimes accepted D30740: net.inet.tcp.tolerate_missing_ts=1.
Jun 11 2021, 11:20 PM

May 21 2021

rgrimes accepted D30374: Restore RFC reference.

Though I am not a big fan of these, as the src tree would need a massive quantity of these added to make much of a dent at all in documenting what part of what rfc is being implemented, I wont stand in the way of one more near useless comment.

May 21 2021, 11:52 AM

May 13 2021

rgrimes added inline comments to D30239: Add ALLOW_OSVERSION_MISMATCH flag to bsd.ports.mk.
May 13 2021, 5:36 AM
rgrimes accepted D30239: Add ALLOW_OSVERSION_MISMATCH flag to bsd.ports.mk.
May 13 2021, 5:26 AM

May 3 2021

rgrimes added a comment to D30043: tcp: Whitespace cleanup in brr and rack.

The adding of blank lines between all the forward declarations seems wrong to me.

May 3 2021, 6:17 PM

May 2 2021

rgrimes accepted D30050: Adds uuid validation to bhyve(8) arg parsing.
May 2 2021, 12:31 PM
rgrimes added inline comments to D30050: Adds uuid validation to bhyve(8) arg parsing.
May 2 2021, 12:11 PM

May 1 2021

rgrimes requested changes to D30050: Adds uuid validation to bhyve(8) arg parsing.
May 1 2021, 11:22 PM
rgrimes added a comment to D30050: Adds uuid validation to bhyve(8) arg parsing.

The uuid is being correctly validated in smbiostbl.c:smbios_type1_initializer() so there's no need to do it again. An fprintf to stderr there indicatiing it is invalid is fine, and the assert on a return from smbios_build() can be changed into an exit(1).

May 1 2021, 1:51 PM

Apr 29 2021

rgrimes added inline comments to D30037: bhyve: Set SO_REUSEADDR on the gdb stub socket.
Apr 29 2021, 7:48 PM
rgrimes added inline comments to D30037: bhyve: Set SO_REUSEADDR on the gdb stub socket.
Apr 29 2021, 4:33 PM

Apr 27 2021

rgrimes accepted D29968: Do not forward datagrams original from 169.254.0.0/16 link-local addresses.

I am accepting this without the IPSTAT_INC(ips_forward) issue being fixed, as it looks to me as if that is an existing and separate problem in the code. Probably a walk through should be done to see that ips_forward and ips_cantforward are all done correctly.

Apr 27 2021, 11:31 AM · network

Apr 26 2021

rgrimes added a comment to D29968: Do not forward datagrams original from 169.254.0.0/16 link-local addresses.

I would still like to see the "169.254.0.0/16" changed to IN_LINKLOCAL, purpose of macro is to locate this value one place and one place only, scattering this string in the code undoes that.

Apr 26 2021, 7:08 PM · network
rgrimes added inline comments to D29968: Do not forward datagrams original from 169.254.0.0/16 link-local addresses.
Apr 26 2021, 2:26 PM · network

Apr 23 2021

rgrimes accepted D29850: param.h: Document __FreeBSD_version better.
Apr 23 2021, 12:15 PM

Apr 20 2021

rgrimes accepted D29850: param.h: Document __FreeBSD_version better.
Apr 20 2021, 4:49 PM
rgrimes accepted D29869: newvers.sh: better regexp for the FreeBSD_version line.

Thanks for chasing these down

Apr 20 2021, 4:46 PM
rgrimes accepted D29850: param.h: Document __FreeBSD_version better.

This is already a good improvement and acceptable as is with Greg's corrections.

Apr 20 2021, 6:31 AM
rgrimes added inline comments to D29850: param.h: Document __FreeBSD_version better.
Apr 20 2021, 6:26 AM

Apr 10 2021

rgrimes added reviewers for D29698: bhyve: do not intercept PCI BAR probe addresses: jhb, grehan.
Apr 10 2021, 9:46 PM

Apr 9 2021

rgrimes accepted D29657: bhyve: add SMBIOS Baseboard Information.
Apr 9 2021, 4:47 AM

Apr 7 2021

rgrimes accepted D29607: byhve: add option to specify IP address for gdb.

Though this is not exactly a normal service, to me listening on any by default is the correct thing to do here. One thing I would like to note, this code appears to only listens on one of IPv4 or IPv6, which is probably a short coming.

Apr 7 2021, 12:07 PM

Apr 6 2021

rgrimes added a comment to D26447: add deprecation notice to ftpd.

Hum, not a core system functionality? May I remind you that ftp://ftp.freebsd.org exists? Though it probably does not run the base system ftpd, it DOES run that functionality. Also so much for the project being a democracy, seems that core@ and security@ now simply dictate to developers@ how things are to be done... nothing personal Gordon, but that is exactly how this is coming across.

Apr 6 2021, 11:41 PM
rgrimes requested changes to D26447: add deprecation notice to ftpd.

Rather than spend cycles on deprecating USED features, please spend cycles on getting pkg base done so that those that feel they have no need for things like ftp/ftpd/telnet/telnetd/foo/bar/etc can choose to not have these and those of us who live and die by such tools can choose to have them.

Apr 6 2021, 1:15 PM

Mar 5 2021

rgrimes accepted D29069: pfctl: Add missing 'va' code point name.

I am ok with doing this, though it still leaves all the other issues open.

Mar 5 2021, 1:49 PM
rgrimes requested changes to D29069: pfctl: Add missing 'va' code point name.

Given the issues I would rather NOT add dscp support at all, until these issues can be addressed from down/upstream? The current situation, both in pfsense and freebsd is poor at best and may actually be one of the sources of issues we are seeing in our ECN data collection work. We know for a fact people are being told to use these ancient and obsolete TOS values by looking for them in blog posts and how-to's. Using the pry bar that is "reduce diffs between" as a reason to add a bad situation is an ever worse situation!

Mar 5 2021, 11:29 AM
rgrimes added a comment to D29069: pfctl: Add missing 'va' code point name.

I'd be happy to extend the man page to make that clearer. Do you have any suggested phrasing?

Mar 5 2021, 9:49 AM
rgrimes added a reviewer for D29069: pfctl: Add missing 'va' code point name: transport.
Mar 5 2021, 9:37 AM
rgrimes added a comment to D29069: pfctl: Add missing 'va' code point name.

I have a concern here, some of which goes beyond just this change, about aliasing DSCP to TOS. We (a small congestion control research group) have found that due to ambigious manual pages, headers and other factors, some present in PF it appears are causing mismarked traffic on the internet. DSCP is shifted left by the 2 ECN bits, the manual pages and any other documentation MUST be made explicity clear about this fact as to if your supplying the values as specified in the RFC"s on DSCP (unshifted) or are you applying TOS bits that may or may not have the ECN bits masked out.

Mar 5 2021, 8:58 AM
rgrimes accepted D29068: Put /boot/efi back in mtree.

This is a move in the right directions, at least this is state created by the installer.

Mar 5 2021, 8:24 AM

Mar 4 2021

rgrimes accepted D29056: net: Introduce IPV6_DSCP(), IPV6_ECN() and IPV6_TRAFFIC_CLASS() macros.
Mar 4 2021, 3:36 PM
rgrimes added a comment to D28814: hier.7: move ESP mountpoint to /efi (from /boot/efi).

Maybe a seperate pass over this code to try and clean up the fact that we have used the string "/efi" many places such that it should probably become some type of #define or derived from the system make file values so that any changes to this value can be done in one place and one place only and all things using it are fixed.

Mar 4 2021, 2:29 PM

Mar 3 2021

rgrimes accepted D28814: hier.7: move ESP mountpoint to /efi (from /boot/efi).

I personally prefer /efi, as I consider /boot to belong to FreeBSD and contain the FreeBSD specific boot code. EFI is a platform specific set of boot code and belongs to the system board, and though it may contain freeBSD specific code it may also contain OTHER code, especially in a multiboot environment.

Mar 3 2021, 12:45 PM

Feb 14 2021

rgrimes added a comment to D28645: Remove classful masks from interface addition code..

Infact it is probalby safer to assume a /24 than a /32.

No, please. It would assume, that the user is using the system in a home lan only.

/24 is not an assumption of home lab, it is the longest of the 3 prefixes that would of been picked before, and infact is probably most often the correct mask to be used.

Feb 14 2021, 2:35 AM

Feb 13 2021

rgrimes added a comment to D28645: Remove classful masks from interface addition code..

I would like to see a survey of what some other OS's due in this situation. I have participated in discussions elsewhere on this issue and just blindly making these host only, IMHO, is probably going to silently cause a lot of failures on finger memory. Infact it is probalby safer to assume a /24 than a /32. BUTT I think the preferable solution here may be to return an error if the netmask is not specified, thus doing nothing rather than guessing and doing something wrong.

Feb 13 2021, 12:29 PM

Feb 11 2021

rgrimes added a comment to D28568: Adding PRR sysctls to tcp(4) man page.

No statement about do_prr being on by default?

Feb 11 2021, 2:19 PM
rgrimes added inline comments to D28571: Add network related comments into the release notes.
Feb 11 2021, 2:13 PM

Feb 9 2021

rgrimes added a comment to D28545: netgraph/ng_bridge: Merge internal host entry structures..
  • Get rid of "hent" instead of "host".

This types of change just cause lots of noise in this review that makes it harder to see the real change.

That's why this change is a secondary modification.
Please choose the relevant part in the revision tab "History"

Feb 9 2021, 8:02 PM
rgrimes added a comment to D28545: netgraph/ng_bridge: Merge internal host entry structures..
  • Get rid of "hent" instead of "host".
Feb 9 2021, 2:54 PM

Feb 2 2021

rgrimes resigned from D28410: libvmm: clean up vmmapi.h.
Feb 2 2021, 12:55 AM

Feb 1 2021

rgrimes added a comment to D28410: libvmm: clean up vmmapi.h.
In D28410#636597, @rew wrote:

ping rgrimes@, does that sound reasonable to you?

Feb 1 2021, 8:00 PM

Jan 29 2021

rgrimes requested changes to D28410: libvmm: clean up vmmapi.h.
Jan 29 2021, 3:25 PM

Jan 25 2021

rgrimes accepted D28338: newvers: tweak uname to be more useful.

Yes please

Jan 25 2021, 9:11 PM

Jan 21 2021

rgrimes added a comment to D28265: kern: net: remove TCP_LINGERTIME.

How is the default 2 minute "linger" timer being implemented now if this is dead code? iirc this value use to be used when a socket was closed on the server side to control how long one waited in close_wait for the client to finish up the connection (server initiated close.)

Jan 21 2021, 2:11 PM

Jan 17 2021

rgrimes accepted D28209: Remove dependency of rc.d/tmp on grep.

This fixes at least one dependance on /usr, I see another later, mktemp which is /usr/bin/mktemp. I would of marked it above, but a full file context was not uploaded to this review.

Jan 17 2021, 2:09 PM

Dec 4 2020

rgrimes added a reviewer for D27463: Extend the VMM stats interface to support a dynamic count of statistics.: pmooney_pfmooney.com.
Dec 4 2020, 3:43 PM

Nov 24 2020

rgrimes added inline comments to D27348: Fix bhyve type19 SMBIOS handling to avoid losing 4GB.
Nov 24 2020, 3:19 PM

Oct 26 2020

rgrimes removed a reviewer for D26942: Replace literal uses of /usr/local with a macro defined in paths.h: rgrimes.
Oct 26 2020, 9:00 PM

Oct 25 2020

rgrimes added a comment to D26942: Replace literal uses of /usr/local with a macro defined in paths.h.

Though this is good intent, it is not a good approach. I'll assert again at one time we had erradicated all /usr/local from the base system, these above have crept in over time and again should be erradicated. There should never ever be a /usr/local #define in paths.h, having to recompile code to change this, again, is the wrong approach. This should _possibly_/_probably_ be moved to a kernel variable that can be changed at boot time.

Oct 25 2020, 9:00 PM

Oct 1 2020

rgrimes updated the summary of D10070: vmm.ko: retire compile time VM_MAXCPU, replace with per VM topology maxcpus.
Oct 1 2020, 4:29 PM

Sep 25 2020

rgrimes added inline comments to D26409: Add IP(V6)_VLAN_PCP to adjust 802.1 priority per-flow..
Sep 25 2020, 5:28 PM

Aug 25 2020

rgrimes added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 25 2020, 7:54 PM

Aug 22 2020

rgrimes added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 22 2020, 4:02 PM

Aug 19 2020

rgrimes added a comment to D25993: bpf(4): Update the manual page to reflect reality.

The summary of this review is lacking detail

Aug 19 2020, 4:40 PM

Aug 17 2020

rgrimes added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 17 2020, 2:54 AM

Aug 16 2020

rgrimes added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 16 2020, 4:18 PM

Aug 15 2020

rgrimes added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 15 2020, 2:50 PM

Aug 14 2020

rgrimes committed rS364236: Release rscheff from mentorship..
Release rscheff from mentorship.
Aug 14 2020, 4:44 PM

Aug 13 2020

rgrimes updated the test plan for D6656: net/tso: use the most restrictive segment size to perform the calculations.
Aug 13 2020, 11:06 PM
rgrimes updated the test plan for D6612: net: allow fast-forwarding TSO packets.
Aug 13 2020, 11:05 PM
rgrimes updated the test plan for D6611: net: translate inbound checksum offloading flags to outbound when forwarding.
Aug 13 2020, 11:04 PM
rgrimes added inline comments to D6612: net: allow fast-forwarding TSO packets.
Aug 13 2020, 6:59 PM
rgrimes added a reviewer for D6612: net: allow fast-forwarding TSO packets: gallatin.
Aug 13 2020, 2:38 PM
rgrimes added a reviewer for D6611: net: translate inbound checksum offloading flags to outbound when forwarding: gallatin.
Aug 13 2020, 2:32 PM
rgrimes added a comment to D6611: net: translate inbound checksum offloading flags to outbound when forwarding.

Is there any concern or additional work needed for ipV6?

Aug 13 2020, 2:32 PM
rgrimes added a reviewer for D6656: net/tso: use the most restrictive segment size to perform the calculations: gallatin.
Aug 13 2020, 2:29 PM
rgrimes accepted D18624: improvements to support code for RFC6675.
Aug 13 2020, 2:05 PM

Aug 12 2020

rgrimes added a comment to D26035: Refactor configuration management in bhyve..

To all those harping about it not being foo or bar or zed, this *is* an underlying frame work that is very flexible and allows one to implement what ever foo, bar or zed configuration you want on top of it. This leaves json, xml, or any other implementation out of the base layer code and those can be implemented in a layer above this. This has been discussed for a some time extensively by those that attend the semi-monthly bhyve call.

Aug 12 2020, 5:23 PM

Aug 7 2020

rgrimes accepted D25746: Address unintended jump of calculated cwnd when leaving slowstart.
Aug 7 2020, 3:33 PM

Aug 6 2020

rgrimes accepted D25976: TCP Cubic: Have Fast Convergence Heuristic work for ECN, and align concave region.

Approving as mentor only.

Aug 6 2020, 7:46 PM

Aug 1 2020

rgrimes added a comment to D25876: bhyve: Passthrough host's NVMe device health logpage to guests..

...
Your observation that the data units values restart at zero is very valid. My tentative plan for this is to optionally save the current values when the VM is powered down using the new configuration file format. This saved device state could then be used on a subsequent restart to provide the continuity you describe.

Aug 1 2020, 5:21 PM

Jul 31 2020

rgrimes accepted D24952: ipfirewall.4: restructure new line starts and remove .Tn.

Reflowing sentences and removal of .Tn seems like busy work to me. Much easier to just make mandoc ignore .Tn and igor silent on its usage. These macros DO make the groff man pages output look different, and IMHO, nicer.

Jul 31 2020, 4:11 PM
rgrimes added inline comments to D25793: 10Gigabit Ethernet driver for AMD SoC.
Jul 31 2020, 2:52 PM

Jul 30 2020

rgrimes accepted D10335: VirtFS/9p filesystem passthrough support (virtio-9p).

I still see request changes markers from emaste and jhb/bhyve, what are these changes?

Jul 30 2020, 4:04 PM

Jul 28 2020

rgrimes added a comment to D25833: Remove AES-CBC ciphers from default server and client lists..

Could we please get stances in /etc/sshd/ssh{,d}_config commented out that show how to enable these if they are needed?

For example,

Ciphers +aes128-cbc,aes192-cbc,aes256-cbc

I'd rather not deviate from upstream, but if we must I'd rather do so in sshd_config, not in the source.

Jul 28 2020, 1:20 AM

Jul 27 2020

rgrimes accepted D25833: Remove AES-CBC ciphers from default server and client lists..
Jul 27 2020, 5:32 PM
rgrimes added a comment to D25833: Remove AES-CBC ciphers from default server and client lists..

Could we please get stances in /etc/sshd/ssh{,d}_config commented out that show how to enable these if they are needed?

Jul 27 2020, 5:32 PM
rgrimes added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Can we add an appropriate SPDX tag to the source files as well - e.g. /* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */ or similar?

Need a clarification here please. The license text in the source files has additional text (part of it give below) apart from the normal BSD-3-Clause text. If this is not an issue, we can use /* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */. Please clarify.

Jul 27 2020, 5:10 PM

Jul 24 2020

rgrimes added a comment to D25566: apropos(1) and makewhatis(8): Update HISTORY sections.

I have no objection to it, but it is still not totally factual, more than likely it was "intergrated" into FreeBSD Current/Head when it was at 12 and merged back to stable/11 and first appeared in a FreeBSD release at 11.1. I still do not see any added value to the history of mandoc by this change, and it just makes FreeBSD have a local diff to the mandoc from witch it was derived. Speaking of which, shouldn't this be on a vendor branch?

Jul 24 2020, 10:47 PM

Jul 21 2020

rgrimes accepted D24657: update cwnd in both convex and concave regions like comment stated..
Jul 21 2020, 3:19 PM

Jul 20 2020

rgrimes accepted D25744: Add MODULE_VERSION to TCP loadable congestion control modules..
Jul 20 2020, 11:04 PM
rgrimes accepted D25746: Address unintended jump of calculated cwnd when leaving slowstart.
Jul 20 2020, 10:51 PM

Jul 16 2020

rgrimes accepted D10335: VirtFS/9p filesystem passthrough support (virtio-9p).
Jul 16 2020, 4:49 PM
rgrimes added a reviewer for D25334: Add lib9p to the build, squashed and rebased off master 20200617: rgrimes.
Jul 16 2020, 4:46 PM

Jul 15 2020

rgrimes added inline comments to D25312: Relax the rule against declaring variables in nested scopes..
Jul 15 2020, 4:53 PM
rgrimes added inline comments to D25312: Relax the rule against declaring variables in nested scopes..
Jul 15 2020, 4:45 PM
rgrimes added inline comments to D25312: Relax the rule against declaring variables in nested scopes..
Jul 15 2020, 4:38 PM

Jul 10 2020

rgrimes added inline comments to D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.
Jul 10 2020, 4:16 PM · network
rgrimes added a comment to D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

I see a fair amount of white space/formatting only changes in this, it MAY make since to break those out as 0 effort review.
I also have concerns over any performance claims, though I see the old code is probably at least sub optimal in that it often checks for UDP, then for TCP when the volume of traffic should almost always be mostly TCP. Also modern compilers should just "handle this" without rewritting code unless something odd is being done. If you really want to micro optimize I suspect rewriting this as "branchless" code that results in cmovl or other instructions might be interesting. I have heard of 40x code speed improvements using such tenchiques, but that is mostly in tight loops.

Jul 10 2020, 3:47 PM · network