Page MenuHomeFreeBSD

rgrimes
User

Projects

User Details

User Since
Dec 19 2016, 4:11 AM (117 w, 1 d)

Recent Activity

Today

rgrimes added a comment to D19317: Use IN_foo() macros from sys/netinet/in.h inplace of handcrafted code.

Can I get some final accept on this, I updated the open issues

Tue, Mar 19, 3:01 AM

Fri, Mar 15

rgrimes added inline comments to D19587: net: adjust randomized address bits.
Fri, Mar 15, 7:42 PM

Thu, Mar 14

rgrimes accepted D19580: Fix bhyve PCIe capability emulation.
Thu, Mar 14, 11:38 AM
rgrimes added reviewers for D19580: Fix bhyve PCIe capability emulation: jhb, rgrimes.
Thu, Mar 14, 11:34 AM
rgrimes accepted D19579: Fix bhyve's NVMe Identify Namespace data.
Thu, Mar 14, 11:30 AM
rgrimes added a reviewer for D19579: Fix bhyve's NVMe Identify Namespace data: jhb.
Thu, Mar 14, 11:29 AM

Mon, Mar 11

rgrimes added inline comments to D19357: PFIL_MEMPTR support for ipfw link level hook.
Mon, Mar 11, 10:05 PM
rgrimes accepted D19535: Support device-independent labels for geom_flashmap slices..
Mon, Mar 11, 5:16 PM
rgrimes added a comment to D19535: Support device-independent labels for geom_flashmap slices..

I like it, just nits, that for the most part you can ignore, other than $FreeBSD: vs $FreeBSD$

Mon, Mar 11, 5:16 PM

Sat, Mar 9

rgrimes added a comment to D19506: Fix bug in bhyve by ignoring writes to errata MSRs in AMD cpus.

This appears to be used to deal with a core hang on specific CPU's, we need to see that we have mitigated that in the host, and the decide what the appropriate action here is, I am uncomfortable with just making this silently disappear. Deferning to jhb.

Sat, Mar 9, 7:55 PM · bhyve
rgrimes added a comment to D19506: Fix bug in bhyve by ignoring writes to errata MSRs in AMD cpus.

Though this does fix your issue by silencing the log, it does little to improve the situation. I think what we may want to do is to add yet another option to the bhyve command that along with -w to ignore invalid MSR access to do so silently so that we do not have to add code like this everything a new msr comes into play. John, Patrick your thoughts on this approach?

Sat, Mar 9, 1:44 PM · bhyve
rgrimes added reviewers for D19506: Fix bug in bhyve by ignoring writes to errata MSRs in AMD cpus: jhb, pmooney_pfmooney.com.
Sat, Mar 9, 1:34 PM · bhyve

Fri, Mar 8

rgrimes added a comment to D19426: post-commit hooks: Accept BZ URLs in PR lines.

I would be comfortable with simply "https://bugs.freebsd.org/12344" as that can likely work forever.

Note that https://bugs.freebsd.org/12344 does work - we should accept either https://bugs.freebsd.org/bugzilla/show_bug.cgi?id= or https://bugs.freebsd.org/[0-9]+

Fri, Mar 8, 9:33 PM
rgrimes added a comment to D19459: subversion: update commit message template to allow URLs in PR field.

I believe what your wanting is web server re-write rules, that would rewrite the URL in and out of the web pages to have the preffered form. Beyond my area of expertise to implement, but I know it can be done and that is probably the easiest place to do it (ie, no modifying bugzilla should be required.)

Fri, Mar 8, 4:43 PM

Thu, Mar 7

rgrimes accepted D19501: bhyve virtio needs barriers.
Thu, Mar 7, 8:51 PM
rgrimes accepted D19499: bhyve uart broken for win2016 guest.

I removed a redundant "to" in the description. Patch looks good to me. Copyright over to jhb@

Thu, Mar 7, 8:47 PM · bhyve
rgrimes updated the summary of D19499: bhyve uart broken for win2016 guest.
Thu, Mar 7, 8:46 PM · bhyve

Wed, Mar 6

rgrimes accepted D19485: Drop "All rights reserved" from my copyright statements..
Wed, Mar 6, 9:58 PM
rgrimes added inline comments to D19485: Drop "All rights reserved" from my copyright statements..
Wed, Mar 6, 9:28 PM
rgrimes added a comment to D19485: Drop "All rights reserved" from my copyright statements..

I'll review if you ack your are done updating John

Wed, Mar 6, 8:07 PM
rgrimes accepted D19485: Drop "All rights reserved" from my copyright statements..
Wed, Mar 6, 7:46 PM

Tue, Mar 5

rgrimes accepted D19460: subversion: update commit message template to allow URLs in PR field.
Tue, Mar 5, 7:42 PM
rgrimes added a comment to D19460: subversion: update commit message template to allow URLs in PR field.

Close, very very close, but still slightly short of leaving no doubt as to what goes here.

Tue, Mar 5, 7:22 PM

Mon, Mar 4

rgrimes added inline comments to D19459: subversion: update commit message template to allow URLs in PR field.
Mon, Mar 4, 10:12 PM

Fri, Mar 1

rgrimes added a reviewer for D19426: post-commit hooks: Accept BZ URLs in PR lines: rgrimes.
Fri, Mar 1, 9:24 PM
rgrimes added a comment to D19426: post-commit hooks: Accept BZ URLs in PR lines.

Missing is the change to the commit message template to update it to say URL instead of PRxxxx

Fri, Mar 1, 9:23 PM
rgrimes accepted D19422: if_vxlan(4) Allow set MTU more than 1500 bytes..
Fri, Mar 1, 4:56 PM

Thu, Feb 28

rgrimes added inline comments to D19317: Use IN_foo() macros from sys/netinet/in.h inplace of handcrafted code.
Thu, Feb 28, 2:51 PM
rgrimes updated the diff for D19317: Use IN_foo() macros from sys/netinet/in.h inplace of handcrafted code.

Convert nat64_check_ip4 in sys/netpfil/ipfw/nat64/nat64_translate.h to use IN_foo macros rather than hand rolled code.

Thu, Feb 28, 2:50 PM
rgrimes added a reviewer for D19400: attempt to load vmm.ko if it's not already loaded (bhyveload): jhb.
Thu, Feb 28, 2:01 AM
rgrimes added a reviewer for D19400: attempt to load vmm.ko if it's not already loaded (bhyveload): bhyve.
Thu, Feb 28, 2:00 AM

Wed, Feb 27

rgrimes accepted D19299: bhyve can miss PIR wake-ups.
Wed, Feb 27, 9:01 PM · bhyve
rgrimes added inline comments to D19299: bhyve can miss PIR wake-ups.
Wed, Feb 27, 8:42 PM · bhyve
rgrimes added a comment to D19380: build SD images for boards.
In D19380#414840, @manu wrote:

I don't think this is a good approach.
My goal for this is :

  • Finish u-boot-install (https://gist.github.com/evadot/1bcad7c4c1e5cc7f9a692f4d19ab5421) to handle multi file u-boot
  • Do a rpi-fw-install script and include it in the rpi-firmware package
  • Create to GENERICSD image for arm64 (like the armv7 one), one with MBR and one with GPT scheme.
  • Remove board configs that have no quirks from release.
  • re@ could then create only two images (GENERICSD-MBR, GENERICSD-GPT) and install u-boot on each one based on list somewhere.
Wed, Feb 27, 7:27 PM
rgrimes updated the test plan for D19380: build SD images for boards.
Wed, Feb 27, 7:25 PM
rgrimes added a comment to D19316: IPV4 Experimental address space usage and cleanup of code not using IN_foo.

I agree with John that we should do everything we can to eliminate class A/B/C rather than just shuffle it around. ..trimmed...

Some of the patches I have already posted do infact remove the direct use of IN_CLASSA by use of the proper macro IN_LOOPBACK. I shall keep an eye out as I look over the code for issues that effect my stated goals in cleaning up things such that IN_ZERONET, IN_LOOPBACK, and IN_EXPERIMENTAL can be used to fully effect all places that are trying to deal with these ranges should they ever be redefined.

Wed, Feb 27, 2:27 PM

Mon, Feb 25

rgrimes accepted D19218: fix nfsuserd to find a mapped "localhost" ip address and to use INET6 when INET isn't available.

The added kernel code seems to be mssing INET/INET6 ifdefs. None of the inline comments are marked done, but the code looks as if you have addressed them.

Mon, Feb 25, 1:08 AM
rgrimes added a comment to D19316: IPV4 Experimental address space usage and cleanup of code not using IN_foo.

Re: Classs A/B/C: I'd be quite happy to see those definitions go away.

In my first pass audit of a search results on IN_CLASS[A-E] the common use cases here are the default calculation of netmasks, 2 minutes ago I would of told you that probably can not go away, but it just hit me, IN_DEFAULTMASKFOR(i) could be written that would incorporate the ancient class rules in a central place and cleaning up some code. Thoughts?

Mon, Feb 25, 12:58 AM

Sun, Feb 24

rgrimes added a comment to D19316: IPV4 Experimental address space usage and cleanup of code not using IN_foo.

I don't understand the purpose of this review. As it says, these changes should not be committed. I'm not actually sure of the official status of Class E, although I suspect it is still experimental/not for production use.

The changes well need expansion, the present form is to make a patch available so that the other patches can be tested.
A walk down through the RFC's say a few things, one is that it is not called Class E anymore. It is still reserved.

Sun, Feb 24, 6:08 PM
rgrimes added a reviewer for D19317: Use IN_foo() macros from sys/netinet/in.h inplace of handcrafted code: kristof.
Sun, Feb 24, 5:51 PM
rgrimes removed a reviewer for D19316: IPV4 Experimental address space usage and cleanup of code not using IN_foo: bz.
Sun, Feb 24, 5:30 PM
rgrimes edited reviewers for D19317: Use IN_foo() macros from sys/netinet/in.h inplace of handcrafted code, added: karels; removed: bz.
Sun, Feb 24, 5:30 PM
rgrimes added a reviewer for D19316: IPV4 Experimental address space usage and cleanup of code not using IN_foo: karels.
Sun, Feb 24, 5:29 PM
rgrimes updated the diff for D19317: Use IN_foo() macros from sys/netinet/in.h inplace of handcrafted code.

Add some more places that hand crafted macros are used, ip_input, ip_output, netdump code.

Sun, Feb 24, 7:38 AM
rgrimes added a parent revision for D19317: Use IN_foo() macros from sys/netinet/in.h inplace of handcrafted code: D19316: IPV4 Experimental address space usage and cleanup of code not using IN_foo.
Sun, Feb 24, 5:37 AM
rgrimes added a child revision for D19316: IPV4 Experimental address space usage and cleanup of code not using IN_foo: D19317: Use IN_foo() macros from sys/netinet/in.h inplace of handcrafted code.
Sun, Feb 24, 5:37 AM
rgrimes created D19317: Use IN_foo() macros from sys/netinet/in.h inplace of handcrafted code.
Sun, Feb 24, 5:36 AM
rgrimes created D19316: IPV4 Experimental address space usage and cleanup of code not using IN_foo.
Sun, Feb 24, 5:10 AM
rgrimes committed rS344490: MFC r339707: Allow fdisk(8) to deal with sectors larger than 2048.
MFC r339707: Allow fdisk(8) to deal with sectors larger than 2048
Sun, Feb 24, 1:56 AM

Sat, Feb 23

rgrimes updated the diff for D18755: Add accessor for vm->maxcpus in preperation for run time maxcpu setting.

Address review comments from Patrick Mooney. Found some additional places that caching would be helpful so update them too.

Sat, Feb 23, 7:06 PM

Fri, Feb 22

rgrimes added a comment to D19299: bhyve can miss PIR wake-ups.

In the future it helps to upload full file diffs, not sure what vcs your using or what its command is, for svn I use svn diff -x U999999.

Fri, Feb 22, 10:53 PM · bhyve
rgrimes added inline comments to D18755: Add accessor for vm->maxcpus in preperation for run time maxcpu setting.
Fri, Feb 22, 6:23 PM
rgrimes added a comment to D19218: fix nfsuserd to find a mapped "localhost" ip address and to use INET6 when INET isn't available.

Whether or not "#ifdef INET6" and "#ifdef INET" should be in the code is still an open question.
I was hoping bz@ could answer this?
(I, personally, was of the understanding that this was no longer required/recommended for
FreeBSD sources. If bz@ does not know the correct answer for this, I will ask on freebsd-net@.)
At this point I have made no changes to the Makefile.
To build/run it, there is a small kernel change required, but I did not include that in this review.

Fri, Feb 22, 12:51 AM

Thu, Feb 21

rgrimes added inline comments to D18846: Move amd apic page and intel guest_msrs pages into seperate data structures.
Thu, Feb 21, 8:56 PM
rgrimes updated the diff for D18998: Make bhyve SMBIOS table topology aware.

Add handling of cores or threads > 254 by truncating to 0, per smbios 2.6 spec

Thu, Feb 21, 8:42 PM
rgrimes added a comment to D18998: Make bhyve SMBIOS table topology aware.
In D18998#412749, @jhb wrote:

FYI, you can get SMBIOS specs here: https://www.dmtf.org/standards/smbios

Thu, Feb 21, 8:24 PM
rgrimes added a comment to D18815: Bhyve acpi MADT table correction for VM_MAXCPU > 21.

It doesn't looks quite right! I need more time to articulate better arguments, but this patch as it is, must not be committed in.

Thu, Feb 21, 3:57 PM
rgrimes added inline comments to D18815: Bhyve acpi MADT table correction for VM_MAXCPU > 21.
Thu, Feb 21, 3:55 PM
rgrimes updated the diff for D18815: Bhyve acpi MADT table correction for VM_MAXCPU > 21.

Wrap comment text, provide details of MADT_SIZE formula

Thu, Feb 21, 3:47 PM
rgrimes updated the diff for D18755: Add accessor for vm->maxcpus in preperation for run time maxcpu setting.

Update to incorporate feedback from bde@ (mentor), wrap long lines, sort prototypes within group vm_get* in sys/amd64/include/vmm.h.

Thu, Feb 21, 8:15 AM
rgrimes requested changes to D19218: fix nfsuserd to find a mapped "localhost" ip address and to use INET6 when INET isn't available.

I smashed the wrong thing. I do not see the Makefile in the diffs, nor do I see the inline #ifdef's.

Thu, Feb 21, 6:10 AM
rgrimes accepted D19218: fix nfsuserd to find a mapped "localhost" ip address and to use INET6 when INET isn't available.
In D19218#412405, @bz wrote:

I think doing DNS things for these is not a good thing. Especially given inside an IP jail a "localhost" will give you different results.

Could you elaborate on that "give you different results?" This may be the very thing I am trying to say, and it may be what could break this code if run inside a jail, or in my other cases test bed with modified localhost value.

Thu, Feb 21, 6:06 AM

Wed, Feb 20

rgrimes edited reviewers for D8100: Bhyve hypercall implementation, added: bhyve; removed: grehan.
Wed, Feb 20, 6:30 PM
rgrimes removed a reviewer for D2469: Allow byte reads of AHCI registers.: grehan.
Wed, Feb 20, 6:14 PM
rgrimes removed a reviewer for D11768: Add support to devel/libhyve-remote. (VNC Server): grehan.
Wed, Feb 20, 6:09 PM
rgrimes removed a reviewer for D2350: Implement NMI window exiting on AMD/SVM processors.: grehan.
Wed, Feb 20, 5:59 PM
rgrimes removed a reviewer for D2838: Add on bhyvectl the capability to list the running vms.: grehan.
Wed, Feb 20, 5:58 PM
rgrimes removed a reviewer for D9033: Raise BLOCKIF_IOV_MAX to 128. : grehan.
Wed, Feb 20, 5:57 PM
rgrimes edited reviewers for D10009: Fix a memory leak in bhyve, added: bhyve; removed: grehan.
Wed, Feb 20, 5:57 PM
rgrimes removed a reviewer for D10335: VirtFS/9p filesystem passthrough support (virtio-9p): grehan.
Wed, Feb 20, 5:55 PM
rgrimes removed a reviewer for D12419: HD Audio Emulation For Bhyve (Based on D7840): grehan.
Wed, Feb 20, 5:55 PM
rgrimes removed a reviewer for D10070: vmm.ko: retire compile time VM_MAXCPU, replace with per VM topology maxcpus: grehan.
Wed, Feb 20, 5:52 PM

Tue, Feb 19

rgrimes added a comment to D18816: bhyve vmm statistics tables need to be sized relative to VM_MAXCPU.
In D18816#411819, @jhb wrote:
In D18816#411818, @jhb wrote:

Pasting a reply from Rod:

I am just trying to fix the current bug that this code does not
work correctly if you raise VM_MAXCPU, it starts to give you
problems at something like 24 due to the stats array not having
space for the ipi table that tries to get added.

This also documents the size dependancy and removes the
false /* arbitrary */ comment.

The problem is you can't change it. Changing the constant in vmm_dev.h changes the ABI since the size of the structure is assumed in vmm_stat_copy()'s current API and that is also encoded in the ioctl value since the size of the structure is part of the constant. One of the approaches I described above is the only way you can do this without breaking the ABI.

Tue, Feb 19, 7:21 PM
rgrimes added inline comments to D18755: Add accessor for vm->maxcpus in preperation for run time maxcpu setting.
Tue, Feb 19, 7:04 PM
rgrimes added a comment to D13706: sysv_ipc.c: merge copyright assignment to the NetBSD Foundation.

pfg I think you miss understood, and upon looking I was not clear, it is not you that I am unhappy with about "playing with copyrights and licenses", it is NetBSD and possibly Charles Hannum who as Robert points out modified a license without ALL authors approval. I would be very upset if someone disturbed my disclaimer in this manner.

Tue, Feb 19, 6:17 PM
rgrimes added a comment to D18816: bhyve vmm statistics tables need to be sized relative to VM_MAXCPU.

The review does nothing about addressing your other issues, it simply corrects a current state of affairs that is wrong if you raise VM_MAXCPU above 24.

Tue, Feb 19, 5:58 PM
rgrimes added inline comments to D18815: Bhyve acpi MADT table correction for VM_MAXCPU > 21.
Tue, Feb 19, 5:55 PM
rgrimes added inline comments to D18755: Add accessor for vm->maxcpus in preperation for run time maxcpu setting.
Tue, Feb 19, 5:45 PM
rgrimes added a comment to D18944: freebsd-update: Clarify unclear help text.

Ping

Tue, Feb 19, 5:29 PM
rgrimes commandeered D10070: vmm.ko: retire compile time VM_MAXCPU, replace with per VM topology maxcpus.
Tue, Feb 19, 5:02 PM
rgrimes added child revisions for D10070: vmm.ko: retire compile time VM_MAXCPU, replace with per VM topology maxcpus: D18815: Bhyve acpi MADT table correction for VM_MAXCPU > 21, D18998: Make bhyve SMBIOS table topology aware, D18816: bhyve vmm statistics tables need to be sized relative to VM_MAXCPU, D18755: Add accessor for vm->maxcpus in preperation for run time maxcpu setting, D18846: Move amd apic page and intel guest_msrs pages into seperate data structures.
Tue, Feb 19, 5:00 PM
rgrimes added a parent revision for D18755: Add accessor for vm->maxcpus in preperation for run time maxcpu setting: D10070: vmm.ko: retire compile time VM_MAXCPU, replace with per VM topology maxcpus.
Tue, Feb 19, 5:00 PM
rgrimes added a parent revision for D18846: Move amd apic page and intel guest_msrs pages into seperate data structures: D10070: vmm.ko: retire compile time VM_MAXCPU, replace with per VM topology maxcpus.
Tue, Feb 19, 5:00 PM
rgrimes added a parent revision for D18816: bhyve vmm statistics tables need to be sized relative to VM_MAXCPU: D10070: vmm.ko: retire compile time VM_MAXCPU, replace with per VM topology maxcpus.
Tue, Feb 19, 5:00 PM
rgrimes added a parent revision for D18998: Make bhyve SMBIOS table topology aware: D10070: vmm.ko: retire compile time VM_MAXCPU, replace with per VM topology maxcpus.
Tue, Feb 19, 5:00 PM
rgrimes added a parent revision for D18815: Bhyve acpi MADT table correction for VM_MAXCPU > 21: D10070: vmm.ko: retire compile time VM_MAXCPU, replace with per VM topology maxcpus.
Tue, Feb 19, 5:00 PM
rgrimes retitled D10070: vmm.ko: retire compile time VM_MAXCPU, replace with per VM topology maxcpus from WIP: make VM_MAXCPU tunable to vmm.ko: retire compile time VM_MAXCPU, replace with per VM topology maxcpus.
Tue, Feb 19, 4:58 PM
rgrimes added a comment to D10070: vmm.ko: retire compile time VM_MAXCPU, replace with per VM topology maxcpus.

Fabian, I have done some other work that moves forward with this concept, mostly correcting stuff that puts limits in place on how high VM_MAXCPU can go, and have WIP that actually changes this to a run time per vm value. Can we either abandon and retire this differential, and I'll start a new one or can I commandeer this one and make all the other work subordanate to it?

Tue, Feb 19, 4:34 PM
rgrimes added a comment to D13706: sysv_ipc.c: merge copyright assignment to the NetBSD Foundation.

Upon closer examination of this there are some issues, it alters a license post fact of copyrights asserted by some, and changes the clause in the license from Author to NetBSD, which effects the since of the copyright. I really wish the playing with Copyrights and Licenses would stop, this is a good example, of a well meant change, causing an ugly problem. For examle, the disclaimer is now in the name NetBSD, so what happened to the disclaim asserted by nCircle Network, and Robert Watson?

Tue, Feb 19, 4:15 PM

Mon, Feb 18

rgrimes added a comment to D19218: fix nfsuserd to find a mapped "localhost" ip address and to use INET6 when INET isn't available.

W.r.t. the NFS root mount, you are sort of correct at this time.
What would happen for an NFSv4 root mount at this time is
that the NFS client code would have a miss on the "uid<->username"
cache and attempt an upcall to the nfsuserd, which would not
work. (I think it will eventually fail and use "nobody", but I'd have
to look at the code to be sure.
As such, NFSv4 root mounts are not currently recommended, but I
would like to resolve that someday.

Mon, Feb 18, 3:58 PM
rgrimes added a comment to D19218: fix nfsuserd to find a mapped "localhost" ip address and to use INET6 when INET isn't available.

The problem with doing a name lookup in this daemon is that it assumes/expects it
to work. Often (an NFS mounted root fs is one example and a system configured to
use DNS before the local /etc/hosts file) are not yet working and an NFS mount is
expected to work.
(ie. In general I'd agree with you, but for NFS not so much...)

Mon, Feb 18, 2:20 AM

Feb 16 2019

rgrimes added a comment to D19218: fix nfsuserd to find a mapped "localhost" ip address and to use INET6 when INET isn't available.

I can not speak much for all this code, other than to say I can read it and pretty much understand what is going on, however I would like to address the issue that this code is missing the conditional compilation on if I even want either or both of IPv4 or ipv6 supported. I believe most (all) our other code has #ifdef INET or #ifdef INET6 in it, see usr.bin/netstat as an example. I am not hardbound on using "localhost" as a grep of the code shows this has seriously been ignored, which means /etc/hosts is no longer the source of truth for the value of localhost :-(.

Feb 16 2019, 11:18 PM

Feb 15 2019

rgrimes closed D19202: bhyve(8) pci_xhci.c elliminate possible double free of uopt.
Feb 15 2019, 4:48 PM
rgrimes committed rS344160: In r340044 an attempt to quiet coverity warning cid 1357336.
In r340044 an attempt to quiet coverity warning cid 1357336
Feb 15 2019, 4:48 PM
rgrimes closed D19200: bhyve(8) block_if.c remove multiple freeing of nopt added in r340042.
Feb 15 2019, 4:21 PM
rgrimes committed rS344159: In r340042 an attempt to quiet coverity warning cid 1305412 was overdone..
In r340042 an attempt to quiet coverity warning cid 1305412 was overdone.
Feb 15 2019, 4:20 PM

Feb 14 2019

rgrimes added a comment to D19202: bhyve(8) pci_xhci.c elliminate possible double free of uopt.

Address jhb style 9 issues

Feb 14 2019, 8:23 PM
rgrimes updated the diff for D19202: bhyve(8) pci_xhci.c elliminate possible double free of uopt.

Move initialization of uopt to after declares addressing jhb style(9) issue

Feb 14 2019, 8:23 PM
rgrimes created D19202: bhyve(8) pci_xhci.c elliminate possible double free of uopt.
Feb 14 2019, 8:00 PM
rgrimes created D19200: bhyve(8) block_if.c remove multiple freeing of nopt added in r340042.
Feb 14 2019, 7:28 PM