Page MenuHomeFreeBSD

rgrimes
User

Projects

User Details

User Since
Dec 19 2016, 4:11 AM (171 w, 1 d)

Recent Activity

Yesterday

rgrimes accepted D24107: Bhyve: fix SMBIOS Type 17 table generation.
Mon, Mar 30, 10:05 PM
rgrimes added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.

I am happy with the other fixes, not sure if there is a need to fix or error check memory size bit overflows

Mon, Mar 30, 10:05 PM

Sun, Mar 29

rgrimes added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Sun, Mar 29, 1:14 AM
rgrimes added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.
  • Rework type17 generation and error out on overflow.

There is no need to error out on overflow here. The type17 isn't used by most o/s's for determining how much memory is available: there is e820, the EFI memory map, etc etc. Perhaps print an error in bhyve, buit there doesn't seem any point in erroring out.

Sun, Mar 29, 1:09 AM

Sat, Mar 28

rgrimes added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Sat, Mar 28, 11:20 AM

Fri, Mar 27

rgrimes added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.
In D24107#532391, @jhb wrote:

I think we should go with 2.7 btw. Systems shouldn't read 2.7 fields if we advertise 2.6 since those fields "shouldn't exist". OTOH, the spec does say systems are permitted to use the length of individual structures to determine which optional fields exist.

Fri, Mar 27, 4:51 PM
rgrimes added inline comments to D24107: Bhyve: fix SMBIOS Type 17 table generation.
Fri, Mar 27, 1:25 AM
rgrimes accepted D24199: Create and use a tests group for the tests user..

Thanks, and this should happen in the port too as you pointed out it was also doing the wrong thing.

Fri, Mar 27, 12:54 AM

Fri, Mar 20

rgrimes requested changes to D24107: Bhyve: fix SMBIOS Type 17 table generation.

This code should work without a need to split memory up into 32GB Dimms

Fri, Mar 20, 7:12 PM
rgrimes added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.

Argg.. you did at the new field. Hum, I am reading 3.3.0 type 17 now.

Fri, Mar 20, 6:28 PM
rgrimes added a comment to D24107: Bhyve: fix SMBIOS Type 17 table generation.

In looking at the SMBios 2.7 change list in DSP01342.7.1.pdf (final version of 2.7) on page 134 There is a memory device (type 17) update that you also need to implement to allow DIMM's >32GB. In my work on VM_MAXCPU's I found it would actually be desirable at some point to get to 3.X version of some form, can not recall exactly what the minimum was right now, but reading a newer change log I see some interesting things like in 3.0.0 add GUID value for discovering SMBIOS tables in UEFI, which iirc would help our UEFI situation, add new entry for extended BIOS ROM size, oh here it is 3.0.0 Type 4, extned core, core eabled and thread count ranges. Looking at the change list in the 3.3.0 spec between 2.6 and 3.0.0 is not a huge task as much of it does not apply to bhyve.

Fri, Mar 20, 6:26 PM

Sun, Mar 15

rgrimes added a comment to D23971: [bhyve][virtio-net] Add MTU advice support.

I still object to range testing MTU here, but less so now that the values are closer to implementation limits. Base reason for objection is your range testing data at the producer, and it is the consumer that this should be, and I believe already is, done at.

Sun, Mar 15, 5:56 PM

Wed, Mar 11

rgrimes added a comment to D23971: [bhyve][virtio-net] Add MTU advice support.

Let me try again to make my point of why it is wrong for this code to have ANY checks on the value of MTU other than to fit in the datatype.
The in kernel vtnet device ALREADY contains code that enforces the implementation specific limits of this value, and is a single place to make adjustments to those values.
See src/sys/dev/vertio/network/if_vtnet.c at about line 1044:

if (new_mtu < ETHERNMIN || new_mtu > VTNET_MAX_MTU)
    return (EINVAL);

This should be the sole place that limits on this value are enforced, and doing so any other place is just duplicate code that raises the work to maintain the code.

Wed, Mar 11, 2:11 AM

Tue, Mar 10

rgrimes accepted D23329: Make ICMP redirect processing depend on routing daemon.
Tue, Mar 10, 8:10 PM
rgrimes added a comment to D23971: [bhyve][virtio-net] Add MTU advice support.

The kernel device, vtnet, already does proper bounds check on mtu, returns an error if it is <ETHERMIN || >VTNET_MAX_MTU, adding range check code here just increases code maintanance, and if it is done it MUST much the kernel implementation (Which oddly has 65536 as VTNET_MAX_MTU, so even the 65535 above is a false collapse of capabilities.

Tue, Mar 10, 8:02 PM
rgrimes added a comment to D23971: [bhyve][virtio-net] Add MTU advice support.

I have no idea why someone thinks a network device should have a minimum MTU of 1280, that is simply the IPv6 value, ethernet is very happy to transfer 64 byte packets. There should be some implementation detail of the in kernel vt driver that can at least go that small, and perhaps smaller as you do not have the collision detection minimum wire time that ethernet has(had).

So you suggest to violate RFC 6540 and disallow IPv6? ATM has a very small frame size, but the fragmentation FRF.8 is part of the standard. For IPv4 the minimum MTU is 512, for IPv6 it is 1280, even is the medium at layer 2 is able to transport smaller frames (which is perfectly allowed by a minimal maximum). 802.3 is even able to transport smaller packets than the minimum frame size ...
What do I miss?

Tue, Mar 10, 7:50 PM
rgrimes requested changes to D23971: [bhyve][virtio-net] Add MTU advice support.

I have no idea why someone thinks a network device should have a minimum MTU of 1280, that is simply the IPv6 value, ethernet is very happy to transfer 64 byte packets. There should be some implementation detail of the in kernel vt driver that can at least go that small, and perhaps smaller as you do not have the collision detection minimum wire time that ethernet has(had).

Tue, Mar 10, 5:59 PM

Fri, Mar 6

rgrimes added inline comments to D23971: [bhyve][virtio-net] Add MTU advice support.
Fri, Mar 6, 7:21 PM
rgrimes accepted D23987: [if_vtnet] Add VIRTIO_NET_F_MTU flag support..
Fri, Mar 6, 7:06 PM

Mon, Mar 2

rgrimes added a comment to D23928: Add deprecation notices to ce,cp,mn sync serial drivers.

Why are we dropping these (other than cx?)

Mon, Mar 2, 6:16 PM

Feb 16 2020

rgrimes added a comment to D23690: pkgbase: return most config files back to ^/etc.

Breaking this comment up a bit to respond to it:

Perhaps we should have this discussion on arch? I find phabricator a horrible place to try and do this level of a discussion.

Feb 16 2020, 6:19 PM
rgrimes added a comment to D23690: pkgbase: return most config files back to ^/etc.

Why not go back exactly how it was before? Why change additional things like ttys (note that the use of arch subdir symatics is matching to other parts of the tree. How did you arrive at this patch, what was the mechanics you went through? Why not put rc.d back? What about rather than using .PATH have the reachover to call into etc/Makefile to install the sub component? I do need to look at this much closer,. Thats all for now.

Feb 16 2020, 6:01 PM
rgrimes accepted D23687: Fix sporadic odd MSS values when TCP HostCache is not in use.

OK, I double checked the code. I think the way to go is taking your change to tcp_hc_get() and not do the initialisations in cc_conn_init() and tcp_mss_update().

...
I concur with Michael's conclusion, the struct initializers are unneeded and wasteful of cycles, and accept the differential based on them being removed before commiot.

Feb 16 2020, 5:35 PM

Feb 13 2020

rgrimes accepted D23329: Make ICMP redirect processing depend on routing daemon.

...

PR created for other routing daemon I do not maintain:

  • net/quagga (PR 244027)
  • net/openbgpd (PR 244028)
  • net/openbgpd6 (PR 244029)

I have added myself to these 3 bugs and if no one else has committed the base change once those are closed I'll do it. Thanks for getting all the others Oliver

Feb 13 2020, 3:40 PM

Feb 6 2020

rgrimes accepted D23526: Mark elf2aout as deprecated..

A document describing the language and process of depreicating would be good to have.

Feb 6 2020, 4:26 PM

Feb 3 2020

rgrimes added a comment to D23335: retire rmt(8), the remote magtape protocol module.

when dump/restore are invoked with the leading r they change behavior and speak "rmt". Yes, there is probably much documentaiton missing.

Feb 3 2020, 4:57 PM
rgrimes added a comment to D23335: retire rmt(8), the remote magtape protocol module.

You need r{dump,restore} to talk rmt protocol to a remote tape drive, you can not just pipe over ssh to a remote tape drive.

Feb 3 2020, 4:35 PM
rgrimes added a comment to D23335: retire rmt(8), the remote magtape protocol module.

*sigh* usr.sbin/rmt/Makefile needs updated to do the proper packaging of rmt and your done?

Feb 3 2020, 3:48 PM
rgrimes added a comment to D23335: retire rmt(8), the remote magtape protocol module.

How are the symlinks /etc/termcap, /etc/unbound, and /etc/aliases handled by pkgbase? You certainly can't go removing those.

Feb 3 2020, 3:18 PM
rgrimes added a comment to D23335: retire rmt(8), the remote magtape protocol module.

@emaste Yes I object especially if that is the basis for this change. Why are we messing with other software to fix a defeciency in pkg base? symlinks in /etc/ should be supported. My fear is that though you say /etc/rmt "is to support ancient tar commands" the reality is everyone using rmt probably refers to it via /etc/rmt and this is going to break if you remove it. Using the word ancient is poor taste, all things "Unix" are ancient :-) I am ancient also by your standards :-(.

Feb 3 2020, 3:16 PM

Jan 29 2020

rgrimes added a comment to D23403: Add deprecation notice to vpo.4.

Shouldnt the driver code include a gone_in?

Jan 29 2020, 7:28 PM
rgrimes added a comment to D23329: Make ICMP redirect processing depend on routing daemon.

olivier siad: Yes I can fix all routing ports to be sure they all PROVIDE the dynamicrouting keyword.

Jan 29 2020, 7:23 PM
rgrimes added a comment to D23329: Make ICMP redirect processing depend on routing daemon.

melifaro said: No one uses routed. In the current form this change is useless.
I disagree, but the use is sparse, HOWEVER, routed_program, etc all CAN and are overriden. I start what ever routing layer I am using that way, which include but are not limited to: gated, bird, openbgp. And I use routed_enable to turn them on and off.

Jan 29 2020, 7:22 PM

Jan 28 2020

rgrimes accepted D23389: Add deprecation notice to vpo.4 / Remove vpo.4.
Jan 28 2020, 7:27 AM
rgrimes added a comment to D23389: Add deprecation notice to vpo.4 / Remove vpo.4.

Please create a review to first add deprecation notices to the man pages and a gone_in to the driver, with a RELNOTES: y, and a MFC 11+12. Then this can be committed with a MFC: never right behind it.

Jan 28 2020, 7:27 AM

Jan 27 2020

rgrimes accepted D23329: Make ICMP redirect processing depend on routing daemon.

For icmp6 since that is left out of any of this I think starting a new review to add icmpv6 handling is probably in order. I do see a sysctl, net.inet5.icmp.redirectaccept=1, but do not see a log one.

Jan 27 2020, 6:15 PM
rgrimes accepted D23224: bsdinstall: Provide help text for partitioning options.
Jan 27 2020, 6:01 PM

Jan 25 2020

rgrimes accepted D23364: Send CWR only on new data, as per sec. 6.1.2 of RFC3168.

The output in Phabricator GUI looks all messed up, the raw diff looks fine though.

Jan 25 2020, 8:33 PM
rgrimes accepted D23224: bsdinstall: Provide help text for partitioning options.

Other than perhaps a uniformity issue, that you can ignore if you wish, this looks fine to me.

Jan 25 2020, 4:23 PM

Jan 23 2020

rgrimes added a comment to D23335: retire rmt(8), the remote magtape protocol module.

rmt, rdump, rrestore all support something other than rsh(1) as a transport mechanism, ie ssh. Also if rmt goes you need to kill rdump, rrestore and fix the man pages. MFC'able depreication notices should go in first too.

Jan 23 2020, 7:11 PM
rgrimes requested changes to D23335: retire rmt(8), the remote magtape protocol module.

The TODO: must be done before rmt is removed. And I think further discussion on -arch about this should occur, rmt is kinda a common thing for people that run tapes, and tapes are still alive.

Jan 23 2020, 7:09 PM
rgrimes added a comment to D23327: add mergemaster(8) deprecation notice.

Further note, you should make the utility itself spit out a notice when executed.

Jan 23 2020, 7:02 PM
rgrimes added a comment to D23327: add mergemaster(8) deprecation notice.

The timing is flexible I think, but my recollection of the current depricaiton policy is since no notice went out in 12.0 the first notice of deprecation should be in the 13 branch and the code is removed in 14. But as I said history has shown us to be pretty flexible especially if we get notice MFC'ed and it goes out in 12.2. So up to you which path you choose.

Jan 23 2020, 7:01 PM
rgrimes requested changes to D23327: add mergemaster(8) deprecation notice.

Relnotes: Y and RELNOTES entry possible too, and with a slight language change MFC to 11 and 12.

Jan 23 2020, 2:42 AM

Jan 18 2020

rgrimes accepted D22704: Remove superfluous trailing whitespaces in TCP source files.

I concur that one large commit is best, BUTT, we should also see how it merges before doing that, as I suspect a large amount of this well fail to merge, and that creates a merge nightmare. As one who shoots down white space fixes within your other reviews let me try to expand on reasoning. It is not that it is bad or wrong to fix white space, it is that it adds noise to a review and each white space change has to be looked at as if it was part of the functional change and that creates reviewer work load and sometimes also causes mistakes to slip by.

Jan 18 2020, 3:12 AM
rgrimes accepted D22877: libalias: Add support for RFC 6598/Carrier Grade NAT subnets.

Looks good visually, need some others confirmed to have tested.

Jan 18 2020, 3:02 AM

Jan 17 2020

rgrimes accepted D23228: Fix passive ECN negotiation.
Jan 17 2020, 3:20 PM

Jan 10 2020

rgrimes accepted D23119: Send CWR whenever a ECN-enabled session runs into RTO.
Jan 10 2020, 5:14 AM
rgrimes accepted D23118: Fix IP ECN codepoint for SACK retransmissions (RFC3168).

How did you run into this one?

Jan 10 2020, 5:10 AM

Dec 19 2019

rgrimes accepted D22873: Fix rfb handshake after r355301..

Good catch, thank you Yamagi and Marcelo

Dec 19 2019, 11:22 PM

Dec 15 2019

rgrimes accepted D22800: Better copyright advice.

I would of like to seen a more formal Copyright update plan in place before large tree sweeps got started by people doing the All Rights Reserved cleaning, but too late now.

Dec 15 2019, 6:44 PM

Dec 7 2019

rgrimes accepted D22706: Add per-FIB gateway support to rc.d/routing.
Dec 7 2019, 6:26 AM

Dec 6 2019

rgrimes accepted D22644: Fix the CE reflector receiver state machine in DCTCP.
Dec 6 2019, 7:54 AM

Dec 5 2019

rgrimes accepted D22691: ifnet: drain+halt ioctl/vmove operations on detach.

I might of used tunif_freed inplace of tunifdtor, but thats just me wanting grep to find these :-)

Dec 5 2019, 7:34 PM
rgrimes requested changes to D22644: Fix the CE reflector receiver state machine in DCTCP.

I am ok to move forward with this and leave rethinking of factoring out the newreno latch to a cc function until later, how ever I would like to not use default: for the only possible state of the ECT bits being 00, OR explicity comment that the only case that can trigger the default is ECN=00.

Dec 5 2019, 7:05 PM
rgrimes accepted D22670: Send immediate ACK on receipt of CWR.
Dec 5 2019, 6:56 PM
rgrimes added a comment to D20468: Port if_vether from OpenBSD.

I would encourage continued work on this and the switch code too.

Dec 5 2019, 7:54 AM
rgrimes added a reviewer for D20468: Port if_vether from OpenBSD: rgrimes.
Dec 5 2019, 7:51 AM
rgrimes added a comment to D18892: Phase 2 to add Proportional Rate Reduction (RFC6937) to FreeBSD.

This is a visual code read only review, I have not compiled or tested the code.

Dec 5 2019, 7:37 AM
rgrimes accepted D22670: Send immediate ACK on receipt of CWR.

Nice find.

Dec 5 2019, 7:17 AM
rgrimes added a comment to D22657: bhyve: add wrapper for debug printf statements.

Can you first revert the wrong change, which cleans this up by not doing the deletes of \n\r that was added by that diff.

Dec 5 2019, 6:54 AM
rgrimes requested changes to D22644: Fix the CE reflector receiver state machine in DCTCP.

From the summary:

The main question remaining is then, if the DCTCP receiver
state machine asks for an explicit immediate ACK to be set,
in order to convey any change in the "CE" state of the incoming
packets in a timely fashion.
Dec 5 2019, 6:50 AM

Dec 3 2019

rgrimes accepted D22595: Align refcounting in multicast code between IPv4 and IPv6.

Thanks

Dec 3 2019, 8:30 AM
rgrimes accepted D22595: Align refcounting in multicast code between IPv4 and IPv6.

Thanks for quickly addressing this. Just a code comment I noticed, and am curious if I missed something that would not allow the removal of a duplicate conditional

Dec 3 2019, 7:38 AM
rgrimes added a comment to D15488: If reading the routing table fails, retry up to 10 times.

Offering a solution. Have the kernel track the max size of the routing table and return that value on sysctl(null) rather than the current size. This should only fail during initial table growth on a large table router, and should not require a retry except on rare occasion.

Dec 3 2019, 6:20 AM

Dec 2 2019

rgrimes added a comment to D15488: If reading the routing table fails, retry up to 10 times.

I have come to the state that if your running into this problem you probably should not be using netstat -rn to look at route tables but rather use the proper tool that talks with your routing daemon, adding a "bang on the kernel" repeat inside of netstat is probably a poor solution.

Well, I'm not sure.
First of all, there _are_ cases where you have to fetch the data, regardless of its size - troubleshooting can be one of those.

And when trouble shooting netstat -rn general works ok, it gets the error only while the route table is growing rapidly and is very easy for the user to retry the command, SHOULD they be using it.

Dec 2 2019, 6:42 PM

Nov 28 2019

rgrimes added a comment to D15488: If reading the routing table fails, retry up to 10 times.

I have come to the state that if your running into this problem you probably should not be using netstat -rn to look at route tables but rather use the proper tool that talks with your routing daemon, adding a "bang on the kernel" repeat inside of netstat is probably a poor solution.

Nov 28 2019, 4:23 AM

Nov 21 2019

rgrimes accepted D22466: add deprecation warning to amd.
Nov 21 2019, 1:25 AM

Nov 18 2019

rgrimes accepted D22436: Add access to TOS(ECN bits) to the TCP syncache.
Nov 18 2019, 3:15 AM

Nov 17 2019

rgrimes accepted D22429: Addition of flag bit definitions in preparation of AccECN.

Something really strange here with this diff

The raw diff should be ok though...

Nov 17 2019, 7:21 PM
rgrimes added a comment to D22429: Addition of flag bit definitions in preparation of AccECN.

Something really strange here with this diff

Nov 17 2019, 8:18 AM
rgrimes accepted D22428: Editorial change to enhance readability of the TF_* bit constants.
Nov 17 2019, 8:02 AM
rgrimes requested changes to D22428: Editorial change to enhance readability of the TF_* bit constants.
Nov 17 2019, 7:59 AM
rgrimes accepted D22426: Add access to TOS(ECN bits) byte in TCP RACK.
Nov 17 2019, 4:24 AM

Nov 16 2019

rgrimes accepted D19118: Add Boundary and Overflow checks in Cubic formulas.

I usually do the comparison separate from formula when they already exist, but either is ok with me.

Nov 16 2019, 4:14 AM
rgrimes added a reviewer for D21798: Restrict cwnd growth on app-limited flows: rgrimes.
Nov 16 2019, 1:32 AM

Sep 15 2019

rgrimes accepted D21662: sysctl: deprecation notices.

This is defanitly needed. Only two comment, you elude to having a version, it would indeed be nice to have a thing like the gonein(13) functionality, how to do that I do not know, and I would commit this in 2 parts, the new functionality, and then its first use.

Sep 15 2019, 4:23 PM

Sep 10 2019

rgrimes accepted D21581: Disable the default of ntpd locking of pages in memory.
Sep 10 2019, 5:23 PM

Aug 16 2019

D19976: bhyve: Support a _VARS.fd file for bootrom is now accepted and ready to land.
Aug 16 2019, 6:55 PM
rgrimes added a comment to D19976: bhyve: Support a _VARS.fd file for bootrom.

The additional note on style(9) on variable order declaration is informative only, you can choose to fix at your option.

Aug 16 2019, 6:39 PM

Aug 15 2019

D21060: Stop installing clang, clang++, and clang-cpp hardlinks in /usr/bin. is now accepted and ready to land.
Aug 15 2019, 4:50 PM
rgrimes added a comment to D21270: ping6: Disable definition of the old copyright variable.

My position is that "intent" in law carries a greater weight than "implementation". I agree that the intent of UCB was to embed the Copyright into the binary, and the fact that has been defeated by the choice of tools is on us to correct. Though Berne makes the binary copyright by default, it was still the intent of the original author to have these copyright strings appear. It is also very much understood in copyright law that "removing of any copyright" is an actionable item. Now, the likely hood that UCB would take action is moot. We could contact the UCB legal office and ask them for advice? Even a duplicate copyright can raise that question, I have seen no place an exception based on the fact that the same copyright appeared more than once.

Aug 15 2019, 4:08 PM

Aug 7 2019

rgrimes added a comment to D21181: Remove the fuse.ko -> fusefs.ko symlink.

Thanks for remebering to clean this up.

Aug 7 2019, 8:19 PM

Jun 27 2019

rgrimes added a comment to D20762: Add an initial RELNOTES file..

Reformat to 80 columns.

Jun 27 2019, 5:16 PM

Jun 26 2019

rgrimes committed rS349443: MFC: r347065 (by jhb) Emulate the "ADD reg, r/m" instruction (opcode 03H)..
MFC: r347065 (by jhb) Emulate the "ADD reg, r/m" instruction (opcode 03H).
Jun 26 2019, 9:59 PM
rgrimes committed rS349441: Emulate the "TEST r/m{16,32,64}, imm{16,32,32}" instructions (opcode F7H)..
Emulate the "TEST r/m{16,32,64}, imm{16,32,32}" instructions (opcode F7H).
Jun 26 2019, 9:20 PM
rgrimes closed D20755: Emulate the TEST instruction with opcode F7 /0..
Jun 26 2019, 9:20 PM
rgrimes added a comment to D20755: Emulate the TEST instruction with opcode F7 /0..

Finally review please

Jun 26 2019, 8:27 PM
rgrimes added reviewers for D20755: Emulate the TEST instruction with opcode F7 /0.: markj, pmooney_pfmooney.com.
Jun 26 2019, 8:27 PM
rgrimes added a comment to D20755: Emulate the TEST instruction with opcode F7 /0..

Fix 7F to F7 in 4 places

Jun 26 2019, 8:26 PM
rgrimes added inline comments to D20755: Emulate the TEST instruction with opcode F7 /0..
Jun 26 2019, 8:23 PM
rgrimes added a reviewer for D20755: Emulate the TEST instruction with opcode F7 /0.: jhb.

I was kinda waiting for jhb@ on this, as it is his patch, but given the urgency I am commandering this, and I'll push a new patch up for review. I would like to ask markj and pmooney to final review that and accept it before I commit to ^/head and push for an immediate MFC, and merge to releng. I'll also need to merge r347065 which is 6 weeks past MFC date.

Jun 26 2019, 8:03 PM
rgrimes added a comment to D20755: Emulate the TEST instruction with opcode F7 /0..

Ping, since 11.3RC3 is back on the table I would like to see this pushed through along with r347065 which should of already been pushed through as it is 3 weeks past original MFC.

Jun 26 2019, 7:23 PM
rgrimes added a comment to D19495: bhyve - Snapshot Save and Restore.

I have applied the feedback @jhb gave, except for the #ifdef guards. Will work on it after rebasing with a newer master.

Jun 26 2019, 11:11 AM · bhyve
rgrimes added a comment to D20755: Emulate the TEST instruction with opcode F7 /0..

I helped Jason Tubnor test this patch on 11.3RC2, we had to first merge r347065 to get this patch to apply, and then had to make the 0x7F to 0xF7 Markj points out to get it to work. OpenBSD now runs as a guest in 11.3RC2

Jun 26 2019, 3:43 AM

Jun 25 2019

rgrimes added a comment to D20755: Emulate the TEST instruction with opcode F7 /0..

I am working with the original poster to get him a binary so he can test this fix.

Jun 25 2019, 2:14 PM

Jun 21 2019

rgrimes added a comment to D12419: HD Audio Emulation For Bhyve (Based on D7840).

Just tested with TruOS/Trident from a May 2019 kernel, and it's getting ECAPMODE. Maybe the problems with Capsicum aren't worked out yet. I'll look some more at it.

Jun 21 2019, 7:55 PM

Jun 20 2019

rgrimes added a comment to D7840: HD Audio Emulation For Bhyve.

This appears to be hung up on Capsicum additions

Jun 20 2019, 5:07 PM
rgrimes resigned from D20389: bhyve vioapic writes can deadlock instance.
Jun 20 2019, 4:52 PM · bhyve

Jun 19 2019

rgrimes added a comment to D20673: Make RFB_ENCODING_ZLIB message handling idempotent..

In agreement on it probably needs cleaned up, but first finding out why it was done this way as a safe position to take.

Jun 19 2019, 2:01 PM