rgrimes
User

Projects

User Details

User Since
Dec 19 2016, 4:11 AM (74 w, 3 d)

Recent Activity

Yesterday

rgrimes added a comment to D15550: Fix a memory leak on topology_parse()..

Please mark the commit as MFC-X with https://svnweb.freebsd.org/changeset/base/332298

Thu, May 24, 1:19 PM
rgrimes accepted D15550: Fix a memory leak on topology_parse()..
Thu, May 24, 1:15 PM

Wed, May 23

rgrimes accepted D15488: If reading the routing table fails, retry up to 10 times.

I am ok with this for now, but I think the values 100000uS and 2x are going to need some "experience" tuning.

Wed, May 23, 7:38 AM

Tue, May 22

rgrimes accepted D15459: Use __SCCSID for SCCS IDs in libkvm sources..
Tue, May 22, 1:12 AM

Sat, May 19

rgrimes added inline comments to D15488: If reading the routing table fails, retry up to 10 times.
Sat, May 19, 4:53 PM
rgrimes added a comment to D15488: If reading the routing table fails, retry up to 10 times.

I see this problem often on BPG routers. I usually use the birdc as a better and more reliabe interface to the routing information, though on occasion you do have to sanity check with what the kernel has.
Also birdc seems to be able to give me a routing table 10x faster than netstat -rn and without this issue.

Sat, May 19, 4:38 PM
rgrimes added reviewers for D15488: If reading the routing table fails, retry up to 10 times: network, rgrimes.
Sat, May 19, 4:15 PM

Fri, May 18

rgrimes accepted D15189: Cleanups related to debug exceptions on x86..
Fri, May 18, 3:28 AM

Thu, May 17

rgrimes accepted D15465: Enable kernel dump options on most architectures..

Thanks

Thu, May 17, 9:54 PM
rgrimes added a comment to D15465: Enable kernel dump options on most architectures..

Can we not split KDB and DDB with NETDUMP?
Ie, put it after the options MALLOC_DEBUG_MAXZONES=8 # Separate malloc(9) zones
would keep all the KDB, GDB, DDB, etc in one lump, followed by dumping stuff, perhaps with one line of white space

Wouldn't that make it look like the "turn off in stable branch" comment applies to the new options? Or am I misunderstanding your suggestion?

Thu, May 17, 8:41 PM
rgrimes added a comment to D15465: Enable kernel dump options on most architectures..

Can we not split KDB and DDB with NETDUMP?
Ie, put it after the options MALLOC_DEBUG_MAXZONES=8 # Separate malloc(9) zones
would keep all the KDB, GDB, DDB, etc in one lump, followed by dumping stuff, perhaps with one line of white space

Thu, May 17, 8:33 PM
rgrimes added a comment to D15421: bhyve: fix usage formatting.

Thanks for catch Roman, I have prepared a commit and sent it to my mentors for approval, with a fast track 3 day MFC as this made it into stable/11.

Wait! Do you just committed a patch sent by another developer?

@novel have you approved that?

Best

Thu, May 17, 1:42 PM
rgrimes committed rS333712: Add missing newline to end of -c usage string ..
Add missing newline to end of -c usage string .
Thu, May 17, 12:19 PM
rgrimes closed D15421: bhyve: fix usage formatting.
Thu, May 17, 12:18 PM
rgrimes accepted D15459: Use __SCCSID for SCCS IDs in libkvm sources..
In D15459#326241, @jhb wrote:

Yeah, I actually meant to post a comment asking about the blank line. I would be fine with collapsing it now that the ID isn't surrounded by N layers of #ifdef.

Thu, May 17, 1:40 AM

Tue, May 15

rgrimes added inline comments to D15358: Address memory leak in new reno cc module.
Tue, May 15, 7:28 AM

Mon, May 14

rgrimes accepted D15421: bhyve: fix usage formatting.

Thanks for catch Roman, I have prepared a commit and sent it to my mentors for approval, with a fast track 3 day MFC as this made it into stable/11.

Mon, May 14, 1:22 PM

Fri, May 11

rgrimes added inline comments to D15388: assert(3) vq_getchain() on pci_vtcon_notify_tx() spotted by gcc..
Fri, May 11, 2:26 PM
rgrimes added inline comments to D15388: assert(3) vq_getchain() on pci_vtcon_notify_tx() spotted by gcc..
Fri, May 11, 1:56 PM

Wed, May 9

rgrimes added a comment to D11725: Add optional TCP logging on sonewconn failures..

I have changed the transport reviewer to non-blocking, and added glebius as a reviewer since he seems to have some stake in this. Hopefully this can help it move forward.

Wed, May 9, 2:26 AM
rgrimes added a reviewer for D11725: Add optional TCP logging on sonewconn failures.: glebius. rgrimes removed 1 blocking reviewer(s) for D11725: Add optional TCP logging on sonewconn failures.: transport.
Wed, May 9, 2:24 AM

Tue, May 8

rgrimes added a reviewer for D15356: in-kernel virtio and VPC (virtual private cloud) stack: bhyve.
Tue, May 8, 7:32 PM
rgrimes added a reviewer for D15348: add supporting interfaces for in-kernel virtio backend: bhyve.
Tue, May 8, 10:45 AM

Fri, May 4

rgrimes added inline comments to D15276: Add virtio-scsi block storage backend support.
Fri, May 4, 2:17 PM
rgrimes added inline comments to D15290: recursive mutex in pci_xhci leads to deadlock.
Fri, May 4, 2:04 PM

Thu, May 3

rgrimes added a reviewer for D15276: Add virtio-scsi block storage backend support: jhb.
Thu, May 3, 1:17 PM

Wed, May 2

rgrimes accepted D15269: Allow PCI VGA devices to be detached..
Wed, May 2, 6:15 PM
rgrimes added a comment to D15269: Allow PCI VGA devices to be detached..

How do you trigger a call to this DEVMETHOD?

Wed, May 2, 5:31 PM
rgrimes accepted D15268: Use PCI power-mgmt to reset a device if FLR fails..

Is this the workaround developed with macy?

Wed, May 2, 5:14 PM

Tue, May 1

rgrimes accepted D15245: Retire lmc(4).
Tue, May 1, 1:44 AM

Wed, Apr 25

rgrimes added a comment to D15189: Cleanups related to debug exceptions on x86..

It is a bit confusing to still have it be T_TRCTRAP, but all the comments now say debug exception...

Wed, Apr 25, 3:39 AM
rgrimes added a reviewer for D15189: Cleanups related to debug exceptions on x86.: bhyve.
Wed, Apr 25, 3:33 AM

Apr 24 2018

rgrimes accepted D15182: Add deprecation notice for lmc(4).
Apr 24 2018, 3:55 PM

Apr 21 2018

rgrimes accepted D15144: pwd_mkdb: retire legacy v3 db support (-l option).
Apr 21 2018, 9:04 AM

Apr 19 2018

rgrimes added a reviewer for D15138: Correct undesirable interaction between caching of %cr4 in bhyve and invltlb_glob().: bhyve.
Apr 19 2018, 11:40 PM

Apr 13 2018

rgrimes committed rS332465: MFC: r332075.
MFC: r332075
Apr 13 2018, 3:48 AM

Apr 8 2018

rgrimes closed D9930: Bhyve cpu topology control.
Apr 8 2018, 7:25 PM
rgrimes committed rS332298: Add the ability to control the CPU topology of created VMs.
Add the ability to control the CPU topology of created VMs
Apr 8 2018, 7:25 PM

Apr 7 2018

rgrimes added a comment to D14995: Fix PSL_T inheritance on exec for x86..
In D14995#315621, @imp wrote:

The reason I harped on the "Before 2.0" is that technically all 1.x code is to be unpublished by Agreement with AT&T/USL.
The time frame you are looking at here is 2.0, very near its actual release.

Yet, it's widely available. For example, you can find it at https://github.com/dspinellis/unix-history-repo/tree/FreeBSD-release/1.0-Import as well as all the pre-history of FreeBSD in the 386BSD + patchkit era. We're long past the time where it really matters for everybody that wasn't a direct party to that agreement, since there's no legal entity that could make an agreement on my behalf, since I wasn't even part of the project at the time, and the agreement was secret for years.

Apr 7 2018, 5:06 AM
rgrimes added a comment to D14995: Fix PSL_T inheritance on exec for x86..

So this doesn't get lost this is the original change in SVN. It dates back before FreeBSD 2.0

https://svnweb.freebsd.org/base/head/sys/i386/i386/machdep.c?r1=4193&r2=4201

I find that hard to believe, given that the cvs versions before 2.0 do not exist in svn, or ncvs, and should only exist in an offline repository called cvs.

Well the SVN revisions might be bogus because of the transition from CVS. But I'm assuming the dates and the snapshots of the releases are correct.

r4201 is where the bzero() was introduced to setregs() on Nov. 6, 1994
r4762 is the creation of RELEASE_2_0 on Nov. 22, 1994

https://svnweb.freebsd.org/base/release/2.0/sys/i386/i386/machdep.c?revision=4762&view=markup#l865

Apr 7 2018, 2:40 AM
rgrimes added a comment to D14995: Fix PSL_T inheritance on exec for x86..

So this doesn't get lost this is the original change in SVN. It dates back before FreeBSD 2.0

https://svnweb.freebsd.org/base/head/sys/i386/i386/machdep.c?r1=4193&r2=4201

Apr 7 2018, 12:50 AM

Apr 6 2018

rgrimes added a comment to D14989: Replace exect() with a portable version.

Could it be this works on i386 only?

Apr 6 2018, 9:36 PM
rgrimes added a comment to D9930: Bhyve cpu topology control.
In D9930#315522, @bcr wrote:

I think we're still good on the man page!

Apr 6 2018, 9:09 PM
rgrimes added a comment to D14989: Replace exect() with a portable version.
In D14989#315514, @kib wrote:

It still appears that you deprecated a function, you can not just do that in stable/11 as that breaks ABI It is also desirable to have a change to stable/11 that makes use of this function emit a deprecation warning.

What ABI does it break ?

Apr 6 2018, 8:43 PM
rgrimes added a comment to D14989: Replace exect() with a portable version.

@rgrimes With this version of the patch do we need to do anything about stable/11? The behavior now should most closely match the documentation.

Apr 6 2018, 8:24 PM
rgrimes updated the diff for D9930: Bhyve cpu topology control.

Clean up the topology_parse() routing to catch more errors, and to properly match the documented syntax, update the bhyve.8 manual page to reflect the actual syntax implemented.

Apr 6 2018, 7:16 PM
rgrimes added a comment to D14989: Replace exect() with a portable version.

What are the plans/methods to be used for stable/11 informing consumers that this feature is being deprecated?

Apr 6 2018, 3:49 PM

Apr 5 2018

rgrimes committed rS332075: Exit with usage when extra arguments are on command line.
Exit with usage when extra arguments are on command line
Apr 5 2018, 3:00 PM
rgrimes committed rS332074: MFC: r304147(bde).
MFC: r304147(bde)
Apr 5 2018, 2:55 PM

Mar 31 2018

rgrimes committed rS331837: MFC: r331664.
MFC: r331664
Mar 31 2018, 5:17 AM

Mar 29 2018

rgrimes updated the diff for D9930: Bhyve cpu topology control.

Make cpu topology sysctl's conditional on FreeBSD_version so that this patch can be merged to stable/11 and make these sysctl obsolete in >120057

Mar 29 2018, 6:56 PM
rgrimes updated the diff for D9930: Bhyve cpu topology control.
Mar 29 2018, 5:08 PM
rgrimes added a comment to D9930: Bhyve cpu topology control.

The issue causing the cpu topology to come out wrong on Intel cpus has been found, it is a misplaced call to vm_get_topology that is only executed for the cpuid 0xb, ecx=0 case, causing the ecx=1 case to use uninitialized values.

Mar 29 2018, 5:06 PM

Mar 28 2018

rgrimes committed rS331664: Add Bruce Evans.
Add Bruce Evans
Mar 28 2018, 7:50 AM

Mar 23 2018

rgrimes added a reviewer for D10213: Adding virtualization support for ARMv7 platforms: bhyve.
Mar 23 2018, 3:10 PM · ARM

Mar 20 2018

rgrimes updated the summary of D9930: Bhyve cpu topology control.
Mar 20 2018, 3:27 PM
rgrimes updated the summary of D9930: Bhyve cpu topology control.
Mar 20 2018, 3:26 PM

Mar 19 2018

rgrimes added a reviewer for D14466: Add a way to temporarily suspend and resume virtual CPUs.: bhyve.
Mar 19 2018, 11:22 PM

Mar 14 2018

rgrimes added a comment to D14679: Modify rc.d/fsck to handle new status from fsck/fsck_ffs.

A couple of points that I would like to add to this discussion:

  1. The rerunning of fsck can happen when certain cleanups are needed that may undo some earlier changes. For example when a disconnected directory is added to lost+found, previously calculated link counts for the directory that it used to be in may need to be adjusted. Rather than add a lot of code to fsck to deal with these rare cases, it is easier to just rerun it. Worst case scenario, it could happen once for each level of directory hierarchy in the filesystem. In practice I have only ever been able to make it loop twice with carefully constructed damage to the filesystem. There are many places where a change could cause the need for a rerun (and thus it is requested) even though it actually does not which is why the most common examples where it reruns, the result is simply to mark the filesystem clean.
Mar 14 2018, 5:37 PM

Mar 13 2018

rgrimes added a comment to D14679: Modify rc.d/fsck to handle new status from fsck/fsck_ffs.
In D14679#308469, @ian wrote:

[...]

I'll support any knobs you want to add to get to your goal, just please do not remove or change any knobs that prevent me from getting to my goal.

It sounds like maybe what we need is to add support for an "fsck_p_flags" rcvar that gets used on fsck -p runs. We can put fsck_p_flags="-T ffs:-R" in /etc/defaults/rc.conf so that by default we fully preen a filesystem automatically, but users/admins can override it to turn off that default as needed.

Mar 13 2018, 6:57 PM
rgrimes added a comment to D14679: Modify rc.d/fsck to handle new status from fsck/fsck_ffs.

If fsck -p internally does a restart I do have some concerns, as this usually is indicative of a decaying situation.

I've hit this problem dozens of times in my setup, and the second invocation does nothing but mark the superblock clean. I don't agree with your claim.

Mar 13 2018, 5:38 PM
rgrimes added a comment to D14679: Modify rc.d/fsck to handle new status from fsck/fsck_ffs.
In D14679#308387, @ian wrote:

Ian reported in the thread that -R has no effect if -p is specified, but I'm not seeing how that's true (and that behaviour doesn't really make sense if it is true).

I just looked at the code again, and I think maybe I was confused between ERESTART vs ERERUN or something, because now it looks to me like the -R option does restart internally in preen mode. Sorry for the misinformation.

Given that, I think "fsck -p -T ffs:-R" should be the standard set of flags in defaults/rc.conf. If preen is safe to run once, it should be safe to run multiple times as needed.

Mar 13 2018, 5:28 PM
rgrimes accepted D14679: Modify rc.d/fsck to handle new status from fsck/fsck_ffs.

Since fsck_y_enable is "NO" by default, this leaves us with fragile out-of-the-box behaviour. I would really like us to try harder to not leave a system stuck in single-user mode.

Ian reported in the thread that -R has no effect if -p is specified, but I'm not seeing how that's true (and that behaviour doesn't really make sense if it is true).

Rodney's claim that we wouldn't want to run fsck_ffs -p multiple times if requested also doesn't make sense to me: why would you be ok with running it once, unprompted, but not multiple times?

Mar 13 2018, 5:21 PM

Mar 12 2018

rgrimes added a comment to D9920: Fix rc.firewall workstation profile for fragmented packets.

Let me try again about the net.inet.ip.fw.one_pass. This patch leaves that value alone, that value is 1 by default. The added rules shall reassemble all UDP packets, and since one_pass is set it well at that point PASS THE PACKET. This is a huge hole in the firewall in effect allowing all UDP traffic to pass inward without any port or state being checked. With the added rule that reassembles udp packets it is a MUST that net.inet.ip.fw.one_pass be set to 0 so that the additional checks later in the firewall can be checked. It is also a must that the rule be moved before the check-state.

Mar 12 2018, 5:19 PM
rgrimes retitled D9920: Fix rc.firewall workstation profile for fragmented packets from Fix rc.firewall workstation profile to work with DNSSEC to Fix rc.firewall workstation profile for fragmented packets.
Mar 12 2018, 5:08 PM

Mar 11 2018

rgrimes added a comment to D9920: Fix rc.firewall workstation profile for fragmented packets.

I am not so sure if we want to turn on net.inet.ip.fw.one_pass

Indeed we should not do that. It's also not necessary. The addition of a reass line suffices to fix the issue.

Mar 11 2018, 5:34 PM
rgrimes added a comment to D9920: Fix rc.firewall workstation profile for fragmented packets.

I agree that the rule order is wrong here, reass should be done before a check state,
in general you want reass to occur very early, so that other rules are checking the
reassembled packet. reass should occur before any rules that list ports.

Mar 11 2018, 4:42 PM
rgrimes added a reviewer for D9920: Fix rc.firewall workstation profile for fragmented packets: rgrimes.
Mar 11 2018, 4:37 PM
rgrimes added a reviewer for D12419: HD Audio Emulation For Bhyve (Based on D7840): bhyve.
Mar 11 2018, 2:55 AM

Mar 10 2018

rgrimes updated the diff for D9930: Bhyve cpu topology control.

Update bhyve -h usage output to include new cpu topology options.
Pointed out by Roman Bogorodskiy (novel@).

Mar 10 2018, 4:39 PM
rgrimes resigned from D13784: Make loader.efi dual boot, step 1.

Translate reviewer rgrimes -> bhyve triggered by touching stand/userboot.

Mar 10 2018, 5:12 AM
rgrimes edited reviewers for D13784: Make loader.efi dual boot, step 1, added: bhyve; removed: rgrimes.
Mar 10 2018, 5:11 AM

Mar 7 2018

rgrimes updated the diff for D9930: Bhyve cpu topology control.

Fix white space nit in usr.sbin/bhyve/bhyve.8
Remove extra comma in usr.sbin/bhyvectl/bhyvectl.c causing build failure

Mar 7 2018, 3:23 PM
rgrimes added a comment to D9930: Bhyve cpu topology control.
In D9930#306720, @bcr wrote:

Found a small whitespace nit in the man page. Also, you need to bump the .Dd to the date of the commit (when it is ready).

Mar 7 2018, 3:17 PM
rgrimes added inline comments to D9930: Bhyve cpu topology control.
Mar 7 2018, 4:56 AM
rgrimes updated the diff for D9930: Bhyve cpu topology control.

Update per Peter Grehan

Mar 7 2018, 4:53 AM

Mar 6 2018

rgrimes resigned from D14022: NVMe emulation for bhyve (improved).
Mar 6 2018, 12:49 AM

Mar 5 2018

rgrimes added a comment to D9930: Bhyve cpu topology control.

You might have to explain further why you think you are exempt from having to demonstrate testing with this.

Mar 5 2018, 10:00 PM
rgrimes added a comment to D9930: Bhyve cpu topology control.

I'd like to see some guest test results (FreeBSD, Linux, Windows) for varying numbers of these, in particular, with sockets > 1, and comparing what Qemu shows for the same configuration.

Mar 5 2018, 8:21 PM

Feb 28 2018

rgrimes resigned from D14548: Fix a lock recursion introduced in r327065..

Since your all here from the add of bhyve can you look at herald rule H97 https://reviews.freebsd.org/H97 , look for anything I might of missed in the list of file directories.
I am trying to get that upgraded to a global rule with an add non-blocking reviewer bhyve, but that requires higher access than I have.

Feb 28 2018, 8:13 PM

Feb 27 2018

rgrimes added a comment to D14473: userboot: add callbacks to set unrestricted guest mode.

If Peter accepts this and says I can go ahead with a commit I would do that, but I need his approval to commit it.

Feb 27 2018, 7:41 PM · bhyve

Feb 23 2018

rgrimes added reviewers for D14473: userboot: add callbacks to set unrestricted guest mode: bhyve, grehan.

I dont know why it did that, I tried to simply "accept revision" and it removed all other reviewers, so put them back.

Feb 23 2018, 12:05 AM · bhyve
rgrimes accepted D14473: userboot: add callbacks to set unrestricted guest mode.
Feb 23 2018, 12:03 AM · bhyve

Feb 22 2018

rgrimes added a reviewer for D14473: userboot: add callbacks to set unrestricted guest mode: bhyve.
Feb 22 2018, 8:10 PM · bhyve

Feb 17 2018

rgrimes added a comment to D9930: Bhyve cpu topology control.

Thanks for getting back to this Rod.

On the validation issue, AMD and Intel have their own limits on how these numbers are exposed, and even that can be model-specific. While they can be verified in the kernel, the error return is somewhat limited - it may be worth doing the check in user-space where a more useful error can be returned.

Feb 17 2018, 10:16 AM
rgrimes added a reviewer for D9930: Bhyve cpu topology control: manpages.
Feb 17 2018, 2:47 AM
rgrimes updated the diff for D9930: Bhyve cpu topology control.

Correct issues and add man page changes

Feb 17 2018, 2:37 AM

Feb 16 2018

rgrimes accepted D14291: Allow route change requests to not specify the gateway..
Feb 16 2018, 7:13 PM
rgrimes accepted D14401: Fix route manpage to show correct flush syntax.

I missed that, overall I think this man page could use a rework in general form, gather all the syntax up in the SYNOPSIS, but if we keep pecking away at it at least the errors can be removed.

Feb 16 2018, 7:12 PM

Feb 15 2018

rgrimes added a comment to D9930: Bhyve cpu topology control.

I have all the other comments corrected in my copy, seeking clarification on error check value for vm_set_topology before I correct that. Plan to delay depreciation of old sysctl method to allow simpler merge to stable/11. That is going to require a direct commit to stable/11, and a different commit to ^head

Feb 15 2018, 9:25 PM

Feb 12 2018

rgrimes committed rS329179: MFC: r328695,r328720,r328784,r328795 share/examples/bhyve/vmrun.sh additions.
MFC: r328695,r328720,r328784,r328795 share/examples/bhyve/vmrun.sh additions
Feb 12 2018, 7:08 PM
rgrimes committed rS329178: MFC: r316746 Add UEFI support to vmrun.sh.
MFC: r316746 Add UEFI support to vmrun.sh
Feb 12 2018, 6:53 PM

Feb 10 2018

rgrimes added a comment to D14291: Allow route change requests to not specify the gateway..

This is missing the associated man page change that changes gateway to [gateway] on the change syntax,
Though perhaps BSD did allow this in the past, the man page never said that the gateway was optional as far as I can recall.

Feb 10 2018, 4:29 PM

Feb 2 2018

rgrimes committed rS328795: Fold constants and unify vnc variable names..
Fold constants and unify vnc variable names.
Feb 2 2018, 5:52 PM
rgrimes committed rS328784: Clean up long lines..
Clean up long lines.
Feb 2 2018, 4:35 PM

Feb 1 2018

rgrimes committed rS328720: Add -n <network device emulation type> to usage synopsis.
Add -n <network device emulation type> to usage synopsis
Feb 1 2018, 7:39 PM
rgrimes committed rS328695: Add option '-n' network device emulation type which has a default of virtio-net.
Add option '-n' network device emulation type which has a default of virtio-net
Feb 1 2018, 5:59 PM

Jan 28 2018

rgrimes added a comment to D10320: usr.bin/netstat: -n should not print symbolic names.

I still find this as a gratuitous difference in FreeBSD that does not exist in NetBSD or OpenBSD, and appears to be BSD behavior back into the 80's, anyone that HAS already scripted to deal with symbolic names well be broken if this change is made.

Jan 28 2018, 12:38 AM

Jan 25 2018

rgrimes added a comment to D14051: Remove K&R stuff: never use it in new code..
In D14051#295081, @imp wrote:

Only question I have before we remove this, is the tree void of code in this format?

If it is not then I think it would be unwise to remove this,if it is then yes, absolutely, remove this.

No new code has it.
There's odd corners of the tree that may still have it, but anybody changing it would remove the K&R style and go with full ANSI, so I'm not sure I understand how it would be useful to retain.

Jan 25 2018, 5:19 PM
rgrimes added a comment to D14051: Remove K&R stuff: never use it in new code..

Only question I have before we remove this, is the tree void of code in this format?

Jan 25 2018, 4:40 PM