rgrimes
User

Projects

User Details

User Since
Dec 19 2016, 4:11 AM (56 w, 3 d)

Recent Activity

Mon, Jan 15

rgrimes accepted D13919: mitigate against CVE-2017-5715 by clearing registers upon returning from the guest.

Looks good to me, but a future refactor would be nice, #define VMX_GUEST_CLOBBER_INTEL and VMX_GUEST_CLOBBER_AMD and invoke them at the right place. Makes the *_support.S files less different from each other.

Mon, Jan 15, 6:22 PM

Sat, Jan 13

rgrimes added inline comments to D13892: Record ticks in td_swvoltick after sched_switch() returns.
Sat, Jan 13, 4:37 PM
rgrimes added inline comments to D13892: Record ticks in td_swvoltick after sched_switch() returns.
Sat, Jan 13, 4:51 AM

Thu, Jan 4

rgrimes accepted D13755: Resolve ipfilter seed array size panic.

On visual inspection this looks good, I do not run pf or stateful so I can not do any real world testing. Please make sure the commit message includes a comment about refactoring common code to a new function ipf_state_seed_alloc.

Thu, Jan 4, 2:01 PM

Sun, Dec 31

rgrimes added a comment to D13713: make SW_WATCHDOG dynamic.

Two things, first it is not about saving the 100 bytes, it is about not having this function in the kernel at all, I simple do not need it, nor have I needed it for 40 years on any system.
Second, I think we have a POLA problem here, what changes for people that already have SW_WATCHDOG in there kernel config?
Would not this change the behavior of there systems? I think it is a bad idea to take over the existing "option" and changing what it does or how it behaves.
I still think it would just of been simpler to add options SW_WATCHDOG to the GENERIC kernel to solve your desire, that is self documenting more or less as no change is being made to how that behaves, no need to notifiy in RELEASE NOTES (if you push forward with this change as it stands now be certain to mark it for release notes).
Also is not that what you have been doing up to now?
Methods, not policy, your imposing your policy on others.
Also a comparison to the "bloated" generic of 21MB vs a trimmed kernel of 5.5MB is not reasonble to make as a basis for "this is only a tiny bit of code". I agree that it is a tiny bit of code, but it is code most have lived without for decades and should continue to have that option.

Sun, Dec 31, 5:52 PM
rgrimes added a comment to D13713: make SW_WATCHDOG dynamic.

This adds the watchdog code to the kernel witn no knob to turn it off or remove it, please make it possible to NOT have this code in the kernel.

Sun, Dec 31, 5:16 PM

Thu, Dec 21

rgrimes accepted D13573: recognize a pending virtual interrupt while emulating halt instruction.
Thu, Dec 21, 6:14 PM
rgrimes added a reviewer for D13573: recognize a pending virtual interrupt while emulating halt instruction: rgrimes.
Thu, Dec 21, 6:14 PM
rgrimes added inline comments to D13573: recognize a pending virtual interrupt while emulating halt instruction.
Thu, Dec 21, 4:11 PM

Wed, Dec 20

rgrimes added a comment to D13229: Save and restore guest debug registers..

I have this patch downloaded, but not applied, on my AMD test system. I'll apply and build after I send this comment. Do we have any more elaborate testing than just do the watchs that jhb did?

Wed, Dec 20, 3:03 AM

Jul 10 2017

rgrimes added a comment to D10320: usr.bin/netstat: -n should not print symbolic names.

In my review of other systems the printing of "default" for this is common and has a long history, changing it at this point in the game would probably be a POLA and possibly break some scripts. I have worked around the issue that caused me to notice this in another way.

Jul 10 2017, 5:59 PM

Jun 13 2017

rgrimes committed rS319919: MFC r307517, r314342, r316357, r317545, r317777:.
MFC r307517, r314342, r316357, r317545, r317777:
Jun 13 2017, 10:35 PM

Jun 6 2017

rgrimes added a comment to D11071: Make the VNC authentication build with LibreSSL on HardenedBSD and TrueOS..

As pointed on in the PR is it possible to totally remove all this casting?
It would make the code much cleaner.

Jun 6 2017, 10:38 AM

May 28 2017

rgrimes committed rS319016: MFC r314833.
MFC r314833
May 28 2017, 12:14 AM

May 27 2017

rgrimes accepted D10959: Update the comment for the rootpath.

I think this should do nicely.

May 27 2017, 6:40 PM
rgrimes requested changes to D10642: Fix serial line terminal size..

*sigh* After further investigation and some discussion I find that there are still problems with this.
If you login to a serial port and resizewin -z runs, it well set the terminal size to what ever terminal size you login in with, if you then logout and resize your terminal and login again resizewin well see non zero values and not do anything leaving us with the same issue that this change is suppose to fix.

May 27 2017, 6:23 PM
rgrimes accepted D10642: Fix serial line terminal size..
May 27 2017, 6:00 PM
rgrimes added a reviewer for D10642: Fix serial line terminal size.: rgrimes.
May 27 2017, 6:00 PM
rgrimes added a comment to D10642: Fix serial line terminal size..

From resizewin(1):

-z  Do nothing unless the current kernel terminal size is zero.  This is
    useful when run from a user's profile (shell startup) scripts: query-
    ing the window size is required for serial lines, but not when log-
    ging in over the network, as protocols like TELNET or SSH already
    handle the terminal size by themselves.

Okay, so I should not trust man on freefall.... added May 8th, 2017. This makes this change slightly more palatable as resize/resizewin has been known to eat input if commands are typed over an ssh/telnet session while the login scripts are still running causing both the resize operattion and the typed command to fail, I am still leary of this, but dont object to it being committed.

May 27 2017, 5:58 PM
rgrimes added a comment to D10642: Fix serial line terminal size..

FreeBSD's resizewin takes no arguments or options, please remove -z from commands.

May 27 2017, 5:09 PM
rgrimes added inline comments to D10959: Update the comment for the rootpath.
May 27 2017, 4:52 PM
rgrimes added a comment to D10947: Support URI scheme for root-path in netbooting.
In D10947#226718, @bapt wrote:

Other than the comment expansion request I like this, very clean, very easy to understand, and even easier to expand in the future.

You mean you want more comments in that code? if yes I can do that yes :)

May 27 2017, 2:53 PM

May 26 2017

rgrimes added a comment to D10947: Support URI scheme for root-path in netbooting.

Other than the comment expansion request I like this, very clean, very easy to understand, and even easier to expand in the future.

May 26 2017, 11:52 PM

May 25 2017

rgrimes added a comment to D10642: Fix serial line terminal size..

This is starting to sound like a terminal emulation type vs term= miss match perhaps? My term size was quiet correct, that is what a standard Putty serial terminal size comes up as.

May 25 2017, 5:08 PM
rgrimes added inline comments to D10818: VNC authentication based on review D7029.
May 25 2017, 6:11 AM
rgrimes added a comment to D10642: Fix serial line terminal size..

I am having difficulty with this then as my raspberry pie is just fine and dandy over serial when logging into the console:
root@rpi3:~ # stty -a
speed 115200 baud; 24 rows; 80 columns;
uname -a
FreeBSD rpi3 12.0-CURRENT FreeBSD 12.0-CURRENT #0 r313109M: Thu Feb 2 16:16:39 MST 2017 raspberry@hive.raspbsd.org:/usr/home/brd/rpi3/crochet/work/obj/arm64.aarch64/usr/src/sys/GENERIC arm64
root@rpi3:~ # grep ttyu0 /etc/ttys
ttyu0 "/usr/libexec/getty 3wire" vt100 onifconsole secure

May 25 2017, 3:15 AM
rgrimes added inline comments to D10818: VNC authentication based on review D7029.
May 25 2017, 2:29 AM

May 24 2017

rgrimes added a comment to D10642: Fix serial line terminal size..

Isnt this caused by a missing entry in /etc/ttys for the serial console? This should be coming from there, not from .dot files.

May 24 2017, 3:44 PM

May 22 2017

rgrimes accepted D10854: Add support for protocol prefixes in rootpath.

I have no problem with this code going in as it is here, it can be evolved with a table post commit.

May 22 2017, 4:20 PM

May 19 2017

rgrimes added inline comments to D10818: VNC authentication based on review D7029.
May 19 2017, 4:17 PM
rgrimes committed rS318513: MFC r314693.
MFC r314693
May 19 2017, 2:12 AM
rgrimes removed a reviewer for D10581: Raise BLOCKIF_IOV_MAX to 128. Windows uses at least 67 and qemu alsosupports 128.: rgrimes.

Side band communications are not very helpful, that email should of been attached to this review, or at least a note that there was a side band issue raised would of saved a few man cycles.

May 19 2017, 1:29 AM

May 18 2017

rgrimes added a comment to D10581: Raise BLOCKIF_IOV_MAX to 128. Windows uses at least 67 and qemu alsosupports 128..

Please be sure to flag this for MFC to 11 and 10

May 18 2017, 10:25 PM
rgrimes accepted D10581: Raise BLOCKIF_IOV_MAX to 128. Windows uses at least 67 and qemu alsosupports 128..
May 18 2017, 10:23 PM

May 4 2017

rgrimes added a comment to D10603: distinguish NFS versus TFTP boot by rootpath.

I am happy with this, it moves us forward, and removes the option 150 hack. I am pretty sure that you can actually dole out more than 1 tftp server by careful use of dhcp server configurations, ie the dhcp server has full control over what next-server you are told to load from if your environment is large enough that you need more than one.

May 4 2017, 9:05 PM
rgrimes added a comment to D9921: AMD-Vi (IOMMU)support for bhyve.

Mark as done all the nits Fixed in https://reviews.freebsd.org/D10049 by Anish

May 4 2017, 8:05 PM

May 2 2017

rgrimes added a comment to D10485: Replace dhcp option 150 by 66.

The more I look at PXE and DHCP the sicker I get. Your right, a client well not normally request option 150, for that matter I am not sure it well request 66 either, though I suspect many do, and probably many of them also wrongly interpret that as a dotted quad when it is actually a host name. I have had to fuss with dhcp servers and pxe clients for days if not weeks to get some operating systems booting over the network. Right now I can boot almost any FreeBSD >9 version as long as I am not an a UEFI platform, so our code is not that broken, I do have to use loader code from -head on the older releases, so things have improved. My use case is rather narrow I suppose in that I always chain load to iPXE to use its advanced features vs what most cards have in there bios. I am getting freebsd's pxeboot via tftp, then use that to get the kernel via nfs. Again, can we get input from Bapt who did the addition of opt 150 and how it worked?

May 2 2017, 12:58 AM

Apr 28 2017

rgrimes added a comment to D10533: Add IPv6 support to ipfw reass action.

Quick glance for 2 minutes says we should probably have a man page change with this?

Apr 28 2017, 5:15 PM

Apr 26 2017

rgrimes added a comment to D10485: Replace dhcp option 150 by 66.

I have done some more digging, in rfc3492 section 4 the ietf has reclassified options: 4. Reclassifying Options The site-specific option codes 128 to 223 are hereby reclassified as publicly defined options. This leaves 31 site-specific options, 224 to 254.
Interestingly this rfc is by Cisco!
Found the list, these are in the domain of Iana now, so you have to go to https://www.iana.org/assignments/bootp-dhcp-parameters/bootp-dhcp-parameters.xhtml to find them. Which leads you to rfc5859. Reading that RFC is causing me to say something un popular here. We should be using option 150 as an IP addresses, and NOT using option 66 because we can not do hostname resolution. The reasons that Cisco request option 150 was partly based on that.
Does the code even request option 66 from the server? Or do we just expect an sname filled in? I read some of the Intel pxe 2.1 spec and they don't even mention option 66 in there list of options, yet the refer to it several times at the sname line of data structures.

Apr 26 2017, 5:36 PM
rgrimes added inline comments to D10485: Replace dhcp option 150 by 66.
Apr 26 2017, 4:22 PM
rgrimes added a comment to D10485: Replace dhcp option 150 by 66.

@kczekirda I'm not worried about compatibility with the PXE standard. I'm worried about compatibility with existing users of option 150. How are you going to support them or transition them to the new option?

This is a valid concern, We should also ask Bapt why he choose to use option 150 instead of 66 when implementing this?

Apr 26 2017, 4:16 PM
rgrimes added a comment to D10485: Replace dhcp option 150 by 66.

@rgrimes
RFC1048 is here, because 1048 is a part of names of functions or variables in bootp.c, I think we should rename them. I updated the description of revision with part about dotted quad. Probably we have no better way to do that.

Apr 26 2017, 4:15 PM

Apr 25 2017

rgrimes added a comment to D10485: Replace dhcp option 150 by 66.

RFC1048 is obsoleted, first by 1533, then by 2132. Please lets follow current RFC's when seeking information and refering to them. Refering to obsolete RFC's is going to lead to obsolete code. I see at least in the comment of adding vend_end that you refer to RFC2132, it is unclear why you refered to 1048 in the description of the change. RFC2132 names code 66 "TFTP server name". I can not find in the RFC that option 150 is defined. I do find from google searches that this was/is a cisco specific value: "DHCP option 150 provides the IP addresses of a list of TFTP servers. • DHCP option 66 gives the IP address or the hostname of a single TFTP server. Note Cisco IP Phones might also include DHCP option 3 in their requests, which sets the default route. A single request might include both options 150 and 66." This clarifies that it is possible to send both.

Apr 25 2017, 12:20 AM

Apr 22 2017

rgrimes committed rS317303: MFC: r314694.
MFC: r314694
Apr 22 2017, 10:05 PM
rgrimes committed rS317302: MFC: r314691.
MFC: r314691
Apr 22 2017, 9:57 PM
rgrimes committed rS317301: MFC r314691:.
MFC r314691:
Apr 22 2017, 9:50 PM

Apr 21 2017

rgrimes added a comment to D10440: Change arc4random(9) over to using 3-BSD licensed Chacha20..

I've been swayed that this is a short path to a solution for now, but still would like to see the arc4random eventually updated to allow for the crypto funtion use be pluggable and selectable without a kernel recompile.

Apr 21 2017, 4:01 AM

Apr 11 2017

rgrimes added reviewers for D10070: WIP: make VM_MAXCPU tunable: rgrimes, grehan.

I am not sure, but I believe this is pretty much in conflict with what I did in the CPU topology enhancement, D9930

Apr 11 2017, 6:12 PM
rgrimes added a member for network: rgrimes.
Apr 11 2017, 4:41 PM

Apr 5 2017

rgrimes updated subscribers of D10049: Add AMD IOMMU support in bhyve.
Apr 5 2017, 6:48 AM
rgrimes added a comment to D9921: AMD-Vi (IOMMU)support for bhyve.

I was going to close this but I see several things from bcr that are not marked as fixed by anish in D10049, can you please review all of bcr's nits and make sure we have those fixed in D10049 before I abandon this?

Apr 5 2017, 6:45 AM

Mar 12 2017

rgrimes committed rS315091: Revert r314833 until the problem with INSTALL_RSYMLINKS can be found.
Revert r314833 until the problem with INSTALL_RSYMLINKS can be found
Mar 12 2017, 12:38 AM

Mar 11 2017

rgrimes added inline comments to D2838: Add on bhyvectl the capability to list the running vms..
Mar 11 2017, 3:19 PM
rgrimes added a comment to D2838: Add on bhyvectl the capability to list the running vms..

This may be controversial, but I'll just throw it out there as an idea for you to think about.
It would be cool if the output you generate from bhyvectl such as listing vm's could
use libxo to output things in JSON or XML format. This would make it easier for
people writing scripts or web apps to incorporate and analyze this information.

I think what neel is trying to say, is that the 'list vms' functionality, and other stuff that is designed to be 'user facing', and get libxo'd, maybe should be a separate utility, since bhyvectl is a debugging utility.

maybe bhyvemanage or something, that has the few user facing options like:

[--inject-nmi]
[--force-reset]
[--force-poweroff]
[--destroy]
Mar 11 2017, 2:55 PM

Mar 9 2017

rgrimes created D9930: Bhyve cpu topology control.
Mar 9 2017, 8:55 AM

Mar 8 2017

rgrimes added inline comments to D9917: Add abs2rel and rel2abs to libutil and use them in ln to provide the -a and -r options.
Mar 8 2017, 8:10 AM

Mar 7 2017

rgrimes retitled D9921: AMD-Vi (IOMMU)support for bhyve from to AMD-Vi (IOMMU)support for bhyve.
Mar 7 2017, 9:08 PM
rgrimes added a reviewer for D9919: share/mk/bsd.links.mk: add RSYMLINKS support: rgrimes.

The following trivial patch fixes the relativeness of SYMLINKS and given this is already a supported META target no other changes are need.
This has been regression tested with make installworld DESTDIR={before,after} and the trees are the same with special attention taken to
run a find DESTDIR -type l -ls .... and diffing the results. No symbolic link information was altered by this change.

Mar 7 2017, 8:50 PM
rgrimes added a comment to D9918: share/mk/bsd.README: document bsd.links.mk.

Why has some of this been commited??? If your going to commit before a review is done why bother with it?

Mar 7 2017, 8:03 PM
rgrimes added inline comments to D9918: share/mk/bsd.README: document bsd.links.mk.
Mar 7 2017, 5:21 PM
rgrimes added inline comments to D9918: share/mk/bsd.README: document bsd.links.mk.
Mar 7 2017, 9:20 AM
rgrimes added inline comments to D9919: share/mk/bsd.links.mk: add RSYMLINKS support.
Mar 7 2017, 9:15 AM
rgrimes requested changes to D9917: Add abs2rel and rel2abs to libutil and use them in ln to provide the -a and -r options.

First off in the unix philosophy /we also be adding a relname in the spirit of
basename and dirname that calls this library so that any shell script or
Makefile, etc could easily add this functionality?

Mar 7 2017, 7:26 AM
rgrimes committed rS314837: The relative symlink fix causes downstream issues for.
The relative symlink fix causes downstream issues for
Mar 7 2017, 6:11 AM
rgrimes committed rS314833: Convert absolute links to relative links..
Convert absolute links to relative links.
Mar 7 2017, 5:10 AM

Mar 5 2017

rgrimes committed rS314694: Make vmrun.sh passthrough -u and -w to bhybe.
Make vmrun.sh passthrough -u and -w to bhybe
Mar 5 2017, 5:02 AM
rgrimes committed rS314693: Change /etc/rmt symlink from absolute to relative path,.
Change /etc/rmt symlink from absolute to relative path,
Mar 5 2017, 4:09 AM
rgrimes committed rS314692: Move me from Alumni to active src committer..
Move me from Alumni to active src committer.
Mar 5 2017, 4:03 AM
rgrimes committed rS314691: Document 3 more src/ directories.
Document 3 more src/ directories
Mar 5 2017, 3:59 AM

Mar 3 2017

rgrimes committed rD50029: Add myself as returning commiter.
Add myself as returning commiter
Mar 3 2017, 5:32 PM