- User Since
- Dec 19 2016, 4:11 AM (82 w, 5 d)
Thu, Jul 12
Wed, Jul 11
Mon, Jul 9
This is also going to require a man page update, as now there are more than the 4 exit codes listed in the man page.
Sat, Jul 7
Does this not also make it so that these drivers require IFLIB, so they need to be marked as such in GENERIC/NOTES/etc and man pages?
Fri, Jul 6
Looks good over all, just some nits on errx vs err when it appears that there is a proper errno avaliable.
Fri, Jun 29
I think it might be better to have 3 conv types, IDIRECT, ODIRECT, and DIRECT==IDIRECT|ODIRECT. You may or may not want vm effects on specific files.
Sun, Jun 24
Jun 15 2018
I actually worry less about man page DEPRECATION, and more about having the binary spit something out so anyone using it for who knows what gets a heads up that it is/may be going away soon.
@brooks a fully sgree, infact it can be done in a seperate review, and the asf binary should spit out a warning, not just a man page change.
Does it make since to first commit a deprecation notice to this, which can be merged to stable/11, then actually remove it from ^/head after that? This avoids the need for a direct commit to stable/11
Jun 12 2018
I think you have mis understood what I asked for in the other review. It only needs to be split into 2 parts, one containing the SPDX tags, and another containing all the white space cleanup.
It is normal to separate all whitespace changes from other. It is preferable to separate all SPDX changes from others when it is sweeping. I strongly assert that as the person now cleaning up a 180k lines and 16 commits of diff involving SPDX tags that this separation occur before this is commited.
Please seperate this into 2 reviews, one for the white space/tab cleanup and one for the SPDX tag addition.
Jun 11 2018
Jun 9 2018
Unclear why phabricator does the remove of reviewers when I try to add group bhyve, restore grehan caused by that in last change.
May 30 2018
Copy over subscribers from D15628 and describe this review as a fix for an issue found during that review.
May 28 2018
May 26 2018
Isnt there some documentation some place that also needs to be updated?
May 24 2018
Please mark the commit as MFC-X with https://svnweb.freebsd.org/changeset/base/332298
May 23 2018
I am ok with this for now, but I think the values 100000uS and 2x are going to need some "experience" tuning.
May 22 2018
May 19 2018
I see this problem often on BPG routers. I usually use the birdc as a better and more reliabe interface to the routing information, though on occasion you do have to sanity check with what the kernel has.
Also birdc seems to be able to give me a routing table 10x faster than netstat -rn and without this issue.
May 18 2018
May 17 2018
Can we not split KDB and DDB with NETDUMP?
Ie, put it after the options MALLOC_DEBUG_MAXZONES=8 # Separate malloc(9) zones
would keep all the KDB, GDB, DDB, etc in one lump, followed by dumping stuff, perhaps with one line of white space
May 15 2018
May 14 2018
Thanks for catch Roman, I have prepared a commit and sent it to my mentors for approval, with a fast track 3 day MFC as this made it into stable/11.
May 11 2018
May 9 2018
I have changed the transport reviewer to non-blocking, and added glebius as a reviewer since he seems to have some stake in this. Hopefully this can help it move forward.
May 8 2018
May 4 2018
May 3 2018
May 2 2018
How do you trigger a call to this DEVMETHOD?
Is this the workaround developed with macy?
May 1 2018
Apr 25 2018
It is a bit confusing to still have it be T_TRCTRAP, but all the comments now say debug exception...
Apr 24 2018
Apr 21 2018
Apr 19 2018
Apr 13 2018
Apr 8 2018
Apr 7 2018
Apr 6 2018
Could it be this works on i386 only?
Clean up the topology_parse() routing to catch more errors, and to properly match the documented syntax, update the bhyve.8 manual page to reflect the actual syntax implemented.
What are the plans/methods to be used for stable/11 informing consumers that this feature is being deprecated?
Apr 5 2018
Mar 31 2018
Mar 29 2018
Make cpu topology sysctl's conditional on FreeBSD_version so that this patch can be merged to stable/11 and make these sysctl obsolete in >120057
The issue causing the cpu topology to come out wrong on Intel cpus has been found, it is a misplaced call to vm_get_topology that is only executed for the cpuid 0xb, ecx=0 case, causing the ecx=1 case to use uninitialized values.
Mar 28 2018
Mar 23 2018
Mar 20 2018
Mar 19 2018
Mar 14 2018
Mar 13 2018
Mar 12 2018
Let me try again about the net.inet.ip.fw.one_pass. This patch leaves that value alone, that value is 1 by default. The added rules shall reassemble all UDP packets, and since one_pass is set it well at that point PASS THE PACKET. This is a huge hole in the firewall in effect allowing all UDP traffic to pass inward without any port or state being checked. With the added rule that reassembles udp packets it is a MUST that net.inet.ip.fw.one_pass be set to 0 so that the additional checks later in the firewall can be checked. It is also a must that the rule be moved before the check-state.
Mar 11 2018
I agree that the rule order is wrong here, reass should be done before a check state,
in general you want reass to occur very early, so that other rules are checking the
reassembled packet. reass should occur before any rules that list ports.
Mar 10 2018
Update bhyve -h usage output to include new cpu topology options.
Pointed out by Roman Bogorodskiy (novel@).