Page MenuHomeFreeBSD

rgrimes
User

Projects

User Details

User Since
Dec 19 2016, 4:11 AM (99 w, 6 d)

Recent Activity

Thu, Nov 15

rgrimes added a reviewer for D2469: Allow byte reads of AHCI registers.: bhyve.
Thu, Nov 15, 9:23 PM
rgrimes added a reviewer for D2350: Implement NMI window exiting on AMD/SVM processors.: bhyve.
Thu, Nov 15, 9:15 PM
rgrimes added a reviewer for D745: Allow vtnet operation without merged rx buffers.: bhyve.
Thu, Nov 15, 8:48 PM

Tue, Nov 13

rgrimes accepted D17969: Prepare for removal of CTM from FreeBSD-13.

I like imp@'s revisions. I am accepting either version though.

Tue, Nov 13, 4:01 PM · manpages

Mon, Nov 12

rgrimes added a comment to D17935: Remove CTM from 13-CURRENT.
In D17935#383667, @imp wrote:

I'd do a separate commit that just says 'CTM will move to ports in FreeBSD 13' in the ctm man page and get that merged before 12.0R (so ASAP).

Mon, Nov 12, 6:29 PM · Src Committers

Sun, Nov 11

rgrimes added a reviewer for D17935: Remove CTM from 13-CURRENT: rgrimes.

There should be an UPDATING entry to tell people to go get the port.. This has a 0 length deprecation notice if we just go rip it out now. I would support first adding a gonein(13) and merging that to release 12 or 12.1. That should be done first, before this. Have the ports builders made a pkg avaliable for ^/head yet, I see that you can build it, but can pkg get one yet? I would not want to remove it until a binary can be fetched via pkg.

Sun, Nov 11, 3:53 PM · Src Committers

Thu, Nov 8

rgrimes accepted D17911: Remove mention of the pre-11 support model..
Thu, Nov 8, 9:46 PM

Wed, Nov 7

rgrimes added a comment to D17874: libvmmapi: Separate MI from MD code.

A M lib/libvmmapi/amd64/vmmapi_amd64.h (143 lines)
A M lib/libvmmapi/amd64/vmmapi_amd64.c (1035 lines)
These 2 files are showing up as "added" when clearly they are copied/moved from some place else. This may be an artifact of either git or phabricator and hopefully the svn commit shows the proper logic.

Wed, Nov 7, 5:38 AM

Mon, Nov 5

rgrimes added a comment to D17848: Update review requests for bhyve..

This is good, but it is not clear on *who* can approve as bhyve, in the past that was Peter, is it now jhb & tychon, or anyone who just happens to join the bhyve group, which is not controller.

If the bhyve group cannot be controlled, in this case would be better add the team members name explicitly.
I thought the bhyve group were controlled.

Mon, Nov 5, 6:56 PM
rgrimes accepted D17848: Update review requests for bhyve..
Mon, Nov 5, 6:23 PM
rgrimes added a comment to D17848: Update review requests for bhyve..

This is good, but it is not clear on *who* can approve as bhyve, in the past that was Peter, is it now jhb & tychon, or anyone who just happens to join the bhyve group, which is not controller.

Mon, Nov 5, 6:23 PM

Fri, Oct 26

rgrimes added a comment to D2838: Add on bhyvectl the capability to list the running vms..

Proposal: Rename the current bhyvectl code to bhyvedbg, and create a new bhyvectl that has --create, --destory and --list. This could also be the tool to do the bhyvectl --addcpu, --addmemory, --adddisk, etc, etc. This is just a random braincell firing of an idea, anyone and everyone can ignore as they see fit.

Fri, Oct 26, 2:20 PM
rgrimes added a comment to D2838: Add on bhyvectl the capability to list the running vms..

I shall re assert my earlier concern that we want to keep bhyvectl purely as a debugging tool, and not start to clutter it with stuff that is not part of that. Yes, there is the use of --destroy by others, but that is and should be the exception rather than the norm.

Fri, Oct 26, 1:20 PM
rgrimes added a reviewer for D17713: AMD - emulate Extended CPUID Features override.: bhyve.

Sorry for the extra noise here, I did not mean to accept it as bhvye, only me personally, so did delete/add bhyve umbrella to clear that bit.

Fri, Oct 26, 1:08 PM
rgrimes removed a reviewer for D17713: AMD - emulate Extended CPUID Features override.: bhyve.
Fri, Oct 26, 1:07 PM
rgrimes accepted D17713: AMD - emulate Extended CPUID Features override..
Fri, Oct 26, 1:06 PM
rgrimes added a comment to D17713: AMD - emulate Extended CPUID Features override..

I am good with this too, other than it is not emulating it, it is just ignoring it by returning a 0, which may or may not have future implications.

Fri, Oct 26, 1:06 PM

Thu, Oct 25

rgrimes added a comment to D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..
In D16894#378335, @imp wrote:

This has been committed..

Thu, Oct 25, 9:06 PM
rgrimes committed rS339707: Allow fdisk(8) to deal with sectors larger than 2048.
Allow fdisk(8) to deal with sectors larger than 2048
Thu, Oct 25, 12:13 PM

Tue, Oct 23

rgrimes accepted D17594: rip6_input() inp validation after epoch(9).
In D17594#377572, @bz wrote:

Anyone? I'd love to get this in ...

Tue, Oct 23, 10:50 PM
rgrimes accepted D17654: Deprecate a number of less used 10 and 10/100 Ethernet devices..

@allanjude suggested we might do something like papers.freebsd.org where we run the git repo though go-hugo to produce a formatted web page. That might be worth doing, but is definitely out of scope for the time being.

Tue, Oct 23, 5:44 PM
rgrimes added a comment to D17654: Deprecate a number of less used 10 and 10/100 Ethernet devices..
In D17654#377395, @imp wrote:

I'll point out that https://github.com/freebsd is under FreeBSD Project control, for the most part. It's a risk, but this code likely has a limited enough time horizon to accept that limitation until someone can create a fcp.freebsd.org redirector.

Eg, it's not important enough to gate this commit for that.

Tue, Oct 23, 4:10 PM
rgrimes added a comment to D17654: Deprecate a number of less used 10 and 10/100 Ethernet devices..

One of the reasons for me asking to "macrotise" this is that we can commit it today with a poor URL in it, and very easily correct that URL some time soon(ish),
Brooks if you or Imp write the macro I'll do the leg work of converting the current diff to use that macro and remove all my objections from the current state of affairs.

Tue, Oct 23, 4:08 PM
rgrimes added a comment to D17654: Deprecate a number of less used 10 and 10/100 Ethernet devices..

Does it make any sense at all to #define a macro gone_by_fcp101?

Tue, Oct 23, 3:57 AM

Mon, Oct 22

rgrimes accepted D17531: bhyve: provide basic descriptions for VMX exit reason.

The bhyve group hat was requested by Peter Grehan for "Maintainer" approval and awareness of bhyve bits, as far as I can see this review does not touch any bits that need bhyve maintainer approval, so you can commit with out an accept from them.

Mon, Oct 22, 5:47 PM

Oct 12 2018

rgrimes added a reviewer for D17531: bhyve: provide basic descriptions for VMX exit reason: bhyve.
Oct 12 2018, 4:24 PM

Oct 10 2018

rgrimes added a comment to D17482: bhyve: emulate CLFLUSH and CLFLUSHOPT..

Though this may fix running 12.0 on 12.0 we well need EN's back to 11 and perhaps even 10 as the issue exists there as well.
How badly do we need that CLFLUSH instruction in 12?

Oct 10 2018, 3:11 PM

Oct 5 2018

rgrimes added a comment to D17439: Make it possible to disable NUMA support with a tunable..

Please break out the man page changes that are not related to the boot time tuneable into a seperate commit/differential.

Oct 5 2018, 7:59 PM
rgrimes accepted D17338: Fix information about $firewall_myservices.
Oct 5 2018, 4:04 PM

Sep 10 2018

rgrimes added a comment to D17106: Generate /etc/services from the IANA registry (plus local mods).

Is there anyway to NOT have the 141,000 line xml version of the file stored in SVN?
Also we need to make absolutely sure that any services used by ports are not effected by anything this changes.

Sep 10 2018, 5:51 PM
rgrimes added reviewers for D17106: Generate /etc/services from the IANA registry (plus local mods): asomers, rgrimes.
Sep 10 2018, 5:45 PM
rgrimes updated subscribers of D17040: Enable WITHOUT_INET* WITHOUT_CRYPT WITHOUT_OPENSSL, WITHOUT_FILE.

Some more comments inline - as mentioned earlier we should try to address the root causes, as in D17074. That said, I'm fine with this approach pending root cause fixes (given that it doesn't build today), but want to make sure we have some way to track these outstanding issues such that they'll get fixed after the release.

Sep 10 2018, 3:36 PM

Sep 7 2018

rgrimes added a comment to D17074: Allow dhclient and ping to build WITHOUT_DYNAMICROOT.

It just hit me and I have to ask, why isnt libcasper avaliable in a static configuration? I certainly see a /usr/lib/libcasper.a on my systems.

Sep 7 2018, 6:31 PM
rgrimes accepted D17074: Allow dhclient and ping to build WITHOUT_DYNAMICROOT.
Sep 7 2018, 6:26 PM
rgrimes committed rS338525: Increase size of working imgfile from 250MB to 4GB.
Increase size of working imgfile from 250MB to 4GB
Sep 7 2018, 3:52 PM
rgrimes committed rS338524: Remove rsync to phk's server.
Remove rsync to phk's server
Sep 7 2018, 3:48 PM

Sep 6 2018

rgrimes added inline comments to D17040: Enable WITHOUT_INET* WITHOUT_CRYPT WITHOUT_OPENSSL, WITHOUT_FILE.
Sep 6 2018, 12:24 PM

Aug 29 2018

rgrimes added a comment to D16945: userboot: handle guest interpreter mismatches more intelligently.

(Note to Rod: this is only partially what's going to end up in the review... this isn't a final product for review yet)

Aug 29 2018, 4:52 PM

Aug 27 2018

rgrimes added a comment to D16913: vmrun: add -x flag to always exit when bhyve exists.

Allan, would you update the diff please

Aug 27 2018, 3:41 PM

Aug 26 2018

rgrimes added a comment to D16913: vmrun: add -x flag to always exit when bhyve exists.

To add information, I have email from Paul Vixie and in fact he is wanting to break the reboot loop with -x so that it can be handled externally.

Aug 26 2018, 11:18 PM
rgrimes added a comment to D16913: vmrun: add -x flag to always exit when bhyve exists.

I do not believe this is a desirable change, at least it does not do what it claims it does.

Aug 26 2018, 10:41 PM
rgrimes added a reviewer for D10335: VirtFS/9p filesystem passthrough support (virtio-9p): bhyve.
Aug 26 2018, 6:54 PM

Aug 25 2018

rgrimes accepted D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..
Aug 25 2018, 5:51 AM
rgrimes accepted D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..

Looks good, my minor nits can be ignored, up to you.
Oh, I see you changed the return code of the module load, I take it that is to lower its preference???

Aug 25 2018, 3:47 AM

Aug 24 2018

rgrimes added a comment to D12507: Dummynet AQM usage documentation for ipfw man page.

I am sorry for not getting to this today, I was side lined.

Aug 24 2018, 12:41 AM

Aug 23 2018

rgrimes requested changes to D16870: Turn drm2 back on in TEGRA124.

I respectfully request that a straight revert of the commits be done rather than this, for one this does not allow us to do the proper deprecation commits, nor to merge those commits back to stable/11. This is still a major violation of deprecation policy. Warner, would you new policy allow this type of thing to be accepted? I would hope not.

Aug 23 2018, 5:49 PM
rgrimes accepted D16856: Initial proposed patch for SSL root bundle in base.

Looks ok, though I wonder about a shell script that writes a Makefile, it should be possible to do that in a Makefile by itself, there is the .for/.endfor operator to make which can duplicate what the shell script does.

Aug 23 2018, 3:13 PM

Aug 22 2018

rgrimes added a comment to D12507: Dummynet AQM usage documentation for ipfw man page.

Can I please have atleast 24 hours to review the text of this.

Aug 22 2018, 11:39 PM

Aug 21 2018

rgrimes added a comment to D16684: Extend security/ca_root_nss MAca-bundle.pl.

Im no perl fan so I wont comment on that aspect.

Aug 21 2018, 12:19 AM

Aug 20 2018

rgrimes accepted D16805: Turn back the clock just a little: make userboot.so always be 4th.
Aug 20 2018, 12:16 AM
rgrimes added a reviewer for D16805: Turn back the clock just a little: make userboot.so always be 4th: bhyve.
Aug 20 2018, 12:15 AM

Aug 18 2018

rgrimes added a comment to D16770: Move dot.profile dot.cshrc to bin/sh/ and bin/csh/.

Can you please break the change to share/mk/bsd.confs.mk out into a separate review, though it is required by the moving of the profile files, it is actually not a part of that change directly. I would also like to ask that you tag bdrewery in on the review of the .mk change. I do not see how file owner/group/mode are set in the new Makefile.

Aug 18 2018, 3:16 PM
rgrimes added a comment to D16728: Move master.passwd and group to lib/libc/gen/.

Though I disagree with the relocation of this to libc as it is going to be installed with the absolute minimal system anyway so this delta just creates src tree churn, and user finger memory churn. You site your reason for moving it is to put it close to the sources, well, traditionally BSD sources are layed out to match the installed DESTDIR tree. I understand things like csh and sh conf files moving, that makes since in a world where csh or sh may or may not be installed by a pkgbase, however that makes no since in a world where libc and hence master.passwd shall always be installed.

Aug 18 2018, 2:59 PM
rgrimes added a reviewer for D16790: Update L1TF workaround to sustain L1D pollution from NMI.: bhyve.
Aug 18 2018, 2:47 PM

Aug 17 2018

rgrimes added a comment to D16728: Move master.passwd and group to lib/libc/gen/.

A question has come up, isnt libc part of base, ie even in a pkgbase system libc must be installed? If that is the case then master.passwd must be installed, and I do not see a good compelling reason to move it from its current orthagonal to DESTDIR locatoin in the src tree.

Aug 17 2018, 8:55 PM
rgrimes added a comment to D16775: Make 'device crypto' lines more consistent..
In D16775#356743, @ian wrote:

If using option IPSEC (and I guess GELI and maybe other things) requires explicitly specifying device crypto, then shouldn't this change also cleanup and simplify sys/conf/files to remove "| ipsec | ipsec_support" from all the files that are optional on "crypto"?

And as long as I'm on about consistancy, if we're going to start specifying devices in std.arm* then shouldn't we comb the existing arm kernel config files to find all the common [pseudo-]devices and move them into std.arm* as well? I don't remember why we decided that the std.arm* files would contain only options, but I do vaguely remember discussing it; it wasn't by accident.

Aug 17 2018, 6:01 PM
rgrimes accepted D16775: Make 'device crypto' lines more consistent..
Aug 17 2018, 4:21 PM

Aug 16 2018

rgrimes accepted D16740: GPT is standard in x86 and arm64 land. Add it to DEFAULTS with the others..
Aug 16 2018, 2:59 PM
rgrimes accepted D16728: Move master.passwd and group to lib/libc/gen/.

This looks okay to me for just the moving of master.passwd, though I am not found of its landing location, but can I ask for 24 hours to put together the net effect patch of what was commited, and partially reverted in combination with this patch to look for any of the pointy sticks that came up. Thanks, Rod

Aug 16 2018, 2:40 PM

Aug 15 2018

rgrimes added inline comments to D16725: Fix links install for bin/csh and bin/sh.
Aug 15 2018, 4:30 PM
rgrimes added inline comments to D16725: Fix links install for bin/csh and bin/sh.
Aug 15 2018, 4:23 PM
rgrimes added inline comments to D16725: Fix links install for bin/csh and bin/sh.
Aug 15 2018, 4:04 PM

Aug 14 2018

rgrimes added a comment to D16705: Create a loader for each interpreter for x86 BIOS and all EFI.
In D16705#355071, @imp wrote:

Would there be an objection to using SUBDIR names of loader.4th, loader.lua and loader.simp so that they sort next to each other vs the current names that scattter them about the directory? This also means that loader.foo/Makefile simply includes ../loader/Makefile all nice and orderly :-)

I would object.

We can't install them as loader.lua, loader.4th loader.simp because then we'd have loader.lua.efi, loader.4th.efi etc. Also the .4th suffix is what we use for actual 4th code. So that leaves us with a prefix, even if it is a bit less orderly.

Ack, ok simple enough reasoning.

Aug 14 2018, 3:15 PM
rgrimes accepted D16705: Create a loader for each interpreter for x86 BIOS and all EFI.
Aug 14 2018, 2:41 AM
rgrimes added a comment to D16705: Create a loader for each interpreter for x86 BIOS and all EFI.
In D16705#355071, @imp wrote:

Would there be an objection to using SUBDIR names of loader.4th, loader.lua and loader.simp so that they sort next to each other vs the current names that scattter them about the directory? This also means that loader.foo/Makefile simply includes ../loader/Makefile all nice and orderly :-)

I would object.

We can't install them as loader.lua, loader.4th loader.simp because then we'd have loader.lua.efi, loader.4th.efi etc. Also the .4th suffix is what we use for actual 4th code. So that leaves us with a prefix, even if it is a bit less orderly.

Aug 14 2018, 2:41 AM
rgrimes added inline comments to D16705: Create a loader for each interpreter for x86 BIOS and all EFI.
Aug 14 2018, 2:27 AM
rgrimes added a comment to D16705: Create a loader for each interpreter for x86 BIOS and all EFI.

Would there be an objection to using SUBDIR names of loader.4th, loader.lua and loader.simp so that they sort next to each other vs the current names that scattter them about the directory? This also means that loader.foo/Makefile simply includes ../loader/Makefile all nice and orderly :-)

Aug 14 2018, 2:26 AM

Aug 1 2018

rgrimes added a comment to D10320: usr.bin/netstat: -n should not print symbolic names.

Well, I am still on the fence with this one, seems someone has already done it to the route get -n command.

Aug 1 2018, 3:42 PM

Jul 12 2018

rgrimes added a reviewer for D11768: Add support to devel/libhyve-remote. (VNC Server): bhyve.
Jul 12 2018, 3:00 PM

Jul 11 2018

rgrimes added inline comments to D16205: Create three helper functions for parsing boot args..
Jul 11 2018, 4:38 AM
rgrimes added inline comments to D16205: Create three helper functions for parsing boot args..
Jul 11 2018, 4:29 AM

Jul 9 2018

rgrimes added a comment to D16161: Improve bhyve exit(3) error code..

This is also going to require a man page update, as now there are more than the 4 exit codes listed in the man page.

Jul 9 2018, 3:16 AM

Jul 7 2018

rgrimes added a comment to D16164: Make options IFLIB a real configuration option..

Does this not also make it so that these drivers require IFLIB, so they need to be marked as such in GENERIC/NOTES/etc and man pages?

Yeah, definitely. It also means that out of tree drivers (intel, bnxt) wouldn't work if a kernel is built without IFLIB. Is this ok to do?

Jul 7 2018, 5:19 PM
rgrimes added a comment to D16164: Make options IFLIB a real configuration option..

Does this not also make it so that these drivers require IFLIB, so they need to be marked as such in GENERIC/NOTES/etc and man pages?

Jul 7 2018, 3:43 PM

Jul 6 2018

rgrimes added a comment to D16161: Improve bhyve exit(3) error code..

Looks good over all, just some nits on errx vs err when it appears that there is a proper errno avaliable.

Jul 6 2018, 3:29 PM

Jun 29 2018

rgrimes added a comment to D16064: bin/dd: Add conv=direct.

I think it might be better to have 3 conv types, IDIRECT, ODIRECT, and DIRECT==IDIRECT|ODIRECT. You may or may not want vm effects on specific files.

Jun 29 2018, 6:20 PM

Jun 24 2018

rgrimes added a reviewer for D15992: bhyve: supported features reporting PoC: bhyve.
Jun 24 2018, 11:31 AM

Jun 15 2018

rgrimes added a comment to D15827: Remove obsolete asf(8).

I actually worry less about man page DEPRECATION, and more about having the binary spit something out so anyone using it for who knows what gets a heads up that it is/may be going away soon.

Jun 15 2018, 5:34 PM
rgrimes added a comment to D15827: Remove obsolete asf(8).

@brooks a fully sgree, infact it can be done in a seperate review, and the asf binary should spit out a warning, not just a man page change.

Jun 15 2018, 5:29 PM
rgrimes added a comment to D15827: Remove obsolete asf(8).

Does it make since to first commit a deprecation notice to this, which can be merged to stable/11, then actually remove it from ^/head after that? This avoids the need for a direct commit to stable/11

Jun 15 2018, 5:19 PM

Jun 12 2018

rgrimes added a reviewer for D15774: Fix style(9) space vs tab.: bhyve.
Jun 12 2018, 1:26 PM
rgrimes resigned from D15774: Fix style(9) space vs tab..
Jun 12 2018, 1:25 PM
rgrimes added a comment to D15774: Fix style(9) space vs tab..

I think you have mis understood what I asked for in the other review. It only needs to be split into 2 parts, one containing the SPDX tags, and another containing all the white space cleanup.

Jun 12 2018, 1:01 PM
rgrimes added a reviewer for D15775: style(9) remove unnecessary blank tabs.: bhyve.
Jun 12 2018, 12:21 PM
rgrimes added a comment to D15768: Cosmetic style(9) fixes space vs tab..

It is normal to separate all whitespace changes from other. It is preferable to separate all SPDX changes from others when it is sweeping. I strongly assert that as the person now cleaning up a 180k lines and 16 commits of diff involving SPDX tags that this separation occur before this is commited.

Jun 12 2018, 6:49 AM
rgrimes added a comment to D15768: Cosmetic style(9) fixes space vs tab..

Please seperate this into 2 reviews, one for the white space/tab cleanup and one for the SPDX tag addition.

Jun 12 2018, 5:44 AM
rgrimes added a reviewer for D15768: Cosmetic style(9) fixes space vs tab.: bhyve.
Jun 12 2018, 5:41 AM

Jun 11 2018

rgrimes added a reviewer for D15743: Extend loader(8) geli support to all architectures and all disk-like devices.: bhyve.
Jun 11 2018, 5:09 AM

Jun 9 2018

rgrimes added a comment to D9033: Raise BLOCKIF_IOV_MAX to 128. .

Unclear why phabricator does the remove of reviewers when I try to add group bhyve, restore grehan caused by that in last change.

Jun 9 2018, 12:06 PM
rgrimes added a reviewer for D9033: Raise BLOCKIF_IOV_MAX to 128. : grehan.
Jun 9 2018, 12:05 PM
rgrimes edited reviewers for D9033: Raise BLOCKIF_IOV_MAX to 128. , added: bhyve; removed: grehan, rgrimes.
Jun 9 2018, 12:04 PM

May 30 2018

rgrimes added a reviewer for D15628: Fix build of `stand/` with base gcc: bhyve.
May 30 2018, 9:44 PM
rgrimes added a comment to D15629: Pass a struct devdesc to the format commands. Use proper type rather than doing weird type-punning that happened to work because the size was right :(.

Copy over subscribers from D15628 and describe this review as a fix for an issue found during that review.

May 30 2018, 9:43 PM
rgrimes updated the summary of D15629: Pass a struct devdesc to the format commands. Use proper type rather than doing weird type-punning that happened to work because the size was right :(.
May 30 2018, 9:42 PM

May 28 2018

rgrimes added inline comments to D15595: Update pmclog(3) and cap_rights_get(3) EXAMPLE section..
May 28 2018, 2:30 PM
rgrimes added inline comments to D15595: Update pmclog(3) and cap_rights_get(3) EXAMPLE section..
May 28 2018, 2:06 PM

May 26 2018

rgrimes accepted D15481: Create a default wlan for wireless NICs if no wlans are specified..

Isnt there some documentation some place that also needs to be updated?

May 26 2018, 12:05 AM

May 24 2018

rgrimes added a comment to D15550: Fix a memory leak on topology_parse()..

Please mark the commit as MFC-X with https://svnweb.freebsd.org/changeset/base/332298

May 24 2018, 1:19 PM
rgrimes accepted D15550: Fix a memory leak on topology_parse()..
May 24 2018, 1:15 PM

May 23 2018

rgrimes accepted D15488: If reading the routing table fails, retry up to 10 times.

I am ok with this for now, but I think the values 100000uS and 2x are going to need some "experience" tuning.

May 23 2018, 7:38 AM