Page MenuHomeFreeBSD

rgrimes
User

Projects

User Details

User Since
Dec 19 2016, 4:11 AM (127 w, 3 h)

Recent Activity

Yesterday

rgrimes commandeered D16913: vmrun: add -x flag to disable reboot loop.
Sun, May 26, 2:58 AM
rgrimes updated the summary of D16913: vmrun: add -x flag to disable reboot loop.
Sun, May 26, 2:57 AM

Sat, May 25

rgrimes committed rS348271: MFC: r346714: Add accessor function for vm->maxcpus.
MFC: r346714: Add accessor function for vm->maxcpus
Sat, May 25, 11:28 AM
rgrimes committed rS348270: Correctly align usage: output.
Correctly align usage: output
Sat, May 25, 11:23 AM
rgrimes committed rS348269: MFC: r346717: Make bhyve SMBIOS table topology aware.
MFC: r346717: Make bhyve SMBIOS table topology aware
Sat, May 25, 10:17 AM

Fri, May 24

rgrimes resigned from D19247: Merge hold_count into wire_count..

Getting way above my pay grade

Fri, May 24, 11:33 PM
rgrimes retitled D16913: vmrun: add -x flag to disable reboot loop from vmrun: add -x flag to always exit when bhyve exists to vmrun: add -x flag to disable reboot loop.
Fri, May 24, 3:33 PM
rgrimes added a comment to D16913: vmrun: add -x flag to disable reboot loop.

@allanjude I know your work load is huge as well, if you need me to push a new diff I can do that, but then you have to agree to commit it or I have to pester bde/phk for an approval.

Fri, May 24, 3:30 PM
rgrimes added a comment to D10009: Fix a memory leak in bhyve.

Concur, but not sure how to force it closed.

Fri, May 24, 3:23 PM
rgrimes resigned from D10009: Fix a memory leak in bhyve.
Fri, May 24, 3:23 PM
rgrimes committed rS348226: MFC: r346717: Make bhyve SMBIOS table topology aware.
MFC: r346717: Make bhyve SMBIOS table topology aware
Fri, May 24, 5:47 AM
rgrimes committed rS348223: MFC: r346714: Add accessor function for vm->maxcpus.
MFC: r346714: Add accessor function for vm->maxcpus
Fri, May 24, 4:16 AM
rgrimes added a comment to D19506: Fix bug in bhyve by ignoring writes to errata MSRs in AMD cpus.

@jhb, reopening a commited phab review messes with things, as now when you make a second commit the default top patch in this review well be the one you commit, and one has to go digging in the review history to find the prior patch that was in the first commit. It is fine to reopen a review for a revert, but I think one should start a new review for a new change, which is what this is.

Fri, May 24, 12:45 AM · bhyve

Thu, May 23

rgrimes committed rS348201: MFC: r332298,333712,334199,334216,334219 bhyve cpu topology.
MFC: r332298,333712,334199,334216,334219 bhyve cpu topology
Thu, May 23, 9:23 PM
rgrimes committed rS348188: MFC: r347960: bhyve virtio needs barriers.
MFC: r347960: bhyve virtio needs barriers
Thu, May 23, 6:58 PM
rgrimes committed rS348186: MFC: r347960: bhyve virtio needs barriers.
MFC: r347960: bhyve virtio needs barriers
Thu, May 23, 6:49 PM
rgrimes accepted D19904: bhyve: Add Integrated Endpoint to PCIe Capability.
Thu, May 23, 4:46 PM
rgrimes accepted D19905: bhyve: Add EUI64 to NVMe device.
Thu, May 23, 4:45 PM
rgrimes accepted D20365: simplify bhyve vlapic ESR logic.
Thu, May 23, 12:48 AM · bhyve
rgrimes removed reviewers for D20365: simplify bhyve vlapic ESR logic: rgrimes, bhyve.
Thu, May 23, 12:48 AM · bhyve
rgrimes resigned from D20365: simplify bhyve vlapic ESR logic.
Thu, May 23, 12:47 AM · bhyve
rgrimes accepted D20365: simplify bhyve vlapic ESR logic.
Thu, May 23, 12:46 AM · bhyve

Wed, May 22

rgrimes added a comment to D20365: simplify bhyve vlapic ESR logic.

Minor nits, and a major win, good work!

Wed, May 22, 9:18 PM · bhyve

Tue, May 21

rgrimes added a comment to D20335: bhyve could be more precise with vPIT.

Any more little gold mines like this sitting around?

Tue, May 21, 7:51 PM · bhyve

Sat, May 18

rgrimes closed D19501: bhyve virtio needs barriers.
Sat, May 18, 7:33 PM
rgrimes committed rS347960: bhyve virtio needs barriers.
bhyve virtio needs barriers
Sat, May 18, 7:33 PM
rgrimes accepted D19501: bhyve virtio needs barriers.
Sat, May 18, 5:10 AM
rgrimes added a comment to D19501: bhyve virtio needs barriers.

Ok to commit once blank lines are added per jhb in person

Sat, May 18, 5:10 AM

Wed, May 15

rgrimes accepted D16728: Move master.passwd and group to lib/libc/gen/.

I thought this had already been committed?

Wed, May 15, 7:43 PM
rgrimes added a comment to D19501: bhyve virtio needs barriers.

I would like to see this in next weeks 11.3-PRERELEASE build, this looks to be a low risk barrier addition, @jhb does that seem to be a reasonable target, or would you like to see a longer ^head test cycle? Does anyone see any risk in this change?

Wed, May 15, 1:46 PM

Fri, May 10

rgrimes accepted D20117: Restructure mbuf send tags to provide stronger guarantees..
Fri, May 10, 8:00 PM

Thu, May 9

rgrimes updated the test plan for D19501: bhyve virtio needs barriers.
Thu, May 9, 4:51 PM
rgrimes added a comment to D19501: bhyve virtio needs barriers.

This may be a fix for https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231117, the person is testing.

Thu, May 9, 4:50 PM

Tue, May 7

rgrimes accepted D19501: bhyve virtio needs barriers.

Thanks for the quick spin on this Patrick

Tue, May 7, 10:22 PM
rgrimes added a comment to D19501: bhyve virtio needs barriers.

Ping

Tue, May 7, 1:31 PM

Sat, May 4

rgrimes committed rS347124: MFC: r346715: Acpi MADT table correction for VM_MAXCPU > 21.
MFC: r346715: Acpi MADT table correction for VM_MAXCPU > 21
Sat, May 4, 1:43 PM

Fri, May 3

rgrimes accepted D19001: Bhyve VT-d IOMMU: Support capability detection for multiple translation units.

@jhb it would be good to not have this issue in 11.3

Fri, May 3, 8:44 AM · bhyve

Thu, May 2

rgrimes added inline comments to D20117: Restructure mbuf send tags to provide stronger guarantees..
Thu, May 2, 8:44 PM

Wed, May 1

rgrimes added a comment to D20117: Restructure mbuf send tags to provide stronger guarantees..

You can mark all my comments as done, I am fine with your answers, I added bz and requested his review on the one change.

Wed, May 1, 9:48 PM
rgrimes added a reviewer for D20117: Restructure mbuf send tags to provide stronger guarantees.: bz.
Wed, May 1, 9:46 PM
rgrimes added a comment to D20065: Use system wiring in vmm(4)..
In D20065#433092, @kib wrote:
In D20065#432936, @jhb wrote:
In D20065#432917, @jhb wrote:

To be clear, the limit isn't being applied today? From the existing code it seems like it should be already in force if I'm reading the diff to vm_map_wire correctly?

The diff is being applied on top of D19908. Without that change, the limit does not get applied to bhyve.

Ok.

Also, if bhyve is allowed to ignore the limit, the amount of wired memory it uses does mean that small requests by, say, gpg will then fail on the host, yes?

Yes, that's right (and true in head today). In the original version of this diff, where bhyve was doing system wiring, that was not the case since system-wired pages are not counted towards the limit.

Ok. I still don't really know how I feel. I think I probably want all long-term wirings to honor the limit as kib@ says and that users will just have to up the limit when using wired VMs with bhyve. If we can get a suitably unique errno value back in whatever creates the wired memory for bhyve and emit a useful error message to the user, that is probably sufficient.

Ok. I guess we can just try and see if there's any fallout. I do think it means that D19908 is not MFCable.

If you add a knob to disable accounting for bhyve requests, it can be merged.

Wed, May 1, 5:26 PM
rgrimes accepted D19908: Provide accounting of user-wired pages..

Do we have to add _user_ to the variables, I only see a rename here, and not a second value used in place of where _users_ went in, or am I totally missing something?

Wed, May 1, 5:23 PM
rgrimes added a comment to D19908: Provide accounting of user-wired pages..

Do we have to add _user_ to the variables, I only see a rename here, and not a second value used in place of where _users_ went in, or am I totally missing something?

Wed, May 1, 5:21 PM
rgrimes added a comment to D20117: Restructure mbuf send tags to provide stronger guarantees..

I have made one quick pass over this, now that I have read all the bits I would like to make a second pass, my comments now are nits mostly, and can be safely ignored. However I do, as others, have some pretty big concerns about sharing the rcvif with tags, is there some great cost in not doing that?

Wed, May 1, 4:36 PM
rgrimes resigned from D20065: Use system wiring in vmm(4)..
Wed, May 1, 12:37 AM
rgrimes added a comment to D20065: Use system wiring in vmm(4)..

Well this in any way help with the fact we do not apply any pressure to the zfs arc_max and end up in a memory shortfall that causes high paging? I suspect not as most people do not wire there VM's in memory unless they know that is what they need to do to keep zfs from killing your box with OOM

Wed, May 1, 12:36 AM

Apr 27 2019

rgrimes added a comment to D20065: Use system wiring in vmm(4)..

I can see both sides of this, can I ask that the bhyve developers group which meets every 2 weeks be given a chance to discuss this and provide feedback on it? Thanks. Many of us well be at BSDCan a day early for bhyvecon if you wish to discuss it in person.

Why can't the discussion happen here?

Some of it is, but we meet on a cyclic basis to have high bandwidth low delay discussions and I was just asking for the opportunity to allow that discussion to occur. Or if you referring to the in person option that was offered up "if you wish".

Apr 27 2019, 6:40 AM

Apr 26 2019

rgrimes requested changes to D20065: Use system wiring in vmm(4)..

I can see both sides of this, can I ask that the bhyve developers group which meets every 2 weeks be given a chance to discuss this and provide feedback on it? Thanks. Many of us well be at BSDCan a day early for bhyvecon if you wish to discuss it in person.

Apr 26 2019, 3:48 PM
rgrimes added a comment to D19993: Don't symlink fusefs.ko to fuse.ko on PPC.

The symlink is a new addition for 13.0 (and hopefully 12.1). I would be ok with deleting it for 13.0. But how about I commit this change to head first, and then delete the symlink? That will make MFCs cleaner.

Apr 26 2019, 3:27 PM

Apr 25 2019

rgrimes committed rS346717: Make bhyve SMBIOS table topology aware.
Make bhyve SMBIOS table topology aware
Apr 25 2019, 10:54 PM
rgrimes closed D18998: Make bhyve SMBIOS table topology aware.
Apr 25 2019, 10:54 PM
rgrimes committed rS346715: Acpi MADT table correction for VM_MAXCPU > 21.
Acpi MADT table correction for VM_MAXCPU > 21
Apr 25 2019, 10:52 PM
rgrimes closed D18815: Bhyve acpi MADT table correction for VM_MAXCPU > 21.
Apr 25 2019, 10:52 PM
rgrimes committed rS346714: Add accessor function for vm->maxcpus.
Add accessor function for vm->maxcpus
Apr 25 2019, 10:51 PM
rgrimes closed D18755: Add accessor for vm->maxcpus in preperation for run time maxcpu setting.
Apr 25 2019, 10:51 PM
rgrimes committed rS346710: MFC: r345888: Use IN_foo() macros from sys/netinet/in.h inplace of.
MFC: r345888: Use IN_foo() macros from sys/netinet/in.h inplace of
Apr 25 2019, 9:28 PM
rgrimes added inline comments to D20044: tun/tap: merge.
Apr 25 2019, 5:22 PM
rgrimes accepted D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

This makes it much clearer to me, thanks jhb

Apr 25 2019, 5:03 PM · bhyve

Apr 20 2019

rgrimes added a comment to D19993: Don't symlink fusefs.ko to fuse.ko on PPC.

We only need to maintain "backwards" compatibility in the stable/ branches (12 and 11) as far as I am concerned head can just nuke the compatibilty link, and have a 13.0 release notes item that is "fuse has been renamed to fusefs".

Apr 20 2019, 10:28 PM
rgrimes requested changes to D19976: bhyve: Support a _VARS.fd file for bootrom.
Apr 20 2019, 12:45 AM
rgrimes accepted D19975: vmm: Add emulation for the `add` instruction.

A question to @jhb, should the order of the enum and the code updated to be in alphabetic order, in a seperate review, it would only obfuscate the change to do it here.

Apr 20 2019, 12:09 AM

Apr 15 2019

rgrimes accepted D19587: net: adjust randomized address bits.
Apr 15 2019, 10:46 PM

Apr 14 2019

rgrimes accepted D19905: bhyve: Add EUI64 to NVMe device.
Apr 14 2019, 6:30 PM
rgrimes accepted D19904: bhyve: Add Integrated Endpoint to PCIe Capability.

Looks good, other than a lot of extra blank lines.

Apr 14 2019, 6:26 PM

Apr 12 2019

rgrimes added a comment to D19587: net: adjust randomized address bits.

Would iflib like any kind of UPDATING or relnote mention for the generated 'stable' MAC address likely changing (since we're restricting the range now to a subset of the FF OUI), or is it fine without explicit mention?

Apr 12 2019, 4:26 PM

Apr 7 2019

rgrimes accepted D19839: add INET6 support to nfsdumpstate for the client callback address.

You can mark all my comments as done, you have addressed them to my satisfaction.

Apr 7 2019, 8:47 PM
rgrimes added inline comments to D19839: add INET6 support to nfsdumpstate for the client callback address.
Apr 7 2019, 3:57 AM

Apr 6 2019

rgrimes added inline comments to D19218: fix nfsuserd to find a mapped "localhost" ip address and to use INET6 when INET isn't available.
Apr 6 2019, 8:13 AM
rgrimes accepted D19218: fix nfsuserd to find a mapped "localhost" ip address and to use INET6 when INET isn't available.
Apr 6 2019, 4:14 AM

Apr 5 2019

rgrimes added a comment to D18670: Minor speedup for load_kld function.

I have performed a visual only review.

Greatly appreciated. Can I take that as approval by a src developer?

Apr 5 2019, 9:26 PM
rgrimes accepted D18670: Minor speedup for load_kld function.

I have performed a visual only review.

Apr 5 2019, 9:01 PM
rgrimes accepted D19829: Write string constant differently to improve readability..

Thank you, that is 100x clearer as to what is in the constant

Apr 5 2019, 8:15 AM

Apr 3 2019

rgrimes accepted D19695: bhyve(8): Fix NVMe data structure copy to guest.

Confirmation of a working Windows 2019 boot after this patch: https://lists.freebsd.org/pipermail/freebsd-virtualization/2019-April/007333.html

Apr 3 2019, 9:01 AM

Apr 2 2019

rgrimes added a comment to D19788: bhyve: Use separate fds for stdin and stdout..

Can we get a review to cause bhyve -b to emit a deprecation warning notice (gone_in(13)) if someone tries to use it? That could be merged to stable/12, then the code in head killed.
This would also apply to the bvmconsole driver, is there someway to emit a warning during config(8) when someone uses a feature being deprecated? Doing this provides us feedback
sooner rather than later that some feature was in use some place.

Apr 2 2019, 2:32 AM
rgrimes accepted D19786: bhyve: Fix indentation in uart_emul.c.

Looks like someone may of removed a condition at some time in the past and not re-dented the code to produce a minimal diff.

Apr 2 2019, 2:15 AM
rgrimes accepted D19787: bhyve: Stop compiling with -O0..

Does this variable get used by default? I saw this here and just ignored it as I thought it would only be invoked if I asked for a DEBUG build from a level above. If we are always adding DEBUG_FLAGS to our compiles perhaps it should be called something else?

Apr 2 2019, 1:54 AM

Mar 25 2019

rgrimes resigned from D19019: zfs stand: plumb primary vdev out through zfs_probe_dev as needed.
Mar 25 2019, 9:21 AM

Mar 19 2019

rgrimes added a comment to D19649: Rename fuse(4) to fusefs(4).

Please have a discussion on arch@ or filesystems@, this review needs more discussion

Mar 19 2019, 10:23 PM
rgrimes added a comment to D19317: Use IN_foo() macros from sys/netinet/in.h inplace of handcrafted code.

Can I get some final accept on this, I updated the open issues

Mar 19 2019, 3:01 AM

Mar 15 2019

rgrimes added inline comments to D19587: net: adjust randomized address bits.
Mar 15 2019, 7:42 PM

Mar 14 2019

rgrimes accepted D19580: Fix bhyve PCIe capability emulation.
Mar 14 2019, 11:38 AM
rgrimes added reviewers for D19580: Fix bhyve PCIe capability emulation: jhb, rgrimes.
Mar 14 2019, 11:34 AM
rgrimes accepted D19579: Fix bhyve's NVMe Identify Namespace data.
Mar 14 2019, 11:30 AM
rgrimes added a reviewer for D19579: Fix bhyve's NVMe Identify Namespace data: jhb.
Mar 14 2019, 11:29 AM

Mar 11 2019

rgrimes added inline comments to D19357: PFIL_MEMPTR support for ipfw link level hook.
Mar 11 2019, 10:05 PM
rgrimes accepted D19535: Support device-independent labels for geom_flashmap slices..
Mar 11 2019, 5:16 PM
rgrimes added a comment to D19535: Support device-independent labels for geom_flashmap slices..

I like it, just nits, that for the most part you can ignore, other than $FreeBSD: vs $FreeBSD$

Mar 11 2019, 5:16 PM

Mar 9 2019

rgrimes added a comment to D19506: Fix bug in bhyve by ignoring writes to errata MSRs in AMD cpus.

This appears to be used to deal with a core hang on specific CPU's, we need to see that we have mitigated that in the host, and the decide what the appropriate action here is, I am uncomfortable with just making this silently disappear. Deferning to jhb.

Mar 9 2019, 7:55 PM · bhyve
rgrimes added a comment to D19506: Fix bug in bhyve by ignoring writes to errata MSRs in AMD cpus.

Though this does fix your issue by silencing the log, it does little to improve the situation. I think what we may want to do is to add yet another option to the bhyve command that along with -w to ignore invalid MSR access to do so silently so that we do not have to add code like this everything a new msr comes into play. John, Patrick your thoughts on this approach?

Mar 9 2019, 1:44 PM · bhyve
rgrimes added reviewers for D19506: Fix bug in bhyve by ignoring writes to errata MSRs in AMD cpus: jhb, pmooney_pfmooney.com.
Mar 9 2019, 1:34 PM · bhyve

Mar 8 2019

rgrimes added a comment to D19426: post-commit hooks: Accept BZ URLs in PR lines.

I would be comfortable with simply "https://bugs.freebsd.org/12344" as that can likely work forever.

Note that https://bugs.freebsd.org/12344 does work - we should accept either https://bugs.freebsd.org/bugzilla/show_bug.cgi?id= or https://bugs.freebsd.org/[0-9]+

Mar 8 2019, 9:33 PM
rgrimes added a comment to D19459: subversion: update commit message template to allow URLs in PR field.

I believe what your wanting is web server re-write rules, that would rewrite the URL in and out of the web pages to have the preffered form. Beyond my area of expertise to implement, but I know it can be done and that is probably the easiest place to do it (ie, no modifying bugzilla should be required.)

Mar 8 2019, 4:43 PM

Mar 7 2019

rgrimes accepted D19501: bhyve virtio needs barriers.
Mar 7 2019, 8:51 PM
rgrimes accepted D19499: bhyve uart broken for win2016 guest.

I removed a redundant "to" in the description. Patch looks good to me. Copyright over to jhb@

Mar 7 2019, 8:47 PM · bhyve
rgrimes updated the summary of D19499: bhyve uart broken for win2016 guest.
Mar 7 2019, 8:46 PM · bhyve

Mar 6 2019

rgrimes accepted D19485: Drop "All rights reserved" from my copyright statements..
Mar 6 2019, 9:58 PM
rgrimes added inline comments to D19485: Drop "All rights reserved" from my copyright statements..
Mar 6 2019, 9:28 PM
rgrimes added a comment to D19485: Drop "All rights reserved" from my copyright statements..

I'll review if you ack your are done updating John

Mar 6 2019, 8:07 PM
rgrimes accepted D19485: Drop "All rights reserved" from my copyright statements..
Mar 6 2019, 7:46 PM

Mar 5 2019

rgrimes accepted D19460: subversion: update commit message template to allow URLs in PR field.
Mar 5 2019, 7:42 PM