User Details
- User Since
- Dec 19 2016, 4:11 AM (212 w, 5 d)
Dec 4 2020
Nov 24 2020
Oct 26 2020
Oct 25 2020
Though this is good intent, it is not a good approach. I'll assert again at one time we had erradicated all /usr/local from the base system, these above have crept in over time and again should be erradicated. There should never ever be a /usr/local #define in paths.h, having to recompile code to change this, again, is the wrong approach. This should _possibly_/_probably_ be moved to a kernel variable that can be changed at boot time.
Oct 1 2020
Sep 25 2020
Aug 25 2020
Aug 22 2020
Aug 19 2020
The summary of this review is lacking detail
Aug 17 2020
Aug 16 2020
Aug 15 2020
Aug 14 2020
Aug 13 2020
Is there any concern or additional work needed for ipV6?
Aug 12 2020
To all those harping about it not being foo or bar or zed, this *is* an underlying frame work that is very flexible and allows one to implement what ever foo, bar or zed configuration you want on top of it. This leaves json, xml, or any other implementation out of the base layer code and those can be implemented in a layer above this. This has been discussed for a some time extensively by those that attend the semi-monthly bhyve call.
Aug 7 2020
Aug 6 2020
Approving as mentor only.
Aug 1 2020
Jul 31 2020
Reflowing sentences and removal of .Tn seems like busy work to me. Much easier to just make mandoc ignore .Tn and igor silent on its usage. These macros DO make the groff man pages output look different, and IMHO, nicer.
Jul 30 2020
I still see request changes markers from emaste and jhb/bhyve, what are these changes?
Jul 28 2020
Jul 27 2020
Could we please get stances in /etc/sshd/ssh{,d}_config commented out that show how to enable these if they are needed?
Jul 24 2020
I have no objection to it, but it is still not totally factual, more than likely it was "intergrated" into FreeBSD Current/Head when it was at 12 and merged back to stable/11 and first appeared in a FreeBSD release at 11.1. I still do not see any added value to the history of mandoc by this change, and it just makes FreeBSD have a local diff to the mandoc from witch it was derived. Speaking of which, shouldn't this be on a vendor branch?
Jul 21 2020
Jul 20 2020
Jul 16 2020
Jul 15 2020
Jul 10 2020
I see a fair amount of white space/formatting only changes in this, it MAY make since to break those out as 0 effort review.
I also have concerns over any performance claims, though I see the old code is probably at least sub optimal in that it often checks for UDP, then for TCP when the volume of traffic should almost always be mostly TCP. Also modern compilers should just "handle this" without rewritting code unless something odd is being done. If you really want to micro optimize I suspect rewriting this as "branchless" code that results in cmovl or other instructions might be interesting. I have heard of 40x code speed improvements using such tenchiques, but that is mostly in tight loops.
Jul 9 2020
I was asked to look at this and see if I could help get the Makefile issues moved forward. I have commented inline.
I concur on this point. Not all sysctl are idempotent.
Jul 7 2020
Jul 6 2020
This is a good fix, it is wrong for the kernel to try and guess that something is wrong here. "Highly Probably != For Certain" and having this kind of stuff get in the way when your trying to make something work is very annoying for the end user. Now if we could just get the hard coded interface loopback route creating/removal out of the kernel.
Jul 5 2020
I do not believe we normally document this type of information in the HISTORY section of manual pages. The history sections of these man pages are already rich with information, especially when you add the history included in the Authors section.
Jul 4 2020
Is it possible to do cgn without rfc1918? I think the changes should allow for that configuration.
Jul 2 2020
Though much better than the prior iteration I believe it leaves some detail out.
Jun 24 2020
Jun 23 2020
This has been in process for 15 months and should be evolving in tree rather than in a review at this point, IMHO. If no one objects to it being committed in 7 days I am asking that Richard go ahead and commit it.
So, is FreeBSD getting close to a proper Cubic yet?
Jun 22 2020
It took me a few "brain loops" to realize you mean the "local loopback interface address" or is there actually some concept of a "primary local IP address."?
Jun 19 2020
Jun 18 2020
I find this change debatable, and as presented here incomplete as I believe this has effects on some other parts of style(9), nor does it provide a proper sample (it leaves the example unchanged) Lets not RUSH to slam this in the tree!
Jun 10 2020
Jun 9 2020
Jun 5 2020
If you have clients that need to do this type of thing I would recommend they are running behind DSCP and they should use 2 DSCP's to seperate there DCTCP like traffic from there TCP/reno like traffic. Using ECT(1) as a traffic classifier in advance of IETF clear decision may land them in a very hard to resolve possition in the future.
Jun 4 2020
May 22 2020
No, the point was to reduce the amount of change
Just a couple nits, and I can be ignore on my line breaking issues.
May 21 2020
I'll commit this today
Approving as mentor, only a visual code read was done.
May 20 2020
Works for me
May 18 2020
Now that I have had time to go play with this on a "Linux" system, I am afraid I object to this change. Your doing it because you don't like the occasional splat of "foo is a binary file" when you run a grep *, you should see the results when EISDIR is returned. These types of greps on a linux system return an error message for every directory in the directory you ran the grep in, far more noise than your small issue, and for many of us this is gona be a PITA/POLA change. I hadnt thought much about it cause I alias 'grep' 'grep -d skip' and do not see your issue or my issue normally on linux.
May 15 2020
I do not like the undocumented (per summary anyway) KASSERT added for writes.
May 13 2020
May 8 2020
May 7 2020
I know there well be flak over using .Tn in a man page fix, can you submit a new diff without the .Tn's?
May 6 2020
I just fixed a couple typos in the summary, looks ok.
May 5 2020
Can we get some more eyes on this please?
May 3 2020
May 2 2020
Apr 29 2020
Apr 28 2020
Thank you for the comment, that helps me, small english nit
That reads much better, cleaned it up a fair bit more than I thought it would.
Adding bz, as it is his XXX-BZ comment being removed about implementing this.