Page MenuHomeFreeBSD

rgrimes
User

Projects

User Details

User Since
Dec 19 2016, 4:11 AM (91 w, 2 d)

Recent Activity

Mon, Sep 10

rgrimes added a comment to D17106: Generate /etc/services from the IANA registry (plus local mods).

Is there anyway to NOT have the 141,000 line xml version of the file stored in SVN?
Also we need to make absolutely sure that any services used by ports are not effected by anything this changes.

Mon, Sep 10, 5:51 PM
rgrimes added reviewers for D17106: Generate /etc/services from the IANA registry (plus local mods): asomers, rgrimes.
Mon, Sep 10, 5:45 PM
rgrimes updated subscribers of D17040: Enable WITHOUT_INET* WITHOUT_CRYPT WITHOUT_OPENSSL, WITHOUT_FILE.

Some more comments inline - as mentioned earlier we should try to address the root causes, as in D17074. That said, I'm fine with this approach pending root cause fixes (given that it doesn't build today), but want to make sure we have some way to track these outstanding issues such that they'll get fixed after the release.

Mon, Sep 10, 3:36 PM

Fri, Sep 7

rgrimes added a comment to D17074: Allow dhclient and ping to build WITHOUT_DYNAMICROOT.

It just hit me and I have to ask, why isnt libcasper avaliable in a static configuration? I certainly see a /usr/lib/libcasper.a on my systems.

Fri, Sep 7, 6:31 PM
rgrimes accepted D17074: Allow dhclient and ping to build WITHOUT_DYNAMICROOT.
Fri, Sep 7, 6:26 PM
rgrimes committed rS338525: Increase size of working imgfile from 250MB to 4GB.
Increase size of working imgfile from 250MB to 4GB
Fri, Sep 7, 3:52 PM
rgrimes committed rS338524: Remove rsync to phk's server.
Remove rsync to phk's server
Fri, Sep 7, 3:48 PM

Thu, Sep 6

rgrimes added inline comments to D17040: Enable WITHOUT_INET* WITHOUT_CRYPT WITHOUT_OPENSSL, WITHOUT_FILE.
Thu, Sep 6, 12:24 PM

Wed, Aug 29

rgrimes added a comment to D16945: userboot: handle guest interpreter mismatches more intelligently.

(Note to Rod: this is only partially what's going to end up in the review... this isn't a final product for review yet)

Wed, Aug 29, 4:52 PM

Mon, Aug 27

rgrimes added a comment to D16913: vmrun: add -x flag to always exit when bhyve exists.

Allan, would you update the diff please

Mon, Aug 27, 3:41 PM

Sun, Aug 26

rgrimes added a comment to D16913: vmrun: add -x flag to always exit when bhyve exists.

To add information, I have email from Paul Vixie and in fact he is wanting to break the reboot loop with -x so that it can be handled externally.

Sun, Aug 26, 11:18 PM
rgrimes added a comment to D16913: vmrun: add -x flag to always exit when bhyve exists.

I do not believe this is a desirable change, at least it does not do what it claims it does.

Sun, Aug 26, 10:41 PM
rgrimes added a reviewer for D10335: VirtFS/9p filesystem passthrough support (virtio-9p): bhyve.
Sun, Aug 26, 6:54 PM

Sat, Aug 25

rgrimes accepted D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..
Sat, Aug 25, 5:51 AM
rgrimes accepted D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..

Looks good, my minor nits can be ignored, up to you.
Oh, I see you changed the return code of the module load, I take it that is to lower its preference???

Sat, Aug 25, 3:47 AM

Fri, Aug 24

rgrimes added a comment to D12507: Dummynet AQM usage documentation for ipfw man page.

I am sorry for not getting to this today, I was side lined.

Fri, Aug 24, 12:41 AM

Thu, Aug 23

rgrimes requested changes to D16870: Turn drm2 back on in TEGRA124.

I respectfully request that a straight revert of the commits be done rather than this, for one this does not allow us to do the proper deprecation commits, nor to merge those commits back to stable/11. This is still a major violation of deprecation policy. Warner, would you new policy allow this type of thing to be accepted? I would hope not.

Thu, Aug 23, 5:49 PM
rgrimes accepted D16856: Initial proposed patch for SSL root bundle in base.

Looks ok, though I wonder about a shell script that writes a Makefile, it should be possible to do that in a Makefile by itself, there is the .for/.endfor operator to make which can duplicate what the shell script does.

Thu, Aug 23, 3:13 PM

Wed, Aug 22

rgrimes added a comment to D12507: Dummynet AQM usage documentation for ipfw man page.

Can I please have atleast 24 hours to review the text of this.

Wed, Aug 22, 11:39 PM

Tue, Aug 21

rgrimes added a comment to D16684: Extend security/ca_root_nss MAca-bundle.pl.

Im no perl fan so I wont comment on that aspect.

Tue, Aug 21, 12:19 AM

Aug 20 2018

rgrimes accepted D16805: Turn back the clock just a little: make userboot.so always be 4th.
Aug 20 2018, 12:16 AM
rgrimes added a reviewer for D16805: Turn back the clock just a little: make userboot.so always be 4th: bhyve.
Aug 20 2018, 12:15 AM

Aug 18 2018

rgrimes added a comment to D16770: Move dot.profile dot.cshrc to bin/sh/ and bin/csh/.

Can you please break the change to share/mk/bsd.confs.mk out into a separate review, though it is required by the moving of the profile files, it is actually not a part of that change directly. I would also like to ask that you tag bdrewery in on the review of the .mk change. I do not see how file owner/group/mode are set in the new Makefile.

Aug 18 2018, 3:16 PM
rgrimes added a comment to D16728: Move master.passwd to lib/libc/gen/.

Though I disagree with the relocation of this to libc as it is going to be installed with the absolute minimal system anyway so this delta just creates src tree churn, and user finger memory churn. You site your reason for moving it is to put it close to the sources, well, traditionally BSD sources are layed out to match the installed DESTDIR tree. I understand things like csh and sh conf files moving, that makes since in a world where csh or sh may or may not be installed by a pkgbase, however that makes no since in a world where libc and hence master.passwd shall always be installed.

Aug 18 2018, 2:59 PM
rgrimes added a reviewer for D16790: Update L1TF workaround to sustain L1D pollution from NMI.: bhyve.
Aug 18 2018, 2:47 PM

Aug 17 2018

rgrimes added a comment to D16728: Move master.passwd to lib/libc/gen/.

A question has come up, isnt libc part of base, ie even in a pkgbase system libc must be installed? If that is the case then master.passwd must be installed, and I do not see a good compelling reason to move it from its current orthagonal to DESTDIR locatoin in the src tree.

Aug 17 2018, 8:55 PM
rgrimes added a comment to D16775: Make 'device crypto' lines more consistent..
In D16775#356743, @ian wrote:

If using option IPSEC (and I guess GELI and maybe other things) requires explicitly specifying device crypto, then shouldn't this change also cleanup and simplify sys/conf/files to remove "| ipsec | ipsec_support" from all the files that are optional on "crypto"?

And as long as I'm on about consistancy, if we're going to start specifying devices in std.arm* then shouldn't we comb the existing arm kernel config files to find all the common [pseudo-]devices and move them into std.arm* as well? I don't remember why we decided that the std.arm* files would contain only options, but I do vaguely remember discussing it; it wasn't by accident.

Aug 17 2018, 6:01 PM
rgrimes accepted D16775: Make 'device crypto' lines more consistent..
Aug 17 2018, 4:21 PM

Aug 16 2018

rgrimes accepted D16740: GPT is standard in x86 and arm64 land. Add it to DEFAULTS with the others..
Aug 16 2018, 2:59 PM
rgrimes accepted D16728: Move master.passwd to lib/libc/gen/.

This looks okay to me for just the moving of master.passwd, though I am not found of its landing location, but can I ask for 24 hours to put together the net effect patch of what was commited, and partially reverted in combination with this patch to look for any of the pointy sticks that came up. Thanks, Rod

Aug 16 2018, 2:40 PM

Aug 15 2018

rgrimes added inline comments to D16725: Fix links install for bin/csh and bin/sh.
Aug 15 2018, 4:30 PM
rgrimes added inline comments to D16725: Fix links install for bin/csh and bin/sh.
Aug 15 2018, 4:23 PM
rgrimes added inline comments to D16725: Fix links install for bin/csh and bin/sh.
Aug 15 2018, 4:04 PM

Aug 14 2018

rgrimes added a comment to D16705: Create a loader for each interpreter for x86 BIOS and all EFI.
In D16705#355071, @imp wrote:

Would there be an objection to using SUBDIR names of loader.4th, loader.lua and loader.simp so that they sort next to each other vs the current names that scattter them about the directory? This also means that loader.foo/Makefile simply includes ../loader/Makefile all nice and orderly :-)

I would object.

We can't install them as loader.lua, loader.4th loader.simp because then we'd have loader.lua.efi, loader.4th.efi etc. Also the .4th suffix is what we use for actual 4th code. So that leaves us with a prefix, even if it is a bit less orderly.

Ack, ok simple enough reasoning.

Aug 14 2018, 3:15 PM
rgrimes accepted D16705: Create a loader for each interpreter for x86 BIOS and all EFI.
Aug 14 2018, 2:41 AM
rgrimes added a comment to D16705: Create a loader for each interpreter for x86 BIOS and all EFI.
In D16705#355071, @imp wrote:

Would there be an objection to using SUBDIR names of loader.4th, loader.lua and loader.simp so that they sort next to each other vs the current names that scattter them about the directory? This also means that loader.foo/Makefile simply includes ../loader/Makefile all nice and orderly :-)

I would object.

We can't install them as loader.lua, loader.4th loader.simp because then we'd have loader.lua.efi, loader.4th.efi etc. Also the .4th suffix is what we use for actual 4th code. So that leaves us with a prefix, even if it is a bit less orderly.

Aug 14 2018, 2:41 AM
rgrimes added inline comments to D16705: Create a loader for each interpreter for x86 BIOS and all EFI.
Aug 14 2018, 2:27 AM
rgrimes added a comment to D16705: Create a loader for each interpreter for x86 BIOS and all EFI.

Would there be an objection to using SUBDIR names of loader.4th, loader.lua and loader.simp so that they sort next to each other vs the current names that scattter them about the directory? This also means that loader.foo/Makefile simply includes ../loader/Makefile all nice and orderly :-)

Aug 14 2018, 2:26 AM

Aug 1 2018

rgrimes added a comment to D10320: usr.bin/netstat: -n should not print symbolic names.

Well, I am still on the fence with this one, seems someone has already done it to the route get -n command.

Aug 1 2018, 3:42 PM

Jul 12 2018

rgrimes added a reviewer for D11768: Add support to devel/libhyve-remote. (VNC Server): bhyve.
Jul 12 2018, 3:00 PM

Jul 11 2018

rgrimes added inline comments to D16205: Create three helper functions for parsing boot args..
Jul 11 2018, 4:38 AM
rgrimes added inline comments to D16205: Create three helper functions for parsing boot args..
Jul 11 2018, 4:29 AM

Jul 9 2018

rgrimes added a comment to D16161: Improve bhyve exit(3) error code..

This is also going to require a man page update, as now there are more than the 4 exit codes listed in the man page.

Jul 9 2018, 3:16 AM

Jul 7 2018

rgrimes added a comment to D16164: Make options IFLIB a real configuration option..

Does this not also make it so that these drivers require IFLIB, so they need to be marked as such in GENERIC/NOTES/etc and man pages?

Yeah, definitely. It also means that out of tree drivers (intel, bnxt) wouldn't work if a kernel is built without IFLIB. Is this ok to do?

Jul 7 2018, 5:19 PM
rgrimes added a comment to D16164: Make options IFLIB a real configuration option..

Does this not also make it so that these drivers require IFLIB, so they need to be marked as such in GENERIC/NOTES/etc and man pages?

Jul 7 2018, 3:43 PM

Jul 6 2018

rgrimes added a comment to D16161: Improve bhyve exit(3) error code..

Looks good over all, just some nits on errx vs err when it appears that there is a proper errno avaliable.

Jul 6 2018, 3:29 PM

Jun 29 2018

rgrimes added a comment to D16064: bin/dd: Add conv=direct.

I think it might be better to have 3 conv types, IDIRECT, ODIRECT, and DIRECT==IDIRECT|ODIRECT. You may or may not want vm effects on specific files.

Jun 29 2018, 6:20 PM

Jun 24 2018

rgrimes added a reviewer for D15992: bhyve: supported features reporting PoC: bhyve.
Jun 24 2018, 11:31 AM

Jun 15 2018

rgrimes added a comment to D15827: Remove obsolete asf(8).

I actually worry less about man page DEPRECATION, and more about having the binary spit something out so anyone using it for who knows what gets a heads up that it is/may be going away soon.

Jun 15 2018, 5:34 PM
rgrimes added a comment to D15827: Remove obsolete asf(8).

@brooks a fully sgree, infact it can be done in a seperate review, and the asf binary should spit out a warning, not just a man page change.

Jun 15 2018, 5:29 PM
rgrimes added a comment to D15827: Remove obsolete asf(8).

Does it make since to first commit a deprecation notice to this, which can be merged to stable/11, then actually remove it from ^/head after that? This avoids the need for a direct commit to stable/11

Jun 15 2018, 5:19 PM

Jun 12 2018

rgrimes added a reviewer for D15774: Fix style(9) space vs tab.: bhyve.
Jun 12 2018, 1:26 PM
rgrimes resigned from D15774: Fix style(9) space vs tab..
Jun 12 2018, 1:25 PM
rgrimes added a comment to D15774: Fix style(9) space vs tab..

I think you have mis understood what I asked for in the other review. It only needs to be split into 2 parts, one containing the SPDX tags, and another containing all the white space cleanup.

Jun 12 2018, 1:01 PM
rgrimes added a reviewer for D15775: style(9) remove unnecessary blank tabs.: bhyve.
Jun 12 2018, 12:21 PM
rgrimes added a comment to D15768: Cosmetic style(9) fixes space vs tab..

It is normal to separate all whitespace changes from other. It is preferable to separate all SPDX changes from others when it is sweeping. I strongly assert that as the person now cleaning up a 180k lines and 16 commits of diff involving SPDX tags that this separation occur before this is commited.

Jun 12 2018, 6:49 AM
rgrimes added a comment to D15768: Cosmetic style(9) fixes space vs tab..

Please seperate this into 2 reviews, one for the white space/tab cleanup and one for the SPDX tag addition.

Jun 12 2018, 5:44 AM
rgrimes added a reviewer for D15768: Cosmetic style(9) fixes space vs tab.: bhyve.
Jun 12 2018, 5:41 AM

Jun 11 2018

rgrimes added a reviewer for D15743: Extend loader(8) geli support to all architectures and all disk-like devices.: bhyve.
Jun 11 2018, 5:09 AM

Jun 9 2018

rgrimes added a comment to D9033: Raise BLOCKIF_IOV_MAX to 128. .

Unclear why phabricator does the remove of reviewers when I try to add group bhyve, restore grehan caused by that in last change.

Jun 9 2018, 12:06 PM
rgrimes added a reviewer for D9033: Raise BLOCKIF_IOV_MAX to 128. : grehan.
Jun 9 2018, 12:05 PM
rgrimes edited reviewers for D9033: Raise BLOCKIF_IOV_MAX to 128. , added: bhyve; removed: grehan, rgrimes.
Jun 9 2018, 12:04 PM

May 30 2018

rgrimes added a reviewer for D15628: Fix build of `stand/` with base gcc: bhyve.
May 30 2018, 9:44 PM
rgrimes added a comment to D15629: Pass a struct devdesc to the format commands. Use proper type rather than doing weird type-punning that happened to work because the size was right :(.

Copy over subscribers from D15628 and describe this review as a fix for an issue found during that review.

May 30 2018, 9:43 PM
rgrimes updated the summary of D15629: Pass a struct devdesc to the format commands. Use proper type rather than doing weird type-punning that happened to work because the size was right :(.
May 30 2018, 9:42 PM

May 28 2018

rgrimes added inline comments to D15595: Update pmclog(3) and cap_rights_get(3) EXAMPLE section..
May 28 2018, 2:30 PM
rgrimes added inline comments to D15595: Update pmclog(3) and cap_rights_get(3) EXAMPLE section..
May 28 2018, 2:06 PM

May 26 2018

rgrimes accepted D15481: Create a default wlan for wireless NICs if no wlans are specified..

Isnt there some documentation some place that also needs to be updated?

May 26 2018, 12:05 AM

May 24 2018

rgrimes added a comment to D15550: Fix a memory leak on topology_parse()..

Please mark the commit as MFC-X with https://svnweb.freebsd.org/changeset/base/332298

May 24 2018, 1:19 PM
rgrimes accepted D15550: Fix a memory leak on topology_parse()..
May 24 2018, 1:15 PM

May 23 2018

rgrimes accepted D15488: If reading the routing table fails, retry up to 10 times.

I am ok with this for now, but I think the values 100000uS and 2x are going to need some "experience" tuning.

May 23 2018, 7:38 AM

May 22 2018

rgrimes accepted D15459: Use __SCCSID for SCCS IDs in libkvm sources..
May 22 2018, 1:12 AM

May 19 2018

rgrimes added inline comments to D15488: If reading the routing table fails, retry up to 10 times.
May 19 2018, 4:53 PM
rgrimes added a comment to D15488: If reading the routing table fails, retry up to 10 times.

I see this problem often on BPG routers. I usually use the birdc as a better and more reliabe interface to the routing information, though on occasion you do have to sanity check with what the kernel has.
Also birdc seems to be able to give me a routing table 10x faster than netstat -rn and without this issue.

May 19 2018, 4:38 PM
rgrimes added reviewers for D15488: If reading the routing table fails, retry up to 10 times: network, rgrimes.
May 19 2018, 4:15 PM

May 18 2018

rgrimes accepted D15189: Cleanups related to debug exceptions on x86..
May 18 2018, 3:28 AM

May 17 2018

rgrimes accepted D15465: Enable kernel dump options on most architectures..

Thanks

May 17 2018, 9:54 PM
rgrimes added a comment to D15465: Enable kernel dump options on most architectures..

Can we not split KDB and DDB with NETDUMP?
Ie, put it after the options MALLOC_DEBUG_MAXZONES=8 # Separate malloc(9) zones
would keep all the KDB, GDB, DDB, etc in one lump, followed by dumping stuff, perhaps with one line of white space

Wouldn't that make it look like the "turn off in stable branch" comment applies to the new options? Or am I misunderstanding your suggestion?

May 17 2018, 8:41 PM
rgrimes added a comment to D15465: Enable kernel dump options on most architectures..

Can we not split KDB and DDB with NETDUMP?
Ie, put it after the options MALLOC_DEBUG_MAXZONES=8 # Separate malloc(9) zones
would keep all the KDB, GDB, DDB, etc in one lump, followed by dumping stuff, perhaps with one line of white space

May 17 2018, 8:33 PM
rgrimes added a comment to D15421: bhyve: fix usage formatting.

Thanks for catch Roman, I have prepared a commit and sent it to my mentors for approval, with a fast track 3 day MFC as this made it into stable/11.

Wait! Do you just committed a patch sent by another developer?

@novel have you approved that?

Best

May 17 2018, 1:42 PM
rgrimes committed rS333712: Add missing newline to end of -c usage string ..
Add missing newline to end of -c usage string .
May 17 2018, 12:19 PM
rgrimes closed D15421: bhyve: fix usage formatting.
May 17 2018, 12:18 PM
rgrimes accepted D15459: Use __SCCSID for SCCS IDs in libkvm sources..
In D15459#326241, @jhb wrote:

Yeah, I actually meant to post a comment asking about the blank line. I would be fine with collapsing it now that the ID isn't surrounded by N layers of #ifdef.

May 17 2018, 1:40 AM

May 15 2018

rgrimes added inline comments to D15358: Address memory leak in new reno cc module.
May 15 2018, 7:28 AM

May 14 2018

rgrimes accepted D15421: bhyve: fix usage formatting.

Thanks for catch Roman, I have prepared a commit and sent it to my mentors for approval, with a fast track 3 day MFC as this made it into stable/11.

May 14 2018, 1:22 PM

May 11 2018

rgrimes added inline comments to D15388: assert(3) vq_getchain() on pci_vtcon_notify_tx() spotted by gcc..
May 11 2018, 2:26 PM
rgrimes added inline comments to D15388: assert(3) vq_getchain() on pci_vtcon_notify_tx() spotted by gcc..
May 11 2018, 1:56 PM

May 9 2018

rgrimes added a comment to D11725: Add optional TCP logging on sonewconn failures..

I have changed the transport reviewer to non-blocking, and added glebius as a reviewer since he seems to have some stake in this. Hopefully this can help it move forward.

May 9 2018, 2:26 AM
rgrimes added a reviewer for D11725: Add optional TCP logging on sonewconn failures.: glebius. rgrimes removed 1 blocking reviewer(s) for D11725: Add optional TCP logging on sonewconn failures.: transport.
May 9 2018, 2:24 AM

May 8 2018

rgrimes added a reviewer for D15356: in-kernel virtio and VPC (virtual private cloud) stack: bhyve.
May 8 2018, 7:32 PM
rgrimes added a reviewer for D15348: add supporting interfaces for in-kernel virtio backend: bhyve.
May 8 2018, 10:45 AM

May 4 2018

rgrimes added inline comments to D15276: Add virtio-scsi block storage backend support.
May 4 2018, 2:17 PM
rgrimes added inline comments to D15290: recursive mutex in pci_xhci leads to deadlock.
May 4 2018, 2:04 PM

May 3 2018

rgrimes added a reviewer for D15276: Add virtio-scsi block storage backend support: jhb.
May 3 2018, 1:17 PM

May 2 2018

rgrimes accepted D15269: Allow PCI VGA devices to be detached..
May 2 2018, 6:15 PM
rgrimes added a comment to D15269: Allow PCI VGA devices to be detached..

How do you trigger a call to this DEVMETHOD?

May 2 2018, 5:31 PM
rgrimes accepted D15268: Use PCI power-mgmt to reset a device if FLR fails..

Is this the workaround developed with macy?

May 2 2018, 5:14 PM

May 1 2018

rgrimes accepted D15245: Retire lmc(4).
May 1 2018, 1:44 AM

Apr 25 2018

rgrimes added a comment to D15189: Cleanups related to debug exceptions on x86..

It is a bit confusing to still have it be T_TRCTRAP, but all the comments now say debug exception...

Apr 25 2018, 3:39 AM
rgrimes added a reviewer for D15189: Cleanups related to debug exceptions on x86.: bhyve.
Apr 25 2018, 3:33 AM