Page MenuHomeFreeBSD

rgrimes
User

Projects

User Details

User Since
Dec 19 2016, 4:11 AM (195 w, 4 d)

Recent Activity

Tue, Aug 25

rgrimes added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Tue, Aug 25, 7:54 PM

Sat, Aug 22

rgrimes added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Sat, Aug 22, 4:02 PM

Aug 19 2020

rgrimes added a comment to D25993: bpf(4): Update the manual page to reflect reality.

The summary of this review is lacking detail

Aug 19 2020, 4:40 PM

Aug 17 2020

rgrimes added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 17 2020, 2:54 AM

Aug 16 2020

rgrimes added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 16 2020, 4:18 PM

Aug 15 2020

rgrimes added inline comments to D26074: NetFPGA SUME Reference NIC (RIFFA DMA) device driver.
Aug 15 2020, 2:50 PM

Aug 14 2020

rgrimes committed rS364236: Release rscheff from mentorship..
Release rscheff from mentorship.
Aug 14 2020, 4:44 PM

Aug 13 2020

rgrimes updated the test plan for D6656: net/tso: use the most restrictive segment size to perform the calculations.
Aug 13 2020, 11:06 PM
rgrimes updated the test plan for D6612: net: allow fast-forwarding TSO packets.
Aug 13 2020, 11:05 PM
rgrimes updated the test plan for D6611: net: translate inbound checksum offloading flags to outbound when forwarding.
Aug 13 2020, 11:04 PM
rgrimes added inline comments to D6612: net: allow fast-forwarding TSO packets.
Aug 13 2020, 6:59 PM
rgrimes added a reviewer for D6612: net: allow fast-forwarding TSO packets: gallatin.
Aug 13 2020, 2:38 PM
rgrimes added a reviewer for D6611: net: translate inbound checksum offloading flags to outbound when forwarding: gallatin.
Aug 13 2020, 2:32 PM
rgrimes added a comment to D6611: net: translate inbound checksum offloading flags to outbound when forwarding.

Is there any concern or additional work needed for ipV6?

Aug 13 2020, 2:32 PM
rgrimes added a reviewer for D6656: net/tso: use the most restrictive segment size to perform the calculations: gallatin.
Aug 13 2020, 2:29 PM
rgrimes accepted D18624: improvements to support code for RFC6675.
Aug 13 2020, 2:05 PM

Aug 12 2020

rgrimes added a comment to D26035: Refactor configuration management in bhyve..

To all those harping about it not being foo or bar or zed, this *is* an underlying frame work that is very flexible and allows one to implement what ever foo, bar or zed configuration you want on top of it. This leaves json, xml, or any other implementation out of the base layer code and those can be implemented in a layer above this. This has been discussed for a some time extensively by those that attend the semi-monthly bhyve call.

Aug 12 2020, 5:23 PM

Aug 7 2020

rgrimes accepted D25746: Address unintended jump of calculated cwnd when leaving slowstart.
Aug 7 2020, 3:33 PM

Aug 6 2020

rgrimes accepted D25976: TCP Cubic: Have Fast Convergence Heuristic work for ECN, and align concave region.

Approving as mentor only.

Aug 6 2020, 7:46 PM

Aug 1 2020

rgrimes added a comment to D25876: bhyve: Passthrough host's NVMe device health logpage to guests..

...
Your observation that the data units values restart at zero is very valid. My tentative plan for this is to optionally save the current values when the VM is powered down using the new configuration file format. This saved device state could then be used on a subsequent restart to provide the continuity you describe.

Aug 1 2020, 5:21 PM

Jul 31 2020

rgrimes accepted D24952: ipfirewall.4: restructure new line starts and remove .Tn.

Reflowing sentences and removal of .Tn seems like busy work to me. Much easier to just make mandoc ignore .Tn and igor silent on its usage. These macros DO make the groff man pages output look different, and IMHO, nicer.

Jul 31 2020, 4:11 PM
rgrimes added inline comments to D25793: 10Gigabit Ethernet driver for AMD SoC.
Jul 31 2020, 2:52 PM

Jul 30 2020

rgrimes accepted D10335: VirtFS/9p filesystem passthrough support (virtio-9p).

I still see request changes markers from emaste and jhb/bhyve, what are these changes?

Jul 30 2020, 4:04 PM

Jul 28 2020

rgrimes added a comment to D25833: Remove AES-CBC ciphers from default server and client lists..

Could we please get stances in /etc/sshd/ssh{,d}_config commented out that show how to enable these if they are needed?

For example,

Ciphers +aes128-cbc,aes192-cbc,aes256-cbc

I'd rather not deviate from upstream, but if we must I'd rather do so in sshd_config, not in the source.

Jul 28 2020, 1:20 AM

Jul 27 2020

rgrimes accepted D25833: Remove AES-CBC ciphers from default server and client lists..
Jul 27 2020, 5:32 PM
rgrimes added a comment to D25833: Remove AES-CBC ciphers from default server and client lists..

Could we please get stances in /etc/sshd/ssh{,d}_config commented out that show how to enable these if they are needed?

Jul 27 2020, 5:32 PM
rgrimes added a comment to D25793: 10Gigabit Ethernet driver for AMD SoC.

Can we add an appropriate SPDX tag to the source files as well - e.g. /* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */ or similar?

Need a clarification here please. The license text in the source files has additional text (part of it give below) apart from the normal BSD-3-Clause text. If this is not an issue, we can use /* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */. Please clarify.

Jul 27 2020, 5:10 PM

Jul 24 2020

rgrimes added a comment to D25566: apropos(1) and makewhatis(8): Update HISTORY sections.

I have no objection to it, but it is still not totally factual, more than likely it was "intergrated" into FreeBSD Current/Head when it was at 12 and merged back to stable/11 and first appeared in a FreeBSD release at 11.1. I still do not see any added value to the history of mandoc by this change, and it just makes FreeBSD have a local diff to the mandoc from witch it was derived. Speaking of which, shouldn't this be on a vendor branch?

Jul 24 2020, 10:47 PM

Jul 21 2020

rgrimes accepted D24657: update cwnd in both convex and concave regions like comment stated..
Jul 21 2020, 3:19 PM

Jul 20 2020

rgrimes accepted D25744: Add MODULE_VERSION to TCP loadable congestion control modules..
Jul 20 2020, 11:04 PM
rgrimes accepted D25746: Address unintended jump of calculated cwnd when leaving slowstart.
Jul 20 2020, 10:51 PM

Jul 16 2020

rgrimes accepted D10335: VirtFS/9p filesystem passthrough support (virtio-9p).
Jul 16 2020, 4:49 PM
rgrimes added a reviewer for D25334: Add lib9p to the build, squashed and rebased off master 20200617: rgrimes.
Jul 16 2020, 4:46 PM

Jul 15 2020

rgrimes added inline comments to D25312: Relax the rule against declaring variables in nested scopes..
Jul 15 2020, 4:53 PM
rgrimes added inline comments to D25312: Relax the rule against declaring variables in nested scopes..
Jul 15 2020, 4:45 PM
rgrimes added inline comments to D25312: Relax the rule against declaring variables in nested scopes..
Jul 15 2020, 4:38 PM

Jul 10 2020

rgrimes added inline comments to D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.
Jul 10 2020, 4:16 PM · network
rgrimes added a comment to D25607: libalias: Use switch/case statements to compare IPv4 protocol type (TCP/UDP/ICMP).

I see a fair amount of white space/formatting only changes in this, it MAY make since to break those out as 0 effort review.
I also have concerns over any performance claims, though I see the old code is probably at least sub optimal in that it often checks for UDP, then for TCP when the volume of traffic should almost always be mostly TCP. Also modern compilers should just "handle this" without rewritting code unless something odd is being done. If you really want to micro optimize I suspect rewriting this as "branchless" code that results in cmovl or other instructions might be interesting. I have heard of 40x code speed improvements using such tenchiques, but that is mostly in tight loops.

Jul 10 2020, 3:47 PM · network

Jul 9 2020

rgrimes requested changes to D10335: VirtFS/9p filesystem passthrough support (virtio-9p).

I was asked to look at this and see if I could help get the Makefile issues moved forward. I have commented inline.

Jul 9 2020, 9:25 PM
rgrimes requested changes to D25601: rc.d/kld: Set sysctls after loading modules..
In D25601#566423, @imp wrote:
In D25601#566409, @imp wrote:

I don't think this is a good idea....

Setting sysctl values multiple times may be unwise.o

I concur on this point. Not all sysctl are idempotent.

Jul 9 2020, 6:07 PM
rgrimes requested changes to D25595: When modifying a route, only allow one of RTF_<BLACKHOLE,REJECT,GATEWAY> to be configured.
Jul 9 2020, 4:39 PM · network

Jul 7 2020

rgrimes accepted D25583: Fix KASSERT during tcp_newtcpcb when low on memory.
Jul 7 2020, 10:50 AM

Jul 6 2020

rgrimes accepted D25567: PR247718 - incorrectly drops IPv6 packets looping back on p2p interface.

This is a good fix, it is wrong for the kernel to try and guess that something is wrong here. "Highly Probably != For Certain" and having this kind of stuff get in the way when your trying to make something work is very annoying for the end user. Now if we could just get the hard coded interface loopback route creating/removal out of the kernel.

Jul 6 2020, 3:44 PM

Jul 5 2020

rgrimes added a comment to D25566: apropos(1) and makewhatis(8): Update HISTORY sections.

I do not believe we normally document this type of information in the HISTORY section of manual pages. The history sections of these man pages are already rich with information, especially when you add the history included in the Authors section.

Jul 5 2020, 8:32 AM

Jul 4 2020

rgrimes added a reviewer for D23461: netgraph: Add RFC 6598/Carrier Grade NAT support to ng_nat: rgrimes.
Jul 4 2020, 4:09 PM · network
rgrimes added a reviewer for D23356: natd: Add support for RFC 6598/Carrier Grade NAT subnets via libalias: rgrimes.
Jul 4 2020, 4:06 PM · network
rgrimes added a comment to D23356: natd: Add support for RFC 6598/Carrier Grade NAT subnets via libalias.

Is it possible to do cgn without rfc1918? I think the changes should allow for that configuration.

Jul 4 2020, 4:06 PM · network

Jul 2 2020

rgrimes added a comment to D25312: Relax the rule against declaring variables in nested scopes..

Though much better than the prior iteration I believe it leaves some detail out.

Jul 2 2020, 6:54 PM

Jun 24 2020

rgrimes accepted D25133: Fix cubic RTO reaction.
Jun 24 2020, 12:06 PM

Jun 23 2020

rgrimes accepted D18624: improvements to support code for RFC6675.

This has been in process for 15 months and should be evolving in tree rather than in a review at this point, IMHO. If no one objects to it being committed in 7 days I am asking that Richard go ahead and commit it.

Jun 23 2020, 2:12 PM
rgrimes accepted D24657: update cwnd in both convex and concave regions like comment stated..
Jun 23 2020, 2:05 PM
rgrimes accepted D24657: update cwnd in both convex and concave regions like comment stated..

So, is FreeBSD getting close to a proper Cubic yet?

Jun 23 2020, 5:03 AM

Jun 22 2020

rgrimes added a comment to D25401: (Re)allow 0.0.0.0 to be used as a destination address in connect() for TCP.

The in_pcb_setup code is that called independent of L4? Ie for all sockets? Or have i lost my way in the twisty maze of IP layers?

TCP calls it: tcp_usrreq.c:1566. The logic is independent from L4. They are also rewriting INADDR_BROADCAST, which doesn't make sense for TCP, but we are catching this now...

Jun 22 2020, 6:20 PM
rgrimes accepted D25401: (Re)allow 0.0.0.0 to be used as a destination address in connect() for TCP.

Should this

  • If the destination address is INADDR_ANY,
  • use the primary local address.

It took me a few "brain loops" to realize you mean the "local loopback interface address" or is there actually some concept of a "primary local IP address."?

Jun 22 2020, 6:01 PM
rgrimes added a reviewer for D25399: bhyve NVMe controller will accept model/rev config.: chuck.
Jun 22 2020, 10:49 AM
rgrimes added a reviewer for D25396: bhyve nvme controller will pass unknown config if using blockif backend: chuck.
Jun 22 2020, 10:33 AM

Jun 19 2020

rgrimes accepted D25354: net/nbdkit: new port.

Thank you

Jun 19 2020, 4:29 PM
rgrimes added a comment to D25312: Relax the rule against declaring variables in nested scopes..
In D25312#559159, @imp wrote:

Summary so far:

  1. there's overwhelming support for this, at least in theory
  2. the devil is in the details.

... Much sound analysis removed ...

Jun 19 2020, 4:24 PM

Jun 18 2020

rgrimes accepted D18624: improvements to support code for RFC6675.
Jun 18 2020, 5:46 PM
rgrimes accepted D25016: Make After-Idle congestion control work correctly for transactional sessions..
Jun 18 2020, 5:27 PM
rgrimes added a comment to D25312: Relax the rule against declaring variables in nested scopes..

I find this change debatable, and as presented here incomplete as I believe this has effects on some other parts of style(9), nor does it provide a proper sample (it leaves the example unchanged) Lets not RUSH to slam this in the tree!

Jun 18 2020, 9:18 AM

Jun 10 2020

rgrimes accepted D25065: Start cubic epoch after having been app-limited..
Jun 10 2020, 12:47 AM

Jun 9 2020

rgrimes accepted D25065: Start cubic epoch after having been app-limited..
Jun 9 2020, 6:08 PM

Jun 5 2020

rgrimes added a comment to D24869: Transition DCTCP to use ECT1 marks for elegible segments.

If you have clients that need to do this type of thing I would recommend they are running behind DSCP and they should use 2 DSCP's to seperate there DCTCP like traffic from there TCP/reno like traffic. Using ECT(1) as a traffic classifier in advance of IETF clear decision may land them in a very hard to resolve possition in the future.

Jun 5 2020, 12:53 AM

Jun 4 2020

rgrimes accepted D25066: Add O_DIRECT flag to DD for cache bypass.
Jun 4 2020, 5:38 PM
rgrimes accepted D25065: Start cubic epoch after having been app-limited..
Jun 4 2020, 5:38 PM

May 22 2020

rgrimes added a comment to D24952: ipfirewall.4: restructure new line starts and remove .Tn.

No, the point was to reduce the amount of change

May 22 2020, 4:07 PM
rgrimes added inline comments to D24952: ipfirewall.4: restructure new line starts and remove .Tn.
May 22 2020, 3:41 PM
rgrimes requested changes to D24952: ipfirewall.4: restructure new line starts and remove .Tn.

Just a couple nits, and I can be ignore on my line breaking issues.

May 22 2020, 2:06 PM
rgrimes committed rS361355: Include all currently present kernel options for IPFW.
Include all currently present kernel options for IPFW
May 22 2020, 3:13 AM
rgrimes closed D24541: Update ipfw(4) manpage with all kernel options.
May 22 2020, 3:13 AM

May 21 2020

rgrimes added a comment to D24541: Update ipfw(4) manpage with all kernel options.

I'll commit this today

May 21 2020, 2:27 PM
rgrimes accepted D23373: Handle ECN handshake in simultaneous open.

Approving as mentor, only a visual code read was done.

May 21 2020, 2:07 PM

May 20 2020

rgrimes accepted D24596: vfs: add restrictions to read(2) of a directory.

Works for me

May 20 2020, 5:50 PM
rgrimes added a comment to D24596: vfs: add restrictions to read(2) of a directory.
In D24596#547800, @pi wrote:

These types of greps on a linux system return an error message for every directory in the directory you ran the grep in

So if we modify grep to not try to read directories and not spew errors, would that be a solution ?

It wouldn't even take much modification, just changing the default to be -d skip.

Or is there some POSIX or similar rule that requires those errors 8-} ?

POSIX allows implementations to do what they want with read() on a directory and grep's behaviour follows from that, so I think it's within the spirit for us to show errors or not, as we see fit.

May 20 2020, 4:12 PM

May 18 2020

rgrimes added a comment to D24596: vfs: add restrictions to read(2) of a directory.

Now that I have had time to go play with this on a "Linux" system, I am afraid I object to this change. Your doing it because you don't like the occasional splat of "foo is a binary file" when you run a grep *, you should see the results when EISDIR is returned. These types of greps on a linux system return an error message for every directory in the directory you ran the grep in, far more noise than your small issue, and for many of us this is gona be a PITA/POLA change. I hadnt thought much about it cause I alias 'grep' 'grep -d skip' and do not see your issue or my issue normally on linux.

I think to rectifier your issue you should probably do the same I have done...

I'm afraid I have no idea what you're talking about here...grep isn't my problem, my problems are:

  1. The security implications of being able to read(2) a dirfd,
  2. Consistency with how most modern kernels behave,

2a) the amount of time I waste hunting down application bugs because of that

There was probably a 3, but it's late and a bit worn down from recent discussions.

May 18 2020, 4:51 AM
rgrimes added a comment to D24596: vfs: add restrictions to read(2) of a directory.
In D24596#547205, @imp wrote:

Probably grep(1) should be updated after this change. It has -d option to specify which action to to take on processing directories. From manpage:

-d ACTION, --directories=ACTION
       If an input file is a directory, use ACTION to process it.  By
       default, ACTION is read, which means that directories are read
       just as if they were ordinary files.  If ACTION is skip,
       directories are silently skipped.  If ACTION is recurse, grep
       reads all files under each directory, recursively; this is
       equivalent to the -r option.

grep doesn't actually read directories for anything useful (and can't for ZFS), so this change is a nop as far as GREP is concerned.

May 18 2020, 4:50 AM
rgrimes added a comment to D24596: vfs: add restrictions to read(2) of a directory.

Now that I have had time to go play with this on a "Linux" system, I am afraid I object to this change. Your doing it because you don't like the occasional splat of "foo is a binary file" when you run a grep *, you should see the results when EISDIR is returned. These types of greps on a linux system return an error message for every directory in the directory you ran the grep in, far more noise than your small issue, and for many of us this is gona be a PITA/POLA change. I hadnt thought much about it cause I alias 'grep' 'grep -d skip' and do not see your issue or my issue normally on linux.

May 18 2020, 3:52 AM

May 15 2020

rgrimes requested changes to D24596: vfs: add restrictions to read(2) of a directory.

I do not like the undocumented (per summary anyway) KASSERT added for writes.

May 15 2020, 7:41 PM

May 13 2020

rgrimes added a comment to D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..

In this patch, "me4" is IPv4-only and "me" is dual-stack. It uses kernel opcodes, however.

May 13 2020, 1:14 AM · network

May 8 2020

rgrimes accepted D24727: x86_emulate_cpuid() should clear upper 32 bits.
May 8 2020, 10:16 AM · bhyve

May 7 2020

rgrimes added a comment to D24541: Update ipfw(4) manpage with all kernel options.

I know there well be flak over using .Tn in a man page fix, can you submit a new diff without the .Tn's?

May 7 2020, 4:11 PM

May 6 2020

rgrimes accepted D24727: x86_emulate_cpuid() should clear upper 32 bits.

I just fixed a couple typos in the summary, looks ok.

May 6 2020, 4:12 AM · bhyve
rgrimes updated the summary of D24727: x86_emulate_cpuid() should clear upper 32 bits.
May 6 2020, 4:07 AM · bhyve

May 5 2020

rgrimes added a comment to D24427: ipfw: use SLIST_REMOVE_HEAD and SLIST_REMOVE_AFTER for the first and subsequent respective states.

Can we get some more eyes on this please?

May 5 2020, 4:15 AM · network
rgrimes added a reviewer for D24427: ipfw: use SLIST_REMOVE_HEAD and SLIST_REMOVE_AFTER for the first and subsequent respective states: bz.
May 5 2020, 4:14 AM · network

May 3 2020

rgrimes accepted D24602: Remove erroneous spacing in SCTP_ABORT_ASSOCIATION case statement comment in send_reject6().
May 3 2020, 2:19 AM

May 2 2020

rgrimes added inline comments to D24602: Remove erroneous spacing in SCTP_ABORT_ASSOCIATION case statement comment in send_reject6().
May 2 2020, 5:44 AM

Apr 29 2020

rgrimes added a reviewer for D21011: Functional implementation of Accurate ECN in FreeBSD: rgrimes.
Apr 29 2020, 2:54 PM
rgrimes accepted D19000: Avoid cwnd update for SYN sequence space.
Apr 29 2020, 9:12 AM

Apr 28 2020

rgrimes accepted D19000: Avoid cwnd update for SYN sequence space.

Thank you for the comment, that helps me, small english nit

Apr 28 2020, 1:43 PM
rgrimes accepted D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command.

That reads much better, cleaned it up a fair bit more than I thought it would.

Apr 28 2020, 4:23 AM · transport, network
rgrimes added inline comments to D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command.
Apr 28 2020, 2:11 AM · transport, network
rgrimes added a comment to D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command.

Adding bz, as it is his XXX-BZ comment being removed about implementing this.

Apr 28 2020, 2:01 AM · transport, network
rgrimes added a reviewer for D24011: ipfw: Support [w:x:y::z]:port (bracketed) IPv6 addresses in the fwd command: bz.
Apr 28 2020, 2:00 AM · transport, network
rgrimes accepted D19000: Avoid cwnd update for SYN sequence space.

Request for a comment, non blocking.

Apr 28 2020, 1:57 AM
rgrimes accepted D24515: Prevent premature zeroing of a scaled receiver window.
Apr 28 2020, 1:52 AM

Apr 23 2020

rgrimes accepted D24541: Update ipfw(4) manpage with all kernel options.

Thank you, nice additions beyond what I stumbled on in the PR

Apr 23 2020, 12:25 AM

Apr 22 2020

rgrimes accepted D24526: Improve formatting of synopsis section.

If you only knew how long I fought with white space issue, Ar and Cm trying to get that to format correct for cpus=. Thank you!

Apr 22 2020, 2:12 AM

Apr 20 2020

rgrimes accepted D19000: Avoid cwnd update for SYN sequence space.
Apr 20 2020, 4:14 AM