- User Since
- Dec 19 2016, 4:11 AM (74 w, 3 d)
Please mark the commit as MFC-X with https://svnweb.freebsd.org/changeset/base/332298
Wed, May 23
I am ok with this for now, but I think the values 100000uS and 2x are going to need some "experience" tuning.
Tue, May 22
Sat, May 19
I see this problem often on BPG routers. I usually use the birdc as a better and more reliabe interface to the routing information, though on occasion you do have to sanity check with what the kernel has.
Also birdc seems to be able to give me a routing table 10x faster than netstat -rn and without this issue.
Fri, May 18
Thu, May 17
Can we not split KDB and DDB with NETDUMP?
Ie, put it after the options MALLOC_DEBUG_MAXZONES=8 # Separate malloc(9) zones
would keep all the KDB, GDB, DDB, etc in one lump, followed by dumping stuff, perhaps with one line of white space
Tue, May 15
Mon, May 14
Thanks for catch Roman, I have prepared a commit and sent it to my mentors for approval, with a fast track 3 day MFC as this made it into stable/11.
Fri, May 11
Wed, May 9
I have changed the transport reviewer to non-blocking, and added glebius as a reviewer since he seems to have some stake in this. Hopefully this can help it move forward.
Tue, May 8
Fri, May 4
Thu, May 3
Wed, May 2
How do you trigger a call to this DEVMETHOD?
Is this the workaround developed with macy?
Tue, May 1
Wed, Apr 25
It is a bit confusing to still have it be T_TRCTRAP, but all the comments now say debug exception...
Apr 24 2018
Apr 21 2018
Apr 19 2018
Apr 13 2018
Apr 8 2018
Apr 7 2018
Apr 6 2018
Could it be this works on i386 only?
Clean up the topology_parse() routing to catch more errors, and to properly match the documented syntax, update the bhyve.8 manual page to reflect the actual syntax implemented.
What are the plans/methods to be used for stable/11 informing consumers that this feature is being deprecated?
Apr 5 2018
Mar 31 2018
Mar 29 2018
Make cpu topology sysctl's conditional on FreeBSD_version so that this patch can be merged to stable/11 and make these sysctl obsolete in >120057
The issue causing the cpu topology to come out wrong on Intel cpus has been found, it is a misplaced call to vm_get_topology that is only executed for the cpuid 0xb, ecx=0 case, causing the ecx=1 case to use uninitialized values.
Mar 28 2018
Mar 23 2018
Mar 20 2018
Mar 19 2018
Mar 14 2018
Mar 13 2018
Mar 12 2018
Let me try again about the net.inet.ip.fw.one_pass. This patch leaves that value alone, that value is 1 by default. The added rules shall reassemble all UDP packets, and since one_pass is set it well at that point PASS THE PACKET. This is a huge hole in the firewall in effect allowing all UDP traffic to pass inward without any port or state being checked. With the added rule that reassembles udp packets it is a MUST that net.inet.ip.fw.one_pass be set to 0 so that the additional checks later in the firewall can be checked. It is also a must that the rule be moved before the check-state.
Mar 11 2018
I agree that the rule order is wrong here, reass should be done before a check state,
in general you want reass to occur very early, so that other rules are checking the
reassembled packet. reass should occur before any rules that list ports.
Mar 10 2018
Update bhyve -h usage output to include new cpu topology options.
Pointed out by Roman Bogorodskiy (novel@).
Translate reviewer rgrimes -> bhyve triggered by touching stand/userboot.
Mar 7 2018
Fix white space nit in usr.sbin/bhyve/bhyve.8
Remove extra comma in usr.sbin/bhyvectl/bhyvectl.c causing build failure
Update per Peter Grehan
Mar 6 2018
Mar 5 2018
Feb 28 2018
Since your all here from the add of bhyve can you look at herald rule H97 https://reviews.freebsd.org/H97 , look for anything I might of missed in the list of file directories.
I am trying to get that upgraded to a global rule with an add non-blocking reviewer bhyve, but that requires higher access than I have.
Feb 27 2018
If Peter accepts this and says I can go ahead with a commit I would do that, but I need his approval to commit it.
Feb 23 2018
I dont know why it did that, I tried to simply "accept revision" and it removed all other reviewers, so put them back.
Feb 22 2018
Feb 17 2018
Correct issues and add man page changes
Feb 16 2018
I missed that, overall I think this man page could use a rework in general form, gather all the syntax up in the SYNOPSIS, but if we keep pecking away at it at least the errors can be removed.
Feb 15 2018
I have all the other comments corrected in my copy, seeking clarification on error check value for vm_set_topology before I correct that. Plan to delay depreciation of old sysctl method to allow simpler merge to stable/11. That is going to require a direct commit to stable/11, and a different commit to ^head
Feb 12 2018
Feb 10 2018
This is missing the associated man page change that changes gateway to [gateway] on the change syntax,
Though perhaps BSD did allow this in the past, the man page never said that the gateway was optional as far as I can recall.
Feb 2 2018
Feb 1 2018
Jan 28 2018
I still find this as a gratuitous difference in FreeBSD that does not exist in NetBSD or OpenBSD, and appears to be BSD behavior back into the 80's, anyone that HAS already scripted to deal with symbolic names well be broken if this change is made.
Jan 25 2018
Only question I have before we remove this, is the tree void of code in this format?