Page MenuHomeFreeBSD

rgrimes
User

Projects

User Details

User Since
Dec 19 2016, 4:11 AM (134 w, 3 d)

Recent Activity

Thu, Jun 27

rgrimes added a comment to D20762: Add an initial RELNOTES file..

Reformat to 80 columns.

Thu, Jun 27, 5:16 PM

Wed, Jun 26

rgrimes committed rS349443: MFC: r347065 (by jhb) Emulate the "ADD reg, r/m" instruction (opcode 03H)..
MFC: r347065 (by jhb) Emulate the "ADD reg, r/m" instruction (opcode 03H).
Wed, Jun 26, 9:59 PM
rgrimes committed rS349441: Emulate the "TEST r/m{16,32,64}, imm{16,32,32}" instructions (opcode F7H)..
Emulate the "TEST r/m{16,32,64}, imm{16,32,32}" instructions (opcode F7H).
Wed, Jun 26, 9:20 PM
rgrimes closed D20755: Emulate the TEST instruction with opcode F7 /0..
Wed, Jun 26, 9:20 PM
rgrimes added a comment to D20755: Emulate the TEST instruction with opcode F7 /0..

Finally review please

Wed, Jun 26, 8:27 PM
rgrimes added reviewers for D20755: Emulate the TEST instruction with opcode F7 /0.: markj, pmooney_pfmooney.com.
Wed, Jun 26, 8:27 PM
rgrimes added a comment to D20755: Emulate the TEST instruction with opcode F7 /0..

Fix 7F to F7 in 4 places

Wed, Jun 26, 8:26 PM
rgrimes added inline comments to D20755: Emulate the TEST instruction with opcode F7 /0..
Wed, Jun 26, 8:23 PM
rgrimes added a reviewer for D20755: Emulate the TEST instruction with opcode F7 /0.: jhb.

I was kinda waiting for jhb@ on this, as it is his patch, but given the urgency I am commandering this, and I'll push a new patch up for review. I would like to ask markj and pmooney to final review that and accept it before I commit to ^/head and push for an immediate MFC, and merge to releng. I'll also need to merge r347065 which is 6 weeks past MFC date.

Wed, Jun 26, 8:03 PM
rgrimes added a comment to D20755: Emulate the TEST instruction with opcode F7 /0..

Ping, since 11.3RC3 is back on the table I would like to see this pushed through along with r347065 which should of already been pushed through as it is 3 weeks past original MFC.

Wed, Jun 26, 7:23 PM
rgrimes added a comment to D19495: bhyve - Snapshot Save and Restore.

I have applied the feedback @jhb gave, except for the #ifdef guards. Will work on it after rebasing with a newer master.

Wed, Jun 26, 11:11 AM · bhyve
rgrimes added a comment to D20755: Emulate the TEST instruction with opcode F7 /0..

I helped Jason Tubnor test this patch on 11.3RC2, we had to first merge r347065 to get this patch to apply, and then had to make the 0x7F to 0xF7 Markj points out to get it to work. OpenBSD now runs as a guest in 11.3RC2

Wed, Jun 26, 3:43 AM

Tue, Jun 25

rgrimes added a comment to D20755: Emulate the TEST instruction with opcode F7 /0..

I am working with the original poster to get him a binary so he can test this fix.

Tue, Jun 25, 2:14 PM

Fri, Jun 21

rgrimes added a comment to D12419: HD Audio Emulation For Bhyve (Based on D7840).

Just tested with TruOS/Trident from a May 2019 kernel, and it's getting ECAPMODE. Maybe the problems with Capsicum aren't worked out yet. I'll look some more at it.

Fri, Jun 21, 7:55 PM

Thu, Jun 20

rgrimes added a comment to D7840: HD Audio Emulation For Bhyve.

This appears to be hung up on Capsicum additions

Thu, Jun 20, 5:07 PM
rgrimes resigned from D20389: bhyve vioapic writes can deadlock instance.
Thu, Jun 20, 4:52 PM · bhyve

Wed, Jun 19

rgrimes added a comment to D20673: Make RFB_ENCODING_ZLIB message handling idempotent..

In agreement on it probably needs cleaned up, but first finding out why it was done this way as a safe position to take.

Wed, Jun 19, 2:01 PM

Jun 13 2019

rgrimes added a comment to D20626: bhyve: move common code to net_utils.c.

I am pulling Kyle Evans in on this as he just did a bunch of cleanup on mac generation code and there may already be existing code to reused rather than have yet another mac generator.

...

One could theoretically take advantage of this to have a stable MAC across hosts for cases like, e.g., migration, no? Although it's not clear that bhyve folk would want to maintain this kind of promise, I could see it being somewhat handy.

For the purpose of migration you take the mac with you, that is part of the guest state.

Jun 13 2019, 5:42 PM
rgrimes added a comment to D20626: bhyve: move common code to net_utils.c.

I am pulling Kyle Evans in on this as he just did a bunch of cleanup on mac generation code and there may already be existing code to reused rather than have yet another mac generator.

Jun 13 2019, 4:54 AM
rgrimes added a reviewer for D20626: bhyve: move common code to net_utils.c: kevans.
Jun 13 2019, 4:53 AM
rgrimes accepted D20623: Deterministically initialize the PCI command register for passthru devices..

Good find.

Jun 13 2019, 4:41 AM

Jun 10 2019

rgrimes added a comment to D20581: bhyve: virtio: introduce vq_kick_enable() and vq_kick_disable().
In D20581#445096, @v.maffione_gmail.com wrote:

Moved include <machine/atomic.h> to virtio.h.

Jun 10 2019, 8:30 PM
rgrimes accepted D20365: simplify bhyve vlapic ESR logic.
Jun 10 2019, 2:28 PM · bhyve

Jun 8 2019

rgrimes resigned from D18880: Extend mmap/mprotect API to specify the max page protections..
Jun 8 2019, 1:42 AM

Jun 6 2019

rgrimes added a comment to D20529: bhyve: fix reporting of virtio scsi seg_max.

Please document why the -2 is needed per the earlier discussion. Does this need urgent attention to get in 11.3?

Jun 6 2019, 5:51 PM
rgrimes accepted D20531: Keep the shadow PCIR_COMMAND synced with the real one for pass through..

Looks like diff has gotten really confused by something making this very hard to see what it is that really changed since we are seeing function
pci_emul_cmdsts_write
compared to a new function
pci_emul_cmd_changed and are not actually seeing what changed in
pci_emul_cmdsts_write

Jun 6 2019, 1:08 AM
rgrimes accepted D20530: Enable memory and I/O decoding in PCI devices on demand..
Jun 6 2019, 12:59 AM

Jun 5 2019

rgrimes accepted D20525: Support MSI-X for passthrough devices with a separate PBA BAR..

Just questions really, no changes requested.

Jun 5 2019, 5:18 PM
rgrimes added a comment to D20520: Normalize deployment tools usage and definitions.
In D20520#443376, @imp wrote:

bootools is a terrible name, so bad I'm ticking 'request changes'.,

I agree here, but did not have a better name so opted to say nothing.

Jun 5 2019, 4:01 PM
rgrimes added reviewers for D20520: Normalize deployment tools usage and definitions: bdrewery, sjg.
Jun 5 2019, 9:10 AM
rgrimes added a comment to D20520: Normalize deployment tools usage and definitions.

I am not really keen on adding yet another top level .mk file that sets command names, much of this is caused by scatering etc/Makefile contents and rules about the tree when it was and should of been maintained as the one place for all of this and simply called as a submake. Perhaps it makes since anymore, perhaps not. But certainly having INSTALL and INSTALL_CMD default to and 99.999% of the time be "install" is not a good idea, same for MTREE and MTREE_CMD, they are being used in mixed manners, this needs to be sorted out asap and just use
MTREE_CMD and untwist some of this MTREE overload that should really overlaod MTREE_CMD.

Jun 5 2019, 9:09 AM

Jun 4 2019

rgrimes added a comment to D19001: Bhyve VT-d IOMMU: Support capability detection for multiple translation units.

This is a ping. The pr https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229852 has had another success report. This really should get in tree and in release, what is holding it up?

Jun 4 2019, 4:09 AM · bhyve

May 29 2019

rgrimes accepted D20448: style.9: Codify tolerance for eliding blank lines.
May 29 2019, 9:26 PM
rgrimes added a comment to D20448: style.9: Codify tolerance for eliding blank lines.

The very first version had:

f3()
{
					/* Empty line if no variables. */
	return (1);
}

Quote above As Ed beat me to the comment, I had be saying: Actually look closer at that 1.1 version, at line 119 it existed, and then in 1.3 was modified at line 159 became 194.
We can ask Kirk for clarity?

May 29 2019, 12:18 AM

May 28 2019

rgrimes accepted D20448: style.9: Codify tolerance for eliding blank lines.
May 28 2019, 6:04 PM
rgrimes added a comment to D20448: style.9: Codify tolerance for eliding blank lines.

I would even be fine with "If the function has no local variables", I do not think the length should come into play at all. Can someone explain why we have this special case at all? I know we want a blank line between variable declarations and the start of the function, is this just an attempt to preserve that empty line when there are no declarations?

May 28 2019, 6:04 PM

May 26 2019

rgrimes commandeered D16913: vmrun: add -x flag to disable reboot loop.
May 26 2019, 2:58 AM
rgrimes updated the summary of D16913: vmrun: add -x flag to disable reboot loop.
May 26 2019, 2:57 AM

May 25 2019

rgrimes committed rS348271: MFC: r346714: Add accessor function for vm->maxcpus.
MFC: r346714: Add accessor function for vm->maxcpus
May 25 2019, 11:28 AM
rgrimes committed rS348270: Correctly align usage: output.
Correctly align usage: output
May 25 2019, 11:23 AM
rgrimes committed rS348269: MFC: r346717: Make bhyve SMBIOS table topology aware.
MFC: r346717: Make bhyve SMBIOS table topology aware
May 25 2019, 10:17 AM

May 24 2019

rgrimes resigned from D19247: Merge hold_count into wire_count..

Getting way above my pay grade

May 24 2019, 11:33 PM
rgrimes retitled D16913: vmrun: add -x flag to disable reboot loop from vmrun: add -x flag to always exit when bhyve exists to vmrun: add -x flag to disable reboot loop.
May 24 2019, 3:33 PM
rgrimes added a comment to D16913: vmrun: add -x flag to disable reboot loop.

@allanjude I know your work load is huge as well, if you need me to push a new diff I can do that, but then you have to agree to commit it or I have to pester bde/phk for an approval.

May 24 2019, 3:30 PM
rgrimes added a comment to D10009: Fix a memory leak in bhyve.

Concur, but not sure how to force it closed.

May 24 2019, 3:23 PM
rgrimes resigned from D10009: Fix a memory leak in bhyve.
May 24 2019, 3:23 PM
rgrimes committed rS348226: MFC: r346717: Make bhyve SMBIOS table topology aware.
MFC: r346717: Make bhyve SMBIOS table topology aware
May 24 2019, 5:47 AM
rgrimes committed rS348223: MFC: r346714: Add accessor function for vm->maxcpus.
MFC: r346714: Add accessor function for vm->maxcpus
May 24 2019, 4:16 AM
rgrimes added a comment to D19506: Fix bug in bhyve by ignoring writes to errata MSRs in AMD cpus.

@jhb, reopening a commited phab review messes with things, as now when you make a second commit the default top patch in this review well be the one you commit, and one has to go digging in the review history to find the prior patch that was in the first commit. It is fine to reopen a review for a revert, but I think one should start a new review for a new change, which is what this is.

May 24 2019, 12:45 AM · bhyve

May 23 2019

rgrimes committed rS348201: MFC: r332298,333712,334199,334216,334219 bhyve cpu topology.
MFC: r332298,333712,334199,334216,334219 bhyve cpu topology
May 23 2019, 9:23 PM
rgrimes committed rS348188: MFC: r347960: bhyve virtio needs barriers.
MFC: r347960: bhyve virtio needs barriers
May 23 2019, 6:58 PM
rgrimes committed rS348186: MFC: r347960: bhyve virtio needs barriers.
MFC: r347960: bhyve virtio needs barriers
May 23 2019, 6:49 PM
rgrimes accepted D19904: bhyve: Add Integrated Endpoint to PCIe Capability.
May 23 2019, 4:46 PM
rgrimes accepted D19905: bhyve: Add EUI64 to NVMe device.
May 23 2019, 4:45 PM
rgrimes accepted D20365: simplify bhyve vlapic ESR logic.
May 23 2019, 12:48 AM · bhyve
rgrimes removed reviewers for D20365: simplify bhyve vlapic ESR logic: rgrimes, bhyve.
May 23 2019, 12:48 AM · bhyve
rgrimes resigned from D20365: simplify bhyve vlapic ESR logic.
May 23 2019, 12:47 AM · bhyve
rgrimes accepted D20365: simplify bhyve vlapic ESR logic.
May 23 2019, 12:46 AM · bhyve

May 22 2019

rgrimes added a comment to D20365: simplify bhyve vlapic ESR logic.

Minor nits, and a major win, good work!

May 22 2019, 9:18 PM · bhyve

May 21 2019

rgrimes added a comment to D20335: bhyve could be more precise with vPIT.

Any more little gold mines like this sitting around?

May 21 2019, 7:51 PM · bhyve

May 18 2019

rgrimes closed D19501: bhyve virtio needs barriers.
May 18 2019, 7:33 PM
rgrimes committed rS347960: bhyve virtio needs barriers.
bhyve virtio needs barriers
May 18 2019, 7:33 PM
rgrimes accepted D19501: bhyve virtio needs barriers.
May 18 2019, 5:10 AM
rgrimes added a comment to D19501: bhyve virtio needs barriers.

Ok to commit once blank lines are added per jhb in person

May 18 2019, 5:10 AM

May 15 2019

rgrimes accepted D16728: Move master.passwd and group to lib/libc/gen/.

I thought this had already been committed?

May 15 2019, 7:43 PM
rgrimes added a comment to D19501: bhyve virtio needs barriers.

I would like to see this in next weeks 11.3-PRERELEASE build, this looks to be a low risk barrier addition, @jhb does that seem to be a reasonable target, or would you like to see a longer ^head test cycle? Does anyone see any risk in this change?

May 15 2019, 1:46 PM

May 10 2019

rgrimes accepted D20117: Restructure mbuf send tags to provide stronger guarantees..
May 10 2019, 8:00 PM

May 9 2019

rgrimes updated the test plan for D19501: bhyve virtio needs barriers.
May 9 2019, 4:51 PM
rgrimes added a comment to D19501: bhyve virtio needs barriers.

This may be a fix for https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231117, the person is testing.

May 9 2019, 4:50 PM

May 7 2019

rgrimes accepted D19501: bhyve virtio needs barriers.

Thanks for the quick spin on this Patrick

May 7 2019, 10:22 PM
rgrimes added a comment to D19501: bhyve virtio needs barriers.

Ping

May 7 2019, 1:31 PM

May 4 2019

rgrimes committed rS347124: MFC: r346715: Acpi MADT table correction for VM_MAXCPU > 21.
MFC: r346715: Acpi MADT table correction for VM_MAXCPU > 21
May 4 2019, 1:43 PM

May 3 2019

rgrimes accepted D19001: Bhyve VT-d IOMMU: Support capability detection for multiple translation units.

@jhb it would be good to not have this issue in 11.3

May 3 2019, 8:44 AM · bhyve

May 2 2019

rgrimes added inline comments to D20117: Restructure mbuf send tags to provide stronger guarantees..
May 2 2019, 8:44 PM

May 1 2019

rgrimes added a comment to D20117: Restructure mbuf send tags to provide stronger guarantees..

You can mark all my comments as done, I am fine with your answers, I added bz and requested his review on the one change.

May 1 2019, 9:48 PM
rgrimes added a reviewer for D20117: Restructure mbuf send tags to provide stronger guarantees.: bz.
May 1 2019, 9:46 PM
rgrimes added a comment to D20065: Use system wiring in vmm(4)..
In D20065#433092, @kib wrote:
In D20065#432936, @jhb wrote:
In D20065#432917, @jhb wrote:

To be clear, the limit isn't being applied today? From the existing code it seems like it should be already in force if I'm reading the diff to vm_map_wire correctly?

The diff is being applied on top of D19908. Without that change, the limit does not get applied to bhyve.

Ok.

Also, if bhyve is allowed to ignore the limit, the amount of wired memory it uses does mean that small requests by, say, gpg will then fail on the host, yes?

Yes, that's right (and true in head today). In the original version of this diff, where bhyve was doing system wiring, that was not the case since system-wired pages are not counted towards the limit.

Ok. I still don't really know how I feel. I think I probably want all long-term wirings to honor the limit as kib@ says and that users will just have to up the limit when using wired VMs with bhyve. If we can get a suitably unique errno value back in whatever creates the wired memory for bhyve and emit a useful error message to the user, that is probably sufficient.

Ok. I guess we can just try and see if there's any fallout. I do think it means that D19908 is not MFCable.

If you add a knob to disable accounting for bhyve requests, it can be merged.

May 1 2019, 5:26 PM
rgrimes accepted D19908: Provide accounting of user-wired pages..

Do we have to add _user_ to the variables, I only see a rename here, and not a second value used in place of where _users_ went in, or am I totally missing something?

May 1 2019, 5:23 PM
rgrimes added a comment to D19908: Provide accounting of user-wired pages..

Do we have to add _user_ to the variables, I only see a rename here, and not a second value used in place of where _users_ went in, or am I totally missing something?

May 1 2019, 5:21 PM
rgrimes added a comment to D20117: Restructure mbuf send tags to provide stronger guarantees..

I have made one quick pass over this, now that I have read all the bits I would like to make a second pass, my comments now are nits mostly, and can be safely ignored. However I do, as others, have some pretty big concerns about sharing the rcvif with tags, is there some great cost in not doing that?

May 1 2019, 4:36 PM
rgrimes resigned from D20065: Use system wiring in vmm(4)..
May 1 2019, 12:37 AM
rgrimes added a comment to D20065: Use system wiring in vmm(4)..

Well this in any way help with the fact we do not apply any pressure to the zfs arc_max and end up in a memory shortfall that causes high paging? I suspect not as most people do not wire there VM's in memory unless they know that is what they need to do to keep zfs from killing your box with OOM

May 1 2019, 12:36 AM

Apr 27 2019

rgrimes added a comment to D20065: Use system wiring in vmm(4)..

I can see both sides of this, can I ask that the bhyve developers group which meets every 2 weeks be given a chance to discuss this and provide feedback on it? Thanks. Many of us well be at BSDCan a day early for bhyvecon if you wish to discuss it in person.

Why can't the discussion happen here?

Some of it is, but we meet on a cyclic basis to have high bandwidth low delay discussions and I was just asking for the opportunity to allow that discussion to occur. Or if you referring to the in person option that was offered up "if you wish".

Apr 27 2019, 6:40 AM

Apr 26 2019

rgrimes requested changes to D20065: Use system wiring in vmm(4)..

I can see both sides of this, can I ask that the bhyve developers group which meets every 2 weeks be given a chance to discuss this and provide feedback on it? Thanks. Many of us well be at BSDCan a day early for bhyvecon if you wish to discuss it in person.

Apr 26 2019, 3:48 PM
rgrimes added a comment to D19993: Don't symlink fusefs.ko to fuse.ko on PPC.

The symlink is a new addition for 13.0 (and hopefully 12.1). I would be ok with deleting it for 13.0. But how about I commit this change to head first, and then delete the symlink? That will make MFCs cleaner.

Apr 26 2019, 3:27 PM

Apr 25 2019

rgrimes committed rS346717: Make bhyve SMBIOS table topology aware.
Make bhyve SMBIOS table topology aware
Apr 25 2019, 10:54 PM
rgrimes closed D18998: Make bhyve SMBIOS table topology aware.
Apr 25 2019, 10:54 PM
rgrimes committed rS346715: Acpi MADT table correction for VM_MAXCPU > 21.
Acpi MADT table correction for VM_MAXCPU > 21
Apr 25 2019, 10:52 PM
rgrimes closed D18815: Bhyve acpi MADT table correction for VM_MAXCPU > 21.
Apr 25 2019, 10:52 PM
rgrimes committed rS346714: Add accessor function for vm->maxcpus.
Add accessor function for vm->maxcpus
Apr 25 2019, 10:51 PM
rgrimes closed D18755: Add accessor for vm->maxcpus in preperation for run time maxcpu setting.
Apr 25 2019, 10:51 PM
rgrimes committed rS346710: MFC: r345888: Use IN_foo() macros from sys/netinet/in.h inplace of.
MFC: r345888: Use IN_foo() macros from sys/netinet/in.h inplace of
Apr 25 2019, 9:28 PM
rgrimes added inline comments to D20044: tun/tap: merge.
Apr 25 2019, 5:22 PM
rgrimes accepted D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

This makes it much clearer to me, thanks jhb

Apr 25 2019, 5:03 PM · bhyve

Apr 20 2019

rgrimes added a comment to D19993: Don't symlink fusefs.ko to fuse.ko on PPC.

We only need to maintain "backwards" compatibility in the stable/ branches (12 and 11) as far as I am concerned head can just nuke the compatibilty link, and have a 13.0 release notes item that is "fuse has been renamed to fusefs".

Apr 20 2019, 10:28 PM
rgrimes requested changes to D19976: bhyve: Support a _VARS.fd file for bootrom.
Apr 20 2019, 12:45 AM
rgrimes accepted D19975: vmm: Add emulation for the `add` instruction.

A question to @jhb, should the order of the enum and the code updated to be in alphabetic order, in a seperate review, it would only obfuscate the change to do it here.

Apr 20 2019, 12:09 AM

Apr 15 2019

rgrimes accepted D19587: net: adjust randomized address bits.
Apr 15 2019, 10:46 PM

Apr 14 2019

rgrimes accepted D19905: bhyve: Add EUI64 to NVMe device.
Apr 14 2019, 6:30 PM
rgrimes accepted D19904: bhyve: Add Integrated Endpoint to PCIe Capability.

Looks good, other than a lot of extra blank lines.

Apr 14 2019, 6:26 PM