ofed/infiniband: fix ifdefs for new INET changes, fixing LINT-NOIP
ClosedPublic
Actions

Authored by • karels on Jul 16 2022, 9:14 PM.

Details

Reviewers

glebius
• hselasky
rgrimes
bz

Group Reviewers

network
transport

Commits

rGa11f080e8682: ofed/infiniband: fix ifdefs for new INET changes, fixing LINT-NOIP

Summary

Some of the ofed/infiniband code has INET and INET6 address handling
code without using ifdefs. This failed with a recent change to INET,
in which IN_LOOPBACK() started using a VNET variable, and which is not
present if INET is not configured. Add #ifdef INET, and INET6 for good
measure, in cma_loopback_addr(), along with inclusion of the options
headers in ib_cma.c.

Test Plan

verified that correct symbols are referenced with and without
INET.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karels created this revision.Jul 16 2022, 9:14 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 16 2022, 9:14 PM

• karels requested review of this revision.Jul 16 2022, 9:14 PM

Harbormaster completed remote builds in B46460: Diff 108236.Jul 16 2022, 9:14 PM

LGTM.

rgrimes added reviewers: • hselasky, network, transport.Jul 17 2022, 5:13 PM

Adding some more eyes to this, IIRC this is ofed code and actually maintained and imported from some place else. Though I agree with Glebius that this is the right way to fix it, it may need or be desired to do this upstream. Hselesky is the infiniband expert.

This revision is now accepted and ready to land.Jul 17 2022, 5:15 PM

bz accepted this revision as: bz.Jul 17 2022, 5:31 PM

bz added a subscriber: bz.

bz added inline comments.