Page MenuHomeFreeBSD

rpokala (Ravi Pokala)
User

Projects

User Details

User Since
Nov 20 2015, 9:23 AM (263 w, 2 h)

Recent Activity

Yesterday

rpokala accepted D26839: [axgbe] fix compiler warnings when compiling using gcc-6.4.

I don't have the hardware to test, but the change looks fine.

  1. The zero-initialization is obviously valid
  2. It's clear in context that XGBE_SET_ADV() (which sets the flag) is what was really intended, instead of testing the flag with XGBE_ADV() and throwing away the result.
Thu, Dec 3, 3:46 AM

Tue, Dec 1

rpokala added a comment to D27354: Address issue pointed out in CVE-2020-25705.
In D27354#612664, @cy wrote:

Correct. A constant rate limit allows the attackers to infer which source port the request is coming from reducing its randomness from 32 bits to the original 16 bits. (Same mistake WPA made with WPS.)

Tue, Dec 1, 2:00 AM

Mon, Nov 30

rpokala added a comment to D27354: Address issue pointed out in CVE-2020-25705.

Forgive my (carefully cultivated) ignorance of the network stack, but I'd like to understand this:

Mon, Nov 30, 7:41 AM

Sun, Nov 29

rpokala added a comment to D27373: Add VT driver for VBE framebuffer device.

Code change looks good to me; please update any manual pages.

Sun, Nov 29, 10:35 PM
rpokala added a comment to D27373: Add VT driver for VBE framebuffer device.

I guess it is better just to keep them all separate.

Sun, Nov 29, 10:32 PM

Wed, Nov 25

rpokala added a comment to D27373: Add VT driver for VBE framebuffer device.

To reduce confusion, we maybe should pick better name to replace "efi_fb". The VT internal state is filled from this structure.

Wed, Nov 25, 10:04 PM
rpokala added a comment to D27373: Add VT driver for VBE framebuffer device.

Implement vt_vbefb to support VBE framebuffer with VT

Wed, Nov 25, 7:39 PM

Mon, Nov 23

rpokala accepted D27333: Make cam_getccb(3) zero the whole ccb, not just the header.

LGTM, but I'm not authoritative when it comes to CAM.

Mon, Nov 23, 7:04 PM

Thu, Nov 19

rpokala added inline comments to D26928: Add atf-lua, a lua analog to atf-sh(1) and atf-sh(3).
Thu, Nov 19, 6:37 PM

Wed, Nov 18

rpokala added a comment to D23551: nvdimm(4): Prototype real basic NVDIMM-N health info.
Wed, Nov 18, 6:43 AM

Oct 30 2020

rpokala added inline comments to D27022: Introduce getlocalbase.3.
Oct 30 2020, 5:41 PM
rpokala added inline comments to D27022: Introduce getlocalbase.3.
Oct 30 2020, 5:19 PM

Oct 29 2020

rpokala added inline comments to D26994: Document disk ioctl.
Oct 29 2020, 12:41 AM

Oct 28 2020

rpokala added a comment to D26994: Document disk ioctl.
In D26994#602203, @imp wrote:

All this was cut and pasted from sys/disk.h, almost vebatim

Oct 28 2020, 11:57 PM
rpokala added inline comments to D26994: Document disk ioctl.
Oct 28 2020, 11:48 PM

Oct 25 2020

rpokala committed rS367047: MFC r366686:.
MFC r366686:
Oct 25 2020, 11:26 PM
rpokala committed rS367046: MFC r366686:.
MFC r366686:
Oct 25 2020, 11:26 PM

Oct 20 2020

rpokala added a comment to D26254: Add support for IPoIB lagg devices in FreeBSD.

Hi,

It is not possible to re-use lagg<N> for infiniband, because we set the type of the network device when it is created. lagg<N> are created like ethernet and bond<N> are created like infiniband.

Let's try to work it backwards?
I'd start with an assumption that from user POV we should be able to use the same interface for the same type of job, similarly to bond in Linux.
I see multiple options here:

  1. make lagg auto-change type based on the first interface attached. That would involve quite a lot of mechanics with notifications when changing between eth/ib.
  2. require lagg creation to specify laggtype in the creation params, assuming ethernet by default. ifconfig(8) needs to be updated (changes similar to vxlan_create() in sbin/ifconfig/ifvxlan.c).

(1) benefit that it won't require any userland changes when merging, compared to (2), however it comes at the cost of greater kernel complexity.
What is your feeling on requiring users to rebuild ifconfig(8)? Is it an absolute no-go?

Oct 20 2020, 11:59 PM
rpokala added a comment to D26254: Add support for IPoIB lagg devices in FreeBSD.

The only real question/concern I have is the name. I'm a bit afraid that we're saying that "bond" is an IB port-channel and "lagg" is an ethernet port-channel. It's a bit confusing, given one cannot distinguish which is which by name and the fact that Linux folks are used to "bond" as the ethernet port-channel. If we really want to have the different names (to keep some applications happy?), would it be possible to have a name other than "bond"?

Oct 20 2020, 7:17 PM

Oct 16 2020

rpokala added a comment to D26819: cdefs: require gcc 4.2 or later.

cdefs: require gcc 4.2

Oct 16 2020, 5:24 PM

Oct 13 2020

rpokala added a comment to D26767: nvme: Use shared timeout rather than timeout per transaction.

to ensure that any commands that completed after we last poll are handled in a timely manner.

Oct 13 2020, 9:55 PM
rpokala closed D26733: Allow IPoIB to work with multiple FIBs.
Oct 13 2020, 8:47 PM
rpokala committed rS366686: Allow IP over IB to work with multiple FIBs..
Allow IP over IB to work with multiple FIBs.
Oct 13 2020, 8:42 PM

Oct 12 2020

rpokala added a comment to D26733: Allow IPoIB to work with multiple FIBs.

This piece of code is about to change with D26254 . I've added the patch there instead.

Oct 12 2020, 10:02 PM

Oct 10 2020

rpokala retitled D26733: Allow IPoIB to work with multiple FIBs from Allow IPoIB to work with mutiple FIBs to Allow IPoIB to work with multiple FIBs.
Oct 10 2020, 9:56 PM
rpokala requested review of D26733: Allow IPoIB to work with multiple FIBs.
Oct 10 2020, 9:50 PM

Oct 8 2020

rpokala added a comment to D26254: Add support for IPoIB lagg devices in FreeBSD.

Anmol is no longer with Panasas. 🙁 We remain interested in this feature, but we no longer have anyone with the cycles to participate in the review.

Oct 8 2020, 5:52 PM
rpokala removed a reviewer for D26254: Add support for IPoIB lagg devices in FreeBSD: anmolk_panasas.com.
Oct 8 2020, 5:49 PM

Sep 25 2020

rpokala accepted D26562: Move kernel env global variables, etc to sys/kenv.h.
Sep 25 2020, 11:36 PM

Sep 23 2020

rpokala accepted D26526: Add a new option (-H) to daemon(8) to catch SIGHUP and re-open output_file file when received..
Sep 23 2020, 9:48 PM
rpokala added inline comments to D26526: Add a new option (-H) to daemon(8) to catch SIGHUP and re-open output_file file when received..
Sep 23 2020, 8:48 PM

Sep 21 2020

rpokala added a comment to D21111: beinstall.sh: Use bectl instead of beadm by default.

FWIW, in consultation w/ @kevans, I did s/beadm/bectl/g on beinstall,sh to get myself out of a problem, and it worked without issue.

Sep 21 2020, 6:51 PM

Sep 4 2020

rpokala edited reviewers for D26254: Add support for IPoIB lagg devices in FreeBSD, added: anmolk_panasas.com; removed: rpokala, khirbat_gmail.com.

Removing myself as a reviewer, and adding (the correct) Anmol from Panasas instead.

Sep 4 2020, 3:50 PM

Sep 3 2020

rpokala added a comment to D26254: Add support for IPoIB lagg devices in FreeBSD.

I am nowhere near competent to review any of this, but I did skim it. One thing that jumped out at me is that you're using "bond", not "lagg", only for Infiniband. That seems like a gratuitous difference; why?

Sep 3 2020, 4:36 AM

Sep 1 2020

rpokala added inline comments to D26241: update exports.5 to include information on the TLS export options.
Sep 1 2020, 6:13 AM

Aug 13 2020

rpokala accepted D25938: acpi_asus: Expose keyboard backlight control via a sysctl.

I don't know enough about ACPI to really comment on the code change. The manpage change looks fine, but please remember to bump .Dd when you actually commit.

Aug 13 2020, 4:54 PM

Aug 12 2020

rpokala added inline comments to D26012: Add apple-zfs and solaris-reserved to make `gpart show` more convenient.
Aug 12 2020, 5:37 PM

Aug 7 2020

rpokala added inline comments to D25938: acpi_asus: Expose keyboard backlight control via a sysctl.
Aug 7 2020, 4:33 PM

Aug 5 2020

rpokala added inline comments to D25967: The practice of creating symbolic links is somewhat fragile. Make hard copies instead always..
Aug 5 2020, 9:26 PM
rpokala added inline comments to D25967: The practice of creating symbolic links is somewhat fragile. Make hard copies instead always..
Aug 5 2020, 9:20 PM

Aug 4 2020

rpokala added inline comments to D25938: acpi_asus: Expose keyboard backlight control via a sysctl.
Aug 4 2020, 7:23 PM

Aug 3 2020

rpokala added a comment to D25936: Add domain-policy free for amd64 fpu_kern_ctx.
In D25936#574723, @cem wrote:

Sorry Ravi, no idea why I thought this was you. It was Anton @ ISLN.

Aug 3 2020, 11:51 PM
rpokala added inline comments to D25916: Add prng(9) API.
Aug 3 2020, 8:09 PM

Jul 30 2020

rpokala accepted D25893: Add definition for the 'removable media flag' from word 0 in the Identify page..

Danke!

Jul 30 2020, 4:13 PM
rpokala added a comment to D25847: Do not mention portsnap(8) in ports.7.

As we are moving away from portsnap, ...

Jul 30 2020, 12:17 AM
rpokala added a comment to D25839: efibootmgr: Add option to request booting to the firmware user interface.

So this is the moral equivalent of ipmitool chassis bootdev bios?

Jul 30 2020, 12:11 AM

Jul 15 2020

rpokala added a comment to D25677: devstat(9): Rename devstat_add_entry to devstat_new_entry.
In D25677#568288, @gbe wrote:

Rename devstat_add_entry to devstat_new_entry -- but why?

The function was deleted from sys/sys/devicestat.h around 2003 and devstat_new_entry was added as a replacement.

Jul 15 2020, 6:01 PM
rpokala added a comment to D25677: devstat(9): Rename devstat_add_entry to devstat_new_entry.

Rename devstat_add_entry to devstat_new_entry -- but why?

Jul 15 2020, 5:24 PM
rpokala accepted D25312: Relax the rule against declaring variables in nested scopes..
Jul 15 2020, 2:12 AM

Jul 10 2020

rpokala accepted D25608: First cut at a loader.conf.d support.

Code LGTM; suggestion for the manpage.

Jul 10 2020, 3:46 AM
rpokala added inline comments to D25608: First cut at a loader.conf.d support.
Jul 10 2020, 3:09 AM

Jul 9 2020

rpokala added a comment to D25605: loader: GELI writes are not yet implemented.

LGTM, but you probably want to hear from someone who knows more (read: anything) about GELI. :-)

Jul 9 2020, 10:53 PM
rpokala added inline comments to D25605: loader: GELI writes are not yet implemented.
Jul 9 2020, 10:05 PM

Jun 22 2020

rpokala added a comment to D25389: Add loop visualization and parallel execution support into rcorder.
In D25389#560500, @avg wrote:

I'm a little late to the party, but thanks for the GraphViz! IIRC, I wrote a little shell script several years ago to pipe through to do the same thing, but I never committed it.

I can see sbin/rcorder/rcorder-visualize.sh committed by @vangyzen more than 3 years ago.
According to the commit message, it was written by Joerg Sonnenberger for NetBSD.

Jun 22 2020, 8:49 PM
rpokala added inline comments to D25389: Add loop visualization and parallel execution support into rcorder.
Jun 22 2020, 8:46 PM
rpokala added a comment to D25389: Add loop visualization and parallel execution support into rcorder.

I'm a little late to the party, but thanks for the GraphViz! IIRC, I wrote a little shell script several years ago to pipe through to do the same thing, but I never committed it.

Jun 22 2020, 8:32 PM

Jun 20 2020

rpokala accepted D25369: Make vipw error message less cryptic.

Seems reasonable.

Jun 20 2020, 1:18 AM

Jun 19 2020

rpokala committed rS362368: MFC r362078:.
MFC r362078:
Jun 19 2020, 7:07 AM
rpokala committed rS362366: MFC r362078:.
MFC r362078:
Jun 19 2020, 6:36 AM
rpokala committed rS362364: MFC r362078:.
MFC r362078:
Jun 19 2020, 5:54 AM

Jun 17 2020

rpokala added a comment to D25312: Relax the rule against declaring variables in nested scopes..

Please clarify that declaring a variable within the parens of the for is permissible.

Jun 17 2020, 5:19 AM

Jun 11 2020

rpokala committed rS362078: Decode the "LACP Fast Timeout" LAGG option flag.
Decode the "LACP Fast Timeout" LAGG option flag
Jun 11 2020, 10:46 PM
rpokala closed D25239: Decode "LACP Fast Timeout" option flag.
Jun 11 2020, 10:46 PM
rpokala added a reviewer for D25239: Decode "LACP Fast Timeout" option flag: jpaetzel.
Jun 11 2020, 10:33 PM
rpokala requested review of D25239: Decode "LACP Fast Timeout" option flag.
Jun 11 2020, 9:25 PM

Jun 9 2020

rpokala accepted D25161: Remove the FIRMWARE_MAX limit..

LGTM

Jun 9 2020, 3:06 PM

Jun 8 2020

rpokala added inline comments to D25161: Remove the FIRMWARE_MAX limit..
Jun 8 2020, 4:45 AM
rpokala added inline comments to D25161: Remove the FIRMWARE_MAX limit..
Jun 8 2020, 12:22 AM

May 20 2020

rpokala accepted D24922: bnxt: isc_nrxd_max and isc_ntxd_max must be powers of two.

Thanks!

May 20 2020, 3:22 PM

May 19 2020

rpokala added inline comments to D24922: bnxt: isc_nrxd_max and isc_ntxd_max must be powers of two.
May 19 2020, 9:52 PM

May 13 2020

rpokala accepted D24762: Implement aliases in a way that actually work..

Changes look fine, and I'm satisfied with your answers to my question.

May 13 2020, 6:23 PM

May 12 2020

rpokala added a comment to D24825: Make all the ata probe* and xpt* routines aprobe* and axpt* respectively..

What about NVMe and MMC? If they don't have this problem, please say so in the commit message.

May 12 2020, 11:44 PM

May 11 2020

rpokala added a comment to D24762: Implement aliases in a way that actually work..

I note this is now creating an alias in NVMECAM, as well as in the GEOM layer; why both?

May 11 2020, 7:21 AM

Apr 30 2020

rpokala added inline comments to D24629: Implement the NVME_GET_NSID and NVME_PASSTHROUGH_CMD ioctls.
Apr 30 2020, 12:42 AM

Apr 20 2020

rpokala added inline comments to D24511: Introduce gauges as new types.
Apr 20 2020, 8:28 PM
rpokala requested changes to D24511: Introduce gauges as new types.

Please don't submit without a manpage!

Apr 20 2020, 8:23 PM

Apr 18 2020

rpokala accepted D24477: llvm9 wont allow enum definition inside anon-struct.

This seems reasonable.

Apr 18 2020, 1:07 AM

Apr 3 2020

rpokala added a comment to D23714: Add a manual page for smbios(4).
In D23714#534003, @gbergling_gmail.com wrote:

Ping?

Apr 3 2020, 9:47 PM

Mar 31 2020

rpokala closed D24242: Fix build for mips.XLP64 kernel, by re-ordering headers..
Mar 31 2020, 8:09 PM
rpokala committed rS359493: Fix build for mips.XLP64 kernel, by re-ordering headers.
Fix build for mips.XLP64 kernel, by re-ordering headers
Mar 31 2020, 8:09 PM
rpokala retitled D24242: Fix build for mips.XLP64 kernel, by re-ordering headers. from Fix build for mips.XLP64 kernel, by adding a missing header. to Fix build for mips.XLP64 kernel, by re-ordering headers..
Mar 31 2020, 8:02 PM
rpokala updated the diff for D24242: Fix build for mips.XLP64 kernel, by re-ordering headers..

Address review comments from emaste and jhb:

Mar 31 2020, 8:01 PM
rpokala updated the summary of D24242: Fix build for mips.XLP64 kernel, by re-ordering headers..
Mar 31 2020, 6:32 PM
rpokala updated the summary of D24242: Fix build for mips.XLP64 kernel, by re-ordering headers..
Mar 31 2020, 6:31 PM
rpokala created D24242: Fix build for mips.XLP64 kernel, by re-ordering headers..
Mar 31 2020, 6:30 PM

Mar 24 2020

rpokala accepted D24178: Disable rarely used architecture variants in make universe by default..
Mar 24 2020, 5:21 PM
rpokala accepted D24178: Disable rarely used architecture variants in make universe by default..

FWIW, LGTM.

Mar 24 2020, 3:51 PM

Feb 23 2020

rpokala accepted D23714: Add a manual page for smbios(4).
Feb 23 2020, 6:18 PM

Feb 17 2020

rpokala added inline comments to D23714: Add a manual page for smbios(4).
Feb 17 2020, 7:47 PM

Jan 24 2020

rpokala added inline comments to D23336: stdio: provide _unlocked variants of fflush, fputc, fputs, fread, fwrite.
Jan 24 2020, 6:27 PM

Jan 23 2020

rpokala added inline comments to D23336: stdio: provide _unlocked variants of fflush, fputc, fputs, fread, fwrite.
Jan 23 2020, 7:43 PM

Jan 18 2020

rpokala added a comment to D23247: Provide O_SEARCH.

The manpage should explain what "search only" means.

Jan 18 2020, 7:31 AM

Jan 16 2020

rpokala added inline comments to D12773: Manage thread signal mask using a shared word, instead of syscall..
Jan 16 2020, 3:21 AM

Jan 15 2020

rpokala added inline comments to D23165: bhyve(8): Add VM Generation Counter ACPI device.
Jan 15 2020, 6:46 PM
rpokala added inline comments to D23174: Add qsort_s(3).
Jan 15 2020, 1:13 AM
rpokala added a comment to D23165: bhyve(8): Add VM Generation Counter ACPI device.

So, bhyve literally generates the ACPI source text, and then does system(iasl) as part of startup? "Neat!"

Jan 15 2020, 12:36 AM

Jan 14 2020

rpokala added inline comments to D12773: Manage thread signal mask using a shared word, instead of syscall..
Jan 14 2020, 2:32 AM

Jan 10 2020

rpokala added inline comments to D23129: Small tweak to the default behavior of shutdown -c.
Jan 10 2020, 9:35 PM

Dec 13 2019

rpokala added inline comments to D22792: Build pxeboot files for all interpreters..
Dec 13 2019, 8:15 PM
rpokala added a comment to D22792: Build pxeboot files for all interpreters..

In any case, I will take another swing at this, using a Makefile.inc as @imp suggested.

Dec 13 2019, 4:06 PM