Page MenuHomeFreeBSD

rpokala (Ravi Pokala)
User

Projects

User Details

User Since
Nov 20 2015, 9:23 AM (444 w, 3 d)

Recent Activity

Jan 16 2024

rpokala added inline comments to D41318: Add the "missing" WireGuard rc.d script.
Jan 16 2024, 4:09 PM · manpages, rc, network

Jan 14 2024

rpokala accepted D43426: cdefs: Introduce __result_use_or_ignore_check.
Jan 14 2024, 12:43 AM

Sep 26 2023

rpokala added inline comments to D41984: newvers: Add comment about why we need sccs, but deprecate it.
Sep 26 2023, 7:49 PM

Aug 16 2023

rpokala added inline comments to D41484: snd: simplify SND_DECLARE_FILE.
Aug 16 2023, 9:07 PM

Jul 19 2023

rpokala added inline comments to D41104: intro(9): rewrite from scratch.
Jul 19 2023, 9:36 PM
rpokala added inline comments to D41104: intro(9): rewrite from scratch.
Jul 19 2023, 9:35 PM

Jun 28 2023

rpokala added a comment to D40789: atkbc: Better test for old chromebooks.

D40787 applied the quirks for {"coreboot", "Acer", "Peppy"}, but this change does not...?

Jun 28 2023, 6:53 PM
rpokala accepted D40787: atkbd: Flip the default for 'coreboot' to being normal.

I don't have any particular context for this issue, but the description makes sense, and the code change implements it.

Jun 28 2023, 5:55 PM

May 5 2023

rpokala added inline comments to D39983: stand: add comconsole backwards compatibility shim for aarch64.
May 5 2023, 10:38 PM
rpokala committed rGd0049a46bd35: jedec_dimm(4): Refactor offset adjustment and page0 reset (authored by rpokala).
jedec_dimm(4): Refactor offset adjustment and page0 reset
May 5 2023, 12:31 AM
rpokala committed rGa9ee57e46ff0: jedec_dimm(4): Add manufacturing year and week. (authored by rpokala).
jedec_dimm(4): Add manufacturing year and week.
May 5 2023, 12:31 AM
rpokala committed rGfa63175685bf: jedec_dimm(4): Refactor offset adjustment and page0 reset (authored by rpokala).
jedec_dimm(4): Refactor offset adjustment and page0 reset
May 5 2023, 12:30 AM
rpokala committed rG861fdb46300b: jedec_dimm(4): Add manufacturing year and week. (authored by rpokala).
jedec_dimm(4): Add manufacturing year and week.
May 5 2023, 12:30 AM

Apr 28 2023

rpokala committed rG15d69c840d86: jedec_dimm(4): Refactor offset adjustment and page0 reset (authored by rpokala).
jedec_dimm(4): Refactor offset adjustment and page0 reset
Apr 28 2023, 5:55 PM
rpokala committed rGde57e0ef5a15: jedec_dimm(4): Add manufacturing year and week. (authored by rpokala).
jedec_dimm(4): Add manufacturing year and week.
Apr 28 2023, 5:55 PM
rpokala closed D39842: jedec_dimm(4): Refactor offset adjustment and page0 reset.
Apr 28 2023, 5:55 PM
rpokala closed D39795: jedec_dimm(4): Add manufacturing year and week..
Apr 28 2023, 5:55 PM

Apr 27 2023

rpokala added a comment to D39842: jedec_dimm(4): Refactor offset adjustment and page0 reset.
In D39842#907259, @imp wrote:

seems reasonable, though there's a lot to test to make sure you didn't miss a spot where you'd need to restore page0.

Apr 27 2023, 8:02 PM
rpokala added inline comments to D39795: jedec_dimm(4): Add manufacturing year and week..
Apr 27 2023, 7:01 AM
rpokala added reviewers for D39842: jedec_dimm(4): Refactor offset adjustment and page0 reset: jhb, imp.
Apr 27 2023, 5:08 AM
rpokala requested review of D39842: jedec_dimm(4): Refactor offset adjustment and page0 reset.
Apr 27 2023, 5:08 AM

Apr 26 2023

rpokala updated the diff for D39795: jedec_dimm(4): Add manufacturing year and week..

Reformat copyright, per imp@'s request.

Apr 26 2023, 5:24 PM

Apr 25 2023

rpokala added inline comments to D39795: jedec_dimm(4): Add manufacturing year and week..
Apr 25 2023, 6:33 PM
rpokala updated the diff for D39795: jedec_dimm(4): Add manufacturing year and week..

Describe new fields in jedec_dimm.4

Apr 25 2023, 5:36 PM
rpokala added a reviewer for D39795: jedec_dimm(4): Add manufacturing year and week.: avg.
Apr 25 2023, 6:24 AM
rpokala updated the diff for D39795: jedec_dimm(4): Add manufacturing year and week..

Update the date for the manpage.

Apr 25 2023, 6:22 AM
rpokala requested review of D39795: jedec_dimm(4): Add manufacturing year and week..
Apr 25 2023, 6:14 AM

Apr 24 2023

rpokala added inline comments to D36594: Document library types in the intro(3) manual page.
Apr 24 2023, 5:55 PM

Apr 20 2023

rpokala added inline comments to D39714: tzcode: Clean up the ctime(3) manual page..
Apr 20 2023, 11:28 PM

Apr 10 2023

rpokala added inline comments to D34747: ls(1): Change -g and make -n imply -l to implement POSIX.
Apr 10 2023, 4:54 PM

Mar 21 2023

rpokala added a comment to D39129: groupmember.9: remove the man page.

Maybe add an entry for groupmember() to ucred.9, along with other (struct ucred)-related functions? crsetgroups() is there, for example.

Mar 21 2023, 4:17 PM

Mar 20 2023

rpokala added inline comments to D39135: kern_reboot(9): describe event handlers.
Mar 20 2023, 4:58 PM
rpokala added inline comments to D39133: kern_reboot(9): some updates.
Mar 20 2023, 4:55 PM

Mar 18 2023

rpokala accepted D39132: panic(9): some updates.
Mar 18 2023, 12:33 AM
rpokala accepted D39131: KASSERT(9): some updates.
Mar 18 2023, 12:31 AM
rpokala added inline comments to D39130: critical(9): small updates.
Mar 18 2023, 12:27 AM

Mar 16 2023

rpokala accepted D39132: panic(9): some updates.
Mar 16 2023, 10:04 PM
rpokala accepted D39131: KASSERT(9): some updates.
Mar 16 2023, 9:03 PM
rpokala accepted D39137: hardclock(9): small cleanups.
Mar 16 2023, 8:46 PM
rpokala added inline comments to D39135: kern_reboot(9): describe event handlers.
Mar 16 2023, 8:39 PM
rpokala added inline comments to D39132: panic(9): some updates.
Mar 16 2023, 8:19 PM
rpokala added a comment to D39131: KASSERT(9): some updates.

I have been wondering about MPASS() forever! :-)

Mar 16 2023, 8:04 PM
rpokala accepted D39130: critical(9): small updates.
Mar 16 2023, 8:00 PM
rpokala accepted D39128: vcount.9: remove obsolete man page.
Mar 16 2023, 7:53 PM

Mar 15 2023

rpokala accepted D39079: veriexec: Improve comments.
Mar 15 2023, 4:38 AM
rpokala added inline comments to D39079: veriexec: Improve comments.
Mar 15 2023, 4:08 AM

Mar 14 2023

rpokala added a comment to D39079: veriexec: Improve comments.

I would just have a single comment for the new functions: The target is verified, so disallow replacement.

Mar 14 2023, 5:13 PM
rpokala accepted D39074: arm: generic_timer: dedupe resource specs between ACPI and FDT.
Mar 14 2023, 5:00 AM

Mar 6 2023

rpokala added a comment to D38904: ifnet: add if_foreach_sleep() to allow ifnet iterations with sleep..

As discussed in email, if_foreach_sleep() sounds like the loop itself inserts a delay. I suggest changing it to if_foreach_sleepable(), which more accurately conveys that it can sleep (or use callbacks that can sleep), not that that it does sleep.

Mar 6 2023, 7:01 PM

Mar 4 2023

rpokala accepted D38817: FFS/UFS snapshots: improve documentation for removal (deletion) and unlinking.
Mar 4 2023, 6:27 PM
rpokala added inline comments to D38817: FFS/UFS snapshots: improve documentation for removal (deletion) and unlinking.
Mar 4 2023, 2:02 AM
rpokala added inline comments to D38817: FFS/UFS snapshots: improve documentation for removal (deletion) and unlinking.
Mar 4 2023, 1:31 AM

Feb 28 2023

rpokala accepted D38817: FFS/UFS snapshots: improve documentation for removal (deletion) and unlinking.
Feb 28 2023, 3:36 AM
rpokala added inline comments to D38817: FFS/UFS snapshots: improve documentation for removal (deletion) and unlinking.
Feb 28 2023, 3:22 AM

Jan 31 2023

rpokala accepted D38281: cmp: Increase buffer size for non-mmap case..

The libc default is 1KB; 64KB should help significantly without excessive overhead.

Jan 31 2023, 12:27 AM

Nov 18 2022

rpokala accepted D37439: arm64/machdep: Add parameter to the EFI table walking code.
Nov 18 2022, 5:52 PM
rpokala accepted D37438: arm64/pmap: freed only used for PV_STATS.
Nov 18 2022, 4:59 PM

Oct 28 2022

rpokala added inline comments to D29543: license: Create a license guideline document.
Oct 28 2022, 5:54 AM

Oct 3 2022

rpokala added a comment to D22150: Update swapon.8 to discourage using ZFS as swap device/file..
.Sh NOTE
ZVOLs are discouraged for use as swap devices,
because ZFS needs to allocate memory in order to write,
which may not be possible while the system is under memory pressure.
In other words, ZFS needs memory to make memory available.
ZFS swap files are discouraged for the same reason.
Oct 3 2022, 5:14 AM

Sep 15 2022

rpokala added a comment to D36515: ctime.3: Add a note about a possible return value to the description of localtime(3).

Is the problem when the year won't fit into an int, or specifically when it won't fit into a 32-bit int?

Sep 15 2022, 4:56 PM

Sep 5 2022

rpokala added a comment to D36435: loader.efi(8): document slop control, amd64 nocopy, and amd64 fault commands.

I have reworded the proposed diff for better readability in English; please consider adopting any or all of these changes:

.Ss Staging Slop
The kernel needs to allocate memory during very early bootstrap,
when creating kernel page tables and other data structures needed for initial operations.
Because the kernel cannot even parse the firmware tables describing available memory without allocating,
this makes bootstrapping problematic.
To solve this issue,
the kernel assumes that some memory after the staging area
.Po
where the kernel itself, together with modules and metadata, as loaded by
.Nm ,
resides
.Pc
is available for use,
without causing corruption of any firmware data.
.Pp
It is up to the loader to ensure that the staging area is larger than just the loaded kernel, modules, and metadata, by an extra
.Dq slop
amount.
By default, amd64 reserves 8MB.
The
.Ic staging_slop
command allows for tuning the slop size.
It takes a single argument, the size of the slop in bytes.
.Ss amd64 Nocopy
BIOS loaders on i386 and amd64 put the staging area starting at the physical address
.Ad 2M ,
then enables paging with identical mapping for the low
.Ad 1G .
The initial port of
.Nm
followed the same scheme for handing control to the kernel,
since it avoided modifications for the loader/kernel hand-off protocol,
and for the kernel page table bootstrap.
.Pp
This approach is incompatible with the UEFI specification,
and as a practical matter,
caused troubles on many boards,
because UEFI firmware is free to use any memory for its own needs.
Applications like
.Nm
must only use memory explicitly allocated using boot interfaces.
The original way also potentially destroyed UEFI runtime interfaces data.
.Pp
Eventually,
.Nm
and the kernel were improved to avoid this problem.
For backward bug-compatibility,
and to allow booting older kernels with newer
.Nm ,
this
.Sq nocopy
behaviour can be controlled by the loader
.Ic copy_staging
command.
It takes a single argument,
which can be one of
.Bl -tag -width disable
.It Ar disable
Force-disable copying staging area to
.Ad 2M .
.It Ar enable
Force-enable copying staging area to
.Ad 2M .
.It Ar auto
Selects the behaviour based on the kernel's capability of boostraping
from non-2M physical base.
The kernel reports this capability by exporting the symbol
.Va kernphys .
.El
.Pp
Arm64 loaders have operated in the
.Sq nocopy
mode from their inception,
so there is no
.Ic copy_staging
command on that platform.
.Ss amd64 Faults
Because it executes in x86 protected mode,
the amd64 version of
.Nm
is susceptible to CPU faults due to programmer mistakes and memory corruption.
To make debugging such faults easier, amd64
.Nm
can provide detailed reporting of the CPU state at the time of the fault.
.Pp
The
.Ic grab_faults
command installs a handler for faults directly in the IDT,
avoiding the use of the UEFI debugging interface
.Fn EFI_DEBUG_SUPPORT_PROTOCOL.RegisterExceptionCallback .
That interface is left available for advanced debuggers in the UEFI environment.
The
.Ic ungrab_faults
command tries to deinstall the fault handler, returning TSS and IDT
CPU tables to their pre-installation state.
The
.Ic fault
command produces a fault in the
.Nm
environment for testing purposes,
by executing the
.Ic ud2
processor instruction.
Sep 5 2022, 6:53 AM

Sep 1 2022

rpokala accepted D36418: lualoader: Add loader_menu_multi_user_prompt config variable.
Sep 1 2022, 10:42 PM

Aug 29 2022

rpokala accepted D36286: stand: Document EFI consoles.
Aug 29 2022, 5:42 AM

Aug 26 2022

rpokala added inline comments to D36286: stand: Document EFI consoles.
Aug 26 2022, 9:47 PM
rpokala added inline comments to D33779: nvmecontrol: logpage will use the controller's vid to choose the formatting function when the vendor name is not provided..
Aug 26 2022, 2:54 AM

Aug 23 2022

rpokala added inline comments to D36318: Add new EVENTHANDLER types: PREEMPTIBLE and SLEEPABLE.
Aug 23 2022, 8:20 PM

Aug 22 2022

rpokala added inline comments to D36286: stand: Document EFI consoles.
Aug 22 2022, 8:06 PM
rpokala added inline comments to D36286: stand: Document EFI consoles.
Aug 22 2022, 6:08 PM
rpokala requested changes to D36286: stand: Document EFI consoles.
Aug 22 2022, 6:07 PM

Aug 5 2022

rpokala added a comment to D22012: Import dhcpcd(8) into FreeBSD base..

Given that we h ave a number of options in ports, why? What would dhcpd in base provide us that one of the alternatives in ports cannot?

Aug 5 2022, 11:28 PM
rpokala accepted D35588: bsdinstall: allow setting the root password via env variables.
Aug 5 2022, 2:46 AM

Jul 28 2022

rpokala added a comment to D35912: stand: Add driver interface docs.

Based on my previous comments, I suggest something like this for dv_type:

.It dv_type
Type of device.
The supported types are:
.Bl -tag -width "DEVT_NONE"
.It DEVT_NONE
.It DEVT_DISK
.It DEVT_NET
.It DEVT_CD
.It DEVT_ZFS
.It DEVT_FD
.El
Each type may have its own associated (struct type_devdesc),
which has the generic (struct devdesc) as its first member.

(The markup might need a little tweaking, particularly the references to the structures, but that should be in the right ballpark.)

Jul 28 2022, 10:41 PM
rpokala added inline comments to D35912: stand: Add driver interface docs.
Jul 28 2022, 10:25 PM
rpokala added a comment to D35966: date: refer to tzdata as a 'distribution' rather than 'package'.
In D35966#816520, @pauamma wrote:

I agree "package" is unclear, but I have mixed feelings about "distribution". "tzdata data" read weirdly to me, so what about "information"?

Jul 28 2022, 12:06 AM

Jul 27 2022

rpokala accepted D35966: date: refer to tzdata as a 'distribution' rather than 'package'.
Jul 27 2022, 6:03 PM

Jul 26 2022

rpokala added inline comments to D35959: style: Tighten up one use of 'may'.
Jul 26 2022, 9:13 PM
rpokala added a comment to D35960: style: Allow C++ comments.

I would suggest clarifying "appropriate for the situation".

Jul 26 2022, 9:09 PM
rpokala accepted D35959: style: Tighten up one use of 'may'.
Jul 26 2022, 8:24 PM
rpokala accepted D35945: Style(9): Strengthen statements about not using K&R function definitions.
Jul 26 2022, 5:30 PM
rpokala accepted D35945: Style(9): Strengthen statements about not using K&R function definitions.
Jul 26 2022, 4:34 PM

Jul 25 2022

rpokala added inline comments to D35912: stand: Add driver interface docs.
Jul 25 2022, 9:05 PM

Jul 21 2022

rpokala added a comment to D35817: qat: Rename to qat_c2xxx and remove support for modern chipsets.

Re-add the manual page.

Jul 21 2022, 5:16 PM

Jul 19 2022

rpokala added a comment to D35588: bsdinstall: allow setting the root password via env variables.

FWIW, I'd switch to printf '%s' "$ROOTPASS" on general principles, to avoid the possibility of silliness.

Jul 19 2022, 2:49 AM

Jul 18 2022

rpokala accepted D35588: bsdinstall: allow setting the root password via env variables.
Jul 18 2022, 5:15 PM

Jul 17 2022

rpokala added a comment to D35817: qat: Rename to qat_c2xxx and remove support for modern chipsets.

The qat(4) manual page was deleted, not moved or renamed. Is that deliberate?

Yes. The new QAT driver has its own manual page, and since qat_c2xxx is specifically for old hardware and won't be receiving improvements beyond the usual maintenance, I don't see much reason to keep a man page for it.

Jul 17 2022, 6:35 PM

Jul 16 2022

rpokala added a comment to D35835: ofed/infiniband: fix ifdefs for new INET changes, fixing LINT-NOIP.

LGTM.

Jul 16 2022, 9:22 PM
rpokala accepted D35828: atomic: Define inline functions for atomic_load/store.
Jul 16 2022, 12:43 AM

Jul 13 2022

rpokala accepted D35806: inet.4 tcp.4 udp.4: Replace *CTL_* OID macro names with sysctls.

LGTM.

Jul 13 2022, 8:55 PM
rpokala added inline comments to D35806: inet.4 tcp.4 udp.4: Replace *CTL_* OID macro names with sysctls.
Jul 13 2022, 7:50 PM
rpokala added a comment to D35774: kdump: Advance kdump timestamp resolution..
In D35774#812599, @jhb wrote:

Perhaps adjust the log message a bit to something like:

Jul 13 2022, 6:51 PM
rpokala added inline comments to D35774: kdump: Advance kdump timestamp resolution..
Jul 13 2022, 6:49 PM

Jul 12 2022

rpokala added a comment to D35783: ls: `-v` flag (and `strverscmp(3)` & `versionsort(3)`).

I implemented something similar to strverscmp() several years back, but in a much simpler (though potentially slower?) way, by leveraging strtol():

int
strnumcmp(
    const char *s1,
    const char *s2)
{
    unsigned int n1 = 0;
    unsigned int n2 = 0;
Jul 12 2022, 4:39 PM

Jul 11 2022

rpokala added inline comments to D35774: kdump: Advance kdump timestamp resolution..
Jul 11 2022, 5:28 PM

May 27 2022

rpokala added a comment to D35326: glabel.8: Warn against using generic labels on a shared device.
In D35326#800921, @imp wrote:

"You should not use glabel with any device you plan on putting a filesystem on"

might be better advise.

May 27 2022, 12:22 AM

May 6 2022

rpokala added a comment to D35141: msgbuf: Allow microsecond granularity timestamps.
In D35141#796582, @imp wrote:

Nice! (How did I not know that kern.msgbuf_show_timestamp was a thing?!?)

Because nobody has done something like https://reviews.freebsd.org/D35139 to document it?

May 6 2022, 5:48 PM
rpokala added a comment to D35141: msgbuf: Allow microsecond granularity timestamps.

Nice! (How did I not know that kern.msgbuf_show_timestamp was a thing?!?)

May 6 2022, 5:41 PM
rpokala added inline comments to D35139: dmesg: Document kern.msgbuf_show_timestamp.
May 6 2022, 4:40 PM

May 1 2022

rpokala committed rG3cbc8109a985: lacp: short timeout erroneously declares link-flapping (authored by Greg Foster <gfoster@panasas.com>).
lacp: short timeout erroneously declares link-flapping
May 1 2022, 7:18 PM
rpokala committed rG3fbee9be2563: lacp: short timeout erroneously declares link-flapping (authored by Greg Foster <gfoster@panasas.com>).
lacp: short timeout erroneously declares link-flapping
May 1 2022, 7:18 PM

Apr 28 2022

rpokala added inline comments to D34208: find-mfc: add a tool to find MFC candidates.
Apr 28 2022, 5:05 PM