Page MenuHomeFreeBSD

rpokala (Ravi Pokala)
User

Projects

User Details

User Since
Nov 20 2015, 9:23 AM (160 w, 4 d)

Recent Activity

Thu, Dec 6

rpokala added a comment to D18445: Update ext2fs(5) man page.

Please create links for ext3fs.5 and ext4fs.5; in share/man/man5/Makefile, add these to the list:

MLINKS+= ext2fs.5 ext3fs.5
MLINKS+= ext2fs.5 ext4fs.5
Thu, Dec 6, 1:39 AM

Mon, Dec 3

rpokala added inline comments to D17947: Rework UEFI ESP generation.
Mon, Dec 3, 11:54 PM

Thu, Nov 29

rpokala added inline comments to D18380: Fix a number of style issues with trim(8).
Thu, Nov 29, 7:11 PM

Oct 4 2018

rpokala added inline comments to D16092: Committer guide: add note about private discussions.
Oct 4 2018, 10:01 PM
rpokala added inline comments to D16089: committer guide: update rules for contrib software..
Oct 4 2018, 9:58 PM

Aug 28 2018

rpokala committed rD52189: I forgot to update the docs with my keys when I first got my commit bit..
I forgot to update the docs with my keys when I first got my commit bit.
Aug 28 2018, 10:39 PM
rpokala closed D16915: Long-overdue addition of my keys..
Aug 28 2018, 10:39 PM
rpokala added a comment to D16915: Long-overdue addition of my keys..

I went ahead and moved the news.xml change as you suggested; I'm including it there for posterity.

Aug 28 2018, 7:42 AM
rpokala updated the diff for D16915: Long-overdue addition of my keys..

Re-order change to news.xml to be in reverse-chronological order.

Aug 28 2018, 7:37 AM

Aug 27 2018

rpokala updated the diff for D16915: Long-overdue addition of my keys..

Actually include the new key in the diff...

Aug 27 2018, 3:34 AM
rpokala created D16915: Long-overdue addition of my keys..
Aug 27 2018, 3:33 AM

Aug 25 2018

rpokala accepted D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..

LGTM from a purely technical standpoint. (I'm actively avoiding the larger policy discussion around drm(4) and drm2(4).)

Aug 25 2018, 2:13 AM

Aug 1 2018

rpokala committed rS337033: Remove jedec_ts(4).
Remove jedec_ts(4)
Aug 1 2018, 8:24 AM
rpokala closed D16537: Remove jedec_ts(4)..
Aug 1 2018, 8:24 AM

Jul 31 2018

rpokala updated the diff for D16537: Remove jedec_ts(4)..

Fix a typo in UPDATING: "jdedc_ts" -> "jedec_ts".

Jul 31 2018, 9:06 PM
rpokala created D16537: Remove jedec_ts(4)..
Jul 31 2018, 9:03 PM
rpokala committed rS336976: MFC r336662,r336682.
MFC r336662,r336682
Jul 31 2018, 4:08 PM

Jul 24 2018

rpokala committed rS336682: Update .Dd in light of r336662..
Update .Dd in light of r336662.
Jul 24 2018, 7:21 PM
rpokala committed rS336662: Deprecate jedec_ts(4) and point users to jedec_dimm(4) instead.
Deprecate jedec_ts(4) and point users to jedec_dimm(4) instead
Jul 24 2018, 8:15 AM
rpokala closed D16412: Deprecate jedec_ts(4) and point users to jedec_dimm(4) instead..
Jul 24 2018, 8:15 AM
rpokala created D16412: Deprecate jedec_ts(4) and point users to jedec_dimm(4) instead..
Jul 24 2018, 12:34 AM

Jul 21 2018

rpokala accepted D16375: Mention the Linux compatibility layer instead of the Linux emulator in the BUGS section..

Looks good to me.

Jul 21 2018, 1:35 AM
rpokala added inline comments to D16375: Mention the Linux compatibility layer instead of the Linux emulator in the BUGS section..
Jul 21 2018, 12:51 AM

Jul 11 2018

rpokala added a comment to D16211: run(4): Add a new USB device ID..

... the numbers just happened to coincide here.

Jul 11 2018, 1:53 AM
rpokala added a comment to D16211: run(4): Add a new USB device ID..

The summary says PAU06 is the combination of two already-supported chips: RT5372 radio and RT5392 MAC. But nothing in the diff mentions the latter chip.

Jul 11 2018, 1:27 AM

Jun 29 2018

rpokala accepted D16064: bin/dd: Add conv=direct.
Jun 29 2018, 4:21 PM

Jun 25 2018

rpokala added inline comments to D15999: Create PCI_MATCH and pci_match_device.
Jun 25 2018, 7:55 PM

Jun 22 2018

rpokala added a comment to D15927: Update ixl(4) and ixlv(4) man pages.
In D15927#338098, @erj wrote:
In D15927#337633, @pi wrote:

Please expand LOM to 'onboard interfaces (LAN on Motherboard, LOM)', if possible. I'm a 30-years user of ethernet, but I've never heard that abbreviation.

I don't think it's that rare of an abbreviation, but I can add the expansion.

Jun 22 2018, 5:53 PM

Jun 9 2018

rpokala accepted D14818: lualoader: Add cli.lua(8) to the tree.
Jun 9 2018, 6:44 PM

Jun 8 2018

rpokala added a comment to D14819: lualoader: Add config.lua(8) to the tree.

Just a note: Anywhere I wrote {kernel} is because I couldn't come up with a better markup. I have no idea what the ideal syntax is for "this is a path with this variable substituted in" rather than "this is a path with this variable name literally in it"

Jun 8 2018, 3:52 AM
rpokala added a comment to D14476: libsa(3): Correct statement about FS Write-support, name change.

Might want to poke @imp and/or @jhb while all three of you are in the same city. :-)

Jun 8 2018, 3:51 AM
rpokala requested changes to D14819: lualoader: Add config.lua(8) to the tree.
Jun 8 2018, 3:49 AM
rpokala requested changes to D14818: lualoader: Add cli.lua(8) to the tree.
Jun 8 2018, 3:49 AM
rpokala requested changes to D14815: lualoader: Add hook.lua(8) to tree.
Jun 8 2018, 3:48 AM
rpokala closed D14790: jedec_dimm: Use correct string length when populating sc->slotid_str.
Jun 8 2018, 3:27 AM
rpokala added 1 commit(s) for D14790: jedec_dimm: Use correct string length when populating sc->slotid_str: rS331345: jedec_dimm: Use correct string length when populating sc->slotid_str.
Jun 8 2018, 3:27 AM
rpokala added an edge to rS331345: jedec_dimm: Use correct string length when populating sc->slotid_str: D14790: jedec_dimm: Use correct string length when populating sc->slotid_str.
Jun 8 2018, 3:27 AM
rpokala abandoned D5672: MAC of VLAN interface does not change.
Jun 8 2018, 3:22 AM
rpokala commandeered D5672: MAC of VLAN interface does not change.
Jun 8 2018, 3:22 AM

Jun 7 2018

rpokala added a comment to D15689: Including rc_conf_directories to be loaded with rc(8).

I think this looks good now. Now you can point someone who actually knows `rc' at it. :-)

Jun 7 2018, 4:08 PM
rpokala added inline comments to D15689: Including rc_conf_directories to be loaded with rc(8).
Jun 7 2018, 2:44 PM
rpokala added inline comments to D15689: Including rc_conf_directories to be loaded with rc(8).
Jun 7 2018, 2:32 PM
rpokala added inline comments to D15689: Including rc_conf_directories to be loaded with rc(8).
Jun 7 2018, 2:22 PM

May 30 2018

rpokala committed rS334364: Remove the mlx5 driver from LINT kernel config for 32-bit PPC.
Remove the mlx5 driver from LINT kernel config for 32-bit PPC
May 30 2018, 2:26 AM
rpokala closed D15611: Remove mlx5(4) from LINT kernel config for 32-bit PPC.
May 30 2018, 2:26 AM

May 29 2018

rpokala retitled D15611: Remove mlx5(4) from LINT kernel config for 32-bit PPC from mlx5(4) requires 64-bit atomics, which are not supported on 32-bit PPC exclude that driver from the LINT kernel config. to Remove mlx5(4) from LINT kernel config for 32-bit PPC.
May 29 2018, 10:15 PM
rpokala created D15611: Remove mlx5(4) from LINT kernel config for 32-bit PPC.
May 29 2018, 9:54 PM

May 17 2018

rpokala added a comment to D15465: Enable kernel dump options on most architectures..
In D15465#326493, @cem wrote:

It looks like the GENERIC configs that you're not updating are for ARM, RISC-V, and PPC64. Why are they being excluded?

PPC64 is not excluded. That's powerpc/conf/GENERIC64.

May 17 2018, 11:57 PM
rpokala added a comment to D15465: Enable kernel dump options on most architectures..

It looks like the GENERIC configs that you're not updating are for ARM, RISC-V, and PPC64. Why are they being excluded?

May 17 2018, 11:31 PM

Apr 10 2018

rpokala updated subscribers of D15029: new utility usr.sbin/spi.

Oh, heh, I didn't even realize that this wasn't @ian, since he and I talked about this yesterday. :-)

Apr 10 2018, 11:59 PM
rpokala added a comment to D15029: new utility usr.sbin/spi.

I started but didn't finish reading through the manpage. My comments so far are in-line.

Apr 10 2018, 6:42 PM

Mar 29 2018

rpokala added a comment to D14897: Fallback to copy if chown/chgrp would land in different filesystems.

Out of curiosity, why specifically for chown / chgrp?

Mar 29 2018, 5:30 PM
rpokala committed rS331734: MFC 331345:.
MFC 331345:
Mar 29 2018, 3:01 PM
rpokala committed rS331733: MFC 331345:.
MFC 331345:
Mar 29 2018, 3:01 PM

Mar 24 2018

rpokala added a comment to D14815: lualoader: Add hook.lua(8) to tree.

It would be good if you explained what a hook was, somewhere before the Exported functions section.

Mar 24 2018, 12:35 AM

Mar 22 2018

rpokala committed rS331345: jedec_dimm: Use correct string length when populating sc->slotid_str.
jedec_dimm: Use correct string length when populating sc->slotid_str
Mar 22 2018, 6:31 AM
rpokala added a comment to D14790: jedec_dimm: Use correct string length when populating sc->slotid_str.
In D14790#311049, @cem wrote:

Feel free to spend a bunch of time documenting libkern if you want. It's definitely valuable and shouldn't be too hard. Mostly just tedious. Maybe a thin document that just defines all of the libc-alike aliases and gets linked in a million places would be enough to start.

Mar 22 2018, 6:14 AM
rpokala added a comment to D14790: jedec_dimm: Use correct string length when populating sc->slotid_str.
# Much longer than sizeof(sc->slotid_str)
% kenv hint.jedec_dimm.0.slotid
DIMM0LONGERSTRING
Mar 22 2018, 5:58 AM
rpokala updated the diff for D14790: jedec_dimm: Use correct string length when populating sc->slotid_str.

As @cem pointed out, it's even easier to use strdup().

Mar 22 2018, 5:51 AM
rpokala added inline comments to D14790: jedec_dimm: Use correct string length when populating sc->slotid_str.
Mar 22 2018, 2:52 AM
rpokala updated the diff for D14790: jedec_dimm: Use correct string length when populating sc->slotid_str.

@imp correctly observed that since the buffer is allocated to fit, then
fully initialized, there's no need to use M_ZERO.

Mar 22 2018, 1:19 AM
rpokala created D14790: jedec_dimm: Use correct string length when populating sc->slotid_str.
Mar 22 2018, 1:12 AM

Mar 9 2018

rpokala accepted D14569: Permit sysctl(8) to set an array of numeric values for a single node..
Mar 9 2018, 10:47 PM
rpokala committed rS330680: MFC r330304: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus.
MFC r330304: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus
Mar 9 2018, 2:55 AM
rpokala committed rS330679: MFC r330304: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus.
MFC r330304: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus
Mar 9 2018, 2:55 AM

Mar 7 2018

rpokala accepted D14604: Add CTASSERTs for where CTLFLAG_MPSAFE is redundant..

Looks fine to my relatively-untrained eye.

Mar 7 2018, 4:42 PM

Mar 3 2018

rpokala committed rS330304: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.
imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver
Mar 3 2018, 1:54 AM
rpokala closed D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.
Mar 3 2018, 1:54 AM
rpokala added a comment to D14569: Permit sysctl(8) to set an array of numeric values for a single node..

Modulo adding a comment, LGTM.

Mar 3 2018, 12:06 AM

Mar 2 2018

rpokala accepted D14479: Add core.lua(8), but do not add to distribution.
Mar 2 2018, 5:30 AM
rpokala accepted D14480: Add menu.lua(8), but do not add to distribution.
Mar 2 2018, 5:06 AM
rpokala added inline comments to D14479: Add core.lua(8), but do not add to distribution.
Mar 2 2018, 5:01 AM

Mar 1 2018

rpokala added a comment to D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.

@avg / @jhb : I think I've addressed everything you were concerned about -- modulo some personal style, which is still conformant with style(9).

Mar 1 2018, 8:34 PM
rpokala added inline comments to D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.
Mar 1 2018, 2:00 AM
rpokala updated the diff for D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.

Address a few more things @jhb mentioned.

Mar 1 2018, 2:00 AM
rpokala added inline comments to D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.
Mar 1 2018, 1:07 AM
rpokala added inline comments to D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.
Mar 1 2018, 1:00 AM
rpokala updated the diff for D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.

Call only bus_generic_attach(), but not bus_generic_probe(), from the attach
methods. This behaves properly for both pre-loading via loader.conf and loading
via kldload.

Mar 1 2018, 12:59 AM

Feb 28 2018

rpokala committed rS330109: MFC r329843:.
MFC r329843:
Feb 28 2018, 10:00 AM
rpokala committed rS330107: MFC r329843:.
MFC r329843:
Feb 28 2018, 10:00 AM
rpokala added a comment to D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.

At this point, it looks like the only outstanding issue is either adding device_probe_and_attach(), or confirming that it's not necessary. I'll try to do that tomorrow.

Feb 28 2018, 8:22 AM
rpokala added inline comments to D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.
Feb 28 2018, 2:37 AM
rpokala updated the diff for D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.

Address most of @avg's review comments.

Feb 28 2018, 2:31 AM
rpokala committed rS330093: MFC r329682:.
MFC r329682:
Feb 28 2018, 12:30 AM
rpokala committed rS330092: MFC r329682:.
MFC r329682:
Feb 28 2018, 12:30 AM
rpokala added inline comments to D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.
Feb 28 2018, 12:15 AM

Feb 27 2018

rpokala updated subscribers of D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.

Thanks for finding time for this! I'll address many of your comments and post an updated diff later today.

Feb 27 2018, 5:38 PM

Feb 23 2018

rpokala committed rS329871: Somehow r329870 disn't include the mergeinfo...?.
Somehow r329870 disn't include the mergeinfo...?
Feb 23 2018, 4:51 PM
rpokala committed rS329870: MFC r323508:.
MFC r323508:
Feb 23 2018, 4:47 PM
rpokala committed rS329869: MFC r323508:.
MFC r323508:
Feb 23 2018, 4:46 PM
rpokala added inline comments to D14479: Add core.lua(8), but do not add to distribution.
Feb 23 2018, 5:06 AM
rpokala added inline comments to D14480: Add menu.lua(8), but do not add to distribution.
Feb 23 2018, 4:51 AM
rpokala added inline comments to D14480: Add menu.lua(8), but do not add to distribution.
Feb 23 2018, 3:55 AM

Feb 22 2018

rpokala committed rS329843: jedec_dimm(4): report asset info and temperatures for DDR3 and DDR4 DIMMs.
jedec_dimm(4): report asset info and temperatures for DDR3 and DDR4 DIMMs
Feb 22 2018, 11:19 PM
rpokala closed D14392: jedec_dimm(4): report asset info and temperatures for DDR3 and DDR4 DIMMs.
Feb 22 2018, 11:19 PM
rpokala accepted D14476: libsa(3): Correct statement about FS Write-support, name change.

LGTM.

Feb 22 2018, 10:57 PM
rpokala committed rS329834: MFC r329295:.
MFC r329295:
Feb 22 2018, 7:40 PM
rpokala committed rS329833: MFC r329295:.
MFC r329295:
Feb 22 2018, 7:39 PM

Feb 21 2018

rpokala updated the diff for D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.

Remove some stray comments from the manpage.

Feb 21 2018, 2:29 AM
rpokala updated the diff for D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.

style(9) changes: Correct formatting of function prototypes and declarations, and re-order variables.

Feb 21 2018, 1:43 AM