- User Since
- Nov 20 2015, 9:23 AM (126 w, 5 d)
Tue, Apr 10
Oh, heh, I didn't even realize that this wasn't @ian, since he and I talked about this yesterday. :-)
I started but didn't finish reading through the manpage. My comments so far are in-line.
Thu, Mar 29
Out of curiosity, why specifically for chown / chgrp?
Mar 24 2018
It would be good if you explained what a hook was, somewhere before the Exported functions section.
Mar 22 2018
# Much longer than sizeof(sc->slotid_str) % kenv hint.jedec_dimm.0.slotid DIMM0LONGERSTRING
As @cem pointed out, it's even easier to use strdup().
@imp correctly observed that since the buffer is allocated to fit, then
fully initialized, there's no need to use M_ZERO.
Mar 9 2018
Mar 7 2018
Looks fine to my relatively-untrained eye.
Mar 3 2018
Modulo adding a comment, LGTM.
Mar 2 2018
Mar 1 2018
Address a few more things @jhb mentioned.
Call only bus_generic_attach(), but not bus_generic_probe(), from the attach
methods. This behaves properly for both pre-loading via loader.conf and loading
Feb 28 2018
At this point, it looks like the only outstanding issue is either adding device_probe_and_attach(), or confirming that it's not necessary. I'll try to do that tomorrow.
Address most of @avg's review comments.
Feb 27 2018
Thanks for finding time for this! I'll address many of your comments and post an updated diff later today.
Feb 23 2018
Feb 22 2018
Feb 21 2018
Remove some stray comments from the manpage.
style(9) changes: Correct formatting of function prototypes and declarations, and re-order variables.
Feb 20 2018
Address some of @cem's review comments.
Feb 19 2018
Feb 16 2018
Feb 15 2018
Feb 8 2018
Feb 6 2018
Jan 31 2018
Leading 8-space -> hard-tab. Whoops!
Use the obvious one-liner, which somehow escaped me at the time of the
original diff. Thanks, avg@!
Jan 26 2018
Jan 25 2018
Jan 19 2018
Jan 10 2018
A one-sentence description of what each of the functions does would be good too (i.e. expand ctz => Count Trailing Zeros, etc).
The kernel as a standalone target does not link against libgcc or libcompiler-rt. On platforms (e.g., MIPS and RISCV) that do not have a direct assembly implementation of the relevant builtin functions that zstd references, the compiler converts them into calls to the runtime library intrinsics. Since the kernel doesn't link against the libraries, this results in a failure to link the kernel.
A comment explaining why you're doing all this would be good.
And of course the same comments for _gone_in_dev() as in _gone_in().
Jan 8 2018
I don't understand the G_NOP_PHYSPATH_PASSTHROUGH stuff. Can't you just check for non-NULL or non-empty 'physpath' being passed in?
Jan 4 2018
Dec 31 2017
Dec 20 2017
Dec 6 2017
Heh. I've had a half-done, semi-related change sitting in one of my sandboxes for months.
Nov 27 2017
Nov 21 2017
Nov 16 2017
Is the name correct?
Nov 15 2017
Nov 1 2017
Oct 31 2017
@cem mentioned this today. It sounds like this was held up over concerns about the watchdog not getting petted while panicking; is that correct? I ran into the same problem recently, and I solved it by simply adding the following to /etc/ddb.conf:
Sep 20 2017
Sep 12 2017
Address dteske's comment by unconditionally setting "choice", and overriding it
for the interactive case.