- User Since
- Nov 20 2015, 9:23 AM (178 w, 19 h)
Wed, Apr 17
Fri, Apr 5
Wed, Apr 3
Tue, Apr 2
Fri, Mar 29
Thu, Mar 28
Wed, Mar 27
Mon, Mar 25
@avg ping? Please take a look at this in the next day or two. If I don't hear from you, I'll go ahead and submit, but I'd prefer to have your review.
Sat, Mar 23
Remove the reference to sysctl(3) from the individual descriptions.
As suggested, simplified the descriptions and added a pointer to the manpage.
Fri, Mar 22
Feb 19 2019
Yes, BIOS INT call will treat the 4KB device like if it was 512 byte based and hide the fact we are using multiples of 4KB disk access. This was observed by at least Apple's BIOS.
I'm not sure I understand the point of this. No matter what the GEOM is doing, the BIOS INT call interface doesn't support 4KB sectors...?
Jan 31 2019
Thanks for the feedback, @kib; take another look?
Update descriptions based on Kostik's feedback.
Jan 30 2019
Anyway I have no strong opinion about the prefix/naming, What do you prefer? sysctlmib.h/.c/.3/_* ?
Err, yes. Thanks @rgrimes.
Committed as r343583, but forgot to attach this review to the commit message. 🤦♂️
Jan 29 2019
Question: why "sysctlmif", as opposed to "sysctlmib"? Since this is about walking the MIB tree?
Jan 28 2019
Jan 15 2019
Jan 11 2019
Since 12 is already out and using 2, shouldn't that be <= 12?
Jan 3 2019
Dec 6 2018
Please create links for ext3fs.5 and ext4fs.5; in share/man/man5/Makefile, add these to the list:
MLINKS+= ext2fs.5 ext3fs.5 MLINKS+= ext2fs.5 ext4fs.5
Dec 3 2018
Nov 29 2018
Oct 4 2018
Aug 28 2018
I went ahead and moved the news.xml change as you suggested; I'm including it there for posterity.
Re-order change to news.xml to be in reverse-chronological order.
Aug 27 2018
Actually include the new key in the diff...
Aug 25 2018
LGTM from a purely technical standpoint. (I'm actively avoiding the larger policy discussion around drm(4) and drm2(4).)
Aug 1 2018
Jul 31 2018
Fix a typo in UPDATING: "jdedc_ts" -> "jedec_ts".
Jul 24 2018
Jul 21 2018
Looks good to me.
Jul 11 2018
... the numbers just happened to coincide here.
The summary says PAU06 is the combination of two already-supported chips: RT5372 radio and RT5392 MAC. But nothing in the diff mentions the latter chip.
Jun 29 2018
Jun 25 2018
Jun 22 2018
Jun 9 2018
Jun 8 2018
Jun 7 2018
I think this looks good now. Now you can point someone who actually knows `rc' at it. :-)
May 30 2018
May 29 2018
May 17 2018
It looks like the GENERIC configs that you're not updating are for ARM, RISC-V, and PPC64. Why are they being excluded?
Apr 10 2018
Oh, heh, I didn't even realize that this wasn't @ian, since he and I talked about this yesterday. :-)
I started but didn't finish reading through the manpage. My comments so far are in-line.
Mar 29 2018
Out of curiosity, why specifically for chown / chgrp?
Mar 24 2018
It would be good if you explained what a hook was, somewhere before the Exported functions section.
Mar 22 2018
# Much longer than sizeof(sc->slotid_str) % kenv hint.jedec_dimm.0.slotid DIMM0LONGERSTRING
As @cem pointed out, it's even easier to use strdup().
@imp correctly observed that since the buffer is allocated to fit, then
fully initialized, there's no need to use M_ZERO.