rpokala (Ravi Pokala)
User

Projects

User Details

User Since
Nov 20 2015, 9:23 AM (126 w, 5 d)

Recent Activity

Tue, Apr 10

rpokala updated subscribers of D15029: new utility usr.sbin/spi.

Oh, heh, I didn't even realize that this wasn't @ian, since he and I talked about this yesterday. :-)

Tue, Apr 10, 11:59 PM
rpokala added a comment to D15029: new utility usr.sbin/spi.

I started but didn't finish reading through the manpage. My comments so far are in-line.

Tue, Apr 10, 6:42 PM

Thu, Mar 29

rpokala added a comment to D14897: Fallback to copy if chown/chgrp would land in different filesystems.

Out of curiosity, why specifically for chown / chgrp?

Thu, Mar 29, 5:30 PM
rpokala committed rS331734: MFC 331345:.
MFC 331345:
Thu, Mar 29, 3:01 PM
rpokala committed rS331733: MFC 331345:.
MFC 331345:
Thu, Mar 29, 3:01 PM

Mar 24 2018

rpokala added a comment to D14815: lualoader: Add hook.lua(8) to tree.

It would be good if you explained what a hook was, somewhere before the Exported functions section.

Mar 24 2018, 12:35 AM

Mar 22 2018

rpokala committed rS331345: jedec_dimm: Use correct string length when populating sc->slotid_str.
jedec_dimm: Use correct string length when populating sc->slotid_str
Mar 22 2018, 6:31 AM
rpokala added a comment to D14790: jedec_dimm: Use correct string length when populating sc->slotid_str.
In D14790#311049, @cem wrote:

Feel free to spend a bunch of time documenting libkern if you want. It's definitely valuable and shouldn't be too hard. Mostly just tedious. Maybe a thin document that just defines all of the libc-alike aliases and gets linked in a million places would be enough to start.

Mar 22 2018, 6:14 AM
rpokala added a comment to D14790: jedec_dimm: Use correct string length when populating sc->slotid_str.
# Much longer than sizeof(sc->slotid_str)
% kenv hint.jedec_dimm.0.slotid
DIMM0LONGERSTRING
Mar 22 2018, 5:58 AM
rpokala updated the diff for D14790: jedec_dimm: Use correct string length when populating sc->slotid_str.

As @cem pointed out, it's even easier to use strdup().

Mar 22 2018, 5:51 AM
rpokala added inline comments to D14790: jedec_dimm: Use correct string length when populating sc->slotid_str.
Mar 22 2018, 2:52 AM
rpokala updated the diff for D14790: jedec_dimm: Use correct string length when populating sc->slotid_str.

@imp correctly observed that since the buffer is allocated to fit, then
fully initialized, there's no need to use M_ZERO.

Mar 22 2018, 1:19 AM
rpokala created D14790: jedec_dimm: Use correct string length when populating sc->slotid_str.
Mar 22 2018, 1:12 AM

Mar 9 2018

rpokala accepted D14569: Permit sysctl(8) to set an array of numeric values for a single node..
Mar 9 2018, 10:47 PM
rpokala committed rS330680: MFC r330304: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus.
MFC r330304: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus
Mar 9 2018, 2:55 AM
rpokala committed rS330679: MFC r330304: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus.
MFC r330304: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus
Mar 9 2018, 2:55 AM

Mar 7 2018

rpokala accepted D14604: Add CTASSERTs for where CTLFLAG_MPSAFE is redundant..

Looks fine to my relatively-untrained eye.

Mar 7 2018, 4:42 PM

Mar 3 2018

rpokala committed rS330304: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.
imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver
Mar 3 2018, 1:54 AM
rpokala closed D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.
Mar 3 2018, 1:54 AM
rpokala added a comment to D14569: Permit sysctl(8) to set an array of numeric values for a single node..

Modulo adding a comment, LGTM.

Mar 3 2018, 12:06 AM

Mar 2 2018

rpokala accepted D14479: Add core.lua(8), but do not add to distribution.
Mar 2 2018, 5:30 AM
rpokala accepted D14480: Add menu.lua(8), but do not add to distribution.
Mar 2 2018, 5:06 AM
rpokala added inline comments to D14479: Add core.lua(8), but do not add to distribution.
Mar 2 2018, 5:01 AM

Mar 1 2018

rpokala added a comment to D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.

@avg / @jhb : I think I've addressed everything you were concerned about -- modulo some personal style, which is still conformant with style(9).

Mar 1 2018, 8:34 PM
rpokala added inline comments to D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.
Mar 1 2018, 2:00 AM
rpokala updated the diff for D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.

Address a few more things @jhb mentioned.

Mar 1 2018, 2:00 AM
rpokala added inline comments to D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.
Mar 1 2018, 1:07 AM
rpokala added inline comments to D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.
Mar 1 2018, 1:00 AM
rpokala updated the diff for D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.

Call only bus_generic_attach(), but not bus_generic_probe(), from the attach
methods. This behaves properly for both pre-loading via loader.conf and loading
via kldload.

Mar 1 2018, 12:59 AM

Feb 28 2018

rpokala committed rS330109: MFC r329843:.
MFC r329843:
Feb 28 2018, 10:00 AM
rpokala committed rS330107: MFC r329843:.
MFC r329843:
Feb 28 2018, 10:00 AM
rpokala added a comment to D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.

At this point, it looks like the only outstanding issue is either adding device_probe_and_attach(), or confirming that it's not necessary. I'll try to do that tomorrow.

Feb 28 2018, 8:22 AM
rpokala added inline comments to D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.
Feb 28 2018, 2:37 AM
rpokala updated the diff for D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.

Address most of @avg's review comments.

Feb 28 2018, 2:31 AM
rpokala committed rS330093: MFC r329682:.
MFC r329682:
Feb 28 2018, 12:30 AM
rpokala committed rS330092: MFC r329682:.
MFC r329682:
Feb 28 2018, 12:30 AM
rpokala added inline comments to D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.
Feb 28 2018, 12:15 AM

Feb 27 2018

rpokala updated subscribers of D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.

Thanks for finding time for this! I'll address many of your comments and post an updated diff later today.

Feb 27 2018, 5:38 PM

Feb 23 2018

rpokala committed rS329871: Somehow r329870 disn't include the mergeinfo...?.
Somehow r329870 disn't include the mergeinfo...?
Feb 23 2018, 4:51 PM
rpokala committed rS329870: MFC r323508:.
MFC r323508:
Feb 23 2018, 4:47 PM
rpokala committed rS329869: MFC r323508:.
MFC r323508:
Feb 23 2018, 4:46 PM
rpokala added inline comments to D14479: Add core.lua(8), but do not add to distribution.
Feb 23 2018, 5:06 AM
rpokala added inline comments to D14480: Add menu.lua(8), but do not add to distribution.
Feb 23 2018, 4:51 AM
rpokala added inline comments to D14480: Add menu.lua(8), but do not add to distribution.
Feb 23 2018, 3:55 AM

Feb 22 2018

rpokala committed rS329843: jedec_dimm(4): report asset info and temperatures for DDR3 and DDR4 DIMMs.
jedec_dimm(4): report asset info and temperatures for DDR3 and DDR4 DIMMs
Feb 22 2018, 11:19 PM
rpokala closed D14392: jedec_dimm(4): report asset info and temperatures for DDR3 and DDR4 DIMMs.
Feb 22 2018, 11:19 PM
rpokala accepted D14476: libsa(3): Correct statement about FS Write-support, name change.

LGTM.

Feb 22 2018, 10:57 PM
rpokala committed rS329834: MFC r329295:.
MFC r329295:
Feb 22 2018, 7:40 PM
rpokala committed rS329833: MFC r329295:.
MFC r329295:
Feb 22 2018, 7:39 PM

Feb 21 2018

rpokala updated the diff for D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.

Remove some stray comments from the manpage.

Feb 21 2018, 2:29 AM
rpokala updated the diff for D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.

style(9) changes: Correct formatting of function prototypes and declarations, and re-order variables.

Feb 21 2018, 1:43 AM
rpokala committed rS329682: mountd: Return proper errno values in a few error paths.
mountd: Return proper errno values in a few error paths
Feb 21 2018, 12:19 AM
rpokala closed D14438: Return proper errno values in a few error paths..
Feb 21 2018, 12:19 AM

Feb 20 2018

rpokala updated subscribers of D14392: jedec_dimm(4): report asset info and temperatures for DDR3 and DDR4 DIMMs.
Feb 20 2018, 11:28 PM
rpokala updated the diff for D14392: jedec_dimm(4): report asset info and temperatures for DDR3 and DDR4 DIMMs.

Address some of @cem's review comments.

Feb 20 2018, 11:27 PM
rpokala updated subscribers of D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.
Feb 20 2018, 3:40 AM
rpokala created D14447: imcsmb(4): Intel integrated Memory Controller (iMC) SMBus controller driver.
Feb 20 2018, 3:39 AM

Feb 19 2018

rpokala created D14438: Return proper errno values in a few error paths..
Feb 19 2018, 5:09 PM

Feb 16 2018

rpokala added inline comments to D14402: PID Controlled page daemon.
Feb 16 2018, 9:17 PM
rpokala added a comment to D14381: mxge(4) should pass unhandled ioctls to ether_ioctl().

Well thats embarrassing. Thanks for the fix.

Feb 16 2018, 2:29 AM

Feb 15 2018

rpokala created D14392: jedec_dimm(4): report asset info and temperatures for DDR3 and DDR4 DIMMs.
Feb 15 2018, 11:05 PM
rpokala closed D14381: mxge(4) should pass unhandled ioctls to ether_ioctl().
Feb 15 2018, 3:22 AM
rpokala committed rS329295: mxge(4) should pass unhandled ioctls to ether_ioctl().
mxge(4) should pass unhandled ioctls to ether_ioctl()
Feb 15 2018, 3:22 AM
rpokala created D14381: mxge(4) should pass unhandled ioctls to ether_ioctl().
Feb 15 2018, 3:01 AM

Feb 8 2018

rpokala closed D14055: jedec_ts(4) is broken on stable/10.
Feb 8 2018, 9:24 AM
rpokala committed rS329015: jedec_ts(4) uses a sysctl format specifier of "IK4", to indicate that it.
jedec_ts(4) uses a sysctl format specifier of "IK4", to indicate that it
Feb 8 2018, 9:24 AM

Feb 6 2018

rpokala accepted D14231: Avoid find -s, use find | sort instead..
Feb 6 2018, 10:12 PM

Jan 31 2018

rpokala updated the diff for D14055: jedec_ts(4) is broken on stable/10.

Leading 8-space -> hard-tab. Whoops!

Jan 31 2018, 4:00 PM
rpokala updated the diff for D14055: jedec_ts(4) is broken on stable/10.

Use the obvious one-liner, which somehow escaped me at the time of the
original diff. Thanks, avg@!

Jan 31 2018, 3:16 PM
rpokala added inline comments to D14055: jedec_ts(4) is broken on stable/10.
Jan 31 2018, 3:13 PM

Jan 26 2018

rpokala archived P141 Is this license BSD-compatible?.
Jan 26 2018, 9:35 PM
rpokala created D14055: jedec_ts(4) is broken on stable/10.
Jan 26 2018, 12:39 AM

Jan 25 2018

rpokala added inline comments to D14022: NVMe emulation for bhyve (improved).
Jan 25 2018, 11:51 PM
rpokala accepted D14051: Remove K&R stuff: never use it in new code..
Jan 25 2018, 3:56 PM

Jan 19 2018

rpokala accepted D13975: Add info about c99 designationed initializers..
Jan 19 2018, 1:00 AM

Jan 10 2018

rpokala added a comment to P158 (An Untitled Masterwork).

A one-sentence description of what each of the functions does would be good too (i.e. expand ctz => Count Trailing Zeros, etc).

Jan 10 2018, 1:30 AM
rpokala added a comment to P158 (An Untitled Masterwork).

The kernel as a standalone target does not link against libgcc or libcompiler-rt. On platforms (e.g., MIPS and RISCV) that do not have a direct assembly implementation of the relevant builtin functions that zstd references, the compiler converts them into calls to the runtime library intrinsics. Since the kernel doesn't link against the libraries, this results in a failure to link the kernel.

Jan 10 2018, 1:29 AM
rpokala added inline comments to D13818: Create deprecation management functions..
Jan 10 2018, 1:24 AM
rpokala added a comment to P158 (An Untitled Masterwork).

A comment explaining why you're doing all this would be good.

Jan 10 2018, 1:13 AM
rpokala added a comment to D13818: Create deprecation management functions..

And of course the same comments for _gone_in_dev() as in _gone_in().

Jan 10 2018, 1:12 AM
rpokala added inline comments to D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.
Jan 10 2018, 1:04 AM
rpokala requested changes to D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.
Jan 10 2018, 12:09 AM

Jan 8 2018

rpokala added a comment to D13579: gnop(8): add the ability to set a nop provider's physical path.

I don't understand the G_NOP_PHYSPATH_PASSTHROUGH stuff. Can't you just check for non-NULL or non-empty 'physpath' being passed in?

Jan 8 2018, 6:57 PM

Jan 4 2018

rpokala added inline comments to D13770: Make it possible to re-evaluate cpu_features..
Jan 4 2018, 11:06 PM
rpokala added inline comments to D13759: Remove/Limit whole process swapout.
Jan 4 2018, 3:21 AM · committers

Dec 31 2017

rpokala added inline comments to D13682: Add memset_s(3) doc to memset(3) man page..
Dec 31 2017, 10:26 PM

Dec 20 2017

rpokala added inline comments to D13546: New pci device hints wiring..
Dec 20 2017, 2:06 AM

Dec 6 2017

rpokala accepted D13387: Define xpt_path_inq..

Heh. I've had a half-done, semi-related change sitting in one of my sandboxes for months.

Dec 6 2017, 5:12 PM

Nov 27 2017

rpokala added a watcher for NUMA: rpokala.
Nov 27 2017, 7:38 PM

Nov 21 2017

rpokala added inline comments to D13179: Add "Pull Request" to the devel/subversion commit template.
Nov 21 2017, 2:47 AM

Nov 16 2017

rpokala added a comment to D13086: Add chvgpio driver for gpio present of Intel z8000 series (Cherry View) SOC.

Is the name correct?

Nov 16 2017, 11:39 PM
rpokala added a comment to D13101: Add support for Zstd-compressed kernel and userspace dumps.
In D13101#272595, @cem wrote:

Switch off of a compression mode enumeration for userspace cores.

Nov 16 2017, 4:18 AM
rpokala added inline comments to D13101: Add support for Zstd-compressed kernel and userspace dumps.
Nov 16 2017, 3:26 AM

Nov 15 2017

rpokala added inline comments to D13101: Add support for Zstd-compressed kernel and userspace dumps.
Nov 15 2017, 11:39 PM

Nov 1 2017

rpokala added a comment to D8244: KCS thread hogs the CPU.

@cem mentioned this today. It sounds like this was held up over concerns about the watchdog not getting petted while panicking; is that correct? I ran into the same problem recently, and I solved it by simply adding the following to /etc/ddb.conf:

script kdb.enter.default=call db_watchdog

That stops the watchdog when entering the debugger, which works for both interactive debug sessions and dumping core.

Additionally, r325024 included a change to continue patting the watchdog while dumping core.

If debugger/dump issues were preventing this from landing, I think we're past those now.

Nov 1 2017, 1:42 AM

Oct 31 2017

rpokala added a comment to D8244: KCS thread hogs the CPU.

@cem mentioned this today. It sounds like this was held up over concerns about the watchdog not getting petted while panicking; is that correct? I ran into the same problem recently, and I solved it by simply adding the following to /etc/ddb.conf:

Oct 31 2017, 2:29 AM

Sep 20 2017

rpokala created P141 Is this license BSD-compatible?.
Sep 20 2017, 11:42 PM

Sep 12 2017

rpokala committed rS323508: When doing a non-interactive installation, don't display an interactive.
When doing a non-interactive installation, don't display an interactive
Sep 12 2017, 10:19 PM
rpokala closed D12346: Don't complain about missing mountpoints for scripted installations..
Sep 12 2017, 10:19 PM
rpokala updated the diff for D12346: Don't complain about missing mountpoints for scripted installations..

Address dteske's comment by unconditionally setting "choice", and overriding it
for the interactive case.

Sep 12 2017, 9:57 PM