Page MenuHomeFreeBSD

rpokala (Ravi Pokala)
User

Projects

User Details

User Since
Nov 20 2015, 9:23 AM (222 w, 3 d)

Recent Activity

Sun, Feb 23

rpokala accepted D23714: Add a manual page for smbios(4).
Sun, Feb 23, 6:18 PM

Mon, Feb 17

rpokala added inline comments to D23714: Add a manual page for smbios(4).
Mon, Feb 17, 7:47 PM

Jan 24 2020

rpokala added inline comments to D23336: stdio: provide _unlocked variants of fflush, fputc, fputs, fread, fwrite.
Jan 24 2020, 6:27 PM

Jan 23 2020

rpokala added inline comments to D23336: stdio: provide _unlocked variants of fflush, fputc, fputs, fread, fwrite.
Jan 23 2020, 7:43 PM

Jan 18 2020

rpokala added a comment to D23247: Provide O_SEARCH.

The manpage should explain what "search only" means.

Jan 18 2020, 7:31 AM

Jan 16 2020

rpokala added inline comments to D12773: Manage thread signal mask using a shared word, instead of syscall..
Jan 16 2020, 3:21 AM

Jan 15 2020

rpokala added inline comments to D23165: bhyve(8): Add VM Generation Counter ACPI device.
Jan 15 2020, 6:46 PM
rpokala added inline comments to D23174: Add qsort_s(3).
Jan 15 2020, 1:13 AM
rpokala added a comment to D23165: bhyve(8): Add VM Generation Counter ACPI device.

So, bhyve literally generates the ACPI source text, and then does system(iasl) as part of startup? "Neat!"

Jan 15 2020, 12:36 AM

Jan 14 2020

rpokala added inline comments to D12773: Manage thread signal mask using a shared word, instead of syscall..
Jan 14 2020, 2:32 AM

Jan 10 2020

rpokala added inline comments to D23129: Small tweak to the default behavior of shutdown -c.
Jan 10 2020, 9:35 PM

Dec 13 2019

rpokala added inline comments to D22792: Build pxeboot files for all interpreters..
Dec 13 2019, 8:15 PM
rpokala added a comment to D22792: Build pxeboot files for all interpreters..

In any case, I will take another swing at this, using a Makefile.inc as @imp suggested.

Dec 13 2019, 4:06 PM
rpokala added a comment to D22792: Build pxeboot files for all interpreters..
In D22792#499018, @imp wrote:

You should rename btxldr/Makefile to be btxldr/Makefile.inc
You should create a new btxldr/Makefile that (1) installs btdldr.8 and (2) create a symlink to btxldr from the default interpreter.

Dec 13 2019, 4:05 PM
rpokala added a comment to D22792: Build pxeboot files for all interpreters..

I will be the first to admit that this is somewhat hackish; if someone can suggest a better way, I'm all for it.

Dec 13 2019, 7:13 AM
rpokala created D22792: Build pxeboot files for all interpreters..
Dec 13 2019, 7:10 AM

Dec 6 2019

rpokala added inline comments to D22715: vfs: introduce v_irflag and make v_type smaller.
Dec 6 2019, 11:59 PM

Dec 3 2019

rpokala committed rS355368: MFC r355006:.
MFC r355006:
Dec 3 2019, 10:54 PM
rpokala committed rS355367: MFC r354673:.
MFC r354673:
Dec 3 2019, 10:54 PM
rpokala committed rS355366: MFC r343583:.
MFC r343583:
Dec 3 2019, 10:54 PM
rpokala committed rS355365: MFC r355006:.
MFC r355006:
Dec 3 2019, 10:53 PM
rpokala committed rS355364: MFC r354673:.
MFC r354673:
Dec 3 2019, 10:53 PM
rpokala committed rS355363: MFC r354102:.
MFC r354102:
Dec 3 2019, 10:51 PM
rpokala committed rS355362: MFC r343583:.
MFC r343583:
Dec 3 2019, 10:49 PM

Nov 22 2019

rpokala closed D22474: Add option to run rpc.{lockd,statd} in the foreground..
Nov 22 2019, 4:53 PM
rpokala committed rS355006: Add and document options to allow rpc.lockd and rpc.statd to run in the.
Add and document options to allow rpc.lockd and rpc.statd to run in the
Nov 22 2019, 4:53 PM
rpokala updated the diff for D22474: Add option to run rpc.{lockd,statd} in the foreground..

Split lines in the manpages at the start of new sentences. Thanks igor(1)!

Nov 22 2019, 4:38 PM
rpokala added a comment to D22474: Add option to run rpc.{lockd,statd} in the foreground..
In D22474#491849, @imp wrote:

Looks good to me. Other commands use different flags to run in foreground, though. IT's inconsistent...

Nov 22 2019, 12:19 AM

Nov 21 2019

rpokala created D22474: Add option to run rpc.{lockd,statd} in the foreground..
Nov 21 2019, 5:21 AM

Nov 13 2019

rpokala committed rS354673: Logging improvements to loader::nfs.
Logging improvements to loader::nfs
Nov 13 2019, 3:57 AM
rpokala closed D22346: Logging improvements to loader::nfs.
Nov 13 2019, 3:57 AM
rpokala created D22346: Logging improvements to loader::nfs.
Nov 13 2019, 3:48 AM
rpokala abandoned D22345: Logging improvements to loader::nfs.

Argh. When I tried to fix some tabbing, I accidentally added a bunch of unrelated stuff.

Nov 13 2019, 3:47 AM
rpokala updated the diff for D22345: Logging improvements to loader::nfs.

Whoops, let some soft-tabs sneak in there! <facepalm>

Nov 13 2019, 3:46 AM
rpokala created D22345: Logging improvements to loader::nfs.
Nov 13 2019, 3:40 AM

Nov 10 2019

rpokala accepted D22271: Create /etc/os-release file..
Nov 10 2019, 8:06 AM

Nov 7 2019

rpokala added a comment to D22271: Create /etc/os-release file..

and is what the
sysutil/os-release port.

Nov 7 2019, 9:36 PM

Oct 25 2019

rpokala committed rS354102: Args for buf_track() might be unused.
Args for buf_track() might be unused
Oct 25 2019, 9:32 PM

Oct 10 2019

rpokala added a comment to D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.

Don't forget a manpage. :-)

Oct 10 2019, 6:10 PM

Sep 16 2019

rpokala added a comment to D20477: Introduce stats(3).
Sep 16 2019, 12:34 AM

Sep 14 2019

rpokala added a comment to D21660: Ask sync(8) to sync multiple times.

My understanding of the "old wives tale" was not sync()ing three times, but actually *typing* sync<enter> three times; by the time you finished typing the third one, any background operations initiated by the first one would have completed.

Sep 14 2019, 8:43 PM

Sep 10 2019

rpokala added inline comments to D21593: Add an option to gnop to allow rejecting I/O after allowing some through..
Sep 10 2019, 8:37 PM

Aug 23 2019

rpokala added inline comments to D21383: Add VMD support to FreeBSD.
Aug 23 2019, 7:51 PM

Aug 15 2019

D21265: fusefs: fix conditional from r351061 is now accepted and ready to land.

LGTM, thanks for the fast turn-around.

Aug 15 2019, 4:36 AM

Jul 30 2019

rpokala added a comment to D21111: beinstall.sh: Use bectl instead of beadm by default.

I second @bcr's manpages comments. Otherwise LGTM.

Jul 30 2019, 9:36 PM

Jul 24 2019

rpokala added inline comments to D21034: improve swapon comments.
Jul 24 2019, 6:03 AM

Jul 18 2019

D20988: Provide new tunable hw.nvme.verbose_cmd_dump is now accepted and ready to land.

SHIP IT!

Jul 18 2019, 9:34 PM
rpokala added a comment to D20983: Sort & dedupe getopt flags for daemon.

Now this includes parts of D20969 😕

Jul 18 2019, 4:40 PM
D20983: Sort & dedupe getopt flags for daemon now requires changes to proceed.

In addition to fixing the getopt() line, please upload a full diff, as described on the FreeBSD wiki: https://wiki.freebsd.org/action/show/Phabricator#Create_a_Revision_via_Web_Interface

Jul 18 2019, 5:18 AM
rpokala added inline comments to D20969: Add option to set umask before starting child process.
Jul 18 2019, 3:07 AM
D17102: Add build-time option to boot0sio to reset terminal is now accepted and ready to land.

LGTM, but I defer to @imp. Oh, and @kevans did a lot of stuff related to loader output as part of LuaLoader, so you might want to get his feedback as well.

Jul 18 2019, 2:47 AM

Jul 16 2019

rpokala added inline comments to D17102: Add build-time option to boot0sio to reset terminal.
Jul 16 2019, 4:19 PM

Jul 15 2019

D20950: Implement a devtype command. is now accepted and ready to land.

Looks reasonable to my not-very-CAM-savvy eyes.

Jul 15 2019, 9:41 PM
rpokala added inline comments to D20950: Implement a devtype command..
Jul 15 2019, 8:57 PM

Jun 17 2019

rpokala added inline comments to D20678: Changes to allow camcontrol to use cached data more often.
Jun 17 2019, 8:45 PM

May 29 2019

rpokala committed rS348376: Add bits related to SANITIZE, SED, and form-factor to (struct ata_params).
Add bits related to SANITIZE, SED, and form-factor to (struct ata_params)
May 29 2019, 11:50 PM
rpokala closed D20455: Add bits related to SANITIZE, SED, and form-factor to (struct ata_params).
May 29 2019, 11:50 PM
rpokala created D20455: Add bits related to SANITIZE, SED, and form-factor to (struct ata_params).
May 29 2019, 5:47 AM

May 21 2019

rpokala added inline comments to D20326: Expose the buildid hash through sysctl.
May 21 2019, 4:45 PM

May 20 2019

rpokala added inline comments to D20326: Expose the buildid hash through sysctl.
May 20 2019, 9:07 PM

Apr 25 2019

rpokala added a comment to D20054: Document the UEFI boot loading process.

boot1.efi.8 needs to mention where boot1.efi lives on disk. (/efi/boot/boot${ARCH}.efi, right?)

Apr 25 2019, 5:24 PM

Apr 17 2019

rpokala added inline comments to D19944: random(4): Restore availability tradeoff prior to r346250.
Apr 17 2019, 10:28 PM

Apr 5 2019

rpokala added a comment to D19827: aac(4): Add subvendor / subdevice to MODULE_PNP_INFO()'s descriptor_string.
In D19827#425235, @imp wrote:

I specifically allowed those duplicates when I was originally reviewing this change....

Apr 5 2019, 5:31 AM
rpokala created D19827: aac(4): Add subvendor / subdevice to MODULE_PNP_INFO()'s descriptor_string.
Apr 5 2019, 4:50 AM

Apr 3 2019

rpokala committed rS345838: MFC r345611:.
MFC r345611:
Apr 3 2019, 6:37 AM
rpokala committed rS345837: MFC r345611:.
MFC r345611:
Apr 3 2019, 6:37 AM
rpokala committed rS345836: MFC r345611:.
MFC r345611:
Apr 3 2019, 6:36 AM
rpokala committed rS345827: MFC r345457:.
MFC r345457:
Apr 3 2019, 3:31 AM
rpokala committed rS345826: MFC r345457:.
MFC r345457:
Apr 3 2019, 3:30 AM

Apr 2 2019

rpokala added inline comments to D19799: rewrite of intro(4) manpage.
Apr 2 2019, 9:52 PM · docs
rpokala added inline comments to D19799: rewrite of intro(4) manpage.
Apr 2 2019, 9:17 PM · docs

Mar 29 2019

rpokala committed rS345668: MFC r339683:.
MFC r339683:
Mar 29 2019, 1:32 AM

Mar 28 2019

rpokala committed rS345663: MFC r339683:.
MFC r339683:
Mar 28 2019, 10:19 PM

Mar 27 2019

rpokala committed rS345611: Teach jedec_dimm(4) to be more forgiving of non-fatal errors..
Teach jedec_dimm(4) to be more forgiving of non-fatal errors.
Mar 27 2019, 9:50 PM
rpokala closed D19681: Teach jedec_dimm(4) to be more forgiving of non-fatal errors..
Mar 27 2019, 9:50 PM

Mar 25 2019

rpokala added a comment to D19681: Teach jedec_dimm(4) to be more forgiving of non-fatal errors..

@avg ping? Please take a look at this in the next day or two. If I don't hear from you, I'll go ahead and submit, but I'd prefer to have your review.

Mar 25 2019, 11:25 PM

Mar 23 2019

rpokala committed rS345457: Add descriptions for sysctls in kern_mib.c and sysctl.3 which lack them..
Add descriptions for sysctls in kern_mib.c and sysctl.3 which lack them.
Mar 23 2019, 7:53 PM
rpokala closed D19007: Add descriptions for sysctls in kern_mib.c which lack them..
Mar 23 2019, 7:53 PM
rpokala updated the diff for D19007: Add descriptions for sysctls in kern_mib.c which lack them..

Remove the reference to sysctl(3) from the individual descriptions.

Mar 23 2019, 6:36 PM
rpokala updated the diff for D19007: Add descriptions for sysctls in kern_mib.c which lack them..

As suggested, simplified the descriptions and added a pointer to the manpage.

Mar 23 2019, 3:03 AM

Mar 22 2019

rpokala created D19681: Teach jedec_dimm(4) to be more forgiving of non-fatal errors..
Mar 22 2019, 6:39 PM

Feb 19 2019

rpokala added a comment to D19245: Add support for legacy 512-byte block size MBRs on 4K block size disks.

Yes, BIOS INT call will treat the 4KB device like if it was 512 byte based and hide the fact we are using multiples of 4KB disk access. This was observed by at least Apple's BIOS.

Feb 19 2019, 10:37 PM
rpokala added a comment to D19245: Add support for legacy 512-byte block size MBRs on 4K block size disks.

I'm not sure I understand the point of this. No matter what the GEOM is doing, the BIOS INT call interface doesn't support 4KB sectors...?

Feb 19 2019, 10:04 PM

Jan 31 2019

rpokala added a comment to D19007: Add descriptions for sysctls in kern_mib.c which lack them..

Thanks for the feedback, @kib; take another look?

Jan 31 2019, 3:10 AM
rpokala updated the diff for D19007: Add descriptions for sysctls in kern_mib.c which lack them..

Update descriptions based on Kostik's feedback.

Jan 31 2019, 3:09 AM

Jan 30 2019

rpokala added a comment to D18696: sysctlmibinfo(3).

Anyway I have no strong opinion about the prefix/naming, What do you prefer? sysctlmib.h/.c/.3/_* ?

Jan 30 2019, 8:33 PM
rpokala added a comment to D19029: Remove unecessary "All rights reserved" from files under my or Panasas's copyright..

Err, yes. Thanks @rgrimes.

Jan 30 2019, 5:18 PM
rpokala closed D19029: Remove unecessary "All rights reserved" from files under my or Panasas's copyright..

Committed as r343583, but forgot to attach this review to the commit message. 🤦‍♂️

Jan 30 2019, 5:14 PM
rpokala committed rS343583: Remove unecessary "All rights reserved" from files under my or Panasas's.
Remove unecessary "All rights reserved" from files under my or Panasas's
Jan 30 2019, 4:55 PM
rpokala retitled D19029: Remove unecessary "All rights reserved" from files under my or Panasas's copyright. from Remove unecessary "All rights reserved" from files under my or Panasas's copyright. The files related to jedec_dimm(4) also bear avg@'s copyright; he approves of this change as well. to Remove unecessary "All rights reserved" from files under my or Panasas's copyright..
Jan 30 2019, 9:13 AM
rpokala created D19029: Remove unecessary "All rights reserved" from files under my or Panasas's copyright..
Jan 30 2019, 8:59 AM

Jan 29 2019

rpokala added a comment to D18696: sysctlmibinfo(3).

Question: why "sysctlmif", as opposed to "sysctlmib"? Since this is about walking the MIB tree?

Jan 29 2019, 2:05 AM

Jan 28 2019

rpokala created D19007: Add descriptions for sysctls in kern_mib.c which lack them..
Jan 28 2019, 9:51 PM

Jan 15 2019

rpokala added inline comments to D18841: New port: sysutils/ltfs: Reference implementation of LTFS for stand alone tape drive.
Jan 15 2019, 3:21 PM

Jan 11 2019

rpokala added a comment to D17930: clang: default to DWARF 4 as of FreeBSD 12.

Since 12 is already out and using 2, shouldn't that be <= 12?

Jan 11 2019, 9:01 PM

Jan 3 2019

rpokala added a comment to D18708: add instructions for SMTP access setup.

FWIW, LGTM.

Jan 3 2019, 7:00 AM

Dec 6 2018

rpokala added a comment to D18445: Update ext2fs(5) man page.

Please create links for ext3fs.5 and ext4fs.5; in share/man/man5/Makefile, add these to the list:

MLINKS+= ext2fs.5 ext3fs.5
MLINKS+= ext2fs.5 ext4fs.5
Dec 6 2018, 1:39 AM

Dec 3 2018

rpokala added inline comments to D17947: Rework UEFI ESP generation.
Dec 3 2018, 11:54 PM

Nov 29 2018

rpokala added inline comments to D18380: Fix a number of style issues with trim(8).
Nov 29 2018, 7:11 PM

Oct 4 2018

rpokala added inline comments to D16092: Committer guide: add note about private discussions.
Oct 4 2018, 10:01 PM