Page MenuHomeFreeBSD

rpokala (Ravi Pokala)
User

Projects

User Details

User Since
Nov 20 2015, 9:23 AM (314 w, 2 d)

Recent Activity

Fri, Nov 12

rpokala added inline comments to D32954: Retire non-NEW_PCIB code and remove config option.
Fri, Nov 12, 2:49 AM
rpokala added a comment to D32954: Retire non-NEW_PCIB code and remove config option.

... leaving just arm (which still enables it for GENERIC and TEGRA124) and mips
(which still enables it for RT2880_FDT and various std.mediatek-using kernel
configs), ...

Fri, Nov 12, 2:42 AM

Wed, Nov 10

rpokala added inline comments to D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.
Wed, Nov 10, 6:25 AM

Mon, Nov 8

rpokala added inline comments to D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.
Mon, Nov 8, 7:11 PM

Fri, Nov 5

rpokala added inline comments to D32832: nvme: improve selftest option for nvmecontrol.
Fri, Nov 5, 2:52 AM

Thu, Nov 4

rpokala added inline comments to D32832: nvme: improve selftest option for nvmecontrol.
Thu, Nov 4, 6:57 PM

Sep 10 2021

rpokala added inline comments to D29543: license: Create a license guideline document.
Sep 10 2021, 9:06 PM

Jun 13 2021

rpokala added a comment to D30751: linux(4): Get rid of Linuxulator's kernel build options..

To make sure I understand this: this change is to no longer allow Linuxulator to be built into the kernel, and only allow it to be built as a module?

Jun 13 2021, 9:23 PM

May 31 2021

rpokala added inline comments to D21886: Add USB support for location based device unit numbers.
May 31 2021, 10:58 PM

May 13 2021

rpokala added a comment to D30254: style: tweak tab after #define advice.

Can we please encourage per-file or per-group consistency? Patches are annoying to read when the a group of #defines randomly switches between styles.

May 13 2021, 10:08 PM
rpokala added inline comments to D17083: Alter the prototype of qsort_r(3) to match glibc..
May 13 2021, 6:56 PM

May 5 2021

rpokala accepted D30116: kern: clarify boot time.

Thanks for the changes!

May 5 2021, 6:48 AM
rpokala added inline comments to D30116: kern: clarify boot time.
May 5 2021, 6:21 AM
rpokala added inline comments to D30116: kern: clarify boot time.
May 5 2021, 6:06 AM
rpokala added inline comments to D30116: kern: clarify boot time.
May 5 2021, 5:39 AM
rpokala added a comment to D30116: kern: clarify boot time.
In D30116#676007, @phk wrote:

I would go with:

"Estimated System Boot time. When the clock is set, this is recalculated as new_time - uptime"

I think the "Estimated" is important, because neither clock-frequency tweaks, up to half a millisecond per second, nor leap-seconds are accounted for.

May 5 2021, 5:33 AM
rpokala added inline comments to D30116: kern: clarify boot time.
May 5 2021, 3:34 AM
rpokala added inline comments to D30116: kern: clarify boot time.
May 5 2021, 2:32 AM

May 2 2021

rpokala added inline comments to D30050: Adds uuid validation to bhyve(8) arg parsing.
May 2 2021, 9:54 PM

Apr 26 2021

rpokala added inline comments to D29992: camcontrol(8): add "smart" command.
Apr 26 2021, 5:45 PM
rpokala added inline comments to D29917: BeFS support for fstyp command.
Apr 26 2021, 2:58 AM

Apr 23 2021

rpokala added inline comments to D29937: newbus: Move from bus_child_{pnpinfo,location}_src to bus_child_{pnpinfo,location} with sbuf.
Apr 23 2021, 12:19 AM

Apr 20 2021

rpokala accepted D29871: fix leak in lib/libc/posix1e/acl_support_nfs4.c.

@freqlabs requested a second set of eyes; LGTM

Apr 20 2021, 7:30 PM

Apr 10 2021

rpokala accepted D29676: Rename struct device to struct _device.

LGTM, FWIW.

Apr 10 2021, 8:36 PM
rpokala added inline comments to D29676: Rename struct device to struct _device.
Apr 10 2021, 2:19 AM

Apr 7 2021

rpokala added a comment to D29531: Add kvmclock timecounter support to FreeBSD.

Thanks!

Apr 7 2021, 11:06 PM
rpokala added a comment to D29531: Add kvmclock timecounter support to FreeBSD.

As for the copyright, it was originally there but got removed after @imp said it was no longer custom.

Apr 7 2021, 10:56 PM
rpokala added a comment to D29531: Add kvmclock timecounter support to FreeBSD.

In addition to the copyright thing mentioned inline, a question: This is for FreeBSD VMs running under Linux Kernel-based Virtual Machine, correct? If that's the case, for clarity, please change the

# KVM support

line in in the GENERIC and NOTES files to something like

# Linux KVM support
Apr 7 2021, 10:31 PM

Apr 6 2021

rpokala accepted D29591: gptboot.efi: Add man page.
Apr 6 2021, 5:00 AM
rpokala added inline comments to D29591: gptboot.efi: Add man page.
Apr 6 2021, 4:35 AM

Apr 5 2021

rpokala added inline comments to D29591: gptboot.efi: Add man page.
Apr 5 2021, 11:20 PM
rpokala added a comment to D29276: smbios: support getting address from EFI.

Code LGTM. ==@ambrisko WRT testing on legacy BIOS platforms.

Apr 5 2021, 10:16 PM
rpokala added inline comments to D29591: gptboot.efi: Add man page.
Apr 5 2021, 8:01 PM
rpokala added inline comments to D29591: gptboot.efi: Add man page.
Apr 5 2021, 7:25 PM

Apr 3 2021

rpokala added inline comments to D29479: x11: document the latest best advice about graphics.
Apr 3 2021, 12:13 AM

Mar 27 2021

rpokala added inline comments to D29437: Start pre-commit best practices guide.
Mar 27 2021, 5:03 AM

Mar 23 2021

rpokala accepted D29182: libc: Add get_current_dir_name().

Thanks for the review. I'll make the suggested manual changes later.

This bothers me a whole lot. Did you really have to add a swipe on Linux or glibc? I wonder where exactly I have given the impression that my justification to want to import get_current_dir_name is "because Linux".

Mar 23 2021, 6:39 PM
rpokala added inline comments to D29380: Fix scripted installations on EFI systems for 13.0.
Mar 23 2021, 12:20 AM

Mar 22 2021

rpokala added a comment to D29182: libc: Add get_current_dir_name().

This appears to conform to the description of the Linux version:

Mar 22 2021, 8:33 PM

Mar 15 2021

rpokala added a comment to D29277: smbios: expose useful DMI information as sysctl and dmesg.

Most of that info is already available through kenv(1) and/or kenv(2):

[threepio:~] rpokala% kenv | grep smbios
hint.smbios.0.mem="0xf05b0"
smbios.bios.reldate="11/22/2019"
smbios.bios.vendor="American Megatrends Inc."
smbios.bios.version="2.1"
smbios.chassis.maker="Supermicro"
smbios.chassis.serial="0123456789"
smbios.chassis.tag="To Be Filled By O.E.M."
smbios.chassis.type="Main Server Chassis"
smbios.chassis.version="0123456789"
smbios.memory.enabled="33554432"
smbios.planar.location="To be filled by O.E.M."
smbios.planar.maker="Supermicro"
smbios.planar.product="X10SDV-TLN4F"
smbios.planar.serial="ZM15AS030025"
smbios.planar.tag="To be filled by O.E.M."
smbios.planar.version="1.02"
smbios.socket.enabled="1"
smbios.socket.populated="1"
smbios.system.family="To be filled by O.E.M."
smbios.system.maker="Supermicro"
smbios.system.product="Super Server"
smbios.system.serial="0123456789"
smbios.system.sku="To be filled by O.E.M."
smbios.system.uuid="00000000-0000-0000-0000-0cc47a7c0a92"
smbios.system.version="0123456789"
smbios.version="2.7"
Mar 15 2021, 9:20 PM
rpokala updated subscribers of D29276: smbios: support getting address from EFI.

This looks grossly correct to me, but it's been a long time since I've thought about this stuff. IIRC @ambrisko did some stuff with SMBIOS a ways back; Doug?

Mar 15 2021, 9:10 PM
rpokala added a comment to D29270: ipmi,smbios: move smbios_walk_table to smbios.h.

This function will be used for exposing DMI info as sysctls in the smbios module (in an upcoming review).

Mar 15 2021, 9:05 PM

Mar 12 2021

rpokala accepted D29215: Document that uma_zfree_pcpu() allows NULL now.
Mar 12 2021, 3:11 AM

Mar 11 2021

rpokala added inline comments to D29215: Document that uma_zfree_pcpu() allows NULL now.
Mar 11 2021, 7:31 PM
rpokala accepted D29139: share/man/man9/pwmbus.9 fix types in arguments.

LGTM. Remember to bump .Dd when you commit.

Mar 11 2021, 8:27 AM

Mar 10 2021

rpokala accepted D29210: cam: Run all XPT_ASYNC ccbs in a dedicated thread.

LGTM, for whatever little that's worth.

Mar 10 2021, 11:28 PM
rpokala requested changes to D29139: share/man/man9/pwmbus.9 fix types in arguments.
Mar 10 2021, 3:45 AM

Mar 9 2021

rpokala added a comment to D29163: cam: use disk_alloc_nowait.

Can drivers are created in a callback in xpt_done_td.

Mar 9 2021, 9:00 PM
rpokala added inline comments to D29161: geom: create disk_free() to free uninitialized disks.
Mar 9 2021, 8:59 PM

Mar 2 2021

rpokala added a comment to D29018: camcontrol: depop command.

Document the new depop command.

Implement and document the new "depop" command.
Mar 2 2021, 11:51 PM

Feb 28 2021

rpokala accepted D28940: usr.sbin/newsyslog: Implement E newsyslog.conf entry flag.
Feb 28 2021, 12:17 AM

Feb 27 2021

rpokala requested changes to D28940: usr.sbin/newsyslog: Implement E newsyslog.conf entry flag.
Feb 27 2021, 2:49 AM

Feb 25 2021

rpokala accepted D28922: pmap: Fix largemap restart checks in the kernel_maps sysctl handler.

@rpokala could you please see if this patch fixes the hang you see when reading vm.pmap.kernel_maps while an nvdimm is mapped?

Feb 25 2021, 11:12 PM

Feb 21 2021

rpokala accepted D28818: virtio_pci_legacy: Allow memory space for configuration.
In D28818#645488, @khng300_gmail.com wrote:

The old virtio_pci.c code handling legacy Virtio is ported over to
virtio_pci_legacy.c in FreeBSD 13 and -CURRENT

Feb 21 2021, 8:17 PM
rpokala committed R10:49318a0aac64: nvdimm(4): Export NVDIMM health flags via sysctl (authored by rpokala).
nvdimm(4): Export NVDIMM health flags via sysctl
Feb 21 2021, 1:50 AM
rpokala committed R10:ea5a304c734f: nvdimm(4): Export NVDIMM health flags via sysctl (authored by rpokala).
nvdimm(4): Export NVDIMM health flags via sysctl
Feb 21 2021, 12:51 AM

Feb 20 2021

rpokala added a comment to D28818: virtio_pci_legacy: Allow memory space for configuration.

D26915 is marked as superseded by this one, but that one was for virtio_pci.c, and this one is for virtio_pci_legacy.c...?

Feb 20 2021, 10:31 PM

Feb 19 2021

rpokala committed R10:a069809d907d: Ignore generated LINT files (authored by rpokala).
Ignore generated LINT files
Feb 19 2021, 12:15 AM
rpokala committed R10:0adeb3b23e04: Ignore generated LINT files (authored by rpokala).
Ignore generated LINT files
Feb 19 2021, 12:13 AM

Feb 18 2021

rpokala closed D28700: nvdimm(4): Export NVDIMM health flags via sysctl.
Feb 18 2021, 11:31 PM
rpokala committed R10:bdde49b7c723: nvdimm(4): Export NVDIMM health flags via sysctl (authored by rpokala).
nvdimm(4): Export NVDIMM health flags via sysctl
Feb 18 2021, 11:29 PM
rpokala accepted D28738: smbios: Move smbios driver out from x86 machdep code.

LGTM, FWIW.

Feb 18 2021, 6:54 PM
rpokala added a comment to D28738: smbios: Move smbios driver out from x86 machdep code.

If the intention is to support smbios(4) on non-x86, shouldn't it be added to a non-x86 KERNCONF file?

That is done here: https://reviews.freebsd.org/D28744

Feb 18 2021, 6:52 PM
rpokala updated the diff for D28700: nvdimm(4): Export NVDIMM health flags via sysctl.

Address review comments from @cem

Feb 18 2021, 2:15 AM
rpokala added inline comments to D28700: nvdimm(4): Export NVDIMM health flags via sysctl.
Feb 18 2021, 2:03 AM

Feb 17 2021

rpokala updated the diff for D28700: nvdimm(4): Export NVDIMM health flags via sysctl.

Address review comments from @cem

Feb 17 2021, 11:56 PM
rpokala added inline comments to D28700: nvdimm(4): Export NVDIMM health flags via sysctl.
Feb 17 2021, 11:00 PM
rpokala added a comment to D28738: smbios: Move smbios driver out from x86 machdep code.

If the intention is to support smbios(4) on non-x86, shouldn't it be added to a non-x86 KERNCONF file?

Feb 17 2021, 10:02 PM
rpokala accepted D28745: ipmi: Add smbus and pci ipmi types to aarch64 builds.
Feb 17 2021, 9:55 PM
rpokala added a comment to D28700: nvdimm(4): Export NVDIMM health flags via sysctl.
In D28700#642544, @mav wrote:

In my driver in TrueNAS I am printing this in dmesg if anything other than ACPI_NFIT_MEM_HEALTH_ENABLED is set. Everything read from NFIT applies more to boot state, rather than run-time.

Feb 17 2021, 2:56 AM
rpokala updated the diff for D28700: nvdimm(4): Export NVDIMM health flags via sysctl.

Address review comments from @mav

Feb 17 2021, 2:56 AM
rpokala added inline comments to D28720: Simplify and update the hardware notes for x86 architectures..
Feb 17 2021, 2:29 AM

Feb 16 2021

rpokala updated the test plan for D28700: nvdimm(4): Export NVDIMM health flags via sysctl.
Feb 16 2021, 9:03 AM
rpokala requested review of D28700: nvdimm(4): Export NVDIMM health flags via sysctl.
Feb 16 2021, 9:03 AM

Feb 11 2021

rpokala committed R10:40c1f835412d: nvdimm: Fix error path mis-free (authored by cem).
nvdimm: Fix error path mis-free
Feb 11 2021, 5:16 AM
rpokala added a comment to D28573: fmtree: prepare for removal.

It probably goes without saying, but please confirm that contrib/mtree/mtree.8 is what's getting installed as mtree.8, not usr.sbin/fmtree/mtree.8.

Feb 11 2021, 1:49 AM

Feb 8 2021

rpokala added inline comments to D28519: git-arc(1): Add manual page.
Feb 8 2021, 11:58 PM
rpokala added inline comments to D28519: git-arc(1): Add manual page.
Feb 8 2021, 9:50 PM

Feb 4 2021

rpokala added inline comments to D28474: Convert vendor imports to git instructions.
Feb 4 2021, 1:22 AM

Jan 28 2021

rpokala added inline comments to D27194: Add vnode_pager_purge_range(9) KPI.
Jan 28 2021, 12:46 AM

Jan 26 2021

rpokala added a comment to D27194: Add vnode_pager_purge_range(9) KPI.
In D27194#634238, @khng300_gmail.com wrote:

Don't forget a manpage.

Seems like a manpage for vnode_pager_setsize(9) is also missing. Should I do it all together or separate the manpage into another differential?

Jan 26 2021, 6:14 PM
rpokala added a comment to D27194: Add vnode_pager_purge_range(9) KPI.

Don't forget a manpage.

Jan 26 2021, 3:32 AM

Jan 21 2021

rpokala accepted D28247: Introduce SIOCGIFDNAME to get the interface device name.

LGTM

Jan 21 2021, 7:07 AM
rpokala added inline comments to D28251: Explain the newfs naming convention.
Jan 21 2021, 6:16 AM

Jan 20 2021

rpokala accepted D28247: Introduce SIOCGIFDNAME to get the interface device name.

Okay from me, but let @kp and @kevans weigh in as well.

Jan 20 2021, 3:30 AM
rpokala accepted D28245: ifconfig: add vlanproto "qiniq" as an alias for "802.1ad".
Jan 20 2021, 3:18 AM
rpokala added inline comments to D28245: ifconfig: add vlanproto "qiniq" as an alias for "802.1ad".
Jan 20 2021, 12:27 AM

Jan 19 2021

rpokala accepted D28240: Remove deadlock in rc caused by pwait waiting for itself.

Remember to bump .Dd at the top, to reflect the commit date. Other than that, looks good from a manpage standpoint.

Jan 19 2021, 7:57 PM · rc
rpokala added inline comments to D28240: Remove deadlock in rc caused by pwait waiting for itself.
Jan 19 2021, 7:32 PM · rc

Jan 14 2021

rpokala accepted D28168: uart: Improve console specification parsing.
Jan 14 2021, 9:08 PM

Jan 11 2021

rpokala added inline comments to D27800: Man page for AMD 10GbE driver.
Jan 11 2021, 10:25 PM

Jan 4 2021

rpokala added a comment to D27517: nvmecontrol: add device self-test op and log page.

That having been said - this is because the failing_lba field isn't aligned, right? But according to NVMe-1.4, it is aligned: failing_lba is bytes [23:16] of the data structure, which is clearly both 4-byte and 8-byte aligned. So, what's the problem with just having it be a uint64_t?

In the first element of the results[] array, yes, failing_lba is nicely aligned. But the packed array element size (28 bytes) is not divisible by 8 which will force every other failing_lba field to only be 4 byte aligned.

Jan 4 2021, 5:45 PM

Jan 3 2021

rpokala added a comment to D27517: nvmecontrol: add device self-test op and log page.

Any feedback on the change of failing_lba to uint8_t [8]? Does anything else stick out?

Jan 3 2021, 6:52 AM

Jan 1 2021

rpokala added inline comments to D27800: Man page for AMD 10GbE driver.
Jan 1 2021, 11:37 PM

Dec 10 2020

rpokala accepted D26915: virtio_pci: Allow memory space for configuration.

Looks good! Thanks for making the changes. :-)

Dec 10 2020, 6:28 AM
rpokala added inline comments to D26915: virtio_pci: Allow memory space for configuration.
Dec 10 2020, 4:37 AM

Dec 9 2020

rpokala added inline comments to D26915: virtio_pci: Allow memory space for configuration.
Dec 9 2020, 6:56 PM

Dec 3 2020

rpokala accepted D26839: [axgbe] fix compiler warnings when compiling using gcc-6.4.

I don't have the hardware to test, but the change looks fine.

  1. The zero-initialization is obviously valid
  2. It's clear in context that XGBE_SET_ADV() (which sets the flag) is what was really intended, instead of testing the flag with XGBE_ADV() and throwing away the result.
Dec 3 2020, 3:46 AM

Dec 1 2020

rpokala added a comment to D27354: Address issue pointed out in CVE-2020-25705.
In D27354#612664, @cy wrote:

Correct. A constant rate limit allows the attackers to infer which source port the request is coming from reducing its randomness from 32 bits to the original 16 bits. (Same mistake WPA made with WPS.)

Dec 1 2020, 2:00 AM

Nov 30 2020

rpokala added a comment to D27354: Address issue pointed out in CVE-2020-25705.

Forgive my (carefully cultivated) ignorance of the network stack, but I'd like to understand this:

Nov 30 2020, 7:41 AM