Page MenuHomeFreeBSD

rpokala (Ravi Pokala)
User

Projects

User Details

User Since
Nov 20 2015, 9:23 AM (241 w, 4 d)

Recent Activity

Mon, Jun 22

rpokala added a comment to D25389: Add loop visualization and parallel execution support into rcorder.
In D25389#560500, @avg wrote:

I'm a little late to the party, but thanks for the GraphViz! IIRC, I wrote a little shell script several years ago to pipe through to do the same thing, but I never committed it.

I can see sbin/rcorder/rcorder-visualize.sh committed by @vangyzen more than 3 years ago.
According to the commit message, it was written by Joerg Sonnenberger for NetBSD.

Mon, Jun 22, 8:49 PM
rpokala added inline comments to D25389: Add loop visualization and parallel execution support into rcorder.
Mon, Jun 22, 8:46 PM
rpokala added a comment to D25389: Add loop visualization and parallel execution support into rcorder.

I'm a little late to the party, but thanks for the GraphViz! IIRC, I wrote a little shell script several years ago to pipe through to do the same thing, but I never committed it.

Mon, Jun 22, 8:32 PM

Sat, Jun 20

rpokala accepted D25369: Make vipw error message less cryptic.

Seems reasonable.

Sat, Jun 20, 1:18 AM

Fri, Jun 19

rpokala committed rS362368: MFC r362078:.
MFC r362078:
Fri, Jun 19, 7:07 AM
rpokala committed rS362366: MFC r362078:.
MFC r362078:
Fri, Jun 19, 6:36 AM
rpokala committed rS362364: MFC r362078:.
MFC r362078:
Fri, Jun 19, 5:54 AM

Wed, Jun 17

rpokala added a comment to D25312: Relax the rule against declaring variables in nested scopes..

Please clarify that declaring a variable within the parens of the for is permissible.

Wed, Jun 17, 5:19 AM

Thu, Jun 11

rpokala committed rS362078: Decode the "LACP Fast Timeout" LAGG option flag.
Decode the "LACP Fast Timeout" LAGG option flag
Thu, Jun 11, 10:46 PM
rpokala closed D25239: Decode "LACP Fast Timeout" option flag.
Thu, Jun 11, 10:46 PM
rpokala added a reviewer for D25239: Decode "LACP Fast Timeout" option flag: jpaetzel.
Thu, Jun 11, 10:33 PM
rpokala requested review of D25239: Decode "LACP Fast Timeout" option flag.
Thu, Jun 11, 9:25 PM

Tue, Jun 9

rpokala accepted D25161: Remove the FIRMWARE_MAX limit..

LGTM

Tue, Jun 9, 3:06 PM

Mon, Jun 8

rpokala added inline comments to D25161: Remove the FIRMWARE_MAX limit..
Mon, Jun 8, 4:45 AM
rpokala added inline comments to D25161: Remove the FIRMWARE_MAX limit..
Mon, Jun 8, 12:22 AM

May 20 2020

rpokala accepted D24922: bnxt: isc_nrxd_max and isc_ntxd_max must be powers of two.

Thanks!

May 20 2020, 3:22 PM

May 19 2020

rpokala added inline comments to D24922: bnxt: isc_nrxd_max and isc_ntxd_max must be powers of two.
May 19 2020, 9:52 PM

May 13 2020

rpokala accepted D24762: Implement aliases in a way that actually work..

Changes look fine, and I'm satisfied with your answers to my question.

May 13 2020, 6:23 PM

May 12 2020

rpokala added a comment to D24825: Make all the ata probe* and xpt* routines aprobe* and axpt* respectively..

What about NVMe and MMC? If they don't have this problem, please say so in the commit message.

May 12 2020, 11:44 PM

May 11 2020

rpokala added a comment to D24762: Implement aliases in a way that actually work..

I note this is now creating an alias in NVMECAM, as well as in the GEOM layer; why both?

May 11 2020, 7:21 AM

Apr 30 2020

rpokala added inline comments to D24629: Implement the NVME_GET_NSID and NVME_PASSTHROUGH_CMD ioctls.
Apr 30 2020, 12:42 AM

Apr 20 2020

rpokala added inline comments to D24511: Introduce gauges as new types.
Apr 20 2020, 8:28 PM
rpokala requested changes to D24511: Introduce gauges as new types.

Please don't submit without a manpage!

Apr 20 2020, 8:23 PM

Apr 18 2020

rpokala accepted D24477: llvm9 wont allow enum definition inside anon-struct.

This seems reasonable.

Apr 18 2020, 1:07 AM

Apr 3 2020

rpokala added a comment to D23714: Add a manual page for smbios(4).
In D23714#534003, @gbergling_gmail.com wrote:

Ping?

Apr 3 2020, 9:47 PM

Mar 31 2020

rpokala closed D24242: Fix build for mips.XLP64 kernel, by re-ordering headers..
Mar 31 2020, 8:09 PM
rpokala committed rS359493: Fix build for mips.XLP64 kernel, by re-ordering headers.
Fix build for mips.XLP64 kernel, by re-ordering headers
Mar 31 2020, 8:09 PM
rpokala retitled D24242: Fix build for mips.XLP64 kernel, by re-ordering headers. from Fix build for mips.XLP64 kernel, by adding a missing header. to Fix build for mips.XLP64 kernel, by re-ordering headers..
Mar 31 2020, 8:02 PM
rpokala updated the diff for D24242: Fix build for mips.XLP64 kernel, by re-ordering headers..

Address review comments from emaste and jhb:

Mar 31 2020, 8:01 PM
rpokala updated the summary of D24242: Fix build for mips.XLP64 kernel, by re-ordering headers..
Mar 31 2020, 6:32 PM
rpokala updated the summary of D24242: Fix build for mips.XLP64 kernel, by re-ordering headers..
Mar 31 2020, 6:31 PM
rpokala created D24242: Fix build for mips.XLP64 kernel, by re-ordering headers..
Mar 31 2020, 6:30 PM

Mar 24 2020

rpokala accepted D24178: Disable rarely used architecture variants in make universe by default..
Mar 24 2020, 5:21 PM
rpokala accepted D24178: Disable rarely used architecture variants in make universe by default..

FWIW, LGTM.

Mar 24 2020, 3:51 PM

Feb 23 2020

rpokala accepted D23714: Add a manual page for smbios(4).
Feb 23 2020, 6:18 PM

Feb 17 2020

rpokala added inline comments to D23714: Add a manual page for smbios(4).
Feb 17 2020, 7:47 PM

Jan 24 2020

rpokala added inline comments to D23336: stdio: provide _unlocked variants of fflush, fputc, fputs, fread, fwrite.
Jan 24 2020, 6:27 PM

Jan 23 2020

rpokala added inline comments to D23336: stdio: provide _unlocked variants of fflush, fputc, fputs, fread, fwrite.
Jan 23 2020, 7:43 PM

Jan 18 2020

rpokala added a comment to D23247: Provide O_SEARCH.

The manpage should explain what "search only" means.

Jan 18 2020, 7:31 AM

Jan 16 2020

rpokala added inline comments to D12773: Manage thread signal mask using a shared word, instead of syscall..
Jan 16 2020, 3:21 AM

Jan 15 2020

rpokala added inline comments to D23165: bhyve(8): Add VM Generation Counter ACPI device.
Jan 15 2020, 6:46 PM
rpokala added inline comments to D23174: Add qsort_s(3).
Jan 15 2020, 1:13 AM
rpokala added a comment to D23165: bhyve(8): Add VM Generation Counter ACPI device.

So, bhyve literally generates the ACPI source text, and then does system(iasl) as part of startup? "Neat!"

Jan 15 2020, 12:36 AM

Jan 14 2020

rpokala added inline comments to D12773: Manage thread signal mask using a shared word, instead of syscall..
Jan 14 2020, 2:32 AM

Jan 10 2020

rpokala added inline comments to D23129: Small tweak to the default behavior of shutdown -c.
Jan 10 2020, 9:35 PM

Dec 13 2019

rpokala added inline comments to D22792: Build pxeboot files for all interpreters..
Dec 13 2019, 8:15 PM
rpokala added a comment to D22792: Build pxeboot files for all interpreters..

In any case, I will take another swing at this, using a Makefile.inc as @imp suggested.

Dec 13 2019, 4:06 PM
rpokala added a comment to D22792: Build pxeboot files for all interpreters..
In D22792#499018, @imp wrote:

You should rename btxldr/Makefile to be btxldr/Makefile.inc
You should create a new btxldr/Makefile that (1) installs btdldr.8 and (2) create a symlink to btxldr from the default interpreter.

Dec 13 2019, 4:05 PM
rpokala added a comment to D22792: Build pxeboot files for all interpreters..

I will be the first to admit that this is somewhat hackish; if someone can suggest a better way, I'm all for it.

Dec 13 2019, 7:13 AM
rpokala created D22792: Build pxeboot files for all interpreters..
Dec 13 2019, 7:10 AM

Dec 6 2019

rpokala added inline comments to D22715: vfs: introduce v_irflag and make v_type smaller.
Dec 6 2019, 11:59 PM

Dec 3 2019

rpokala committed rS355368: MFC r355006:.
MFC r355006:
Dec 3 2019, 10:54 PM
rpokala committed rS355367: MFC r354673:.
MFC r354673:
Dec 3 2019, 10:54 PM
rpokala committed rS355366: MFC r343583:.
MFC r343583:
Dec 3 2019, 10:54 PM
rpokala committed rS355365: MFC r355006:.
MFC r355006:
Dec 3 2019, 10:53 PM
rpokala committed rS355364: MFC r354673:.
MFC r354673:
Dec 3 2019, 10:53 PM
rpokala committed rS355363: MFC r354102:.
MFC r354102:
Dec 3 2019, 10:51 PM
rpokala committed rS355362: MFC r343583:.
MFC r343583:
Dec 3 2019, 10:49 PM

Nov 22 2019

rpokala closed D22474: Add option to run rpc.{lockd,statd} in the foreground..
Nov 22 2019, 4:53 PM
rpokala committed rS355006: Add and document options to allow rpc.lockd and rpc.statd to run in the.
Add and document options to allow rpc.lockd and rpc.statd to run in the
Nov 22 2019, 4:53 PM
rpokala updated the diff for D22474: Add option to run rpc.{lockd,statd} in the foreground..

Split lines in the manpages at the start of new sentences. Thanks igor(1)!

Nov 22 2019, 4:38 PM
rpokala added a comment to D22474: Add option to run rpc.{lockd,statd} in the foreground..
In D22474#491849, @imp wrote:

Looks good to me. Other commands use different flags to run in foreground, though. IT's inconsistent...

Nov 22 2019, 12:19 AM

Nov 21 2019

rpokala created D22474: Add option to run rpc.{lockd,statd} in the foreground..
Nov 21 2019, 5:21 AM

Nov 13 2019

rpokala committed rS354673: Logging improvements to loader::nfs.
Logging improvements to loader::nfs
Nov 13 2019, 3:57 AM
rpokala closed D22346: Logging improvements to loader::nfs.
Nov 13 2019, 3:57 AM
rpokala created D22346: Logging improvements to loader::nfs.
Nov 13 2019, 3:48 AM
rpokala abandoned D22345: Logging improvements to loader::nfs.

Argh. When I tried to fix some tabbing, I accidentally added a bunch of unrelated stuff.

Nov 13 2019, 3:47 AM
rpokala updated the diff for D22345: Logging improvements to loader::nfs.

Whoops, let some soft-tabs sneak in there! <facepalm>

Nov 13 2019, 3:46 AM
rpokala created D22345: Logging improvements to loader::nfs.
Nov 13 2019, 3:40 AM

Nov 10 2019

rpokala accepted D22271: Create /etc/os-release file..
Nov 10 2019, 8:06 AM

Nov 7 2019

rpokala added a comment to D22271: Create /etc/os-release file..

and is what the
sysutil/os-release port.

Nov 7 2019, 9:36 PM

Oct 25 2019

rpokala committed rS354102: Args for buf_track() might be unused.
Args for buf_track() might be unused
Oct 25 2019, 9:32 PM

Oct 10 2019

rpokala added a comment to D21959: introduce new 'ice' driver for Intel E800 Ethernet controllers.

Don't forget a manpage. :-)

Oct 10 2019, 6:10 PM

Sep 16 2019

rpokala added a comment to D20477: Introduce stats(3).
Sep 16 2019, 12:34 AM

Sep 14 2019

rpokala added a comment to D21660: Ask sync(8) to sync multiple times.

My understanding of the "old wives tale" was not sync()ing three times, but actually *typing* sync<enter> three times; by the time you finished typing the third one, any background operations initiated by the first one would have completed.

Sep 14 2019, 8:43 PM

Sep 10 2019

rpokala added inline comments to D21593: Add an option to gnop to allow rejecting I/O after allowing some through..
Sep 10 2019, 8:37 PM

Aug 23 2019

rpokala added inline comments to D21383: Add VMD support to FreeBSD.
Aug 23 2019, 7:51 PM

Aug 15 2019

D21265: fusefs: fix conditional from r351061 is now accepted and ready to land.

LGTM, thanks for the fast turn-around.

Aug 15 2019, 4:36 AM

Jul 30 2019

rpokala added a comment to D21111: beinstall.sh: Use bectl instead of beadm by default.

I second @bcr's manpages comments. Otherwise LGTM.

Jul 30 2019, 9:36 PM

Jul 24 2019

rpokala added inline comments to D21034: improve swapon comments.
Jul 24 2019, 6:03 AM

Jul 18 2019

D20988: Provide new tunable hw.nvme.verbose_cmd_dump is now accepted and ready to land.

SHIP IT!

Jul 18 2019, 9:34 PM
rpokala added a comment to D20983: Sort & dedupe getopt flags for daemon.

Now this includes parts of D20969 😕

Jul 18 2019, 4:40 PM
D20983: Sort & dedupe getopt flags for daemon now requires changes to proceed.

In addition to fixing the getopt() line, please upload a full diff, as described on the FreeBSD wiki: https://wiki.freebsd.org/action/show/Phabricator#Create_a_Revision_via_Web_Interface

Jul 18 2019, 5:18 AM
rpokala added inline comments to D20969: Add option to set umask before starting child process.
Jul 18 2019, 3:07 AM
D17102: Add build-time option to boot0sio to reset terminal is now accepted and ready to land.

LGTM, but I defer to @imp. Oh, and @kevans did a lot of stuff related to loader output as part of LuaLoader, so you might want to get his feedback as well.

Jul 18 2019, 2:47 AM

Jul 16 2019

rpokala added inline comments to D17102: Add build-time option to boot0sio to reset terminal.
Jul 16 2019, 4:19 PM

Jul 15 2019

D20950: Implement a devtype command. is now accepted and ready to land.

Looks reasonable to my not-very-CAM-savvy eyes.

Jul 15 2019, 9:41 PM
rpokala added inline comments to D20950: Implement a devtype command..
Jul 15 2019, 8:57 PM

Jun 17 2019

rpokala added inline comments to D20678: Changes to allow camcontrol to use cached data more often.
Jun 17 2019, 8:45 PM

May 29 2019

rpokala committed rS348376: Add bits related to SANITIZE, SED, and form-factor to (struct ata_params).
Add bits related to SANITIZE, SED, and form-factor to (struct ata_params)
May 29 2019, 11:50 PM
rpokala closed D20455: Add bits related to SANITIZE, SED, and form-factor to (struct ata_params).
May 29 2019, 11:50 PM
rpokala created D20455: Add bits related to SANITIZE, SED, and form-factor to (struct ata_params).
May 29 2019, 5:47 AM

May 21 2019

rpokala added inline comments to D20326: Expose the buildid hash through sysctl.
May 21 2019, 4:45 PM

May 20 2019

rpokala added inline comments to D20326: Expose the buildid hash through sysctl.
May 20 2019, 9:07 PM

Apr 25 2019

rpokala added a comment to D20054: Document the UEFI boot loading process.

boot1.efi.8 needs to mention where boot1.efi lives on disk. (/efi/boot/boot${ARCH}.efi, right?)

Apr 25 2019, 5:24 PM

Apr 17 2019

rpokala added inline comments to D19944: random(4): Restore availability tradeoff prior to r346250.
Apr 17 2019, 10:28 PM

Apr 5 2019

rpokala added a comment to D19827: aac(4): Add subvendor / subdevice to MODULE_PNP_INFO()'s descriptor_string.
In D19827#425235, @imp wrote:

I specifically allowed those duplicates when I was originally reviewing this change....

Apr 5 2019, 5:31 AM
rpokala created D19827: aac(4): Add subvendor / subdevice to MODULE_PNP_INFO()'s descriptor_string.
Apr 5 2019, 4:50 AM

Apr 3 2019

rpokala committed rS345838: MFC r345611:.
MFC r345611:
Apr 3 2019, 6:37 AM
rpokala committed rS345837: MFC r345611:.
MFC r345611:
Apr 3 2019, 6:37 AM