rpokala (Ravi Pokala)
User

Projects

User Details

User Since
Nov 20 2015, 9:23 AM (112 w, 6 d)

Recent Activity

Today

rpokala accepted D13975: Add info about c99 designationed initializers..
Fri, Jan 19, 1:00 AM

Wed, Jan 10

rpokala added a comment to P158 (An Untitled Masterwork).

A one-sentence description of what each of the functions does would be good too (i.e. expand ctz => Count Trailing Zeros, etc).

Wed, Jan 10, 1:30 AM
rpokala added a comment to P158 (An Untitled Masterwork).

The kernel as a standalone target does not link against libgcc or libcompiler-rt. On platforms (e.g., MIPS and RISCV) that do not have a direct assembly implementation of the relevant builtin functions that zstd references, the compiler converts them into calls to the runtime library intrinsics. Since the kernel doesn't link against the libraries, this results in a failure to link the kernel.

Wed, Jan 10, 1:29 AM
rpokala added inline comments to D13818: Create deprecation management functions..
Wed, Jan 10, 1:24 AM
rpokala added a comment to P158 (An Untitled Masterwork).

A comment explaining why you're doing all this would be good.

Wed, Jan 10, 1:13 AM
rpokala added a comment to D13818: Create deprecation management functions..

And of course the same comments for _gone_in_dev() as in _gone_in().

Wed, Jan 10, 1:12 AM
rpokala added inline comments to D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.
Wed, Jan 10, 1:04 AM
rpokala requested changes to D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.
Wed, Jan 10, 12:09 AM

Mon, Jan 8

rpokala added a comment to D13579: gnop(8): add the ability to set a nop provider's physical path.

I don't understand the G_NOP_PHYSPATH_PASSTHROUGH stuff. Can't you just check for non-NULL or non-empty 'physpath' being passed in?

Mon, Jan 8, 6:57 PM

Thu, Jan 4

rpokala added inline comments to D13770: Make it possible to re-evaluate cpu_features..
Thu, Jan 4, 11:06 PM
rpokala added inline comments to D13759: Remove/Limit whole process swapout.
Thu, Jan 4, 3:21 AM · committers

Sun, Dec 31

rpokala added inline comments to D13682: Add memset_s(3) doc to memset(3) man page..
Sun, Dec 31, 10:26 PM

Dec 20 2017

rpokala added inline comments to D13546: New pci device hints wiring..
Dec 20 2017, 2:06 AM

Dec 6 2017

rpokala accepted D13387: Define xpt_path_inq..

Heh. I've had a half-done, semi-related change sitting in one of my sandboxes for months.

Dec 6 2017, 5:12 PM

Nov 27 2017

rpokala added a watcher for NUMA: rpokala.
Nov 27 2017, 7:38 PM

Nov 21 2017

rpokala added inline comments to D13179: Add "Pull Request" to the devel/subversion commit template.
Nov 21 2017, 2:47 AM

Nov 16 2017

rpokala added a comment to D13086: Add chvgpio driver for gpio present of Intel z8000 series (Cherry View) SOC.

Is the name correct?

Nov 16 2017, 11:39 PM
rpokala added a comment to D13101: Add support for Zstd-compressed kernel and userspace dumps.
In D13101#272595, @cem wrote:

Switch off of a compression mode enumeration for userspace cores.

Nov 16 2017, 4:18 AM
rpokala added inline comments to D13101: Add support for Zstd-compressed kernel and userspace dumps.
Nov 16 2017, 3:26 AM

Nov 15 2017

rpokala added inline comments to D13101: Add support for Zstd-compressed kernel and userspace dumps.
Nov 15 2017, 11:39 PM

Nov 1 2017

rpokala added a comment to D8244: KCS thread hogs the CPU.

@cem mentioned this today. It sounds like this was held up over concerns about the watchdog not getting petted while panicking; is that correct? I ran into the same problem recently, and I solved it by simply adding the following to /etc/ddb.conf:

script kdb.enter.default=call db_watchdog

That stops the watchdog when entering the debugger, which works for both interactive debug sessions and dumping core.

Additionally, r325024 included a change to continue patting the watchdog while dumping core.

If debugger/dump issues were preventing this from landing, I think we're past those now.

Nov 1 2017, 1:42 AM

Oct 31 2017

rpokala added a comment to D8244: KCS thread hogs the CPU.

@cem mentioned this today. It sounds like this was held up over concerns about the watchdog not getting petted while panicking; is that correct? I ran into the same problem recently, and I solved it by simply adding the following to /etc/ddb.conf:

Oct 31 2017, 2:29 AM

Sep 20 2017

rpokala created P141 Is this license BSD-compatible?.
Sep 20 2017, 11:42 PM

Sep 12 2017

rpokala committed rS323508: When doing a non-interactive installation, don't display an interactive.
When doing a non-interactive installation, don't display an interactive
Sep 12 2017, 10:19 PM
rpokala closed D12346: Don't complain about missing mountpoints for scripted installations..
Sep 12 2017, 10:19 PM
rpokala updated the diff for D12346: Don't complain about missing mountpoints for scripted installations..

Address dteske's comment by unconditionally setting "choice", and overriding it
for the interactive case.

Sep 12 2017, 9:57 PM
rpokala accepted D11730: jedec_ts: add many more devices from various vendors.

Looks good to me. Thanks for the changes.

Sep 12 2017, 9:46 PM
rpokala updated the summary of D12346: Don't complain about missing mountpoints for scripted installations..
Sep 12 2017, 9:44 PM
rpokala created D12346: Don't complain about missing mountpoints for scripted installations..
Sep 12 2017, 9:42 PM

Aug 28 2017

rpokala committed rS322991: Fix a day-one typo in tty.4 - the sysctls in question are "tty", not "tk".
Fix a day-one typo in tty.4 - the sysctls in question are "tty", not "tk"
Aug 28 2017, 11:30 PM

Aug 5 2017

rpokala added inline comments to D11873: Create mechanism to allow nvd to be an alias for nda.
Aug 5 2017, 9:28 PM
rpokala added a comment to D11873: Create mechanism to allow nvd to be an alias for nda.

Shouldn't the aliasing be documented in nvd(4), nda(4), or both?

Aug 5 2017, 7:27 AM

Jul 31 2017

rpokala committed rS321786: Add my birthday to the FreeBSD calendar.
Add my birthday to the FreeBSD calendar
Jul 31 2017, 2:43 PM

Jul 29 2017

rpokala added a comment to D11730: jedec_ts: add many more devices from various vendors.
In D11730#244186, @imp wrote:

So long as it isn't automatic, but done to a specific address by request in a config file that's not there by default, then I think you may be right. It isn't horrible to do.

Jul 29 2017, 5:35 PM
rpokala added a comment to D11730: jedec_ts: add many more devices from various vendors.
In D11730#244159, @imp wrote:

I recall @imp specifically advising me that any access to the device should be done in attach, not in probe.

Fascinating. For my education, could you explain why, @imp?

Because writing to the IIC bus can cause a write cycle to EEROMs.

Jul 29 2017, 4:59 AM
rpokala accepted D11777: Selectively print "hwaddr" from ifconfig(8)..
Jul 29 2017, 2:29 AM
rpokala accepted D11776: Don't use libc++ when cross-building for gcc arches.

make tinderbox JFLAG=-j16 TARGETS="mips powerpc sparc64" UNIVERSE_TARGET=buildworld

Jul 29 2017, 12:47 AM

Jul 28 2017

rpokala added a comment to D11776: Don't use libc++ when cross-building for gcc arches.

I confirmed that this mips.mips.buildworld works; the other MIPS builds, PowerPC, and Sparc64 are in progress.

Jul 28 2017, 11:20 PM
rpokala added a comment to D11771: Add the Thunderbolt Apple interfaces to the bge(4) supported list.

That seems like and important limitation, so yeah, I'd include that info.

Sure, add a BUGS section?

Jul 28 2017, 3:06 PM
rpokala added a comment to D11730: jedec_ts: add many more devices from various vendors.

I recall @imp specifically advising me that any access to the device should be done in attach, not in probe.

Jul 28 2017, 2:52 PM
rpokala added a comment to D11771: Add the Thunderbolt Apple interfaces to the bge(4) supported list.

Also: is that the right URL? The snippet doesn't appear there.

Jul 28 2017, 2:48 PM
rpokala added a comment to D11771: Add the Thunderbolt Apple interfaces to the bge(4) supported list.

Not sure if I should extend the man page to state that hot plug isn't supported on FreeBSD (like on OS X) hence device should be connected prior to system power up and removal should be avoided when system is live (system stays up if I recall correctly, but kernel freaks out that a bge interface just disappeared).

Jul 28 2017, 2:46 PM

Jul 27 2017

rpokala added a comment to D11730: jedec_ts: add many more devices from various vendors.
In D11730#243574, @avg wrote:

One thing that can be considered a regression in the proposed code is that now device_set_desc() is called from the attach method, not from the probe method as before.
That's fine in general, but the messages printed just before DEVICE_ATTACH do not contain any description now.

Jul 27 2017, 6:16 PM

Jul 26 2017

rpokala added a reviewer for D11730: jedec_ts: add many more devices from various vendors: rpokala.
Jul 26 2017, 5:15 PM
rpokala added inline comments to D11730: jedec_ts: add many more devices from various vendors.
Jul 26 2017, 5:15 PM
rpokala added a comment to D11730: jedec_ts: add many more devices from various vendors.

Can you point to a copy (or even a recent draft?) of the TSE2004av spec for reference?

Jul 26 2017, 3:25 PM

Jun 16 2017

rpokala abandoned D11234: Fix a typo: s/Marwell/Marvell/g.

@zbb committed this independently as r320001.

Jun 16 2017, 2:41 PM
rpokala created D11234: Fix a typo: s/Marwell/Marvell/g.
Jun 16 2017, 4:54 AM

Jun 2 2017

rpokala accepted D11022: Add -H as an alias for --speed-large-file to match GNU diff..
Jun 2 2017, 12:10 AM

May 29 2017

rpokala committed rS319090: MFC r318688: "struct ata_params" field "reserved206[2]" actually starts at.
MFC r318688: "struct ata_params" field "reserved206[2]" actually starts at
May 29 2017, 5:23 AM
rpokala committed rS319089: MFC r318688: "struct ata_params" field "reserved206[2]" actually starts at.
MFC r318688: "struct ata_params" field "reserved206[2]" actually starts at
May 29 2017, 5:23 AM

May 22 2017

rpokala committed rS318688: "struct ata_params" field "reserved206[2]" actually starts at offset 20*7*..
"struct ata_params" field "reserved206[2]" actually starts at offset 20*7*.
May 22 2017, 11:31 PM

May 18 2017

rpokala committed rS318505: Persistently store NIC's hardware MAC address, and add a way to retrive it.
Persistently store NIC's hardware MAC address, and add a way to retrive it
May 18 2017, 11:42 PM
rpokala committed rS318504: Persistently store NIC's hardware MAC address, and add a way to retrive it.
Persistently store NIC's hardware MAC address, and add a way to retrive it
May 18 2017, 11:41 PM

May 17 2017

rpokala committed rS318430: MFC r318160, 318176: Persistently store NIC's hardware MAC address, and add.
MFC r318160, 318176: Persistently store NIC's hardware MAC address, and add
May 17 2017, 10:29 PM
rpokala committed rS318397: MFC r318160, 318176: Persistently store NIC's hardware MAC address, and add.
MFC r318160, 318176: Persistently store NIC's hardware MAC address, and add
May 17 2017, 5:53 AM

May 11 2017

rpokala committed rS318176: Persistently store NIC's hardware MAC address, and add a way to retrive it.
Persistently store NIC's hardware MAC address, and add a way to retrive it
May 11 2017, 6:46 AM
rpokala closed D10678: Fix panic in persistent hardware MAC storage by committing rS318176: Persistently store NIC's hardware MAC address, and add a way to retrive it.
May 11 2017, 6:46 AM
rpokala added a comment to D10678: Fix panic in persistent hardware MAC storage.

Thanks for the review, and sorry about the breakage!

May 11 2017, 6:44 AM
rpokala updated the diff for D10678: Fix panic in persistent hardware MAC storage.

The rest of ether_ifattach() foregoes braces for single-line blocks, so
do the same.

May 11 2017, 6:27 AM
rpokala created D10678: Fix panic in persistent hardware MAC storage.
May 11 2017, 6:06 AM

May 10 2017

rpokala committed rS318160: Persistently store NIC's hardware MAC address, and add a way to retrive it.
Persistently store NIC's hardware MAC address, and add a way to retrive it
May 10 2017, 10:14 PM
rpokala closed D10609: Persistently store NIC's hardware MAC address, and add a way to retrive it by committing rS318160: Persistently store NIC's hardware MAC address, and add a way to retrive it.
May 10 2017, 10:14 PM

May 9 2017

rpokala added a comment to D10654: Fix build(7) example..

It would also be good if the example wasn't using an architecture that's planned to be de-orbited "soon".

May 9 2017, 3:29 PM

May 7 2017

rpokala added a comment to D10609: Persistently store NIC's hardware MAC address, and add a way to retrive it.

@glebius - Please review at your earliest convenience. If you don't think you can get to it in the next week, I'll find someone else. Thanks!

May 7 2017, 4:42 AM
rpokala updated the test plan for D10609: Persistently store NIC's hardware MAC address, and add a way to retrive it.
May 7 2017, 4:40 AM
rpokala updated the diff for D10609: Persistently store NIC's hardware MAC address, and add a way to retrive it.

Address review comments from brooks: only store / retrieve for IFT_ETHER.

May 7 2017, 1:54 AM

May 5 2017

rpokala added inline comments to D10609: Persistently store NIC's hardware MAC address, and add a way to retrive it.
May 5 2017, 10:21 PM
rpokala updated subscribers of D10609: Persistently store NIC's hardware MAC address, and add a way to retrive it.
May 5 2017, 9:58 PM
rpokala added inline comments to D10609: Persistently store NIC's hardware MAC address, and add a way to retrive it.
May 5 2017, 9:58 PM
rpokala created D10609: Persistently store NIC's hardware MAC address, and add a way to retrive it.
May 5 2017, 8:47 AM

Apr 26 2017

rpokala accepted D10466: Fix NVMe's use of XPT_GDEV_TYPE.

LGTM, but @imp should have the final say.

Apr 26 2017, 10:17 PM

Apr 25 2017

rpokala added a comment to D10489: Add EXAMPLES section to uname(1).
In D10489#217460, @imp wrote:

If "platform" (-m) and "processor architecture" (-p) are the same as the TARGET and TARGET_ARCH, then it would be great to include that too.

They are MACHINE and MACHINE_ARCH which are universal, please document them as such. The build man page already gives the translation for the TARGET and TARGET_ARCH which only have meaning in Makefile.inc1 (eg, the top level of buildworld where they are used to set MACHINE and MACHINE_ARCH).

Apr 25 2017, 2:24 PM · manpages
rpokala added a comment to D10489: Add EXAMPLES section to uname(1).

If "platform" (-m) and "processor architecture" (-p) are the same as the TARGET and TARGET_ARCH, then it would be great to include that too.

Apr 25 2017, 6:48 AM · manpages

Apr 24 2017

rpokala added inline comments to D10466: Fix NVMe's use of XPT_GDEV_TYPE.
Apr 24 2017, 9:49 PM
rpokala added a comment to D10466: Fix NVMe's use of XPT_GDEV_TYPE.

Please regenerate the diffs w/ proper context. See https://wiki.freebsd.org/action/show/Phabricator for details on how to do that.

Apr 24 2017, 2:22 PM

Apr 23 2017

rpokala added inline comments to D10457: Add ability to label md(4) devices.
Apr 23 2017, 3:13 AM

Apr 22 2017

rpokala added inline comments to D10457: Add ability to label md(4) devices.
Apr 22 2017, 11:32 PM
rpokala added inline comments to D10457: Add ability to label md(4) devices.
Apr 22 2017, 6:00 AM

Mar 31 2017

rpokala abandoned D10210: loader(8) doesn't have "cat", but it has "more"; add a pointer to it..

Actually, forget this -- I'll actually implement "cat". Fortunately, it's in C, not FICL, so I have a chance. :-)

Mar 31 2017, 12:35 AM
rpokala updated the diff for D10210: loader(8) doesn't have "cat", but it has "more"; add a pointer to it..

Update the date.

Mar 31 2017, 12:04 AM
rpokala created D10210: loader(8) doesn't have "cat", but it has "more"; add a pointer to it..
Mar 31 2017, 12:03 AM

Mar 25 2017

rpokala added a comment to D7828: Add -p (physpath) and -s (serial#) to diskinfo.

Hi Allan, this patch has been sitting idle for a few months, could you either commit it or abandon it?

Mar 25 2017, 7:00 PM

Mar 15 2017

rpokala accepted D8491: libstand: verify value provided by nfs.read_size.

Fair enough. :-)

Mar 15 2017, 9:44 PM
rpokala added inline comments to D8491: libstand: verify value provided by nfs.read_size.
Mar 15 2017, 9:30 PM
rpokala requested changes to D8491: libstand: verify value provided by nfs.read_size.
Mar 15 2017, 9:05 PM

Mar 3 2017

rpokala added a comment to D9870: PR216964: boot1.efi: can't boot from ZFS on 4kn HDD.

It seems to me the two ReadBlocks() calls could be consolidated, which would allow you to also include the buffer size in the DPRINTF(). Something like this:

Mar 3 2017, 4:38 PM

Feb 18 2017

rpokala added a comment to D9502: Introduce geom_slow to simulate slow disks.

Warner and Warren are both right - this functionality would fit in well in either g_sched, or as part of g_nop.

Feb 18 2017, 6:17 AM

Feb 15 2017

rpokala committed rS313777: Un-break vt(4) for {powerpc,powerpc64,sparc64} LINT kernel builds.
Un-break vt(4) for {powerpc,powerpc64,sparc64} LINT kernel builds
Feb 15 2017, 5:33 PM

Feb 8 2017

rpokala committed rS313433: MFC r304142: ensure stripe size is non-zero multiple of 4096.
MFC r304142: ensure stripe size is non-zero multiple of 4096
Feb 8 2017, 8:38 AM
rpokala committed rS313410: Fix indentation (only line in file w/ 8-space indent rather than hard-tab)..
Fix indentation (only line in file w/ 8-space indent rather than hard-tab).
Feb 8 2017, 12:03 AM

Feb 3 2017

rpokala added a comment to D9424: remove bdes(1).

Ah, I remembered the context! bdes was involved in decrypting the video of one of Kirk's lecture series.

Feb 3 2017, 2:16 PM
rpokala added a comment to D9424: remove bdes(1).

Is it useless? ISTR using bdes in the not-too-distant past...

Feb 3 2017, 2:14 PM

Feb 1 2017

rpokala committed rS313039: MFC r312678: Eliminate misleading comments and dead code in.
MFC r312678: Eliminate misleading comments and dead code in
Feb 1 2017, 4:54 AM
rpokala committed rS313038: MFC r312678: Eliminate misleading comments and dead code in.
MFC r312678: Eliminate misleading comments and dead code in
Feb 1 2017, 4:54 AM

Jan 24 2017

rpokala committed rS312678: Eliminate misleading comments and dead code in lacp_port_create().
Eliminate misleading comments and dead code in lacp_port_create()
Jan 24 2017, 1:40 AM
rpokala closed D9302: Eliminate misleading comments and dead code in lacp_port_create() by committing rS312678: Eliminate misleading comments and dead code in lacp_port_create().
Jan 24 2017, 1:40 AM

Jan 23 2017

rpokala added a comment to D9306: Add LOGDIR option to redirect "make universe" output to a different directory..

Is there any particular reason not to just put them in the build output directory?

Jan 23 2017, 7:05 PM
rpokala added a comment to D9302: Eliminate misleading comments and dead code in lacp_port_create().

Thanks. I'm tinderboxing right now, will submit when that's done.

Jan 23 2017, 3:38 PM
rpokala retitled D9302: Eliminate misleading comments and dead code in lacp_port_create() from to Eliminate misleading comments and dead code in lacp_port_create().
Jan 23 2017, 8:19 AM