- User Since
- Nov 20 2015, 9:23 AM (112 w, 6 d)
Wed, Jan 10
A one-sentence description of what each of the functions does would be good too (i.e. expand ctz => Count Trailing Zeros, etc).
The kernel as a standalone target does not link against libgcc or libcompiler-rt. On platforms (e.g., MIPS and RISCV) that do not have a direct assembly implementation of the relevant builtin functions that zstd references, the compiler converts them into calls to the runtime library intrinsics. Since the kernel doesn't link against the libraries, this results in a failure to link the kernel.
A comment explaining why you're doing all this would be good.
And of course the same comments for _gone_in_dev() as in _gone_in().
Mon, Jan 8
I don't understand the G_NOP_PHYSPATH_PASSTHROUGH stuff. Can't you just check for non-NULL or non-empty 'physpath' being passed in?
Thu, Jan 4
Sun, Dec 31
Dec 20 2017
Dec 6 2017
Heh. I've had a half-done, semi-related change sitting in one of my sandboxes for months.
Nov 27 2017
Nov 21 2017
Nov 16 2017
Is the name correct?
Nov 15 2017
Nov 1 2017
Oct 31 2017
@cem mentioned this today. It sounds like this was held up over concerns about the watchdog not getting petted while panicking; is that correct? I ran into the same problem recently, and I solved it by simply adding the following to /etc/ddb.conf:
Sep 20 2017
Sep 12 2017
Address dteske's comment by unconditionally setting "choice", and overriding it
for the interactive case.
Looks good to me. Thanks for the changes.
Aug 28 2017
Aug 5 2017
Shouldn't the aliasing be documented in nvd(4), nda(4), or both?
Jul 31 2017
Jul 29 2017
make tinderbox JFLAG=-j16 TARGETS="mips powerpc sparc64" UNIVERSE_TARGET=buildworld
Jul 28 2017
I confirmed that this mips.mips.buildworld works; the other MIPS builds, PowerPC, and Sparc64 are in progress.
I recall @imp specifically advising me that any access to the device should be done in attach, not in probe.
Also: is that the right URL? The snippet doesn't appear there.
Not sure if I should extend the man page to state that hot plug isn't supported on FreeBSD (like on OS X) hence device should be connected prior to system power up and removal should be avoided when system is live (system stays up if I recall correctly, but kernel freaks out that a bge interface just disappeared).
Jul 27 2017
Jul 26 2017
Can you point to a copy (or even a recent draft?) of the TSE2004av spec for reference?
Jun 16 2017
@zbb committed this independently as r320001.
Jun 2 2017
May 29 2017
May 22 2017
May 18 2017
May 17 2017
May 11 2017
Thanks for the review, and sorry about the breakage!
The rest of ether_ifattach() foregoes braces for single-line blocks, so
do the same.
May 10 2017
May 9 2017
It would also be good if the example wasn't using an architecture that's planned to be de-orbited "soon".
May 7 2017
@glebius - Please review at your earliest convenience. If you don't think you can get to it in the next week, I'll find someone else. Thanks!
Address review comments from brooks: only store / retrieve for IFT_ETHER.
May 5 2017
Apr 26 2017
LGTM, but @imp should have the final say.
Apr 25 2017
If "platform" (-m) and "processor architecture" (-p) are the same as the TARGET and TARGET_ARCH, then it would be great to include that too.
Apr 24 2017
Please regenerate the diffs w/ proper context. See https://wiki.freebsd.org/action/show/Phabricator for details on how to do that.
Apr 23 2017
Apr 22 2017
Mar 31 2017
Actually, forget this -- I'll actually implement "cat". Fortunately, it's in C, not FICL, so I have a chance. :-)
Update the date.
Mar 25 2017
Hi Allan, this patch has been sitting idle for a few months, could you either commit it or abandon it?
Mar 15 2017
Fair enough. :-)
Mar 3 2017
It seems to me the two ReadBlocks() calls could be consolidated, which would allow you to also include the buffer size in the DPRINTF(). Something like this:
Feb 18 2017
Warner and Warren are both right - this functionality would fit in well in either g_sched, or as part of g_nop.
Feb 15 2017
Feb 8 2017
Feb 3 2017
Ah, I remembered the context! bdes was involved in decrypting the video of one of Kirk's lecture series.
Is it useless? ISTR using bdes in the not-too-distant past...
Feb 1 2017
Jan 24 2017
Jan 23 2017
Is there any particular reason not to just put them in the build output directory?
Thanks. I'm tinderboxing right now, will submit when that's done.