Page MenuHomeFreeBSD

qat: Rename to qat_c2xxx and remove support for modern chipsets
ClosedPublic

Authored by markj on Jul 14 2022, 3:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 15 2022, 7:36 AM
Unknown Object (File)
Dec 2 2022, 7:53 AM

Details

Summary

A replacement driver will be imported, but this replacement does not
attach to Atom C2xxx hardware. So, the existing driver will be kept
around to provide opencrypto offload support.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Jul 14 2022, 3:41 PM

The qat(4) manual page was deleted, not moved or renamed. Is that deliberate?

In D35817#813191, @pauamma_gundo.com wrote:

The qat(4) manual page was deleted, not moved or renamed. Is that deliberate?

Yes. The new QAT driver has its own manual page, and since qat_c2xxx is specifically for old hardware and won't be receiving improvements beyond the usual maintenance, I don't see much reason to keep a man page for it.

In D35817#813191, @pauamma_gundo.com wrote:

The qat(4) manual page was deleted, not moved or renamed. Is that deliberate?

Yes. The new QAT driver has its own manual page, and since qat_c2xxx is specifically for old hardware and won't be receiving improvements beyond the usual maintenance, I don't see much reason to keep a man page for it.

<grimace>

I don't like the idea of removing an existing manpage from an existing driver, just on general principles. Can you keep it and rename it appropriately instead?

pauamma requested changes to this revision.Jul 17 2022, 9:40 PM

<grimace>

I don't like the idea of removing an existing manpage from an existing driver, just on general principles. Can you keep it and rename it appropriately instead?

Seconded.

This revision now requires changes to proceed.Jul 17 2022, 9:40 PM
emaste added a subscriber: emaste.

I guess note in the commit message that there's no change to ObsoleteFiles.inc etc. because the new driver will provide the files that have been removed. (Is that the case for all of the firmware files?)

share/man/man4/qat_c2xxx.4
74

We'll want to add an Xr to new qat once it goes in

Re-add the manual page.

Thanks!

I guess note in the commit message that there's no change to ObsoleteFiles.inc etc. because the new driver will provide the files that have been removed. (Is that the case for all of the firmware files?)

Oh hmm, not sure about the firmware files in fact.

I guess note in the commit message that there's no change to ObsoleteFiles.inc etc. because the new driver will provide the files that have been removed. (Is that the case for all of the firmware files?)

Oh hmm, not sure about the firmware files in fact.

I think it's ok. The firmware is installed as kernel modules, e.g., qat_dh895xcc_fw.ko. Some of them have different names with the new driver, but they'll be replaced simply by installing a new kernel, since installkernel wipes out the old one.

I think it's ok. The firmware is installed as kernel modules, e.g., qat_dh895xcc_fw.ko. Some of them have different names with the new driver, but they'll be replaced simply by installing a new kernel, since installkernel wipes out the old one.

👍

Manual page change English looks good to me and its content is consistent with change summary.

This revision is now accepted and ready to land.Jul 23 2022, 8:02 AM