A replacement driver will be imported, but this replacement does not
attach to Atom C2xxx hardware. So, the existing driver will be kept
around to provide opencrypto offload support.
Details
- Reviewers
pauamma_gundo.com emaste - Group Reviewers
manpages - Commits
- rGf4f56ff43dbd: qat: Rename to qat_c2xxx and remove support for modern chipsets
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Yes. The new QAT driver has its own manual page, and since qat_c2xxx is specifically for old hardware and won't be receiving improvements beyond the usual maintenance, I don't see much reason to keep a man page for it.
<grimace>
I don't like the idea of removing an existing manpage from an existing driver, just on general principles. Can you keep it and rename it appropriately instead?
I guess note in the commit message that there's no change to ObsoleteFiles.inc etc. because the new driver will provide the files that have been removed. (Is that the case for all of the firmware files?)
share/man/man4/qat_c2xxx.4 | ||
---|---|---|
74 | We'll want to add an Xr to new qat once it goes in |
I think it's ok. The firmware is installed as kernel modules, e.g., qat_dh895xcc_fw.ko. Some of them have different names with the new driver, but they'll be replaced simply by installing a new kernel, since installkernel wipes out the old one.
Manual page change English looks good to me and its content is consistent with change summary.