Page MenuHomeFreeBSD

obiwac_gmail.com (Aymeric Wibo)
Fan-bearer on the Right Side of the King

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2022, 11:32 AM (134 w, 5 d)

Recent Activity

Thu, Jan 30

obiwac_gmail.com abandoned D48720: acpi: Suspend-to-idle support (S0i).

Split out into D48732, D48734, and D48735.

Thu, Jan 30, 7:10 PM
obiwac_gmail.com updated the test plan for D48734: acpi: Suspend-to-idle support (s2idle).
Thu, Jan 30, 7:09 PM
obiwac_gmail.com requested review of D48735: acpi: Call SPMC entry/exit hooks if SPMC device is set.
Thu, Jan 30, 7:07 PM
obiwac_gmail.com updated the summary of D48734: acpi: Suspend-to-idle support (s2idle).
Thu, Jan 30, 7:04 PM
obiwac_gmail.com requested review of D48734: acpi: Suspend-to-idle support (s2idle).
Thu, Jan 30, 6:59 PM
obiwac_gmail.com requested review of D48732: acpi: Abstract over ACPI Sx sleep states with `enum sleep_type`.
Thu, Jan 30, 6:26 PM
obiwac_gmail.com added a comment to D48387: acpi_spmc: Add SPMC (system power management controller) driver.

Thanks for trying this out @jkim & @shuriku_shurik.kiev.ua :)

Thu, Jan 30, 5:36 PM

Wed, Jan 29

obiwac_gmail.com updated the test plan for D48720: acpi: Suspend-to-idle support (S0i).
Wed, Jan 29, 11:21 PM
obiwac_gmail.com requested review of D48721: amdsmu: Sleep entry/exit hints for PMFW.
Wed, Jan 29, 9:19 PM
obiwac_gmail.com requested review of D48720: acpi: Suspend-to-idle support (S0i).
Wed, Jan 29, 8:53 PM
obiwac_gmail.com updated the diff for D48387: acpi_spmc: Add SPMC (system power management controller) driver.

Print out message when all device power constraints are respected

Wed, Jan 29, 8:21 PM
obiwac_gmail.com updated the diff for D48387: acpi_spmc: Add SPMC (system power management controller) driver.
  • Use Intel GET_DEVICE_CONSTRAINTS DSM by default (Microsoft doesn't have this)
  • Comment for entry/exit notification functions
Wed, Jan 29, 4:30 PM
obiwac_gmail.com requested review of D48714: amdsmu: Get and expose sysctls for metrics about last sleep.
Wed, Jan 29, 4:14 PM
obiwac_gmail.com added a comment to D48387: acpi_spmc: Add SPMC (system power management controller) driver.

On my laptop with Intel i7-1355U CPU I see this while device attached:

Jan 29 15:19:07 thinkpad kernel: acpi_spmc0: <Low Power S0 Idle (DSM sets 0x3)> on acpi0
Jan 29 15:19:07 thinkpad kernel: ACPI Error: Incorrect return type from \_SB_.PEPD._DSM - received [Buffer], requested [Package] (20241212/nsxfeval-274)
Jan 29 15:19:07 thinkpad kernel: acpi_spmc0: failed to call DSM 1 (acpi_spmc_get_constraints)
Wed, Jan 29, 2:35 PM

Sat, Jan 25

obiwac_gmail.com requested review of D48683: amdsmu: Initial work on a driver for the AMD SMU.
Sat, Jan 25, 7:17 PM

Sat, Jan 11

obiwac_gmail.com added a comment to D48384: acpi_powerres: D3cold support and `acpi_d_state_to_str`.

Based on the discussion on github, it looks like the unqualified D3 state likely should correspond to D3hot?

Sat, Jan 11, 4:08 PM

Jan 10 2025

obiwac_gmail.com updated the diff for D48384: acpi_powerres: D3cold support and `acpi_d_state_to_str`.

more style(9) closening

Jan 10 2025, 11:35 PM
obiwac_gmail.com updated the diff for D48387: acpi_spmc: Add SPMC (system power management controller) driver.

bring closer to style(9)

Jan 10 2025, 11:33 PM
obiwac_gmail.com updated the diff for D48384: acpi_powerres: D3cold support and `acpi_d_state_to_str`.

Add PCI_POWERSTATE_D3_COLD to pci(9) manpage

Jan 10 2025, 11:30 PM
obiwac_gmail.com added inline comments to D48384: acpi_powerres: D3cold support and `acpi_d_state_to_str`.
Jan 10 2025, 11:20 PM
obiwac_gmail.com updated the diff for D48384: acpi_powerres: D3cold support and `acpi_d_state_to_str`.

Respond to style comments

Jan 10 2025, 11:19 PM

Jan 9 2025

obiwac_gmail.com added inline comments to D46992: libusb: implement `libusb_get_parent`.
Jan 9 2025, 5:19 PM
obiwac_gmail.com updated the diff for D46992: libusb: implement `libusb_get_parent`.

Add missing section header in libusb.3 manpage

Jan 9 2025, 5:18 PM
obiwac_gmail.com updated the summary of D48387: acpi_spmc: Add SPMC (system power management controller) driver.
Jan 9 2025, 12:18 AM
obiwac_gmail.com requested review of D48387: acpi_spmc: Add SPMC (system power management controller) driver.
Jan 9 2025, 12:15 AM
obiwac_gmail.com retitled D48386: acpi_powerres: `acpi_pwr_get_state` and getting initial D-state for device from acpi_powerres: Get initial D-state for device to acpi_powerres: `acpi_pwr_get_state` and getting initial D-state for device.
Jan 9 2025, 12:14 AM

Jan 8 2025

obiwac_gmail.com updated the summary of D48385: acpi_powerres: Fix turning off power resources on first D-state switch.
Jan 8 2025, 11:56 PM
obiwac_gmail.com updated the summary of D48384: acpi_powerres: D3cold support and `acpi_d_state_to_str`.
Jan 8 2025, 11:56 PM
obiwac_gmail.com updated the summary of D48386: acpi_powerres: `acpi_pwr_get_state` and getting initial D-state for device.
Jan 8 2025, 11:56 PM
obiwac_gmail.com added reviewers for D48386: acpi_powerres: `acpi_pwr_get_state` and getting initial D-state for device: jkim, emaste, imp, markj, jhb.
Jan 8 2025, 11:29 PM
obiwac_gmail.com added reviewers for D48385: acpi_powerres: Fix turning off power resources on first D-state switch: imp, emaste, markj, jhb, jkim.
Jan 8 2025, 11:28 PM
obiwac_gmail.com abandoned D48294: acpi_powerres: D3cold support and fix turning off power resources on first D-state switch.

This has been split out into revisions D48384, D48385, and D48386.

Jan 8 2025, 11:25 PM
obiwac_gmail.com updated the summary of D48384: acpi_powerres: D3cold support and `acpi_d_state_to_str`.
Jan 8 2025, 11:24 PM
obiwac_gmail.com updated the summary of D48385: acpi_powerres: Fix turning off power resources on first D-state switch.
Jan 8 2025, 11:24 PM
obiwac_gmail.com requested review of D48386: acpi_powerres: `acpi_pwr_get_state` and getting initial D-state for device.
Jan 8 2025, 11:24 PM
obiwac_gmail.com updated the summary of D48385: acpi_powerres: Fix turning off power resources on first D-state switch.
Jan 8 2025, 11:15 PM
obiwac_gmail.com requested review of D48385: acpi_powerres: Fix turning off power resources on first D-state switch.
Jan 8 2025, 11:12 PM
obiwac_gmail.com updated the summary of D48384: acpi_powerres: D3cold support and `acpi_d_state_to_str`.
Jan 8 2025, 11:12 PM
obiwac_gmail.com requested review of D48384: acpi_powerres: D3cold support and `acpi_d_state_to_str`.
Jan 8 2025, 11:07 PM

Jan 3 2025

obiwac_gmail.com added inline comments to D48294: acpi_powerres: D3cold support and fix turning off power resources on first D-state switch.
Jan 3 2025, 10:07 AM

Jan 2 2025

obiwac_gmail.com updated the diff for D48294: acpi_powerres: D3cold support and fix turning off power resources on first D-state switch.

Explicit check for reslist_name to set reslist_handle. Was previously relying on hidden check in AcpiGetHandle.

Jan 2 2025, 10:40 PM
obiwac_gmail.com updated the diff for D48294: acpi_powerres: D3cold support and fix turning off power resources on first D-state switch.

Address review comments by @emaste and @imp.

Jan 2 2025, 10:34 PM
obiwac_gmail.com added reviewers for D48294: acpi_powerres: D3cold support and fix turning off power resources on first D-state switch: jhb, markj, jkim, imp.
Jan 2 2025, 10:09 PM
obiwac_gmail.com added a comment to D48294: acpi_powerres: D3cold support and fix turning off power resources on first D-state switch.

Also, we'll likely want to split this up since it looks like several different changes combined. Though we can split once we're happy with the changes if you have them all combined at the moment.

Jan 2 2025, 10:09 PM
obiwac_gmail.com added inline comments to D48294: acpi_powerres: D3cold support and fix turning off power resources on first D-state switch.
Jan 2 2025, 7:59 PM
obiwac_gmail.com updated the summary of D48294: acpi_powerres: D3cold support and fix turning off power resources on first D-state switch.
Jan 2 2025, 7:55 PM
obiwac_gmail.com requested review of D48294: acpi_powerres: D3cold support and fix turning off power resources on first D-state switch.
Jan 2 2025, 7:52 PM

Dec 27 2024

obiwac_gmail.com accepted D48134: draft for suspend/resume submission.
Dec 27 2024, 8:10 PM

Dec 18 2024

obiwac_gmail.com accepted D48134: draft for suspend/resume submission.
Dec 18 2024, 8:01 PM
obiwac_gmail.com added inline comments to D48134: draft for suspend/resume submission.
Dec 18 2024, 7:38 PM

Nov 5 2024

obiwac_gmail.com updated the diff for D46992: libusb: implement `libusb_get_parent`.
  • libusb.3: add libusb_get_parent
Nov 5 2024, 11:24 AM
obiwac_gmail.com updated the diff for D46992: libusb: implement `libusb_get_parent`.
Nov 5 2024, 11:21 AM
obiwac_gmail.com updated the diff for D46992: libusb: implement `libusb_get_parent`.
  • libusb.3: add libusb_get_parent
Nov 5 2024, 11:16 AM

Oct 9 2024

obiwac_gmail.com abandoned D41679: gsoc: BATMAN code pulled from Linux (with no changes).

This will end up being a port.

Oct 9 2024, 2:35 PM · GSoC Students

Oct 7 2024

obiwac_gmail.com requested review of D46992: libusb: implement `libusb_get_parent`.
Oct 7 2024, 5:18 PM

Aug 31 2023

obiwac_gmail.com added a comment to D41679: gsoc: BATMAN code pulled from Linux (with no changes).
In D41679#949804, @imp wrote:

sys/contrib is good for this, but sys/gnu might be even better since it is GPL'd.

Aug 31 2023, 8:28 PM · GSoC Students
obiwac_gmail.com requested review of D41679: gsoc: BATMAN code pulled from Linux (with no changes).
Aug 31 2023, 8:12 PM · GSoC Students

Feb 5 2023

obiwac_gmail.com added a comment to D38387: ietp: Load dummy HID report descriptor if mangled.

Ah yes I forgot to specify sorry, "Aymeric Wibo" :)

Feb 5 2023, 2:53 PM
obiwac_gmail.com requested review of D38387: ietp: Load dummy HID report descriptor if mangled.
Feb 5 2023, 12:25 AM

Sep 8 2022

obiwac_gmail.com updated the diff for D36407: ls: `-v` flag.

ls: Remove Tn macros from manpage

Sep 8 2022, 3:31 PM
obiwac_gmail.com updated the summary of D36407: ls: `-v` flag.
Sep 8 2022, 11:48 AM
obiwac_gmail.com updated the diff for D36407: ls: `-v` flag.

Fix warnings from mandoc -Tlint

Sep 8 2022, 11:48 AM

Sep 7 2022

obiwac_gmail.com added a comment to D36407: ls: `-v` flag.

I have not, I didn't know about that, thanks for pointing me to it! I'll fix that in a bit. May I fix all the "STYLE: useless macro: Tn" errors or do I ignore those?

Sep 7 2022, 7:01 PM

Sep 3 2022

obiwac_gmail.com updated obiwac_gmail.com.
Sep 3 2022, 6:25 PM

Sep 1 2022

obiwac_gmail.com updated the diff for D36407: ls: `-v` flag.

Fix commas in ls.1

Sep 1 2022, 11:33 AM

Aug 31 2022

obiwac_gmail.com added inline comments to D36407: ls: `-v` flag.
Aug 31 2022, 11:05 PM
obiwac_gmail.com updated the diff for D36407: ls: `-v` flag.

ls: Add strcoll(3) & strverscmp(3) to "SEE ALSO" in manpage

Aug 31 2022, 7:52 PM
obiwac_gmail.com requested review of D36407: ls: `-v` flag.
Aug 31 2022, 7:48 PM

Aug 24 2022

obiwac_gmail.com accepted D36301: Add scandirat(3).
Aug 24 2022, 2:11 PM

Aug 23 2022

obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

scandir: Add man link from versionsort.3

Aug 23 2022, 9:28 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Stupid mistake in usage of __DECONST

Aug 23 2022, 9:22 PM
obiwac_gmail.com added a comment to D36301: Add scandirat(3).

Looks fine to me aside from the manpage typos :)

Aug 23 2022, 9:08 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Code style

Aug 23 2022, 8:52 PM
obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

I still haven't tried compiling anything yet; I don't have access to a FreeBSD machine for the moment.

Aug 23 2022, 7:00 AM

Aug 21 2022

obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Does spacing like this work for you @kib? Hopefully I'll get the feeling for where blank spaces are/aren't appropriate in FreeBSD code in future patches 😄

Aug 21 2022, 4:54 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Replace casts with __DECONST & remove some blank lines

Aug 21 2022, 4:53 PM
obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Do you mean indentation?

Aug 21 2022, 12:41 PM
obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Where can I find the rules for vertical spacing? I can't find it explicitly in style(9)

Aug 21 2022, 12:07 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Integrate styling comments from @kib

Aug 21 2022, 12:05 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Integrate styling comments from @kib

Aug 21 2022, 12:03 PM
obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

I'll make those changes a little later, thank you :)

Aug 21 2022, 7:10 AM

Aug 19 2022

obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

strverscmp: Respect new rules in style(9)

Aug 19 2022, 8:23 PM
obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Please go ahead.

Aug 19 2022, 8:08 PM
obiwac_gmail.com updated the summary of D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Aug 19 2022, 8:05 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
  • strverscmp: Respect new rules in style(9)
Aug 19 2022, 8:02 PM
obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

I can fix both of those - or do you want to do it yourself and update this review?

Aug 19 2022, 10:54 AM

Jul 27 2022

obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
In D35807#816089, @pauamma wrote:
Jul 27 2022, 11:34 AM

Jul 24 2022

obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Hey guys, is there anything here that I still need to do?

Jul 24 2022, 12:14 PM

Jul 20 2022

obiwac_gmail.com abandoned D35783: ls: `-v` flag (and `strverscmp(3)` & `versionsort(3)`).

See D35807.

Jul 20 2022, 12:46 PM

Jul 16 2022

obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Simplify digit counting code & style

Jul 16 2022, 4:59 PM
obiwac_gmail.com added inline comments to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 16 2022, 1:39 PM

Jul 15 2022

obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Remove contraction in manual page

Jul 15 2022, 8:39 PM
obiwac_gmail.com added inline comments to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 15 2022, 11:20 AM

Jul 14 2022

obiwac_gmail.com added inline comments to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 14 2022, 6:37 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Integrate feedback from pstef@

Jul 14 2022, 6:35 PM
obiwac_gmail.com added inline comments to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 14 2022, 6:29 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Integrate feedback from danfe@ about comments not consistently ending with full stops.

Jul 14 2022, 2:26 PM
obiwac_gmail.com added inline comments to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 14 2022, 2:26 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Integrate feedback from danfe@ about 000 < 09 example.

Jul 14 2022, 2:09 PM
obiwac_gmail.com added inline comments to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 14 2022, 2:08 PM