In D41679#949804, @imp wrote:

sys/contrib is good for this, but sys/gnu might be even better since it is GPL'd.

Ah yes I forgot to specify sorry, "Aymeric Wibo" :)

ls: Remove Tn macros from manpage

Fix warnings from mandoc -Tlint

I have not, I didn't know about that, thanks for pointing me to it! I'll fix that in a bit. May I fix all the "STYLE: useless macro: Tn" errors or do I ignore those?

Fix commas in ls.1

ls: Add strcoll(3) & strverscmp(3) to "SEE ALSO" in manpage

scandir: Add man link from versionsort.3

Stupid mistake in usage of __DECONST

Looks fine to me aside from the manpage typos :)

Code style

I still haven't tried compiling anything yet; I don't have access to a FreeBSD machine for the moment.

Does spacing like this work for you @kib? Hopefully I'll get the feeling for where blank spaces are/aren't appropriate in FreeBSD code in future patches 😄

Replace casts with __DECONST & remove some blank lines

In D35807#823736, @pstef wrote:

Do you mean indentation?

Where can I find the rules for vertical spacing? I can't find it explicitly in style(9)

Integrate styling comments from @kib

Integrate styling comments from @kib

I'll make those changes a little later, thank you :)

strverscmp: Respect new rules in style(9)

In D35807#823359, @pstef wrote:

Please go ahead.

• strverscmp: Respect new rules in style(9)

In D35807#823356, @pstef wrote:

I can fix both of those - or do you want to do it yourself and update this review?

In D35807#816089, @pauamma wrote:

My remaining 2 concerns/questions;

• https://reviews.freebsd.org/D35807#inline-220489
• https://reviews.freebsd.org/D35807#inline-220575 (first sentence)

Hey guys, is there anything here that I still need to do?

See D35807.

Simplify digit counting code & style

Remove contraction in manual page

Integrate feedback from pstef@

Integrate feedback from danfe@ about comments not consistently ending with full stops.

Integrate feedback from danfe@ about 000 < 09 example.

Integrate feedback from danfe@ about leading zeros comment.

Thanks for the review.

• strverscmp: Integrate feedback from danfe@ and pauamma@gundo.com

Thank you for the review :)

Replace username by legal name (see D35783)

Thanks for all the feedback!

I don't think yours is slower per se, but without testing I do think the behaviour is slightly different for fractional numbers. There's also the issue of strtol potentially overflowing, but that could easily be remedied.

since this is on FreeBSD, maybe we need to check its behavior is the compatible with -t in pkg-version(8)?