Page MenuHomeFreeBSD

obiwac_gmail.com (Aymeric Wibo)
Fan-bearer on the Right Side of the King

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2022, 11:32 AM (105 w, 2 d)

Recent Activity

Aug 31 2023

obiwac_gmail.com added a comment to D41679: gsoc: BATMAN code pulled from Linux (with no changes).
In D41679#949804, @imp wrote:

sys/contrib is good for this, but sys/gnu might be even better since it is GPL'd.

Aug 31 2023, 8:28 PM · GSoC Students
obiwac_gmail.com requested review of D41679: gsoc: BATMAN code pulled from Linux (with no changes).
Aug 31 2023, 8:12 PM · GSoC Students

Feb 5 2023

obiwac_gmail.com added a comment to D38387: ietp: Load dummy HID report descriptor if mangled.

Ah yes I forgot to specify sorry, "Aymeric Wibo" :)

Feb 5 2023, 2:53 PM
obiwac_gmail.com requested review of D38387: ietp: Load dummy HID report descriptor if mangled.
Feb 5 2023, 12:25 AM

Sep 8 2022

obiwac_gmail.com updated the diff for D36407: ls: `-v` flag.

ls: Remove Tn macros from manpage

Sep 8 2022, 3:31 PM
obiwac_gmail.com updated the summary of D36407: ls: `-v` flag.
Sep 8 2022, 11:48 AM
obiwac_gmail.com updated the diff for D36407: ls: `-v` flag.

Fix warnings from mandoc -Tlint

Sep 8 2022, 11:48 AM

Sep 7 2022

obiwac_gmail.com added a comment to D36407: ls: `-v` flag.

I have not, I didn't know about that, thanks for pointing me to it! I'll fix that in a bit. May I fix all the "STYLE: useless macro: Tn" errors or do I ignore those?

Sep 7 2022, 7:01 PM

Sep 3 2022

obiwac_gmail.com updated obiwac_gmail.com.
Sep 3 2022, 6:25 PM

Sep 1 2022

obiwac_gmail.com updated the diff for D36407: ls: `-v` flag.

Fix commas in ls.1

Sep 1 2022, 11:33 AM

Aug 31 2022

obiwac_gmail.com added inline comments to D36407: ls: `-v` flag.
Aug 31 2022, 11:05 PM
obiwac_gmail.com updated the diff for D36407: ls: `-v` flag.

ls: Add strcoll(3) & strverscmp(3) to "SEE ALSO" in manpage

Aug 31 2022, 7:52 PM
obiwac_gmail.com requested review of D36407: ls: `-v` flag.
Aug 31 2022, 7:48 PM

Aug 24 2022

obiwac_gmail.com accepted D36301: Add scandirat(3).
Aug 24 2022, 2:11 PM

Aug 23 2022

obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

scandir: Add man link from versionsort.3

Aug 23 2022, 9:28 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Stupid mistake in usage of __DECONST

Aug 23 2022, 9:22 PM
obiwac_gmail.com added a comment to D36301: Add scandirat(3).

Looks fine to me aside from the manpage typos :)

Aug 23 2022, 9:08 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Code style

Aug 23 2022, 8:52 PM
obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

I still haven't tried compiling anything yet; I don't have access to a FreeBSD machine for the moment.

Aug 23 2022, 7:00 AM

Aug 21 2022

obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Does spacing like this work for you @kib? Hopefully I'll get the feeling for where blank spaces are/aren't appropriate in FreeBSD code in future patches 😄

Aug 21 2022, 4:54 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Replace casts with __DECONST & remove some blank lines

Aug 21 2022, 4:53 PM
obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Do you mean indentation?

Aug 21 2022, 12:41 PM
obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Where can I find the rules for vertical spacing? I can't find it explicitly in style(9)

Aug 21 2022, 12:07 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Integrate styling comments from @kib

Aug 21 2022, 12:05 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Integrate styling comments from @kib

Aug 21 2022, 12:03 PM
obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

I'll make those changes a little later, thank you :)

Aug 21 2022, 7:10 AM

Aug 19 2022

obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

strverscmp: Respect new rules in style(9)

Aug 19 2022, 8:23 PM
obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Please go ahead.

Aug 19 2022, 8:08 PM
obiwac_gmail.com updated the summary of D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Aug 19 2022, 8:05 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
  • strverscmp: Respect new rules in style(9)
Aug 19 2022, 8:02 PM
obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

I can fix both of those - or do you want to do it yourself and update this review?

Aug 19 2022, 10:54 AM

Jul 27 2022

obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
In D35807#816089, @pauamma wrote:
Jul 27 2022, 11:34 AM

Jul 24 2022

obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Hey guys, is there anything here that I still need to do?

Jul 24 2022, 12:14 PM

Jul 20 2022

obiwac_gmail.com abandoned D35783: ls: `-v` flag (and `strverscmp(3)` & `versionsort(3)`).

See D35807.

Jul 20 2022, 12:46 PM

Jul 16 2022

obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Simplify digit counting code & style

Jul 16 2022, 4:59 PM
obiwac_gmail.com added inline comments to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 16 2022, 1:39 PM

Jul 15 2022

obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Remove contraction in manual page

Jul 15 2022, 8:39 PM
obiwac_gmail.com added inline comments to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 15 2022, 11:20 AM

Jul 14 2022

obiwac_gmail.com added inline comments to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 14 2022, 6:37 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Integrate feedback from pstef@

Jul 14 2022, 6:35 PM
obiwac_gmail.com added inline comments to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 14 2022, 6:29 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Integrate feedback from danfe@ about comments not consistently ending with full stops.

Jul 14 2022, 2:26 PM
obiwac_gmail.com added inline comments to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 14 2022, 2:26 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Integrate feedback from danfe@ about 000 < 09 example.

Jul 14 2022, 2:09 PM
obiwac_gmail.com added inline comments to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 14 2022, 2:08 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Integrate feedback from danfe@ about leading zeros comment.

Jul 14 2022, 1:47 PM
obiwac_gmail.com added inline comments to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 14 2022, 1:43 PM
obiwac_gmail.com added a comment to D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Thanks for the review.

Jul 14 2022, 12:17 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
  • strverscmp: Integrate feedback from danfe@ and pauamma@gundo.com
Jul 14 2022, 12:17 PM

Jul 13 2022

obiwac_gmail.com added a comment to D35783: ls: `-v` flag (and `strverscmp(3)` & `versionsort(3)`).

Thank you for the review :)

Jul 13 2022, 10:31 PM
obiwac_gmail.com updated the diff for D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.

Replace username by legal name (see D35783)

Jul 13 2022, 9:08 PM
obiwac_gmail.com requested review of D35807: libc: Add `strverscmp(3)` & `versionsort(3)`.
Jul 13 2022, 8:51 PM
obiwac_gmail.com added a comment to D35783: ls: `-v` flag (and `strverscmp(3)` & `versionsort(3)`).

Thanks for all the feedback!

Jul 13 2022, 8:21 AM

Jul 12 2022

obiwac_gmail.com added a comment to D35783: ls: `-v` flag (and `strverscmp(3)` & `versionsort(3)`).

I don't think yours is slower per se, but without testing I do think the behaviour is slightly different for fractional numbers. There's also the issue of strtol potentially overflowing, but that could easily be remedied.

Jul 12 2022, 4:47 PM
obiwac_gmail.com added a comment to D35783: ls: `-v` flag (and `strverscmp(3)` & `versionsort(3)`).

since this is on FreeBSD, maybe we need to check its behavior is the compatible with -t in pkg-version(8)?

Jul 12 2022, 3:31 PM
obiwac_gmail.com requested review of D35783: ls: `-v` flag (and `strverscmp(3)` & `versionsort(3)`).
Jul 12 2022, 2:08 PM